[ANNOUNCE] WicketStuff 8.16.0 Released
WicketStuff core 8.16.0 based on Apache Wicket 8.16.0 is released and soon will be available at Maven Central! Maxim Solodovnik (2): Dependencies are updated wicketstuff-core-8.16.0 release build is successful The WicketStuff team
Re: [VOTE] Release Apache Wicket 8.16.0
Hello Mat, the required change is here: https://github.com/apache/wicket/compare/rel/wicket-8.15.0...rel/wicket-8.16.0#diff-0257ba4a00901a14987a1f85de6b356f44f99f85661c9b4dc4a944ec35d48cffR90 On Tue, 18 Jun 2024 at 05:20, Matt Pavlovich wrote: > > Hi @dev- > > I understand that I’m late to the release change check-in, but wanted to > verify all the fixes for the CVE are included in Wicket 8.16.0 > > I saw that this XML-releated change is included in 9.x and 10.x, but not in > Wicket 8.16.0. > > https://github.com/apache/wicket/commit/6db134c6a89f7cd374eede7d5cd467e128c781b9 > > Please confirm that the only change needed to address the XSLT-based RCE CVE > are the fixes here: > > https://github.com/apache/wicket/compare/rel/wicket-8.15.0...rel/wicket-8.16.0 > > Thanks, > Matt > > > On Jun 17, 2024, at 2:00 AM, Andrea Del Bene wrote: > > > > this vote passes. Thank you! > > > > On 6/14/24 10:43, Martin Grigorov wrote: > >> +1 to release > >> > >> On Thu, Jun 13, 2024 at 12:13 AM Andrea Del Bene > >> wrote: > >> > >>> This is a vote to release Apache Wicket 8.16.0 > >>> > >>> Please download the source distributions found in our staging area > >>> linked below. > >>> > >>> I have included the signatures for both the source archives. This vote > >>> lasts for 72 hours minimum. > >>> > >>> [ ] Yes, release Apache Wicket 8.16.0 > >>> [ ] No, don't release Apache Wicket 8.16.0, because ... > >>> > >>> Distributions, changelog, keys and signatures can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/wicket/8.16.0 > >>> > >>> Staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1205 > >>> > >>> The binaries are available in the above link, as are a staging > >>> repository for Maven. Typically the vote is on the source, but should > >>> you find a problem with one of the binaries, please let me know, I can > >>> re-roll them some way or the other. > >>> > >>> Staging git repository data: > >>> > >>> Repository: g...@github.com:bitstorm/wicket.git > >>> Branch: build/wicket-8.16.0 > >>> Release tag: rel/wicket-8.16.0 > >>> > >>> > >>> > >>> > >>> The signatures for the source release artefacts: > >>> > >>> > >>> Signature for apache-wicket-8.16.0.zip: > >>> > >>> -BEGIN PGP SIGNATURE- > >>> > >>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmZqB+QACgkQh48B+qjT > >>> VuGz+xAAqu5r2R39HGtVLFDQ+t26pP/0DNGZv95sJvPbAjZjlnmPvw2zrbM+p69/ > >>> G2JC1BYn9kSae2FVPALS6bcZ+c55Lg8atoA8o7RFOsbvQmRaXCXnU+ISu02xKlvg > >>> +6EL4a2aXka4jF4nDSWIBfU9jm9Nk3CTMwYKTVd0r7LdVEcANB/LCSq74j08/PVM > >>> CCh9vF0/FqLjC6GfD6uu6kL13r24aVk9RmvLXq5uZIOs/nnsfEx5jZtH818kdqre > >>> fvuuT3wbTUJye9DDpuKTESAzMo+aXTKP9M1+pZOmiKnTDiN2aFi02vCo7YrmWpKO > >>> +03LiQt5WZorDUamuBZwetzWajA1lyc+SGWwgnTCTEOkvZ6hMq3zRvo1awb+w0GL > >>> hKGspHRWrlXuwueaIT7/ZDyE26UzIR+oo7l5C0iXPZkAz9ejG6lyoQz4B0sifJlC > >>> ob3j5goApWIXBZMX/FyU1pHivLEbY7Uf8PNcq0g/NYtNuSk+/3yENH1cW+79gWEW > >>> XvaxYfrhTjyIxhnv3cPz3erwSZTHA3r1xURrOYlrlsv8Aqd+Jj+USUhRPP60mc/W > >>> S9bM3o05eFsZVY1rtJVfGl+nYuFEri1T8RgWNeolAdh37S5wdJy+iHn0jUnsPMQK > >>> d27lFJ5neYqYC4F826vwBKDIg8FWUyrX1CDKfXidkJV/IAA03NE= > >>> =Wi7u > >>> -END PGP SIGNATURE- > >>> > >>> Signature for apache-wicket-8.16.0.tar.gz: > >>> > >>> -BEGIN PGP SIGNATURE- > >>> > >>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmZqB+QACgkQh48B+qjT > >>> VuEdjA/+P1szVHdIcom1H1hBTFBSaVaEM8aGf2S4dGplaFiHF3tySsvXzWnbFApU > >>> 7ycylRMheTz6BXRTpo1XGC57WNiqKCE5R9EFZkPqQiQMoFVb6lmEtTQqV+l8Tbxb > >>> L2D1HEN3FhZ/KfPGKm6q46bjMfvfC+hb2mFbcsA8EftnkyKkZ0QfSYfXOCFSaEmF > >>> mEruwXLeQAx2VRTzXgJzhQanjmNiqb1o7x0lCF26m7J6fgXMk+dl7wMg1/Lzl+tV > >>> 8It+eD598zs19hoytO5lKLDVbLPeSVAfxYEChH5BTpR2MTjY2YDBtngo8U5HtHTs > >>> Sd0ICr/oOAWbu86GKCyMNk+uYNdcQCEZtdA4/qQUTq4O0UsFS5UcAUWT4Z0uoq3S > >>> 6c4Aa6S2faPw4ThhaCWSO56PMN3xKBAmERA8gmADv41PHh4N3BDuTANB3bwSrN/3 > >>> b1I39Hxol+OXyuKMnivMeG9OdjoalSlSMhZkA4Tu0dokiZpDVslKltQcnApZdOyd > >>> 6BQuF7j8sQugiZLjtRPzyvIMo3oILNz1bVLOvltYEKI/AB4+C9ShBIX+EO1KlThO > >>> 0P2PjZXgPKNPKS51EsFGZa33tMEDCiuITEDGFeH0XveEnG0BLbBkE/Yx5lJfULdr > >>> hZzNoF2E7tbktMsC0fSIoSQ6rCwrgeF0FTqZrkQuuKzMFJ1fdck= > >>> =4MXn > >>> -END PGP SIGNATURE- > >>> > >>> > >>> > >>> CHANGELOG for 8.16.0: > >>> > >>> ** Bug > >>> > >>> * [WICKET-7056] - HttpSessionStore#getAttribute called on > >>> invalidated session > >>> > >>> > -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 8.16.0
+1 On Thu, 13 Jun 2024 at 04:13, Andrea Del Bene wrote: > > This is a vote to release Apache Wicket 8.16.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 8.16.0 > [ ] No, don't release Apache Wicket 8.16.0, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/8.16.0 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1205 > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-8.16.0 > Release tag: rel/wicket-8.16.0 > > > > > The signatures for the source release artefacts: > > > Signature for apache-wicket-8.16.0.zip: > > -BEGIN PGP SIGNATURE- > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmZqB+QACgkQh48B+qjT > VuGz+xAAqu5r2R39HGtVLFDQ+t26pP/0DNGZv95sJvPbAjZjlnmPvw2zrbM+p69/ > G2JC1BYn9kSae2FVPALS6bcZ+c55Lg8atoA8o7RFOsbvQmRaXCXnU+ISu02xKlvg > +6EL4a2aXka4jF4nDSWIBfU9jm9Nk3CTMwYKTVd0r7LdVEcANB/LCSq74j08/PVM > CCh9vF0/FqLjC6GfD6uu6kL13r24aVk9RmvLXq5uZIOs/nnsfEx5jZtH818kdqre > fvuuT3wbTUJye9DDpuKTESAzMo+aXTKP9M1+pZOmiKnTDiN2aFi02vCo7YrmWpKO > +03LiQt5WZorDUamuBZwetzWajA1lyc+SGWwgnTCTEOkvZ6hMq3zRvo1awb+w0GL > hKGspHRWrlXuwueaIT7/ZDyE26UzIR+oo7l5C0iXPZkAz9ejG6lyoQz4B0sifJlC > ob3j5goApWIXBZMX/FyU1pHivLEbY7Uf8PNcq0g/NYtNuSk+/3yENH1cW+79gWEW > XvaxYfrhTjyIxhnv3cPz3erwSZTHA3r1xURrOYlrlsv8Aqd+Jj+USUhRPP60mc/W > S9bM3o05eFsZVY1rtJVfGl+nYuFEri1T8RgWNeolAdh37S5wdJy+iHn0jUnsPMQK > d27lFJ5neYqYC4F826vwBKDIg8FWUyrX1CDKfXidkJV/IAA03NE= > =Wi7u > -END PGP SIGNATURE- > > Signature for apache-wicket-8.16.0.tar.gz: > > -BEGIN PGP SIGNATURE- > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmZqB+QACgkQh48B+qjT > VuEdjA/+P1szVHdIcom1H1hBTFBSaVaEM8aGf2S4dGplaFiHF3tySsvXzWnbFApU > 7ycylRMheTz6BXRTpo1XGC57WNiqKCE5R9EFZkPqQiQMoFVb6lmEtTQqV+l8Tbxb > L2D1HEN3FhZ/KfPGKm6q46bjMfvfC+hb2mFbcsA8EftnkyKkZ0QfSYfXOCFSaEmF > mEruwXLeQAx2VRTzXgJzhQanjmNiqb1o7x0lCF26m7J6fgXMk+dl7wMg1/Lzl+tV > 8It+eD598zs19hoytO5lKLDVbLPeSVAfxYEChH5BTpR2MTjY2YDBtngo8U5HtHTs > Sd0ICr/oOAWbu86GKCyMNk+uYNdcQCEZtdA4/qQUTq4O0UsFS5UcAUWT4Z0uoq3S > 6c4Aa6S2faPw4ThhaCWSO56PMN3xKBAmERA8gmADv41PHh4N3BDuTANB3bwSrN/3 > b1I39Hxol+OXyuKMnivMeG9OdjoalSlSMhZkA4Tu0dokiZpDVslKltQcnApZdOyd > 6BQuF7j8sQugiZLjtRPzyvIMo3oILNz1bVLOvltYEKI/AB4+C9ShBIX+EO1KlThO > 0P2PjZXgPKNPKS51EsFGZa33tMEDCiuITEDGFeH0XveEnG0BLbBkE/Yx5lJfULdr > hZzNoF2E7tbktMsC0fSIoSQ6rCwrgeF0FTqZrkQuuKzMFJ1fdck= > =4MXn > -END PGP SIGNATURE- > > > > CHANGELOG for 8.16.0: > > ** Bug > > * [WICKET-7056] - HttpSessionStore#getAttribute called on > invalidated session > -- Best regards, Maxim
[ANNOUNCE] WicketStuff 10.1.1 Released
WicketStuff core 10.1.1 based on Apache Wicket 10.1.0 is released and soon will be available at Maven Central! Maxim Solodovnik (5): Switching to the next development version #933 - Error during startup when using a non-default theme (#935) Dependencies are updated Dependencies are updated wicketstuff-core-10.1.1 release build is successful dependabot[bot] (5): Bump org.apache.maven.plugins:maven-checkstyle-plugin (#940) Bump org.easymock:easymock from 5.2.0 to 5.3.0 (#939) Bump org.apache.maven.plugins:maven-jxr-plugin from 3.3.2 to 3.4.0 (#938) Bump wicket-bootstrap-core.version from 7.0.4 to 7.0.5 (#937) Bump org.webjars.npm:moment from 2.29.4 to 2.30.1 (#936) The WicketStuff team
[ANNOUNCE] WicketStuff 10.1.0 Released
WicketStuff core 10.1.0 based on Apache Wicket 10.1.0 is released and soon will be available at Maven Central! Richard Eckart de Castilho (1): wicket-jquery-ui - was migrated to wicketstuff with all commit history (NOTE: maven coordinates were changed) dependabot[bot] (17): Bump spring.version from 6.1.7 to 6.1.8 (#901) Bump redis.clients:jedis from 5.1.2 to 5.1.3 (#908) Bump org.apache.maven.plugins:maven-enforcer-plugin (#907) Bump org.hibernate.orm:hibernate-core from 6.5.1.Final to 6.5.2.Final (#906) Bump org.apache.felix:maven-bundle-plugin from 5.1.2 to 5.1.9 (#905) Bump com.google.protobuf:protobuf-java from 4.26.1 to 4.27.0 (#904) Bump jakarta.validation:jakarta.validation-api from 3.0.2 to 3.1.0 (#902) Bump com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer (#900) Bump org.hsqldb:hsqldb from 2.7.2 to 2.7.3 (#921) Bump org.glassfish.main.extras:glassfish-embedded-all (#920) Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.4.1 to 3.5.0 (#918) Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.3 to 3.7.0 (#916) Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre (#917) Bump shiro.version from 2.0.0 to 2.0.1 (#914) Bump org.apache.maven.plugins:maven-site-plugin (#919) Bump slf4j.version from 2.0.13 to 2.0.13 (#915) Bump wicket.version from 10.1.0-SNAPSHOT to 10.1.0 (#913) Paul Anand (4): Refactoring/912 upgrade datatables library webjars (#923) #928 Upgrade moment.min.js from 2.29.3 to 2.29.4 (#929) #926 Use Webjars for JQueryUI (#927) Refactoring/#931 update JQuery UI dashboard webjars (#932) Maxim Solodovnik (3): Old bundled jQuery files are removed FullCalendar v6 is added (#925) wicketstuff-core-10.1.0 release build is successful sundar (1): #910 Used the jQuery provided by wicket and removed the vulnerable jQuery 1.x scripts (#911) The WicketStuff team
[ANNOUNCE] WicketStuff 9.18.0 Released
WicketStuff core 9.18.0 based on Apache Wicket 9.18.0 is released and soon will be available at Maven Central! Richard Eckart de Castilho (1): wicket-jquery-ui - was migrated to wicketstuff with all commit history Andreas Svanberg (1): Removed unused bcprov-jdk18on dependency Maxim Solodovnik (8): Fixes issue #99: RestartResponseException is used instead of setResponsePage Merge pull request #861 from reckart/refactoring/850-Merging-wicket-jquery-ui-into-wicketstuff-core-9.x Indentation is fixed Dependencies are updated Maven WARNING is removed Old bundled jQuery files are removed Dependencies are updated wicketstuff-core-9.18.0 release build is successful sundar (1): #910 Used the jQuery provided by wicket and removed the vulnerable jQuery 1.x scripts (#911) The WicketStuff team
Re: new wicket releases?
Previous release was ~6 weeks ago so +1 for release :) On Tue, 7 May 2024 at 23:08, Ernesto Reinaldo Barreiro wrote: > > Hi, > > Maybe it is time for the next releases of wicket 10 and 9? WDYT? > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.17.0 Released
WicketStuff core 9.17.0 based on Apache Wicket 9.17.0 is released and soon will be available at Maven Central! Maxim Solodovnik (8): Switching to the next development version Dependencies are updated Fixes issue #764: presense of 'getAttribute' function is being tested Dependencies are updated Dependencies are updated Dashboard: outdated widgets are dropped; examples are fixed Dependencies are updated; some javadoc errors are fixed wicketstuff-core-9.17.0 release build is successful The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.17.0
+1 tested: - signatures - build from sources - wicketstuff build - some exmaples BTW I guess the repository URL in the ANN email is wrong, Repository: g...@github.com:bitstorm/wicket.git -> g...@github.com:apache/wicket.git ? On Mon, 18 Mar 2024 at 00:14, Andrea Del Bene wrote: > > +1 to release. tested user guide examples > > On 3/13/24 22:36, Andrea Del Bene wrote: > > This is a vote to release Apache Wicket 9.17.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 9.17.0 > > [ ] No, don't release Apache Wicket 9.17.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/9.17.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1201 > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-9.17.0 > > Release tag: rel/wicket-9.17.0 > > > > > > > > > > CHANGELOG for 9.17.0: > > > > ** Bug > > > > * [WICKET-7086] - Injecting Spring bean may cause ClassCastException > > * [WICKET-7091] - FilePageStore throws NPE > > * [WICKET-7096] - stylesheets referenced via automatic linking > > miss nonce attribute > > * [WICKET-7097] - ServletWebResponse allows writing headers to > > committed HttpServletResponse > > > > ** Improvement > > > > * [WICKET-7093] - Add support for missing CSP directives > > * [WICKET-7094] - Make all CSP schemes configurable > > * [WICKET-7099] - Validate FormTester constructor parameter > > workingForm > > -- Best regards, Maxim
[ANNOUNCE] WicketStuff 10.0.0 Released
WicketStuff core 10.0.0 based on Apache Wicket 10.0.0 is released and soon will be available at Maven Central! dependabot[bot] (50): Bump org.springframework:spring-core from 6.0.10 to 6.0.15 (#760) Bump org.springframework:spring-core from 6.0.15 to 6.0.16 (#761) Bump com.hazelcast:hazelcast in /datastores-parent/datastore-hazelcast (#763) Bump org.springframework:spring-web from 6.0.16 to 6.0.17 (#765) Bump actions/checkout from 2 to 4 (#766) Bump actions/setup-java from 2 to 4 (#768) Bump actions/cache from 2 to 4 (#770) Bump ch.qos.logback:logback-classic from 1.4.8 to 1.5.0 (#815) Bump commons-logging:commons-logging from 1.2 to 1.3.0 (#814) Bump org.apache.maven.plugins:maven-surefire-report-plugin (#813) Bump org.apache.maven.plugins:maven-project-info-reports-plugin (#812) Bump org.javassist:javassist from 3.29.2-GA to 3.30.2-GA (#811) Bump org.apache.maven.archetype:archetype-packaging from 3.1.0 to 3.2.1 (#805) Bump org.apache.felix:org.apache.felix.webconsole from 3.1.8 to 5.0.0 (#802) Bump com.datastax.cassandra:cassandra-driver-core from 3.6.0 to 3.11.5 (#801) Bump org.apache.maven.plugins:maven-clean-plugin from 3.2.0 to 3.3.2 (#799) Bump com.hazelcast:hazelcast from 5.3.5 to 5.3.6 (#798) Bump org.webjars.bower:datatables from 1.10.19 to 1.10.21 (#796) Bump org.ow2.asm:asm-util from 9.5 to 9.6 (#795) Bump scala.version from 2.13.11 to 2.13.13 (#794) Bump com.google.protobuf:protobuf-java from 3.19.6 to 3.25.3 (#787) Bump redis.clients:jedis from 4.3.1 to 5.1.1 (#786) Bump org.apache.maven.plugins:maven-jxr-plugin from 2.5 to 3.3.2 (#783) Bump org.apache.servicemix.bundles:org.apache.servicemix.bundles.cglib (#782) Bump org.apache.ignite:ignite-core from 2.14.0 to 2.16.0 (#781) Bump org.apache.maven.plugins:maven-checkstyle-plugin from 2.15 to 3.3.1 (#776) Bump spring.version from 6.0.17 to 6.1.4 (#773) Bump net.javacrumbs.json-unit:json-unit from 2.17.0 to 3.2.7 (#769) Bump org.apache.shiro:shiro-core from 1.11.0 to 1.13.0 (#759) Bump org.glassfish.main.extras:glassfish-embedded-all from 4.0 to 7.0.12 (#778) Bump org.apache.shiro:shiro-web from 1.11.0 to 1.13.0 (#758) Bump log4j.version from 2.20.0 to 2.23.0 (#797) Bump org.codehaus.mojo:findbugs-maven-plugin from 3.0.1 to 3.0.5 (#829) Bump ch.qos.logback:logback-classic from 1.5.0 to 1.5.2 (#828) Bump org.webjars.npm:tinymce from 6.8.2 to 6.8.3 (#827) Bump org.codehaus.mojo:taglist-maven-plugin from 2.4 to 3.0.0 (#826) Bump org.apache.maven.plugins:maven-archetype-plugin from 3.1.0 to 3.2.1 (#825) Bump org.apache.maven.plugins:maven-site-plugin (#824) Bump jakarta.servlet.jsp:jakarta.servlet.jsp-api from 3.1.0 to 3.1.1 (#823) Bump org.glassfish.main.extras:glassfish-embedded-all (#820) Bump com.sun.xml.bind:jaxb-core from 2.3.0.1 to 4.0.4 (#819) Bump org.mockito:mockito-core from 5.10.0 to 5.11.0 (#818) Bump org.apache.maven.plugins:maven-toolchains-plugin from 1.1 to 3.1.0 (#817) Bump shiro.version from 1.13.0 to 2.0.0 (#816) Bump slf4j.version from 2.0.7 to 2.0.12 (#779) Bump org.clojure:clojure from 1.11.1 to 1.11.2 (#830) Bump ch.qos.logback:logback-classic from 1.5.2 to 1.5.3 (#836) Bump com.sun.xml.bind:jaxb-core from 4.0.4 to 4.0.5 (#835) Bump com.fasterxml.jackson.core:jackson-databind from 2.14.3 to 2.16.2 (#833) Bump redis.clients:jedis from 5.1.1 to 5.1.2 (#832) Maxim Solodovnik (15): Switching to the next development version schemaLocation for web.xml files is updated Jetty DTD URL is updated Dependencies are updated Merge is fixed Duplicate property removed TinyMCE 3 and 4 are dropped Modules for TinyMCE 3 and 4 are dropped Dependencies are updated Fixes issue #764: presense of 'getAttribute' function is being tested Dependencies are updated Dependencies are updated Fast serializer is updated GPG plugin is updated wicketstuff-core-10.0.0 is released Johannes Renoth (1): Add TinyMCE 6 module (#762) Martin Tzvetanov Grigorov (1): Add dependabot config for updating the Java deps and Github Actions Silas Porth (1): Update/partial rewrite of editable-grid (#756) The WicketStuff team
Re: Wicket 10(-M?) checkpoint
Hello All, Do we still need `javax.servlet` and `javax.servlet.http` packages in `wicket-util` ? On Mon, 18 Dec 2023 at 07:33, Vit Rozkovec wrote: > > One more catch: https://github.com/apache/wicket/pull/749 > > > On 15. 12. 23 13:24, Martin Grigorov wrote: > > It seems we are good to go! > > > > On Mon, Dec 11, 2023 at 3:10 PM Thomas Heigl wrote: > > > >> Hi all, > >> > >> I upgraded our main application to Wicket 10.0.0-M2, Spring 6.1, and Spring > >> Boot 3.2 last week. > >> > >> All my (thousands) of tests are green and I did some exploratory testing. > >> > >> LGTM! > >> > >> Thomas > >> > >> > >> On Wed, Dec 6, 2023 at 2:08 PM Vit Rozkovec wrote: > >> > >>> > >>> On 06. 12. 23 13:08, Martin Grigorov wrote: > The reason is SameSite support - > > >> https://github.com/apache/wicket/commit/f0b4b1b3b63f33e12c8b2b04e22fcf73b773ec34 > It is easy for us to fix the version in the wiki! > How easy is it for you to use a container that supports Servlet API 6 ? > > >>> Unfortunately some libraries do not support Jetty 12 yet, so I'm stuck > >>> with Jetty 11 that supports only Servlet API 5: > >> https://eclipse.dev/jetty/ > >>> The solution you've done in > >>> > >>> > >> https://github.com/apache/wicket/commit/a68536eb095bb5cf59e4063b6af9436523ddc623 > >>> works for me, tried with locally built M3-SNAPSHOT. > >>> > > > -- Best regards, Maxim
Re: Incorrect modification time in jars
File timestamps might be set to `project.build.outputTimestamp` by Maven This enables "reproducible builds" https://maven.apache.org/guides/mini/guide-reproducible-builds.html I believe Maven `project.build.outputTimestamp` property should be set in the pom.xml by release manager during release should be easy to check :) (sorry, I don't have time to check it myself : ) On Thu, 7 Dec 2023 at 04:50, Emond Papegaaij wrote: > > > > > > > > > https://github.com/apache/wicket/blob/a68536eb095bb5cf59e4063b6af9436523ddc623/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java#L650-L664 > > LastModifiedResourceVersion is used in DEV mode by default. > > MessageDigestResourceVersion is for PROD. > > > > Yes, I know. I don't know why we ever configured our applications to always > use LastModifiedResourceVersion, but this was working fine for us, until > wicket 9.8.0. Something changed that caused the timestamps to be reset at > that time. I think we should try to find out what caused this, and fix it. > As you said LastModifiedResourceVersion is used by default in dev mode, and > it is currently broken. I'll create a Jira issue for this tomorrow, I > didn't have the time for it today. > > For us, I've already recommended everyone to remove our custom > configuration of this setting. The default makes much more sense, and only > developers will be faced with a possible invalid cache entry. > > Best regards, > Emond > > > -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.16.0 Released
WicketStuff core 9.16.0 based on Apache Wicket 9.16.0 is released and soon will be available at Maven Central! Maxim Solodovnik (5): Switching to the next development version BCprov is updated; Tests are fixed Jetty is updated Dependencies are updated wicketstuff-core-9.16.0 release build is successful The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.16.0 (take 2)
+1 usual tests :) On Sun, 26 Nov 2023 at 21:35, Andrea Del Bene wrote: > > +1 to release. Tested with tutorial examples. > > On 11/25/23 11:15, Tobias Soloschenko wrote: > > +1 - thanks for updating the dependencies - good hint Maxim :) > > > >> Am 24.11.2023 um 20:51 schrieb Ernesto Reinaldo Barreiro > >> : > >> > >> +1 our application seems to work as expected with wicket 9.16.0. Thanks for > >> taking care of our releases! > >> > >> On Thu, Nov 23, 2023 at 9:55 AM Andrea Del Bene > >> wrote: > >> > >>> This is a vote to release Apache Wicket 9.16.0 > >>> > >>> Please download the source distributions found in our staging area > >>> linked below. > >>> > >>> I have included the signatures for both the source archives. This vote > >>> lasts for 72 hours minimum. > >>> > >>> [ ] Yes, release Apache Wicket 9.16.0 > >>> [ ] No, don't release Apache Wicket 9.16.0, because ... > >>> > >>> Distributions, changelog, keys and signatures can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/wicket/9.16.0 > >>> > >>> Staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1198 > >>> > >>> The binaries are available in the above link, as are a staging > >>> repository for Maven. Typically the vote is on the source, but should > >>> you find a problem with one of the binaries, please let me know, I can > >>> re-roll them some way or the other. > >>> > >>> Staging git repository data: > >>> > >>> Repository: g...@github.com:bitstorm/wicket.git > >>> Branch: build/wicket-9.16.0 > >>> Release tag: rel/wicket-9.16.0 > >>> > >>> > >>> > >>> > >>> CHANGELOG for 9.16.0: > >>> > >>> ** Bug > >>> > >>> * [WICKET-7056] - HttpSessionStore#getAttribute called on > >>> invalidated session > >>> * [WICKET-7074] - [AJAX] malformed XML is produced if an error is > >>> produced during AJAX rendering and a redirect is issued > >>> * [WICKET-7076] - JavaScriptReferenceType newly created is not > >>> serializable > >>> * [WICKET-7081] - Open packages to expose resources to other modules > >>> > >>> ** Improvement > >>> > >>> * [WICKET-7078] - CSP: inline JS in Choices and Selection of Palette > >>> * [WICKET-7080] - [Events] make default events delivery machinery > >>> pluggable and roll usable annotation based one > >>> * [WICKET-7082] - Easier to work with polymorphic values inside > >>> IModel > >>> * [WICKET-7083] - Trigger client side validation when using > >>> SubmitLinks > >>> > >>> ** Task > >>> > >>> * [WICKET-7073] - Update JQuery to 3.7.1 > >>> > >>> > >> -- > >> Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.16.0
sure, I'll try to update them tomorrow :) On Wed, 22 Nov 2023 at 03:34, Andrea Del Bene wrote: > > If you like to update dependencies I can't start a new vote. No problem. > > On 11/21/23 08:39, Maxim Solodovnik wrote: > > I would update dependencies before release :))) > > > > +1 > > > > Tested: > > - signatures > > - build from sources > > - wicketstuff build > > - some examples > > > > On Mon, 20 Nov 2023 at 19:29, Ernesto Reinaldo Barreiro > > wrote: > >> +1. I have tested our application against wicket 9.16.0 > >> > >> On Sun, Nov 19, 2023 at 6:00 PM Andrea Del Bene > >> wrote: > >> > >>> This is a vote to release Apache Wicket 9.16.0 > >>> > >>> Please download the source distributions found in our staging area > >>> linked below. > >>> > >>> I have included the signatures for both the source archives. This vote > >>> lasts for 72 hours minimum. > >>> > >>> [ ] Yes, release Apache Wicket 9.16.0 > >>> [ ] No, don't release Apache Wicket 9.16.0, because ... > >>> > >>> Distributions, changelog, keys and signatures can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/wicket/9.16.0 > >>> > >>> Staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1195 > >>> > >>> The binaries are available in the above link, as are a staging > >>> repository for Maven. Typically the vote is on the source, but should > >>> you find a problem with one of the binaries, please let me know, I can > >>> re-roll them some way or the other. > >>> > >>> Staging git repository data: > >>> > >>> Repository: g...@github.com:bitstorm/wicket.git > >>> Branch: build/wicket-9.16.0 > >>> Release tag: rel/wicket-9.16.0 > >>> > >>> > >>> > >>> > >>> CHANGELOG for 9.16.0: > >>> > >>> ** Bug > >>> > >>> * [WICKET-7056] - HttpSessionStore#getAttribute called on > >>> invalidated session > >>> * [WICKET-7074] - [AJAX] malformed XML is produced if an error is > >>> produced during AJAX rendering and a redirect is issued > >>> * [WICKET-7076] - JavaScriptReferenceType newly created is not > >>> serializable > >>> * [WICKET-7081] - Open packages to expose resources to other modules > >>> > >>> ** Improvement > >>> > >>> * [WICKET-7078] - CSP: inline JS in Choices and Selection of Palette > >>> * [WICKET-7080] - [Events] make default events delivery machinery > >>> pluggable and roll usable annotation based one > >>> * [WICKET-7082] - Easier to work with polymorphic values inside > >>> IModel > >>> * [WICKET-7083] - Trigger client side validation when using > >>> SubmitLinks > >>> > >>> ** Task > >>> > >>> * [WICKET-7073] - Update JQuery to 3.7.1 > >>> > >>> > >> -- > >> Regards - Ernesto Reinaldo Barreiro > > > > -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.16.0
I would update dependencies before release :))) +1 Tested: - signatures - build from sources - wicketstuff build - some examples On Mon, 20 Nov 2023 at 19:29, Ernesto Reinaldo Barreiro wrote: > > +1. I have tested our application against wicket 9.16.0 > > On Sun, Nov 19, 2023 at 6:00 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 9.16.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 9.16.0 > > [ ] No, don't release Apache Wicket 9.16.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/9.16.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1195 > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-9.16.0 > > Release tag: rel/wicket-9.16.0 > > > > > > > > > > CHANGELOG for 9.16.0: > > > > ** Bug > > > > * [WICKET-7056] - HttpSessionStore#getAttribute called on > > invalidated session > > * [WICKET-7074] - [AJAX] malformed XML is produced if an error is > > produced during AJAX rendering and a redirect is issued > > * [WICKET-7076] - JavaScriptReferenceType newly created is not > > serializable > > * [WICKET-7081] - Open packages to expose resources to other modules > > > > ** Improvement > > > > * [WICKET-7078] - CSP: inline JS in Choices and Selection of Palette > > * [WICKET-7080] - [Events] make default events delivery machinery > > pluggable and roll usable annotation based one > > * [WICKET-7082] - Easier to work with polymorphic values inside IModel > > * [WICKET-7083] - Trigger client side validation when using > > SubmitLinks > > > > ** Task > > > > * [WICKET-7073] - Update JQuery to 3.7.1 > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: is 9.x branch build broken?
The build is green for me :)
mvn --version
Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f)
Maven home: /opt/maven
Java version: 11.0.20.1, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-88-generic", arch: "amd64", family: "unix"
On Thu, 2 Nov 2023 at 00:52, Ernesto Reinaldo Barreiro
wrote:
>
> sealed interface TextMatchingStatus
> {
> record NotSubmitted() implements TextMatchingStatus {}
> record Queued() implements TextMatchingStatus {}
> record Analysed(int matchingInPercent) implements TextMatchingStatus {}
> record Error(int errorCode, String humanReadableMessage) implements
> TextMatchingStatus
> {}
> }
>
> ?
> --
> Regards - Ernesto Reinaldo Barreiro
--
Best regards,
Maxim
[ANNOUNCE] WicketStuff 10.0.0-M2 Released
WicketStuff core 10.0.0-M2 based on Apache Wicket 10.0.0-M2 is released and soon will be available at Maven Central! Maxim Solodovnik (10): portlet-parent is dropped Switching to the next development version Fixes #753: wicketstuff-openlayers3-bootstrap modified to work under bootstrap 4/5 HTTPS SniHostCheck is turned off for all Start applications Build is fixed due to M2 restructure Some modules were converted to JPMS Javadoc links are updated Naming clean-up wicket-webjars and jquery-selectors are updated wicketstuff-core-10.0.0-M2 is released The WicketStuff team
Re: [VOTE] Release Apache Wicket 10.0.0-M2 - take 2
@Andrea I'm afraid the link to binaries should be https://dist.apache.org/repos/dist/dev/wicket/10.0.0-M2/ the above folder still contains `CHANGELOG-9.x` (I believe this should be dropped) +1 from me :) Tested: - signatures - build from sources - wicket examples - wicketstuff build + run - Apache OpenMeetings On Fri, 13 Oct 2023 at 14:30, Andrea Del Bene wrote: > > I guess I can fix the changelog manually, so it's not a big issue. > > On Fri, Oct 13, 2023 at 8:55 AM Jeroen Steenbeeke > wrote: > > > For the changelog: I took a quick look at the sources JAR and it looks like > > https://issues.apache.org/jira/browse/WICKET-7075 is also included. > > > > Which makes it a +1 from me (nonbinding of course) > > > > Op vr 13 okt 2023 om 00:36 schreef Andrea Del Bene : > > > > > This is a vote to release Apache Wicket 10.0.0-M2 > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 10.0.0-M2 > > > [ ] No, don't release Apache Wicket 10.0.0-M2, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1193/ > > > > > > Staging repository: > > > > > > https://repository.apache.org/content/repositories// > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-10.0.0-M2 > > > Release tag: rel/wicket-10.0.0-M2 > > > > > > > > > > > > > > > CHANGELOG for 10.0.0-M2: > > > > > > > > > ** Bug > > > > > > * [WICKET-7056] - HttpSessionStore#getAttribute called on > > > invalidated session > > > * [WICKET-7061] - When I move from 9.13.0->9.14.0, my importmaps > > > fail to parse correctly due to presence of the CDATA wrapping. > > > * [WICKET-7065] - TextFilteredPropertyColumn violates CSP > > > * [WICKET-7067] - DefaultExceptionMapper should not set > > > disableCaching for WebSocketResponse > > > * [WICKET-7070] - Quick start generated app has multiple errors > > > * [WICKET-7071] - Problems when calling request.getInputStream() > > > before executing WicketFilter > > > * [WICKET-7072] - JUnit code in /src/main/java breaks JPMS support > > > in Eclipse IDE > > > * [WICKET-7074] - [AJAX] malformed XML is produced if an error is > > > produced during AJAX rendering and a redirect is issued > > > * [WICKET-7076] - JavaScriptReferenceType newly created is not > > > serializable > > > * [WICKET-7077] - 2 spring web application contexts are created > > > > > > ** Improvement > > > > > > * [WICKET-7039] - Improve Accessibility of wicket-autocomplete.js > > > * [WICKET-7060] - Minor improvements to wicket-examples > > > * [WICKET-7063] - Convert all Application_*.properties to > > > Application_*.utf8.properties > > > * [WICKET-7066] - Add possibility to define type-Attribute of > > > JavascriptHeaderItem as "module" > > > * [WICKET-7068] - Current tree themes are not RTL friendly > > > * [WICKET-7078] - CSP: inline JS in Choices and Selection of Palette > > > > > > ** Task > > > > > > * [WICKET-7064] - commons-fileupload2 dependency should be added > > back > > > * [WICKET-7069] - assertTrue(equals()) in tests should be replaced > > > with assertEquals > > > * [WICKET-7073] - Update JQuery to 3.7.1 > > > > > > > > > > -- > > Jeroen Steenbeeke > > > > > -- > Andrea Del Bene. > Apache Wicket committer. -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 10.0.0-M2
+1 to cancel release due to both WICKET-7072 and WICKET-7077 On Sat, 23 Sept 2023 at 18:23, Andrea Del Bene wrote: > > +1 BUT...I see there is issue WICKET-7072 that might be worthwhile to wait > for its completition, and it looks well under way. So maybe we should > cancel this vote e start a new one when WICKET-7072 is merged. > > On Fri, Sep 22, 2023 at 4:29 AM Maxim Solodovnik > wrote: > > > +1 > > > > Tested: > > - signatures > > - build from sources > > - run Wicket examples > > > > For whatever reason > > https://dist.apache.org/repos/dist/dev/wicket/10.0.0-M2/ contains > > outdated CHANGELOG-9.x ... > > I believe it should be removed > > > > On Sat, 16 Sept 2023 at 22:30, Andrea Del Bene > > wrote: > > > > > > This is a vote to release Apache Wicket 10.0.0-M2 > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 10.0.0-M2 > > > [ ] No, don't release Apache Wicket 10.0.0-M2, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/wicket/10.0.0-M2 > > > > > > Staging repository: > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1191/ > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-10.0.0-M2 > > > Release tag: rel/wicket-10.0.0-M2 > > > > > > > > > > > > > > > CHANGELOG for 10.0.0-M2: > > > > > > ** Bug > > > > > > * [WICKET-7040] - find a different way to add CSP headers > > > * [WICKET-7061] - When I move from 9.13.0->9.14.0, my importmaps > > > fail to parse correctly due to presence of the CDATA wrapping. > > > * [WICKET-7065] - TextFilteredPropertyColumn violates CSP > > > * [WICKET-7067] - DefaultExceptionMapper should not set > > > disableCaching for WebSocketResponse > > > * [WICKET-7070] - Quick start generated app has multiple errors > > > * [WICKET-7071] - Problems when calling request.getInputStream() > > > before executing WicketFilter > > > > > > ** Improvement > > > > > > * [WICKET-7039] - Improve Accessibility of wicket-autocomplete.js > > > * [WICKET-7060] - Minor improvements to wicket-examples > > > * [WICKET-7063] - Convert all Application_*.properties to > > > Application_*.utf8.properties > > > * [WICKET-7066] - Add possibility to define type-Attribute of > > > JavascriptHeaderItem as "module" > > > * [WICKET-7068] - Current tree themes are not RTL friendly > > > > > > ** Task > > > > > > * [WICKET-7064] - commons-fileupload2 dependency should be added > > back > > > * [WICKET-7069] - assertTrue(equals()) in tests should be replaced > > > with assertEquals > > > * [WICKET-7073] - Update JQuery to 3.7.1 > > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Andrea Del Bene. > Apache Wicket committer. -- Best regards, Maxim
Re: [DISCUSSION] LocalDate*Time*TextField modification
On Wed, 13 Sept 2023 at 05:13, Sven Meier wrote:
>
> Hi Maxim,
>
> it will be hard to make that suitable for different projects with
> different requirements:
> In Arabic sometimes dates are written in Latin digits, so we can't call
> #withDecimalStyle in general.
>
> We could add other constructors with IConverter argument, but then
> Local*TextField wouldn't add anything that you can't do with your own
> TextField subclass.
>
> Maybe add this?
>
> protected DateTimeFormatter configure(DateTimeFormatter formatter) {
> return formatter; }
Just have checked LocalDateTextField and LocalDateTimeTextField both
has method createConverter
Which actually doesn't create converter ...
Maybe I it worth to refactor both to
- remove final from converter
- create and set converter in `createConverter` method
This way users can tune converter on creation? :)
>
> Once again, rolling your own component might be simpler.
>
> Regards
> Sven
>
>
> On 12.09.23 03:54, Maxim Solodovnik wrote:
> > Hello All,
> >
> > Sorry for the long email
> >
> > While working on PR for wicket-bootstrap [1] i have test multiple
> > locales and find out LocalDate*Time*TextField doesn't behave well with
> > locales like Persian/Arabic (those with custom digits)
> >
> > All classes `Local*TextField` from datetime package [2]
> >
> > have `TextFormatConverter converter` as private member
> > With constructors accepting `String pattern` and `FormatStyle`
> >
> > With locales uses different numeral systems (like Arabic) this doesn't
> > work well :(
> >
> > Here are some examples
> > All below can be checked with `jshell` (and/or `bootstrap-samples` from [1])
> >
> > `LocalDate.of(2020, 11,
> > 5).format(DateTimeFormatter.ofPattern("/M/d").withLocale(Locale.forLanguageTag("fa")).withDecimalStyle(DecimalStyle.of(Locale.forLanguageTag("fa"`
> > > "۲۰۲۰/۱۱/۵"
> >
> > Let's parse this one using DateTimeFormatter like it is being created
> > in current Wicket code:
> >
> > `DateTimeFormatter.ofPattern("/M/d").withLocale(Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
> > > Exception java.time.format.DateTimeParseException
> >
> > Missing `withDecimalStyle` might help but unfortunately
> > tempus-dominus-v6 [3] produces dates like "2003/۱۱/5" (please note
> > digits in mixed numeral systems are present)
> >
> > Surprisingly the above works well with SimpleDateFormat:
> >
> > `LocalDate.ofInstant(new SimpleDateFormat("/M/d",
> > Locale.forLanguageTag("fa")).parse("2003/۱۱/5").toInstant(),
> > ZoneId.systemDefault())`
> >
> > please NOTE SimpleDateFormat doesn't honor RTL
> > It will produce wrong date for
> >
> > `new SimpleDateFormat("d/M/",
> > Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
> >
> > BUT correct date with
> >
> > `new SimpleDateFormat("/M/d",
> > Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
> >
> > So I believe wicket code need to be improved:
> >
> > - `withDecimalStyle` *might* be added
> > - internal date/time formatter should be accessible for the user (so
> > it can be twicked)
> >
> > WDYT?
> >
> > [1]https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/1002
> > [2]https://github.com/apache/wicket/tree/master/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime
> > [3]https://getdatepicker.com/6/
> >
--
Best regards,
Maxim
Re: [VOTE] Release Apache Wicket 10.0.0-M2
+1 Tested: - signatures - build from sources - run Wicket examples For whatever reason https://dist.apache.org/repos/dist/dev/wicket/10.0.0-M2/ contains outdated CHANGELOG-9.x ... I believe it should be removed On Sat, 16 Sept 2023 at 22:30, Andrea Del Bene wrote: > > This is a vote to release Apache Wicket 10.0.0-M2 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 10.0.0-M2 > [ ] No, don't release Apache Wicket 10.0.0-M2, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/10.0.0-M2 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1191/ > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-10.0.0-M2 > Release tag: rel/wicket-10.0.0-M2 > > > > > CHANGELOG for 10.0.0-M2: > > ** Bug > > * [WICKET-7040] - find a different way to add CSP headers > * [WICKET-7061] - When I move from 9.13.0->9.14.0, my importmaps > fail to parse correctly due to presence of the CDATA wrapping. > * [WICKET-7065] - TextFilteredPropertyColumn violates CSP > * [WICKET-7067] - DefaultExceptionMapper should not set > disableCaching for WebSocketResponse > * [WICKET-7070] - Quick start generated app has multiple errors > * [WICKET-7071] - Problems when calling request.getInputStream() > before executing WicketFilter > > ** Improvement > > * [WICKET-7039] - Improve Accessibility of wicket-autocomplete.js > * [WICKET-7060] - Minor improvements to wicket-examples > * [WICKET-7063] - Convert all Application_*.properties to > Application_*.utf8.properties > * [WICKET-7066] - Add possibility to define type-Attribute of > JavascriptHeaderItem as "module" > * [WICKET-7068] - Current tree themes are not RTL friendly > > ** Task > > * [WICKET-7064] - commons-fileupload2 dependency should be added back > * [WICKET-7069] - assertTrue(equals()) in tests should be replaced > with assertEquals > * [WICKET-7073] - Update JQuery to 3.7.1 > -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.15.0 Released
WicketStuff core 9.15.0 based on Apache Wicket 9.15.0 is released and soon will be available at Maven Central! Maxim Solodovnik (6): Switching to the next development version wicketstuff-openlayers3 fixed to work with bootstrap 3, 4, 5 Jackson is downgraded Jetty is updated Dependencies are updated wicketstuff-core-9.15.0 is released The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.15.0
Just have tested: - signatures - build from sources - wicketstuff build All OK BUT run of `select2-examples` with JDK-17 on the PATH failed with: ``` java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.String java.lang.Enum.name accessible: module java.base does not "opens java.lang" to unnamed module @2069b0f8 at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) at java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at org.apache.wicket.core.util.lang.PropertyResolver$DefaultPropertyLocator.findField(PropertyResolver.java:1522) at org.apache.wicket.core.util.lang.PropertyResolver$DefaultPropertyLocator.get(PropertyResolver.java:1449) at org.apache.wicket.core.util.lang.PropertyResolver$CachingPropertyLocator.get(PropertyResolver.java:1344) at org.apache.wicket.core.util.lang.PropertyResolver.getGetAndSet(PropertyResolver.java:390) at org.apache.wicket.core.util.lang.PropertyResolver.getObjectWithGetAndSet(PropertyResolver.java:354) at org.apache.wicket.core.util.lang.PropertyResolver.getObjectWithGetAndSet(PropertyResolver.java:260) at org.apache.wicket.core.util.lang.PropertyResolver.getValue(PropertyResolver.java:110) at org.apache.wicket.markup.html.form.ChoiceRenderer.getIdValue(ChoiceRenderer.java:149) ``` Everything is OK with Java-11 on the PATH So I'm +1 for the release, but would appreciate any hint on how wicketstuff run under Java-17 can be fixed On Sat, 16 Sept 2023 at 11:31, Maxim Solodovnik wrote: > > On Thu, 14 Sept 2023 at 14:58, Andrea Del Bene wrote: > > > > FYI I had to downgrade Maven Source Plugin to 3.2.1 as 3.3.0 kept giving > > me this message > > https://stackoverflow.com/questions/76433857/failed-to-execute-goal-org-apache-maven-pluginsmaven-source-plugin3-3-0jar-no > > Actually the goal should be changed: > > > jar-no-fork > > > And everything will work :) > > > Probably it's this bug > > https://issues.apache.org/jira/projects/MSOURCES/issues/MSOURCES-141 > > > > On Thu, Sep 14, 2023 at 2:41 AM Ernesto Reinaldo Barreiro < > > reier...@gmail.com> wrote: > > > > > +1 for release: manually tested our application + the 600+ integration > > > selenium tests passed > > > > > > On Wed, Sep 13, 2023 at 2:28 PM Andrea Del Bene > > > wrote: > > > > > > > This is a vote to release Apache Wicket 9.15.0 > > > > > > > > Please download the source distributions found in our staging area > > > > linked below. > > > > > > > > I have included the signatures for both the source archives. This vote > > > > lasts for 72 hours minimum. > > > > > > > > [ ] Yes, release Apache Wicket 9.15.0 > > > > [ ] No, don't release Apache Wicket 9.15.0, because ... > > > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.15.0 > > > > > > > > Staging repository: > > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1189 > > > > > > > > The binaries are available in the above link, as are a staging > > > > repository for Maven. Typically the vote is on the source, but should > > > > you find a problem with one of the binaries, please let me know, I can > > > > re-roll them some way or the other. > > > > > > > > Staging git repository data: > > > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > > Branch: build/wicket-9.15.0 > > > > Release tag: rel/wicket-9.15.0 > > > > > > > > > > > > > > > > > > > > CHANGELOG for 9.15.0: > > > > > > > > ** Bug > > > > > > > > * [WICKET-7061] - When I move from 9.13.0->9.14.0, my importmaps > > > > fail to parse correctly due to presence of the CDATA wrapping. > > > > * [WICKET-7065] - TextFilteredPropertyColumn violates CSP > > > > * [WICKET-7067] - DefaultExceptionMapper should not set > > > > disableCaching for WebSocketResponse > > > > * [WICKET-7070] - Quick start generated app has multiple errors > > > > * [WICKET-7071] - Pr
Re: [VOTE] Release Apache Wicket 9.15.0
On Thu, 14 Sept 2023 at 14:58, Andrea Del Bene wrote: > > FYI I had to downgrade Maven Source Plugin to 3.2.1 as 3.3.0 kept giving > me this message > https://stackoverflow.com/questions/76433857/failed-to-execute-goal-org-apache-maven-pluginsmaven-source-plugin3-3-0jar-no Actually the goal should be changed: jar-no-fork And everything will work :) > Probably it's this bug > https://issues.apache.org/jira/projects/MSOURCES/issues/MSOURCES-141 > > On Thu, Sep 14, 2023 at 2:41 AM Ernesto Reinaldo Barreiro < > reier...@gmail.com> wrote: > > > +1 for release: manually tested our application + the 600+ integration > > selenium tests passed > > > > On Wed, Sep 13, 2023 at 2:28 PM Andrea Del Bene > > wrote: > > > > > This is a vote to release Apache Wicket 9.15.0 > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 9.15.0 > > > [ ] No, don't release Apache Wicket 9.15.0, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.15.0 > > > > > > Staging repository: > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1189 > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-9.15.0 > > > Release tag: rel/wicket-9.15.0 > > > > > > > > > > > > > > > CHANGELOG for 9.15.0: > > > > > > ** Bug > > > > > > * [WICKET-7061] - When I move from 9.13.0->9.14.0, my importmaps > > > fail to parse correctly due to presence of the CDATA wrapping. > > > * [WICKET-7065] - TextFilteredPropertyColumn violates CSP > > > * [WICKET-7067] - DefaultExceptionMapper should not set > > > disableCaching for WebSocketResponse > > > * [WICKET-7070] - Quick start generated app has multiple errors > > > * [WICKET-7071] - Problems when calling request.getInputStream() > > > before executing WicketFilter > > > > > > ** Improvement > > > > > > * [WICKET-7039] - Improve Accessibility of wicket-autocomplete.js > > > * [WICKET-7059] - [Serialization] make easier to avoid > > > serialization for form request > > > * [WICKET-7062] - [Tooling] improve tools for investigating page > > sizes > > > * [WICKET-7063] - Convert all Application_*.properties to > > > Application_*.utf8.properties > > > * [WICKET-7066] - Add possibility to define type-Attribute of > > > JavascriptHeaderItem as "module" > > > * [WICKET-7068] - Current tree themes are not RTL friendly > > > > > > ** Task > > > > > > * [WICKET-7069] - assertTrue(equals()) in tests should be replaced > > > with assertEquals > > > > > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > > > > > -- > Andrea Del Bene. > Apache Wicket committer. -- Best regards, Maxim
[DISCUSSION] LocalDate*Time*TextField modification
Hello All,
Sorry for the long email
While working on PR for wicket-bootstrap [1] i have test multiple
locales and find out LocalDate*Time*TextField doesn't behave well with
locales like Persian/Arabic (those with custom digits)
All classes `Local*TextField` from datetime package [2]
have `TextFormatConverter converter` as private member
With constructors accepting `String pattern` and `FormatStyle`
With locales uses different numeral systems (like Arabic) this doesn't
work well :(
Here are some examples
All below can be checked with `jshell` (and/or `bootstrap-samples` from [1])
`LocalDate.of(2020, 11,
5).format(DateTimeFormatter.ofPattern("/M/d").withLocale(Locale.forLanguageTag("fa")).withDecimalStyle(DecimalStyle.of(Locale.forLanguageTag("fa"`
> "۲۰۲۰/۱۱/۵"
Let's parse this one using DateTimeFormatter like it is being created
in current Wicket code:
`DateTimeFormatter.ofPattern("/M/d").withLocale(Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
> Exception java.time.format.DateTimeParseException
Missing `withDecimalStyle` might help but unfortunately
tempus-dominus-v6 [3] produces dates like "2003/۱۱/5" (please note
digits in mixed numeral systems are present)
Surprisingly the above works well with SimpleDateFormat:
`LocalDate.ofInstant(new SimpleDateFormat("/M/d",
Locale.forLanguageTag("fa")).parse("2003/۱۱/5").toInstant(),
ZoneId.systemDefault())`
please NOTE SimpleDateFormat doesn't honor RTL
It will produce wrong date for
`new SimpleDateFormat("d/M/",
Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
BUT correct date with
`new SimpleDateFormat("/M/d",
Locale.forLanguageTag("fa")).parse("۲۰۲۰/۱۱/۵")`
So I believe wicket code need to be improved:
- `withDecimalStyle` *might* be added
- internal date/time formatter should be accessible for the user (so
it can be twicked)
WDYT?
[1] https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/1002
[2]
https://github.com/apache/wicket/tree/master/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/datetime
[3] https://getdatepicker.com/6/
--
Best regards,
Maxim
Re: Wicket 9.x versions are NOT backward compatible
Hello Emond, On Fri, 25 Aug 2023 at 14:38, Emond Papegaaij wrote: > > Op vr 25 aug 2023 om 07:02 schreef Maxim Solodovnik : > > > So if (for whatever reason) we do have > > wicket-core 9.8.0+ AND wicket-util 9.7.0- > > > > In class path WebApplication will fail to start with > > java.lang.NoSuchMethodError > > > > This is perfectly fine. Semver only is about Wicket as a whole, so you > should not be mixing different versions of parts of Wicket. > > Also, the problem you are describing is about forward compatibility (if > were to be an external piece of code using this new method): you are using > code that is compiled against a newer version of Wicket and use it with an > older version. Semver does guarantee forward compatibility on any level. > > Finally, in minor releases you are allowed to add new functionality, this > is by definition not forward compatible. You cannot build something that > uses this new functionality in a piece of code and then expect it to work > with a version of Wicket where this functionality did not yet exist. Let me explain the situation I found during debugging :) I was testing org.wicketstuff:openlayers3-examples:war:9.14.0 here is it's dependency tree: [INFO] +- de.agilecoders.wicket:wicket-bootstrap-extensions:jar:4.0.4:compile [INFO] | +- de.agilecoders.wicket:jquery-selectors:jar:3.0.3:compile [INFO] | | +- com.fasterxml.jackson.core:jackson-core:jar:2.11.4:compile [INFO] | | \- com.fasterxml.jackson.core:jackson-databind:jar:2.15.1:compile [INFO] | | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.15.1:compile [INFO] | +- org.apache.wicket:wicket-extensions:jar:9.14.0:compile [INFO] | +- org.apache.wicket:wicket-util:jar:9.3.0:compile [INFO] | | +- commons-fileupload:commons-fileupload:jar:1.4:compile [INFO] | | +- commons-io:commons-io:jar:2.12.0:compile [INFO] | | \- org.apache.commons:commons-collections4:jar:4.4:compile [INFO] \- org.apache.wicket:wicket-core:jar:9.14.0:compile [INFO]+- com.github.openjson:openjson:jar:1.0.12:compile [INFO]+- org.apache.wicket:wicket-request:jar:9.14.0:compile [INFO]\- org.danekja:jdk-serializable-functional:jar:1.9.0:compile As you can see it directly depends on `org.apache.wicket:wicket-core:jar:9.14.0:compile` BUT it has no direct dependency on wicket-util :( The other (very much old) library wicket-bootstrap-extensions:jar:4.0.4 has it's dependency So we have conflict :( Maybe it worth to add some redundancy to our dependency:tree and add `wicket-util` as direct dependency of `wicket-core`? > > Best regards, > Emond -- Best regards, Maxim
Re: new wicket release?
I would say we have one active PR: WICKET-7066 https://github.com/apache/wicket/pull/598 :) On Mon, 28 Aug 2023 at 00:20, Andrea Del Bene wrote: > > Ready when you are gentle souls... > > On Thu, 24 Aug 2023, 17:03 Maxim Solodovnik, wrote: > > > Please review this one https://github.com/apache/wicket/pull/603 > > before release :) > > no more blockers from my side :) > > > > On Sat, 19 Aug 2023 at 08:46, Maxim Solodovnik > > wrote: > > > > > > I would like to add one small rtl-specific pr :) > > > Give me couple of days :) > > > > > > from mobile (sorry for typos ;) > > > > > > > > > On Fri, Aug 18, 2023, 21:47 Ernesto Reinaldo Barreiro < > > reier...@gmail.com> wrote: > > >> > > >> Hi, > > >> > > >> I just fixed > > >> > > >> https://issues.apache.org/jira/browse/WICKET-7067 > > >> > > >> that is impacting us. Would it be a good time for a wicket release? We > > >> could also wait a couple of weeks more for a release. > > >> > > >> -- > > >> Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Wicket 9.x versions are NOT backward compatible
Hello All, I've just noticed subj during wicketstuff testing :( In wicket 9.8.0+ we have added org.apache.wicket.util.string.Strings.isEmpty(final String string) Which is used by WicketFilter So if (for whatever reason) we do have wicket-core 9.8.0+ AND wicket-util 9.7.0- In class path WebApplication will fail to start with java.lang.NoSuchMethodError: 'boolean org.apache.wicket.util.string.Strings.isEmpty(java.lang.String)' at org.apache.wicket.protocol.http.WicketFilter.initIgnorePaths (WicketFilter.java:824) at org.apache.wicket.protocol.http.WicketFilter.init (WicketFilter.java:384) at org.apache.wicket.protocol.http.WicketFilter.init (WicketFilter.java:365) at org.eclipse.jetty.servlet.FilterHolder.initialize (FilterHolder.java:140) at org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0 (ServletHandler.java:750) Not sure what can be done here :( -- Best regards, Maxim
Re: new wicket release?
Please review this one https://github.com/apache/wicket/pull/603 before release :) no more blockers from my side :) On Sat, 19 Aug 2023 at 08:46, Maxim Solodovnik wrote: > > I would like to add one small rtl-specific pr :) > Give me couple of days :) > > from mobile (sorry for typos ;) > > > On Fri, Aug 18, 2023, 21:47 Ernesto Reinaldo Barreiro > wrote: >> >> Hi, >> >> I just fixed >> >> https://issues.apache.org/jira/browse/WICKET-7067 >> >> that is impacting us. Would it be a good time for a wicket release? We >> could also wait a couple of weeks more for a release. >> >> -- >> Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: new wicket release?
I would like to add one small rtl-specific pr :) Give me couple of days :) from mobile (sorry for typos ;) On Fri, Aug 18, 2023, 21:47 Ernesto Reinaldo Barreiro wrote: > Hi, > > I just fixed > > https://issues.apache.org/jira/browse/WICKET-7067 > > that is impacting us. Would it be a good time for a wicket release? We > could also wait a couple of weeks more for a release. > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: TinyMce 6 and possible alternatives
Could please create PR at wickestuff with version 6? I will be happy to drop other versions for master (wicket-10) Ill try to do a review (but unfortunately don't have much time, so i can do only 1-2 reviews per week) Hopefully others can help :) Thanks in advance for contribution :) from mobile (sorry for typos ;) On Thu, Jul 13, 2023, 19:23 Johannes Renoth wrote: > Hi all, > > First of all: Thanks for providing continued support and even further > development for Wicket. > > Now to my questions: > > Since Wicketstuff only has TinyMCE until version 4 but this version has > some serious vulnerabilites https://security.snyk.io/package/npm/tinymce > and the version used in wicketstuff is really old (4.3.4) i have begun > to implement a Wicket-Integration of trumbowyg > https://alex-d.github.io/Trumbowyg/ and > https://github.com/renoth/wicket-trumbowyg > > I already have a maven nexus account to release artifacts on maven > central, but before i do this i have some questions > > Do you plan to update Tinymce to latest version? > > Is there an alternative already implemented? > > Would you be interested in integrating the code into wicketstuff? If > yes, would you do a code review? > > The plugin structure of trumbowyg is somewhat finegrained and there is > some serious loading of lots of js and css files necessary at the moment > see > > https://github.com/renoth/wicket-trumbowyg/blob/master/src/main/java/dev/renoth/trumbowyg/TrumboWygBehavior.java#L70-L107, > > maybe someone has an idea how to improve it to only need one request per > JS and CSS in total > > Other than that i works great with a quickstart. > > Thank you for your time, > > Johannes Renoth > > > >
Re: wicket and commons-fileupload 2.0.0-M1
On Wed, 12 Jul 2023 at 18:50, Maxim Solodovnik wrote: > > On Wed, 12 Jul 2023 at 18:34, Martin Grigorov wrote: > > > > On Wed, Jul 12, 2023 at 8:03 AM Maxim Solodovnik > > wrote: > > > > > BTW here is the discussion regarding future of commons-fileupload: > > > https://lists.apache.org/thread/koclgykqx0sfkrz8tf1w37n15zyql822 > > > please join :) > > > > > > > Regarding commons-fileupload vs. Servlet API: I've mentioned the reason why > > Wicket does not use Servlet file upload APIs : > > - https://issues.apache.org/jira/browse/WICKET-5192 > > - https://issues.apache.org/jira/browse/WICKET-5924 (also shows some > > limitations) > > > > Regarding the release of commons-fileupload: > > I understand it is volunteer work but the Commons people talk about making > > a release for 3 years now... > > OK, let's assume they release -M1 next weekend. How much more would it take > > for a final release ?! > > The funny part is that commons-fileupload classes were part of wicket-util > > back in the days but I replaced them with a proper dependency with > > https://issues.apache.org/jira/browse/WICKET-5503 :-) > > > > I believe the whole above comment should go to mail thread in commons ;) oops, you already did it :) sorry for the noise :( > > > > > > > > > > > On Fri, 16 Jun 2023 at 21:35, Ernesto Reinaldo Barreiro > > > wrote: > > > > > > > > Hi, > > > > > > > > Yes but then we, wicket developers, will be responsible for tracking > > > > file > > > > upload related issues and port to wicket fixes done in the original > > > project > > > > (and vice versa, e.g. I already fixed one thing in wicket copy and had > > > > to > > > > submit a PR to the original project). > > > > > > > > On Fri, Jun 16, 2023 at 5:23 PM Matt Pavlovich > > > wrote: > > > > > > > > > Hi Maxim- > > > > > > > > > > I understand that preference— this is a build-vs-buy decision. My > > > point is > > > > > that a file upload handler makes sense for Wicket to host itself, > > > > > considering it is a small set of functions and relates to storage > > > > > management needed by Wicket apps. Also, Wicket is more active in > > > > > development and adopting JDK and Jakarta EE than the commons-file > > > upload > > > > > project. I suspect we’ll be right back here as the Servlet spec is > > > evolving > > > > > in Jakarta EE. > > > > > > > > > > -Matt > > > > > > > > > > > On Jun 16, 2023, at 2:32 AM, Maxim Solodovnik > > > > > wrote: > > > > > > > > > > > > On Thu, 15 Jun 2023 at 00:40, Matt Pavlovich > > > wrote: > > > > > >> > > > > > >> Why add it back? The feature is just a couple of classes. > > > > > commons-fileupload2 can continue to serve as a reference > > > implementation to > > > > > draw from. > > > > > >> > > > > > >> These backside dependencies create headaches when building web > > > > > applications with Wicket that are platforms that allow end-users to > > > provide > > > > > their own plugins or extensions that may use the same or similarly > > > > > versioned dependencies. > > > > > > > > > > > > IMO it's bad practice to copy/paste other libraries, > > > > > > having fileupload2 as dependency we have all fixes and additional > > > > > testing :) > > > > > > > > > > > > BTW the build of my branch seems to be green, only minor issues with > > > > > > Automatic-Module-Name remain unresolved :) > > > > > > > > > > > >> > > > > > >> Thanks, > > > > > >> Matt > > > > > >> > > > > > >>> On Jun 14, 2023, at 11:48 AM, Maxim Solodovnik < > > > solomax...@gmail.com> > > > > > wrote: > > > > > >>> > > > > > >>> Hello All, > > > > > >>> > > > > > >>> I've start working on migration back to commons-fileupload > > > > > >>> 2.0.0-M1 > > > > > >>> (the branch is here: [1] :))) > > > > > >>> > > > > > >>> Latest version of commons-fileupload2 has couple of issues > > > > > >>> 1) missing `Automatic-Module-Name` > > > > > >>> 2) FileItemHeadersImpl is not public anymore > > > > > >>> (discussion is here: [2]) > > > > > >>> > > > > > >>> I'm going to have vacation in a couple of days (will be offline > > > almost > > > > > >>> all the time :) > > > > > >>> > > > > > >>> Can someone take a look at [2] ? > > > > > >>> So we have all required features at 2.0.0-M1 release? > > > > > >>> > > > > > >>> Thanks in advance :) > > > > > >>> > > > > > >>> [1] https://github.com/apache/wicket/blob/commons-fileupload2-back > > > > > >>> [2] > > > https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk > > > > > >>> > > > > > >>> -- > > > > > >>> Best regards, > > > > > >>> Maxim > > > > > >> > > > > > > > > > > > > > > > > > > -- > > > > > > Best regards, > > > > > > Maxim > > > > > > > > > > > > > > > > > > -- > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > -- > Best regards, > Maxim -- Best regards, Maxim
Re: wicket and commons-fileupload 2.0.0-M1
On Wed, 12 Jul 2023 at 18:34, Martin Grigorov wrote: > > On Wed, Jul 12, 2023 at 8:03 AM Maxim Solodovnik > wrote: > > > BTW here is the discussion regarding future of commons-fileupload: > > https://lists.apache.org/thread/koclgykqx0sfkrz8tf1w37n15zyql822 > > please join :) > > > > Regarding commons-fileupload vs. Servlet API: I've mentioned the reason why > Wicket does not use Servlet file upload APIs : > - https://issues.apache.org/jira/browse/WICKET-5192 > - https://issues.apache.org/jira/browse/WICKET-5924 (also shows some > limitations) > > Regarding the release of commons-fileupload: > I understand it is volunteer work but the Commons people talk about making > a release for 3 years now... > OK, let's assume they release -M1 next weekend. How much more would it take > for a final release ?! > The funny part is that commons-fileupload classes were part of wicket-util > back in the days but I replaced them with a proper dependency with > https://issues.apache.org/jira/browse/WICKET-5503 :-) > I believe the whole above comment should go to mail thread in commons ;) > > > > > > On Fri, 16 Jun 2023 at 21:35, Ernesto Reinaldo Barreiro > > wrote: > > > > > > Hi, > > > > > > Yes but then we, wicket developers, will be responsible for tracking file > > > upload related issues and port to wicket fixes done in the original > > project > > > (and vice versa, e.g. I already fixed one thing in wicket copy and had to > > > submit a PR to the original project). > > > > > > On Fri, Jun 16, 2023 at 5:23 PM Matt Pavlovich > > wrote: > > > > > > > Hi Maxim- > > > > > > > > I understand that preference— this is a build-vs-buy decision. My > > point is > > > > that a file upload handler makes sense for Wicket to host itself, > > > > considering it is a small set of functions and relates to storage > > > > management needed by Wicket apps. Also, Wicket is more active in > > > > development and adopting JDK and Jakarta EE than the commons-file > > upload > > > > project. I suspect we’ll be right back here as the Servlet spec is > > evolving > > > > in Jakarta EE. > > > > > > > > -Matt > > > > > > > > > On Jun 16, 2023, at 2:32 AM, Maxim Solodovnik > > > > wrote: > > > > > > > > > > On Thu, 15 Jun 2023 at 00:40, Matt Pavlovich > > wrote: > > > > >> > > > > >> Why add it back? The feature is just a couple of classes. > > > > commons-fileupload2 can continue to serve as a reference > > implementation to > > > > draw from. > > > > >> > > > > >> These backside dependencies create headaches when building web > > > > applications with Wicket that are platforms that allow end-users to > > provide > > > > their own plugins or extensions that may use the same or similarly > > > > versioned dependencies. > > > > > > > > > > IMO it's bad practice to copy/paste other libraries, > > > > > having fileupload2 as dependency we have all fixes and additional > > > > testing :) > > > > > > > > > > BTW the build of my branch seems to be green, only minor issues with > > > > > Automatic-Module-Name remain unresolved :) > > > > > > > > > >> > > > > >> Thanks, > > > > >> Matt > > > > >> > > > > >>> On Jun 14, 2023, at 11:48 AM, Maxim Solodovnik < > > solomax...@gmail.com> > > > > wrote: > > > > >>> > > > > >>> Hello All, > > > > >>> > > > > >>> I've start working on migration back to commons-fileupload 2.0.0-M1 > > > > >>> (the branch is here: [1] :))) > > > > >>> > > > > >>> Latest version of commons-fileupload2 has couple of issues > > > > >>> 1) missing `Automatic-Module-Name` > > > > >>> 2) FileItemHeadersImpl is not public anymore > > > > >>> (discussion is here: [2]) > > > > >>> > > > > >>> I'm going to have vacation in a couple of days (will be offline > > almost > > > > >>> all the time :) > > > > >>> > > > > >>> Can someone take a look at [2] ? > > > > >>> So we have all required features at 2.0.0-M1 release? > > > > >>> > > > > >>> Thanks in advance :) > > > > >>> > > > > >>> [1] https://github.com/apache/wicket/blob/commons-fileupload2-back > > > > >>> [2] > > https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk > > > > >>> > > > > >>> -- > > > > >>> Best regards, > > > > >>> Maxim > > > > >> > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Maxim > > > > > > > > > > > > > > -- > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Re: wicket and commons-fileupload 2.0.0-M1
BTW here is the discussion regarding future of commons-fileupload: https://lists.apache.org/thread/koclgykqx0sfkrz8tf1w37n15zyql822 please join :) On Fri, 16 Jun 2023 at 21:35, Ernesto Reinaldo Barreiro wrote: > > Hi, > > Yes but then we, wicket developers, will be responsible for tracking file > upload related issues and port to wicket fixes done in the original project > (and vice versa, e.g. I already fixed one thing in wicket copy and had to > submit a PR to the original project). > > On Fri, Jun 16, 2023 at 5:23 PM Matt Pavlovich wrote: > > > Hi Maxim- > > > > I understand that preference— this is a build-vs-buy decision. My point is > > that a file upload handler makes sense for Wicket to host itself, > > considering it is a small set of functions and relates to storage > > management needed by Wicket apps. Also, Wicket is more active in > > development and adopting JDK and Jakarta EE than the commons-file upload > > project. I suspect we’ll be right back here as the Servlet spec is evolving > > in Jakarta EE. > > > > -Matt > > > > > On Jun 16, 2023, at 2:32 AM, Maxim Solodovnik > > wrote: > > > > > > On Thu, 15 Jun 2023 at 00:40, Matt Pavlovich wrote: > > >> > > >> Why add it back? The feature is just a couple of classes. > > commons-fileupload2 can continue to serve as a reference implementation to > > draw from. > > >> > > >> These backside dependencies create headaches when building web > > applications with Wicket that are platforms that allow end-users to provide > > their own plugins or extensions that may use the same or similarly > > versioned dependencies. > > > > > > IMO it's bad practice to copy/paste other libraries, > > > having fileupload2 as dependency we have all fixes and additional > > testing :) > > > > > > BTW the build of my branch seems to be green, only minor issues with > > > Automatic-Module-Name remain unresolved :) > > > > > >> > > >> Thanks, > > >> Matt > > >> > > >>> On Jun 14, 2023, at 11:48 AM, Maxim Solodovnik > > wrote: > > >>> > > >>> Hello All, > > >>> > > >>> I've start working on migration back to commons-fileupload 2.0.0-M1 > > >>> (the branch is here: [1] :))) > > >>> > > >>> Latest version of commons-fileupload2 has couple of issues > > >>> 1) missing `Automatic-Module-Name` > > >>> 2) FileItemHeadersImpl is not public anymore > > >>> (discussion is here: [2]) > > >>> > > >>> I'm going to have vacation in a couple of days (will be offline almost > > >>> all the time :) > > >>> > > >>> Can someone take a look at [2] ? > > >>> So we have all required features at 2.0.0-M1 release? > > >>> > > >>> Thanks in advance :) > > >>> > > >>> [1] https://github.com/apache/wicket/blob/commons-fileupload2-back > > >>> [2] https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk > > >>> > > >>> -- > > >>> Best regards, > > >>> Maxim > > >> > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
[ANNOUNCE] WicketStuff 10.0.0-M1 Released
WicketStuff core 10.0.0-M1 based on Apache Wicket 10.0.0-M1 is released and soon will be available at Maven Central! Maxim Solodovnik (24): wicket-webjars is updated Fixes Issue #743: JSON.stringify is used instead of $.toJson Deprecated code is removed closure-compiler updated to test build Debugging secrets Testing environments Testing environments Testing environments Testing environments: clean-up Attempt to fix CI build Another attempt to fix CI build Deprecated code is removed Dependencies are updated Dependencies are updated; jetty:run is fixed Build should be fixed maven-deploy-plugin is updated Jetty-uber is dropped Dependencies are updated Tests are fixed Portlets should be fixed; Deprecations are cleaned-up Code clean-up Dependencies are updated SNAPSHOT dependency is removed, duplicated wicket-native-websocket-javax is removed Portlets are dropped; wicketstuff-core-10.0.0-M1 released dependabot[bot] (3): Bump spring-core from 6.0.4 to 6.0.7 (#746) Bump log4j-core (#745) Bump hazelcast in /datastores-parent/datastore-hazelcast (#751) Urs Joss (2): bump jasperreports to 6.20.3 and explicitly depend on openpdf (#749) bump jasperreports to 6.20.4 and fall back to transitive dependency on openpdf (#750) Francesco Chicchiriccò (1): Upgrading to Wicket 10, Spring 6 and related Jakarta EE specs (#741) Martin Tzvetanov Grigorov (1): Update jQuery from 3.6.0 to 3.6.4 The WicketStuff team
Re: wicket and commons-fileupload 2.0.0-M1
On Thu, 15 Jun 2023 at 00:40, Matt Pavlovich wrote: > > Why add it back? The feature is just a couple of classes. commons-fileupload2 > can continue to serve as a reference implementation to draw from. > > These backside dependencies create headaches when building web applications > with Wicket that are platforms that allow end-users to provide their own > plugins or extensions that may use the same or similarly versioned > dependencies. IMO it's bad practice to copy/paste other libraries, having fileupload2 as dependency we have all fixes and additional testing :) BTW the build of my branch seems to be green, only minor issues with Automatic-Module-Name remain unresolved :) > > Thanks, > Matt > > > On Jun 14, 2023, at 11:48 AM, Maxim Solodovnik wrote: > > > > Hello All, > > > > I've start working on migration back to commons-fileupload 2.0.0-M1 > > (the branch is here: [1] :))) > > > > Latest version of commons-fileupload2 has couple of issues > > 1) missing `Automatic-Module-Name` > > 2) FileItemHeadersImpl is not public anymore > > (discussion is here: [2]) > > > > I'm going to have vacation in a couple of days (will be offline almost > > all the time :) > > > > Can someone take a look at [2] ? > > So we have all required features at 2.0.0-M1 release? > > > > Thanks in advance :) > > > > [1] https://github.com/apache/wicket/blob/commons-fileupload2-back > > [2] https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk > > > > -- > > Best regards, > > Maxim > -- Best regards, Maxim
wicket and commons-fileupload 2.0.0-M1
Hello All, I've start working on migration back to commons-fileupload 2.0.0-M1 (the branch is here: [1] :))) Latest version of commons-fileupload2 has couple of issues 1) missing `Automatic-Module-Name` 2) FileItemHeadersImpl is not public anymore (discussion is here: [2]) I'm going to have vacation in a couple of days (will be offline almost all the time :) Can someone take a look at [2] ? So we have all required features at 2.0.0-M1 release? Thanks in advance :) [1] https://github.com/apache/wicket/blob/commons-fileupload2-back [2] https://lists.apache.org/thread/gjglf0c1xzdrhm143swfcq0xpg5ofrqk -- Best regards, Maxim
Re: Plans for Wicket 10 Release
from mobile (sorry for typos ;) On Sat, Jun 10, 2023, 20:49 Andrea Del Bene wrote: > Hi, > > I'm having some module related problems building Wicket 10.0.0-M1. On my > first attempt build failed with message > > "Error: log4j-api-2.9.0.jar is a multi-release jar file but > --multi-release option is not set" > Build was green at my Ubuntu ... Will try to take a look a bit later (maybe on Monday) > So I decided to use Apache Maven JDeps Plugin as suggested here : > > https://stackoverflow.com/questions/46662286/error-log4j-api-2-9-0-jar-is-a-multi-release-jar-file-but-multi-release-optio > > But know I receive this complain about modules and > wicket-commons-fileupload: > > INFO] [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-jdeps-plugin:3.1.1:jdkinternals (default) > on project wicket-commons-fileupload: > [INFO] [ERROR] Exit code: 1 - Exception in thread "main" > java.lang.module.FindException: Module org.apache.commons.io not found, > required by org.apache.wicket.commons.fileupload > [INFO] [ERROR] at > java.base/java.lang.module.Resolver.findFail(Resolver.java:893) > [INFO] [ERROR] at > java.base/java.lang.module.Resolver.resolve(Resolver.java:192) > [INFO] [ERROR] at > java.base/java.lang.module.Resolver.resolve(Resolver.java:141) > [INFO] [ERROR] at > java.base/java.lang.module.Configuration.resolve(Configuration.java:421) > [INFO] [ERROR] at > java.base/java.lang.module.Configuration.resolve(Configuration.java:255) > [INFO] [ERROR] at > > jdk.jdeps/com.sun.tools.jdeps.JdepsConfiguration$Builder.build(JdepsConfiguration.java:564) > [INFO] [ERROR] at > jdk.jdeps/com.sun.tools.jdeps.JdepsTask.buildConfig(JdepsTask.java:603) > [INFO] [ERROR] at > jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:557) > [INFO] [ERROR] at > jdk.jdeps/com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:533) > [INFO] [ERROR] at jdk.jdeps/com.sun.tools.jdeps.Main.main(Main.java:49) > [INFO] [ERROR] > [INFO] [ERROR] Command line was: /bin/sh -c > '/usr/lib/jvm/temurin-17-jdk-amd64/bin/jdeps' '-cp' > '/home/andrea/.m2/repository/commons-io/commons-io/2.11.0/commons-io-2.11.0.jar:/home/andrea/.m2/repository/jakarta/servlet/jakarta.servlet-api/6.0.0/jakarta.servlet-api-6.0.0.jar:/home/andrea/.m2/repository/org/slf4j/slf4j-api/2.0.6/slf4j-api-2.0.6.jar' > > '--multi-release' '17' > > '/home/andrea/WicketBuild/wicket/target/checkout/wicket-commons-fileupload/target/classes' > > Do you have any suggestion about this? > > Thank you. > > > On 08/06/23 16:28, Martin Grigorov wrote: > > I don’t have any tasks for 10 at the moment > > > > On Thu, 8 Jun 2023 at 16:17, Andrea Del Bene > wrote: > > > >> Ready when you are :-)...if everything is in place I can start working > on > >> RC1 release on this weekend > >> > >> On Wed, Jun 7, 2023 at 4:06 PM Martin Grigorov > >> wrote: > >> > >>> The PR has been merged! > >>> > >>> On Wed, Jun 7, 2023 at 3:32 PM Greb Lindqvist < > greb.lindqv...@gmail.com> > >>> wrote: > >>> > >>>> I am looking forward to testing RC1 in several projects. > >>>> > >>>> Thank you for moving this forward! > >>>> > >>>> On Wed, Jun 7, 2023 at 6:00 AM Martin Grigorov > >>>> wrote: > >>>> > >>>>> On Wed, May 31, 2023 at 7:37 AM Maxim Solodovnik < > >> solomax...@gmail.com > >>>>> wrote: > >>>>> > >>>>>> Should be fixed with this: > >> https://github.com/apache/wicket/pull/591 > >>>> :) > >>>>> If no one has a better solution than I suggest to merge this PR and > >>>> release > >>>>> Wicket 10 RC1 > >>>>> > >>>>> > >>>>> > >>>>>> On Tue, 30 May 2023 at 22:16, Maxim Solodovnik < > >> solomax...@gmail.com > >>>>>> wrote: > >>>>>>> > >>>>>>> > >>>>>>> from mobile (sorry for typos ;) > >>>>>>> > >>>>>>> > >>>>>>> On Tue, May 30, 2023, 20:05 Jeroen Steenbeeke < > >>>>> j.steenbeeke...@gmail.com> > >>>>>> wrote: > >>>>>>>> The current wicket-commons-fileupload 10.0.0-M1-SNAPSHOT jar in > >>> the > >>>>>> Apache > >>>>>>>> snapshots repo duplicates classes from commons-io, Jakart
[ANNOUNCE] WicketStuff 9.14.0 Released
WicketStuff core 9.14.0 based on Apache Wicket 9.14.0 is released and soon will be available at Maven Central! Maxim Solodovnik (6): Switching to the next development version Hazelcast is updated Dependencies are updated Code clean-up Dependencies are updated wicketstuff-core-9.14.0 release Urs Joss (2): bump jasperreports to 6.20.3 and explicitly depend on openpdf (#749) bump jasperreports to 6.20.4 and fall back to transitive dependency on openpdf (#750) The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.14.0 - take 2
+1 Tested: - signatures - build from sources - wicketstuff build - some wicketstuff examples On Wed, 24 May 2023 at 21:08, Andrea Del Bene wrote: > > always a pleasure > > > On Wed, May 24, 2023 at 3:10 PM Ernesto Reinaldo Barreiro < > reier...@gmail.com> wrote: > > > And many thanks Andrea for taking care of our releases! > > > > On Wed, May 24, 2023 at 4:08 PM Ernesto Reinaldo Barreiro < > > reier...@gmail.com> wrote: > > > > > +1 > > > > > > Tests on our app (around 600 selenium tests) passed ok. > > > > > > On Wed, May 24, 2023 at 3:14 PM Andrea Del Bene > > > wrote: > > > > > >> This is a vote to release Apache Wicket 9.14.0 > > >> > > >> Please download the source distributions found in our staging area > > >> linked below. > > >> > > >> I have included the signatures for both the source archives. This vote > > >> lasts for 72 hours minimum. > > >> > > >> [ ] Yes, release Apache Wicket 9.14.0 > > >> [ ] No, don't release Apache Wicket 9.14.0, because ... > > >> > > >> Distributions, changelog, keys and signatures can be found at: > > >> > > >> https://dist.apache.org/repos/dist/dev/wicket/9.14.0 > > >> > > >> Staging repository: > > >> > > >> > > https://repository.apache.org/content/repositories/orgapachewicket-1182/ > > >> > > >> The binaries are available in the above link, as are a staging > > >> repository for Maven. Typically the vote is on the source, but should > > >> you find a problem with one of the binaries, please let me know, I can > > >> re-roll them some way or the other. > > >> > > >> Staging git repository data: > > >> > > >> Repository: g...@github.com:bitstorm/wicket.git > > >> Branch: build/wicket-9.14.0 > > >> Release tag: rel/wicket-9.14.0 > > >> > > >> > > >> > > >> > > >> CHANGELOG for 9.14.0: > > >> > > >> ** Bug > > >> > > >> * [WICKET-7013] - IndexOutOfBoundsException in InSessionPageStore > > >> * [WICKET-7052] - Interrupting a task should not be logged as an > > >> error > > >> * [WICKET-7054] - Tag
Re: [VOTE] Release Apache Wicket 9.14.0
There are lots of dependencies with newer versions:
[INFO] ${asm.version} . 9.1 -> 9.5
[INFO] ${bouncycastle.version} 1.72 -> 1.73
[INFO] ${commons-io.version} .. 2.11.0 -> 2.12.0
[INFO] ${jackson.version} . 2.14.2
-> 2.14.3 (2.15.1 requires code changes)
[INFO] ${junit.version} . 5.9.2 -> 5.9.3
[INFO] ${mockito.version} ... 5.2.0 -> 5.3.1
[INFO] ${spring.version} ... 5.3.25
-> 5.3.27 (2 Vulnerabilities are fixed)
do we like to updated whose?
https://github.com/apache/wicket/pull/590
On Tue, 23 May 2023 at 02:05, Andrea Del Bene wrote:
>
> This is a vote to release Apache Wicket 9.14.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 9.14.0
> [ ] No, don't release Apache Wicket 9.14.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/9.14.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1181/
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
> Repository: g...@github.com:bitstorm/wicket.git
> Branch: build/wicket-9.14.0
> Release tag: rel/wicket-9.14.0
>
>
>
>
> CHANGELOG for 9.14.0:
>
> ** Bug
>
> * [WICKET-7013] - IndexOutOfBoundsException in InSessionPageStore
> * [WICKET-7052] - Interrupting a task should not be logged as an error
> * [WICKET-7054] - Tag
Re: a new release for 9.x?
+1 :) On Fri, 12 May 2023 at 09:58, Ernesto Reinaldo Barreiro wrote: > > Hi, > > We would appreciate having a 9.14.0 release as we have local developments > on hold (because they depend on new upload to resource functionality). WDYT? > > On Thu, Apr 27, 2023 at 7:38 AM Maxim Solodovnik > wrote: > > > IMO we should wait couple of weeks :) > > > > On Thu, 27 Apr 2023 at 10:21, Ernesto Reinaldo Barreiro > > wrote: > > > > > > Good! > > > > > > On Wed, Apr 26, 2023 at 10:40 PM Andrea Del Bene > > > wrote: > > > > > > > First 8.15 :-), then let's see what people say... > > > > > > > > On 26/04/23 11:10, Ernesto Reinaldo Barreiro wrote: > > > > > Hi, > > > > > > > > > > I know 9.13.0 was just released but after that I have merged 2 or 3 > > > > commits > > > > > to the 9.x branch that I would like to have in particular uploading > > to a > > > > > resource. > > > > > > > > > > How do you all feel about a 9.14.0 release? > > > > > > > > > > > > > > > > > > -- > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
[ANNOUNCE] WicketStuff 8.15.0 Released
WicketStuff core 8.15.0 based on Apache Wicket 8.15.0 is released and soon will be available at Maven Central! Maxim Solodovnik (3): Switching to the next development version Versions are updated WicketStuff Core 8.15.0 build is successful The WicketStuff team
Re: a new release for 9.x?
IMO we should wait couple of weeks :) On Thu, 27 Apr 2023 at 10:21, Ernesto Reinaldo Barreiro wrote: > > Good! > > On Wed, Apr 26, 2023 at 10:40 PM Andrea Del Bene > wrote: > > > First 8.15 :-), then let's see what people say... > > > > On 26/04/23 11:10, Ernesto Reinaldo Barreiro wrote: > > > Hi, > > > > > > I know 9.13.0 was just released but after that I have merged 2 or 3 > > commits > > > to the 9.x branch that I would like to have in particular uploading to a > > > resource. > > > > > > How do you all feel about a 9.14.0 release? > > > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 8.15.0
+1 tested: - signatures - build from sources - wicketstuff build - run couple of wicketstuff examples I would update dependencies before next release :) On Thu, 27 Apr 2023 at 10:22, Ernesto Reinaldo Barreiro wrote: > > +1 > > and thanks for taking care of our releases > > On Wed, Apr 26, 2023 at 11:04 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 8.15.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 8.15.0 > > [ ] No, don't release Apache Wicket 8.15.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/8.15.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1180 > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-8.15.0 > > Release tag: rel/wicket-8.15.0 > > > > > > > > > > The signatures for the source release artefacts: > > > > > > Signature for apache-wicket-8.15.0.zip: > > > > -BEGIN PGP SIGNATURE- > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmRJgq4ACgkQh48B+qjT > > VuGlLRAAiELeMl8pDlFMzrVef2bX1hX/MXdT5lUj8Hpsak2c8UyBvNwl1Ro4y2ZQ > > CqMB0BDUQvvrPgix8p3ee0kLhZEnStFrkvp+QckEdN/tFNV1vf4jJUFIif2Xi+od > > wmhPizR7YTN/Zy77oK5VeACGjtBgx2fgxm7g4gJ1fw+XCi9Kj/OV9UapqrLIoS2U > > rjId/f/kfo442QE1zPgkDzuWSYvg3mAonrARSpP0PK6eSm6KNvMV8AXMg0SBjoUJ > > M1KMVmMln7YVmPh0LfNNgSiy2qXPfA6Pk3mJmOeDWrnZZ/t1tHU/m0RwIEds0dRg > > LxZ9Wb1fZW7fL5eMnXEkON74XacQ8E4ixGeTJf6npFEU0CZfkjiQwoYF+1Gpju9K > > Wfr+y3KBY8EspgHo/JDd6d6UkGjIpemoC/HNaNwFvNapNWxasIBU/mmvoHlz/HmH > > zAwG2AX0Ns1SZjTenPhSVUmz00+VjktJdqyBK83z3DFHaQQfKIdkki+0kVSPmmRe > > /BpR8q4Oqn7/6ETJMVEE25Hy7r4KQvp0q4tyzxPK557nDfmA085sdqBXvRA89GMI > > S08K+fDmOJ3CgZydcTrXWnPU2B9G3pfnpGye/f9QWcqT/qO5WC3Zzq3KmULT/PwV > > zICOCB8bovolj5Am/dRGE48UXDrMXkAu3fnC61qPcLT6aBy2XTc= > > =rAUk > > -END PGP SIGNATURE- > > > > Signature for apache-wicket-8.15.0.tar.gz: > > > > -BEGIN PGP SIGNATURE- > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAmRJgq4ACgkQh48B+qjT > > VuENwxAAj4Cu8uqXHIPwlzBl1WIJk8+7FeLfH7jO/udElyDQlfh3BHp4QeE0cYuh > > TAx8JFZ+QwAplcSGErjzptCygXZprHAy0W5CLmXuQ9ldvgkwskR+E3iGY9VUGBXl > > GMIQUGAAqjBh1wzhaKepqREg38V6twYsR9yqWGj8uD0IlosIDIWzZWkLuHlAjkeS > > sa+lsj0KdNVyuWeElPt3n2yQY1NBQQ3KMqT5bUXsRu0fuZYiHbJzXHymxpwFgTRu > > SKh0mGIfMM9pRfMHr5vSk/JeUV1xeaiFF0fGRnbd3uVG9u8NFQZoRMbv4XnGuWly > > JOpvfidLQLCVzfy/bfQ92xSWCnQkIxJLjkhZs/4JsuxBExek2QzoL2Bpd9P/Qj8Z > > QsJzhuY+/xXMUjWwgf93P+9DH9qobhlxs57Q8EwLKpmSbJ+aKTZByqAiPvAnp8VL > > q7uvP8HD/NEEWM/9eHndEp9YVn87qcAE41wt6dTwetss5XcSqCfGt/1uIuPuO3Sy > > hhI0AolFLNJJxUNMGnF1ojMKoQ0tMi5miZJjHLrKZ11kWszkdf/0HInpsdZilj/X > > jQP3a3XNLvmXC6Tc/G7CH2FWZqECJ0lFQZiz3Z4XwFbsL8x59uW1Y+RTSlSY3fQ3 > > BIenl8fpvset+jnYG1EHSvRACpO3witT6Ge6N8AM8Lsg0qjs950= > > =GqLg > > -END PGP SIGNATURE- > > > > > > > > CHANGELOG for 8.15.0: > > > > ** Improvement > > > > * [WICKET-7002] - Application metadata access should not require > > synchronization > > * [WICKET-7017] - ListenerRequestHandler should not hide > > IndexOutOfBoundsException > > * [WICKET-7035] - fileCountMax should be added to control the > > amount of files being uploaded > > * [WICKET-7041] - Reduce allocations when rendering component headers > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.13.0 Released
WicketStuff core 9.13.0 based on Apache Wicket 9.13.0 is released and soon will be available at Maven Central! Maxim Solodovnik (16): Switching to the next development version Dependencies are updated Dependencies are updated, vulnerable testng is removed Dependencies are updated Fixes Issue #743: JSON.stringify is used instead of $.toJson Attempt to fix CI build Another attempt to fix CI build Deprecated code is removed Dependencies are updated Fixing CI build Dependencies are updated, tests are fixed More dependencies are updated; Attempt to fix CI build maven-deploy-plugin is updated Tests are fixed Dependencies are updated wicketstuff-core-9.13.0 is released Martin Tzvetanov Grigorov (1): Build only when wicket-9.x branch is modified muecke87 (1): fixes issue #737 (#738) The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.13.0
The vote inside a vote :) IMO we have 5 or so last-minute fixes There is no guarantee we will not have 5 more if we will restart this vote :) We might do another release in, let's say, 3 weeks or so :) from mobile (sorry for typos ;) On Mon, Apr 17, 2023, 23:06 Thomas Heigl wrote: > +1 > > Let's release 9.13.0. > > On Mon, Apr 17, 2023 at 5:59 PM Ernesto Reinaldo Barreiro < > reier...@gmail.com> wrote: > > > +1 for releasing 9.13.0! > > > > On Fri, Apr 14, 2023 at 10:13 PM Andrea Del Bene > > wrote: > > > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > > > Staging repository: > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1179 > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-9.13.0 > > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > > > > > > > CHANGELOG for 9.13.0: > > > > > > ** Bug > > > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: Cannot inject > > > already loaded type > > > * [WICKET-7022] - JavaScriptStripper fails to detect regular > > > expression correctly > > > * [WICKET-7028] - CSP header not rendered when using > > > RedirectPolicy.NEVER_REDIRECT > > > * [WICKET-7034] - WebSocket.Closed event not fired when error > > occurred > > > * [WICKET-7037] - [Ajax Download] cookie used to track download > > > complete misses the SameSite attribute > > > * [WICKET-7044] - Images in the Wicket 9.x reference guide are not > > > displayed. > > > > > > ** Improvement > > > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > > * [WICKET-7014] - Use new API for forward compatibility with CDI 4 > > > * [WICKET-7016] - Support GCM-SIV for page store encryption > > > * [WICKET-7017] - ListenerRequestHandler should not hide > > > IndexOutOfBoundsException > > > * [WICKET-7021] - Additional OSGi import fixes > > > * [WICKET-7025] - Package private methods should be proxied by > > > ByteBuddy > > > * [WICKET-7031] - Update to JQuery 3.6.4 > > > * [WICKET-7032] - Update the JS tests to use latest version of > > > QUnit (2.x) > > > * [WICKET-7035] - fileCountMax should be added to control the > > > amount of files being uploaded > > > * [WICKET-7041] - Reduce allocations when rendering component > > headers > > > * [WICKET-7042] - Improve sizing of StringResponse when writing > > > scripts in PartialPageResponse > > > > > > > > > > > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > > >
Re: [VOTE] Release Apache Wicket 9.13.0
+1 Tested: - signatures - local build - wicketstuff build - main application build and run On Sun, 16 Apr 2023 at 21:36, Thomas Heigl wrote: > > Hi all, > > I didn't expect to, but I discovered one more *major* way to reduce > allocations in ajax requests: > > - https://github.com/apache/wicket/pull/578 > > This avoids allocating some 50-100KB *per request* in our ajax heavy > application. > > Then there are two other small improvements: > > - https://github.com/apache/wicket/pull/577 > - https://github.com/apache/wicket/pull/579 > > I don't want to disrupt the vote once again and cause more work for Andrea, > so I'm OK with including these changes in 9.14.0, > but I wanted to let you know in case someone else is interested in these > improvements. > > Best, > > Thomas > > On Sat, Apr 15, 2023 at 3:08 PM Sven Meier wrote: > > > +1 please release 9.13.0 > > > > Thanks > > Sven > > > > > > On 14.04.23 21:13, Andrea Del Bene wrote: > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > > > Staging repository: > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1179 > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-9.13.0 > > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > > > > > > CHANGELOG for 9.13.0: > > > > > > ** Bug > > > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: Cannot inject > > > already loaded type > > > * [WICKET-7022] - JavaScriptStripper fails to detect regular > > > expression correctly > > > * [WICKET-7028] - CSP header not rendered when using > > > RedirectPolicy.NEVER_REDIRECT > > > * [WICKET-7034] - WebSocket.Closed event not fired when error > > > occurred > > > * [WICKET-7037] - [Ajax Download] cookie used to track download > > > complete misses the SameSite attribute > > > * [WICKET-7044] - Images in the Wicket 9.x reference guide are not > > > displayed. > > > > > > ** Improvement > > > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > > * [WICKET-7014] - Use new API for forward compatibility with CDI 4 > > > * [WICKET-7016] - Support GCM-SIV for page store encryption > > > * [WICKET-7017] - ListenerRequestHandler should not hide > > > IndexOutOfBoundsException > > > * [WICKET-7021] - Additional OSGi import fixes > > > * [WICKET-7025] - Package private methods should be proxied by > > > ByteBuddy > > > * [WICKET-7031] - Update to JQuery 3.6.4 > > > * [WICKET-7032] - Update the JS tests to use latest version of > > > QUnit (2.x) > > > * [WICKET-7035] - fileCountMax should be added to control the > > > amount of files being uploaded > > > * [WICKET-7041] - Reduce allocations when rendering component headers > > > * [WICKET-7042] - Improve sizing of StringResponse when writing > > > scripts in PartialPageResponse > > > > > > > > > > > -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.13.0
I would start the VOTE on 9.13.0 without WICKET-7033 It seems to be big enough for last minute fix IMO better to release, then add it without rush :) On Thu, 13 Apr 2023 at 19:31, Ernesto Reinaldo Barreiro wrote: > > Hi, > > I also worked on this: uploading to a resource + adapt the progress upload > to work for such use case > > https://github.com/apache/wicket/pull/571 > > https://issues.apache.org/jira/browse/WICKET-7033 > > This seems to be working. Not sure if this needs more work and if it is > better to leave this for 9.14.x? This needs to be potted to master 10.x > (which should not be difficult) > > > On Wed, Apr 12, 2023 at 4:27 AM Maxim Solodovnik > wrote: > > > This one https://issues.apache.org/jira/browse/WICKET-7044 > > > > Also meed to be addressed > > I'll try to take a look ASAP > > > > from mobile (sorry for typos ;) > > > > > > On Wed, Apr 12, 2023, 01:07 Thomas Heigl wrote: > > > > > I have backported the two improvements to 9.x. Thanks a lot for letting > > me > > > include these two PRs. > > > > > > We can continue with the release. > > > > > > On Tue, Apr 11, 2023 at 10:57 AM Andrea Del Bene > > > wrote: > > > > > > > On Tue, Apr 11, 2023 at 8:38 AM Ernesto Reinaldo Barreiro < > > > > reier...@gmail.com> wrote: > > > > > > > > > Many thanks for this. For us it will be fine if we can get a new > > > version > > > > of > > > > > wicket by the end of this week. > > > > > > > > > > > > > I agree ! this vote is cancelled > > > > > > > > > > > > > > > > > > On Tue, Apr 11, 2023 at 9:07 AM Thomas Heigl > > > > wrote: > > > > > > > > > > > I have one more small optimization: > > > > > > https://github.com/apache/wicket/pull/573 > > > > > > > > > > > > There are many more potential allocation improvements but those two > > > are > > > > > the > > > > > > lowest hanging fruit. > > > > > > > > > > > > On Tue, Apr 11, 2023 at 7:31 AM Maxim Solodovnik < > > > solomax...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > +1 to restart the VOTE with this optimization included :) > > > > > > > > > > > > > > On Mon, 10 Apr 2023 at 22:29, Thomas Heigl > > > > > wrote: > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > I know I'm a bit late, but I just discovered a way to reduce a > > > ton > > > > of > > > > > > > > allocations in our application: > > > > > > > > > > > > > > > > https://github.com/apache/wicket/pull/572 > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7041 > > > > > > > > > > > > > > > > Any chance we can wait for this change? The implementation is > > > > trivial > > > > > > and > > > > > > > > should reduce allocations for pretty much all users of Wicket. > > > > > > > > We just have to decide if we make the optimization the default > > > for > > > > > all > > > > > > > > `StringResponse`s or apply it case-by-case. > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > > > Thomas > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Apr 10, 2023 at 8:55 AM Maxim Solodovnik < > > > > > solomax...@gmail.com > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > Tested: > > > > > > > > > - signarures > > > > > > > > > - build from sources > > > > > > > > > - wicketstuff build > > > > > > > > > - our main app build and manual tests > > > > > > > > > > > > > > > > > > On Sat, 8 Apr 2023 at 13:
Re: [VOTE] Release Apache Wicket 9.13.0
This one https://issues.apache.org/jira/browse/WICKET-7044 Also meed to be addressed I'll try to take a look ASAP from mobile (sorry for typos ;) On Wed, Apr 12, 2023, 01:07 Thomas Heigl wrote: > I have backported the two improvements to 9.x. Thanks a lot for letting me > include these two PRs. > > We can continue with the release. > > On Tue, Apr 11, 2023 at 10:57 AM Andrea Del Bene > wrote: > > > On Tue, Apr 11, 2023 at 8:38 AM Ernesto Reinaldo Barreiro < > > reier...@gmail.com> wrote: > > > > > Many thanks for this. For us it will be fine if we can get a new > version > > of > > > wicket by the end of this week. > > > > > > > I agree ! this vote is cancelled > > > > > > > > > > On Tue, Apr 11, 2023 at 9:07 AM Thomas Heigl > > wrote: > > > > > > > I have one more small optimization: > > > > https://github.com/apache/wicket/pull/573 > > > > > > > > There are many more potential allocation improvements but those two > are > > > the > > > > lowest hanging fruit. > > > > > > > > On Tue, Apr 11, 2023 at 7:31 AM Maxim Solodovnik < > solomax...@gmail.com > > > > > > > wrote: > > > > > > > > > +1 to restart the VOTE with this optimization included :) > > > > > > > > > > On Mon, 10 Apr 2023 at 22:29, Thomas Heigl > > > wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > I know I'm a bit late, but I just discovered a way to reduce a > ton > > of > > > > > > allocations in our application: > > > > > > > > > > > > https://github.com/apache/wicket/pull/572 > > > > > > https://issues.apache.org/jira/browse/WICKET-7041 > > > > > > > > > > > > Any chance we can wait for this change? The implementation is > > trivial > > > > and > > > > > > should reduce allocations for pretty much all users of Wicket. > > > > > > We just have to decide if we make the optimization the default > for > > > all > > > > > > `StringResponse`s or apply it case-by-case. > > > > > > > > > > > > Best, > > > > > > > > > > > > Thomas > > > > > > > > > > > > > > > > > > On Mon, Apr 10, 2023 at 8:55 AM Maxim Solodovnik < > > > solomax...@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > Tested: > > > > > > > - signarures > > > > > > > - build from sources > > > > > > > - wicketstuff build > > > > > > > - our main app build and manual tests > > > > > > > > > > > > > > On Sat, 8 Apr 2023 at 13:37, Ernesto Reinaldo Barreiro > > > > > > > wrote: > > > > > > > > > > > > > > > > Many thanks for starting a vote! > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > On Fri, Apr 7, 2023 at 11:07 PM Andrea Del Bene < > > > > > an.delb...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > > > > > > > > > > > Please download the source distributions found in our > staging > > > > area > > > > > > > > > linked below. > > > > > > > > > > > > > > > > > > I have included the signatures for both the source > archives. > > > This > > > > > vote > > > > > > > > > lasts for 72 hours minimum. > > > > > > > > > > > > > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > > > > > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > > > > > > > > > > > > > Distributions, changelog, keys and signatures can be found > > at: > > > > > > > > > > > > > > > > > > https://dist.
Re: [VOTE] Release Apache Wicket 9.13.0
+1 to restart the VOTE with this optimization included :) On Mon, 10 Apr 2023 at 22:29, Thomas Heigl wrote: > > Hi all, > > I know I'm a bit late, but I just discovered a way to reduce a ton of > allocations in our application: > > https://github.com/apache/wicket/pull/572 > https://issues.apache.org/jira/browse/WICKET-7041 > > Any chance we can wait for this change? The implementation is trivial and > should reduce allocations for pretty much all users of Wicket. > We just have to decide if we make the optimization the default for all > `StringResponse`s or apply it case-by-case. > > Best, > > Thomas > > > On Mon, Apr 10, 2023 at 8:55 AM Maxim Solodovnik > wrote: > > > +1 > > > > Tested: > > - signarures > > - build from sources > > - wicketstuff build > > - our main app build and manual tests > > > > On Sat, 8 Apr 2023 at 13:37, Ernesto Reinaldo Barreiro > > wrote: > > > > > > Many thanks for starting a vote! > > > > > > +1 > > > > > > On Fri, Apr 7, 2023 at 11:07 PM Andrea Del Bene > > > wrote: > > > > > > > This is a vote to release Apache Wicket 9.13.0 > > > > > > > > Please download the source distributions found in our staging area > > > > linked below. > > > > > > > > I have included the signatures for both the source archives. This vote > > > > lasts for 72 hours minimum. > > > > > > > > [ ] Yes, release Apache Wicket 9.13.0 > > > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > > > > > Staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1178/ > > > > > > > > The binaries are available in the above link, as are a staging > > > > repository for Maven. Typically the vote is on the source, but should > > > > you find a problem with one of the binaries, please let me know, I can > > > > re-roll them some way or the other. > > > > > > > > Staging git repository data: > > > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > > Branch: build/wicket-9.13.0 > > > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > > > > > > > > > > > > > CHANGELOG for 9.13.0: > > > > > > > > > > > > ** Bug > > > > > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: Cannot inject > > > > already loaded type > > > > * [WICKET-7022] - JavaScriptStripper fails to detect regular > > > > expression correctly > > > > * [WICKET-7028] - CSP header not rendered when using > > > > RedirectPolicy.NEVER_REDIRECT > > > > * [WICKET-7034] - WebSocket.Closed event not fired when error > > occurred > > > > * [WICKET-7037] - [Ajax Download] cookie used to track download > > > > complete misses the SameSite attribute > > > > > > > > ** Improvement > > > > > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > > > * [WICKET-7014] - Use new API for forward compatibility with CDI 4 > > > > * [WICKET-7016] - Support GCM-SIV for page store encryption > > > > * [WICKET-7017] - ListenerRequestHandler should not hide > > > > IndexOutOfBoundsException > > > > * [WICKET-7021] - Additional OSGi import fixes > > > > * [WICKET-7025] - Package private methods should be proxied by > > > > ByteBuddy > > > > * [WICKET-7031] - Update to JQuery 3.6.4 > > > > * [WICKET-7032] - Update the JS tests to use latest version of > > > > QUnit (2.x) > > > > * [WICKET-7035] - fileCountMax should be added to control the > > > > amount of files being uploaded > > > > > > > > > > > > > > -- > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.13.0
+1 Tested: - signarures - build from sources - wicketstuff build - our main app build and manual tests On Sat, 8 Apr 2023 at 13:37, Ernesto Reinaldo Barreiro wrote: > > Many thanks for starting a vote! > > +1 > > On Fri, Apr 7, 2023 at 11:07 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 9.13.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 9.13.0 > > [ ] No, don't release Apache Wicket 9.13.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/9.13.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1178/ > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-9.13.0 > > Release tag: rel/wicket-9.13.0 > > > > > > > > > > CHANGELOG for 9.13.0: > > > > > > ** Bug > > > > * [WICKET-7005] - ByteBuddy IllegalStateException: Cannot inject > > already loaded type > > * [WICKET-7022] - JavaScriptStripper fails to detect regular > > expression correctly > > * [WICKET-7028] - CSP header not rendered when using > > RedirectPolicy.NEVER_REDIRECT > > * [WICKET-7034] - WebSocket.Closed event not fired when error occurred > > * [WICKET-7037] - [Ajax Download] cookie used to track download > > complete misses the SameSite attribute > > > > ** Improvement > > > > * [WICKET-7011] - Improve usage of JUnit 5.x APIs > > * [WICKET-7014] - Use new API for forward compatibility with CDI 4 > > * [WICKET-7016] - Support GCM-SIV for page store encryption > > * [WICKET-7017] - ListenerRequestHandler should not hide > > IndexOutOfBoundsException > > * [WICKET-7021] - Additional OSGi import fixes > > * [WICKET-7025] - Package private methods should be proxied by > > ByteBuddy > > * [WICKET-7031] - Update to JQuery 3.6.4 > > * [WICKET-7032] - Update the JS tests to use latest version of > > QUnit (2.x) > > * [WICKET-7035] - fileCountMax should be added to control the > > amount of files being uploaded > > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: time to release a new 9.x version?
10-m1 is a bit blocked by commons-fileupload I'll ping it's devs :) from mobile (sorry for typos ;) On Fri, Apr 7, 2023, 15:23 Richard Eckart de Castilho wrote: > +1 for a Wicket 9.x release > > ... and how about a Wicket 10.x Milestone release ;) > > Cheers, > > -- Richard > >
Re: time to release a new 9.x version?
It doesn't merged to master (yet) Please close it I'll do the merge later this week from mobile (sorry for typos ;) On Fri, Apr 7, 2023, 15:10 Andrea Del Bene wrote: > +1. WICKET-7035 <https://issues.apache.org/jira/browse/WICKET-7035> can be > closed , right? > > On Fri, Apr 7, 2023 at 8:34 AM Maxim Solodovnik > wrote: > > > +1 from me :) > > > > from mobile (sorry for typos ;) > > > > > > On Fri, Apr 7, 2023, 13:26 Ernesto Reinaldo Barreiro > > > wrote: > > > > > Can we start a new vote for releasing wicket 9.13.0? Any objections? > Any > > > other blockers? > > > > > > On Thu, Apr 6, 2023 at 1:06 PM Maxim Solodovnik > > > wrote: > > > > > > > https://github.com/apache/wicket/pull/570 > > > > > > > > On Thu, 6 Apr 2023 at 14:53, Maxim Solodovnik > > > > wrote: > > > > > > > > > > Some dependencies/plugins can be updated :) > > > > > I can do PR later this night > > > > > > > > > > but this is not a blocker :) > > > > > > > > > > On Thu, 6 Apr 2023 at 14:47, Ernesto Reinaldo Barreiro > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > On Wed, Apr 5, 2023 at 8:51 AM Maxim Solodovnik < > > > solomax...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > AFAIK WICKET-7028 is the only blocker > > > > > > > Maybe we can shift it to the next release to have more time for > > > > > > > investigation? > > > > > > > > > > > > > > > > > > > I have marked this issue. Any other objections/blockers for > 9.13.x? > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 5 Apr 2023 at 12:10, Ernesto Reinaldo Barreiro > > > > > > > wrote: > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > I saw that > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7028 > > > > > > > > > > > > > > > > is marked to be fixed on 9.13.0... But we will love to have a > > > > 9.13.0 out > > > > > > > > because we are in a ramp down fase for an internal release > and > > > we > > > > would > > > > > > > > like to have > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7037 > > > > > > > > > > > > > > > > included in our next internal release. > > > > > > > > > > > > > > > > -- > > > > > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Best regards, > > > > > > > Maxim > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Maxim > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Maxim > > > > > > > > > > > > > -- > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > Andrea Del Bene. > Apache Wicket committer. >
Re: time to release a new 9.x version?
+1 from me :) from mobile (sorry for typos ;) On Fri, Apr 7, 2023, 13:26 Ernesto Reinaldo Barreiro wrote: > Can we start a new vote for releasing wicket 9.13.0? Any objections? Any > other blockers? > > On Thu, Apr 6, 2023 at 1:06 PM Maxim Solodovnik > wrote: > > > https://github.com/apache/wicket/pull/570 > > > > On Thu, 6 Apr 2023 at 14:53, Maxim Solodovnik > > wrote: > > > > > > Some dependencies/plugins can be updated :) > > > I can do PR later this night > > > > > > but this is not a blocker :) > > > > > > On Thu, 6 Apr 2023 at 14:47, Ernesto Reinaldo Barreiro > > > wrote: > > > > > > > > Hi, > > > > > > > > On Wed, Apr 5, 2023 at 8:51 AM Maxim Solodovnik < > solomax...@gmail.com> > > > > wrote: > > > > > > > > > AFAIK WICKET-7028 is the only blocker > > > > > Maybe we can shift it to the next release to have more time for > > > > > investigation? > > > > > > > > > > > > > I have marked this issue. Any other objections/blockers for 9.13.x? > > > > > > > > > > > > > > > > > On Wed, 5 Apr 2023 at 12:10, Ernesto Reinaldo Barreiro > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > I saw that > > > > > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7028 > > > > > > > > > > > > is marked to be fixed on 9.13.0... But we will love to have a > > 9.13.0 out > > > > > > because we are in a ramp down fase for an internal release and > we > > would > > > > > > like to have > > > > > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7037 > > > > > > > > > > > > included in our next internal release. > > > > > > > > > > > > -- > > > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Maxim > > > > > > > > > > > > > > > > > -- > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: time to release a new 9.x version?
https://github.com/apache/wicket/pull/570 On Thu, 6 Apr 2023 at 14:53, Maxim Solodovnik wrote: > > Some dependencies/plugins can be updated :) > I can do PR later this night > > but this is not a blocker :) > > On Thu, 6 Apr 2023 at 14:47, Ernesto Reinaldo Barreiro > wrote: > > > > Hi, > > > > On Wed, Apr 5, 2023 at 8:51 AM Maxim Solodovnik > > wrote: > > > > > AFAIK WICKET-7028 is the only blocker > > > Maybe we can shift it to the next release to have more time for > > > investigation? > > > > > > > I have marked this issue. Any other objections/blockers for 9.13.x? > > > > > > > > > On Wed, 5 Apr 2023 at 12:10, Ernesto Reinaldo Barreiro > > > wrote: > > > > > > > > Hi, > > > > > > > > I saw that > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7028 > > > > > > > > is marked to be fixed on 9.13.0... But we will love to have a 9.13.0 out > > > > because we are in a ramp down fase for an internal release and we would > > > > like to have > > > > > > > > https://issues.apache.org/jira/browse/WICKET-7037 > > > > > > > > included in our next internal release. > > > > > > > > -- > > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > > > > -- > Best regards, > Maxim -- Best regards, Maxim
Re: time to release a new 9.x version?
Some dependencies/plugins can be updated :) I can do PR later this night but this is not a blocker :) On Thu, 6 Apr 2023 at 14:47, Ernesto Reinaldo Barreiro wrote: > > Hi, > > On Wed, Apr 5, 2023 at 8:51 AM Maxim Solodovnik > wrote: > > > AFAIK WICKET-7028 is the only blocker > > Maybe we can shift it to the next release to have more time for > > investigation? > > > > I have marked this issue. Any other objections/blockers for 9.13.x? > > > > > On Wed, 5 Apr 2023 at 12:10, Ernesto Reinaldo Barreiro > > wrote: > > > > > > Hi, > > > > > > I saw that > > > > > > https://issues.apache.org/jira/browse/WICKET-7028 > > > > > > is marked to be fixed on 9.13.0... But we will love to have a 9.13.0 out > > > because we are in a ramp down fase for an internal release and we would > > > like to have > > > > > > https://issues.apache.org/jira/browse/WICKET-7037 > > > > > > included in our next internal release. > > > > > > -- > > > Regards - Ernesto Reinaldo Barreiro > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
Re: time to release a new 9.x version?
AFAIK WICKET-7028 is the only blocker Maybe we can shift it to the next release to have more time for investigation? On Wed, 5 Apr 2023 at 12:10, Ernesto Reinaldo Barreiro wrote: > > Hi, > > I saw that > > https://issues.apache.org/jira/browse/WICKET-7028 > > is marked to be fixed on 9.13.0... But we will love to have a 9.13.0 out > because we are in a ramp down fase for an internal release and we would > like to have > > https://issues.apache.org/jira/browse/WICKET-7037 > > included in our next internal release. > > -- > Regards - Ernesto Reinaldo Barreiro -- Best regards, Maxim
[wicketstuff] drop Start.java in master
Hello All, It seems some wicketstuff-core sub-projects has Start.java in test/ It depends on jetty uber jar which seems to support jetty-9 only I would like to drop Start.java and jetty uber jar in master Please stop me if they are required :) -- Best regards, Maxim
Re: Time for Wicket M1?
from mobile (sorry for typos ;) On Thu, Feb 9, 2023, 18:03 Andrea Del Bene wrote: > Excuse my silly question but isn't ok for milestone version to depend on a > snapshot version (fileupload 2.0-SNAPSHOT)? > Unfortunately not :( The build will not be reproducible > On Thu, Feb 9, 2023 at 8:36 AM Emond Papegaaij > wrote: > > > Op do 9 feb. 2023 om 08:32 schreef Martin Grigorov >: > > > > > On Thu, Feb 9, 2023 at 9:16 AM Emond Papegaaij < > > emond.papega...@gmail.com> > > > wrote: > > > > > > > Op do 9 feb. 2023 om 07:47 schreef Martin Grigorov < > > mgrigo...@apache.org > > > >: > > > > > > > > > Please update > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+10.0 > > > > > that the Component Queueing is gone > > > > > > > > > > Before releasing M1 I think we need to: > > > > > 1) update all dependencies to their latest stable version > > > > > 2) copy over commons-fileupload2 classes to wicket-util or a new > > Maven > > > > > module > > > > > > > > > > > > > What about shading the classes in an internal package? I'm a bit > > > concerned > > > > with having to cope with different classes with the same fqcn when > some > > > > other dependency also pulls in commons-fileupload. > > > > > > > > > > I am not sure whether Maven would be happy to use a -SNAPSHOT for the > > > shading process when making a release. If you mean maven-shade-plugin. > > > Doing it manually should work! > > > > > > > Yes, releasing against a SNAPSHOT version is not a very good idea, even > if > > shaded. That will give issues trying to rebuild a certain version if > > something has changed. Copy-pasting and changing the package should be > ok. > > > > Best regards, > > Emond > > > > > -- > Andrea Del Bene. > Apache Wicket committer. >
Re: Time for Wicket M1?
+1 :) from mobile (sorry for typos ;) On Thu, Feb 9, 2023, 05:41 Andrea Del Bene wrote: > On Wed, Feb 8, 2023, 8:31 PM Sven Meier wrote: > > > I've removed queuing on branch > > https://github.com/apache/wicket/tree/remove-queuing > > Still ready to be merged. > > > > We agreed to remove it from Wicket 10, didn't we? > > > > the hell "yes" :-) > > Sven > > > > > > On 08.02.23 12:54, Ernesto Reinaldo Barreiro wrote: > > > No idea. There was some effort (by Sven) to remove component > queueing... > > No > > > idea if that landed on the master branch? > > > > > > On Wed, Feb 8, 2023 at 1:03 PM Andrea Del Bene > > wrote: > > > > > >> Hi, > > >> > > >> I've seen that lately there have been some activities and questions > > related > > >> to Wicket 10. Although we have some pending issues before proposing a > > >> release candidate, I think it's the right time for a first milestone > > >> release. What do you think? > > >> > > >> -- > > >> Andrea Del Bene. > > >> Apache Wicket committer. > > >> > > > > > >
Re: Time for Wicket M1?
Afaik the only blocker for m1 is fileupload2 ... from mobile (sorry for typos ;) On Wed, Feb 8, 2023, 18:55 Ernesto Reinaldo Barreiro wrote: > No idea. There was some effort (by Sven) to remove component queueing... No > idea if that landed on the master branch? > > On Wed, Feb 8, 2023 at 1:03 PM Andrea Del Bene > wrote: > > > Hi, > > > > I've seen that lately there have been some activities and questions > related > > to Wicket 10. Although we have some pending issues before proposing a > > release candidate, I think it's the right time for a first milestone > > release. What do you think? > > > > -- > > Andrea Del Bene. > > Apache Wicket committer. > > > > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: CI for wicketstuff
I've added credentials seems to work (with some exceptions) :) On Fri, 18 Feb 2022 at 15:39, Martijn Dashorst wrote: > > I did not find any... > > Martijn > > > On Fri, Feb 11, 2022 at 6:49 AM Maxim Solodovnik > wrote: > > > Hello Martijn, > > > > were you able to find credentials? :) > > I can try to add my personal login/password > > > > I believe SNAPSHOTs are very useful :) > > > > On Wed, 19 Jan 2022 at 15:12, Martijn Dashorst > > wrote: > > > > > > IIRC all our secrets are in the wicket-pmc's private repository. I'm > > trying > > > to find the coordinates but I am unable to find them. > > > > > > Martijn > > > > > > > > > On Fri, Jan 14, 2022 at 10:55 PM Martin Grigorov > > > wrote: > > > > > > > I've merged the PR! > > > > > > > > But it failed because there are no env vars/secrets for deploying to > > > > oss.sonatype.org > > > > Travis was using > > > > > > > > > > https://github.com/wicketstuff/core/blob/b3f84bb0f49f1ebee8eec5100cb31b22176d5a4b/.travis.yml#L22-L26 > > > > If anyone knows what were those credentials then please set them up at > > > > https://github.com/wicketstuff/core/settings/secrets/actions with > > names > > > > CI_DEPLOY_USERNAME and CI_DEPLOY_PASSWORD ( > > > > > > > > > > https://github.com/wicketstuff/core/blob/b3f84bb0f49f1ebee8eec5100cb31b22176d5a4b/.github/workflows/ci.yml#L54-L56 > > > > ) > > > > Otherwise we could run just 'mvn verify' > > > > > > > > On Fri, Jan 14, 2022 at 9:51 AM Martin Grigorov > > > > wrote: > > > > > > > > > > > > > > > > > > > On Fri, Jan 14, 2022 at 9:32 AM Maxim Solodovnik < > > solomax...@gmail.com> > > > > > wrote: > > > > > > > > > >> On Thu, 13 Jan 2022 at 10:29, Maxim Solodovnik < > > solomax...@gmail.com> > > > > >> wrote: > > > > >> > > > > > >> > I'm +1 for any solution :) > > > > >> > I can ask INFRA if we can use Jenkins :) > > > > >> > > > > > >> > On Thu, 13 Jan 2022 at 02:47, Martin Grigorov < > > mgrigo...@apache.org> > > > > >> wrote: > > > > >> > > > > > > >> > > Shall we move to Github Actions ? > > > > >> > > > > >> Are you familiar with "Github Actions" > > > > >> Maybe you can set it up and we will see how it will suit our needs > > :) > > > > >> > > > > > > > > > > No problemo! :-) > > > > > > > > > > > > > > >> > > > > >> > > TravisCI degrades day by day :-( > > > > >> > > CircleCI is also a very good alternative! > > > > >> > > > > > > >> > > On Wed, Jan 12, 2022 at 6:52 PM Maxim Solodovnik < > > > > >> solomax...@gmail.com> > > > > >> > > wrote: > > > > >> > > > > > > >> > > > Hello All, > > > > >> > > > > > > > >> > > > Maybe you know what is the current status of CI for > > wicketstuff > > > > >> > > > > > > > >> > > > I was unable to find latest snapshot > > > > >> > > > And the job at travis-ci.com :( > > > > >> > > > > > > > >> > > > from mobile (sorry for typos ;) > > > > >> > > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > -- > > > > >> > Best regards, > > > > >> > Maxim > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Best regards, > > > > >> Maxim > > > > >> > > > > > > > > > > > > > > > > > > -- > > > Become a Wicket expert, learn from the best: http://wicketinaction.com > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com -- Best regards, Maxim
Re: wicket-10 spring bean injection
https://issues.apache.org/jira/browse/WICKET-7025 On Sat, 14 Jan 2023 at 12:16, Maxim Solodovnik wrote: > > It seems this line > > https://github.com/apache/wicket/blob/master/wicket-ioc/src/main/java/org/apache/wicket/proxy/bytebuddy/ByteBuddyProxyFactory.java#L109 > > Should be tweaked :) > > from mobile (sorry for typos ;) > > > On Fri, Jan 13, 2023, 23:02 Maxim Solodovnik wrote: >> >> Hello Thomas, >> >> here it is: https://github.com/solomax/ajax-download >> `git clone ...` >> `mvn clean jetty:run` >> >> go to http://localhost:8080 >> >> there are 2 bittons: >> "Spring package private" >> "Spring public" >> >> One works. another one results NPE (and for whatever reason weird >> java.lang.NoClassDefFoundError under jetty (no such errors under >> tomcat) >> >> In case you will change true->false >> https://github.com/solomax/ajax-download/blob/master/src/main/java/org/apache/WicketApplication.java#L42 >> >> Both buttons will work >> But there will be serialization errors >> >> same code works with wicket 9 (tested with our main app, haven't test >> this quick start) >> >> On Fri, 13 Jan 2023 at 18:52, Thomas Matthijs wrote: >> > >> > If you can make a small project on github that can reproduce it, wouldn't >> > mind taking a look >> > >> > Regards >> > >> > On Fri, Jan 13, 2023, at 12:37, Maxim Solodovnik wrote: >> > > How to check why ByteBuddyInterceptor.intercept is not being called >> > > for method call? >> > > (the method is package private, not sure if this is important ...) >> > > >> > > On Fri, 13 Jan 2023 at 17:30, Maxim Solodovnik >> > > wrote: >> > >> >> > >> Lots of "java.io.NotSerializableException" in such case :((( >> > >> Have to check wrapInProxies code ... >> > >> >> > >> On Fri, 13 Jan 2023 at 17:20, Maxim Solodovnik >> > >> wrote: >> > >> > >> > >> > Thanks a lot! >> > >> > >> > >> > The problem was >> > >> > "getComponentInstantiationListeners().add(new >> > >> > SpringComponentInjector(this, ctx, true))" >> > >> > >> > >> > Works for me after changing to be >> > >> > "getComponentInstantiationListeners().add(new >> > >> > SpringComponentInjector(this, ctx, false))" >> > >> > >> > >> > investigating :) >> > >> > >> > >> > On Thu, 12 Jan 2023 at 23:46, Martin Grigorov >> > >> > wrote: >> > >> > > >> > >> > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik >> > >> > > wrote: >> > >> > > >> > >> > > > Hello All, >> > >> > > > >> > >> > > > It seems "Injector.get().inject(this);" doesn't work for me as >> > >> > > > expected >> > >> > > > >> > >> > > > The bean annotated with @Inject or @SpringBean is injected >> > >> > > > >> > >> > > >> > >> > > Here you say @Inject injects the proxy. >> > >> > > >> > >> > > (WicketProxy, via ByteBuddy but it differs from what is being >> > >> > > injected >> > >> > > > by Spring, and all @Inject/@Autowired fields are null :((( >> > >> > > > >> > >> > > >> > >> > > Here it is null... >> > >> > > Which one is correct? >> > >> > > >> > >> > > Or you mean the transitive dependencies are null? If this is the >> > >> > > case then >> > >> > > debug in SpringBeanLocator. It uses Spring APIs to load the real >> > >> > > bean. >> > >> > > >> > >> > > >> > >> > > >> > >> > > > What can I troubleshoot? >> > >> > > > >> > >> > > > -- >> > >> > > > Best regards, >> > >> > > > Maxim >> > >> > > > >> > >> > >> > >> > >> > >> > >> > >> > -- >> > >> > Best regards, >> > >> > Maxim >> > >> >> > >> >> > >> >> > >> -- >> > >> Best regards, >> > >> Maxim >> > > >> > > >> > > >> > > -- >> > > Best regards, >> > > Maxim >> >> >> >> -- >> Best regards, >> Maxim -- Best regards, Maxim
Re: wicket-10 spring bean injection
It seems this line https://github.com/apache/wicket/blob/master/wicket-ioc/src/main/java/org/apache/wicket/proxy/bytebuddy/ByteBuddyProxyFactory.java#L109 Should be tweaked :) from mobile (sorry for typos ;) On Fri, Jan 13, 2023, 23:02 Maxim Solodovnik wrote: > Hello Thomas, > > here it is: https://github.com/solomax/ajax-download > `git clone ...` > `mvn clean jetty:run` > > go to http://localhost:8080 > > there are 2 bittons: > "Spring package private" > "Spring public" > > One works. another one results NPE (and for whatever reason weird > java.lang.NoClassDefFoundError under jetty (no such errors under > tomcat) > > In case you will change true->false > > https://github.com/solomax/ajax-download/blob/master/src/main/java/org/apache/WicketApplication.java#L42 > > Both buttons will work > But there will be serialization errors > > same code works with wicket 9 (tested with our main app, haven't test > this quick start) > > On Fri, 13 Jan 2023 at 18:52, Thomas Matthijs wrote: > > > > If you can make a small project on github that can reproduce it, > wouldn't mind taking a look > > > > Regards > > > > On Fri, Jan 13, 2023, at 12:37, Maxim Solodovnik wrote: > > > How to check why ByteBuddyInterceptor.intercept is not being called > > > for method call? > > > (the method is package private, not sure if this is important ...) > > > > > > On Fri, 13 Jan 2023 at 17:30, Maxim Solodovnik > wrote: > > >> > > >> Lots of "java.io.NotSerializableException" in such case :((( > > >> Have to check wrapInProxies code ... > > >> > > >> On Fri, 13 Jan 2023 at 17:20, Maxim Solodovnik > wrote: > > >> > > > >> > Thanks a lot! > > >> > > > >> > The problem was > > >> > "getComponentInstantiationListeners().add(new > > >> > SpringComponentInjector(this, ctx, true))" > > >> > > > >> > Works for me after changing to be > > >> > "getComponentInstantiationListeners().add(new > > >> > SpringComponentInjector(this, ctx, false))" > > >> > > > >> > investigating :) > > >> > > > >> > On Thu, 12 Jan 2023 at 23:46, Martin Grigorov > wrote: > > >> > > > > >> > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik < > solomax...@gmail.com> wrote: > > >> > > > > >> > > > Hello All, > > >> > > > > > >> > > > It seems "Injector.get().inject(this);" doesn't work for me as > expected > > >> > > > > > >> > > > The bean annotated with @Inject or @SpringBean is injected > > >> > > > > > >> > > > > >> > > Here you say @Inject injects the proxy. > > >> > > > > >> > > (WicketProxy, via ByteBuddy but it differs from what is being > injected > > >> > > > by Spring, and all @Inject/@Autowired fields are null :((( > > >> > > > > > >> > > > > >> > > Here it is null... > > >> > > Which one is correct? > > >> > > > > >> > > Or you mean the transitive dependencies are null? If this is the > case then > > >> > > debug in SpringBeanLocator. It uses Spring APIs to load the real > bean. > > >> > > > > >> > > > > >> > > > > >> > > > What can I troubleshoot? > > >> > > > > > >> > > > -- > > >> > > > Best regards, > > >> > > > Maxim > > >> > > > > > >> > > > >> > > > >> > > > >> > -- > > >> > Best regards, > > >> > Maxim > > >> > > >> > > >> > > >> -- > > >> Best regards, > > >> Maxim > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > -- > Best regards, > Maxim >
Re: wicket-10 spring bean injection
Hello Thomas, here it is: https://github.com/solomax/ajax-download `git clone ...` `mvn clean jetty:run` go to http://localhost:8080 there are 2 bittons: "Spring package private" "Spring public" One works. another one results NPE (and for whatever reason weird java.lang.NoClassDefFoundError under jetty (no such errors under tomcat) In case you will change true->false https://github.com/solomax/ajax-download/blob/master/src/main/java/org/apache/WicketApplication.java#L42 Both buttons will work But there will be serialization errors same code works with wicket 9 (tested with our main app, haven't test this quick start) On Fri, 13 Jan 2023 at 18:52, Thomas Matthijs wrote: > > If you can make a small project on github that can reproduce it, wouldn't > mind taking a look > > Regards > > On Fri, Jan 13, 2023, at 12:37, Maxim Solodovnik wrote: > > How to check why ByteBuddyInterceptor.intercept is not being called > > for method call? > > (the method is package private, not sure if this is important ...) > > > > On Fri, 13 Jan 2023 at 17:30, Maxim Solodovnik wrote: > >> > >> Lots of "java.io.NotSerializableException" in such case :((( > >> Have to check wrapInProxies code ... > >> > >> On Fri, 13 Jan 2023 at 17:20, Maxim Solodovnik > >> wrote: > >> > > >> > Thanks a lot! > >> > > >> > The problem was > >> > "getComponentInstantiationListeners().add(new > >> > SpringComponentInjector(this, ctx, true))" > >> > > >> > Works for me after changing to be > >> > "getComponentInstantiationListeners().add(new > >> > SpringComponentInjector(this, ctx, false))" > >> > > >> > investigating :) > >> > > >> > On Thu, 12 Jan 2023 at 23:46, Martin Grigorov > >> > wrote: > >> > > > >> > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik > >> > > wrote: > >> > > > >> > > > Hello All, > >> > > > > >> > > > It seems "Injector.get().inject(this);" doesn't work for me as > >> > > > expected > >> > > > > >> > > > The bean annotated with @Inject or @SpringBean is injected > >> > > > > >> > > > >> > > Here you say @Inject injects the proxy. > >> > > > >> > > (WicketProxy, via ByteBuddy but it differs from what is being injected > >> > > > by Spring, and all @Inject/@Autowired fields are null :((( > >> > > > > >> > > > >> > > Here it is null... > >> > > Which one is correct? > >> > > > >> > > Or you mean the transitive dependencies are null? If this is the case > >> > > then > >> > > debug in SpringBeanLocator. It uses Spring APIs to load the real bean. > >> > > > >> > > > >> > > > >> > > > What can I troubleshoot? > >> > > > > >> > > > -- > >> > > > Best regards, > >> > > > Maxim > >> > > > > >> > > >> > > >> > > >> > -- > >> > Best regards, > >> > Maxim > >> > >> > >> > >> -- > >> Best regards, > >> Maxim > > > > > > > > -- > > Best regards, > > Maxim -- Best regards, Maxim
Re: wicket-10 spring bean injection
How to check why ByteBuddyInterceptor.intercept is not being called for method call? (the method is package private, not sure if this is important ...) On Fri, 13 Jan 2023 at 17:30, Maxim Solodovnik wrote: > > Lots of "java.io.NotSerializableException" in such case :((( > Have to check wrapInProxies code ... > > On Fri, 13 Jan 2023 at 17:20, Maxim Solodovnik wrote: > > > > Thanks a lot! > > > > The problem was > > "getComponentInstantiationListeners().add(new > > SpringComponentInjector(this, ctx, true))" > > > > Works for me after changing to be > > "getComponentInstantiationListeners().add(new > > SpringComponentInjector(this, ctx, false))" > > > > investigating :) > > > > On Thu, 12 Jan 2023 at 23:46, Martin Grigorov wrote: > > > > > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik wrote: > > > > > > > Hello All, > > > > > > > > It seems "Injector.get().inject(this);" doesn't work for me as expected > > > > > > > > The bean annotated with @Inject or @SpringBean is injected > > > > > > > > > > Here you say @Inject injects the proxy. > > > > > > (WicketProxy, via ByteBuddy but it differs from what is being injected > > > > by Spring, and all @Inject/@Autowired fields are null :((( > > > > > > > > > > Here it is null... > > > Which one is correct? > > > > > > Or you mean the transitive dependencies are null? If this is the case then > > > debug in SpringBeanLocator. It uses Spring APIs to load the real bean. > > > > > > > > > > > > > What can I troubleshoot? > > > > > > > > -- > > > > Best regards, > > > > Maxim > > > > > > > > > > > > -- > > Best regards, > > Maxim > > > > -- > Best regards, > Maxim -- Best regards, Maxim
Re: wicket-10 spring bean injection
Lots of "java.io.NotSerializableException" in such case :((( Have to check wrapInProxies code ... On Fri, 13 Jan 2023 at 17:20, Maxim Solodovnik wrote: > > Thanks a lot! > > The problem was > "getComponentInstantiationListeners().add(new > SpringComponentInjector(this, ctx, true))" > > Works for me after changing to be > "getComponentInstantiationListeners().add(new > SpringComponentInjector(this, ctx, false))" > > investigating :) > > On Thu, 12 Jan 2023 at 23:46, Martin Grigorov wrote: > > > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik wrote: > > > > > Hello All, > > > > > > It seems "Injector.get().inject(this);" doesn't work for me as expected > > > > > > The bean annotated with @Inject or @SpringBean is injected > > > > > > > Here you say @Inject injects the proxy. > > > > (WicketProxy, via ByteBuddy but it differs from what is being injected > > > by Spring, and all @Inject/@Autowired fields are null :((( > > > > > > > Here it is null... > > Which one is correct? > > > > Or you mean the transitive dependencies are null? If this is the case then > > debug in SpringBeanLocator. It uses Spring APIs to load the real bean. > > > > > > > > > What can I troubleshoot? > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > -- > Best regards, > Maxim -- Best regards, Maxim
Re: wicket-10 spring bean injection
Thanks a lot! The problem was "getComponentInstantiationListeners().add(new SpringComponentInjector(this, ctx, true))" Works for me after changing to be "getComponentInstantiationListeners().add(new SpringComponentInjector(this, ctx, false))" investigating :) On Thu, 12 Jan 2023 at 23:46, Martin Grigorov wrote: > > On Thu, Jan 12, 2023, 18:06 Maxim Solodovnik wrote: > > > Hello All, > > > > It seems "Injector.get().inject(this);" doesn't work for me as expected > > > > The bean annotated with @Inject or @SpringBean is injected > > > > Here you say @Inject injects the proxy. > > (WicketProxy, via ByteBuddy but it differs from what is being injected > > by Spring, and all @Inject/@Autowired fields are null :((( > > > > Here it is null... > Which one is correct? > > Or you mean the transitive dependencies are null? If this is the case then > debug in SpringBeanLocator. It uses Spring APIs to load the real bean. > > > > > What can I troubleshoot? > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Re: @Inject in wicket-10
Thanks :) On Thu, 12 Jan 2023 at 23:56, Martin Grigorov wrote: > > On Thu, Jan 12, 2023, 18:51 Maxim Solodovnik wrote: > > > The only place I was to find is > > > > org.apache.wicket.arquillian.testing.pages.ListContacts; > > > > Arqillian is not supported since a long time. It is not member of the Maven > reactor. > > > > On Thu, 12 Jan 2023 at 23:47, Martin Grigorov > > wrote: > > > > > > On Thu, Jan 12, 2023, 18:43 Maxim Solodovnik > > wrote: > > > > > > > What about "import javax.annotation.Resource;" ? > > > > > > > > > > Do we use/support it?! > > > > > > > > > > On Thu, 12 Jan 2023 at 23:41, Martin Grigorov > > > > wrote: > > > > > > > > > > Do it! > > > > > > > > > > On Thu, Jan 12, 2023, 17:33 Maxim Solodovnik > > > > wrote: > > > > > > > > > > > Hello All, > > > > > > > > > > > > Am I right thinking "import javax.inject.Inject;" should be > > replaced > > > > > > with "import jakarta.inject.Inject;"? > > > > > > > > > > > > Shall I do it in "master" branch of wicket? (My IDE reports "17 > > > > > > results in 14 files") > > > > > > > > > > > > -- > > > > > > Best regards, > > > > > > Maxim > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Maxim > > > > > > > > > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Re: @Inject in wicket-10
The only place I was to find is org.apache.wicket.arquillian.testing.pages.ListContacts; On Thu, 12 Jan 2023 at 23:47, Martin Grigorov wrote: > > On Thu, Jan 12, 2023, 18:43 Maxim Solodovnik wrote: > > > What about "import javax.annotation.Resource;" ? > > > > Do we use/support it?! > > > > On Thu, 12 Jan 2023 at 23:41, Martin Grigorov > > wrote: > > > > > > Do it! > > > > > > On Thu, Jan 12, 2023, 17:33 Maxim Solodovnik > > wrote: > > > > > > > Hello All, > > > > > > > > Am I right thinking "import javax.inject.Inject;" should be replaced > > > > with "import jakarta.inject.Inject;"? > > > > > > > > Shall I do it in "master" branch of wicket? (My IDE reports "17 > > > > results in 14 files") > > > > > > > > -- > > > > Best regards, > > > > Maxim > > > > > > > > > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
Re: @Inject in wicket-10
What about "import javax.annotation.Resource;" ? On Thu, 12 Jan 2023 at 23:41, Martin Grigorov wrote: > > Do it! > > On Thu, Jan 12, 2023, 17:33 Maxim Solodovnik wrote: > > > Hello All, > > > > Am I right thinking "import javax.inject.Inject;" should be replaced > > with "import jakarta.inject.Inject;"? > > > > Shall I do it in "master" branch of wicket? (My IDE reports "17 > > results in 14 files") > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
wicket-10 spring bean injection
Hello All, It seems "Injector.get().inject(this);" doesn't work for me as expected The bean annotated with @Inject or @SpringBean is injected (WicketProxy, via ByteBuddy but it differs from what is being injected by Spring, and all @Inject/@Autowired fields are null :((( What can I troubleshoot? -- Best regards, Maxim
@Inject in wicket-10
Hello All, Am I right thinking "import javax.inject.Inject;" should be replaced with "import jakarta.inject.Inject;"? Shall I do it in "master" branch of wicket? (My IDE reports "17 results in 14 files") -- Best regards, Maxim
Re: Release Wicket 10.0.0-M1?
According to this: https://lists.apache.org/thread/22ro2qbstmrhrdq92g370kdsgf3fpfv2 There should be release soon :) from mobile (sorry for typos ;) On Sat, Dec 17, 2022, 01:38 Martin Grigorov wrote: > Maybe copy the commons-file upload classes in a new Maven module? > > On Fri, Dec 16, 2022, 17:07 Thomas Heigl wrote: > > > Hi, > > > > There doesn't seem to be any progress with commons-fileupload. Should we > > start exploring other options? Or should we try to push some more on the > > JIRA? > > > > I'm still blocked by one other dependency (Apache Shiro) but they are > close > > to releasing Jakarta artifacts. > > > > Best, > > > > Thomas > > > > > > On Tue, Apr 19, 2022 at 9:27 PM Martin Grigorov > > wrote: > > > > > On Tue, Apr 19, 2022 at 2:42 PM Thomas Heigl > > wrote: > > > > > > > OK I just saw that Martin already asked them to do a release in > > > > > > https://issues.apache.org/jira/projects/FILEUPLOAD/issues/FILEUPLOAD-309 > > > . > > > > > > > > > > 1 year ago ... > > > I see you JIRA voted for the issue. I think no one cares about the > number > > > of votes. Better add a comment! Comments go to the mailing list and the > > > maintainers are notified. > > > > > > > > > > > > > > > > > On Tue, Apr 19, 2022 at 1:35 PM Thomas Heigl > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > I started migrating our app to the new Jakarta APIs. Wicket is the > > only > > > > > dependency that doesn't yet have a pre-release. Is there anything > > > > > preventing us from releasing 10.0.0-M1? > > > > > > > > > > Is the SNAPSHOT dependency on commons-fileupload the only remaining > > > > issue? > > > > > If so, we should probably ask them to create a release candidate. > > > > > > > > > > Best, > > > > > > > > > > Thomas > > > > > > > > > > > > > > >
[ANNOUNCE] WicketStuff 9.12.0 Released
WicketStuff core 9.12.0 based on Apache Wicket 9.12.0 is released and soon will be available at Maven Central! Maxim Solodovnik (7): Switching to the next development version Jetty and Spring are updated Dependencies are updated Dependencies are updated .vscode is added to .gitignore Dependencies are updated wicketstuff-core-9.12.0 is released dependabot[bot] (1): Bump protobuf-java from 3.19.3 to 3.19.6 (#733) rkurucz9 (1): [wicketstuff-input-events] 'disable_in_input' would handle the contenteditable="true" attribute (#731) The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.12.0
+1
Tested:
- signarures
- build from sources
- wicketstuff build
- some wicketstuff examples
On Wed, 12 Oct 2022 at 00:06, Andrea Del Bene wrote:
>
> This is a vote to release Apache Wicket 9.12.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 9.12.0
> [ ] No, don't release Apache Wicket 9.12.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/9.12.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1177
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
> Repository: g...@github.com:bitstorm/wicket.git
> Branch: build/wicket-9.12.0
> Release tag: rel/wicket-9.12.0
>
>
>
>
> CHANGELOG for 9.12.0:
>
> ** Bug
>
> * [WICKET-6955] - Wicket uses unstable slf4j version
> * [WICKET-6996] - NotSerializableException near
> KeyInSessionSunJceCryptFactory
> * [WICKET-6999] - Missing Export-Package of packages with
> "internal" in name
> * [WICKET-7007] - Code snippets for CSRF documentation fixing
>
> ** Improvement
>
> * [WICKET-6958] - Allow to use Slf4j 1.7.x in OSGi runtime
> * [WICKET-6982] - Unnecessary initialization of stateful pages in
> ListenerRequestHandler
> * [WICKET-6998] - Bump slf4j-api to 2.0.0
> * [WICKET-7000] - ParseException ("Malformed tag") if
Re: Time for 9.12.0?
+1 from mobile (sorry for typos ;) On Wed, Sep 14, 2022, 10:36 Tobias Soloschenko wrote: > +1 > > kind regards > > Tobias > > > Am 13.09.2022 um 22:19 schrieb Thomas Heigl : > > > > +1 > > > >> On Tue, Sep 13, 2022 at 1:14 PM Andrea Del Bene > >> wrote: > >> > >> Looks like we have enough material to promote a new release. WDYT? > >> > >> -- > >> Andrea Del Bene. > >> Apache Wicket committer. > >> >
[ANNOUNCE] WicketStuff 9.11.0 Released
WicketStuff core 9.11.0 based on Apache Wicket 9.11.0 is released and soon will be available at Maven Central! Maxim Solodovnik (3): Switching to the next development version Dependencies are updated and organized wicketstuff-core 9.11.0 is released The WicketStuff team
[ANNOUNCE] WicketStuff 9.10.0 Released
WicketStuff core 9.10.0 based on Apache Wicket 9.10.0 is released and soon will be available at Maven Central! Maxim Solodovnik (3): Switching to the next development version Dependencies are updated wicketstuff-core-9.10.0 is released The WicketStuff team
Re: [DISCUSSION] Shall we clean-up git branches?
Done :) 40 branches remain I believe branches of closed PRs can also be dropped any objections? :)) On Thu, 28 Apr 2022 at 15:27, Andrea Del Bene wrote: > > I agree. Deleting 2 years older branches is ok. > > On Thu, Apr 28, 2022 at 9:01 AM Maxim Solodovnik > wrote: > > > Maybe we can drop all branches older than 2 years ago? :) > > > > On Thu, 28 Apr 2022 at 13:30, Maxim Solodovnik > > wrote: > > > > > > Merged are dropped > > > 121 branch remains :) > > > > > > On Thu, 28 Apr 2022 at 12:54, Martin Grigorov > > wrote: > > > > > > > > Hi, > > > > > > > > Easy win is to delete all branches which are already merged. > > > > The next step is to review the "closed" ones. > > > > > > > > On Thu, Apr 28, 2022 at 5:55 AM Maxim Solodovnik > > > > > > wrote: > > > > > > > > > Hello All, > > > > > > > > > > Currently we have 130 git branches: > > > > > https://github.com/apache/wicket/branches > > > > > Maybe we can perform clean-up? :)) > > > > > > > > > > -- > > > > > Best regards, > > > > > Maxim > > > > > > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > > -- > > Best regards, > > Maxim > > > > > -- > Andrea Del Bene. > Apache Wicket committer. -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.10.0
+1 tested: - signatures - local build - wicketstuff build - couple wicketstuff examples On Tue, 3 May 2022 at 18:23, Thomas Heigl wrote: > > +1. > > I deployed this release to production yesterday and have not noticed any > issues so far. > > On Sun, May 1, 2022 at 12:38 PM Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 9.10.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 9.10.0 > > [ ] No, don't release Apache Wicket 9.10.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/9.10.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1175/ > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-9.10.0 > > Release tag: rel/wicket-9.10.0 > > > > > > > > > > CHANGELOG for 9.10.0: > > > > ** Bug > > > > * [WICKET-6970] - Unnecessary string building in > > AssociatedMarkupSourcingStrategy > > * [WICKET-6971] - NullPointerException in ModificationWatcher > > * [WICKET-6974] - JavaxUpgradeHttpRequest returns an empty contextPath > > * [WICKET-6975] - Behavior.renderHead may be called multiple times > > > > ** Improvement > > > > * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy > > * [WICKET-6967] - allow to send non-blocking web socket messages > > * [WICKET-6969] - allow to process web socket push messages in an > > asynchronous way. > > * [WICKET-6972] - Add Resource key to be logged on Warning in > > Localizer.java > > * [WICKET-6976] - Reduce allocations when writing synthetic closing > > tags > > * [WICKET-6977] - hashCode computations generate excessive garbage > > objects > > > > -- Best regards, Maxim
Re: Release Wicket 9.10.0?
+1 from mobile (sorry for typos ;) On Fri, Apr 29, 2022, 20:28 Ernesto Reinaldo Barreiro wrote: > There was some additional issue that missed the fix version > > https://issues.apache.org/jira/browse/WICKET-6969 > > Now this is included in release too > > On Fri, Apr 29, 2022 at 7:16 AM Thomas Heigl wrote: > > > Hi all, > > > > What do you think about releasing Wicket 9.10.0? > > > > https://issues.apache.org/jira/projects/WICKET/versions/12351540 > > > > I'd very much like to roll out all the recent allocation improvements. > > > > Best, > > > > Thomas > > > > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: [DISCUSSION] Shall we clean-up git branches?
Sure :) wicket-* should leave forever :) from mobile (sorry for typos ;) On Thu, Apr 28, 2022, 15:08 Korbinian Bachl wrote: > I wouldn't drop any of the wicket-x.x branches as these were the releases > and imagine you had to use wicket 1.4 in an old app and need a fix asap? > > > - Ursprüngliche Mail - > > Von: "Maxim Solodovnik" > > An: "dev" > > Gesendet: Donnerstag, 28. April 2022 09:01:09 > > Betreff: Re: [DISCUSSION] Shall we clean-up git branches? > > > Maybe we can drop all branches older than 2 years ago? :) > > > > On Thu, 28 Apr 2022 at 13:30, Maxim Solodovnik wrote: > >> > >> Merged are dropped > >> 121 branch remains :) > >> > >> On Thu, 28 Apr 2022 at 12:54, Martin Grigorov wrote: > >> > > >> > Hi, > >> > > >> > Easy win is to delete all branches which are already merged. > >> > The next step is to review the "closed" ones. > >> > > >> > On Thu, Apr 28, 2022 at 5:55 AM Maxim Solodovnik > >> > wrote: > >> > > >> > > Hello All, > >> > > > >> > > Currently we have 130 git branches: > >> > > https://github.com/apache/wicket/branches > >> > > Maybe we can perform clean-up? :)) > >> > > > >> > > -- > >> > > Best regards, > >> > > Maxim > >> > > > >> > >> > >> > >> -- > >> Best regards, > >> Maxim > > > > > > > > -- > > Best regards, > > Maxim >
Re: [DISCUSSION] Shall we clean-up git branches?
Maybe we can drop all branches older than 2 years ago? :) On Thu, 28 Apr 2022 at 13:30, Maxim Solodovnik wrote: > > Merged are dropped > 121 branch remains :) > > On Thu, 28 Apr 2022 at 12:54, Martin Grigorov wrote: > > > > Hi, > > > > Easy win is to delete all branches which are already merged. > > The next step is to review the "closed" ones. > > > > On Thu, Apr 28, 2022 at 5:55 AM Maxim Solodovnik > > wrote: > > > > > Hello All, > > > > > > Currently we have 130 git branches: > > > https://github.com/apache/wicket/branches > > > Maybe we can perform clean-up? :)) > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > -- > Best regards, > Maxim -- Best regards, Maxim
Re: [DISCUSSION] Shall we clean-up git branches?
Merged are dropped 121 branch remains :) On Thu, 28 Apr 2022 at 12:54, Martin Grigorov wrote: > > Hi, > > Easy win is to delete all branches which are already merged. > The next step is to review the "closed" ones. > > On Thu, Apr 28, 2022 at 5:55 AM Maxim Solodovnik > wrote: > > > Hello All, > > > > Currently we have 130 git branches: > > https://github.com/apache/wicket/branches > > Maybe we can perform clean-up? :)) > > > > -- > > Best regards, > > Maxim > > -- Best regards, Maxim
[DISCUSSION] Shall we clean-up git branches?
Hello All, Currently we have 130 git branches: https://github.com/apache/wicket/branches Maybe we can perform clean-up? :)) -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.9.1 Released
WicketStuff core 9.9.1 based on Apache Wicket 9.9.1 is released and soon will be available at Maven Central! Maxim Solodovnik (5): commons-io is updated push-* modules are dropped Dependencies and plugins are updated Dependencies are updated Wicketstuff-core 9.9.1 The WicketStuff team
Re: [VOTE] Release Apache Wicket 9.9.1
+1 - signatures - local build - main app On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: > > +1 > > Sven > > On 05.04.22 16:47, Tobias Soloschenko wrote: > > +1 > > > > kind regards > > > > Tobias > > > >> Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > >> > >> +1 > >> > >> Ran our CI build and repeated stress tests on our staging environment. > >> > >>> On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene > >>> wrote: > >>> > >>> This is a vote to release Apache Wicket 9.9.1 > >>> > >>> Please download the source distributions found in our staging area > >>> linked below. > >>> > >>> I have included the signatures for both the source archives. This vote > >>> lasts for 72 hours minimum. > >>> > >>> [ ] Yes, release Apache Wicket 9.9.1 > >>> [ ] No, don't release Apache Wicket 9.9.1, because ... > >>> > >>> Distributions, changelog, keys and signatures can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > >>> > >>> Staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1174/ > >>> > >>> The binaries are available in the above link, as are a staging > >>> repository for Maven. Typically the vote is on the source, but should > >>> you find a problem with one of the binaries, please let me know, I can > >>> re-roll them some way or the other. > >>> > >>> Staging git repository data: > >>> > >>> Repository: g...@github.com:bitstorm/wicket.git > >>> Branch: build/wicket-9.9.1 > >>> Release tag: rel/wicket-9.9.1 > >>> > >>> > >>> > >>> > >>> CHANGELOG for 9.9.1: > >>> > >>> ** Bug > >>> > >>> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > >>> * [WICKET-6965] - Memory leak in WicketEndpoint > >>> > >>> ** Improvement > >>> > >>> * [WICKET-6963] - (REVERTED) Use singletons for > >>> PanelMarkupSourcingStrategy > >>> -- Best regards, Maxim
Re: [DISSCUSSION] can we drop wicketstuff-pushd*
Dropped Thanks! :) On Sat, 2 Apr 2022 at 10:32, Tobias Soloschenko wrote: > +1 to remove > > kind regards > > Tobias > > > Am 01.04.2022 um 20:12 schrieb Ernesto Reinaldo Barreiro < > reier...@gmail.com>: > > > > +1 to remove > > > >> On Fri, Apr 1, 2022 at 12:51 AM Martin Grigorov > >> wrote: > >> > >> +1 to drop it! > >> > >> If someone uses it then (s)he can use the old releases and send a PR > later > >> to revive it! > >> > >> On Fri, Apr 1, 2022 at 5:20 AM Maxim Solodovnik > >> wrote: > >> > >>> Hello All, > >>> > >>> AFAIK these days push is available out-of-the-box via websockets > >>> Do we need all these components? > >>> > >>> If we do need them can anyone take a look at `push-cometd`? > >>> cometd-java-client/cometd-java-server seems to be changed a lot > >>> and the version we are currently using reported to be vulnerable: > >>> > >>> > >> > https://sbom.lift.sonatype.com/report/T1-a0368c8f29fdaa555824-83a6cd82eac598-1648715554-9fa6855eebd24639bf9f6239d6d95ddf > >>> > >>> WDYT? :)) > >>> > >>> -- > >>> Best regards, > >>> Maxim > >>> > >> > > > > > > -- > > Regards - Ernesto Reinaldo Barreiro > -- Best regards, Maxim
[DISSCUSSION] can we drop wicketstuff-pushd*
Hello All, AFAIK these days push is available out-of-the-box via websockets Do we need all these components? If we do need them can anyone take a look at `push-cometd`? cometd-java-client/cometd-java-server seems to be changed a lot and the version we are currently using reported to be vulnerable: https://sbom.lift.sonatype.com/report/T1-a0368c8f29fdaa555824-83a6cd82eac598-1648715554-9fa6855eebd24639bf9f6239d6d95ddf WDYT? :)) -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.9.0 Released
WicketStuff core 9.9.0 based on Apache Wicket 9.9.0 is released and soon will be available at Maven Central! Maxim Solodovnik (3): Switching to the next development version Dependencies are updated wicketstuff core 9.9.0 is released The WicketStuff team
Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?
It seems I should cancel wicketstuff build :(( On Thu, 31 Mar 2022 at 15:14, Thomas Heigl wrote: > I think we will have to revert WICKET-6963. > > I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed > in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton > strategy doesn't work. > > Thomas > > On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl wrote: > > > This is probably caused by my change in > > https://issues.apache.org/jira/browse/WICKET-6963 > > > > I have been using this code in production for a couple of weeks now > > without issues, but there seem to be cases where the singleton strategy > > doesn't work. > > > > Can you reproduce this issue in a test-case? > > > > Thomas > > > > On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik > > wrote: > > > >> " tags are only allowed before , , > >> > >> etc. tag" > >> sounds reasonable :) > >> > >> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl < > >> korbinian.ba...@whiskyworld.de> wrote: > >> > >> > Hi, > >> > > >> > I deployed our app on 9.9.0 this morning and after initializing a > crawl > >> of > >> > the page I ended up getting a low quote of 503s. > >> > > >> > The 503s are always the same: > >> > 2022-03-31 09:35:05,031 ERROR > [org.apache.wicket.DefaultExceptionMapper] > >> > Unexpected error occurred > >> > org.apache.wicket.markup.MarkupException: tags are only > >> > allowed before , , etc. tag > >> > at > >> > > >> > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341) > >> > ~[wicket-core-9.9.0.jar:9.9.0] > >> > at > >> > > >> > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236) > >> > ~[wicket-core-9.9.0.jar:9.9.0] > >> > at > >> > > >> > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204) > >> > ~[wicket-core-9.9.0.jar:9.9.0] > >> > at > >> > org.apache.wicket.Component.internalRenderHead(Component.java:2649) > >> > ~[wicket-core-9.9.0.jar:9.9.0] > >> > > >> > at > >> > > >> > org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569) > >> > [nucleus-grizzly-all.jar:?] at > >> > > >> > org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549) > >> > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) > >> [?:?] > >> > > >> > Any idea how to debug this or where it may come from (race condition > in > >> > our code as wicket became faster?)? > >> > It somehow seems to be a happen when requests coming in at the same > >> > time with 9.8.0 we got no such errors. > >> > > >> > Best, > >> > > >> > KB > >> > > >> > > >> > > >> > > >> > >> -- > >> Best regards, > >> Maxim > >> > > > -- Best regards, Maxim
Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?
" tags are only allowed before , , etc. tag" sounds reasonable :) On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl < korbinian.ba...@whiskyworld.de> wrote: > Hi, > > I deployed our app on 9.9.0 this morning and after initializing a crawl of > the page I ended up getting a low quote of 503s. > > The 503s are always the same: > 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper] > Unexpected error occurred > org.apache.wicket.markup.MarkupException: tags are only > allowed before , , etc. tag > at > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341) > ~[wicket-core-9.9.0.jar:9.9.0] > at > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236) > ~[wicket-core-9.9.0.jar:9.9.0] > at > org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204) > ~[wicket-core-9.9.0.jar:9.9.0] > at > org.apache.wicket.Component.internalRenderHead(Component.java:2649) > ~[wicket-core-9.9.0.jar:9.9.0] > > at > org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569) > [nucleus-grizzly-all.jar:?] at > org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549) > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) [?:?] > > Any idea how to debug this or where it may come from (race condition in > our code as wicket became faster?)? > It somehow seems to be a happen when requests coming in at the same > time with 9.8.0 we got no such errors. > > Best, > > KB > > > > -- Best regards, Maxim
Re: CI for wicketstuff
Hello Martijn, were you able to find credentials? :) I can try to add my personal login/password I believe SNAPSHOTs are very useful :) On Wed, 19 Jan 2022 at 15:12, Martijn Dashorst wrote: > > IIRC all our secrets are in the wicket-pmc's private repository. I'm trying > to find the coordinates but I am unable to find them. > > Martijn > > > On Fri, Jan 14, 2022 at 10:55 PM Martin Grigorov > wrote: > > > I've merged the PR! > > > > But it failed because there are no env vars/secrets for deploying to > > oss.sonatype.org > > Travis was using > > > > https://github.com/wicketstuff/core/blob/b3f84bb0f49f1ebee8eec5100cb31b22176d5a4b/.travis.yml#L22-L26 > > If anyone knows what were those credentials then please set them up at > > https://github.com/wicketstuff/core/settings/secrets/actions with names > > CI_DEPLOY_USERNAME and CI_DEPLOY_PASSWORD ( > > > > https://github.com/wicketstuff/core/blob/b3f84bb0f49f1ebee8eec5100cb31b22176d5a4b/.github/workflows/ci.yml#L54-L56 > > ) > > Otherwise we could run just 'mvn verify' > > > > On Fri, Jan 14, 2022 at 9:51 AM Martin Grigorov > > wrote: > > > > > > > > > > > On Fri, Jan 14, 2022 at 9:32 AM Maxim Solodovnik > > > wrote: > > > > > >> On Thu, 13 Jan 2022 at 10:29, Maxim Solodovnik > > >> wrote: > > >> > > > >> > I'm +1 for any solution :) > > >> > I can ask INFRA if we can use Jenkins :) > > >> > > > >> > On Thu, 13 Jan 2022 at 02:47, Martin Grigorov > > >> wrote: > > >> > > > > >> > > Shall we move to Github Actions ? > > >> > > >> Are you familiar with "Github Actions" > > >> Maybe you can set it up and we will see how it will suit our needs :) > > >> > > > > > > No problemo! :-) > > > > > > > > >> > > >> > > TravisCI degrades day by day :-( > > >> > > CircleCI is also a very good alternative! > > >> > > > > >> > > On Wed, Jan 12, 2022 at 6:52 PM Maxim Solodovnik < > > >> solomax...@gmail.com> > > >> > > wrote: > > >> > > > > >> > > > Hello All, > > >> > > > > > >> > > > Maybe you know what is the current status of CI for wicketstuff > > >> > > > > > >> > > > I was unable to find latest snapshot > > >> > > > And the job at travis-ci.com :( > > >> > > > > > >> > > > from mobile (sorry for typos ;) > > >> > > > > > >> > > > >> > > > >> > > > >> > -- > > >> > Best regards, > > >> > Maxim > > >> > > >> > > >> > > >> -- > > >> Best regards, > > >> Maxim > > >> > > > > > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com -- Best regards, Maxim
[ANNOUNCE] WicketStuff 9.8.0 Released
WicketStuff core 9.8.0 based on Apache Wicket 9.8.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (11): Switching to the next development version [dashboard] proper way of RTL detection, jquery-ui is updated Merge branch 'master' of github.com:wicketstuff/core Dependencies are updated protobuf-java moved to dependencyManagement and updated Merge branch 'master' of github.com:wicketstuff/core POI is updated Merge branch 'master' of github.com:wicketstuff/core Dependencies are updated wicketstuff-jwicket-ui* are dropped wicketstuff-core-9.8.0 is released dependabot[bot] (7): Bump log4j-core (#716) Bump log4j-core from 2.16.0 to 2.17.0 (#717) Bump log4j-core (#718) Bump log4j-core from 2.17.0 to 2.17.1 (#719) Bump spring-core from 5.3.13 to 5.3.14 (#720) Bump hazelcast in /datastores-parent/datastore-hazelcast (#723) Bump xstream from 1.4.18 to 1.4.19 (#724) Martin Grigorov (1): Use Github Actions as CI (#722) Martin Tzvetanov Grigorov (1): Add Github Actions CI config The WicketStuff team
[ANNOUNCE] WicketStuff 8.14.0 Released
WicketStuff core 8.14.0 based on Apache Wicket 8.14.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (3): Switching to the next development version Dependencies are updated wicketstuff-core 8.14.0 is released The WicketStuff team
Re: new 9.8.0 release
+1 from mobile (sorry for typos ;) On Fri, Jan 28, 2022, 06:09 Ernesto Reinaldo Barreiro wrote: > Hi, > > In our application we are heavily using web-sockets, we are 9.x based, and > we need to release a new version in 3/4 weeks. We would like if possible to > go with 9.8.0 because of > > https://issues.apache.org/jira/browse/WICKET-6944 > > WDYT? > > -- > Regards - Ernesto Reinaldo Barreiro >
Re: CI for wicketstuff
On Thu, 13 Jan 2022 at 10:29, Maxim Solodovnik wrote: > > I'm +1 for any solution :) > I can ask INFRA if we can use Jenkins :) > > On Thu, 13 Jan 2022 at 02:47, Martin Grigorov wrote: > > > > Shall we move to Github Actions ? Are you familiar with "Github Actions" Maybe you can set it up and we will see how it will suit our needs :) > > TravisCI degrades day by day :-( > > CircleCI is also a very good alternative! > > > > On Wed, Jan 12, 2022 at 6:52 PM Maxim Solodovnik > > wrote: > > > > > Hello All, > > > > > > Maybe you know what is the current status of CI for wicketstuff > > > > > > I was unable to find latest snapshot > > > And the job at travis-ci.com :( > > > > > > from mobile (sorry for typos ;) > > > > > > > -- > Best regards, > Maxim -- Best regards, Maxim
