[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
Sorry for my late blocking, but actually I even didn't know that there is 
`README.md` under `conf/`. Maybe many ppl are same with me I guess. Seems there 
is already some duplicated information existed. How about adding this file's 
location using hyperlink (or whatever) under [this 
section](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration)?
 It would be better to be provided in official docs since this is useful info. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1781: Followup for ZEPPELIN-1785

2016-12-18 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1781
  
@Leemoonsoo @jongyoul 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] zeppelin pull request #1781: Followup for ZEPPELIN-1785

2016-12-18 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1781

Followup for ZEPPELIN-1785

### What is this PR for?
After #1745, zeppelin fail to launch in windows. 
https://issues.apache.org/jira/browse/ZEPPELIN-1785?focusedCommentId=15754688=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15754688

This due to the shell script difference between windows and *nix. This PR 
just remove the checking for ZEPPELIN_NOTEBOOK_DIR as it would be created in 
JVM side if the dir is not existed. I also remove it from  zeppelin.sh for *nix 
as well.


### What type of PR is it?
[Hot Fix |]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1785

### How should this be tested?
Tested it manually in windows and mac. Zeppelin can launch successfully on 
windows/mac even when the notebook dir doesn't exist. 


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin Followup_ZEPPELIN-1785

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1781


commit 2c7c719583cbfcacb27a7340d8561abca51eb6ae
Author: Jeff Zhang 
Date:   2016-12-19T07:12:04Z

HotFix for zeppelin.cmd




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Re: Build error on windows

2016-12-18 Thread Jeff Zhang
Thanks, This PR resolve my issue.



zjp_j...@163.com 于2016年12月19日周一 上午10:21写道:

> I think the following issue can help u.
> - JIRA : https://issues.apache.org/jira/browse/ZEPPELIN-1239
> - PR : https://github.com/apache/zeppelin/pull/1731
>
> --
> zjp_j...@163.com
>
>
> *From:* Jeff Zhang 
> *Date:* 2016-12-19 09:27
> *To:* users ; dev 
> *Subject:* Re: Build error on windows
>
> Attach npm-debug.log
>
>
> Alexander Bezzubov 于2016年12月18日周日 下午10:34写道:
>
> Hi Jeff,
>
>
> looks like something failed during `grunt build`.
> Could you also show the content of 
> `C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`?
> It might have some details to give a hint on the issue.
>
> --
> Alex
>
> On Sun, Dec 18, 2016 at 10:46 PM, Jeff Zhang  wrote:
>
> I try to build zeppelin on windows, but hit the following error. Does
> anyone know how to address this ? Thanks
>
>
> [ERROR] npm ERR! Windows_NT 6.1.7601
> [ERROR] npm ERR! argv
> "C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe"
> "C:\\Users\\jzhang\\zeppelin\\zeppelin
> -web\\node\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
> [ERROR] npm ERR! node v6.9.1
> [ERROR] npm ERR! npm  v3.10.8
> [ERROR] npm ERR! code ELIFECYCLE
> [ERROR] npm ERR! zeppelin-web@0.0.0 build: `grunt build`
> [ERROR] npm ERR! Exit status 3
> [ERROR] npm ERR!
> [ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 build script 'grunt
> build'.
> [ERROR] npm ERR! Make sure you have the latest version of node.js and npm
> installed.
> [ERROR] npm ERR! If you do, this is most likely a problem with the
> zeppelin-web package,
> [ERROR] npm ERR! not with npm itself.
> [ERROR] npm ERR! Tell the author that this fails on your system:
> [ERROR] npm ERR! grunt build
> [ERROR] npm ERR! You can get information on how to open an issue for this
> project with:
> [ERROR] npm ERR! npm bugs zeppelin-web
> [ERROR] npm ERR! Or if that isn't available, you can get their info via:
> [ERROR] npm ERR! npm owner ls zeppelin-web
> [ERROR] npm ERR! There is likely additional logging output above.
> [ERROR]
> [ERROR] npm ERR! Please include the following file with any support
> request:
> [ERROR] npm ERR! C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log
> [INFO]
> 
>
>
>


[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
@tae-jun 

It works well as described and here are two things to consider. 

1. Trash is represented in `~Trash` in the Navbar.

https://cloud.githubusercontent.com/assets/4968473/21301739/91cfc5dc-c5f3-11e6-92c4-4d1010024aae.png;>



2. Do we really need *rename*, *clear output* button on notes in Trash? 
IMO, we need only 2 options. **remove** or **restore** for that notes.

https://cloud.githubusercontent.com/assets/4968473/21301709/5901b012-c5f3-11e6-9699-f036fc3de694.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI ...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at:

https://github.com/apache/zeppelin/pull/1734


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1734
  
Hi all, This PR looks like unbacked from the point of view design. I will 
close this issue. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/1689

[ZEPPELIN-1709] Update checkstyle rule file, plugin

### What is this PR for?

We have

- outdated checkstyle.xml
- old maven checkstyle plugin
- no detailed style plugin guide (e.g available plugins, how to use them in 
your IDEA)

By fixing those issues, we can keep our code clean. It will results the 
number of rebase count (reduced conflict due to just style) and boost our 
productivity.

**important note**

1. This PR set an option to print all checkstyle warnings into stdout. The 
reason is, people should be told about invalid styles of not only errors but 
also warnings.
2. They would fix it progressionally. (unfortunately, we can fix all 
warnings in this PR. too much)
3. Once those warnings are all fixed, we can set 
`warning` to fail build even when 
checkstyle warning is occurred. That means we have more strict rule for our 
java code :)

```xml
true

```

### What type of PR is it?
[Improvement]

### Todos
* [x] - update check style plugin (6.19, the most recent for java 7)
* [x] - update checkstyle.xml  (brought from checkstyle 6.19 release)
* [x] - fix some styles
* [x] - print checkstyle WARN
* [x] - update docs

### What is the Jira issue?

[ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709)

### How should this be tested?

```
mvn validate -Denforcer.skip=true
```


### Questions:
* Does the licenses files need update - NO
* Is there breaking changes for older versions - NO
* Does this needs documentation - NO, but I added some docs about how to 
use checkstyle.xml in IDEA (https://github.com/apache/zeppelin/pull/1690)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1689


commit 0ae295639e69f2cbd79ab349cdd6234414e7c463
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:27:18Z

chore: Use pluginManagement block

so that config be shared in children projects

commit 092155dfb06a17f78a0dd949b2edd152a12b907e
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:28:29Z

chore: Remove useless failOnViolation config

its default value is already `true`

see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html

commit 1c3048ea763c5108f1489fdf15a72b40b19436f4
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:29:46Z

chore: Remove duplicated  exclude

commit 0e90cc3d39845388742b99bf9501c08965746025
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T02:52:15Z

style: Fix Invalid indents in interpreter

[INFO] 

[INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT
[INFO] 

[INFO]
[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ 
zeppelin-interpreter ---
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with 
_tools/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] 
(indentation) Indentation: 'Collection' have incorrect indentation level 4, 
expected level should be 6.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242]
 (indentation) Indentation: 'getClassName' have incorrect indentation level 10, 
expected level should be 12.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59]
 (indentation) Indentation: 'extends' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] 
src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60]
 (indentation) Indentation: 'implements' have incorrect indentation level 2, 
expected level should be 4.
[ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: 
File does not end with a newline.
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ... SUCCESS [  
3.587 s]
[INFO] Zeppelin: Interpreter .. FAILURE [  
0.901 s]

commit 13c53fcdfc526f63f083cedb991128fcda1ba739
Author: 1ambda <1am...@gmail.com>
Date:   2016-11-28T03:03:06Z

style: Fix invalid indents in zengine

[INFO] 

[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...

2016-12-18 Thread 1ambda
Github user 1ambda closed the pull request at:

https://github.com/apache/zeppelin/pull/1689


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1689
  
Hi all, This PR looks like unpopular from the point of view design. I will 
close this issue. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...

2016-12-18 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1730
  
Hi all, This PR looks like unpopular from the point of view design. I will 
close this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

2016-12-18 Thread AhyoungRyu
GitHub user AhyoungRyu reopened a pull request:

https://github.com/apache/zeppelin/pull/1694

[ZEPPELIN-1718] Prevent anonymous user to set note permission

### What is this PR for?
Currently anonymous user can open the notebook permission page and type sth 
in `Owner`/ `Reader` / `Writer` and then even can save it. However, in fact, it 
doesn't work actually. 

e.g.  An anonymous user can type `admin` / `user1` to the note permission 
setting fields.

It doesn't make sense. At least we should disallow the non-authenticated 
users(a.k.a anonymous users) by deactivating those permission related 
features(will handle interpreter user setting in another PR). So what I did in 
this PR is
 - Hide note authorization setting fields with notice sentence in dialog & 
add related docs link: 
https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/notebook_authorization.html

### What type of PR is it?
Bug Fix | Improvement

### What is the Jira issue?
[ZEPPELIN-1718](https://issues.apache.org/jira/browse/ZEPPELIN-1718)

### How should this be tested?

### Screenshots (if appropriate)
 - Doesn't show note permission setting page & show warning dialog if 
anonymous user tries to click lock icon

![block](https://cloud.githubusercontent.com/assets/10060731/21294995/696ae582-c58e-11e6-912c-76a590d19e75.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin prevent-anon-user

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1694


commit 06c632641afcddf57d1b1a15248876c88fbbb8fe
Author: AhyoungRyu 
Date:   2016-12-18T16:00:21Z

Block anonymous user to set the note permission

commit b59771c0bfa44c352c6d2044599063a93f48a227
Author: AhyoungRyu 
Date:   2016-12-18T16:35:36Z

Remove useless div block




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu closed the pull request at:

https://github.com/apache/zeppelin/pull/1694


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1694
  
@prabhjyotsingh @cloverhearts @astroshim Sorry for my late response. 
I added checking anonymous user by using websocket and updated PR 
description \w new UI screenshot image. Please take a look :)

And if you guys don't mind, will handle blocking interpreter owner setting 
part by anon user in other PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1750
  
Will merge into master if there are no more comments then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-18 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1731
  
@cuspymd please let me know you ASF JIRA user or email and I'll be happy to 
assign [ZEPPELIN-1239](https://issues.apache.org/jira/browse/ZEPPELIN-1239) so 
attribution is keept for release notes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1731: [ZEPPELIN-1239] Google WebFont: goog-webfont-dl Grunt ...

2016-12-18 Thread bzz
Github user bzz commented on the issue:

https://github.com/apache/zeppelin/pull/1731
  
Looks great to me. Merging to master if there is no further discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Re: Build error on windows

2016-12-18 Thread zjp_j...@163.com
I think the following issue can help u.
- JIRA : https://issues.apache.org/jira/browse/ZEPPELIN-1239
- PR : https://github.com/apache/zeppelin/pull/1731



zjp_j...@163.com
 
From: Jeff Zhang
Date: 2016-12-19 09:27
To: users; dev
Subject: Re: Build error on windows
Attach npm-debug.log


Alexander Bezzubov 于2016年12月18日周日 下午10:34写道:
Hi Jeff,


looks like something failed during `grunt build`. 
Could you also show the content of 
`C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`? It might have some 
details to give a hint on the issue.

--
Alex

On Sun, Dec 18, 2016 at 10:46 PM, Jeff Zhang  wrote:
I try to build zeppelin on windows, but hit the following error. Does
anyone know how to address this ? Thanks


[ERROR] npm ERR! Windows_NT 6.1.7601
[ERROR] npm ERR! argv
"C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe"
"C:\\Users\\jzhang\\zeppelin\\zeppelin
-web\\node\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
[ERROR] npm ERR! node v6.9.1
[ERROR] npm ERR! npm  v3.10.8
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! zeppelin-web@0.0.0 build: `grunt build`
[ERROR] npm ERR! Exit status 3
[ERROR] npm ERR!
[ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 build script 'grunt
build'.
[ERROR] npm ERR! Make sure you have the latest version of node.js and npm
installed.
[ERROR] npm ERR! If you do, this is most likely a problem with the
zeppelin-web package,
[ERROR] npm ERR! not with npm itself.
[ERROR] npm ERR! Tell the author that this fails on your system:
[ERROR] npm ERR! grunt build
[ERROR] npm ERR! You can get information on how to open an issue for this
project with:
[ERROR] npm ERR! npm bugs zeppelin-web
[ERROR] npm ERR! Or if that isn't available, you can get their info via:
[ERROR] npm ERR! npm owner ls zeppelin-web
[ERROR] npm ERR! There is likely additional logging output above.
[ERROR]
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log
[INFO]




[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...

2016-12-18 Thread pmccaffrey6
Github user pmccaffrey6 commented on the issue:

https://github.com/apache/zeppelin/pull/1776
  
I went ahead and changed parsing of the "explore" keyword to use `split(" 
+")` instead of substring so that it wasn't tied to any particular word length 
etc.. and the `METADATA_KEYWORD` can be set to any single case-insensitive word.

As an additional detail, if you look up a table that doesn't exist you'll 
just get an empty table in the paragraph as opposed to an explicit error 
message. I experimented a bit with testing for an empty result set using 
`resultSet.next()` and `resultSet.first()` so that I could output an error 
message like "Database object not found". 

However, it seems that when getting metadata, since you're not using 
`Statement`, this kind of thing causes problems because re-setting cursors on 
the resultset using methods like `resultSet.beforeFirst()` isn't supported for 
all data sources. I don't want to use `Statement` because I want to have this 
abstracted away from SQL and simply use the JDBC api to get metadata. So, in 
the interest of making this as general of a feature as possible, and therefore 
not using `Statement`, as well as not having a good way to test for `resultSet` 
emptiness that is adequately vendor-agnostic, there currently isn't testing for 
empty result sets, they just return as empty tables.

I don't imagine this is an issue really but if anyone has a suggestion of a 
good way to do this, I'd be very interested to hear it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1750
  
@felixcheung Yeah that's my plan :D 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build error on windows

2016-12-18 Thread Jeff Zhang
Attach npm-debug.log


Alexander Bezzubov 于2016年12月18日周日 下午10:34写道:

Hi Jeff,


looks like something failed during `grunt build`.
Could you also show the content of
`C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`?
It might have some details to give a hint on the issue.

--
Alex

On Sun, Dec 18, 2016 at 10:46 PM, Jeff Zhang  wrote:

I try to build zeppelin on windows, but hit the following error. Does
anyone know how to address this ? Thanks


[ERROR] npm ERR! Windows_NT 6.1.7601
[ERROR] npm ERR! argv
"C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe"
"C:\\Users\\jzhang\\zeppelin\\zeppelin
-web\\node\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
[ERROR] npm ERR! node v6.9.1
[ERROR] npm ERR! npm  v3.10.8
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! zeppelin-web@0.0.0 build: `grunt build`
[ERROR] npm ERR! Exit status 3
[ERROR] npm ERR!
[ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 build script 'grunt
build'.
[ERROR] npm ERR! Make sure you have the latest version of node.js and npm
installed.
[ERROR] npm ERR! If you do, this is most likely a problem with the
zeppelin-web package,
[ERROR] npm ERR! not with npm itself.
[ERROR] npm ERR! Tell the author that this fails on your system:
[ERROR] npm ERR! grunt build
[ERROR] npm ERR! You can get information on how to open an issue for this
project with:
[ERROR] npm ERR! npm bugs zeppelin-web
[ERROR] npm ERR! Or if that isn't available, you can get their info via:
[ERROR] npm ERR! npm owner ls zeppelin-web
[ERROR] npm ERR! There is likely additional logging output above.
[ERROR]
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log
[INFO]



[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-18 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1765

[WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build

### What is this PR for?
Add more logging as I could not reproduce it locally. 


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1761

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1765


commit 6f7c5897a3a069f4c512cef7925894dd5d66c5dc
Author: Jeff Zhang 
Date:   2016-12-15T07:29:07Z

ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...

2016-12-18 Thread zjffdu
Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1765


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1751
  
LGTM
CI was passing, merging if no more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1755: [ZEPPELIN-1801] To force end table - append %text

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1755
  
@ravwojdyla feel free to ping me directly for scio changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1755: [ZEPPELIN-1801] To force end table - append %text

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1755
  
LGTM, CI good, merging if no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
LGTM!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* ...

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1765
  
could you mark the title with [WIP]?
let me know when this is ready!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1750: [ZEPPELIN-1796] Add 'copy to clipboard' next to the pa...

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1750
  
LGTM!
Maybe we can leverage this for more copy to clipboard features?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...

2016-12-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1763


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1763
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1779: [ZEPPELIN-1835] Upgrade ElasticSearch to version 2.4.3

2016-12-18 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1779
  
LGTM. I guess next would be to support ES 5.x? :)

merging if no more comment.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build error on windows

2016-12-18 Thread Alexander Bezzubov
Hi Jeff,


looks like something failed during `grunt build`.
Could you also show the content of
`C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log`?
It might have some details to give a hint on the issue.

--
Alex

On Sun, Dec 18, 2016 at 10:46 PM, Jeff Zhang  wrote:

> I try to build zeppelin on windows, but hit the following error. Does
> anyone know how to address this ? Thanks
>
>
> [ERROR] npm ERR! Windows_NT 6.1.7601
> [ERROR] npm ERR! argv
> "C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe"
> "C:\\Users\\jzhang\\zeppelin\\zeppelin
> -web\\node\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
> [ERROR] npm ERR! node v6.9.1
> [ERROR] npm ERR! npm  v3.10.8
> [ERROR] npm ERR! code ELIFECYCLE
> [ERROR] npm ERR! zeppelin-web@0.0.0 build: `grunt build`
> [ERROR] npm ERR! Exit status 3
> [ERROR] npm ERR!
> [ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 build script 'grunt
> build'.
> [ERROR] npm ERR! Make sure you have the latest version of node.js and npm
> installed.
> [ERROR] npm ERR! If you do, this is most likely a problem with the
> zeppelin-web package,
> [ERROR] npm ERR! not with npm itself.
> [ERROR] npm ERR! Tell the author that this fails on your system:
> [ERROR] npm ERR! grunt build
> [ERROR] npm ERR! You can get information on how to open an issue for this
> project with:
> [ERROR] npm ERR! npm bugs zeppelin-web
> [ERROR] npm ERR! Or if that isn't available, you can get their info via:
> [ERROR] npm ERR! npm owner ls zeppelin-web
> [ERROR] npm ERR! There is likely additional logging output above.
> [ERROR]
> [ERROR] npm ERR! Please include the following file with any support
> request:
> [ERROR] npm ERR! C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log
> [INFO]
> 
>


Build error on windows

2016-12-18 Thread Jeff Zhang
I try to build zeppelin on windows, but hit the following error. Does
anyone know how to address this ? Thanks


[ERROR] npm ERR! Windows_NT 6.1.7601
[ERROR] npm ERR! argv
"C:\\Users\\jzhang\\zeppelin\\zeppelin-web\\node\\node.exe"
"C:\\Users\\jzhang\\zeppelin\\zeppelin
-web\\node\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
[ERROR] npm ERR! node v6.9.1
[ERROR] npm ERR! npm  v3.10.8
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! zeppelin-web@0.0.0 build: `grunt build`
[ERROR] npm ERR! Exit status 3
[ERROR] npm ERR!
[ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 build script 'grunt
build'.
[ERROR] npm ERR! Make sure you have the latest version of node.js and npm
installed.
[ERROR] npm ERR! If you do, this is most likely a problem with the
zeppelin-web package,
[ERROR] npm ERR! not with npm itself.
[ERROR] npm ERR! Tell the author that this fails on your system:
[ERROR] npm ERR! grunt build
[ERROR] npm ERR! You can get information on how to open an issue for this
project with:
[ERROR] npm ERR! npm bugs zeppelin-web
[ERROR] npm ERR! Or if that isn't available, you can get their info via:
[ERROR] npm ERR! npm owner ls zeppelin-web
[ERROR] npm ERR! There is likely additional logging output above.
[ERROR]
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! C:\Users\jzhang\zeppelin\zeppelin-web\npm-debug.log
[INFO]



[GitHub] zeppelin pull request #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .py...

2016-12-18 Thread zjffdu
Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/1765


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1765: ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .py...

2016-12-18 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/1765

ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build

### What is this PR for?
Add more logging as I could not reproduce it locally. 


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1761

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1761

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1765


commit 6f7c5897a3a069f4c512cef7925894dd5d66c5dc
Author: Jeff Zhang 
Date:   2016-12-15T07:29:07Z

ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---