[GitHub] zeppelin pull request #2729: [ZEPPELIN-2826] support for carriage return '\r...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2729

[ZEPPELIN-2826] support for carriage return '\r', on result window

### What is this PR for?
This PR implements carriage return '\r' on result window, currently since 
HTML treats "\n", "\r" and "\r\n"  equally.


### What type of PR is it?
[Improvement]


### What is the Jira issue?
* [ZEPPELIN-2826](https://issues.apache.org/jira/browse/ZEPPELIN-2826)

### How should this be tested?
Here is a sample code to test it
```
%python
import time,sys
end_val = 10
bar_length = 20
for i in xrange(0, end_val + 1):
time.sleep(0.5)
percent = float(i) / end_val
hashes = '#' * int(round(percent * bar_length))
spaces = ' ' * (bar_length - len(hashes))
sys.stdout.write("\rPercent: [{0}] {1}%".format(hashes + spaces, 
int(round(percent * 100
#print "Percent: [{0}] {1}%".format(hashes + spaces, int(round(percent 
* 100)))
```

### Screenshots (if appropriate)

![after2](https://user-images.githubusercontent.com/674497/34886813-55e6e2d8-f7ea-11e7-9e40-24ded6631d75.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2826

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2729.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2729


commit 4511eec3a1e7df62c09ab0fdfa47fde5ba1ffa8e
Author: Prabhjyot Singh 
Date:   2018-01-12T16:54:15Z

ZEPPELIN-2826: support for carriage return '\r', on result

Change-Id: If7e953718b19de56808276fd695ea0a5582b4277




---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2725
  
Tried it on local, works well.


---

[GitHub] zeppelin issue #2728: ZEPPELIN-3104. Support Hadoop 3.0

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2728
  
Build number 1433.11 fails, assuming it's not related. Rest looks good.


---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2729
  
I think that can be adjusted via `zeppelin.interpreter.output.limit`? Or 
help me understand if you meant something else.


---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2729
  
I now see what you were saying earlier, let me check if there is a quick 
fix for this.


---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2729
  
@zjffdu  That "calculation" looks like a bigger change and might change the 
content of notebook as well.


---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2729
  
That works well, have merged that commit to this PR.


---

[GitHub] zeppelin issue #2729: [ZEPPELIN-2826] support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2729
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2732: [ZEPPELIN-3172] Support for carriage return '\r...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2732

[ZEPPELIN-3172] Support for carriage return '\r', on result window

### What is this PR for?
This got introduced while trying to fix html/xml rendering 
https://github.com/apache/zeppelin/pull/2729/commits/7851c130cf62fc7ff2281d1cf2c6f25658829fe5


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-3172]

### How should this be tested?
Here is a sample code to test it

```
%python
import time,sys
end_val = 10
bar_length = 20
for i in xrange(0, end_val + 1):
time.sleep(0.5)
percent = float(i) / end_val
hashes = '#' * int(round(percent * bar_length))
spaces = ' ' * (bar_length - len(hashes))
sys.stdout.write("\rPercent: [{0}] {1}%".format(hashes + spaces, 
int(round(percent * 100
#print "Percent: [{0}] {1}%".format(hashes + spaces, int(round(percent 
* 100)))
```

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2732


commit e3c2162ddc208b7f75ad5a2763996e88bfa34fcf
Author: Prabhjyot Singh 
Date:   2018-01-17T10:53:51Z

fix contained html/xml

Change-Id: I60c02435e312a9898de41ca59458c84d467e19be




---

[GitHub] zeppelin issue #2732: [ZEPPELIN-3172] Support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2732
  
@zjffdu  Please help review this.


---

[GitHub] zeppelin issue #2732: [ZEPPELIN-3172] Support for carriage return '\r', on r...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2732
  
Thanks for the review, will merge this soon.


---

[GitHub] zeppelin issue #2737: ZEPPELIN-3181. Enable impersonation support for kerber...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2737
  
Does it not requires renew of keytab? Or this takes care of it ?
```
env.put("ZEPPELIN_SERVER_KERBEROS_KEYTAB", keytab);
env.put("ZEPPELIN_SERVER_KERBEROS_PRINCIPAL", principal);
```


---

[GitHub] zeppelin pull request #2739: [ZEPPELIN-3183] Add date format support for lin...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2739

[ZEPPELIN-3183] Add date format support for line chart as x-axis

### What is this PR for?
Add date format support for line chart as x-axis

### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3183](https://issues.apache.org/jira/browse/ZEPPELIN-3183)

### Screenshots (if appropriate)
Before

![before](https://user-images.githubusercontent.com/674497/35231655-5cb7b5f6-ffbf-11e7-8dfa-541985946fcb.gif)

After

![after](https://user-images.githubusercontent.com/674497/35231653-5c67d23e-ffbf-11e7-8ee8-33dedf137f73.gif)




### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3183

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2739


commit a0f7155d0e9d319b708bb0f05a22a8bdf166
Author: Prabhjyot Singh 
Date:   2018-01-22T16:27:00Z

ZEPPELIN-3183: Add date format support for line chart




---

[GitHub] zeppelin issue #2739: [ZEPPELIN-3183] Add date format support for line chart...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2739
  
I think the number what you see after +{number} is the time zone. Eg:
```
Default which is coming from query -> 2018-01-22T14:57:43+
When enabled Date -> Mon Jan 22 2018 20:27:43 GMT+0530 (IST)
```


---

[GitHub] zeppelin pull request #2740: [ZEPPELIN-3185] Add profiles for adding depende...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2740

[ZEPPELIN-3185] Add profiles for adding dependencies for Hive and Phoenix

### What is this PR for?
This PR adds profiles for adding dependencies for Hive and Phoenix

### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3185](https://issues.apache.org/jira/browse/ZEPPELIN-3185)


### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3185

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2740


commit 99eafdecb7b04440f0546adfdfd46f51e8581a41
Author: Prabhjyot Singh 
Date:   2018-01-23T10:55:59Z

add profile for adding dependencies for hive and phoenix

Change-Id: I3ddfa2af7b7f6742a49f615ba4af5f4cd06478ff




---

[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2740
  
@zjffdu  Please help review this.


---

[GitHub] zeppelin issue #2739: [ZEPPELIN-3183] Add date format support for line chart...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2739
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2740
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2740
  
I believe `zeppelin-jdbc` depends only on `zeppelin-interpreter`, and not 
on `zeppelin-zengine`, so it should be safe.


---

[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2740
  
No I think it should be disabled by default, it may increase the size of 
binary.


---

[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2740
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2753: ZEPPELIN-3138. checkstyle for zeppelin-interpreter

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2753
  
Assuming all of the styling/reformating is done by Idea, looks good.


---

[GitHub] zeppelin pull request #2757: [ZEPPELIN-3198] UI should not show Version/GIT ...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2757

[ZEPPELIN-3198] UI should not show Version/GIT Control if the same if not 
supported

### What is this PR for?
Currently, UI shows an option for version/GIT Control even when it is not 
supported by the underlying implementing storage configuration.

It is only after users try to save a commit and get an error "Couldn't 
checkpoint note revision: possibly storage doesn't support versioning. Please 
check the logs for more details.".

So, if implementing storage configuration doesn't support git storage, UI 
should not show those options.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
* 
[ZEPPELIN-3198](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3198)

### How should this be tested?
On using "org.apache.zeppelin.notebook.repo.GitNotebookRepo"  for 
`zeppelin.notebook.storage`  user should see revision/version control option, 
for rest of the others e.g. "FileSystemNotebookRepo" user should not see that 
option 


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2757


commit cd7fde105c5017ac5ef8fab956c79987529fc10d
Author: Prabhjyot Singh 
Date:   2018-02-01T09:38:50Z

ZEPPELIN-3198: add isRevisionSupported for NotebookRepo

Change-Id: I67af210fb003e007129db4b24e5f8f53fb034c6f




---

[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2757
  
Yes, I believe that is exactly what I'm trying to do over here, for example 
in S3NotebookRepo, since none of checkpoint, get, revisionHistory, or 
setNoteRevision is implemented 
(https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/S3NotebookRepo.java#L292)
 hence for the same the method isRevisionSupported returns false. Let me know 
if I'm missing out on a case.


---

[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2757
  
@felixcheung @zjffdu  can you please help review this?


---

[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2757
  
@zjffdu have made the suggested changes, waiting for CI, does this looks 
good?


---

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2587
  
This looks good, with one minor comment, this was one long pending feature 
missing in Livy a big +1 for adding this functionality.


---

[GitHub] zeppelin issue #2769: ZEPPELIN-3171. Restart of interpreter in note also abo...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2769
  
LGTM!


---

[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2757
  
Shall I merge this, if no more discussion?


---

[GitHub] zeppelin pull request #2779: [ZEPPELIN-3213] Support for KNOXSSO logout url ...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2779

[ZEPPELIN-3213] Support for KNOXSSO logout url as API

### What is this PR for?
KNOXSSO logout URL can be an API or it can be a redirect URL, Zeppelin 
should support both.


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3213](https://issues.apache.org/jira/browse/ZEPPELIN-3213)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3213

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2779


commit 25d7c5bc056c388e1a49ce7ef502f8a8f1b06fd6
Author: Prabhjyot Singh 
Date:   2018-02-08T07:14:11Z

[ZEPPELIN-3213] Support for KNOXSSO logout url as API

Change-Id: I28857e9b39c8daf639a4d0fe537cabd81e971cec




---

[GitHub] zeppelin issue #2779: [ZEPPELIN-3213] Support for KNOXSSO logout url as API

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2779
  
@r-kamath @zjffdu  Can you help review this.


---

[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2757
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2800: [HOTFIX] fix ZEPPELIN-3198 failures

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2800
  
@zjffdu  can you please help review this PR


---

[GitHub] zeppelin pull request #2800: [HOTFIX] fix ZEPPELIN-3198 failures

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2800

[HOTFIX] fix ZEPPELIN-3198 failures

### What is this PR for?
While merging ZEPPELIN-3198(https://github.com/apache/zeppelin/pull/2757), 
did not merge ZEPPELIN-3092 and ZEPPELIN-3182 (rebase from master), which is 
causing CI to fail

### What type of PR is it?
[Hot Fix]


### How should this be tested?
* CI should pass

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin hotfix/ZEPPELIN-3198

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2800


commit fdf47bb854f2deaa4c75590141a455812242ef50
Author: Prabhjyot Singh 
Date:   2018-02-14T11:13:16Z

fix ZEPPELIN-3198 related failures

Change-Id: I0688823f805dcdd0dd7201b8775463e01120e080




---

[GitHub] zeppelin issue #2800: [HOTFIX] fix ZEPPELIN-3198 failures

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2800
  
All passed except 
[653.4](https://api.travis-ci.org/v3/job/341384443/log.txt), which looks 
unrelated to me.

https://travis-ci.org/prabhjyotsingh/zeppelin/builds/341384435


---

[GitHub] zeppelin pull request #2804: [DISCUSS] semicolons in javascript

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2804

[DISCUSS] semicolons in javascript

## What is this PR for?
Have added this PR to discuss if we should add a rule in eslinerc to have 
semicolons in javascript source

### What type of PR is it?
[Improvement | Refactoring]

### How should this be tested?

```
cd zeppelin-web
npm install (or yarn install if you have yarn)
npm run lint:once
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin 
discuss/eslint_semi_rule

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2804


commit e15b0e6d7685b4b2ab6206871f076ad0ba2aebf6
Author: Prabhjyot Singh 
Date:   2018-02-15T06:46:25Z

add `"semi": [2, "always"]` rule in eslinerc

Change-Id: If0356e494152c1beb8b8cef666c95d448a490749




---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2804
  
cc: @1ambda @AhyoungRyu @r-kamath 


---

[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2804
  
@mebelousov I did not follow your comment.


---

[GitHub] zeppelin pull request #2805: [ZEPPELIN-3240] Zeppelin server fail to start i...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2805

[ZEPPELIN-3240] Zeppelin server fail to start if interpreter has mixed 
properties

### What is this PR for?
I found that Zeppelin server is failing to start when there is a mix of 
both kind of properties in interpreter;

```
"properties": {
"shell.command.timeout.millisecs": {
  "type": "string",
  "name": "shell.command.timeout.millisecs",
  "value": "6"
},
"shell.working.directory.user.home": {
  "type": "checkbox",
  "name": "shell.working.directory.user.home",
  "value": false
},
"zeppelin.shell.auth.type": "KERBEROS",
"zeppelin.shell.keytab.location": 
"/etc/security/keytabs/zeppelin.server.kerberos.keytab",
"zeppelin.shell.principal": "zeppe...@example.com"
  }
```

Mix as in these two kind of properties:

 - Where key is string and value is object
```
"shell.command.timeout.millisecs": {
  "type": "string",
  "name": "shell.command.timeout.millisecs",
  "value": "6"
}
```

 - Where key and value both are string
```
"zeppelin.shell.auth.type": "KERBEROS"
```

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3240](https://issues.apache.org/jira/browse/ZEPPELIN-3240)

### How should this be tested?
* Place this 
[interpreter.json](https://issues.apache.org/jira/secure/attachment/12910862/interpreter.json)
 in Z-server conf folder and try to start Z-Server, with this patch it should 
start.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3240

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2805


commit 8545ecd040c7641fc97062acfbf7c58a5b6f1a90
Author: Prabhjyot Singh 
Date:   2018-02-16T04:32:46Z

ZEPPELIN-3240: Zeppelin server fail to start if interpreter has mixed 
properties

Change-Id: I63dfb66f34e8b50bbc9d2b1e48d70c7949ebfbf9




---

[GitHub] zeppelin issue #2805: [ZEPPELIN-3240] Zeppelin server fail to start if inter...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2805
  
@zjffdu  can you help review this.


---

[GitHub] zeppelin issue #2805: [ZEPPELIN-3240] Zeppelin server fail to start if inter...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2805
  
@Tagar  Yes, this can happen in Zeppelin upgrade, not in all upgrades, but 
in some trivial case hard to reproduce.

Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2809: [ZEPPELIN-3249] Add support for streaming table

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2809

[ZEPPELIN-3249] Add support for streaming table

### What is this PR for?
Since Zeppelin support streaming from various backends, I think it will be 
useful if even tables (and later graphs) can also be streamed.

### What type of PR is it?
[Improvement | Feature]

### What is the Jira issue?
* [ZEPPELIN-3249](https://issues.apache.org/jira/browse/ZEPPELIN-3249)

### How should this be tested?
I have done it using shell interpreter, but this should work for all other 
backends as well
```
%sh
echo "%table"
echo "Col1  Col2"
echo "1 2"
sleep 1
echo "3 4"
echo "5 6"
sleep 2
echo "7 8"
sleep 3
echo "9 10"
echo "1112"
sleep 4
echo "1213"
```

### Screenshots (if appropriate)

![zeppelin-3249](https://user-images.githubusercontent.com/674497/36419469-fa4c26e0-1657-11e8-8a8a-717b29d91771.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2809


commit 21564fcb4f336867e1b628445c0f194ccc3ed574
Author: Prabhjyot Singh 
Date:   2018-02-16T09:45:20Z

Add support for streaming table

Change-Id: If47e6646755ed47463fec9c2ab38adeaec700053




---

[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2809
  
Here is another example for python.
```
%python
print "%table col1  col2"
print "i 1  i 1"
wait_time = 2
import time
time.sleep(1)
for x in range(2, 200):
print "i",x,"   i",x
if x == wait_time:
time.sleep(2)
wait_time = wait_time*2
```


![zeppelin-3249-python](https://user-images.githubusercontent.com/674497/36424708-48fb237e-166a-11e8-9b12-7d117984cc7e.gif)



---

[GitHub] zeppelin issue #2804: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2804
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2804: [ZEPPELIN-3245] checkstyle/eslintrc for zeppeli...

[prabhjyotsingh]

Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/2804


---

[GitHub] zeppelin pull request #2804: [ZEPPELIN-3245] checkstyle/eslintrc for zeppeli...

[prabhjyotsingh]

GitHub user prabhjyotsingh reopened a pull request:

https://github.com/apache/zeppelin/pull/2804

[ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (JavaScript)

## What is this PR for?
Have added this PR to add a rule in eslinerc to have semicolons in 
javascript source

### What type of PR is it?
[Improvement | Refactoring]

### What is the Jira issue?
* [ZEPPELIN-3245](https://issues.apache.org/jira/browse/ZEPPELIN-3245)

### How should this be tested?

```
cd zeppelin-web
npm install (or yarn install if you have yarn)
npm run lint:once
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin 
discuss/eslint_semi_rule

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2804


commit e7062d70529671a8def8dfc3eb144ff4ffe074fd
Author: Prabhjyot Singh 
Date:   2018-02-15T06:46:25Z

add `"semi": [2, "always"]` rule in eslinerc

Change-Id: If0356e494152c1beb8b8cef666c95d448a490749

commit 3a133f48bc7824858f02841a1ba81100977a50df
Author: Prabhjyot Singh 
Date:   2018-02-19T09:28:11Z

remove "standard" from eslint

Change-Id: If488e5a7faf68fea9c0f463de7aba1dae0607b0d

commit 9a43465535a87cb156cc9ab8007fbb17b910e7d2
Author: Prabhjyot Singh 
Date:   2018-02-19T09:31:06Z

remove `"linebreak-style": 0,` and `"no-use-before-define": 0,`

Change-Id: If9727c13bf40be52cbe40b5c7c888c99af739e9b

commit a5c9db67acdfe25de712dee09ace5765fdfc45ee
Author: Prabhjyot Singh 
Date:   2018-02-21T18:37:40Z

fix failing WEB_E2E="true"

Change-Id: I8af5179afcd63377a4bd76486f7e30e29a97a30b




---

[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2809
  
@r-kamath can you help review this PR


---

[GitHub] zeppelin issue #2804: [ZEPPELIN-3245] checkstyle/eslintrc for zeppelin-web (...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2804
  
Will merge this to branch-0.8 as well, so that if there are any backports 
they are convenient.


---

[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2809
  
Thanks for the review will merge this to master and branch-0.8 if no more 
discussion.


---

[GitHub] zeppelin issue #2708: [Zeppelin-3095] Fix UI when all paragraphs executing s...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2708
  
Tested it locally, and front-end changes looks OK.
In this case, I agree popup is not user-friendly. Also since we are 
blocking (or temporarily disabling) Paragraphs Control, should we block editing 
of paragraphs as well, since from backend it is also blocked?


---

[GitHub] zeppelin pull request #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2821

[ZEPPELIN-3271] Option for disabling scheduler

### What is this PR for?
Zeppelin server should have an option to enable/disable cron scheduler from 
Zeppelin config.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3271](https://issues.apache.org/jira/browse/ZEPPELIN-3271)

### How should this be tested?
* On adding below mentioned property in `zeppelin-site.xml`, this feature 
should get disabled from both web-socket and REST-APIs.

```

  zeppelin.notebook.cron.enable
  false
  Notebook enable cron scheduler feature

```


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3271

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2821


commit d25ebcc4da30bc8f17250728ea52387861920706
Author: Prabhjyot Singh 
Date:   2018-02-27T09:20:31Z

ZEPPELIN-3271: Option for disabling scheduler

Change-Id: I0a2a000e9ef2045e6928cbd909c99bfa1b0a5f6d




---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
@r-kamath @zjffdu  can you help review this PR.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
@mebelousov Help me understand what you are saying, say if 
`zeppelin.notebook.cron.enable` (defined in this PR) is set to `true` and 
`zeppelin.notebook.cron.folders` is set to `System, Testing` then cron will 
only be run on these two folders.

My general opinion about cron is around either user should have permission 
or not, not at notebook level.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
@mebelousov have pushed a commit with your suggested feedback.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
Merging this to master and branch-0.8 if no more discussion.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
@zjffdu  Sure added it.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
Have pushed another commit that disables Cron/scheduler by default, and 
user needs this feature, will need to with config.


---

[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2821
  
Yes, I've updated the doc 
(https://github.com/apache/zeppelin/pull/2821/files#diff-bed1be4fb1f7f6c8e3bd6db18d72dc44R54).
 and yes, I agree we should document this in our release notes as well.


---

[GitHub] zeppelin pull request #2826: [ZEPPELIN-3276] Upgrade Firefox version in Trav...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2826

[ZEPPELIN-3276] Upgrade Firefox version in Travis CI

### What is this PR for?
Upgrade Firefox version in Travis CI

### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3276](https://issues.apache.org/jira/browse/ZEPPELIN-3276)

### How should this be tested?
* CI should be green.

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3276

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2826


commit ffb03e10ad1d90dad9057bb008e4b930fda4bbce
Author: Prabhjyot Singh 
Date:   2018-03-01T21:15:51Z

upgrade FF to 58




---

[GitHub] zeppelin pull request #2826: [ZEPPELIN-3276] Upgrade Firefox version in Trav...

[prabhjyotsingh]

Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/2826


---

[GitHub] zeppelin issue #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for integratio...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2816
  
I understand Selenium, Gecko, WebExtensions are constantly evolving. 
However, with this (https://github.com/apache/zeppelin/pull/2826/files), I'm 
able to make all the Selenium test case pass on FF-58. This PR is still work in 
progress. 

Also, there is stuff that will get fixed with FF-59.


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2827
  
@r-kamath @zjffdu  Please help review this.


---

[GitHub] zeppelin pull request #2827: [HOTFIX] fix checkstyle errors

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2827

[HOTFIX] fix checkstyle errors

### What is this PR for?
There are some checkstyle errors in branch-0.8, this is to fix all those 
errors.

### What type of PR is it?
[Hot Fix]


### How should this be tested?
* CI should be green.


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin 
hotfix/branch-0.8_checkstyle_errors

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2827


commit 1c94e5cd9d81ae18861b375056db74f5dfe36597
Author: Prabhjyot Singh 
Date:   2018-03-02T15:22:20Z

fix checkstyle errors

Change-Id: I0b24f9287f4a8d63d18d55863505370b70c3659f




---

[GitHub] zeppelin pull request #2827: [HOTFIX] fix checkstyle errors

[prabhjyotsingh]

Github user prabhjyotsingh closed the pull request at:

https://github.com/apache/zeppelin/pull/2827


---

[GitHub] zeppelin issue #2827: [HOTFIX] fix checkstyle errors

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2827
  
@zjffdu sure, no problem.


---

[GitHub] zeppelin issue #2809: [ZEPPELIN-3249] Add support for streaming table

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2809
  
Sure, let me take a look.


---

[GitHub] zeppelin pull request #2835: [ZEPPELIN-3289] Table not using full height aft...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2835

[ZEPPELIN-3289] Table not using full height after paragraph height has been 
changed

### What is this PR for?
Changing paragraph height does not work correctly anymore in conjunction 
with table output. Refer screen shot:

![image](https://user-images.githubusercontent.com/674497/36977669-f28c77a2-20a7-11e8-854a-0b6d40973700.png)

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3289](https://issues.apache.org/jira/browse/ZEPPELIN-3289)
* [ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3289

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2835.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2835


commit dd6a6d1211d612ab38af7bc279061bfe23430747
Author: Prabhjyot Singh 
Date:   2018-03-05T13:29:19Z

ZEPPELIN-3289: refresh() also updates height

Change-Id: I001421ee174ed2fa06cecfeb845916097fdf1464




---

[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
@weand  @r-kamath  Can you help review this PR.


---

[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
@Tagar This PR fixes 
[ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272) as well, 
can you help review this.


---

[GitHub] zeppelin issue #2405: [ZEPPELIN-2640] Roles are not getting honored from shi...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2405
  
@paramount2u sounds like something to do with your activeDirectory 
configuration not correct, and if you feel issue can be reproduced, please 
create a new JIRA.


---

[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
Have made a fix for both.


---

[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2835
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2853: [ZEPPELIN-3306] Web e2e test fails

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2853

[ZEPPELIN-3306] Web e2e test fails

### What is this PR for?
This is one of the flaky tests that fails with "should have a welcome 
message" because Z-Server did not start by the time test started executing.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3306](https://issues.apache.org/jira/browse/ZEPPELIN-3306)

### How should this be tested?
* CI should pass

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3306

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2853.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2853


commit 8742b1104f7d3671d33343006a25decf9618f79b
Author: Prabhjyot Singh 
Date:   2018-03-09T07:42:12Z

ZEPPELIN-3306: Web e2e test fails

Change-Id: If29e84e5ff2b3bf06dbf624d6baab87b6b9f38c4




---

[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2853
  
@zjffdu 
Can you help review this? Looks like this was actually because of the 
latest version of chrome (65.0.3325.146) and had to update webdriver-manager's 
chrome version.


---

[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2853
  
CI green https://travis-ci.org/prabhjyotsingh/zeppelin/builds/351259448.


---

[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2853
  
Will merge this soon.


---

[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2853
  
@felixcheung it doesn't happen always but at times before could 
Zeppelin-server start test case starts executing, and by making `spawn="false"` 
maven waits for the command (./bin/zeppelin-daemon.sh start) to complete, and 
`CI=true` make zeppelin-daemon to wait for localhost:8080 to be active.


---

[GitHub] zeppelin pull request #2862: [ZEPPELIN-3321] isRevisionSupported not working...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2862

[ZEPPELIN-3321] isRevisionSupported not working for importing notebooks.

### What is this PR for?
 when importing note of from one zeppelin instance that don't support 
revision to another zeppelin instance where revision is supported, the imported 
note still don't support revision.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* (ZEPPELIN-3321)[https://issues.apache.org/jira/browse/ZEPPELIN-3321]

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2862


commit 18873d3b62a57b07415043aebff1cd991f6d8059
Author: Prabhjyot Singh 
Date:   2018-03-13T11:20:09Z

ZEPPELIN-3321: fix isRevisionSupported




---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2862
  
@zjffdu, @r-kamath  can you help review this.


---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2671
  
Ping @kjmrknsn, are you still working on this?


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2862
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2872: [ZEPPELIN-3089] Delete all notes for current us...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2872

[ZEPPELIN-3089] Delete all notes for current user

### What is this PR for?
"Empty Trash" is not working when multi-user create a notebook and move it 
to trash.
Because all notebooks are in the same trash folder even though the user 
doesn't have permission to the notebook, and on clicking "Empty Trash" button 
next to Trash folder, Zeppelin tries to delete all notebooks in the Trash 
folder, which includes no permission notebook, but cannot delete those because 
of no permission.

This has slightly different implementation than that is there is 
https://github.com/apache/zeppelin/pull/2695


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Add unit test case

### What is the Jira issue?
* [ZEPPELIN-3089](https://issues.apache.org/jira/browse/ZEPPELIN-3089)

### How should this be tested?
* Login as user 'A' and create a notebook 'A'
* Move notebook 'A' to Trash
* Login as user 'B' and create a notebook 'B'
* Move notebook 'B' to Trash
* Click 'Empty Trash' button next to 'Trash' folder


### Screenshots (if appropriate)

![zeppelin-3249-python](https://user-images.githubusercontent.com/674497/37451922-229533ea-2859-11e8-9a76-085c5cb8b9d1.gif)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3089

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2872


commit 971cbf6727f45da79653c3030aea35b7563f3467
Author: Prabhjyot Singh 
Date:   2018-03-15T07:58:36Z

ZEPPELIN-3089: Delete all notes for current user

Change-Id: I5cb685c7e78852f1e2bc146d988b99aaf68ae6df




---

[GitHub] zeppelin issue #2872: [ZEPPELIN-3089] Delete all notes for current user

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2872
  
@felixcheung @yu74n  can you help review this


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
I have created a new PR https://github.com/apache/zeppelin/pull/2872. Let 
me know if that makes sense, I can close that if required. Have created new as 
this was stale for 3+ months.


---

[GitHub] zeppelin issue #2872: [ZEPPELIN-3089] Delete all notes for current user

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2872
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2873: ZEPPELIN-3340 Streaming support in builtin visualizati...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2873
  
Tried on local, works well. LGTM!


---

[GitHub] zeppelin pull request #2885: [ZEPPELIN-3001] Disable ace editor code complet...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2885

[ZEPPELIN-3001] Disable ace editor code completion when backend interpreter 
support completion

### What is this PR for?
This is what I see in zeppelin and jupyter. The difference is due to 
zeppelin also add code completion of ace editor. I think code completion of ace 
editor should only be enabled when the backend interpreter doesn't support 
completion.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3001](https://issues.apache.org/jira/browse/ZEPPELIN-3001)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3001

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2885


commit adaabcbf922eb2ab2476b4209e0e29b97fb4229d
Author: Prabhjyot Singh 
Date:   2018-03-20T10:48:44Z

ZEPPELIN-3001: Disable ace editor code completion when back-end interpreter 
support completion

Change-Id: I315ff17c6f50ad3ad912a38366833823e5241574

commit 34b7f61848bd991097f390d7068c22255f9b8606
Author: Prabhjyot Singh 
Date:   2018-03-21T11:59:31Z

get completionSupport from interpreter (backend)

Change-Id: Id03ba92143dfe4743e7c7b66c92ef4263df4d569




---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
That sounds like nothing came back from the backend, can you check your 
WebSocket messages for "op= COMPLETION_LIST", then look under data.completions, 
that should be an empty array. 

Right now this PR is suppressing the default (BasicAutocompletion) 
completion if `completionSupport` is set to `true` for a given interpreter, 
should I change this to, if the return list is empty, then show the basic 
autocompletion?


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
@felixcheung agreed, but at least it gives back something basic.


---

[GitHub] zeppelin pull request #2888: [minor] Escape string before insertion it into ...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2888

[minor] Escape string before insertion it into HTML

### What is this PR for?
In current implementation some of the unescaped HTML get passed to frontend 
via BootstrapDialog, this PR is to escape those string (and sanitize the 
output).

### What type of PR is it?
[Improvement]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin 
applyEscapeBootstrapDialog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2888


commit 757cfff91ddb55d50351fbd3868826f3aafbd7e2
Author: Prabhjyot Singh 
Date:   2018-03-22T09:15:09Z

apply _.Escape to BootstrapDialog

Change-Id: I192b4dc57243feef9e027848ee7f5b934b77bb1e




---

[GitHub] zeppelin issue #2888: [minor] Escape string before insertion it into HTML

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2888
  
@r-kamath @zjffdu can you help review this.


---

[GitHub] zeppelin issue #2888: [minor] Escape string before insertion it into HTML

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2888
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2888: [minor] Escape string before insertion it into HTML

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2888
  
Angular template take care of these. In future, we need to watch for any 
javascript variables that can directly render html, like in this case it was 
most of the BootstrapDialog calls.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
Sure I was able to repro your issue, have pushed another commit with the 
fix.


---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2894
  
@zjffdu  sure, I've created a new JIRA 
https://issues.apache.org/jira/browse/ZEPPELIN-3369


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
I didn't know this, there is a difference is spark, let me try it out.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
@zjffdu I was able to reproduce the issue that you mentioned, have made a 
fix for the same.


---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin pull request #2909: [ZEPPELIN-3384] Reduce the number of calls that...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/2909

[ZEPPELIN-3384] Reduce the number of calls that are made to 
`loginUserFromKeytab` in JDBC interpreter

### What is this PR for?
In JDBC interpreter every time `getConnection` has requested a call is made 
to `UserGroupInformation.loginUserFromKeytab` this PR is created to reduce the 
number of time it gets called.


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3384](https://issues.apache.org/jira/browse/ZEPPELIN-3384)

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3384

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2909


commit b0be2078546ec02a1868fa55e6c755f02c03c431
Author: Prabhjyot Singh 
Date:   2018-04-04T04:08:52Z

ZEPPELIN-3384: Reduce number of calls that are made to 
`UserGroupInformation.loginUserFromKeytab`

Change-Id: I4f6b983ff83aaa840e0c54deea9c315e29b1331f




---

[GitHub] zeppelin issue #2909: [ZEPPELIN-3384] Reduce the number of calls that are ma...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2909
  
@zjffdu @felixcheung  Can you help review this.


---