[GitHub] zeppelin pull request #2124: [ZEPPELIN-2154] Support zeppelin.server.port in...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2124: [ZEPPELIN-2154] Support zeppelin.server.port in dev mo...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2124 I did, Thanks @AhyoungRyu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2234 Nice feature @tinkoff-dwh Tested and it works well. LGTM!   --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2239 Show dialog if owners field set to be empty on shiro ### What is this PR for? This PR is for a showing dialog when note's permission set `Readers/Writers` but `Owners` is empty. Currently, after merged #849, if user set `Owners` is empty, it's automatically set as the current user. So, It would be better to show a dialog before `Owners` is fill with the current user because user might think it is not intended. Plus, if a user only set `Readers` role, all field(`Writers` and `Owners`) role is filled as the current user like below. It's not necessary to our because the `Owner` role can read and write note.  ### What type of PR is it? [ Improvement ] ### What is the Jira issue? * [ZEPPELIN-2206](https://issues.apache.org/jira/browse/ZEPPELIN-2206) ### How should this be tested? 1. Turn on shiro. 2. Set permission `Writers` and `Readers` except `Owner` role. 3. Check the dialog appears ### Screenshots (if appropriate) [Before] * Set `Readers` and `Writers` except `Owners`  * Set only 'Writers`  * set only `Readers`; this screen is attached above. [After] * Set `Readers` and `Writers` except `Owners` ( Set only `Writers`; this result is same)  * Set only 'Readers`  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2206_auto_shiro Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2239 commit 3197647131a78e01f7d358145ed80ff9d7c4e188 Author: soralee Date: 2017-04-10T09:54:25Z show dialog if owners field is empty add dialog for insufficient privileges remove dialog for insufficient privileges commit b0ec2ced4cc9e612889b93507e81f91f096c5df7 Author: soralee Date: 2017-04-10T16:06:41Z remove annotaion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overla...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2133 [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in the MultiBarChart ### What is this PR for? If using the `multiChartBar`, it often occurs overlap in text. So, this PR is for preventing to overlap in text. >~~The below is the case what I updated.~~ ~~1. The xLabel generally show all of the text without rotation (less than 30).~~ ~~2. If the xLabel size is over than 30 and less than 80, the xLabel text are rotated as 90 degree and displayed.~~ ~~3. If the xLabel size is over than 80, the xLabel text are disappeared, but the tooltip is displayed.~~ >~~I have made improvements based on my thinking, so I would appreciate to give me your feedback.~~ ~~And if merged this PR, I'll update the feature so that user can use `min` and `max` variables by user on web.~~ **[Update]** To prevent overlap in xLabel text, in one way which is talked the below mentions, user who is using zeppelin could select to visualization type of xLabel such as `rotate 45 degree` or `remove`. ### What type of PR is it? [Bug Fix | Improvement ] ### What is the Jira issue? * [ZEPPELIN-1357; UI - label wrapping not done properly in charts](https://issues.apache.org/jira/browse/ZEPPELIN-1357) * [ZEPPELIN-1892; Display label vertically or horizontally smartly](https://issues.apache.org/jira/browse/ZEPPELIN-1892) * [ZEPPELIN-1370; Label overlaps - in default visualization example barchart](https://issues.apache.org/jira/browse/ZEPPELIN-1370) ### How should this be tested? 1. Run the paragraph for bank data in the `Basic Features (Spark)` notebook. 2. Execute the following query. ``` %sql select * from bank ``` 3. Use the pivot in the `Setting` toggle in the `MultiBarChart` such as the screenshots. ### Screenshots (if appropriate) **[Before]**   **[After]**  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1357_overlap_text Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2133 commit b25c9289d000c91846f24daf5cf00f840b9a8a24 Author: soralee Date: 2017-03-14T05:07:44Z prevent to overlap in text if using multiBarChart commit ce59800b7892659711da973a9b4c035da2f69010 Author: soralee Date: 2017-03-14T10:28:47Z prevent to overlap in text if using multiBarChart commit fe39dd768090d06e1400c60d56569fe6e9313e25 Author: soralee Date: 2017-03-17T04:35:51Z fix typo commit e1fd2866f00e13d043ad77f897cca5c3573e6b3d Author: soralee Date: 2017-03-17T06:32:52Z move to barchart commit 5974f417381fae64efe9e2596008ce835d453f35 Author: soralee Date: 2017-04-03T03:55:19Z remove initial defind xlabels commit d6dfcd5881cb3e2302065e1fdbb9ccc12c9e766e Author: soralee Date: 2017-04-06T07:30:21Z update select visualization xLabel commit 58d54a0003c2ffb04b60782cf4fa849823ec0dd4 Author: soralee Date: 2017-04-06T07:35:42Z remove xLabel variable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overla...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2228 Thanks for improvement @tinkoff-dwh! Let me test and I'll give you feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overla...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overla...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2133 [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in the MultiBarChart ### What is this PR for? If using the `multiChartBar`, it often occurs overlap in text. So, this PR is for preventing to overlap in text. >~~The below is the case what I updated.~~ ~~1. The xLabel generally show all of the text without rotation (less than 30).~~ ~~2. If the xLabel size is over than 30 and less than 80, the xLabel text are rotated as 90 degree and displayed.~~ ~~3. If the xLabel size is over than 80, the xLabel text are disappeared, but the tooltip is displayed.~~ >~~I have made improvements based on my thinking, so I would appreciate to give me your feedback.~~ ~~And if merged this PR, I'll update the feature so that user can use `min` and `max` variables by user on web.~~ **[Update]** To prevent overlap in xLabel text, in one way which is talked the below mentions, user who is using zeppelin could select to visualization type of xLabel such as `rotate 45 degree` or `hide`. ### What type of PR is it? [Bug Fix | Improvement ] ### What is the Jira issue? * [ZEPPELIN-1357; UI - label wrapping not done properly in charts](https://issues.apache.org/jira/browse/ZEPPELIN-1357) * [ZEPPELIN-1892; Display label vertically or horizontally smartly](https://issues.apache.org/jira/browse/ZEPPELIN-1892) * [ZEPPELIN-1370; Label overlaps - in default visualization example barchart](https://issues.apache.org/jira/browse/ZEPPELIN-1370) ### How should this be tested? 1. Run the paragraph for bank data in the `Basic Features (Spark)` notebook. 2. Execute the following query. ``` %sql select * from bank ``` 3. Use the pivot in the `Setting` toggle in the `MultiBarChart` such as the screenshots. ### Screenshots (if appropriate) **[Before]**   **[After]**  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1357_overlap_text Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2133 commit 67e739c0fc7f6ffbf36812c5c6970feb6e2f1c2f Author: soralee Date: 2017-03-14T05:07:44Z prevent to overlap in text if using multiBarChart commit a47804bf2cd443e232ec11fc6cdd3727a83ed5ba Author: soralee Date: 2017-03-14T10:28:47Z prevent to overlap in text if using multiBarChart commit e5c7ac6d312913ba4b5b23ab7aafe40f7f6fb3e3 Author: soralee Date: 2017-03-17T04:35:51Z fix typo commit cd033ff336e0c2cd249ea30bdd36e5af8fade4c2 Author: soralee Date: 2017-03-17T06:32:52Z move to barchart commit 668702cec76bc920604066d7f6a3b14edada2daa Author: soralee Date: 2017-04-03T03:55:19Z remove initial defind xlabels commit 08411326289c89a9773402972faffd2031b72a84 Author: soralee Date: 2017-04-06T07:30:21Z update select visualization xLabel commit 7ec879c921e1f81c6fd6709c8c8cbeb342b0e8ad Author: soralee Date: 2017-04-06T07:35:42Z remove xLabel variable commit c3ececdc3c7c06d216fe55858a796c2afcd838f6 Author: soralee Date: 2017-04-11T00:51:59Z change remove to hide --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2234 @tinkoff-dwh, Could you rebase for resolving conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2228 @tinkoff-dwh, Before testing, could you rebase for resolving conflicts, too? :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2244: [MINOR] fix typo from 'interpeter' to 'interpre...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2244 [MINOR] fix typo from 'interpeter' to 'interpreter' ### What is this PR for? Fix typo from `interpeter` to `interpreter` ### What type of PR is it? [Improvement] ### What is the Jira issue? * No, it's minor issue ### How should this be tested? - N/A ### Screenshots (if appropriate) - N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin typo_interpreter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2244.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2244 commit 863dc4fb09d35f0e503124b45990eb695649b527 Author: soralee Date: 2017-04-11T00:43:03Z fix typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2228 Thanks @tinkoff-dwh for quick resolving! Let me check again if CI become green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2228: [ZEPPELIN-2365] button to create note into folder
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2228 Tested and it's work well, LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2248 [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboard ### What is this PR for? This PR is for that eliminate the `ctrl+L` shortcut keyboard. This function is what the ace editor defined. ### What type of PR is it? [Improvement] ### What is the Jira issue? * [ZEPPELIN-2396](https://issues.apache.org/jira/browse/ZEPPELIN-2396) ### How should this be tested? * Press `Ctrl + L` key and check if showing the dialog or not ### Screenshots (if appropriate) [Before]  [After]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2396_ctrl_l Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2248 commit 4e1b8465a84099efff077e6767d643ee148a4fad Author: soralee Date: 2017-04-13T04:49:11Z ZEPPELIN-2396 drop the Ctrl+L shortcut keyboard --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' shortcut keyboa...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2248 @1ambda Thanks for review! Yeah, it's make sense. Let me update `command+L` and the document --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' keyboard shortc...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2248 I added `command+L` and changed `Alt` and `Option` feature to flexibly remove some binding shortcut key. And, I updated the document as your comment. Could you review again @1ambda ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Thanks for review! Right! Label would be better :+1: Let me update again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2248 @1ambda I just updated it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' ...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2248 [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboard shortcut ### What is this PR for? This PR is for that eliminate the `Ctrl/Command+L` shortcut keyboard. This function is what the ace editor defined. ### What type of PR is it? [Improvement | Document] ### What is the Jira issue? * [ZEPPELIN-2396](https://issues.apache.org/jira/browse/ZEPPELIN-2396) ### How should this be tested? * **Improvement** - Press `Ctrl + L` key and check if showing the dialog or not * **Document** - Run document development mode and check [this document](http://localhost:4000/install/upgrade.html#upgrading-from-zeppelin-07-to-08) ### Screenshots (if appropriate) [Before]  [After]  [Document]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, I did. Please review [this document](http://localhost:4000/install/upgrade.html#upgrading-from-zeppelin-07-to-08) if you run document development mode (localhost:4000) You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2396_ctrl_l Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2248 commit 4e1b8465a84099efff077e6767d643ee148a4fad Author: soralee Date: 2017-04-13T04:49:11Z ZEPPELIN-2396 drop the Ctrl+L shortcut keyboard commit 5f30fe473b6b893895d038d5d5a3468820c4ad2d Author: soralee Date: 2017-04-14T10:08:34Z upgrade eliminate keyboard shortcut feature and add document commit 928f179821642c7ccb4fda5deec6b778322cbd6f Author: soralee Date: 2017-04-15T04:49:04Z add space between + and who is providing commit d1f966a36c759a87398d65284afb09d1d8f7bb48 Author: soralee Date: 2017-04-15T05:00:42Z modify document commit bb0f7d8223d6516e037215c552fcd62792accfb3 Author: soralee Date: 2017-04-15T05:01:40Z modify document --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' ...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo I added label and default variable furthermore, I changed from radio to button like this.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @felixcheung Thanks for review! Yeah, you're right. It would be better if we also check on the REST API side stably. So, let me create a JIRA ticket and revert code in `REST API`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Yeah, this CI problem is related in #2255 if merging #2255, I'll rebase this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Ready to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 Hi, @felixcheung :slightly_smiling_face: I added JIRA url about this improvement in this PR description and I reverted some code in `notebook Rest API` side except that, if only setting `Readers` role, all field(Writers and Owners) role is filled as the current user. Because the `Owners` role can already read and write note, we don't need to fill in `Writers` role. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2260 @1ambda Thanks for fixing! Let me check this and I'll leave a comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2234 @Leemoonsoo could you review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @felixcheung Thanks for detail suggestion! That's sounds good. Let me update as each comment. @1ambda Sure, I agree! I'll remove `!!!` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2260 @1ambda Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @1ambda Thanks for information always :+1: I already worked to rebase and run build successfully, but now, I'm checking the `white space` problem. Let me updated ASAP! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 I modified dialog title and `OK` button. I've checked the `whitespace` and the `$scope.permissions.owners` array don't insert `whitespace` originally. But for stability, I added `if statement`. @felixcheung, @1ambda could you guys review this again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2239 Show dialog if owners field set to be empty on shiro ### What is this PR for? This PR is for a showing dialog when note's permission set `Readers/Writers` but `Owners` is empty. Currently, after merged #849, if user set `Owners` is empty, it's automatically set as the current user. So, It would be better to show a dialog before `Owners` is fill with the current user because user might think it is not intended. Plus, if a user only set `Readers` role, all field(`Writers` and `Owners`) role is filled as the current user like below. It's not necessary to our because the `Owner` role can read and write note.  ### What type of PR is it? [ Improvement ] ### What is the Jira issue? * [ZEPPELIN-2206; Be added a writer account when adding a reader account on Shiro](https://issues.apache.org/jira/browse/ZEPPELIN-2206) * [ZEPPELIN-2418; show dialog if user set to the empty owner permission](https://issues.apache.org/jira/browse/ZEPPELIN-2418) ### How should this be tested? 1. Turn on shiro. 2. Set permission `Writers` and `Readers` except `Owner` role. 3. Check the dialog appears ### Screenshots (if appropriate) [Before] * Set `Readers` and `Writers` except `Owners`  * Set only 'Writers`  * set only `Readers`; this screen is attached above. [After] * Set `Readers` and `Writers` except `Owners` ( Set only `Writers`; this result is same)  * Set only 'Readers`  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2206_auto_shiro Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2239 commit af4ff29be8a20f597670e7610305d5956243ac2e Author: soralee Date: 2017-04-10T09:54:25Z rebase master and revert notebookRestApi commit 047029944014c606f25df6b0c3b4fe82a394caca Author: soralee Date: 2017-04-20T05:05:07Z modify title of dialogs commit 3913e00f07a3bfeae802043dcbb93857d6c6ab14 Author: soralee Date: 2017-04-20T06:05:59Z rebase notebook.controller commit 783fd948a4dc87d07fb581a957fb9933fb504542 Author: soralee Date: 2017-04-20T08:34:15Z add to check whitespace commit 5ed8b26c47859a01286f1dbf40b11008916a06dc Author: soralee Date: 2017-04-20T09:03:51Z add to check whitespace commit ea274830bbf0dd81389c99f20630565f3feefec4 Author: soralee Date: 2017-04-20T09:24:10Z add if statement for checking whitespace --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2260: [ZEPPELIN-2408] Should use $uibTooltip instead of $too...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2260 @1ambda could you rebase this PR? :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2274 [ZEPPELIN-2388] Improve the keyboard shortcuts dialog ## What is this PR for? This PR is for Improving the keyboard shortcuts dialog form and here is what i improve. - change to table shape - add scrollbar - fixed that text is misaligned when resizing windows ## What type of PR is it? [Bug fix | Improvement] ## What is the Jira issue? * [ZEPPELIN-2388; Prettify Keyboard Shortcut Dialog](https://issues.apache.org/jira/browse/ZEPPELIN-2388) ## How should this be tested? 1. Click `Keyboard Shortcuts' icon in a paragraph. 2. Check `Keyboard Shortcuts` shape. 3. Check resizing windows. ## Screenshots (if appropriate) ### [Before - default]  ### [Before - 1. text is misaligned when resizing windows]  ### [Before - 2. not scrollbar]  ### [After - 1. default]  ### [After - 2. resizing windows (my image is a little broken.)]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2388_shortcut_key Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2274 commit 6ce8954ebfc671e863c85af34353d8bd87bc14e7 Author: soralee Date: 2017-04-21T10:20:49Z improve the keyboard shortcuts dialog --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 @kun @Leemoonsoo Could you guys review this PR, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2270 @1ambda Let me test and come back here :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thank you @1ambda @felixcheung for seeing this! Yeah, I like @1ambda's opinions! Let me update those as @1ambda's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2270: [ZEPPELIN-2409] DON'T block body scrolling in results ...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2270 Tested and it's work nicely! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Thanks @tae-jun for seeing :slightly_smiling_face: And, @1ambda I updated this as your comments!  Could you review again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 @felixcheung Thanks for your opinion :+1: Let me update this like your describe! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @felixcheung Thanks for review and useful comments! I initially think something wrong. Let me modify this part again! Thanks a lots! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 I updated as @felixcheung suggestion such as the following screenshot! Could @felixcheung check it again, please?  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2151 Hi,@Remilito. I think now you needed a doing rebase. Could you rebase it, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @khalidhuseynov Thanks for comments! You mean, this can be occurred another problem like the following steps. 1. A user who has admin permissions sets `readers` and `writers` and empty `owners` roles in `Note permissions'. 2. The user clicks 'Save' button in `Note permissions` 3. The user clicks `Cancel button` in the new dialog(`Setting Owners Permissions`) which I made. 3. then, the default `owners` value is disappeared. 4. and, the user add `user1` to `owners` role and click 'Save' button. As my understanding your comment, this 3 and 4 steps can be a problem. right? @khalidhuseynov, Could you check what I understood correctly, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @khalidhuseynov thanks for checking it really! You're right! I think so too! this should be considered. Furthermore, I checked above steps which I addressed, I saw that zeppelin run strange operation. Let me improve it so that it does not disappear. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @khalidhuseynov Thanks for opinion! Yeah, I see. This PR is for showing a dialog when (already existing backend logic) that note's permission set Readers/Writers but Owners is empty. I think I would better to focus the purpose! So, next step is that I'd like to update this PR as @felixcheung addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 @felixcheung I updated as your advice! @khalidhuseynov I added a logic which is reverted with old value if user cancel button like above `4 step`. How about this? > 4. then, the default owners value is disappeared.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2275: [ZEPPELIN-2442] button to create note into folder (nav...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2275 I tested long folder name and LGTM!  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 @1ambda Thanks, I did. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 CI failed but irrelevant. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce... SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException... ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2309 Thanks @tinkoff-dwh and nice feature! Let me test and come back here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2327: [ZEPPELIN-2520] DON'T set bottom margin for markdown t...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2327 Nicely fixed bug! Let me test and give you feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2328: [ZEPPELIN-2521] fix: Confusing axis description in adv...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2328 Let me test it out. Thanks @1ambda for fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2339: [ZEPPELIN-2430] The xAxis text in the line and ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2339 [ZEPPELIN-2430] The xAxis text in the line and area chart overlaps ### What is this PR for? Like in the #2133 case, the xAxis text of area chart and line chart is overlapping. For reusing form, I created a html template file for how to show xLabel and, in `rotate` button checked, show up `input` box for set value of rotate degree. ### What type of PR is it? [Bug Fix | Improvement] ### What is the Jira issue? * [ZEPPELIN-2430 - The xlabel text in the line and area graph overlaps](https://issues.apache.org/jira/browse/ZEPPELIN-2430) ### How should this be tested? 1. Click `settings` button in the barChart 2. Check to whether there are `default`, `rotate`, `hide` button or not. 3. Test to click each button and whether it works well or not for each situation. 4. In rotate button checked, check to set value and showing xAixs rotate degree properly. 5. In the areaChart and lineChart, test with above steps. ### Screenshots (if appropriate) [Before]   [After]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2430_overlap_line_area Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2339 commit 59fa755522953e7a03a0164cdb150b7171adce37 Author: soralee Date: 2017-05-08T08:16:15Z fix area chart commit 3f500e37da3f5160493c86f893b1e0725876e49c Author: soralee Date: 2017-05-12T03:25:08Z create template and apply area and line chart --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2339: [ZEPPELIN-2430] The xAxis text in the line and area ch...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2339 CI fail is irrelevant this PR. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce... SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException... Tests run: 58, Failures: 5, Errors: 2, Skipped: 1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2309 In `Font size and clone` and firefox browser case, I tested and it's work well. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2327: [ZEPPELIN-2520] DON'T set bottom margin for markdown t...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2327 Tested and it's work well. My result are exactly same the above `after and before` screenshots. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 Ping! And this CI fail is irrelevant this PR. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce... SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException... Tests run: 58, Failures: 5, Errors: 2, Skipped: 1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2274 Ping! And this CI fail is irrelevant this PR. ``` Tests in error: SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce... SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException... Tests run: 58, Failures: 5, Errors: 2, Skipped: 1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2325: [ZEPPELIN-2516] Set offset, tolerance for navbar, acti...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2325 @1ambda Sorry for my late test! Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2328: [ZEPPELIN-2521] fix: Confusing axis description in adv...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2328 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2335 Of course! Let me test #2340 out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2340: [ZEPPELIN-2426] Improve graph setting DOMs
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2340 Teset and LGTM! It's really good improvement for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 Hi, there. CI became green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2339: [ZEPPELIN-2430] The xAxis text in the line and area ch...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2339 I removed `ng-include` in bar chart and area char. the `ng-include` in line chart couldn't remove now because there are other `html` source. (I think to improve a logic is other problem.) @moon, could you review again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2339: [ZEPPELIN-2430] The xAxis text in the line and area ch...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2339 Fixed CI : https://travis-ci.org/soralee/zeppelin/builds/232368042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2346 Nicely Improvement it, Thanks @AhyoungRyu! But, tested and I found a bug which if I moved a last page, the page buttons is disappeared so, I couldn't move to before pages. I attached the following screenshot. [Before]  [After]  Could you confirm this problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2345: [MINOR] Hide pagination button if there is only 1 page...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2345 Tested and I'd like to leave a comment for I found [bug which it's same](https://github.com/apache/zeppelin/pull/2346#issuecomment-301693168). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2338: [ZEPPELIN-2122] Add execution time for Spell
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2338 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 Ping! @felixcheung @khalidhuseynov @1ambda, could you guys confirm again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2344: [ZEPPELIN-2545] [ZEPPELIN-2546] SecurityRestApiTest, N...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2344 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2357 @1ambda, Sure! Nice feature! Let me test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 @1ambda Thanks for improving dialog! I'll test it out and give you a feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2359 @1ambda I'll test it out and give you a feedback! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 @1ambda Thanks for improving dialog! I'll test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 About `clone note` and `create note`, both look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2361 @1ambda could you check uploaded `before/after` image files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2361 @1ambda Thanks for checking and improvement this! Let me test it out ASAP! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2359 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2357 LGTM!  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2376: Branch 0.7
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2376 Hi, @simulight. If you want to improve zeppelin about your idea, could you create a JIRA ticket? And, this branch is fault. could you close this PR, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2381: [WIP] [ZEPPELIN-2583] Updating offcial main web...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2381 [WIP] [ZEPPELIN-2583] Updating offcial main website ## What is this PR for? This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage. To sum up, `Technologies` section is consist of 3 interpreters most people search or want (already talking about this on the mailing list.) and, `Deployments` section describes single or multiple user setting. Please check **TODO** list and Screenshots for detail. Plus, note that this PR is related #2371 PR. ## What type of PR is it? [Improvement ] ## Todos * [x] - change navigation bar items. - add `Quick Start` - move `Community` and add `Github` in here * [x] - remove 'Apache Aeppelin' title in the blue section and change button. - `Get Started` and `Download` * [x] - add form and mouse event css for quick interpreter links section (Technologies). * [x] - add form and css for user setting option (Deployments). * [ ] - connect to each quick links. (@1ambda, could you review about this, please?) * [ ] - adding zeppelin log image in the blue section. ## What is the Jira issue? * [ZEPPELIN-2583](https://issues.apache.org/jira/browse/ZEPPELIN-2583) ## How should this be tested? 1. run `bundle exec jekyll serve --watch` in this branch 2. open `localhost:4000` ## Screenshots (if appropriate) ### 1. overall shape  ### 2. changed navigation  ### 3. Technologies  ### 4. Deployments  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, this is You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin updating-offcial-Main-Website Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2381.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2381 commit 4a4f24527f8abd4c45f979ea10525449fd56b277 Author: soralee Date: 2017-05-29T11:01:24Z initial updating to main homepage commit 998c745f2748007d074c0e7102254eb0aef6e7fe Author: soralee Date: 2017-05-30T18:13:14Z change button and quick interpreter and user setting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 Thanks @1ambda :+1: Let me test it out ASAP! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Wow, @1ambda, thanks a lots for review! I'll improve as your comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Hi, all. There are many feedback in here so, I've arranged the following TODO list for sharing progress. 1) in blue section - [x] add zeppelin logo in the blue section - [x] fix to bug about misalign apache zeppelin text and icon - [ ] change `Get started` button hover color - [ ] connecting a link to `Get started` button 2) regarding to improve navbar - [ ] apply style - [ ] change border color - [ ] change background color and text style - [ ] fix not fully hovered color 3) regarding to improve layout - [x] when resizing window - [x] change multi-user icon - [ ] improve what's new section 4) in technologies section - [x] set more bigger text in technologies - [ ] apply sql font - [ ] connecting quick start links 5) in deployments section - [x] change title for user setting option (single user, multi user) - [ ] connecting quick start links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 I'm improving navigation bar but, I found two bug in navigation bar. so we should resolve those issues together. 1. when resizing window, drop-toggle is appeared.  2. after using navigation bar in small window, and then drop-toggle place is misaligned in big window.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 one more bug problem, if I escape `download` menu, color still leaves active color.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Hi, finally I finished the above To-do list. @1ambda @Leemoonsoo Could you confirm this, again? For now, the quick links is connected with 0.8.0-SNAPSHOT documentation. @Leemoonsoo could you advice this, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 @AhyoungRyu Thanks for your opinions! But, Sorry for sending disagreement message. First, `Navbar` part is that the basis is #2371 PR. We should match this new feature and, I think font and shadow of `navbar` is better than before. And `Main` part is that `Apache Zeppelin` takes currently the position too much and, many `Apache Zeppelin` is placed in main page. Also, a user already know this page is `Apache Zeppelin` page so, we don't need to put `Apache Zeppelin` big font. furthermore, I think it is more important to inform the sentence which is placed in under `Apache Zeppelin` to users. Therefore, this PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage. So I don't agree that PR is separated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 Sorry for my late response I quickly checked some navbar bug about https://github.com/apache/zeppelin/pull/2381#issuecomment-305451690 and https://github.com/apache/zeppelin/pull/2381#issuecomment-305705051 in #2381. and this branch has same those bugs. @1ambda, could you check those bugs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381  this part is different between #2371. Let me update to match it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Um.. So, for quickly review, I'll separate this PR to 2 PR. 1. updating navbar and main sections. 2. adding technologies and deployments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2394 [gh-pages] [ZEPPELIN-2597] adding technologies and deployments (Main Page) ### What is this PR for? This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage. To sum up, Technologies section is consist of 3 interpreters most people search or want (already talking about this on the mailing list.) and, Deployments section describes single or multiple user setting. ### What type of PR is it? [Improvement] ### What is the Jira issue? * [ZEPPELIN-2597](https://issues.apache.org/jira/browse/ZEPPELIN-2597) ### How should this be tested? 1. run `bundle exec jekyll serve --watch` in this branch 2. open `localhost:4000` ### Screenshots (if appropriate) - Look `Technologies` and `Deployments` sections  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, this is. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin adding_technologies_and_deployments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2394.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2394 commit b8105cd3c09a8c2b56e190a4e18fb64a2c7b114d Author: soralee Date: 2017-06-05T06:08:14Z adding technologies and deployments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 @1ambda, @Leemoonsoo, @AhyoungRyu, I created a PR regrading `Technologies and Deployments` #2394. Let me make a remainder PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @AhyoungRyu @1ambda @Leemoonsoo, please review again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @sravan-s, I've fixed to match font size as your mention. Regarding of `uniform margin / padding scheme` I tried to fit the box ratio. could you check this if you have time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda , I've update regarding of `7.Improve layout for mobile browsers.` could you confirm, again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
