[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1902 @jaspinderdineout This was merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1905: [ZEPPELIN-1974] Remove extension from webpack config f...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1905 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't transfile im...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2071 CI failed, but irrelevant. - profile: https://travis-ci.org/1ambda/zeppelin/builds/205664772 - failed log1: https://s3.amazonaws.com/archive.travis-ci.org/jobs/205664774/log.txt - failed log2: https://s3.amazonaws.com/archive.travis-ci.org/jobs/205664775/log.txt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2037: [ZEPPELIN-2109][2110] Sortable Helium pkgs & Introduce...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2037 I will review and comment soon. Great Feature! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2077: [ZEPPELIN-2191] Helium package should be able to impor...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2077 CI failed, but irrelevant. - build profile: https://travis-ci.org/1ambda/zeppelin/builds/206002571 - failed log1: https://s3.amazonaws.com/archive.travis-ci.org/jobs/206002573/log.txt - failed log2: https://s3.amazonaws.com/archive.travis-ci.org/jobs/206002574/log.txt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2074: ZEPPELIN-2148: On creation of Bar graph zeppelin UI sh...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2074 Sure. I will test and give you feedback soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1887: [ZEPPELIN-1940] most of eslint rules are NOT applied a...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1887 @AhyoungRyu Thanks for caring this! - It would be easier to start from scratch i think. ð - I will work on after #1982 is handed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2077: [ZEPPELIN-2191] Helium package should be able to impor...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2077 @AhyoungRyu Thanks for cool review ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't transfile im...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2071 @AhyoungRyu It's because invalid `.babelrc`. - https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/.babelrc Thanks for detailed review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2054: [ZEPPELIN-2113] Remove border and margin of Link this ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2054 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't trans...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2071 [ZEPPELIN-2166] HeliumBundleFactoty can't transfile imported es6+ ### What is this PR for? Currently, we don't use any preset. This cause error messages like when a helium package imports another packages which include es6+ syntax. ``` SyntaxError: Unexpected token import at helium.service.js:36 at angular.js:10973 at processQueue (angular.js:15552) at angular.js:15568 at Scope.$eval (angular.js:16820) at Scope.$digest (angular.js:16636) at Scope.$apply (angular.js:16928) at done (angular.js:11266) at completeRequest (angular.js:11464) at XMLHttpRequest.requestLoaded (angular.js:11405) ``` - https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/examples/example-highcharts-columnrange/index.js#L3 - https://github.com/1ambda/zeppelin-advanced-transformation/blob/master/index.js#L11 ### What type of PR is it? [Improvement] ### Todos * [x] - Install required NPM packages * [x] - fix babel configuration ### What is the Jira issue? [ZEPPELIN-533] ### How should this be tested? - Should be able to bundle existing helium vis - Should be able to bundle https://github.com/1ambda/zeppelin-advanced-transformation/tree/master/examples/example-highcharts-columnrange ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NONE * Is there breaking changes for older versions? - NONE * Does this needs documentation? - NONE You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2166/fix-webpack-config-for-es6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2071.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2071 commit 00a0afe12250db36290acb11d7e8f94aa30822bd Author: 1ambda <1am...@gmail.com> Date: 2017-02-27T02:35:38Z fix: Update babel configuration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1982: [ZEPPELIN-2069] Helium Package Configuration
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1982 I'v just rebased to resolve conflict ## Newly added commits - Remove `local` values in helium package jsons: https://github.com/apache/zeppelin/pull/1982/commits/ce5f8c0c0f88de79bd9c4172a5d74066c9345a50 - DON't refresh `helium.json` when fetching spell config to reduce execution time: https://github.com/apache/zeppelin/pull/1982/commits/dbc4f10fd3ee556d5e38cb4f6e391eaf69a9 @Leemoonsoo Could you help review? Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2077: [ZEPPELIN-2191] Helium package should be able t...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2077 [ZEPPELIN-2191] Helium package should be able to import css ### What is this PR for? Helium package should be able to import css. For example, - Someone want to create spell using jsoneditor (https://github.com/josdejong/jsoneditor/blob/master/docs/usage.md). In this case, he/she should import like this ```js import 'jsoneditor/dist/jsoneditor.min.css' import JSONEditor from 'jsoneditor/dist/jsoneditor.min.js' ``` **This PR is written based on #2071, so duplicated commit will be dropped. Please review the commit 505c7db only.** ### What type of PR is it? [Improvement] ### Todos * [x] - denote required packages in `package.json` * [x] - setup `webpack.config.js` ### What is the Jira issue? [ZEPPELIN-2191](https://issues.apache.org/jira/browse/ZEPPELIN-2191) ### How should this be tested? Should be able to bundle [zeppelin-echo-spell](https://github.com/1ambda/zeppelin-json-spell) ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2191/import-css-in-helium-pkg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2077.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2077 commit 00a0afe12250db36290acb11d7e8f94aa30822bd Author: 1ambda <1am...@gmail.com> Date: 2017-02-27T02:35:38Z fix: Update babel configuration commit 505c7dbb51a80253704c9fc0b29d2c2f154be378 Author: 1ambda <1am...@gmail.com> Date: 2017-02-27T23:45:19Z fix: Import css globally in helium package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo I think **option 2** (Adding a property) is a better solution. because 1) Adding a new interpreter just for support another markdown parser might be confusing to users 2) Pegdown parser will be able to replace markdown4j parser soon if we implement YUML and Websequence. At that time, we can just modify the parser property of `md` interpreter instead of requesting for users to change their interpreter type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 I'v restored markdown4j parser and add `markdown.parser.type` property to `md` group. Pegdown parser will be used only if user specify `pegdown` property value. https://cloud.githubusercontent.com/assets/4968473/18211602/66b9cf9c-7179-11e6-8506-9ae6fcfbfe3b.png;> One more question. It seems that `description` does't show even if i already provide in `markdown/src/main/resources/interpreter-setting.json` like ```json [ { "group": "md", "name": "md", "className": "org.apache.zeppelin.markdown.MarkdownInterpreter", "properties": { "markdown.parser.type": { "envName": "MARKDOWN_PARSER_TYPE", "propertyName": "markdown.parser.type", "defaultValue": "markdown4j", "description": "Markdown Parser Type. Available values: markdown4j, pegdown. Default = markdown4j" } } } ] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu Thanks for for your review and comments :) I'v updated docs and added missing license declaration in some java files. Now docs/markdown looks like https://cloud.githubusercontent.com/assets/4968473/18229076/06d5b834-72a5-11e6-994c-585def006adc.png;> https://cloud.githubusercontent.com/assets/4968473/18229096/80ba7a22-72a5-11e6-8c8c-46a105e2bf96.png;> https://cloud.githubusercontent.com/assets/4968473/18229083/0b7b6bcc-72a5-11e6-9688-c1f0238634c4.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1384: [ZEPPELIN-1387] Support table in markdown inter...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1384 [ZEPPELIN-1387] Support table in markdown interpreter ### What is this PR for? Support markdown syntax issued by [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. ### Todos * [ ] - Check the license issue of the [pegdown](https://github.com/sirthias/pegdown) library introduced by this PR ### What is the Jira issue? [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### How should this be tested? Write markdown texts and compare them with expected html DOMs ### Screenshots (if appropriate) https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png;> ### Questions: * Does the licenses files need update? * Does coding style is appropriate? You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 029f550a04721c786b1d0021ac9551f2a6e62aed Author: 1ambda <1am...@gmail.com> Date: 2016-08-29T17:44:21Z [ZEPPELIN-1387] Support table in markdown interpreter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo I'v fixed license description. Also, now I understand when to describe licenses to `licenses` or `bin_licenses`. Thanks. :) @bzz I think it is better to use more specific exception types in catch block as you pointed out. Could you review e08929a again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu It was due to the `ANCHORLINK` option in pegdown. I removed it. ![markdown gif](https://cloud.githubusercontent.com/assets/4968473/18173464/a18a4d66-70a4-11e6-95b7-7d030e93cf2b.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Now markdown table looks like https://cloud.githubusercontent.com/assets/4968473/18141148/54414ab6-6ff3-11e6-897d-94dab08e6516.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @Leemoonsoo Thanks! I'v added missing transitive deps and removed unused markdown4j dep. I also found that `org.ow2.asm:asm:jar:3.0.1` is described in `zeppelin-distribution/src/licence_bin/LICENSE` But already denoted license is different version (3.0.1) compared to pegdown's dependency (5.0.3). Should I updated `org.ow2.asm:asm:jar:3.0.1` to `org.ow2.asm:asm:jar:5.0.3`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 https://cloud.githubusercontent.com/assets/4968473/18679870/5ae08dec-7f9c-11e6-8c61-91e87bad5ed9.png;> CI is failing on only the last job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 @AhyoungRyu I'v resolved the merge conflict with 8f344db. Could you try again? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Now CI is failing on the third build job. :( I checked out `zeppelin/master` and merged it on `1ambda/fix-zeppelin-1387`. Should I have use git `rebase` command instead? I thought using `rebase` command will overwrite this PR history (comments, etc...) https://cloud.githubusercontent.com/assets/4968473/18695206/2afb0c0c-7feb-11e6-8d94-119a456876a0.png;> https://cloud.githubusercontent.com/assets/4968473/18695207/2cd2ce8e-7feb-11e6-961d-5292d58513cf.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1384: [ZEPPELIN-1387] Support table syntax in markdow...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1384 [ZEPPELIN-1387] Support table syntax in markdown interpreter ### What is this PR for? Support table markdown syntax issued by [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### What type of PR is it? [Bug Fix | Improvement] This PR can be categorized as bug fix and improvement since it not only resolves the above issue but also support other markdown syntaxes. ### Todos * [ ] - Check the license issue of the [pegdown](https://github.com/sirthias/pegdown) library introduced by this PR ### What is the Jira issue? [ZEPPELIN-1387](https://issues.apache.org/jira/browse/ZEPPELIN-1387?jql=project%20%3D%20ZEPPELIN) ### How should this be tested? Write markdown texts and compare them with expected html DOMs. I'v also included some tests for this PR. ### Screenshots (if appropriate) https://cloud.githubusercontent.com/assets/4968473/18061274/1f2be526-6e5d-11e6-9f1a-3528f3958d2c.png;> ### Questions: * Does the licenses files need update? * Does coding style is appropriate? ### Additional Comments We might solve this issue by implementing custom table plugin for markdown4j by referring [the existing work of txtmark](https://github.com/zhenchuan/txtmark/commit/178486805e78e3d572b071ca8b9f8887a066edef). But I think it is not good idea in regard to coverage, maintainability and efficiency since markdown4j is currently not developed actively and it costs to implement all markdown plugins which is not supported by markdown4j. You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix-zeppelin-1387 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1384 commit 029f550a04721c786b1d0021ac9551f2a6e62aed Author: 1ambda <1am...@gmail.com> Date: 2016-08-29T17:44:21Z [ZEPPELIN-1387] Support table in markdown interpreter commit fa14b3ed75c051ad6da0e3955ef8debf4d231b13 Author: 1ambda <1am...@gmail.com> Date: 2016-08-30T15:44:13Z style: Apply google java code style guide commit 7aecdcb536a7561fb67f2e1404d4bcb3921774da Author: 1ambda <1am...@gmail.com> Date: 2016-08-30T15:55:47Z chore: Add pegdown to the binary license list commit 603d3db4068f1eed5a8647489da80c945ac23cfb Author: 1ambda <1am...@gmail.com> Date: 2016-08-31T04:18:25Z fix: Add missing transitive deps for pegdown commit f7419492adde2ad0d71e8f189b3a4ace9a80a9a8 Author: 1ambda <1am...@gmail.com> Date: 2016-08-31T18:19:20Z fix: Add styles for markdown - Wrap parsed DOM with div which has `markdown` class attr - Style them with github flavored markdown style ([github-markdown-css](https://github.com/sindresorhus/github-markdown-css)) - add [github-markdown-css](https://github.com/sindresorhus/github-markdown-css) license to `zeppelin-distribution` commit 9cf31d0bbc9db4b8be2ab1e1ca62b72c7d596cca Author: 1ambda <1am...@gmail.com> Date: 2016-09-01T14:25:26Z fix: Use markdown-body class (default) commit c33c71590ae8dd5fbe09091d95d6f81614bf3e43 Author: 1ambda <1am...@gmail.com> Date: 2016-09-01T15:28:24Z fix: Remove the ANCHORLINKS option - added some markdown syntax tests commit 55a2f1025483b8be705bfd94734c968a6acfa9ce Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:24:35Z fix: Add MarkdownParser interface to support mulitple parsers commit bf9100de31fb630ea19c61eda0f9b89f8382dd20 Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:25:03Z chore: Restore markdown4j dependency commit d2d4455118191dfc89fc789dfefecfccc4c210cb Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T14:28:50Z style: Reformat using intellij-java-google-style commit 2b6516cad31b08d12d0f2e76d3bca3a1c8209eb7 Author: 1ambda <1am...@gmail.com> Date: 2016-09-02T16:49:06Z feat: Support markdown.parser.type attr in md commit d228423d636c2d7d9ca4d8c7b7c211433c5c0706 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T04:33:49Z docs: Update markdown docs config, examples commit 947a92acf7cfef8744b28ae65695410a28179b52 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T04:36:23Z chore: Add license to newly created java files commit 297733f196aac4f0cec1077b8d6ec7a5deb09220 Author: 1ambda <1am...@gmail.com> Date: 2016-09-04T14:10:37Z fix: Modify github-markdown-css license - move the license file from `bin_license/` to `license/` - extract source code from `interpreter.css` to
[GitHub] zeppelin pull request #1384: [ZEPPELIN-1387] Support table syntax in markdow...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Close PR to re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Open PR to re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1384: [ZEPPELIN-1387] Support table syntax in markdown inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1384 Finally, CI is green! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1594: [ZEPPELIN-1614] Remove markdown4j dep
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @bzz Resolving CI failure will be next step. But i think it is not problem of markdown processor. All tests are failed in scalding interpreter test I will rebase and retrigger CI again. ``` // PROFILE="-Pspark-2.0 -Phadoop-2.3 -Ppyspark -Psparkr -Pscalding -Pexamples -Pscala-2.11" // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808635/log.txt // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808636/log.txt // https://s3.amazonaws.com/archive.travis-ci.org/jobs/173808637/log.txt [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 12.258 s] [INFO] Zeppelin: Interpreter .. SUCCESS [ 17.129 s] [INFO] Zeppelin: Zengine .. SUCCESS [ 11.340 s] [INFO] Zeppelin: Display system apis .. SUCCESS [ 19.516 s] [INFO] Zeppelin: Spark dependencies ... SUCCESS [ 44.808 s] [INFO] Zeppelin: Spark SUCCESS [ 23.799 s] [INFO] Zeppelin: Markdown interpreter . SUCCESS [ 0.594 s] [INFO] Zeppelin: Angular interpreter .. SUCCESS [ 0.270 s] [INFO] Zeppelin: Shell interpreter SUCCESS [ 0.335 s] [INFO] Zeppelin: Livy interpreter . SUCCESS [02:34 min] [INFO] Zeppelin: HBase interpreter SUCCESS [ 10.105 s] [INFO] Zeppelin: Apache Pig Interpreter ... SUCCESS [ 5.611 s] [INFO] Zeppelin: PostgreSQL interpreter ... SUCCESS [ 0.615 s] [INFO] Zeppelin: JDBC interpreter . SUCCESS [ 1.026 s] [INFO] Zeppelin: File System Interpreters . SUCCESS [ 1.140 s] [INFO] Zeppelin: Flink SUCCESS [ 8.944 s] [INFO] Zeppelin: Apache Ignite interpreter SUCCESS [ 1.168 s] [INFO] Zeppelin: Kylin interpreter SUCCESS [ 0.407 s] [INFO] Zeppelin: Python interpreter ... SUCCESS [ 0.397 s] [INFO] Zeppelin: Lens interpreter . SUCCESS [ 4.180 s] [INFO] Zeppelin: Apache Cassandra interpreter . SUCCESS [01:04 min] [INFO] Zeppelin: Elasticsearch interpreter SUCCESS [ 8.569 s] [INFO] Zeppelin: BigQuery interpreter . SUCCESS [ 4.676 s] [INFO] Zeppelin: Alluxio interpreter .. SUCCESS [ 3.305 s] [INFO] Zeppelin: web Application .. SUCCESS [01:37 min] [INFO] Zeppelin: Server ... SUCCESS [ 22.082 s] [INFO] Zeppelin: Packaging distribution ... SUCCESS [01:04 min] [INFO] Zeppelin: Scalding interpreter . FAILURE [ 1.212 s] [INFO] Zeppelin: Examples . SKIPPED [INFO] Zeppelin: Example application - Clock .. SKIPPED [INFO] Zeppelin: Example application - Horizontal Bar chart SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 Blocked until 5.1 release due to too many undocumented breaking changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 @bbonnin Thanks for the quick review :) 1. Duplicated code in `executeDeleteQuery` is due to incompatible API between 2.x and 5.x ``` // 2.x public boolean isFound() { ... } // 5.x RestStatus.NOT_FOUND != response.status()) ``` But we can extract duplicated validation logic to the base class as you mentioned. 2. @bzz, @bbonnin Regarding to update docs, Are there more files I should update? I am asking because - new maven profile is added `elasticsearch-2` (activated by default), `elasticsearch-5` - `elasticsearch-5` profile requires java 8 + --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1594: [ZEPPELIN-1614] Remove markdown4j dep
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1594: [ZEPPELIN-1614] Remove markdown4j dep
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1594 [ZEPPELIN-1614] Remove markdown4j dep ### What is this PR for? Remove unmanaged, old library markdown4j dep which exists just for Websequence and YUML plugins. (related to https://github.com/apache/zeppelin/pull/1384) By adding Websequence and YUML plugins to pegdown - Removing markdown4j dependency which is unmanaged library currently. - Addtionally, we can remove `markdown.parser.type` options in **markdown interpreter** - Fixing some bugs in Websequence and YUML plugins - Enable others to add more plugins using pegdown sytnax. ### What type of PR is it? Improvement ### Todos Nothing ### What is the Jira issue? [JIRA - ZEPPELIN-1614](https://issues.apache.org/jira/browse/ZEPPELIN-1614) ### How should this be tested? Some functional tests are included. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - YES * Is there breaking changes for older versions? - NO * Does this needs documentation? - YES You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/remove-markdown4j-dep Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1594.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1594 commit 561fc10a7560519ba6cc991a8b0772aac318be4a Author: 1ambda <1am...@gmail.com> Date: 2016-11-03T16:36:15Z feat: Support webseq markdown plugin commit 1da8826290516d6b75eaab3c45f9cdf398efc793 Author: 1ambda <1am...@gmail.com> Date: 2016-11-03T16:36:30Z feat: Yuml markdown plugin commit 294511208817ce27b25fbfafb2dcf8e45afd5a7c Author: 1ambda <1am...@gmail.com> Date: 2016-11-03T16:58:31Z fix: Add missing docs commit b73240d4850f681312c2d25bc15a8d026275f354 Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T02:34:51Z fix: Cleanup unused Markdown4j Parser commit f12ac8782518aa62e4b5f621ec0d758d0c9cc1ba Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T02:35:20Z docs: Remove markdown.parser.type option commit 8d9f7b9191e04d0503b45e9d26bc4b58b76600c2 Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T02:50:23Z chore: Remove markdown4j dep and update license commit 7c75183f3cb001f5d01d0475b52429be80a40511 Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T03:51:26Z fix: Set {} to avoid 503 commit e35a0e5e7028584bc64992d95ef39c95a11ec2d9 Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T03:56:42Z fix: Parse style param optionally in webseq commit 133d4ac9d1e3bc5f52d4c3727585863ad1d70e1c Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T06:14:37Z fix: style and misspell in docs commit cfcbbee50be0e5f870c4ad8bee6bf8c4b2d1584c Author: 1ambda <1am...@gmail.com> Date: 2016-11-04T06:28:44Z fix: Propagate exception in YUML plugin commit f2472d170b18f2b5d72199f7945df662f1e2973d Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:22:30Z Revert "fix: Propagate exception in YUML plugin" This reverts commit f704d3ef6558f1a4c82caebed5e4c6e7ba3bb825. commit ec5f8d0a81f29042ef517496ec759cf2af2a16bf Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:22:48Z Revert "fix: style and misspell in docs" This reverts commit a9c619d842db7e37aea525a77dac36cddd2d4924. commit 7b06005b956d7f546dae6a2bc354775609b8e586 Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:23:10Z Revert "fix: Parse style param optionally in webseq" This reverts commit 580233fb715fdf141adb3ea0920c143327720ef7. commit 62505293cfdbf22c8ead975e9c2cc00ad327b23c Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:24:14Z Revert "fix: Set {} to avoid 503" This reverts commit cd45d85a1e3260569b4e94e26a9b494de01f6821. commit 07c8839445023524a60ca969e89b833362bfd729 Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:24:28Z Revert "chore: Remove markdown4j dep and update license" This reverts commit 226c1e67c8b44e22c6c68679e80b0d497d5343d4. commit 32b14af23c8634e004e794af0131e1bb10530242 Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:24:47Z Revert "docs: Remove markdown.parser.type option" This reverts commit a36c86c1828ae33d967a9847d604dd539a005ff7. commit 86a478b43a9d3f56d2ff3e905512483de678a795 Author: 1ambda <1am...@gmail.com> Date: 2016-11-07T05:25:10Z Revert "fix: Cleanup unused Markdown4j Parser" This reverts commit e9fb0df57b7b5b3737b467c7c0d9a
[GitHub] zeppelin pull request #1594: [ZEPPELIN-1614] Remove markdown4j dep
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1611: ZEPPELIN-1625 - Add support of user specific propertie...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1611 Hi ð @benoyantony! I'v checked out your PR and tested, but zeppelin doesn't start rendering 503 page. ``` $ zeppelin-master git:(pr/1611) mvn clean package -DskipTests $ ... ``` https://cloud.githubusercontent.com/assets/4968473/20084622/f870f012-a5a6-11e6-89a2-c52ef0c47382.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1594: [ZEPPELIN-1614] Remove markdown4j dep
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @Leemoonsoo @felixcheung @bzz test is now green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1621: [ZEPPELIN-1650] Add mariadb, redshift configs a...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1621 [ZEPPELIN-1650] Add mariadb, redshift configs and useful links to JDBC doc ### What is this PR for? Add 2 JDBC configs and useful links to JDBC doc so that users can connect those backends easily :) ### What type of PR is it? Documentation ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1650](https://issues.apache.org/jira/browse/ZEPPELIN-1650) ### How should this be tested? See screenshots. ### Screenshots (if appropriate) https://cloud.githubusercontent.com/assets/4968473/20208653/01b1e468-a833-11e6-9166-b05d15e9a5fe.png;> https://cloud.githubusercontent.com/assets/4968473/20208654/02b49a22-a833-11e6-9b29-5a61f2b6a4bb.png;> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin jdbc-doc-improve Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1621 commit 79a5e3d731a272367094901e79eb97204f47f02e Author: 1ambda <1am...@gmail.com> Date: 2016-11-11T08:12:03Z docs: Add mariadb, redshift configs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1621: [ZEPPELIN-1650] Add mariadb, redshift configs and usef...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1621 I wanted to add drill settings in this PR but failed to test it. Could anyone recently try drill (1.8)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1598: [ZEPPELIN-1618] [WIP] Support ElasticSearch 5.0
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1598 Ref - https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_50_java_api_changes.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1538 Additionally, It would be better to - run zeppelin immediately (using `zeppelin.sh` because we can run docker as daemon mode) - allow user to modify config important config files by passing env variables. You can refer this docker init script https://github.com/wurstmeister/kafka-docker/blob/master/start-kafka.sh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1621: [ZEPPELIN-1650] Add mariadb, redshift configs a...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1621 [ZEPPELIN-1650] Add mariadb, redshift configs and useful links to JDBC doc ### What is this PR for? Add 2 JDBC configs and useful links to JDBC doc so that users can connect those backends easily :) ### What type of PR is it? Documentation ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1650](https://issues.apache.org/jira/browse/ZEPPELIN-1650) ### How should this be tested? See screenshots. ### Screenshots (if appropriate) https://cloud.githubusercontent.com/assets/4968473/20208653/01b1e468-a833-11e6-9166-b05d15e9a5fe.png;> https://cloud.githubusercontent.com/assets/4968473/20208654/02b49a22-a833-11e6-9b29-5a61f2b6a4bb.png;> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin jdbc-doc-improve Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1621 commit 2fb5db15ad5906a16cfe6fd908526cfc098eba11 Author: 1ambda <1am...@gmail.com> Date: 2016-11-11T08:12:03Z docs: Add mariadb, redshift configs commit ce24af174cab58278d6cd8647f7c60c15788ac62 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2016-11-11T17:13:20Z Make mariadb and redshift screenshots same with others commit 6009eb9c88d7faefead819fa735a75b265d00221 Author: 1ambda <1am...@gmail.com> Date: 2016-11-12T03:28:25Z docs: Add postgres section, hive2 doc link Don't make users confused when seperated postgre doc is removed commit 0aab8788a1f0baa83422bf5216caa48c307568ba Author: 1ambda <1am...@gmail.com> Date: 2016-11-14T10:35:17Z docs: Update postgres img ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1621: [ZEPPELIN-1650] Add mariadb, redshift configs a...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1629: [ZEPPELIN-1659] DON'T reset filter whenever eac...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1629 [ZEPPELIN-1659] DON'T reset filter whenever each interpreter setting is updated ### What is this PR for? Filter is cleared whenever each interpreter setting is updated. it's sometimes annoying if user wants to debugging settings (I attached GIF) ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1659](https://issues.apache.org/jira/browse/ZEPPELIN-1659) ### How should this be tested? 1. insert interpreter filter 2. update a interpreter setting 3. check whether the filter is cleared or not ### Screenshots (if appropriate) ![filter_is_cleared_everytime](https://cloud.githubusercontent.com/assets/4968473/20266522/c61410fa-aab9-11e6-8d1d-5e28748a7830.gif) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix/clear-filter-when-setting-updated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1629 commit 72bac065e8b361ef055e1b61243531c5c2f68283 Author: 1ambda <1am...@gmail.com> Date: 2016-11-14T11:44:51Z fix: DON'T reset filter When a interpreter setting is updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1629: [ZEPPELIN-1659] DON'T reset filter whenever eac...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1629: [ZEPPELIN-1569] DON'T reset filter whenever each inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1629 After fixed: ![filter_is_now_not_cleared](https://cloud.githubusercontent.com/assets/4968473/20266574/14628912-aaba-11e6-91f2-7278e243cd39.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1621: [ZEPPELIN-1650] Add mariadb, redshift configs a...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1621 [ZEPPELIN-1650] Add mariadb, redshift configs and useful links to JDBC doc ### What is this PR for? Add 2 JDBC configs and useful links to JDBC doc so that users can connect those backends easily :) ### What type of PR is it? Documentation ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1650](https://issues.apache.org/jira/browse/ZEPPELIN-1650) ### How should this be tested? See screenshots. ### Screenshots (if appropriate) https://cloud.githubusercontent.com/assets/4968473/20208653/01b1e468-a833-11e6-9166-b05d15e9a5fe.png;> https://cloud.githubusercontent.com/assets/4968473/20208654/02b49a22-a833-11e6-9b29-5a61f2b6a4bb.png;> ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin jdbc-doc-improve Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1621 commit 2fb5db15ad5906a16cfe6fd908526cfc098eba11 Author: 1ambda <1am...@gmail.com> Date: 2016-11-11T08:12:03Z docs: Add mariadb, redshift configs commit ce24af174cab58278d6cd8647f7c60c15788ac62 Author: AhyoungRyu <fbdkdu...@hanmail.net> Date: 2016-11-11T17:13:20Z Make mariadb and redshift screenshots same with others commit 6009eb9c88d7faefead819fa735a75b265d00221 Author: 1ambda <1am...@gmail.com> Date: 2016-11-12T03:28:25Z docs: Add postgres section, hive2 doc link Don't make users confused when seperated postgre doc is removed commit 0aab8788a1f0baa83422bf5216caa48c307568ba Author: 1ambda <1am...@gmail.com> Date: 2016-11-14T10:35:17Z docs: Update postgres img ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1621: [ZEPPELIN-1650] Add mariadb, redshift configs a...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1621 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1629: [ZEPPELIN-1569] DON'T reset filter whenever eac...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1629 [ZEPPELIN-1569] DON'T reset filter whenever each interpreter setting is updated ### What is this PR for? Filter is cleared whenever each interpreter setting is updated. it's sometimes annoying if user wants to debugging settings (I attached GIF) ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-1659](https://issues.apache.org/jira/browse/ZEPPELIN-1659) ### How should this be tested? 1. insert interpreter filter 2. update a interpreter setting 3. check whether the filter is cleared or not ### Screenshots (if appropriate) ![filter_is_cleared_everytime](https://cloud.githubusercontent.com/assets/4968473/20266522/c61410fa-aab9-11e6-8d1d-5e28748a7830.gif) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin fix/clear-filter-when-setting-updated Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1629.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1629 commit 72bac065e8b361ef055e1b61243531c5c2f68283 Author: 1ambda <1am...@gmail.com> Date: 2016-11-14T11:44:51Z fix: DON'T reset filter When a interpreter setting is updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1629: [ZEPPELIN-1659] DON'T reset filter whenever each inter...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1629 What if we keep filter after interpreter creation? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1621: [ZEPPELIN-1650] Add mariadb, redshift configs and usef...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1621 @AhyoungRyu Updated postgres image :) Thanks again. CI is failing but it doens't related this PR i think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1594: [ZEPPELIN-1614] Remove markdown4j dep
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1594 @bzz Please let me know if you need anything to merge this PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1623: ZEPPELIN-1625 add support for user specific properties
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1623 @benoyantony Hi, I am trying to test this feature. May I ask 2 things about this PR? - What is possible if this feature is merged in terms of usage? (e.g user scenario) - Are there another features which can be implemented upon this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 ``` 05:33:43,422 INFO alluxio.logger.type:202 - Connecting to local worker @ testing-docker-d2b67f49-f525-4c23-a9ab-36aafddcf032/172.17.0.12:42241 05:33:43,422 ERROR alluxio.logger.type:212 - java.net.ConnectException: Connection refused org.apache.thrift.transport.TTransportException: java.net.ConnectException: Connection refused at org.apache.thrift.transport.TSocket.open(TSocket.java:187) at org.apache.thrift.transport.TFramedTransport.open(TFramedTransport.java:81) at alluxio.client.block.BlockWorkerClient.connectOperation(BlockWorkerClient.java:210) at alluxio.client.block.BlockWorkerClient.connect(BlockWorkerClient.java:304) at alluxio.AbstractClient.retryRPC(AbstractClient.java:291) at alluxio.client.block.BlockWorkerClient.sessionHeartbeat(BlockWorkerClient.java:408) at alluxio.client.block.BlockWorkerClient.periodicHeartbeat(BlockWorkerClient.java:424) at alluxio.client.block.BlockWorkerClientHeartbeatExecutor.heartbeat(BlockWorkerClientHeartbeatExecutor.java:34) at alluxio.heartbeat.HeartbeatThread.run(HeartbeatThread.java:67) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) Caused by: java.net.ConnectException: Connection refused at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339) at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200) at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:182) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) at java.net.Socket.connect(Socket.java:579) at org.apache.thrift.transport.TSocket.open(TSocket.java:182) ... 13 more ``` ``` 05:33:43,416 INFO alluxio.logger.type:151 - Folder /tmp/Alluxio871779581980018644U1479706421593/ramdisk/datastore/2965139340539231725 was created! 05:33:43,417 INFO alluxio.logger.type:65 - LocalBlockOutStream created new file block, block path: /tmp/Alluxio871779581980018644U1479706421593/ramdisk/datastore/2965139340539231725/16777389 05:33:43,421 ERROR alluxio.logger.type:297 - org.apache.thrift.transport.TTransportException at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132) at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86) at org.apache.thrift.transport.TFramedTransport.readFrame(TFramedTransport.java:129) at org.apache.thrift.transport.TFramedTransport.read(TFramedTransport.java:101) at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86) at org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429) at org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318) at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219) at org.apache.thrift.protocol.TProtocolDecorator.readMessageBegin(TProtocolDecorator.java:135) at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69) at alluxio.thrift.BlockWorkerClientService$Client.recv_sessionHeartbeat(BlockWorkerClientService.java:424) at alluxio.thrift.BlockWorkerClientService$Client.sessionHeartbeat(BlockWorkerClientService.java:410) at alluxio.client.block.BlockWorkerClient$10.call(BlockWorkerClient.java:411) at alluxio.client.block.BlockWorkerClient$10.call(BlockWorkerClient.java:408) at alluxio.AbstractClient.retryRPC(AbstractClient.java:293) at alluxio.client.block.BlockWorkerClient.sessionHeartbeat(BlockWorkerClient.java:408) at alluxio.client.block.BlockWorkerClient.periodicHeartbeat(BlockWorkerClient.java:424) at alluxio.client.block.BlockWorkerClientHeartbeatExecutor.heartbeat(BlockWorkerClientHeartbeatExecutor.java:34) at alluxio.heartbeat.HeartbeatThread.run(HeartbeatThread.java:67) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) ``` ``` ERROR [04:32:57,995][] org.apache.zeppelin.cassandra.InterpreterLogic@:interpret All host(s) tried for query failed
[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1663 Let me review this PR and then give you some feedbacks. Thanks @karup1990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1647: [ZEPPELIN-1013] Don't run paragraph on selectbox chang...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1647 @Mleekko Thanks for contribution. A. CI failure is not related to this PR ``` // https://api.travis-ci.org/jobs/176444213/log.txt?deansi=true 17:44:25,594 ERROR org.apache.zeppelin.search.LuceneSearch:120 - Failed to open index dir RAMDirectory@7e1ec70e lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@169ea8d2, make sure indexing finished OK org.apache.lucene.index.IndexNotFoundException: no segments* file found in RAMDirectory@7e1ec70e lockFactory=org.apache.lucene.store.SingleInstanceLockFactory@169ea8d2: files: [] at org.apache.lucene.index.SegmentInfos$FindSegmentsFile.run(SegmentInfos.java:726) at org.apache.lucene.index.StandardDirectoryReader.open(StandardDirectoryReader.java:50) at org.apache.lucene.index.DirectoryReader.open(DirectoryReader.java:63) at org.apache.zeppelin.search.LuceneSearch.query(LuceneSearch.java:104) at org.apache.zeppelin.search.LuceneSearchTest.canNotSearchBeforeIndexing(LuceneSearchTest.java:147) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) 17:44:25,606 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 notebooks took 7ms 17:44:25,653 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 notebooks took 5ms 17:44:25,704 INFO org.apache.zeppelin.search.LuceneSearch:305 - Indexing 2 notebooks took 5ms ``` B. However, making CI green is good usually. Since reviews may not see a failed PR because of many PRs There are 2 ways to trigger CI again - (clean way) commit --amend and push HEAD --force - (easy, but not clean way) close PR and reopen C. Let me review and return some feedbacks. Thanks again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1663 @karup1990 sorry for misspelling It was **clear output** --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 @bzz Thanks for review! I didn't know about `change_scala_version.sh` but it is very important if it's affected There are many ways to compare, but i choose simple and reproduceable way so that other can to do again. - run `./dev/change_scala_version.sh` in both branch `master` and `pr1668` - create diff files - compare the above files As you can see, `change_scala_version.sh` is no relevant with this PR. ``` $ zeppelin-review git:(master) git rev-parse HEAD abe03a866fc9ac2563c057d6edc00d3ec0a7d733 $ zeppelin-review git:(master) ./dev/change_scala_version.sh 2.11 ./dev/../alluxio/pom.xml ./dev/../angular/pom.xml ./dev/../beam/pom.xml ./dev/../bigquery/pom.xml ./dev/../cassandra/pom.xml ./dev/../elasticsearch/pom.xml ./dev/../file/pom.xml ./dev/../flink/pom.xml ./dev/../geode/pom.xml ./dev/../hbase/pom.xml ./dev/../ignite/pom.xml ./dev/../jdbc/pom.xml ./dev/../kylin/pom.xml ./dev/../lens/pom.xml ./dev/../livy/pom.xml ./dev/../markdown/pom.xml ./dev/../pig/pom.xml ./dev/../pom.xml ./dev/../postgresql/pom.xml ./dev/../python/pom.xml ./dev/../r/pom.xml ./dev/../scalding/pom.xml ./dev/../scio/pom.xml ./dev/../shell/pom.xml ./dev/../spark/pom.xml ./dev/../spark-dependencies/pom.xml ./dev/../zeppelin-display/pom.xml ./dev/../zeppelin-distribution/pom.xml ./dev/../zeppelin-examples/pom.xml ./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml ./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml ./dev/../zeppelin-interpreter/pom.xml ./dev/../zeppelin-server/pom.xml ./dev/../zeppelin-web/pom.xml ./dev/../zeppelin-zengine/pom.xml $ zeppelin-review git:(master) â git diff --no-color > ~/master $ zeppelin-master git:(chore/centralize-maven-pom-versions) git rev-parse HEAD b724218c446f3f740238e528c86ee32864f46e92 $ zeppelin-master git:(chore/centralize-maven-pom-versions) ./dev/change_scala_version.sh 2.11 ./dev/../alluxio/pom.xml ./dev/../angular/pom.xml ./dev/../beam/pom.xml ./dev/../bigquery/pom.xml ./dev/../cassandra/pom.xml ./dev/../elasticsearch/pom.xml ./dev/../file/pom.xml ./dev/../flink/pom.xml ./dev/../geode/pom.xml ./dev/../hbase/pom.xml ./dev/../ignite/pom.xml ./dev/../jdbc/pom.xml ./dev/../kylin/pom.xml ./dev/../lens/pom.xml ./dev/../livy/pom.xml ./dev/../markdown/pom.xml ./dev/../pig/pom.xml ./dev/../pom.xml ./dev/../postgresql/pom.xml ./dev/../python/pom.xml ./dev/../r/pom.xml ./dev/../scalding/pom.xml ./dev/../scio/pom.xml ./dev/../shell/pom.xml ./dev/../spark/pom.xml ./dev/../spark-dependencies/pom.xml ./dev/../zeppelin-display/pom.xml ./dev/../zeppelin-distribution/pom.xml ./dev/../zeppelin-examples/pom.xml ./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml ./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml ./dev/../zeppelin-interpreter/pom.xml ./dev/../zeppelin-server/pom.xml ./dev/../zeppelin-web/pom.xml ./dev/../zeppelin-zengine/pom.xml $ zeppelin-master git:(chore/centralize-maven-pom-versions) â git diff --no-color > ~/pr1668 $ ~ diff master pr1668 2c2 < index dc31594..c4ad855 100644 --- > index 02a7ab3..c821dbb 100644 5c5 < @@ -47,7 +47,7 @@ --- > @@ -52,7 +52,7 @@ 14c14 < @@ -59,15 +59,15 @@ --- > @@ -64,15 +64,15 @@ 33c33 < @@ -75,7 +75,7 @@ --- > @@ -80,7 +80,7 @@ 43c43 < index e425f48..7e6cc2b 100644 --- > index 267eb0d..a3d0ab9 100644 56c56 < index 1885a1f..6ffd328 100644 --- > index 7ed559f..d835f91 100644 69c69 < index d70c488..95b5bf9 100644 --- > index 4e7ed2c..6be9e69 100644 82c82 < index 1e717f8..17af6bc 100644 --- > index 0fc8847..af7a926 100644 85c85 < @@ -121,27 +121,27 @@ --- > @@ -133,27 +133,27 @@ 119c119 < @@ -181,27 +181,27 @@ --- > @@ -193,27 +193,27 @@ 153c153 < @@ -217,27 +217,27 @@ --- > @@ -229,27 +229,27 @@ 188c188 < index 2f7ac3c..491a0c9 100644 --- > index ccee507..fe4a502 100644 191,192c191 < @@ -83,7 +83,7 @@ < --- > @@ -84,7 +84,7 @@ 193a193 > 201c201 < index 2dc2eef..88f09e3 100644 --- > index c4ac898..e275f6e 100644 214c214 < index 937d11a..aff1d77 100644 --- > index 83485b0..5af4ffa 100644 227c227 < index 27f5433..4cd3c7e 100644 --- > index 5d385ac..cfafbf8 100644 240c240 < index 04b6983..2eb5cab 100644 --- > index 0185bb7..9b98473 100644 253c2
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1673 @bzz I think this is cool. This will reduce build time for profiles do not test If we worry about version, we could specify in `pretest` command like `npm install karma-phantomjs-launcher@1.0.2` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 @bzz Removed styling commit. Let's see the CI result. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1662: [ZEPPELIN-1695] Enforce pom.xml style while removing u...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1662 @bzz I couldn't consider the reviewer's point of view. I will split this! Thanks again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1339 Let me also review this great PR and then give some feedbacks ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 @bzz Failed due to not the related test. I will amend commit and trigger CI again ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.105 sec - in org.apache.zeppelin.integration.ZeppelinIT Results : Tests in error: InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » ElementNotVisible El... Tests run: 18, Failures: 0, Errors: 1, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 Something is wrong. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1638: [ZEPPELIN-1666] DON'T share mutable deps, options betw...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1638 I will rebase to clean useless commits --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1668: [WIP] chore/centralize maven pom versions
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1668 [WIP] chore/centralize maven pom versions I am trying to centralising versions of libraries, plugins in pom.xml. (I need powerful CI to test this PR continuously) You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin chore/centralize-maven-pom-versions Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1668 commit 54548b9787c3bb497a05cc7a5bdcd805a4508c9a Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T07:27:38Z chore: Fix pom.xml commit b2e474e739a9cc9a338610fd34a62fc03abecedc Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T07:33:12Z chore: Fix alluxio/pom.xml - we already specified versions of enforcer, dependencies in root pom.xml commit b529a01996981e8a0f745b3e31dec6ce90649bb1 Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T07:36:40Z chore: Fix angular/pom.xml we don't need to specify enforcer, dependency plugin versions in children pom.xml commit ea0928f9200fd1911beccf4b01604e80c346d6fe Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T09:28:13Z fix: Remove plugin versions in beam/pom.xml commit bf3c3e55bcb07d5113d27d0c0e79526b26ff3a33 Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T09:37:35Z fix: library versions in beam/pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1659: [ZEPPELIN-1667] Fix maven options while updatin...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1659 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1659: [ZEPPELIN-1667] Fix maven options while updatin...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/1659 [ZEPPELIN-1667] Fix maven options while updating node, npm packages ### What is this PR for? Update maven plugin, node vesion, npm package and fix tests to make #1639 pass CI ### What is the Jira issue? Sub issue of #1639 ### Questions: Does the licenses files need update? NO Is there breaking changes for older versions? YES (front-end build tool usage changed) Does this needs documentation? YES (front-end build tool usage changed) You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin pr/1639 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1659.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1659 commit 314dcd8b45f795fef987650ffc9d6b3cd42378b7 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T07:47:42Z chore: Update frontend plugin version commit 6568960571a908854f07cc6ad4cd13982ade5e8d Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T08:05:21Z chore: Add test, build task to npm commit 532f1e697ba3f7614e444b9d2e9a28f3bcd17177 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T12:37:26Z fix(web): npm tasks in pom.xml commit f42531aff8ba5bad601bd40ea91be39f80d5bfa6 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:21:57Z chore: Update assembly plugin version commit 668a68761b1c5f48568bcddc2cffc04527a901f5 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:24:43Z chore: Set maven option using mavenrc commit 488092af94982d3da51cb1132fbab761311cc1ad Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:27:53Z chore: fix travis maven option commit e08580983f0b6b4c04f7e2a485510ae7115bc78e Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:38:10Z chore: Remove bower install root option commit 4c26211faec7822cc3b25d47dc4b53dc739ac737 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:44:55Z chore: Update node, npm version to avoid proxy error commit ca2359c5226ea25491a898d8f9b3067dbdd0bce3 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T13:50:53Z fix: Restore bower install option commit 6bb52ccace7617344033c99569464e709cd4da23 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T14:19:13Z chore: Add slient option to bower (show error only) commit ded1f2c0dc8dfeb8224a71facdc18e9d5f64ad2b Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T14:31:40Z chore: Update karma, phantom related package version commit ac40b5690d755f52914a9cc7d68139ddbec27a71 Author: 1ambda <1am...@gmail.com> Date: 2016-11-19T14:58:43Z test: fix test for jasmine-core 2.x ref - http://stackoverflow.com/questions/27680933/jasmine-have-createspy-return-mock-object commit 5e1e746d5b324189f4e2b9e66dc5d8f8fa074bfd Author: 1ambda <1am...@gmail.com> Date: 2016-11-21T02:42:36Z fix: Caching npm, bower, node directories commit 5cdd813e1570638e290457e7c03ea373741d5c8c Author: 1ambda <1am...@gmail.com> Date: 2016-11-21T03:05:53Z fix: Print warn, error log only while packing commit a2aab1f22b89b6a4a407f5d4cd155bc0a9e1860d Author: 1ambda <1am...@gmail.com> Date: 2016-11-21T03:07:28Z fix: Remove useless script commit f0fcdff352e3fc6be4a6801c40d1de4a2bb99a66 Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T04:37:11Z feat: Add start script to package.json commit d8c9d36e777e278b4e2f8c94ece0ffabfff30d4b Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T04:37:34Z docs: Update zeppelin-web/README.md commit e5b414b91a630fb8ea33ea1a8c59f3666a910dc6 Author: 1ambda <1am...@gmail.com> Date: 2016-11-22T04:49:04Z docs: Add a package installation command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1659: [ZEPPELIN-1667] Fix maven options while updating node,...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1659 retrigger CI due to failures of irrelevant tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1666 I think we can merge this first and then rebase #1659 easily :) This PR looks good to me and is what we want :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1659: [ZEPPELIN-1667] Fix maven options while updating node,...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1659 rebased to resolve conflict with #1666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1669: HOT FIX: Fix NPE while getting default interpreter set...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1669 Test failed, but not irrelevant with this PR ``` // https://travis-ci.org/apache/zeppelin/jobs/177967999 // https://api.travis-ci.org/jobs/177967999/log.txt?deansi=true 14:40:57,230 INFO org.apache.zeppelin.ZeppelinITUtils:41 - Finished. 14:40:57,230 INFO org.apache.zeppelin.integration.ZeppelinIT:189 - testCreateNotebook Test executed Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 113.057 sec - in org.apache.zeppelin.integration.ZeppelinIT Results : Tests in error: ParagraphActionsIT.testClearOutputButton:278->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 » Timeout Tests run: 18, Failures: 0, Errors: 1, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal Hi :) ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1674: [ZEPPELIN-1695] Apply regular maven indent
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1674 [ZEPPELIN-1695] Apply regular maven indent ### What is this PR for? **First of all, this PR doesn't affect on runtime application behaivor and existing build processes. Just styling all pom.xml files** We have not standardized maven indent currently. I referred [maven code convention](https://maven.apache.org/developers/conventions/code.html) and applied it to this PR. This is the sub issue of https://github.com/apache/zeppelin/pull/1662 ### What type of PR is it? [Improvement] ### What is the Jira issue? [ZEPPELIN-1695](https://issues.apache.org/jira/browse/ZEPPELIN-1695) ### How should this be tested? CI will be enough. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin style/fix-indent-all-pom-files Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1674 commit 277370d2c2ab6dac12891270daa579e087e15aab Author: 1ambda <1am...@gmail.com> Date: 2016-11-24T07:49:03Z style: Apply regular maven indent ref - https://maven.apache.org/developers/conventions/code.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1538 @mfelgamal @bzz I think we should dockerize binary zeppelin images first because more users use binary versions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1538: [ZEPPELIN-1386] Docker images for running Apache Zeppe...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1538 Now this issue is like more about building base image :) I will start working on a new JIRA issue as @bzz mentioned about creating runnable zeppelin images per version based on this. That would be the next step. https://issues.apache.org/jira/browse/ZEPPELIN-1711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1168: [MINOR] Add formatter
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1168 @bzz I created a JIRA issue for this: https://issues.apache.org/jira/browse/ZEPPELIN-1709 We can resolve this in 1 PR or can split it into multiples. I think we can resolve these things - update checkstyle.xml - update maven plugin or introduce more recent a new plugin https://github.com/checkstyle/checkstyle (some apache projects use both) - write a detailed guide about how to format your zeppelin code while making contribution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1680: [MINOR] Invalid constructor call in a test caus...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1680 [MINOR] Invalid constructor call in a test causes all CI failure ### What is this PR for? A small minor fix for CI failure ### What type of PR is it? [Bug Fix] ### What is the Jira issue? NO JIRA issue. (small, emergently) ### How should this be tested? CI will do that :) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin minor/fix-invalid-constructor-call-in-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1680 commit 6c57e4226efffacbdcd47d097f2dc801b96426b5 Author: 1ambda <1am...@gmail.com> Date: 2016-11-25T05:13:26Z fix: Invalid constructor call in a test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1674: [ZEPPELIN-1695] Apply regular maven indent
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1674 @bzz We can rebase and merge smaller PRs first like https://github.com/apache/zeppelin/pull/1668 and #1339 you mentioned. I will rebase #1668 first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1686 @soralee This is cool! ð a small suggestions here :) - usually, many tools use `CTRL + L` to clear output. Can we use this familiar key instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 rebased to keep sync with master (+ to see CI is green as well) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1696: CI test for 1689
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1696 CI test for 1689 This is a comparison group for #1689 You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ci-test-for-1689 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1696.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1696 commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:27:18Z chore: Use pluginManagement block so that config be shared in children projects commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:28:29Z chore: Remove useless failOnViolation config its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html commit 1988d41f26c20b1633963abd5ea93d35d7007f4b Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:29:46Z chore: Remove duplicated exclude commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:13:15Z chore: Update checkstyle version commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:52:15Z style: Fix Invalid indents in interpreter [INFO] [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .. FAILURE [ 0.901 s] commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T03:03:06Z style: Fix invalid indents in zengine [INFO] [INFO] Building Zeppelin: Zengine 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-zengine --- [INFO] There are 13 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[348] (indentation) Indentation: '.' have incorrect indentation level 5, expected level should be 8. [ERROR] src/main/java/org/apache/zeppelin/interpreter/InterpreterFactory.java:[412] (indentation) Indentation: '"Information From loaded Interpreter Setting Ref - {} "' have incorrect indentation level10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[37] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[38] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[39] (indentation) Indentation: 'array initialization' child have incorrect indentation level 4, expected level shouldbe 6. [ERROR] src/main/java/org/apache/zeppelin/notebook/NotebookImportDeserializer.java:[44] (indentation)
[GitHub] zeppelin issue #1690: [ZEPPELIN-1709] docs: Describe how to use checkstyle p...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1690 I separated plugin link with setting guide @AhyoungRyu :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1339: [ZEPPELIN-1332] Remove spark-dependencies & suggest ne...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1339 Short summary and small thought about #1399 1. Using symlink like `local-spark/master` would be safe i think. It enables user replace his local spark without renaming directories. Currently we are using hard coded name. ``` SPARK_CACHE="local-spark" SPARK_ARCHIVE="spark-${SPARK_VERSION}-bin-hadoop${HADOOP_VERSION}" ``` 2. about UX, - most (experienced in zeppelin) users do not use local spark - for new comers, we can provide embedded spark using docker will be shipped by #1538 - and storking `get-spark` is not too hard even if new users do not use the docker images. 3. Now users need to type `get-spark`. it works as described ``` $ zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh start Log dir doesn't exist, create /Users/1ambda/github/apache-zeppelin/zeppelin-review/logs Pid dir doesn't exist, create /Users/1ambda/github/apache-zeppelin/zeppelin-review/run You do not have neither local-spark, nor external SPARK_HOME set up. If you want to use Spark interpreter, you need to run get-spark at least one time or set SPARK_HOME. Zeppelin start [ OK ] $ zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh stop Zeppelin stop [ OK ] $ zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh get-spark Download spark-2.0.1-bin-hadoop2.7.tgz from mirror ... % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 100 178M 100 178M0 0 7157k 0 0:00:25 0:00:25 --:--:-- 6953k spark-2.0.1-bin-hadoop2.7 is successfully downloaded and saved under /Users/lambda/github/apache-zeppelin/zeppelin-review/local-spark $ zeppelin-review git:(pr/1339) ./bin/zeppelin-daemon.sh start Zeppelin start [ OK ] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1696: CI test for 1689
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1696 @bzz That's because invalid `_tools/checkstyle.xml`. I'v just updated sorry for distraction :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1668: [ZEPPELIN-1695] Centralize libs, plugin versions in al...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1668 I will resolve conflict with https://github.com/apache/zeppelin/commit/4ac577f711b2d62afb2016b95b6ccc3a85afd108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1690: [ZEPPELIN-1709] docs: Describe how to use check...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1690 [ZEPPELIN-1709] docs: Describe how to use checkstyle plugins ### What is this PR for? The sub issue of https://github.com/apache/zeppelin/pull/1689 (PRs are splitted due to `contribute.md` exists in different branch `gh-pages`) - Describe how to IDE plugins to contribute consistent code ### What type of PR is it? [Documentation] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1709 ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin docs/update-checkstyle-plugins Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1690.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1690 commit 099479cf0118b1313aa667fa820e81d04af6bee1 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T07:06:18Z docs: Update checkstyle plugins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1689: [ZEPPELIN-1709] Update checkstyle rule file, pl...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1689 [ZEPPELIN-1709] Update checkstyle rule file, plugin ### What is this PR for? We have - outdated checkstyle.xml - old maven checkstyle plugin - no detailed style plugin guide (e.g available plugins, how to use them in your IDEA) By fixing those issues, we can keep our code clean. It will results the number of rebase count (reduced conflict due to just style) and boost our productivity. **important note** This PR set an option to print all checkstyle warnings into stdout. The reason is, people should be told about invalid styles of not only errors but also warnings. Once those warnings are all fixed, we can set `warning` to fail build even when checkstyle warning is occurred. By doing that, we can make our code more consistent. ```xml true ``` ### What type of PR is it? [Improvement] ### Todos * [x] - update check style plugin * [x] - update checkstyle.xml * [x] - fix some styles * [x] - print checkstyle WARN ### What is the Jira issue? [ZEPPELIN-1709](https://issues.apache.org/jira/browse/ZEPPELIN-1709) ### How should this be tested? ``` mvn validate -Denforcer.skip=true ``` ### Questions: * Does the licenses files need update - NO * Is there breaking changes for older versions - NO * Does this needs documentation - NO, but I added some docs about how to use checkstyle.xml in IDEA You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin feat/update-checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1689 commit 46c59bae0daf38df9dae39203632f0d7a2c8d6d1 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:27:18Z chore: Use pluginManagement block so that config be shared in children projects commit 2fa6f734a1176a35f0cec7a440e0f992fb781cdb Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:28:29Z chore: Remove useless failOnViolation config its default value is already `true` see https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html commit 1988d41f26c20b1633963abd5ea93d35d7007f4b Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:29:46Z chore: Remove duplicated exclude commit 83e0c7b0d75b52cee695f186ef9743bbc575e31d Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:13:15Z chore: Update checkstyle version commit 70b15c9b0d231ec4a12cc01e889e8ed1d75ad828 Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T02:52:15Z style: Fix Invalid indents in interpreter [INFO] [INFO] Building Zeppelin: Interpreter 0.7.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-fail-build) @ zeppelin-interpreter --- [INFO] There are 5 errors reported by Checkstyle 6.11.2 with _tools/checkstyle.xml ruleset. [ERROR] src/main/java/org/apache/zeppelin/dep/DependencyResolver.java:[162] (indentation) Indentation: 'Collection' have incorrect indentation level 4, expected level should be 6. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java:[242] (indentation) Indentation: 'getClassName' have incorrect indentation level 10, expected level should be 12. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[59] (indentation) Indentation: 'extends' have incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:[60] (indentation) Indentation: 'implements' have incorrect indentation level 2, expected level should be 4. [ERROR] src/test/resources/log4j.properties:[0] (misc) NewlineAtEndOfFile: File does not end with a newline. [INFO] [INFO] Reactor Summary: [INFO] [INFO] Zeppelin ... SUCCESS [ 3.587 s] [INFO] Zeppelin: Interpreter .. FAILURE [ 0.901 s] commit 6f0d72fb281c04bd44e839adc08cfbcd4dd9654e Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T03:03:06Z style: Fix invalid indents in zengine [INFO] [INFO] Building Zeppel
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 \cc @bzz for review thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1686: [ZEPPELIN-1686] Added clear output to keyboard shortcu...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1686 Ace users also issued about it. https://github.com/ajaxorg/ace/issues/210 - I think this is a good feature and will be used so many times by so many people. Thus we should carefully design this shortcut. - it is hard and not usual to stroke `CTRL + SHIFT + C` for me at least. What about others opinion? we might find better key for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1684 I am not sure but this might be due to OS I tested this PR and works well as @marchpig described. (but i didn't reproduce this issue like @AhyoungRyu) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1689: [ZEPPELIN-1709] Update checkstyle rule file, plugin
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1689 Failed due to log size limitation of travis CI ``` The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over). ``` We might disable `true` only in CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1693: [ZEPPELIN-1695] chore: Set xml plugin phase to ...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/1693 [ZEPPELIN-1695] chore: Set xml plugin phase to verify (minor) ### What is this PR for? Changed the phase of xml validation plugin from validate to verify so that developers can use `mvn test` in submodule dirctories (**this PR doesn't affect on runtime application behaivor.**) ``` [INFO] --- xml-maven-plugin:1.0.1:validate (default) @ zeppelin-markdown --- [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 1.643 s [INFO] Finished at: 2016-11-28T17:53:47+09:00 [INFO] Final Memory: 17M/307M [INFO] [ERROR] Failed to execute goal org.codehaus.mojo:xml-maven-plugin:1.0.1:validate (default) on project zeppelin-markdown: Failed to load schema with public ID null, system ID _tools/maven-4.0.0.xsd: /Users/lambda/github/apache-zeppelin/zeppelin-feature/markdown/_tools/maven-4.0.0.xsd (No such file or directory) -> [Help 1] [ERROR] ``` ### What type of PR is it? [Improvement] ### Todos ### What is the Jira issue? [ZEPPELIN-1695](https://issues.apache.org/jira/browse/ZEPPELIN-1695?filter=-3) ### How should this be tested? ``` $ cd markdown $ mvn test ``` ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin chore/modify-xml-plugin-phase-to-verify Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1693.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1693 commit cc3858b6bafbb7cb70753205069b14591b33087b Author: 1ambda <1am...@gmail.com> Date: 2016-11-28T08:09:41Z chore: Set xml plugin phase to verify --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1659: [ZEPPELIN-1667] Fix maven options while updating node,...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1659 @cloverhearts Thanks for your comment. I have some questions. - How we can check one of our dependencies doens't work on 6.x but works in 4.x even build passes? - As I know, all node modules are dev dependencies and doesn't affect on frontend libraries (bower packages). They are just concated and added to HTML. Are not they? ([Gruntfile.js of es6 PR](https://github.com/felizbear/zeppelin/blob/f083492cfb22073732ee4af70d1cb1d02b743706/zeppelin-web/Gruntfile.js)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1659: [ZEPPELIN-1667] Fix maven options while updating node,...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1659 README is updated. You can preview - https://github.com/1ambda/zeppelin/blob/239c74a3100031bf615b879bf589719a78e9ba71/zeppelin-web/README.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1659: [ZEPPELIN-1667] Fix maven options while updating node,...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1659 README is updated. - (preview) https://github.com/1ambda/zeppelin/blob/ece898e982360aae05b899a02de9e8f8da095759/zeppelin-web/README.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1666 Hi, @asanjar Actually, we are talking about upgrading node, npm and karma related versions in https://github.com/apache/zeppelin/pull/1659 Could you check it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1640 I think this PR is cool :) @AhyoungRyu One more question, What do you think if we can filter out interpreters using keywords like `%dep` `%r`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1649: [ZEPPELIN-1678] Improve main page notebook filter styl...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1649 CI failed but it doesn't related with this PR - https://api.travis-ci.org/jobs/176613823/log.txt?deansi=true (NPE) - https://api.travis-ci.org/jobs/176613828/log.txt?deansi=true (`ParagraphActionsIT.testEditOnDoubleClick:443 » ElementNotVisible Element is no...`) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1638: [ZEPPELIN-1666] DON'T share mutable deps, optio...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/1638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---