ZooKeeper-trunk-WinVS2008 - Build # 1790 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1790/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 111 lines...] [javacc] File SimpleCharStream.java does not exist. Will create one. [javacc] Parser generated successfully. jute: [javac] Compiling 39 source files to f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes compile_jute_uptodate: compile_jute: [mkdir] Created dir: f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated [mkdir] Created dir: f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\generated [java] ../../zookeeper.jute Parsed Successfully [java] ../../zookeeper.jute Parsed Successfully [touch] Creating f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated\.generated BUILD SUCCESSFUL Total time: 10 seconds [ZooKeeper-trunk-WinVS2008] $ cmd /c call C:\Windows\TEMP\hudson2973866653873007127.bat f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008set ZOOKEEPER_HOME=f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008msbuild trunk/src/c/zookeeper.sln /p:Configuration=Release Microsoft (R) Build Engine version 4.0.30319.18408 [Microsoft .NET Framework, version 4.0.30319.18444] Copyright (C) Microsoft Corporation. All rights reserved. Building the projects in this solution one at a time. To enable parallel build, please add the /m switch. Build started 5/6/2015 9:22:37 AM. Project f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln on node 1 (default targets). ValidateSolutionConfiguration: Building solution configuration Release|Win32. zookeeper: C:\Program Files (x86)\Microsoft Visual Studio 9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.vcproj Release|Win32 cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] .\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] Cli: C:\Program Files (x86)\Microsoft Visual Studio 9.0\Common7\IDE\..\..\vc\vcpackages\VCBuild.exe f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\Cli.vcproj Release|Win32 Done Building Project f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default targets) -- FAILED. Build FAILED. f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default target) (1) - (zookeeper target) - cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default target) (1) - (zookeeper target) - .\src\zookeeper.c(43): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory [f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln] 1 Warning(s) 1 Error(s) Time Elapsed 00:00:08.49 f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
ZooKeeper-trunk-solaris - Build # 1023 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1023/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer Building remotely on solaris1 (Solaris) in workspace /export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision '2015-05-06T08:30:00.964 +' U src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml U src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml U src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java U CHANGES.txt At revision 1677913 Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision '2015-05-06T08:30:00.964 +' At revision 1677913 no change for http://svn.apache.org/repos/asf/hadoop/nightly since the previous build No emails were triggered. [locks-and-latches] Checking to see if we really have the locks [locks-and-latches] Have all the locks, build can start [ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson4096381598868608023.sh /var/tmp/hudson4096381598868608023.sh: line 12: ant: command not found Build step 'Execute shell' marked build as failure [locks-and-latches] Releasing all the locks [locks-and-latches] All the locks released Recording test results Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated ZOOKEEPER-2163:
Fix Version/s: 3.6.0
Introduce new ZNode type: container
---
Key: ZOOKEEPER-2163
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
Project: ZooKeeper
Issue Type: New Feature
Components: c client, java client, server
Affects Versions: 3.5.0
Reporter: Jordan Zimmerman
Assignee: Jordan Zimmerman
Fix For: 3.6.0
Attachments: zookeeper-2163.3.patch
BACKGROUND
A recurring problem for ZooKeeper users is garbage collection of parent
nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
parent node under which participants create sequential nodes. When the
participant is done, it deletes its node. In practice, the ZooKeeper tree
begins to fill up with orphaned parent nodes that are no longer needed. The
ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
become unstable due to the number of these nodes.
CURRENT SOLUTIONS
===
Apache Curator has a workaround solution for this by providing the Reaper
class which runs in the background looking for orphaned parent nodes and
deleting them. This isn’t ideal and it would be better if ZooKeeper supported
this directly.
PROPOSAL
=
ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
to contain child nodes. This is not optimum as EPHEMERALs are tied to a
session and the general use case of parent nodes is for PERSISTENT nodes.
This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
as a PERSISTENT node with the additional property that when its last child is
deleted, it is deleted (and CONTAINER nodes recursively up the tree are
deleted if empty).
CANONICAL USAGE
{code}
while ( true) { // or some reasonable limit
try {
zk.create(path, ...);
break;
} catch ( KeeperException.NoNodeException e ) {
try {
zk.createContainer(containerPath, ...);
} catch ( KeeperException.NodeExistsException ignore) {
}
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review82648
---
CHANGES.txt
https://reviews.apache.org/r/33713/#comment133418
This is not required, please revert this changes
bin/zkServer.sh
https://reviews.apache.org/r/33713/#comment133419
This is not required, please revert this changes
src/java/main/org/apache/zookeeper/ZooKeeper.java
https://reviews.apache.org/r/33713/#comment133438
Minor suggestion:
I could see many places the import statements has been modified to .*
I prefer not to change the existing imports it may show many changes in
diff that may deviate reviewers focus. We can do import the necessary
classess/items required for the implementation.
src/java/main/org/apache/zookeeper/ZooKeeper.java
https://reviews.apache.org/r/33713/#comment133420
I assume you are referring to jute.maxbuffer. It is not good to hard code
value 1MB, right?
src/java/main/org/apache/zookeeper/ZooKeeper.java
https://reviews.apache.org/r/33713/#comment133437
One general thought:
Instead of providing a new API for creating the container, can we think of
CreateMode.CONTAINER a new znode type? Also, I feel this may help us to
support multiTxn/batch apis.
I haven't done detailed analysis, this is just a rough thought that comes
in my mind.
src/java/main/org/apache/zookeeper/ZooKeeper.java
https://reviews.apache.org/r/33713/#comment133421
I assume you are referring to jute.maxbuffer. It is not good to hard code
value 1MB, right?
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133422
Please replace System.currentMillis() with
org.apache.zookeeper.common.Time.currentElapsedTime()
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133423
Please use {} instead of + for string concatenation in logs
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133424
Please use {} instead of + for string concatenation in logs
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133425
Can we modify System.currentTimeMillis() using
org.apache.zookeeper.common.Time ?
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133426
Please format this line, its more than 80 chars
src/java/main/org/apache/zookeeper/server/ContainerManager.java
https://reviews.apache.org/r/33713/#comment133428
Could you please tell me the reson for the checks
node.stat.getCversion() 0 ?
Probably you can add a comment over there, so that others also will
understand.
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
https://reviews.apache.org/r/33713/#comment133431
Please modify string concatenation in logs using {}
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
https://reviews.apache.org/r/33713/#comment133432
Could you tell me the behaviour if there occurs NoNodeException?
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
https://reviews.apache.org/r/33713/#comment133434
Please add timeout args in tests like,
@Test(timeout=6)
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
https://reviews.apache.org/r/33713/#comment133435
Can we think of some better logic instead of Thread.sleep(1000) in tests.
It may be flaky in some env, right?
src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
https://reviews.apache.org/r/33713/#comment133436
Can we think of some better logic instead of Thread.sleep(1000) in tests.
It may be flaky in some env, right?
I could see there are few more occurances of Thread.sleep(xx) similar to
this, please do the changes. Thanks!
- Rakesh R
On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/
---
(Updated April 30, 2015, 4:08 p.m.)
Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
Bugs: ZOOKEEPER-2163
https://issues.apache.org/jira/browse/ZOOKEEPER-2163
Repository: zookeeper-git
Description
---
Introduce new ZNode type: container
Diffs
-
CHANGES.txt 51ec65d
bin/zkServer.sh dae3ce2
src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca
src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e
src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82654 --- src/java/main/org/apache/zookeeper/server/ContainerManager.java https://reviews.apache.org/r/33713/#comment133439 It would be good to add log statement shows the values of checkIntervalMs and maxPerMinute. - Rakesh R On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated April 30, 2015, 4:08 p.m.) Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. Bugs: ZOOKEEPER-2163 https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Repository: zookeeper-git Description --- Introduce new ZNode type: container Diffs - CHANGES.txt 51ec65d bin/zkServer.sh dae3ce2 src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf src/java/main/org/apache/zookeeper/server/Request.java bed9b13 src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4 src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION src/zookeeper.jute 709e935 Diff: https://reviews.apache.org/r/33713/diff/ Testing --- Thanks, Jordan Zimmerman
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530235#comment-14530235
]
Rakesh R commented on ZOOKEEPER-2163:
-
Nice work! Thanks [~randgalt] for the contribution. I've added review comments
in [RB|https://reviews.apache.org/r/33713/], please take a look at it.
Introduce new ZNode type: container
---
Key: ZOOKEEPER-2163
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
Project: ZooKeeper
Issue Type: New Feature
Components: c client, java client, server
Affects Versions: 3.5.0
Reporter: Jordan Zimmerman
Assignee: Jordan Zimmerman
Fix For: 3.6.0
Attachments: zookeeper-2163.3.patch
BACKGROUND
A recurring problem for ZooKeeper users is garbage collection of parent
nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
parent node under which participants create sequential nodes. When the
participant is done, it deletes its node. In practice, the ZooKeeper tree
begins to fill up with orphaned parent nodes that are no longer needed. The
ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
become unstable due to the number of these nodes.
CURRENT SOLUTIONS
===
Apache Curator has a workaround solution for this by providing the Reaper
class which runs in the background looking for orphaned parent nodes and
deleting them. This isn’t ideal and it would be better if ZooKeeper supported
this directly.
PROPOSAL
=
ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
to contain child nodes. This is not optimum as EPHEMERALs are tied to a
session and the general use case of parent nodes is for PERSISTENT nodes.
This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
as a PERSISTENT node with the additional property that when its last child is
deleted, it is deleted (and CONTAINER nodes recursively up the tree are
deleted if empty).
CANONICAL USAGE
{code}
while ( true) { // or some reasonable limit
try {
zk.create(path, ...);
break;
} catch ( KeeperException.NoNodeException e ) {
try {
zk.createContainer(containerPath, ...);
} catch ( KeeperException.NodeExistsException ignore) {
}
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2176) Unclear error message should be info not error
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530397#comment-14530397
]
Hudson commented on ZOOKEEPER-2176:
---
FAILURE: Integrated in ZooKeeper-trunk #2683 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2683/])
ZOOKEEPER-2176 Unclear error message should be info not error (rgs via hdeng)
(hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677865)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
Unclear error message should be info not error
--
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ZooKeeper-trunk - Build # 2683 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/2683/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 1685 lines...] [exec] [exec] install-plugin: [exec] [exec] configure-plugin: [exec] [exec] configure-input-plugin: [exec] Mounting input plugin: org.apache.forrest.plugin.input.simplifiedDocbook [exec] Processing /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/input.xmap to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/input.xmap.new [exec] Loading stylesheet /home/jenkins/tools/forrest/latest/main/var/pluginMountSnippet.xsl [exec] Moving 1 file to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp [exec] Processing /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/resources.xmap to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/resources.xmap.new [exec] Loading stylesheet /home/jenkins/tools/forrest/latest/main/var/pluginMountSnippet.xsl [exec] Moving 1 file to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp [exec] [exec] configure-plugin-locationmap: [exec] Mounting plugin locationmap for org.apache.forrest.plugin.input.simplifiedDocbook [exec] Processing /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/locationmap.xml to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp/locationmap.xml.new [exec] Loading stylesheet /home/jenkins/tools/forrest/latest/main/var/pluginLmMountSnippet.xsl [exec] Moving 1 file to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/build/tmp [exec] [exec] init: [exec] [exec] -prepare-classpath: [exec] [exec] check-contentdir: [exec] [exec] examine-proj: [exec] [exec] validation-props: [exec] Using these catalog descriptors: /home/jenkins/tools/forrest/latest/main/webapp/resources/schema/catalog.xcat:/home/jenkins/tools/forrest/latest/build/plugins/catalog.xcat:/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/src/documentation/resources/schema/catalog.xcat [exec] [exec] validate-xdocs: [exec] /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml:1152:56: The element type emphasis must be terminated by the matching end-tag /emphasis. [exec] [exec] BUILD FAILED [exec] /home/jenkins/tools/forrest/latest/main/targets/validate.xml:135: Could not validate document /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml [exec] [exec] Total time: 6 seconds BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:483: exec returned: 1 Total time: 7 seconds mv: cannot stat 'build/*.tar.gz': No such file or directory mv: cannot stat 'build/*.jar': No such file or directory mv: cannot stat 'build/test/findbugs': No such file or directory mv: cannot stat 'build/docs/api': No such file or directory Build Failed Build step 'Execute shell' marked build as failure [FINDBUGS] Skipping publisher since build result is FAILURE [WARNINGS] Skipping publisher since build result is FAILURE Archiving artifacts Recording fingerprints Updating ZOOKEEPER-2176 Updating ZOOKEEPER-2153 Recording test results Publishing Javadoc Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-2153) X509 Authentication Documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530398#comment-14530398 ] Hudson commented on ZOOKEEPER-2153: --- FAILURE: Integrated in ZooKeeper-trunk #2683 (See [https://builds.apache.org/job/ZooKeeper-trunk/2683/]) ZOOKEEPER-2153 X509 Authentication Documentation (Ian Dimayuga via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677867) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml X509 Authentication Documentation - Key: ZOOKEEPER-2153 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2153 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Hongchao Deng Assignee: Ian Dimayuga Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2153.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_jdk7 - Build # 286 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/286/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 365536 lines...] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@980: Client environment:host.name=proserpina.apache.org] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@987: Client environment:os.name=Linux] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@988: Client environment:os.arch=3.13.0-36-lowlatency] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@989: Client environment:os.version=#63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@997: Client environment:user.name=jenkins] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@1005: Client environment:user.home=/home/jenkins] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@log_env@1017: Client environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/test-cppunit] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc30bc2540):ZOO_INFO@zookeeper_init_internal@1060: Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 watcher=0x45d350 sessionId=0 sessionPasswd=null context=0x7fff40e3d910 flags=0] [exec] Log Message Received: [2015-05-06 11:47:34,871:25498(0x2acc33251700):ZOO_INFO@check_events@2298: initiated connection to server [127.0.0.1:22181]] [exec] Log Message Received: [2015-05-06 11:47:34,891:25498(0x2acc33251700):ZOO_INFO@check_events@2350: session establishment complete on server [127.0.0.1:22181], sessionId=0x10027fd3251000f, negotiated timeout=1 ] [exec] : elapsed 1000 : OK [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server started : elapsed 10126 : OK [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK [exec] Zookeeper_simpleSystem::testNullData : elapsed 1056 : OK [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1017 : OK [exec] Zookeeper_simpleSystem::testCreate : elapsed 1025 : OK [exec] Zookeeper_simpleSystem::testPath : elapsed 1049 : OK [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1150 : OK [exec] Zookeeper_simpleSystem::testPing : elapsed 17664 : OK [exec] Zookeeper_simpleSystem::testAcl : elapsed 1034 : OK [exec] Zookeeper_simpleSystem::testChroot : elapsed 3110 : OK [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper server started : elapsed 30324 : OK [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1043 : OK [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper server started ZooKeeper server started ZooKeeper server started : elapsed 14587 : OK [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper server started ZooKeeper server started ZooKeeper server started : elapsed 14618 : OK [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1064 : OK [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4527 : OK [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started : elapsed 4212 : OK [exec] Zookeeper_readOnly::testReadOnly : elapsed 4100 : OK [exec] /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/src/c/tests/TestReconfig.cc:183: Assertion: equality assertion failed [Expected: 1, Actual : 0] [exec] Failures !!! [exec] Run: 72 Failure total: 1 Failures: 1 Errors: 0 [exec] FAIL: zktest-mt [exec] == [exec] 1 of 2 tests failed [exec] Please report to u...@zookeeper.apache.org [exec] == [exec] make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/test-cppunit' [exec] make[1]: *** [check-TESTS] Error 1 [exec] make: *** [check-am] Error 2 BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1439: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1399: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1409: exec returned: 2 Total time: 53 minutes 12 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1404 https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1404 One general thought: Instead of providing a new API for creating the container, can we think of CreateMode.CONTAINER a new znode type? Also, I feel this may help us to support multiTxn/batch apis. I haven't done detailed analysis, this is just a rough thought that comes in my mind. Jordan Zimmerman wrote: At this point, I don't remember why I chose to add a new API. Other committers haven't asked for this. But, if you like I can change it a new CreateMode. Supporting multi/trans is a good point. Please advise. Yes, since this is a design change it would be good to listen others thought also. IMO will add this point in the jira so that will get more attention. - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82648 --- On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated April 30, 2015, 4:08 p.m.) Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. Bugs: ZOOKEEPER-2163 https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Repository: zookeeper-git Description --- Introduce new ZNode type: container Diffs - CHANGES.txt 51ec65d bin/zkServer.sh dae3ce2 src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf src/java/main/org/apache/zookeeper/server/Request.java bed9b13 src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4 src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION src/zookeeper.jute 709e935 Diff: https://reviews.apache.org/r/33713/diff/ Testing --- Thanks, Jordan Zimmerman
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1404 https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1404 One general thought: Instead of providing a new API for creating the container, can we think of CreateMode.CONTAINER a new znode type? Also, I feel this may help us to support multiTxn/batch apis. I haven't done detailed analysis, this is just a rough thought that comes in my mind. At this point, I don't remember why I chose to add a new API. Other committers haven't asked for this. But, if you like I can change it a new CreateMode. Supporting multi/trans is a good point. Please advise. On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/server/ContainerManager.java, line 132 https://reviews.apache.org/r/33713/diff/1/?file=946049#file946049line132 Could you please tell me the reson for the checks node.stat.getCversion() 0 ? Probably you can add a comment over there, so that others also will understand. It's to keep newly created containers from being deleted before any children have been added. If you were to create the container just before a container cleaning period the container would be immediately be deleted. However, we could change to only deleting a container once it's n ticks old. Thoughts? - Jordan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82648 --- On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated April 30, 2015, 4:08 p.m.) Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. Bugs: ZOOKEEPER-2163 https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Repository: zookeeper-git Description --- Introduce new ZNode type: container Diffs - CHANGES.txt 51ec65d bin/zkServer.sh dae3ce2 src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf src/java/main/org/apache/zookeeper/server/Request.java bed9b13 src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4 src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION src/zookeeper.jute 709e935 Diff: https://reviews.apache.org/r/33713/diff/ Testing --- Thanks, Jordan Zimmerman
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531126#comment-14531126
]
Rakesh R commented on ZOOKEEPER-2163:
-
One general design thought:
Presently the patch proposes a client API {{zkclient#createContainer}} for
creating the container. Instead of providing a new API can we think of
{{CreateMode.CONTAINER}} a new znode type?. Also, I feel this will help us to
support {{multitransaction/batch}} operations. Welcome input from others.
Thanks!
Introduce new ZNode type: container
---
Key: ZOOKEEPER-2163
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
Project: ZooKeeper
Issue Type: New Feature
Components: c client, java client, server
Affects Versions: 3.5.0
Reporter: Jordan Zimmerman
Assignee: Jordan Zimmerman
Fix For: 3.6.0
Attachments: zookeeper-2163.3.patch
BACKGROUND
A recurring problem for ZooKeeper users is garbage collection of parent
nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
parent node under which participants create sequential nodes. When the
participant is done, it deletes its node. In practice, the ZooKeeper tree
begins to fill up with orphaned parent nodes that are no longer needed. The
ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
become unstable due to the number of these nodes.
CURRENT SOLUTIONS
===
Apache Curator has a workaround solution for this by providing the Reaper
class which runs in the background looking for orphaned parent nodes and
deleting them. This isn’t ideal and it would be better if ZooKeeper supported
this directly.
PROPOSAL
=
ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
to contain child nodes. This is not optimum as EPHEMERALs are tied to a
session and the general use case of parent nodes is for PERSISTENT nodes.
This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
as a PERSISTENT node with the additional property that when its last child is
deleted, it is deleted (and CONTAINER nodes recursively up the tree are
deleted if empty).
CANONICAL USAGE
{code}
while ( true) { // or some reasonable limit
try {
zk.create(path, ...);
break;
} catch ( KeeperException.NoNodeException e ) {
try {
zk.createContainer(containerPath, ...);
} catch ( KeeperException.NodeExistsException ignore) {
}
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 34 https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line34 Minor suggestion: I could see many places the import statements has been modified to .* I prefer not to change the existing imports it may show many changes in diff that may deviate reviewers focus. We can do import the necessary classess/items required for the implementation. Sorry - IntelliJ does this automatically. I'll try to revert these. On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1392 https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1392 I assume you are referring to jute.maxbuffer. It is not good to hard code value 1MB, right? I copied this doc verbatim from the create() method. It seems to me that this should be globally changed in a separate issue. On May 6, 2015, 9:22 a.m., Rakesh R wrote: src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1433 https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1433 I assume you are referring to jute.maxbuffer. It is not good to hard code value 1MB, right? I copied this doc verbatim from the create() method. It seems to me that this should be globally changed in a separate issue. - Jordan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/#review82648 --- On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33713/ --- (Updated April 30, 2015, 4:08 p.m.) Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales. Bugs: ZOOKEEPER-2163 https://issues.apache.org/jira/browse/ZOOKEEPER-2163 Repository: zookeeper-git Description --- Introduce new ZNode type: container Diffs - CHANGES.txt 51ec65d bin/zkServer.sh dae3ce2 src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf src/java/main/org/apache/zookeeper/server/Request.java bed9b13 src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4 src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION src/zookeeper.jute 709e935 Diff: https://reviews.apache.org/r/33713/diff/ Testing --- Thanks, Jordan Zimmerman
[jira] [Updated] (ZOOKEEPER-2153) X509 Authentication Documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongchao Deng updated ZOOKEEPER-2153: - Attachment: ZOOKEEPER-2153.patch X509 Authentication Documentation - Key: ZOOKEEPER-2153 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2153 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Hongchao Deng Assignee: Ian Dimayuga Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2153.patch, ZOOKEEPER-2153.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2153) X509 Authentication Documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530765#comment-14530765 ] Hongchao Deng commented on ZOOKEEPER-2153: -- The parenthesis is fixed: trunk: https://github.com/apache/zookeeper/commit/f45e48569b2e684378fdc56ef6bab96d3fcc0f88 branch-3.5: https://github.com/apache/zookeeper/commit/665c5aba9bba297daa8e491ff593945ab5e69a2f X509 Authentication Documentation - Key: ZOOKEEPER-2153 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2153 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Hongchao Deng Assignee: Ian Dimayuga Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2153.patch, ZOOKEEPER-2153.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
