[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[hanm]

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
>> Breaking changes should be in a 3.6 version.

Sounds OK to me.

>> We need to either create a new issue or have a different pull request 
for 3.5 under this same issue

I think this pull request (122) should target branch 3.5, because it keeps 
the old API. We need create a new PR that target master which only contain 
updates to the API name (reconfig -> reconfigure) and some doc / test updates 
without bringing back the old APIs.

@Randgalt Could you update the base branch of this PR to be branch-3.5 
instead of master? I think this PR is ready to land in branch-3.5.

@fpj I can create a new PR target master that only contain API name 
changes, if @Randgalt does not get ahead of me on this work.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825579#comment-15825579
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
>> Breaking changes should be in a 3.6 version.

Sounds OK to me.

>> We need to either create a new issue or have a different pull request 
for 3.5 under this same issue

I think this pull request (122) should target branch 3.5, because it keeps 
the old API. We need create a new PR that target master which only contain 
updates to the API name (reconfig -> reconfigure) and some doc / test updates 
without bringing back the old APIs.

@Randgalt Could you update the base branch of this PR to be branch-3.5 
instead of master? I think this PR is ready to land in branch-3.5.

@fpj I can create a new PR target master that only contain API name 
changes, if @Randgalt does not get ahead of me on this work.






> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: ZooKeeper 3.4.10 release discussion

[Rakesh Radhakrishnan]

OK. I have modified ZK cwiki page
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
directly. Please review the newly added lines in orange color to understand
the changes. The following sections has been modified:

   - *Updating the release branch -> modified steps **1, 4, 10, 11*
   - *Building -> modified step 9*
   - *Publishing -> modified step 1*

Thanks,
Rakesh

On Tue, Jan 17, 2017 at 11:36 AM, Patrick Hunt  wrote:

> Perhaps you can make the changes directly on the wiki page as a duplicate
> line item under the original in a different color? It's hard for me to
> really follow, esp as it's not a 1:1 replacement iiuc. Could you try
> editing the wiki directly to start with, leave the original line and add
> the new line(s) but in another color or some other indication?
>
> Thanks Rakesh.
>
> Patrick
>
> On Mon, Jan 16, 2017 at 8:48 AM, Rakesh Radhakrishnan 
> wrote:
>
> > Hi folks,
> >
> > As we all know, 3.4.10 release is the first ZooKeeper release after the
> > github repository migration. I have tried an attempt to modify the steps
> > described in the '
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease' page
> > to
> > make the release. Since this release is from an already created branch, I
> > have focused only the branch related parts in cwiki and below sections in
> > the page needed changes like,
> >
> >
> > *Updating the release branch*
> > 1. Check out the branch with:
> > git clone -b branch-X.Y
> > https://git-wip-us.apache.org/repos/asf/zookeeper.git
> >
> > 2. I'm skipping this step, which is not required now.
> >
> > 4. Update CHANGES.txt with the committed jira details. As we follow PR
> > merging, most of the jira info is not updated in this file. I believe
> > release manager need to update this file to capture the jira details
> marked
> > for that release.
> >
> > 10. Commit these changes.
> > git commit -a -m "Preparing for release X.Y.Z"
> > git push  
> >
> > 11. Tag the release candidate (R is the release candidate number, and
> > starts from 0):
> > git tag -s release-X.Y.Z-rcR -m "ZooKeeper X.Y.Z-rcR release."
> >
> > Push the newly created rc tag to the remote repo.
> > git push  release-X.Y.Z-rcR
> >
> >
> > *Building*
> > 9. Call for a release vote on dev
> >   In the release candidate dev mail format, it needs to change
> the
> > tag like,
> >
> >   "The RC tag in git to be voted upon: release-X.Y.Z-rcR"
> >
> >
> > *Publishing*
> > 1. Tag the release:
> > git tag -s release-X.Y.Z -m "ZooKeeper X.Y.Z release."
> >
> > Push the newly created release tag to the remote repo.
> > git push  release-X.Y.Z
> >
> >
> > I'd like to know whether I'm going in the right direction and start
> cutting
> > the 3.4.10 release by following this approach. Thanks!
> >
> > Thanks,
> > Rakesh
> >
> > On Mon, Jan 16, 2017 at 11:09 AM, Rakesh Radhakrishnan <
> rake...@apache.org
> > >
> > wrote:
> >
> > > Thanks for pointing this jira. I will take a look at this.
> > >
> > > Rakesh
> > >
> > > On Fri, Jan 13, 2017 at 7:27 PM, Edward Ribeiro <
> > edward.ribe...@gmail.com>
> > > wrote:
> > >
> > >> Hi Rakesh,
> > >>
> > >> Thansk for stepping up to this task! Pretty cool! :)
> > >>
> > >> Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is
> > >> worth
> > >> targeting 3.4.10 too?
> > >>
> > >> Edward
> > >>
> > >>
> > >>
> > >> On Fri, Jan 13, 2017 at 7:56 AM, Rakesh Radhakrishnan <
> > rake...@apache.org
> > >> >
> > >> wrote:
> > >>
> > >> > Hi All,
> > >> >
> > >> > I hope to cut an RC in a week - giving some more time for your
> > favorite
> > >> > outstanding blocker/critical issues. Will start moving out any
> tickets
> > >> that
> > >> > are not blockers and/or won’t fit the timeline - there are 1
> blocker,
> > 5
> > >> > critical, 15 major, 7 minor tickets outstanding as of now.
> Appreciate
> > >> your
> > >> > support in releasing 3.4.10 version. Thanks!
> > >> >
> > >> > Please find the open issues marked for 3.4.10 release here,
> > >> > https://goo.gl/XdraFA
> > >> >
> > >> > Thanks,
> > >> > Rakesh
> > >> >
> > >> >
> > >> > On Tue, Dec 6, 2016 at 4:15 PM, Rakesh Radhakrishnan <
> > >> rake...@apache.org>
> > >> > wrote:
> > >> >
> > >> > > Hi All,
> > >> > >
> > >> > > I am interested in going through the release process as the RM.
> > >> > >
> > >> > > Overall, I could see total 41 issues marked for 3.4.10 release as
> of
> > >> now,
> > >> > > which includes 4 blockers, 5 critical, 20 major and 12 minor
> > issues. I
> > >> > > count 9 issues fixed/committed already for 3.4.10 which includes 1
> > >> > blocker
> > >> > > and 1 critical(security related) issue. ZOOKEEPER-1045 is a much
> > >> awaited
> > >> > > one and the feature code is committed. I think it is a good time
> to
> > >> > > initiate the discussion of 3.4.10 release processes.
> > >> > >
> > >> > > Please find the issues marked for 3.4.10 release here,
> > >> > > https://goo.gl/FfbpVG
> > >> > >
> 

Re: ZooKeeper 3.4.10 release discussion

[Patrick Hunt]

Perhaps you can make the changes directly on the wiki page as a duplicate
line item under the original in a different color? It's hard for me to
really follow, esp as it's not a 1:1 replacement iiuc. Could you try
editing the wiki directly to start with, leave the original line and add
the new line(s) but in another color or some other indication?

Thanks Rakesh.

Patrick

On Mon, Jan 16, 2017 at 8:48 AM, Rakesh Radhakrishnan 
wrote:

> Hi folks,
>
> As we all know, 3.4.10 release is the first ZooKeeper release after the
> github repository migration. I have tried an attempt to modify the steps
> described in the '
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease' page
> to
> make the release. Since this release is from an already created branch, I
> have focused only the branch related parts in cwiki and below sections in
> the page needed changes like,
>
>
> *Updating the release branch*
> 1. Check out the branch with:
> git clone -b branch-X.Y
> https://git-wip-us.apache.org/repos/asf/zookeeper.git
>
> 2. I'm skipping this step, which is not required now.
>
> 4. Update CHANGES.txt with the committed jira details. As we follow PR
> merging, most of the jira info is not updated in this file. I believe
> release manager need to update this file to capture the jira details marked
> for that release.
>
> 10. Commit these changes.
> git commit -a -m "Preparing for release X.Y.Z"
> git push  
>
> 11. Tag the release candidate (R is the release candidate number, and
> starts from 0):
> git tag -s release-X.Y.Z-rcR -m "ZooKeeper X.Y.Z-rcR release."
>
> Push the newly created rc tag to the remote repo.
> git push  release-X.Y.Z-rcR
>
>
> *Building*
> 9. Call for a release vote on dev
>   In the release candidate dev mail format, it needs to change the
> tag like,
>
>   "The RC tag in git to be voted upon: release-X.Y.Z-rcR"
>
>
> *Publishing*
> 1. Tag the release:
> git tag -s release-X.Y.Z -m "ZooKeeper X.Y.Z release."
>
> Push the newly created release tag to the remote repo.
> git push  release-X.Y.Z
>
>
> I'd like to know whether I'm going in the right direction and start cutting
> the 3.4.10 release by following this approach. Thanks!
>
> Thanks,
> Rakesh
>
> On Mon, Jan 16, 2017 at 11:09 AM, Rakesh Radhakrishnan  >
> wrote:
>
> > Thanks for pointing this jira. I will take a look at this.
> >
> > Rakesh
> >
> > On Fri, Jan 13, 2017 at 7:27 PM, Edward Ribeiro <
> edward.ribe...@gmail.com>
> > wrote:
> >
> >> Hi Rakesh,
> >>
> >> Thansk for stepping up to this task! Pretty cool! :)
> >>
> >> Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is
> >> worth
> >> targeting 3.4.10 too?
> >>
> >> Edward
> >>
> >>
> >>
> >> On Fri, Jan 13, 2017 at 7:56 AM, Rakesh Radhakrishnan <
> rake...@apache.org
> >> >
> >> wrote:
> >>
> >> > Hi All,
> >> >
> >> > I hope to cut an RC in a week - giving some more time for your
> favorite
> >> > outstanding blocker/critical issues. Will start moving out any tickets
> >> that
> >> > are not blockers and/or won’t fit the timeline - there are 1 blocker,
> 5
> >> > critical, 15 major, 7 minor tickets outstanding as of now. Appreciate
> >> your
> >> > support in releasing 3.4.10 version. Thanks!
> >> >
> >> > Please find the open issues marked for 3.4.10 release here,
> >> > https://goo.gl/XdraFA
> >> >
> >> > Thanks,
> >> > Rakesh
> >> >
> >> >
> >> > On Tue, Dec 6, 2016 at 4:15 PM, Rakesh Radhakrishnan <
> >> rake...@apache.org>
> >> > wrote:
> >> >
> >> > > Hi All,
> >> > >
> >> > > I am interested in going through the release process as the RM.
> >> > >
> >> > > Overall, I could see total 41 issues marked for 3.4.10 release as of
> >> now,
> >> > > which includes 4 blockers, 5 critical, 20 major and 12 minor
> issues. I
> >> > > count 9 issues fixed/committed already for 3.4.10 which includes 1
> >> > blocker
> >> > > and 1 critical(security related) issue. ZOOKEEPER-1045 is a much
> >> awaited
> >> > > one and the feature code is committed. I think it is a good time to
> >> > > initiate the discussion of 3.4.10 release processes.
> >> > >
> >> > > Please find the issues marked for 3.4.10 release here,
> >> > > https://goo.gl/FfbpVG
> >> > >
> >> > > Currently, I'm focusing on updating ZOOKEEPER-1045 feature details
> >> into
> >> > > our project cwiki and related ZOOKEEPER-2479 improvement jira. I'd
> >> like
> >> > to
> >> > > include ZOOKEEPER-2383 into this release if everyone agrees.
> >> Appreciate
> >> > > your help in reviewing the jira patches and making it stable for
> >> release.
> >> > > Also, please feel free to push your favorite issues ahead of 3.4.10
> >> > release.
> >> > >
> >> > > I hope with the community support, we should be able to close all
> >> > > necessary blockers/critical issues soon. Kindly requesting everyone
> to
> >> > look
> >> > > at the issues marked for 3.4.10 and push these asap or can be pushed
> >> out
> >> > to
> >> > > 3.4.11.
> >> > >
> >> > > Imp: 

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824814#comment-15824814
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329273
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

Ok, makes sense. Would be something good to note somewhere, though.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[jvz]

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329244
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

Agreed, just pointing out in case anything is still using the old API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824813#comment-15824813
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329244
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

Agreed, just pointing out in case anything is still using the old API.


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[jvz]

Github user jvz commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96329273
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

Ok, makes sense. Would be something good to note somewhere, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[praste]

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96327023
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

@jvz Thanks for the suggestion, will look into it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824783#comment-15824783
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96327023
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum() throws 
Exception {
 ClientBase.setupTestEnv();
 
 // setup the logger to capture all logs
+LoggerContext loggerContext =  (LoggerContext) 
LogManager.getContext(false);
--- End diff --

@jvz Thanks for the suggestion, will look into it. 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 3240 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3240/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 480863 lines...]
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-01-16 23:32:45,710 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x1023a0b3b6d]
[junit] 2017-01-16 23:32:45,759 [myid:127.0.0.1:16608] - INFO  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16608. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-01-16 23:32:45,759 [myid:127.0.0.1:16608] - WARN  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1235] - Session 
0x1023a0428f2 for server 127.0.0.1/127.0.0.1:16608, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-01-16 23:32:45,810 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1023a0b3b6d closed
[junit] 2017-01-16 23:32:45,810 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1023a0b3b6d
[junit] 2017-01-16 23:32:45,810 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 189031
[junit] 2017-01-16 23:32:45,811 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2017-01-16 23:32:45,811 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-01-16 23:32:45,811 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-01-16 23:32:45,812 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-01-16 23:32:45,813 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-01-16 23:32:45,819 [myid:] - INFO  [main:ZooKeeperServer@534] 
- shutting down
[junit] 2017-01-16 23:32:45,819 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 23:32:45,819 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-01-16 23:32:45,819 [myid:] - INFO  
[main:PrepRequestProcessor@1009] - Shutting down
[junit] 2017-01-16 23:32:45,819 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-01-16 23:32:45,819 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-01-16 23:32:45,820 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-01-16 23:32:45,820 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-01-16 23:32:45,820 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-01-16 23:32:45,821 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-01-16 23:32:45,821 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854
[junit] 2017-01-16 23:32:45,821 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-01-16 23:32:45,827 [myid:] - INFO  [main:ClientBase@583] - 
fdcount after test is: 4824 at start it was 4824
[junit] 2017-01-16 23:32:45,827 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-01-16 23:32:45,827 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
470.954 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest

BUILD FAILED

ZooKeeper_branch34_jdk8 - Build # 844 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/844/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 244501 lines...]
[junit] 2017-01-16 23:18:20,250 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2017-01-16 23:18:20,250 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2017-01-16 23:18:20,250 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 23:18:20,250 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2017-01-16 23:18:20,250 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2017-01-16 23:18:20,251 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-01-16 23:18:20,251 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2017-01-16 23:18:20,251 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-01-16 23:18:20,251 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2017-01-16 23:18:20,252 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-16 23:18:20,252 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-01-16 23:18:20,254 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2017-01-16 23:18:20,254 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-01-16 23:18:20,255 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-01-16 23:18:20,255 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-01-16 23:18:20,255 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test2214964557032831787.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test2214964557032831787.junit.dir/version-2
[junit] 2017-01-16 23:18:20,258 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 23:18:20,259 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-16 23:18:20,259 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:37753
[junit] 2017-01-16 23:18:20,260 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:37753
[junit] 2017-01-16 23:18:20,260 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2017-01-16 23:18:20,260 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:37753 (no session established for client)
[junit] 2017-01-16 23:18:20,260 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-16 23:18:20,262 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-01-16 23:18:20,262 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-01-16 23:18:20,263 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-01-16 23:18:20,263 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-01-16 23:18:20,263 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 33645
[junit] 2017-01-16 23:18:20,263 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-01-16 23:18:20,264 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-01-16 23:18:20,264 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2017-01-16 23:18:20,329 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x159a992fd46 closed
[junit] 2017-01-16 23:18:20,330 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2017-01-16 23:18:20,330 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2017-01-16 

Re: Anyone interested in learning about our QA build? (ZK-2665)

[Enrico Olivelli]

Great!
I will be happy to help and to understand better Zookeeper automatic QA jobs

-- Enrico

Il lun 16 gen 2017, 14:19 Flavio Junqueira  ha scritto:

> Very cool, thanks guys for volunteering, Edward and Enrico. Let me write
> down a couple of notes in the jira and we go from there.
>
> -Flavio
>
> > On 16 Jan 2017, at 12:54, Edward Ribeiro 
> wrote:
> >
> > Okay, I left two days to anyone step up. You can count on me. :)
> Where/How
> > do I start?
> >
> > Edward
> >
> > Em 14 de jan de 2017 3:39 PM, "Flavio Junqueira" 
> escreveu:
> >
> >> If anyone wants to learn about our QA build, then working on
> >> ZOOKEEPER-2665 might be a good task. It is not a difficult task as it is
> >> mainly copying stuff from master, but you'd need to understand to copy
> the
> >> right stuff. I'm willing to guide anyone interested in doing this.
> >>
> >> I can definitely do it myself if no one else is interested in picking it
> >> up.
> >>
> >> -Flavio
>
> --


-- Enrico Olivelli

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824357#comment-15824357
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277825
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

I was trying to make sure that I can generate log4j2.xml configuration 
compatible with the current log4j.properties 


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[praste]

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277825
  
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+  
+%d{ISO8601} [myid:%X{myid}] - 
%-5p [%t:%C{1}@%L] - %m%n
--- End diff --

I was trying to make sure that I can generate log4j2.xml configuration 
compatible with the current log4j.properties 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2659) Use log4j2 as a logging framework as log4j 1.X is now deprecated

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824353#comment-15824353
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2659:
---

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277523
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

I don't think we should be using 'log4j 1' at all


> Use log4j2 as a logging framework as log4j 1.X is now deprecated
> 
>
> Key: ZOOKEEPER-2659
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2659
> Project: ZooKeeper
>  Issue Type: Wish
>Reporter: Pushkar Raste
>Priority: Minor
> Attachments: zk_log4j2_migration.patch
>
>
> Zookeeper currently uses {{log4j 1.X}} as the default logging framework. 
> {{log4j 1.X}} is now deprecated http://logging.apache.org/log4j/1.2/
> This ticket is to track efforts to move zookeeper to {{log4j2}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #148: ZOOKEEPER-2659 Log4j 2 migration

[praste]

Github user praste commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/148#discussion_r96277523
  
--- Diff: ivy.xml ---
@@ -41,13 +41,20 @@
 
   
 
-
+
+
+
+
+
+
+
+
 
   
 
 
 
-
+
--- End diff --

I don't think we should be using 'log4j 1' at all


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824332#comment-15824332
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
> Are you OK with us removing the deprecated methods when 3.5 becomes GA?
No. I'd vote against that. Breaking changes should be in a 3.6 version. 
That was the genesis of this issue to begin with. Regardless of the intent of 
the ZK team, 3.5.x has been in production in a large number of companies for 
years now. To break a public API without increment the version will cause 
unnecessary problems.


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[Randgalt]

Github user Randgalt commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
> Are you OK with us removing the deprecated methods when 3.5 becomes GA?
No. I'd vote against that. Breaking changes should be in a 3.6 version. 
That was the genesis of this issue to begin with. Regardless of the intent of 
the ZK team, 3.5.x has been in production in a large number of companies for 
years now. To break a public API without increment the version will cause 
unnecessary problems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch35_solaris - Build # 398 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/398/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 468880 lines...]
[junit] 2017-01-16 17:14:42,509 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2017-01-16 17:14:42,509 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2017-01-16 17:14:42,509 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2017-01-16 17:14:42,510 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2017-01-16 17:14:42,510 [myid:] - INFO  [main:ZooKeeperServer@893] 
- minSessionTimeout set to 6000
[junit] 2017-01-16 17:14:42,511 [myid:] - INFO  [main:ZooKeeperServer@902] 
- maxSessionTimeout set to 6
[junit] 2017-01-16 17:14:42,511 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1002186927836853385.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1002186927836853385.junit.dir/version-2
[junit] 2017-01-16 17:14:42,511 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1002186927836853385.junit.dir/version-2/snapshot.b
[junit] 2017-01-16 17:14:42,513 [myid:] - INFO  [main:FileTxnSnapLog@320] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1002186927836853385.junit.dir/version-2/snapshot.b
[junit] 2017-01-16 17:14:42,515 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 17:14:42,515 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2017-01-16 17:14:42,515 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:48161
[junit] 2017-01-16 17:14:42,516 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:48161
[junit] 2017-01-16 17:14:42,516 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2017-01-16 17:14:42,517 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:48161 (no session established for client)
[junit] 2017-01-16 17:14:42,517 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-16 17:14:42,518 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2017-01-16 17:14:42,518 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2017-01-16 17:14:42,518 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2017-01-16 17:14:42,518 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2017-01-16 17:14:42,519 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17889
[junit] 2017-01-16 17:14:42,519 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2017-01-16 17:14:42,519 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2017-01-16 17:14:42,519 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-01-16 17:14:42,602 [myid:] - INFO  [main:ZooKeeper@1322] - 
Session: 0x126253f7942 closed
[junit] 2017-01-16 17:14:42,602 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-01-16 17:14:42,602 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x126253f7942
[junit] 2017-01-16 17:14:42,603 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-01-16 17:14:42,603 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-16 17:14:42,603 [myid:] - INFO  

Re: ZooKeeper cwiki - Updated ZooKeeper and SASL auth 1045 work

[Rakesh Radhakrishnan]

Hi All,

FYI, I'm planning to delete our existing "https://cwiki.apache.org/
confluence/display/ZOOKEEPER/Zookeeper+and+SASL" web page by tomorrow (IST).

Then rename https://cwiki.apache.org/confluence/display/ZOOKEEPER/
ZooKeeper+and+SASL+authentication web page to "https://cwiki.apache.org/
confluence/display/ZOOKEEPER/Zookeeper+and+SASL" in place of the deleted
page.

Please let me know if you have any comments. Thanks!

Regards,
Rakesh

On Tue, Dec 20, 2016 at 6:03 PM, Rakesh Radhakrishnan 
wrote:

> Like I mentioned at the beginning of this mail thread, presently I've
> maintained this original page as a history. How about deleting this old
> page now and rename the newly added "https://cwiki.apache.org/
> confluence/display/ZOOKEEPER/ZooKeeper+and+SASL+authentication" in place
> of the old page? I think, that will help the existing webpages to continue
> referring to a valid cwiki ZK sasl page. Otw those links becomes stale.
>
> I could see many blogs, wiki already have a reference link to our existing
> "https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL;
> page.
>
> Following are few blogs/sites which has a reference to the ZK SASL page:-
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 38%3A+ZooKeeper+Authentication
> http://blog.intelligencecomputing.io/security/12409/repost-
> zookeeper-and-sasl
>
> Thanks,
> Rakesh
>
>
> On Tue, Dec 20, 2016 at 7:02 AM, Patrick Hunt  wrote:
>
>> LGTM. Those changes are very helpful, thanks Rakesh!
>>
>> Patrick
>>
>> On Mon, Dec 19, 2016 at 12:04 PM, Rakesh Radhakrishnan <
>> rake...@apache.org>
>> wrote:
>>
>> > Thanks a lot Patrick Hunt for the review comments. Please take another
>> look
>> > at the wiki page when you get a chance.
>> >
>> > I've updated the wiki page addressing these,.
>> >
>> > 1) ===> DONE. Added JCE encryption part.
>> > 2) ===> DONE. Corrected case.
>> > 3) ===> DONE. Included version.
>> > 4) ===> DONE. Corrected numbering format.
>> > 5) ===> DONE. Added an example case to understand the tuning mechanism.
>> > 6) ===> DONE. I've removed this part because it can be discussed
>> separately
>> > and added if someone has a use case.
>> > 7) ===> DONE. Rephrased upgrade feature section
>> >
>> > Thanks,
>> > Rakesh
>> >
>> > On Wed, Dec 14, 2016 at 9:03 AM, Patrick Hunt  wrote:
>> >
>> > > Nice job Rakesh, some comments:
>> > >
>> > > 1) the appendix is a great idea, should be useful for many people. One
>> > > thing I noticed
>> > > "There is no additional dependencies needed to use SASL with Java
>> since
>> > it
>> > > is part of the the Java Standard Edition." - you might want to
>> > mention/link
>> > > the JCE? The JVM doesn't come with very modern encryption - some of
>> the
>> > > distros use more strong encryption out of the box with kerberos. I've
>> run
>> > > into this a number of times (need to also install JCE).
>> > >
>> > > 2) consistently use "ZooKeeper" rather than "Zookeeper". Only noticed
>> > this
>> > > in a few places...
>> > >
>> > > 3) on client-server it would be good to mention when it was added
>> > (3.4.0+),
>> > > similar to what you did with 1045.
>> > >
>> > > 4) on "ZooKeeper SASL configurations" the numbering of the bullets
>> starts
>> > > at 2.1. and finishes at 2.4. I suspect the formatting didn't copy over
>> > > quite right?
>> > >
>> > > 5) similar formatting issue for "# Defaulting to
>> > > 20quorum.cnxn.threads.size=20"
>> > >
>> > > Can we give any insight into how this value should be set? i.e. why
>> is 20
>> > > the default and when should it be raised/lowered?
>> > >
>> > > 6) can the doc shed any light on why we are recommending
>> > > "javax.security.auth.useSubjectCredsOnly=false" ? I'm not familiar
>> with
>> > > this myself.
>> > >
>> > > 7) "This feature is supported in 3.4 branch" is ambiguous - perhaps
>> > > rephrase. What "feature" are you referring to, 1045 or to rolling
>> > upgrade?
>> > > Also the ref to 3.4 itself is ambiguous - perhaps change to 3.4.10+?
>> > >
>> > > These are some minor nits, overall impressive effort -- thanks again
>> > > Rakesh!
>> > >
>> > > Patrick
>> > >
>> > >
>> > >
>> > > On Tue, Dec 13, 2016 at 6:56 PM, Rakesh Radhakrishnan <
>> > rake...@apache.org>
>> > > wrote:
>> > >
>> > > > Hi All,
>> > > >
>> > > > I've incorporated ZK-1045 feature details into the Apache ZooKeeper
>> > > project
>> > > > cwiki. Since "ZooKeeper and SASL" section is quite large I've
>> splitted
>> > > > ZooKeeper client-server and server-server sections into sub-pages.
>> > Please
>> > > > read the following page,
>> > > >
>> > > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> > > ZooKeeper+and+SASL+
>> > > > authentication
>> > > >
>> > > > *ZooKeeper and SASL authentication*
>> > > >
>> > > >- Client-Server mutual authentication
>> > > >- Server-Server mutual authentication
>> > > >- Appendix: Kerberos, GSSAPI, SASL, and JAAS
>> > > >
>> > > > I have reused the 

Re: ZooKeeper 3.4.10 release discussion

[Rakesh Radhakrishnan]

Hi folks,

As we all know, 3.4.10 release is the first ZooKeeper release after the
github repository migration. I have tried an attempt to modify the steps
described in the '
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease' page to
make the release. Since this release is from an already created branch, I
have focused only the branch related parts in cwiki and below sections in
the page needed changes like,


*Updating the release branch*
1. Check out the branch with:
git clone -b branch-X.Y
https://git-wip-us.apache.org/repos/asf/zookeeper.git

2. I'm skipping this step, which is not required now.

4. Update CHANGES.txt with the committed jira details. As we follow PR
merging, most of the jira info is not updated in this file. I believe
release manager need to update this file to capture the jira details marked
for that release.

10. Commit these changes.
git commit -a -m "Preparing for release X.Y.Z"
git push  

11. Tag the release candidate (R is the release candidate number, and
starts from 0):
git tag -s release-X.Y.Z-rcR -m "ZooKeeper X.Y.Z-rcR release."

Push the newly created rc tag to the remote repo.
git push  release-X.Y.Z-rcR


*Building*
9. Call for a release vote on dev
  In the release candidate dev mail format, it needs to change the
tag like,

  "The RC tag in git to be voted upon: release-X.Y.Z-rcR"


*Publishing*
1. Tag the release:
git tag -s release-X.Y.Z -m "ZooKeeper X.Y.Z release."

Push the newly created release tag to the remote repo.
git push  release-X.Y.Z


I'd like to know whether I'm going in the right direction and start cutting
the 3.4.10 release by following this approach. Thanks!

Thanks,
Rakesh

On Mon, Jan 16, 2017 at 11:09 AM, Rakesh Radhakrishnan 
wrote:

> Thanks for pointing this jira. I will take a look at this.
>
> Rakesh
>
> On Fri, Jan 13, 2017 at 7:27 PM, Edward Ribeiro 
> wrote:
>
>> Hi Rakesh,
>>
>> Thansk for stepping up to this task! Pretty cool! :)
>>
>> Do you think https://issues.apache.org/jira/browse/ZOOKEEPER-2573 is
>> worth
>> targeting 3.4.10 too?
>>
>> Edward
>>
>>
>>
>> On Fri, Jan 13, 2017 at 7:56 AM, Rakesh Radhakrishnan > >
>> wrote:
>>
>> > Hi All,
>> >
>> > I hope to cut an RC in a week - giving some more time for your favorite
>> > outstanding blocker/critical issues. Will start moving out any tickets
>> that
>> > are not blockers and/or won’t fit the timeline - there are 1 blocker, 5
>> > critical, 15 major, 7 minor tickets outstanding as of now. Appreciate
>> your
>> > support in releasing 3.4.10 version. Thanks!
>> >
>> > Please find the open issues marked for 3.4.10 release here,
>> > https://goo.gl/XdraFA
>> >
>> > Thanks,
>> > Rakesh
>> >
>> >
>> > On Tue, Dec 6, 2016 at 4:15 PM, Rakesh Radhakrishnan <
>> rake...@apache.org>
>> > wrote:
>> >
>> > > Hi All,
>> > >
>> > > I am interested in going through the release process as the RM.
>> > >
>> > > Overall, I could see total 41 issues marked for 3.4.10 release as of
>> now,
>> > > which includes 4 blockers, 5 critical, 20 major and 12 minor issues. I
>> > > count 9 issues fixed/committed already for 3.4.10 which includes 1
>> > blocker
>> > > and 1 critical(security related) issue. ZOOKEEPER-1045 is a much
>> awaited
>> > > one and the feature code is committed. I think it is a good time to
>> > > initiate the discussion of 3.4.10 release processes.
>> > >
>> > > Please find the issues marked for 3.4.10 release here,
>> > > https://goo.gl/FfbpVG
>> > >
>> > > Currently, I'm focusing on updating ZOOKEEPER-1045 feature details
>> into
>> > > our project cwiki and related ZOOKEEPER-2479 improvement jira. I'd
>> like
>> > to
>> > > include ZOOKEEPER-2383 into this release if everyone agrees.
>> Appreciate
>> > > your help in reviewing the jira patches and making it stable for
>> release.
>> > > Also, please feel free to push your favorite issues ahead of 3.4.10
>> > release.
>> > >
>> > > I hope with the community support, we should be able to close all
>> > > necessary blockers/critical issues soon. Kindly requesting everyone to
>> > look
>> > > at the issues marked for 3.4.10 and push these asap or can be pushed
>> out
>> > to
>> > > 3.4.11.
>> > >
>> > > Imp: Since we moved to github repository, the release procedure
>> > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
>> > > requires changes. Appreciate your help in this part. Thanks!
>> > >
>> > > Please let me know your thoughts on the plan.
>> > >
>> > > Thanks,
>> > > Rakesh
>> > >
>> >
>>
>
>

[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync

[Arshad Mohammad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824117#comment-15824117
 ] 

Arshad Mohammad commented on ZOOKEEPER-2577:


Test case expectation is wrong. Test case is expecting the old leader to be the 
follower only, which is not correct.
Old leader can become the leader again. I will soon raise a merge request.

> Flaky Test: 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
> 
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Arshad Mohammad
>  Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> This failure is new and consistent on jdk7/8 with trunk branch - happened 
> after build 3070 recently. Not sure if this is caused by svn - git migration 
> or not.
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
>   at 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO  [main:ZKTestCase$1@55] - STARTING 
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO  [main:PortAssignment@151] - Test 
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
>  clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
>  clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
>  clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-0:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-2:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-1:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO  [main:FourLetterWordMain@85] - 
> connecting to 127.0.0.1 13915
> 2016-09-13 05:09:25,425 [myid:] - INFO  [Thread-0:QuorumPeerConfig@318] - 
> clientPortAddress is 

[jira] [Assigned] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync

[Arshad Mohammad (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arshad Mohammad reassigned ZOOKEEPER-2577:
--

Assignee: Arshad Mohammad

> Flaky Test: 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
> 
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Arshad Mohammad
>  Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> This failure is new and consistent on jdk7/8 with trunk branch - happened 
> after build 3070 recently. Not sure if this is caused by svn - git migration 
> or not.
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
>   at 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO  [main:ZKTestCase$1@55] - STARTING 
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO  [main:PortAssignment@151] - Test 
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
>  clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
>  clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
>  clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-0:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-2:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-1:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,424 [myid:] - INFO  [main:FourLetterWordMain@85] - 
> connecting to 127.0.0.1 13915
> 2016-09-13 05:09:25,425 [myid:] - INFO  [Thread-0:QuorumPeerConfig@318] - 
> clientPortAddress is 0.0.0.0/0.0.0.0:13915
> 2016-09-13 05:09:25,425 [myid:] - INFO  [Thread-0:QuorumPeerConfig@322] - 
> secureClientPort is not set
> 2016-09-13 05:09:25,425 [myid:] - INFO  [Thread-1:QuorumPeerConfig@318] - 
> 

[jira] [Commented] (ZOOKEEPER-2642) ZOOKEEPER-2014 breaks existing clients for little benefit

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824106#comment-15824106
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2642:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@Randgalt 
>> when are we going to be removing these deprecated methods, in trunk
> Maybe when we get a stable release of 3.5?

Are you OK with us removing the deprecated methods when 3.5 becomes GA?

> Agree, for trunk the change would be just rename ZooKeeperAdmin::reconfig 
to ZooKeeperAdmin::reconfigure so it's consistent with branch-3.5 (with some 
documentation updates and tests update.).

We need to either create a new issue or have a different pull request for 
3.5 under this same issue. I'd rather do the latter just so that we wrap this 
up in one shot, but it depends on whether @Randgalt is willing to do it.


> ZOOKEEPER-2014 breaks existing clients for little benefit
> -
>
> Key: ZOOKEEPER-2642
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2642
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client, java client
>Affects Versions: 3.5.2
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Blocker
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, ZOOKEEPER-2642.patch, 
> ZOOKEEPER-2642.patch
>
>
> ZOOKEEPER-2014 moved the reconfig() methods into a new class, ZooKeeperAdmin. 
> It appears this was done to document that these are methods have access 
> restrictions. However, this change breaks Apache Curator (and possibly other 
> clients). Curator APIs will have to be changed and/or special methods need to 
> be added. A breaking change of this kind should only be done when the benefit 
> is overwhelming. In this case, the same information can be conveyed with 
> documentation and possibly a deprecation notice.
> Revert the creation of the ZooKeeperAdmin class and move the reconfig() 
> methods back to the ZooKeeper class with additional documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

[fpj]

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/122
  
@Randgalt 
>> when are we going to be removing these deprecated methods, in trunk
> Maybe when we get a stable release of 3.5?

Are you OK with us removing the deprecated methods when 3.5 becomes GA?

> Agree, for trunk the change would be just rename ZooKeeperAdmin::reconfig 
to ZooKeeperAdmin::reconfigure so it's consistent with branch-3.5 (with some 
documentation updates and tests update.).

We need to either create a new issue or have a different pull request for 
3.5 under this same issue. I'd rather do the latter just so that we wrap this 
up in one shot, but it depends on whether @Randgalt is willing to do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch34_openjdk7 - Build # 1350 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1350/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H13 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > git://git.apache.org/zookeeper.git +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision cded802708fac417369affbd25bf9ad2016a904d 
(refs/remotes/origin/branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f cded802708fac417369affbd25bf9ad2016a904d
 > git rev-list cded802708fac417369affbd25bf9ad2016a904d # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ /home/jenkins/tools/ant/latest/bin/ant 
-Dtest.output=yes -Dtest.junit.threads=8 -Dtest.junit.output.format=xml 
-Djavac.target=1.7 clean test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch34_solaris - Build # 1433 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_solaris/1433/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 191069 lines...]
[junit] 2017-01-16 13:54:32,139 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2017-01-16 13:54:32,139 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 13:54:32,139 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2017-01-16 13:54:32,139 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2017-01-16 13:54:32,140 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-01-16 13:54:32,140 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2017-01-16 13:54:32,140 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-01-16 13:54:32,140 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2017-01-16 13:54:32,141 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-16 13:54:32,142 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-01-16 13:54:32,144 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2017-01-16 13:54:32,144 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-01-16 13:54:32,145 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-01-16 13:54:32,145 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-01-16 13:54:32,145 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test6507705728881883657.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/build/test/tmp/test6507705728881883657.junit.dir/version-2
[junit] 2017-01-16 13:54:32,148 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 13:54:32,149 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2017-01-16 13:54:32,149 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:61777
[junit] 2017-01-16 13:54:32,149 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:61777
[junit] 2017-01-16 13:54:32,150 [myid:] - INFO  
[Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2017-01-16 13:54:32,150 [myid:] - INFO  
[Thread-5:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:61777 (no session established for client)
[junit] 2017-01-16 13:54:32,150 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-16 13:54:32,152 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-01-16 13:54:32,152 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-01-16 13:54:32,152 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-01-16 13:54:32,152 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-01-16 13:54:32,153 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 8997
[junit] 2017-01-16 13:54:32,153 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-01-16 13:54:32,153 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-01-16 13:54:32,153 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2017-01-16 13:54:32,223 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x159a78ed000 closed
[junit] 2017-01-16 13:54:32,223 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x159a78ed000
[junit] 2017-01-16 13:54:32,223 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2017-01-16 13:54:32,224 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2017-01-16 13:54:32,224 [myid:] - 

Re: Anyone interested in learning about our QA build? (ZK-2665)

[Flavio Junqueira]

Very cool, thanks guys for volunteering, Edward and Enrico. Let me write down a 
couple of notes in the jira and we go from there.

-Flavio

> On 16 Jan 2017, at 12:54, Edward Ribeiro  wrote:
> 
> Okay, I left two days to anyone step up. You can count on me. :) Where/How
> do I start?
> 
> Edward
> 
> Em 14 de jan de 2017 3:39 PM, "Flavio Junqueira"  escreveu:
> 
>> If anyone wants to learn about our QA build, then working on
>> ZOOKEEPER-2665 might be a good task. It is not a difficult task as it is
>> mainly copying stuff from master, but you'd need to understand to copy the
>> right stuff. I'm willing to guide anyone interested in doing this.
>> 
>> I can definitely do it myself if no one else is interested in picking it
>> up.
>> 
>> -Flavio

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823954#comment-15823954
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96227005
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

+1


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts 

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96227005
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection 
serverAddresses)
 Collections.shuffle(this.serverAddresses);
 }
 
+/**
+ * In Java 7, we have a method getHostString, but earlier versions do 
not support it.
+ * This method is to provide a replacement for 
InetSocketAddress.getHostString().
+ *
+ * It evaluates to a hostname if one is available and otherwise it 
returns the
+ * string representation of the IP address.
+ *
+ * @param addr
+ * @return Hostname string of address parameter
+ */
+private String getHostString(InetSocketAddress addr) {
+String hostString;
+InetAddress ia = addr.getAddress();
+
+if (ia != null) {
+// If the string starts with '/', then it has no hostname
+// and we want to avoid the reverse lookup, so we return
+// the string representation of the address.
+if (ia.toString().startsWith("/")) {
+hostString = ia.getHostAddress();
+} else {
+hostString = addr.getHostName();
+}
+} else {
+// According to the Java 6 documentation, if the hostname is
+// unresolved, then the string before the colon is the 
hostname.
+String addrString = addr.toString();
+hostString = addrString.substring(0, 
addrString.lastIndexOf(':'));
+}
+
+return hostString;
+}
+
 public int size() {
 return serverAddresses.size();
 }
 
 public InetSocketAddress next(long spinDelay) {
-++currentIndex;
-if (currentIndex == serverAddresses.size()) {
-currentIndex = 0;
+// Handle possible connection error by re-resolving hostname if 
possible
+if (!connectedSinceNext) {
+InetSocketAddress curAddr = serverAddresses.get(currentIndex);
+if 
(!curAddr.getHostString().equals(curAddr.getAddress().getHostAddress())) {
+try {
+int thePort = curAddr.getPort();
+InetAddress resolvedAddresses[] = 
InetAddress.getAllByName(getHostString(curAddr));
+if (resolvedAddresses.length == 1) {
+serverAddresses.set(currentIndex, new 
InetSocketAddress(resolvedAddresses[0], thePort));
+} else {
+serverAddresses.remove(currentIndex);
+for (InetAddress resolvedAddress : 
resolvedAddresses) {
+InetSocketAddress newAddr = new 
InetSocketAddress(resolvedAddress, thePort);
+if (!serverAddresses.contains(newAddr)) {
+serverAddresses.add(newAddr);
+}
+}
+}
+} catch (UnknownHostException e) {
+LOG.warn("Cannot re-resolve server: " + curAddr + " 
UnknownHostException: " + e);
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823951#comment-15823951
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2184:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96226819
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -45,6 +45,9 @@
 
 private int currentIndex = -1;
 
+// Don't re-resolve on first next() call
+private boolean connectedSinceNext = true;
--- End diff --

My reasoning was only defensively, but on a 2nd look, it would be overkill. 
So, no problem without being volatile, imo.


> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/150#discussion_r96226819
  
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
@@ -45,6 +45,9 @@
 
 private int currentIndex = -1;
 
+// Don't re-resolve on first next() call
+private boolean connectedSinceNext = true;
--- End diff --

My reasoning was only defensively, but on a 2nd look, it would be overkill. 
So, no problem without being volatile, imo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823942#comment-15823942
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96225742
  
--- Diff: src/java/main/org/apache/zookeeper/Version.java ---
@@ -20,7 +20,7 @@
 
 public class Version implements org.apache.zookeeper.version.Info {
 
-public static int getRevision() {
+public static String getRevision() {
--- End diff --

Good question! Um... Maybe we should contact folks at Kafka, HBase and 
other projects for feedback? Anyone has a clue?


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96225742
  
--- Diff: src/java/main/org/apache/zookeeper/Version.java ---
@@ -20,7 +20,7 @@
 
 public class Version implements org.apache.zookeeper.version.Info {
 
-public static int getRevision() {
+public static String getRevision() {
--- End diff --

Good question! Um... Maybe we should contact folks at Kafka, HBase and 
other projects for feedback? Anyone has a clue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[Flavio Junqueira (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira reassigned ZOOKEEPER-2184:
---

Assignee: Flavio Junqueira  (was: Robert P. Thille)

> Zookeeper Client should re-resolve hosts when connection attempts fail
> --
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper & 
> Kafka
>Reporter: Robert P. Thille
>Assignee: Flavio Junqueira
>  Labels: easyfix, patch
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single 
> Zookeeper instance. Restarting the Zookeeper container will cause it to 
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper 
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP 
> address will not help the client to reconnect as the 
> zookeeper/client/StaticHostProvider resolves the connection string hosts at 
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail 
> and attempt to re-resolve the hostnames in the connectString.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823939#comment-15823939
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96225530
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

Hi @rakeskadr, usually the first 8 characters of commit are enough to 
identify the commit.

But I think putting the whole SHA-1 is nice, because the more context the 
better. Also, it simplifies the code even more (to substr the sha1 is annoying 
on windows).

Thanks for pointing out!


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96225530
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

Hi @rakeskadr, usually the first 8 characters of commit are enough to 
identify the commit.

But I think putting the whole SHA-1 is nice, because the more context the 
better. Also, it simplifies the code even more (to substr the sha1 is annoying 
on windows).

Thanks for pointing out!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Anyone interested in learning about our QA build? (ZK-2665)

[Edward Ribeiro]

Okay, I left two days to anyone step up. You can count on me. :) Where/How
do I start?

Edward

Em 14 de jan de 2017 3:39 PM, "Flavio Junqueira"  escreveu:

> If anyone wants to learn about our QA build, then working on
> ZOOKEEPER-2665 might be a good task. It is not a difficult task as it is
> mainly copying stuff from master, but you'd need to understand to copy the
> right stuff. I'm willing to guide anyone interested in doing this.
>
> I can definitely do it myself if no one else is interested in picking it
> up.
>
> -Flavio

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823877#comment-15823877
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96218924
  
--- Diff: src/java/main/org/apache/zookeeper/Version.java ---
@@ -20,7 +20,7 @@
 
 public class Version implements org.apache.zookeeper.version.Info {
 
-public static int getRevision() {
+public static String getRevision() {
--- End diff --

Since this is not an exposed interface it is OK to change the signature. 
But, I'm curious to know that any other project or users depending on the 
revision number.


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96218924
  
--- Diff: src/java/main/org/apache/zookeeper/Version.java ---
@@ -20,7 +20,7 @@
 
 public class Version implements org.apache.zookeeper.version.Info {
 
-public static int getRevision() {
+public static String getRevision() {
--- End diff --

Since this is not an exposed interface it is OK to change the signature. 
But, I'm curious to know that any other project or users depending on the 
revision number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper-trunk-jdk8 - Build # 903 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/903/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 458855 lines...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-01-16 11:59:21,112 [myid:] - INFO  [New I/O boss 
#66:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-01-16 11:59:21,112 [myid:127.0.0.1:24687] - INFO  
[main-SendThread(127.0.0.1:24687):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x1023ad2839c is lost, closing socket connection and attempting 
reconnect
[junit] 2017-01-16 12:00:54,843 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 133619
[junit] 2017-01-16 12:00:54,844 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2017-01-16 12:00:54,844 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2017-01-16 12:00:54,845 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-01-16 12:00:54,846 [myid:] - INFO  [ProcessThread(sid:0 
cport:27383)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x1023ad0fcd1
[junit] 2017-01-16 12:00:54,895 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1023ad0fcd1 closed
[junit] 2017-01-16 12:00:54,895 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1023ad0fcd1
[junit] 2017-01-16 12:00:54,895 [myid:] - INFO  
[NIOWorkerThread-26:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1023ad0fcd1]
[junit] 2017-01-16 12:00:54,895 [myid:] - INFO  [ProcessThread(sid:0 
cport:27383)::PrepRequestProcessor@618] - Processed session termination for 
sessionid: 0x1023ad0fcd10001
[junit] 2017-01-16 12:00:54,896 [myid:] - INFO  
[NIOWorkerThread-26:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:36884 which had sessionid 0x1023ad0fcd1
[junit] 2017-01-16 12:00:54,927 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1023ad0fcd10001 closed
[junit] 2017-01-16 12:00:54,927 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1023ad0fcd10001
[junit] 2017-01-16 12:00:54,927 [myid:] - INFO  
[NIOWorkerThread-30:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27383,name1=Connections,name2=127.0.0.1,name3=0x1023ad0fcd10001]
[junit] 2017-01-16 12:00:54,927 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-01-16 12:00:54,929 [myid:] - INFO  
[NIOWorkerThread-30:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:36860 which had sessionid 0x1023ad0fcd10001
[junit] 2017-01-16 12:00:54,929 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-01-16 12:00:54,931 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-16 12:00:54,932 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:27383:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2017-01-16 12:00:54,932 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-01-16 12:00:54,934 [myid:] - INFO  [main:ZooKeeperServer@534] 
- shutting down
[junit] 2017-01-16 12:00:54,934 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so 

[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt git repo

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823820#comment-15823820
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2573:
---

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96212537
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

Thanks @eribeiro for the patch. Any specific reason to use only the first 8 
characters of the git SHA-1. Will this be helpful in analyzing whether a 
particular fix included in the release?

How about keeping the complete SHA-1?


> Modify Info.REVISION to adapt git repo
> --
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: build, server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Arshad Mohammad
>Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo 
> revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo 
> revision which is of type int
> But after migrating to git repo the git repo's revision(commit 
> 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable 
> to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be 
> modified. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper pull request #137: ZOOKEEPER-2573: Modify Info.REVISION to adapt g...

[rakeshadr]

Github user rakeshadr commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/137#discussion_r96212537
  
--- Diff: src/lastRevision.sh ---
@@ -16,6 +16,6 @@
 
 # Find the current revision, store it in a file
 FILE=$1
-LASTREV=`svn info | grep '^Revision' | sed -e 's/Revision: *//'`
+LASTREV=`git rev-parse HEAD | cut -c1-8`
--- End diff --

Thanks @eribeiro for the patch. Any specific reason to use only the first 8 
characters of the git SHA-1. Will this be helpful in analyzing whether a 
particular fix included in the release?

How about keeping the complete SHA-1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper-trunk-solaris - Build # 1468 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1468/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 472551 lines...]
[junit] 2017-01-16 08:24:51,146 [myid:] - INFO  [main:ClientBase@401] - 
CREATING server instance 127.0.0.1:11222
[junit] 2017-01-16 08:24:51,147 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2017-01-16 08:24:51,147 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2017-01-16 08:24:51,148 [myid:] - INFO  [main:ClientBase@376] - 
STARTING server instance 127.0.0.1:11222
[junit] 2017-01-16 08:24:51,148 [myid:] - INFO  [main:ZooKeeperServer@894] 
- minSessionTimeout set to 6000
[junit] 2017-01-16 08:24:51,148 [myid:] - INFO  [main:ZooKeeperServer@903] 
- maxSessionTimeout set to 6
[junit] 2017-01-16 08:24:51,149 [myid:] - INFO  [main:ZooKeeperServer@160] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test3598977637547994720.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test3598977637547994720.junit.dir/version-2
[junit] 2017-01-16 08:24:51,149 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test3598977637547994720.junit.dir/version-2/snapshot.b
[junit] 2017-01-16 08:24:51,151 [myid:] - INFO  [main:FileTxnSnapLog@346] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test3598977637547994720.junit.dir/version-2/snapshot.b
[junit] 2017-01-16 08:24:51,153 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-01-16 08:24:51,153 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2017-01-16 08:24:51,153 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:53446
[junit] 2017-01-16 08:24:51,154 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:53446
[junit] 2017-01-16 08:24:51,154 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2017-01-16 08:24:51,154 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@614] - Closed socket connection for client 
/127.0.0.1:53446 (no session established for client)
[junit] 2017-01-16 08:24:51,155 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-01-16 08:24:51,156 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2017-01-16 08:24:51,156 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2017-01-16 08:24:51,156 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2017-01-16 08:24:51,156 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2017-01-16 08:24:51,157 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17904
[junit] 2017-01-16 08:24:51,157 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2017-01-16 08:24:51,157 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2017-01-16 08:24:51,157 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-01-16 08:24:51,232 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x126235a5d66 closed
[junit] 2017-01-16 08:24:51,232 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-01-16 08:24:51,232 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x126235a5d66
[junit] 2017-01-16 08:24:51,232 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2017-01-16 08:24:51,232 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-01-16 08:24:51,233 [myid:] - INFO