ZooKeeper_branch35_jdk7 - Build # 903 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/903/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.78 MB...]
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-03-27 08:49:22,654 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=Connections,name2=127.0.0.1,name3=0x1033a27153e]
[junit] 2017-03-27 08:49:22,754 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1033a27153e closed
[junit] 2017-03-27 08:49:22,755 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 211809
[junit] 2017-03-27 08:49:22,755 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2427
[junit] 2017-03-27 08:49:22,755 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-27 08:49:22,755 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-03-27 08:49:22,756 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-03-27 08:49:22,756 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22240
[junit] 2017-03-27 08:49:22,754 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1033a27153e
[junit] 2017-03-27 08:49:22,766 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-03-27 08:49:22,766 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 08:49:22,769 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 08:49:22,770 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-03-27 08:49:22,770 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 08:49:22,770 [myid:] - INFO  [ProcessThread(sid:0 
cport:22240)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 08:49:22,770 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 08:49:22,771 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 08:49:22,771 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=InMemoryDataTree]
[junit] 2017-03-27 08:49:22,771 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240]
[junit] 2017-03-27 08:49:22,772 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22240
[junit] 2017-03-27 08:49:22,773 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 08:49:22,783 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 7141 at start it was 7141
[junit] 2017-03-27 08:49:22,783 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-27 08:49:22,784 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
478.328 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-27 08:49:22,935 [myid:127.0.0.1:22120] - INFO  
[main-SendThread(127.0.0.1:22120):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22120. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 08:49:22,936 [myid:127.0.0.1:22120] - WARN  
[main-SendThread(127.0.0.1:22120):ClientCnxn$SendThread@1235] - Session 
0x2033a23b940 for server 127.0.0.1/127.0.0.1:22120, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChan

ZooKeeper_branch35_jdk8 - Build # 471 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/471/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.49 MB...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 12:15:56,426 [myid:] - INFO  [ProcessThread(sid:0 
cport:14161)::PrepRequestProcessor@613] - Processed session termination for 
sessionid: 0x1045580cdf6
[junit] 2017-03-27 12:15:56,428 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=Connections,name2=127.0.0.1,name3=0x1045580cdf6]
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1045580cdf6 closed
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1045580cdf6
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 123855
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 468
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-03-27 12:15:56,429 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:14161
[junit] 2017-03-27 12:15:56,430 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-03-27 12:15:56,430 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 12:15:56,430 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  [ProcessThread(sid:0 
cport:14161)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@158] - SessionTrackerImpl exited loop!
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=InMemoryDataTree]
[junit] 2017-03-27 12:15:56,431 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161]
[junit] 2017-03-27 12:15:56,432 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 14161
[junit] 2017-03-27 12:15:56,432 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 12:15:56,435 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1399 at start it was 1395
[junit] 2017-03-27 12:15:56,435 [myid:] - INFO  [main:ClientBase@570] - 
sleeping for 20 secs
[junit] 2017-03-27 12:15:56,435 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-27 12:15:56,435 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
456.138 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-27 12:15:56,577 [myid:127.0.0.1:14044] - INFO  
[main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14044. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 12:15:56,578 [myid:127.0.0.1:14044] - WARN  
[main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1235] - Session 
0x304557dc488 for server 127.0.0.1/127.0.0.1:14044, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection 

ZooKeeper_branch34_openjdk7 - Build # 1445 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1445/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H15 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.apache.org/zookeeper.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision b0aaa7de5b28375cd34ead8c8fbf14e3ebddd30f 
(refs/remotes/origin/branch-3.4)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f b0aaa7de5b28375cd34ead8c8fbf14e3ebddd30f
 > git rev-list b0aaa7de5b28375cd34ead8c8fbf14e3ebddd30f # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant -Dtest.output=yes 
-Dtest.junit.threads=8 -Dtest.junit.output.format=xml -Djavac.target=1.7 clean 
test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #207: ZOOKEEPER-2737: close netty connection when exceptions...

[afine]

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943553#comment-15943553
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2737:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
+1


> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper issue #207: ZOOKEEPER-2737: close netty connection when exceptions...

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
Ugh, sorry about that. ;-)

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943590#comment-15943590
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2737:
---

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
Ugh, sorry about that. ;-)

+1


> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper issue #207: ZOOKEEPER-2737: close netty connection when exceptions...

[rakeshadr]

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
Thanks @hanm, +1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943653#comment-15943653
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2737:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/207
  
Thanks @hanm, +1 LGTM


> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #209: ZOOKEEPER-2738 maxClientCnxns not limiting conc...

[vincentpoon]

GitHub user vincentpoon opened a pull request:

https://github.com/apache/zookeeper/pull/209

ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections pro…

…perly

The problem was that in branch-3.5+ , because of ZOOKEEPER-1504, we now 
have one acceptor thread and multiple selector threads.  The acceptor thread 
was checking the max connections, but adding the connection to the ipMap (used 
to check maxCnxnCount) was done in the selector threads.  As a result, when 
many connections come in concurrently, the acceptor thread can potentially 
accept many connections before the selector threads have a chance to update the 
ipMap.

This patch updates the ipMap from the acceptor thread immediately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vincentpoon/zookeeper ZOOKEEPER-2738

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #209


commit c4fdafbf94f8e6296a349eb10ff02f2d77a2ddb8
Author: Vincent 
Date:   2017-03-27T17:19:37Z

ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections properly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943684#comment-15943684
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2738:
---

GitHub user vincentpoon opened a pull request:

https://github.com/apache/zookeeper/pull/209

ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections pro…

…perly

The problem was that in branch-3.5+ , because of ZOOKEEPER-1504, we now 
have one acceptor thread and multiple selector threads.  The acceptor thread 
was checking the max connections, but adding the connection to the ipMap (used 
to check maxCnxnCount) was done in the selector threads.  As a result, when 
many connections come in concurrently, the acceptor thread can potentially 
accept many connections before the selector threads have a chance to update the 
ipMap.

This patch updates the ipMap from the acceptor thread immediately.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vincentpoon/zookeeper ZOOKEEPER-2738

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #209


commit c4fdafbf94f8e6296a349eb10ff02f2d77a2ddb8
Author: Vincent 
Date:   2017-03-27T17:19:37Z

ZOOKEEPER-2738 maxClientCnxns not limiting concurrent connections properly




> maxClientCnxns not limiting concurrent connections properly
> ---
>
> Key: ZOOKEEPER-2738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2, 3.6.0
>Reporter: Vincent Poon
> Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number 
> of threads, whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 
> removed some synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-2737.

   Resolution: Fixed
Fix Version/s: 3.5.3
   3.6.0

Issue resolved by pull request 207
[https://github.com/apache/zookeeper/pull/207]

> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
> Fix For: 3.6.0, 3.5.3
>
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943691#comment-15943691
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2737:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/207


> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
> Fix For: 3.5.3, 3.6.0
>
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #207: ZOOKEEPER-2737: close netty connection when exc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZOOKEEPER-2740) Port ZOOKEEPER-2737 to branch-3.4

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2740:
--

 Summary: Port ZOOKEEPER-2737 to branch-3.4
 Key: ZOOKEEPER-2740
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2740
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.9, 3.4.10
Reporter: Michael Han
Priority: Critical
 Fix For: 3.4.11


ZOOKEEPER-2737 fix is pending to branch-3.4 because we are in middle of 
release. This fix should get in after 3.4.10 gets out.

cc [~rakeshr].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #483

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/483/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 19.17 KB...]
warning: Cannot merge binary files: docs/zookeeperOver.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/zookeeperObservers.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/zookeeperJMX.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/zookeeperInternals.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/zookeeperHierarchicalQuorums.pdf (HEAD 
vs. 5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/zookeeperAdmin.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/recipes.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/linkmap.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/javaExample.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)
warning: Cannot merge binary files: docs/index.pdf (HEAD vs. 
5c356f5a47402c000b5e206a536273afc75de883)

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1793)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1766)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1762)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1409)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$3.execute(CliGitAPIImpl.java:588)
at 
org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.merge(AbstractGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.merge(CliGitAPIImpl.java:64)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:894)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:869)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:828)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to H6(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1537)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:822)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:256)
at com.sun.proxy.$Proxy96.merge(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.merge(RemoteGitImpl.java:435)
at 
com.cloudbees.jenkins.plugins.git.vmerge.BuildChooserImpl.getCandidateRevisions(BuildChooserImpl.java:107)
at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:995)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1102)
at hudson.scm.SCM.checkout(SCM.java:495)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1278)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Email was triggered for: Failure - Any
Sending email f

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943701#comment-15943701
 ] 

Michael Han commented on ZOOKEEPER-2737:


Committed.
Master: 
https://github.com/apache/zookeeper/commit/d8adc547f9856747905b7d46450f13fa98df147f
3.5:
https://github.com/apache/zookeeper/commit/5c356f5a47402c000b5e206a536273afc75de883

> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
> Fix For: 3.5.3, 3.6.0
>
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943716#comment-15943716
 ] 

Hadoop QA commented on ZOOKEEPER-2738:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//console

This message is automatically generated.

> maxClientCnxns not limiting concurrent connections properly
> ---
>
> Key: ZOOKEEPER-2738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2, 3.6.0
>Reporter: Vincent Poon
> Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number 
> of threads, whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 
> removed some synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #482

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.17 MB...]
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/482//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] a281b267f686dc04ec823b3f3b89db6ab33c4091 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 13 minutes 52 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2738
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.test.NonRecoverableErrorTest.testZooKeeperServiceAvailableOnLeader

Error Message:
IOException is expected due to error injected to transaction log commit

Stack Trace:
junit.framework.AssertionFailedError: IOException is expected due to error 
injected to transaction log commit
at 
org.apache.zookeeper.test.NonRecoverableErrorTest.testZooKeeperServiceAvailableOnLeader(NonRecoverableErrorTest.java:115)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.lang.Thread.run(Thread.java:745)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108231907
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
--- End diff --

it seems strange to me to have some tests that start their on zookeeper 
server and another which uses the one provided by the @before from the 
superclass. I think we should pick one approach per test class. What do you 
think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108229544
  
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close() {
 + Long.toHexString(sessionId));
 }
 
-synchronized (factory.ipMap) {
-Set s =
-factory.ipMap.get(((InetSocketAddress)channel
-.getRemoteAddress()).getAddress());
-s.remove(this);
+InetAddress address = ((InetSocketAddress) 
channel.getRemoteAddress()).getAddress();
+Set s = factory.ipMap.get(address);
--- End diff --

I agree that that ipMap management would be cleaner if it was handled in 
the factory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108219703
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -51,9 +65,9 @@ public void setUp() throws Exception {
  * 
  * @see https://issues.jboss.org/browse/NETTY-412";>NETTY-412
  */
-@Test(timeout = 4)
+@Test(timeout = 3)
--- End diff --

why was this changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108230180
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

I think it may be cleaner to inline this method instead of casting again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108229036
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

Not sure if this is an issue or not, but if multiple connections (from a 
new address) hit this line before reaching the next one, the maxclientcnxns 
will never be checked as factory.ipMap.get(address) will return null for all of 
the connections?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108220399
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -28,6 +32,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.File;
+import java.net.InetAddress;
+import java.util.Set;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.CountDownLatch;
+
+import static junit.framework.TestCase.assertEquals;
+import static junit.framework.TestCase.assertNotNull;
--- End diff --

i don't believe this import is being used


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108230944
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
+ServerCnxnFactory scf = 
ServerCnxnFactory.createFactory(CLIENT_PORT, maxClientCnxns);
+scf.startup(zks);
+
+try {
+assertTrue("waiting for server being up",
+ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT, 
CONNECTION_TIMEOUT));
+assertTrue("Didn't instantiate ServerCnxnFactory with 
NettyServerCnxnFactory!",
+scf instanceof NettyServerCnxnFactory);
+
+assertEquals(0, scf.getNumAliveConnections());
+
+assertTrue(cnxnsAccepted <= numClients);
+
+final CountDownLatch countDownLatch = new 
CountDownLatch(cnxnsAccepted);
+
+TestableZooKeeper[] clients = new 
TestableZooKeeper[numClients];
+for (int i = 0; i < numClients; i++) {
+clients[i] = new TestableZooKeeper("127.0.0.1:" + 
CLIENT_PORT, 3000, new Watcher() {
+@Override
+public void process(WatchedEvent event)
+{
+if (event.getState() == 
Event.KeeperState.SyncConnected) {
+   countDownLatch.countDown();
+}
+}
+});
+}
+
+countDownLatch.await();
+
+assertEquals(cnxnsAccepted, scf.getNumAliveConnections());
+
+ConcurrentMap> ipMap = 
((NettyServerCnxnFactory) scf).ipMap;
+assertEquals(1, ipMap.size());
+Set set = 
ipMap.get(ipMap.keySet().toArray()[0]);
+assertEquals(cnxnsAccepted, set.size());
+
+int connected = 0;
+for (int i = 0; i < numClients; i++) {
+if (clients[i].getState().isConnected()) connected++;
--- End diff --

nit: I think we prefer multi-line if statements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108225920
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -170,7 +185,6 @@ public void messageReceived(ChannelHandlerContext ctx, 
MessageEvent e)
 throw ex;
 }
 }
-
--- End diff --

unnecessary line removal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943735#comment-15943735
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108220399
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -28,6 +32,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.io.File;
+import java.net.InetAddress;
+import java.util.Set;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.CountDownLatch;
+
+import static junit.framework.TestCase.assertEquals;
+import static junit.framework.TestCase.assertNotNull;
--- End diff --

i don't believe this import is being used


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943731#comment-15943731
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108229036
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

Not sure if this is an issue or not, but if multiple connections (from a 
new address) hit this line before reaching the next one, the maxclientcnxns 
will never be checked as factory.ipMap.get(address) will return null for all of 
the connections?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943729#comment-15943729
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108225920
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -170,7 +185,6 @@ public void messageReceived(ChannelHandlerContext ctx, 
MessageEvent e)
 throw ex;
 }
 }
-
--- End diff --

unnecessary line removal


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943736#comment-15943736
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108231907
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
--- End diff --

it seems strange to me to have some tests that start their on zookeeper 
server and another which uses the one provided by the @before from the 
superclass. I think we should pick one approach per test class. What do you 
think?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943730#comment-15943730
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108219703
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -51,9 +65,9 @@ public void setUp() throws Exception {
  * 
  * @see https://issues.jboss.org/browse/NETTY-412";>NETTY-412
  */
-@Test(timeout = 4)
+@Test(timeout = 3)
--- End diff --

why was this changed?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943733#comment-15943733
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108230944
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
+ServerCnxnFactory scf = 
ServerCnxnFactory.createFactory(CLIENT_PORT, maxClientCnxns);
+scf.startup(zks);
+
+try {
+assertTrue("waiting for server being up",
+ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT, 
CONNECTION_TIMEOUT));
+assertTrue("Didn't instantiate ServerCnxnFactory with 
NettyServerCnxnFactory!",
+scf instanceof NettyServerCnxnFactory);
+
+assertEquals(0, scf.getNumAliveConnections());
+
+assertTrue(cnxnsAccepted <= numClients);
+
+final CountDownLatch countDownLatch = new 
CountDownLatch(cnxnsAccepted);
+
+TestableZooKeeper[] clients = new 
TestableZooKeeper[numClients];
+for (int i = 0; i < numClients; i++) {
+clients[i] = new TestableZooKeeper("127.0.0.1:" + 
CLIENT_PORT, 3000, new Watcher() {
+@Override
+public void process(WatchedEvent event)
+{
+if (event.getState() == 
Event.KeeperState.SyncConnected) {
+   countDownLatch.countDown();
+}
+}
+});
+}
+
+countDownLatch.await();
+
+assertEquals(cnxnsAccepted, scf.getNumAliveConnections());
+
+ConcurrentMap> ipMap = 
((NettyServerCnxnFactory) scf).ipMap;
+assertEquals(1, ipMap.size());
+Set set = 
ipMap.get(ipMap.keySet().toArray()[0]);
+assertEquals(cnxnsAccepted, set.size());
+
+int connected = 0;
+for (int i = 0; i < numClients; i++) {
+if (clients[i].getState().isConnected()) connected++;
--- End diff --

nit: I think we prefer multi-line if statements.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943734#comment-15943734
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108229544
  
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close() {
 + Long.toHexString(sessionId));
 }
 
-synchronized (factory.ipMap) {
-Set s =
-factory.ipMap.get(((InetSocketAddress)channel
-.getRemoteAddress()).getAddress());
-s.remove(this);
+InetAddress address = ((InetSocketAddress) 
channel.getRemoteAddress()).getAddress();
+Set s = factory.ipMap.get(address);
--- End diff --

I agree that that ipMap management would be cleaner if it was handled in 
the factory.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943732#comment-15943732
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108230180
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

I think it may be cleaner to inline this method instead of casting again.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108239884
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -51,9 +65,9 @@ public void setUp() throws Exception {
  * 
  * @see https://issues.jboss.org/browse/NETTY-412";>NETTY-412
  */
-@Test(timeout = 4)
+@Test(timeout = 3)
--- End diff --

Due to @fpj previous review on previous incarnation this patch: 
https://github.com/apache/zookeeper/pull/77/files#r80003749 (sorry, should have 
put the original link).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108240078
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -170,7 +185,6 @@ public void messageReceived(ChannelHandlerContext ctx, 
MessageEvent e)
 throw ex;
 }
 }
-
--- End diff --

Ops, again Flavio's previous review comment: 
https://github.com/apache/zookeeper/pull/77/files#r80004333 (should have put 
referenced this here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943756#comment-15943756
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108239884
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -51,9 +65,9 @@ public void setUp() throws Exception {
  * 
  * @see https://issues.jboss.org/browse/NETTY-412";>NETTY-412
  */
-@Test(timeout = 4)
+@Test(timeout = 3)
--- End diff --

Due to @fpj previous review on previous incarnation this patch: 
https://github.com/apache/zookeeper/pull/77/files#r80003749 (sorry, should have 
put the original link).


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943757#comment-15943757
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108240078
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -170,7 +185,6 @@ public void messageReceived(ChannelHandlerContext ctx, 
MessageEvent e)
 throw ex;
 }
 }
-
--- End diff --

Ops, again Flavio's previous review comment: 
https://github.com/apache/zookeeper/pull/77/files#r80004333 (should have put 
referenced this here).


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242052
  
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close() {
 + Long.toHexString(sessionId));
 }
 
-synchronized (factory.ipMap) {
-Set s =
-factory.ipMap.get(((InetSocketAddress)channel
-.getRemoteAddress()).getAddress());
-s.remove(this);
+InetAddress address = ((InetSocketAddress) 
channel.getRemoteAddress()).getAddress();
+Set s = factory.ipMap.get(address);
+if (s != null) {
+synchronized (s) {
--- End diff --

Yeah... in the context of this call I think it is not necessary to 
synchronize here if -- as you said -- we use a synchronized set (**currently 
it's not**). I would also change `ipMap` to be a `ConcurrentMap` but unsure if 
it's worth the effort, tbh. :thinking: thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943769#comment-15943769
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242052
  
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close() {
 + Long.toHexString(sessionId));
 }
 
-synchronized (factory.ipMap) {
-Set s =
-factory.ipMap.get(((InetSocketAddress)channel
-.getRemoteAddress()).getAddress());
-s.remove(this);
+InetAddress address = ((InetSocketAddress) 
channel.getRemoteAddress()).getAddress();
+Set s = factory.ipMap.get(address);
+if (s != null) {
+synchronized (s) {
--- End diff --

Yeah... in the context of this call I think it is not necessary to 
synchronize here if -- as you said -- we use a synchronized set (**currently 
it's not**). I would also change `ipMap` to be a `ConcurrentMap` but unsure if 
it's worth the effort, tbh. :thinking: thoughts?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242277
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
+if (s != null) {
+synchronized (s) {
--- End diff --

If we change `s` to be a synchronized set I think we can get rid of this 
synchronized block. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943770#comment-15943770
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242277
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
+if (s != null) {
+synchronized (s) {
--- End diff --

If we change `s` to be a synchronized set I think we can get rid of this 
synchronized block. 


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242887
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
--- End diff --

+1. :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242965
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
+ServerCnxnFactory scf = 
ServerCnxnFactory.createFactory(CLIENT_PORT, maxClientCnxns);
+scf.startup(zks);
+
+try {
+assertTrue("waiting for server being up",
+ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT, 
CONNECTION_TIMEOUT));
+assertTrue("Didn't instantiate ServerCnxnFactory with 
NettyServerCnxnFactory!",
+scf instanceof NettyServerCnxnFactory);
+
+assertEquals(0, scf.getNumAliveConnections());
+
+assertTrue(cnxnsAccepted <= numClients);
+
+final CountDownLatch countDownLatch = new 
CountDownLatch(cnxnsAccepted);
+
+TestableZooKeeper[] clients = new 
TestableZooKeeper[numClients];
+for (int i = 0; i < numClients; i++) {
+clients[i] = new TestableZooKeeper("127.0.0.1:" + 
CLIENT_PORT, 3000, new Watcher() {
+@Override
+public void process(WatchedEvent event)
+{
+if (event.getState() == 
Event.KeeperState.SyncConnected) {
+   countDownLatch.countDown();
+}
+}
+});
+}
+
+countDownLatch.await();
+
+assertEquals(cnxnsAccepted, scf.getNumAliveConnections());
+
+ConcurrentMap> ipMap = 
((NettyServerCnxnFactory) scf).ipMap;
+assertEquals(1, ipMap.size());
+Set set = 
ipMap.get(ipMap.keySet().toArray()[0]);
+assertEquals(cnxnsAccepted, set.size());
+
+int connected = 0;
+for (int i = 0; i < numClients; i++) {
+if (clients[i].getState().isConnected()) connected++;
--- End diff --

Oops, indeed! +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943776#comment-15943776
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242965
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
+ServerCnxnFactory scf = 
ServerCnxnFactory.createFactory(CLIENT_PORT, maxClientCnxns);
+scf.startup(zks);
+
+try {
+assertTrue("waiting for server being up",
+ClientBase.waitForServerUp("127.0.0.1:" + CLIENT_PORT, 
CONNECTION_TIMEOUT));
+assertTrue("Didn't instantiate ServerCnxnFactory with 
NettyServerCnxnFactory!",
+scf instanceof NettyServerCnxnFactory);
+
+assertEquals(0, scf.getNumAliveConnections());
+
+assertTrue(cnxnsAccepted <= numClients);
+
+final CountDownLatch countDownLatch = new 
CountDownLatch(cnxnsAccepted);
+
+TestableZooKeeper[] clients = new 
TestableZooKeeper[numClients];
+for (int i = 0; i < numClients; i++) {
+clients[i] = new TestableZooKeeper("127.0.0.1:" + 
CLIENT_PORT, 3000, new Watcher() {
+@Override
+public void process(WatchedEvent event)
+{
+if (event.getState() == 
Event.KeeperState.SyncConnected) {
+   countDownLatch.countDown();
+}
+}
+});
+}
+
+countDownLatch.await();
+
+assertEquals(cnxnsAccepted, scf.getNumAliveConnections());
+
+ConcurrentMap> ipMap = 
((NettyServerCnxnFactory) scf).ipMap;
+assertEquals(1, ipMap.size());
+Set set = 
ipMap.get(ipMap.keySet().toArray()[0]);
+assertEquals(cnxnsAccepted, set.size());
+
+int connected = 0;
+for (int i = 0; i < numClients; i++) {
+if (clients[i].getState().isConnected()) connected++;
--- End diff --

Oops, indeed! +1.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943775#comment-15943775
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108242887
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception {
 zk.close();
 }
 }
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsReached() throws Exception {
+final int maxClientCnxns = 4;
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, 
maxClientCnxns);
+}
+
+@Test(timeout = 3)
+public void testMaxClientConnectionsDisabled() throws Exception {
+final int maxClientCnxns = 0; // disabled cnxns limit
+final int numClients = 10;
+createAndTestConnections(numClients, maxClientCnxns, numClients);
+}
+
+private void createAndTestConnections(int numClients, int 
maxClientCnxns, int cnxnsAccepted) throws Exception {
+
+File tmpDir = ClientBase.createTmpDir();
+final int CLIENT_PORT = PortAssignment.unique();
+
+ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
--- End diff --

+1. :+1: 


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

ZooKeeper-trunk - Build # 3334 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3334/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 62.20 MB...]
[junit] 2017-03-27 18:46:44,176 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2017-03-27 18:46:44,176 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-03-27 18:46:44,177 [myid:] - INFO  [ProcessThread(sid:0 
cport:16611)::PrepRequestProcessor@617] - Processed session termination for 
sessionid: 0x104a48b01c3
[junit] 2017-03-27 18:46:44,218 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x104a48b01c3 closed
[junit] 2017-03-27 18:46:44,218 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x104a48b01c3
[junit] 2017-03-27 18:46:44,218 [myid:] - INFO  
[NIOWorkerThread-25:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x104a48b01c3]
[junit] 2017-03-27 18:46:44,219 [myid:] - INFO  [ProcessThread(sid:0 
cport:16611)::PrepRequestProcessor@617] - Processed session termination for 
sessionid: 0x104a48b01c30001
[junit] 2017-03-27 18:46:44,219 [myid:] - INFO  
[NIOWorkerThread-25:NIOServerCnxn@627] - Closed socket connection for client 
/127.0.0.1:51863 which had sessionid 0x104a48b01c3
[junit] 2017-03-27 18:46:44,260 [myid:] - INFO  
[NIOWorkerThread-19:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x104a48b01c30001]
[junit] 2017-03-27 18:46:44,261 [myid:] - INFO  
[NIOWorkerThread-19:NIOServerCnxn@627] - Closed socket connection for client 
/127.0.0.1:51884 which had sessionid 0x104a48b01c30001
[junit] 2017-03-27 18:46:44,261 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x104a48b01c30001 closed
[junit] 2017-03-27 18:46:44,261 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-03-27 18:46:44,261 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x104a48b01c30001
[junit] 2017-03-27 18:46:44,262 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:16611:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2017-03-27 18:46:44,263 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2017-03-27 18:46:44,269 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  [main:ZooKeeperServer@542] 
- shutting down
[junit] 2017-03-27 18:46:44,270 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  [ProcessThread(sid:0 
cport:16611)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 18:46:44,270 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 18:46:44,271 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 18:46:44,271 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=InMemoryDataTree]
[junit] 2017-03-27 18:46:44,271 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16611]
[junit] 2017-03-27 18:46:44,272 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16611
[junit] 2017-03-27 18:46:44,272 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 18:46:44,295 [myid:] - INFO  [main:ClientBase@583] - 
fdcount after test is: 53 at start it was 53
[junit] 2017-03-27 18:46:44,295 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testManyChildWatchersAutoReset
[junit] 2017-03-27 18:46:44,295 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testManyChildWatchersAutoReset
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 

[jira] [Commented] (ZOOKEEPER-2737) NettyServerCnxFactory leaks connection if exception happens while writing to a channel.

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943825#comment-15943825
 ] 

Hudson commented on ZOOKEEPER-2737:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3334 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3334/])
ZOOKEEPER-2737: close netty connection when exceptions occur during w… (hanm: 
rev d8adc547f9856747905b7d46450f13fa98df147f)
* (edit) src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java


> NettyServerCnxFactory leaks connection if exception happens while writing to 
> a channel.
> ---
>
> Key: ZOOKEEPER-2737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2737
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Critical
>  Labels: connection, netty, server
> Fix For: 3.5.3, 3.6.0
>
>
> Found this while debugging occasionally failed unit tests. Currently we do 
> this if exception occurs during writing to a channel with Netty:
> {code}
> @Override
> public void exceptionCaught(ChannelHandlerContext ctx, ExceptionEvent 
> e)
> throws Exception
> {
> LOG.warn("Exception caught " + e, e.getCause());
> NettyServerCnxn cnxn = (NettyServerCnxn) ctx.getAttachment();
> if (cnxn != null) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("Closing " + cnxn);
> cnxn.close();
> }
> }
> }
> {code}
> So the connection is only closed when debug mode is enabled. This is 
> problematic as lots of clean up code is abstracted inside the close and 
> without proper close the connection we are leaking resources.
> [Commit 
> log|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java#L147]
>  indicates the issue exists since day 1 with ZOOKEEPER-733. Note the original 
> patch uploaded to ZOOKEEPER-733 has this close call in right place, and the 
> call gets moved around during iteration of the patches w/o gets noticed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108255892
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

Good catch! Congrats! :smiley:

Now, I am a bit unsure if this:

* this is a real issue and/or worth fixing;
* how to achieve a good compromise without entangling the logic too much.

Wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943877#comment-15943877
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108255892
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

Good catch! Congrats! :smiley:

Now, I am a bit unsure if this:

* this is a real issue and/or worth fixing;
* how to achieve a good compromise without entangling the logic too much.

Wdyt?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[eribeiro]

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108256234
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

Indeed, there's too much call for casting in this class already. Are you 
suggesting to extract this line into a method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943884#comment-15943884
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108256234
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

Indeed, there's too much call for casting in this class already. Are you 
suggesting to extract this line into a method?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108256938
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

we can pass the InetAddress as a param?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943892#comment-15943892
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108256938
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress() {
 
 private void addCnxn(NettyServerCnxn cnxn) {
 cnxns.add(cnxn);
-synchronized (ipMap){
-InetAddress addr =
-((InetSocketAddress)cnxn.channel.getRemoteAddress())
-.getAddress();
-Set s = ipMap.get(addr);
-if (s == null) {
-s = new HashSet();
-}
-s.add(cnxn);
-ipMap.put(addr,s);
+
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
--- End diff --

we can pass the InetAddress as a param?


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zookeeper pull request #208: ZOOKEEPER-2280: NettyServerCnxnFactory doesn't ...

[afine]

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108258656
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

So I can't imagine this causing much more than the occasional extra single 
connection, but I do think it is worth fixing.

My feeling here is that if we move the ipMap logic to the factory this 
should be easier to fix as synchronization in a singleton is much simpler than 
trying to figure out what Netty does with these CnxnChannelHandler objects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2280) NettyServerCnxnFactory doesn't honor maxClientCnxns param

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943908#comment-15943908
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2280:
---

Github user afine commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/208#discussion_r108258656
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected(ChannelHandlerContext ctx,
 zkServer, NettyServerCnxnFactory.this);
 ctx.setAttachment(cnxn);
 
+InetAddress addr = 
((InetSocketAddress)cnxn.channel.getRemoteAddress()).getAddress();
+Set s = ipMap.get(addr);
--- End diff --

So I can't imagine this causing much more than the occasional extra single 
connection, but I do think it is worth fixing.

My feeling here is that if we move the ipMap logic to the factory this 
should be easier to fix as synchronization in a singleton is much simpler than 
trying to figure out what Netty does with these CnxnChannelHandler objects.


> NettyServerCnxnFactory doesn't honor maxClientCnxns param
> -
>
> Key: ZOOKEEPER-2280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2280
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2280.2.patch, ZOOKEEPER-2280.patch
>
>
> Even though NettyServerCnxnFactory has maxClientCnxns (default to 60) it 
> doesn't enforce this limit in the code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

ZooKeeper_branch35_jdk7 - Build # 904 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/904/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 57.60 MB...]
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 1, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 18:42:55,385 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x (n.round), 
FOLLOWING (n.state), 4 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 
(n.config version)
[junit] 2017-03-27 18:42:55,386 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 6 (n.leader), 0x0 (n.zxid), 0x3 (n.round), LOOKING (n.state), 
6 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,386 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x (n.round), 
FOLLOWING (n.state), 4 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 
(n.config version)
[junit] 2017-03-27 18:42:55,386 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x1 (n.round), LOOKING (n.state), 
7 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x1 (n.round), LOOKING (n.state), 
7 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x1 (n.round), LOOKING (n.state), 
7 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 7 (n.leader), 0x0 (n.zxid), 0x2 (n.round), LOOKING (n.state), 
7 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerReceiver[myid=6]:FastLeaderElection@688] - Notification: 2 (message 
format version), 6 (n.leader), 0x0 (n.zxid), 0x3 (n.round), LOOKING (n.state), 
6 (n.sid), 0x0 (n.peerEPoch), LOOKING (my state)0 (n.config version)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerSender[myid=6]:QuorumCnxManager@278] - Have smaller server identifier, 
so dropping the connection: (7, 6)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerSender[myid=6]:QuorumCnxManager@278] - Have smaller server identifier, 
so dropping the connection: (7, 6)
[junit] 2017-03-27 18:42:55,387 [myid:] - INFO  
[WorkerSender[myid=6]:QuorumCnxManager@278] - Have smaller server identifier, 
so dropping the connection: (7, 6)[junit] Test 
org.apache.zookeeper.test.NettyNettySuiteTest FAILED (timeout)

[junit] 2017-03-27 18:42:55,388 [myid:] - INFO  
[WorkerSender[myid=6]:QuorumCnxManager@278] - Have smaller server identifier, 
so dropping the connection: (7, 6)
[junit] 2017-03-27 18:42:55,383 [myid:] - INFO  
[/127.0.0.1:14041:QuorumCnxManager$Listener@642] - Received connection request 
/127.0.0.1:36070
[junit] 2017-03-27 18:42:55,389 [myid:] - WARN  
[RecvWorker:6:QuorumCnxManager$RecvWorker@919] - Connection broken for id 6, my 
id = 7, error = 
[junit] java.net.SocketException: Socket closed
[junit] at java.net.SocketInputStream.socketRead0(Native Method)
[junit] at java.net.SocketInputStream.read(SocketInputStream.java:152)
[junit] at java.net.SocketInputStream.read(SocketInputStream.java:122)
[junit] at java.net.SocketInputStream.read(SocketInputStream.java:210)
[junit] at java.io.DataInputStream.readInt(DataInputStream.java:387)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumCnxManager$RecvWorker.run(QuorumCnxManager.java:904)
[junit] 2017-03-27 18:42:55,389 [myid:] - WARN  
[RecvWorker:6:QuorumCnxManager$RecvWorker@922] - Interrupting SendWorker
[junit] 2017-03-27 18:42:55,389 [myid:] - WARN  
[SendWorker:6:QuorumCnxManager$SendWorker@836] - Interrupted while waiting for 
message on queue
[junit] java.lang.InterruptedException
[junit] at 
java.util.concurrent.locks.Abs

Success: ZOOKEEPER- PreCommit Build #484

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.10 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ed06bffccfaf02ed98d87434b7bf1ae1d7c2d842 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 19 minutes 21 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2738
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944014#comment-15944014
 ] 

Hadoop QA commented on ZOOKEEPER-2738:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/484//console

This message is automatically generated.

> maxClientCnxns not limiting concurrent connections properly
> ---
>
> Key: ZOOKEEPER-2738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2, 3.6.0
>Reporter: Vincent Poon
> Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number 
> of threads, whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 
> removed some synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

ZooKeeper-trunk-jdk8 - Build # 995 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/995/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 62.32 MB...]
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 20:51:43,928 [myid:127.0.0.1:16734] - INFO  
[main-SendThread(127.0.0.1:16734):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16734. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 20:51:43,928 [myid:127.0.0.1:16734] - WARN  
[main-SendThread(127.0.0.1:16734):ClientCnxn$SendThread@1235] - Session 
0x2033c7a2866 for server 127.0.0.1/127.0.0.1:16734, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 20:51:43,990 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@617] - Processed session termination for 
sessionid: 0x1033c7d90a7
[junit] 2017-03-27 20:51:43,991 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x1033c7d90a7]
[junit] 2017-03-27 20:51:43,991 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x1033c7d90a7 closed
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 227311
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2428
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-03-27 20:51:43,992 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-03-27 20:51:43,991 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1033c7d90a7
[junit] 2017-03-27 20:51:44,000 [myid:] - INFO  [main:ZooKeeperServer@542] 
- shutting down
[junit] 2017-03-27 20:51:44,000 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 20:51:44,000 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 20:51:44,001 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-03-27 20:51:44,001 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 20:51:44,001 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 20:51:44,001 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 20:51:44,010 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 20:51:44,010 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-03-27 20:51:44,011 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-03-27 20:51:44,067 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854
[junit] 2017-03-27 20:51:44,068 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 20:51:44,084 [myid:] - INFO  [main:ClientBase@583] - 
fdcount after test is: 7145 at start it was 7141
[junit] 2017-03-27 20:51:44,084 [myid:] - INFO  [main:ClientBase@585] - 
sleeping for 20 secs
[junit] 2017-03-27 20:51:44,084 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-27 20:51:44,084 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAuto

ZooKeeper_branch35_openjdk7 - Build # 471 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/471/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 64.01 MB...]
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 22:26:40,624 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1dd29a1 closed
[junit] 2017-03-27 22:26:40,624 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1dd29a1
[junit] 2017-03-27 22:26:40,624 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 80461
[junit] 2017-03-27 22:26:40,625 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 466
[junit] 2017-03-27 22:26:40,625 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-27 22:26:40,625 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-03-27 22:26:40,625 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-03-27 22:26:40,626 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22240
[junit] 2017-03-27 22:26:40,628 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-03-27 22:26:40,628 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 22:26:40,628 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 22:26:40,629 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-03-27 22:26:40,629 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 22:26:40,629 [myid:] - INFO  [ProcessThread(sid:0 
cport:22240)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 22:26:40,629 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 22:26:40,630 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 22:26:40,631 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=InMemoryDataTree]
[junit] 2017-03-27 22:26:40,631 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240]
[junit] 2017-03-27 22:26:40,632 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22240
[junit] 2017-03-27 22:26:40,632 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 22:26:40,637 [myid:127.0.0.1:22120] - INFO  
[main-SendThread(127.0.0.1:22120):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22120. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 22:26:40,637 [myid:127.0.0.1:22120] - WARN  
[main-SendThread(127.0.0.1:22120):ClientCnxn$SendThread@1235] - Session 
0x2d9abc3 for server 127.0.0.1/127.0.0.1:22120, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-27 22:26:40,640 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1376 at start it was 1376
[junit] 2017-03-27 22:26:40,640 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-27 22:26:40,640 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
487.067 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-27 22:26:41,208 [myid:127.0.0.1:22117] - INFO  
[main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22117. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 22:26:41,209 [myid:127.0.0.1:22117] - WARN  
[main-SendThread(127.0.0.1:22117):ClientCnxn$SendThread@1235] - Session 
0x1d9abc4 for server 127.0.0.1/127.0.0.1:22117, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectExce

Re: [VOTE] Make 3.5.3 the first beta release.

[Patrick Hunt]

+1.

Patrick

On Thu, Mar 23, 2017 at 8:54 PM, Abraham Fine  wrote:

> +1 non binding
>
> On Thu, Mar 23, 2017, at 13:00, Edward Ribeiro wrote:
> > +1 non binding
> >
> > On Thu, Mar 23, 2017 at 2:17 PM, Rakesh Radhakrishnan
> > 
> > wrote:
> >
> > > +1
> > >
> > >
> > > Rakesh
> > >
> > > On Thu, Mar 23, 2017 at 10:41 PM, Jordan Zimmerman <
> > > jor...@jordanzimmerman.com> wrote:
> > >
> > > > +1 non binding
> > > >
> > > > 
> > > > Jordan Zimmerman
> > > >
> > > > > On Mar 23, 2017, at 11:50 AM, Michael Han 
> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > As previously discussed on dev list [1] and JIRA [2], I propose we
> make
> > > > the
> > > > > upcoming 3.5.3 release the first beta release and drops the alpha
> tag.
> > > > >
> > > > > Please vote by *March 27th 2017, 23:59 UTC+0*. If no objections,
> I'll
> > > > > commit the patch for [2] and proceed with release process next week
> > > after
> > > > > the vote cycle ends.
> > > > >
> > > > > [1] 3.5.3: alpha or beta?
> > > > >  > > > 201703.mbox/%3CCA%2Bi0x1JZacVMQGd_Jb34jSaw7p_
> nhWpcx9uzHwCwPPF%2BPPrf3g%
> > > > 40mail.gmail.com%3E>
> > > > > [2] ZOOKEEPER-2734  > > jira/browse/ZOOKEEPER-2734
> > > > >
> > > > >
> > > > > --
> > > > > Cheers
> > > > > Michael.
> > > >
> > >
>

Re: ZOOKEEPER-900

[Patrick Hunt]

Hi Atri. Which do you intend to work on? 900, 901, or both? Typically if
someone is intending to work on something they will be listed as the
"assigned" in JIRA. They would be the first person to check in with. If
they no longer intend to work on something it's easy enough to reassign.

Regards,

Patrick

On Sat, Mar 25, 2017 at 7:36 AM, Atri Sharma  wrote:

> Hi folks,
>
> I was looking to work on ZOOKEEPER-901. Could anybody please let me
> know if they are working on it?
>
> --
> Regards,
>
> Atri
> l'apprenant
>

ZooKeeper-trunk - Build # 3335 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3335/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 63.57 MB...]
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-03-27 23:30:09,918 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=Connections,name2=127.0.0.1,name3=0x100dece4e76]
[junit] 2017-03-27 23:30:10,018 [myid:] - INFO  [main:ZooKeeper@1324] - 
Session: 0x100dece4e76 closed
[junit] 2017-03-27 23:30:10,018 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x100dece4e76
[junit] 2017-03-27 23:30:10,018 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 175637
[junit] 2017-03-27 23:30:10,018 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2017-03-27 23:30:10,018 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-27 23:30:10,019 [myid:] - INFO  [main:ClientBase@558] - 
tearDown starting
[junit] 2017-03-27 23:30:10,019 [myid:] - INFO  [main:ClientBase@528] - 
STOPPING server
[junit] 2017-03-27 23:30:10,019 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:11468
[junit] 2017-03-27 23:30:10,024 [myid:] - INFO  [main:ZooKeeperServer@542] 
- shutting down
[junit] 2017-03-27 23:30:10,025 [myid:] - ERROR [main:ZooKeeperServer@506] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  [ProcessThread(sid:0 
cport:11468)::PrepRequestProcessor@157] - PrepRequestProcessor exited loop!
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-27 23:30:10,025 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-27 23:30:10,026 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=InMemoryDataTree]
[junit] 2017-03-27 23:30:10,026 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11468]
[junit] 2017-03-27 23:30:10,026 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11468
[junit] 2017-03-27 23:30:10,027 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-27 23:30:10,032 [myid:] - INFO  [main:ClientBase@583] - 
fdcount after test is: 4836 at start it was 4836
[junit] 2017-03-27 23:30:10,033 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-27 23:30:10,033 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
554.501 sec, Thread: 1, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-27 23:30:10,148 [myid:127.0.0.1:11345] - INFO  
[main-SendThread(127.0.0.1:11345):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11345. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-27 23:30:10,148 [myid:127.0.0.1:11345] - WARN  
[main-SendThread(127.0.0.1:11345):ClientCnxn$SendThread@1235] - Session 
0x100decad891 for server 127.0.0.1/127.0.0.1:11345, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1338: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1219: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1223: Tests 

Re: [VOTE] Apache ZooKeeper release 3.4.10 candidate 1

[Patrick Hunt]

+1 - xsum/sig verified, RAT ran clean, was able to build and run the tests
successfully (mac).

Patrick

On Thu, Mar 23, 2017 at 5:40 AM, Rakesh Radhakrishnan 
wrote:

> This is the second release candidate for 3.4.10. This candidate fixed the
> MiniKDC authentication test case failures reported in the previous
> candidate.
>
> This is a bug fix release candidate for 3.4.10. It fixes 43 issues,
> including
> security feature QuorumPeer mutual authentication via SASL and other
> potential bugs.
>
> The full release notes are available at:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12310801&version=12338036
>
> *** Please download, test and vote by March 29th 2017, 23:59 UTC+0. ***
>
> Source files:
> http://people.apache.org/~rakeshr/zookeeper-3.4.10-candidate-1/
>
> Maven staging repo:
> https://repository.apache.org/content/groups/staging/org/
> apache/zookeeper/zookeeper/3.4.10/
>
> The release candidate tag in git to be voted upon: release-3.4.10-rc1
> https://github.com/apache/zookeeper/tree/release-3.4.10-rc1
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> http://www.apache.org/dist/zookeeper/KEYS
>
> Should we release this candidate?
>
>
> Rakesh
>

Failed: ZOOKEEPER- PreCommit Build #485

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/485/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.12 KB...]
 [exec] Pull request id: 209
 [exec] Pull request title: ZOOKEEPER-2738 maxClientCnxns not limiting 
concurrent connections pro?
 [exec] Defect number: ZOOKEEPER-2738
 [exec] - Parsed args, going to checkout -
 [exec] 
 [exec] 
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec]  Dload  Upload   Total   Spent
Left  Speed
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 209.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0857  0 --:--:-- --:--:-- 
--:--:--   859
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest 
-Dforrest.home=/home/jenkins/tools/forrest/latest -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 413320 0  72214  0 --:--:-- --:--:-- 
--:--:--  276kmv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 11 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2738
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #487

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/487/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 3.09 KB...]
 [exec] Pull request id: 205
 [exec] Pull request title: ZOOKEEPER-2736 Add a connection rate limiter
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec] Defect number: ZOOKEEPER-2736
 [exec] - Parsed args, going to checkout -  
   Dload  Upload   Total   SpentLeft  Speed
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for pull request 205.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0100   1410   1410 0954  0 --:--:-- --:--:-- 
--:--:--   959
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant  
-Djavac.args=-Xlint -Xmaxwarns 1000 
-Djava5.home=/home/jenkins/tools/java5/latest 
-Dforrest.home=/home/jenkins/tools/forrest/latest -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 413320 0  75545  0 --:--:-- --:--:-- 
--:--:-- 75545mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 13 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2736
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

Success: ZOOKEEPER- PreCommit Build #486

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 65.60 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 4d575ebf707632a2ab68932e9ffe74805d7921b2 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 51 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2738
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2738) maxClientCnxns not limiting concurrent connections properly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944383#comment-15944383
 ] 

Hadoop QA commented on ZOOKEEPER-2738:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/486//console

This message is automatically generated.

> maxClientCnxns not limiting concurrent connections properly
> ---
>
> Key: ZOOKEEPER-2738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2738
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2, 3.6.0
>Reporter: Vincent Poon
> Attachments: MaxCnxnsTest.patch
>
>
> The test MaxCnxnsTest is incorrect as it only creates up the maxCnxns number 
> of threads, whereas it should create more.  See attached patch
> When the test is fixed, it fails on master and 3.5, where ZOOKEEPER-1504 
> removed some synchronization.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Failed: ZOOKEEPER- PreCommit Build #488

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/488/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 19.17 KB...]
warning: Cannot merge binary files: docs/zookeeperOver.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/zookeeperObservers.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/zookeeperJMX.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/zookeeperInternals.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/zookeeperHierarchicalQuorums.pdf (HEAD 
vs. c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/zookeeperAdmin.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/recipes.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/linkmap.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/javaExample.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)
warning: Cannot merge binary files: docs/index.pdf (HEAD vs. 
c1c13db19829943b8ae955372dab1e254b9aae52)

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1793)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1766)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1762)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1409)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$3.execute(CliGitAPIImpl.java:588)
at 
org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.merge(AbstractGitAPIImpl.java:86)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.merge(CliGitAPIImpl.java:64)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:894)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:869)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:828)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to H6(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1537)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:822)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:256)
at com.sun.proxy.$Proxy96.merge(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.merge(RemoteGitImpl.java:435)
at 
com.cloudbees.jenkins.plugins.git.vmerge.BuildChooserImpl.getCandidateRevisions(BuildChooserImpl.java:107)
at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:995)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1102)
at hudson.scm.SCM.checkout(SCM.java:495)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1278)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Archiving artifacts
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Email was triggered for: Failure - Any
Sending email f

[GitHub] zookeeper pull request #201: ZOOKEEPER-2734: 3.5.3 should be a beta release ...

[hanm]

Github user hanm closed the pull request at:

https://github.com/apache/zookeeper/pull/201


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (ZOOKEEPER-2734) 3.5.3 should be a beta release instead of alpha release.

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han resolved ZOOKEEPER-2734.

Resolution: Fixed

Issue resolved by pull request 201
[https://github.com/apache/zookeeper/pull/201]

> 3.5.3 should be a beta release instead of alpha release.
> 
>
> Key: ZOOKEEPER-2734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2734
> Project: ZooKeeper
>  Issue Type: Task
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build, release
> Fix For: 3.5.3
>
>
> Currently 3.5.3 is tagged as alpha both in build and JIRA. We should reach a 
> consensus on the tag before release. See the email thread on dev list for 
> more details.
> Deliverable:
> * A consensus on using beta as the version for 3.5.3 release.
> * Update build.xml.
> * Update JIRA (3.5.3-alpha -> 3.5.3-beta).
> Thread on dev list:
> http://mail-archives.apache.org/mod_mbox/zookeeper-dev/201703.mbox/%3CCA%2Bi0x1JZacVMQGd_Jb34jSaw7p_nhWpcx9uzHwCwPPF%2BPPrf3g%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2734) 3.5.3 should be a beta release instead of alpha release.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944479#comment-15944479
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2734:
---

Github user hanm closed the pull request at:

https://github.com/apache/zookeeper/pull/201


> 3.5.3 should be a beta release instead of alpha release.
> 
>
> Key: ZOOKEEPER-2734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2734
> Project: ZooKeeper
>  Issue Type: Task
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build, release
> Fix For: 3.5.3
>
>
> Currently 3.5.3 is tagged as alpha both in build and JIRA. We should reach a 
> consensus on the tag before release. See the email thread on dev list for 
> more details.
> Deliverable:
> * A consensus on using beta as the version for 3.5.3 release.
> * Update build.xml.
> * Update JIRA (3.5.3-alpha -> 3.5.3-beta).
> Thread on dev list:
> http://mail-archives.apache.org/mod_mbox/zookeeper-dev/201703.mbox/%3CCA%2Bi0x1JZacVMQGd_Jb34jSaw7p_nhWpcx9uzHwCwPPF%2BPPrf3g%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2734) 3.5.3 should be a beta release instead of alpha release.

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944482#comment-15944482
 ] 

Michael Han commented on ZOOKEEPER-2734:


Community has voted 3.5.3 as the first beta release. Vote thread: 
https://goo.gl/pxkYdn
Merged to 3.5 as 
https://github.com/apache/zookeeper/commit/c1c13db19829943b8ae955372dab1e254b9aae52

> 3.5.3 should be a beta release instead of alpha release.
> 
>
> Key: ZOOKEEPER-2734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2734
> Project: ZooKeeper
>  Issue Type: Task
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build, release
> Fix For: 3.5.3
>
>
> Currently 3.5.3 is tagged as alpha both in build and JIRA. We should reach a 
> consensus on the tag before release. See the email thread on dev list for 
> more details.
> Deliverable:
> * A consensus on using beta as the version for 3.5.3 release.
> * Update build.xml.
> * Update JIRA (3.5.3-alpha -> 3.5.3-beta).
> Thread on dev list:
> http://mail-archives.apache.org/mod_mbox/zookeeper-dev/201703.mbox/%3CCA%2Bi0x1JZacVMQGd_Jb34jSaw7p_nhWpcx9uzHwCwPPF%2BPPrf3g%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [VOTE] Make 3.5.3 the first beta release.

[Michael Han]

Thanks all that participated voting.

As no objection being presented, 3.5.3 will be first 3.5 beta release.
Patch of ZOOKEEPER-2734
 is now committed.

On Mon, Mar 27, 2017 at 4:14 PM, Patrick Hunt  wrote:

> +1.
>
> Patrick
>
> On Thu, Mar 23, 2017 at 8:54 PM, Abraham Fine  wrote:
>
> > +1 non binding
> >
> > On Thu, Mar 23, 2017, at 13:00, Edward Ribeiro wrote:
> > > +1 non binding
> > >
> > > On Thu, Mar 23, 2017 at 2:17 PM, Rakesh Radhakrishnan
> > > 
> > > wrote:
> > >
> > > > +1
> > > >
> > > >
> > > > Rakesh
> > > >
> > > > On Thu, Mar 23, 2017 at 10:41 PM, Jordan Zimmerman <
> > > > jor...@jordanzimmerman.com> wrote:
> > > >
> > > > > +1 non binding
> > > > >
> > > > > 
> > > > > Jordan Zimmerman
> > > > >
> > > > > > On Mar 23, 2017, at 11:50 AM, Michael Han 
> > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > As previously discussed on dev list [1] and JIRA [2], I propose
> we
> > make
> > > > > the
> > > > > > upcoming 3.5.3 release the first beta release and drops the alpha
> > tag.
> > > > > >
> > > > > > Please vote by *March 27th 2017, 23:59 UTC+0*. If no objections,
> > I'll
> > > > > > commit the patch for [2] and proceed with release process next
> week
> > > > after
> > > > > > the vote cycle ends.
> > > > > >
> > > > > > [1] 3.5.3: alpha or beta?
> > > > > >  > > > > 201703.mbox/%3CCA%2Bi0x1JZacVMQGd_Jb34jSaw7p_
> > nhWpcx9uzHwCwPPF%2BPPrf3g%
> > > > > 40mail.gmail.com%3E>
> > > > > > [2] ZOOKEEPER-2734  > > > jira/browse/ZOOKEEPER-2734
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Cheers
> > > > > > Michael.
> > > > >
> > > >
> >
>



-- 
Cheers
Michael.

ZooKeeper_branch35_openjdk7 - Build # 472 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/472/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.85 MB...]
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:315)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-03-28 04:08:04,049 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27626,name1=Connections,name2=127.0.0.1,name3=0x1033e15f06d]
[junit] 2017-03-28 04:08:04,149 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1033e15f06d closed
[junit] 2017-03-28 04:08:04,149 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 244883
[junit] 2017-03-28 04:08:04,149 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1033e15f06d
[junit] 2017-03-28 04:08:04,150 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2427
[junit] 2017-03-28 04:08:04,150 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-28 04:08:04,150 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-03-28 04:08:04,150 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-03-28 04:08:04,151 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:27626
[junit] 2017-03-28 04:08:04,158 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-03-28 04:08:04,159 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-28 04:08:04,159 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-28 04:08:04,159 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-03-28 04:08:04,159 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-28 04:08:04,159 [myid:] - INFO  [ProcessThread(sid:0 
cport:27626)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-03-28 04:08:04,160 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-28 04:08:04,160 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-28 04:08:04,160 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27626,name1=InMemoryDataTree]
[junit] 2017-03-28 04:08:04,160 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port27626]
[junit] 2017-03-28 04:08:04,161 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 27626
[junit] 2017-03-28 04:08:04,161 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-28 04:08:04,173 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 7136 at start it was 7136
[junit] 2017-03-28 04:08:04,173 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-28 04:08:04,173 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
469.172 sec, Thread: 7, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-28 04:08:04,364 [myid:127.0.0.1:27380] - INFO  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-28 04:08:04,366 [myid:127.0.0.1:27380] - WARN  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 
0x1033e0ee03b for server 127.0.0.1/127.0.0.1:27380, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.Socket

Re: ZOOKEEPER-900

[Atri Sharma]

Hi Patrick,

I am fine with either. I tried pinging the owners but got no response.

Please let me know.

Regards,

Atri

On Tue, Mar 28, 2017 at 4:51 AM, Patrick Hunt  wrote:
> Hi Atri. Which do you intend to work on? 900, 901, or both? Typically if
> someone is intending to work on something they will be listed as the
> "assigned" in JIRA. They would be the first person to check in with. If
> they no longer intend to work on something it's easy enough to reassign.
>
> Regards,
>
> Patrick
>
> On Sat, Mar 25, 2017 at 7:36 AM, Atri Sharma  wrote:
>
>> Hi folks,
>>
>> I was looking to work on ZOOKEEPER-901. Could anybody please let me
>> know if they are working on it?
>>
>> --
>> Regards,
>>
>> Atri
>> l'apprenant
>>



-- 
Regards,

Atri
l'apprenant

ZooKeeper_branch35_jdk8 - Build # 473 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/473/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 63.96 MB...]
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  [main:ZooKeeper@1326] - 
Session: 0x1016fb3e0af closed
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 196765
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1656
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:24930
[junit] 2017-03-28 05:04:33,245 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1016fb3e0af
[junit] 2017-03-28 05:04:33,248 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-03-28 05:04:33,248 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-03-28 05:04:33,248 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  
[main:PrepRequestProcessor@1004] - Shutting down
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  [ProcessThread(sid:0 
cport:24930)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port24930,name1=InMemoryDataTree]
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port24930]
[junit] 2017-03-28 05:04:33,249 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 24930
[junit] 2017-03-28 05:04:33,250 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-03-28 05:04:33,253 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4864 at start it was 4864
[junit] 2017-03-28 05:04:33,254 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-03-28 05:04:33,254 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
524.736 sec, Thread: 6, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-03-28 05:04:33,408 [myid:127.0.0.1:24789] - INFO  
[main-SendThread(127.0.0.1:24789):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:24789. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-28 05:04:33,409 [myid:127.0.0.1:24789] - WARN  
[main-SendThread(127.0.0.1:24789):ClientCnxn$SendThread@1235] - Session 
0x3016faf0faa0001 for server 127.0.0.1/127.0.0.1:24789, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-03-28 05:04:33,440 [myid:127.0.0.1:24786] - INFO  
[main-SendThread(127.0.0.1:24786):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:24786. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-03-28 05:04:33,440 [myid:127.0.0.1:24786] - WARN  
[main-SendThread(127.0.0.1:24786):ClientCnxn$SendThread@1235] - Session 
0x2016faf0f270001 for server 127.0.0.1/127.0.0.1:24786, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
   

[GitHub] zookeeper pull request #210: Fix typo

[jeffwidman]

GitHub user jeffwidman opened a pull request:

https://github.com/apache/zookeeper/pull/210

Fix typo



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeffwidman/zookeeper patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #210


commit 09367c2dd5930b3bd5858c3d443617a49bb86152
Author: Jeff Widman 
Date:   2017-03-28T05:07:38Z

Fix typo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Failed: ZOOKEEPER- PreCommit Build #489

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/489/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 68.35 MB...]
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/489//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/489//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/489//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] b9ff1f9f5e5978d8209b9784ae47395eed0429a8 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 19 minutes 1 second
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)