[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[Ted Dunning (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102749#comment-16102749
 ] 

Ted Dunning commented on ZOOKEEPER-2770:


The typical approach is to set a limit on number of messages per unit time
(say one every 10 minutes). Each message that is printed sets a coalescence
time during which no further messages are printed, but a counter is
updated. At the end of the coalescence time a modified message which
mentions that n additional events were detected and the coalescence time is
disabled.

This way if the warnings are rare, you get normal behavior. If the warnings
are frequent, you get at most one message per 10 minutes (or whatever
coalescence period you choose). You get instant notification of a problem
and limited log output.


On Wed, Jul 26, 2017 at 10:05 PM, Karan Mehta (JIRA) 



> ZooKeeper slow operation log
> 
>
> Key: ZOOKEEPER-2770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Karan Mehta
>Assignee: Karan Mehta
> Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch, 
> ZOOKEEPER-2770.003.patch
>
>
> ZooKeeper is a complex distributed application. There are many reasons why 
> any given read or write operation may become slow: a software bug, a protocol 
> problem, a hardware issue with the commit log(s), a network issue. If the 
> problem is constant it is trivial to come to an understanding of the cause. 
> However in order to diagnose intermittent problems we often don't know where, 
> or when, to begin looking. We need some sort of timestamped indication of the 
> problem. Although ZooKeeper is not a datastore, it does persist data, and can 
> suffer intermittent performance degradation, and should consider implementing 
> a 'slow query' log, a feature very common to services which persist 
> information on behalf of clients which may be sensitive to latency while 
> waiting for confirmation of successful persistence.
> Log the client and request details if the server discovers, when finally 
> processing the request, that the current time minus arrival time of the 
> request is beyond a configured threshold. 
> Look at the HBase {{responseTooSlow}} feature for inspiration. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

[Karan Mehta (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102708#comment-16102708
 ] 

Karan Mehta commented on ZOOKEEPER-2770:


[~tdunning]
There is no rate limiting on logging. If the threshold is too low, it might 
result in huge amount of messages getting printed. At this point, I suggest the 
following things. Please suggest your opinion.
1. Turn off this feature by default, so that we don't end up on an arbitrary 
value.
I personally not want this, since I believe that no matter what your 
requirements are or your hardware, it can be possible to put some upper bound 
on this value. Experienced people can comment on this more than I can. 
2. Add rate limiter based on some logic
  2.1 Time based logic (Limit messages printed in a given amount of time)
  2.2 Random sampling based on some probability percentage.

I am not aware of how typically these things are implemented. It would be good 
if you can suggest some part of code which does similar stuff. Thanks!

> ZooKeeper slow operation log
> 
>
> Key: ZOOKEEPER-2770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Karan Mehta
>Assignee: Karan Mehta
> Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch, 
> ZOOKEEPER-2770.003.patch
>
>
> ZooKeeper is a complex distributed application. There are many reasons why 
> any given read or write operation may become slow: a software bug, a protocol 
> problem, a hardware issue with the commit log(s), a network issue. If the 
> problem is constant it is trivial to come to an understanding of the cause. 
> However in order to diagnose intermittent problems we often don't know where, 
> or when, to begin looking. We need some sort of timestamped indication of the 
> problem. Although ZooKeeper is not a datastore, it does persist data, and can 
> suffer intermittent performance degradation, and should consider implementing 
> a 'slow query' log, a feature very common to services which persist 
> information on behalf of clients which may be sensitive to latency while 
> waiting for confirmation of successful persistence.
> Log the client and request details if the server discovers, when finally 
> processing the request, that the current time minus arrival time of the 
> request is beyond a configured threshold. 
> Look at the HBase {{responseTooSlow}} feature for inspiration. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch35_openjdk7 - Build # 613 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/613/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 69.80 MB...]
[junit] 2017-07-27 03:28:12,559 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-27 03:28:12,560 [myid:127.0.0.1:11222] - WARN  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1235] - Session 
0x100a3e6edcb for server 127.0.0.1/127.0.0.1:11222, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 03:28:13,001 [myid:] - INFO  [ProcessThread(sid:0 
cport:11468)::PrepRequestProcessor@611] - Processed session termination for 
sessionid: 0x100a3ef7a4c
[junit] 2017-07-27 03:28:13,006 [myid:127.0.0.1:11348] - INFO  
[main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11348. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-27 03:28:13,006 [myid:127.0.0.1:11348] - WARN  
[main-SendThread(127.0.0.1:11348):ClientCnxn$SendThread@1235] - Session 
0x200a3ec6ee1 for server 127.0.0.1/127.0.0.1:11348, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 03:28:13,016 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=Connections,name2=127.0.0.1,name3=0x100a3ef7a4c]
[junit] 2017-07-27 03:28:13,017 [myid:] - INFO  [main:ZooKeeper@1331] - 
Session: 0x100a3ef7a4c closed
[junit] 2017-07-27 03:28:13,017 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x100a3ef7a4c
[junit] 2017-07-27 03:28:13,017 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 219271
[junit] 2017-07-27 03:28:13,017 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2432
[junit] 2017-07-27 03:28:13,017 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-07-27 03:28:13,018 [myid:] - INFO  [main:ClientBase@586] - 
tearDown starting
[junit] 2017-07-27 03:28:13,018 [myid:] - INFO  [main:ClientBase@556] - 
STOPPING server
[junit] 2017-07-27 03:28:13,018 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:11468
[junit] 2017-07-27 03:28:13,026 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-07-27 03:28:13,026 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-27 03:28:13,026 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-27 03:28:13,027 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-27 03:28:13,027 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-27 03:28:13,027 [myid:] - INFO  [ProcessThread(sid:0 
cport:11468)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-27 03:28:13,027 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-27 03:28:13,027 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-27 03:28:13,028 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11468,name1=InMemoryDataTree]
[junit] 2017-07-27 03:28:13,028 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11468]
[junit] 2017-07-27 03:28:13,028 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11468

ZooKeeper_branch35_jdk8 - Build # 613 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/613/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66.61 MB...]
[junit] 2017-07-27 02:32:37,443 [myid:127.0.0.1:16657] - WARN  
[main-SendThread(127.0.0.1:16657):ClientCnxn$SendThread@1235] - Session 
0x106c7aca1960001 for server 127.0.0.1/127.0.0.1:16657, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 02:32:37,486 [myid:127.0.0.1:16731] - INFO  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16731. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-27 02:32:37,486 [myid:127.0.0.1:16731] - WARN  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1235] - Session 
0x106c7af7b10 for server 127.0.0.1/127.0.0.1:16731, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 02:32:37,789 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@611] - Processed session termination for 
sessionid: 0x106c7b29cb2
[junit] 2017-07-27 02:32:37,792 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x106c7b29cb2]
[junit] 2017-07-27 02:32:37,792 [myid:] - INFO  [main:ZooKeeper@1331] - 
Session: 0x106c7b29cb2 closed
[junit] 2017-07-27 02:32:37,792 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x106c7b29cb2
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 90204
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 471
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  [main:ClientBase@586] - 
tearDown starting
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  [main:ClientBase@556] - 
STOPPING server
[junit] 2017-07-27 02:32:37,793 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-07-27 02:32:37,794 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-07-27 02:32:37,794 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-27 02:32:37,794 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-27 02:32:37,794 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-27 02:32:37,794 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-27 02:32:37,794 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-27 02:32:37,795 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-27 02:32:37,795 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-27 02:32:37,795 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-07-27 02:32:37,795 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-07-27 02:32:37,795 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854
[junit] 2017-07-27 02:32:37,796 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-27 02:32:37,800 [myid:] - INFO  [main:ClientBase@611] - 
fdcount after test is: 1403 at start it was 1399
[junit] 2017-07-27 02:32:37,800 [myid:] - 

ZooKeeper-trunk-jdk8 - Build # 1141 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1141/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 61.52 MB...]
[junit] 2017-07-27 02:20:56,038 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-27 02:20:56,038 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-27 02:20:56,038 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-07-27 02:20:56,038 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-27 02:20:56,038 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-27 02:20:56,039 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-27 02:20:56,039 [myid:] - INFO  [ProcessThread(sid:0 
cport:19547)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-27 02:20:56,039 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19547,name1=InMemoryDataTree]
[junit] 2017-07-27 02:20:56,039 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port19547]
[junit] 2017-07-27 02:20:56,039 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 19547
[junit] 2017-07-27 02:20:56,040 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-27 02:20:56,049 [myid:] - INFO  [main:ClientBase@626] - 
fdcount after test is: 2818 at start it was 2823
[junit] 2017-07-27 02:20:56,049 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-07-27 02:20:56,049 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
443.675 sec, Thread: 4, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 2017-07-27 02:20:56,628 [myid:127.0.0.1:19365] - INFO  
[main-SendThread(127.0.0.1:19365):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19365. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-27 02:20:56,629 [myid:] - INFO  [New I/O boss 
#3723:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:19365
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:748)
[junit] 2017-07-27 02:20:56,630 [myid:] - WARN  [New I/O boss 
#3723:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x4c46fd29] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:19365
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:19365
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 

ZooKeeper_branch34_openjdk7 - Build # 1588 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1588/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by an SCM change
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on qnode1 (ubuntu) in workspace 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://git.apache.org/zookeeper.git # timeout=10
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > git reset --hard # timeout=10
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.apache.org/zookeeper.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/branch-3.4^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/branch-3.4^{commit} # timeout=10
Checking out Revision 90652669bece7bcde11e16df3f5722d80b3c5b31 
(refs/remotes/origin/branch-3.4)
Commit message: "ZOOKEEPER-2856: ZooKeeperSaslClient#respondToServer should log 
exception"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 90652669bece7bcde11e16df3f5722d80b3c5b31
 > git rev-list f8b5be0af45d2127b096ed41c11d3c0d7244df8e # timeout=10
No emails were triggered.
[ZooKeeper_branch34_openjdk7] $ 
/home/jenkins/tools/ant/apache-ant-1.9.9/bin/ant -Dtest.output=yes 
-Dtest.junit.threads=8 -Dtest.junit.output.format=xml -Djavac.target=1.7 clean 
test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /usr/lib/jvm/java-7-openjdk-amd64//bin/java
Build step 'Invoke Ant' marked build as failure
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk7 - Build # 1056 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1056/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.34 MB...]
[junit] 2017-07-27 01:50:47,990 [myid:127.0.0.1:16672] - WARN  
[main-SendThread(127.0.0.1:16672):ClientCnxn$SendThread@1235] - Session 
0x105acb41351 for server 127.0.0.1/127.0.0.1:16672, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 01:50:48,000 [myid:127.0.0.1:16608] - INFO  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16608. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-27 01:50:48,000 [myid:127.0.0.1:16608] - WARN  
[main-SendThread(127.0.0.1:16608):ClientCnxn$SendThread@1235] - Session 
0x105acb37aee for server 127.0.0.1/127.0.0.1:16608, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-27 01:50:48,221 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@611] - Processed session termination for 
sessionid: 0x105acb9c0c1
[junit] 2017-07-27 01:50:48,222 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x105acb9c0c1]
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  [main:ZooKeeper@1331] - 
Session: 0x105acb9c0c1 closed
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x105acb9c0c1
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 242260
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2490
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  [main:ClientBase@586] - 
tearDown starting
[junit] 2017-07-27 01:50:48,223 [myid:] - INFO  [main:ClientBase@556] - 
STOPPING server
[junit] 2017-07-27 01:50:48,224 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-07-27 01:50:48,229 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-07-27 01:50:48,229 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-27 01:50:48,229 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-27 01:50:48,229 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-27 01:50:48,229 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-27 01:50:48,229 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-27 01:50:48,230 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-27 01:50:48,230 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-27 01:50:48,230 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-07-27 01:50:48,230 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-07-27 01:50:48,231 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854
[junit] 2017-07-27 01:50:48,231 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-27 01:50:48,239 [myid:] - INFO  [main:ClientBase@611] - 
fdcount after test is: 7337 at start it was 7337
[junit] 2017-07-27 01:50:48,239 [myid:] - 

[jira] [Commented] (ZOOKEEPER-2829) Interface usability / compatibility improvements through Java annotation.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102568#comment-16102568
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2829:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/316
  
The only other change in the output of our javadoc due to this patch are 
extra packages appearing in the package list in the javadoc. Those packages do 
not include any "Public" classes and a user clicking on them will reveal no 
documented classes. This could be fixed by manually excluding those packages in 
the javadoc ant task but doing so would "defeat the purpose" of handling 
exclusion using the annotations. The behavior is consistent with other projects 
in our ecosystem such as Hadoop and HBase.


> Interface usability / compatibility improvements through Java annotation.
> -
>
> Key: ZOOKEEPER-2829
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2829
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: java client, server
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Michael Han
>Assignee: Abraham Fine
>  Labels: annotation
>
> Hadoop has interface classification regarding the interfaces' scope and 
> stability. ZK should do something similar, which not only provides additional 
> benefits of making API compatibility easier between releases (or even 
> commits, by automating the checks via some tooling), but also consistent with 
> rest of Hadoop ecosystem.
> See HADOOP-5073 for more context.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper issue #316: ZOOKEEPER-2829: Interface usability / compatibility im...

[afine]

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/316
  
The only other change in the output of our javadoc due to this patch are 
extra packages appearing in the package list in the javadoc. Those packages do 
not include any "Public" classes and a user clicking on them will reveal no 
documented classes. This could be fixed by manually excluding those packages in 
the javadoc ant task but doing so would "defeat the purpose" of handling 
exclusion using the annotations. The behavior is consistent with other projects 
in our ecosystem such as Hadoop and HBase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102565#comment-16102565
 ] 

Hudson commented on ZOOKEEPER-2856:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3478 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3478/])
ZOOKEEPER-2856: ZooKeeperSaslClient#respondToServer should log exception (hanm: 
rev 41b30a74ec8b33255e99d97a102de53d315c28b3)
* (edit) src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java


> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102537#comment-16102537
 ] 

Michael Han commented on ZOOKEEPER-2849:


[~brian.linin...@gmail.com] thanks, assigning this issue to you. Please 
checkout https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute 
for how to create a pull request. 

> Quorum port binding needs exponential back-off retry
> 
>
> Key: ZOOKEEPER-2849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.4.6, 3.5.3
>Reporter: Brian Lininger
>Assignee: Brian Lininger
>Priority: Minor
>
> Recently we upgraded the AWS instance type we use for running out ZooKeeper 
> nodes, and by doing so we're intermittently hitting an issue where ZooKeeper 
> cannot bind to the server election port because the IP is incorrect.  This is 
> due to name resolution in Route53 not being in sync when ZooKeeper starts on 
> the more powerful EC2 instances.  Currently in QuorumCnxManager.Listener, we 
> only attempt to bind 3 times with a 1s sleep between retries, which is not 
> long enough.  
> I'm proposing to change this to follow an exponential back-off type strategy 
> where each failed attempt causes a longer sleep between retry attempts.  This 
> would allow for Zookeeper to gracefully recover when the host is 
> misconfigured, and subsequently corrected, without requiring the process to 
> be restarted while also minimizing the impact to the running instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han reassigned ZOOKEEPER-2849:
--

Assignee: Brian Lininger

> Quorum port binding needs exponential back-off retry
> 
>
> Key: ZOOKEEPER-2849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.4.6, 3.5.3
>Reporter: Brian Lininger
>Assignee: Brian Lininger
>Priority: Minor
>
> Recently we upgraded the AWS instance type we use for running out ZooKeeper 
> nodes, and by doing so we're intermittently hitting an issue where ZooKeeper 
> cannot bind to the server election port because the IP is incorrect.  This is 
> due to name resolution in Route53 not being in sync when ZooKeeper starts on 
> the more powerful EC2 instances.  Currently in QuorumCnxManager.Listener, we 
> only attempt to bind 3 times with a 1s sleep between retries, which is not 
> long enough.  
> I'm proposing to change this to follow an exponential back-off type strategy 
> where each failed attempt causes a longer sleep between retry attempts.  This 
> would allow for Zookeeper to gracefully recover when the host is 
> misconfigured, and subsequently corrected, without requiring the process to 
> be restarted while also minimizing the impact to the running instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #904

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 73.35 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 19c4a74f98b8b980e3b0c7cbb246807d881b400c logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 17 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2577
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102525#comment-16102525
 ] 

Hadoop QA commented on ZOOKEEPER-2577:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/904//console

This message is automatically generated.

> Flaky Test: 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
> 
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>  Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
>   at 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO  [main:ZKTestCase$1@55] - STARTING 
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO  [main:PortAssignment@151] - Test 
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
>  clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
>  clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
>  clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-0:QuorumPeerConfig@116] - 
> Reading configuration from: 
> 

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102522#comment-16102522
 ] 

Michael Han commented on ZOOKEEPER-2856:


Committed.
master: 
https://github.com/apache/zookeeper/commit/41b30a74ec8b33255e99d97a102de53d315c28b3
branch-3.5: 
https://github.com/apache/zookeeper/commit/f671a6a08258b911957cc2c3a9031a6d510ff8af
branch-3.4: 
https://github.com/apache/zookeeper/commit/90652669bece7bcde11e16df3f5722d80b3c5b31

> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #318: ZOOKEEPER-2856 ZooKeeperSaslClient#respondToSer...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/318


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102518#comment-16102518
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2856:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/318


> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102514#comment-16102514
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2856:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/318
  
LGTM. The failed test is a known issue and will be fixed by 
https://github.com/apache/zookeeper/pull/315.
Merging.


> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2577) Flaky Test: org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102507#comment-16102507
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2577:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/315#discussion_r129727799
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -1451,7 +1452,12 @@ public synchronized void 
restartLeaderElection(QuorumVerifier qvOLD, QuorumVerif
 }
 
 public String getNextDynamicConfigFilename() {
-return configFilename + 
QuorumPeerConfig.nextDynamicConfigFileSuffix;
+if (configFilename != null) {
--- End diff --

@shralex Turns out pretty trivial to guarantee a real configFileName in 
this case - update with one line change. Tested on apache jenkins the issue is 
fixed.

Note we still have configFileName as null for some other tests (such as FLE 
tests) but in those tests the intermediate reconfig file is not relevant so 
I'll just leave as they are. 


> Flaky Test: 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync
> 
>
> Key: ZOOKEEPER-2577
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2577
> Project: ZooKeeper
>  Issue Type: Test
>  Components: tests
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>  Labels: flaky, flaky-test
> Fix For: 3.6.0
>
>
> {noformat}
> Error Message
> zoo.cfg.dynamic.next is not deleted.
> Stacktrace
> junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
>   at 
> org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync(ReconfigDuringLeaderSyncTest.java:155)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
> Standard Output
> 2016-09-13 05:09:25,247 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,349 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
> test.method specified. using default methods.
> 2016-09-13 05:09:25,370 [myid:] - INFO  [main:ZKTestCase$1@55] - STARTING 
> testDuringLeaderSync
> 2016-09-13 05:09:25,372 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
> testDuringLeaderSync
> 2016-09-13 05:09:25,375 [myid:] - INFO  [main:PortAssignment@151] - Test 
> process 2/8 using ports from 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13915 from range 13914 - 16606.
> 2016-09-13 05:09:25,380 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13916 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13917 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13918 from range 13914 - 16606.
> 2016-09-13 05:09:25,381 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13919 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13920 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13921 from range 13914 - 16606.
> 2016-09-13 05:09:25,382 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13922 from range 13914 - 16606.
> 2016-09-13 05:09:25,383 [myid:] - INFO  [main:PortAssignment@85] - Assigned 
> port 13923 from range 13914 - 16606.
> 2016-09-13 05:09:25,406 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir
>  clientPort = 13915 adminServerPort = 8080
> 2016-09-13 05:09:25,416 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test176919429940621.junit.dir
>  clientPort = 13918 adminServerPort = 8080
> 2016-09-13 05:09:25,420 [myid:] - INFO  
> [main:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir = 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test5455612786130415623.junit.dir
>  clientPort = 13921 adminServerPort = 8080
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-0:QuorumPeerConfig@116] - 
> Reading configuration from: 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/build/test/tmp/test8397079557861207505.junit.dir/zoo.cfg
> 2016-09-13 05:09:25,422 [myid:] - INFO  [Thread-2:QuorumPeerConfig@116] - 
> Reading configuration from: 
> 

[GitHub] zookeeper pull request #315: ZOOKEEPER-2577: Fix flaky testDuringLeaderSync ...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/315#discussion_r129727799
  
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 
---
@@ -1451,7 +1452,12 @@ public synchronized void 
restartLeaderElection(QuorumVerifier qvOLD, QuorumVerif
 }
 
 public String getNextDynamicConfigFilename() {
-return configFilename + 
QuorumPeerConfig.nextDynamicConfigFileSuffix;
+if (configFilename != null) {
--- End diff --

@shralex Turns out pretty trivial to guarantee a real configFileName in 
this case - update with one line change. Tested on apache jenkins the issue is 
fixed.

Note we still have configFileName as null for some other tests (such as FLE 
tests) but in those tests the intermediate reconfig file is not relevant so 
I'll just leave as they are. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper-trunk - Build # 3477 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3477/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 64.92 MB...]
[junit] 2017-07-26 23:27:45,003 [myid:] - INFO  [main:QuorumUtil@259] - 
Waiting for QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled) to exit 
thread
[junit] 2017-07-26 23:27:45,003 [myid:] - WARN  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1130] - 
Unexpected exception
[junit] java.lang.InterruptedException
[junit] at java.lang.Object.wait(Native Method)
[junit] at 
org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:563)
[junit] at 
org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1127)
[junit] 2017-07-26 23:27:45,003 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):Leader@626] - 
Shutting down
[junit] 2017-07-26 23:27:45,003 [myid:] - WARN  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1161] - 
PeerState set to LOOKING
[junit] 2017-07-26 23:27:45,004 [myid:] - WARN  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):QuorumPeer@1143] - 
QuorumPeer main thread exited
[junit] 2017-07-26 23:27:45,004 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] 
- Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5]
[junit] 2017-07-26 23:27:45,004 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] 
- Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5]
[junit] 2017-07-26 23:27:45,004 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] 
- Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1]
[junit] 2017-07-26 23:27:45,004 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] 
- Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2]
[junit] 2017-07-26 23:27:45,004 [myid:] - INFO  
[QuorumPeer[myid=5](plain=/127.0.0.1:11383)(secure=disabled):MBeanRegistry@128] 
- Unregister MBean 
[org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3]
[junit] 2017-07-26 23:27:45,005 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11371
[junit] 2017-07-26 23:27:45,005 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11371 is no longer accepting client connections
[junit] 2017-07-26 23:27:45,005 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11374
[junit] 2017-07-26 23:27:45,005 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11374 is no longer accepting client connections
[junit] 2017-07-26 23:27:45,006 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11377
[junit] 2017-07-26 23:27:45,006 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11377 is no longer accepting client connections
[junit] 2017-07-26 23:27:45,006 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11380
[junit] 2017-07-26 23:27:45,006 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11380 is no longer accepting client connections
[junit] 2017-07-26 23:27:45,006 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11383
[junit] 2017-07-26 23:27:45,007 [myid:] - INFO  [main:QuorumUtil@243] - 
127.0.0.1:11383 is no longer accepting client connections
[junit] 2017-07-26 23:27:45,008 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testRemoveOneAsynchronous
[junit] 2017-07-26 23:27:45,008 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testRemoveOneAsynchronous
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
277.362 sec, Thread: 1, Class: org.apache.zookeeper.test.ReconfigTest
[junit] 2017-07-26 23:27:45,199 [myid:127.0.0.1:11276] - INFO  
[main-SendThread(127.0.0.1:11276):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11276. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 23:27:45,200 [myid:127.0.0.1:11276] - WARN  
[main-SendThread(127.0.0.1:11276):ClientCnxn$SendThread@1235] - Session 
0x3006dde9806 for server 127.0.0.1/127.0.0.1:11276, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)

Success: ZOOKEEPER- PreCommit Build #903

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.90 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] c9adcfb09ffae0ecd5b0f70eb9307e5f110f6981 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 43 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2859
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102392#comment-16102392
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/903//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #902

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 71.13 MB...]
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 80cf3b80edab5c2a37f21aa48d06ec42c8ce8f7a logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1642:
 exec returned: 1

Total time: 19 minutes 38 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2859
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
3 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun

Error Message:
Timeout occurred. Please note the time in the report does not reflect the time 
until the timeout.

Stack Trace:
junit.framework.AssertionFailedError: Timeout occurred. Please note the time in 
the report does not reflect the time until the timeout.
at java.lang.Thread.run(Thread.java:745)


FAILED:  
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

Error Message:
expected: but was:

Stack Trace:
junit.framework.AssertionFailedError: expected: but 
was:
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest$EventsWatcher.assertEvent(WatchEventWhenAutoResetTest.java:67)
at 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged(WatchEventWhenAutoResetTest.java:126)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)


FAILED:  
org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest.testDuringLeaderSync

Error Message:
zoo.cfg.dynamic.next is not deleted.

Stack Trace:
junit.framework.AssertionFailedError: zoo.cfg.dynamic.next is not deleted.
at 

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102387#comment-16102387
 ] 

Hadoop QA commented on ZOOKEEPER-2859:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/902//console

This message is automatically generated.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102360#comment-16102360
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
---

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/319

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper macos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit 050ece633b3a9eec70db139a7e95bc70015cb6ab
Author: Andrew Schwartzmeyer 
Date:   2017-07-26T22:01:40Z

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.




> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #319: ZOOKEEPER-2859: Fix CMake build on OS X.

[andschwa]

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/319

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper macos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit 050ece633b3a9eec70db139a7e95bc70015cb6ab
Author: Andrew Schwartzmeyer 
Date:   2017-07-26T22:01:40Z

ZOOKEEPER-2859: Fix CMake build on OS X.

And take care of a TODO for pthread.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Andrew Schwartzmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102320#comment-16102320
 ] 

Andrew Schwartzmeyer commented on ZOOKEEPER-2859:
-

Fixing the build of just the client is trivial. Change {{if(UNIX)}} to 
{{if(LINUX)}} where we guard {{target_link_libraries(zookeeper PUBLIC m rt)}}.

> CMake build doesn't support OS X
> 
>
> Key: ZOOKEEPER-2859
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: OS X 10.12.6
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2859) CMake build doesn't support OS X

[Andrew Schwartzmeyer (JIRA)]

Andrew Schwartzmeyer created ZOOKEEPER-2859:
---

 Summary: CMake build doesn't support OS X
 Key: ZOOKEEPER-2859
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
 Project: ZooKeeper
  Issue Type: Bug
 Environment: OS X 10.12.6
Reporter: Andrew Schwartzmeyer
Assignee: Andrew Schwartzmeyer


Couple problems:

libm, librt, and libdl are all Linux specific, and provided "for free" on OS X

CppUnit (at least on OS X) needs `-std=c++11`

clang's ld doesn't understand --wrap

I can post an easy patch that at least lets you build the client (but not the 
tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper-trunk-openjdk7 - Build # 1557 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1557/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 52.42 MB...]
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-26 20:19:30,808 [myid:] - INFO  [main:ZooKeeper@1329] - 
Session: 0x105ab84e445 closed
[junit] 2017-07-26 20:19:30,808 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 199943
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2437
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  [main:ClientBase@601] - 
tearDown starting
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  [main:ClientBase@571] - 
STOPPING server
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:22240
[junit] 2017-07-26 20:19:30,809 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x105ab84e445
[junit] 2017-07-26 20:19:30,812 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-07-26 20:19:30,812 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-26 20:19:30,812 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-26 20:19:30,812 [myid:] - INFO  
[main:PrepRequestProcessor@1008] - Shutting down
[junit] 2017-07-26 20:19:30,812 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-26 20:19:30,813 [myid:] - INFO  [ProcessThread(sid:0 
cport:22240)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-26 20:19:30,813 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-26 20:19:30,816 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-26 20:19:30,816 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port22240,name1=InMemoryDataTree]
[junit] 2017-07-26 20:19:30,817 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22240]
[junit] 2017-07-26 20:19:30,817 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 22240
[junit] 2017-07-26 20:19:30,817 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-26 20:19:30,828 [myid:] - INFO  [main:ClientBase@626] - 
fdcount after test is: 7157 at start it was 7159
[junit] 2017-07-26 20:19:30,828 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-07-26 20:19:30,828 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
414.693 sec, Thread: 5, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-07-26 20:19:31,089 [myid:127.0.0.1:22058] - INFO  
[main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22058. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 20:19:31,089 [myid:127.0.0.1:22058] - WARN  
[main-SendThread(127.0.0.1:22058):ClientCnxn$SendThread@1235] - Session 
0x105ab7f4b6f for server 127.0.0.1/127.0.0.1:22058, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-26 20:19:31,134 [myid:127.0.0.1:22123] - INFO  
[main-SendThread(127.0.0.1:22123):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:22123. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 20:19:31,135 [myid:127.0.0.1:22123] - WARN  

[jira] [Assigned] (ZOOKEEPER-2491) C client build error in vs 2015

[Andrew Schwartzmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Schwartzmeyer reassigned ZOOKEEPER-2491:
---

Assignee: Andrew Schwartzmeyer  (was: spooky000)

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: Andrew Schwartzmeyer
>Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015

[Andrew Schwartzmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102060#comment-16102060
 ] 

Andrew Schwartzmeyer commented on ZOOKEEPER-2491:
-

[~hanm] I believe we can close this issue; I fixed it in my patch that's 
upstream now for 3.5+

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: spooky000
>Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry

[Brian Lininger (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101922#comment-16101922
 ] 

Brian Lininger commented on ZOOKEEPER-2849:
---

[~hanm] I am interested, I'll try to get something together in a week or so.

> Quorum port binding needs exponential back-off retry
> 
>
> Key: ZOOKEEPER-2849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.4.6, 3.5.3
>Reporter: Brian Lininger
>Priority: Minor
>
> Recently we upgraded the AWS instance type we use for running out ZooKeeper 
> nodes, and by doing so we're intermittently hitting an issue where ZooKeeper 
> cannot bind to the server election port because the IP is incorrect.  This is 
> due to name resolution in Route53 not being in sync when ZooKeeper starts on 
> the more powerful EC2 instances.  Currently in QuorumCnxManager.Listener, we 
> only attempt to bind 3 times with a 1s sleep between retries, which is not 
> long enough.  
> I'm proposing to change this to follow an exponential back-off type strategy 
> where each failed attempt causes a longer sleep between retry attempts.  This 
> would allow for Zookeeper to gracefully recover when the host is 
> misconfigured, and subsequently corrected, without requiring the process to 
> be restarted while also minimizing the impact to the running instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2858) Disable reverse DNS lookup for java client

[Andrey (JIRA)]

Andrey created ZOOKEEPER-2858:
-

 Summary: Disable reverse DNS lookup for java client
 Key: ZOOKEEPER-2858
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2858
 Project: ZooKeeper
  Issue Type: New Feature
  Components: java client
Affects Versions: 3.4.6
Reporter: Andrey


I have the following setup:
- zookeeper server running in docker container
- kerberos auth

When client setup sasl connection it creates service principal name as:
- "principalUserName+"/"+addr.getHostName()",

where:
- addr.getHostName is the reverse DNS of original server host.

If zookeeper nodes will be deployed behind the firewall or software defined 
network (the docker case), then reverse DNS host won't match original server 
host. And this is done by design.

If these hosts won't match, then principals won't match and Kerberos auth will 
fail.

Is it possible to introduce some configuration parameter to disable reverse DNS 
lookups?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch35_jdk8 - Build # 612 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/612/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.64 MB...]
[junit] 2017-07-26 12:16:00,018 [myid:127.0.0.1:16731] - INFO  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16731. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 12:16:00,018 [myid:127.0.0.1:16731] - WARN  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1235] - Session 
0x106c49ef41d for server 127.0.0.1/127.0.0.1:16731, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-07-26 12:16:00,115 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@611] - Processed session termination for 
sessionid: 0x106c4a2528f
[junit] 2017-07-26 12:16:00,117 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=Connections,name2=127.0.0.1,name3=0x106c4a2528f]
[junit] 2017-07-26 12:16:00,117 [myid:] - INFO  [main:ZooKeeper@1331] - 
Session: 0x106c4a2528f closed
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 71760
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 473
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  [main:ClientBase@586] - 
tearDown starting
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  [main:ClientBase@556] - 
STOPPING server
[junit] 2017-07-26 12:16:00,118 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16854
[junit] 2017-07-26 12:16:00,119 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x106c4a2528f
[junit] 2017-07-26 12:16:00,120 [myid:] - INFO  [main:ZooKeeperServer@541] 
- shutting down
[junit] 2017-07-26 12:16:00,121 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  [ProcessThread(sid:0 
cport:16854)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-26 12:16:00,121 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-26 12:16:00,122 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16854,name1=InMemoryDataTree]
[junit] 2017-07-26 12:16:00,122 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16854]
[junit] 2017-07-26 12:16:00,122 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16854
[junit] 2017-07-26 12:16:00,122 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-26 12:16:00,127 [myid:] - INFO  [main:ClientBase@611] - 
fdcount after test is: 1407 at start it was 1409
[junit] 2017-07-26 12:16:00,127 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-07-26 12:16:00,127 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
428.84 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-07-26 12:16:00,196 [myid:127.0.0.1:16737] - INFO  
[main-SendThread(127.0.0.1:16737):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16737. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 12:16:00,197 [myid:127.0.0.1:16737] - WARN  

ZooKeeper-trunk-jdk8 - Build # 1140 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1140/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 8.15 KB...]
Cleaning workspace
 > git rev-parse --verify HEAD # timeout=10
No valid HEAD. Skipping the resetting
 > git clean -fdx # timeout=10
Fetching upstream changes from git://git.apache.org/zookeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress git://git.apache.org/zookeeper.git 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
git://git.apache.org/zookeeper.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:812)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1079)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1110)
at hudson.scm.SCM.checkout(SCM.java:495)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:560)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:485)
at hudson.model.Run.execute(Run.java:1735)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:405)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress git://git.apache.org/zookeeper.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to connect to git.apache.org:
git.apache.org: Temporary failure in name resolution


at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1903)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1622)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:71)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:348)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
at ..remote call to cassandra11(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1545)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:830)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor864.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy104.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:810)
... 11 more
ERROR: Error fetching remote repo 'origin'
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch35_jdk7 - Build # 1055 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1055/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 66.14 MB...]
[junit] 2017-07-26 09:00:30,929 [myid:] - ERROR [main:ZooKeeperServer@505] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-07-26 09:00:30,929 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-07-26 09:00:30,929 [myid:] - INFO  
[main:PrepRequestProcessor@1005] - Shutting down
[junit] 2017-07-26 09:00:30,929 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-07-26 09:00:30,929 [myid:] - INFO  [ProcessThread(sid:0 
cport:14161)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-07-26 09:00:30,929 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-07-26 09:00:30,930 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-07-26 09:00:30,930 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=InMemoryDataTree]
[junit] 2017-07-26 09:00:30,930 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161]
[junit] 2017-07-26 09:00:30,930 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 14161
[junit] 2017-07-26 09:00:30,931 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-07-26 09:00:30,937 [myid:] - INFO  [main:ClientBase@611] - 
fdcount after test is: 2838 at start it was 2838
[junit] 2017-07-26 09:00:30,937 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-07-26 09:00:30,937 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
434.094 sec, Thread: 2, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 2017-07-26 09:00:31,465 [myid:127.0.0.1:14038] - INFO  
[main-SendThread(127.0.0.1:14038):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14038. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-07-26 09:00:31,466 [myid:] - INFO  [New I/O boss 
#5219:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:14038
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-07-26 09:00:31,467 [myid:] - WARN  [New I/O boss 
#5219:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x4160a724] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:14038
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:14038
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 

[jira] [Created] (ZOOKEEPER-2857) Server deal command has problem

[Bo Hu (JIRA)]

Bo Hu created ZOOKEEPER-2857:


 Summary: Server deal command has problem
 Key: ZOOKEEPER-2857
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2857
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.3.0
Reporter: Bo Hu


NIOServerCnxn.java
private boolean readLength(SelectionKey k) throws IOException 
if (!initialized && checkFourLetterWord(sk, len)) {
return false;
}

I think this is a problem. when initialized is true, it also need execute 
checkFourLetterWord, but it don't execute.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101260#comment-16101260
 ] 

Hadoop QA commented on ZOOKEEPER-2856:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//console

This message is automatically generated.

> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[Pan Yuxuan (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101254#comment-16101254
 ] 

Pan Yuxuan commented on ZOOKEEPER-2856:
---

[~hanm]
Thanks for your kindly reply.
I have created a pull request in github and use parameterized logging instead.

> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101245#comment-16101245
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2856:
---

GitHub user pyx1990 opened a pull request:

https://github.com/apache/zookeeper/pull/318

ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception

See https://issues.apache.org/jira/browse/ZOOKEEPER-2856 for details.

When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
sometimes get error in HBase logs like:
`SASL authentication failed using login context 'Client'.`
This error occures when getting SaslException in 
ZooKeeperSaslClient#respondToServer :
`catch (SaslException e) {`
`LOG.error("SASL authentication failed using login context 
'" +`
   ` this.getLoginContext() + "'.");`
`saslState = SaslState.FAILED;`
`gotLastPacket = true;`
`  }`
This error makes user confused without explicit exception message. So I 
think we can add exception message to the log.

The patch uses  parameterized logging to add the exception message to the 
log.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pyx1990/zookeeper ZOOKEEPER-2856

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit 298a636acb2e1c7c09a0151ba6529aff101ea200
Author: panyuxuan 
Date:   2017-07-26T06:47:29Z

ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception
message of SaslException




> ZooKeeperSaslClient#respondToServer should log exception message of 
> SaslException
> -
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Pan Yuxuan
>Assignee: Pan Yuxuan
>Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in 
> ZooKeeperSaslClient#respondToServer :
> {noformat}
>  catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think 
> we can add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #318: ZOOKEEPER-2856 ZooKeeperSaslClient#respondToSer...

[pyx1990]

GitHub user pyx1990 opened a pull request:

https://github.com/apache/zookeeper/pull/318

ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception

See https://issues.apache.org/jira/browse/ZOOKEEPER-2856 for details.

When upstream like HBase call ZooKeeperSaslClient with security enabled, we 
sometimes get error in HBase logs like:
`SASL authentication failed using login context 'Client'.`
This error occures when getting SaslException in 
ZooKeeperSaslClient#respondToServer :
`catch (SaslException e) {`
`LOG.error("SASL authentication failed using login context 
'" +`
   ` this.getLoginContext() + "'.");`
`saslState = SaslState.FAILED;`
`gotLastPacket = true;`
`  }`
This error makes user confused without explicit exception message. So I 
think we can add exception message to the log.

The patch uses  parameterized logging to add the exception message to the 
log.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pyx1990/zookeeper ZOOKEEPER-2856

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit 298a636acb2e1c7c09a0151ba6529aff101ea200
Author: panyuxuan 
Date:   2017-07-26T06:47:29Z

ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception
message of SaslException




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---