Re: Correct way to build style bindings on GNU/Linux ARMv7?

[Emilio Cobos Álvarez]

On 02/07/2018 06:04 PM, Henri Sivonen wrote:
> mach bootstrap doesn't appear to download a bindgen-compatible clang
> on an ARMv7 GNU/Linux host.
> 
> mach build then complains about not being able to generate the stylo bindings.
> 
> As I understand it, --disable-stylo-build-bindgen should be OK if one
> isn't modifying stylo, but building with that flag fails:

It fails because the position of those flags is different depending on
the architecture:


https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/dom/base/nsWrapperCache.h#31

So it's not the bindings what are failing. If your purpose is building
(not running), you can probably just tweak the wrapper.rs file to remove
the conditional #[cfg]s:


https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/servo/components/style/gecko/wrapper.rs#190

Hope it helps,

 -- Emilio
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Correct way to build style bindings on GNU/Linux ARMv7?

[Ralph Giles]

If you can install a new-enough (4.0.1 worked last I checked, but 5.0.1 is
better) clang and llvm development system packages, those should let the
build complete.

If your distro doesn't provide a new-enough toolchain you'll have to
compile one. Set LLVM_CONFIG in the environment to point to your
llvm-config executable if it's not in path.

We don't build a clang package in automation for arm hosts, so there isn't
one to download. If this is to be a regular thing, It should be
straightforward to add one.

HTH,
 -r

On Wed, Feb 7, 2018 at 9:04 AM, Henri Sivonen  wrote:

> mach bootstrap doesn't appear to download a bindgen-compatible clang
> on an ARMv7 GNU/Linux host.
>
> mach build then complains about not being able to generate the stylo
> bindings.
>
> As I understand it, --disable-stylo-build-bindgen should be OK if one
> isn't modifying stylo, but building with that flag fails:
> 12:02.52 error[E0609]: no field `mBoolFlags` on type `&'ln
> gecko_bindings::structs::root::nsINode`
> 12:02.53-->
> /var/host/media/removable/gecko/gecko/mozilla-central-
> ea00596eb02e/servo/components/style/gecko/wrapper.rs:200:18
> 12:02.53 |
> 12:02.53 200 | (self.0).mBoolFlags
> 12:02.53 |  ^^
>
> What's the correct way to build m-c, the stylo bindings in particular,
> on ARMv7+NEON GNU/Linux?
>
> (My goal is to run XPCOM string gtest microbenchmarks in the hope that
> they are representative of Android ARMv7+NEON.)
>
> --
> Henri Sivonen
> hsivo...@hsivonen.fi
> https://hsivonen.fi/
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: MinGW Target on TaskCluster

[Steve Fink]

On 2/6/18 6:27 PM, Tom Ritter wrote:

But when it comes to the header case mismatch issue, we could automate this.
Would it be possible for us to write some code to automatically detect these 
case
discrepancies and automatically land corrections? Where would be the right place
for something like that to live?

I'd be happy to build something that does this. I don't know what's
possible or where it should live though. It's probably easy for me to
add it to the lint job, wherever that is.  I might be able to
integrate it into the new MozReview Static Analysis thing. I don't
know if it's possible, or how, to automatically land corrections* but
maybe?



This came up in a less pressing situation recently within the js/src 
tree, where we were thinking that the nicest way for this to work would 
be to have some limited pre-push lint checks. In our case, it could be 
easily restricted to a particular portion of the tree. I don't know if 
it would be fast enough to not add friction if it had to check any 
source file anywhere in the tree, but it seems like the nicest developer 
experience -- you wouldn't be bothered by it until you tried to land, 
and then an opt-out pre-push hook would tell you that you're going to 
break something. There has been talk of hooking up mozlint in this way, 
so that might be the place to look if you're thinking of setting it up. 
I'm not sure what the story there is for a git workflow, but at least 
for mercurial it would seem to make sense to have the hooks installed 
via mach bootstrap / mach mercurial-setup.


The new phabricator workflow may have a place for this sort of thing as 
well?



___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Correct way to build style bindings on GNU/Linux ARMv7?

[Henri Sivonen]

mach bootstrap doesn't appear to download a bindgen-compatible clang
on an ARMv7 GNU/Linux host.

mach build then complains about not being able to generate the stylo bindings.

As I understand it, --disable-stylo-build-bindgen should be OK if one
isn't modifying stylo, but building with that flag fails:
12:02.52 error[E0609]: no field `mBoolFlags` on type `&'ln
gecko_bindings::structs::root::nsINode`
12:02.53-->
/var/host/media/removable/gecko/gecko/mozilla-central-ea00596eb02e/servo/components/style/gecko/wrapper.rs:200:18
12:02.53 |
12:02.53 200 | (self.0).mBoolFlags
12:02.53 |  ^^

What's the correct way to build m-c, the stylo bindings in particular,
on ARMv7+NEON GNU/Linux?

(My goal is to run XPCOM string gtest microbenchmarks in the hope that
they are representative of Android ARMv7+NEON.)

-- 
Henri Sivonen
hsivo...@hsivonen.fi
https://hsivonen.fi/
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform