date:20240506

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
> >
> > From: Brit Chesley 
> >
> > Including the SpiHc drivers in MdeModulePkg.dsc
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 177128bdfd3e..a1c8e2f90524 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -290,6 +290,8 @@ [Components]
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> > nf
> >MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
> >MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
> > +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcDxe.inf
> > +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcSmm.inf
> >
> >MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> >MdeModulePkg/Core/Pei/PeiMain.inf
> > --
> > 2.42.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118629): https://edk2.groups.io/g/devel/message/118629
Mute This Topic: https://groups.io/mt/105953681/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
> >
> > From: Brit Chesley 
> >
> > Including the SpiBus drivers in MdeModulePkg.dsc
> >
> > Platform Initialization spec 1.7 volume 5 section 18.1.6
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 6bed9205ea69..33d6f4a1f6a6 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -287,6 +287,8 @@ [Components]
> >
> > MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> > eviceDxe.inf
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.inf
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> > nf
> > +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
> > +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
> >
> >MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> >MdeModulePkg/Core/Pei/PeiMain.inf
> > --
> > 2.42.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118628): https://edk2.groups.io/g/devel/message/118628
Mute This Topic: https://groups.io/mt/105953680/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:08
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
lib
> instance
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
> > lib instance
> >
> > From: Brit Chesley 
> >
> > Adding NULL SpiHcPlatformLib instance. This library is responsible for
> > handling the low level details of the SPI host controller. Since this is
> > platform specific this library will be dependent on OEM SPI
> > implementation. The SPI host controller layer will utilize this library
> > for SPI bus transactions.
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dec |   5 +
> >  MdeModulePkg/MdeModulePkg.dsc |   2 +
> >  .../BaseSpiHcPlatformLibNull.inf  |  33 
> >  .../Include/Library/SpiHcPlatformLib.h| 148 ++
> >  .../BaseSpiHcPlatformLibNull.c| 145
> +
> >  .../BaseSpiHcPlatformLibNull.uni  |  11 ++
> >  6 files changed, 344 insertions(+)
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > inf
> >  create mode 100644 MdeModulePkg/Include/Library/SpiHcPlatformLib.h
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > c
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > uni
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 085370eae41a..8a3bcb9aded1 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -169,6 +169,11 @@ [LibraryClasses]
> >#
> >ImagePropertiesRecordLib|Include/Library/ImagePropertiesRecordLib.h
> >
> > +  ##  @libraryclass   Platform SPI Host Controller library which
provides
> low-
> > level
> > +  #   control over the SPI hardware
> > +  #
> > +  SpiHcPlatformLib|Include/Library/SpiHcPlatformLib.h
> > +
> >  [Guids]
> >## MdeModule package token space guid
> ># Include/Guid/MdeModulePkgTokenSpace.h
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 33d6f4a1f6a6..177128bdfd3e 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -107,6 +107,7 @@ [LibraryClasses]
> >
> > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> > ckMemoryLibNull.inf
> >
> > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseV
> > ariableFlashInfoLib.inf
> >
> > IpmiCommandLib|MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIp
> > miCommandLibNull.inf
> > +
> > SpiHcPlatformLib|MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpi
> > HcPlatformLibNull.inf
> >
> >  [LibraryClasses.EBC.PEIM]
> >IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf
> > @@ -528,6 +529,7 @@ [Components.IA32, Components.X64]
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.i
> > nf
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.in
> > f
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys
> > TLib.inf
> > +
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > inf
> >
> >  [Components.X64]
> >MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> > diff --git
> > a/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > new file mode 100644
> > index ..805f50b89565
> > --- /dev/null
> > +++
> > b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > @@ -0,0 +1,33 @@
> > +## @file
> > +#  NULL library for platform SPI Host controller, which should be
provided
> > +#  by the OEM.
> > +#
> > +#  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.

> > +#
> > +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +##
> > +[Defines]
> > +  INF_VERSION   = 1.27
> > +  BASE_NAME = BaseSpiHcPlatformLibNull
> > +  FILE_GUID =
> 3C230948-6DF5-4802-8177-967A190579CF
> > +  MODULE_TYPE   = BASE
> > +  VERSION_STRING= 0.1
> > +  PI_SPECIFICATION_VERSION  = 0x0001000A
> > +  LIBRARY_CLASS

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread Xianglei Cai

Thanks Liming. The patch already merged: MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error · tianocore/edk2@c12bbc1 
(github.com)

From: gaoliming 
Sent: Tuesday, May 7, 2024 9:27 AM
To: devel@edk2.groups.io; Cai, Xianglei ; Shih, More 

Cc: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny 
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

Yes. I just add PUSH label. If it passes CI, it will be merged.

发件人: devel@edk2.groups.io 
mailto:devel@edk2.groups.io>> 代表 Xianglei Cai
发送时间: 2024年5月7日 9:24
收件人: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
Shih, More mailto:more.s...@intel.com>>; 
devel@edk2.groups.io
抄送: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

Hi Liming,

I create one pull request: MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error by Xianglei-Cai · Pull Request #5631 · tianocore/edk2 
(github.com).
Is it helpful for merge the change?

Thanks,
Xianglei

From: gaoliming mailto:gaolim...@byosoft.com.cn>>
Sent: Tuesday, May 7, 2024 9:12 AM
To: Shih, More mailto:more.s...@intel.com>>; Cai, Xianglei 
mailto:xianglei@intel.com>>; 
devel@edk2.groups.io
Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

I will merge it this week.

发件人: Shih, More mailto:more.s...@intel.com>>
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei mailto:xianglei@intel.com>>; 
gaoliming mailto:gaolim...@byosoft.com.cn>>; 
devel@edk2.groups.io
抄送: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

Hi Gaoliming,

Could you help push the PR ?

BR,
More Shih

From: Cai, Xianglei mailto:xianglei@intel.com>>
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
devel@edk2.groups.io 
mailto:devel@edk2.groups.io>>
Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>; Shih, More 
mailto:more.s...@intel.com>>
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

I have no access to push PR. But I tried with my personal fork, it can pass CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn>>
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io; Cai, Xianglei 
mailto:xianglei@intel.com>>
Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>; Shih, More 
mailto:more.s...@intel.com>>
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
> mailto:devel@edk2.groups.io>> 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
> devel@edk2.groups.io
> 抄送: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, 
> Krzysztof
> mailto:krzysztof.lewandow...@intel.com>>; 
> Huang, Jenny
> mailto:jenny.hu...@intel.com>>; Shih, More 
> mailto:more.s...@intel.com>>
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
>
> Hi @gaoliming
>
> Could you provide the eta when the patch can be merged?
>
> Thanks,
> Xianglei
>
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
> devel@edk2.groups.io
> Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, 
> Krzysztof
> mailto:krzysztof.lewandow...@intel.com>>; 
> Huang, Jenny
> mailto:jenny.hu...@intel.com>>; Shih, More 
> mailto:more.s...@intel.com>>
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
>
> Hi Liming,
>
> Could you help pick the change to the master branch?
>
> Thanks,
> Xianglei
>
> -Original Message-
> From: gaoliming

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li

Hi Ard,

Thanks,
Chao
On 2024/5/6 18:24, Ard Biesheuvel wrote:

On Mon, 6 May 2024 at 12:02, Chao Li wrote:

Hi Gerd,

Thanks,
Chao
On 2024/3/19 16:03, Gerd Hoffmann wrote:

Hi,

I can't tell the implementation scheme of the current lib and existing
lib implementation scheme which one is better, Could you give we some
advice?

I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as
it is not really loongarch-specific.

If you want try switch aarch64 to use the same code that'll be great,
but sorting that out later is also fine with me.

If you think this design is looks better, then I'm prepare to commit this
change under the OvmfPkg/Library as a public library. And I will enable it
in aarch64 after merging this change, because I think it may be tweaked and
validated in aarch64 for many platforms. Do you think that is good?

The VirtNorFlashDxe is optimized for qemu-emulated pflash. It tries to
avoid switching between read and write mode much, because that operation
has a significant overhead in virtualization. So it's really only used
by ArmVirtPkg and not lots of other arm platforms.

I'm moving the ARM version of the library to OvmfPkg and adding the set PCD
method, I have verified successfully on ArmVirtQemu.dsc(both -bios and pflash),
but I found that the ArmVirtQemuKernel.dsc also depends this library, so what's
the difference between the two platforms?

When I try to verify on ArmVirtQemuKernel.dsc that it works based on -bios option, I use the command line
"qemu-system-aarch64 -M virt -cpu cortex-a57 -bios LA_Virt_FW/AARCH64/QEMU_EFI.fd -net none -serial
stdio -hdb /home/lichao/Software/Qemu/SctPkg/share.imag -device ramfb -device nec-usb-xhci -device usb-mouse
-device usb-kbd", and it tells me "Could not open option rom 'vgabios-ramfb.bin': No such file or
directory", I tried removing the option "-device ramfb", it looks like can't work.

How does ArmVirtQemuKernel.dsc work?

It uses the -kernel QEMU command line argument, not the -bios one.

This uses the Linux/arm64 kernel boot protocol (and runs the firmware
entirely from RAM) rather than booting from NOR flash.

Alright, I got it.

Does this mean that after this change, I just verify that the -kernel
command line can boot the OS and that it can load/store some variables
via the Linux OS?

If so, I have some plans:

1. Port the ARM version to OvmfPkg and add the setting PCD method. *Done*.

2. Enable the new library on ArmVirtQemu.dsc and remove the hardcode in
INC file, verify this platform. *Done*.

3. Enable the new library on ArmVirtQemuKernel.dsc and verify this
platform. *Just verfiy booting OS and load/store some variables via
Linux kernel. In progress.*

4. Remove the ARM NorFlashQemuLib. *Pending.*

Is the plans mentioned above possible?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118625): https://edk2.groups.io/g/devel/message/118625
Mute This Topic: https://groups.io/mt/104859896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/3] TCG_Sp800_155_PlatformId_Event3 support

2024-05-06 Thread Yao, Jiewen

Merged https://github.com/tianocore/edk2/pull/5628

> -Original Message-
> From: Dionna Glaze 
> Sent: Tuesday, May 7, 2024 2:08 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Kinney, Michael D
> ; Liming Gao ; Liu,
> Zhiguang ; Yao, Jiewen ;
> Kumar, Rahul R ; Ard Biesheuvel
> ; Gerd Hoffmann 
> Subject: [PATCH v4 0/3] TCG_Sp800_155_PlatformId_Event3 support
> 
> In December 2023, the TCG published the PC Client Platform Firmware
> Profile version 1.06 revision 52. This revision includes a new event
> type for NIST SP 800-155 recommended signed BIOS reference measurements.
> The new type allows for the event log auditor to find local or remote
> copies of the signed reference measurements.
> 
> Supporting this new event type eases the process of distributing signed
> reference measurements since the machine can now simply report where
> they can be found in a standard way.
> 
> Changes since v3:
>   - Fixed build error from 1 too many ')'s.
>   - Fixed formatting for uncrustify.
> Changes since v2:
>   - Removed errant spacing.
> Changes since v1:
>   - MdePkg defines TCG_Sp800_155_PlatformId_Event3 instead of adding a
> comment about Event3 to Event2.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jiewen Yao 
> Cc: Rahul Kumar 
> Cc: Ard Biesheuvel 
> Cc: Gerd Hoffmann 
> Reviewed-by: Jiewen Yao 
> 
> Dionna Glaze (3):
>   MdePkg: Add TcgSp800155Event3 type info
>   SecurityPkg: Recognize sp800155Event3 event
>   OvmfPkg: Add sp800155Event3 support
> 
>  .../IndustryStandard/UefiTcgPlatform.h| 38 ++-
>  OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 15 +---
>  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 15 +---
>  3 files changed, 57 insertions(+), 11 deletions(-)
> 
> --
> 2.45.0.rc1.225.g2a3ae87e7f-goog


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118624): https://edk2.groups.io/g/devel/message/118624
Mute This Topic: https://groups.io/mt/105945150/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

Yes. I just add PUSH label. If it passes CI, it will be merged. 

 

发件人: devel@edk2.groups.io  代表 Xianglei Cai
发送时间: 2024年5月7日 9:24
收件人: gaoliming ; Shih, More ; 
devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny 
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

 

Hi Liming,

 

I create one pull request: MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error by Xianglei-Cai · Pull Request #5631 · tianocore/edk2 
(github.com)  .

Is it helpful for merge the change?

 

Thanks,

Xianglei

 

From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Tuesday, May 7, 2024 9:12 AM
To: Shih, More mailto:more.s...@intel.com> >; Cai, 
Xianglei mailto:xianglei@intel.com> >; 
devel@edk2.groups.io  
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

 

I will merge it this week. 

 

发件人: Shih, More mailto:more.s...@intel.com> > 
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei mailto:xianglei@intel.com> >; 
gaoliming mailto:gaolim...@byosoft.com.cn> >; 
devel@edk2.groups.io  
抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

 

Hi Gaoliming,

 

Could you help push the PR ?

 

BR,

More Shih

  _  

From: Cai, Xianglei mailto:xianglei@intel.com> >
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error 

 

I have no access to push PR. But I tried with my personal fork, it can pass CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io  ; Cai, Xianglei 
mailto:xianglei@intel.com> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io   
> mailto:devel@edk2.groups.io> > 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
> devel@edk2.groups.io  
> 抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi @gaoliming
> 
> Could you provide the eta when the patch can be merged?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
> devel@edk2.groups.io  
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi Liming,
> 
> Could you help pick the change to the master branch?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: gaoliming mailto:gaolim...@byosoft.com.cn> >
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io  ; Cai, Xianglei 
> mailto:xianglei@intel.com> >
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Reviewed-by: Liming Gao   >
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io   
> > mailto:devel@edk2.groups.io>

Re: [edk2-devel] [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

2024-05-06 Thread Xianglei Cai

Hi Liming,

I create one pull request: https://github.com/tianocore/edk2/pull/5630.
Is it helpful for merge the change?

Thanks,
Xianglei

-Original Message-
From: Cai, Xianglei 
Sent: Thursday, April 25, 2024 5:59 PM
To: gaoliming ; devel@edk2.groups.io
Cc: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny ; Shih, 
More ; Chiu, Ian 
Subject: RE: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

Hi @gaoliming,

Could you provide the eta when the patch can be merged?

Thanks,
Xianglei

-Original Message-
From: Cai, Xianglei
Sent: Thursday, April 18, 2024 5:00 PM
To: gaoliming ; devel@edk2.groups.io
Cc: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny ; Shih, 
More ; Chiu, Ian 
Subject: RE: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

Hi Liming,

Could you help pick the change to master branch?

Thanks,
Xianglei

-Original Message-
From: gaoliming 
Sent: Monday, April 15, 2024 2:36 PM
To: Cai, Xianglei ; devel@edk2.groups.io
Cc: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny ; Shih, 
More ; Chiu, Ian 
Subject: 回复: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Xianglei Cai 
> 发送时间: 2024年4月15日 14:34
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ; 
> Liming Gao ; Krzysztof Lewandowski 
> ; Jenny Huang 
> ; More Shih ; Ian Chiu 
> 
> 主题: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of 
> HCRST
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4727
> 
> Recently some of XHCI host controllers require to have extra 1ms delay 
> before accessing any MMIO register during reset. PHY transition from
> P3 to P0 can take around 1.3ms and the xHCI reset can take around 
> 1.5ms.
> Add PCD to control the delay, the default is 2 ms.
> 
> Cc: Ray Ni   
> Cc: Liming Gao   
> Cc: Krzysztof Lewandowski
> Cc: Jenny Huang  
> Cc: More Shih
> Cc: Ian Chiu 
> Signed-off-by: Xianglei Cai 
> Reviewed-by: Krzysztof Lewandowski 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h  | 1 +
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 4 
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 2 +-
>  MdeModulePkg/MdeModulePkg.dec| 5 +
>  4 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> index 44016758724c..c9a12095c29e 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> @@ -28,6 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent 
> #include   #include 
>   #include 
> +#include 
> 
>  #include 
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> index 18ef87916ae4..e6c1ac8a6346 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> @@ -56,6 +56,7 @@
>DebugLib
>ReportStatusCodeLib
>TimerLib
> +  PcdLib
> 
>  [Guids]
>gEfiEventExitBootServicesGuid ##
> SOMETIMES_CONSUMES ## Event
> @@ -64,6 +65,9 @@
>gEfiPciIoProtocolGuid ## TO_START
>gEfiUsb2HcProtocolGuid## BY_START
> 
> +[Pcd]
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset  ##
> CONSUMES
> +
>  # [Event]
>  # EVENT_TYPE_PERIODIC_TIMER   ## CONSUMES
>  #
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> index 40f2f1f22766..525942a167b0 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> @@ -864,7 +864,7 @@ XhcResetHC (
>  // Otherwise there may have the timeout case happened.
>  // The below is a workaround to solve such problem.
>  //
> -gBS->Stall (XHC_1_MILLISECOND);
> +gBS->Stall (PcdGet16 (PcdDelayXhciHCReset));
>  Status = XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET, 
> XHC_USBCMD_RESET, FALSE, Timeout);
> 
>  if (!EFI_ERROR (Status)) {
> diff --git a/MdeModulePkg/MdeModulePkg.dec 
> b/MdeModulePkg/MdeModulePkg.dec index a91058e5b5df..d9e2e724df9e
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1148,6 +1148,11 @@
># @Prompt Enable large address image loading.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdImageLargeAddressLoad|TRUE|BOO
> LEAN|0x30001059
> 
> +  ## Indicates time delay for XHCI registers access after it issues
HCRST.
> +  # Default is 2000, it represent delay is 2 ms.
> +  # @Prompt Delay access XHCI register after it issues HCRST (us)
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000|UINT16|0x3
> 0001060
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>## Dynamic type PCD can be registered callback function for Pcd 
> setting action.
>#  PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum 
> number of callback function
> --
> 2.42.0.windows.2





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:

Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

2024-05-06 Thread Xianglei Cai

Hi Liming,

I create one pull request: MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error by Xianglei-Cai · Pull Request #5631 · tianocore/edk2 
(github.com).
Is it helpful for merge the change?

Thanks,
Xianglei

From: gaoliming 
Sent: Tuesday, May 7, 2024 9:12 AM
To: Shih, More ; Cai, Xianglei ; 
devel@edk2.groups.io
Cc: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny 
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

I will merge it this week.

发件人: Shih, More mailto:more.s...@intel.com>>
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei mailto:xianglei@intel.com>>; 
gaoliming mailto:gaolim...@byosoft.com.cn>>; 
devel@edk2.groups.io
抄送: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

Hi Gaoliming,

Could you help push the PR ?

BR,
More Shih

From: Cai, Xianglei mailto:xianglei@intel.com>>
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
devel@edk2.groups.io 
mailto:devel@edk2.groups.io>>
Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>; Shih, More 
mailto:more.s...@intel.com>>
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

I have no access to push PR. But I tried with my personal fork, it can pass CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn>>
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io; Cai, Xianglei 
mailto:xianglei@intel.com>>
Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com>>; 
Huang, Jenny mailto:jenny.hu...@intel.com>>; Shih, More 
mailto:more.s...@intel.com>>
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
> mailto:devel@edk2.groups.io>> 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
> devel@edk2.groups.io
> 抄送: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, 
> Krzysztof
> mailto:krzysztof.lewandow...@intel.com>>; 
> Huang, Jenny
> mailto:jenny.hu...@intel.com>>; Shih, More 
> mailto:more.s...@intel.com>>
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
>
> Hi @gaoliming
>
> Could you provide the eta when the patch can be merged?
>
> Thanks,
> Xianglei
>
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn>>; 
> devel@edk2.groups.io
> Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, 
> Krzysztof
> mailto:krzysztof.lewandow...@intel.com>>; 
> Huang, Jenny
> mailto:jenny.hu...@intel.com>>; Shih, More 
> mailto:more.s...@intel.com>>
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
>
> Hi Liming,
>
> Could you help pick the change to the master branch?
>
> Thanks,
> Xianglei
>
> -Original Message-
> From: gaoliming mailto:gaolim...@byosoft.com.cn>>
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io; Cai, Xianglei 
> mailto:xianglei@intel.com>>
> Cc: Ni, Ray mailto:ray...@intel.com>>; Lewandowski, 
> Krzysztof
> mailto:krzysztof.lewandow...@intel.com>>; 
> Huang, Jenny
> mailto:jenny.hu...@intel.com>>; Shih, More 
> mailto:more.s...@intel.com>>
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
>
> Reviewed-by: Liming Gao 
> mailto:gaolim...@byosoft.com.cn>>
>
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 
> > mailto:devel@edk2.groups.io>> 代表 Xianglei
> Cai
> > 发送时间: 2024年4月15日 14:55
> > 收件人: devel@edk2.groups.io
> > 抄送: Xianglei Cai mailto:xianglei@intel.com>>; 
> > Ray Ni
> > mailto:ray...@intel.com>>; Liming Gao 
> > mailto:gaolim...@byosoft.com.cn>>; Krzysztof
> > Lewandowski 
> > mailto:krzysztof.lewandow...@intel.com>>; 
> > Jenny Huang
> > mailto:jenny.hu...@intel.com>>; More Shih 
> > mailto:more.s...@intel.com>>
> > 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint
> > while USB Transaction error
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4556
> >
> > Based on XHCI spec 4.8.3, software should do the

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

I will merge it this week. 

 

发件人: Shih, More  
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei ; gaoliming
; devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof
; Huang, Jenny 
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint
while USB Transaction error

 

Hi Gaoliming,

 

Could you help push the PR ?

 

BR,

More Shih

  _  

From: Cai, Xianglei mailto:xianglei@intel.com>
>
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn> >;
devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
endpoint while USB Transaction error 

 

I have no access to push PR. But I tried with my personal fork, it can pass
CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn>
> 
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io  ; Cai, Xianglei
mailto:xianglei@intel.com> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
endpoint while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> > 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.
cn> >; devel@edk2.groups.io  
> 抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi @gaoliming
> 
> Could you provide the eta when the patch can be merged?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn>
>; devel@edk2.groups.io  
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi Liming,
> 
> Could you help pick the change to the master branch?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: gaoliming mailto:gaolim...@byosoft.com.cn> >
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io  ; Cai, Xianglei
mailto:xianglei@intel.com> >
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Reviewed-by: Liming Gao mailto:gaolim...@byosoft.com.cn> >
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io   mailto:devel@edk2.groups.io> > 代表 Xianglei
> Cai
> > 发送时间: 2024年4月15日 14:55
> > 收件人: devel@edk2.groups.io  
> > 抄送: Xianglei Cai mailto:xianglei@intel.com> >; Ray Ni 
> > mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Krzysztof 
> > Lewandowski mailto:krzysztof.lewandow...@intel.com> >; Jenny Huang 
> > mailto:jenny.hu...@intel.com> >; More Shih
mailto:more.s...@intel.com> >
> > 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint
> > while USB Transaction error
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4556
> >
> > Based on XHCI spec 4.8.3, software should do the reset endpoint 
> > while USB Transaction occur.
> > Add the error code for USB Transaction error since UEFI spec don't 
> > have the related definition.
> >
> > Cc: Ray Ni  mailto:ray...@intel.com>
>
> > Cc: Liming Gao  mailto:gaolim...@byosoft.com.cn> >
> > Cc: Krzysztof Lewandowski   
> > Cc: Jenny Huang mailto:jenny.hu...@intel.com> >
> > Cc: More Shih   mailto:more.s...@intel.com> >
> > Signed-off-by: Xianglei Cai mailto:xianglei@intel.com> >
> > Reviewed-by: Krzysztof Lewandowski mailto:krzysztof.lewandow...@intel.com> >
> > ---
> >  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  | 5 -
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 - 
> > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++
> >  3

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, May 6, 2024 #cal-notice

2024-05-06 Thread Group Notification

*Tools, CI, Code base construction meeting series*

*When:*
Monday, May 6, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2159790 )

*Description:*

TianoCore community,

Microsoft and Intel will be hosting a series of open meetings to discuss build, 
CI, tools, and other related topics. If you are interested, have ideas/opinions 
please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft 
Teams.

MS Teams Link in following discussion: * 
https://github.com/tianocore/edk2/discussions/2614

Anyone is welcome to join.

* tianocore/edk2: EDK II (github.com)
* tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module 
(github.com) https://github.com/tianocore/edk2-basetools
* tianocore/edk2-pytool-extensions: Extensions to the edk2 build system 
allowing for a more robust and plugin based build system and tool execution 
environment (github.com) https://github.com/tianocore/edk2-pytool-extensions
* tianocore/edk2-pytool-library: Python library package that supports UEFI 
development (github.com) https://github.com/tianocore/edk2-pytool-library

MS Teams Browser Clients * 
https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118617): https://edk2.groups.io/g/devel/message/118617
Mute This Topic: https://groups.io/mt/105950660/21656
Mute #cal-notice:https://edk2.groups.io/g/devel/mutehashtag/cal-notice
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, May 6, 2024 #cal-reminder

2024-05-06 Thread Group Notification

*Reminder: Tools, CI, Code base construction meeting series*

*When:*
Monday, May 6, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles

*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d

View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2159790 )

*Description:*

TianoCore community,

Microsoft and Intel will be hosting a series of open meetings to discuss build, 
CI, tools, and other related topics. If you are interested, have ideas/opinions 
please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft 
Teams.

MS Teams Link in following discussion: * 
https://github.com/tianocore/edk2/discussions/2614

Anyone is welcome to join.

* tianocore/edk2: EDK II (github.com)
* tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module 
(github.com) https://github.com/tianocore/edk2-basetools
* tianocore/edk2-pytool-extensions: Extensions to the edk2 build system 
allowing for a more robust and plugin based build system and tool execution 
environment (github.com) https://github.com/tianocore/edk2-pytool-extensions
* tianocore/edk2-pytool-library: Python library package that supports UEFI 
development (github.com) https://github.com/tianocore/edk2-pytool-library

MS Teams Browser Clients * 
https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118616): https://edk2.groups.io/g/devel/message/118616
Mute This Topic: https://groups.io/mt/105931057/21656
Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Assistance Needed: ArmVirtPkg

2024-05-06 Thread Doug Flick via groups.io

All,

In order to patch Tianocore Bugzilla issues and CVEs:
 4541 – Bug 08 - edk2/NetworkPkg: Predictable TCP ISNs 
(tianocore.org)
and
4542 – Bug 09 - edk2/NetworkPkg: Use of a Weak PseudoRandom Number Generator 
(tianocore.org)

I've added as a dependency Hash2CryptoDxe and RngDxe lib to NetworkPkg. I've 
been able to add the relevant libraries to the DSCs of OvmfPkg and EmulatorPkg 
however I'm seeing odd behavior with ArmVirtPkg.

Would someone more knowledgeable with ArmVirtPkg take a look this PR.

PixieFail #8 and #9 TCBZ4541 and TCBZ4542 by Flickdm · Pull Request #5582 · 
tianocore/edk2 (github.com)

The issue was introduced in the commit "ArmVirtPkg: : Add RngDxe to 
ArmVirtPkg"

Right now PlatformCI_ArmVirtPkg_Ubuntu_GCC5_PR is crashing with

INFO - Synchronous Exception at 0x7FBE35BC
INFO - PC 0x7FBE35BC (0x7FBE+0x35BC) [ 0] RngDxe.dll
INFO - PC 0x7FBE2430 (0x7FBE+0x2430) [ 0] RngDxe.dll
INFO - PC 0x7FBE2E14 (0x7FBE+0x2E14) [ 0] RngDxe.dll
INFO - PC 0x4748CCFC (0x47485000+0x7CFC) [ 1] DxeCore.dll
INFO - PC 0x4749A6C4 (0x47485000+0x000156C4) [ 1] DxeCore.dll
INFO - PC 0x474904F0 (0x47485000+0xB4F0) [ 1] DxeCore.dll
INFO -
INFO - [ 0] 
/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe/DEBUG/RngDxe.dll
INFO - [ 1] 
/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/MdeModulePkg/Core/Dxe/DxeMain/DEBUG/DxeCore.dll
INFO -
INFO -   X0 0x8000   X1 0x   X2 0x  
 X3 0x
INFO -   X4 0x   X5 0x   X6 0x  
 X7 0x
INFO -   X8 0x7008   X9 0x0007  X10 0x7EA47000  
X11 0x7EA54FFF
INFO -  X12 0x  X13 0x0008  X14 0x  
X15 0x
INFO -  X16 0x47484D70  X17 0x474CC000  X18 0x  
X19 0x7FFD0018
INFO -  X20 0x0001  X21 0x7EA55D98  X22 0x7FBE5000  
X23 0x0030
INFO -  X24 0x  X25 0x7FBE5000  X26 0x  
X27 0x474B
INFO -  X28 0x0001   FP 0x47484C50   LR 0x7FBE2430
INFO -
INFO -   V0 0x    V1 0x 

INFO -   V2 0x    V3 0x 

INFO -   V4 0x    V5 0x 

INFO -   V6 0x    V7 0x 

INFO -   V8 0x    V9 0x 

INFO -  V10 0x   V11 0x 

INFO -  V12 0x   V13 0x 

INFO -  V14 0x   V15 0x 

INFO -  V16 0x   V17 0x 

INFO -  V18 0x   V19 0x 

INFO -  V20 0x   V21 0x 

INFO -  V22 0x   V23 0x 

INFO -  V24 0x   V25 0x 

INFO -  V26 0x   V27 0x 

INFO -  V28 0x   V29 0x 

INFO -  V30 0x   V31 0x 



Thanks!


  *
Doug



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118615): https://edk2.groups.io/g/devel/message/118615
Mute This Topic: https://groups.io/mt/105949609/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses

2024-05-06 Thread Chiu, Chasel



Reviewed-by: Chasel Chiu 

Thanks,
Chasel


> -Original Message-
> From: Desimone, Nathaniel L 
> Sent: Friday, February 9, 2024 2:48 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Liming Gao
> ; Dong, Eric 
> Subject: [PATCH v1] MinPlatformPkg: Add MM_STANDALONE LibraryClasses
> 
> Adds MM_STANDALONE instances for core LibraryClasses to facilitate using
> Standalone MM in platform code.
> 
> Cc: Chasel Chiu 
> Cc: Liming Gao 
> Cc: Eric Dong 
> Signed-off-by: Nate DeSimone 
> ---
>  .../Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc   | 11 +++
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc  |  9 -
>  2 files changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> index b469938823..1e86de282f 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> @@ -97,6 +97,17 @@
> 
> ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/SmmRe
> portStatusCodeLib.inf
>SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf
> 
> +[LibraryClasses.common.MM_STANDALONE]
> +
> +MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAlloca
> tio
> +nLib/StandaloneMmMemoryAllocationLib.inf
> +
> +MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Standalo
> +neMmServicesTableLib.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +
> +HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLi
> b.in
> +f
> +
> +TimerLib|PcAtChipsetPkg/Library/AcpiTimerLib/StandaloneMmAcpiTimerLib.i
> +nf
> +
> +ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/Standa
> l
> +oneMmReportStatusCodeLib.inf
> +
> +StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoi
> n
> +t/StandaloneMmDriverEntryPoint.inf
> +
> +VariableReadLib|MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMm
> V
> +ariableReadLib.inf
> +
> +VariableWriteLib|MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneM
> +mVariableWriteLib.inf
> +
>  !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable == TRUE
> 
> PerformanceLib|MdeModulePkg/Library/SmmCorePerformanceLib/SmmCorePer
> formanceLib.inf
>  !endif
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 4b295babf5..ecb4d8f65e 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -111,15 +111,6 @@
> 
> TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPoin
> tCheckLib.inf
>TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/SmmTestPointLib.inf
> 
> -[LibraryClasses.common.MM_STANDALONE]
> -  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> -
> MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocati
> onLib/StandaloneMmMemoryAllocationLib.inf
> -
> MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/Standalon
> eMmServicesTableLib.inf
> -  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> -
> StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoin
> t/StandaloneMmDriverEntryPoint.inf
> -
> VariableReadLib|MinPlatformPkg/Library/SmmVariableReadLib/StandaloneMmV
> ariableReadLib.inf
> -
> VariableWriteLib|MinPlatformPkg/Library/SmmVariableWriteLib/StandaloneMm
> VariableWriteLib.inf
> -
> 
> #
> ##
>  #
>  # Components Section - list of the modules and components that will be
> processed by compilation
> --
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118614): https://edk2.groups.io/g/devel/message/118614
Mute This Topic: https://groups.io/mt/104269623/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v4 3/3] OvmfPkg: Add sp800155Event3 support

The signatures for event2 or event3 are now valid TCG SP800155 event
types. Fixes uncrustify formatting.

Cc: Ard Biesheuvel 
Cc: Jiewen Yao 
Cc: Gerd Hoffmann 

Reviewed-by: Jiewen Yao 
Signed-off-by: Dionna Glaze 
---
 OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c 
b/OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
index 6ca29f5de0..5241f60891 100644
--- a/OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
+++ b/OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
@@ -821,11 +821,16 @@ Is800155Event (
 {
   if TCG_PCR_EVENT2_HDR *)NewEventHdr)->EventType == EV_NO_ACTION) &&
   (NewEventSize >= sizeof (TCG_Sp800_155_PlatformId_Event2)) &&
-  (CompareMem (
- NewEventData,
- TCG_Sp800_155_PlatformId_Event2_SIGNATURE,
- sizeof (TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1
- ) == 0))
+  ((CompareMem (
+  NewEventData,
+  TCG_Sp800_155_PlatformId_Event2_SIGNATURE,
+  sizeof (TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1
+  ) == 0) ||
+   (CompareMem (
+  NewEventData,
+  TCG_Sp800_155_PlatformId_Event3_SIGNATURE,
+  sizeof (TCG_Sp800_155_PlatformId_Event3_SIGNATURE) - 1
+  ) == 0)))
   {
 return TRUE;
   }
-- 
2.45.0.rc1.225.g2a3ae87e7f-goog



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118613): https://edk2.groups.io/g/devel/message/118613
Mute This Topic: https://groups.io/mt/105945155/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v4 2/3] SecurityPkg: Recognize sp800155Event3 event

The signatures for event2 or event3 are now valid TCG SP800155 event
types. Fixes uncrustify formatting.

Cc: Jiewen Yao 
Cc: Rahul Kumar 

Reviewed-by: Jiewen Yao 
Signed-off-by: Dionna Glaze 
---
 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c 
b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
index b8f50e25df..b55b6c12d2 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
@@ -812,11 +812,16 @@ Is800155Event (
 {
   if TCG_PCR_EVENT2_HDR *)NewEventHdr)->EventType == EV_NO_ACTION) &&
   (NewEventSize >= sizeof (TCG_Sp800_155_PlatformId_Event2)) &&
-  (CompareMem (
- NewEventData,
- TCG_Sp800_155_PlatformId_Event2_SIGNATURE,
- sizeof (TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1
- ) == 0))
+  ((CompareMem (
+  NewEventData,
+  TCG_Sp800_155_PlatformId_Event2_SIGNATURE,
+  sizeof (TCG_Sp800_155_PlatformId_Event2_SIGNATURE) - 1
+  ) == 0) ||
+   (CompareMem (
+  NewEventData,
+  TCG_Sp800_155_PlatformId_Event3_SIGNATURE,
+  sizeof (TCG_Sp800_155_PlatformId_Event3_SIGNATURE) - 1
+  ) == 0)))
   {
 return TRUE;
   }
-- 
2.45.0.rc1.225.g2a3ae87e7f-goog



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118612): https://edk2.groups.io/g/devel/message/118612
Mute This Topic: https://groups.io/mt/105945152/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v4 1/3] MdePkg: Add TcgSp800155Event3 type info

TCG PC Client Platform Firmware Profile 1.06 revision 52 of December
2023 added a new event signature and extended information about where a
reference measurement document for the firmware can be found.

Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 

Reviewed-by: Jiewen Yao 
Signed-off-by: Dionna Glaze 
---
 .../IndustryStandard/UefiTcgPlatform.h| 38 ++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h 
b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
index 61bd4e4667..aaee5d6c88 100644
--- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
+++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
@@ -451,6 +451,7 @@ typedef struct tdTCG_PCClientTaggedEvent {
 
 #define TCG_Sp800_155_PlatformId_Event_SIGNATURE   "SP800-155 Event"
 #define TCG_Sp800_155_PlatformId_Event2_SIGNATURE  "SP800-155 Event2"
+#define TCG_Sp800_155_PlatformId_Event3_SIGNATURE  "SP800-155 Event3"
 
 typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
   UINT8   Signature[16];
@@ -478,9 +479,44 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
   // UINT8   FirmwareManufacturerStr[FirmwareManufacturerStrSize];
   // UINT32  FirmwareManufacturerId;
   // UINT8   FirmwareVersion;
-  // UINT8   FirmwareVersion[FirmwareVersionSize]];
+  // UINT8   FirmwareVersion[FirmwareVersionSize];
 } TCG_Sp800_155_PlatformId_Event2;
 
+typedef struct tdTCG_Sp800_155_PlatformId_Event3 {
+  UINT8   Signature[16];
+  //
+  // Where Vendor ID is an integer defined
+  // at http://www.iana.org/assignments/enterprisenumbers
+  //
+  UINT32  VendorId;
+  //
+  // 16-byte identifier of a given platform's static configuration of code
+  //
+  EFI_GUIDReferenceManifestGuid;
+  // UINT8   PlatformManufacturerStrSize;
+  // UINT8   PlatformManufacturerStr[PlatformManufacturerStrSize];
+  // UINT8   PlatformModelSize;
+  // UINT8   PlatformModel[PlatformModelSize];
+  // UINT8   PlatformVersionSize;
+  // UINT8   PlatformVersion[PlatformVersionSize];
+  // UINT8   PlatformModelSize;
+  // UINT8   PlatformModel[PlatformModelSize];
+  // UINT8   FirmwareManufacturerStrSize;
+  // UINT8   FirmwareManufacturerStr[FirmwareManufacturerStrSize];
+  // UINT32  FirmwareManufacturerId;
+  // UINT8   FirmwareVersion;
+  // UINT8   FirmwareVersion[FirmwareVersionSize];
+  //
+  // Below structure is newly added in TCG_Sp800_155_PlatformId_Event3
+  //
+  // UINT32  RimLocatorType;
+  // UINT32  RimLocatorLength;
+  // UINT8   RimLocator[RimLocatorLength];
+  // UINT32  PlatformCertLocatorType;
+  // UINT32  PlatformCertLocatorLength;
+  // UINT8   PlatformCertLocator[PlatformCertLocatorLength];
+} TCG_Sp800_155_PlatformId_Event3;
+
 #define TCG_EfiStartupLocalityEvent_SIGNATURE  "StartupLocality"
 
 //
-- 
2.45.0.rc1.225.g2a3ae87e7f-goog



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118611): https://edk2.groups.io/g/devel/message/118611
Mute This Topic: https://groups.io/mt/105945151/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v4 0/3] TCG_Sp800_155_PlatformId_Event3 support

In December 2023, the TCG published the PC Client Platform Firmware
Profile version 1.06 revision 52. This revision includes a new event
type for NIST SP 800-155 recommended signed BIOS reference measurements.
The new type allows for the event log auditor to find local or remote
copies of the signed reference measurements.

Supporting this new event type eases the process of distributing signed
reference measurements since the machine can now simply report where
they can be found in a standard way.

Changes since v3:
  - Fixed build error from 1 too many ')'s.
  - Fixed formatting for uncrustify.
Changes since v2:
  - Removed errant spacing.
Changes since v1:
  - MdePkg defines TCG_Sp800_155_PlatformId_Event3 instead of adding a
comment about Event3 to Event2.

Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 
Cc: Jiewen Yao 
Cc: Rahul Kumar 
Cc: Ard Biesheuvel 
Cc: Gerd Hoffmann 
Reviewed-by: Jiewen Yao 

Dionna Glaze (3):
  MdePkg: Add TcgSp800155Event3 type info
  SecurityPkg: Recognize sp800155Event3 event
  OvmfPkg: Add sp800155Event3 support

 .../IndustryStandard/UefiTcgPlatform.h| 38 ++-
 OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 15 +---
 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 15 +---
 3 files changed, 57 insertions(+), 11 deletions(-)

--
2.45.0.rc1.225.g2a3ae87e7f-goog


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118610): https://edk2.groups.io/g/devel/message/118610
Mute This Topic: https://groups.io/mt/105945150/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/3] TCG_Sp800_155_PlatformId_Event3 support

I had not passed some tests, apologies. I fixed the spacing issue and
build failure with too many )s in
https://github.com/tianocore/edk2/pull/5615. Shall I email a v4?

On Sun, May 5, 2024 at 8:28 PM Yao, Jiewen  wrote:
>
> Hi Dionna
> I tried to create PR but I saw failure - 
> https://github.com/tianocore/edk2/pull/5628
>
> Would you please clarify if you have tested the patch in EDKII CI, before you 
> submit the patch?
>
>
> BTW: I have fixed a typo in the V3 patch. The "Reviewed-By" tag in 1/3 should 
> be "Reviewed-by".
>
> Thank you
> Yao, Jiewen
>
>
>
> > -Original Message-
> > From: Dionna Glaze 
> > Sent: Thursday, May 2, 2024 8:50 AM
> > To: devel@edk2.groups.io
> > Cc: Dionna Glaze ; Kinney, Michael D
> > ; Liming Gao ; Liu,
> > Zhiguang ; Yao, Jiewen ;
> > Kumar, Rahul R ; Ard Biesheuvel
> > ; Gerd Hoffmann 
> > Subject: [PATCH v3 0/3] TCG_Sp800_155_PlatformId_Event3 support
> >
> > In December 2023, the TCG published the PC Client Platform Firmware
> > Profile version 1.06 revision 52. This revision includes a new event
> > type for NIST SP 800-155 recommended signed BIOS reference measurements.
> > The new type allows for the event log auditor to find local or remote
> > copies of the signed reference measurements.
> >
> > Supporting this new event type eases the process of distributing signed
> > reference measurements since the machine can now simply report where
> > they can be found in a standard way.
> >
> > Changes since v2:
> >   - Removed errant spacing.
> > Changes since v1:
> >   - MdePkg defines TCG_Sp800_155_PlatformId_Event3 instead of adding a
> > comment about Event3 to Event2.
> >
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Jiewen Yao 
> > Cc: Rahul Kumar 
> > Cc: Ard Biesheuvel 
> > Cc: Gerd Hoffmann 
> > Reviewed-by: Jiewen Yao 
> >
> > Dionna Glaze (3):
> >   MdePkg: Add TcgSp800155Event3 type info
> >   SecurityPkg: recognize sp800155Event3 event too
> >   OvmfPkg: add sp800155Event3 support
> >
> >  .../IndustryStandard/UefiTcgPlatform.h| 38 ++-
> >  OvmfPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c |  9 -
> >  SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c |  9 -
> >  3 files changed, 51 insertions(+), 5 deletions(-)
> >
> > --
> > 2.45.0.rc0.197.gbae5840b3b-goog



-- 
-Dionna Glaze, PhD, CISSP (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118609): https://edk2.groups.io/g/devel/message/118609
Mute This Topic: https://groups.io/mt/105854725/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

2024-05-06 Thread G Edhaya Chandran

Hi Heinrich,

   The folder structure for edk2-test-rc2_202405 is created:
https://members.uefi.org/wg/utwg/document/folder/128

With Warm Regards,
Edhay


> -Original Message-
> From: Heinrich Schuchardt 
> Sent: Sunday, May 5, 2024 5:22 PM
> To: G Edhaya Chandran 
> Cc: alex_...@phoenix.com; david_wri...@phoenix.com;
> lic...@loongson.cn; Stuart Yoder ;
> devel@edk2.groups.io; gao...@byosoft.com.cn
> Subject: Re: edk2-test Release candidate 2: edk2-test-rc2_202405
>
> On 5/4/24 01:47, G Edhaya Chandran wrote:
> > Hi All,
> > A new release candidate is published after upstreaming Stuart's
> > commits on build cleanup.
> > _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_
> > 
> > The updates since the old tag are the following commits in the patch
> > series:
> > _[PATCH v2 0/4] TCG2 protocol clean up (groups.io)_
> >
>  C0%2
> >
> C0%3A%3Arecentpostdate%2Fsticky%2C%2Cstuart+yoder%2C20%2C2%2C0%
> 2C10555
> > 8005> The release candidate may be used for any further testing.
> > With Warm Regards,
> > Edhay
>
> Hello Edhaya,
>
> I am not allowed to create the folder structure for uploading the test 
> results.
>
> Could you, please, create it and inform us.
>
> Best regards
>
> Heinrich
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118608): https://edk2.groups.io/g/devel/message/118608
Mute This Topic: https://groups.io/mt/105929926/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

Pushed as 0ab97ab

> -Original Message-
> From: Hsueh, DoraX 
> Sent: Monday, May 6, 2024 2:50 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX ; Chaganty, Rangasai V
> ; Chuang, Rosen ;
> Kasbekar, Saloni ; Tang, Haoyu
> ; Desimone, Nathaniel L
> ; Chiu, Chasel 
> Subject: [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install
> Windows11.
> 
> From: DoraX Hsueh 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4665
> 
> 1. Since installing windows does not meet the minimum system requirements,
>Added TPM related code to meet the requirements.
> 2. Support stage 6, add FvAdvancedPreMemory.
> 
> Cc: Sai Chaganty 
> Cc: Rosen Chuang 
> Cc: Saloni Kasbekar 
> Cc: Haoyu Tang 
> Cc: Nate DeSimone 
> Cc: Chasel Chiu 
> Signed-off-by: DoraX Hsueh 
> ---
>  .../Include/Fdf/FlashMapInclude.fdf   | 26 
>  .../AlderlakePRvp/OpenBoardPkg.dsc|  1 +
>  .../AlderlakePRvp/OpenBoardPkg.fdf| 66 +--
>  .../AlderlakePRvp/OpenBoardPkgPcd.dsc | 10 ++-
>  4 files changed, 86 insertions(+), 17 deletions(-)
> 
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> index 03c198c0..3e515d4e 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> @@ -26,27 +26,29 @@ SET 
> gMinPlatformPkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareOffset = 0x000300
>  SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize  = 
> 0x0003  #
>  
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedOffset= 
> 0x000E  # Flash addr (0xFF0E)
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize  = 
> 0x0031  #
> -SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset   = 
> 0x003F  # Flash addr (0xFF40)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize  = 
> 0x002E  #
> +SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset   = 
> 0x003C  # Flash addr (0xFF3C)
>  SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalSize = 
> 0x0036  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset= 
> 0x0075  # Flash addr (0xFF76)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset= 
> 0x0072  # Flash addr (0xFF72)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize  = 
> 0x0009  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset  = 
> 0x007E  # Flash addr (0xFF7F)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset  = 
> 0x007B  # Flash addr (0xFF7B)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootSize= 
> 0x000A  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset= 
> 0x0088  # Flash addr (0xFF86)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset= 
> 0x0085  # Flash addr (0xFF85)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootSize  = 
> 0x0018  #
>  
> -SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset   = 
> 0x00A0  # Flash addr (0xFFA0)
> +SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset   = 
> 0x009D  # Flash addr (0xFF9D)
>  SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesSize = 
> 0x0008  # Keep 0x8 or larger
> -SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset  = 
> 0x00A8  # Flash addr (0xFFA8)
> +SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset  = 
> 0x00A5  # Flash addr (0xFFA5)
>  SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize= 
> 0x0023  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset  = 
> 0x00CB  # Flash addr (0xFFCB)
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize= 
> 0x0004  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset= 
> 0x00CF  # Flash addr (0xFFCF)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset  = 
> 0x00C8  # Flash addr (0xFFC8)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize= 
> 0x0006  #
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset= 
> 0x00CE  # Flash addr (0xFFCE)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize  = 
> 0x000A
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset= 
> 0x00D9  # Flash addr (0xFFD9)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset= 
> 0x00D8  # Flash addr (0xFFD8)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11.

Reviewed-by: Nate DeSimone 

> -Original Message-
> From: Hsueh, DoraX 
> Sent: Monday, May 6, 2024 2:50 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX ; Chaganty, Rangasai V
> ; Chuang, Rosen ;
> Kasbekar, Saloni ; Tang, Haoyu
> ; Desimone, Nathaniel L
> ; Chiu, Chasel 
> Subject: [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install
> Windows11.
> 
> From: DoraX Hsueh 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4665
> 
> 1. Since installing windows does not meet the minimum system requirements,
>Added TPM related code to meet the requirements.
> 2. Support stage 6, add FvAdvancedPreMemory.
> 
> Cc: Sai Chaganty 
> Cc: Rosen Chuang 
> Cc: Saloni Kasbekar 
> Cc: Haoyu Tang 
> Cc: Nate DeSimone 
> Cc: Chasel Chiu 
> Signed-off-by: DoraX Hsueh 
> ---
>  .../Include/Fdf/FlashMapInclude.fdf   | 26 
>  .../AlderlakePRvp/OpenBoardPkg.dsc|  1 +
>  .../AlderlakePRvp/OpenBoardPkg.fdf| 66 +--
>  .../AlderlakePRvp/OpenBoardPkgPcd.dsc | 10 ++-
>  4 files changed, 86 insertions(+), 17 deletions(-)
> 
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> index 03c198c0..3e515d4e 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/FlashMapInclude.fdf
> @@ -26,27 +26,29 @@ SET 
> gMinPlatformPkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareOffset = 0x000300
>  SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize  = 
> 0x0003  #
>  
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedOffset= 
> 0x000E  # Flash addr (0xFF0E)
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize  = 
> 0x0031  #
> -SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset   = 
> 0x003F  # Flash addr (0xFF40)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize  = 
> 0x002E  #
> +SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset   = 
> 0x003C  # Flash addr (0xFF3C)
>  SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalSize = 
> 0x0036  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset= 
> 0x0075  # Flash addr (0xFF76)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset= 
> 0x0072  # Flash addr (0xFF72)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize  = 
> 0x0009  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset  = 
> 0x007E  # Flash addr (0xFF7F)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset  = 
> 0x007B  # Flash addr (0xFF7B)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootSize= 
> 0x000A  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset= 
> 0x0088  # Flash addr (0xFF86)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset= 
> 0x0085  # Flash addr (0xFF85)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootSize  = 
> 0x0018  #
>  
> -SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset   = 
> 0x00A0  # Flash addr (0xFFA0)
> +SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset   = 
> 0x009D  # Flash addr (0xFF9D)
>  SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesSize = 
> 0x0008  # Keep 0x8 or larger
> -SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset  = 
> 0x00A8  # Flash addr (0xFFA8)
> +SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset  = 
> 0x00A5  # Flash addr (0xFFA5)
>  SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize= 
> 0x0023  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset  = 
> 0x00CB  # Flash addr (0xFFCB)
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize= 
> 0x0004  #
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset= 
> 0x00CF  # Flash addr (0xFFCF)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset  = 
> 0x00C8  # Flash addr (0xFFC8)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize= 
> 0x0006  #
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset= 
> 0x00CE  # Flash addr (0xFFCE)
>  SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize  = 
> 0x000A
> -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset= 
> 0x00D9  # Flash addr (0xFFD9)
> +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset= 
> 0x00D8  # Flash addr (0xFFD8)
>  SET

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Update to reference RaptorLakeFspBinPkg FSP

Pushed as 7e51d29

> -Original Message-
> From: Hsueh, DoraX 
> Sent: Monday, May 6, 2024 2:42 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX ; Chaganty, Rangasai V
> ; Chuang, Rosen ;
> Kasbekar, Saloni ; Desimone, Nathaniel L
> 
> Subject: [PATCH] AlderlakeOpenBoardPkg: Update to reference
> RaptorLakeFspBinPkg FSP
> 
> From: DoraX Hsueh 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4771
> 
> Due to AlderLakeFspBinPkg will not be maintained going forward, ADL
> Openboard will reference RaptorLakeFspBinPkg FSP.
> 
> Cc: Sai Chaganty 
> Cc: Rosen Chuang 
> Cc: Saloni Kasbekar 
> Cc: Nate DeSimone 
> Signed-off-by: DoraX Hsueh 
> ---
>  .../Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc  | 2 +-
>  .../Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg  | 2 +-
>  .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 2 +-
>  .../OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf   | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> index ea92ec75..1af1dd5a 100644
> --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> @@ -14,7 +14,7 @@
>DEFINE  PLATFORM_PACKAGE= MinPlatformPkg
>DEFINE  PLATFORM_SI_PACKAGE = AlderlakeSiliconPkg
>DEFINE  PLATFORM_SI_BIN_PACKAGE = AlderlakeSiliconBinPkg
> -  DEFINE  PLATFORM_FSP_BIN_PACKAGE= 
> AlderLakeFspBinPkg/Client/AlderLakeP
> +  DEFINE  PLATFORM_FSP_BIN_PACKAGE= 
> RaptorLakeFspBinPkg/Client/RaptorLakeP
>DEFINE  PLATFORM_BOARD_PACKAGE  = AlderlakeOpenBoardPkg
>DEFINE  BOARD   = AlderlakePRvp
>DEFINE  PROJECT = 
> $(PLATFORM_BOARD_PACKAGE)/$(BOARD)
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> index ae391bec..e74a1a4b 100644
> --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> @@ -26,7 +26,7 @@ TARGET = DEBUG
>  TARGET_SHORT = D
>  PERFORMANCE_BUILD = FALSE
>  FSP_WRAPPER_BUILD = TRUE
> -FSP_BIN_PKG = AlderlakeFspBinPkg/Client/AlderlakeP
> +FSP_BIN_PKG = RaptorLakeFspBinPkg/Client/RaptorLakeP
>  FSP_PKG_NAME = AlderlakeSiliconPkg
>  FSP_BINARY_BUILD = FALSE
>  FSP_TEST_RELEASE = FALSE
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> index abc84057..14da8dd7 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> @@ -64,7 +64,7 @@
>IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
>MinPlatformPkg/MinPlatformPkg.dec
>AlderlakeSiliconPkg/SiPkg.dec
> -  AlderLakeFspBinPkg/Client/AlderLakeP/AlderLakeFspBinPkg.dec
> +  RaptorLakeFspBinPkg/Client/RaptorLakeP/RaptorLakeFspBinPkg.dec
>AlderlakeOpenBoardPkg/OpenBoardPkg.dec
>  
>  [LibraryClasses]
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> index 31c01919..09a17fa7 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> @@ -31,7 +31,7 @@
>UefiCpuPkg/UefiCpuPkg.dec
>IntelFsp2Pkg/IntelFsp2Pkg.dec
>IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> -  AlderLakeFspBinPkg/Client/AlderLakeP/AlderLakeFspBinPkg.dec
> +  RaptorLakeFspBinPkg/Client/RaptorLakeP/RaptorLakeFspBinPkg.dec
>AlderlakeOpenBoardPkg/OpenBoardPkg.dec
>MinPlatformPkg/MinPlatformPkg.dec
>IntelSiliconPkg/IntelSiliconPkg.dec
> -- 
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118605): https://edk2.groups.io/g/devel/message/118605
Mute This Topic: https://groups.io/mt/105936315/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Update to reference RaptorLakeFspBinPkg FSP

Reviewed-by: Nate DeSimone 

> -Original Message-
> From: Hsueh, DoraX 
> Sent: Monday, May 6, 2024 2:42 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX ; Chaganty, Rangasai V
> ; Chuang, Rosen ;
> Kasbekar, Saloni ; Desimone, Nathaniel L
> 
> Subject: [PATCH] AlderlakeOpenBoardPkg: Update to reference
> RaptorLakeFspBinPkg FSP
> 
> From: DoraX Hsueh 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4771
> 
> Due to AlderLakeFspBinPkg will not be maintained going forward, ADL
> Openboard will reference RaptorLakeFspBinPkg FSP.
> 
> Cc: Sai Chaganty 
> Cc: Rosen Chuang 
> Cc: Saloni Kasbekar 
> Cc: Nate DeSimone 
> Signed-off-by: DoraX Hsueh 
> ---
>  .../Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc  | 2 +-
>  .../Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg  | 2 +-
>  .../SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf | 2 +-
>  .../OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf   | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> index ea92ec75..1af1dd5a 100644
> --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc
> @@ -14,7 +14,7 @@
>DEFINE  PLATFORM_PACKAGE= MinPlatformPkg
>DEFINE  PLATFORM_SI_PACKAGE = AlderlakeSiliconPkg
>DEFINE  PLATFORM_SI_BIN_PACKAGE = AlderlakeSiliconBinPkg
> -  DEFINE  PLATFORM_FSP_BIN_PACKAGE= 
> AlderLakeFspBinPkg/Client/AlderLakeP
> +  DEFINE  PLATFORM_FSP_BIN_PACKAGE= 
> RaptorLakeFspBinPkg/Client/RaptorLakeP
>DEFINE  PLATFORM_BOARD_PACKAGE  = AlderlakeOpenBoardPkg
>DEFINE  BOARD   = AlderlakePRvp
>DEFINE  PROJECT = 
> $(PLATFORM_BOARD_PACKAGE)/$(BOARD)
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg 
> b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> index ae391bec..e74a1a4b 100644
> --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/build_config.cfg
> @@ -26,7 +26,7 @@ TARGET = DEBUG
>  TARGET_SHORT = D
>  PERFORMANCE_BUILD = FALSE
>  FSP_WRAPPER_BUILD = TRUE
> -FSP_BIN_PKG = AlderlakeFspBinPkg/Client/AlderlakeP
> +FSP_BIN_PKG = RaptorLakeFspBinPkg/Client/RaptorLakeP
>  FSP_PKG_NAME = AlderlakeSiliconPkg
>  FSP_BINARY_BUILD = FALSE
>  FSP_TEST_RELEASE = FALSE
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> index abc84057..14da8dd7 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf
> @@ -64,7 +64,7 @@
>IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
>MinPlatformPkg/MinPlatformPkg.dec
>AlderlakeSiliconPkg/SiPkg.dec
> -  AlderLakeFspBinPkg/Client/AlderLakeP/AlderLakeFspBinPkg.dec
> +  RaptorLakeFspBinPkg/Client/RaptorLakeP/RaptorLakeFspBinPkg.dec
>AlderlakeOpenBoardPkg/OpenBoardPkg.dec
>  
>  [LibraryClasses]
> diff --git 
> a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
>  
> b/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> index 31c01919..09a17fa7 100644
> --- 
> a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> +++ 
> b/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPlatformInit/OpenBoardPlatformInitPei/OpenBoardPlatformInitPostMem.inf
> @@ -31,7 +31,7 @@
>UefiCpuPkg/UefiCpuPkg.dec
>IntelFsp2Pkg/IntelFsp2Pkg.dec
>IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> -  AlderLakeFspBinPkg/Client/AlderLakeP/AlderLakeFspBinPkg.dec
> +  RaptorLakeFspBinPkg/Client/RaptorLakeP/RaptorLakeFspBinPkg.dec
>AlderlakeOpenBoardPkg/OpenBoardPkg.dec
>MinPlatformPkg/MinPlatformPkg.dec
>IntelSiliconPkg/IntelSiliconPkg.dec
> -- 
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118604): https://edk2.groups.io/g/devel/message/118604
Mute This Topic: https://groups.io/mt/105936315/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On Mon, 6 May 2024 at 17:57, Kinney, Michael D
 wrote:
>
> Hi Ard,
>
> Thais is an attribute of Mergify.  I do not see a way to change that
> behavior.
>
> I do not know if using the GitHub merge capability or other merge services
> provides different behavior here or not.
>
> This specific request is not related to the change to GitHub PRs
> for code review.  There is no intention to change the requirement
> for a maintainer to set the 'push' label and no intention to change
> away from Mergify at this time.
>
> Perhaps we can open your request as an independent request that we
> can find an owner to evaluate options and provide recommendations.
>

Yep that works for me - it is not an urgent issue anyway, just
something I realized while going through the thread.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118603): https://edk2.groups.io/g/devel/message/118603
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney

Hi Ard,

Thais is an attribute of Mergify.  I do not see a way to change that
behavior.

I do not know if using the GitHub merge capability or other merge services
provides different behavior here or not.

This specific request is not related to the change to GitHub PRs
for code review.  There is no intention to change the requirement
for a maintainer to set the 'push' label and no intention to change
away from Mergify at this time.

Perhaps we can open your request as an independent request that we
can find an owner to evaluate options and provide recommendations.

Thanks,

Mike

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Monday, May 6, 2024 8:31 AM
> To: Kinney, Michael D 
> Cc: r...@edk2.groups.io; devel@edk2.groups.io; Pedro Falcato
> ; Leif Lindholm ; Andrew
> Fish (af...@apple.com) 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> On Mon, 6 May 2024 at 17:11, Kinney, Michael D
>  wrote:
> >
> > That information is in GitHub in the PR conversation.
> >
> > If you follow the link from the commit to the PR, the PR conversation
> shows
> > who set the 'push' label.
> >
> 
> But that is GitHub proprietary metadata, no? Is it not possible to set
> the committer field in Git itself to something meaningful?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118602): https://edk2.groups.io/g/devel/message/118602
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On Mon, 6 May 2024 at 17:11, Kinney, Michael D
 wrote:
>
> That information is in GitHub in the PR conversation.
>
> If you follow the link from the commit to the PR, the PR conversation shows
> who set the 'push' label.
>

But that is GitHub proprietary metadata, no? Is it not possible to set
the committer field in Git itself to something meaningful?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118601): https://edk2.groups.io/g/devel/message/118601
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

2024-05-06 Thread Michael D Kinney

That information is in GitHub in the PR conversation.

If you follow the link from the commit to the PR, the PR conversation shows
who set the 'push' label.

Mike

> -Original Message-
> From: r...@edk2.groups.io  On Behalf Of Ard
> Biesheuvel
> Sent: Monday, May 6, 2024 3:01 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> Cc: Pedro Falcato ; r...@edk2.groups.io; Leif
> Lindholm ; Andrew Fish (af...@apple.com)
> 
> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code
> Review from email to GitHub Pull Requests on 5-24-2024
> 
> This reminds me: would it be possible to keep track of who merged a
> PR? (i.e., the person that set the 'push' label)
> 
> Currently, commits just appear on the branch with the original author
> and the committer field set to something non-descript, e.g.,
> 
> commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96 (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Gerd Hoffmann 
> AuthorDate: Fri Mar 1 08:44:00 2024 +0100
> Commit: mergify[bot]
> <37929162+mergify[bot]@users.noreply.github.com>
> CommitDate: Fri Mar 1 18:47:27 2024 +
> 
> which means we cannot tell from the git history which maintainer merged
> this.
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118600): https://edk2.groups.io/g/devel/message/118600
Mute This Topic: https://groups.io/mt/105873467/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

2024-05-06 Thread Igor Kulchytskyy via groups.io

Reviewed-by: Igor Kulchytskyy 
Regards,
Igor

-Original Message-
From: Chang, Abner 
Sent: Thursday, May 02, 2024 11:49 PM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Igor Kulchytskyy ; Nick Ramirez 
Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: rename 
x-uefi-redfish to x-UEFI-redfish


**CAUTION: The e-mail below is from an external source. Please exercise caution 
before opening attachments, clicking links, or following guidance.**

[AMD Official Use Only - General]

Reviewed-by: Abner Chang 

> -Original Message-
> From: Nickle Wang 
> Sent: Friday, May 3, 2024 9:57 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez 
> Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish
> to x-UEFI-redfish
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Rename x-uefi-redfish to x-UEFI-redfish to match the format of
> UEFI configuration namespace prefix.
>
> RFC: https://edk2.groups.io/g/rfc/message/849
>
> Signed-off-by: Jeff Brasen 
> Co-authored-by: Nickle Wang 
> Cc: Abner Chang 
> Cc: Igor Kulchytskyy 
> Cc: Nick Ramirez 
> ---
>  .../Features/Bios/v1_0_9/Common/BiosCommon.h  |  2 +-
>  .../v1_0_4/Common/BootOptionCommon.h  |  2 +-
>  .../v1_13_0/Common/ComputerSystemCommon.h |  2 +-
>  .../v1_5_0/Common/ComputerSystemCommon.h  |  2 +-
>  .../Memory/V1_7_1/Common/MemoryCommon.h   |  2 +-
>  .../HiiToRedfishBootDxe/HiiToRedfishBootDxe.h |  2 +-
>  .../EdkIIRedfishResourceConfigInternal.h  |  2 +-
>  .../RedfishFeatureUtilityInternal.h   |  2 +-
>  .../HiiToRedfishBootDxe/HiiToRedfishBootDxe.c |  4 +-
>  .../Media/RedfishClientDriverStack.svg|  2 +-
>  .../HiiToRedfishBiosDxeMap.uni| 16 +++---
>  .../HiiToRedfishBootDxeMap.uni| 32 +--
>  .../HiiToRedfishMemoryDxeMap.uni  | 56 +--
>  RedfishClientPkg/Readme.md| 41 +++---
>  14 files changed, 84 insertions(+), 83 deletions(-)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> index 9a6f9684b..50772d5da 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> @@ -24,7 +24,7 @@
>  #define RESOURCE_SCHEMA_VERSION  "v1_0_9"
>  #define REDPATH_ARRAY_PATTERNL"/Bios/.*"
>  #define REDPATH_ARRAY_PREFIX L"/Bios/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-Bios.v1_0_9"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-Bios.v1_0_9"
>  #define REDFISH_SCHEMA_NAME  "ComputerSystem"
>
>  #endif
> diff --git
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> index 83babf16f..9293d22cd 100644
> ---
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> +++
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> @@ -27,7 +27,7 @@
>  #define RESOURCE_SCHEMA_VERSION  "v1_0_4"
>  #define REDPATH_ARRAY_PATTERNL"/BootOptions/\\{.*\\}/"
>  #define REDPATH_ARRAY_PREFIX L"/BootOptions/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-BootOption.v1_0_4"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-
> BootOption.v1_0_4"
>  #define REDFISH_BOOT_OPTION_PARAMETERL"?name="
>  #define REDFISH_BOOT_OPTION_DEBUG_TRACE  DEBUG_INFO
>  #endif
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> index 7b83d2939..b5e3fa919 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> @@ -24,6 +24,6 @@
>  #define RESOURCE_SCHEMA_VERSION  "v1_13_0"
>  #define REDPATH_ARRAY_PATTERNL"/Systems/\\{.*\\}/"
>  #define REDPATH_ARRAY_PREFIX L"/Systems/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-
> ComputerSystem.v1_13_0"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-
> ComputerSystem.v1_13_0"
>
>  #endif
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> index a0eb41b8b..24a484d18 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> @@ -22,6 +22,6 @@
>  #define RESOURCE_SCHEMA_VERSION  "v1_5_0"
>  #define REDPATH_ARRAY_PATTERNL"/Systems/\\{.*\\}/"
>  #define REDPATH_ARRAY_PREFIX L"/Systems/"
> -#define RESOURCE_SCHEMA_FULL

Re: [edk2-devel] [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

2024-05-06 Thread Chang, Abner via groups.io

[AMD Official Use Only - General]

Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard 
freeze.
Thanks
Abner

> -Original Message-
> From: Chesley, Brit 
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> 
> Subject: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
>
> From: Brit Chesley 
>
> Including the SpiBus drivers in MdeModulePkg.dsc
>
> Platform Initialization spec 1.7 volume 5 section 18.1.6
>
> Bugzilla #4753
>
> Cc: Liming Gao 
> Cc: Ray Ni 
> Cc: Abner Chang 
> Cc: Abdul Lateef Attar 
> Signed-off-by: Brit Chesley 
> ---
>  MdeModulePkg/MdeModulePkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index 6bed9205ea69..33d6f4a1f6a6 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -287,6 +287,8 @@ [Components]
>
> MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceDxe.inf
>
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.inf
>
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> nf
> +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
> +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
>
>MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
>MdeModulePkg/Core/Pei/PeiMain.inf
> --
> 2.42.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118598): https://edk2.groups.io/g/devel/message/118598
Mute This Topic: https://groups.io/mt/105849126/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

2024-05-06 Thread Chang, Abner via groups.io

[AMD Official Use Only - General]

Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard 
freeze.
Thanks
Abner

> -Original Message-
> From: Chesley, Brit 
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> 
> Subject: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
>
> From: Brit Chesley 
>
> Including the SpiHc drivers in MdeModulePkg.dsc
>
> Bugzilla #4753
>
> Cc: Liming Gao 
> Cc: Ray Ni 
> Cc: Abner Chang 
> Cc: Abdul Lateef Attar 
> Signed-off-by: Brit Chesley 
> ---
>  MdeModulePkg/MdeModulePkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index 177128bdfd3e..a1c8e2f90524 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -290,6 +290,8 @@ [Components]
>
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> nf
>MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
>MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
> +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcDxe.inf
> +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcSmm.inf
>
>MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
>MdeModulePkg/Core/Pei/PeiMain.inf
> --
> 2.42.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118597): https://edk2.groups.io/g/devel/message/118597
Mute This Topic: https://groups.io/mt/105849136/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-06 Thread Chang, Abner via groups.io

[AMD Official Use Only - General]

Hi MdeModulePkg maintainers,
Please review this patch as we would like to merge it before the upcoming hard 
freeze.
Thanks
Abner

> -Original Message-
> From: Chesley, Brit 
> Sent: Thursday, May 2, 2024 3:05 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Ray Ni ;
> Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> 
> Subject: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
> lib instance
>
> From: Brit Chesley 
>
> Adding NULL SpiHcPlatformLib instance. This library is responsible for
> handling the low level details of the SPI host controller. Since this is
> platform specific this library will be dependent on OEM SPI
> implementation. The SPI host controller layer will utilize this library
> for SPI bus transactions.
>
> Bugzilla #4753
>
> Cc: Liming Gao 
> Cc: Ray Ni 
> Cc: Abner Chang 
> Cc: Abdul Lateef Attar 
> Signed-off-by: Brit Chesley 
> ---
>  MdeModulePkg/MdeModulePkg.dec |   5 +
>  MdeModulePkg/MdeModulePkg.dsc |   2 +
>  .../BaseSpiHcPlatformLibNull.inf  |  33 
>  .../Include/Library/SpiHcPlatformLib.h| 148 ++
>  .../BaseSpiHcPlatformLibNull.c| 145 +
>  .../BaseSpiHcPlatformLibNull.uni  |  11 ++
>  6 files changed, 344 insertions(+)
>  create mode 100644
> MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> inf
>  create mode 100644 MdeModulePkg/Include/Library/SpiHcPlatformLib.h
>  create mode 100644
> MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> c
>  create mode 100644
> MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> uni
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 085370eae41a..8a3bcb9aded1 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -169,6 +169,11 @@ [LibraryClasses]
>#
>ImagePropertiesRecordLib|Include/Library/ImagePropertiesRecordLib.h
>
> +  ##  @libraryclass   Platform SPI Host Controller library which provides 
> low-
> level
> +  #   control over the SPI hardware
> +  #
> +  SpiHcPlatformLib|Include/Library/SpiHcPlatformLib.h
> +
>  [Guids]
>## MdeModule package token space guid
># Include/Guid/MdeModulePkgTokenSpace.h
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index 33d6f4a1f6a6..177128bdfd3e 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -107,6 +107,7 @@ [LibraryClasses]
>
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> ckMemoryLibNull.inf
>
> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseV
> ariableFlashInfoLib.inf
>
> IpmiCommandLib|MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIp
> miCommandLibNull.inf
> +
> SpiHcPlatformLib|MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpi
> HcPlatformLibNull.inf
>
>  [LibraryClasses.EBC.PEIM]
>IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf
> @@ -528,6 +529,7 @@ [Components.IA32, Components.X64]
>
> MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.i
> nf
>
> MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.in
> f
>
> MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys
> TLib.inf
> +
> MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> inf
>
>  [Components.X64]
>MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> diff --git
> a/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> ull.inf
> b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> ull.inf
> new file mode 100644
> index ..805f50b89565
> --- /dev/null
> +++
> b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> ull.inf
> @@ -0,0 +1,33 @@
> +## @file
> +#  NULL library for platform SPI Host controller, which should be provided
> +#  by the OEM.
> +#
> +#  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
> +#
> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +[Defines]
> +  INF_VERSION   = 1.27
> +  BASE_NAME = BaseSpiHcPlatformLibNull
> +  FILE_GUID = 3C230948-6DF5-4802-8177-967A190579CF
> +  MODULE_TYPE   = BASE
> +  VERSION_STRING= 0.1
> +  PI_SPECIFICATION_VERSION  = 0x0001000A
> +  LIBRARY_CLASS = SpiHcPlatformLib
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
> +
> +[LibraryClasses]
> +  DevicePathLib
> +  UefiLib
> +
> +[Sources]
> +  BaseSpiHcPlatformLibNull.c
> +
> +[Depex]
> +  TRUE
> +
> +[UserExtensions.TianoCore."ExtraFiles"]
> +  BaseSpiHcPlatformLibNull.uni
> diff --git a/MdeModulePkg/Include/Library/SpiHcPlatformLib.h
> b/MdeModulePkg/Include/Library/SpiHcPlatformLib.h
> new file mode 100644
> index ..c68f7455372c
> --- /dev/null
> +++

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

On Mon, 6 May 2024 at 12:02, Chao Li  wrote:
>
> Hi Gerd,
>
>
> Thanks,
> Chao
> On 2024/3/19 16:03, Gerd Hoffmann wrote:
>
>   Hi,
>
> I can't tell the implementation scheme of the current lib and existing
> lib implementation scheme which one is better, Could you give we some
> advice?
>
> I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as
> it is not really loongarch-specific.
>
> If you want try switch aarch64 to use the same code that'll be great,
> but sorting that out later is also fine with me.
>
> If you think this design is looks better, then I'm prepare to commit this
> change under the OvmfPkg/Library as a public library. And I will enable it
> in aarch64 after merging this change, because I think it may be tweaked and
> validated in aarch64 for many platforms. Do you think that is good?
>
> The VirtNorFlashDxe is optimized for qemu-emulated pflash.  It tries to
> avoid switching between read and write mode much, because that operation
> has a significant overhead in virtualization.  So it's really only used
> by ArmVirtPkg and not lots of other arm platforms.
>
> I'm moving the ARM version of the library to OvmfPkg and adding the set PCD 
> method, I have verified successfully on ArmVirtQemu.dsc(both -bios and 
> pflash), but I found that the ArmVirtQemuKernel.dsc also depends this 
> library, so what's the difference between the two platforms?
>
> When I try to verify on ArmVirtQemuKernel.dsc that it works based on -bios 
> option,  I use the command line "qemu-system-aarch64 -M virt -cpu cortex-a57 
> -bios LA_Virt_FW/AARCH64/QEMU_EFI.fd -net none -serial stdio -hdb 
> /home/lichao/Software/Qemu/SctPkg/share.imag -device ramfb -device 
> nec-usb-xhci -device usb-mouse -device usb-kbd", and it tells me "Could not 
> open option rom 'vgabios-ramfb.bin': No such file or directory", I tried 
> removing the option "-device ramfb", it looks like can't work.
>
> How does ArmVirtQemuKernel.dsc work?
>

It uses the -kernel QEMU command line argument, not the -bios one.

This uses the Linux/arm64 kernel boot protocol (and runs the firmware
entirely from RAM) rather than booting from NOR flash.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118595): https://edk2.groups.io/g/devel/message/118595
Mute This Topic: https://groups.io/mt/104859896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 20/26] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

2024-05-06 Thread Chao Li


Hi Gerd,


Thanks,
Chao
On 2024/3/19 16:03, Gerd Hoffmann wrote:

   Hi,


I can't tell the implementation scheme of the current lib and existing
lib implementation scheme which one is better, Could you give we some
advice?

I'd suggest to merge your code as OvmfPkg/Library/FdtNorFlashQemuLib as
it is not really loongarch-specific.

If you want try switch aarch64 to use the same code that'll be great,
but sorting that out later is also fine with me.

If you think this design is looks better, then I'm prepare to commit this
change under the OvmfPkg/Library as a public library. And I will enable it
in aarch64 after merging this change, because I think it may be tweaked and
validated in aarch64 for many platforms. Do you think that is good?

The VirtNorFlashDxe is optimized for qemu-emulated pflash.  It tries to
avoid switching between read and write mode much, because that operation
has a significant overhead in virtualization.  So it's really only used
by ArmVirtPkg and not lots of other arm platforms.


I'm moving the ARM version of the library to OvmfPkg and adding the set 
PCD method, I have verified successfully on ArmVirtQemu.dsc(both -bios 
and pflash), but I found that the ArmVirtQemuKernel.dsc also depends 
this library, so what's the difference between the two platforms?


When I try to verify on ArmVirtQemuKernel.dsc that it works based on 
-bios option,  I use the command line "qemu-system-aarch64 -M virt -cpu 
cortex-a57 -bios LA_Virt_FW/AARCH64/QEMU_EFI.fd -net none -serial stdio 
-hdb /home/lichao/Software/Qemu/SctPkg/share.imag -device ramfb -device 
nec-usb-xhci -device usb-mouse -device usb-kbd", and it tells me "Could 
not open option rom 'vgabios-ramfb.bin': No such file or directory", I 
tried removing the option "-device ramfb", it looks like can't work.


How does ArmVirtQemuKernel.dsc work?



Doing it separate from this patch series makes sense nevertheless.

Speaking of this series: maybe split it into two?  The first part
of this series with the Mde*Pkg + UefiPkg changes looks almost ready
to merge to me, so maybe we can get that in while still sorting out
the remaining issues in the OvmfPkg patches ...

take care,
   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118594): https://edk2.groups.io/g/devel/message/118594
Mute This Topic: https://groups.io/mt/104859896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024