回复: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and MaxVcpus

[gaoliming via groups.io]

Is there Pull Request for this patch?

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Xiaoyao Li
> 发送时间: 2024年6月27日 9:27
> 收件人: devel@edk2.groups.io
> 抄送: xiaoyao...@intel.com
> 主题: [edk2-devel] [PATCH] MdePkg/Tdx.h: Fix the order of NumVcpus and
> MaxVcpus
> 
> For TDCALL leaf TDG.VP.INFO, the bit 31:0 in R8 returns NUM_VCPUS and
> bit 63:32 in R8 returns MAX_VCPUS. Current struct
> TDCALL_INFO_RETURN_DATA defines them in wrong order.
> 
> Signed-off-by: Xiaoyao Li 
> Cc: Jiewen Yao 
> Cc: Min Xu 
> Cc: Gerd Hoffmann 
> Cc: Laszlo Ersek 
> ---
>  MdePkg/Include/IndustryStandard/Tdx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Tdx.h
> b/MdePkg/Include/IndustryStandard/Tdx.h
> index 2662761883e5..17f1e8f4146a 100644
> --- a/MdePkg/Include/IndustryStandard/Tdx.h
> +++ b/MdePkg/Include/IndustryStandard/Tdx.h
> @@ -113,8 +113,8 @@ typedef struct {
>  typedef struct {
> 
>UINT64Gpaw;
> 
>UINT64Attributes;
> 
> -  UINT32MaxVcpus;
> 
>UINT32NumVcpus;
> 
> +  UINT32MaxVcpus;
> 
>UINT64Resv[3];
> 
>  } TDCALL_INFO_RETURN_DATA;
> 
> 
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#119726): https://edk2.groups.io/g/devel/message/119726
> Mute This Topic: https://groups.io/mt/106918890/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119767): https://edk2.groups.io/g/devel/message/119767
Mute This Topic: https://groups.io/mt/107012181/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

[gaoliming via groups.io]

Abner:

  Is PR for this change?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Chang, Abner via groups.io
发送时间: 2024年6月18日 10:50
收件人: Chesley, Brit ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor 
Table

 

Hi Hao,
What is your comment on the response from Brit? Hoping that I didn't miss the 
latest conversation of this thread.

Thanks
Abner 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119600): https://edk2.groups.io/g/devel/message/119600
Mute This Topic: https://groups.io/mt/106736045/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

[gaoliming via groups.io]

Zhihao:
  I have no other comment for the change in MdeModulePkg. Please create pull 
request for it. 

Thanks
Liming
> -邮件原件-
> 发件人: Li, Zhihao 
> 发送时间: 2024年6月11日 15:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C 
> 主题: RE: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> MigrateTempRamPpi
> 
> Hi Liming
> 
> If there are no concerns about it, could you please help to review the patch 
> in
> MdeModulePkg scope and check in?
> And then, I contact with the maintainers of IntelFsp2WrapperPkg for another
> patch review.
> 
> BR,
> Zhihao
> 
> -Original Message-
> From: Li, Zhihao
> Sent: Thursday, May 30, 2024 2:32 PM
> To: gaoliming ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C 
> Subject: RE: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> MigrateTempRamPpi
> 
> Yes, they are used.
> Refer to https://bugzilla.tianocore.org/show_bug.cgi?id=2376 , Fsp binary
> measurement has been implemented and controlled by
> PcdFspMeasurementConfig.
> Current defect:
> 1. FSP-T/FSP-M may not be migrated.
> 2. Even if FSP-M has been migrated, its measurement still used the original
> address.
> Corresponding modifications:
> In MdeModulePkg scope:
> 1. Add the gEdkiiPeiMigrateTempRamPpiGuid and install it after
> EvacuateTempRam is called.
> In IntelFsp2WrapperPkg scope:
> 1. Add MigrateTempRamPpi notification which will check the migration of
> FSP-T/M and migrate them if they are not migrated but need to be measured.
> 2. Fix Tcg notification to use migrated address if the binaries had been 
> migrated.
> 
> BR,
> Zhihao
> 
> -Original Message-
> From: gaoliming 
> Sent: Thursday, May 30, 2024 1:12 PM
> To: devel@edk2.groups.io; Li, Zhihao 
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C 
> Subject: 回复: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> MigrateTempRamPpi
> 
> Zhihao:
>   If Fsp-T/M is not installed, are they still used in PEI boot? If they are 
> used, I
> agree they should be measured.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Li, Zhihao
> > 发送时间: 2024年5月29日 11:36
> > 收件人: gaoliming ; devel@edk2.groups.io
> > 抄送: Chiu, Chasel ; Desimone, Nathaniel L
> > ; Duggapu, Chinni B
> > ; Chen, Gang C 
> > 主题: Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> > MigrateTempRamPpi
> >
> > Issue description:
> > 1. PeiCore only migrates Fsp-M in dispatch mode and doesn't migrate
> > Fsp-T and Fsp-M in Api mode.
> > 2. Fsp-T and Fsp-M will be measured in post-mem PEI and the
> > measurement uses original addresses.
> > RootCause:
> > PeiCore only migrates installed FVs and Fsp-T/M may not be installed.
> >
> > Defect in implementation:
> > In MdeModulePkg/Core/Pei/PeiMain/PeiMain.c line 450:
> > EvacuateTempRam will migrate installed content from Temporary RAM to
> > Permanent RAM because of BootGuard TOCTOU
> > vulnerability(https://bugzilla.tianocore.org/show_bug.cgi?id=1614).
> > In IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c line 220:
> > FspmWrapperInit will install Fspm in dispatch mode or directly call
> > PeiFspMemoryInit function in api mode.
> > ==>
> > Api mode: Fsp-T and Fsp-M are not migrated because they are not installed.
> > Dispatch mode: Fsp-T is not migrated because it is not installed.
> >
> > In IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c line 291,
> 300:
> > TcgPpiNotify transmits original addresses(PcdFsptBaseAddress,
> > PcdFspmBaseAddress) to MeasureFspFirmwareBlob which will trigger
> > HashLogExtendEvent.
> > In SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c line 966:
> > TcgPpi will be installed in PeimEntryMP which will be called when the
> > PEI Foundation discovers permanent memory(line 1059 mImageInMemory =
> TRUE).
> > ==>
> > Original addresses of Fsp-T and Fsp-M will be used for measurement
> > after permanent memory is ready and installed FVs are migrated.
> >
> >
> > Solution:
> > MdeModulePkg: PeiCore Installs MigrateTempRamPpi if
> > PcdMigrateTemporaryRamFirmwareVolumes is True.
> > IntelFsp2WrapperPkg : 1. MigrateTempRamPpi nitification in
> > FspmWrapperPeim migrates FspT/M binary to permanent memory and build
> MigatedFvInfoHob.
> >   2. TCG notification checks
> > MigatedFvInfoHob and transmits DRAM address for measurement.
> >
> > BR,
> > Zhihao
> >
> >
> > -Original Message-
> > From: gaoliming 
> > Sent: Tuesday, May 28, 2024 5:44 PM
> > To: Li, Zhihao ; devel@edk2.groups.io
> > Cc: Chiu, Chasel ; Desimone, Nathaniel L
> > ; Duggapu, Chinni B
> > ; Chen, Gang C 
> > Subject: 回复: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> > MigrateTempRamPpi
> >
> > Zhihao:
> >   Could you explain the situation that FSP-T/M is not migrated by PeiCore?
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 发件人: Zhihao Li 
> > > 发送时间: 2024年4月29日 11:20
> > > 

回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory allocation for SP type

[gaoliming via groups.io]

Can you create pull request for this change? I will add my review for it. 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Dhaval Sharma
> 发送时间: 2024年6月11日 12:09
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao 
> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
allocation
> for SP type
> 
> Most of the times it is desirable not to use special purpose
> memory for regular edk2 usages. That memory (HBm/CXL) are
> either meant for special purposes or are less reliable to
> be used. So avoid using them as long as possible. We could
> also introduce PCD for this control.
> 
> Cc: Liming Gao 
> Signed-off-by: Dhaval Sharma 
> ---
>  MdeModulePkg/Core/Dxe/Mem/Page.c | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c
> b/MdeModulePkg/Core/Dxe/Mem/Page.c
> index 5a51d9df1a29..e4daa741b971 100644
> --- a/MdeModulePkg/Core/Dxe/Mem/Page.c
> +++ b/MdeModulePkg/Core/Dxe/Mem/Page.c
> @@ -1183,6 +1183,13 @@ CoreFindFreePagesI (
>continue;
> 
>  }
> 
> 
> 
> +//
> 
> +// Don't allocate out of Special-Purpose memory.
> 
> +//
> 
> +if ((Entry->Attribute & EFI_MEMORY_SP) != 0) {
> 
> +  continue;
> 
> +}
> 
> +
> 
>  DescStart = Entry->Start;
> 
>  DescEnd   = Entry->End;
> 
> 
> 
> --
> 2.40.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#119545): https://edk2.groups.io/g/devel/message/119545
> Mute This Topic: https://groups.io/mt/106607739/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119581): https://edk2.groups.io/g/devel/message/119581
Mute This Topic: https://groups.io/mt/106682610/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

[gaoliming via groups.io]

I just add push label for it. 

 

发件人: Hsueh, Hong-Chih (Neo)  
发送时间: 2024年6月4日 23:46
收件人: gaoliming ; devel@edk2.groups.io; Chang,
Abner 
抄送: michael.d.kin...@intel.com; zhiguang@intel.com; He, Jiangang

主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from
header file (BZ# 4775)

 

[AMD Official Use Only - AMD Internal Distribution Only]

 

Hi Liming,

 

Sorry for the late response. I already created a pull request for it.

https://github.com/tianocore/edk2/pull/5737

 

Regards,

Neo

  _  

From: gaoliming mailto:gaolim...@byosoft.com.cn>
>
Sent: Wednesday, May 15, 2024 8:08 PM
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >; Chang, Abner
mailto:abner.ch...@amd.com> >; Hsueh, Hong-Chih (Neo)
mailto:hong-chih.hs...@amd.com> >
Cc: michael.d.kin...@intel.com 
mailto:michael.d.kin...@intel.com> >; zhiguang.
l...@intel.com   mailto:zhiguang@intel.com> >; He, Jiangang mailto:jiangang...@amd.com> >
Subject: 回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from
header file (BZ# 4775) 

 

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


Abner:
  This change is good to me. Reviewed-by: Liming Gao mailto:gaolim...@byosoft.com.cn> >

  But, this is not critical issue. So, I suggest to merge it after the
stable tag.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> > 代表 Chang, Abner via
> groups.io
> 发送时间: 2024年5月16日 8:50
> 收件人: Hsueh, Hong-Chih (Neo) mailto:Hong-Chih.
hs...@amd.com> >;
> devel@edk2.groups.io  
> 抄送: michael.d.kin...@intel.com  ;
gaolim...@byosoft.com.cn  ;
> zhiguang@intel.com  ; He, Jiangang
mailto:jiangang...@amd.com> >
> 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from
> header file (BZ# 4775)
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Mike, Liming and Zhiguang,
> Could you please check this patch sent two weeks ago? The corresponding BZ
> ticket is 4775. We overlooked tracking this issue and missed the 202405
stable
> release. As this impacts the build, do you think we can have a quick
review and
> approve it; having this change pulled in 202405 stable release? Otherwise
we will
> have to wait until next stable release.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Hsueh, Hong-Chih (Neo) mailto:Hong-Chih.
hs...@amd.com> >
> > Sent: Thursday, May 2, 2024 3:31 AM
> > To: devel@edk2.groups.io  
> > Cc: michael.d.kin...@intel.com  ;
gaolim...@byosoft.com.cn  ;
> > zhiguang@intel.com  ; He, Jiangang
mailto:jiangang...@amd.com> >; Chang,
> > Abner mailto:abner.ch...@amd.com> >; Hsueh,
Hong-Chih (Neo)  > chih.hs...@amd.com  >
> > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file
> >
> > Cc: Jiangang He mailto:jiangang...@amd.com> >
> > Signed-off-by: Neo Hsueh mailto:hong-chih.hs...@amd.com> >
> > ---
> >  MdePkg/Include/Register/Amd/Cpuid.h  | 4 ++--
> >  MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h
> > b/MdePkg/Include/Register/Amd/Cpuid.h
> > index add43c40aa..51fa9f235c 100644
> > --- a/MdePkg/Include/Register/Amd/Cpuid.h
> > +++ b/MdePkg/Include/Register/Amd/Cpuid.h
> > @@ -46,9 +46,9 @@ CPUID Signature Information
> >CPUID Extended Topology Enumeration
> >
> >@note
> > -  Reference: AMD64 Architecture Programmer’s Manual Volume 3: General-
> > Purpose and System Instructions,
> > +  Reference: AMD64 Architecture Programmer's Manual Volume 3: General-
> > Purpose and System Instructions,
> >   Revision 3.35 Appendix E,
> > -  E.4.24 Function 8000_0026―Extended CPU Topology:
> > +  E.4.24 Function 8000_0026-Extended CPU Topology:
> >  CPUID Fn8000_0026 reports extended topology information for logical
> > processors, including
> >  asymmetric and heterogenous topology descriptions. Individual
logical
> > processors may report
> >  different values in systems with asynchronous and heterogeneous
> > topologies.
> > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > index 756e7c86ec..4715c59dc4 100644
> > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > @@ -5733,9 +5733,9 @@ typedef union {
> >  /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms
> enumerated
> > in
> >  /// IA32_TME_CAPABILITY are allowed.
> 

回复: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

[gaoliming via groups.io]

Zhihao:
  If Fsp-T/M is not installed, are they still used in PEI boot? If they are 
used, I agree they should be measured. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Li, Zhihao
> 发送时间: 2024年5月29日 11:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C 
> 主题: Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> MigrateTempRamPpi
> 
> Issue description:
> 1. PeiCore only migrates Fsp-M in dispatch mode and doesn't migrate Fsp-T and
> Fsp-M in Api mode.
> 2. Fsp-T and Fsp-M will be measured in post-mem PEI and the measurement uses
> original addresses.
> RootCause:
> PeiCore only migrates installed FVs and Fsp-T/M may not be installed.
> 
> Defect in implementation:
> In MdeModulePkg/Core/Pei/PeiMain/PeiMain.c line 450:
> EvacuateTempRam will migrate installed content from Temporary RAM to
> Permanent RAM because of BootGuard TOCTOU
> vulnerability(https://bugzilla.tianocore.org/show_bug.cgi?id=1614).
> In IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c line 220:
> FspmWrapperInit will install Fspm in dispatch mode or directly call
> PeiFspMemoryInit function in api mode.
> ==>
> Api mode: Fsp-T and Fsp-M are not migrated because they are not installed.
> Dispatch mode: Fsp-T is not migrated because it is not installed.
> 
> In IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c line 291, 300:
> TcgPpiNotify transmits original addresses(PcdFsptBaseAddress,
> PcdFspmBaseAddress) to MeasureFspFirmwareBlob which will trigger
> HashLogExtendEvent.
> In SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c line 966:
> TcgPpi will be installed in PeimEntryMP which will be called when the PEI
> Foundation discovers permanent memory(line 1059 mImageInMemory = TRUE).
> ==>
> Original addresses of Fsp-T and Fsp-M will be used for measurement after
> permanent memory is ready and installed FVs are migrated.
> 
> 
> Solution:
> MdeModulePkg: PeiCore Installs MigrateTempRamPpi if
> PcdMigrateTemporaryRamFirmwareVolumes is True.
> IntelFsp2WrapperPkg : 1. MigrateTempRamPpi nitification in FspmWrapperPeim
> migrates FspT/M binary to permanent memory and build MigatedFvInfoHob.
>   2. TCG notification checks
> MigatedFvInfoHob and transmits DRAM address for measurement.
> 
> BR,
> Zhihao
> 
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, May 28, 2024 5:44 PM
> To: Li, Zhihao ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang C 
> Subject: 回复: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install
> MigrateTempRamPpi
> 
> Zhihao:
>   Could you explain the situation that FSP-T/M is not migrated by PeiCore?
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Zhihao Li 
> > 发送时间: 2024年4月29日 11:20
> > 收件人: devel@edk2.groups.io
> > 抄送: Chasel Chiu ; Nate DeSimone
> > ; Duggapu Chinni B
> > ; Chen Gang C ;
> > Liming Gao 
> > 主题: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4716
> >
> > Migrate FSP-T/M binary from temporary RAM to permanent RAM before NEM
> > tear down. Tcg module will use permanent address of FSP-T/M for
> > measurement.
> > 1. PeiCore installs mMigrateTempRamPpi if
> > PcdMigrateTemporaryRamFirmwareVolumes is True 2. FspmWrapperPeim
> > migrate FspT/M binary to permanent memory and build MigatedFvInfoHob
> > 3. TCG notification checks MigatedFvInfoHob and transmits DRAM address
> > for measurement
> >
> > Cc: Chasel Chiu 
> > Cc: Nate DeSimone 
> > Cc: Duggapu Chinni B 
> > Cc: Chen Gang C 
> > Cc: Liming Gao 
> >
> > Signed-off-by: Zhihao Li 
> > ---
> >  MdeModulePkg/Core/Pei/PeiMain/PeiMain.c| 10 -
> >  MdeModulePkg/Core/Pei/PeiMain.h|  3 ++-
> >  MdeModulePkg/Core/Pei/PeiMain.inf  |  3 ++-
> >  MdeModulePkg/Include/Guid/MigratedFvInfo.h |  4 ++--
> > MdeModulePkg/Include/Ppi/MigrateTempRam.h  | 23
> > 
> >  MdeModulePkg/MdeModulePkg.dec  |  5 -
> >  6 files changed, 42 insertions(+), 6 deletions(-)
> >
> > diff --git a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> > b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> > index bf1719d7941a..0e3d9a843816 100644
> > --- a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> > +++ b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> > @@ -1,7 +1,7 @@
> >  /** @file
> >Pei Core Main Entry Point
> >
> > -Copyright (c) 2006 - 2019, Intel Corporation. All rights
> > reserved.
> > +Copyright (c) 2006 - 2024, Intel Corporation. All rights
> > +reserved.
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -13,6 +13,11 @@ EFI_PEI_PPI_DESCRIPTOR  mMemoryDiscoveredPpi = {
> >,
> >NULL
> >  };
> > +EFI_PEI_PPI_DESCRIPTOR  mMigrateTempRamPpi = {
> > +  (EFI_PEI_PPI_DESCRIPTOR_PPI |
> > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),
> > +  ,
> > +  NULL
> > +};
> >
> >  ///
> >  /// Pei service instance
> > @@ -449,6 +454,9 @@ PeiCore (
> >

回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

If ASSERT trigs the exception, could call stack show each caller?

Thanks
Liming
> -邮件原件-
> 发件人: Gerd Hoffmann 
> 发送时间: 2024年5月29日 21:09
> 收件人: devel@edk2.groups.io; dougfl...@microsoft.com
> 抄送: Liming Gao ; Ard Biesheuvel
> 
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
> On Thu, May 23, 2024 at 10:44:52PM GMT, Doug Flick via groups.io wrote:
> >
> >
>
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-
edk-ii-
> ipv6-network-stack.html
> >
> > This patch series patches the following CVEs:
> > - CVE-2023-45236: Predictable TCP Initial Sequence Numbers
> > - CVE-2023-45237: Use of a Weak PseudoRandom Number Generator
> 
> Ok, looks like there is some more fallout from this patch series which I
> havn't seen in my initial testing.  It does not always happen, didn't
> figure yet what exactly triggers the behavior.  But in some cases there
> is quite some network stack activity, apparently done by
> EVT_SIGNAL_EXIT_BOOT_SERVICES event handlers ...
> 
> With the debug patch below applied the tail of the ovmf log looks like
> this:
> 
>   VirtioRngExitBoot: Context=0x7D73D798
>   Hash2ServiceBindingDestroyChild - Invalid handle
>   MnpServiceBindingDestroyChild: Failed to uninstall the ManagedNetwork
> protocol, Invalid Parameter.
>   Support(): UNDI3.1 found on handle 7D461118
>   Support(): supported on 7D461118
>   Start(): UNDI3.1 found
> 
>   snp->undi.start()  1h:8000h
>   InstallProtocolInterface: 7AB33A91-ACE5-4326-B572-E7EE33D39F16
> 7CE872C0
>   InstallProtocolInterface: F44C00EE-1F2C-4A00-AA09-1C9F3E0800A3
> 7CE7D020
>   Failed to generate random data using secure algorithm 0: Unsupported
>   Failed to generate random data using secure algorithm 1: Unsupported
>   Failed to generate random data using secure algorithm 2: Unsupported
>   Failed to generate random data using secure algorithm 3: Unsupported
>   VirtioRngGetRNG: not ready
>   Failed to generate random data using secure algorithm 4: Device Error
> 
>   ASSERT_EFI_ERROR (Status = Device Error)
>   ASSERT
> /home/kraxel/projects/edk2/NetworkPkg/Library/DxeNetLib/DxeNetLib.c(965):
> !(((INTN)(RETURN_STATUS)(Status)) < 0)
> 
> The VirtioRngDxe EVT_SIGNAL_EXIT_BOOT_SERVICES handler resets the
> device, to make sure it will stop any DMA.
> 
> Once the reset is done the device can't deliver random numbers any more,
> but the network code wants some.  So with the debug patch an assert is
> triggered, without the debug patch the system simply hangs because the
> virtio-rng device wouldn't answer request sent by the driver.
> 
> I'm wondering what the network code is actually doing here in the first
> place?  It apparently /installs/ protocols in the
> EVT_SIGNAL_EXIT_BOOT_SERVICES handler?  I don't think this is how things
> are supposed to work ...
> 
> take care,
>   Gerd
> 
> - cut here -
> diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.h
> b/OvmfPkg/VirtioRngDxe/VirtioRng.h
> index 2da99540a208..3519521d6ab5 100644
> --- a/OvmfPkg/VirtioRngDxe/VirtioRng.h
> +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.h
> @@ -33,6 +33,7 @@ typedef struct {
>VRING Ring;   // VirtioRingInit   2
>EFI_RNG_PROTOCOL  Rng;// VirtioRngInit1
>VOID  *RingMap;   // VirtioRingMap
> 2
> +  BOOLEAN   Ready;
>  } VIRTIO_RNG_DEV;
> 
>  #define VIRTIO_ENTROPY_SOURCE_FROM_RNG(RngPointer) \
> diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.c
> index 75a9644f749c..36e3eed4617c 100644
> --- a/OvmfPkg/VirtioNetDxe/Events.c
> +++ b/OvmfPkg/VirtioNetDxe/Events.c
> @@ -77,7 +77,7 @@ VirtioNetExitBoot (
>//
>VNET_DEV  *Dev;
> 
> -  DEBUG ((DEBUG_VERBOSE, "%a: Context=0x%p\n", __func__, Context));
> +  DEBUG ((DEBUG_INFO, "%a: Context=0x%p\n", __func__, Context));
>Dev = Context;
>if (Dev->Snm.State == EfiSimpleNetworkInitialized) {
>  Dev->VirtIo->SetDeviceStatus (Dev->VirtIo, 0);
> diff --git a/OvmfPkg/VirtioRngDxe/VirtioRng.c
> b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> index 069aed148af1..370c9ac8f1de 100644
> --- a/OvmfPkg/VirtioRngDxe/VirtioRng.c
> +++ b/OvmfPkg/VirtioRngDxe/VirtioRng.c
> @@ -156,6 +156,10 @@ VirtioRngGetRNG (
>}
> 
>Dev = VIRTIO_ENTROPY_SOURCE_FROM_RNG (This);
> +  if (!Dev->Ready) {
> +DEBUG ((DEBUG_INFO, "%a: not ready\n", __func__));
> +return EFI_DEVICE_ERROR;
> +  }
>//
>// Map Buffer's system physical address to device address
>//
> @@ -382,6 +386,7 @@ VirtioRngInit (
>//
>Dev->Rng.GetInfo = VirtioRngGetInfo;
>Dev->Rng.GetRNG  = VirtioRngGetRNG;
> +  Dev->Ready = TRUE;
> 
>return EFI_SUCCESS;
> 
> @@ -414,8 +419,8 @@ VirtioRngUninit (
>// VIRTIO_CFG_WRITE() returns, the host will have learned to stay away
from
>// the old comms area.
>//
> +  Dev->Ready = FALSE;
>Dev->VirtIo->SetDeviceStatus (Dev->VirtIo, 0);
> -
>

回复: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute

[gaoliming via groups.io]

Lin:

  I see there is some discussion. Have you made the agreement with this
change?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Du Lin
发送时间: 2024年5月29日 21:05
收件人: devel@edk2.groups.io
抄送: Liming Gao ; Ni, Ray ;
Lin, Du 
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion
to support SP attribute

 

A pull request has been created for this patch:
https://github.com/tianocore/edk2/pull/5691.

 

BRs,

Lin, Du

 

From: Ni, Ray mailto:ray...@intel.com> > 
Sent: Friday, May 10, 2024 10:53 AM
To: Lin, Du mailto:du@intel.com> >;
devel@edk2.groups.io  
Cc: Liming Gao mailto:gaolim...@byosoft.com.cn> >
Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to
support SP attribute

 

Reviewed-by: Ray Ni mailto:ray...@intel.com> >

 

Thanks,

Ray

  _  

From: Lin, Du mailto:du@intel.com> >
Sent: Thursday, May 9, 2024 12:04
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >
Cc: Lin, Du mailto:du@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Ni, Ray mailto:ray...@intel.com> >
Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP
attribute 

 

Add a new entry into GCD attribute conversion table to convert
EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP.

Cc: Liming Gao mailto:gaolim...@byosoft.com.cn> >
Cc: Ray Ni mailto:ray...@intel.com> >
Signed-off-by: Du Lin mailto:du@intel.com> >
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index fe1bbd6974..99364508cd 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY
mAttributeConversionTable[] = {
   { EFI_RESOURCE_ATTRIBUTE_TESTED,  EFI_MEMORY_TESTED,
FALSE },
   { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
TRUE  },
   { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,
EFI_MEMORY_MORE_RELIABLE, TRUE  },
+  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
TRUE  },
   { 0,  0,
FALSE }
 };
 
-- 
2.44.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119378): https://edk2.groups.io/g/devel/message/119378
Mute This Topic: https://groups.io/mt/106383242/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Tan, Dun 
> 发送时间: 2024年5月28日 17:44
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Wang, Jian J 
> 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
> 
> Liming,
> 
> Sure, I think we can remove the field. Could you please add your reviewed-by 
> for
> this patch?
> 
> Thanks,
> Dun
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, May 28, 2024 5:39 PM
> To: Tan, Dun ; devel@edk2.groups.io
> Cc: Ni, Ray ; Wang, Jian J 
> Subject: 回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> MpService2Ppi field in SMM_S3_RESUME_STATE
> 
> Dun:
>   If you confirm that there is no impact on the existing module, you can 
> remove
> it.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Tan, Dun 
> > 发送时间: 2024年5月28日 17:34
> > 收件人: gaoliming ; devel@edk2.groups.io
> > 抄送: Ni, Ray ; Wang, Jian J 
> > 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > MpService2Ppi field in SMM_S3_RESUME_STATE
> >
> > Hi Liming,
> >
> > Sorry I didn't get what the code needs to be compatible with. Could
> > you please explain more?
> > The MpService2Ppi field was added in " MdeModulePkg: add MpService2Ppi
> > field in SMM_S3_RESUME_STATE"( b1955cddb2) last year by me. Previously
> > It was added to simplify the code logic to wakeup AP in S3 boot
> > related code of CPU SMM driver when code execution modes for PEI and
> > DXE are the same. In this patch set, all the related code logic was removed.
> >
> > Thanks,
> > Dun
> >
> > -Original Message-
> > From: gaoliming 
> > Sent: Tuesday, May 28, 2024 5:17 PM
> > To: devel@edk2.groups.io; Tan, Dun 
> > Cc: Ni, Ray ; Wang, Jian J 
> > Subject: 回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > MpService2Ppi field in SMM_S3_RESUME_STATE
> >
> > Dun:
> >   To be compatible, I suggest to keep the same layout of
> > SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not
> > used any more.
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 发件人: devel@edk2.groups.io  代表 duntan
> > > 发送时间: 2024年5月28日 14:35
> > > 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
> > > 
> > > 抄送: Ni, Ray ; Wang, Jian J 
> > > 主题: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > > MpService2Ppi field in SMM_S3_RESUME_STATE
> > >
> > > Hi Liming,
> > >
> > > Could you please help to review this patch?
> > > This patch set is to simplify the X86 CPU SMM driver by removing
> > > most of
> > S3
> > > related logics and we want to merge it as soon as possible.
> > >
> > > Thanks,
> > > Dun
> > >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> > > duntan
> > > Sent: Friday, May 17, 2024 5:46 PM
> > > To: devel@edk2.groups.io
> > > Cc: Ni, Ray ; Wang, Jian J
> > > ;
> > Liming
> > > Gao 
> > > Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > > MpService2Ppi field in SMM_S3_RESUME_STATE
> > >
> > > This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP
> > > to do the CPU initialization during smm s3 boot when the execution
> > > mode of PEI
> > and
> > > DXE are the same.
> > > Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup
> > > AP anymore. The initialization for AP will be done in S3Resume.c
> > > before
> > transfer to
> > > CpuS3.c of smm cpu driver.
> > > So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.
> > >
> > > Signed-off-by: Dun Tan 
> > > Reviewed-by: Ray Ni 
> > > Cc: Jian J Wang 
> > > Cc: Liming Gao 
> > > ---
> > >  MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > > b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > > index 72d173c4fd..6c7237727e 100644
> > > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > > @@ -1,7 +1,7 @@
> > >  /** @file
> > >Definitions for data structures used in S3 resume.
> > >
> > > -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> > > reserved.
> > > +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> > > +reserved.
> > >
> > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > > @@ -30,7 +30,6 @@ typedef struct {
> > >EFI_PHYSICAL_ADDRESSReturnContext1;
> > >EFI_PHYSICAL_ADDRESSReturnContext2;
> > >EFI_PHYSICAL_ADDRESSReturnStackPointer;
> > > -  EFI_PHYSICAL_ADDRESSMpService2Ppi;
> > >EFI_PHYSICAL_ADDRESSSmst;
> > >  } SMM_S3_RESUME_STATE;
> > >
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > 
> > >
> >
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119377): https://edk2.groups.io/g/devel/message/119377
Mute This Topic: https://groups.io/mt/106383229/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub 

[edk2-devel] 回复: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi

[gaoliming via groups.io]

Zhihao:
  Could you explain the situation that FSP-T/M is not migrated by PeiCore? 

Thanks
Liming
> -邮件原件-
> 发件人: Zhihao Li 
> 发送时间: 2024年4月29日 11:20
> 收件人: devel@edk2.groups.io
> 抄送: Chasel Chiu ; Nate DeSimone
> ; Duggapu Chinni B
> ; Chen Gang C ; Liming
> Gao 
> 主题: [PATCH v1 1/2] MdeModulePkg/Core/Pei: Install MigrateTempRamPpi
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4716
> 
> Migrate FSP-T/M binary from temporary RAM to permanent RAM before NEM
> tear down. Tcg module will use permanent address of FSP-T/M for
> measurement.
> 1. PeiCore installs mMigrateTempRamPpi if
> PcdMigrateTemporaryRamFirmwareVolumes is True
> 2. FspmWrapperPeim migrate FspT/M binary to permanent
> memory and build MigatedFvInfoHob
> 3. TCG notification checks MigatedFvInfoHob and transmits
> DRAM address for measurement
> 
> Cc: Chasel Chiu 
> Cc: Nate DeSimone 
> Cc: Duggapu Chinni B 
> Cc: Chen Gang C 
> Cc: Liming Gao 
> 
> Signed-off-by: Zhihao Li 
> ---
>  MdeModulePkg/Core/Pei/PeiMain/PeiMain.c| 10 -
>  MdeModulePkg/Core/Pei/PeiMain.h|  3 ++-
>  MdeModulePkg/Core/Pei/PeiMain.inf  |  3 ++-
>  MdeModulePkg/Include/Guid/MigratedFvInfo.h |  4 ++--
>  MdeModulePkg/Include/Ppi/MigrateTempRam.h  | 23
> 
>  MdeModulePkg/MdeModulePkg.dec  |  5 -
>  6 files changed, 42 insertions(+), 6 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> index bf1719d7941a..0e3d9a843816 100644
> --- a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> +++ b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c
> @@ -1,7 +1,7 @@
>  /** @file
>Pei Core Main Entry Point
> 
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -13,6 +13,11 @@ EFI_PEI_PPI_DESCRIPTOR  mMemoryDiscoveredPpi = {
>,
>NULL
>  };
> +EFI_PEI_PPI_DESCRIPTOR  mMigrateTempRamPpi = {
> +  (EFI_PEI_PPI_DESCRIPTOR_PPI |
> EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST),
> +  ,
> +  NULL
> +};
> 
>  ///
>  /// Pei service instance
> @@ -449,6 +454,9 @@ PeiCore (
>//
>EvacuateTempRam (, SecCoreData);
> 
> +  Status = PeiServicesInstallPpi ();
> +  ASSERT_EFI_ERROR (Status);
> +
>DEBUG ((DEBUG_VERBOSE, "PPI lists after temporary RAM
> evacuation:\n"));
>DumpPpiList ();
>  }
> diff --git a/MdeModulePkg/Core/Pei/PeiMain.h
> b/MdeModulePkg/Core/Pei/PeiMain.h
> index 46b6c23014a3..8df0c2d561f7 100644
> --- a/MdeModulePkg/Core/Pei/PeiMain.h
> +++ b/MdeModulePkg/Core/Pei/PeiMain.h
> @@ -1,7 +1,7 @@
>  /** @file
>Definition of Pei Core Structures and Services
> 
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  #include 
>  #include 
> diff --git a/MdeModulePkg/Core/Pei/PeiMain.inf
> b/MdeModulePkg/Core/Pei/PeiMain.inf
> index 893bdc052798..4e545ddab2ab 100644
> --- a/MdeModulePkg/Core/Pei/PeiMain.inf
> +++ b/MdeModulePkg/Core/Pei/PeiMain.inf
> @@ -6,7 +6,7 @@
>  # 2) Dispatch PEIM from discovered FV.
>  # 3) Handoff control to DxeIpl to load DXE core and enter DXE phase.
>  #
> -# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -101,6 +101,7 @@
>gEfiPeiReset2PpiGuid  ##
> SOMETIMES_CONSUMES
>gEfiSecHobDataPpiGuid ##
> SOMETIMES_CONSUMES
>gEfiPeiCoreFvLocationPpiGuid  ##
> SOMETIMES_CONSUMES
> +  gEdkiiPeiMigrateTempRamPpiGuid## PRODUCES
> 
>  [Pcd]
>gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeiStackSize
> ## CONSUMES
> diff --git a/MdeModulePkg/Include/Guid/MigratedFvInfo.h
> b/MdeModulePkg/Include/Guid/MigratedFvInfo.h
> index 1c8b0dfefc49..255e278235b1 100644
> --- a/MdeModulePkg/Include/Guid/MigratedFvInfo.h
> +++ b/MdeModulePkg/Include/Guid/MigratedFvInfo.h
> @@ -1,7 +1,7 @@
>  /** @file
>Migrated FV information
> 
> -Copyright (c) 2020, Intel Corporation. All rights reserved.
> +Copyright (c) 2020 - 2024, Intel Corporation. All rights reserved.
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -50,7 +50,7 @@ typedef struct {
> 
>  typedef struct {
>UINT32FvOrgBase; // original FV address
> -  UINT32FvNewBase; // new FV address
> +  UINT32FvNewBase; // new FV address, 0 means rebased data
> is not copied
>UINT32FvDataBase;// original FV data, 0 means raw data is
not
> copied
>UINT32FvLength;  // Fv Length
>  } EDKII_MIGRATED_FV_INFO;
> diff 

回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

[gaoliming via groups.io]

Dun:
  If you confirm that there is no impact on the existing module, you can remove 
it. 

Thanks
Liming
> -邮件原件-
> 发件人: Tan, Dun 
> 发送时间: 2024年5月28日 17:34
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Wang, Jian J 
> 主题: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
> 
> Hi Liming,
> 
> Sorry I didn't get what the code needs to be compatible with. Could you please
> explain more?
> The MpService2Ppi field was added in " MdeModulePkg: add MpService2Ppi
> field in SMM_S3_RESUME_STATE"( b1955cddb2) last year by me. Previously It
> was added to simplify the code logic to wakeup AP in S3 boot related code of 
> CPU
> SMM driver when code execution modes for PEI and DXE are the same. In this
> patch set, all the related code logic was removed.
> 
> Thanks,
> Dun
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, May 28, 2024 5:17 PM
> To: devel@edk2.groups.io; Tan, Dun 
> Cc: Ni, Ray ; Wang, Jian J 
> Subject: 回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> MpService2Ppi field in SMM_S3_RESUME_STATE
> 
> Dun:
>   To be compatible, I suggest to keep the same layout of
> SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used any
> more.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 duntan
> > 发送时间: 2024年5月28日 14:35
> > 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
> > 
> > 抄送: Ni, Ray ; Wang, Jian J 
> > 主题: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > MpService2Ppi field in SMM_S3_RESUME_STATE
> >
> > Hi Liming,
> >
> > Could you please help to review this patch?
> > This patch set is to simplify the X86 CPU SMM driver by removing most
> > of
> S3
> > related logics and we want to merge it as soon as possible.
> >
> > Thanks,
> > Dun
> >
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of duntan
> > Sent: Friday, May 17, 2024 5:46 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray ; Wang, Jian J ;
> Liming
> > Gao 
> > Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove
> > MpService2Ppi field in SMM_S3_RESUME_STATE
> >
> > This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP
> > to do the CPU initialization during smm s3 boot when the execution
> > mode of PEI
> and
> > DXE are the same.
> > Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP
> > anymore. The initialization for AP will be done in S3Resume.c before
> transfer to
> > CpuS3.c of smm cpu driver.
> > So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.
> >
> > Signed-off-by: Dun Tan 
> > Reviewed-by: Ray Ni 
> > Cc: Jian J Wang 
> > Cc: Liming Gao 
> > ---
> >  MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > index 72d173c4fd..6c7237727e 100644
> > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> > @@ -1,7 +1,7 @@
> >  /** @file
> >Definitions for data structures used in S3 resume.
> >
> > -Copyright (c) 2011 - 2023, Intel Corporation. All rights
> > reserved.
> > +Copyright (c) 2011 - 2024, Intel Corporation. All rights
> > +reserved.
> >
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -30,7 +30,6 @@ typedef struct {
> >EFI_PHYSICAL_ADDRESSReturnContext1;
> >EFI_PHYSICAL_ADDRESSReturnContext2;
> >EFI_PHYSICAL_ADDRESSReturnStackPointer;
> > -  EFI_PHYSICAL_ADDRESSMpService2Ppi;
> >EFI_PHYSICAL_ADDRESSSmst;
> >  } SMM_S3_RESUME_STATE;
> >
> > --
> > 2.31.1.windows.1
> >
> >
> >
> >
> >
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119297): https://edk2.groups.io/g/devel/message/119297
Mute This Topic: https://groups.io/mt/106345574/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi field in SMM_S3_RESUME_STATE

[gaoliming via groups.io]

Dun:
  To be compatible, I suggest to keep the same layout of
SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used any
more. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 duntan
> 发送时间: 2024年5月28日 14:35
> 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
> 
> 抄送: Ni, Ray ; Wang, Jian J 
> 主题: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
> 
> Hi Liming,
> 
> Could you please help to review this patch?
> This patch set is to simplify the X86 CPU SMM driver by removing most of
S3
> related logics and we want to merge it as soon as possible.
> 
> Thanks,
> Dun
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of duntan
> Sent: Friday, May 17, 2024 5:46 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Wang, Jian J ;
Liming
> Gao 
> Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi
> field in SMM_S3_RESUME_STATE
> 
> This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to do
> the CPU initialization during smm s3 boot when the execution mode of PEI
and
> DXE are the same.
> Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP
> anymore. The initialization for AP will be done in S3Resume.c before
transfer to
> CpuS3.c of smm cpu driver.
> So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE.
> 
> Signed-off-by: Dun Tan 
> Reviewed-by: Ray Ni 
> Cc: Jian J Wang 
> Cc: Liming Gao 
> ---
>  MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> index 72d173c4fd..6c7237727e 100644
> --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h
> +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h
> @@ -1,7 +1,7 @@
>  /** @file
>Definitions for data structures used in S3 resume.
> 
> -Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights reserved.
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> @@ -30,7 +30,6 @@ typedef struct {
>EFI_PHYSICAL_ADDRESSReturnContext1;
>EFI_PHYSICAL_ADDRESSReturnContext2;
>EFI_PHYSICAL_ADDRESSReturnStackPointer;
> -  EFI_PHYSICAL_ADDRESSMpService2Ppi;
>EFI_PHYSICAL_ADDRESSSmst;
>  } SMM_S3_RESUME_STATE;
> 
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119295): https://edk2.groups.io/g/devel/message/119295
Mute This Topic: https://groups.io/mt/106345448/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add gEdkiiS3MtrrSettingGuid

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 duntan
> 发送时间: 2024年5月28日 14:37
> 收件人: devel@edk2.groups.io; Tan, Dun ; Liming Gao
> 
> 抄送: Ni, Ray ; Wu, Jiaxin 
> 主题: Re: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add
> gEdkiiS3MtrrSettingGuid
> 
> Hi Liming,
> 
> Could you please help to review this patch?
> This patch set is to simplify the X86 CPU SMM driver by removing most of
S3
> related logics and we want to merge it as soon as possible.
> 
> Thanks,
> Dun
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of duntan
> Sent: Friday, May 17, 2024 5:46 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Liming Gao ; Wu,
> Jiaxin 
> Subject: [edk2-devel] [Patch V2 01/18] MdeModulePkg: Add
> gEdkiiS3MtrrSettingGuid
> 
> Add gEdkiiS3MtrrSettingGuid a new GUID for s3 MTRR setting. This GUID will
be
> used to save MTRR_SETTINGS at EndOfDxe by LockBox and restore at S3 boot
PEI
> phase for s3 usage.
> 
> Signed-off-by: Dun Tan 
> Reviewed-by: Ray Ni 
> Cc: Liming Gao 
> Cc: Jiaxin Wu 
> ---
>  MdeModulePkg/MdeModulePkg.dec | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index f7339f0aec..02f330a453 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -4,7 +4,7 @@
>  # and libraries instances, which are used for those modules.
>  #
>  # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved.
> -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2024, Intel Corporation. All rights
> +reserved.
>  # Copyright (c) 2016, Linaro Ltd. All rights reserved.  # (C)
Copyright 2016
> - 2019 Hewlett Packard Enterprise Development LP  # Copyright (c)
2017,
> AMD Incorporated. All rights reserved. @@ -465,6 +465,9 @@
>gEdk2JedecSfdpSpiDxeDriverGuid  = { 0xBE71701E, 0xB63C, 0x4574, { 0x9C,
> 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }}
>gEdk2JedecSfdpSpiSmmDriverGuid  = { 0x95A1E915, 0x195C, 0x477C,
> { 0x92, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }}
> 
> +  ## This GUID will be used to save MTRR_SETTINGS at EndOfDxe by LockBox
> and restore at S3 boot PEI phase for s3 usage.
> +  gEdkiiS3MtrrSettingGuid = { 0xd77baa84, 0xb332, 0x4463, { 0x9f, 0x1d,
> + 0xce, 0x81, 0x00, 0xfe, 0x7f, 0x35 }}
> +
>  [Ppis]
>## Include/Ppi/FirmwareVolumeShadowPpi.h
>gEdkiiPeiFirmwareVolumeShadowPpiGuid = { 0x7dfe756c, 0xed8d, 0x4d77,
> {0x9e, 0xc4, 0x39, 0x9a, 0x8a, 0x81, 0x51, 0x16 } }
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119294): https://edk2.groups.io/g/devel/message/119294
Mute This Topic: https://groups.io/mt/106345436/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[gaoliming via groups.io]

APIs based on Mbedtls ( 
<https://edk2.groups.io/g/devel/message/118772> 
https://edk2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It 
plans to catch this stable tag.

 

[Mike] This patch series uses ‘..’ in INF to access source files in another 
component.  This is not legal.  I am surprised this was not caught in code 
review.

 

DEFINE OPENSSL_PATH= ../OpensslLib/openssl

DEFINE BASE_CRYPT_PATH = ../BaseCryptLib

 

[Mike] I see a reference to some “platform integration” testing.  Given that 
this patch series implements a number of

crypto service APIs and is a large number of new lines of code, it would be 
good to know if all of the newly added APIs 

were tested in a platform integration. A table of the added APIs and the 
platform integration test status would be good to 

know if there was any functional testing of each API.  If there are APIs that 
are not covered by any platform integration 

testing, then I would be concerned with such a large change with limited 
testing.

 

Thanks

Liming

发件人:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io < 
<mailto:devel@edk2.groups.io> devel@edk2.groups.io> 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io;  
<mailto:annou...@edk2.groups.io> annou...@edk2.groups.io
抄送: 'Michael D Kinney' < <mailto:michael.d.kin...@intel.com> 
michael.d.kin...@intel.com>; 'Andrew Fish' < <mailto:af...@apple.com> 
af...@apple.com>; 'Leif Lindholm' < <mailto:quic_llind...@quicinc.com> 
quic_llind...@quicinc.com>
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi, all

 

  We enter into Soft Feature Freeze phase now. In this phase,

the feature under review will not be allowed to be pushed. The feature

passed review can still be merged.

 

  The patch review can continue without break in edk2 community. If the

patch is sent before Soft Feature Freeze, and plans to catch this stable tag, 
the

patch contributor need reply to his patch and notify edk2 community. If the

patch is sent after Soft Feature Freeze, and plans to catch this stable tag,

please add edk2-stable202405 key words in the patch title and BZ, so the

community know this patch target and give the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 stable tag release,

all edk2 maintainers' write access will be temporarily disabled until stable

tag is released on 05-24. That means edk2 maintainer can't set push label in

pull request after soft feature freeze starts.

 

  If the change wants to catch this stable tag 202405, please follow above

rules, then send the merge request to  <mailto:gaolim...@byosoft.com.cn> 
gaolim...@byosoft.com.cn or 

 <mailto:michael.d.kin...@intel.com> michael.d.kin...@intel.com.

 

  We will help merge the code change in soft feature freeze and hard feature

freeze phase. 

 

Below is edk2-stable202405 tag planning Proposed Schedule

Date (00:00:00 UTC-8) Description

 

2024-02-23 Beginning of development

2024-05-06 Soft Feature Freeze

2024-05-10 Hard Feature Freeze

2024-05-24 Release

 

Thanks

Liming

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119281): https://edk2.groups.io/g/devel/message/119281
Mute This Topic: https://groups.io/mt/106327381/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[gaoliming via groups.io]

 < 
<mailto:john.math...@intel.com> john.math...@intel.com>; Hou, Wenxing < 
<mailto:wenxing@intel.com> wenxing@intel.com>; Li, Yi1 < 
<mailto:yi1...@intel.com> yi1...@intel.com>; Yao, Jiewen < 
<mailto:jiewen@intel.com> jiewen@intel.com>; Kinney, Michael D < 
<mailto:michael.d.kin...@intel.com> michael.d.kin...@intel.com>
主题: RE: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi Liming,

 

My responses below in [Mike].

 

Mike

 

 

From: gaoliming < <mailto:gaolim...@byosoft.com.cn> gaolim...@byosoft.com.cn> 
Sent: Friday, May 10, 2024 8:29 AM
To:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io; Kinney, Michael D < 
<mailto:michael.d.kin...@intel.com> michael.d.kin...@intel.com>; 'Andrew Fish' 
< <mailto:af...@apple.com> af...@apple.com>; 'Leif Lindholm' < 
<mailto:quic_llind...@quicinc.com> quic_llind...@quicinc.com>
Cc: 'Ard Biesheuvel' < <mailto:a...@kernel.org> a...@kernel.org>;  
<mailto:sam.kay...@arm.com> sam.kay...@arm.com;  
<mailto:dougfl...@microsoft.com> dougfl...@microsoft.com; Mathews, John < 
<mailto:john.math...@intel.com> john.math...@intel.com>; Hou, Wenxing < 
<mailto:wenxing@intel.com> wenxing@intel.com>
Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Stewards:

  Now, there are several patches to catch this table tag. Could you give the 
comments for them?

 

1.  Adding support for verbose UEFI Table dumping to Dmem.c 
(https://edk2.groups.io/g/devel/message/118582)

[Liming] This patch set has been reviewed before soft feature freeze. It plans 
to catch this stable tag. 

 

[Mike] I see this PR:  <https://github.com/tianocore/edk2/pull/5653> 
https://github.com/tianocore/edk2/pull/5653 that is not passing CI and appears 
it will require additional code changes

 

[Mike] Reject for edk2-stable202405

 

2.  MdePkg/BaseLib: Fix AARCH64 compilation error 
(https://edk2.groups.io/g/devel/message/118690)

[Liming] This bug fix is reviewed in soft feature freeze phase. It plans to 
catch this stable tag. 

 

[Mike] Approved for edk2-stable202405

[Liming] I add push label for  <https://github.com/tianocore/edk2/pull/5642> 
https://github.com/tianocore/edk2/pull/5642

 

3.  MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount ( 
<https://edk2.groups.io/g/devel/message/118745> 
https://edk2.groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft feature freeze phase. It plans 
to catch this stable tag.

 

[Mike] Approved for edk2-stable202405

[Liming] I add push label for  <https://github.com/tianocore/edk2/pull/5659> 
https://github.com/tianocore/edk2/pull/5659

 

4.  NetworkPkg: CVE-2023-45236 and CVE-2023-45237 ( 
<https://edk2.groups.io/g/devel/message/118768> 
https://edk2.groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It plans to catch this 
stable tag.

 

[Mike] Is the code review complete?  Is there a link to the PR?

[Liming] NetworkPkg reviewer will review this patch set this week. 

 

Thanks

 

5.  Add more crypt APIs based on Mbedtls ( 
<https://edk2.groups.io/g/devel/message/118772> 
https://edk2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It 
plans to catch this stable tag.

 

[Mike] This patch series uses ‘..’ in INF to access source files in another 
component.  This is not legal.  I am surprised this was not caught in code 
review.

 

DEFINE OPENSSL_PATH= ../OpensslLib/openssl

DEFINE BASE_CRYPT_PATH = ../BaseCryptLib

 

[Mike] I see a reference to some “platform integration” testing.  Given that 
this patch series implements a number of

crypto service APIs and is a large number of new lines of code, it would be 
good to know if all of the newly added APIs 

were tested in a platform integration. A table of the added APIs and the 
platform integration test status would be good to 

know if there was any functional testing of each API.  If there are APIs that 
are not covered by any platform integration 

testing, then I would be concerned with such a large change with limited 
testing.

 

Thanks

Liming

发件人:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io < 
<mailto:devel@edk2.groups.io> devel@edk2.groups.io> 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人:  <mailto:devel@edk2.groups.io> devel@edk2.groups.io;  
<mailto:annou...@edk2.groups.io> annou...@edk2.groups.io
抄送: 'Michael D Kinney' < <mailto:michael.d.kin...@intel.com> 
michael.d.kin...@intel.com>; 'Andrew Fish' < <mailto:af...@apple.com> 
af...@apple.com>; 'Leif Lindholm' < <mailto:quic_llind...@quicinc.com> 
quic_llind...@quicinc.com>
主题: [edk2-devel] Soft Feature Freeze s

回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

[gaoliming via groups.io]

Jiewen:
  If the patch is urgent to be merged, I will help add push label to merge
it with current process. 
  
  If the patch is not urgent, it can be merged after TianoCore Code Review
is switched from email to GitHub Pull Requests on US Tuesday.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Yao, Jiewen
> 发送时间: 2024年5月27日 14:43
> 收件人: Lin, Du ; devel@edk2.groups.io
> 抄送: Ard Biesheuvel ; Gerd Hoffmann
> 
> 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
support
> new resource attributes
> 
> I have approved it.
> 
> What is the process to merge? There is no COMMIT button or PUSH label.
> 
> 
> > -Original Message-
> > From: Lin, Du 
> > Sent: Monday, May 27, 2024 2:23 PM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel ; Gerd Hoffmann
> > ; Yao, Jiewen ; Lin, Du
> > 
> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > support new resource attributes
> >
> > Thanks for the review and approval. Could you please help merge this
patch to
> > the upstream? A pull request has been created for this patch:
> > https://github.com/tianocore/edk2/pull/5644. Thanks.
> >
> > BRs,
> > Lin, Du
> >
> > -Original Message-
> > From: Yao, Jiewen 
> > Sent: Thursday, May 16, 2024 5:37 PM
> > To: devel@edk2.groups.io; Lin, Du 
> > Cc: Ard Biesheuvel ; Gerd Hoffmann
> > 
> > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > support new resource attributes
> >
> > Reviewed-by: Jiewen Yao 
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of Lin, Du
> > > Sent: Thursday, May 9, 2024 1:27 PM
> > > To: devel@edk2.groups.io
> > > Cc: Lin, Du ; Ard Biesheuvel
> > > ; Gerd Hoffmann ; Yao,
> > > Jiewen 
> > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > > support new resource attributes
> > >
> > > Encrypted and Special Purpose resource attributes are introduced in PI
> > > 1.8 Specification. This patch is to update VMM Hob list integrity
> > > check to recognise these resource attributes.
> > >
> > > Cc: Ard Biesheuvel 
> > > Cc: Gerd Hoffmann 
> > > Cc: Jiewen Yao 
> > > Signed-off-by: Du Lin 
> > > ---
> > >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > index b6085eab44..19e9b1bf54 100644
> > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > @@ -643,6 +643,8 @@ ValidateHobList (
> > >
> > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE |
> > >
> > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED |
> > >
> > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE |
> > > +
> > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED|
> > > +
> > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE |
> > >
> > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0)
> > >  {
> > >DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor
> > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor-
> > > >ResourceAttribute));
> > > --
> > > 2.44.0.windows.1
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119277): https://edk2.groups.io/g/devel/message/119277
Mute This Topic: https://groups.io/mt/106326539/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0.

[gaoliming via groups.io]

Ray:

  This PR doesn’t pass CI. Please check.

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Ni, Ray
发送时间: 2024年5月25日 9:35
收件人: Feng, Ning ; devel@edk2.groups.io; Ni, Ray
; Gao, Liming 
主题: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0.

 

I created PR for merge: UefiCpuPkg/MpLib:Do not assume BSP is #0. by niruiyu
・ Pull Request #5683 ・ tianocore/edk2 (github.com)
 

But, I cannot set "push" label.

 

  @Gao, Liming?

 

Thanks,

Ray

  _  

From: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> > on behalf of Ni, Ray
mailto:ray...@intel.com> >
Sent: Saturday, May 25, 2024 9:32
To: Feng, Ning mailto:ning.f...@intel.com> >;
devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0. 

 

Reviewed-by: Ray Ni mailto:ray...@intel.com> >

 

Thanks,

Ray

  _  

From: Feng, Ning mailto:ning.f...@intel.com> >
Sent: Saturday, May 25, 2024 15:42
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >
Cc: Feng, Ning mailto:ning.f...@intel.com> >; Ni, Ray
mailto:ray...@intel.com> >
Subject: [PATCH] UefiCpuPkg/MpLib:Do not assume BSP is #0. 

 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4778
MPInitlib have wrong expectation that BSP index should always be 0 in
MpInitLibInitialize(), SwitchBsp(),ApWakeupFunction().
That will cause the data mismatch, if the initial BSP is not 0.
Cc: Ray Ni mailto:ray...@intel.com> >
Signed-off-by: Ning Feng mailto:ning.f...@intel.com> >
---
 UefiCpuPkg/Library/MpInitLib/MpLib.c | 47 ++--
 1 file changed, 30 insertions(+), 17 deletions(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c
b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index d724456502..ba497cbfd9 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -114,6 +114,10 @@ FutureBSPProc (
   SaveVolatileRegisters (>APInfo.VolatileRegisters);

   AsmExchangeRole (>APInfo, >BSPInfo);

   RestoreVolatileRegisters (>APInfo.VolatileRegisters, FALSE);

+  //

+  // Restore VolatileReg saved in CpuMpData->CpuData

+  //

+  CopyMem (>CpuData[DataInHob->BspNumber].VolatileRegisters,
>APInfo.VolatileRegisters, sizeof (CPU_VOLATILE_REGISTERS));

 }

 

 /**

@@ -761,11 +765,11 @@ ApWakeupFunction (
   BistData = (UINT32)ApStackData->Bist;

 

   //

-  // CpuMpData->CpuData[0].VolatileRegisters is initialized based on
BSP environment,

+  // CpuMpData->CpuData[BspNumber].VolatileRegisters is initialized
based on BSP environment,

   //   to initialize AP in InitConfig path.

-  // NOTE: IDTR.BASE stored in CpuMpData->CpuData[0].VolatileRegisters
points to a different IDT shared by all APs.

+  // NOTE: IDTR.BASE stored in
CpuMpData->CpuData[BspNumber].VolatileRegisters points to a different IDT
shared by all APs.

   //

-  RestoreVolatileRegisters (>CpuData[0].VolatileRegisters,
FALSE);

+  RestoreVolatileRegisters
(>CpuData[CpuMpData->BspNumber].VolatileRegisters, FALSE);

   InitializeApData (CpuMpData, ProcessorNumber, BistData,
ApTopOfStack);

   ApStartupSignalBuffer =
CpuMpData->CpuData[ProcessorNumber].StartupApSignal;

 } else {

@@ -798,10 +802,10 @@ ApWakeupFunction (
 // 1. AP is re-enabled after it's disabled, in either PEI or DXE
phase.

 // 2. AP is initialized in DXE phase.

 // In either case, use the volatile registers value derived from
BSP.

-// NOTE: IDTR.BASE stored in
CpuMpData->CpuData[0].VolatileRegisters points to a

+// NOTE: IDTR.BASE stored in
CpuMpData->CpuData[BspNumber].VolatileRegisters points to a

 //   different IDT shared by all APs.

 //

-RestoreVolatileRegisters (>CpuData[0].VolatileRegisters,
FALSE);

+RestoreVolatileRegisters
(>CpuData[CpuMpData->BspNumber].VolatileRegisters, FALSE);

   } else {

 if (CpuMpData->ApLoopMode == ApInHltLoop) {

   //

@@ -927,7 +931,7 @@ DxeApEntryPoint (
 AsmWriteMsr64 (MSR_IA32_EFER, EferMsr.Uint64);

   }

 

-  RestoreVolatileRegisters (>CpuData[0].VolatileRegisters,
FALSE);

+  RestoreVolatileRegisters
(>CpuData[CpuMpData->BspNumber].VolatileRegisters, FALSE);

   InterlockedIncrement ((UINT32 *)>FinishedCount);

   PlaceAPInMwaitLoopOrRunLoop (

 CpuMpData->ApLoopMode,

@@ -2151,11 +2155,16 @@ MpInitLibInitialize (
   CpuMpData->BackupBufferSize = ApResetVectorSizeBelow1Mb;

   CpuMpData->WakeupBuffer = (UINTN)-1;

   CpuMpData->CpuCount = 1;

-  CpuMpData->BspNumber= 0;

-  CpuMpData->WaitEvent= NULL;

-  CpuMpData->SwitchBspFlag= FALSE;

-  CpuMpData->CpuData  = (CPU_AP_DATA *)(CpuMpData + 1);

-  CpuMpData->CpuInfoInHob = (UINT64)(UINTN)(CpuMpData->CpuData +
MaxLogicalProcessorNumber);

+  if (FirstMpHandOff == NULL) {

+   

回复: [edk2-devel] 回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Doug:

  What’s impact if no EFI_HASH2_PROTOCOL? Does network boot work or not?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Doug Flick via groups.io
发送时间: 2024年5月25日 0:51
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: 
CVE-2023-45236 and CVE-2023-45237

 

To be clear, it requires EFI_RNG_PROTOCOL and EFI_HASH2_PROTOCOL. Both should 
be mentioned in the release notes





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119265): https://edk2.groups.io/g/devel/message/119265
Mute This Topic: https://groups.io/mt/106294144/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Hi, all

Because this patch fixes two CVE, I decide to include them in this stable
tag 202405. 

https://github.com/tianocore/edk2/pull/5582 has been merged. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 gaoliming via
> groups.io
> 发送时间: 2024年5月24日 22:51
> 收件人: devel@edk2.groups.io; kra...@redhat.com; 'Ard Biesheuvel'
> 
> 抄送: dougfl...@microsoft.com; 'Michael D Kinney'
> ; 'Andrew Fish' ;
> quic_llind...@quicinc.com
> 主题: 回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
> Gerd and Ard:
>   Thanks for your comments. I understand this CVE fix requires
> EFI_RNG_PROTOCOL. I will add this requirement in the release note.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Gerd
> Hoffmann
> > 发送时间: 2024年5月24日 19:49
> > 收件人: Ard Biesheuvel 
> > 抄送: devel@edk2.groups.io; gaolim...@byosoft.com.cn;
> > dougfl...@microsoft.com; Michael D Kinney ;
> > Andrew Fish ; quic_llind...@quicinc.com
> > 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> > CVE-2023-45237
> >
> > On Fri, May 24, 2024 at 11:41:04AM GMT, Ard Biesheuvel wrote:
> > > On Fri, 24 May 2024 at 11:12, gaoliming via groups.io
> > >  wrote:
> > > >
> > > > Ard:
> > > >   Here is Doug PR https://github.com/tianocore/edk2/pull/5582 that
> > includes 20 commits. You can check them.
> > > >
> > >
> > > This looks fine to me in principle.
> > >
> > > Reviewed-by: Ard Biesheuvel 
> > >
> > > However, IIUC, the impact of this series is that all out-of-tree
> > > platforms that lack the right implementation of the EFI_RNG_PROTOCOL
> > > (i.e., using a GUID that appears in the allowlist) will lose the
> > > ability to do network boot. If that is a tolerable result, I am fine
> > > with that too, but I think it needs to be made very clear in the
> > > stable tag release notes.
> >
> > Tested the v3 series with OVMF, results are as expected:  Without
> > virtio-rng-pci network boot does not work.  With virtio-rng-pci
> > everything is fine.
> >
> > Tested-by: Gerd Hoffmann 
> > Acked-by: Gerd Hoffmann 
> >
> > Agree that this must be noted in the release notes.
> >
> > Related: I'm working on patch series adding RngDxe to OVMF with
> > runtime rdrand detection:
> > https://github.com/kraxel/edk2/commits/devel/ovmf-rdrand/
> >
> > take care,
> >   Gerd
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119258): https://edk2.groups.io/g/devel/message/119258
Mute This Topic: https://groups.io/mt/106284249/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Gerd and Ard:
  Thanks for your comments. I understand this CVE fix requires
EFI_RNG_PROTOCOL. I will add this requirement in the release note. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Gerd Hoffmann
> 发送时间: 2024年5月24日 19:49
> 收件人: Ard Biesheuvel 
> 抄送: devel@edk2.groups.io; gaolim...@byosoft.com.cn;
> dougfl...@microsoft.com; Michael D Kinney ;
> Andrew Fish ; quic_llind...@quicinc.com
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
> On Fri, May 24, 2024 at 11:41:04AM GMT, Ard Biesheuvel wrote:
> > On Fri, 24 May 2024 at 11:12, gaoliming via groups.io
> >  wrote:
> > >
> > > Ard:
> > >   Here is Doug PR https://github.com/tianocore/edk2/pull/5582 that
> includes 20 commits. You can check them.
> > >
> >
> > This looks fine to me in principle.
> >
> > Reviewed-by: Ard Biesheuvel 
> >
> > However, IIUC, the impact of this series is that all out-of-tree
> > platforms that lack the right implementation of the EFI_RNG_PROTOCOL
> > (i.e., using a GUID that appears in the allowlist) will lose the
> > ability to do network boot. If that is a tolerable result, I am fine
> > with that too, but I think it needs to be made very clear in the
> > stable tag release notes.
> 
> Tested the v3 series with OVMF, results are as expected:  Without
> virtio-rng-pci network boot does not work.  With virtio-rng-pci
> everything is fine.
> 
> Tested-by: Gerd Hoffmann 
> Acked-by: Gerd Hoffmann 
> 
> Agree that this must be noted in the release notes.
> 
> Related: I'm working on patch series adding RngDxe to OVMF with
> runtime rdrand detection:
> https://github.com/kraxel/edk2/commits/devel/ovmf-rdrand/
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119256): https://edk2.groups.io/g/devel/message/119256
Mute This Topic: https://groups.io/mt/106282939/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Ard:
  Here is Doug PR https://github.com/tianocore/edk2/pull/5582 that includes 20 
commits. You can check them. 

Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel 
> 发送时间: 2024年5月24日 15:07
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: dougfl...@microsoft.com; kra...@redhat.com; Michael D Kinney
> ; Andrew Fish ;
> quic_llind...@quicinc.com
> 主题: Re: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
> On Fri, 24 May 2024 at 09:01, gaoliming via groups.io
>  wrote:
> >
> > Ard and Gerd:
> >   Doug updated this patch set based on your suggestion. Could you give
> > reviewed-by or acked-by for the changes in OvmfPkg and ArmVirtPkg if you
> > have no other comments?
> >
> 
> I see ~60 patches from Doug, seemingly 3 copies of the v3 series. I am
> going to assume they are identical.
> 
> The changes I contributed should appear at the beginning of the
> series, not the end, so that bisect does not get broken.
> 
> Perhaps Doug could send a v4 (only once!) that has everything in the
> correct order, and I will look at it.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119252): https://edk2.groups.io/g/devel/message/119252
Mute This Topic: https://groups.io/mt/106278281/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Ard and Gerd:
  Doug updated this patch set based on your suggestion. Could you give
reviewed-by or acked-by for the changes in OvmfPkg and ArmVirtPkg if you
have no other comments?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月24日 13:45
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao 
> 主题: [edk2-devel] [PATCH v3 00/20] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
> 
>
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-
edk-ii-
> ipv6-network-stack.html
> 
> This patch series patches the following CVEs:
> - CVE-2023-45236: Predictable TCP Initial Sequence Numbers
> - CVE-2023-45237: Use of a Weak PseudoRandom Number Generator
> 
> In order to patch these CVEs, the following changes were made:
> - NetworkPkg no longer performs it's own random number generation,
>   instead it uses EFI_RNG_PROTOCOL provided by the plaform to
>   generate random numbers.
>   - This change was made such that any future random number
> generation vulnerabilities will be a result of the platforms
> implementation of the EFI_RNG_PROTOCOL and not the NetworkPkg
> 
> - NetworkPkg uses the TCP initial sequence number algorithm as described
>   in RFC 6528 to generate the initial sequence number for TCP connections.
>   - This change was made to ensure that the initial sequence number
> is not predictable and therefore cannot be used in a TCP hijacking
> attack.
> 
> In addition to the above changes, the following changes were made:
> - EmulatorPkg OvmfPkg, and ArmVirtPkg were updated to include the
>   Hash2DxeCrypto driver to support TCP ISN generation using
>   EFI_HASH2_PROTOCOL
> 
> - EmulatorPkg was updated to include the
>   RngDxe driver to support random number generation using the
>   EFI_RNG_PROTOCOL
> 
> - OvmfPkg, and ArmVirtPkg were updated to include the
>   virtio-rng-pci device to support random number generation using the
>   EFI_RNG_PROTOCOL using the existing VirtioRngDxe driver
> 
> - SecurityPkg was updated to fix an incorrect limitation on the
>   GetRng function in the RngDxe driver where the minimum amount of
>   random data that could be requested was 32 bytes (256 bits) instead
>   of what the caller requested
> 
> - MdePkg was updated to include MockUefiBootServicesTableLib,
>   MockRng, and MockHash2 protocols for testing
> 
> - NetworkPkg was updated to include a test for the PxeBcDhcp6 driver
>   due to underlying changes
> 
> - ArmPkg was updated to allow the SMC/HVC monitor conduit to be
>   specified at runtime
> 
> - MdePkg was updated to remove an overzealous ASSERT in BaseRngLib
> 
> - ArmVirtPkg was updated to permit the use of dynamic PCDs in PEI
> 
> - ArmVirtPkg was updated to use dynamic PCDs to set the SMCCC conduit
> 
> - ArmVirtPkg was updated to add the RngDxe driver
> 
> Cc: Liming Gao 
> 
> Signed-off-by: Doug Flick [MSFT] 
> 
> Ard Biesheuvel (6):
>   ArmPkg: Allow SMC/HVC monitor conduit to be specified at runtime
>   MdePkg/BaseRngLib AARCH64: Remove overzealous ASSERT()
>   ArmVirtPkg/ArmVirtQemu: Permit the use of dynamic PCDs in PEI
>   ArmVirtPkg: Use dynamic PCD to set the SMCCC conduit
>   ArmVirtPkg: Reverse inclusion order of MdeLibs.inc and ArmVirt.dsc.inc
>   ArmVirtPkg/ArmVirtQemu: Add RngDxe driver
> 
> Doug Flick (8):
>   EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg
>   OvmfPkg: : Add Hash2DxeCrypto to OvmfPkg
>   NetworkPkg:: SECURITY PATCH CVE-2023-45237
>   NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236
>   MdePkg: : Add MockUefiBootServicesTableLib
>   MdePkg: : Adds Protocol for MockRng
>   MdePkg: Add MockHash2 Protocol for testing
>   NetworkPkg: Update the PxeBcDhcp6GoogleTest due to underlying changes
> 
> Flickdm (6):
>   EmulatorPkg: : Add RngDxe to EmulatorPkg
>   OvmfPkg:PlatformCI: Support virtio-rng-pci
>   ArmVirtPkg:PlatformCI: Support virtio-rng-pci
>   ArmVirtPkg: : Add Hash2DxeCrypto to ArmVirtPkg
>   SecurityPkg: RngDxe: Remove incorrect limitation on GetRng
>   ArmVirtPkg: Move PcdMonitorConduitHvc
> 
>  ArmPkg/ArmPkg.dec
> |  10 +-
>  NetworkPkg/NetworkPkg.dec
> |   7 +
>  ArmVirtPkg/ArmVirt.dsc.inc
> |   5 +-
>  ArmVirtPkg/ArmVirtCloudHv.dsc
> |   3 +
>  ArmVirtPkg/ArmVirtKvmTool.dsc
> |   4 +-
>  ArmVirtPkg/ArmVirtQemu.dsc
> |  20 +-
>  ArmVirtPkg/ArmVirtQemuKernel.dsc
> |  12 +-
>  ArmVirtPkg/ArmVirtXen.dsc
> |   6 +-
>  EmulatorPkg/EmulatorPkg.dsc
> |  14 +-
>  MdePkg/Test/MdePkgHostTest.dsc
> |   1 +
>  NetworkPkg/Test/NetworkPkgHostTest.dsc
> |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc
> |   6 +-
>  OvmfPkg/OvmfPkgIa32X64.dsc
> |   6 +-
>  OvmfPkg/OvmfPkgX64.dsc
> |   6 +-
>  OvmfPkg/OvmfXen.dsc
> |   5 +
>  ArmVirtPkg/ArmVirtQemu.fdf
> |   2 +-
>  EmulatorPkg/EmulatorPkg.fdf
> |  11 +-
>  OvmfPkg/OvmfPkgIa32.fdf
> |   5 +
>  OvmfPkg/OvmfPkgIa32X64.fdf
> |   5 +
>  OvmfPkg/OvmfPkgX64.fdf
> |   5 +
>  OvmfPkg/OvmfXen.fdf
> |   5 +
>  ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.inf
> |   1 +
> 
> 

回复: [edk2-devel] [PATCH v3 16/20] MdePkg/BaseRngLib AARCH64: Remove overzealous ASSERT()

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月24日 13:45
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu 
> 主题: [edk2-devel] [PATCH v3 16/20] MdePkg/BaseRngLib AARCH64: Remove
> overzealous ASSERT()
> 
> From: Ard Biesheuvel 
> 
> BaseRngLib on AARCH64 will discover whether or not RNDR instructions are
> supported, by inspecting the ISAR0 identification register, and setting
> a global boolean accordingly. This boolean is used in subsequent
> execution to decide whether or not to issue the instruction.
> 
> The same discovery code also ASSERT()s that RNDR instructions are
> implemented, which is unnecessary, and breaks execution on systems that
> incorporate the library but don't implement the instruction (or fail to
> expose it to the exception level that the firmware executes at).
> 
> So drop the ASSERT().
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> 
> Committed-by: Ard Biesheuvel 
> Signed-off-by: Doug Flick [MSFT] 
> ---
>  MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> index d39db62153..3a556a2e3f 100644
> --- a/MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> +++ b/MdePkg/Library/BaseRngLib/AArch64/Rndr.c
> @@ -50,7 +50,6 @@ BaseRngLibConstructor (
>// MSR. A non-zero value indicates that the processor supports the RNDR
> instruction.
> 
>//
> 
>Isar0 = ArmReadIdIsar0 ();
> 
> -  ASSERT ((Isar0 & RNDR_MASK) != 0);
> 
> 
> 
>mRndrSupported = ((Isar0 & RNDR_MASK) != 0);
> 
> 
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#119243): https://edk2.groups.io/g/devel/message/119243
> Mute This Topic: https://groups.io/mt/106276868/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119247): https://edk2.groups.io/g/devel/message/119247
Mute This Topic: https://groups.io/mt/106277273/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

[gaoliming via groups.io]

Doug:
  Have you any update for this patch set?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Gerd Hoffmann
> 发送时间: 2024年5月17日 17:48
> 收件人: devel@edk2.groups.io; a...@kernel.org
> 抄送: Doug Flick ; Jiewen Yao
> ; Liming Gao (Byosoft address)
> 
> 主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v2 03/13]
> OvmfPkg:PlatformCI: Support virtio-rng-pci
> 
> On Fri, May 17, 2024 at 09:27:53AM GMT, Ard Biesheuvel wrote:
> > On Fri, 17 May 2024 at 05:27, Doug Flick via groups.io
> >  wrote:
> > >
> > > On ARM, we can actually do better than this: I have taken Doug's v2
and
> applied some changes on top to make it work with ArmVirtQemu.
> > >
> > > https://github.com/ardbiesheuvel/edk2/tree/doug-v2
> > >
> > > Ard, would you be comfortable with this patch series if I take the
commits
> you're suggesting? I'm being asked to see what it would take to get these
commits
> in for this release.
> >
> > I won't object to that, but I'd like Gerd's take as well, given that a
> > similar concern appears to apply to OVMF/x86 IIUC.
> 
> I think including RngDxe in OvmfPkg is not an option.  That would
> be a silent regression on the random number quality delivered by
> EFI_RNG_PROTOCOL because OvmfPkg uses BaseRngLibTimerLib.
> 
> Switching to BaseRngLib is an easy way out for physical platforms
> with a sufficient recent processor.  OVMF can not assume the rdrand
> instruction is available, so that is not possible.
> 
> So short-term (i.e. 2024-05 stable tag) the only option I see is
> depending on virtio-rng.  Which is a regression too (network booting
> without '-device virtio-rng-pci' breaks), but it is an obvious failure
> with an easy fix.  Not an ideal solution, but much better than a
> regression which can easily go unnoticed.
> 
> Longer term it probably makes sense to have a EFI_RNG_PROTOCOL driver
> using the rdrand instruction and runtime detection whenever the
> instruction is available or not.  Either by adapting RngDxe accordingly,
> or by having an OVMF-specific driver handling the runtime detection.
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119180): https://edk2.groups.io/g/devel/message/119180
Mute This Topic: https://groups.io/mt/106275345/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236

[gaoliming via groups.io]

Saloni:

  Have you any other comments for this patch?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Doug Flick via groups.io
发送时间: 2024年5月22日 3:29
收件人: Saloni Kasbekar ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 09/13] NetworkPkg: TcpDxe: SECURITY PATCH 
CVE-2023-45236

 

This was more of a design decision. Both Hash2Protocol and HashLib serve 
similar purposes. The goal was to use Hash2Protocol to decouple and provide 
greater modularity and flexibility over HashLib.





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119169): https://edk2.groups.io/g/devel/message/119169
Mute This Topic: https://groups.io/mt/106274103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[gaoliming via groups.io]

e/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It 
plans to catch this stable tag.

 

[Mike] This patch series uses ‘..’ in INF to access source files in another 
component.  This is not legal.  I am surprised this was not caught in code 
review.

 

DEFINE OPENSSL_PATH= ../OpensslLib/openssl

DEFINE BASE_CRYPT_PATH = ../BaseCryptLib

 

[Mike] I see a reference to some “platform integration” testing.  Given that 
this patch series implements a number of

crypto service APIs and is a large number of new lines of code, it would be 
good to know if all of the newly added APIs 

were tested in a platform integration. A table of the added APIs and the 
platform integration test status would be good to 

know if there was any functional testing of each API.  If there are APIs that 
are not covered by any platform integration 

testing, then I would be concerned with such a large change with limited 
testing.

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  mailto:devel@edk2.groups.io> > 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; 
annou...@edk2.groups.io <mailto:annou...@edk2.groups.io> 
抄送: 'Michael D Kinney' mailto:michael.d.kin...@intel.com> >; 'Andrew Fish' mailto:af...@apple.com> >; 'Leif Lindholm' mailto:quic_llind...@quicinc.com> >
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi, all

 

  We enter into Soft Feature Freeze phase now. In this phase,

the feature under review will not be allowed to be pushed. The feature

passed review can still be merged.

 

  The patch review can continue without break in edk2 community. If the

patch is sent before Soft Feature Freeze, and plans to catch this stable tag, 
the

patch contributor need reply to his patch and notify edk2 community. If the

patch is sent after Soft Feature Freeze, and plans to catch this stable tag,

please add edk2-stable202405 key words in the patch title and BZ, so the

community know this patch target and give the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 stable tag release,

all edk2 maintainers' write access will be temporarily disabled until stable

tag is released on 05-24. That means edk2 maintainer can't set push label in

pull request after soft feature freeze starts.

 

  If the change wants to catch this stable tag 202405, please follow above

rules, then send the merge request to gaolim...@byosoft.com.cn 
<mailto:gaolim...@byosoft.com.cn>  or 

michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> .

 

  We will help merge the code change in soft feature freeze and hard feature

freeze phase. 

 

Below is edk2-stable202405 tag planning Proposed Schedule

Date (00:00:00 UTC-8) Description

 

2024-02-23 Beginning of development

2024-05-06 Soft Feature Freeze

2024-05-10 Hard Feature Freeze

2024-05-24 Release

 

Thanks

Liming

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119105): https://edk2.groups.io/g/devel/message/119105
Mute This Topic: https://groups.io/mt/106223956/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache buffer in PEI

[gaoliming via groups.io]

Dun:
  Is there a Bugzilla for this change?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 duntan
> 发送时间: 2024年5月17日 17:49
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni ; Liming Gao ;
> Jiaxin Wu ; Ard Biesheuvel
;
> Leif Lindholm ; Sami Mujawar
> ; Gerd Hoffmann ; Andrew Fish
> ; Jiewen Yao 
> 主题: [edk2-devel] [PATCH 0/9] Allocate and unblock variable runtime cache
> buffer in PEI
> 
> This patch set defines a new VARIABLE_RUNTIME_CACHE_INFO HOB. The HOB is
> used to store the address and size of the buffer that will be used for
variable
> runtime service when the PcdEnableVariableRuntimeCache is TRUE.
> In following patches, when PcdEnableVariableRuntimeCache is TRUE,
VariablePei
> will install a callback of gEfiPeiMemoryDiscoveredPpiGuid to allocate the
needed
> buffer for different type variable runtime cache and build the HOB.
> Then VariableSmmRuntimeDxe driver will consume
> gEdkiiVariableRuntimeCacheInfoHobGuid to initialize the variable runtime
cache
> related content. The code to allocate and unblock the runtime cache buffer
in
> VariableSmmRuntimeDxe is also removed in this patc set.
> 
> PR for review: https://github.com/tianocore/edk2/pull/5607
> 
> Cc: Ray Ni 
> Cc: Liming Gao 
> Cc: Jiaxin Wu 
> Cc: Ard Biesheuvel 
> Cc: Leif Lindholm 
> Cc: Sami Mujawar 
> Cc: Gerd Hoffmann 
> Cc: Andrew Fish 
> Cc: Jiewen Yao 
> 
> Dun Tan (9):
>   MdeModulePkg:Add new gEdkiiVariableRuntimeCacheInfoHobGuid
>   ArmVirtPkg: Add MmUnblockMemoryLib in DSC
>   EmulatorPkg: Add MmUnblockMemoryLib in DSC
>   OvmfPkg: Add MmUnblockMemoryLib in DSC
>   MdeModulePkg:Create gEdkiiVariableRuntimeCacheInfoHobGuid
>   MdeModulePkg:Remove unnecessary global variable
>   MdeModulePkg:Consume gEdkiiVariableRuntimeCacheInfoHobGuid
>   MdeModulePkg: Refine InitVariableCache()
>   MdeModulePkg:Add global variable mVariableRtCacheInfo
> 
>  ArmVirtPkg/ArmVirtCloudHv.dsc
> |   2 ++
>  EmulatorPkg/EmulatorPkg.dsc
> |   1 +
>  MdeModulePkg/Include/Guid/VariableRuntimeCacheInfo.h
> |  65
> +
> 
>  MdeModulePkg/MdeModulePkg.dec
> |   3 +++
>  MdeModulePkg/Universal/Variable/Pei/Variable.c   |
> 298
> +
> +
> +
> +
> +-
>  MdeModulePkg/Universal/Variable/Pei/Variable.h   |
> 3 +++
>  MdeModulePkg/Universal/Variable/Pei/VariablePei.inf  |
> 8 +++-
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c
> | 293
> +
> +
>
++--
-
> --
>  MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf |
> 5 +++--
>  OvmfPkg/OvmfPkgIa32X64.dsc
> |   2 +-
>  10 files changed, 506 insertions(+), 174 deletions(-)
>  create mode 100644
> MdeModulePkg/Include/Guid/VariableRuntimeCacheInfo.h
> 
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119070): https://edk2.groups.io/g/devel/message/119070
Mute This Topic: https://groups.io/mt/106196627/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/1] Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute.

[gaoliming via groups.io]

Patrick:
  Commit message needs package name MdePkg. 

  One comment for the change is below. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Michael Kubacki
> 发送时间: 2024年5月17日 4:20
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Michael D Kinney
> 
> 主题: [edk2-devel] [PATCH v1 1/1] Add the
> EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute.
> 
> From: Patrick Payne 
> 
> Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE resource attribute as
> per the PI 1.8 spec. This flag is used to indicate that the memory
> should be treated as special purpose memory (SPM).
> 
> Also adds GCD code that marks the SPM with the EFI_MEMORY_SP bit and
> sets the GCD memory type to EfiGcdMemoryTypeSystemMemory.
> 
> Cc: Liming Gao 
> Cc: Michael D Kinney 
> Signed-off-by: Patrick Payne 
> ---
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 12 +++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> index fe1bbd6974b7..c941fe941276 100644
> --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
> @@ -26,7 +26,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> EFI_RESOURCE_ATTRIBUTE_16_BIT_IO   | \
> 
> EFI_RESOURCE_ATTRIBUTE_32_BIT_IO   | \
> 
> EFI_RESOURCE_ATTRIBUTE_64_BIT_IO   | \
> -
> EFI_RESOURCE_ATTRIBUTE_PERSISTENT  )
> +
> EFI_RESOURCE_ATTRIBUTE_PERSISTENT  | \
> +
> EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE )
> 
>  #define TESTED_MEMORY_ATTRIBUTES
> (EFI_RESOURCE_ATTRIBUTE_PRESENT | \
> 
> EFI_RESOURCE_ATTRIBUTE_INITIALIZED | \
> @@ -92,6 +93,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY
> mAttributeConversionTable[] = {
>{ EFI_RESOURCE_ATTRIBUTE_TESTED,
> EFI_MEMORY_TESTED,FALSE },
>{ EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV,
> TRUE  },
>{ EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE,
> EFI_MEMORY_MORE_RELIABLE, TRUE  },
> +  { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP,
> TRUE  },
>{ 0,  0,
> FALSE }
>  };
> 
> @@ -691,6 +693,10 @@ ConverToCpuArchAttributes (
>  CpuArchAttributes |= EFI_MEMORY_WP;
>}
> 
> +  if ((Attributes & EFI_MEMORY_SP) == EFI_MEMORY_SP) {
> +CpuArchAttributes |= EFI_MEMORY_SP;
> +  }
> +
>return CpuArchAttributes;
>  }
> 
> @@ -2660,6 +2666,10 @@ CoreInitializeGcdServices (
>  GcdMemoryType = EfiGcdMemoryTypePersistent;
>}
> 
> +  if ((ResourceHob->ResourceAttribute &
> EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE) ==
> EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE) {
> +GcdMemoryType = EfiGcdMemoryTypeSystemMemory;
> +  }
> +
[Liming] The type memory is earmarked for specific purposes such as for
specific device drivers or applications. So, its Gcd memory type may be
EfiGcdMemoryTypeReserved. 
Then, this memory range can't be allocated as the normal system memory. 

Thanks
Liming
>break;
>  case EFI_RESOURCE_MEMORY_MAPPED_IO:
>  case EFI_RESOURCE_FIRMWARE_DEVICE:
> --
> 2.45.1.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#118972): https://edk2.groups.io/g/devel/message/118972
> Mute This Topic: https://groups.io/mt/106142180/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118983): https://edk2.groups.io/g/devel/message/118983
Mute This Topic: https://groups.io/mt/106149241/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from header file (BZ# 4775)

[gaoliming via groups.io]

Abner:
  This change is good to me. Reviewed-by: Liming Gao 

  But, this is not critical issue. So, I suggest to merge it after the stable 
tag. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Chang, Abner via
> groups.io
> 发送时间: 2024年5月16日 8:50
> 收件人: Hsueh, Hong-Chih (Neo) ;
> devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; He, Jiangang 
> 主题: Re: [edk2-devel] [PATCH] MdePkg: Remove non-ASCII characters from
> header file (BZ# 4775)
> 
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Mike, Liming and Zhiguang,
> Could you please check this patch sent two weeks ago? The corresponding BZ
> ticket is 4775. We overlooked tracking this issue and missed the 202405 stable
> release. As this impacts the build, do you think we can have a quick review 
> and
> approve it; having this change pulled in 202405 stable release? Otherwise we 
> will
> have to wait until next stable release.
> 
> Thanks
> Abner
> 
> > -Original Message-
> > From: Hsueh, Hong-Chih (Neo) 
> > Sent: Thursday, May 2, 2024 3:31 AM
> > To: devel@edk2.groups.io
> > Cc: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> > zhiguang@intel.com; He, Jiangang ; Chang,
> > Abner ; Hsueh, Hong-Chih (Neo)  > chih.hs...@amd.com>
> > Subject: [PATCH] MdePkg: Remove non-ASCII characters from header file
> >
> > Cc: Jiangang He 
> > Signed-off-by: Neo Hsueh 
> > ---
> >  MdePkg/Include/Register/Amd/Cpuid.h  | 4 ++--
> >  MdePkg/Include/Register/Intel/ArchitecturalMsr.h | 8 
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/MdePkg/Include/Register/Amd/Cpuid.h
> > b/MdePkg/Include/Register/Amd/Cpuid.h
> > index add43c40aa..51fa9f235c 100644
> > --- a/MdePkg/Include/Register/Amd/Cpuid.h
> > +++ b/MdePkg/Include/Register/Amd/Cpuid.h
> > @@ -46,9 +46,9 @@ CPUID Signature Information
> >CPUID Extended Topology Enumeration
> >
> >@note
> > -  Reference: AMD64 Architecture Programmer’s Manual Volume 3: General-
> > Purpose and System Instructions,
> > +  Reference: AMD64 Architecture Programmer's Manual Volume 3: General-
> > Purpose and System Instructions,
> >   Revision 3.35 Appendix E,
> > -  E.4.24 Function 8000_0026—Extended CPU Topology:
> > +  E.4.24 Function 8000_0026-Extended CPU Topology:
> >  CPUID Fn8000_0026 reports extended topology information for logical
> > processors, including
> >  asymmetric and heterogenous topology descriptions. Individual logical
> > processors may report
> >  different values in systems with asynchronous and heterogeneous
> > topologies.
> > diff --git a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > index 756e7c86ec..4715c59dc4 100644
> > --- a/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > +++ b/MdePkg/Include/Register/Intel/ArchitecturalMsr.h
> > @@ -5733,9 +5733,9 @@ typedef union {
> >  /// [Bit 7:4] TME Policy/Encryption Algorithm: Only algorithms
> enumerated
> > in
> >  /// IA32_TME_CAPABILITY are allowed.
> >  /// For example:
> > -///    – AES-XTS-128.
> > -///   0001 – AES-XTS-128 with integrity.
> > -///   0010 – AES-XTS-256.
> > +///    - AES-XTS-128.
> > +///   0001 - AES-XTS-128 with integrity.
> > +///   0010 - AES-XTS-256.
> >  ///   Other values are invalid.
> >  ///
> >  UINT32TmePolicy : 4;
> > @@ -5756,7 +5756,7 @@ typedef union {
> >  /// Similar to enumeration, this is an encoded value.
> >  /// Writing a value greater than MK_TME_MAX_KEYID_BITS will result in
> > #GP.
> >  /// Writing a non-zero value to this field will #GP if bit 1 of EAX 
> > (Hardware
> > -/// Encryption Enable) is not also set to ‘1, as encryption hardware 
> > must
> be
> > +/// Encryption Enable) is not also set to 1, as encryption hardware 
> > must
> be
> >  /// enabled to use MKTME.
> >  /// Example: To support 255 keys, this field would be set to a value 
> > of 8.
> >  ///
> > --
> > 2.40.0.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118938): https://edk2.groups.io/g/devel/message/118938
Mute This Topic: https://groups.io/mt/106126636/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[gaoliming via groups.io]

Mike:

  Thanks for your comments. I update the status below. 

 

Thanks

Liming

发件人: Kinney, Michael D  
发送时间: 2024年5月15日 0:35
收件人: gaoliming ; devel@edk2.groups.io; 'Andrew Fish' 
; 'Leif Lindholm' 
抄送: 'Ard Biesheuvel' ; sam.kay...@arm.com; 
dougfl...@microsoft.com; Mathews, John ; Hou, Wenxing 
; Li, Yi1 ; Yao, Jiewen 
; Kinney, Michael D 
主题: RE: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi Liming,

 

My responses below in [Mike].

 

Mike

 

 

From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Friday, May 10, 2024 8:29 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; Kinney, Michael D 
mailto:michael.d.kin...@intel.com> >; 'Andrew 
Fish' mailto:af...@apple.com> >; 'Leif Lindholm' 
mailto:quic_llind...@quicinc.com> >
Cc: 'Ard Biesheuvel' mailto:a...@kernel.org> >; 
sam.kay...@arm.com <mailto:sam.kay...@arm.com> ; dougfl...@microsoft.com 
<mailto:dougfl...@microsoft.com> ; Mathews, John mailto:john.math...@intel.com> >; Hou, Wenxing mailto:wenxing@intel.com> >
Subject: 回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Stewards:

  Now, there are several patches to catch this table tag. Could you give the 
comments for them?

 

1.  Adding support for verbose UEFI Table dumping to Dmem.c 
(https://edk2.groups.io/g/devel/message/118582)

[Liming] This patch set has been reviewed before soft feature freeze. It plans 
to catch this stable tag. 

 

[Mike] I see this PR: https://github.com/tianocore/edk2/pull/5653 that is not 
passing CI and appears it will require additional code changes

 

[Mike] Reject for edk2-stable202405

 

2.  MdePkg/BaseLib: Fix AARCH64 compilation error 
(https://edk2.groups.io/g/devel/message/118690)

[Liming] This bug fix is reviewed in soft feature freeze phase. It plans to 
catch this stable tag. 

 

[Mike] Approved for edk2-stable202405

[Liming] I add push label for https://github.com/tianocore/edk2/pull/5642

 

3.  MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount 
(https://edk2.groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft feature freeze phase. It plans 
to catch this stable tag.

 

[Mike] Approved for edk2-stable202405

[Liming] I add push label for https://github.com/tianocore/edk2/pull/5659

 

4.  NetworkPkg: CVE-2023-45236 and CVE-2023-45237 
(https://edk2.groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It plans to catch this 
stable tag.

 

[Mike] Is the code review complete?  Is there a link to the PR?

[Liming] NetworkPkg reviewer will review this patch set this week. 

 

Thanks

 

5.  Add more crypt APIs based on Mbedtls 
(https://edk2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It 
plans to catch this stable tag.

 

[Mike] This patch series uses ‘..’ in INF to access source files in another 
component.  This is not legal.  I am surprised this was not caught in code 
review.

 

DEFINE OPENSSL_PATH= ../OpensslLib/openssl

DEFINE BASE_CRYPT_PATH = ../BaseCryptLib

 

[Mike] I see a reference to some “platform integration” testing.  Given that 
this patch series implements a number of

crypto service APIs and is a large number of new lines of code, it would be 
good to know if all of the newly added APIs 

were tested in a platform integration. A table of the added APIs and the 
platform integration test status would be good to 

know if there was any functional testing of each API.  If there are APIs that 
are not covered by any platform integration 

testing, then I would be concerned with such a large change with limited 
testing.

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  mailto:devel@edk2.groups.io> > 代表 gaoliming via groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ; 
annou...@edk2.groups.io <mailto:annou...@edk2.groups.io> 
抄送: 'Michael D Kinney' mailto:michael.d.kin...@intel.com> >; 'Andrew Fish' mailto:af...@apple.com> >; 'Leif Lindholm' mailto:quic_llind...@quicinc.com> >
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi, all

 

  We enter into Soft Feature Freeze phase now. In this phase,

the feature under review will not be allowed to be pushed. The feature

passed review can still be merged.

 

  The patch review can continue without break in edk2 community. If the

patch is sent before Soft Feature Freeze, and plans to catch this stable tag, 
the

patch contributor need reply to his patch and notify edk2 community. If the

patch is sent after Soft Feature Freeze, and plans to catch this stable tag,

please add edk2-stable202405 key words in the patch title and BZ, so the

community know this patch target and give the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 

回复: [edk2-devel] 回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Doug:

  Thanks for your clarification. For the changes in MdePkg and EmulatorPkg, I 
have no comments. Reviewed-by: Liming Gao 

 

Thanks

Liming

发件人: Doug Flick via groups.io  
发送时间: 2024年5月10日 2:26
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] 
NetworkPkg: CVE-2023-45236 and CVE-2023-45237

 

>From the two CVE patches there should be no functional differences to a 
>platform assuming the platform provides them with a RNG implementation and 
>HASH2 implementation.

The "NetworkPkg:: SECURITY PATCH CVE-2023-45237" change simply get's it's 
random numbers from outside of the NetworkPkg and makes it a platform decision. 
The "NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236" changes how the TCP Isn 
number is generated and puts the platform in compliance with the relevant 
specification.

There is a functional change with "SecurityPkg: RngDxe: Remove incorrect 
limitation on GetRng" as this will now allow a caller to call less than 32 
bytes.

The other changes are unit tests and platform integration changes.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118897): https://edk2.groups.io/g/devel/message/118897
Mute This Topic: https://groups.io/mt/106106240/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

[gaoliming via groups.io]

These PRs are all failure. Please update them. 

Thanks
Liming
> -邮件原件-
> 发件人: Pethaiyan, Madhan 
> 发送时间: 2024年5月13日 20:10
> 收件人: gaoliming ; Kinney, Michael D
> ; devel@edk2.groups.io
> 抄送: Liu, Zhiguang ; Li, Yi1 ; 'GuoX
> Xu' 
> 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo
> description details
> 
> Hi all ,
> 
> I had created EDK2 PR, few weeks ago, thought it will be reviewed and 
> approved .
> Please help to check and approve.
> 
> https://github.com/tianocore/edk2/pull/5584
> https://github.com/tianocore/edk2/pull/5586
> https://github.com/tianocore/edk2/pull/5587
> 
> Thanks,
> P. Madhan
> 
> -Original Message-
> From: gaoliming 
> Sent: Thursday, March 28, 2024 6:41 AM
> To: Pethaiyan, Madhan ; Kinney, Michael D
> ; devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Li, Yi1 ; 'GuoX 
> Xu'
> 
> Subject: 回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,
> GetImageInfo description details
> 
> Madhan:
>   I have no comments for this patch set. Reviewed-by: Liming Gao
> 
> 
>   Have you create Edk2 PR to verify the changes?
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Pethaiyan, Madhan 
> > 发送时间: 2024年3月14日 16:17
> > 收件人: Kinney, Michael D ;
> > devel@edk2.groups.io
> > 抄送: Liming Gao ; Liu, Zhiguang
> > ; Li, Yi1 ; GuoX Xu
> > 
> > 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo
> > description details
> >
> > Hi Mike ,
> >
> > I had raised new code review addressing the coding standard errors and
> those
> > were not part of my change any way ..
> >
> > Thanks,
> > P. Madhan
> >
> > -Original Message-
> > From: Kinney, Michael D 
> > Sent: Sunday, March 10, 2024 1:47 AM
> > To: devel@edk2.groups.io; Pethaiyan, Madhan
> > 
> > Cc: Liming Gao ; Liu, Zhiguang
> > ; Li, Yi1 ; GuoX Xu
> > ; Kinney, Michael D 
> > Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,
> > GetImageInfo description details
> >
> > Hi Madhan,
> >
> > I created a PR with all 3 related patches to run through EDK II CI.
> >
> > https://github.com/tianocore/edk2/pull/5453
> >
> > There are CI failures.  Please resolve and send updated patches.
> >
> > Thanks,
> >
> > Mike
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io  On Behalf Of
> > > Pethaiyan Madhan
> > > Sent: Friday, March 8, 2024 3:17 PM
> > > To: devel@edk2.groups.io
> > > Cc: Pethaiyan, Madhan ; Kinney, Michael
> > > D ; Liming Gao
> > > ; Liu, Zhiguang ;
> > > Li, Yi1 ; GuoX Xu 
> > > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,
> > > GetImageInfo description details
> > >
> > > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
> > > Add the following sentence at the end of the Image parameter
> > > description. "May be NULL with a zero ImageSize in order to
> > > determine the size of the buffer needed".
> > >
> > > Modify the description of "EFI_INVALID_PARAMETER" return code as
> > > "The ImageSize is not too small and Image is NULL."
> > >
> > > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo():
> > > Add the following sentence at the end of the ImageInfo parameter
> > > description."May be NULL with a zero ImageInfoSize in order to
> > > determine the size of the buffer needed".
> > >
> > > Modify the description of "EFI_INVALID_PARAMETER" return code as
> > > "The ImageInfoSize is not too small and Image is NULL." and add new
> > > descriptions for "EFI_INVALID_PARAMETER" return code.
> > >
> > >  REF: UEFI spec v2.10 23.1.2
> > >  REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660
> > >
> > > Cc: Michael D Kinney 
> > > Cc: Liming Gao 
> > > Cc: Zhiguang Liu 
> > > Cc: Yi Li 
> > > Cc: GuoX Xu 
> > > Signed-off-by: Pethaiyan Madhan 
> > > ---
> > >  MdePkg/Include/Protocol/FirmwareManagement.h | 14 --
> > >  1 file changed, 12 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h
> > > b/MdePkg/Include/Protocol/FirmwareManagement.h
> > > index e535bb697d..90b7d83c8f 100644
> > > --- a/MdePkg/Include/Protocol/FirmwareManagement.h
> > > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h
> > > @@ -294,6 +294,8 @@ EFI_STATUS
> > >   to contain the image(s)
> > > information if the buffer was too small.
> > >@param[in, out] ImageInfo  A pointer to the buffer in which
> > > firmware places the current image(s)
> > >   information. The
> > information is
> > > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs.
> > > + May be NULL with a zero
> > > ImageInfoSize in order to determine the size of the
> > > + buffer needed.
> > >@param[out] DescriptorVersion  A pointer to the location in
> > > which firmware returns the version number
> > >   associated with the
> > > EFI_FIRMWARE_IMAGE_DESCRIPTOR.
> > >@param[out] DescriptorCountA pointer to the location in
> > > which firmware 

回复: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

[gaoliming via groups.io]

Stewards:

  Now, there are several patches to catch this table tag. Could you give the
comments for them?

 

1.  Adding support for verbose UEFI Table dumping to Dmem.c
(https://edk2.groups.io/g/devel/message/118582)

[Liming] This patch set has been reviewed before soft feature freeze. It
plans to catch this stable tag. 

 

2.  MdePkg/BaseLib: Fix AARCH64 compilation error
(https://edk2.groups.io/g/devel/message/118690)

[Liming] This bug fix is reviewed in soft feature freeze phase. It plans to
catch this stable tag. 

 

3.  MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount (https://edk2.
groups.io/g/devel/message/118745)

[Liming] This security fix is reviewed in soft feature freeze phase. It
plans to catch this stable tag.

 

4.  NetworkPkg: CVE-2023-45236 and CVE-2023-45237
(https://edk2.groups.io/g/devel/message/118768)

[Liming] This security fix is still under code review. It plans to catch
this stable tag.

 

5.  Add more crypt APIs based on Mbedtls
(https://edk2.groups.io/g/devel/message/118772)

[Liming] This patch set passes code review in soft feature freeze phase. It
plans to catch this stable tag.

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 gaoliming via
groups.io
发送时间: 2024年5月7日 9:25
收件人: devel@edk2.groups.io; annou...@edk2.groups.io
抄送: 'Michael D Kinney' ; 'Andrew Fish'
; 'Leif Lindholm' 
主题: [edk2-devel] Soft Feature Freeze starts now for edk2-stable202405

 

Hi, all

 

  We enter into Soft Feature Freeze phase now. In this phase,

the feature under review will not be allowed to be pushed. The feature

passed review can still be merged.

 

  The patch review can continue without break in edk2 community. If the

patch is sent before Soft Feature Freeze, and plans to catch this stable
tag, the

patch contributor need reply to his patch and notify edk2 community. If the

patch is sent after Soft Feature Freeze, and plans to catch this stable tag,

please add edk2-stable202405 key words in the patch title and BZ, so the

community know this patch target and give the feedback.

 

  To avoid the unnecessary changes to be merged in edk2 stable tag release,

all edk2 maintainers' write access will be temporarily disabled until stable

tag is released on 05-24. That means edk2 maintainer can't set push label in

pull request after soft feature freeze starts.

 

  If the change wants to catch this stable tag 202405, please follow above

rules, then send the merge request to gaolim...@byosoft.com.cn
<mailto:gaolim...@byosoft.com.cn>  or 

michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com> .

 

  We will help merge the code change in soft feature freeze and hard feature

freeze phase. 

 

Below is edk2-stable202405 tag planning Proposed Schedule

Date (00:00:00 UTC-8) Description

 

2024-02-23 Beginning of development

2024-05-06 Soft Feature Freeze

2024-05-10 Hard Feature Freeze

2024-05-24 Release

 

Thanks

Liming

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118823): https://edk2.groups.io/g/devel/message/118823
Mute This Topic: https://groups.io/mt/106022998/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

[gaoliming via groups.io]

Doug:

  From the compatibility point,  may PcdEnforceSecureRngAlgorithms default 
value be set to FALSE?

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Doug Flick via groups.io
发送时间: 2024年5月10日 2:21
收件人: Ard Biesheuvel ; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 03/13] OvmfPkg:PlatformCI: Support virtio-rng-pci

 

So this patch is necessary as otherwise, QEMU fails to boot due to a missing 
source of randomness in the network drivers, right?

So I added this based on your initial suggestion to get the ArmVirtPkg working 
- running it locally (and against the pipelines) shows this isn't necessary. So 
I'll drop the commits.

There were concerns around compatibility, however the only fallback we would be 
able to do from NetworkPkg is depend on the time based LCG that we've 
considered a high profile CVE. This is where NetworkPkg must depend on the 
platform to provide it Rng and Hashing services. Fundamentally the platform 
must own it's own security.

RNDR raises another interesting problem, by the way - the ARM arch spec 
requires RNDR to be backed by an appropriate DRBG that complies with the NIST 
spec but it does not specify which one. IOW, it is backed by a DRBG not by a 
raw entropy source, but specifying which DRBG (by GUID) is not generally 
feasible, as the guest VM firmware cannot interrogate the host about which DRBG 
is behind RNDR.

This is why the PCD PcdEnforceSecureRngAlgorithms exists. The platform can make 
the determination to depend on default if they understand the security 
implications behind that. Additionally, the platform is free to override RngDxe 
and provide their own implementations.





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118779): https://edk2.groups.io/g/devel/message/118779
Mute This Topic: https://groups.io/mt/106013302/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to Dmem.c

[gaoliming via groups.io]

Sam:
 Please help create PR.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Sam Kaynor
> 发送时间: 2024年5月10日 4:51
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Ray Ni' ; 'Zhichao Gao' ;
> 'Michael D Kinney' ; 'Zhiguang Liu'
> ; Stuart Yoder 
> 主题: Re: [edk2-devel] [PATCH v7 0/5] Adding support for veborse UEFI Table
> dumping to Dmem.c
> 
> Liming,
> 
> I have not made a Pull Request for this patch set, should I make one?
> 
> Thanks,
> Sam
> 
> -Original Message-
> From: gaoliming 
> Sent: Sunday, May 5, 2024 9:49 PM
> To: Sam Kaynor ; devel@edk2.groups.io
> Cc: 'Ray Ni' ; 'Zhichao Gao' ;
> 'Michael D Kinney' ; 'Zhiguang Liu'
> ; Stuart Yoder 
> Subject: 回复: [PATCH v7 0/5] Adding support for veborse UEFI Table dumping
> to Dmem.c
> 
> Sam:
> 
> Thanks for your update. This version patch is good to me. Reviewed-by:
> Liming Gao 
> 
> Besides, is there a Pull Request for this patch set?
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Sam Kaynor 
> > 发送时间: 2024年5月1日 22:58
> > 收件人: devel@edk2.groups.io
> > 抄送: Ray Ni ; Zhichao Gao ;
> > Michael D Kinney ; Liming Gao
> > ; Zhiguang Liu ;
> > Stuart Yoder 
> > 主题: [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to
> > Dmem.c
> >
> > This adds an additional option to the dmem UEFI shell command for
> > verbose dumping of a couple of UEFI tables.
> >
> > The tables specified are the RT Properties Table, the Image Execution
> Table,
> > and the Conformance Profiles table.
> >
> > Supporting objects are added in the .inf and .uni files relating to
> > Dmem.c
> and
> > an additional header file for the Conformance Profiles table was added.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> >
> > v6->v7:
> > - Additional patch to separate UEFI and EBBR Guids
> >
> > Cc: Ray Ni 
> > Cc: Zhichao Gao 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Stuart Yoder 
> > Signed-off-by: Sam Kaynor 
> >
> > Sam Kaynor (5):
> >   ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in
> > Dmem.c
> >   ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c
> >   MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE
> >   MdePkg: Adding EBBR EFI_CONFORMANCE_PROFILE_TABLE GUIDs
> >   ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c
> >
> >  MdePkg/MdePkg.dec
> > |  10 +
> >
> > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsL
> > ib.inf |   4 +
> >  MdePkg/Include/Guid/ConformanceProfiles.h
> > |  63 
> >  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> > | 321 ++--
> >
> > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsL
> > ib.uni |  31 +-
> >  5 files changed, 402 insertions(+), 27 deletions(-)  create mode
> > 100644 MdePkg/Include/Guid/ConformanceProfiles.h
> >
> > --
> > 2.34.1
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended 
> recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118778): https://edk2.groups.io/g/devel/message/118778
Mute This Topic: https://groups.io/mt/106013237/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

[gaoliming via groups.io]

It has been merged. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Praveen Sankar
> N via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com; zhiguang@intel.com;
> Felix Polyudov ; Rabisha R 
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
> 
> Hi Liming,
>   Pull request is done and pipelines are built successfully and the patch 
> is
> ready to push to the master.
> 
> Thanks,
> Praveen Sankar
> 
> -Original Message-
> From: gaoliming 
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: Srinivasan Mani ; Sundaresan S
> ; michael.d.kin...@intel.com; zhiguang@intel.com;
> Felix Polyudov ; Rabisha R 
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise 
> caution
> before opening attachments, clicking links, or following guidance.**
> 
> Reviewed-by: Liming Gao 
> 
> > -邮件原件-
> > 发件人: Praveen Sankar N 
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> > Sundaresan S ; michael.d.kin...@intel.com;
> > zhiguang@intel.com; Felix Polyudov ; Rabisha R
> > 
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> >
> > Cc: michael.d.kin...@intel.com
> >
> > Cc: gaolim...@byosoft.com.cn
> >
> > Cc: zhiguang@intel.com
> >
> > Cc: fel...@ami.com
> >
> > Cc: srinivas...@ami.com
> >
> > Cc: sundares...@ami.com
> >
> > Cc: rabis...@ami.com
> > ---
> >  .../SerialPortConsoleRedirectionTable.h   | 32 +++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -23,6 +23,7 @@
> >  ///
> >
> >  #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION  0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> >  ///
> >
> >  /// Serial Port Console Redirection Table Format
> >
> >  ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> >UINT32Reserved3;
> >
> >  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > +  EFI_ACPI_DESCRIPTION_HEADER   Header;
> >
> > +  UINT8 InterfaceType;
> >
> > +  UINT8 Reserved1[3];
> >
> > +  EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
> >
> > +  UINT8 InterruptType;
> >
> > +  UINT8 Irq;
> >
> > +  UINT32
> > GlobalSystemInterrupt;
> >
> > +  UINT8 BaudRate;
> >
> > +  UINT8 Parity;
> >
> > +  UINT8 StopBits;
> >
> > +  UINT8 FlowControl;
> >
> > +  UINT8 TerminalType;
> >
> > +  UINT8 Reserved2;
> >
> > +  UINT16PciDeviceId;
> >
> > +  UINT16PciVendorId;
> >
> > +  UINT8 PciBusNumber;
> >
> > +  UINT8 PciDeviceNumber;
> >
> > +  UINT8 PciFunctionNumber;
> >
> > +  UINT32PciFlags;
> >
> > +  UINT8 PciSegment;
> >
> > +  UINT32UartClockFrequency;
> >
> > +  UINT32PreciseBaudRate;
> >
> > +  UINT16
> > NameSpaceStrLength;
> >
> > +  UINT16
> > NameSpaceStrOffset;
> >
> > +  CHAR8
> > NameSpaceString[0];
> >
> > +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> > +
> >
> >  #pragma pack()
> >
> >
> >
> >  //
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message 

回复: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

[gaoliming via groups.io]

Sami:

  Thanks for your update. I agree Pierre reviewed this patch before the soft 
feature freeze. So, this patch can be merged for this stable tag 202405.

 

Thanks

Liming

发件人: devel@edk2.groups.io  代表 Sami Mujawar
发送时间: 2024年5月9日 18:18
收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Attar, AbdulLateef (Abdul 
Lateef)' 
抄送: Pierre Gondois ; 'Leif Lindholm' 
; 'Andrew Fish' ; 'Michael Kinney' 

主题: Re: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] 
DynamicTablesPkg: Adds integer to the AML package node

 

Hi Liming,

 

> What’s your comments for this patch?

The patch was reviewed by Pierre at 
https://edk2.groups.io/g/devel/message/118589 before the feature freeze email 
was sent out.

Pierre had some minor recommendations that Abdul has addressed in the V2 patch. 
Ideally Pierre’s the r-b tag could have been carried forward.

 

> Is this a required bug fix or new feature?

This is adding a new feature by introducing a new API, and I think it should 
not impact the existing functionality as such. 

So, by merging this patch the risk of breaking existing functionality seems to 
be low.

 

This patch looks good to me.

Reviewed-by: Sami Mujawar mailto:sami.muja...@arm.com> >

 

Regards,

 

Sami Mujawar

 

 

 

From: mailto:devel@edk2.groups.io> > on behalf of 
"gaoliming via groups.io" mailto:gaoliming=byosoft.com...@groups.io> >
Reply to: "devel@edk2.groups.io <mailto:devel@edk2.groups.io> " 
mailto:devel@edk2.groups.io> >, 
"gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn> " 
mailto:gaolim...@byosoft.com.cn> >
Date: Thursday 9 May 2024 at 10:01
To: "'Attar, AbdulLateef (Abdul Lateef)'" mailto:abdullateef.at...@amd.com> >, "devel@edk2.groups.io 
<mailto:devel@edk2.groups.io> " mailto:devel@edk2.groups.io> >
Cc: Pierre Gondois mailto:pierre.gond...@arm.com> >, 
Sami Mujawar mailto:sami.muja...@arm.com> >, 'Leif 
Lindholm' mailto:quic_llind...@quicinc.com> >, 
'Andrew Fish' mailto:af...@apple.com> >, 'Michael Kinney' 
mailto:michael.d.kin...@intel.com> >
Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] 
DynamicTablesPkg: Adds integer to the AML package node
Resent from: mailto:gaolim...@byosoft.com.cn> >
Resent date: Thursday 9 May 2024 at 10:00

 

Sami and Pierre:

  What’s your comments for this patch? Is this a required bug fix or new 
feature?

 

Thanks

Liming

发件人: Attar, AbdulLateef (Abdul Lateef) mailto:abdullateef.at...@amd.com> > 
发送时间: 2024年5月9日 16:39
收件人: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
抄送: 'Pierre Gondois' mailto:pierre.gond...@arm.com> >; 
'Sami Mujawar' mailto:sami.muja...@arm.com> >
主题: Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: 
Adds integer to the AML package node

 

[AMD Official Use Only - General]

 

Hi Liming,

This patch provides an API to add integer value to AML package node.

Using this API user can create CXL device with two PNPID.

Without this API user has to rely on static ASL files.

 

This patch is required for platform who uses DynamicTablesPkg to generate ACPI 
tables based on this stable release.

 

Thanks

AbduL

  _  

From: gaoliming mailto:gaolim...@byosoft.com.cn> >
Sent: Thursday, May 9, 2024 1:10 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  mailto:devel@edk2.groups.io> >; Attar, AbdulLateef (Abdul Lateef) 
mailto:abdullateef.at...@amd.com> >
Cc: 'Pierre Gondois' mailto:pierre.gond...@arm.com> >; 
'Sami Mujawar' mailto:sami.muja...@arm.com> >
Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] 
DynamicTablesPkg: Adds integer to the AML package node 

 

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Abdul:
  Can you give more information why this change is required for this stable
tag 202405?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>  
> mailto:devel@edk2.groups.io> > 代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
> 抄送: Abdul Lateef Attar  <mailto:abdullateef.at...@amd.com> >; Pierre Gondois
> mailto:pierre.gond...@arm.com> >; Sami Mujawar 
> mailto:sami.muja...@arm.com> >
> 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
> DynamicTablesPkg: Adds integer to the AML package node
>
> Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
> which adds an integer value to the package node.
>
> Cc: Pierre Gondois mailto:pierre.gond...@arm.com> >
> Cc: Sami Mujawar mailto:sami.muja...@arm.com> >
> Signed-off-by: Abdul Lateef Attar  &l

回复: [edk2-devel][edk2-stable202405] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

[gaoliming via groups.io]

Include more people for feedback.

> -邮件原件-
> 发件人: Hou, Wenxing 
> 发送时间: 2024年5月9日 17:35
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Li, Yi1
> 
> 抄送: Yao, Jiewen 
> 主题: RE: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> Hi Liming,
> Thanks for your suggestion.
> 
> 
> Hi all,
> The current Patch Set status is:
>   This patch set was submitted before soft feature freeze.
>   It passed code review after soft feature freeze starts.
>   And the Patch set is: Acked-by: Jiewen Yao 
>Reviewed-by: Yi Li 
> 
> We want to catch this 202405 stable tag.
> If anyone have feedback, please let me know.
> 
> Thanks,
> Wenxing
> 
> -----Original Message-
> From: devel@edk2.groups.io  On Behalf Of gaoliming
> via groups.io
> Sent: Thursday, May 9, 2024 4:59 PM
> To: devel@edk2.groups.io; Li, Yi1 ; Hou, Wenxing
> 
> Cc: Yao, Jiewen 
> Subject: 回复: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on
> Mbedtls
> 
> Seemly, this change is new feature to add more crypt APIs based on Mbedtls.
> 
> This patch set was submitted before soft feature freeze. But, it passed code 
> review
> after soft feature freeze starts.
> 
> Based on current rule, this patch set is not allowed to be merged for this 
> stable
> tag 202405.
> 
> If you want to catch this stable tag, please raise this requirement to the 
> mail list
> and collect the feedback.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Li, Yi
> > 发送时间: 2024年5月9日 16:33
> > 收件人: Hou, Wenxing ; gaoliming
> > ; devel@edk2.groups.io
> > 抄送: Yao, Jiewen 
> > 主题: Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on
> Mbedtls
> >
> > This patch set was submitted before soft freeze and will not affect
> > other
> existed
> > codes, I am OK to merge it.
> >
> > Hi Liming,
> >
> > Do you have any comments?  I will merge it if no objections.
> >
> > Thanks,
> > Yi
> >
> > -Original Message-
> > From: Hou, Wenxing 
> > Sent: Thursday, May 9, 2024 4:29 PM
> > To: Li, Yi1 ; devel@edk2.groups.io
> > Cc: Yao, Jiewen ; gaoliming
> > 
> > Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> >
> > Hi,
> >
> > Thanks for your feedback.
> > The new PR is: https://github.com/tianocore/edk2/pull/5645
> >
> > Could Li Yi help me merge the PR?
> >
> > Thanks,
> > Wenxing
> >
> > -Original Message-
> > From: Li, Yi1 
> > Sent: Thursday, May 9, 2024 2:54 PM
> > To: Hou, Wenxing ; devel@edk2.groups.io
> > Cc: Yao, Jiewen 
> > Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> >
> > For this patch set:
> >
> > Looks good to me.
> > Reviewed-by: Yi Li 
> >
> >
> > -Original Message-
> > From: Hou, Wenxing 
> > Sent: Thursday, May 9, 2024 2:27 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen ; Li, Yi1 
> > Subject: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
> >
> > Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More
> > RSA/PKCS5/pKCS7/Authenticode/Timestamp
> > implementation based on Mbedtls.
> >
> > The patch has passed the EDKII CI check:
> > https://github.com/tianocore/edk2/pull/5552
> >
> > And the patch has passed unit_test in EDKII and integration test for
> platform.
> > And the patch hass passed the fuzz test:
> > https://github.com/tianocore/edk2-staging/commit/4f19398053c92e4f7791d
> > 4
> > 68a184530b6ab89128
> >
> > v2 changes:
> >  - Fix format variable name/hardcode number issue;
> >  - Fix Pkcs7 memory leak;
> >
> > v3 changes:
> >  - Fix some issues form reviewer;
> >  - Add SHA3/SM3 implementation;
> >  - Update *.inf files;
> >
> > Cc: Jiewen Yao 
> > Cc: Yi Li 
> > Signed-off-by: Wenxing Hou 
> >
> > Wenxing Hou (11):
> >   CryptoPkg: Add AeadAesGcm based on Mbedtls
> >   CryptoPkg: Add rand function for BaseCryptLibMbedTls
> >   CryptoPkg: Add Pem APIs based on Mbedtls
> >   CryptoPkg: Add X509 functions based on Mbedtls
> >   CryptoPkg: Add Pkcs7 related functions based on Mbedtls
> >   CryptoPkg: Add Pkcs5 functions based on Mbedtls
> >   CryptoPkg: Add more RSA related functions based on Mbedtls
> >   CryptoPkg: Add AuthenticodeVerify based on Mbedtls
> >   CryptoPkg: Add ImageTimestampVerify 

回复: [edk2-devel][edk2-stable202405] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and CVE-2023-45237

[gaoliming via groups.io]

Doug:
  Is there any functionality impact by these two CVE fixes?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Doug Flick via
> groups.io
> 发送时间: 2024年5月9日 13:56
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao 
> 主题: [edk2-devel] [PATCH v2 00/13] NetworkPkg: CVE-2023-45236 and
> CVE-2023-45237
> 
>
REF:https://blog.quarkslab.com/pixiefail-nine-vulnerabilities-in-tianocores-
edk-ii-
> ipv6-network-stack.html
> 
> This patch series patches the following CVEs:
> - CVE-2023-45236: Predictable TCP Initial Sequence Numbers
> - CVE-2023-45237: Use of a Weak PseudoRandom Number Generator
> 
> In order to patch these CVEs, the following changes were made:
> - NetworkPkg no longer performs it's own random number generation,
>   instead it uses EFI_RNG_PROTOCOL provided by the plaform to
>   generate random numbers.
>   - This change was made such that any future random number
> generation vulnerabilities will be a result of the platforms
> implementation of the EFI_RNG_PROTOCOL and not the NetworkPkg
> 
> - NetworkPkg uses the TCP initial sequence number algorithm as described
>   in RFC 6528 to generate the initial sequence number for TCP connections.
>   - This change was made to ensure that the initial sequence number
> is not predictable and therefore cannot be used in a TCP hijacking
> attack.
> 
> In addition to the above changes, the following changes were made:
> - EmulatorPkg OvmfPkg, and ArmVirtPkg were updated to include the
>   Hash2DxeCrypto driver to support TCP ISN generation using
>   EFI_HASH2_PROTOCOL
> 
> - EmulatorPkg was updated to include the
>   RngDxe driver to support random number generation using the
>   EFI_RNG_PROTOCOL
> 
> - OvmfPkg, and ArmVirtPkg were updated to include the
>   virtio-rng-pci device to support random number generation using the
>   EFI_RNG_PROTOCOL using the existing VirtioRngDxe driver
> 
> - SecurityPkg was updated to fix an incorrect limitation on the
>   GetRng function in the RngDxe driver where the minimum amount of
>   random data that could be requested was 32 bytes (256 bits) instead
>   of what the caller requested
> 
> - MdePkg was updated to include MockUefiBootServicesTableLib,
>   MockRng, and MockHash2 protocols for testing
> 
> - NetworkPkg was updated to include a test for the PxeBcDhcp6 driver
>   due to underlying changes
> 
> Cc: Liming Gao 
> 
> Signed-off-by: Doug Flick [MSFT] 
> 
> Doug Flick (13):
>   EmulatorPkg: : Add RngDxe to EmulatorPkg
>   EmulatorPkg: : Add Hash2DxeCrypto to EmulatorPkg
>   OvmfPkg:PlatformCI: Support virtio-rng-pci
>   OvmfPkg: : Add Hash2DxeCrypto to OvmfPkg
>   ArmVirtPkg:PlatformCI: Support virtio-rng-pci
>   ArmVirtPkg: : Add Hash2DxeCrypto to ArmVirtPkg
>   SecurityPkg: RngDxe: Remove incorrect limitation on GetRng
>   NetworkPkg:: SECURITY PATCH CVE-2023-45237
>   NetworkPkg: TcpDxe: SECURITY PATCH CVE-2023-45236
>   MdePkg: : Add MockUefiBootServicesTableLib
>   MdePkg: : Adds Protocol for MockRng
>   MdePkg: Add MockHash2 Protocol for testing
>   NetworkPkg: Update the PxeBcDhcp6GoogleTest due to underlying changes
> 
>  NetworkPkg/NetworkPkg.dec
> |   7 +
>  ArmVirtPkg/ArmVirtQemu.dsc
> |   5 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc
> |   5 +
>  EmulatorPkg/EmulatorPkg.dsc
> |  14 +-
>  MdePkg/Test/MdePkgHostTest.dsc
> |   1 +
>  NetworkPkg/Test/NetworkPkgHostTest.dsc
> |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc
> |   6 +-
>  OvmfPkg/OvmfPkgIa32X64.dsc
> |   6 +-
>  OvmfPkg/OvmfPkgX64.dsc
> |   6 +-
>  OvmfPkg/OvmfXen.dsc
> |   5 +
>  EmulatorPkg/EmulatorPkg.fdf
> |  11 +-
>  OvmfPkg/OvmfPkgIa32.fdf
> |   5 +
>  OvmfPkg/OvmfPkgIa32X64.fdf
> |   5 +
>  OvmfPkg/OvmfPkgX64.fdf
> |   5 +
>  OvmfPkg/OvmfXen.fdf
> |   5 +
> 
> MdePkg/Test/Mock/Library/GoogleTest/MockUefiBootServicesTableLib/MockUe
> fiBootServicesTableLib.inf |  32 +++
>  NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> |  13 +-
>  NetworkPkg/TcpDxe/TcpDxe.inf
> |  11 +-
>  NetworkPkg/UefiPxeBcDxe/GoogleTest/UefiPxeBcDxeGoogleTest.inf
> |   3 +-
> 
> MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiBootServicesTableLib.
> h|  78 +++
>  MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockHash2.h
> |  67 ++
>  MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockRng.h
> |  48 
>  NetworkPkg/IScsiDxe/IScsiMisc.h
> |   6 +-
>  NetworkPkg/Include/Library/NetLib.h
> |  40 +++-
>  NetworkPkg/Ip6Dxe/Ip6Nd.h
> |   8 +-
>  NetworkPkg/TcpDxe/TcpFunc.h
> |  23 +-
>  NetworkPkg/TcpDxe/TcpMain.h
> |  59 -
>  NetworkPkg/Dhcp4Dxe/Dhcp4Driver.c
> |  10 +-
>  NetworkPkg/Dhcp6Dxe/Dhcp6Driver.c
> |  11 +-
>  NetworkPkg/DnsDxe/DnsDhcp.c
> |  10 +-
>  NetworkPkg/DnsDxe/DnsImpl.c
> |  11 +-
>  NetworkPkg/HttpBootDxe/HttpBootDhcp6.c
> |  10 +-
>  NetworkPkg/IScsiDxe/IScsiCHAP.c
> |  19 +-
>  NetworkPkg/IScsiDxe/IScsiMisc.c
> |  14 +-
>  NetworkPkg/Ip4Dxe/Ip4Driver.c
> |  10 +-
>  NetworkPkg/Ip6Dxe/Ip6ConfigImpl.c
> |   9 +-
>  NetworkPkg/Ip6Dxe/Ip6Driver.c
> |  17 +-
>  NetworkPkg/Ip6Dxe/Ip6If.c
> |  12 +-
>  

回复: 回复：[Internet]Re: [edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

[gaoliming via groups.io]

MdePkg includes the definitions from the public specification. 

Those definitions are the implement related definition. So, they should be 
added into RISC-V platform package instead of MdePkg.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Sunil V L
> 发送时间: 2024年5月9日 16:36
> 收件人: dylanlhdu(杜林恒) 
> 抄送: devel ; gaoliming 
> 主题: Re: 回复：[Internet]Re: [edk2-devel] [PATCH] Added support for ACPI
> related data structures for RISC_V64 platform
> 
> On Mon, May 06, 2024 at 10:54:45AM +0800, dylanlhdu(杜林恒) wrote:
> > Hi Sunil,
> >
> >
> >
> > We mainly want to use UEFI+ACPI mode to start RISCV64 server. However,
> during the development process, we found that ACPI(6.5) in the current version
> of UEFI does not support riscv for the time being. In order to solve this 
> problem,
> We refer to the upstream RISC-V ACPI platform specification provided by 
> Ventana
> to implement RISC-V ACPI support, so adding this header file can make ACPI
> support RISCV architecture until the new version of ACPI specification 
> supports
> RISCV architecture.
> >
> Understood. But adding as 6_5* doesn't make sense.
> 
> I will let maintainers of MdePkg to comment. I don't know
> whether they can accept approved ECRs but not yet released spec.
> 
> Thanks,
> Sunil
> 
> >
> >
> >
> >
> >
> >
> > Thanks
> >
> >
> >
> >
> > 发自我的企业微信
> >
> >
> >
> >
> >
> >  --回复的邮件信息--
> >Sunil V L 20:02 写道：
> >
> > Hi Lingheng Du,
> >
> > What is the use of adding this header file and how did you create it? I
> > think EDK2 needs ACPI spec to be released to get these definitions
> > added. Also, these are not part of 6.5 and hence names like
> > EFI_ACPI_6_5* are incorrect. So, it will be helpful if you add some
> > commit message why do we need this header.
> >
> > Thanks,
> > Sunil
> > On Mon, Apr 29, 2024 at 05:53:55PM +0800, gaoliming via groups.io wrote:
> >  From: dylanlhdu  > 
> >  Signed-off-by:
> Lingheng Du  >  Reviewed-by:
> Song Huang  >  Reviewed-by:
> Bing Fan  >  ---
> >  .../Include/IndustryStandard/AcpiRiscv64.h |
> 176 ++
> >  1 file changed, 176 insertions(+)
> >  create mode 100644
> edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
> > 
> >  diff --git a/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
> b/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
> >  new file mode 100644
> >  index ..4111b3ea
> >  --- /dev/null
> >  +++ b/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
> >  @@ -0,0 +1,176 @@
> >  +/** @file
> >  + RISCV64 platform ACPI related support April, 2022.
> >  +
> >  + SPDX-License-Identifier: BSD-2-Clause-Patent
> >  +**/
> >  +
> >  +#ifndef ACPI_RISCV64_H_
> >  +#define ACPI_RISCV64_H_
> >  +
> >  +//
> >  +// Ensure proper structure formats
> >  +//
> >  +#pragma pack(1)
> >  +
> >  +///
> >  +/// RISC-V Interrupt Type
> >  +///
> >  +#define EFI_ACPI_6_5_INC_RINTC_TYPE 0x18
> >  +#define EFI_ACPI_6_5_INC_IMSIC_TYPE 0x19
> >  +#define EFI_ACPI_6_5_INC_APLIC_TYPE 0x1A
> >  +#define EFI_ACPI_6_5_INC_PLIC_TYPE 0x1B
> >  +
> >  +///
> >  +/// RISC-V Interrupt Controller (RINTC)
> >  +///
> >  +typedef struct {
> >  + UINT8 Type;
> >  + UINT8 Length;
> >  + UINT8 Version;
> >  + UINT8 Reserved;
> >  + UINT32 Flags;
> >  + UINT64 HartId;
> >  + UINT32 Uid;
> >  + UINT32 ExtIntcId;
> >  + UINT64 ImsicAddr;
> >  + UINT32 ImsicSize;
> >  +} EFI_ACPI_6_5_INC_RINTC_STRUCTURE;
> >  +
> >  +///
> >  +/// Incoming MSI Controller (IMSIC)
> >  +///
> >  +typedef struct {
> >  + UINT8 Type;
> >  + UINT8 Length;
> >  + UINT8 Version;
> >  + UINT8 Reserved;
> >  + UINT32 Flags;
> >  + UINT16 NumIds;
> >  + UINT16 NumGuestIds;
> >  + UINT8 GuestIndexBits;
> >  + UINT8 HartIndexBits;
> >  + UINT8 GroupIndexBits;
> >  + UINT8 GroupIndexShift;
> >  +} EFI_ACPI_6_5_INC_IMSIC_STRUCTURE;
> >  +
> >  +///
> >  +/// RISC-V Advanced Platform Level Interrupt Controller (APLIC)
> >  +///
> >  +typedef struct {
> >  + UINT8 Type;
> >  + UINT8 Length;
> >  + UINT8 Version;
> >  + UINT8 AplicId;
> >  + UINT32 Flags;
> >  + UINT8 HW_ID[8];
> >  + UINT16 NumIdc;
> >  + UINT16 ExternSoureceSupport;
> >  + UINT32 GSysInterruptBase;
> >

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

[gaoliming via groups.io]

Sami and Pierre:

  What’s your comments for this patch? Is this a required bug fix or new
feature?

 

Thanks

Liming

发件人: Attar, AbdulLateef (Abdul Lateef)  
发送时间: 2024年5月9日 16:39
收件人: gaoliming ; devel@edk2.groups.io
抄送: 'Pierre Gondois' ; 'Sami Mujawar'

主题: Re: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
DynamicTablesPkg: Adds integer to the AML package node

 

[AMD Official Use Only - General]

 

Hi Liming,

This patch provides an API to add integer value to AML package node.

Using this API user can create CXL device with two PNPID.

Without this API user has to rely on static ASL files.

 

This patch is required for platform who uses DynamicTablesPkg to generate
ACPI tables based on this stable release.

 

Thanks

AbduL

  _  

From: gaoliming mailto:gaolim...@byosoft.com.cn>
>
Sent: Thursday, May 9, 2024 1:10 PM
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >; Attar, AbdulLateef
(Abdul Lateef) mailto:abdullateef.at...@amd.com>
>
Cc: 'Pierre Gondois' mailto:pierre.gond...@arm.com>
>; 'Sami Mujawar' mailto:sami.muja...@arm.com> >
Subject: 回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
DynamicTablesPkg: Adds integer to the AML package node 

 

Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.


Abdul:
  Can you give more information why this change is required for this stable
tag 202405?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> > 代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io  
> 抄送: Abdul Lateef Attar mailto:abdullateef.at...@amd.com> >; Pierre Gondois
> mailto:pierre.gond...@arm.com> >; Sami Mujawar
mailto:sami.muja...@arm.com> >
> 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
> DynamicTablesPkg: Adds integer to the AML package node
>
> Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
> which adds an integer value to the package node.
>
> Cc: Pierre Gondois mailto:pierre.gond...@arm.com>
>
> Cc: Sami Mujawar mailto:sami.muja...@arm.com> >
> Signed-off-by: Abdul Lateef Attar mailto:abdullateef.at...@amd.com> >
> ---
>  .../Include/Library/AmlLib/AmlLib.h   | 41 +++-
>  .../Common/AmlLib/CodeGen/AmlCodeGen.c| 67
> +++
>  2 files changed, 107 insertions(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> index 82d5464084..4427ab68fa 100644
> --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> @@ -2,7 +2,7 @@
>AML Lib.
>
>Copyright (c) 2019 - 2023, Arm Limited. All rights reserved.
> -  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.
> +  Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights
> reserved.
>
>SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> @@ -1743,6 +1743,45 @@ AmlAddNameStringToNamedPackage (
>IN AML_OBJECT_NODE_HANDLE  NamedNode
>);
>
> +/** Add an integer value to the named package node.
> +
> +  AmlCodeGenNamePackage ("_CID", NULL, );
> +  AmlGetEisaIdFromString ("PNP0A03", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +  AmlGetEisaIdFromString ("PNP0A08", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +
> +  equivalent of the following ASL code:
> +  Name (_CID, Package (0x02)  // _CID: Compatible ID
> +  {
> +  EisaId ("PNP0A03"),
> +  EisaId ("PNP0A08")
> +  })
> +
> +  The package is added at the tail of the list of the input package node
> +  name:
> +Name ("NamePackageNode", Package () {
> +  [Pre-existing package entries],
> +  [Newly created integer entry]
> +})
> +
> +
> +  @ingroup CodeGenApis
> +
> +  @param [in]   Integer   Integer value that need to be added to
> package node.
> +  @param [in, out]  NameNode  Package named node to add the object
> to.
> +
> +  @retval EFI_SUCCESS Success.
> +  @retval EFI_INVALID_PARAMETER   Invalid parameter.
> +  @retval Others  Error occurred during the operation.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlAddIntegerToNamedPackage (
> +  INUINT32  Integer,
> +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode
> +  );
> +
>  /** AML code generation to invoke/call another method.
>
>This method is a subset implementation of MethodInvocation
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> index 22c2d598d0..89fa4e06f8 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> @@ -3871,6 +3871,73 @@ exit_handler:
>return Status;
>  }
>
> +/** Add an integer value to the named package node.

回复: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on Mbedtls

[gaoliming via groups.io]

Seemly, this change is new feature to add more crypt APIs based on Mbedtls.

This patch set was submitted before soft feature freeze. But, it passed code
review after soft feature freeze starts. 

Based on current rule, this patch set is not allowed to be merged for this
stable tag 202405. 

If you want to catch this stable tag, please raise this requirement to the
mail list and collect the feedback. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Li, Yi
> 发送时间: 2024年5月9日 16:33
> 收件人: Hou, Wenxing ; gaoliming
> ; devel@edk2.groups.io
> 抄送: Yao, Jiewen 
> 主题: Re: [edk2-devel] [PATCH v3 00/11] Add more crypt APIs based on
Mbedtls
> 
> This patch set was submitted before soft freeze and will not affect other
existed
> codes, I am OK to merge it.
> 
> Hi Liming,
> 
> Do you have any comments?  I will merge it if no objections.
> 
> Thanks,
> Yi
> 
> -Original Message-
> From: Hou, Wenxing 
> Sent: Thursday, May 9, 2024 4:29 PM
> To: Li, Yi1 ; devel@edk2.groups.io
> Cc: Yao, Jiewen ; gaoliming
> 
> Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> Hi,
> 
> Thanks for your feedback.
> The new PR is: https://github.com/tianocore/edk2/pull/5645
> 
> Could Li Yi help me merge the PR?
> 
> Thanks,
> Wenxing
> 
> -Original Message-
> From: Li, Yi1 
> Sent: Thursday, May 9, 2024 2:54 PM
> To: Hou, Wenxing ; devel@edk2.groups.io
> Cc: Yao, Jiewen 
> Subject: RE: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> For this patch set:
> 
> Looks good to me.
> Reviewed-by: Yi Li 
> 
> 
> -Original Message-
> From: Hou, Wenxing 
> Sent: Thursday, May 9, 2024 2:27 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Li, Yi1 
> Subject: [PATCH v3 00/11] Add more crypt APIs based on Mbedtls
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
> 
> Add AeadAesGcm/Pem(only RSA)/X509(only RSA)/More
> RSA/PKCS5/pKCS7/Authenticode/Timestamp
> implementation based on Mbedtls.
> 
> The patch has passed the EDKII CI check:
> https://github.com/tianocore/edk2/pull/5552
> 
> And the patch has passed unit_test in EDKII and integration test for
platform.
> And the patch hass passed the fuzz test:
> https://github.com/tianocore/edk2-staging/commit/4f19398053c92e4f7791d4
> 68a184530b6ab89128
> 
> v2 changes:
>  - Fix format variable name/hardcode number issue;
>  - Fix Pkcs7 memory leak;
> 
> v3 changes:
>  - Fix some issues form reviewer;
>  - Add SHA3/SM3 implementation;
>  - Update *.inf files;
> 
> Cc: Jiewen Yao 
> Cc: Yi Li 
> Signed-off-by: Wenxing Hou 
> 
> Wenxing Hou (11):
>   CryptoPkg: Add AeadAesGcm based on Mbedtls
>   CryptoPkg: Add rand function for BaseCryptLibMbedTls
>   CryptoPkg: Add Pem APIs based on Mbedtls
>   CryptoPkg: Add X509 functions based on Mbedtls
>   CryptoPkg: Add Pkcs7 related functions based on Mbedtls
>   CryptoPkg: Add Pkcs5 functions based on Mbedtls
>   CryptoPkg: Add more RSA related functions based on Mbedtls
>   CryptoPkg: Add AuthenticodeVerify based on Mbedtls
>   CryptoPkg: Add ImageTimestampVerify based on Mbedtls
>   CryptoPkg: Update *.inf in BaseCryptLibMbedTls
>   Add SHA3/SM3 functions with openssl for Mbedtls
> 
>  CryptoPkg/Include/Library/BaseCryptLib.h  |4 +
>  .../BaseCryptLibMbedTls/BaseCryptLib.inf  |   47 +-
>  .../Cipher/CryptAeadAesGcm.c  |  227 ++
>  .../BaseCryptLibMbedTls/InternalCryptLib.h|   49 +
>  .../BaseCryptLibMbedTls/PeiCryptLib.inf   |   27 +-
>  .../BaseCryptLibMbedTls/Pem/CryptPem.c|  138 ++
>  .../Pk/CryptAuthenticode.c|  214 ++
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs1Oaep.c   |  278 +++
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs5Pbkdf2.c |  100 +
>  .../Pk/CryptPkcs7Internal.h   |   29 +-
>  .../BaseCryptLibMbedTls/Pk/CryptPkcs7Sign.c   |  635 ++
>  .../Pk/CryptPkcs7VerifyBase.c |  113 +
>  .../Pk/CryptPkcs7VerifyCommon.c   | 1354 
>  .../Pk/CryptPkcs7VerifyEku.c  |  689 ++
>  .../BaseCryptLibMbedTls/Pk/CryptRsaExt.c  |  352 +++
>  .../BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c  |  140
> ++  .../Library/BaseCryptLibMbedTls/Pk/CryptTs.c  |  381 
>  .../BaseCryptLibMbedTls/Pk/CryptX509.c| 1940
> +
>  .../BaseCryptLibMbedTls/Rand/CryptRand.c  |  114 +
>  .../BaseCryptLibMbedTls/Rand/CryptRandTsc.c   |  114 +
>  .../BaseCryptLibMbedTls/RuntimeCryptLib.inf   |   26 +-
>  .../BaseCryptLibMbedTls/SmmCryptLib.inf   |   36 +-
>  .../BaseCryptLibMbedTls/TestBaseCryptLib.inf  |   39 +-
>  CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf   |6 +
>  .../Library/MbedTlsLib/MbedTlsLibFull.inf |6 +
>  25 files changed, 6973 insertions(+), 85 deletions(-)  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Cipher/CryptAeadAesGcm.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pem/CryptPem.c
>  create mode 100644
> CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptAuthenticode.c
>  create mode 100644
> 

回复: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1] DynamicTablesPkg: Adds integer to the AML package node

[gaoliming via groups.io]

Abdul:
  Can you give more information why this change is required for this stable
tag 202405?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Abdul Lateef
> Attar via groups.io
> 发送时间: 2024年5月9日 12:49
> 收件人: devel@edk2.groups.io
> 抄送: Abdul Lateef Attar ; Pierre Gondois
> ; Sami Mujawar 
> 主题: [edk2-devel] [edk2-stable202405 RESEND PATCH v2 1/1]
> DynamicTablesPkg: Adds integer to the AML package node
> 
> Adds an AmlAddIntegerToNamedPackage() API to generate AML code,
> which adds an integer value to the package node.
> 
> Cc: Pierre Gondois 
> Cc: Sami Mujawar 
> Signed-off-by: Abdul Lateef Attar 
> ---
>  .../Include/Library/AmlLib/AmlLib.h   | 41 +++-
>  .../Common/AmlLib/CodeGen/AmlCodeGen.c| 67
> +++
>  2 files changed, 107 insertions(+), 1 deletion(-)
> 
> diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> index 82d5464084..4427ab68fa 100644
> --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> @@ -2,7 +2,7 @@
>AML Lib.
> 
>Copyright (c) 2019 - 2023, Arm Limited. All rights reserved.
> -  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.
> +  Copyright (C) 2023 - 2024, Advanced Micro Devices, Inc. All rights
> reserved.
> 
>SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> @@ -1743,6 +1743,45 @@ AmlAddNameStringToNamedPackage (
>IN AML_OBJECT_NODE_HANDLE  NamedNode
>);
> 
> +/** Add an integer value to the named package node.
> +
> +  AmlCodeGenNamePackage ("_CID", NULL, );
> +  AmlGetEisaIdFromString ("PNP0A03", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +  AmlGetEisaIdFromString ("PNP0A08", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +
> +  equivalent of the following ASL code:
> +  Name (_CID, Package (0x02)  // _CID: Compatible ID
> +  {
> +  EisaId ("PNP0A03"),
> +  EisaId ("PNP0A08")
> +  })
> +
> +  The package is added at the tail of the list of the input package node
> +  name:
> +Name ("NamePackageNode", Package () {
> +  [Pre-existing package entries],
> +  [Newly created integer entry]
> +})
> +
> +
> +  @ingroup CodeGenApis
> +
> +  @param [in]   Integer   Integer value that need to be added to
> package node.
> +  @param [in, out]  NameNode  Package named node to add the object
> to.
> +
> +  @retval EFI_SUCCESS Success.
> +  @retval EFI_INVALID_PARAMETER   Invalid parameter.
> +  @retval Others  Error occurred during the operation.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlAddIntegerToNamedPackage (
> +  INUINT32  Integer,
> +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode
> +  );
> +
>  /** AML code generation to invoke/call another method.
> 
>This method is a subset implementation of MethodInvocation
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> index 22c2d598d0..89fa4e06f8 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> @@ -3871,6 +3871,73 @@ exit_handler:
>return Status;
>  }
> 
> +/** Add an integer value to the named package node.
> +
> +  AmlCodeGenNamePackage ("_CID", NULL, );
> +  AmlGetEisaIdFromString ("PNP0A03", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +  AmlGetEisaIdFromString ("PNP0A08", );
> +  AmlAddIntegerToNamedPackage (EisaId, NameNode);
> +
> +  equivalent of the following ASL code:
> +  Name (_CID, Package (0x02)  // _CID: Compatible ID
> +  {
> +  EisaId ("PNP0A03"),
> +  EisaId ("PNP0A08")
> +  })
> +
> +  The package is added at the tail of the list of the input package node
> +  name:
> +Name ("NamePackageNode", Package () {
> +  [Pre-existing package entries],
> +  [Newly created integer entry]
> +})
> +
> +
> +  @ingroup CodeGenApis
> +
> +  @param [in]   Integer   Integer value that need to be added to
> package node.
> +  @param [in, out]  NameNode  Package named node to add the object
> to.
> +
> +  @retval EFI_SUCCESS Success.
> +  @retval EFI_INVALID_PARAMETER   Invalid parameter.
> +  @retval Others  Error occurred during the operation.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlAddIntegerToNamedPackage (
> +  INUINT32  Integer,
> +  IN  OUT   AML_OBJECT_NODE_HANDLE  NameNode
> +  )
> +{
> +  EFI_STATUS   Status;
> +  AML_OBJECT_NODE  *PackageNode;
> +
> +  if (NameNode == NULL) {
> +ASSERT_EFI_ERROR (FALSE);
> +return EFI_INVALID_PARAMETER;
> +  }
> +
> +  PackageNode = (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument (
> +  NameNode,
> +  EAmlParseIndexTerm1
> +  );
> +  if ((PackageNode == NULL)
> 

回复: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib

[gaoliming via groups.io]

Ard:
  Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature freeze. 
So, this patch set can be merged for this stable tag 202405. 

  And, this patch set has been merged. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Ard Biesheuvel
> 发送时间: 2024年5月9日 0:44
> 收件人: Wu, Jiaxin ; Liming Gao (Byosoft address)
> 
> 抄送: Yao, Jiewen ; Ni, Ray ;
> devel@edk2.groups.io; Zeng, Star ; Gerd Hoffmann
> ; Kumar, Rahul R ; Dong, Guo
> ; Rhodes, Sean ; Lu, James
> ; Guo, Gua ; Abdul Lateef Attar
> ; Abner Chang ; Tom
> Lendacky 
> 主题: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLib
> 
> Happy to merge this.
> 
> Liming, please let me know if this meets the soft freeze requirements?
> 
> Thanks,
> 
> 
> On Tue, 7 May 2024 at 07:18, Wu, Jiaxin  wrote:
> >
> > Thanks Jiewen.
> >
> >
> >
> >
> >
> >
> >
> > From: Yao, Jiewen 
> > Sent: Tuesday, May 7, 2024 12:59 PM
> > To: Wu, Jiaxin ; Ni, Ray ;
> devel@edk2.groups.io; Ard Biesheuvel 
> > Cc: Zeng, Star ; Gerd Hoffmann ;
> Kumar, Rahul R ; Dong, Guo ;
> Rhodes, Sean ; Lu, James ; Guo,
> Gua ; Abdul Lateef Attar ;
> Abner Chang ; Tom Lendacky
> 
> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib
> >
> >
> >
> > Acked-by: Jiewen Yao 
> >
> >
> >
> > From: Wu, Jiaxin 
> > Sent: Tuesday, May 7, 2024 11:39 AM
> > To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel
> ; Yao, Jiewen 
> > Cc: Zeng, Star ; Gerd Hoffmann ;
> Kumar, Rahul R ; Dong, Guo ;
> Rhodes, Sean ; Lu, James ; Guo,
> Gua ; Abdul Lateef Attar ;
> Abner Chang ; Tom Lendacky
> 
> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib
> >
> >
> >
> > Hi Jiewen and Ard,
> >
> >
> >
> > @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related to
> OVMF package since you are the OVMF maintainers. Please help check /review.
> >
> >
> >
> > The patches have been acked/tested by the Gerd.
> >
> >
> >
> >   [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for
> OVMF
> >   [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create
> gEfiSmmSmramMemoryGuid
> >   [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
> >   [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation
> is done or not
> >   [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
> >
> >
> >
> > Thanks,
> >
> > Jiaxin
> >
> >
> >
> > From: Wu, Jiaxin
> > Sent: Tuesday, April 30, 2024 6:14 PM
> > To: Ni, Ray ; devel@edk2.groups.io
> > Cc: Zeng, Star ; Gerd Hoffmann ;
> Kumar, Rahul R ; Dong, Guo ;
> Rhodes, Sean ; Lu, James ; Guo,
> Gua ; Ard Biesheuvel ; Yao,
> Jiewen ; Abdul Lateef Attar
> ; Abner Chang ; Tom
> Lendacky 
> > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib
> >
> >
> >
> > Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 
> > patches
> are tested & acted by Gerd:
> >
> > Tested-by: Gerd Hoffmann 
> >
> > Acked-by: Gerd Hoffmann 
> >
> >
> >
> > For each one: listed as below, *so need Ray “reviewed-by” tag on the patch:
> 05/06/14, need Gerd “reviewed-by” tag on the patch:  08/09/10/11/12*
> >
> >
> >
> >   [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class
> >
> > Reviewed-by: Ray Ni   --> no change compared to V3
> >
> >
> >   [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib
> library instance
> >
> > Reviewed-by: Ray Ni  --> no change compared to V3
> >
> >
> >   [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables
> >
> > Reviewed-by: Ray Ni  --> no change compared to V3
> >
> >
> >  [PATCH v4 04/14]  UefiCpuPkg/SmmRelocationLib: Avoid unnecessary
> memory allocation
> >
> > Reviewed-by: Ray Ni  --> no change compared to V3
> >
> >
> >   [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary
> global variable
> >   [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary
> CpuIndex
> >
> > * Change Based on Ray’s comment on V3: split the removal of CpuIndex
> parameter in a new patch, so add the 06 patch in V4.*
> >
> >
> >   [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance for
> AMD
> >
> > Reviewed-by: Abdul Lateef Attar  --> no change
> compared to V3
> >
> >
> >   [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for
> OVMF
> >   [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create
> gEfiSmmSmramMemoryGuid
> >   [PATCH v4 10/14]  OvmfPkg: Refine SmmAccess implementation
> >   [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation
> is done or not
> >   [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase
> >
> > *Change Based on Gerd’s  comment on V3: 1. Creating the
> EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own function.
> 2) refine the comment in SmmAccess 3) refine the commit log.*
> >
> >
> >   [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include
> SmmRelocationLib
> >
> > Reviewed-by: Gua Guo 
> >
> > Reviewed-by: Guo Dong 
> >
> >
> >   [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases
> relocation logic
> >
> > *Change Based on Ray’s comment on V3: move the "TileSize" 

回复: [edk2-devel][edk2-stable202405][PATCH] MdeModulePkg: Potential UINT32 overflow in S3 ResumeCount

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

This is a security fix. So, I think it should catch this stable tag 202405

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Pakkirisamy
> ShanmugavelX
> 发送时间: 2024年5月6日 17:53
> 收件人: devel@edk2.groups.io
> 抄送: Shanmugavel Pakkirisamy ;
> Zhiguang Liu ; Dandan Bi ;
> Liming Gao 
> 主题: [edk2-devel] [PATCH] MdeModulePkg: Potential UINT32 overflow in S3
> ResumeCount
> 
> From: Shanmugavel Pakkirisamy 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4677
> 
> Attacker able to modify physical memory and ResumeCount.
> System will crash/DoS when ResumeCount reaches its MAX_UINT32.
> 
> Cc: Zhiguang Liu 
> Cc: Dandan Bi 
> Cc: Liming Gao 
> 
> Signed-off-by: Pakkirisamy ShanmugavelX
> 
> ---
> 
> MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePe
> rformancePei.c | 14 +-
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> PerformancePei.c
> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> PerformancePei.c
> index 2f2b2a80b2..1035ed8640 100644
> ---
> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> PerformancePei.c
> +++
> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/Firmware
> PerformancePei.c
> @@ -112,11 +112,15 @@ FpdtStatusCodeListenerPei (
>//
>S3ResumeTotal = MultU64x32 (AcpiS3ResumeRecord->AverageResume,
> AcpiS3ResumeRecord->ResumeCount);
>AcpiS3ResumeRecord->ResumeCount++;
> -  AcpiS3ResumeRecord->AverageResume = DivU64x32 (S3ResumeTotal +
> AcpiS3ResumeRecord->FullResume, AcpiS3ResumeRecord->ResumeCount);
> -
> -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - ResumeCount
> = %d\n", AcpiS3ResumeRecord->ResumeCount));
> -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - FullResume
> = %ld\n", AcpiS3ResumeRecord->FullResume));
> -  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - AverageResume
> = %ld\n", AcpiS3ResumeRecord->AverageResume));
> +  if (AcpiS3ResumeRecord->ResumeCount > 0) {
> +AcpiS3ResumeRecord->AverageResume = DivU64x32 (S3ResumeTotal +
> AcpiS3ResumeRecord->FullResume, AcpiS3ResumeRecord->ResumeCount);
> +DEBUG ((DEBUG_INFO, "\nFPDT: S3 Resume Performance -
> AverageResume = 0x%x\n", AcpiS3ResumeRecord->AverageResume));
> +  }
> +  else {
> +DEBUG ((DEBUG_ERROR, "\nFPDT: S3 ResumeCount reaches the
> MAX_UINT32 value. S3 ResumeCount record reset to Zero."));
> +  }
> +  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - ResumeCount   =
> 0x%x\n", AcpiS3ResumeRecord->ResumeCount));
> +  DEBUG ((DEBUG_INFO, "FPDT: S3 Resume Performance - FullResume=
> 0x%x\n", AcpiS3ResumeRecord->FullResume));
> 
>//
>// Update S3 Suspend Performance Record.
> --
> 2.45.0.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118745): https://edk2.groups.io/g/devel/message/118745
Mute This Topic: https://groups.io/mt/105997183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] pr for stable tag

[gaoliming via groups.io]

Ard:
  I am OK to merge this regression bug fix for stable tag 202405. If no other 
comments, I will merge it. 

Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel 
> 发送时间: 2024年5月9日 0:15
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: Michael Kinney ; Leif Lindholm
> ; Peter Batard 
> 主题: Re: [edk2-devel] pr for stable tag
> 
> Yes
> 
> On Wed, 8 May 2024 at 17:36, gaoliming via groups.io
>  wrote:
> >
> > Ard:
> >   So, this patch needs to catch this stable tag. Right?
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 发件人: devel@edk2.groups.io  代表 Ard
> Biesheuvel
> > > 发送时间: 2024年5月8日 20:41
> > > 收件人: Liming Gao (Byosoft address) ; Michael
> > > Kinney ; Leif Lindholm
> > > ; edk2-devel-groups-io 
> > > 抄送: Peter Batard 
> > > 主题: [edk2-devel] pr for stable tag
> > >
> > > Please set the push label on
> > >
> > > https://github.com/tianocore/edk2/pull/5642
> > >
> > > discussed here:
> > >
> > > https://openfw.io/edk2-devel/20240508085148.1725-1-p...@akeo.ie/
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> > 
> >
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118744): https://edk2.groups.io/g/devel/message/118744
Mute This Topic: https://groups.io/mt/105997173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] pr for stable tag

[gaoliming via groups.io]

Ard:
  So, this patch needs to catch this stable tag. Right?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Ard Biesheuvel
> 发送时间: 2024年5月8日 20:41
> 收件人: Liming Gao (Byosoft address) ; Michael
> Kinney ; Leif Lindholm
> ; edk2-devel-groups-io 
> 抄送: Peter Batard 
> 主题: [edk2-devel] pr for stable tag
> 
> Please set the push label on
> 
> https://github.com/tianocore/edk2/pull/5642
> 
> discussed here:
> 
> https://openfw.io/edk2-devel/20240508085148.1725-1-p...@akeo.ie/
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118689): https://edk2.groups.io/g/devel/message/118689
Mute This Topic: https://groups.io/mt/105983425/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 6/6] MdeModulePkg: Adding SpiHc Drivers
> >
> > From: Brit Chesley 
> >
> > Including the SpiHc drivers in MdeModulePkg.dsc
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 177128bdfd3e..a1c8e2f90524 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -290,6 +290,8 @@ [Components]
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> > nf
> >MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
> >MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
> > +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcDxe.inf
> > +  MdeModulePkg/Bus/Spi/SpiHc/SpiHcSmm.inf
> >
> >MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> >MdeModulePkg/Core/Pei/PeiMain.inf
> > --
> > 2.42.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118629): https://edk2.groups.io/g/devel/message/118629
Mute This Topic: https://groups.io/mt/105953681/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:09
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 3/6] MdeModulePkg: Adding SpiBus Drivers
> >
> > From: Brit Chesley 
> >
> > Including the SpiBus drivers in MdeModulePkg.dsc
> >
> > Platform Initialization spec 1.7 volume 5 section 18.1.6
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 6bed9205ea69..33d6f4a1f6a6 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -287,6 +287,8 @@ [Components]
> >
> > MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> > eviceDxe.inf
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.inf
> >
> > MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.i
> > nf
> > +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusDxe.inf
> > +  MdeModulePkg/Bus/Spi/SpiBus/SpiBusSmm.inf
> >
> >MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> >MdeModulePkg/Core/Pei/PeiMain.inf
> > --
> > 2.42.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118628): https://edk2.groups.io/g/devel/message/118628
Mute This Topic: https://groups.io/mt/105953680/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Chang, Abner 
> 发送时间: 2024年5月6日 19:08
> 收件人: Chesley, Brit ; devel@edk2.groups.io
> 抄送: Liming Gao ; Ray Ni ;
Attar,
> AbdulLateef (Abdul Lateef) 
> 主题: RE: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
lib
> instance
> 
> [AMD Official Use Only - General]
> 
> Hi MdeModulePkg maintainers,
> Please review this patch as we would like to merge it before the upcoming
hard
> freeze.
> Thanks
> Abner
> 
> > -Original Message-
> > From: Chesley, Brit 
> > Sent: Thursday, May 2, 2024 3:05 AM
> > To: devel@edk2.groups.io
> > Cc: Liming Gao ; Ray Ni ;
> > Chang, Abner ; Attar, AbdulLateef (Abdul Lateef)
> > 
> > Subject: [PATCH v1 4/6] MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL
> > lib instance
> >
> > From: Brit Chesley 
> >
> > Adding NULL SpiHcPlatformLib instance. This library is responsible for
> > handling the low level details of the SPI host controller. Since this is
> > platform specific this library will be dependent on OEM SPI
> > implementation. The SPI host controller layer will utilize this library
> > for SPI bus transactions.
> >
> > Bugzilla #4753
> >
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Signed-off-by: Brit Chesley 
> > ---
> >  MdeModulePkg/MdeModulePkg.dec |   5 +
> >  MdeModulePkg/MdeModulePkg.dsc |   2 +
> >  .../BaseSpiHcPlatformLibNull.inf  |  33 
> >  .../Include/Library/SpiHcPlatformLib.h| 148 ++
> >  .../BaseSpiHcPlatformLibNull.c| 145
> +
> >  .../BaseSpiHcPlatformLibNull.uni  |  11 ++
> >  6 files changed, 344 insertions(+)
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > inf
> >  create mode 100644 MdeModulePkg/Include/Library/SpiHcPlatformLib.h
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > c
> >  create mode 100644
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > uni
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 085370eae41a..8a3bcb9aded1 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -169,6 +169,11 @@ [LibraryClasses]
> >#
> >ImagePropertiesRecordLib|Include/Library/ImagePropertiesRecordLib.h
> >
> > +  ##  @libraryclass   Platform SPI Host Controller library which
provides
> low-
> > level
> > +  #   control over the SPI hardware
> > +  #
> > +  SpiHcPlatformLib|Include/Library/SpiHcPlatformLib.h
> > +
> >  [Guids]
> >## MdeModule package token space guid
> ># Include/Guid/MdeModulePkgTokenSpace.h
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc
> > index 33d6f4a1f6a6..177128bdfd3e 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -107,6 +107,7 @@ [LibraryClasses]
> >
> > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo
> > ckMemoryLibNull.inf
> >
> > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseV
> > ariableFlashInfoLib.inf
> >
> > IpmiCommandLib|MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIp
> > miCommandLibNull.inf
> > +
> > SpiHcPlatformLib|MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpi
> > HcPlatformLibNull.inf
> >
> >  [LibraryClasses.EBC.PEIM]
> >IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf
> > @@ -528,6 +529,7 @@ [Components.IA32, Components.X64]
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.i
> > nf
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.in
> > f
> >
> > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSys
> > TLib.inf
> > +
> > MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.
> > inf
> >
> >  [Components.X64]
> >MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf
> > diff --git
> > a/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > new file mode 100644
> > index ..805f50b89565
> > --- /dev/null
> > +++
> > b/MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibN
> > ull.inf
> > @@ -0,0 +1,33 @@
> > +## @file
> > +#  NULL library for platform SPI Host controller, which should be
provided
> > +#  by the OEM.
> > +#
> > +#  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.

> > +#
> > +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +##
> > +[Defines]
> > +  INF_VERSION   = 1.27
> > +  BASE_NAME = BaseSpiHcPlatformLibNull
> > +  FILE_GUID =
> 3C230948-6DF5-4802-8177-967A190579CF
> > +  MODULE_TYPE   = BASE
> > +  VERSION_STRING= 0.1
> > +  PI_SPECIFICATION_VERSION  = 0x0001000A
> > +  LIBRARY_CLASS  

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

Yes. I just add PUSH label. If it passes CI, it will be merged. 

 

发件人: devel@edk2.groups.io  代表 Xianglei Cai
发送时间: 2024年5月7日 9:24
收件人: gaoliming ; Shih, More ; 
devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof 
; Huang, Jenny 
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

 

Hi Liming,

 

I create one pull request: MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error by Xianglei-Cai · Pull Request #5631 · tianocore/edk2 
(github.com)  .

Is it helpful for merge the change?

 

Thanks,

Xianglei

 

From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Tuesday, May 7, 2024 9:12 AM
To: Shih, More mailto:more.s...@intel.com> >; Cai, 
Xianglei mailto:xianglei@intel.com> >; 
devel@edk2.groups.io  
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

 

I will merge it this week. 

 

发件人: Shih, More mailto:more.s...@intel.com> > 
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei mailto:xianglei@intel.com> >; 
gaoliming mailto:gaolim...@byosoft.com.cn> >; 
devel@edk2.groups.io  
抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while 
USB Transaction error

 

Hi Gaoliming,

 

Could you help push the PR ?

 

BR,

More Shih

  _  

From: Cai, Xianglei mailto:xianglei@intel.com> >
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error 

 

I have no access to push PR. But I tried with my personal fork, it can pass CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io  ; Cai, Xianglei 
mailto:xianglei@intel.com> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint 
while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io   
> mailto:devel@edk2.groups.io> > 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
> devel@edk2.groups.io  
> 抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi @gaoliming
> 
> Could you provide the eta when the patch can be merged?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn> >; 
> devel@edk2.groups.io  
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi Liming,
> 
> Could you help pick the change to the master branch?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: gaoliming mailto:gaolim...@byosoft.com.cn> >
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io  ; Cai, Xianglei 
> mailto:xianglei@intel.com> >
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski, 
> Krzysztof 
> mailto:krzysztof.lewandow...@intel.com> >; 
> Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More 
> mailto:more.s...@intel.com> >
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Reviewed-by: Liming Gao   >
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io   
> > mailto:devel@edk2.groups.io> 

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

I will merge it this week. 

 

发件人: Shih, More  
发送时间: 2024年5月6日 11:34
收件人: Cai, Xianglei ; gaoliming
; devel@edk2.groups.io
抄送: Ni, Ray ; Lewandowski, Krzysztof
; Huang, Jenny 
主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint
while USB Transaction error

 

Hi Gaoliming,

 

Could you help push the PR ?

 

BR,

More Shih

  _  

From: Cai, Xianglei mailto:xianglei@intel.com>
>
Sent: Friday, April 26, 2024 5:13 PM
To: gaoliming mailto:gaolim...@byosoft.com.cn> >;
devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
endpoint while USB Transaction error 

 

I have no access to push PR. But I tried with my personal fork, it can pass
CI.

Thanks,
Xianglei

-Original Message-
From: gaoliming mailto:gaolim...@byosoft.com.cn>
> 
Sent: Friday, April 26, 2024 4:44 PM
To: devel@edk2.groups.io  ; Cai, Xianglei
mailto:xianglei@intel.com> >
Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
endpoint while USB Transaction error

Can you create PR for this patch? If it passes CI, I will add push label. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> > 代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming mailto:gaolim...@byosoft.com.
cn> >; devel@edk2.groups.io  
> 抄送: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi @gaoliming
> 
> Could you provide the eta when the patch can be merged?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming mailto:gaolim...@byosoft.com.cn>
>; devel@edk2.groups.io  
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Hi Liming,
> 
> Could you help pick the change to the master branch?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: gaoliming mailto:gaolim...@byosoft.com.cn> >
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io  ; Cai, Xianglei
mailto:xianglei@intel.com> >
> Cc: Ni, Ray mailto:ray...@intel.com> >; Lewandowski,
Krzysztof 
> mailto:krzysztof.lewandow...@intel.com>
>; Huang, Jenny 
> mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset 
> endpoint while USB Transaction error
> 
> Reviewed-by: Liming Gao mailto:gaolim...@byosoft.com.cn> >
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io   mailto:devel@edk2.groups.io> > 代表 Xianglei
> Cai
> > 发送时间: 2024年4月15日 14:55
> > 收件人: devel@edk2.groups.io  
> > 抄送: Xianglei Cai mailto:xianglei@intel.com> >; Ray Ni 
> > mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Krzysztof 
> > Lewandowski mailto:krzysztof.lewandow...@intel.com> >; Jenny Huang 
> > mailto:jenny.hu...@intel.com> >; More Shih
mailto:more.s...@intel.com> >
> > 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint
> > while USB Transaction error
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4556
> >
> > Based on XHCI spec 4.8.3, software should do the reset endpoint 
> > while USB Transaction occur.
> > Add the error code for USB Transaction error since UEFI spec don't 
> > have the related definition.
> >
> > Cc: Ray Ni  mailto:ray...@intel.com>
>
> > Cc: Liming Gao  mailto:gaolim...@byosoft.com.cn> >
> > Cc: Krzysztof Lewandowski   
> > Cc: Jenny Huang mailto:jenny.hu...@intel.com> >
> > Cc: More Shih   mailto:more.s...@intel.com> >
> > Signed-off-by: Xianglei Cai mailto:xianglei@intel.com> >
> > Reviewed-by: Krzysztof Lewandowski mailto:krzysztof.lewandow...@intel.com> >
> > ---
> >  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  | 5 -
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 - 
> > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++
> >  3 

[edk2-devel] 回复: [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to Dmem.c

[gaoliming via groups.io]

Sam:

Thanks for your update. This version patch is good to me. Reviewed-by:
Liming Gao 

Besides, is there a Pull Request for this patch set?

Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor 
> 发送时间: 2024年5月1日 22:58
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni ; Zhichao Gao ;
> Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Stuart
> Yoder 
> 主题: [PATCH v7 0/5] Adding support for veborse UEFI Table dumping to
> Dmem.c
> 
> This adds an additional option to the dmem UEFI shell command for verbose
> dumping of a couple of UEFI tables.
> 
> The tables specified are the RT Properties Table, the Image Execution
Table,
> and the Conformance Profiles table.
> 
> Supporting objects are added in the .inf and .uni files relating to Dmem.c
and
> an additional header file for the Conformance Profiles table was added.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> 
> v6->v7:
> - Additional patch to separate UEFI and EBBR Guids
> 
> Cc: Ray Ni 
> Cc: Zhichao Gao 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Stuart Yoder 
> Signed-off-by: Sam Kaynor 
> 
> Sam Kaynor (5):
>   ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in
> Dmem.c
>   ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c
>   MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE
>   MdePkg: Adding EBBR EFI_CONFORMANCE_PROFILE_TABLE GUIDs
>   ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c
> 
>  MdePkg/MdePkg.dec
> |  10 +
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsL
> ib.inf |   4 +
>  MdePkg/Include/Guid/ConformanceProfiles.h
> |  63 
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
> | 321 ++--
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsL
> ib.uni |  31 +-
>  5 files changed, 402 insertions(+), 27 deletions(-)
>  create mode 100644 MdePkg/Include/Guid/ConformanceProfiles.h
> 
> --
> 2.34.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118582): https://edk2.groups.io/g/devel/message/118582
Mute This Topic: https://groups.io/mt/105933482/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v3 1/3] MdePkg: Add TcgSp800155Event3 type info

[gaoliming via groups.io]

Acked-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Dionna Glaze
> via groups.io
> 发送时间: 2024年5月2日 8:50
> 收件人: devel@edk2.groups.io
> 抄送: Dionna Glaze ; Michael D Kinney
> ; Liming Gao ;
> Zhiguang Liu ; Jiewen Yao 
> 主题: [edk2-devel] [PATCH v3 1/3] MdePkg: Add TcgSp800155Event3 type
> info
> 
> TCG PC Client Platform Firmware Profile 1.06 revision 52 of December
> 2023 added a new event signature and extended information about where a
> reference measurement document for the firmware can be found.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> 
> Reviewed-By: Jiewen Yao 
> Signed-off-by: Dionna Glaze 
> ---
>  .../IndustryStandard/UefiTcgPlatform.h| 38
> ++-
>  1 file changed, 37 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> index 61bd4e4667..aaee5d6c88 100644
> --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> @@ -451,6 +451,7 @@ typedef struct tdTCG_PCClientTaggedEvent {
> 
>  #define TCG_Sp800_155_PlatformId_Event_SIGNATURE   "SP800-155
> Event"
>  #define TCG_Sp800_155_PlatformId_Event2_SIGNATURE  "SP800-155
> Event2"
> +#define TCG_Sp800_155_PlatformId_Event3_SIGNATURE  "SP800-155
> Event3"
> 
>  typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
>UINT8   Signature[16];
> @@ -478,9 +479,44 @@ typedef struct
> tdTCG_Sp800_155_PlatformId_Event2 {
>// UINT8
> FirmwareManufacturerStr[FirmwareManufacturerStrSize];
>// UINT32  FirmwareManufacturerId;
>// UINT8   FirmwareVersion;
> -  // UINT8   FirmwareVersion[FirmwareVersionSize]];
> +  // UINT8   FirmwareVersion[FirmwareVersionSize];
>  } TCG_Sp800_155_PlatformId_Event2;
> 
> +typedef struct tdTCG_Sp800_155_PlatformId_Event3 {
> +  UINT8   Signature[16];
> +  //
> +  // Where Vendor ID is an integer defined
> +  // at http://www.iana.org/assignments/enterprisenumbers
> +  //
> +  UINT32  VendorId;
> +  //
> +  // 16-byte identifier of a given platform's static configuration of code
> +  //
> +  EFI_GUIDReferenceManifestGuid;
> +  // UINT8   PlatformManufacturerStrSize;
> +  // UINT8
> PlatformManufacturerStr[PlatformManufacturerStrSize];
> +  // UINT8   PlatformModelSize;
> +  // UINT8   PlatformModel[PlatformModelSize];
> +  // UINT8   PlatformVersionSize;
> +  // UINT8   PlatformVersion[PlatformVersionSize];
> +  // UINT8   PlatformModelSize;
> +  // UINT8   PlatformModel[PlatformModelSize];
> +  // UINT8   FirmwareManufacturerStrSize;
> +  // UINT8
> FirmwareManufacturerStr[FirmwareManufacturerStrSize];
> +  // UINT32  FirmwareManufacturerId;
> +  // UINT8   FirmwareVersion;
> +  // UINT8   FirmwareVersion[FirmwareVersionSize];
> +  //
> +  // Below structure is newly added in TCG_Sp800_155_PlatformId_Event3
> +  //
> +  // UINT32  RimLocatorType;
> +  // UINT32  RimLocatorLength;
> +  // UINT8   RimLocator[RimLocatorLength];
> +  // UINT32  PlatformCertLocatorType;
> +  // UINT32  PlatformCertLocatorLength;
> +  // UINT8
> PlatformCertLocator[PlatformCertLocatorLength];
> +} TCG_Sp800_155_PlatformId_Event3;
> +
>  #define TCG_EfiStartupLocalityEvent_SIGNATURE  "StartupLocality"
> 
>  //
> --
> 2.45.0.rc0.197.gbae5840b3b-goog
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118581): https://edk2.groups.io/g/devel/message/118581
Mute This Topic: https://groups.io/mt/105933440/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Felix:
 I understand your point. I would suggest to directly add 
PI_SPECIFICATION_VERSION definition, and update PEI/DXE/SMM version to align 
with it. 
 
 Original PEI/DXE/SMM minor and major version definitions are still kept now. 

Thanks
Liming
> -邮件原件-
> 发件人: Felix Polyudov 
> 发送时间: 2024年5月1日 6:35
> 收件人: gaoliming ; Sachin Ganesh
> ; devel@edk2.groups.io
> 抄送: zhiguang@intel.com; michael.d.kin...@intel.com;
> ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com;
> Dhanaraj V 
> 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> Liming,
> 
> In PI 1.8 macros for major and minor versions have been replaced with a
> single revision macro combining both version elements.
> Refer to:
> PEI:
> https://uefi.org/specs/PI/1.8/V1_PEI_Services_Table.html#related-definition
> s
> DXE: https://uefi.org/specs/PI/1.8/V2_UEFI_System_Table.html#dxe-services
> MM:
> https://uefi.org/specs/PI/1.8/V4_Management_Mode_System_Table.html#e
> fi-mm-system-table
> 
> If patch is updated to literally follow the spec, the following macros will be
> removed:
> PEI_SPECIFICATION_MAJOR_REVISION
> PEI_SPECIFICATION_MINOR_REVISION
> DXE_SPECIFICATION_MAJOR_REVISION
> DXE_SPECIFICATION_MINOR_REVISION
> MM_SPECIFICATION_MAJOR_REVISION
> MM_SPECIFICATION_MINOR_REVISION
> 
> These macros exist for a long time, so their removal can break some code in
> the downstream projects.
> That's why we thought it would be safer to honor the spirit of the spec
> without following it literally.
> 
> Let us know if you want us to update the patch to match the spec.
> 
> -Original Message-
> From: gaoliming 
> Sent: Friday, April 26, 2024 5:23 AM
> To: Sachin Ganesh ; Felix Polyudov
> ; devel@edk2.groups.io
> Cc: zhiguang@intel.com; michael.d.kin...@intel.com;
> ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com;
> Dhanaraj V 
> Subject: 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on
> UEFI 2.10 and PI 1.8 Specification
> 
> Felix and Sachin:
>   I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest
> public PI 1.8A. So, this change may not be added now.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Sachin Ganesh 
> > 发送时间: 2024年4月25日 17:57
> > 收件人: Felix Polyudov ; gaoliming
> > ; devel@edk2.groups.io
> > 抄送: zhiguang@intel.com; michael.d.kin...@intel.com;
> > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> > erdemak...@google.com; min.m...@intel.com;
> thomas.lenda...@amd.com;
> > Dhanaraj V 
> > 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> > 2.10 and PI 1.8 Specification
> >
> > Hi Felix/ Liming,
> >
> > Thank you for your comments. Patch 6 has been updated to only focus on
> > consolidating the revision macros.
> >
> > Patch Link:
> >
> https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2
> 52
> >
> C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%
> > 2C105721897
> > PR Link: https://github.com/tianocore/edk2/pull/5569
> >
> > Thank you,
> > Sachin.
> >
> > -Original Message-
> > From: Felix Polyudov 
> > Sent: Tuesday, April 23, 2024 10:58 PM
> > To: gaoliming ; Sachin Ganesh
> > ; devel@edk2.groups.io
> > Cc: zhiguang@intel.com; michael.d.kin...@intel.com;
> > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> > erdemak...@google.com; min.m...@intel.com;
> thomas.lenda...@amd.com;
> > Dhanaraj V 
> > Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on
> UEFI
> > 2.10 and PI 1.8 Specification
> >
> > I think patch 6 can be updated to introduce unified PI specification
> versioning
> > macros without incrementing the minor revision, by changing
> > PI_SPECIFICATION_MINOR_REVISION back to 70.
> > This will ensure compliance with the versioning schema introduced in PI
> 1.7B
> > without changing the PI support level.
> > (the macros were introduced by PIWG mantis 2101)
> >
> > -Original Message-
> > From: gaoliming 
> > Sent: Tuesday, April 23, 2024 10:49 AM
> > To: Sachin Ganesh ; devel@edk2.groups.io
> > Cc: zhiguang@intel.com; michael.d.kin...@intel.com;
> > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> > erdemak...@google.com; min.m...@intel.com;
> thomas.lenda...@amd.com;
> > Felix Polyudov ; Dhanaraj V 
> > Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10
> > and PI 1.8 Specification
> >
> >
> > **CAUTION: The e-mail below is from an external source. Please exercise
> > caution before opening attachments, clicking links, or following guidance.**
> >
> > Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
> > 
> >
> > I suggest to merge others first. The patch 6/7 to update PI version from 1.7
> to
> > 1.8 can be discussed first.
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 

[edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Praveen Sankar N 
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; Srinivasan Mani ;
> Sundaresan S ; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Rabisha R
> 
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> 
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> 
> Signed-off-by: Praveen Sankar N praveensank...@ami.com
> 
> Cc: michael.d.kin...@intel.com
> 
> Cc: gaolim...@byosoft.com.cn
> 
> Cc: zhiguang@intel.com
> 
> Cc: fel...@ami.com
> 
> Cc: srinivas...@ami.com
> 
> Cc: sundares...@ami.com
> 
> Cc: rabis...@ami.com
> ---
>  .../SerialPortConsoleRedirectionTable.h   | 32 +++
>  1 file changed, 32 insertions(+)
> 
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
>  ///
> 
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION  0x02
> 
> 
> 
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
> 
>  ///
> 
>  /// Serial Port Console Redirection Table Format
> 
>  ///
> 
> @@ -50,6 +51,37 @@ typedef struct {
>UINT32Reserved3;
> 
>  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> 
> 
> 
> +///
> 
> +/// Serial Port Console Redirection Table Format Revision 4
> 
> +///
> 
> +typedef struct {
> 
> +  EFI_ACPI_DESCRIPTION_HEADER   Header;
> 
> +  UINT8 InterfaceType;
> 
> +  UINT8 Reserved1[3];
> 
> +  EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTUREBaseAddress;
> 
> +  UINT8 InterruptType;
> 
> +  UINT8 Irq;
> 
> +  UINT32
> GlobalSystemInterrupt;
> 
> +  UINT8 BaudRate;
> 
> +  UINT8 Parity;
> 
> +  UINT8 StopBits;
> 
> +  UINT8 FlowControl;
> 
> +  UINT8 TerminalType;
> 
> +  UINT8 Reserved2;
> 
> +  UINT16PciDeviceId;
> 
> +  UINT16PciVendorId;
> 
> +  UINT8 PciBusNumber;
> 
> +  UINT8 PciDeviceNumber;
> 
> +  UINT8 PciFunctionNumber;
> 
> +  UINT32PciFlags;
> 
> +  UINT8 PciSegment;
> 
> +  UINT32UartClockFrequency;
> 
> +  UINT32PreciseBaudRate;
> 
> +  UINT16
> NameSpaceStrLength;
> 
> +  UINT16
> NameSpaceStrOffset;
> 
> +  CHAR8
> NameSpaceString[0];
> 
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> 
> +
> 
>  #pragma pack()
> 
> 
> 
>  //
> 
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118578): https://edk2.groups.io/g/devel/message/118578
Mute This Topic: https://groups.io/mt/105933234/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2] MdePkg: Add Cxl30.h into IndustryStandard

[gaoliming via groups.io]

Foster:
  This change has been merged. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Nong, Foster
> 发送时间: 2024年4月29日 15:19
> 收件人: devel@edk2.groups.io
> 抄送: Kinney, Michael D ; Liming Gao
> ; Ni, Ray ; Chris Li
> 
> 主题: Re: [edk2-devel] [PATCH v2] MdePkg: Add Cxl30.h into
> IndustryStandard
> 
> Hi Liming,
> The Patch V2 will help fix the CI failure on Uncrustify issue.
> 
> There is CI failure in https://github.com/tianocore/edk2/pull/5585.
> 
> -Original Message-
> From: Nong, Foster 
> Sent: Monday, April 29, 2024 3:10 PM
> To: devel@edk2.groups.io
> Cc: Nong, Foster ; Kinney, Michael D
> ; Liming Gao ; Ni,
> Ray ; Chris Li 
> Subject: [PATCH v2] MdePkg: Add Cxl30.h into IndustryStandard
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4516
> 
> 1) Add CXL 3.0 header file to comply with CXL 3.0 specification
> 2) CXL 3.0 header will embed Cxl20.h
> 3) Updated Cxl.h to point to 3.0 header file
> 
> Signed-off-by: Foster Nong 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Ray Ni 
> Cc: Chris Li 
> ---
>  MdePkg/Include/IndustryStandard/Cxl.h   |   2 +-
>  MdePkg/Include/IndustryStandard/Cxl30.h | 316 
>  2 files changed, 317 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Cxl.h
> b/MdePkg/Include/IndustryStandard/Cxl.h
> index 9ad3242e25..cb623a355d 100755
> --- a/MdePkg/Include/IndustryStandard/Cxl.h
> +++ b/MdePkg/Include/IndustryStandard/Cxl.h
> @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent  #ifndef
> _CXL_MAIN_H_ #define _CXL_MAIN_H_ -#include
> +#include  // // CXL
> assigned new Vendor ID //diff --git
> a/MdePkg/Include/IndustryStandard/Cxl30.h
> b/MdePkg/Include/IndustryStandard/Cxl30.h
> new file mode 100644
> index 00..7a9a6d6940
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/Cxl30.h
> @@ -0,0 +1,316 @@
> +/** @file+  CXL 3.0 Register definitions++  This file contains the
register
> definitions based on the Compute Express Link+  (CXL) Specification
Revision
> 3.0.++  Copyright (c) 2024, Intel Corporation. All rights reserved.++
> SPDX-License-Identifier: BSD-2-Clause-Patent++**/++#ifndef
> CXL30_H_+#define CXL30_H_++#include ++//+//
> CXL Cache Memory Capability IDs+// Compute Express Link Specification
> Revision 3.0 - Chapter 8.2.4 Table 8-22+//+#define
> CXL_CACHE_MEM_CAPABILITY_ID_TIMEOUT_AND_ISOLATION
> 0x0009+#define CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED
> 0x000A+#define CXL_CACHE_MEM_CAPABILITY_ID_BI_ROUTE_TABLE
> 0x000B+#define CXL_CACHE_MEM_CAPABILITY_ID_BI_DECODER
> 0x000C+#define
> CXL_CACHE_MEM_CAPABILITY_ID_CACHE_ID_ROUTE_TABLE
> 0x000D+#define CXL_CACHE_MEM_CAPABILITY_ID_CACHE_ID_DECODER
> 0x000E+#define
> CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED_HDM_DECODER
> 0x000F++//+// CXL_Capability_Version+// Compute Express ink Specification
> Revision 3.0 - Chapter 8.2.4.5+//+#define CXL_HDM_DECODER_VERSION_30
> 0x3++//+// CXL CXL HDM Decoder n Control+// Compute Express Link
> Specification Revision 3.0 - 8.2.4.19.7+//+//+// Bit4..7: Interleave Ways
> (IW)+//+#define CXL_HDM_16_WAY_INTERLEAVING  0x4+#define
> CXL_HDM_3_WAY_INTERLEAVING   0x8+#define
> CXL_HDM_6_WAY_INTERLEAVING   0x9+#define
> CXL_HDM_12_WAY_INTERLEAVING  0xA++//+// Ensure proper structure
> formats+//+#pragma pack(1)++//+// CXL.cachemem Extended Register
> Capability+// Compute Express Link Specification Revision 3.0  - Chapter
> 8.2.4.24+//+typedef union {+  struct {+UINT32
> ExtendedRangesBitmap : 16;  // Bit 0..15+UINT32
> Reserved : 16;  // Bit 16..31+  } Bits;+  UINT32
> Uint32;+} CXL_CM_EXTENTED_REGISTER_CAPABILITY;++#define
> CXL_CM_EXTENTED_RANGES_BITMAP  (BIT2 | BIT3 | BIT4 | BIT5 | BIT6 |
> BIT7 | BIT8 | BIT9 | BIT10 | BIT11 | BIT12 | BIT13 | BIT15)++//+// CXL BI
> Route Table Capability+// Compute Express Link Specification Revision 3.0
-
> Chapter 8.2.4.25+//+typedef union {+  struct {+UINT32
> ExplicitBiRtCommitRequired : 1;  // bit 0+UINT32
> Reserved   : 31; // bit 1..31+  }
> Bits;+  UINT32Uint32;+} CXL_BI_RT_CAPABILITY;++typedef union {+
> struct {+UINT32BiRtCommit : 1;
> // bit 0+UINT32Reserved   : 31;
> // bit 1..31+  } Bits;+  UINT32Uint32;+}
> CXL_BI_RT_CONTROL;++typedef union {+  struct {+UINT32
> BiRtCommitted  : 1;  // bit 0+
> UINT32BiRtErrorNotCommitted  : 1;  // bit
> 1+UINT32Reserved1  : 6;
> // bit 2..7+UINT32BiRtCommitTimeoutScale : 4;
> // bit 8..11+UINT32BiRtCommitTimeoutBase  : 4;
> // bit 12..15+UINT32Reserved2  : 16;
> // bit 16..31+  } Bits;+  UINT32Uint32;+}
> CXL_BI_RT_STATUS;++typedef struct {+  CXL_BI_RT_CAPABILITY
> BiRtCap;  // offset 0x00+
> CXL_BI_RT_CONTROL   BiRtControl;  //
> offset 0x04+  CXL_BI_RT_STATUSBiRtStatus;
> // offset 0x08+} CXL_BI_ROUTE_TABLE_CAPABILITY;++//+// CXL 

回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec

[gaoliming via groups.io]

I see your patch in ShellPkg. For this change in MdePkg, Reviewed-by: Liming
Gao 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 gaoliming via
> groups.io
> 发送时间: 2024年4月15日 14:33
> 收件人: devel@edk2.groups.io; shenbagade...@ami.com
> 抄送: 'Sainadh Nagolu' ; 'Sundaresan S'
> ; 'Srinivasan Mani' ;
> 'Ramesh R' 
> 主题: 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0
> Spec
> 
> Shenbagadevi:
>   I think you still need to update ShellPkg SmbiosView to support the
> updated TYPE17.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表
> Shenbagadevi
> > R via groups.io
> > 发送时间: 2023年11月17日 18:05
> > 收件人: devel@edk2.groups.io; Shenbagadevi R
> 
> > 抄送: gaolim...@byosoft.com.cn; Sainadh Nagolu ;
> > Sundaresan S ; Srinivasan Mani
> > ; Ramesh R 
> > 主题: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
> >
> > As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
> > PMIC & RCD manufacturer ID and Revision information in Type17.
> >
> > Signed-off-by: Shenbagadevi R 
> >
> > CC: Gaoliming 
> > CC: Sainadh N 
> > CC: Sundaresan S 
> > CC: Srinivasan M 
> > CC: Ramesh R 
> >
> > ---
> >  MdePkg/Include/IndustryStandard/SmBios.h | 11 +--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > b/MdePkg/Include/IndustryStandard/SmBios.h
> > index 56cec615a0..cfefc2fa52 100644
> > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights
> > reserved.
> >  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development
> LP
> >
> >  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development
> LP
> >
> >  Copyright (c) 2022, AMD Incorporated. All rights reserved.
> >
> > -Copyright (c) 1985 - 2022, American Megatrends International LLC.
> >
> > +Copyright (c) 1985 - 2023, American Megatrends International LLC.
> >
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >
> >
> >  **/
> >
> > @@ -1509,7 +1509,7 @@ typedef struct {
> >UINT8AsyncSurpriseRemoval: 1;
> >
> >UINT8FlexbusSlotCxl10Capable : 1;
> >
> >UINT8FlexbusSlotCxl20Capable : 1;
> >
> > -  UINT8Reserved: 1; ///< Set to 0.
> >
> > +  UINT8FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated
> > CXL 3.0 support
> >
> >  } MISC_SLOT_CHARACTERISTICS2;
> >
> >
> >
> >  ///
> >
> > @@ -2012,6 +2012,13 @@ typedef struct {
> >//
> >
> >UINT32 ExtendedSpeed;
> >
> >UINT32
> > ExtendedConfiguredMemorySpeed;
> >
> > +  //
> >
> > +  // Add for smbios 3.7.0
> >
> > +  //
> >
> > +  UINT16
> > Pmic0ManufacturerID;
> >
> > +  UINT16
> > Pmic0RevisionNumber;
> >
> > +  UINT16
> > RcdManufacturerID;
> >
> > +  UINT16
> > RcdRevisionNumber;
> >
> >  } SMBIOS_TABLE_TYPE17;
> >
> >
> >
> >  ///
> >
> > --
> > 2.38.0.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
you
> are
> > on notice that any distribution of this message, in any form, is
strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118418): https://edk2.groups.io/g/devel/message/118418
Mute This Topic: https://groups.io/mt/105816498/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] Changes to print PMIC info in Shell Smbiosview

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Shenbagadevi
> R via groups.io
> 发送时间: 2024年4月23日 20:00
> 收件人: devel@edk2.groups.io; Shenbagadevi R 
> 抄送: gaolim...@byosoft.com.cn; Sainadh Nagolu ;
> Sundaresan S ; Srinivasan Mani
> ; Ramesh R ; Karthika R
> 
> 主题: [edk2-devel] [PATCH] Changes to print PMIC info in Shell
> Smbiosview
> 
> Add changes to print PMIC and RCD details of Smbios Type17 in Shell
> smbiosview command
> 
> Signed-off-by: Shenbagadevi R 
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c  | 7
> +++
>  1 file changed, 7 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 35369f0183..0fbaeb88ae 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -902,6 +902,13 @@ SmbiosPrintStructure (
>  ShellPrintEx (-1, -1, L"Extended Speed: 0x%x\n",
> Struct->Type17->ExtendedSpeed);
> 
>  ShellPrintEx (-1, -1, L"Extended Configured Memory Speed:
> 0x%x\n", Struct->Type17->ExtendedConfiguredMemorySpeed);
> 
>}
> 
> +
> 
> +  if (AE_SMBIOS_VERSION (0x3, 0x7) && (Struct->Hdr->Length > 0x5C))
> {
> 
> +ShellPrintEx (-1, -1, L"PMIC0 Manufacturer ID: 0x%x\n",
> Struct->Type17->Pmic0ManufacturerID);
> 
> +ShellPrintEx (-1, -1, L"PMIC0 Revision Number: 0x%x\n",
> Struct->Type17->Pmic0RevisionNumber);
> 
> +ShellPrintEx (-1, -1, L"RCD Manufacturer ID: 0x%x\n",
> Struct->Type17->RcdManufacturerID);
> 
> +ShellPrintEx (-1, -1, L"RCD Revision Number: 0x%x\n",
> Struct->Type17->RcdRevisionNumber);
> 
> +  }
> 
> 
> 
>break;
> 
> 
> 
> --
> 2.38.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118417): https://edk2.groups.io/g/devel/message/118417
Mute This Topic: https://groups.io/mt/105816495/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Praveen:
  To be compatible, I would suggest to follow new ACPI version definition to 
add new structure for SPCR table version 4, and also need to define version 4 
macro. 
  
  For example, 

#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION_4  0x04

EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_V4

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Praveen
> Sankar N via groups.io
> 发送时间: 2024年4月29日 18:58
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
> 
> 主题: Re: 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> Hi Liming,
>   We are updating the ACPI tables with newer revision released recently
> and SPCR table has its revision 4 upgradation. So, we updated the SPCR table
> to revision 4, tested in our AMI BIOS environment and validated Windows
> Server EMS functionality.
> 
> Thanks,
> Praveen Sankar
> 
> -Original Message-
> From: gaoliming 
> Sent: Monday, April 29, 2024 6:27 AM
> To: devel@edk2.groups.io; Praveen Sankar N 
> Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
> 
> Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject:
> [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Praveen:
>   I want to know what will happen if the platform doesn't make changes with
> the updated table.
> 
>   According to its impact, we can make direction how and when to merge
> this patch.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Praveen
> Sankar N
> > via groups.io
> > 发送时间: 2024年4月26日 12:58
> > 收件人: gaoliming ; devel@edk2.groups.io
> > 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> > ; Srinivasan Mani ; Sundaresan
> S
> > 
> > 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added
> > new SPCR table stucture members as in Rev4.
> >
> > Hi Liming,
> > I am about to resubmit the patch with the changes in the files
> > SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure
> > from SerialPortConsoleRedirectionTable.h file and these files
> > seemingly initializes the SPCR structure members. So please let me
> > know about your opinion on this and I think you mean the incompatible
> > change as these files are affected with the initial patch.
> >
> > Thanks,
> > Praveen Sankar N
> >
> > -Original Message-
> > From: gaoliming 
> > Sent: Tuesday, April 23, 2024 6:47 PM
> > To: Praveen Sankar N ; devel@edk2.groups.io
> > Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> > ; Srinivasan Mani ; Sundaresan
> S
> > 
> > Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added
> > new SPCR table stucture members as in Rev4.
> >
> >
> > **CAUTION: The e-mail below is from an external source. Please
> > exercise caution before opening attachments, clicking links, or
> > following guidance.**
> >
> > Seemly, this is an incompatible change. What's impact with this change?
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 发件人: Praveen Sankar N 
> > > 发送时间: 2024年4月22日 19:26
> > > 收件人: devel@edk2.groups.io
> > > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> > > zhiguang@intel.com; Felix Polyudov ; Srinivasan
> > > Mani ; Sundaresan S 
> > > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > > stucture members as in Rev4.
> > >
> > > In SPCR table, 4 structure members have been added newly as per SPCR
> > > table Rev4, which has to be added in
> > > MdePkg/SerialPortConsoleRedirectionTable.h file.
> > >
> > > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> > > Cc: michael.d.kin...@intel.com
> > > Cc: gaolim...@byosoft.com.cn
> > > Cc: zhiguang@intel.com
> > > Cc: fel...@ami.com
> > > Cc: srinivas...@ami.com
> > > Cc: sundares...@ami.com
> > > ---
> > >  .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6
> +-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > index eb5ae28390..f0001ab137 100644
> > > ---
> > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > +++
> > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > > h
> > > @@ -47,7 +47,11 @@ typedef struct {
> > >UINT8
> > PciFunctionNumber;
> > >
> > >UINT32PciFlags;
> > >
> > >UINT8 PciSegment;
> > >
> > > -  UINT32Reserved3;
> > >
> > > +  UINT32
> > 

[edk2-devel] 回复: [PATCH v6 3/4] MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE

[gaoliming via groups.io]

Sam:
 I would suggest to separate this patch 3/4 to two patches. One is to add UEFI 
definition, another is to add EBBR definition. Do you think so?

Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor 
> 发送时间: 2024年4月29日 21:49
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Michael D Kinney' ; 'Zhiguang Liu'
> 
> 主题: RE: [PATCH v6 3/4] MdePkg: Adding support for
> EFI_CONFORMANCE_PROFILE_TABLE
> 
> Liming,
> 
> Excuse me, I forgot to include the spec for that GUID. It's defined in the
> Embedded Base Boot Requirements (EBBR) specification 2.1.0 release.
> https://arm-software.github.io/ebbr/
> 
> Thanks,
> Sam
> 
> -Original Message-
> From: gaoliming 
> Sent: Sunday, April 28, 2024 8:05 PM
> To: Sam Kaynor ; devel@edk2.groups.io
> Cc: 'Michael D Kinney' ; 'Zhiguang Liu'
> 
> Subject: 回复: [PATCH v6 3/4] MdePkg: Adding support for
> EFI_CONFORMANCE_PROFILE_TABLE
> 
> Sam:
>   I don't find EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID definition in
> UEFI 2.10 spec. So, what's its definition from?
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Sam Kaynor 
> > 发送时间: 2024年4月27日 1:53
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney ; Liming Gao
> > ; Zhiguang Liu 
> > 主题: [PATCH v6 3/4] MdePkg: Adding support for
> > EFI_CONFORMANCE_PROFILE_TABLE
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> >
> > Adding support for EFI_CONFORMANCE_PROFILE_TABLE by adding an
> > associated header file and relevant GUIDs to MdePkg.dec as defined in
> > the UEFI 2.10 spec.
> > This table is needed to address changes being made within ShellPkg.
> >
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Signed-off-by: Sam Kaynor 
> > ---
> >
> > Notes:
> > v6:
> > - Added patch to address MdePkg changes separately
> >
> >  MdePkg/MdePkg.dec |  5 ++
> >  MdePkg/Include/Guid/ConformanceProfiles.h | 56
> 
> >  2 files changed, 61 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> > bf94549cbfbd..2c053a7459f3 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -746,6 +746,11 @@ [Guids]
> >## Include/Guid/DeviceAuthentication.h
> >gEfiDeviceSignatureDatabaseGuid  = { 0xb9c2b4f4, 0xbf5f, 0x462d,
> > {0x8a, 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d, 0xad }}
> >
> > +  ## Include/Guid/ConformanceProfiles.h
> > +  gEfiConfProfilesTableGuid= { 0x36122546, 0xf7e7, 0x4c8f, {
> 0xbd,
> > 0x9b, 0xeb, 0x85, 0x25, 0xb5, 0x0c, 0x0b }}
> > +  gEfiConfProfilesUefiSpecGuid = { 0x523c91af, 0xa195, 0x4382, {
> 0x81,
> > 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }}
> > +  gEfiConfProfilesEbbrSpecGuid = { 0xcce33c35, 0x74ac, 0x4087,
> > { 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }}
> > +
> >#
> ># GUID defined in PI1.0
> >#
> > diff --git a/MdePkg/Include/Guid/ConformanceProfiles.h
> > b/MdePkg/Include/Guid/ConformanceProfiles.h
> > new file mode 100644
> > index ..c6211d63d79c
> > --- /dev/null
> > +++ b/MdePkg/Include/Guid/ConformanceProfiles.h
> > @@ -0,0 +1,56 @@
> > +/** @file
> > +  Legal information
> > +
> > +**/
> > +
> > +#ifndef __CONFORMANCE_PROFILES_TABLE_GUID_H__
> > +#define __CONFORMANCE_PROFILES_TABLE_GUID_H__
> > +
> > +
> > +//
> > +// This table allows the platform to advertise its UEFI specification
> > conformance
> > +// in the form of pre-defined profiles. Each profile is identified by
> > +a
> GUID,
> > with
> > +// known profiles listed in the section below.
> > +// The absence of this table shall indicate that the platform
> implementation
> > is
> > +// conformant with the UEFI specification requirements, as defined in
> > Section 2.6.
> > +// This is equivalent to publishing this configuration table with the
> > +// EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID conformance profile.
> > +//
> > +#define EFI_CONFORMANCE_PROFILES_TABLE_GUID \
> > +  { \
> > +0x36122546, 0xf7e7, 0x4c8f, { 0xbd, 0x9b, 0xeb, 0x85, 0x25, 0xb5,
> 0x0c,
> > 0x0b } \
> > +  }
> > +
> > +#pragma pack(1)
> > +
> > +typedef struct {
> > +  ///
> > +  /// Version of the table must be 0x1
> > +  ///
> > +  UINT16 Version;
> > +  ///
> > +  /// The number of profiles GUIDs present in ConformanceProfiles
> > +  ///
> > +  UINT16 NumberOfProfiles;
> > +  ///
> > +  /// An array of conformance profile GUIDs that are supported by
> > +this
> > system.
> > +  /// EFI_GUIDConformanceProfiles[];
> > +  ///
> > +} EFI_CONFORMANCE_PROFILES_TABLE;
> > +
> > +#define EFI_CONFORMANCE_PROFILES_TABLE_VERSION 0x1
> > +
> > +//
> > +// GUID defined in spec.
> > +//
> > +#define EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID \
> > +{ 0x523c91af, 0xa195, 0x4382, \
> > +{ 0x81, 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }} #define
> > +EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID \
> > +{ 0xcce33c35, 0x74ac, 0x4087, \
> > +{ 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }}
> > +
> > +extern EFI_GUID  gEfiConfProfilesTableGuid; extern EFI_GUID
> > +gEfiConfProfilesUefiSpecGuid;
> > +
> 

[edk2-devel] [PATCH] Added support for ACPI related data structures for RISC_V64 platform

[gaoliming via groups.io]

From: dylanlhdu 

Signed-off-by: Lingheng Du 
Reviewed-by: Song Huang  
Reviewed-by: Bing Fan 
---
 .../Include/IndustryStandard/AcpiRiscv64.h| 176 ++
 1 file changed, 176 insertions(+)
 create mode 100644 edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h

diff --git a/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h 
b/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
new file mode 100644
index ..4111b3ea
--- /dev/null
+++ b/edk2/MdePkg/Include/IndustryStandard/AcpiRiscv64.h
@@ -0,0 +1,176 @@
+/** @file
+  RISCV64 platform ACPI related support April, 2022.
+
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef ACPI_RISCV64_H_
+#define ACPI_RISCV64_H_
+
+//
+// Ensure proper structure formats
+//
+#pragma pack(1)
+
+///
+/// RISC-V Interrupt Type
+///
+#define EFI_ACPI_6_5_INC_RINTC_TYPE  0x18
+#define EFI_ACPI_6_5_INC_IMSIC_TYPE  0x19
+#define EFI_ACPI_6_5_INC_APLIC_TYPE  0x1A
+#define EFI_ACPI_6_5_INC_PLIC_TYPE   0x1B
+
+///
+///  RISC-V Interrupt Controller (RINTC)
+///
+typedef struct {
+  UINT8 Type;
+  UINT8 Length;
+  UINT8 Version;
+  UINT8 Reserved;
+  UINT32Flags;
+  UINT64HartId;
+  UINT32Uid;
+  UINT32ExtIntcId;
+  UINT64ImsicAddr;
+  UINT32ImsicSize;
+} EFI_ACPI_6_5_INC_RINTC_STRUCTURE;
+
+///
+///  Incoming MSI Controller (IMSIC)
+///
+typedef struct {
+  UINT8 Type;
+  UINT8 Length;
+  UINT8 Version;
+  UINT8 Reserved;
+  UINT32Flags;
+  UINT16NumIds;
+  UINT16NumGuestIds;
+  UINT8 GuestIndexBits;
+  UINT8 HartIndexBits;
+  UINT8 GroupIndexBits;
+  UINT8 GroupIndexShift;
+} EFI_ACPI_6_5_INC_IMSIC_STRUCTURE;
+
+///
+///  RISC-V Advanced Platform Level Interrupt Controller (APLIC)
+///
+typedef struct {
+  UINT8 Type;
+  UINT8 Length;
+  UINT8 Version;
+  UINT8 AplicId;
+  UINT32Flags;
+  UINT8 HW_ID[8];
+  UINT16NumIdc;
+  UINT16ExternSoureceSupport;
+  UINT32GSysInterruptBase;
+  UINT64AplicAddress;
+  UINT32AplicSize;
+} EFI_ACPI_6_5_INC_APLIC_STRUCTURE;
+
+///
+///   RISC-V Platform Level Interrupt Controller (PLIC)
+///
+typedef struct {
+  UINT8 Type;
+  UINT8 Length;
+  UINT8 Version;
+  UINT8 PlicId;
+  UINT8 HwId[8];
+  UINT16NumIrqs;
+  UINT16MaxPrio;
+  UINT32Flags;
+  UINT32PlicSize;
+  UINT64PlicAddress;
+  UINT32GsiBase;
+} EFI_ACPI_6_5_INC_PLIC_STRUCTURE;
+
+///
+/// RISC-V Hart Capabilities Table (RHCT)
+///
+typedef struct {
+  EFI_ACPI_DESCRIPTION_HEADERHeader;
+} EFI_ACPI_6_5_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_HEADER;
+
+///
+/// RHCT Revision
+///
+#define EFI_ACPI_6_5_RHCT_APIC_DESCRIPTION_TABLE_REVISION  0x05
+
+///
+/// RHCT types
+///
+#define EFI_ACPI_6_5_NODE_ISA_TYPE   0x0
+#define EFI_ACPI_6_5_NODE_CM0_TYPE   0x1
+#define EFI_ACPI_6_5_NODE_MMU_TYPE   0x2
+#define EFI_ACPI_6_5_NODE_RESERVED_TYPE  0x3
+#define EFI_ACPI_6_5_NODE_HART_TYPE  0x
+
+///
+/// RHCT Flags
+///
+#define ACPI_RHCT_TIMER_CANNOT_WAKEUP_CPU  (1)
+
+///
+/// ISA string node
+///
+typedef struct {
+  UINT16Type;
+  UINT16Length;
+  UINT16Revision;
+  UINT16IsaLength;
+  UINT8 IsaString[];
+} EFI_ACPI_6_5_NODE_ISA_STRING_STRUCTURE;
+
+///
+/// CM0 node
+///
+typedef struct {
+  UINT16Type;
+  UINT16Length;
+  UINT16Revision;
+  UINT8 Reserved;
+  UINT8 CbomSize;
+  UINT8 CbopSize;
+  UINT8 CbozSize;
+} EFI_ACPI_6_5_NODE_CM0_STRUCTURE;
+
+///
+/// MMU node
+///
+typedef struct {
+  UINT16Type;
+  UINT16Length;
+  UINT16Revision;
+  UINT8 Reserved;
+  UINT8 MmuType;
+} EFI_ACPI_6_5_NODE_MMU_STRUCTURE;
+
+///
+/// MMU type
+///
+#define EFI_ACPI_6_5_MMU_SV39_TYPE  0x0
+#define EFI_ACPI_6_5_MMU_SV48_TYPE  0x1
+#define EFI_ACPI_6_5_MMU_SV57_TYPE  0x2
+
+///
+/// Hart Info Node
+///
+typedef struct {
+  UINT16Type;
+  UINT16Length;
+  UINT16Revision;
+  UINT16NumOffsets;
+  UINT32Uid;
+} EFI_ACPI_6_5_NODE_HARTINFO_STRUCTURE;
+
+///
+/// "RHCT" RISC-V Hart Capabilities Table
+///
+#define EFI_ACPI_6_5_RHCT_HART_DESCRIPTION_TABLE_SIGNATURE  SIGNATURE_32('R', 
'H', 'C', 'T')
+
+#pragma pack()
+
+#endif
\ No newline at end of file
-- 
2.34.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118386): https://edk2.groups.io/g/devel/message/118386
Mute This Topic: https://groups.io/mt/105797514/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v6 3/4] MdePkg: Adding support for EFI_CONFORMANCE_PROFILE_TABLE

[gaoliming via groups.io]

Sam:
  I don't find EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID definition in UEFI 2.10
spec. So, what's its definition from?

Thanks
Liming
> -邮件原件-
> 发件人: Sam Kaynor 
> 发送时间: 2024年4月27日 1:53
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu 
> 主题: [PATCH v6 3/4] MdePkg: Adding support for
> EFI_CONFORMANCE_PROFILE_TABLE
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> 
> Adding support for EFI_CONFORMANCE_PROFILE_TABLE by adding an
> associated header file and relevant GUIDs to MdePkg.dec as defined
> in the UEFI 2.10 spec.
> This table is needed to address changes being made within ShellPkg.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Signed-off-by: Sam Kaynor 
> ---
> 
> Notes:
> v6:
> - Added patch to address MdePkg changes separately
> 
>  MdePkg/MdePkg.dec |  5 ++
>  MdePkg/Include/Guid/ConformanceProfiles.h | 56 
>  2 files changed, 61 insertions(+)
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index bf94549cbfbd..2c053a7459f3 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -746,6 +746,11 @@ [Guids]
>## Include/Guid/DeviceAuthentication.h
>gEfiDeviceSignatureDatabaseGuid  = { 0xb9c2b4f4, 0xbf5f, 0x462d, {0x8a,
> 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d, 0xad }}
> 
> +  ## Include/Guid/ConformanceProfiles.h
> +  gEfiConfProfilesTableGuid= { 0x36122546, 0xf7e7, 0x4c8f, {
0xbd,
> 0x9b, 0xeb, 0x85, 0x25, 0xb5, 0x0c, 0x0b }}
> +  gEfiConfProfilesUefiSpecGuid = { 0x523c91af, 0xa195, 0x4382, {
0x81,
> 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }}
> +  gEfiConfProfilesEbbrSpecGuid = { 0xcce33c35, 0x74ac, 0x4087,
> { 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }}
> +
>#
># GUID defined in PI1.0
>#
> diff --git a/MdePkg/Include/Guid/ConformanceProfiles.h
> b/MdePkg/Include/Guid/ConformanceProfiles.h
> new file mode 100644
> index ..c6211d63d79c
> --- /dev/null
> +++ b/MdePkg/Include/Guid/ConformanceProfiles.h
> @@ -0,0 +1,56 @@
> +/** @file
> +  Legal information
> +
> +**/
> +
> +#ifndef __CONFORMANCE_PROFILES_TABLE_GUID_H__
> +#define __CONFORMANCE_PROFILES_TABLE_GUID_H__
> +
> +
> +//
> +// This table allows the platform to advertise its UEFI specification
> conformance
> +// in the form of pre-defined profiles. Each profile is identified by a
GUID,
> with
> +// known profiles listed in the section below.
> +// The absence of this table shall indicate that the platform
implementation
> is
> +// conformant with the UEFI specification requirements, as defined in
> Section 2.6.
> +// This is equivalent to publishing this configuration table with the
> +// EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID conformance profile.
> +//
> +#define EFI_CONFORMANCE_PROFILES_TABLE_GUID \
> +  { \
> +0x36122546, 0xf7e7, 0x4c8f, { 0xbd, 0x9b, 0xeb, 0x85, 0x25, 0xb5,
0x0c,
> 0x0b } \
> +  }
> +
> +#pragma pack(1)
> +
> +typedef struct {
> +  ///
> +  /// Version of the table must be 0x1
> +  ///
> +  UINT16 Version;
> +  ///
> +  /// The number of profiles GUIDs present in ConformanceProfiles
> +  ///
> +  UINT16 NumberOfProfiles;
> +  ///
> +  /// An array of conformance profile GUIDs that are supported by this
> system.
> +  /// EFI_GUIDConformanceProfiles[];
> +  ///
> +} EFI_CONFORMANCE_PROFILES_TABLE;
> +
> +#define EFI_CONFORMANCE_PROFILES_TABLE_VERSION 0x1
> +
> +//
> +// GUID defined in spec.
> +//
> +#define EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID \
> +{ 0x523c91af, 0xa195, 0x4382, \
> +{ 0x81, 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }}
> +#define EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID \
> +{ 0xcce33c35, 0x74ac, 0x4087, \
> +{ 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }}
> +
> +extern EFI_GUID  gEfiConfProfilesTableGuid;
> +extern EFI_GUID  gEfiConfProfilesUefiSpecGuid;
> +
> +#endif
> --
> 2.34.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118360): https://edk2.groups.io/g/devel/message/118360
Mute This Topic: https://groups.io/mt/105793166/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Praveen:
  I want to know what will happen if the platform doesn't make changes with the 
updated table. 

  According to its impact, we can make direction how and when to merge this 
patch. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Praveen
> Sankar N via groups.io
> 发送时间: 2024年4月26日 12:58
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
> 
> 主题: Re: [edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH]
> MdePkg:Added new SPCR table stucture members as in Rev4.
> 
> Hi Liming,
> I am about to resubmit the patch with the changes in the files
> SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure from
> SerialPortConsoleRedirectionTable.h file and these files seemingly initializes
> the SPCR structure members. So please let me know about your opinion on
> this and I think you mean the incompatible change as these files are affected
> with the initial patch.
> 
> Thanks,
> Praveen Sankar N
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, April 23, 2024 6:47 PM
> To: Praveen Sankar N ; devel@edk2.groups.io
> Cc: michael.d.kin...@intel.com; zhiguang@intel.com; Felix Polyudov
> ; Srinivasan Mani ; Sundaresan S
> 
> Subject: [EXTERNAL] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added
> new SPCR table stucture members as in Rev4.
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Seemly, this is an incompatible change. What's impact with this change?
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Praveen Sankar N 
> > 发送时间: 2024年4月22日 19:26
> > 收件人: devel@edk2.groups.io
> > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> > zhiguang@intel.com; Felix Polyudov ; Srinivasan
> > Mani ; Sundaresan S 
> > 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> > stucture members as in Rev4.
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Rev4, which has to be added in
> > MdePkg/SerialPortConsoleRedirectionTable.h file.
> >
> > Signed-off-by: Praveen Sankar N praveensank...@ami.com
> > Cc: michael.d.kin...@intel.com
> > Cc: gaolim...@byosoft.com.cn
> > Cc: zhiguang@intel.com
> > Cc: fel...@ami.com
> > Cc: srinivas...@ami.com
> > Cc: sundares...@ami.com
> > ---
> >  .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index eb5ae28390..f0001ab137 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -47,7 +47,11 @@ typedef struct {
> >UINT8
> PciFunctionNumber;
> >
> >UINT32PciFlags;
> >
> >UINT8 PciSegment;
> >
> > -  UINT32Reserved3;
> >
> > +  UINT32
> UartClockFrequency;
> >
> > +  UINT32PreciseBaudRate;
> >
> > +  UINT16
> > NameSpaceStrLength;
> >
> > +  UINT16
> > NameSpaceStrOffset;
> >
> > +  CHAR8
> > NameSpaceString[0];
> >
> >  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> >  #pragma pack()
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
> > you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply e-mail
> > or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118359): https://edk2.groups.io/g/devel/message/118359
Mute This Topic: https://groups.io/mt/105793070/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub 

回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard

[gaoliming via groups.io]

Foster:
  There is CI failure in https://github.com/tianocore/edk2/pull/5585. Please 
resolve them first.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 gaoliming via
> groups.io
> 发送时间: 2024年4月23日 21:15
> 收件人: 'Nong, Foster' ; devel@edk2.groups.io;
> 'Kinney, Michael D' ; 'Chris Li'
> 
> 抄送: 'Ni, Ray' 
> 主题: 回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> IndustryStandard
> 
> Seemly, there is no other comments. I create PR
> https://github.com/tianocore/edk2/pull/5585 to merge it.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Nong, Foster 
> > 发送时间: 2024年4月23日 18:07
> > 收件人: gaoliming ; devel@edk2.groups.io;
> > Kinney, Michael D ; 'Chris Li'
> > 
> > 抄送: Ni, Ray 
> > 主题: RE: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> > IndustryStandard
> >
> > Hi Liming,
> >
> > What is the patch review status? Can this patch be merged?
> >
> > -Original Message-
> > From: Nong, Foster
> > Sent: Wednesday, December 27, 2023 2:05 PM
> > To: gaoliming ; devel@edk2.groups.io; Kinney,
> > Michael D ; 'Chris Li'
> > 
> > Cc: Ni, Ray 
> > Subject: RE: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> > IndustryStandard
> >
> > Thanks Liming!
> > @'Chris Li' and @Kinney, Michael D, please help comment the patch.
> Thanks!
> >
> > -Original Message-
> > From: gaoliming 
> > Sent: Tuesday, December 19, 2023 9:05 PM
> > To: devel@edk2.groups.io; Nong, Foster ; Kinney,
> > Michael D ; 'Chris Li'
> > 
> > Cc: Ni, Ray 
> > Subject: 回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> > IndustryStandard
> >
> > Foster:
> >   I have no comments for this patch. Acked-by: Liming Gao
> > 
> >
> > Thanks
> > Liming
> > > -邮件原件-
> > > 发件人: devel@edk2.groups.io  代表 Nong,
> > Foster
> > > 发送时间: 2023年12月19日 18:17
> > > 收件人: devel@edk2.groups.io; Kinney, Michael D
> > > ; Gao, Liming
> ;
> > > Chris Li 
> > > 抄送: Ni, Ray 
> > > 主题: Re: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> > > IndustryStandard
> > >
> > > @Gao, Liming @Chris Li @Kinney, Michael D,
> > >
> > > Don't forget reviewing the patch. Thanks!
> > >
> > > -Original Message-
> > > From: Nong, Foster 
> > > Sent: Wednesday, November 29, 2023 2:57 PM
> > > To: devel@edk2.groups.io
> > > Cc: Nong, Foster ; Kinney, Michael D
> > > ; Gao, Liming
> ;
> > > Ni, Ray ; Chris Li 
> > > Subject: [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4516
> > >
> > > 1) Add CXL 3.0 header file to comply with CXL 3.0 specification
> > > 2) CXL 3.0 header will embed Cxl20.h
> > > 3) Updated Cxl.h to point to 3.0 header file
> > >
> > > Signed-off-by: Foster Nong 
> > > Cc: Michael D Kinney 
> > > Cc: Liming Gao 
> > > Cc: Ray Ni 
> > > Cc: Chris Li 
> > > ---
> > >  MdePkg/Include/IndustryStandard/Cxl.h   |   2 +-
> > >  MdePkg/Include/IndustryStandard/Cxl30.h | 315
> > 
> > >  2 files changed, 316 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/Cxl.h
> > > b/MdePkg/Include/IndustryStandard/Cxl.h
> > > index 9ad3242e25..cb623a355d 100755
> > > --- a/MdePkg/Include/IndustryStandard/Cxl.h
> > > +++ b/MdePkg/Include/IndustryStandard/Cxl.h
> > > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #ifndef
> > > _CXL_MAIN_H_ #define _CXL_MAIN_H_ -#include
> > > +#include  // //
> > > CXL assigned new Vendor ID //diff --git
> > > a/MdePkg/Include/IndustryStandard/Cxl30.h
> > > b/MdePkg/Include/IndustryStandard/Cxl30.h
> > > new file mode 100644
> > > index 00..feb6b9c52f
> > > --- /dev/null
> > > +++ b/MdePkg/Include/IndustryStandard/Cxl30.h
> > > @@ -0,0 +1,315 @@
> > > +/** @file+  CXL 3.0 Register definitions++  This file contains the
> > register
> > > definitions based on the Compute Express Link+  (CXL) Specification
> > Revision
> > > 3.0.++  Copyright (c) 2023, Intel Corporation. All rights
> > > reserved.++
> > > SPDX-License-Identifier: BSD-2-Clause-Patent++**/+#ifndef
> > > CXL30_H_+#define CXL30_H_++#include
> > ++//+//
> > > CXL Cache Memory Capability IDs+// Compute Express Link Specif

[edk2-devel] 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Felix and Sachin:
  I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest 
public PI 1.8A. So, this change may not be added now. 

Thanks
Liming
> -邮件原件-
> 发件人: Sachin Ganesh 
> 发送时间: 2024年4月25日 17:57
> 收件人: Felix Polyudov ; gaoliming
> ; devel@edk2.groups.io
> 抄送: zhiguang@intel.com; michael.d.kin...@intel.com;
> ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com;
> Dhanaraj V 
> 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> Hi Felix/ Liming,
> 
> Thank you for your comments. Patch 6 has been updated to only focus on
> consolidating the revision macros.
> 
> Patch Link:
> https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2
> C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%
> 2C105721897
> PR Link: https://github.com/tianocore/edk2/pull/5569
> 
> Thank you,
> Sachin.
> 
> -Original Message-
> From: Felix Polyudov 
> Sent: Tuesday, April 23, 2024 10:58 PM
> To: gaoliming ; Sachin Ganesh
> ; devel@edk2.groups.io
> Cc: zhiguang@intel.com; michael.d.kin...@intel.com;
> ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com;
> Dhanaraj V 
> Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> I think patch 6 can be updated to introduce unified PI specification 
> versioning
> macros without incrementing the minor revision, by changing
> PI_SPECIFICATION_MINOR_REVISION back to 70.
> This will ensure compliance with the versioning schema introduced in PI 1.7B
> without changing the PI support level.
> (the macros were introduced by PIWG mantis 2101)
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, April 23, 2024 10:49 AM
> To: Sachin Ganesh ; devel@edk2.groups.io
> Cc: zhiguang@intel.com; michael.d.kin...@intel.com;
> ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen@intel.com;
> erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com;
> Felix Polyudov ; Dhanaraj V 
> Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10
> and PI 1.8 Specification
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
> 
> 
> I suggest to merge others first. The patch 6/7 to update PI version from 1.7 
> to
> 1.8 can be discussed first.
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Sachin Ganesh 
> > 发送时间: 2024年4月20日 5:46
> > 收件人: devel@edk2.groups.io
> > 抄送: gaolim...@byosoft.com.cn; zhiguang@intel.com;
> > michael.d.kin...@intel.com; ardb+tianoc...@kernel.org;
> > kra...@redhat.com; jiewen@intel.com; erdemak...@google.com;
> > min.m...@intel.com; thomas.lenda...@amd.com; Felix Polyudov
> > ; Dhanaraj V ; Sachin Ganesh
> > 
> > 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> > Specification
> >
> > This series of patches are for general updates to MdePkg and
> > MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
> >
> > Sachin Ganesh (7):
> >   MdePkg: Add definition for NVMe Over Fabric Device Path
> >   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
> >   MdePkg: Define Unaccepted Memory Type
> >   MdeModulePkg: Use newly defined Unaccepted Memory Type
> >   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
> >   MdePkg: Update to PI 1.8 Revision
> >   OvmfPkg: Use newly defined Unaccepted Memory Type
> >
> >  MdeModulePkg/Core/Dxe/Gcd/Gcd.c  | 10 +++---
> >  MdeModulePkg/Core/Dxe/Mem/Page.c | 38
> > ++--
> >  MdeModulePkg/Include/Pi/PrePiDxeCis.h| 25 -
> >  MdeModulePkg/Include/Pi/PrePiHob.h   | 20 ---
> >  MdePkg/Include/Pi/PiDxeCis.h | 19 +-
> >  MdePkg/Include/Pi/PiHob.h| 14 +++-
> >  MdePkg/Include/Pi/PiMmCis.h  |  6 ++--
> >  MdePkg/Include/Pi/PiMultiPhase.h |  6 
> >  MdePkg/Include/Pi/PiPeiCis.h |  6 ++--
> >  MdePkg/Include/Pi/PiSmmCis.h |  2 +-
> >  MdePkg/Include/Ppi/DelayedDispatch.h | 24 -
> >  MdePkg/Include/Protocol/DevicePath.h | 22 
> >  OvmfPkg/AmdSevDxe/AmdSevDxe.c|  4 +--
> >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
> >  OvmfPkg/Library/PeilessStartupLib/Hob.c  |  4 +--
> >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
> >  OvmfPkg/PlatformPei/AmdSev.c |  4 +--
> >  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> > 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
> >  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> >
> > --
> > 2.24.1.windows.2
> > -The information contained 

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

Can you create PR for this patch? If it passes CI, I will add push label. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Xianglei Cai
> 发送时间: 2024年4月25日 17:58
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Ni, Ray ; Lewandowski, Krzysztof
> ; Huang, Jenny ;
> Shih, More 
> 主题: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
> 
> Hi @gaoliming
> 
> Could you provide the eta when the patch can be merged?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: Cai, Xianglei
> Sent: Thursday, April 18, 2024 4:59 PM
> To: gaoliming ; devel@edk2.groups.io
> Cc: Ni, Ray ; Lewandowski, Krzysztof
> ; Huang, Jenny ;
> Shih, More 
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
> 
> Hi Liming,
> 
> Could you help pick the change to the master branch?
> 
> Thanks,
> Xianglei
> 
> -Original Message-
> From: gaoliming 
> Sent: Monday, April 15, 2024 5:52 PM
> To: devel@edk2.groups.io; Cai, Xianglei 
> Cc: Ni, Ray ; Lewandowski, Krzysztof
> ; Huang, Jenny ;
> Shih, More 
> Subject: 回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint while USB Transaction error
> 
> Reviewed-by: Liming Gao 
> 
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Xianglei
> Cai
> > 发送时间: 2024年4月15日 14:55
> > 收件人: devel@edk2.groups.io
> > 抄送: Xianglei Cai ; Ray Ni ;
> > Liming Gao ; Krzysztof Lewandowski
> > ; Jenny Huang
> > ; More Shih 
> > 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset
> endpoint
> > while USB Transaction error
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4556
> >
> > Based on XHCI spec 4.8.3, software should do the reset endpoint while
> > USB Transaction occur.
> > Add the error code for USB Transaction error since UEFI spec don't
> > have the related definition.
> >
> > Cc: Ray Ni  
> > Cc: Liming Gao  
> > Cc: Krzysztof Lewandowski   
> > Cc: Jenny Huang 
> > Cc: More Shih   
> > Signed-off-by: Xianglei Cai 
> > Reviewed-by: Krzysztof Lewandowski 
> > ---
> >  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  | 5 -
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 -
> > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++
> >  3 files changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > index f4e61d223c1b..cf6b32959e68 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> > @@ -825,7 +825,10 @@ XhcTransfer (
> >*TransferResult = Urb->Result;
> >*DataLength = Urb->Completed;
> >
> > -  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
> > EFI_USB_ERR_BABBLE)) {
> > +  //
> > +  // Based on XHCI spec 4.8.3, software should do the reset endpoint
> while
> > USB Transaction occur.
> > +  //
> > +  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
> > EFI_USB_ERR_BABBLE) || (*TransferResult ==
> > EDKII_USB_ERR_TRANSACTION)) {
> >  ASSERT (Status == EFI_DEVICE_ERROR);
> >  RecoveryStatus = XhcRecoverHaltedEndpoint (Xhc, Urb);
> >  if (EFI_ERROR (RecoveryStatus)) { diff --git
> > a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > index 5d735008ba31..a97ed44dbfc3 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > @@ -1192,8 +1192,11 @@ XhcCheckUrbResult (
> >  DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: ERR_BUFFER!
> > Completecode = %x\n", EvtTrb->Completecode));
> >  goto EXIT;
> >
> > +  //
> > +  // Based on XHCI spec 4.8.3, software should do the reset
> > + endpoint
> > while USB Transaction occur.
> > +  //
> >case TRB_COMPLETION_USB_TRANSACTION_ERROR:
> > -CheckedUrb->Result  |= EFI_USB_ERR_TIMEOUT;
> > +CheckedUrb->Result  |= EDKII_USB_ERR_TRANSACTION;
> >  CheckedUrb->Finished = TRUE;
> >  DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult:
> > TRANSACTION_ERROR! Completecode = %x\n", EvtTrb->Completecode));
> >  goto EXIT;
> > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > index 7c85f7993b5c..e606e212a1d3 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> > @@ -78,6 +78,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >  #define TRB_COMPLETION_STOPPED 26
> >  #define TRB_COMPLETION_STOPPED_LENGTH_INVALID  27
> >
> > +//
> > +// USB Transfer Results Internal Definition // Based on XHCI spec
> > +4.8.3, software should do the reset endpoint while
> > USB Transaction occur.
> > +// Add the error code for USB Transaction error since UEFI spec don't
> have
> > the related definition.
> > +//
> > +#define EDKII_USB_ERR_TRANSACTION  0x200
> > +
> >  //
> >  // The topology string used to 

[edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao


I suggest to merge others first. The patch 6/7 to update PI version from 1.7
to 1.8 can be discussed first. 

Thanks
Liming
> -邮件原件-
> 发件人: Sachin Ganesh 
> 发送时间: 2024年4月20日 5:46
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; zhiguang@intel.com;
> michael.d.kin...@intel.com; ardb+tianoc...@kernel.org;
> kra...@redhat.com; jiewen@intel.com; erdemak...@google.com;
> min.m...@intel.com; thomas.lenda...@amd.com; Felix Polyudov
> ; Dhanaraj V ; Sachin Ganesh
> 
> 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> Specification
> 
> This series of patches are for general updates to MdePkg and MdeModulePkg
> based on
> UEFI 2.10 and PI 1.8 Specifications
> 
> Sachin Ganesh (7):
>   MdePkg: Add definition for NVMe Over Fabric Device Path
>   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
>   MdePkg: Define Unaccepted Memory Type
>   MdeModulePkg: Use newly defined Unaccepted Memory Type
>   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
>   MdePkg: Update to PI 1.8 Revision
>   OvmfPkg: Use newly defined Unaccepted Memory Type
> 
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c  | 10 +++---
>  MdeModulePkg/Core/Dxe/Mem/Page.c | 38
> ++--
>  MdeModulePkg/Include/Pi/PrePiDxeCis.h| 25 -
>  MdeModulePkg/Include/Pi/PrePiHob.h   | 20 ---
>  MdePkg/Include/Pi/PiDxeCis.h | 19 +-
>  MdePkg/Include/Pi/PiHob.h| 14 +++-
>  MdePkg/Include/Pi/PiMmCis.h  |  6 ++--
>  MdePkg/Include/Pi/PiMultiPhase.h |  6 
>  MdePkg/Include/Pi/PiPeiCis.h |  6 ++--
>  MdePkg/Include/Pi/PiSmmCis.h |  2 +-
>  MdePkg/Include/Ppi/DelayedDispatch.h | 24 -
>  MdePkg/Include/Protocol/DevicePath.h | 22 
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c|  4 +--
>  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
>  OvmfPkg/Library/PeilessStartupLib/Hob.c  |  4 +--
>  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
>  OvmfPkg/PlatformPei/AmdSev.c |  4 +--
>  17 files changed, 108 insertions(+), 112 deletions(-)
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118147): https://edk2.groups.io/g/devel/message/118147
Mute This Topic: https://groups.io/mt/105690795/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Fmmt.py: Python 3.12 support

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Guo, Gua
> 发送时间: 2024年4月22日 9:50
> 收件人: devel@edk2.groups.io
> 抄送: gua@intel.com; Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
> 
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/Fmmt.py: Python 3.12 support
> 
> From: Gua Guo 
> 
> Ref to https://docs.python.org/3/whatsnew/3.12.html
> A backslash-character pair that is not a valid
> escape sequence now generates
> 
> Cc: Rebecca Cran 
> Cc: Liming Gao 
> Cc: Bob Feng 
> Cc: Yuwei Chen 
> Signed-off-by: Gua Guo 
> ---
>  BaseTools/Source/Python/FMMT/FMMT.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/FMMT/FMMT.py
> b/BaseTools/Source/Python/FMMT/FMMT.py
> index 26fc4c5792..7505b6c88a 100644
> --- a/BaseTools/Source/Python/FMMT/FMMT.py
> +++ b/BaseTools/Source/Python/FMMT/FMMT.py
> @@ -37,7 +37,7 @@ parser.add_argument("-l", "--LayoutFileName",
> dest="LayoutFileName", nargs='+',
>  the file will be generated with default name
> (Layout_'InputFileName'.txt). \
> 
>  Currently supports two formats: json, txt.
> More formats will be added in the future")
> 
>  parser.add_argument("-c", "--ConfigFilePath", dest="ConfigFilePath",
> nargs='+',
> 
> -help="Provide the target FmmtConf.ini file path: '-c
> C:\Code\FmmtConf.ini' \
> 
> +help="Provide the target FmmtConf.ini file path: '-c
> C:\\Code\\FmmtConf.ini' \
> 
>  FmmtConf file saves the target guidtool used
> in compress/uncompress process.\
> 
>  If do not provide, FMMT tool will search the
> inputfile folder for FmmtConf.ini firstly, if not found,\
> 
>  the FmmtConf.ini saved in FMMT tool's folder
> will be used as default.")
> 
> --
> 2.39.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#118064):
> https://edk2.groups.io/g/devel/message/118064
> Mute This Topic: https://groups.io/mt/105662555/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118146): https://edk2.groups.io/g/devel/message/118146
Mute This Topic: https://groups.io/mt/105690664/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateTime.py: Python 3.12 support

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Guo, Gua
> 发送时间: 2024年4月21日 20:51
> 收件人: devel@edk2.groups.io
> 抄送: gua@intel.com; saloni.kasbe...@intel.com; Rebecca Cran
> ; Liming Gao ; Bob Feng
> ; Yuwei Chen 
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/GetUtcDateTime.py: Python
> 3.12 support
> 
> From: Gua Guo 
> 
> Ref to https://docs.python.org/3/whatsnew/3.12.html
> utcnow() and utcfromtimestamp() are deprecated
> Prevent use it cause build error.
> 
> Cc: Rebecca Cran 
> Cc: Liming Gao 
> Cc: Bob Feng 
> Cc: Yuwei Chen 
> Signed-off-by: Gua Guo 
> ---
>  BaseTools/Scripts/GetUtcDateTime.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Scripts/GetUtcDateTime.py
> b/BaseTools/Scripts/GetUtcDateTime.py
> index 3cfb6ac2ae..6764fb22a7 100644
> --- a/BaseTools/Scripts/GetUtcDateTime.py
> +++ b/BaseTools/Scripts/GetUtcDateTime.py
> @@ -29,7 +29,7 @@ def Main():
>  print ("ERROR: At least one argument is required!\n")
> 
>  PARSER.print_help()
> 
> 
> 
> -today = datetime.datetime.utcnow()
> 
> +today = datetime.datetime.now(datetime.UTC)
> 
>  if ARGS.year:
> 
>  ReversedNumber = str(today.year)[::-1]
> 
>  print (''.join(hex(ord(HexString))[2:] for HexString in
> ReversedNumber))
> 
> --
> 2.39.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#118054):
> https://edk2.groups.io/g/devel/message/118054
> Mute This Topic: https://groups.io/mt/105650842/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118145): https://edk2.groups.io/g/devel/message/118145
Mute This Topic: https://groups.io/mt/105690657/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4.

[gaoliming via groups.io]

Seemly, this is an incompatible change. What's impact with this change?

Thanks
Liming
> -邮件原件-
> 发件人: Praveen Sankar N 
> 发送时间: 2024年4月22日 19:26
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com; Felix Polyudov ; Srinivasan Mani
> ; Sundaresan S 
> 主题: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new SPCR table
> stucture members as in Rev4.
> 
> In SPCR table, 4 structure members have been added newly as per
> SPCR table Rev4, which has to be added in
> MdePkg/SerialPortConsoleRedirectionTable.h file.
> 
> Signed-off-by: Praveen Sankar N praveensank...@ami.com
> Cc: michael.d.kin...@intel.com
> Cc: gaolim...@byosoft.com.cn
> Cc: zhiguang@intel.com
> Cc: fel...@ami.com
> Cc: srinivas...@ami.com
> Cc: sundares...@ami.com
> ---
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h| 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..f0001ab137 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -47,7 +47,11 @@ typedef struct {
>UINT8 PciFunctionNumber;
> 
>UINT32PciFlags;
> 
>UINT8 PciSegment;
> 
> -  UINT32Reserved3;
> 
> +  UINT32UartClockFrequency;
> 
> +  UINT32PreciseBaudRate;
> 
> +  UINT16
> NameSpaceStrLength;
> 
> +  UINT16
> NameSpaceStrOffset;
> 
> +  CHAR8
> NameSpaceString[0];
> 
>  } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> 
> 
> 
>  #pragma pack()
> 
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118140): https://edk2.groups.io/g/devel/message/118140
Mute This Topic: https://groups.io/mt/105689097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard

[gaoliming via groups.io]

Seemly, there is no other comments. I create PR 
https://github.com/tianocore/edk2/pull/5585 to merge it. 

Thanks
Liming
> -邮件原件-
> 发件人: Nong, Foster 
> 发送时间: 2024年4月23日 18:07
> 收件人: gaoliming ; devel@edk2.groups.io;
> Kinney, Michael D ; 'Chris Li'
> 
> 抄送: Ni, Ray 
> 主题: RE: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> IndustryStandard
> 
> Hi Liming,
> 
> What is the patch review status? Can this patch be merged?
> 
> -Original Message-
> From: Nong, Foster
> Sent: Wednesday, December 27, 2023 2:05 PM
> To: gaoliming ; devel@edk2.groups.io; Kinney,
> Michael D ; 'Chris Li'
> 
> Cc: Ni, Ray 
> Subject: RE: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> IndustryStandard
> 
> Thanks Liming!
> @'Chris Li' and @Kinney, Michael D, please help comment the patch. Thanks!
> 
> -Original Message-
> From: gaoliming 
> Sent: Tuesday, December 19, 2023 9:05 PM
> To: devel@edk2.groups.io; Nong, Foster ; Kinney,
> Michael D ; 'Chris Li'
> 
> Cc: Ni, Ray 
> Subject: 回复: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> IndustryStandard
> 
> Foster:
>   I have no comments for this patch. Acked-by: Liming Gao
> 
> 
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Nong,
> Foster
> > 发送时间: 2023年12月19日 18:17
> > 收件人: devel@edk2.groups.io; Kinney, Michael D
> > ; Gao, Liming ;
> > Chris Li 
> > 抄送: Ni, Ray 
> > 主题: Re: [edk2-devel] [PATCH v1] MdePkg: Add Cxl30.h into
> > IndustryStandard
> >
> > @Gao, Liming @Chris Li @Kinney, Michael D,
> >
> > Don't forget reviewing the patch. Thanks!
> >
> > -Original Message-
> > From: Nong, Foster 
> > Sent: Wednesday, November 29, 2023 2:57 PM
> > To: devel@edk2.groups.io
> > Cc: Nong, Foster ; Kinney, Michael D
> > ; Gao, Liming ;
> > Ni, Ray ; Chris Li 
> > Subject: [PATCH v1] MdePkg: Add Cxl30.h into IndustryStandard
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4516
> >
> > 1) Add CXL 3.0 header file to comply with CXL 3.0 specification
> > 2) CXL 3.0 header will embed Cxl20.h
> > 3) Updated Cxl.h to point to 3.0 header file
> >
> > Signed-off-by: Foster Nong 
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Ray Ni 
> > Cc: Chris Li 
> > ---
> >  MdePkg/Include/IndustryStandard/Cxl.h   |   2 +-
> >  MdePkg/Include/IndustryStandard/Cxl30.h | 315
> 
> >  2 files changed, 316 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Cxl.h
> > b/MdePkg/Include/IndustryStandard/Cxl.h
> > index 9ad3242e25..cb623a355d 100755
> > --- a/MdePkg/Include/IndustryStandard/Cxl.h
> > +++ b/MdePkg/Include/IndustryStandard/Cxl.h
> > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #ifndef
> > _CXL_MAIN_H_ #define _CXL_MAIN_H_ -#include
> > +#include  // //
> > CXL assigned new Vendor ID //diff --git
> > a/MdePkg/Include/IndustryStandard/Cxl30.h
> > b/MdePkg/Include/IndustryStandard/Cxl30.h
> > new file mode 100644
> > index 00..feb6b9c52f
> > --- /dev/null
> > +++ b/MdePkg/Include/IndustryStandard/Cxl30.h
> > @@ -0,0 +1,315 @@
> > +/** @file+  CXL 3.0 Register definitions++  This file contains the
> register
> > definitions based on the Compute Express Link+  (CXL) Specification
> Revision
> > 3.0.++  Copyright (c) 2023, Intel Corporation. All rights
> > reserved.++
> > SPDX-License-Identifier: BSD-2-Clause-Patent++**/+#ifndef
> > CXL30_H_+#define CXL30_H_++#include
> ++//+//
> > CXL Cache Memory Capability IDs+// Compute Express Link Specification
> > Revision 3.0 - Chapter 8.2.4 Table 8-22+//+#define
> > CXL_CACHE_MEM_CAPABILITY_ID_TIMEOUT_AND_ISOLATION
> > 0x0009+#define CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED
> > 0x000A+#define CXL_CACHE_MEM_CAPABILITY_ID_BI_ROUTE_TABLE
> > 0x000B+#define CXL_CACHE_MEM_CAPABILITY_ID_BI_DECODER
> > 0x000C+#define
> > CXL_CACHE_MEM_CAPABILITY_ID_CACHE_ID_ROUTE_TABLE
> > 0x000D+#define CXL_CACHE_MEM_CAPABILITY_ID_CACHE_ID_DECODER
> > 0x000E+#define
> > CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED_HDM_DECODER
> > 0x000F++//+// CXL_Capability_Version+// Compute Express ink
> > 0x000F++Specification
> > Revision 3.0 - Chapter 8.2.4.5+//+#define
> CXL_HDM_DECODER_VERSION_30
> > 0x3++//+// CXL CXL HDM Decoder n Control+// Compute Express Link
> > Specification Revision 3.0 - 8.2.4.19.7+//+//+// Bit4..7: Interleave
> > Ways (IW)+//+#define CXL_HDM_16_WAY_INTERLEAVING
> > 0x4+#define CXL_HDM_3_WAY_INTERLEAVING
> > 0x8+#define CXL_HDM_6_WAY_INTERLEAVING
> > 0x9+#define CXL_HDM_12_WAY_INTERLEAVING
> > 0xA++//+// Ensure proper structure formats+//+#pragma pack(1)++//+//
> > CXL.cachemem Extended Register Capability+// Compute Express Link
> > Specification Revision 3.0  - Chapter 8.2.4.24+//+typedef union {+
> > struct
> {+
> > UINT32ExtendedRangesBitmap : 16;  // Bit 0..15+UINT32
> > Reserved : 16;  // Bit 16..31+  } Bits;+  UINT32
> > Uint32;+} CXL_CM_EXTENTED_REGISTER_CAPABILITY;++#define
> > CXL_CM_EXTENTED_RANGES_BITMAP(BIT2 | BIT3 | BIT4 | BIT5 |
> BIT6
> > | BIT7 | BIT8 | BIT9 | BIT10 | BIT11 | BIT12 

回复: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while parsing FMMTConfig.ini

[gaoliming via groups.io]

Ashraf:
  I just merge it. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Ashraf Ali S
> 发送时间: 2024年4月17日 16:36
> 收件人: devel@edk2.groups.io; S, Ashraf Ali ;
Chen,
> Christine ; Rebecca Cran ;
> Liming Gao 
> 抄送: Feng, Bob C ; Chaganty, Rangasai V
> 
> 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while
> parsing FMMTConfig.ini
> 
> Hi @Liming Gao @Rebecca Cran
> 
> Is this patch already pushed? As its been already reviewed.
> 
> Thanks.,
> S, Ashraf Ali
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Ashraf Ali
> S
> Sent: Monday, March 11, 2024 5:01 PM
> To: devel@edk2.groups.io; Chen, Christine 
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ;
> Chaganty, Rangasai V 
> Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while
> parsing FMMTConfig.ini
> 
> Thanks for the review.
> 
> I have triggered the PR under basetools :
> https://github.com/tianocore/edk2-basetools/pull/122
> 
> Thanks.,
> S, Ashraf Ali
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Yuwei
> Chen
> Sent: Monday, March 11, 2024 1:22 PM
> To: S, Ashraf Ali ; devel@edk2.groups.io
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ;
> Chaganty, Rangasai V 
> Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while
> parsing FMMTConfig.ini
> 
> Ali, please also create PR in BaseTools repo.
> Reviewed-by: Yuwei Chen 
> 
> > -Original Message-
> > From: S, Ashraf Ali 
> > Sent: Wednesday, February 28, 2024 5:57 PM
> > To: devel@edk2.groups.io
> > Cc: S, Ashraf Ali ; Rebecca Cran
> > ; Liming Gao ; Feng,
> Bob
> > C ; Chen, Christine ;
> > Chaganty, Rangasai V 
> > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing
> > FMMTConfig.ini
> >
> > When the FMMTConf.ini file has empty lines then it used to throw
> > errors GuidTool load error!, this patch is to skip checking for empty
> > lines in the ini file
> >
> > Cc: Rebecca Cran 
> > Cc: Liming Gao 
> > Cc: Bob Feng 
> > Cc: Yuwei Chen 
> > Cc: Chen Christine 
> > Cc: Chaganty Rangasai V 
> >
> > Signed-off-by: Ashraf Ali 
> > ---
> >  BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > index f6bdeffa50..f9cfd4ead0 100644
> > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> > @@ -153,7 +153,7 @@ class GUIDTools:
> >  config_data = fd.readlines()
> >  for line in config_data:
> >  try:
> > -if not line.startswith("#"):
> > +if not line.startswith("#") and line.strip():
> >  guid, short_name, command = line.split()
> >  new_format_guid =
> > struct2stream(ModifyGuidFormat(guid.strip()))
> >  self.tooldef[new_format_guid] = GUIDTool(
> > --
> > 2.42.0.windows.2
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117918): https://edk2.groups.io/g/devel/message/117918
Mute This Topic: https://groups.io/mt/105575993/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH 1/1] BaseTool/Ecc: Fix incorrect parsing of variable initialisation

[gaoliming via groups.io]

Sami:
  I have no comments for this change. Acked-by: Liming Gao 


Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Sami
> Mujawar
> 发送时间: 2024年4月16日 11:51
> 收件人: devel@edk2.groups.io; rebe...@bsdio.com;
> gaolim...@byosoft.com.cn; bob.c.f...@intel.com; yuwei.c...@intel.com
> 抄送: Yeo Reum Yun ; Pierre Gondois
> ; nd 
> 主题: Re: [edk2-devel] [PATCH 1/1] BaseTool/Ecc: Fix incorrect parsing of
> variable initialisation
> 
> Dear Maintainers,
> 
> This patch fixes an ECC tool issue that is preventing the Arm CCA patch series
> from passing the edk2-CI tests, see
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=122726
> w=logs=ec42d809-3c3b-54a9-276c-e54a8b9aaee9=bd91c6c3-6d75-5ed
> e-7b63-5767cf827334=74
> 
> Regards,
> 
> Sami Mujawar
> 
> On 16/04/2024, 00:30, "devel@edk2.groups.io 
> on behalf of levi.yun via groups.io"   on behalf of
> yeoreum.yun=arm@groups.io > wrote:
> 
> 
> If a global variable is initialised using a macro with multiple
> arguments, ECC incorrectly parses the statement and reports the
> macro arguments as variable declarations.
> 
> 
> Example: In the following statement:
> STATIC INT WrongVariable = MACRO_VERSION(1, 0), NextVariable;
> The logic in the ECC function GetIdentifierList() interprets the
> above statement as declaration of three variables:
> 1. 'WrongVariable = MACRO_VERSION(1,'
> 2. '0)'
> 3. 'NextVariable'
> Following which NamingConventionCheckVariableName() reports an
> error for "0)" stating an incorrect variable declaration as
> below:
> "ERROR - *The variable name [0)] does not follow the rules"
> 
> 
> This patch fixes the parsing logic so that scenarios with macro
> initialisations are handled correctly.
> 
> 
> Cc: Rebecca Cran mailto:rebe...@bsdio.com>>
> Cc: Liming Gao  >
> Cc: Bob Feng mailto:bob.c.f...@intel.com>>
> Cc: Yuwei Chen mailto:yuwei.c...@intel.com>>
> Cc: Sami Mujawar  >
> Cc: Pierre Gondois  >
> Signed-off-by: levi.yun  >
> ---
> 
> 
> The changes can be seen at
> https://github.com/LeviYeoReum/edk2/tree/levi/3057_fix_false_on_ecc_v2
>  >
> 
> 
> BaseTools/Source/Python/Ecc/c.py | 23 ++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/BaseTools/Source/Python/Ecc/c.py
> b/BaseTools/Source/Python/Ecc/c.py
> index
> 61ad084fcc5b85b5a2194afd8bb1a4b4b65fdaee..71dc0fcf884ee3d45a527f20
> 844b697958df366c 100644
> --- a/BaseTools/Source/Python/Ecc/c.py
> +++ b/BaseTools/Source/Python/Ecc/c.py
> @@ -182,8 +182,27 @@ def GetIdentifierList():
> continue
> 
> 
> if var.Declarator.find('{') == -1:
> - for decl in var.Declarator.split(','):
> - DeclList = decl.split('=')
> + DeclText = var.Declarator
> + while (len(DeclText) > 0):
> + AllocatorPos = DeclText.find('=')
> + SplitPos = DeclText.find(',')
> +
> + if (SplitPos == -1):
> + SplitPos = len(DeclText)
> + elif (SplitPos > AllocatorPos):
> + NextAllcatorPos = DeclText.find('=', AllocatorPos + 1)
> + if (NextAllcatorPos == -1):
> + NextAllcatorPos = len(DeclText)
> + ParPos = DeclText.rfind(')', SplitPos, NextAllcatorPos)
> + if (ParPos != -1):
> + SplitPos = DeclText.find(',', ParPos)
> + if (SplitPos == -1):
> + SplitPos = ParPos + 1
> +
> + SubDeclText = DeclText[:SplitPos]
> + DeclText = DeclText[SplitPos + 1:]
> +
> + DeclList = SubDeclText.split('=')
> Name = DeclList[0].strip()
> if ArrayPattern.match(Name):
> LSBPos = var.Declarator.find('[')
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 
> 
> 
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#117802):
> https://edk2.groups.io/g/devel/message/117802
> 
> Mute This Topic: https://groups.io/mt/105542888/1779659
> 
> Group Owner: devel+ow...@edk2.groups.io
> 
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
>  [sami.muja...@arm.com
> ]
> -=-=-=-=-=-=
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117894): https://edk2.groups.io/g/devel/message/117894
Mute This Topic: https://groups.io/mt/105572420/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Sachin Ganesh 
> 发送时间: 2024年4月16日 3:28
> 收件人: devel@edk2.groups.io
> 抄送: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com;
> zhiguang@intel.com; Felix Polyudov ; Dhanaraj V
> ; Sachin Ganesh 
> 主题: [PATCH v2 1/5] MdePkg: Add definition for NVMe Over Fabric Device
> Path
> 
> In accordance with UEFI 2.10 Specification:
> Adding definition for NVMe Over Fabric (NVMe-oF) Device Path
> of Messaging Sub-Type.
> 
> Cc: Liming Gao 
> Cc: Michael D Kinney 
> Cc: Zhiguang Liu 
> Cc: Felix Polyudov 
> Cc: Dhanaraj V 
> Signed-off-by: Sachin Ganesh 
> ---
>  MdePkg/Include/Protocol/DevicePath.h | 22 ++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/DevicePath.h
> b/MdePkg/Include/Protocol/DevicePath.h
> index 9060dd782e..35008ddcdf 100644
> --- a/MdePkg/Include/Protocol/DevicePath.h
> +++ b/MdePkg/Include/Protocol/DevicePath.h
> @@ -837,6 +837,26 @@ typedef struct {
>UINT64  NamespaceUuid;
> 
>  } NVME_NAMESPACE_DEVICE_PATH;
> 
> 
> 
> +///
> 
> +/// NVMe over Fabric (NVMe-oF) Namespace Device Path SubType.
> 
> +///
> 
> +#define MSG_NVME_OF_NAMESPACE_DP  0x22
> 
> +typedef struct {
> 
> +  EFI_DEVICE_PATH_PROTOCOLHeader;
> 
> +  ///
> 
> +  /// Namespace Identifier Type (NIDT)
> 
> +  ///
> 
> +  UINT8   NamespaceIdType;
> 
> +  ///
> 
> +  /// Namespace Identifier (NID)
> 
> +  ///
> 
> +  UINT8   NamespaceId[16];
> 
> +  ///
> 
> +  /// Unique identifier of an NVM subsystem
> 
> +  ///
> 
> +  CHAR8   SubsystemNqn[];
> 
> +} NVME_OF_NAMESPACE_DEVICE_PATH;
> 
> +
> 
>  ///
> 
>  /// DNS Device Path SubType
> 
>  ///
> 
> @@ -1287,6 +1307,7 @@ typedef union {
>SAS_DEVICE_PATHSas;
> 
>SASEX_DEVICE_PATH  SasEx;
> 
>NVME_NAMESPACE_DEVICE_PATH
> NvmeNamespace;
> 
> +  NVME_OF_NAMESPACE_DEVICE_PATH
> NvmeOfNamespace;
> 
>DNS_DEVICE_PATHDns;
> 
>URI_DEVICE_PATHUri;
> 
>BLUETOOTH_DEVICE_PATH  Bluetooth;
> 
> @@ -1343,6 +1364,7 @@ typedef union {
>SAS_DEVICE_PATH*Sas;
> 
>SASEX_DEVICE_PATH  *SasEx;
> 
>NVME_NAMESPACE_DEVICE_PATH
> *NvmeNamespace;
> 
> +  NVME_OF_NAMESPACE_DEVICE_PATH
> *NvmeOfNamespace;
> 
>DNS_DEVICE_PATH*Dns;
> 
>URI_DEVICE_PATH*Uri;
> 
>BLUETOOTH_DEVICE_PATH  *Bluetooth;
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117845): https://edk2.groups.io/g/devel/message/117845
Mute This Topic: https://groups.io/mt/105551420/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Xianglei Cai
> 发送时间: 2024年4月15日 14:55
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih 
> 主题: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Reset endpoint
> while USB Transaction error
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4556
> 
> Based on XHCI spec 4.8.3, software should do the
> reset endpoint while USB Transaction occur.
> Add the error code for USB Transaction error
> since UEFI spec don't have the related definition.
> 
> Cc: Ray Ni  
> Cc: Liming Gao  
> Cc: Krzysztof Lewandowski   
> Cc: Jenny Huang 
> Cc: More Shih   
> Signed-off-by: Xianglei Cai 
> Reviewed-by: Krzysztof Lewandowski 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  | 5 -
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 5 -
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h | 7 +++
>  3 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> index f4e61d223c1b..cf6b32959e68 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
> @@ -825,7 +825,10 @@ XhcTransfer (
>*TransferResult = Urb->Result;
>*DataLength = Urb->Completed;
> 
> -  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
> EFI_USB_ERR_BABBLE)) {
> +  //
> +  // Based on XHCI spec 4.8.3, software should do the reset endpoint
while
> USB Transaction occur.
> +  //
> +  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
> EFI_USB_ERR_BABBLE) || (*TransferResult ==
> EDKII_USB_ERR_TRANSACTION)) {
>  ASSERT (Status == EFI_DEVICE_ERROR);
>  RecoveryStatus = XhcRecoverHaltedEndpoint (Xhc, Urb);
>  if (EFI_ERROR (RecoveryStatus)) {
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index 5d735008ba31..a97ed44dbfc3 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -1192,8 +1192,11 @@ XhcCheckUrbResult (
>  DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: ERR_BUFFER!
> Completecode = %x\n", EvtTrb->Completecode));
>  goto EXIT;
> 
> +  //
> +  // Based on XHCI spec 4.8.3, software should do the reset endpoint
> while USB Transaction occur.
> +  //
>case TRB_COMPLETION_USB_TRANSACTION_ERROR:
> -CheckedUrb->Result  |= EFI_USB_ERR_TIMEOUT;
> +CheckedUrb->Result  |= EDKII_USB_ERR_TRANSACTION;
>  CheckedUrb->Finished = TRUE;
>  DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult:
> TRANSACTION_ERROR! Completecode = %x\n", EvtTrb->Completecode));
>  goto EXIT;
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> index 7c85f7993b5c..e606e212a1d3 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.h
> @@ -78,6 +78,13 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #define TRB_COMPLETION_STOPPED 26
>  #define TRB_COMPLETION_STOPPED_LENGTH_INVALID  27
> 
> +//
> +// USB Transfer Results Internal Definition
> +// Based on XHCI spec 4.8.3, software should do the reset endpoint while
> USB Transaction occur.
> +// Add the error code for USB Transaction error since UEFI spec don't
have
> the related definition.
> +//
> +#define EDKII_USB_ERR_TRANSACTION  0x200
> +
>  //
>  // The topology string used to present usb device location
>  //
> --
> 2.42.0.windows.2
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117771): https://edk2.groups.io/g/devel/message/117771
Mute This Topic: https://groups.io/mt/105532714/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Xianglei Cai 
> 发送时间: 2024年4月15日 14:34
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih ; Ian Chiu 
> 主题: [PATCH V3 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of
> HCRST
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4727
> 
> Recently some of XHCI host controllers require to have
> extra 1ms delay before accessing any MMIO register
> during reset. PHY transition from P3 to P0 can take
> around 1.3ms and the xHCI reset can take around 1.5ms.
> Add PCD to control the delay, the default is 2 ms.
> 
> Cc: Ray Ni   
> Cc: Liming Gao   
> Cc: Krzysztof Lewandowski
> Cc: Jenny Huang  
> Cc: More Shih
> Cc: Ian Chiu 
> Signed-off-by: Xianglei Cai 
> Reviewed-by: Krzysztof Lewandowski 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h  | 1 +
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 4 
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 2 +-
>  MdeModulePkg/MdeModulePkg.dec| 5 +
>  4 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> index 44016758724c..c9a12095c29e 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> @@ -28,6 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  #include 
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> index 18ef87916ae4..e6c1ac8a6346 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> @@ -56,6 +56,7 @@
>DebugLib
>ReportStatusCodeLib
>TimerLib
> +  PcdLib
> 
>  [Guids]
>gEfiEventExitBootServicesGuid ##
> SOMETIMES_CONSUMES ## Event
> @@ -64,6 +65,9 @@
>gEfiPciIoProtocolGuid ## TO_START
>gEfiUsb2HcProtocolGuid## BY_START
> 
> +[Pcd]
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset  ##
> CONSUMES
> +
>  # [Event]
>  # EVENT_TYPE_PERIODIC_TIMER   ## CONSUMES
>  #
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> index 40f2f1f22766..525942a167b0 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> @@ -864,7 +864,7 @@ XhcResetHC (
>  // Otherwise there may have the timeout case happened.
>  // The below is a workaround to solve such problem.
>  //
> -gBS->Stall (XHC_1_MILLISECOND);
> +gBS->Stall (PcdGet16 (PcdDelayXhciHCReset));
>  Status = XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET,
> XHC_USBCMD_RESET, FALSE, Timeout);
> 
>  if (!EFI_ERROR (Status)) {
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index a91058e5b5df..d9e2e724df9e 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1148,6 +1148,11 @@
># @Prompt Enable large address image loading.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdImageLargeAddressLoad|TRUE|BOO
> LEAN|0x30001059
> 
> +  ## Indicates time delay for XHCI registers access after it issues
HCRST.
> +  # Default is 2000, it represent delay is 2 ms.
> +  # @Prompt Delay access XHCI register after it issues HCRST (us)
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000|UINT16|0x3
> 0001060
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>## Dynamic type PCD can be registered callback function for Pcd setting
> action.
>#  PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum
> number of callback function
> --
> 2.42.0.windows.2





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117760): https://edk2.groups.io/g/devel/message/117760
Mute This Topic: https://groups.io/mt/105531090/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

Xianglei:

  I understand this issue now. I suggest to add the internal definition in 
XhciDxe module for transaction error type, such as EDKII_USB_ERR_TRANSACTION. 
It can avoid the change in UEFI UsbIo protocol.

 

Thanks

Liming

发件人: Cai, Xianglei  
发送时间: 2024年4月15日 13:27
收件人: gaoliming ; Ni, Ray 
抄送: Huang, Jenny ; Shih, More ; 
devel@edk2.groups.io; Lewandowski, Krzysztof ; 
Lewandowski, Krzysztof 
主题: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction 
error

 

Hi Liming,

 

But we met some issues that system will stuck for 5-7 minutes because of USB 
transaction error with some USB device.

And check the XHCI spec, it shows need reset endpoint when USB transaction.

 

Thanks,

Xianglei

 

From: gaoliming mailto:gaolim...@byosoft.com.cn> > 
Sent: Monday, April 15, 2024 1:23 PM
To: Ni, Ray mailto:ray...@intel.com> >
Cc: Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, 
More mailto:more.s...@intel.com> >; devel@edk2.groups.io 
 ; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com> >; 
Cai, Xianglei mailto:xianglei@intel.com> >; 
Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> >
Subject: 回复: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error

 

Xianglei:

  Now, UEFI spec doesn’t define EFI_USB_ERR_TRANSACTION. So, we can’t update 
UsbIo.h now. 

 

  EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition check. I 
suggest to add comments for current code, don’t need code update. 

 

Thanks

Liming

发件人: Ni, Ray mailto:ray...@intel.com> > 
发送时间: 2024年4月15日 10:17
收件人: Liming Gao mailto:gaolim...@byosoft.com.cn> >
抄送: Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, 
More mailto:more.s...@intel.com> >; devel@edk2.groups.io 
 ; Lewandowski, Krzysztof 
mailto:krzysztof.lewandow...@intel.com> >; 
Cai, Xianglei mailto:xianglei@intel.com> >; 
Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> >
主题: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction 
error

 

Liming,

Can you give a R-B?

 

Thanks,

Ray

  _  

From: Cai, Xianglei mailto:xianglei@intel.com> >
Sent: Friday, April 12, 2024 9:53
To: Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> >; devel@edk2.groups.io 
  mailto:devel@edk2.groups.io> >; Ni, Ray mailto:ray...@intel.com> >; Liming Gao mailto:gaolim...@byosoft.com.cn> >
Cc: Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, 
More mailto:more.s...@intel.com> >
Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error 

 

  @Ni, Ray   @Liming 
GaoWould you like to merge the patch to upstream?

 

Thanks,

Xianglei

 

From: Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> > 
Sent: Thursday, April 11, 2024 9:45 PM
To: devel@edk2.groups.io  
Cc: Ni, Ray mailto:ray...@intel.com> >; Liming Gao 
mailto:gaolim...@byosoft.com.cn> >; Huang, Jenny 
mailto:jenny.hu...@intel.com> >; Shih, More 
mailto:more.s...@intel.com> >; Cai, Xianglei 
mailto:xianglei@intel.com> >
Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB 
Transaction error

 

Looks good to me.

Reviewed-by: Krzysztof Lewandowski mailto:krzysztof.lewandow...@intel.com> >

  _  

From: Cai, Xianglei mailto:xianglei@intel.com> >
Sent: Wednesday, April 10, 2024 09:02
To: devel@edk2.groups.io   mailto:devel@edk2.groups.io> >
Cc: Cai, Xianglei mailto:xianglei@intel.com> >; 
Ni, Ray mailto:ray...@intel.com> >; Liming Gao 
mailto:gaolim...@byosoft.com.cn> >; Lewandowski, 
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction 
error 

 

https://bugzilla.tianocore.org/show_bug.cgi?id=4556

Based on XHCI spec 4.8.3, software should do the
reset endpoint while USB Transaction occur.
Also add the error code for USB Transaction error
since UEFI spec don't have the related definition.

Cc: Ray Nimailto:ray...@intel.com> >
Cc: Liming Gaomailto:gaolim...@byosoft.com.cn> >
Cc: Krzysztof Lewandowskimailto:krzysztof.lewandow...@intel.com> >
Cc: Jenny Huang   mailto:jenny.hu...@intel.com> >
Cc: More Shih mailto:more.s...@intel.com> >

Signed-off-by: Xianglei Cai mailto:xianglei@intel.com> >
---
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  |  2 +-
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c |  2 +-
 MdePkg/Include/Protocol/UsbIo.h  | 21 +++--
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c 
b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
index f4e61d223c1b..63cc29b26536 

回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec

[gaoliming via groups.io]

Shenbagadevi:
  I think you still need to update ShellPkg SmbiosView to support the
updated TYPE17.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Shenbagadevi
> R via groups.io
> 发送时间: 2023年11月17日 18:05
> 收件人: devel@edk2.groups.io; Shenbagadevi R 
> 抄送: gaolim...@byosoft.com.cn; Sainadh Nagolu ;
> Sundaresan S ; Srinivasan Mani
> ; Ramesh R 
> 主题: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
> 
> As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
> PMIC & RCD manufacturer ID and Revision information in Type17.
> 
> Signed-off-by: Shenbagadevi R 
> 
> CC: Gaoliming 
> CC: Sainadh N 
> CC: Sundaresan S 
> CC: Srinivasan M 
> CC: Ramesh R 
> 
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 11 +--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 56cec615a0..cfefc2fa52 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights
> reserved.
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> 
>  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP
> 
>  Copyright (c) 2022, AMD Incorporated. All rights reserved.
> 
> -Copyright (c) 1985 - 2022, American Megatrends International LLC.
> 
> +Copyright (c) 1985 - 2023, American Megatrends International LLC.
> 
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>  **/
> 
> @@ -1509,7 +1509,7 @@ typedef struct {
>UINT8AsyncSurpriseRemoval: 1;
> 
>UINT8FlexbusSlotCxl10Capable : 1;
> 
>UINT8FlexbusSlotCxl20Capable : 1;
> 
> -  UINT8Reserved: 1; ///< Set to 0.
> 
> +  UINT8FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated
> CXL 3.0 support
> 
>  } MISC_SLOT_CHARACTERISTICS2;
> 
> 
> 
>  ///
> 
> @@ -2012,6 +2012,13 @@ typedef struct {
>//
> 
>UINT32 ExtendedSpeed;
> 
>UINT32
> ExtendedConfiguredMemorySpeed;
> 
> +  //
> 
> +  // Add for smbios 3.7.0
> 
> +  //
> 
> +  UINT16
> Pmic0ManufacturerID;
> 
> +  UINT16
> Pmic0RevisionNumber;
> 
> +  UINT16
> RcdManufacturerID;
> 
> +  UINT16
> RcdRevisionNumber;
> 
>  } SMBIOS_TABLE_TYPE17;
> 
> 
> 
>  ///
> 
> --
> 2.38.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117757): https://edk2.groups.io/g/devel/message/117757
Mute This Topic: https://groups.io/mt/105531068/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH V2 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

[gaoliming via groups.io]

The change in DSC is not required. PCD default value is from DEC. 

Thanks
Liming
> -邮件原件-
> 发件人: Xianglei Cai 
> 发送时间: 2024年4月15日 14:25
> 收件人: devel@edk2.groups.io
> 抄送: Xianglei Cai ; Ray Ni ;
> Liming Gao ; Krzysztof Lewandowski
> ; Jenny Huang ;
> More Shih ; Ian Chiu 
> 主题: [PATCH V2 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of
> HCRST
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4727
> 
> Recently some of XHCI host controllers require to have
> extra 1ms delay before accessing any MMIO register
> during reset. PHY transition from P3 to P0 can take
> around 1.3ms and the xHCI reset can take around 1.5ms.
> Add PCD to control the delay, the default is 2 ms.
> 
> Cc: Ray Ni   
> Cc: Liming Gao   
> Cc: Krzysztof Lewandowski
> Cc: Jenny Huang  
> Cc: More Shih
> Cc: Ian Chiu 
> Signed-off-by: Xianglei Cai 
> Reviewed-by: Krzysztof Lewandowski 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h  | 1 +
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 4 
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 2 +-
>  MdeModulePkg/MdeModulePkg.dec| 5 +
>  MdeModulePkg/MdeModulePkg.dsc| 1 +
>  5 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> index 44016758724c..c9a12095c29e 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
> @@ -28,6 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  #include 
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> index 18ef87916ae4..e6c1ac8a6346 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> @@ -56,6 +56,7 @@
>DebugLib
>ReportStatusCodeLib
>TimerLib
> +  PcdLib
> 
>  [Guids]
>gEfiEventExitBootServicesGuid ##
> SOMETIMES_CONSUMES ## Event
> @@ -64,6 +65,9 @@
>gEfiPciIoProtocolGuid ## TO_START
>gEfiUsb2HcProtocolGuid## BY_START
> 
> +[Pcd]
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset  ##
> CONSUMES
> +
>  # [Event]
>  # EVENT_TYPE_PERIODIC_TIMER   ## CONSUMES
>  #
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> index 40f2f1f22766..525942a167b0 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> @@ -864,7 +864,7 @@ XhcResetHC (
>  // Otherwise there may have the timeout case happened.
>  // The below is a workaround to solve such problem.
>  //
> -gBS->Stall (XHC_1_MILLISECOND);
> +gBS->Stall (PcdGet16 (PcdDelayXhciHCReset));
>  Status = XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET,
> XHC_USBCMD_RESET, FALSE, Timeout);
> 
>  if (!EFI_ERROR (Status)) {
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index a91058e5b5df..d9e2e724df9e 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1148,6 +1148,11 @@
># @Prompt Enable large address image loading.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdImageLargeAddressLoad|TRUE|BOO
> LEAN|0x30001059
> 
> +  ## Indicates time delay for XHCI registers access after it issues
HCRST.
> +  # Default is 2000, it represent delay is 2 ms.
> +  # @Prompt Delay access XHCI register after it issues HCRST (us)
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000|UINT16|0x3
> 0001060
> +
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>## Dynamic type PCD can be registered callback function for Pcd setting
> action.
>#  PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum
> number of callback function
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc
> index c0f1df3bfbca..0ce4f687679a 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -210,6 +210,7 @@
>gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule|0x0
>gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizePopulateCapsule|0x0
>gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries|28
> +  gEfiMdePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000
> 
>  [PcdsDynamicExDefault]
>gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"FVMAIN.FV"
> --
> 2.42.0.windows.2





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117756): https://edk2.groups.io/g/devel/message/117756
Mute This Topic: https://groups.io/mt/105531056/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx - mantis #2131

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Qingyu
> 发送时间: 2024年4月2日 11:56
> 收件人: devel@edk2.groups.io
> 抄送: Dandan Bi ; Liming Gao
> 
> 主题: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg:
> Update the comments of ReadKeyStroke and ReadKeyStrokeEx - mantis
> #2131
> 
> Refer to Uefi spec 2.10 section 12.3.3, Add a new retval
> EFI_UNSUPPORTED to
> EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx
> and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().
> 
> Cc: Dandan Bi 
> Cc: Liming Gao 
> Signed-off-by: Qingyu 
> ---
>  .../VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c | 2 ++
>  .../VirtualKeyboardDxe/VirtualKeyboard.h| 2
> ++
>  2 files changed, 4 insertions(+)
> 
> diff --git
> a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/Keyboard.c
> b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/Keyboard.c
> index 82aeac31bc..9c9b585ae2 100644
> ---
> a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/Keyboard.c
> +++
> b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/Keyboard.c
> @@ -1101,6 +1101,7 @@ End:
>@retval EFI_NOT_READYThere was no keystroke data available.
>@retval EFI_DEVICE_ERROR The keystroke information was not returned
> due to
> hardware errors.
> +  @retval EFI_UNSUPPORTED  The device does not support the ability to
> read keystroke data.
> 
>  **/
>  EFI_STATUS
> @@ -1154,6 +1155,7 @@ End:
>@retval EFI_SUCCESSThe keystroke information was
> returned.
>@retval EFI_NOT_READY  There was no keystroke data
> available.
>@retval EFI_INVALID_PARAMETER  This or KeyData is NULL.
> +  @retval EFI_UNSUPPORTEDThe device does not support the
> ability to read keystroke data.
> 
>  **/
>  EFI_STATUS
> diff --git
> a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/VirtualKeyboard.h
> b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/VirtualKeyboard.h
> index 7090730861..d7b7340574 100644
> ---
> a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/VirtualKeyboard.h
> +++
> b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboard
> Dxe/VirtualKeyboard.h
> @@ -464,6 +464,7 @@ VkKeyboardReset (
>@retval EFI_NOT_READYThere was no keystroke data available.
>@retval EFI_DEVICE_ERROR The keystroke information was not returned
> due to
> hardware errors.
> +  @retval EFI_UNSUPPORTED  The device does not support the ability to
> read keystroke data.
> 
>  **/
>  EFI_STATUS
> @@ -512,6 +513,7 @@ VkKeyboardResetEx (
>@retval EFI_SUCCESSThe keystroke information was
> returned.
>@retval EFI_NOT_READY  There was no keystroke data
> available.
>@retval EFI_INVALID_PARAMETER  This or KeyData is NULL.
> +  @retval EFI_UNSUPPORTEDThe device does not support the
> ability to read keystroke data.
> 
>  **/
>  EFI_STATUS
> --
> 2.39.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117750): https://edk2.groups.io/g/devel/message/117750
Mute This Topic: https://groups.io/mt/105530319/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

[gaoliming via groups.io]

Xianglei:

  Now, UEFI spec doesn’t define EFI_USB_ERR_TRANSACTION. So, we can’t
update UsbIo.h now. 

 

  EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition check.
I suggest to add comments for current code, don’t need code update. 

 

Thanks

Liming

发件人: Ni, Ray  
发送时间: 2024年4月15日 10:17
收件人: Liming Gao 
抄送: Huang, Jenny ; Shih, More
; devel@edk2.groups.io; Lewandowski, Krzysztof
; Cai, Xianglei ;
Lewandowski, Krzysztof 
主题: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB
Transaction error

 

Liming,

Can you give a R-B?

 

Thanks,

Ray

  _  

From: Cai, Xianglei mailto:xianglei@intel.com>
>
Sent: Friday, April 12, 2024 9:53
To: Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> >; devel@edk2.groups.io
  mailto:devel@edk2.groups.io> >; Ni, Ray mailto:ray...@intel.com> >; Liming Gao mailto:gaolim...@byosoft.com.cn> >
Cc: Huang, Jenny mailto:jenny.hu...@intel.com> >;
Shih, More mailto:more.s...@intel.com> >
Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB
Transaction error 

 

  @Ni, Ray  
@Liming GaoWould you like to merge the patch to upstream?

 

Thanks,

Xianglei

 

From: Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> > 
Sent: Thursday, April 11, 2024 9:45 PM
To: devel@edk2.groups.io  
Cc: Ni, Ray mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Huang, Jenny
mailto:jenny.hu...@intel.com> >; Shih, More
mailto:more.s...@intel.com> >; Cai, Xianglei
mailto:xianglei@intel.com> >
Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB
Transaction error

 

Looks good to me.

Reviewed-by: Krzysztof Lewandowski mailto:krzysztof.lewandow...@intel.com> >

  _  

From: Cai, Xianglei mailto:xianglei@intel.com>
>
Sent: Wednesday, April 10, 2024 09:02
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >
Cc: Cai, Xianglei mailto:xianglei@intel.com> >;
Ni, Ray mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >
Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB
Transaction error 

 

https://bugzilla.tianocore.org/show_bug.cgi?id=4556

Based on XHCI spec 4.8.3, software should do the
reset endpoint while USB Transaction occur.
Also add the error code for USB Transaction error
since UEFI spec don't have the related definition.

Cc: Ray Nimailto:ray...@intel.com> >
Cc: Liming Gaomailto:gaolim...@byosoft.com.cn> >
Cc: Krzysztof Lewandowskimailto:krzysztof.lewandow...@intel.com> >
Cc: Jenny Huang   mailto:jenny.hu...@intel.com> >
Cc: More Shih mailto:more.
s...@intel.com> >

Signed-off-by: Xianglei Cai mailto:xianglei@intel.com> >
---
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c  |  2 +-
 MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c |  2 +-
 MdePkg/Include/Protocol/UsbIo.h  | 21 +++--
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
index f4e61d223c1b..63cc29b26536 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
@@ -825,7 +825,7 @@ XhcTransfer (
   *TransferResult = Urb->Result;
   *DataLength = Urb->Completed;
 
-  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
EFI_USB_ERR_BABBLE)) {
+  if ((*TransferResult == EFI_USB_ERR_STALL) || (*TransferResult ==
EFI_USB_ERR_BABBLE) || (*TransferResult == EFI_USB_ERR_TRANSACTION)) {
 ASSERT (Status == EFI_DEVICE_ERROR);
 RecoveryStatus = XhcRecoverHaltedEndpoint (Xhc, Urb);
 if (EFI_ERROR (RecoveryStatus)) {
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
index 05528a478baf..e77852f62f10 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -1193,7 +1193,7 @@ XhcCheckUrbResult (
 goto EXIT;
 
   case TRB_COMPLETION_USB_TRANSACTION_ERROR:
-CheckedUrb->Result  |= EFI_USB_ERR_TIMEOUT;
+CheckedUrb->Result  |= EFI_USB_ERR_TRANSACTION;
 CheckedUrb->Finished = TRUE;
 DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: TRANSACTION_ERROR!
Completecode = %x\n", EvtTrb->Completecode));
 goto EXIT;
diff --git a/MdePkg/Include/Protocol/UsbIo.h
b/MdePkg/Include/Protocol/UsbIo.h
index a780b4e07b44..211ef0c94156 100644
--- a/MdePkg/Include/Protocol/UsbIo.h
+++ b/MdePkg/Include/Protocol/UsbIo.h
@@ -50,16 +50,17 @@ typedef enum {
 //
 // USB Transfer Results
 //
-#define EFI_USB_NOERROR 0x00
-#define EFI_USB_ERR_NOTEXECUTE  0x01
-#define EFI_USB_ERR_STALL   0x02

[edk2-devel] 回复: [PATCH 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

[gaoliming via groups.io]

I suggest to define this PCD in MdeModulePkg instead of MdePkg. This PCD is
only consumed by MdeModulePkg XhciDxe module. 

 

Thanks

Liming

发件人: Cai, Xianglei  
发送时间: 2024年4月12日 9:54
收件人: Lewandowski, Krzysztof ;
devel@edk2.groups.io; Ni, Ray ; Liming Gao

抄送: Huang, Jenny ; Shih, More
; Chiu, Ian 
主题: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST

 

  @Liming Gao  
@Ni, Ray Would you like to merge the patch to upstream?

 

Thanks,

Xianglei

 

From: Lewandowski, Krzysztof mailto:krzysztof.lewandow...@intel.com> > 
Sent: Wednesday, April 10, 2024 9:29 PM
To: Cai, Xianglei mailto:xianglei@intel.com> >;
devel@edk2.groups.io  
Cc: Ni, Ray mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Huang, Jenny
mailto:jenny.hu...@intel.com> >; Shih, More
mailto:more.s...@intel.com> >; Chiu, Ian
mailto:ian.c...@intel.com> >
Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of
HCRST

 

Looks good to me.

Reviewed-by: Krzysztof Lewandowski mailto:krzysztof.lewandow...@intel.com> >

  _  

From: Cai, Xianglei mailto:xianglei@intel.com>
>
Sent: Wednesday, April 10, 2024 09:01
To: devel@edk2.groups.io 
mailto:devel@edk2.groups.io> >
Cc: Cai, Xianglei mailto:xianglei@intel.com> >;
Ni, Ray mailto:ray...@intel.com> >; Liming Gao
mailto:gaolim...@byosoft.com.cn> >; Lewandowski,
Krzysztof mailto:krzysztof.lewandow...@intel.com> >; Huang, Jenny mailto:jenny.hu...@intel.com> >; Shih, More mailto:more.s...@intel.com> >; Chiu, Ian mailto:ian.c...@intel.com> >
Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Add PCD for the delay of HCRST 

 

https://bugzilla.tianocore.org/show_bug.cgi?id=4727

Recently some of XHCI host controllers require to have
extra 1ms delay before accessing any MMIO register
during reset. PHY transition from P3 to P0 can take
around 1.3ms and the xHCI reset can take around 1.5ms.
Add PCD to control the delay, the default is 2 ms.

Cc: Ray Nimailto:ray...@intel.com> >
Cc: Liming Gaomailto:gaolim...@byosoft.com.cn> >
Cc: Krzysztof Lewandowskimailto:krzysztof.lewandow...@intel.com> >
Cc: Jenny Huang   mailto:jenny.hu...@intel.com> >
Cc: More Shih mailto:more.
s...@intel.com> >
Cc: Ian Chiu  mailto:ian.c...@intel.com> >

Signed-off-by: Xianglei Cai mailto:xianglei@intel.com> >
---
 MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h  | 1 +
 MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf | 4 
 MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c   | 2 +-
 MdePkg/MdePkg.dec| 4 
 MdePkg/MdePkg.dsc| 1 +
 5 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
index 44016758724c..c9a12095c29e 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h
@@ -28,6 +28,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
index 18ef87916ae4..2ee4c22d1e32 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
@@ -56,6 +56,7 @@
   DebugLib
   ReportStatusCodeLib
   TimerLib
+  PcdLib
 
 [Guids]
   gEfiEventExitBootServicesGuid ## SOMETIMES_CONSUMES ##
Event
@@ -64,6 +65,9 @@
   gEfiPciIoProtocolGuid ## TO_START
   gEfiUsb2HcProtocolGuid## BY_START
 
+[Pcd]
+  gEfiMdePkgTokenSpaceGuid.PcdDelayXhciHCReset  ## CONSUMES
+
 # [Event]
 # EVENT_TYPE_PERIODIC_TIMER   ## CONSUMES
 #
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
index 40f2f1f22766..525942a167b0 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
@@ -864,7 +864,7 @@ XhcResetHC (
 // Otherwise there may have the timeout case happened.
 // The below is a workaround to solve such problem.
 //
-gBS->Stall (XHC_1_MILLISECOND);
+gBS->Stall (PcdGet16 (PcdDelayXhciHCReset));
 Status = XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET,
FALSE, Timeout);
 
 if (!EFI_ERROR (Status)) {
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 0459418906f8..a5b3ce94072c 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2510,5 +2510,9 @@
   # @Prompt Memory encryption attribute
 
gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x00
2e
 
+  ## This dynamic PCD indicates time delay for XHCI registers access after
it issues HCRST.
+  # @Prompt Delay access XHCI register after it issues HCRST (us)
+  gEfiMdePkgTokenSpaceGuid.PcdDelayXhciHCReset|2000|UINT16|0x0043
+
 

回复: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

[gaoliming via groups.io]

Thanks for your update. Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Taylor Beebe
> 发送时间: 2024年4月10日 3:43
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: 'Rebecca Cran' ; 'Bob Feng'
> ; 'Yuwei Chen' 
> 主题: Re: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL
> Include and Library Matching
> 
> Hi Liming,
> 
> I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144
> of WorkspaceCommon.py update the check to:
> 
> `LibraryClassName[4:].isdigit()`
> 
> instead of
> 
> `LibraryClass[4:].isdigit()`
> 
> Can you re-review with this change?
> 
> -Taylor
> 
> On 4/1/2024 6:37 PM, gaoliming via groups.io wrote:
> > Taylor:
> >Thanks for you detail information. I understand this problem. I agree
> your fix. Reviewed-by: Liming Gao 
> >
> > Thanks
> > Liming
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117747): https://edk2.groups.io/g/devel/message/117747
Mute This Topic: https://groups.io/mt/105529073/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/2] MdePkg/SmBios.h: Add New ProcessorUpgrade definitions for SMBIOS Type4

[gaoliming via groups.io]

Reviewed-by: Liming Gao  for this patch set. 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Jason Lou
> 发送时间: 2024年4月14日 23:24
> 收件人: devel@edk2.groups.io
> 抄送: Jason Lou ; Zhiguang Liu
;
> Dandan Bi ; Star Zeng ; Zhichao
> Gao ; Benny Lin ; Gua Guo
> ; Michael D Kinney ;
> Liming Gao 
> 主题: [edk2-devel] [PATCH v1 1/2] MdePkg/SmBios.h: Add New
> ProcessorUpgrade definitions for SMBIOS Type4
> 
> From: Jason Lou 
> 
> The patch adds new ProcessorUpgrade definitions for SMBIOS Type4 based
> on SMBIOS 3.8.0.
> 
> Signed-off-by: Jason Lou 
> Cc: Zhiguang Liu 
> Cc: Dandan Bi 
> Cc: Star Zeng 
> Cc: Zhichao Gao 
> Cc: Benny Lin 
> Cc: Gua Guo 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 9 -
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index bdb28fc3a3..020733b777 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -880,7 +880,14 @@ typedef enum {
>ProcessorUpgradeSocketBGA1190   = 0x4D,
> 
>ProcessorUpgradeSocketBGA4129   = 0x4E,
> 
>ProcessorUpgradeSocketLGA4710   = 0x4F,
> 
> -  ProcessorUpgradeSocketLGA7529   = 0x50
> 
> +  ProcessorUpgradeSocketLGA7529   = 0x50,
> 
> +  ProcessorUpgradeSocketBGA1964   = 0x51,
> 
> +  ProcessorUpgradeSocketBGA1792   = 0x52,
> 
> +  ProcessorUpgradeSocketBGA2049   = 0x53,
> 
> +  ProcessorUpgradeSocketBGA2551   = 0x54,
> 
> +  ProcessorUpgradeSocketLGA1851   = 0x55,
> 
> +  ProcessorUpgradeSocketBGA2114   = 0x56,
> 
> +  ProcessorUpgradeSocketBGA2833   = 0x57
> 
>  } PROCESSOR_UPGRADE;
> 
> 
> 
>  ///
> 
> --
> 2.44.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#117722):
> https://edk2.groups.io/g/devel/message/117722
> Mute This Topic: https://groups.io/mt/105518457/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117746): https://edk2.groups.io/g/devel/message/117746
Mute This Topic: https://groups.io/mt/105529055/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

[gaoliming via groups.io]

PR https://github.com/tianocore/edk2/pull/5539 has been created.

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Aaron Li
> 发送时间: 2024年4月1日 10:32
> 收件人: devel@edk2.groups.io; Liming Gao 
> 抄送: Bi, Dandan ; Liu, Yun Y ;
> Yao, Jiewen ; Ni, Ray ; Kinney,
> Michael D ; Liu, Zhiguang
> 
> 主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD
> switch to avoid using ACPI reclaim memory
> 
> Hi Liming,
> 
> Could you please help review and merge it? Thanks.
> 
> Best,
> Aaron
> 
> -Original Message-
> From: Liu, Zhiguang 
> Sent: Monday, April 1, 2024 10:06 AM
> To: Li, Aaron ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Liming Gao
> ; Liu, Yun Y ; Yao, Jiewen
> ; Ni, Ray ; Kinney, Michael D
> 
> Subject: RE: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to
> avoid using ACPI reclaim memory
> 
> Reviewed-by: Zhiguang Liu 
> 
> > -Original Message-
> > From: Li, Aaron 
> > Sent: Tuesday, March 26, 2024 3:58 PM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang ; Bi, Dandan
> > ; Liming Gao ; Liu, Yun
> Y
> > ; Yao, Jiewen ; Ni, Ray
> > ; Kinney, Michael D 
> > Subject: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid
> > using ACPI reclaim memory
> >
> > UEFI spec defined ACPI Tables at boot time can be contained in memory of
> > type EfiACPIReclaimMemory or EfiAcpiMemoryNVS, although
> InstallAcpiTable
> > with AcpiTableProtocol will only allocate memory with type
> > EfiACPIReclaimMemory (Except FACS).
> >
> > This patch provides an optional method controlled by PCD to avoid using
> > EfiACPIReclaimMemory, by setting the PCD PcdNoACPIReclaimMemory to
> > TRUE, all ACPI allocated memory will use EfiAcpiMemoryNVS instead.
> >
> > Cc: Zhiguang Liu 
> > Cc: Dandan Bi 
> > Cc: Liming Gao 
> > Cc: Liu Yun 
> > Cc: Jiewen Yao 
> > Cc: Ray Ni 
> > Cc: Michael D Kinney 
> > Signed-off-by: Aaron Li 
> > ---
> >  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 37
> > +++-
> >  MdeModulePkg/MdeModulePkg.dec
> |  7 
> >  MdeModulePkg/MdeModulePkg.uni
> |  8 +
> >  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf|  1
> +
> >  4 files changed, 45 insertions(+), 8 deletions(-)
> >
> > diff --git
> a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > index e09bc9b704f5..080768033cfa 100644
> > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > @@ -340,6 +340,7 @@ ReallocateAcpiTableBuffer (
> >EFI_ACPI_TABLE_INSTANCE  TempPrivateData;
> >EFI_STATUS   Status;
> >UINT64   CurrentData;
> > +  EFI_MEMORY_TYPE  AcpiAllocateMemoryType;
> >
> >CopyMem (, AcpiTableInstance, sizeof
> > (EFI_ACPI_TABLE_INSTANCE));
> >//
> > @@ -359,6 +360,12 @@ ReallocateAcpiTableBuffer (
> >   NewMaxTableNumber * sizeof (UINT32);
> >}
> >
> > +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> > +AcpiAllocateMemoryType = EfiACPIMemoryNVS;  } else {
> > +AcpiAllocateMemoryType = EfiACPIReclaimMemory;  }
> > +
> >if (mAcpiTableAllocType != AllocateAnyPages) {
> >  //
> >  // Allocate memory in the lower 32 bit of address range for @@
> -372,13
> > +379,13 @@ ReallocateAcpiTableBuffer (
> >  PageAddress = 0x;
> >  Status  = gBS->AllocatePages (
> >   mAcpiTableAllocType,
> > - EfiACPIReclaimMemory,
> > + AcpiAllocateMemoryType,
> >   EFI_SIZE_TO_PAGES (TotalSize),
> >   
> >   );
> >} else {
> >  Status = gBS->AllocatePool (
> > -EfiACPIReclaimMemory,
> > +AcpiAllocateMemoryType,
> >  TotalSize,
> >  (VOID **)
> >  );
> > @@ -512,6 +519,7 @@ AddTableToList (
> >EFI_PHYSICAL_ADDRESS  AllocPhysAddress;
> >UINT64Buffer64;
> >BOOLEAN   AddToRsdt;
> > +  EFI_MEMORY_TYPE   AcpiAllocateMemoryType;
> >
> >//
> >// Check for invalid input parameters @@ -550,6 +558,12 @@
> > AddTableToList (
> >CurrentTableList->TableSize  = CurrentTableSize;
> >CurrentTableList->PoolAllocation = FALSE;
> >
> > +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> > +AcpiAllocateMemoryType = EfiACPIMemoryNVS;  } else {
> > +AcpiAllocateMemoryType = EfiACPIReclaimMemory;  }
> > +
> >//
> >// Allocation memory type depends on the type of the table
> >//
> > @@ -585,7 +599,7 @@ AddTableToList (
> >  // such as AArch64 that allocate multiples of 64 KB
> >  //
> >  Status = gBS->AllocatePool (
> > -EfiACPIReclaimMemory,
> > +AcpiAllocateMemoryType,
> >  CurrentTableList->TableSize,
> >   

回复: [edk2-devel] [PATCH v2 3/9] MdePkg: Add devAuthBoot GlobalVariable

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Wenxing Hou
> 发送时间: 2024年4月8日 9:47
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao 
> 主题: [edk2-devel] [PATCH v2 3/9] MdePkg: Add devAuthBoot GlobalVariable
> 
> According to UEFI 2.10 spec 3.3 Globally Defined Variables section,
> add devAuthBoot GlobalVariable.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jiewen Yao 
> Signed-off-by: Wenxing Hou 
> ---
>  MdePkg/Include/Guid/GlobalVariable.h  | 8 +++-
>  MdePkg/Include/Guid/ImageAuthentication.h | 5 -
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Guid/GlobalVariable.h
> b/MdePkg/Include/Guid/GlobalVariable.h
> index eb2ce6aaf2..eb6e5a043e 100644
> --- a/MdePkg/Include/Guid/GlobalVariable.h
> +++ b/MdePkg/Include/Guid/GlobalVariable.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>GUID for EFI (NVRAM) Variables.
> 
> 
> 
> -  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> 
> +  Copyright (c) 2006 - 2024, Intel Corporation. All rights reserved.
> 
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>@par Revision Reference:
> 
> @@ -183,4 +183,10 @@ extern EFI_GUID  gEfiGlobalVariableGuid;
>  ///
> 
>  #define EFI_VENDOR_KEYS_VARIABLE_NAME  L"VendorKeys"
> 
> 
> 
> +///
> 
> +/// Whether the platform firmware is operating in device authentication
boot
> mode (1) or not (0).
> 
> +/// The content is UINT8.
> 
> +///
> 
> +#define EFI_DEVICE_AUTH_BOOT_MODE_NAME  L"devAuthBoot"
> 
> +
> 
>  #endif
> 
> diff --git a/MdePkg/Include/Guid/ImageAuthentication.h
> b/MdePkg/Include/Guid/ImageAuthentication.h
> index fe83596571..f95255c0fb 100644
> --- a/MdePkg/Include/Guid/ImageAuthentication.h
> +++ b/MdePkg/Include/Guid/ImageAuthentication.h
> @@ -1,7 +1,7 @@
>  /** @file
> 
>Image signature database are defined for the signed image validation.
> 
> 
> 
> -  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> 
> +  Copyright (c) 2009 - 2024, Intel Corporation. All rights reserved.
> 
>SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> 
> 
>@par Revision Reference:
> 
> @@ -41,6 +41,9 @@
>  #define SETUP_MODE  1
> 
>  #define USER_MODE   0
> 
> 
> 
> +#define DEVICE_AUTH_BOOT_MODE_ENABLE   1
> 
> +#define DEVICE_AUTH_BOOT_MODE_DISABLE  0
> 
> +
> 
>  //
> **
> *
> 
>  // Signature Database
> 
>  //
> **
> *
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#117480):
> https://edk2.groups.io/g/devel/message/117480
> Mute This Topic: https://groups.io/mt/105394115/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117536): https://edk2.groups.io/g/devel/message/117536
Mute This Topic: https://groups.io/mt/105417127/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH] MdePkg: Update the comments of GetInformation function

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Qingyu 
> 发送时间: 2024年4月8日 17:28
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Michael D Kinney
> ; Zhiguang Liu ;
> Gahan Saraiya 
> 主题: [PATCH] MdePkg: Update the comments of GetInformation function
> 
> Refer to Uefi spec 2.10 section 11.11.2, add a new retval
> EFI_NOT_FOUND to
> EFI_ADAPTER_INFORMATION_PROTOCOL.GetInformation().
> Reference: [mantis #1866] - GetInfo() of Adapter Information
> Protocol should have a provision for IHV to return no data.
> 
> Cc: Liming Gao 
> Cc: Michael D Kinney 
> Cc: Zhiguang Liu 
> Signed-off-by: Qingyu 
> Signed-off-by: Gahan Saraiya 
> ---
>  MdePkg/Include/Protocol/AdapterInformation.h | 5 -
>  MdePkg/Library/DxeHstiLib/HstiAip.c  | 5 -
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/AdapterInformation.h
> b/MdePkg/Include/Protocol/AdapterInformation.h
> index ed19e5736c3c..8e4448eb0f87 100644
> --- a/MdePkg/Include/Protocol/AdapterInformation.h
> +++ b/MdePkg/Include/Protocol/AdapterInformation.h
> @@ -140,7 +140,9 @@ typedef struct {
> 
>This function returns information of type InformationType from the
> adapter.
>If an adapter does not support the requested informational type, then
> -  EFI_UNSUPPORTED is returned.
> +  EFI_UNSUPPORTED is returned. If an adapter does not contain
> Information for
> +  the requested InformationType, it fills InformationBlockSize with 0 and
> +  returns EFI_NOT_FOUND.
> 
>@param[in]  This   A pointer to the
> EFI_ADAPTER_INFORMATION_PROTOCOL instance.
>@param[in]  InformationTypeA pointer to an EFI_GUID that
> defines the contents of InformationBlock.
> @@ -150,6 +152,7 @@ typedef struct {
> 
>@retval EFI_SUCCESSThe InformationType
> information was retrieved.
>@retval EFI_UNSUPPORTEDThe InformationType is not
> known.
> +  @retval EFI_NOT_FOUND  Information is not available for
> the requested information type.
>@retval EFI_DEVICE_ERROR   The device reported an error.
>@retval EFI_OUT_OF_RESOURCES   The request could not be
> completed due to a lack of resources.
>@retval EFI_INVALID_PARAMETER  This is NULL.
> diff --git a/MdePkg/Library/DxeHstiLib/HstiAip.c
> b/MdePkg/Library/DxeHstiLib/HstiAip.c
> index a2454ffeaa7a..523a712e6f6e 100644
> --- a/MdePkg/Library/DxeHstiLib/HstiAip.c
> +++ b/MdePkg/Library/DxeHstiLib/HstiAip.c
> @@ -12,7 +12,9 @@
> 
>This function returns information of type InformationType from the
> adapter.
>If an adapter does not support the requested informational type, then
> -  EFI_UNSUPPORTED is returned.
> +  EFI_UNSUPPORTED is returned. If an adapter does not contain
> Information for
> +  the requested InformationType, it fills InformationBlockSize with 0 and
> +  returns EFI_NOT_FOUND.
> 
>@param[in]  This   A pointer to the
> EFI_ADAPTER_INFORMATION_PROTOCOL instance.
>@param[in]  InformationTypeA pointer to an EFI_GUID that
> defines the contents of InformationBlock.
> @@ -22,6 +24,7 @@
> 
>@retval EFI_SUCCESSThe InformationType
> information was retrieved.
>@retval EFI_UNSUPPORTEDThe InformationType is not
> known.
> +  @retval EFI_NOT_FOUND  Information is not available for
> the requested information type.
>@retval EFI_DEVICE_ERROR   The device reported an error.
>@retval EFI_OUT_OF_RESOURCES   The request could not be
> completed due to a lack of resources.
>@retval EFI_INVALID_PARAMETER  This is NULL.
> --
> 2.39.1.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117535): https://edk2.groups.io/g/devel/message/117535
Mute This Topic: https://groups.io/mt/105417121/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V5 0/6] SPI NOR Flash Driver for SFDP flash device

[gaoliming via groups.io]

Abner:
  The change is good to me. Reviewed-by: Liming Gao


Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Chang, Abner
> via groups.io
> 发送时间: 2024年4月4日 17:25
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Abdul
> Lateef Attar ; Hao A Wu ; Ray Ni
> ; Jian J Wang ; Brit Chesley
> 
> 主题: [edk2-devel] [PATCH V5 0/6] SPI NOR Flash Driver for SFDP flash
device
> 
> From: Abner Chang 
> 
> Sending V4 for review as SPI related ECR is approved by
> PIWG in PI spec 1.8A
> 
> In V5: Correct patch 6/6, as some source files are fixed in this patch.
> In RESEND V4: Add Cc in patch 6/6
> In V4: Enhance timeout algorithm
> In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
>MdeModulePkg.dec.
> In V2: Add maintainer entry for Bus/Spi.
> 
> This patch fixes the missing SPI defintions per to PI spec
> 1.8 errata A.
> This patch also provides the implemtation of SPI NOR flash
> driver that supports JEDEC SFDP specification.
> This driver support the flash device that has the GUID
> gEdk2JedecSfdpSpiDxeDriverGuid or gEdk2JedecSfdpSpiSmmDriverGuid
> declared in EFI_SPI_PERIPHERAL SpiPeripheralDriverGuid structure.
> 
> The driver has been verified with Macronix MX25U6435F flash device.
> 
> Signed-off-by: Abner Chang 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Abdul Lateef Attar 
> Cc: Hao A Wu 
> Cc: Ray Ni 
> Cc: Jian J Wang 
> Cc: Liming Gao 
> Cc: Brit Chesley 
> 
> Abner Chang (2):
>   MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver
>   Maintainers: AMD as SPI driver stack maintainer
> 
> abnchang (4):
>   MdePkg/Include: Update definitions of SPI related header files
>   MdePkg/Include: Add SPI NOR Flash JEDEC SFDP header file
>   MdeModulePkg/SpiNorFlashJedecSfdp: SPI NOR Flash JEDEC SFDP
>   MdeModulePkg: Add SPI NOR FLash SFDP drivers to DSC
> 
>  MdeModulePkg/MdeModulePkg.dec |   28 +-
>  MdeModulePkg/MdeModulePkg.dsc |4 +-
>  .../SpiNorFlashJedecSfdpDxe.inf   |   64 +
>  .../SpiNorFlashJedecSfdpSmm.inf   |   64 +
>  .../Spi/SpiNorFlashJedecSfdp/SpiNorFlash.h|  286 +++
>  .../SpiNorFlashJedecSfdpInternal.h|  299 +++
>  .../IndustryStandard/SpiNorFlashJedecSfdp.h   |  324 +++
>  MdePkg/Include/Protocol/SpiConfiguration.h|   10 +-
>  MdePkg/Include/Protocol/SpiHc.h   |   16 +-
>  MdePkg/Include/Protocol/SpiIo.h   |   12 +-
>  .../Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c| 1141 +++
>  .../SpiNorFlashJedecSfdp.c| 1780
> +
>  .../SpiNorFlashJedecSfdpDxe.c |  261 +++
>  .../SpiNorFlashJedecSfdpSmm.c |  234 +++
>  Maintainers.txt   |   11 +
>  .../SpiNorFlashJedecSfdpDxe.uni   |   13 +
>  .../SpiNorFlashJedecSfdpExtra.uni |   11 +
>  .../SpiNorFlashJedecSfdpSmm.uni   |   13 +
>  18 files changed, 4566 insertions(+), 5 deletions(-)
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.inf
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.in
> f
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.h
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpInternal
> .h
>  create mode 100644
> MdePkg/Include/IndustryStandard/SpiNorFlashJedecSfdp.h
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.c
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.c
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpDxe.uni
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpExtra.u
> ni
>  create mode 100644
> MdeModulePkg/Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdpSmm.u
> ni
> 
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117531): https://edk2.groups.io/g/devel/message/117531
Mute This Topic: https://groups.io/mt/105417086/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

[gaoliming via groups.io]

Taylor:
  Thanks for you detail information. I understand this problem. I agree your 
fix. Reviewed-by: Liming Gao 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Taylor Beebe
> 发送时间: 2024年3月29日 8:28
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' ; 'Bob Feng'
> ; 'Yuwei Chen' 
> 主题: Re: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include
> and Library Matching
> 
> Hi Liming,
> 
> Each patch describes the issue being fixed with an example.
> 
> I created a bugzilla and assigned it to me for Patch 1:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4744
> 
> GitHub PR: https://github.com/tianocore/edk2/pull/5365
> 
> Thanks :)
> 
> -Taylor
> 
> On 3/27/24 6:00 PM, gaoliming wrote:
> > Can you submit a Bugzilla for this problem?
> >
> > Can you give one example to explain the incorrect usage?
> >
> > Thanks
> > Liming
> >> -邮件原件-
> >> 发件人: devel@edk2.groups.io  代表 Taylor
> Beebe
> >> 发送时间: 2024年3月23日 3:19
> >> 收件人: devel@edk2.groups.io
> >> 抄送: Rebecca Cran ; Liming Gao
> >> ; Bob Feng ; Yuwei
> Chen
> >> 
> >> 主题: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and
> >> Library Matching
> >>
> >> v1:
> >>- Initial patch series
> >> v2:
> >>- Simplified the check for if the currently evaluated inf is a module or
> >> library.
> >>- Added a commit to use stronger matching of NULL includes (check
> for
> >> pattern "NULL")
> >>
> >> Cc: Rebecca Cran 
> >> Cc: Liming Gao 
> >> Cc: Bob Feng 
> >> Cc: Yuwei Chen 
> >>
> >> Taylor Beebe (2):
> >>BaseTools: Don't Recurse NULL Includes Not Linked to Module
> >>BaseTools: Use Stronger Matching for NULL Linked Libraries
> >>
> >>   BaseTools/Source/Python/GenFds/FfsInfStatement.py| 4 ++--
> >>   BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 8
> +---
> >>   2 files changed, 7 insertions(+), 5 deletions(-)
> >>
> >> --
> >> 2.40.1.vfs.0.0
> >>
> >>
> >>
> >>
> >>
> >
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117304): https://edk2.groups.io/g/devel/message/117304
Mute This Topic: https://groups.io/mt/105280288/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

[gaoliming via groups.io]

Aaron:
  Per the specification, it is valid to publish all ACPI table in
EfiAcpiMemoryNVS. 
  So, I have no other comments for this patch. Reviewed-by: Liming Gao


Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Aaron Li
> 发送时间: 2024年4月1日 10:32
> 收件人: devel@edk2.groups.io; Liming Gao 
> 抄送: Bi, Dandan ; Liu, Yun Y ;
> Yao, Jiewen ; Ni, Ray ; Kinney,
> Michael D ; Liu, Zhiguang
> 
> 主题: Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD
> switch to avoid using ACPI reclaim memory
> 
> Hi Liming,
> 
> Could you please help review and merge it? Thanks.
> 
> Best,
> Aaron
> 
> -Original Message-
> From: Liu, Zhiguang 
> Sent: Monday, April 1, 2024 10:06 AM
> To: Li, Aaron ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Liming Gao
> ; Liu, Yun Y ; Yao, Jiewen
> ; Ni, Ray ; Kinney, Michael D
> 
> Subject: RE: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to
> avoid using ACPI reclaim memory
> 
> Reviewed-by: Zhiguang Liu 
> 
> > -Original Message-
> > From: Li, Aaron 
> > Sent: Tuesday, March 26, 2024 3:58 PM
> > To: devel@edk2.groups.io
> > Cc: Liu, Zhiguang ; Bi, Dandan
> > ; Liming Gao ; Liu, Yun
> Y
> > ; Yao, Jiewen ; Ni, Ray
> > ; Kinney, Michael D 
> > Subject: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid
> > using ACPI reclaim memory
> >
> > UEFI spec defined ACPI Tables at boot time can be contained in memory of
> > type EfiACPIReclaimMemory or EfiAcpiMemoryNVS, although
> InstallAcpiTable
> > with AcpiTableProtocol will only allocate memory with type
> > EfiACPIReclaimMemory (Except FACS).
> >
> > This patch provides an optional method controlled by PCD to avoid using
> > EfiACPIReclaimMemory, by setting the PCD PcdNoACPIReclaimMemory to
> > TRUE, all ACPI allocated memory will use EfiAcpiMemoryNVS instead.
> >
> > Cc: Zhiguang Liu 
> > Cc: Dandan Bi 
> > Cc: Liming Gao 
> > Cc: Liu Yun 
> > Cc: Jiewen Yao 
> > Cc: Ray Ni 
> > Cc: Michael D Kinney 
> > Signed-off-by: Aaron Li 
> > ---
> >  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 37
> > +++-
> >  MdeModulePkg/MdeModulePkg.dec
> |  7 
> >  MdeModulePkg/MdeModulePkg.uni
> |  8 +
> >  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf|  1
> +
> >  4 files changed, 45 insertions(+), 8 deletions(-)
> >
> > diff --git
> a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > index e09bc9b704f5..080768033cfa 100644
> > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> > @@ -340,6 +340,7 @@ ReallocateAcpiTableBuffer (
> >EFI_ACPI_TABLE_INSTANCE  TempPrivateData;
> >EFI_STATUS   Status;
> >UINT64   CurrentData;
> > +  EFI_MEMORY_TYPE  AcpiAllocateMemoryType;
> >
> >CopyMem (, AcpiTableInstance, sizeof
> > (EFI_ACPI_TABLE_INSTANCE));
> >//
> > @@ -359,6 +360,12 @@ ReallocateAcpiTableBuffer (
> >   NewMaxTableNumber * sizeof (UINT32);
> >}
> >
> > +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> > +AcpiAllocateMemoryType = EfiACPIMemoryNVS;  } else {
> > +AcpiAllocateMemoryType = EfiACPIReclaimMemory;  }
> > +
> >if (mAcpiTableAllocType != AllocateAnyPages) {
> >  //
> >  // Allocate memory in the lower 32 bit of address range for @@
> -372,13
> > +379,13 @@ ReallocateAcpiTableBuffer (
> >  PageAddress = 0x;
> >  Status  = gBS->AllocatePages (
> >   mAcpiTableAllocType,
> > - EfiACPIReclaimMemory,
> > + AcpiAllocateMemoryType,
> >   EFI_SIZE_TO_PAGES (TotalSize),
> >   
> >   );
> >} else {
> >  Status = gBS->AllocatePool (
> > -EfiACPIReclaimMemory,
> > +AcpiAllocateMemoryType,
> >  TotalSize,
> >  (VOID **)
> >  );
> > @@ -512,6 +519,7 @@ AddTableToList (
> >EFI_PHYSICAL_ADDRESS  AllocPhysAddress;
> >UINT64Buffer64;
> >BOOLEAN   AddToRsdt;
> > +  EFI_MEMORY_TYPE   AcpiAllocateMemoryType;
> >
> >//
> >// Check for invalid input parameters @@ -550,6 +558,12 @@
> > AddTableToList (
> >CurrentTableList->TableSize  = CurrentTableSize;
> >CurrentTableList->PoolAllocation = FALSE;
> >
> > +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> > +AcpiAllocateMemoryType = EfiACPIMemoryNVS;  } else {
> > +AcpiAllocateMemoryType = EfiACPIReclaimMemory;  }
> > +
> >//
> >// Allocation memory type depends on the type of the table
> >//
> > @@ -585,7 +599,7 @@ AddTableToList (
> >  // such as AArch64 that allocate multiples of 64 KB
> >  //
> >  Status = gBS->AllocatePool (
> > -EfiACPIReclaimMemory,
> > +

回复: [edk2-devel] [Patch V4] BaseTools: VfrCompiler Adds DefaultValueError

[gaoliming via groups.io]

Zifang and Yuting:
  The change looks good. But, there are two ways for error report. One is
gCVfrErrorHandle.HandleWarning, another is DefaultValueError. Can we always
use gCVfrErrorHandle.HandleWarning?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Zhang, Zifeng
> 发送时间: 2024年3月28日 15:29
> 收件人: Yang, Yuting2 ; devel@edk2.groups.io;
> gaoliming 
> 抄送: Chen, Christine ; Feng, Bob C
> ; He, Haiyang 
> 主题: Re: [edk2-devel] [Patch V4] BaseTools: VfrCompiler Adds
> DefaultValueError
> 
> Thanks Yuting for patch update!
> 
> Hi @gaoliming,
> Would you like to review the V4 patch?
> Hope to merge it asap to avoid blocking feature complete.
> 
> Best Regards,
> Zifeng
> 
> -Original Message-
> From: Yang, Yuting2 
> Sent: Thursday, March 21, 2024 3:54 PM
> To: devel@edk2.groups.io; gaoliming 
> Cc: Chen, Christine ; Zhang, Zifeng
> ; Feng, Bob C ; He, Haiyang
> 
> Subject: RE: [edk2-devel] [Patch V4] BaseTools: VfrCompiler Adds
> DefaultValueError
> 
> Hi liming,
> 
> Gentle reminder, we have removed the whitespace. Please help review the
> patch~
> 
> Thanks,
> Yuting
> 
> -Original Message-
> From: devel@edk2.groups.io  On Behalf Of Yuting
> Yang
> Sent: Thursday, March 21, 2024 3:30 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ; Chen,
> Christine ; Zhang, Zifeng 
> Subject: [edk2-devel] [Patch V4] BaseTools: VfrCompiler Adds
> DefaultValueError
> 
> Add --catch_default option
> Raise a DefaultValueError when encountering VFR default definitions to
help
> remove default variables.
> 
> Signed-off-by: Yuting Yang 
> 
> Cc: Rebecca Cran 
> Cc: Liming Gao 
> Cc: Bob Feng 
> Cc: Christine Chen 
> Cc: Zifeng Zhang 
> ---
>  BaseTools/Source/C/VfrCompile/VfrCompiler.cpp |  8 
>  BaseTools/Source/C/VfrCompile/VfrCompiler.h   |  1 +
>  BaseTools/Source/C/VfrCompile/VfrError.cpp|  3 ++-
>  BaseTools/Source/C/VfrCompile/VfrError.h  |  3 ++-
>  BaseTools/Source/C/VfrCompile/VfrFormPkg.h|  1 +
>  BaseTools/Source/C/VfrCompile/VfrSyntax.g | 58
> ++
>  6 files changed, 60 insertions(+), 14 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VfrCompile/VfrCompiler.cpp
> b/BaseTools/Source/C/VfrCompile/VfrCompiler.cpp
> index 5f4d262d85..4031af6e39 100644
> --- a/BaseTools/Source/C/VfrCompile/VfrCompiler.cpp
> +++ b/BaseTools/Source/C/VfrCompile/VfrCompiler.cpp
> @@ -78,6 +78,7 @@ CVfrCompiler::OptionInitialization (
>mOptions.WarningAsError= FALSE;
> mOptions.AutoDefault   = FALSE;
> mOptions.CheckDefault  = FALSE;+
> mOptions.IsCatchDefaultEnable  = FALSE;   memset
> (, 0, sizeof (EFI_GUID));if (Argc == 1) {@@
> -95,6 +96,8 @@ CVfrCompiler::OptionInitialization (
>Version ();   SET_RUN_STATUS (STATUS_DEAD);
> return;+} else if (stricmp(Argv[Index], "--catch_default") == 0){+
> mOptions.IsCatchDefaultEnable = TRUE; } else if (stricmp(Argv[Index],
> "-l") == 0) {   mOptions.CreateRecordListFile = TRUE;
> gCIfrRecordInfoDB.TurnOn ();@@ -179,7 +182,6 @@
> CVfrCompiler::OptionInitialization (
>goto Fail; } strcpy (mOptions.VfrFileName, Argv[Index]);-
> if (mOptions.OutputDirectory == NULL) {   mOptions.OutputDirectory =
> (CHAR8 *) malloc (1);   if (mOptions.OutputDirectory == NULL) {@@
> -679,7 +681,7 @@ CVfrCompiler::Compile (
>  DebugError (NULL, 0, 0001, "Error opening the input file", "%s",
> InFileName); goto Fail;   }-+  InputInfo.IsCatchDefaultEnable =
> mOptions.IsCatchDefaultEnable;   if (mOptions.HasOverrideClassGuid)
> { InputInfo.OverrideClassGuid =} else
> {@@ -937,5 +939,3 @@ main (
> return GetUtilityStatus (); }--diff --git
> a/BaseTools/Source/C/VfrCompile/VfrCompiler.h
> b/BaseTools/Source/C/VfrCompile/VfrCompiler.h
> index b6e207d2ce..974f37c4eb 100644
> --- a/BaseTools/Source/C/VfrCompile/VfrCompiler.h
> +++ b/BaseTools/Source/C/VfrCompile/VfrCompiler.h
> @@ -52,6 +52,7 @@ typedef struct {
>BOOLEAN WarningAsError;   BOOLEAN AutoDefault;   BOOLEAN
> CheckDefault;+  BOOLEAN IsCatchDefaultEnable; } OPTIONS;  typedef
> enum {diff --git a/BaseTools/Source/C/VfrCompile/VfrError.cpp
> b/BaseTools/Source/C/VfrCompile/VfrError.cpp
> index 65bb8e34fd..8a706f929b 100644
> --- a/BaseTools/Source/C/VfrCompile/VfrError.cpp
> +++ b/BaseTools/Source/C/VfrCompile/VfrError.cpp
> @@ -49,7 +49,8 @@ static SVFR_WARNING_HANDLE
> VFR_WARNING_HANDLE_TABLE [] = {
>{ VFR_WARNING_DEFAULT_VALUE_REDEFINED, ": default value
> re-defined with different value"},
> { VFR_WARNING_ACTION_WITH_TEXT_TWO, ": Action opcode should not
> have TextTwo part"},
> { VFR_WARNING_OBSOLETED_FRAMEWORK_OPCODE, ": Not recommend to
> use obsoleted framework opcode"},-  { VFR_WARNING_CODEUNDEFINED, ":
> undefined Warning Code" }+  { VFR_WARNING_CODEUNDEFINED, ":
> undefined Warning Code" },+  { VFR_WARNING_UNSUPPORTED, ": pls
> remove the default values if necessary" } };
> 

[edk2-devel] 回复: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

[gaoliming via groups.io]

Aaron:
 Is there a Bugzilla for this issue? What problem will be resolved with this
change? 

Thanks
Liming
> -邮件原件-
> 发件人: Aaron Li 
> 发送时间: 2024年3月26日 15:58
> 收件人: devel@edk2.groups.io
> 抄送: Zhiguang Liu ; Dandan Bi
> ; Liming Gao ; Liu Yun
> ; Jiewen Yao ; Ray Ni
> ; Michael D Kinney 
> 主题: [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid
> using ACPI reclaim memory
> 
> UEFI spec defined ACPI Tables at boot time can be contained in memory of
> type EfiACPIReclaimMemory or EfiAcpiMemoryNVS, although InstallAcpiTable
> with AcpiTableProtocol will only allocate memory with type
> EfiACPIReclaimMemory (Except FACS).
> 
> This patch provides an optional method controlled by PCD to avoid using
> EfiACPIReclaimMemory, by setting the PCD PcdNoACPIReclaimMemory to
> TRUE,
> all ACPI allocated memory will use EfiAcpiMemoryNVS instead.
> 
> Cc: Zhiguang Liu 
> Cc: Dandan Bi 
> Cc: Liming Gao 
> Cc: Liu Yun 
> Cc: Jiewen Yao 
> Cc: Ray Ni 
> Cc: Michael D Kinney 
> Signed-off-by: Aaron Li 
> ---
>  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 37
> +++-
>  MdeModulePkg/MdeModulePkg.dec
> |  7 
>  MdeModulePkg/MdeModulePkg.uni
> |  8 +
>  MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf|  1 +
>  4 files changed, 45 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> index e09bc9b704f5..080768033cfa 100644
> --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c
> @@ -340,6 +340,7 @@ ReallocateAcpiTableBuffer (
>EFI_ACPI_TABLE_INSTANCE  TempPrivateData;
>EFI_STATUS   Status;
>UINT64   CurrentData;
> +  EFI_MEMORY_TYPE  AcpiAllocateMemoryType;
> 
>CopyMem (, AcpiTableInstance, sizeof
> (EFI_ACPI_TABLE_INSTANCE));
>//
> @@ -359,6 +360,12 @@ ReallocateAcpiTableBuffer (
>   NewMaxTableNumber * sizeof (UINT32);
>}
> 
> +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> +AcpiAllocateMemoryType = EfiACPIMemoryNVS;
> +  } else {
> +AcpiAllocateMemoryType = EfiACPIReclaimMemory;
> +  }
> +
>if (mAcpiTableAllocType != AllocateAnyPages) {
>  //
>  // Allocate memory in the lower 32 bit of address range for
> @@ -372,13 +379,13 @@ ReallocateAcpiTableBuffer (
>  PageAddress = 0x;
>  Status  = gBS->AllocatePages (
>   mAcpiTableAllocType,
> - EfiACPIReclaimMemory,
> + AcpiAllocateMemoryType,
>   EFI_SIZE_TO_PAGES (TotalSize),
>   
>   );
>} else {
>  Status = gBS->AllocatePool (
> -EfiACPIReclaimMemory,
> +AcpiAllocateMemoryType,
>  TotalSize,
>  (VOID **)
>  );
> @@ -512,6 +519,7 @@ AddTableToList (
>EFI_PHYSICAL_ADDRESS  AllocPhysAddress;
>UINT64Buffer64;
>BOOLEAN   AddToRsdt;
> +  EFI_MEMORY_TYPE   AcpiAllocateMemoryType;
> 
>//
>// Check for invalid input parameters
> @@ -550,6 +558,12 @@ AddTableToList (
>CurrentTableList->TableSize  = CurrentTableSize;
>CurrentTableList->PoolAllocation = FALSE;
> 
> +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> +AcpiAllocateMemoryType = EfiACPIMemoryNVS;
> +  } else {
> +AcpiAllocateMemoryType = EfiACPIReclaimMemory;
> +  }
> +
>//
>// Allocation memory type depends on the type of the table
>//
> @@ -585,7 +599,7 @@ AddTableToList (
>  // such as AArch64 that allocate multiples of 64 KB
>  //
>  Status = gBS->AllocatePool (
> -EfiACPIReclaimMemory,
> +AcpiAllocateMemoryType,
>  CurrentTableList->TableSize,
>  (VOID **)>Table
>  );
> @@ -596,7 +610,7 @@ AddTableToList (
>  //
>  Status = gBS->AllocatePages (
>  mAcpiTableAllocType,
> -EfiACPIReclaimMemory,
> +AcpiAllocateMemoryType,
>  EFI_SIZE_TO_PAGES (CurrentTableList->TableSize),
>  
>  );
> @@ -1944,6 +1958,7 @@ AcpiTableAcpiTableConstructor (
>UINTN RsdpTableSize;
>UINT8 *Pointer;
>EFI_PHYSICAL_ADDRESS  PageAddress;
> +  EFI_MEMORY_TYPE   AcpiAllocateMemoryType;
> 
>//
>// Check for invalid input parameters
> @@ -1978,17 +1993,23 @@ AcpiTableAcpiTableConstructor (
>  RsdpTableSize += sizeof
> (EFI_ACPI_1_0_ROOT_SYSTEM_DESCRIPTION_POINTER);
>}
> 
> +  if (PcdGetBool (PcdNoACPIReclaimMemory)) {
> +AcpiAllocateMemoryType = EfiACPIMemoryNVS;
> +  } else {
> +AcpiAllocateMemoryType = EfiACPIReclaimMemory;
> +  }
> +

回复: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Increase 1ms extra delay for xHCI issue HCRST

[gaoliming via groups.io]

Seemly, this change has no other impact. I agree this change. 

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Chiu, Ian
> 发送时间: 2024年3月14日 21:40
> 收件人: devel@edk2.groups.io
> 抄送: Ian Chiu ; Hao A Wu ; Ray
> Ni ; More Shih 
> 主题: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Increase 1ms extra
> delay for xHCI issue HCRST
> 
> From: Ian Chiu 
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=4727
> 
> More and more XHCI host controllers require to have extra 1ms
> delay before accessing any MMIO register during reset.
> 
> Since PHY transition from P3 to P0 can take around 1.3ms and
> the xHCI reset can take around 1.5ms.
> 
> Hence, need delay increase between issuing HCRST on xHCI
> controller till first MMIO read for reset completion check.
> 
> Cc: Hao A Wu 
> Cc: Ray Ni   
> Cc: More Shih
> Signed-off-by: Ian Chiu 
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> index 40f2f1f227..eafe4b0d11 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c
> @@ -861,10 +861,11 @@ XhcResetHC (
>  XhcSetOpRegBit (Xhc, XHC_USBCMD_OFFSET, XHC_USBCMD_RESET);
> 
>  //
> 
>  // Some XHCI host controllers require to have extra 1ms delay before
> accessing any MMIO register during reset.
> 
> +// PHY transition from P3 to P0 can take around 1.3ms and the xHCI
> reset can take around 1.5ms.
> 
>  // Otherwise there may have the timeout case happened.
> 
> -// The below is a workaround to solve such problem.
> 
> +// Stall for 2ms workaround to solve such problem.
> 
>  //
> 
> -gBS->Stall (XHC_1_MILLISECOND);
> 
> +gBS->Stall (XHC_1_MILLISECOND*2);
> 
>  Status = XhcWaitOpRegBit (Xhc, XHC_USBCMD_OFFSET,
> XHC_USBCMD_RESET, FALSE, Timeout);
> 
> 
> 
>  if (!EFI_ERROR (Status)) {
> 
> --
> 2.38.1.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#116751):
> https://edk2.groups.io/g/devel/message/116751
> Mute This Topic: https://groups.io/mt/104926466/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117187): https://edk2.groups.io/g/devel/message/117187
Mute This Topic: https://groups.io/mt/105189543/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo description details

[gaoliming via groups.io]

Madhan:
  I have no comments for this patch set. Reviewed-by: Liming Gao

  
  Have you create Edk2 PR to verify the changes?

Thanks
Liming
> -邮件原件-
> 发件人: Pethaiyan, Madhan 
> 发送时间: 2024年3月14日 16:17
> 收件人: Kinney, Michael D ;
> devel@edk2.groups.io
> 抄送: Liming Gao ; Liu, Zhiguang
> ; Li, Yi1 ; GuoX Xu
> 
> 主题: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage , GetImageInfo
> description details
> 
> Hi Mike ,
> 
> I had raised new code review addressing the coding standard errors and
those
> were not part of my change any way ..
> 
> Thanks,
> P. Madhan
> 
> -Original Message-
> From: Kinney, Michael D 
> Sent: Sunday, March 10, 2024 1:47 AM
> To: devel@edk2.groups.io; Pethaiyan, Madhan
> 
> Cc: Liming Gao ; Liu, Zhiguang
> ; Li, Yi1 ; GuoX Xu
> ; Kinney, Michael D 
> Subject: RE: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,
> GetImageInfo description details
> 
> Hi Madhan,
> 
> I created a PR with all 3 related patches to run through EDK II CI.
> 
> https://github.com/tianocore/edk2/pull/5453
> 
> There are CI failures.  Please resolve and send updated patches.
> 
> Thanks,
> 
> Mike
> 
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of
> > Pethaiyan Madhan
> > Sent: Friday, March 8, 2024 3:17 PM
> > To: devel@edk2.groups.io
> > Cc: Pethaiyan, Madhan ; Kinney, Michael D
> > ; Liming Gao ;
> > Liu, Zhiguang ; Li, Yi1 ;
> > GuoX Xu 
> > Subject: [edk2-devel] [PATCH V1] MdePkg: Update GetImage ,
> > GetImageInfo description details
> >
> > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
> > Add the following sentence at the end of the Image parameter
> > description. "May be NULL with a zero ImageSize in order to determine
> > the size of the buffer needed".
> >
> > Modify the description of "EFI_INVALID_PARAMETER" return code as "The
> > ImageSize is not too small and Image is NULL."
> >
> > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo():
> > Add the following sentence at the end of the ImageInfo parameter
> > description."May be NULL with a zero ImageInfoSize in order to
> > determine the size of the buffer needed".
> >
> > Modify the description of "EFI_INVALID_PARAMETER" return code as "The
> > ImageInfoSize is not too small and Image is NULL." and add new
> > descriptions for "EFI_INVALID_PARAMETER" return code.
> >
> >  REF: UEFI spec v2.10 23.1.2
> >  REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660
> >
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Yi Li 
> > Cc: GuoX Xu 
> > Signed-off-by: Pethaiyan Madhan 
> > ---
> >  MdePkg/Include/Protocol/FirmwareManagement.h | 14 --
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h
> > b/MdePkg/Include/Protocol/FirmwareManagement.h
> > index e535bb697d..90b7d83c8f 100644
> > --- a/MdePkg/Include/Protocol/FirmwareManagement.h
> > +++ b/MdePkg/Include/Protocol/FirmwareManagement.h
> > @@ -294,6 +294,8 @@ EFI_STATUS
> >   to contain the image(s)
> > information if the buffer was too small.
> >@param[in, out] ImageInfo  A pointer to the buffer in which
> > firmware places the current image(s)
> >   information. The
> information is
> > an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs.
> > + May be NULL with a zero
> > ImageInfoSize in order to determine the size of the
> > + buffer needed.
> >@param[out] DescriptorVersion  A pointer to the location in
> > which firmware returns the version number
> >   associated with the
> > EFI_FIRMWARE_IMAGE_DESCRIPTOR.
> >@param[out] DescriptorCountA pointer to the location in
> > which firmware returns the number of
> > @@ -314,7 +316,12 @@ EFI_STATUS
> >@retval EFI_SUCCESSThe device was successfully
> > updated with the new image.
> >@retval EFI_BUFFER_TOO_SMALL   The ImageInfo buffer was
> too
> > small. The current buffer size
> >   needed to hold the image(s)
> > information is returned in ImageInfoSize.
> > -  @retval EFI_INVALID_PARAMETER  ImageInfoSize is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is not too small
> > and ImageInfo is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is non-zero and
> > DescriptorVersion is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is non-zero and
> > DescriptorCount is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is non-zero and
> > DescriptorSize is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is non-zero and
> > PackageVersion is NULL.
> > +  @retval EFI_INVALID_PARAMETER  ImageInfoSize is non-zero and
> > PackageVersionName is NULL.
> >@retval EFI_DEVICE_ERROR   Valid information could not
> be
> > returned. Possible corrupted image.

[edk2-devel] 回复: [PATCH v3 1/2] MdePkg: Add UEFI 2.10 DeviceAuthentication

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: Wenxing Hou 
> 发送时间: 2024年3月27日 14:16
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao 
> 主题: [PATCH v3 1/2] MdePkg: Add UEFI 2.10 DeviceAuthentication
> 
> According to UEFI 2.10 spec
> 32.8.2 UEFI Device Signature Variable GUID and Variable Name section,
> add signature database for device authentication.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jiewen Yao 
> Signed-off-by: Wenxing Hou 
> ---
>  MdePkg/Include/Guid/DeviceAuthentication.h | 61
> ++
>  1 file changed, 61 insertions(+)
>  create mode 100644 MdePkg/Include/Guid/DeviceAuthentication.h
> 
> diff --git a/MdePkg/Include/Guid/DeviceAuthentication.h
> b/MdePkg/Include/Guid/DeviceAuthentication.h
> new file mode 100644
> index 00..0dd933dfa5
> --- /dev/null
> +++ b/MdePkg/Include/Guid/DeviceAuthentication.h
> @@ -0,0 +1,61 @@
> +/** @file
> 
> +  Guid & data structure used for Device Security.
> 
> +
> 
> +  Copyright (c) 2024, Intel Corporation. All rights reserved.
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +
> 
> +**/
> 
> +
> 
> +#ifndef EFI_DEVICE_AUTHENTICATION_GUID_H_
> 
> +#define EFI_DEVICE_AUTHENTICATION_GUID_H_
> 
> +
> 
> +/**
> 
> +  This is a signature database for device authentication, instead of
image
> authentication.
> 
> +
> 
> +  The content of the signature database is same as the one in db/dbx. (a
list
> of EFI_SIGNATURE_LIST)
> 
> +**/
> 
> +#define EFI_DEVICE_SIGNATURE_DATABASE_GUID \
> 
> +  {0xb9c2b4f4, 0xbf5f, 0x462d, 0x8a, 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d,
0xad}
> 
> +#define EFI_DEVICE_SECURITY_DATABASE  L"devdb"
> 
> +
> 
> +extern EFI_GUID  gEfiDeviceSignatureDatabaseGuid;
> 
> +
> 
> +/**
> 
> +  Signature Database:
> 
> +
> 
> +  +---+ <-
> 
> +  | SignatureType (GUID)  |  |
> 
> +  +---+  |
> 
> +  | SignatureListSize (UINT32)|  |
> 
> +  +---+  |
> 
> +  | SignatureHeaderSize (UINT32)  |  |
> 
> +  +---+  |
> 
> +  | SignatureSize (UINT32)|
> |-EFI_SIGNATURE_LIST (1)
> 
> +  +---+  |
> 
> +  | SignatureHeader (SignatureHeaderSize) |  |
> 
> +  +---+ <--  |
> 
> +  | SignatureOwner (GUID) |   |  |
> 
> +  +---+   |-EFI_SIGNATURE_DATA (1)
> 
> +  | SignatureData (SignatureSize - 16)|   |  |
> 
> +  +---+ <--  |
> 
> +  | SignatureOwner (GUID) |   |  |
> 
> +  +---+   |-EFI_SIGNATURE_DATA (n)
> 
> +  | SignatureData (SignatureSize - 16)|   |  |
> 
> +  +---+ <-
> 
> +  | SignatureType (GUID)  |  |
> 
> +  +---+  |
> 
> +  | SignatureListSize (UINT32)|
> |-EFI_SIGNATURE_LIST (n)
> 
> +  +---+  |
> 
> +  | ...   |  |
> 
> +  +---+ <-
> 
> +
> 
> +  SignatureType := EFI_CERT_SHAxxx_GUID |
> 
> +   EFI_CERT_RSA2048_GUID |
> 
> +   EFI_CERT_RSA2048_SHAxxx_GUID |
> 
> +   EFI_CERT_X509_GUID |
> 
> +   EFI_CERT_X509_SHAxxx_GUID
> 
> +  (xxx = 256, 384, 512)
> 
> +
> 
> +**/
> 
> +
> 
> +#endif
> 
> --
> 2.26.2.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117185): https://edk2.groups.io/g/devel/message/117185
Mute This Topic: https://groups.io/mt/105189414/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

[gaoliming via groups.io]

Can you submit a Bugzilla for this problem? 

Can you give one example to explain the incorrect usage?

Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Taylor Beebe
> 发送时间: 2024年3月23日 3:19
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran ; Liming Gao
> ; Bob Feng ; Yuwei Chen
> 
> 主题: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and
> Library Matching
> 
> v1:
>   - Initial patch series
> v2:
>   - Simplified the check for if the currently evaluated inf is a module or
> library.
>   - Added a commit to use stronger matching of NULL includes (check for
> pattern "NULL")
> 
> Cc: Rebecca Cran 
> Cc: Liming Gao 
> Cc: Bob Feng 
> Cc: Yuwei Chen 
> 
> Taylor Beebe (2):
>   BaseTools: Don't Recurse NULL Includes Not Linked to Module
>   BaseTools: Use Stronger Matching for NULL Linked Libraries
> 
>  BaseTools/Source/Python/GenFds/FfsInfStatement.py| 4 ++--
>  BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 8 +---
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> --
> 2.40.1.vfs.0.0
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117184): https://edk2.groups.io/g/devel/message/117184
Mute This Topic: https://groups.io/mt/105189358/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 2/2] MdePkg: Add gEfiDeviceSignatureDatabaseGuid to dec

[gaoliming via groups.io]

Reviewed-by: Liming Gao 

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Wenxing Hou
> 发送时间: 2024年3月6日 11:24
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao 
> 主题: [edk2-devel] [PATCH v2 2/2] MdePkg: Add
> gEfiDeviceSignatureDatabaseGuid to dec
> 
> According to UEFI 2.10 spec
> 32.8.2 UEFI Device Signature Variable GUID and Variable Name section,
> add gEfiDeviceSignatureDatabaseGuid to dec.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jiewen Yao 
> Signed-off-by: Wenxing Hou 
> ---
>  MdePkg/MdePkg.dec | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 0459418906..0c18e1decd 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -4,7 +4,7 @@
>  # It also provides the definitions(including PPIs/PROTOCOLs/GUIDs) of
> 
>  # EFI1.10/UEFI2.7/PI1.7 and some Industry Standards.
> 
>  #
> 
> -# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.
> 
> +# Copyright (c) 2007 - 2024, Intel Corporation. All rights reserved.
> 
>  # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> 
>  # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development
> LP
> 
>  # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights
> reserved.
> 
> @@ -740,6 +740,12 @@
>## Include/Protocol/SerilaIo.h
> 
>gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C,
> { 0x8A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }}
> 
> 
> 
> +  # GUIDs defined in UEFI2.10
> 
> +  #
> 
> +  ## GUID used to specify section with devdb content
> 
> +  ## Include/Guid/DeviceAuthentication.h
> 
> +  gEfiDeviceSignatureDatabaseGuid  = { 0xb9c2b4f4, 0xbf5f, 0x462d, {0x8a,
> 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d, 0xad }}
> 
> +
> 
>#
> 
># GUID defined in PI1.0
> 
>#
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#116416):
> https://edk2.groups.io/g/devel/message/116416
> Mute This Topic: https://groups.io/mt/104760006/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117026): https://edk2.groups.io/g/devel/message/117026
Mute This Topic: https://groups.io/mt/105079886/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 1/2] MdePkg: Add UEFI 2.10 DeviceAuthentication

[gaoliming via groups.io]

Wenxing:

> -邮件原件-
> 发件人: devel@edk2.groups.io  代表 Wenxing Hou
> 发送时间: 2024年3月6日 11:24
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao 
> 主题: [edk2-devel] [PATCH v2 1/2] MdePkg: Add UEFI 2.10
> DeviceAuthentication
> 
> According to UEFI 2.10 spec
> 32.8.2 UEFI Device Signature Variable GUID and Variable Name section,
> add signature database for device authentication.
> 
> Cc: Michael D Kinney 
> Cc: Liming Gao 
> Cc: Zhiguang Liu 
> Cc: Jiewen Yao 
> Signed-off-by: Wenxing Hou 
> ---
>  MdePkg/Include/Guid/DeviceAuthentication.h | 61
> ++
>  1 file changed, 61 insertions(+)
>  create mode 100644 MdePkg/Include/Guid/DeviceAuthentication.h
> 
> diff --git a/MdePkg/Include/Guid/DeviceAuthentication.h
> b/MdePkg/Include/Guid/DeviceAuthentication.h
> new file mode 100644
> index 00..65dea4273d
> --- /dev/null
> +++ b/MdePkg/Include/Guid/DeviceAuthentication.h
> @@ -0,0 +1,61 @@
> +/** @file
> 
> +  Guid & data structure used for Device Security.
> 
> +
> 
> +  Copyright (c) 2024, Intel Corporation. All rights reserved.
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +
> 
> +**/
> 
> +
> 
> +#ifndef EDKII_DEVICE_AUTHENTICATION_GUID_H_
> 
Here can use EFI_ prefix, because this definition is from UEFI spec. 

Thanks
Liming
> +#define EDKII_DEVICE_AUTHENTICATION_GUID_H_
> 
> +
> 
> +/**
> 
> +  This is a signature database for device authentication, instead of
image
> authentication.
> 
> +
> 
> +  The content of the signature database is same as the one in db/dbx. (a
list
> of EFI_SIGNATURE_LIST)
> 
> +**/
> 
> +#define EFI_DEVICE_SIGNATURE_DATABASE_GUID \
> 
> +  {0xb9c2b4f4, 0xbf5f, 0x462d, 0x8a, 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d,
0xad}
> 
> +#define EFI_DEVICE_SECURITY_DATABASE  L"devdb"
> 
> +
> 
> +extern EFI_GUID  gEfiDeviceSignatureDatabaseGuid;
> 
> +
> 
> +/**
> 
> +  Signature Database:
> 
> +
> 
> +  +---+ <-
> 
> +  | SignatureType (GUID)  |  |
> 
> +  +---+  |
> 
> +  | SignatureListSize (UINT32)|  |
> 
> +  +---+  |
> 
> +  | SignatureHeaderSize (UINT32)  |  |
> 
> +  +---+  |
> 
> +  | SignatureSize (UINT32)|
> |-EFI_SIGNATURE_LIST (1)
> 
> +  +---+  |
> 
> +  | SignatureHeader (SignatureHeaderSize) |  |
> 
> +  +---+ <--  |
> 
> +  | SignatureOwner (GUID) |   |  |
> 
> +  +---+   |-EFI_SIGNATURE_DATA (1)
> 
> +  | SignatureData (SignatureSize - 16)|   |  |
> 
> +  +---+ <--  |
> 
> +  | SignatureOwner (GUID) |   |  |
> 
> +  +---+   |-EFI_SIGNATURE_DATA (n)
> 
> +  | SignatureData (SignatureSize - 16)|   |  |
> 
> +  +---+ <-
> 
> +  | SignatureType (GUID)  |  |
> 
> +  +---+  |
> 
> +  | SignatureListSize (UINT32)|
> |-EFI_SIGNATURE_LIST (n)
> 
> +  +---+  |
> 
> +  | ...   |  |
> 
> +  +---+ <-
> 
> +
> 
> +  SignatureType := EFI_CERT_SHAxxx_GUID |
> 
> +   EFI_CERT_RSA2048_GUID |
> 
> +   EFI_CERT_RSA2048_SHAxxx_GUID |
> 
> +   EFI_CERT_X509_GUID |
> 
> +   EFI_CERT_X509_SHAxxx_GUID
> 
> +  (xxx = 256, 384, 512)
> 
> +
> 
> +**/
> 
> +
> 
> +#endif
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#116415):
> https://edk2.groups.io/g/devel/message/116415
> Mute This Topic: https://groups.io/mt/104760005/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117025): https://edk2.groups.io/g/devel/message/117025
Mute This Topic: https://groups.io/mt/105079881/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues

[gaoliming via groups.io]

For this patch set, I have no comments. Reviewed-by: Liming Gao 


> -邮件原件-
> 发件人: Oliver Smith-Denny 
> 发送时间: 2024年3月10日 3:06
> 收件人: devel@edk2.groups.io
> 抄送: Leif Lindholm ; Ard Biesheuvel
> ; Sami Mujawar ;
> Liming Gao 
> 主题: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues
> 
> This patch series is the third version of
> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations​.
> The subject line has been updated because this went from a one commit
> patch with no cover letter to a multi-commit patch.
> 
> The commit messages cover the vast amount of detail here, but this
> patchset fixes three issues:
> - a UEFI spec violation for which memory types require runtime page
> allocation granularity alignment
> - An incompatibility of the heap guard system to guard these regions
> that require runtime page allocation granularities greater than
> the EFI_PAGE_SIZE.
> - A CodeQL error that fails CI when updating the Page.c code
> 
> v3:
> - edit comments for readability
> 
> v2:
> - Add commit to fix UEFI spec violation
> - Add commit to fix newly flagged CodeQL error
> - Update guard commit message, comments, and static assert to use
> the correct types
> 
> Cc: Leif Lindholm 
> Cc: Ard Biesheuvel 
> Cc: Sami Mujawar 
> Cc: Liming Gao 
> 
> Oliver Smith-Denny (3):
>   MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages
>   MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type
>   MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types
> 
>  MdeModulePkg/MdeModulePkg.dec | 10 +
>  MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14
> +
>  MdeModulePkg/Core/Dxe/Mem/Page.c  | 22
> +---
>  MdeModulePkg/Core/Dxe/Mem/Pool.c  | 15
> +++--
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |  4 ++--
>  MdeModulePkg/Core/Pei/Memory/MemoryServices.c |  2 +-
>  6 files changed, 59 insertions(+), 8 deletions(-)
> 
> --
> 2.40.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116762): https://edk2.groups.io/g/devel/message/116762
Mute This Topic: https://groups.io/mt/104927832/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-