Re: DLR and SMPP..

2002-01-02 Thread Stefan Cars

I will try the patch right away. Here is some more information I got from
gdb:

Ok here is some output from gdb, i set the breakpoint to
octstr_compare. And here is the bt:
Breakpoint 18, octstr_compare (ostr1=0x81cc350, ostr2=0x81f2250)
at gwlib/octstr.c:724
724 {
(gdb) bt
#0  octstr_compare (ostr1=0x81cc350, ostr2=0x81f2250) at
gwlib/octstr.c:724
#1  0x80591ae in item_has_key (item=0x81f2210, key=0x81cc350)
at gwlib/dict.c:47
#2  0x8060d91 in list_search (list=0x81f2090, pattern=0x81cc350, 
cmp=0x8059198 ) at gwlib/list.c:358
#3  0x80595cd in dict_get (dict=0x81e8890, key=0x81cc350) at
gwlib/dict.c:239
#4  0x8051ec2 in urltrans_find_service (trans=0x81e8610, msg=0x81f9a10)
at gw/urltrans.c:229
#5  0x804c01b in obey_request_thread (arg=0x0) at gw/smsbox.c:794
#6  0x805b4a3 in new_thread (arg=0x81fa250) at
gwlib/gwthread-pthread.c:283
#7  0x280ece73 in _thread_start () from /usr/lib/libc_r.so.4
#8  0x0 in ?? ()
(gdb) c
Continuing.
2001-12-31 23:21:43 [4] INFO: Starting delivery report  from
<46708443600>
2001-12-31 23:21:43 [4]
PANIC: gwlib/octstr.c:260: octstr_copy_real: Assertion `len >= 0' failed.

Program exited with code 01.
(gdb) 


On Tue, 1 Jan 2002, Stipe Tolj wrote:

> > When using DLR with my SMSC that uses SMPP kannel crashes (cvs
> > version):
> > 
> > 2001-12-31 21:42:27 [9] DEBUG: **>>  SMPP handle_pdu
> > Got DELIVER REPORT
> > 
> > 2001-12-31 21:42:27 [9]
> > PANIC: gwlib/octstr.c:2032: seems_valid_real: Assertion `ostr != NULL'
> > failed. (Called from gwlib/octstr.c:728:octstr_compare.)
> 
> it seems that there is a octstr_compare() call within smsc_smpp.c at
> line 449-450 that cause this assertion.
> 
> The following atteched patch should fix this NULL pointer assertion
> for octstr_compare?! 
> Stefan, please try this patch and report and if there are no
> objections we will commit the patch to cvs.
> 
> Stipe
> 
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
> 
> Münsterstr. 248
> 40470 Düsseldorf
> 
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
> 
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are





Re: DLR and SMPP..

2002-01-02 Thread Stefan Cars

The patched worked (it doesn't crash anymore) but the problem that it
doesn't find the DLR id is still there:

2002-01-02 11:01:41 [7] ERROR: Got DELIV REPORT but couldnt find message
or was not interested in it

A similar problems occurs when using CIMD2 (when receiving the delivery
report from the SMSC):

2002-01-02 11:00:12 [4] INFO: Starting delivery report  from
<46708443600>
2002-01-02 11:00:12 [4]
PANIC: gwlib/octstr.c:260: octstr_copy_real: Assertion `len >= 0' failed.



On Tue, 1 Jan 2002, Stipe Tolj wrote:

> > When using DLR with my SMSC that uses SMPP kannel crashes (cvs
> > version):
> > 
> > 2001-12-31 21:42:27 [9] DEBUG: **>>  SMPP handle_pdu
> > Got DELIVER REPORT
> > 
> > 2001-12-31 21:42:27 [9]
> > PANIC: gwlib/octstr.c:2032: seems_valid_real: Assertion `ostr != NULL'
> > failed. (Called from gwlib/octstr.c:728:octstr_compare.)
> 
> it seems that there is a octstr_compare() call within smsc_smpp.c at
> line 449-450 that cause this assertion.
> 
> The following atteched patch should fix this NULL pointer assertion
> for octstr_compare?! 
> Stefan, please try this patch and report and if there are no
> objections we will commit the patch to cvs.
> 
> Stipe
> 
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
> 
> Münsterstr. 248
> 40470 Düsseldorf
> 
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
> 
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are





Re: DLR and SMPP..

2002-01-02 Thread Valter Santos

Hi there!

I am also having problems with dlrs under smpp.
I am geting this error when i ask for dlr:

2002-01-02 13:14:18 [8] DEBUG: boxc_receiver: sms received
2002-01-02 13:14:18 [5] PANIC: gwlib/octstr.c:2031: seems_valid_real:
Assertion `ostr != NULL' failed. (Called from
gw/smsc_smpp.c:566:handle_pdu.)

I am using simulators for SMPP (openSMPP from logica and SMPPSim by Martin
Woolley)...
maybe these simulators don't handle very well DLR requests :( :(

anyone have ideas about my problem???

thanks!

Valter Santos


- Original Message -
From: "Stipe Tolj" <[EMAIL PROTECTED]>
To: "Stefan Cars" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Tuesday, January 01, 2002 2:30 PM
Subject: Re: DLR and SMPP..


> > When using DLR with my SMSC that uses SMPP kannel crashes (cvs
> > version):
> >
> > 2001-12-31 21:42:27 [9] DEBUG: **>>  SMPP handle_pdu
> > Got DELIVER REPORT
> >
> > 2001-12-31 21:42:27 [9]
> > PANIC: gwlib/octstr.c:2032: seems_valid_real: Assertion `ostr != NULL'
> > failed. (Called from gwlib/octstr.c:728:octstr_compare.)
>
> it seems that there is a octstr_compare() call within smsc_smpp.c at
> line 449-450 that cause this assertion.
>
> The following atteched patch should fix this NULL pointer assertion
> for octstr_compare?!
> Stefan, please try this patch and report and if there are no
> objections we will commit the patch to cvs.
>
> Stipe
>
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
>
> Münsterstr. 248
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are






> --- gateway/gw/smsc_smpp.c.orig Tue Jan  1 14:26:20 2002
> +++ gateway/gw/smsc_smpp.c Tue Jan  1 14:27:26 2002
> @@ -446,8 +446,8 @@
>/* we get the following status: DELIVRD, ACCEPTD,
>EXPIRED, DELETED, UNDELIV, UNKNOWN, REJECTD */
>
> - if ((octstr_compare(stat,octstr_imm("DELIVRD"))==0)
> - || (octstr_compare(stat,octstr_imm("ACCEPTD"))==0))
> + if ((stat != NULL) &&
((octstr_compare(stat,octstr_imm("DELIVRD"))==0)
> + || (octstr_compare(stat,octstr_imm("ACCEPTD"))==0)))
>   dlrstat = DLR_SUCCESS;
>   else
>   dlrstat = DLR_FAIL;
>





Re: Errors in the docs..

2002-01-02 Thread Valter Santos

Greets!

> I may suggest that those developers using and supporting SMPP should
> provide a patch to integrate the multiple-receiver support?!

I have done something in smsbox.c to support mutiple-receiver when using
http post method that seems to work with EMI2 and SMPP... (diff attached)

For instance, X-Kannel-To header could be used with multiple receivers
separated
by a blank char; i add a iteraction in smsbox_sendsms_post() to request a
smsbox_req_handle() to each receiver in -Kannel-To header..

I really dunno if this is the better way to do it... since
smsbox_sendsms_post() will only
return the last call result of smsbox_req_handle()  :(

please add a look to it and let me know your thoughts!

Valter Santos



- Original Message -
From: "Stipe Tolj" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Tuesday, January 01, 2002 2:18 PM
Subject: Re: Errors in the docs..


> > After reading some source I see that (at least) the smpp implementation
> > does not handle multiple receivers (seperarated with space). (this
however
> > works with cimd2). Therefor i suggest that the following is removed from
> > the documentation:
> >
> > Phone number of the receiver. To send to multiple receivers, separate
each
> > entry with space (' ', '+' url-encoded) - but note that this can be
> > deactivated via sendsms-chars in the 'smsbox' group.
>
> I may suggest that those developers using and supporting SMPP should
> provide a patch to integrate the multiple-receiver support?!
>
> Who is in charge of the smsc_smpp.c module?
>
> Stipe
>
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
>
> Münsterstr. 248
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are
>
>
>



mailing-smsbox.c.diff
Description: Binary data


RE: dummy 1234 from number

2002-01-02 Thread Ian Daly

> I have tried to use the at2 driver and found that there is a
> usage of a
> number 1234:
>
> /* Put a dummy address in the receiver for now (SMSC requires
>  * one) */
> message->sms.receiver = octstr_create_from_data("1234", 4);
> /*message->sms.receiver = destination;*/

The reason for this seems to be because there's not really an AT command to
query the modem for the MSISDN of the SIM (that is the 'destination' number
in this case). That said, normally there's no way, but some providers write
it into the "ON" Phonebook of their SIM card but there is no specification
from the GSM Standard that they must do it. For a Siemens M20, you can try
to see if you have some entries in ON by using AT+CPBS="ON" and AT+CPBF="".
I think there's a similar command for the Wavecom. The MSISDN is only stored
in the HLR at the provider, GSM mobiles do not have access to it, the IMSI
is used for dialling purposes, so short of making this "number" configurable
in the smsc group for at2, I don't know what could be done, any comments?

Ian





anyone using mutli-cast GET requests

2002-01-02 Thread Stipe Tolj

for the sendsms HTTP interface?

Any if yes, which smsc? 

I'm currently figuring out in the code where this is supported for the
GET method, but I can't find it. Any I remember that the user's guide
that's that multiple receivers are allowed seperated with a blank in
the "to=" argument.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: anyone using mutli-cast GET requests

2002-01-02 Thread Stipe Tolj

Stefan Cars wrote:
> 
> What do you meanwith multi-cast GET ?

the user guide states at
http://www.kannel.3glab.org/download/kannel-userguide-snapshot/userguide.html#AEN2521

that the "to=" argument may contain multiple receivers, but I can't
see any implementation of this is the code?! 

I'm just curious if someone is using this, otherwise we have a too
optimistic documentation here :))

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: anyone using mutli-cast GET requests

2002-01-02 Thread Stefan Cars

Yes, i'm using this. IT works with CIMD2 at least.

-
Stefan Cars
CTO
Globalwire Communications
Phone: +46 18 10 79 50
Mobile(UK): +44 788 061 36 69
Mobile(SE): +46 708 44 36 00

On Wed, 2 Jan 2002, Stipe Tolj wrote:

> Stefan Cars wrote:
> >
> > What do you meanwith multi-cast GET ?
>
> the user guide states at
> http://www.kannel.3glab.org/download/kannel-userguide-snapshot/userguide.html#AEN2521
>
> that the "to=" argument may contain multiple receivers, but I can't
> see any implementation of this is the code?!
>
> I'm just curious if someone is using this, otherwise we have a too
> optimistic documentation here :))
>
> Stipe
>
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
>
> Münsterstr. 248
> 40470 Düsseldorf
>
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
>
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are
>





Re: anyone using mutli-cast GET requests

2002-01-02 Thread Stipe Tolj

> Yes, i'm using this. IT works with CIMD2 at least.

so where is the splitting and looping of the single receiver number of
the "to" GET variable implemented? In smsc_cimd2.c?

Is the code within the current cvs tree or have you an own version?

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




nyone using the load balancer ?

2002-01-02 Thread Choong Hong Cheng

Anyone testing the load balancer ?

Cheers,
Hong Cheng


__
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com




Re: nyone using the load balancer ?

2002-01-02 Thread Stipe Tolj

Choong Hong Cheng wrote:
> 
> Anyone testing the load balancer ?

not yet, but it's on my TODO list.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




cvs mail post-process

2002-01-02 Thread Bernino Lind

Hello dev team,

A small user request:

Could you setup cvs to make a post-process rule on commit, that all
interested parties gets a mail that states the commit comment, the file
changed etc.

One does this in the cvsroot configuration of the pserver.

The mail could for example be a new list to which cvs process/user can
mail to and maybe you developers and to which the rest of us can listen.

Its only because I like to know exactly what is changing and for what
reason in the code...so now I must do a cvs up, look at what has changed
and then ask the cvs server for the diff...

Happy new year!

-- 
med venlig hilsen / Best Regards
Bernino Lind - [EMAIL PROTECTED]
catpipe Systems ApS - www.catpipe.net
Best done *BSD solutions




Re: nyone using the load balancer ?

2002-01-02 Thread Bernino Lind

Is it in the cvs tree ?

I cant seem to find it ?

On Wed, Jan 02, 2002 at 04:01:07PM +0100, Stipe Tolj wrote:
> Choong Hong Cheng wrote:
> > 
> > Anyone testing the load balancer ?
> 
> not yet, but it's on my TODO list.
> 
> Stipe
> 
> [EMAIL PROTECTED]
> ---
> Wapme Systems AG
> 
> Münsterstr. 248
> 40470 Düsseldorf
> 
> Tel: +49-211-74845-0
> Fax: +49-211-74845-299
> 
> E-Mail: [EMAIL PROTECTED]
> Internet: http://www.wapme-systems.de
> ---
> wapme.net - wherever you are

-- 
med venlig hilsen / Best Regards
Bernino Lind - [EMAIL PROTECTED]
catpipe Systems ApS - www.catpipe.net
Best done *BSD solutions




Re: nyone using the load balancer ?

2002-01-02 Thread Stipe Tolj

> Is it in the cvs tree ?
> 
> I cant seem to find it ?

the proposed patch has been send to the devel@ list, AFAIK.

Choong, can you please state which subject it was, or resend it.
Thanks.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are




Re: cvs mail post-process

2002-01-02 Thread David Holland

On Wed, Jan 02, 2002 at 04:24:29PM +0100, Bernino Lind wrote:
> Could you setup cvs to make a post-process rule on commit, that all
> interested parties gets a mail that states the commit comment, the file
> changed etc.

Look for the daily messages to the devel-reports list with the subject
"Daily patch: gateway".

Dave
-- 
David Holland   =*=   Systems Manager   =*=   tel: +44 01223 478900
http://www.3glab.com/   =*= 3G Lab, UK  =*=   fax: +44 01223 478901




Re: cvs mail post-process

2002-01-02 Thread Bernino Lind

Ah sh**, my fuckup. I had not seen that list...

Sorry for not looking deeply...

//nino

On Wed, Jan 02, 2002 at 03:51:23PM +, David Holland wrote:
> On Wed, Jan 02, 2002 at 04:24:29PM +0100, Bernino Lind wrote:
> > Could you setup cvs to make a post-process rule on commit, that all
> > interested parties gets a mail that states the commit comment, the file
> > changed etc.
> 
> Look for the daily messages to the devel-reports list with the subject
> "Daily patch: gateway".
> 
> Dave
> -- 
> David Holland   =*=   Systems Manager   =*=   tel: +44 01223 478900
> http://www.3glab.com/   =*= 3G Lab, UK  =*=   fax: +44 01223 478901

-- 
med venlig hilsen / Best Regards
Bernino Lind - [EMAIL PROTECTED]
catpipe Systems ApS - www.catpipe.net
Best done *BSD solutions




Re: cvs mail post-process

2002-01-02 Thread Valter Santos

you have to subscribe to [EMAIL PROTECTED]  :

http://kannel.3glab.org/mailman/options/devel-reports/


Valter

- Original Message - 
From: "Bernino Lind" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, January 02, 2002 3:24 PM
Subject: cvs mail post-process


> Hello dev team,
> 
> A small user request:
> 
> Could you setup cvs to make a post-process rule on commit, that all
> interested parties gets a mail that states the commit comment, the file
> changed etc.
> 
> One does this in the cvsroot configuration of the pserver.
> 
> The mail could for example be a new list to which cvs process/user can
> mail to and maybe you developers and to which the rest of us can listen.
> 
> Its only because I like to know exactly what is changing and for what
> reason in the code...so now I must do a cvs up, look at what has changed
> and then ask the cvs server for the diff...
> 
> Happy new year!
> 
> -- 
> med venlig hilsen / Best Regards
> Bernino Lind - [EMAIL PROTECTED]
> catpipe Systems ApS - www.catpipe.net
> Best done *BSD solutions
> 
> 
> 





Re: cvs mail post-process

2002-01-02 Thread Andreas Fink
Title: Re: cvs mail post-process


you have to subscribe to
[EMAIL PROTECTED]  :

http://kannel.3glab.org/mailman/options/devel-reports/

Valter


this URL reports:

Error
Invalid options to CGI script.
-- 


Andreas Fink
Fink-Consulting

--
Tel: +41-61-6932730 Fax: +41-61-6932729  Mobile:
+41-79-2457333
Address: A. Fink, Schwarzwaldallee 16, 4058 Basel, Switzerland
E-Mail:  [EMAIL PROTECTED]  Homepage:
http://www.finkconsulting.com
--
Something urgent? Try http://www.smsrelay.com/  Nickname
afink



Re: cvs mail post-process

2002-01-02 Thread David Holland

On Wed, Jan 02, 2002 at 05:37:03PM +0100, Andreas Fink wrote:
> this URL reports:
> Error
> Invalid options to CGI script.

Please try http://kannel.3glab.org/mailman/listinfo/devel-reports instead.

Dave
-- 
David Holland   =*=   Systems Manager   =*=   tel: +44 01223 478900
http://www.3glab.com/   =*= 3G Lab, UK  =*=   fax: +44 01223 478901




Re: DLR and SMPP..

2002-01-02 Thread tluttine

On Tue, 1 Jan 2002, Stipe Tolj wrote:

> Andreas Fink wrote:

> > Why dont we modify octstr_compare that a NULL string can be compared too?
> > NULL would then be equal to "". Does that make sense?

> I'm not sure how deep the impact would be. Anyone from the core
> architects still reading the list and have their heads up, please?!

As I see it this approach with octstr_compare is a part of the Kannel's
protective coding style where the NULL pointers are not meant to  be used
as any other similar pointer. So the assert prevents the NULL pointer to
go on loosely and stops it before it may cause a segmentation fault on
some other part of the program that is not ready to handle NULL pointers.
Therefore the line between a NULL pointer and an empty octstr; first one
is an accident that shouldn't happen, the latter is a way to say that
there is no content.


-- 
Tuomas Luttinen
   Reach U






Re: DLR and SMPP..

2002-01-02 Thread Stipe Tolj

[EMAIL PROTECTED] wrote:

> As I see it this approach with octstr_compare is a part of the Kannel's
> protective coding style where the NULL pointers are not meant to  be used
> as any other similar pointer. So the assert prevents the NULL pointer to
> go on loosely and stops it before it may cause a segmentation fault on
> some other part of the program that is not ready to handle NULL pointers.
> Therefore the line between a NULL pointer and an empty octstr; first one
> is an accident that shouldn't happen, the latter is a way to say that
> there is no content.

I agree in the view of protective coding style, hence we may
distringuish between a NULL pointer and an empty content, IMO.

Stipe

[EMAIL PROTECTED]
---
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: [EMAIL PROTECTED]
Internet: http://www.wapme-systems.de
---
wapme.net - wherever you are





Re: DLR and SMPP..

2002-01-02 Thread Andreas Fink

>[EMAIL PROTECTED] wrote:
>
>>  As I see it this approach with octstr_compare is a part of the Kannel's
>>  protective coding style where the NULL pointers are not meant to  be used
>>  as any other similar pointer. So the assert prevents the NULL pointer to
>>  go on loosely and stops it before it may cause a segmentation fault on
>>  some other part of the program that is not ready to handle NULL pointers.
>>  Therefore the line between a NULL pointer and an empty octstr; first one
>>  is an accident that shouldn't happen, the latter is a way to say that
>>  there is no content.
>
>I agree in the view of protective coding style, hence we may
>distringuish between a NULL pointer and an empty content, IMO.


Ok. how about dealing with NULL as a different string of "" but still 
being able to compare NULL to something and NULL to NULL?

-- 

Andreas Fink
Fink-Consulting

--
Tel: +41-61-6932730 Fax: +41-61-6932729  Mobile: +41-79-2457333
Address: A. Fink, Schwarzwaldallee 16, 4058 Basel, Switzerland
E-Mail:  [EMAIL PROTECTED]  Homepage: http://www.finkconsulting.com
--
Something urgent? Try http://www.smsrelay.com/  Nickname afink