Re: Announcement: DNF port of livecd-creator
On Tue, Dec 6, 2016 at 10:22 PM, Kevin Kofler wrote: > Adam Williamson wrote: >> Dennis has untagged this from Rawhide for now, as it broke ARM disk >> image composes. > > That is probably Neal's fix to make -foo actually exclude foo from the > compose. That is required to make -foo work with weak dependencies, i.e., > for when something Recommends: foo or when foo Supplements something. (We > will also be submitting a similar fix to Anaconda/livemedia-creator.) > Unfortunately, it is a behavior change for when foo is actually Required by > something else in the compose: That now produces an error instead of > silently including foo anyway. We think, however, that this is the right > thing to do (it does not make sense to have -foo in the kickstart just to > have the compose tool include foo behind your back anyway), but existing > live-kickstarts do need fixing to remove bogus exclusions. It was not that. It was because appliance-tools has a broken import for python-imgcreate, and doesn't even properly pull it in. Also, appliance-tools itself doesn't require python-imgcreate, so now that livecd-tools uses python3 by default, it can't import anything anyway. Two simple fixes, attached to this email. -- 真実はいつも一つ!/ Always, there's only one truth! --- appliance-tools.spec~ 2016-12-06 19:46:22.0 -0500 +++ appliance-tools.spec2016-12-06 19:50:11.496865709 -0500 @@ -5,7 +5,7 @@ Summary: Tools for building Appliances Name: appliance-tools Version: 007.8 -Release: 10%{?dist} +Release: 11%{?dist} License: GPLv2 Group: System Environment/Base URL: https://git.fedorahosted.org/git/appliance-tools.git @@ -19,8 +19,10 @@ URL: https://git.fedorahosted.org/git/ap Source0: appliance-tools-%{version}.tar.bz2 Patch0: appliance-tools-nss.hack Patch1: appliance-tools-partitioning-fixes.patch +Patch2: 0001-Fix-import-for-compatibility-with-livecd-tools-v24.patch -Requires: livecd-tools >= 020 curl rsync kpartx +Requires: python-imgcreate >= 24.0 +Requires: curl rsync kpartx Requires: zlib Requires: qemu-img Requires: xz @@ -40,6 +42,7 @@ derived distributions such as RHEL, Cent %setup -q %patch0 -p1 %patch1 -p1 +%patch2 -p1 %build make @@ -67,6 +70,10 @@ rm -rf $RPM_BUILD_ROOT %{python_sitelib}/ec2convert/*.pyc %changelog +* Tue Dec 06 2016 Neal Gompa 007.8-11 +- Change dependency from livecd-tools to python-imgcreate +- Fix for python-imgcreate v24 compatibility + * Tue Sep 20 2016 Peter Robinson 007.8-10 - Fix swap partition type creation - Set boot partition as bootable 0001-Fix-import-for-compatibility-with-livecd-tools-v24.patch Description: Binary data ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: DNF port of livecd-creator
Adam Williamson wrote: > Dennis has untagged this from Rawhide for now, as it broke ARM disk > image composes. That is probably Neal's fix to make -foo actually exclude foo from the compose. That is required to make -foo work with weak dependencies, i.e., for when something Recommends: foo or when foo Supplements something. (We will also be submitting a similar fix to Anaconda/livemedia-creator.) Unfortunately, it is a behavior change for when foo is actually Required by something else in the compose: That now produces an error instead of silently including foo anyway. We think, however, that this is the right thing to do (it does not make sense to have -foo in the kickstart just to have the compose tool include foo behind your back anyway), but existing live-kickstarts do need fixing to remove bogus exclusions. In particular, this snippet (from the minimization stuff): # save some space (from @standard) -make and these from the KDE kickstart: -scim* -m17n* -ibus* -iok are no longer valid nor necessary and should just be removed. (The former is because OpenSSL now requires make. In the latter list, only -ibus* is really invalid, because Plasma requires ibus-libs now, but the others just do nothing and can be omitted as well. -@input-methods is sufficient in any case.) These lines should not needed with livemedia-creator either, they are just silently ignored there. So I think we should just remove them from the kickstarts. Kevin Kofler ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: DNF port of livecd-creator
On Tue, 2016-12-06 at 11:55 -0800, Brian C. Lane wrote: > Thanks to Kevin and Neal for their work on this. Builds for rawhide are > done. If folks could give 'em a test drive and see if there are any > glitches that'd be good. I'll backport the build to 25 and 24 later this > week if nothing serious shows up. Dennis has untagged this from Rawhide for now, as it broke ARM disk image composes. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: DNF port of livecd-creator
Thanks to Kevin and Neal for their work on this. Builds for rawhide are done. If folks could give 'em a test drive and see if there are any glitches that'd be good. I'll backport the build to 25 and 24 later this week if nothing serious shows up. -- Brian C. Lane (PST8PDT) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: Python 3 port of livecd-creator (was: Re: Announcement: DNF port of livecd-creator)
On Mon, 2016-11-14 at 12:35 -0500, Neal Gompa wrote: On Mon, Nov 14, 2016 at 12:17 PM, John Florian mailto:john.flor...@dart.biz>> wrote: On Sun, 2016-11-13 at 05:03 +0100, Kevin Kofler wrote: Hi, FYI, Neal Gompa has now put up a Copr with the DNF + Python 3 version of the livecd-tools: https://copr.fedorainfracloud.org/coprs/ngompa/livecd-creator/ This is interesting news for me. I'm a long time user (in an employed capacity) of livecd-tools and it sort of felt like the project was circling the drain. I've recently started playing with livemedia-creator and have found some aspects that look wonderfully powerful (e.g., the lorax templates) but have also found it frustrating to use when it doesn't like my kickstart. I'm past that frustration (for now), but have hit another bump. To make the spins from lm-c into what I need, I must modify the lorax templates and since our spins are done in our Koji there doesn't yet appear to be anyway to achieve that. In order to use alternative templates, the livemedia-creator command must have an additional parameter passed. Koji currently doesn't support this facility, which makes it difficult to use when you need to support custom layouts. If you'd like this capability, file a bug against koji in bugzilla for it. Done. https://bugzilla.redhat.com/show_bug.cgi?id=1394933 I'm willing to try tackling this. I code Python lots and have read plenty of Koji (to understand how to use it before the excellent https://docs.pagure.org/koji came along ... or maybe that's been around for awhile and I just never stumbled onto it working only with "better than nothing" https://fedoraproject.org/wiki/Koji). If that's acceptable, should this be planned on buildsys or koji-devel first or should I just go for it and show my work as a patch on the RFE I submitted or ... ? So I'm at a crossroad of enhancing Koji to support custom lorax templates or to maybe hold out for this breath of life in livecd-tools. Are you planning to get this work into the livecd-tools in the standard Fedora repos? What about Koji support? Would this work as is or will that require further work? Kevin has already submitted a request to merge our work into the canonical livecd-tools repository[1]. Once merged, we hope that upstream will push a new release to supported releases with the new code. Cool beans! The work we did shouldn't affect Koji support any, though if you run Koji on something other than Fedora, you'll need to have the latest DNF 1.1 version available on the system running Koji. With the release of RHEL 7.3 and EPEL7 subsequently bumping up to it, the version of DNF for EL7 can be bumped to the latest 1.1 release. Please request that in bugzilla, if you want it. I'm currently not providing EL7 packages because of the lack of DNF 1.1. With no CentOS 7.3 available yet, I cannot produce packages that would be installable by the vast majority of people. Will do. I'll probably wait until CentOS 7.3 is out. Unfortunately I don't have any proper RHEL to play with. Then that always puts my brain in a spin as to where I *should* file such requests, CentOS BZ, RH BZ, github, etc. I feel wrong (and have been told so for other rpms) in filing in RH BZ when I expect to use it in CentOS, but if RH *is* upstream like with lorax, then anywhere else seems wrong. [1]: https://github.com/rhinstaller/livecd-tools/pull/37 I'm just trying to gauge where to focus my efforts project-wise. Hopefully I can contribute something here. I would encourage you to try out our new livecd-tools and see how it performs for your needs. Contributions are welcome as well. If upstream doesn't pull it in, the code will be maintained on Kevin's GitHub repository[2]. [2]: https://github.com/kkofler/livecd-tools I will do that. It's always an immense relief for me to see things moving to Python 3 -- I jumped ship long ago, and of course, now I want everything else to do the same. Even if I do wind up using livemedia-creator eventually for composing the ISO, I'll still be using copy-iso-to-disk from livecd-tools for some time to come for the persistent storage support. I'll be more than happy to help test. Hopefully I can also contribute something as well, which is much more likely with Py3 code because it doesn't burn my eyes like Py2 does. [:-)] ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: Python 3 port of livecd-creator (was: Re: Announcement: DNF port of livecd-creator)
On Mon, Nov 14, 2016 at 12:17 PM, John Florian wrote: > On Sun, 2016-11-13 at 05:03 +0100, Kevin Kofler wrote: > > Hi, > > FYI, Neal Gompa has now put up a Copr with the DNF + Python 3 version of the > livecd-tools: > https://copr.fedorainfracloud.org/coprs/ngompa/livecd-creator/ > > > > This is interesting news for me. I'm a long time user (in an employed > capacity) of livecd-tools and it sort of felt like the project was circling > the drain. I've recently started playing with livemedia-creator and have > found some aspects that look wonderfully powerful (e.g., the lorax > templates) but have also found it frustrating to use when it doesn't like my > kickstart. I'm past that frustration (for now), but have hit another bump. > To make the spins from lm-c into what I need, I must modify the lorax > templates and since our spins are done in our Koji there doesn't yet appear > to be anyway to achieve that. > In order to use alternative templates, the livemedia-creator command must have an additional parameter passed. Koji currently doesn't support this facility, which makes it difficult to use when you need to support custom layouts. If you'd like this capability, file a bug against koji in bugzilla for it. > So I'm at a crossroad of enhancing Koji to support custom lorax templates or > to maybe hold out for this breath of life in livecd-tools. Are you planning > to get this work into the livecd-tools in the standard Fedora repos? What > about Koji support? Would this work as is or will that require further > work? > Kevin has already submitted a request to merge our work into the canonical livecd-tools repository[1]. Once merged, we hope that upstream will push a new release to supported releases with the new code. The work we did shouldn't affect Koji support any, though if you run Koji on something other than Fedora, you'll need to have the latest DNF 1.1 version available on the system running Koji. With the release of RHEL 7.3 and EPEL7 subsequently bumping up to it, the version of DNF for EL7 can be bumped to the latest 1.1 release. Please request that in bugzilla, if you want it. I'm currently not providing EL7 packages because of the lack of DNF 1.1. With no CentOS 7.3 available yet, I cannot produce packages that would be installable by the vast majority of people. [1]: https://github.com/rhinstaller/livecd-tools/pull/37 > I'm just trying to gauge where to focus my efforts project-wise. Hopefully > I can contribute something here. I would encourage you to try out our new livecd-tools and see how it performs for your needs. Contributions are welcome as well. If upstream doesn't pull it in, the code will be maintained on Kevin's GitHub repository[2]. [2]: https://github.com/kkofler/livecd-tools -- 真実はいつも一つ!/ Always, there's only one truth! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: Python 3 port of livecd-creator (was: Re: Announcement: DNF port of livecd-creator)
On Sun, 2016-11-13 at 05:03 +0100, Kevin Kofler wrote: Hi, FYI, Neal Gompa has now put up a Copr with the DNF + Python 3 version of the livecd-tools: https://copr.fedorainfracloud.org/coprs/ngompa/livecd-creator/ This is interesting news for me. I'm a long time user (in an employed capacity) of livecd-tools and it sort of felt like the project was circling the drain. I've recently started playing with livemedia-creator and have found some aspects that look wonderfully powerful (e.g., the lorax templates) but have also found it frustrating to use when it doesn't like my kickstart. I'm past that frustration (for now), but have hit another bump. To make the spins from lm-c into what I need, I must modify the lorax templates and since our spins are done in our Koji there doesn't yet appear to be anyway to achieve that. So I'm at a crossroad of enhancing Koji to support custom lorax templates or to maybe hold out for this breath of life in livecd-tools. Are you planning to get this work into the livecd-tools in the standard Fedora repos? What about Koji support? Would this work as is or will that require further work? I'm just trying to gauge where to focus my efforts project-wise. Hopefully I can contribute something here. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Re: Announcement: Python 3 port of livecd-creator (was: Re: Announcement: DNF port of livecd-creator)
Hi, FYI, Neal Gompa has now put up a Copr with the DNF + Python 3 version of the livecd-tools: https://copr.fedorainfracloud.org/coprs/ngompa/livecd-creator/ Enjoy, Kevin Kofler ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Announcement: Python 3 port of livecd-creator (was: Re: Announcement: DNF port of livecd-creator)
Hi, I wrote: > remix authors rejoice: I have ported the old livecd-creator from yum to > dnf (in one night): > https://github.com/kkofler/livecd-tools > (The other tools in the package were also ported away from yum and its > rpmUtils to dnf, but livecd-creator was the main user of yum stuff.) Now, after a 12-hour porting session with Neal Gompa (he did the porting, I the testing), the code is finally working with Python 3 too! https://github.com/kkofler/livecd-tools Python 2 is still supported. You need Python 2 ≥ 2.6 or Python 3 ≥ 3.3. I tested with: python-2.7.12-6.fc24.x86_64 python3-3.5.2-3.fc24.x86_64 The Python 3 port is of course based on the DNF port. (The old YUM does not support Python 3.) So this issue: > * It is still using Python 2, and thus needs python2-dnf (which nothing > else needs). If somebody feels like porting it to Python 3, that should > be easy now that it uses dnf, so please feel free. I would be happy to > take a pull request for that. is now addressed. The other caveats still stand though. Enjoy, Kevin Kofler ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org