Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
From: development-bounces+mitch.curtis=theqtcompany@qt-project.org on behalf of Thiago Macieira Sent: Friday, 14 August 2015 22:19 To: development@qt-project.org Subject: Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes On Friday 14 August 2015 09:41:16 Lisandro Damián Nicanor Pérez Meyer wrote: > On Thursday 13 August 2015 17:40:24 Thiago Macieira wrote: > > I recently tried to fix a very simple bug in Qt 4.8 but I can't get the > > change to integrate because the CI seems to have fallen into disrepair. > > > > Instead of using valuable QA time in fixing the CI for 4.8, I'd like to > > propose instead that we simply disable the CI for that version and close > > Qt > > 4.8 for any submission except security fixes. Gerrit would be configured > > for pure merging instead of staging, but that would only be enabled to > > Gerrit admins and they'd only do it after confirmation from the security > > team (security@qt- project.org). > > > > Any objections? > > FWIW I think this is they way to go. Seeing that we have support across the board, I'll ask the Gerrit admins to do the change. I'll also drop my fix because it's not a security fix. We can also close all Qt 4.x bug reports that do not apply to Qt 5 and aren't security issues. [snip] I created a filter for those bugs: https://bugreports.qt.io/issues/?filter=16968 I'll try to do a bulk close of those bugs and reference this thread. (Sorry about the formatting, on Windows...) ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
On Friday 14 August 2015 09:41:16 Lisandro Damián Nicanor Pérez Meyer wrote: > On Thursday 13 August 2015 17:40:24 Thiago Macieira wrote: > > I recently tried to fix a very simple bug in Qt 4.8 but I can't get the > > change to integrate because the CI seems to have fallen into disrepair. > > > > Instead of using valuable QA time in fixing the CI for 4.8, I'd like to > > propose instead that we simply disable the CI for that version and close > > Qt > > 4.8 for any submission except security fixes. Gerrit would be configured > > for pure merging instead of staging, but that would only be enabled to > > Gerrit admins and they'd only do it after confirmation from the security > > team (security@qt- project.org). > > > > Any objections? > > FWIW I think this is they way to go. Seeing that we have support across the board, I'll ask the Gerrit admins to do the change. I'll also drop my fix because it's not a security fix. We can also close all Qt 4.x bug reports that do not apply to Qt 5 and aren't security issues. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
On Friday 14 August 2015 02:13:36 Jake Petroules wrote: > However, I've submitted a patch which would resolve the CI issue in question > (https://codereview.qt-project.org/#/c/123073/). Do we want to push that > through along with some of the currently posted patches before the lockdown > happens? Unless it's some extremely unlikely coincidence, your patch solves one of the three issues found during my integration. The other two would remain: FAIL! : tst_QGraphicsProxyWidget::childPos(7-) Compared doubles are not the same (fuzzy compare) Actual (proxyChildPosX): 100 Expected (expectedXPosition): 0 FAIL! : tst_LargeFile::fillFileSparsely(block[32] @4294967296)) Compared values are not the same Actual (largeFile.write(block)): -1 Expected ((qint64)blockSize): 4096 -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
On Thursday 13 August 2015 17:40:24 Thiago Macieira wrote: > I recently tried to fix a very simple bug in Qt 4.8 but I can't get the > change to integrate because the CI seems to have fallen into disrepair. > > Instead of using valuable QA time in fixing the CI for 4.8, I'd like to > propose instead that we simply disable the CI for that version and close Qt > 4.8 for any submission except security fixes. Gerrit would be configured > for pure merging instead of staging, but that would only be enabled to > Gerrit admins and they'd only do it after confirmation from the security > team (security@qt- project.org). > > Any objections? FWIW I think this is they way to go. -- Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
On 14 August 2015 at 10:45, Knoll Lars wrote: > Let’s get that one in as well. > Not really a security fix but we'll also want to get the fix to make Apple's ancient openssl to work with apple's certificate store in once the patch is ready. Rich. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
Let’s get that one in as well. Cheers, Lars On 14/08/15 11:13, "Jake Petroules" wrote: > > >On Aug 13, 2015, at 11:50 PM, Knoll Lars >wrote: > >On > 14/08/15 08:25, "Sarajärvi Tony" >wrote: > > >-Original Message- >From: development-bounces+tony.sarajarvi=theqtcompany.com ><http://theqtcompany.com>@qt- >project.org <http://project.org> [mailto:development- >bounces+tony.sarajarvi=theqtcompany@qt-project.org] On Behalf Of >Thiago Macieira >Sent: 14. elokuuta 2015 3:40 >To: development@qt-project.org >Subject: [Development] Qt 4.8: disabling the CI and closing for anything >except security fixes > >I recently tried to fix a very simple bug in Qt 4.8 but I can't get the >change >to integrate because the CI seems to have fallen into disrepair. > >Instead of using valuable QA time in fixing the CI for 4.8, I'd like to >propose >instead that we simply disable the CI for that version and close Qt 4.8 >for >any submission except security fixes. Gerrit would be configured for >pure >merging instead of staging, but that would only be enabled to Gerrit >admins >and they'd only do it after confirmation from the security team >(security@qt- >project.org <http://project.org>). > >Any objections? > > > >Not from me ;) > > > >Agreed. > This sounds like the best way to continue. > >Cheers, >Lars > >___ >Development > mailing list >Development@qt-project.org >http://lists.qt-project.org/mailman/listinfo/development > > > > > >+1, Qt 4.8 needs to die. :) > > >However, I've submitted a patch which would resolve the CI issue in >question (https://codereview.qt-project.org/#/c/123073/). Do we want to >push that through along with some > of the currently posted patches before the lockdown happens? > >-- >Jake Petroules - jake.petroules at petroules.com <http://petroules.com> > > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
> On Aug 13, 2015, at 11:50 PM, Knoll Lars wrote: > > On 14/08/15 08:25, "Sarajärvi Tony" <mailto:tony.saraja...@theqtcompany.com>> > wrote: > >>> -Original Message- >>> From: development-bounces+tony.sarajarvi=theqtcompany.com@qt- >>> project.org [mailto:development- >>> bounces+tony.sarajarvi=theqtcompany@qt-project.org] On Behalf Of >>> Thiago Macieira >>> Sent: 14. elokuuta 2015 3:40 >>> To: development@qt-project.org >>> Subject: [Development] Qt 4.8: disabling the CI and closing for anything >>> except security fixes >>> >>> I recently tried to fix a very simple bug in Qt 4.8 but I can't get the >>> change >>> to integrate because the CI seems to have fallen into disrepair. >>> >>> Instead of using valuable QA time in fixing the CI for 4.8, I'd like to >>> propose >>> instead that we simply disable the CI for that version and close Qt 4.8 >>> for >>> any submission except security fixes. Gerrit would be configured for >>> pure >>> merging instead of staging, but that would only be enabled to Gerrit >>> admins >>> and they'd only do it after confirmation from the security team >>> (security@qt- >>> project.org). >>> >>> Any objections? >> >> Not from me ;) > > Agreed. This sounds like the best way to continue. > > Cheers, > Lars > > ___ > Development mailing list > Development@qt-project.org <mailto:Development@qt-project.org> > http://lists.qt-project.org/mailman/listinfo/development > <http://lists.qt-project.org/mailman/listinfo/development> +1, Qt 4.8 needs to die. :) However, I've submitted a patch which would resolve the CI issue in question (https://codereview.qt-project.org/#/c/123073/). Do we want to push that through along with some of the currently posted patches before the lockdown happens? -- Jake Petroules - jake.petroules at petroules.com ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
On 14/08/15 08:25, "Sarajärvi Tony" wrote: >> -Original Message- >> From: development-bounces+tony.sarajarvi=theqtcompany.com@qt- >> project.org [mailto:development- >> bounces+tony.sarajarvi=theqtcompany@qt-project.org] On Behalf Of >> Thiago Macieira >> Sent: 14. elokuuta 2015 3:40 >> To: development@qt-project.org >> Subject: [Development] Qt 4.8: disabling the CI and closing for anything >> except security fixes >> >> I recently tried to fix a very simple bug in Qt 4.8 but I can't get the >>change >> to integrate because the CI seems to have fallen into disrepair. >> >> Instead of using valuable QA time in fixing the CI for 4.8, I'd like to >>propose >> instead that we simply disable the CI for that version and close Qt 4.8 >>for >> any submission except security fixes. Gerrit would be configured for >>pure >> merging instead of staging, but that would only be enabled to Gerrit >>admins >> and they'd only do it after confirmation from the security team >>(security@qt- >> project.org). >> >> Any objections? > >Not from me ;) Agreed. This sounds like the best way to continue. Cheers, Lars ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 4.8: disabling the CI and closing for anything except security fixes
> -Original Message- > From: development-bounces+tony.sarajarvi=theqtcompany.com@qt- > project.org [mailto:development- > bounces+tony.sarajarvi=theqtcompany@qt-project.org] On Behalf Of > Thiago Macieira > Sent: 14. elokuuta 2015 3:40 > To: development@qt-project.org > Subject: [Development] Qt 4.8: disabling the CI and closing for anything > except security fixes > > I recently tried to fix a very simple bug in Qt 4.8 but I can't get the change > to integrate because the CI seems to have fallen into disrepair. > > Instead of using valuable QA time in fixing the CI for 4.8, I'd like to > propose > instead that we simply disable the CI for that version and close Qt 4.8 for > any submission except security fixes. Gerrit would be configured for pure > merging instead of staging, but that would only be enabled to Gerrit admins > and they'd only do it after confirmation from the security team (security@qt- > project.org). > > Any objections? Not from me ;) -Tony > -- > Thiago Macieira - thiago.macieira (AT) intel.com > Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Qt 4.8: disabling the CI and closing for anything except security fixes
I recently tried to fix a very simple bug in Qt 4.8 but I can't get the change to integrate because the CI seems to have fallen into disrepair. Instead of using valuable QA time in fixing the CI for 4.8, I'd like to propose instead that we simply disable the CI for that version and close Qt 4.8 for any submission except security fixes. Gerrit would be configured for pure merging instead of staging, but that would only be enabled to Gerrit admins and they'd only do it after confirmation from the security team (security@qt- project.org). Any objections? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center smime.p7s Description: S/MIME cryptographic signature ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
