Re: 5 for 1?

[peter]

Thank you aaugustin for taking a look at 
https://code.djangoproject.com/ticket/13794. I've made some further updates 
but haven't heard anything back in a few weeks. Even though the original 
ticket title and description makes it sound like a fairly minor bug I do 
want to point out that as with most to_field related bugs this has the 
potential to cause data corruption. I'm not sure that enough people have 
run into this to warrant 'Release Blocker' status but when it does hit it 
has pretty nasty consequences.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

5 for 1?

[peter]

Not sure if this is still a thing, but i'd like to ask for a review of this 
ticket:

https://code.djangoproject.com/ticket/13794

I triaged/reviewed the following tickets: #18201, #19668, #19663, #19617, 
#19624

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Anyone have time for a 5-for-1?

[Anssi Kääriäinen]

On 3 loka, 03:51, Stephen Burrows  wrote:
> I was hoping someone could have a look 
> at:*https://code.djangoproject.com/ticket/14567*

Committed.

> *https://code.djangoproject.com/ticket/11027*

Some thoughts given in the ticket. I hope some core-dev who knows the
storage backends better than I could take a look, too.

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

5 for 1

[Michael Manfre]

I reviewed:
#16358
#16355
#16359
#16353
#16316

Please look at #15829 (https://code.djangoproject.com/ticket/15829).

Thanks,
Michael Manfre

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Stephen Burrows]

Thanks for having a look at the ticket. I'd be happy to rewrite the
patch to include **kwargs support, if that's what people want.
However, there's no precedent in django for a tag accepting args *and*
kwargs (that I am aware of.) What would the syntax look like?

{% simple_tag arg1 arg2 with hi="low" foo="bar" %}?

{% simple_tag with arg1 arg2 hi="low" foo="bar" %}?

{% simple_tag arg1 arg2 hi="low" foo="bar" %}?

@Sam Bull: Looking at fancy_tag, I think that turning it into a patch
might be as much or more work than just converting the current patch
to also support kwargs.

On Jun 18, 10:12 am, Sam Bull <osir...@gmail.com> wrote:
> Hey,
>
> I've got a reusable app that offers the functionality you're looking for, I 
> think. I just commented on the ticket, so I hope this doesn't count as 
> double-posting, but you can check it out 
> here:https://github.com/trapeze/fancy_tag
>
> It's got unit tests, keyword argument support (like the new with tag), *args 
> support, **kwargs support, and support for the "with " pattern.
>
> Is this something I should convert into a patch?
>
> Sam
>
> On 2011-06-18, at 5:29 AM, Jannis Leidel wrote:
>
>
>
>
>
>
>
> > On 18.06.2011, at 03:38, Stephen Burrows wrote:
>
> >> I would love it if someone could look at 13956 [1]
>
> >> [1]http://code.djangoproject.com/ticket/13956
>
> > I'd like to repeat my concerns from the ticket that it seems odd to extend 
> > the
> > helper tags with support for *args but leaving out **kwargs. If the API of
> > those tags should be extended with concepts from Python we shouldn't do this
> > only partially.
>
> > Fortunately there is a good (new) convention in Django how to write kwarg
> > style template parameters, thanks to Chris Beaven's with/include tag 
> > refactor
> > (``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which
> > could also be used for the tag helpers.
>
> > Jannis
>
> >> On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
> >>> Hi Stephen,
>
> >>> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>
> >>>> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
> >>>> If so, I've reviewed the following tickets:
>
> >>>> 3624
> >>>> 16152
> >>>> 16157
> >>>> 16158
> >>>> 16166
>
> >>>> And would love it if someone could have a look at ticket 14082 [2].
>
> >>>> If not, ah well. :-)
>
> >>> Thanks for the ticket reviews, and your work on the patch. Committed in
> >>> r16334 [1]
>
> >>> Carl
>
> >>>  [1]https://code.djangoproject.com/changeset/16334
>
> >> --
> >> You received this message because you are subscribed to the Google Groups 
> >> "Django developers" group.
> >> To post to this group, send email to django-developers@googlegroups.com.
> >> To unsubscribe from this group, send email to 
> >> django-developers+unsubscr...@googlegroups.com.
> >> For more options, visit this group 
> >> athttp://groups.google.com/group/django-developers?hl=en.
>
> > --
> > You received this message because you are subscribed to the Google Groups 
> > "Django developers" group.
> > To post to this group, send email to django-developers@googlegroups.com.
> > To unsubscribe from this group, send email to 
> > django-developers+unsubscr...@googlegroups.com.
> > For more options, visit this group 
> > athttp://groups.google.com/group/django-developers?hl=en.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Sam Bull]

Hey,

I've got a reusable app that offers the functionality you're looking for, I 
think. I just commented on the ticket, so I hope this doesn't count as 
double-posting, but you can check it out here: 
https://github.com/trapeze/fancy_tag

It's got unit tests, keyword argument support (like the new with tag), *args 
support, **kwargs support, and support for the "with " pattern.

Is this something I should convert into a patch?

Sam

On 2011-06-18, at 5:29 AM, Jannis Leidel wrote:

> On 18.06.2011, at 03:38, Stephen Burrows wrote:
> 
>> I would love it if someone could look at 13956 [1]
>> 
>> [1] http://code.djangoproject.com/ticket/13956
> 
> I'd like to repeat my concerns from the ticket that it seems odd to extend the
> helper tags with support for *args but leaving out **kwargs. If the API of
> those tags should be extended with concepts from Python we shouldn't do this
> only partially.
> 
> Fortunately there is a good (new) convention in Django how to write kwarg
> style template parameters, thanks to Chris Beaven's with/include tag refactor
> (``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which
> could also be used for the tag helpers.
> 
> Jannis
> 
>> On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
>>> Hi Stephen,
>>> 
>>> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>>> 
>>>> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
>>>> If so, I've reviewed the following tickets:
>>> 
>>>> 3624
>>>> 16152
>>>> 16157
>>>> 16158
>>>> 16166
>>> 
>>>> And would love it if someone could have a look at ticket 14082 [2].
>>> 
>>>> If not, ah well. :-)
>>> 
>>> Thanks for the ticket reviews, and your work on the patch. Committed in
>>> r16334 [1]
>>> 
>>> Carl
>>> 
>>>  [1]https://code.djangoproject.com/changeset/16334
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers" group.
>> To post to this group, send email to django-developers@googlegroups.com.
>> To unsubscribe from this group, send email to 
>> django-developers+unsubscr...@googlegroups.com.
>> For more options, visit this group at 
>> http://groups.google.com/group/django-developers?hl=en.
>> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to 
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/django-developers?hl=en.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Jannis Leidel]

On 18.06.2011, at 03:38, Stephen Burrows wrote:

> I would love it if someone could look at 13956 [1]
> 
> [1] http://code.djangoproject.com/ticket/13956

I'd like to repeat my concerns from the ticket that it seems odd to extend the
helper tags with support for *args but leaving out **kwargs. If the API of
those tags should be extended with concepts from Python we shouldn't do this
only partially.

Fortunately there is a good (new) convention in Django how to write kwarg
style template parameters, thanks to Chris Beaven's with/include tag refactor
(``{% with arg1=1 arg2=2 %}{{ arg1 }}: {{ args2 }}{% endwith %}``), which
could also be used for the tag helpers.

Jannis

> On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
>> Hi Stephen,
>> 
>> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>> 
>>> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
>>> If so, I've reviewed the following tickets:
>> 
>>> 3624
>>> 16152
>>> 16157
>>> 16158
>>> 16166
>> 
>>> And would love it if someone could have a look at ticket 14082 [2].
>> 
>>> If not, ah well. :-)
>> 
>> Thanks for the ticket reviews, and your work on the patch. Committed in
>> r16334 [1]
>> 
>> Carl
>> 
>>   [1]https://code.djangoproject.com/changeset/16334
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to 
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at 
> http://groups.google.com/group/django-developers?hl=en.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Julien Phalip]

On Jun 18, 11:38 am, Stephen Burrows 
wrote:
> I would love it if someone could look at 13956 [1]

RFC'd, thanks ;)

Julien

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Stephen Burrows]

Thanks, Carl. :-)

I probably should've written a thank you note sooner & separately. As
it is, I am also writing to request a five-for-one again.
I have reviewed:
16168
16173
16176
16235
16237

I would love it if someone could look at 13956 [1]

Best,
Stephen

[1] http://code.djangoproject.com/ticket/13956

On Jun 7, 12:24 pm, Carl Meyer <c...@oddbird.net> wrote:
> Hi Stephen,
>
> On 06/07/2011 02:37 AM, Stephen Burrows wrote:
>
> > Hi - is the 5-for-1 deal still active on ticket reviews? [1]
> > If so, I've reviewed the following tickets:
>
> > 3624
> > 16152
> > 16157
> > 16158
> > 16166
>
> > And would love it if someone could have a look at ticket 14082 [2].
>
> > If not, ah well. :-)
>
> Thanks for the ticket reviews, and your work on the patch. Committed in
> r16334 [1]
>
> Carl
>
>   [1]https://code.djangoproject.com/changeset/16334

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: 5-for-1?

[Carl Meyer]

Hi Stephen,

On 06/07/2011 02:37 AM, Stephen Burrows wrote:
> Hi - is the 5-for-1 deal still active on ticket reviews? [1]
> If so, I've reviewed the following tickets:
> 
> 3624
> 16152
> 16157
> 16158
> 16166
> 
> And would love it if someone could have a look at ticket 14082 [2].
> 
> If not, ah well. :-)

Thanks for the ticket reviews, and your work on the patch. Committed in
r16334 [1]

Carl

  [1] https://code.djangoproject.com/changeset/16334

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

5-for-1?

[Stephen Burrows]

Hi - is the 5-for-1 deal still active on ticket reviews? [1]
If so, I've reviewed the following tickets:

3624
16152
16157
16158
16166

And would love it if someone could have a look at ticket 14082 [2].

If not, ah well. :-)

Best,
--Stephen Burrows

[1] 
http://groups.google.com/group/django-developers/browse_thread/thread/abc6cf0450812d82?pli=1
[2] https://code.djangoproject.com/ticket/14082

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Aymeric Augustin]

Hello,

I would like a core dev's opinion on #11555.

The tickets I reviewed are listed here: http://myks.org/stuff/django_5-for-1.txt

Thanks,

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jonas H.]

On 04/25/2011 05:33 PM, Jacob Kaplan-Moss wrote:

On Mon, Apr 25, 2011 at 10:28 AM, Jonas H.  wrote:

I'd like you to look into http://code.djangoproject.com/ticket/15696.


Done. Unfortunately, the result's probably not what you wanted. If
you'd like to re-use your review wuffie I'd happily take a look at
something else instead; just let me know.


That's nice, then please have a look at 
http://code.djangoproject.com/ticket/15799.


--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Mon, Apr 25, 2011 at 10:28 AM, Jonas H.  wrote:
> I'd like you to look into http://code.djangoproject.com/ticket/15696.

Done. Unfortunately, the result's probably not what you wanted. If
you'd like to re-use your review wuffie I'd happily take a look at
something else instead; just let me know.

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

[5-for-1] Review request

[Jonas H.]

Here's what I reviewed:

http://code.djangoproject.com/ticket/15783
http://code.djangoproject.com/ticket/15774
http://code.djangoproject.com/ticket/15801
http://code.djangoproject.com/ticket/15896
http://code.djangoproject.com/ticket/15895

I'd like you to look into http://code.djangoproject.com/ticket/15696.

Thanks!
Jonas

--
You received this message because you are subscribed to the Google Groups "Django 
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Gabriel Hurley]

I noticed the "TODO" on the bottom of that page you linked... if you 
actually want to write something up for the docs about reviewing tickets 
(based on the discussion that's happened on the list the last few days) I'd 
suggest adding it to the /docs/howto/contribute section. Feel free to ping 
me if you get a patch written and I'll work with you on getting it in.

- Gabriel

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Fri, Apr 22, 2011 at 3:26 AM, Aymeric Augustin
 wrote:
> I have retroactively added 5 tickets for Alex's review, plus 5 tickets that
> I'd like to trade against a review of #15255, especially the second comment.

Done!

BTW, I'm pretty sure Alex was joking about you needing to do five
more, so double thanks. I really appreciate it - let's keep it up!

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Aymeric Augustin]

2011/4/21 Alex Gaynor <alex.gay...@gmail.com>

> As did I, do we have to retroactively require more reviews ;)
>

I'm now tracking my 5-for-1 deals here:
http://myks.org/stuff/django_5-for-1.txt

I have retroactively added 5 tickets for Alex's review, plus 5 tickets that
I'd like to trade against a review of #15255, especially the second comment.
Thanks!

By the way, we're down to 6 unreviewed tickets. Not everyone claims his
reviews :)

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Alex Gaynor]

On Thu, Apr 21, 2011 at 11:46 AM, Jacob Kaplan-Moss wrote:

> On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin
>  wrote:
> > I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd
> like
> > someone to take a look at #14091.
>
> Done - thank you! I left comments on the ticket.
>
> Jacob
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.
>
>

As did I, do we have to retroactively require more reviews ;)

Alex


-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Re: [5-for-1] Review request

[Jacob Kaplan-Moss]

On Thu, Apr 21, 2011 at 8:05 AM, Aymeric Augustin
 wrote:
> I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like
> someone to take a look at #14091.

Done - thank you! I left comments on the ticket.

Jacob

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

[5-for-1] Review request

[Aymeric Augustin]

Hello,

I suggest we gather review requests on this thread to make the core devs'
job easier (that is, until the thread becomes too long).

I reviewed 5 new tickets: #15782, #15792, #15793, #15795, #15798. I'd like
someone to take a look at #14091.

Best regards,

-- 
Aymeric Augustin.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.