Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  aaugustin
   Type:  New| Status:  closed
  feature|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution:  fixed  |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by lukeplant):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16160]:
 {{{
 #!CommitTicketReference repository="" revision="16160"
 Fixed #15954 - New IGNORABLE_404_URLS setting that allows more powerful
 filtering of 404s to ignore

 Thanks to aaugustin for implementing this.

 (Technically this doesn't fix the original report, as we've decided
 against
 having *any* default values, but the new feature makes it possible, and
 the
 docs have an example addressing #15954).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  aaugustin
   Type:  New| Status:  new
  feature|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution: |  Has patch:  1
   Triage Stage:  Ready for  |Needs tests:  0
  checkin|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by lukeplant):

 * stage:  Accepted => Ready for checkin


Comment:

 I think it's fine to put the warning in the place you've done it, putting
 it in  `django/conf/__init__.py`

 And given that we've decided to warn people if these old settings are non-
 empty, it wouldn't make sense for them to be non-empty by default, so that
 backwards incompatibility is also fine.

 So marking as RFC accordingly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
---+--
   Reporter:  PaulM|  Owner:  aaugustin
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Core (Other)
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:  middleware
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+--
Changes (by aaugustin):

 * needs_better_patch:  1 => 0


Comment:

 Here is a new patch that implements the deprecation path.

 In fact, there are two places where we could raise the
 `PendingDeprecationWarning`:

 - when the settings are used: this is what I have done. A warning will be
 emitted for every 404 when `SEND_BROKEN_LINK_EMAILS` is `True` and `DEBUG`
 is `False`. It will be written in the server log.
 - when the settings are loaded: this would be a bigger change. In
 `django/conf/__init__.py`, we would emit the warning, compile
 `IGNORABLE_404_STARTS/ENDS` to regexps and append them to
 `IGNORABLE_404_URLS`. It has the advantage that the warning will also be
 visible under `./manage runserver`, but I am not sure it is worth it.

 There is still one backwards-incompatible change that will immediately
 appear in 1.4: the default value changes. Arguably, it's a bug fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
---+--
   Reporter:  PaulM|  Owner:  aaugustin
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Core (Other)
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:  middleware
   Triage Stage:  Accepted |  Has patch:  1
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  1|  Easy pickings:  0
---+--
Changes (by lukeplant):

 * needs_better_patch:  0 => 1
 * type:  Cleanup/optimization => New feature


Comment:

 Good work, here's my review:

 Even though it is trivial to replace IGNORABLE_404_STARTS/ENDS with
 IGNORABLE_404_URLS, our deprecation/backwards compatibility policy means
 we should keep supporting the former until we completely remove them two
 versions later. This is consistent with how we've handled `DATABASE_*` ->
 DATABASES (which is actually a simpler change as it doesn't change
 functionality).

 So we need the existing settings to carry on working. We should also emit
 a `PendingDeprecation` warning if they are non-empty.

 We also need this adding to the deprecation timeline under Django 1.6.

 One nit in documentation:  "of if you want to keep the old default value"
 should start **or** not **of**.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  aaugustin
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by aaugustin):

 * has_patch:  0 => 1


Comment:

 Attached patch implements lukeplant's suggestion.

 Bonus: I added tests for the 404 reporting by email—there wasn't any.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  aaugustin
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution: |  Has patch:  0
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by aaugustin):

 * owner:  nobody => aaugustin
 * stage:  Design decision needed => Accepted


Comment:

 Given that the idea was suggested by a core developers, that there were 2
 +1 from the community on django-devs, and that no one opposed the idea,
 I'll mark it as accepted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution: |  Has patch:  0
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by lukeplant):

 One possible solution:

  - deprecate IGNORABLE_404_STARTS and IGNORABLE_404_ENDS
  - replace with IGNORABLE_404_URLS, which:
- uses regular expressions (compiled or otherwise), allowing us to
 match the apple-touch-icon-* requests and others
- defaults to an empty list, so that we are not making decisions about
 whether a site should have robots.txt etc. or not
- possibly has a commented out line in the project template that
 includes a sensible set of defaults, so it is easy for people to enable.
 Alternatively we could put the list in the docs, as Aymeric (aaugustin)
 suggests.

 A quick discussion on django-devs is needed, though, I think.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
-+-
   Reporter:  PaulM  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:  middleware
 Resolution: |  Has patch:  0
   Triage Stage:  Design |Needs tests:  0
  decision needed|  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by aaugustin):

 * needs_docs:   => 0
 * stage:  Unreviewed => Design decision needed
 * easy:  1 => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 The current default value is `IGNORABLE_404_ENDS = ('mail.pl',
 'mailform.pl', 'mail.cgi', 'mailform.cgi', 'favicon.ico', '.php')`.

 It would make sense to ignore `apple-touch-icon-precomposed.png` and
 `apple-touch-icon.png`, but that will not be enough, since iDevices will
 try `apple-touch-icon-x-precomposed.png` and `apple-touch-
 icon-x.png` first starting with iOS 4.2.

 See the documentation here:
 
https://developer.apple.com/library/safari/#documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

 While we are on this topic, maybe `crossdomain.xml` (Flash) and
 `robots.txt` should be ignored too.

 Since all this is pretty debatable, an alternative solution would be to
 remove the default value for this settings. (Do I want to be notified that
 I did not create a robots.txt? Or a favicon.ico? Well, that completely
 depends on the goals of my website.) In practice, that would mean
 providing an empty tuple as the default value and suggesting a list of
 common offenders in the documentation: if you haven't created a
 favicon.ico, robots.txt, etc. add these files to `IGNORABLE_404_ENDS`.

 For the record, there is also `IGNORABLE_404_STARTS = ('/cgi-bin/',
 '/_vti_bin', '/_vti_inf')`. Both settings should be handled consistently.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15954: Django's ignorable 404 list should include iphone favicons

[Django]

#15954: Django's ignorable 404 list should include iphone favicons
--+--
 Reporter:  PaulM |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Milestone:|  Component:  Core (Other)
  Version:  1.3   |   Severity:  Normal
 Keywords:  middleware|   Triage Stage:  Unreviewed
Has patch:  0 |  Easy pickings:  1
--+--
 The ignorable 404 list in global_settings should include some patterns to
 suppress the awful racket that iphones can make when hitting a site.

 Specifically, the IGNORABLE_404_STARTS setting should include 'apple-
 touch-icon.png' for sure.

 It's debatable if it should also include '/m/', '/mobi/, '/mobile/',
 '/iphone/', and /pda/. I'm not sure if those are a bot, or actually some
 versions of the phone itself, but 404s for those urls are pretty common.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.