Re: [PATCH V3] staging: ks7010: use netdev_* instead of printk()

[Joe Perches]

On Mon, 2016-10-10 at 11:14 +0530, Sabitha George wrote:
> 1. Fixes checkpatch warning on printk usage in ks_hostif.c
> 2. Dropped "ks_wlan" prefix from the messages
> 3. Removed the "Memory squeeze,dropping packet" messages
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c 
> b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -549,7 +545,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
>   dev->dev_addr[5] = priv->eth_addr[5];
>   dev->dev_addr[6] = 0x00;
>   dev->dev_addr[7] = 0x00;
> - printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", 
> priv->eth_addr);
> + netdev_info(dev, "MAC ADDRESS = %pM\n",
> + priv->eth_addr);

Do please use all 80 columns where possible.

netdev_info(dev, "MAC ADDRESS = %pM\n", priv->eth_addr);

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH V3] staging: ks7010: use netdev_* instead of printk()

[Sabitha George]

1. Fixes checkpatch warning on printk usage in ks_hostif.c
2. Dropped "ks_wlan" prefix from the messages
3. Removed the "Memory squeeze,dropping packet" messages

Signed-off-by: Sabitha George 
---
 drivers/staging/ks7010/ks_hostif.c | 23 ++-
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index 5714cf7..e1188c0 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -465,8 +465,6 @@ void hostif_data_indication(struct ks_wlan_private *priv)
skb->dev->last_rx = jiffies;
netif_rx(skb);
} else {
-   printk(KERN_WARNING
-  "ks_wlan: Memory squeeze, dropping packet.\n");
priv->nstats.rx_dropped++;
}
break;
@@ -500,8 +498,6 @@ void hostif_data_indication(struct ks_wlan_private *priv)
skb->dev->last_rx = jiffies;
netif_rx(skb);
} else {
-   printk(KERN_WARNING
-  "ks_wlan: Memory squeeze, dropping packet.\n");
priv->nstats.rx_dropped++;
}
break;
@@ -549,7 +545,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
dev->dev_addr[5] = priv->eth_addr[5];
dev->dev_addr[6] = 0x00;
dev->dev_addr[7] = 0x00;
-   printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", 
priv->eth_addr);
+   netdev_info(dev, "MAC ADDRESS = %pM\n",
+   priv->eth_addr);
break;
case DOT11_PRODUCT_VERSION:
/* firmware version */
@@ -557,8 +554,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
priv->version_size = priv->rx_size;
memcpy(priv->firmware_version, priv->rxp, priv->rx_size);
priv->firmware_version[priv->rx_size] = '\0';
-   printk(KERN_INFO "ks_wlan: firmware ver. = %s\n",
-  priv->firmware_version);
+   netdev_info(dev, "firmware ver. = %s\n",
+   priv->firmware_version);
hostif_sme_enqueue(priv, SME_GET_PRODUCT_VERSION);
/* wake_up_interruptible_all(>confirm_wait); */
complete(>confirm_wait);
@@ -578,12 +575,12 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
} else if (priv->eeprom_sum.type == 1) {
if (priv->eeprom_sum.result == 0) {
priv->eeprom_checksum = EEPROM_NG;
-   printk("LOCAL_EEPROM_SUM NG\n");
+   netdev_info(dev, "LOCAL_EEPROM_SUM NG\n");
} else if (priv->eeprom_sum.result == 1) {
priv->eeprom_checksum = EEPROM_OK;
}
} else {
-   printk("LOCAL_EEPROM_SUM error!\n");
+   netdev_err(dev, "LOCAL_EEPROM_SUM error!\n");
}
break;
default:
@@ -880,7 +877,7 @@ void hostif_stop_confirm(struct ks_wlan_private *priv)
netif_carrier_off(netdev);
tmp = FORCE_DISCONNECT & priv->connect_status;
priv->connect_status = tmp | DISCONNECT_STATUS;
-   printk("IWEVENT: disconnect\n");
+   netdev_info(netdev, "IWEVENT: disconnect\n");
 
wrqu0.data.length = 0;
wrqu0.data.flags = 0;
@@ -890,7 +887,7 @@ void hostif_stop_confirm(struct ks_wlan_private *priv)
&& (old_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
eth_zero_addr(wrqu0.ap_addr.sa_data);
DPRINTK(3, "IWEVENT: disconnect\n");
-   printk("IWEVENT: disconnect\n");
+   netdev_info(netdev, "IWEVENT: disconnect\n");
DPRINTK(3, "disconnect :: scan_ind_count=%d\n",
priv->scan_ind_count);
wireless_send_event(netdev, SIOCGIWAP, , NULL);
@@ -1096,7 +1093,7 @@ void hostif_event_check(struct ks_wlan_private *priv)
case HIF_AP_SET_CONF:
default:
//DPRINTK(1, "undefined event[%04X]\n", event);
-   printk("undefined event[%04X]\n", event);
+   netdev_err(priv->net_dev, "undefined event[%04X]\n", event);
/* wake_up_all(>confirm_wait); */
complete(>confirm_wait);
break;
@@ -2644,7 +2641,7 @@ void hostif_sme_enqueue(struct ks_wlan_private *priv, 
unsigned short event)
} else {
/* in case of buffer overflow */
//DPRINTK(2,"sme queue buffer overflow\n");
-

Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()

[Greg KH]

On Sun, Oct 09, 2016 at 10:46:26AM -0700, Joe Perches wrote:
> On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote:
> > Fixes checkpatch warning on printk usage in ks_hostif.c
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c 
> > b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private 
> > *priv)
> > skb->dev->last_rx = jiffies;
> > netif_rx(skb);
> > } else {
> > -   printk(KERN_WARNING
> > -  "ks_wlan: Memory squeeze, dropping packet.\n");
> > +   netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, 
> > dropping packet.\n");
> 
> You could probably drop all the "ks_wlan: " prefixes here
> and the rx_dropped increase generally removes the need
> for a non-rate-limited warning message so these
> memory squeeze messages could be removed as well.

I agree, ks_wlan: should be removed.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: rtl8188eu: fix Block comments warning found by checkpatch.

[victor carvajal]

WARNING: Block comments use * on subsequent lines

Signed-off-by: victor carvajal 
---
 drivers/staging/rtl8188eu/include/rtw_event.h | 39 +--
 1 file changed, 19 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/rtw_event.h 
b/drivers/staging/rtl8188eu/include/rtw_event.h
index df68948..11e048f 100644
--- a/drivers/staging/rtl8188eu/include/rtw_event.h
+++ b/drivers/staging/rtl8188eu/include/rtw_event.h
@@ -22,42 +22,41 @@
 #include 
 
 /*
-Used to report a bss has been scanned
-*/
+ * Used to report a bss has been scanned
+ */
 struct survey_event{
struct wlan_bssid_ex bss;
 };
 
 /*
-Used to report that the requested site survey has been done.
-
-bss_cnt indicates the number of bss that has been reported.
-
-
-*/
+ *   Used to report that the requested site survey has been done.
+ *
+ * bss_cnt indicates the number of bss that has been reported.
+ *
+ */
 struct surveydone_event {
unsigned intbss_cnt;
 
 };
 
 /*
-Used to report the link result of joinning the given bss
-
-
-join_res:
--1: authentication fail
--2: association fail
-> 0: TID
-
-*/
+ * Used to report the link result of joinning the given bss
+ *
+ *
+ *join_res:
+ * -1: authentication fail
+ *-2: association fail
+ *> 0: TID
+ *
+ */
 struct joinbss_event {
struct  wlan_networknetwork;
 };
 
 /*
-Used to report a given STA has joinned the created BSS.
-It is used in AP/Ad-HoC(M) mode.
-*/
+ *Used to report a given STA has joinned the created BSS.
+ *It is used in AP/Ad-HoC(M) mode.
+ */
 
 struct stassoc_event {
unsigned char macaddr[6];
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] RFC: staging: greybus: shape up greybus GPIO

[Linus Walleij]

Greybus GPIO seems to reimplement the already existing generic
gpiolib irqchip. Also use gpiochip_get_data(). Also use
devm_gpiochip_add_data().

Cc: Viresh Kumar 
Cc: Axel Haslam 
Cc: Johan Hovold 
Cc: Sandeep Patil 
Cc: Rui Miguel Silva 
Cc: Greg Kroah-Hartman 
Signed-off-by: Linus Walleij 
---
Greybus folks: please look at this. I expect something like this
to be applied before migrating from staging, I can't test it
obviously.
---
 drivers/staging/greybus/gpio.c | 183 ++---
 1 file changed, 23 insertions(+), 160 deletions(-)

diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 5e06e4229e42..07ccd819ee1c 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -10,7 +10,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -41,14 +41,8 @@ struct gb_gpio_controller {
struct gpio_chipchip;
struct irq_chip irqc;
struct irq_chip *irqchip;
-   struct irq_domain   *irqdomain;
-   unsigned intirq_base;
-   irq_flow_handler_t  irq_handler;
-   unsigned intirq_default_type;
struct mutexirq_lock;
 };
-#define gpio_chip_to_gb_gpio_controller(chip) \
-   container_of(chip, struct gb_gpio_controller, chip)
 #define irq_data_to_gpio_chip(d) (d->domain->host_data)
 
 static int gb_gpio_line_count_operation(struct gb_gpio_controller *ggc)
@@ -277,7 +271,7 @@ static void _gb_gpio_irq_set_type(struct gb_gpio_controller 
*ggc,
 static void gb_gpio_irq_mask(struct irq_data *d)
 {
struct gpio_chip *chip = irq_data_to_gpio_chip(d);
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
struct gb_gpio_line *line = >lines[d->hwirq];
 
line->masked = true;
@@ -287,7 +281,7 @@ static void gb_gpio_irq_mask(struct irq_data *d)
 static void gb_gpio_irq_unmask(struct irq_data *d)
 {
struct gpio_chip *chip = irq_data_to_gpio_chip(d);
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
struct gb_gpio_line *line = >lines[d->hwirq];
 
line->masked = false;
@@ -297,7 +291,7 @@ static void gb_gpio_irq_unmask(struct irq_data *d)
 static int gb_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 {
struct gpio_chip *chip = irq_data_to_gpio_chip(d);
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
struct gb_gpio_line *line = >lines[d->hwirq];
struct device *dev = >gbphy_dev->dev;
u8 irq_type;
@@ -335,7 +329,7 @@ static int gb_gpio_irq_set_type(struct irq_data *d, 
unsigned int type)
 static void gb_gpio_irq_bus_lock(struct irq_data *d)
 {
struct gpio_chip *chip = irq_data_to_gpio_chip(d);
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
 
mutex_lock(>irq_lock);
 }
@@ -343,7 +337,7 @@ static void gb_gpio_irq_bus_lock(struct irq_data *d)
 static void gb_gpio_irq_bus_sync_unlock(struct irq_data *d)
 {
struct gpio_chip *chip = irq_data_to_gpio_chip(d);
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
struct gb_gpio_line *line = >lines[d->hwirq];
 
if (line->irq_type_pending) {
@@ -392,7 +386,7 @@ static int gb_gpio_request_handler(struct gb_operation *op)
return -EINVAL;
}
 
-   irq = irq_find_mapping(ggc->irqdomain, event->which);
+   irq = irq_find_mapping(ggc->chip.irqdomain, event->which);
if (!irq) {
dev_err(dev, "failed to find IRQ\n");
return -EINVAL;
@@ -412,21 +406,21 @@ static int gb_gpio_request_handler(struct gb_operation 
*op)
 
 static int gb_gpio_request(struct gpio_chip *chip, unsigned offset)
 {
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
 
return gb_gpio_activate_operation(ggc, (u8)offset);
 }
 
 static void gb_gpio_free(struct gpio_chip *chip, unsigned offset)
 {
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+   struct gb_gpio_controller *ggc = gpiochip_get_data(chip);
 
gb_gpio_deactivate_operation(ggc, (u8)offset);
 }
 
 static int gb_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
 {
-   struct gb_gpio_controller *ggc = gpio_chip_to_gb_gpio_controller(chip);
+ 

[PATCH] drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issues

[Chase Metzger]

Added braces to else statement where checkpatch complained.

Signed-off-by: Chase Metzger 
---
 drivers/staging/greybus/audio_codec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_codec.c 
b/drivers/staging/greybus/audio_codec.c
index 8a0744b..1bdf849 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -655,8 +655,10 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, 
int mute, int stream)
ret = gb_audio_apbridgea_shutdown_rx(data->connection,
 0);
params->state = GBAUDIO_CODEC_STOP;
-   } else
+   } else {
ret = -EINVAL;
+   }
+
if (ret)
dev_err_ratelimited(dai->dev,
"%s:Error during %s %s stream:%d\n",
-- 
2.1.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/3] staging: ks7010: fix block comment style in ks7010_stdio.c

[Akshay Mariyanna]

This fixes the following checkpatch warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate lines

Signed-off-by: Akshay Mariyanna 
---
 drivers/staging/ks7010/ks7010_sdio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
b/drivers/staging/ks7010/ks7010_sdio.c
index a37cadf..6ae125c 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -495,8 +495,9 @@ static void ks7010_rw_function(struct work_struct *work)
/* wiat after WAKEUP */
while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
DPRINTK(4, "wait after WAKEUP\n");
-/* 
queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,>ks_wlan_hw.rw_wq,
-   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
+   /* 
queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,>ks_wlan_hw.rw_wq,
+* (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
+*/
dev_info(>ks_wlan_hw.sdio_card->func->dev,
 "wake: %lu %lu\n",
 priv->last_wakeup + (30 * HZ) / 1000,
-- 
2.10.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] staging: ks7010: fix space related style issues in ks7010_sdio.c

[Akshay Mariyanna]

This fixes the following checkpatch warnings:
WARNING: Unnecessary space before function pointer arguments
WARNING: unnecessary whitespace before a quoted newline

Signed-off-by: Akshay Mariyanna 
---
 drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
b/drivers/staging/ks7010/ks7010_sdio.c
index 6ae125c..4f5a486 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -254,7 +254,7 @@ int ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 
 static int enqueue_txdev(struct ks_wlan_private *priv, unsigned char *p,
 unsigned long size,
-void (*complete_handler) (void *arg1, void *arg2),
+void (*complete_handler)(void *arg1, void *arg2),
 void *arg1, void *arg2)
 {
struct tx_device_buffer *sp;
@@ -353,7 +353,7 @@ static void tx_device_task(void *dev)
 }
 
 int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p, unsigned long size,
- void (*complete_handler) (void *arg1, void *arg2),
+ void (*complete_handler)(void *arg1, void *arg2),
  void *arg1, void *arg2)
 {
int result = 0;
@@ -413,7 +413,7 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
/* receive data */
if (cnt_rxqbody(priv) >= (RX_DEVICE_BUFF_SIZE - 1)) {
/* in case of buffer overflow */
-   DPRINTK(1, "rx buffer overflow \n");
+   DPRINTK(1, "rx buffer overflow\n");
goto error_out;
}
rx_buffer = >rx_dev.rx_dev_buff[priv->rx_dev.qtail];
-- 
2.10.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] staging: ks7010: fix indent style in ks7010_sdio.c

[Akshay Mariyanna]

This patch fixes the following checkpatch error:
ERROR: code indent should use tabs where possible

Signed-off-by: Akshay Mariyanna 
---
 drivers/staging/ks7010/ks7010_sdio.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c 
b/drivers/staging/ks7010/ks7010_sdio.c
index 1f97161..a37cadf 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
 /* macro */
 
 #define inc_txqhead(priv) \
-(priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
+   (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
 #define inc_txqtail(priv) \
-(priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE)
+   (priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE)
 #define cnt_txqbody(priv) \
-(((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % 
TX_DEVICE_BUFF_SIZE)
+   (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % 
TX_DEVICE_BUFF_SIZE)
 
 #define inc_rxqhead(priv) \
-(priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE)
+   (priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE)
 #define inc_rxqtail(priv) \
-(priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE)
+   (priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE)
 #define cnt_rxqbody(priv) \
-(((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % 
RX_DEVICE_BUFF_SIZE)
+   (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % 
RX_DEVICE_BUFF_SIZE)
 
 static int ks7010_sdio_read(struct ks_wlan_private *priv, unsigned int address,
unsigned char *buffer, int length)
-- 
2.10.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()

[Joe Perches]

On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote:
> Fixes checkpatch warning on printk usage in ks_hostif.c
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c 
> b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
>   skb->dev->last_rx = jiffies;
>   netif_rx(skb);
>   } else {
> - printk(KERN_WARNING
> -"ks_wlan: Memory squeeze, dropping packet.\n");
> + netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, 
> dropping packet.\n");

You could probably drop all the "ks_wlan: " prefixes here
and the rx_dropped increase generally removes the need
for a non-rate-limited warning message so these
memory squeeze messages could be removed as well.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH V2] staging: ks7010: use netdev_* instead of printk()

[Sabitha George]

Fixes checkpatch warning on printk usage in ks_hostif.c

Signed-off-by: Sabitha George 
---
 drivers/staging/ks7010/ks_hostif.c | 25 -
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index 5714cf7..1d62033 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
skb->dev->last_rx = jiffies;
netif_rx(skb);
} else {
-   printk(KERN_WARNING
-  "ks_wlan: Memory squeeze, dropping packet.\n");
+   netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, 
dropping packet.\n");
priv->nstats.rx_dropped++;
}
break;
@@ -500,8 +499,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
skb->dev->last_rx = jiffies;
netif_rx(skb);
} else {
-   printk(KERN_WARNING
-  "ks_wlan: Memory squeeze, dropping packet.\n");
+   netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, 
dropping packet.\n");
priv->nstats.rx_dropped++;
}
break;
@@ -549,7 +547,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
dev->dev_addr[5] = priv->eth_addr[5];
dev->dev_addr[6] = 0x00;
dev->dev_addr[7] = 0x00;
-   printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", 
priv->eth_addr);
+   netdev_info(dev, "ks_wlan: MAC ADDRESS = %pM\n",
+   priv->eth_addr);
break;
case DOT11_PRODUCT_VERSION:
/* firmware version */
@@ -557,8 +556,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
priv->version_size = priv->rx_size;
memcpy(priv->firmware_version, priv->rxp, priv->rx_size);
priv->firmware_version[priv->rx_size] = '\0';
-   printk(KERN_INFO "ks_wlan: firmware ver. = %s\n",
-  priv->firmware_version);
+   netdev_info(dev, "ks_wlan: firmware ver. = %s\n",
+   priv->firmware_version);
hostif_sme_enqueue(priv, SME_GET_PRODUCT_VERSION);
/* wake_up_interruptible_all(>confirm_wait); */
complete(>confirm_wait);
@@ -578,12 +577,12 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
} else if (priv->eeprom_sum.type == 1) {
if (priv->eeprom_sum.result == 0) {
priv->eeprom_checksum = EEPROM_NG;
-   printk("LOCAL_EEPROM_SUM NG\n");
+   netdev_info(dev, "LOCAL_EEPROM_SUM NG\n");
} else if (priv->eeprom_sum.result == 1) {
priv->eeprom_checksum = EEPROM_OK;
}
} else {
-   printk("LOCAL_EEPROM_SUM error!\n");
+   netdev_err(dev, "LOCAL_EEPROM_SUM error!\n");
}
break;
default:
@@ -880,7 +879,7 @@ void hostif_stop_confirm(struct ks_wlan_private *priv)
netif_carrier_off(netdev);
tmp = FORCE_DISCONNECT & priv->connect_status;
priv->connect_status = tmp | DISCONNECT_STATUS;
-   printk("IWEVENT: disconnect\n");
+   netdev_info(netdev, "IWEVENT: disconnect\n");
 
wrqu0.data.length = 0;
wrqu0.data.flags = 0;
@@ -890,7 +889,7 @@ void hostif_stop_confirm(struct ks_wlan_private *priv)
&& (old_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
eth_zero_addr(wrqu0.ap_addr.sa_data);
DPRINTK(3, "IWEVENT: disconnect\n");
-   printk("IWEVENT: disconnect\n");
+   netdev_info(netdev, "IWEVENT: disconnect\n");
DPRINTK(3, "disconnect :: scan_ind_count=%d\n",
priv->scan_ind_count);
wireless_send_event(netdev, SIOCGIWAP, , NULL);
@@ -1096,7 +1095,7 @@ void hostif_event_check(struct ks_wlan_private *priv)
case HIF_AP_SET_CONF:
default:
//DPRINTK(1, "undefined event[%04X]\n", event);
-   printk("undefined event[%04X]\n", event);
+   netdev_err(priv->net_dev, "undefined event[%04X]\n", event);
/* wake_up_all(>confirm_wait); */
complete(>confirm_wait);
break;
@@ -2644,7 +2643,7 @@ void hostif_sme_enqueue(struct ks_wlan_private *priv, 
unsigned short event)
} else {

[PATCH v2 9/9] staging: wlan-ng: fix block comments style in prism2mgmt.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in prism2mgmt.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2mgmt.h | 122 ++-
 1 file changed, 62 insertions(+), 60 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.h 
b/drivers/staging/wlan-ng/prism2mgmt.h
index 567820f..88b979f 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -1,61 +1,61 @@
 /* prism2mgmt.h
-*
-* Declares the mgmt command handler functions
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file contains the constants and data structures for interaction
-* with the hfa384x Wireless LAN (WLAN) Media Access Controller (MAC).
-* The hfa384x is a portion of the Harris PRISM(tm) WLAN chipset.
-*
-* [Implementation and usage notes]
-*
-* [References]
-*   CW10 Programmer's Manual v1.5
-*   IEEE 802.11 D10.0
-*
-*
-*/
+ *
+ * Declares the mgmt command handler functions
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * This file contains the constants and data structures for interaction
+ * with the hfa384x Wireless LAN (WLAN) Media Access Controller 

[PATCH v2 2/9] staging: wlan-ng: fix block comments style in p80211hdr.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211hdr.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211hdr.h | 114 ++--
 1 file changed, 57 insertions(+), 57 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211hdr.h 
b/drivers/staging/wlan-ng/p80211hdr.h
index 79d9b20..c9b7337 100644
--- a/drivers/staging/wlan-ng/p80211hdr.h
+++ b/drivers/staging/wlan-ng/p80211hdr.h
@@ -1,61 +1,61 @@
 /* p80211hdr.h
-*
-* Macros, types, and functions for handling 802.11 MAC headers
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file declares the constants and types used in the interface
-* between a wlan driver and the user mode utilities.
-*
-* Note:
-*  - Constant values are always in HOST byte order.  To assign
-*values to multi-byte fields they _must_ be converted to
-*ieee byte order.  To retrieve multi-byte values from incoming
-*frames, they must be converted to host order.
-*
-* All functions declared here are implemented in p80211.c
-* 
-*/
+ *
+ * Macros, types, and functions for handling 802.11 MAC headers
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * 

[PATCH v2 5/9] staging: wlan-ng: fix block comments style in p80211mgmt.h

[Sergio Paracuellos]

 This patch fixes the following checkpatch.pl warning in p80211mgmt.h:
 Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211mgmt.h | 194 +--
 1 file changed, 97 insertions(+), 97 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211mgmt.h 
b/drivers/staging/wlan-ng/p80211mgmt.h
index 3dd066a..653950f 100644
--- a/drivers/staging/wlan-ng/p80211mgmt.h
+++ b/drivers/staging/wlan-ng/p80211mgmt.h
@@ -1,101 +1,101 @@
 /* p80211mgmt.h
-*
-* Macros, types, and functions to handle 802.11 mgmt frames
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file declares the constants and types used in the interface
-* between a wlan driver and the user mode utilities.
-*
-* Notes:
-*  - Constant values are always in HOST byte order.  To assign
-*values to multi-byte fields they _must_ be converted to
-*ieee byte order.  To retrieve multi-byte values from incoming
-*frames, they must be converted to host order.
-*
-*  - The len member of the frame structure does NOT!!! include
-*the MAC CRC.  Therefore, the len field on rx'd frames should
-*have 4 subtracted from it.
-*
-* All functions declared here are implemented in p80211.c
-*
-* The types, macros, and functions defined here are primarily
-* used for encoding and decoding management frames.  They are
-* designed to follow these patterns of use:
-*
-* DECODE:
-* 1) a frame of length len is received into buffer b
-* 2) using the hdr structure and macros, we determine the type
-* 3) an appropriate mgmt frame structure, mf, is allocated and zeroed
-* 4) mf.hdr = b
-*mf.buf = b
-*mf.len = len
-* 5) call mgmt_decode( mf )
-* 6) the frame field pointers in mf are now set.  Note that any
-*multi-byte frame field values accessed using the frame field
-*pointers are in ieee byte order and will have to be converted
-*to host order.
-*
-* ENCODE:
-* 1) Library client allocates buffer space for maximum length
-*frame of the desired type
-* 2) Library client allocates a mgmt frame structure, called mf,
-*of the desired type
-* 3) Set the following:
-*mf.type = 
-*mf.buf = 
-* 4) call mgmt_encode( mf )
-* 5) all of the fixed field pointers and fixed length information element
-*pointers in mf are now set to their respective locations in the
-*allocated space (fortunately, all variable length information elements
-*fall at the end of their respective frames).
-* 5a) The length field is set to include the last of the fixed and fixed
-* length fields.  It may have to be updated for optional or variable
-*  length information elements.
-* 6) Optional and variable length information elements are special cases
-*and must be handled individually by the client code.
-* 
-*/
+ *
+ * Macros, types, and functions to handle 802.11 mgmt frames
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The 

[PATCH v2 6/9] staging: wlan-ng: fix block comments style in p80211msg.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211msg.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211msg.h | 90 ++---
 1 file changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211msg.h 
b/drivers/staging/wlan-ng/p80211msg.h
index 43d2f97..40c5cf5 100644
--- a/drivers/staging/wlan-ng/p80211msg.h
+++ b/drivers/staging/wlan-ng/p80211msg.h
@@ -1,49 +1,49 @@
 /* p80211msg.h
-*
-* Macros, constants, types, and funcs for req and ind messages
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*/
+ *
+ * Macros, constants, types, and funcs for req and ind messages
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ */
 
 #ifndef _P80211MSG_H
 #define _P80211MSG_H
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 8/9] staging: wlan-ng: fix block comments style in p80211req.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211req.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211req.h | 90 ++---
 1 file changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211req.h 
b/drivers/staging/wlan-ng/p80211req.h
index 8d3054c..6c72f59 100644
--- a/drivers/staging/wlan-ng/p80211req.h
+++ b/drivers/staging/wlan-ng/p80211req.h
@@ -1,49 +1,49 @@
 /* p80211req.h
-*
-* Request handling functions
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*/
+ *
+ * Request handling functions
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ */
 
 #ifndef _LINUX_P80211REQ_H
 #define _LINUX_P80211REQ_H
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 7/9] staging: wlan-ng: fix block comments style in p80211netdev.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211netdev.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211netdev.h | 100 -
 1 file changed, 50 insertions(+), 50 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.h 
b/drivers/staging/wlan-ng/p80211netdev.h
index 1e6a774..972e076 100644
--- a/drivers/staging/wlan-ng/p80211netdev.h
+++ b/drivers/staging/wlan-ng/p80211netdev.h
@@ -1,54 +1,54 @@
 /* p80211netdev.h
-*
-* WLAN net device structure and functions
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file declares the structure type that represents each wlan
-* interface.
-*
-* 
-*/
+ *
+ * WLAN net device structure and functions
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * This file declares the structure type that represents each wlan
+ * interface.
+ *
+ * 
+ */
 
 #ifndef _LINUX_P80211NETDEV_H
 #define _LINUX_P80211NETDEV_H
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org

[PATCH v2 4/9] staging: wlan-ng: fix block comments style in p80211metadef.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211metadef.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211metadef.h | 88 -
 1 file changed, 44 insertions(+), 44 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211metadef.h 
b/drivers/staging/wlan-ng/p80211metadef.h
index b0d3567..ea3d9ce 100644
--- a/drivers/staging/wlan-ng/p80211metadef.h
+++ b/drivers/staging/wlan-ng/p80211metadef.h
@@ -1,48 +1,48 @@
 /* This file is GENERATED AUTOMATICALLY.  DO NOT EDIT OR MODIFY.
-* 
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*/
+ * 
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ */
 
 #ifndef _P80211MKMETADEF_H
 #define _P80211MKMETADEF_H
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 0/9] staging: wlan-ng: fix block comments style warning in header files

[Sergio Paracuellos]

This patch series fix checkpatch.pl script reported warning
Block comments should align the * on each line

Changes v2:
* Fix commit subject from wlang-ng to wlan-ng

Sergio Paracuellos (9):
  staging: wlan-ng: fix block comments style in p80211conv.h
  staging: wlan-ng: fix block comments style in p80211hdr.h
  staging: wlan-ng: fix block comments style in p80211ioctl.h
  staging: wlan-ng: fix block comments style in p80211metadef.h
  staging: wlan-ng: fix block comments style in p80211mgmt.h
  staging: wlan-ng: fix block comments style in p80211msg.h
  staging: wlan-ng: fix block comments style in p80211netdev.h
  staging: wlan-ng: fix block comments style in p80211req.h
  staging: wlan-ng: fix block comments style in prism2mgmt.h

 drivers/staging/wlan-ng/p80211conv.h| 100 
 drivers/staging/wlan-ng/p80211hdr.h | 114 +--
 drivers/staging/wlan-ng/p80211ioctl.h   | 120 ++--
 drivers/staging/wlan-ng/p80211metadef.h |  88 +++
 drivers/staging/wlan-ng/p80211mgmt.h| 194 
 drivers/staging/wlan-ng/p80211msg.h |  90 +++
 drivers/staging/wlan-ng/p80211netdev.h  | 100 
 drivers/staging/wlan-ng/p80211req.h |  90 +++
 drivers/staging/wlan-ng/prism2mgmt.h| 122 ++--
 9 files changed, 510 insertions(+), 508 deletions(-)

-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/9] staging: wlan-ng: fix block comments style in p80211conv.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211conv.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211conv.h | 100 +--
 1 file changed, 50 insertions(+), 50 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211conv.h 
b/drivers/staging/wlan-ng/p80211conv.h
index 8c10357..ed70d98 100644
--- a/drivers/staging/wlan-ng/p80211conv.h
+++ b/drivers/staging/wlan-ng/p80211conv.h
@@ -1,54 +1,54 @@
 /* p80211conv.h
-*
-* Ether/802.11 conversions and packet buffer routines
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file declares the functions, types and macros that perform
-* Ethernet to/from 802.11 frame conversions.
-*
-* 
-*/
+ *
+ * Ether/802.11 conversions and packet buffer routines
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * This file declares the functions, types and macros that perform
+ * Ethernet to/from 802.11 frame conversions.
+ *
+ * 
+ */
 
 #ifndef _LINUX_P80211CONV_H
 #define _LINUX_P80211CONV_H
-- 
1.9.1

___
devel mailing list

[PATCH v2 3/9] staging: wlan-ng: fix block comments style in p80211ioctl.h

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in p80211ioctl.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211ioctl.h | 120 +-
 1 file changed, 60 insertions(+), 60 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211ioctl.h 
b/drivers/staging/wlan-ng/p80211ioctl.h
index 06c5e366..ab6067e 100644
--- a/drivers/staging/wlan-ng/p80211ioctl.h
+++ b/drivers/staging/wlan-ng/p80211ioctl.h
@@ -1,64 +1,64 @@
 /* p80211ioctl.h
-*
-* Declares constants and types for the p80211 ioctls
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-*  While this file is called 'ioctl' is purpose goes a little beyond
-*  that.  This file defines the types and contants used to implement
-*  the p80211 request/confirm/indicate interfaces on Linux.  The
-*  request/confirm interface is, in fact, normally implemented as an
-*  ioctl.  The indicate interface on the other hand, is implemented
-*  using the Linux 'netlink' interface.
-*
-*  The reason I say that request/confirm is 'normally' implemented
-*  via ioctl is that we're reserving the right to be able to send
-*  request commands via the netlink interface.  This will be necessary
-*  if we ever need to send request messages when there aren't any
-*  wlan network devices present (i.e. sending a message that only p80211
-*  cares about.
-* 
-*/
+ *
+ * Declares constants and types for the p80211 ioctls
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com

Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

[Sergio Paracuellos]

This warnings seems to be fixed in the new tree, so I don't resend anything.

El 2016年10月09日 a las 17:23, Greg KH escribió:

On Sun, Oct 09, 2016 at 05:10:31PM +0200, Sergio Paracuellos wrote:

This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
  drivers/staging/wlan-ng/prism2sta.c | 9 ++---
  1 file changed, 6 insertions(+), 3 deletions(-)


This patch doesn't apply to my tree :(


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

[Sergio Paracuellos]

Just sitting in front of my laptop :) Thanks to you for code review!

Cheers,
Sergio Paracuello

El 2016年10月09日 a las 17:36, Greg KH escribió:

On Sun, Oct 09, 2016 at 05:29:22PM +0200, Sergio Paracuellos wrote:

This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 12

Signed-off-by: Sergio Paracuellos 
---
  drivers/staging/wlan-ng/prism2fw.c | 11 ---
  1 file changed, 8 insertions(+), 3 deletions(-)


Fastest patch review turn-around time ever :)

nice work, all now applied.

greg k-h


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

[Greg KH]

On Sun, Oct 09, 2016 at 05:29:22PM +0200, Sergio Paracuellos wrote:
> This patch fix the following sparse warnings in prism2fw.c:
> warning: memset with byte count of 12
> 
> Signed-off-by: Sergio Paracuellos 
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Fastest patch review turn-around time ever :)

nice work, all now applied.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] Staging: i4l: icn: Fixed open brace should be on previous line error

[Harman Kalra]

This patch resolves the following error caught by checkpatch.pl:
ERROR: that open brace { should be on the previous line

Signed-off-by: Harman Kalra 
---
 drivers/staging/i4l/icn/icn.h |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
index e273c27..07e2e01 100644
--- a/drivers/staging/i4l/icn/icn.h
+++ b/drivers/staging/i4l/icn/icn.h
@@ -186,8 +186,7 @@
 #ifdef __KERNEL__
 
 static icn_card *cards = (icn_card *) 0;
-static u_char chan2bank[] =
-{0, 4, 8, 12};  /* for icn_map_channel() */
+static u_char chan2bank[] = {0, 4, 8, 12};  /* for 
icn_map_channel() */
 
 static icn_dev dev;
 
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/3] Staging: i4l: icn: prefer pr_* instead of printk

[Harman Kalra]

This patch replaces call to  printk with  appropriate pr_*
function thus addressing the following warning generated by the
checkpatch script:
Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then
dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: Harman Kalra 
---
 drivers/staging/i4l/icn/icn.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h
index f8f2e76..e273c27 100644
--- a/drivers/staging/i4l/icn/icn.h
+++ b/drivers/staging/i4l/icn/icn.h
@@ -54,7 +54,7 @@
 
 /* some useful macros for debugging */
 #ifdef ICN_DEBUG_PORT
-#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); 
outb_p(v, p);}
+#define OUTB_P(v, p) {pr_debug("icn: outb_p(0x%02x,0x%03x)\n", v, p); 
outb_p(v, p);}
 #else
 #define OUTB_P outb
 #endif
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] Staging: i4l: icn: Fixed open brace should be on previous line error

[Harman Kalra]

This patch resolves the following error caught by checkpatch.pl:
ERROR: that open brace { should be on the previous line

Signed-off-by: Harman Kalra 
---
 drivers/staging/i4l/icn/icn.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c
index 514bfc2..3750ba3 100644
--- a/drivers/staging/i4l/icn/icn.c
+++ b/drivers/staging/i4l/icn/icn.c
@@ -411,8 +411,7 @@
int action;
 } icn_stat;
 /* *INDENT-OFF* */
-static icn_stat icn_stat_table[] =
-{
+static icn_stat icn_stat_table[] = {
{"BCON_",  ISDN_STAT_BCONN, 1}, /* B-Channel connected*/
{"BDIS_",  ISDN_STAT_BHUP,  2}, /* B-Channel disconnected */
/*
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

[Sergio Paracuellos]

This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 12

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2fw.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c 
b/drivers/staging/wlan-ng/prism2fw.c
index 96aa211..7e33048 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -124,7 +124,7 @@ struct imgchunk {
 
 /* Data records */
 static unsigned int ns3data;
-static struct s3datarec s3data[S3DATA_MAX];
+static struct s3datarec *s3data;
 
 /* Plug records */
 static unsigned int ns3plug;
@@ -248,7 +248,12 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
 
/* Initialize the data structures */
ns3data = 0;
-   memset(s3data, 0, sizeof(s3data));
+   s3data = kcalloc(S3DATA_MAX, sizeof(*s3data), GFP_KERNEL);
+   if (!s3data) {
+   result = -ENOMEM;
+   goto out;
+   }
+
ns3plug = 0;
memset(s3plug, 0, sizeof(s3plug));
ns3crc = 0;
@@ -475,7 +480,7 @@ static void free_chunks(struct imgchunk *fchunk, unsigned 
int *nfchunks)
 static void free_srecs(void)
 {
ns3data = 0;
-   memset(s3data, 0, sizeof(s3data));
+   kfree(s3data);
ns3plug = 0;
memset(s3plug, 0, sizeof(s3plug));
ns3crc = 0;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

[Greg KH]

On Sun, Oct 09, 2016 at 05:14:52PM +0200, Sergio Paracuellos wrote:
> This patch fix the following sparse warnings in prism2fw.c:
> warning: memset with byte count of 12
> 
> Signed-off-by: Sergio Paracuellos 
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2fw.c 
> b/drivers/staging/wlan-ng/prism2fw.c
> index 96aa211..7e33048 100644
> --- a/drivers/staging/wlan-ng/prism2fw.c
> +++ b/drivers/staging/wlan-ng/prism2fw.c
> @@ -124,7 +124,7 @@ struct imgchunk {
>  
>  /* Data records */
>  static unsigned int ns3data;
> -static struct s3datarec s3data[S3DATA_MAX];
> +static struct s3datarec *s3data;
>  
>  /* Plug records */
>  static unsigned int ns3plug;
> @@ -248,7 +248,12 @@ static int prism2_fwapply(const struct ihex_binrec 
> *rfptr,
>  
>   /* Initialize the data structures */
>   ns3data = 0;
> - memset(s3data, 0, sizeof(s3data));
> + s3data = kcalloc(S3DATA_MAX, sizeof(*s3data), GFP_KERNEL);
> + if (unlikely(!s3data)) {

Unless you can measure the speed difference, NEVER use likely or
unlikely in kernel code.  The CPU and compiler knows better than you do
what is going to happen, and optimizes it.  Especially for allocating
memory, that is a very common pattern and it knows what to do here.

Please remove this and resend.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

[Greg KH]

On Sun, Oct 09, 2016 at 05:10:31PM +0200, Sergio Paracuellos wrote:
> This patch fix the following checkpatch.pl warnings in prism2sta.c:
> WARNING: line over 80 characters
> 
> Signed-off-by: Sergio Paracuellos 
> ---
>  drivers/staging/wlan-ng/prism2sta.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

This patch doesn't apply to my tree :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

[Greg KH]

On Sun, Oct 09, 2016 at 08:29:11PM +0530, Harman Kalra wrote:
> This patch replaces calls to the "printk" with  appropriate "pr_*"
> function thus addressing the following warning generated by the
> checkpatch script:
> 
> Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
> dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...:w
> 
> Signed-off-by: Harman Kalra 
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c |   25 +++--
>  1 file changed, 11 insertions(+), 14 deletions(-)

This is a new version of the patch, so you need to version it, see the
file, Documentation/SubmittingPatches for all of the details on how to
do that properly.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/15] staging: wlan-ng: fix line style warnings in prism2sta.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2sta.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2sta.c 
b/drivers/staging/wlan-ng/prism2sta.c
index 1a6ea1f..1d8644a 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -104,7 +104,8 @@
 static int prism2sta_txframe(struct wlandevice *wlandev, struct sk_buff *skb,
 union p80211_hdr *p80211_hdr,
 struct p80211_metawep *p80211_wep);
-static int prism2sta_mlmerequest(struct wlandevice *wlandev, struct p80211msg 
*msg);
+static int prism2sta_mlmerequest(struct wlandevice *wlandev,
+struct p80211msg *msg);
 static int prism2sta_getcardinfo(struct wlandevice *wlandev);
 static int prism2sta_globalsetup(struct wlandevice *wlandev);
 static int prism2sta_setmulticast(struct wlandevice *wlandev,
@@ -278,7 +279,8 @@ static int prism2sta_txframe(struct wlandevice *wlandev, 
struct sk_buff *skb,
  * Call context:
  * process thread
  */
-static int prism2sta_mlmerequest(struct wlandevice *wlandev, struct p80211msg 
*msg)
+static int prism2sta_mlmerequest(struct wlandevice *wlandev,
+struct p80211msg *msg)
 {
struct hfa384x *hw = wlandev->priv;
 
@@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct 
wlandevice *wlandev,
 
kfree(hw->scanresults);
 
-   hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), 
GFP_ATOMIC);
+   hw->scanresults = kmemdup(inf,
+ sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);
 
if (nbss == 0)
nbss = -1;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 12/15] staging: wlan-ng: fix block comment warnings in prism2mib.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in prism2mib.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2mib.c | 100 ++--
 1 file changed, 50 insertions(+), 50 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mib.c 
b/drivers/staging/wlan-ng/prism2mib.c
index 63ab6bc8..d7792cd 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -1,54 +1,54 @@
 /* src/prism2/driver/prism2mib.c
-*
-* Management request for mibset/mibget
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* The functions in this file handle the mibset/mibget management
-* functions.
-*
-* 
-*/
+ *
+ * Management request for mibset/mibget
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * The functions in this file handle the mibset/mibget management
+ * functions.
+ *
+ * 
+ */
 
 #include 
 #include 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wlan-ng: avoid new typedef CTLX_STATE

[Sergio Paracuellos]

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef CTLX_STATE

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/hfa384x.h | 3 +--
 drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 43c299c..ab6d37c 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1169,7 +1169,6 @@ enum ctlx_state {
CTLX_REQ_COMPLETE,  /* OUT URB complete */
CTLX_RESP_COMPLETE  /* IN URB received */
 };
-typedef enum ctlx_state CTLX_STATE;
 
 struct hfa384x_usbctlx;
 struct hfa384x;
@@ -1186,7 +1185,7 @@ struct hfa384x_usbctlx {
union hfa384x_usbout outbuf;/* pkt buf for OUT */
union hfa384x_usbin inbuf;  /* pkt buf for IN(a copy) */
 
-   CTLX_STATE state;   /* Tracks running state */
+   enum ctlx_state state;  /* Tracks running state */
 
struct completion done;
volatile int reapable;  /* Food for the reaper task */
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6a107f8..1a8d3ac 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -263,7 +263,7 @@ struct usbctlx_completor {
 
 static int hfa384x_isgood_pdrcode(u16 pdrcode);
 
-static inline const char *ctlxstr(CTLX_STATE s)
+static inline const char *ctlxstr(enum ctlx_state s)
 {
static const char * const ctlx_str[] = {
"Initial state",
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 15/15] staging: wlan-ng: fix block comment warnings in prism2fw.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in prism2fw.c

WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2fw.c | 485 +++--
 1 file changed, 248 insertions(+), 237 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c 
b/drivers/staging/wlan-ng/prism2fw.c
index 96aa211..2454a78 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -1,49 +1,49 @@
 /* from src/prism2/download/prism2dl.c
-*
-* utility for downloading prism2 images moved into kernelspace
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*/
+ *
+ * utility for downloading prism2 images moved into kernelspace
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ */
 
 /**/
 /* System Includes */
@@ -189,18 +189,19 @@ static int writeimage(struct wlandevice *wlandev, struct 
imgchunk *fchunk,
 /* Function Definitions */
 
 /*
-* prism2_fwtry
-*
-* Try and get firmware into memory
-*
-* Arguments:
-*  udevusb device structure
-*  wlandev wlan device 

[PATCH 13/15] staging: wlan-ng: fix block comment warnings in prism2sta.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2sta.c | 36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2sta.c 
b/drivers/staging/wlan-ng/prism2sta.c
index e1b4a94..1a6ea1f 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -1859,24 +1859,24 @@ void prism2sta_ev_alloc(struct wlandevice *wlandev)
 }
 
 /*
-* create_wlan
-*
-* Called at module init time.  This creates the struct wlandevice structure
-* and initializes it with relevant bits.
-*
-* Arguments:
-*  none
-*
-* Returns:
-*  the created struct wlandevice structure.
-*
-* Side effects:
-*  also allocates the priv/hw structures.
-*
-* Call context:
-*  process thread
-*
-*/
+ * create_wlan
+ *
+ * Called at module init time.  This creates the struct wlandevice structure
+ * and initializes it with relevant bits.
+ *
+ * Arguments:
+ * none
+ *
+ * Returns:
+ * the created struct wlandevice structure.
+ *
+ * Side effects:
+ * also allocates the priv/hw structures.
+ *
+ * Call context:
+ * process thread
+ *
+ */
 static struct wlandevice *create_wlan(void)
 {
struct wlandevice *wlandev = NULL;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: wlan-ng: get memory from kernel allocators instead of big static buffer

[Sergio Paracuellos]

This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 12

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2fw.c | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2fw.c 
b/drivers/staging/wlan-ng/prism2fw.c
index 96aa211..7e33048 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -124,7 +124,7 @@ struct imgchunk {
 
 /* Data records */
 static unsigned int ns3data;
-static struct s3datarec s3data[S3DATA_MAX];
+static struct s3datarec *s3data;
 
 /* Plug records */
 static unsigned int ns3plug;
@@ -248,7 +248,12 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
 
/* Initialize the data structures */
ns3data = 0;
-   memset(s3data, 0, sizeof(s3data));
+   s3data = kcalloc(S3DATA_MAX, sizeof(*s3data), GFP_KERNEL);
+   if (unlikely(!s3data)) {
+   result = -ENOMEM;
+   goto out;
+   }
+
ns3plug = 0;
memset(s3plug, 0, sizeof(s3plug));
ns3crc = 0;
@@ -475,7 +480,7 @@ static void free_chunks(struct imgchunk *fchunk, unsigned 
int *nfchunks)
 static void free_srecs(void)
 {
ns3data = 0;
-   memset(s3data, 0, sizeof(s3data));
+   kfree(s3data);
ns3plug = 0;
memset(s3plug, 0, sizeof(s3plug));
ns3crc = 0;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/15] staging: wlan-ng: fix line style warnings in p80211wep.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211wep.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211wep.c 
b/drivers/staging/wlan-ng/p80211wep.c
index 59efb35..2e33fd7 100644
--- a/drivers/staging/wlan-ng/p80211wep.c
+++ b/drivers/staging/wlan-ng/p80211wep.c
@@ -217,8 +217,8 @@ int wep_decrypt(struct wlandevice *wlandev, u8 *buf, u32 
len, int key_override,
 }
 
 /* encrypts in-place. */
-int wep_encrypt(struct wlandevice *wlandev, u8 *buf, u8 *dst, u32 len, int 
keynum,
-   u8 *iv, u8 *icv)
+int wep_encrypt(struct wlandevice *wlandev, u8 *buf,
+   u8 *dst, u32 len, int keynum, u8 *iv, u8 *icv)
 {
u32 i, j, k, crc, keylen;
u8 s[256], key[64];
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/15] staging: wlan-ng: fix block comment warnings in prism2mgmt.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in prism2mgmt.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/prism2mgmt.c | 518 ++-
 1 file changed, 264 insertions(+), 254 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c 
b/drivers/staging/wlan-ng/prism2mgmt.c
index 170de1c..90db53d 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1,61 +1,61 @@
 /* src/prism2/driver/prism2mgmt.c
-*
-* Management request handler functions.
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* The functions in this file handle management requests sent from
-* user mode.
-*
-* Most of these functions have two separate blocks of code that are
-* conditional on whether this is a station or an AP.  This is used
-* to separate out the STA and AP responses to these management primitives.
-* It's a choice (good, bad, indifferent?) to have the code in the same
-* place so it's clear that the same primitive is implemented in both
-* cases but has different behavior.
-*
-* 
-*/
+ *
+ * Management request handler functions.
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product 

[PATCH 02/15] staging: wlan-ng: fix block comment warnings in hfa384x_usb.c

[Sergio Paracuellos]

 This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
 WARNING: Block comments should align the * on each line
 WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 2370 +
 1 file changed, 1213 insertions(+), 1157 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 395690f..1bfea8d 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1,114 +1,114 @@
 /* src/prism2/driver/hfa384x_usb.c
-*
-* Functions that talk to the USB variantof the Intersil hfa384x MAC
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file implements functions that correspond to the prism2/hfa384x
-* 802.11 MAC hardware and firmware host interface.
-*
-* The functions can be considered to represent several levels of
-* abstraction.  The lowest level functions are simply C-callable wrappers
-* around the register accesses.  The next higher level represents C-callable
-* prism2 API functions that match the Intersil documentation as closely
-* as is reasonable.  The next higher layer implements common sequences
-* of invocations of the API layer (e.g. write to bap, followed by cmd).
-*
-* Common sequences:
-* hfa384x_drvr_xxx Highest level abstractions provided by the
-*  hfa384x code.  They are driver defined wrappers
-*  for common sequences.  These functions generally
-*  use the services of the lower levels.
-*
-* hfa384x_drvr_xxxconfig  An example of the drvr level abstraction. These
-*  functions are wrappers for the RID get/set
-*  sequence. They call copy_[to|from]_bap() and
-*  cmd_access(). These functions operate on the
-*  RIDs and buffers without validation. The caller
-*  is responsible for that.
-*
-* API wrapper functions:
-* hfa384x_cmd_xxx  functions that provide access to the f/w commands.
-*  The function arguments correspond to each command
-*  argument, even command arguments that get packed
-*  into single registers.  These functions _just_
-*  issue the command by setting the cmd/parm regs
-*  & reading the status/resp regs.  Additional
-*  activities required to fully use a command
-*  (read/write from/to bap, get/set int status etc.)
-*  are implemented separately.  Think of these as
-*  C-callable prism2 commands.
-*
-* Lowest Layer Functions:
-* hfa384x_docmd_xxxThese functions implement the sequence required
-*  to issue any prism2 command.  Primarily used by the
-*  hfa384x_cmd_xxx functions.
-*
-* hfa384x_bap_xxx  BAP read/write access functions.
-*  Note: we usually use BAP0 for non-interrupt context
-*   and BAP1 

[PATCH 09/15] staging: wlan-ng: fix block comment warnings in p80211wep.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211wep.c | 90 ++---
 1 file changed, 45 insertions(+), 45 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211wep.c 
b/drivers/staging/wlan-ng/p80211wep.c
index 23b1837..59efb35 100644
--- a/drivers/staging/wlan-ng/p80211wep.c
+++ b/drivers/staging/wlan-ng/p80211wep.c
@@ -1,49 +1,49 @@
 /* src/p80211/p80211wep.c
-*
-* WEP encode/decode for P80211.
-*
-* Copyright (C) 2002 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*/
+ *
+ * WEP encode/decode for P80211.
+ *
+ * Copyright (C) 2002 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ */
 
 /**/
 /* System Includes */
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 08/15] staging: wlan-ng: fix line style warnings in p80211req.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211req.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211req.c 
b/drivers/staging/wlan-ng/p80211req.c
index 440dfc1..b3b33d2e 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -72,7 +72,8 @@
 #include "p80211metastruct.h"
 #include "p80211req.h"
 
-static void p80211req_handlemsg(struct wlandevice *wlandev, struct p80211msg 
*msg);
+static void p80211req_handlemsg(struct wlandevice *wlandev,
+   struct p80211msg *msg);
 static void p80211req_mibset_mibget(struct wlandevice *wlandev,
   struct p80211msg_dot11req_mibget *mib_msg,
   int isget);
@@ -166,7 +167,8 @@ int p80211req_dorequest(struct wlandevice *wlandev, u8 
*msgbuf)
  * Process thread
  *
  */
-static void p80211req_handlemsg(struct wlandevice *wlandev, struct p80211msg 
*msg)
+static void p80211req_handlemsg(struct wlandevice *wlandev,
+   struct p80211msg *msg)
 {
switch (msg->msgcode) {
 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/15] staging: wlan-ng: fix block comment warnings in p80211netdev.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211netdev.c | 613 +
 1 file changed, 314 insertions(+), 299 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.c 
b/drivers/staging/wlan-ng/p80211netdev.c
index 78a10af..fb28d8f 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -1,53 +1,53 @@
 /* src/p80211/p80211knetdev.c
-*
-* Linux Kernel net device interface
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* The functions required for a Linux network device are defined here.
-*
-* 
-*/
+ *
+ * Linux Kernel net device interface
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * The functions required for a Linux network device are defined here.
+ *
+ * 
+ */
 
 #include 
 #include 
@@ -112,17 +112,18 @@ static int p80211knetdev_do_ioctl(struct net_device *dev, 
struct ifreq *ifr,
 MODULE_PARM_DESC(wlan_wext_write, "enable 

[PATCH 07/15] staging: wlan-ng: fix block comment warnings in p80211req.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211req.c | 166 ++--
 1 file changed, 84 insertions(+), 82 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211req.c 
b/drivers/staging/wlan-ng/p80211req.c
index d43e85b..440dfc1 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -1,54 +1,54 @@
 /* src/p80211/p80211req.c
-*
-* Request/Indication/MacMgmt interface handling functions
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file contains the functions, types, and macros to support the
-* MLME request interface that's implemented via the device ioctls.
-*
-* 
-*/
+ *
+ * Request/Indication/MacMgmt interface handling functions
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * This file contains the functions, types, and macros to support the
+ * MLME request interface that's implemented via the device ioctls.
+ *
+ * 
+ */
 
 #include 

[PATCH 04/15] staging: wlan-ng: fix line style warnings in p80211netdev.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211netdev.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.c 
b/drivers/staging/wlan-ng/p80211netdev.c
index 825a63a..78a10af 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -227,7 +227,8 @@ void p80211netdev_rx(struct wlandevice *wlandev, struct 
sk_buff *skb)
  * CONV_TO_ETHER_FAILED if conversion failed
  * CONV_TO_ETHER_SKIPPED if frame is ignored
  */
-static int p80211_convert_to_ether(struct wlandevice *wlandev, struct sk_buff 
*skb)
+static int p80211_convert_to_ether(struct wlandevice *wlandev,
+  struct sk_buff *skb)
 {
struct p80211_hdr_a3 *hdr;
 
@@ -459,7 +460,8 @@ static void p80211knetdev_set_multicast_list(struct 
net_device *dev)
 
 #ifdef SIOCETHTOOL
 
-static int p80211netdev_ethtool(struct wlandevice *wlandev, void __user 
*useraddr)
+static int p80211netdev_ethtool(struct wlandevice *wlandev,
+   void __user *useraddr)
 {
u32 ethcmd;
struct ethtool_drvinfo info;
@@ -531,7 +533,8 @@ static int p80211netdev_ethtool(struct wlandevice *wlandev, 
void __user *useradd
 *  Process thread (ioctl caller).  TODO: SMP support may require
 *  locks.
 */
-static int p80211knetdev_do_ioctl(struct net_device *dev, struct ifreq *ifr, 
int cmd)
+static int p80211knetdev_do_ioctl(struct net_device *dev,
+ struct ifreq *ifr, int cmd)
 {
int result = 0;
struct p80211ioctl_req *req = (struct p80211ioctl_req *)ifr;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/15] staging: wlan-ng: fix block comment warnings in p80211conv.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in p80211conv.c:
WARNING: Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211conv.c | 318 +--
 1 file changed, 159 insertions(+), 159 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211conv.c 
b/drivers/staging/wlan-ng/p80211conv.c
index 0247cbc..5c0e658 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -1,56 +1,56 @@
 /* src/p80211/p80211conv.c
-*
-* Ether/802.11 conversions and packet buffer routines
-*
-* Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
-* 
-*
-* linux-wlan
-*
-*   The contents of this file are subject to the Mozilla Public
-*   License Version 1.1 (the "License"); you may not use this file
-*   except in compliance with the License. You may obtain a copy of
-*   the License at http://www.mozilla.org/MPL/
-*
-*   Software distributed under the License is distributed on an "AS
-*   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-*   implied. See the License for the specific language governing
-*   rights and limitations under the License.
-*
-*   Alternatively, the contents of this file may be used under the
-*   terms of the GNU Public License version 2 (the "GPL"), in which
-*   case the provisions of the GPL are applicable instead of the
-*   above.  If you wish to allow the use of your version of this file
-*   only under the terms of the GPL and not to allow others to use
-*   your version of this file under the MPL, indicate your decision
-*   by deleting the provisions above and replace them with the notice
-*   and other provisions required by the GPL.  If you do not delete
-*   the provisions above, a recipient may use your version of this
-*   file under either the MPL or the GPL.
-*
-* 
-*
-* Inquiries regarding the linux-wlan Open Source project can be
-* made directly to:
-*
-* AbsoluteValue Systems Inc.
-* i...@linux-wlan.com
-* http://www.linux-wlan.com
-*
-* 
-*
-* Portions of the development of this software were funded by
-* Intersil Corporation as part of PRISM(R) chipset product development.
-*
-* 
-*
-* This file defines the functions that perform Ethernet to/from
-* 802.11 frame conversions.
-*
-* 
-*
-*
-*/
+ *
+ * Ether/802.11 conversions and packet buffer routines
+ *
+ * Copyright (C) 1999 AbsoluteValue Systems, Inc.  All Rights Reserved.
+ * 
+ *
+ * linux-wlan
+ *
+ *   The contents of this file are subject to the Mozilla Public
+ *   License Version 1.1 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.mozilla.org/MPL/
+ *
+ *   Software distributed under the License is distributed on an "AS
+ *   IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
+ *   implied. See the License for the specific language governing
+ *   rights and limitations under the License.
+ *
+ *   Alternatively, the contents of this file may be used under the
+ *   terms of the GNU Public License version 2 (the "GPL"), in which
+ *   case the provisions of the GPL are applicable instead of the
+ *   above.  If you wish to allow the use of your version of this file
+ *   only under the terms of the GPL and not to allow others to use
+ *   your version of this file under the MPL, indicate your decision
+ *   by deleting the provisions above and replace them with the notice
+ *   and other provisions required by the GPL.  If you do not delete
+ *   the provisions above, a recipient may use your version of this
+ *   file under either the MPL or the GPL.
+ *
+ * 
+ *
+ * Inquiries regarding the linux-wlan Open Source project can be
+ * made directly to:
+ *
+ * AbsoluteValue Systems Inc.
+ * i...@linux-wlan.com
+ * http://www.linux-wlan.com
+ *
+ * 
+ *
+ * Portions of the development of this software were funded by
+ * Intersil Corporation as part of PRISM(R) chipset product development.
+ *
+ * 
+ *
+ * This file defines the functions that perform Ethernet to/from
+ * 802.11 frame conversions.
+ *
+ * 
+ *
+ *
+ */
 
 #include 
 

[PATCH 06/15] staging: wlan-ng: do not return -ENOSYS

[Sergio Paracuellos]

Fixed coding style issue by replacing ENOSYS with EINVAL.

This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/p80211netdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/p80211netdev.c 
b/drivers/staging/wlan-ng/p80211netdev.c
index fb28d8f..656033a 100644
--- a/drivers/staging/wlan-ng/p80211netdev.c
+++ b/drivers/staging/wlan-ng/p80211netdev.c
@@ -532,7 +532,7 @@ static int p80211netdev_ethtool(struct wlandevice *wlandev,
  * -ETIME  p80211 cmd timed out (MSD may have its own timers)
  * -EFAULT memory fault copying msg from user buffer
  * -ENOMEM unable to allocate kernel msg buffer
- * -ENOSYS bad magic, it the cmd really for us?
+ * -EINVAL bad magic, it the cmd really for us?
  * -EintR  sleeping on cmd, awakened by signal, cmd cancelled.
  *
  * Call Context:
@@ -560,7 +560,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
 
/* Test the magic, assume ifr is good if it's there */
if (req->magic != P80211_IOCTL_MAGIC) {
-   result = -ENOSYS;
+   result = -EINVAL;
goto bail;
}
 
@@ -568,7 +568,7 @@ static int p80211knetdev_do_ioctl(struct net_device *dev,
result = 0;
goto bail;
} else if (cmd != P80211_IFREQ) {
-   result = -ENOSYS;
+   result = -EINVAL;
goto bail;
}
 
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 01/15] staging: wlan-ng: fix line style warnings in hfa384x_usb.c

[Sergio Paracuellos]

This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: line over 80 characters

Signed-off-by: Sergio Paracuellos 
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 71 +++
 1 file changed, 38 insertions(+), 33 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c 
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 6a107f8..395690f 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -153,8 +153,8 @@ enum cmd_mode {
 static void dbprint_urb(struct urb *urb);
 #endif
 
-static void
-hfa384x_int_rxmonitor(struct wlandevice *wlandev, struct hfa384x_usb_rxfrm 
*rxfrm);
+static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
+ struct hfa384x_usb_rxfrm *rxfrm);
 
 static void hfa384x_usb_defer(struct work_struct *data);
 
@@ -173,7 +173,8 @@ enum cmd_mode {
 
 static void hfa384x_usbin_rx(struct wlandevice *wlandev, struct sk_buff *skb);
 
-static void hfa384x_usbin_info(struct wlandevice *wlandev, union hfa384x_usbin 
*usbin);
+static void hfa384x_usbin_info(struct wlandevice *wlandev,
+  union hfa384x_usbin *usbin);
 
 static void hfa384x_usbin_ctlx(struct hfa384x *hw, union hfa384x_usbin *usbin,
   int urb_status);
@@ -193,9 +194,11 @@ static void hfa384x_usbin_ctlx(struct hfa384x *hw, union 
hfa384x_usbin *usbin,
 
 static void hfa384x_usbctlx_reaper_task(unsigned long data);
 
-static int hfa384x_usbctlx_submit(struct hfa384x *hw, struct hfa384x_usbctlx 
*ctlx);
+static int hfa384x_usbctlx_submit(struct hfa384x *hw,
+ struct hfa384x_usbctlx *ctlx);
 
-static void unlocked_usbctlx_complete(struct hfa384x *hw, struct 
hfa384x_usbctlx *ctlx);
+static void unlocked_usbctlx_complete(struct hfa384x *hw,
+ struct hfa384x_usbctlx *ctlx);
 
 struct usbctlx_completor {
int (*complete)(struct usbctlx_completor *);
@@ -209,7 +212,8 @@ struct usbctlx_completor {
 static int
 unlocked_usbctlx_cancel_async(struct hfa384x *hw, struct hfa384x_usbctlx 
*ctlx);
 
-static void hfa384x_cb_status(struct hfa384x *hw, const struct hfa384x_usbctlx 
*ctlx);
+static void hfa384x_cb_status(struct hfa384x *hw,
+ const struct hfa384x_usbctlx *ctlx);
 
 static int
 usbctlx_get_status(const struct hfa384x_usb_statusresp *cmdresp,
@@ -664,12 +668,10 @@ static inline int usbctlx_cmd_completor_fn(struct 
usbctlx_completor *head)
return usbctlx_get_status(complete->cmdresp, complete->result);
 }
 
-static inline struct usbctlx_completor *init_cmd_completor(
-   struct usbctlx_cmd_completor
-   *completor,
-   const struct 
hfa384x_usb_statusresp
-   *cmdresp,
-   struct hfa384x_cmdresult 
*result)
+static inline struct usbctlx_completor *
+init_cmd_completor(struct usbctlx_cmd_completor *completor,
+   const struct hfa384x_usb_statusresp *cmdresp,
+   struct hfa384x_cmdresult *result)
 {
completor->head.complete = usbctlx_cmd_completor_fn;
completor->cmdresp = cmdresp;
@@ -710,13 +712,11 @@ static int usbctlx_rrid_completor_fn(struct 
usbctlx_completor *head)
return 0;
 }
 
-static inline struct usbctlx_completor *init_rrid_completor(
-   struct usbctlx_rrid_completor
-   *completor,
-   const struct 
hfa384x_usb_rridresp
-   *rridresp,
-   void *riddata,
-   unsigned int riddatalen)
+static inline struct usbctlx_completor *
+init_rrid_completor(struct usbctlx_rrid_completor *completor,
+   const struct hfa384x_usb_rridresp *rridresp,
+   void *riddata,
+   unsigned int riddatalen)
 {
completor->head.complete = usbctlx_rrid_completor_fn;
completor->rridresp = rridresp;
@@ -759,13 +759,11 @@ static int usbctlx_rmem_completor_fn(struct 
usbctlx_completor *head)
return 0;
 }
 
-static inline struct usbctlx_completor *init_rmem_completor(
-   struct usbctlx_rmem_completor
-   *completor,
-   struct hfa384x_usb_rmemresp
-   *rmemresp,
-   void *data,
-   unsigned int len)
+static inline 

[PATCH 00/15] staging: wlan-ng: Fix several style issues in several source files.

[Sergio Paracuellos]

This patch series fix some of the following checkpatch.pl reported warnings:
WARNING: line over 80 characters
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
WARNING: ENOSYS means 'invalid syscall nr' and nothing else

Sergio Paracuellos (15):
  staging: wlan-ng: fix line style warnings in hfa384x_usb.c
  staging: wlan-ng: fix block comment warnings in hfa384x_usb.c
  staging: wlan-ng: fix block comment warnings in p80211conv.c
  staging: wlan-ng: fix line style warnings in p80211netdev.c
  staging: wlan-ng: fix block comment warnings in p80211netdev.c
  staging: wlan-ng: do not return -ENOSYS
  staging: wlan-ng: fix block comment warnings in p80211req.c
  staging: wlan-ng: fix line style warnings in p80211req.c
  staging: wlan-ng: fix block comment warnings in p80211wep.c
  staging: wlan-ng: fix line style warnings in p80211wep.c
  staging: wlan-ng: fix block comment warnings in prism2mgmt.c
  staging: wlan-ng: fix block comment warnings in prism2mib.c
  staging: wlan-ng: fix block comment warnings in prism2sta.c
  staging: wlan-ng: fix line style warnings in prism2sta.c
  staging: wlan-ng: fix block comment warnings in prism2fw.c

 drivers/staging/wlan-ng/hfa384x_usb.c  | 2441 
 drivers/staging/wlan-ng/p80211conv.c   |  318 ++---
 drivers/staging/wlan-ng/p80211netdev.c |  626 
 drivers/staging/wlan-ng/p80211req.c|  172 +--
 drivers/staging/wlan-ng/p80211wep.c|   94 +-
 drivers/staging/wlan-ng/prism2fw.c |  485 +++
 drivers/staging/wlan-ng/prism2mgmt.c   |  518 +++
 drivers/staging/wlan-ng/prism2mib.c|  100 +-
 drivers/staging/wlan-ng/prism2sta.c|   45 +-
 9 files changed, 2453 insertions(+), 2346 deletions(-)

-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/13] staging: unisys: Convert client_bus_info to debugfs

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:38AM -0400, David Kershner wrote:
> Move /sys/bus/visorbus/devices/visorbus/client_bus_info to debugfs
> 
> In a 9/28/2016 patch inspection that fixed code within the function that
> emits this client_bus_info sysfs entry, GregKH pointed out that this
> shouldn't actually be a sysfs entry at all, and in fact belongs in debugfs.
> This patchset addresses that.
> 
> This patchset also addresses several comments pointed out by GregKH,
> specifically removal of useless initialization and removing unused
> defines from the rest of the driver series. 

I stopped reading after 5 patches.  Please fix up the series based on
the review comments so far and resend.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/13] staging: unisys: visorbus: remove unused initializations

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:43AM -0400, David Kershner wrote:
> From: sameer wadgaonkar 

lower-case name?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 04/13] staging: unisys: include: include.h remove unused pound defines

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:42AM -0400, David Kershner wrote:
> From: Erik Arfvidson 
> 
> This patch removes all the unused pound defines currently in
> include.h.

But does the hardware think they might be needed?  If so, leave them.

And again, wrap at 72.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/13] staging: unisys: visorbus: controlvmchannel.h fix spacing

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:41AM -0400, David Kershner wrote:
> From: Erik Arfvidson 
> 
> This patch fixes space and tab aligned comments in
> controlvmchannel.h.

It does?

> 
> Signed-off-by: Erik Arfvidson 
> Signed-off-by: David Kershner 
> ---
>  drivers/staging/unisys/visorbus/controlvmchannel.h | 42 
> +++---
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/controlvmchannel.h 
> b/drivers/staging/unisys/visorbus/controlvmchannel.h
> index b904376..9599d80 100644
> --- a/drivers/staging/unisys/visorbus/controlvmchannel.h
> +++ b/drivers/staging/unisys/visorbus/controlvmchannel.h
> @@ -33,7 +33,7 @@
>   * software.  Note that you can usually add fields to the END of the
>   * channel struct withOUT needing to increment this.
>   */
> -#define ULTRA_CONTROLVM_CHANNEL_PROTOCOL_VERSIONID  1
> +#define ULTRA_CONTROLVM_CHANNEL_PROTOCOL_VERSIONID 1
>  
>  #define SPAR_CONTROLVM_CHANNEL_OK_CLIENT(ch)   \
>   spar_check_channel_client(ch, \
> @@ -44,13 +44,13 @@
>   ULTRA_CONTROLVM_CHANNEL_PROTOCOL_SIGNATURE)
>  
>  /* Defines for various channel queues */
> -#define CONTROLVM_QUEUE_REQUEST  0
> -#define CONTROLVM_QUEUE_RESPONSE 1
> -#define CONTROLVM_QUEUE_EVENT2
> -#define CONTROLVM_QUEUE_ACK  3
> +#define CONTROLVM_QUEUE_REQUEST 0
> +#define CONTROLVM_QUEUE_RESPONSE 1
> +#define CONTROLVM_QUEUE_EVENT 2
> +#define CONTROLVM_QUEUE_ACK 3

That looks better now?  Doesn't to me :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 02/13] staging: unisys: visorbus: controlvmchannel.h fix comments

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:40AM -0400, David Kershner wrote:
> From: Erik Arfvidson 
> 
> This patch simply fixes comments to mantain a more consistent
> and shorter comments.

Any reason you don't wrap your changelog comment lines at 72 columns
like git asks you to?

> 
> githubissue:

What does that mean?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/13] staging: unisys: visorbus: controlvmchannel.h remove unused pound defines

[Greg KH]

On Tue, Oct 04, 2016 at 10:16:39AM -0400, David Kershner wrote:
> From: Erik Arfvidson 
> 
> This patch removes all unused pound defines in controlvmchannel.h.
> Adds a comment on the now unused error codes for our spar firmware
> to avoid new error messages conflicting with previously defined
> messages.
> 
> Signed-off-by: Erik Arfvidson 
> Signed-off-by: David Kershner 
> ---
>  drivers/staging/unisys/visorbus/controlvmchannel.h | 36 
> ++
>  1 file changed, 3 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/controlvmchannel.h 
> b/drivers/staging/unisys/visorbus/controlvmchannel.h
> index f0bfc4d..a71f875 100644
> --- a/drivers/staging/unisys/visorbus/controlvmchannel.h
> +++ b/drivers/staging/unisys/visorbus/controlvmchannel.h
> @@ -43,8 +43,6 @@
>   ULTRA_CONTROLVM_CHANNEL_PROTOCOL_VERSIONID, \
>   ULTRA_CONTROLVM_CHANNEL_PROTOCOL_SIGNATURE)
>  
> -#define MAX_SERIAL_NUM   32
> -
>  /* Defines for various channel queues */
>  #define CONTROLVM_QUEUE_REQUEST  0
>  #define CONTROLVM_QUEUE_RESPONSE 1
> @@ -436,26 +434,6 @@ struct spar_controlvm_channel_protocol {
>struct controlvm_message saved_crash_msg[CONTROLVM_CRASHMSG_MAX];
>  };
>  
> -/* Offsets for VM channel attributes */
> -#define VM_CH_REQ_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, request_queue)
> -#define VM_CH_RESP_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, response_queue)
> -#define VM_CH_EVENT_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_queue)
> -#define VM_CH_ACK_QUEUE_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_ack_queue)
> -#define VM_CH_REQ_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, request_msg)
> -#define VM_CH_RESP_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, response_msg)
> -#define VM_CH_EVENT_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_msg)
> -#define VM_CH_ACK_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, event_ack_msg)
> -#define VM_CH_CRASH_MSG_OFFSET \
> - offsetof(struct spar_controlvm_channel_protocol, saved_crash_msg)
> -
>  /* The following header will be located at the beginning of PayloadVmOffset 
> for
>   * various ControlVm commands. The receiver of a ControlVm command with a
>   * PayloadVmOffset will dereference this address and then use 
> connection_offset,
> @@ -482,6 +460,9 @@ struct spar_controlvm_parameters_header {
>   u32 reserved;   /* Natural alignment */
>  };
>  
> +/* The following error messages are reserved 100, 101,
> + * 201, 202, 401, 402, 403
> + */

Reserved where?  It's ok to leave defines in here that you don't use, if
the hardware uses/needs them somehow.  Don't feel like you have to only
have things that you use, especially if you end up with cryptic comments
like this :)

I'll not take this patch.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] Staging: i4l: Error "open brace { should be on the previous line" fixed.

[Greg KH]

On Fri, Oct 07, 2016 at 10:27:56PM +0530, Harman Kalra wrote:
> Error "open brace { should be on the previous line" caught by checkpatch.pl 
> fixed.
> Signed-off-by: Harman Kalra 

Please put a blank line before the signed-off-by: line.  As examples,
look at all other commits in the tree :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

[Harman Kalra]

This patch replaces calls to the "printk" with  appropriate "pr_*"
function thus addressing the following warning generated by the
checkpatch script:

Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...:w

Signed-off-by: Harman Kalra 
---
 drivers/staging/i4l/act2000/act2000_isa.c |   25 +++--
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000_isa.c 
b/drivers/staging/i4l/act2000/act2000_isa.c
index ad7a039..76195b9 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -78,10 +78,10 @@
if (istatus & ISA_ISR_ERR) {
/* Error Interrupt */
istatus &= ISA_ISR_ERR_MASK;
-   printk(KERN_WARNING "act2000: errIRQ\n");
+   pr_warn("act2000: errIRQ\n");
}
if (istatus)
-   printk(KERN_DEBUG "act2000: ?IRQ %d %02x\n", card->irq, 
istatus);
+   pr_debug("act2000: ?IRQ %d %02x\n", card->irq, istatus);
return IRQ_HANDLED;
 }
 
@@ -147,8 +147,7 @@
if (request_irq(irq, _isa_interrupt, 0, card->regname, card)) {
card->irq = old_irq;
card->flags |= ACT2000_FLAGS_IVALID;
-   printk(KERN_WARNING
-  "act2000: Could not request irq %d\n", irq);
+   pr_warn("act2000: Could not request irq %d\n", irq);
return -EBUSY;
} else {
act2000_isa_select_irq(card);
@@ -246,8 +245,7 @@
card->idat.isa.rcvskb = 
dev_alloc_skb(card->idat.isa.rcvlen);
if (!card->idat.isa.rcvskb) {
card->idat.isa.rcvignore = 1;
-   printk(KERN_WARNING
-  "act2000_isa_receive: no 
memory\n");
+   pr_warn("act2000_isa_receive: 
no memory\n");

test_and_clear_bit(ACT2000_LOCK_RX, (void *)>ilock);
return;
}
@@ -255,13 +253,12 @@
card->idat.isa.rcvptr = 
skb_put(card->idat.isa.rcvskb, card->idat.isa.rcvlen - 8);
} else {
card->idat.isa.rcvidx = 0;
-   printk(KERN_WARNING
-  "act2000_isa_receive: Invalid 
CAPI msg\n");
+   pr_warn("act2000_isa_receive: Invalid 
CAPI msg\n");
{
int i; __u8 *p; __u8 *t; __u8 
tmp[30];
for (i = 0, p = (__u8 
*)>idat.isa.rcvhdr, t = tmp; i < 8; i++)
t += sprintf(t, "%02x 
", *(p++));
-   printk(KERN_WARNING 
"act2000_isa_receive: %s\n", tmp);
+   pr_warn("act2000_isa_receive: 
%s\n", tmp);
}
}
}
@@ -370,21 +367,21 @@
count++;
}
if (count <= 20) {
-   printk(KERN_WARNING "act2000: No Firmware-ID!\n");
+   pr_warn("act2000: No Firmware-ID!\n");
return -ETIME;
}
*p = '\0';
fid.revlen[0] = '\0';
if (strcmp(fid.isdn, "ISDN")) {
-   printk(KERN_WARNING "act2000: Wrong Firmware-ID!\n");
+   pr_warn("act2000: Wrong Firmware-ID!\n");
return -EPROTO;
}
p = strchr(fid.revision, '\n');
if (p)
*p = '\0';
-   printk(KERN_INFO "act2000: Firmware-ID: %s\n", fid.revision);
+   pr_info("act2000: Firmware-ID: %s\n", fid.revision);
if (card->flags & ACT2000_FLAGS_IVALID) {
-   printk(KERN_DEBUG "Enabling Interrupts ...\n");
+   pr_debug("Enabling Interrupts ...\n");
act2000_isa_enable_irq(card);
}
return 0;
@@ -426,7 +423,7 @@
}
while (c < l) {
if (act2000_isa_writeb(card, *b++)) {
-   printk(KERN_WARNING
+   pr_warn(
   "act2000: loader timed out"
   " len=%d c=%d\n", length, c);
kfree(buf);
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org

Re: [PATCH 1/3] Staging: i4l: Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed

[Greg KH]

On Fri, Oct 07, 2016 at 10:27:54PM +0530, Harman Kalra wrote:
> Warning "Prefer "pr_debug over printk(KERN_DEBUG... " and "few line more than 
> 80 character" fixed

That is two different things again :(

I can't take this as is...

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] staging: ks7010: use netdev_* instead of printk()

[Greg KH]

On Sun, Oct 09, 2016 at 11:23:25AM +0530, Sabitha George wrote:
> Fixes checkpatch warning on printk usage in ks_hostif.c
> 
> Signed-off-by: Sabitha George 
> ---
>  drivers/staging/ks7010/ks_hostif.c | 31 +++
>  1 file changed, 15 insertions(+), 16 deletions(-)

Due to other changes in my tree, this no longer applies :(

Can you rebase it against my staging-testing branch of staging.git and
resend?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: ks7010: use __packed instead of __attribute__((packed))

[Greg KH]

On Sun, Oct 09, 2016 at 11:22:32AM +0530, Sabitha George wrote:
> This patch fixes the below checkpatch warning in ks_hostif.c:
>  __packed is preferred over __attribute__((packed))
> 
> Signed-off-by: Sabitha George 
> ---
>  drivers/staging/ks7010/ks_hostif.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Someone else sent this right before you did, sorry :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: fbtft: Fixed open parenthesis alignment check

[Harman Kalra]

This patch resolves all the following CHECKs caught by checkpatch.pl
CHECK: Alignment should match open parenthesis

Signed-off-by: Harman Kalra 
---
 drivers/staging/fbtft/fb_ili9325.c |9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ili9325.c 
b/drivers/staging/fbtft/fb_ili9325.c
index c31e2e0..4ab4479 100644
--- a/drivers/staging/fbtft/fb_ili9325.c
+++ b/drivers/staging/fbtft/fb_ili9325.c
@@ -38,18 +38,15 @@
 
 static unsigned int vc = 0x03; /* Vci1=Vci*0.80 */
 module_param(vc, uint, 0);
-MODULE_PARM_DESC(vc,
-"Sets the ratio factor of Vci to generate the reference voltages Vci1");
+MODULE_PARM_DESC(vc, "Sets the ratio factor of Vci to generate the reference 
voltages Vci1");
 
 static unsigned int vrh = 0x0d; /* VREG1OUT=Vci*1.85 */
 module_param(vrh, uint, 0);
-MODULE_PARM_DESC(vrh,
-"Set the amplifying rate (1.6 ~ 1.9) of Vci applied to output the VREG1OUT");
+MODULE_PARM_DESC(vrh, "Set the amplifying rate (1.6 ~ 1.9) of Vci applied to 
output the VREG1OUT");
 
 static unsigned int vdv = 0x12; /* VCOMH amplitude=VREG1OUT*0.98 */
 module_param(vdv, uint, 0);
-MODULE_PARM_DESC(vdv,
-"Select the factor of VREG1OUT to set the amplitude of Vcom");
+MODULE_PARM_DESC(vdv, "Select the factor of VREG1OUT to set the amplitude of 
Vcom");
 
 static unsigned int vcm = 0x0a; /* VCOMH=VREG1OUT*0.735 */
 module_param(vcm, uint, 0);
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

[Greg KH]

On Sun, Oct 09, 2016 at 07:58:00PM +0530, Harman Kalra wrote:
> This patch replaces calls to the "printk" with  appropriate "pr_*"
> function thus addressing the following warning generated by the
> checkpatch script:
> 
> Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
>   dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
> 
> Signed-off-by: Harman Kalra 
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c |   23 ++-
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/i4l/act2000/act2000_isa.c 
> b/drivers/staging/i4l/act2000/act2000_isa.c
> index ad7a039..1a91b52 100644
> --- a/drivers/staging/i4l/act2000/act2000_isa.c
> +++ b/drivers/staging/i4l/act2000/act2000_isa.c
> @@ -78,10 +78,10 @@
>   if (istatus & ISA_ISR_ERR) {
>   /* Error Interrupt */
>   istatus &= ISA_ISR_ERR_MASK;
> - printk(KERN_WARNING "act2000: errIRQ\n");
> + pr_warn("act2000: errIRQ\n");
>   }
>   if (istatus)
> - printk(KERN_DEBUG "act2000: ?IRQ %d %02x\n", card->irq, 
> istatus);
> + pr_warn("act2000: ?IRQ %d %02x\n", card->irq, istatus);

shouldn't that be pr_debug()?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: rtl8188eu: fix code indention error and block comments found by checkpatch.

[Greg KH]

On Sun, Oct 02, 2016 at 04:55:55PM -0700, victor carvajal wrote:
> ERROR: code indent should use tabs where possible
> +^I^Iuint in_len, uint initial_out_len);$
> 
> WARNING: Block comments use * on subsequent lines

That is two different things, you need to have two different patches.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlang-ng: avoid new typedef CTLX_STATE

[Greg KH]

On Mon, Oct 03, 2016 at 06:07:03PM +0200, Sergio Paracuellos wrote:
> This patch fixes the following checkpatch.pl warning in hfa384x.h:
> WARNING: do not add new typedefs
> 
> It applies for typedef CTLX_STATE
> 
> Signed-off-by: Sergio Paracuellos 
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 3 +--
>  drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)

Subject also wrong :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: wlang-ng: get memory from kernel allocators instead of big static buffer

[Greg KH]

On Mon, Oct 03, 2016 at 06:05:44PM +0200, Sergio Paracuellos wrote:
> This patch fix the following sparse warnings in prism2fw.c:
> warning: memset with byte count of 12
> 
> Signed-off-by: Sergio Paracuellos 
> ---
>  drivers/staging/wlan-ng/prism2fw.c | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Subject also wrong :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/15] staging: wlang-ng: Fix several style issues in several source files.

[Greg KH]

On Mon, Oct 03, 2016 at 06:04:00PM +0200, Sergio Paracuellos wrote:
> This patch series fix some of the following checkpatch.pl reported warnings:
> WARNING: line over 80 characters
> WARNING: Block comments should align the * on each line
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> 
> Sergio Paracuellos (15):
>   staging: wlang-ng: fix line style warnings in hfa384x_usb.c

For all of these, you mispelled the driver name :(

It is "wlan-ng" not "wlang-ng" :(

Care to fix that up and resend the series?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"

[Harman Kalra]

This patch replaces calls to the "printk" with  appropriate "pr_*"
function thus addressing the following warning generated by the
checkpatch script:

Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...

Signed-off-by: Harman Kalra 
---
 drivers/staging/i4l/act2000/act2000_isa.c |   23 ++-
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000_isa.c 
b/drivers/staging/i4l/act2000/act2000_isa.c
index ad7a039..1a91b52 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -78,10 +78,10 @@
if (istatus & ISA_ISR_ERR) {
/* Error Interrupt */
istatus &= ISA_ISR_ERR_MASK;
-   printk(KERN_WARNING "act2000: errIRQ\n");
+   pr_warn("act2000: errIRQ\n");
}
if (istatus)
-   printk(KERN_DEBUG "act2000: ?IRQ %d %02x\n", card->irq, 
istatus);
+   pr_warn("act2000: ?IRQ %d %02x\n", card->irq, istatus);
return IRQ_HANDLED;
 }
 
@@ -147,8 +147,7 @@
if (request_irq(irq, _isa_interrupt, 0, card->regname, card)) {
card->irq = old_irq;
card->flags |= ACT2000_FLAGS_IVALID;
-   printk(KERN_WARNING
-  "act2000: Could not request irq %d\n", irq);
+   pr_warn("act2000: Could not request irq %d\n", irq);
return -EBUSY;
} else {
act2000_isa_select_irq(card);
@@ -246,8 +245,7 @@
card->idat.isa.rcvskb = 
dev_alloc_skb(card->idat.isa.rcvlen);
if (!card->idat.isa.rcvskb) {
card->idat.isa.rcvignore = 1;
-   printk(KERN_WARNING
-  "act2000_isa_receive: no 
memory\n");
+   pr_warn("act2000_isa_receive: 
no memory\n");

test_and_clear_bit(ACT2000_LOCK_RX, (void *)>ilock);
return;
}
@@ -255,13 +253,12 @@
card->idat.isa.rcvptr = 
skb_put(card->idat.isa.rcvskb, card->idat.isa.rcvlen - 8);
} else {
card->idat.isa.rcvidx = 0;
-   printk(KERN_WARNING
-  "act2000_isa_receive: Invalid 
CAPI msg\n");
+   pr_warn("act2000_isa_receive: Invalid 
CAPI msg\n");
{
int i; __u8 *p; __u8 *t; __u8 
tmp[30];
for (i = 0, p = (__u8 
*)>idat.isa.rcvhdr, t = tmp; i < 8; i++)
t += sprintf(t, "%02x 
", *(p++));
-   printk(KERN_WARNING 
"act2000_isa_receive: %s\n", tmp);
+   pr_warn("act2000_isa_receive: 
%s\n", tmp);
}
}
}
@@ -370,13 +367,13 @@
count++;
}
if (count <= 20) {
-   printk(KERN_WARNING "act2000: No Firmware-ID!\n");
+   pr_warn("act2000: No Firmware-ID!\n");
return -ETIME;
}
*p = '\0';
fid.revlen[0] = '\0';
if (strcmp(fid.isdn, "ISDN")) {
-   printk(KERN_WARNING "act2000: Wrong Firmware-ID!\n");
+   pr_warn("act2000: Wrong Firmware-ID!\n");
return -EPROTO;
}
p = strchr(fid.revision, '\n');
@@ -384,7 +381,7 @@
*p = '\0';
printk(KERN_INFO "act2000: Firmware-ID: %s\n", fid.revision);
if (card->flags & ACT2000_FLAGS_IVALID) {
-   printk(KERN_DEBUG "Enabling Interrupts ...\n");
+   pr_debug("Enabling Interrupts ...\n");
act2000_isa_enable_irq(card);
}
return 0;
@@ -426,7 +423,7 @@
}
while (c < l) {
if (act2000_isa_writeb(card, *b++)) {
-   printk(KERN_WARNING
+   pr_warn(
   "act2000: loader timed out"
   " len=%d c=%d\n", length, c);
kfree(buf);
-- 
1.7.9.5

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 35/41] staging: lustre: hsm: Use file lease to implement migration

[Greg Kroah-Hartman]

On Sun, Oct 02, 2016 at 10:28:31PM -0400, James Simmons wrote:
> From: Henri Doreau 
> 
> Implement non-blocking migration based on exclusive open instead of
> group lock. Implemented exclusive close operation to atomically put
> a lease, swap two layouts and close a file. This allows race-free
> migrations.
> 
> Make the caller responsible for retrying on failure (EBUSY, EAGAIN)
> in non-blocking mode.
> 
> In blocking mode, allow applications to trigger layout swaps using a
> grouplock they already own, to prevent race conditions between the
> actual data copy and the layout swap. Updated lfs accordingly. File
> leases are also taken in blocking mode, so that lfs migrate can issue
> a warning if an application attempts to open a file that is being
> migrated and gets blocked.
> 
> Timestamps (atime/mtime) are set from userland, after the layout swap
> is performed, to prevent conflicts with the grouplock.
> 
> lli_trunc_sem is taken/released in the vvp_io layer, under the DLM
> lock. This re-ordering fixes the original issue between truncate and
> migrate.
> 
> Signed-off-by: Henri Doreau 
> Signed-off-by: Jinshan Xiong 
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4840
> Reviewed-on: http://review.whamcloud.com/10013
> Reviewed-by: John L. Hammond 
> Reviewed-by: frank zago 
> Reviewed-by: Oleg Drokin 
> Signed-off-by: James Simmons 
> ---
>  .../lustre/lustre/include/lustre/lustre_idl.h  |5 +-
>  .../lustre/lustre/include/lustre/lustre_user.h |1 +
>  .../lustre/lustre/include/lustre_req_layout.h  |2 +-
>  drivers/staging/lustre/lustre/llite/file.c |  231 
> 
>  drivers/staging/lustre/lustre/llite/llite_lib.c|4 -
>  drivers/staging/lustre/lustre/llite/vvp_io.c   |   82 +---
>  drivers/staging/lustre/lustre/mdc/mdc_lib.c|   34 ++--
>  drivers/staging/lustre/lustre/mdc/mdc_request.c|7 +-
>  drivers/staging/lustre/lustre/ptlrpc/layout.c  |   10 +-
>  9 files changed, 235 insertions(+), 141 deletions(-)

This patch also failed to apply :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

[Greg Kroah-Hartman]

On Sun, Oct 02, 2016 at 10:28:28PM -0400, James Simmons wrote:
> From: Bobi Jam 
> 
> If normal IO got short read/write, we'd restart the IO from where
> we've accomplished until we meet EOF or error happens.
> 
> Signed-off-by: Bobi Jam 
> Signed-off-by: Jinshan Xiong 
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6389
> Reviewed-on: http://review.whamcloud.com/14123
> Reviewed-by: Andreas Dilger 
> Reviewed-by: Oleg Drokin 
> Signed-off-by: James Simmons 
> ---
>  drivers/staging/lustre/lnet/libcfs/fail.c  |1 +
>  .../staging/lustre/lustre/include/obd_support.h|2 +
>  drivers/staging/lustre/lustre/llite/file.c |   41 
> 
>  drivers/staging/lustre/lustre/llite/vvp_io.c   |   19 -
>  4 files changed, 45 insertions(+), 18 deletions(-)

Due to other changes in the filesystem tree, this patch no longer
applies :(

Can you rebase it and resend?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: greybus: Fixed CHECKS for brace issues

[Greg Kroah-Hartman]

On Fri, Oct 07, 2016 at 05:04:16PM -0700, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
> 
> Signed-off-by: Chase Metzger 

You used the same subject here as your last patch, which implies it did
the same thing, yet it did not :(

So please make the subject unique.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/2] Staging:greybus:arche-apb-ctrl: fix trailing */ Block comments and 80 character line limit coding style issue

[Greg KH]

On Fri, Oct 07, 2016 at 02:05:13PM -0700, Nadim Almas wrote:
> Fixed coding style issue

Your subject is huge, please don't make it so long.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: net: netlogic: use new api ethtool_{get|set}_link_ksettings

[Philippe Reynes]

The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.

Signed-off-by: Philippe Reynes 
---
 drivers/staging/netlogic/xlr_net.c |   14 --
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/netlogic/xlr_net.c 
b/drivers/staging/netlogic/xlr_net.c
index 552a7dc..cdf01b9 100644
--- a/drivers/staging/netlogic/xlr_net.c
+++ b/drivers/staging/netlogic/xlr_net.c
@@ -172,29 +172,31 @@ static struct phy_device *xlr_get_phydev(struct 
xlr_net_priv *priv)
 /*
  * Ethtool operation
  */
-static int xlr_get_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
+static int xlr_get_link_ksettings(struct net_device *ndev,
+ struct ethtool_link_ksettings *ecmd)
 {
struct xlr_net_priv *priv = netdev_priv(ndev);
struct phy_device *phydev = xlr_get_phydev(priv);
 
if (!phydev)
return -ENODEV;
-   return phy_ethtool_gset(phydev, ecmd);
+   return phy_ethtool_ksettings_get(phydev, ecmd);
 }
 
-static int xlr_set_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
+static int xlr_set_link_ksettings(struct net_device *ndev,
+ const struct ethtool_link_ksettings *ecmd)
 {
struct xlr_net_priv *priv = netdev_priv(ndev);
struct phy_device *phydev = xlr_get_phydev(priv);
 
if (!phydev)
return -ENODEV;
-   return phy_ethtool_sset(phydev, ecmd);
+   return phy_ethtool_ksettings_set(phydev, ecmd);
 }
 
 static const struct ethtool_ops xlr_ethtool_ops = {
-   .get_settings = xlr_get_settings,
-   .set_settings = xlr_set_settings,
+   .get_link_ksettings = xlr_get_link_ksettings,
+   .set_link_ksettings = xlr_set_link_ksettings,
 };
 
 /*
-- 
1.7.4.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch] staging: ion: use two separate locks for heaps and clients in ion_device

[Greg KH]

On Fri, Oct 07, 2016 at 04:27:49PM +0800, YiPing Xu wrote:
> 
> 
> On 2016/10/5 2:02, Laura Abbott wrote:
> > On 09/30/2016 01:18 AM, Xu YiPing wrote:
> > > ion_alloc may get into slow path to get free page,
> > > the call stack:
> > > 
> > > __alloc_pages_slowpath
> > > ion_page_pool_alloc_pages
> > > alloc_buffer_page
> > > ion_system_heap_allocate
> > > ion_buffer_create  <-- hold ion_device->lock
> > > ion_alloc
> > > 
> > > after that, kernel invokes low-memory killer to kill some apps in
> > > order to free memory in android system. However, sometimes, the
> > > killing is blocked,
> > > the app's call stack:
> > > 
> > > rwsem_down_write_failed
> > > down_write
> > > ion_client_destroy
> > > ion_release
> > > fput
> > > do_signal
> > > 
> > > the killing is blocked because ion_device->lock is held by ion_alloc.
> > > 
> > > ion_alloc hold the lock for accessing the heaps list,
> > > ion_destroy_client hold the lock for accessing the clients list.
> > > 
> > > so, we can use two separate locks for heaps and clients, to avoid the
> > > unnecessary race.
> > > 
> > 
> > I've reviewed this and it looks okay at first pass but I don't want it
> > applied just yet. Ion locking is a bit of a mess and has been added
> 
> yes, and now "debugfs_mutex" and "ion_root_client" is redundant, after
> commit 49d200deaa680501f19a247b1fffb29301e51d2b and
> 9fd4dcece43a53e5a9e65a973df5693702ee6401.

Ok, now dropping this patch from my queue.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

[Jonathan Cameron]

On 09/10/16 11:35, Brian Masney wrote:
> On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote:
>> On 07/10/16 01:48, Brian Masney wrote:
>>> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
>>>
>>> Signed-off-by: Brian Masney 
>> Time for a nitpick tastic review ;)
>>
>> The nature of a move out of staging patch is that we'll go over it
>> with the level of fine toothed comb we apply to a new submission.
>> A good part of my aim here is to ensure that once it's out it doesn't
>> get a lot of churn from whitespace or comment syntax patches etc.
>>
>> I want to be able to ignore it for ever more and have it continue to
>> work perfectly and be beautiful code ;)
>>
>> Anyhow, nothing of any significance at all in here, but it will need
>> a couple of precursor patches to clean up the loose ends before we
>> move it out of staging.
>>
>> Thanks for doing this and sorry to bounce it back to you over such
>> trivial stuff!
> 
> Thanks, Jonathan, for taking the time to go through this. I'll send a
> second patch series in a day or two.
> 
> I'm hoping to have one of these light sensors (along with 2 others in
> staging/iio/light/) in a week or so that I can hook it up to a
> Raspberry Pi to test the drivers. I ordered the sensors off of
> Digi-Key for a few dollars each. One of my friends is mounting them
> onto a breakout board for me.
> 
> Is my change that renames the Kconfig variable acceptable? After I
> emailed that last patch set, I noticed that the description in Kconfig
> for this driver has 'ISL 29018' but the neighboring one in mainline has
> 'Intersil ISL29125' so I assume that should be changed as well for
> consistency.
Just realised I didn't press send on my reply to that one.

Upshot is unfortunately no.  Feel free to fix the description though!

Jonathan
> 
> Brian
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

[Brian Masney]

On Sun, Oct 09, 2016 at 10:45:12AM +0100, Jonathan Cameron wrote:
> On 07/10/16 01:48, Brian Masney wrote:
> > Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
> > 
> > Signed-off-by: Brian Masney 
> Time for a nitpick tastic review ;)
> 
> The nature of a move out of staging patch is that we'll go over it
> with the level of fine toothed comb we apply to a new submission.
> A good part of my aim here is to ensure that once it's out it doesn't
> get a lot of churn from whitespace or comment syntax patches etc.
> 
> I want to be able to ignore it for ever more and have it continue to
> work perfectly and be beautiful code ;)
> 
> Anyhow, nothing of any significance at all in here, but it will need
> a couple of precursor patches to clean up the loose ends before we
> move it out of staging.
> 
> Thanks for doing this and sorry to bounce it back to you over such
> trivial stuff!

Thanks, Jonathan, for taking the time to go through this. I'll send a
second patch series in a day or two.

I'm hoping to have one of these light sensors (along with 2 others in
staging/iio/light/) in a week or so that I can hook it up to a
Raspberry Pi to test the drivers. I ordered the sensors off of
Digi-Key for a few dollars each. One of my friends is mounting them
onto a breakout board for me.

Is my change that renames the Kconfig variable acceptable? After I
emailed that last patch set, I noticed that the description in Kconfig
for this driver has 'ISL 29018' but the neighboring one in mainline has
'Intersil ISL29125' so I assume that should be changed as well for
consistency.

Brian

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] staging: iio: isl29018: rename Kconfig variable to match existing light drivers in mainline.

[Jonathan Cameron]

On 07/10/16 01:48, Brian Masney wrote:
> Rename CONFIG_SENSORS_ISL29018 to CONFIG_ISL29018 for consistency with
> the other light drivers in mainline.
> 
> Signed-off-by: Brian Masney 
I'm always a bit split on these.  It would be lovely to tidy
it up, but it may cause unnecessary breakage to people's
configs for a very minor gain.  Hence I'm not going to apply this.

Jonathan
> ---
>  drivers/staging/iio/light/Kconfig  | 2 +-
>  drivers/staging/iio/light/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/Kconfig 
> b/drivers/staging/iio/light/Kconfig
> index ca8d6e6..b0e2948 100644
> --- a/drivers/staging/iio/light/Kconfig
> +++ b/drivers/staging/iio/light/Kconfig
> @@ -3,7 +3,7 @@
>  #
>  menu "Light sensors"
>  
> -config SENSORS_ISL29018
> +config ISL29018
>   tristate "ISL 29018 light and proximity sensor"
>   depends on I2C
>   select REGMAP_I2C
> diff --git a/drivers/staging/iio/light/Makefile 
> b/drivers/staging/iio/light/Makefile
> index 9960fdf..89d6b02 100644
> --- a/drivers/staging/iio/light/Makefile
> +++ b/drivers/staging/iio/light/Makefile
> @@ -2,7 +2,7 @@
>  # Makefile for industrial I/O Light sensors
>  #
>  
> -obj-$(CONFIG_SENSORS_ISL29018)   += isl29018.o
> +obj-$(CONFIG_ISL29018)   += isl29018.o
>  obj-$(CONFIG_SENSORS_ISL29028)   += isl29028.o
>  obj-$(CONFIG_TSL2583)+= tsl2583.o
>  obj-$(CONFIG_TSL2x7x)+= tsl2x7x_core.o
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging: iio: isl29018: move out of staging

[Jonathan Cameron]

On 07/10/16 01:48, Brian Masney wrote:
> Move ISL29018/ISL29023/ISL29035 driver out of staging into mainline.
> 
> Signed-off-by: Brian Masney 
Time for a nitpick tastic review ;)

The nature of a move out of staging patch is that we'll go over it
with the level of fine toothed comb we apply to a new submission.
A good part of my aim here is to ensure that once it's out it doesn't
get a lot of churn from whitespace or comment syntax patches etc.

I want to be able to ignore it for ever more and have it continue to
work perfectly and be beautiful code ;)

Anyhow, nothing of any significance at all in here, but it will need
a couple of precursor patches to clean up the loose ends before we
move it out of staging.

Thanks for doing this and sorry to bounce it back to you over such
trivial stuff!

Jonathan

p.s. I may let the next version sit for a little while on the list
anyway as these move out of staging patches often attract some
good reviews.

> ---
>  drivers/iio/light/Kconfig|  12 +
>  drivers/iio/light/Makefile   |   1 +
>  drivers/iio/light/isl29018.c | 847 
> +++
>  drivers/staging/iio/light/Kconfig|  12 -
>  drivers/staging/iio/light/Makefile   |   1 -
>  drivers/staging/iio/light/isl29018.c | 847 
> ---
>  6 files changed, 860 insertions(+), 860 deletions(-)
>  create mode 100644 drivers/iio/light/isl29018.c
>  delete mode 100644 drivers/staging/iio/light/isl29018.c
> 
> diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig
> index ba2e64d..222a5ad 100644
> --- a/drivers/iio/light/Kconfig
> +++ b/drivers/iio/light/Kconfig
> @@ -140,6 +140,18 @@ config GP2AP020A00F
> To compile this driver as a module, choose M here: the
> module will be called gp2ap020a00f.
>  
> +config ISL29018
> + tristate "ISL 29018 light and proximity sensor"
> + depends on I2C
> + select REGMAP_I2C
> + default n
> + help
> +  If you say yes here you get support for ambient light sensing and
> +  proximity infrared sensing from Intersil ISL29018.
> +  This driver will provide the measurements of ambient light intensity
> +  in lux, proximity infrared sensing and normal infrared sensing.
> +  Data from sensor is accessible via sysfs.
> +
>  config ISL29125
>   tristate "Intersil ISL29125 digital color light sensor"
>   depends on I2C
> diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile
> index c5768df..652240b 100644
> --- a/drivers/iio/light/Makefile
> +++ b/drivers/iio/light/Makefile
> @@ -17,6 +17,7 @@ obj-$(CONFIG_CM36651)   += cm36651.o
>  obj-$(CONFIG_GP2AP020A00F)   += gp2ap020a00f.o
>  obj-$(CONFIG_HID_SENSOR_ALS) += hid-sensor-als.o
>  obj-$(CONFIG_HID_SENSOR_PROX)+= hid-sensor-prox.o
> +obj-$(CONFIG_ISL29018)   += isl29018.o
>  obj-$(CONFIG_ISL29125)   += isl29125.o
>  obj-$(CONFIG_JSA1212)+= jsa1212.o
>  obj-$(CONFIG_SENSORS_LM3533) += lm3533-als.o
> diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
> new file mode 100644
> index 000..52bfb1cb
> --- /dev/null
> +++ b/drivers/iio/light/isl29018.c
> @@ -0,0 +1,847 @@
> +/*
> + * A iio driver for the light sensor ISL 29018/29023/29035.
> + *
> + * IIO driver for monitoring ambient light intensity in luxi, proximity
> + * sensing and infrared sensing.
> + *
> + * Copyright (c) 2010, NVIDIA Corporation.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful, but 
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#define ISL29018_CONV_TIME_MS100
> +
> +#define ISL29018_REG_ADD_COMMAND10x00
> +#define ISL29018_CMD1_OPMODE_SHIFT   5
> +#define ISL29018_CMD1_OPMODE_MASK(7 << ISL29018_CMD1_OPMODE_SHIFT)
> +#define ISL29018_CMD1_OPMODE_POWER_DOWN  0
> +#define ISL29018_CMD1_OPMODE_ALS_ONCE1
> +#define ISL29018_CMD1_OPMODE_IR_ONCE 2
> +#define ISL29018_CMD1_OPMODE_PROX_ONCE   3
> +
> +#define ISL29018_REG_ADD_COMMAND20x01
> +#define ISL29018_CMD2_RESOLUTION_SHIFT   2
> +#define ISL29018_CMD2_RESOLUTION_MASK(0x3 << 
> ISL29018_CMD2_RESOLUTION_SHIFT)
> +
> +#define ISL29018_CMD2_RANGE_SHIFT0
> +#define ISL29018_CMD2_RANGE_MASK (0x3 << ISL29018_CMD2_RANGE_SHIFT)
> +
> +#define ISL29018_CMD2_SCHEME_SHIFT   7
> +#define ISL29018_CMD2_SCHEME_MASK(0x1 << 

Re: [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression

[Jonathan Cameron]

On 09/10/16 09:43, Jonathan Cameron wrote:
> On 07/10/16 01:48, Brian Masney wrote:
>> Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012)
>> about the infrared suppression that can be controlled
>> with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
>>
>> Signed-off-by: Brian Masney 
>> ---
>>  drivers/staging/iio/light/isl29018.c | 18 ++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/staging/iio/light/isl29018.c 
>> b/drivers/staging/iio/light/isl29018.c
>> index 51226bd..52bfb1cb 100644
>> --- a/drivers/staging/iio/light/isl29018.c
>> +++ b/drivers/staging/iio/light/isl29018.c
>> @@ -307,6 +307,24 @@ static ssize_t 
>> in_illuminance_integration_time_available_show
>>  return len;
>>  }
>>  
>> +/*
>> + * From ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) regarding the
>> + * infrared suppression:
>> + *
>> + *   Proximity Sensing Scheme: Bit 7. This bit programs the function
>> + * of the proximity detection. Logic 0 of this bit, Scheme 0, makes
>> + * full n (4, 8, 12, 16) bits (unsigned) proximity detection. The range
>> + * of Scheme 0 proximity count is from 0 to 2^n. Logic 1 of this bit,
>> + * Scheme 1, makes n-1 (3, 7, 11, 15) bits (2's complementary)
>> + * proximity_less_ambient detection. The range of Scheme 1
>> + * proximity count is from -2^(n-1) to 2^(n-1) . The sign bit is extended
>> + * for resolutions less than 16. While Scheme 0 has wider dynamic
>> + * range, Scheme 1 proximity detection is less affected by the
>> + * ambient IR noise variation.
>> + *
>> + * 0 Sensing IR from LED and ambient
>> + * 1 Sensing IR from LED with ambient IR rejection
>> + */
> Hi Brian,
> 
> This is good stuff, but the home of ABI docs (where it 'has' to be as
> opposed to here where it is nice to have) is
> Documentation/ABI/testing/sysfs-bus-iio-* (here isl29018 until we
> see if this becomes generic enough to promote to a more generic file)
> 
Forgot to say, I applied this as it is a good addition in it's own right.
Just looking for a follow up patch adding the ABI docs.

Thanks,

Jonathan
> Jonathan
>>  static ssize_t proximity_on_chip_ambient_infrared_suppression_show
>>  (struct device *dev, struct device_attribute *attr,
>>   char *buf)
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/4] staging: iio: isl29018: document device tree bindings

[Jonathan Cameron]

On 07/10/16 01:48, Brian Masney wrote:
> Fix the following warnings from checkpatch:
> 
> WARNING: DT compatible string "isil,isl29018" appears un-documented --
> check ./Documentation/devicetree/bindings/
> WARNING: DT compatible string "isil,isl29023" appears un-documented --
> check ./Documentation/devicetree/bindings/
> WARNING: DT compatible string "isil,isl29035" appears un-documented --
> check ./Documentation/devicetree/bindings/
> 
> Signed-off-by: Brian Masney 
Device tree patches should always be cc'd to the device tree list and
maintainers. (done above).

As this is very simple I'm happy to take it without an Ack from
them (though one would always be welcome and can be added for
a week or so as I'm not pushing this out in a non rebasing tree yet).

Applied to the togreg branch of iio.git - pushed out as testing for
the autobuilders to play with it.

Mark and Rob, just noticed we are down to just the two of you.
Good luck guys and hope you find more assistance soon if you
want it.

Thanks,

Jonathan
> ---
>  .../devicetree/bindings/iio/light/isl29018.txt | 28 
> ++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/isl29018.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt 
> b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> new file mode 100644
> index 000..7e53524
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> @@ -0,0 +1,28 @@
> +* ISL 29018/29023/29035 I2C ALS, Proximity, and Infrared sensor
> +
> +Required properties:
> +
> +  - compatible: Should be one of
> + "isil,isl29018"
> + "isil,isl29023"
> + "isil,isl29035"
> +  - reg: the I2C address of the device
> +
> +Optional properties:
> +
> +  - interrupt-parent: should be the phandle for the interrupt controller
> +  - interrupts: the sole interrupt generated by the device
> +
> +  Refer to interrupt-controller/interrupts.txt for generic interrupt client
> +  node bindings.
> +
> +  - vcc-supply: phandle to the regulator that provides power to the sensor.
> +
> +Example:
> +
> +isl29018@44 {
> + compatible = "isil,isl29018";
> + reg = <0x44>;
> + interrupt-parent = <>;
> + interrupts = ;
> +};
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging: iio: isl29018: add documentation about the infrared suppression

[Jonathan Cameron]

On 07/10/16 01:48, Brian Masney wrote:
> Add documentation from the ISL29018 Data Sheet (FN6619.4, Oct 8, 2012)
> about the infrared suppression that can be controlled
> with the proximity_on_chip_ambient_infrared_suppression sysfs attribute.
> 
> Signed-off-by: Brian Masney 
> ---
>  drivers/staging/iio/light/isl29018.c | 18 ++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/staging/iio/light/isl29018.c 
> b/drivers/staging/iio/light/isl29018.c
> index 51226bd..52bfb1cb 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -307,6 +307,24 @@ static ssize_t 
> in_illuminance_integration_time_available_show
>   return len;
>  }
>  
> +/*
> + * From ISL29018 Data Sheet (FN6619.4, Oct 8, 2012) regarding the
> + * infrared suppression:
> + *
> + *   Proximity Sensing Scheme: Bit 7. This bit programs the function
> + * of the proximity detection. Logic 0 of this bit, Scheme 0, makes
> + * full n (4, 8, 12, 16) bits (unsigned) proximity detection. The range
> + * of Scheme 0 proximity count is from 0 to 2^n. Logic 1 of this bit,
> + * Scheme 1, makes n-1 (3, 7, 11, 15) bits (2's complementary)
> + * proximity_less_ambient detection. The range of Scheme 1
> + * proximity count is from -2^(n-1) to 2^(n-1) . The sign bit is extended
> + * for resolutions less than 16. While Scheme 0 has wider dynamic
> + * range, Scheme 1 proximity detection is less affected by the
> + * ambient IR noise variation.
> + *
> + * 0 Sensing IR from LED and ambient
> + * 1 Sensing IR from LED with ambient IR rejection
> + */
Hi Brian,

This is good stuff, but the home of ABI docs (where it 'has' to be as
opposed to here where it is nice to have) is
Documentation/ABI/testing/sysfs-bus-iio-* (here isl29018 until we
see if this becomes generic enough to promote to a more generic file)

Jonathan
>  static ssize_t proximity_on_chip_ambient_infrared_suppression_show
>   (struct device *dev, struct device_attribute *attr,
>char *buf)
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel