Re: [edk2] Repeated condition check

[Santhapur Naveen]

Hi Jiaxin,

Created a bug in the Bugzilla site.
Here's the bug link https://bugzilla.tianocore.org/show_bug.cgi?id=718

Thank you
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, September 25, 2017 10:40 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan
Subject: RE: Repeated condition check

Thanks Naveen, we appreciate your report:).


> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Monday, September 25, 2017 1:05 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>
> Subject: RE: Repeated condition check
> 
> Hi Jiaxin,
> 
> Duly noted.
> Will mention one of you in the TO/CC list from here onwards.
> 
> Thank you
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Monday, September 25, 2017 10:33 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan
> Subject: RE: Repeated condition check
> 
> Hi Naveen,
> 
> We may ignore your email  if you don't attach any specific receiver 
> (TO OR CC list):(.
> 
> For the issue, I agree the fix. So, can you help to report the issue on 
> Bugzilla?
> We will create the formal patch to fix it.
> 
> Thanks,
> Jiaxin
> 
> 
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Santhapur Naveen
> > Sent: Friday, September 22, 2017 4:40 PM
> > To: edk2-devel@lists.01.org
> > Subject: Re: [edk2] Repeated condition check
> >
> > Hello guys,
> >
> > Any update?
> >
> > Thank you
> > Naveen
> >
> > -Original Message-
> > From: Santhapur Naveen
> > Sent: Wednesday, September 20, 2017 12:05 PM
> > To: edk2-devel@lists.01.org
> > Subject: Repeated condition check
> >
> > Hi all,
> >
> > There is a redundant condition check in the API
> > PxeBcIcmp6ErrorDpcHandle()
> >
> > VOID
> > EFIAPI
> > PxeBcIcmp6ErrorDpcHandle (
> >   IN VOID *Context
> >   )
> > {
> >  ...
> >
> >   if (Type != ICMP_V6_DEST_UNREACHABLE &&
> >   Type != ICMP_V6_PACKET_TOO_BIG &&
> > -Type != ICMP_V6_PACKET_TOO_BIG &&
> > +Type != ICMP_V6_TIME_EXCEEDED &&
> >   Type != ICMP_V6_PARAMETER_PROBLEM) {
> > //
> > // The type of the receveid packet should be an ICMP6 error message.
> > //
> > gBS->SignalEvent (RxData->RecycleSignal);
> > goto ON_EXIT;
> >   }
> >   ...
> > }
> >
> > Unfortunately, some error checking tools were not able to capture this.
> > Please confirm and take the necessary action.
> >
> > Thank you
> > Naveen
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Repeated condition check

[Santhapur Naveen]

Hi Jiaxin,

Duly noted.
Will mention one of you in the TO/CC list from here onwards.

Thank you
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, September 25, 2017 10:33 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan
Subject: RE: Repeated condition check

Hi Naveen, 

We may ignore your email  if you don't attach any specific receiver (TO OR CC 
list):(.

For the issue, I agree the fix. So, can you help to report the issue on 
Bugzilla? We will create the formal patch to fix it.

Thanks,
Jiaxin



> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Friday, September 22, 2017 4:40 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] Repeated condition check
> 
> Hello guys,
> 
> Any update?
> 
> Thank you
> Naveen
> 
> -Original Message-
> From: Santhapur Naveen
> Sent: Wednesday, September 20, 2017 12:05 PM
> To: edk2-devel@lists.01.org
> Subject: Repeated condition check
> 
> Hi all,
> 
> There is a redundant condition check in the API 
> PxeBcIcmp6ErrorDpcHandle()
> 
> VOID
> EFIAPI
> PxeBcIcmp6ErrorDpcHandle (
>   IN VOID *Context
>   )
> {
>  ...
> 
>   if (Type != ICMP_V6_DEST_UNREACHABLE &&
>   Type != ICMP_V6_PACKET_TOO_BIG &&
> -Type != ICMP_V6_PACKET_TOO_BIG &&
> +Type != ICMP_V6_TIME_EXCEEDED &&
>   Type != ICMP_V6_PARAMETER_PROBLEM) {
> //
> // The type of the receveid packet should be an ICMP6 error message.
> //
> gBS->SignalEvent (RxData->RecycleSignal);
> goto ON_EXIT;
>   }
>   ...
> }
> 
> Unfortunately, some error checking tools were not able to capture this.
> Please confirm and take the necessary action.
> 
> Thank you
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Repeated condition check

[Santhapur Naveen]

Hello guys,

Any update?

Thank you
Naveen

-Original Message-
From: Santhapur Naveen 
Sent: Wednesday, September 20, 2017 12:05 PM
To: edk2-devel@lists.01.org
Subject: Repeated condition check

Hi all,

There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()

VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
  IN VOID *Context
  )
{
 ...

  if (Type != ICMP_V6_DEST_UNREACHABLE &&
  Type != ICMP_V6_PACKET_TOO_BIG &&
-Type != ICMP_V6_PACKET_TOO_BIG &&
+Type != ICMP_V6_TIME_EXCEEDED &&
  Type != ICMP_V6_PARAMETER_PROBLEM) {
//
// The type of the receveid packet should be an ICMP6 error message.
//
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
  }
  ...
}

Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Repeated condition check

[Santhapur Naveen]

Hi all,

There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()

VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
  IN VOID *Context
  )
{
 ...

  if (Type != ICMP_V6_DEST_UNREACHABLE &&
  Type != ICMP_V6_PACKET_TOO_BIG &&
-Type != ICMP_V6_PACKET_TOO_BIG &&
+Type != ICMP_V6_TIME_EXCEEDED &&
  Type != ICMP_V6_PARAMETER_PROBLEM) {
//
// The type of the receveid packet should be an ICMP6 error message.
//
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
  }
  ...
}

Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] RFC 3021-Using 31-bit prefixes on IPv4 Point-to-Point Links /31

[Santhapur Naveen]

Hello all,

Does EDK2 NetworkPkg support RFC 3021-Using 31-bit prefixes on IPv4 
Point-to-Point Links /31 for PXE boot?
I don't think it is. Please confirm.
If not, does edk2 has any plans to implements this?

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] FW: The command 'ifconfig -s ethX dhcp' fails to get IP address

[Santhapur Naveen]

Hello all,

The command 'ifconfig -s ethX dhcp' fails to retrieve an IP address in one of 
our platforms.
It is observed that the DISCOVER packet was also not sent from the client.
However with a modified Shell.efi which I'm not able to attach here, the IP is 
assigned properly (D.O.R.A is successful).
I'm not able to decide whether the issue is with ShellPkg or with the IPv4 
drivers.

Please provide your suggestions to take this further.

Thank you
Naveen

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] iSCSI behavior

[Santhapur Naveen]

Hi Ting,

Noted.
Thank you so much.

Thank You
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Wednesday, August 30, 2017 2:27 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

There is no such document available. It is an implementation choice only.

Thanks,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 30, 2017 4:47 PM
To: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] iSCSI behavior

Hi Ting,

Thank you for your confirmation.
I would like to know if there are any specification document(s) available so 
that I can refer them on need.

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Wednesday, August 30, 2017 1:30 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Naveen,

For 1) Yes.
2) Yes, it is valid in current implementation.

Yes, IPv6 source address should be configured separately. It could be through 
manual or auto configuration.

Thanks,
Ting Ye

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Tuesday, August 29, 2017 8:22 PM
To: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Ting,

Thanks for your reply. I got your point but my question(s) are
1) I agree that if I add two attempts for the same NIC, there will be a warning 
popup. But my question is whether the second attempt also be tried for 
connection if first attempt fails to connect?
2) Is it valid to add two attempts where both are 'Enable for MPIO' for the 
same NIC?

I'm not clear about IPv6, you mean to say we need to configure an IPv6 address 
apart from adding the Attempt?

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Tuesday, August 29, 2017 2:01 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Naveen,

For 1), if you configure two attempts with iSCSI Mode "Enabled", you will 
receive an warning that you have configured two attempts using same NIC. 
If you configure two attempts with iSCSI Mode "Enabled for MPIO", it is valid, 
and if the first attempt failed, the second attempt will be tried.

For 2), Enabled for MPIO means you have enabled multi path I/O in iSCSI for 
supporting failover.

For 3 and 4), iSCSI does not allow configuring one new IPv6 address using iSCSI 
menu so Attempt #1 does not show initiator address.
Instead, iSCSI driver will let IPv6 driver to perform source address selection 
according to the configured iSCSI target IP address. You need assign IPv6 
source address using ifconfig6 or autoconfiguration before using iSCSI on IPv6 
stack.

Thanks,
Ting Ye


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, August 29, 2017 2:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] iSCSI behavior

Hello all,

I've some questions regarding iSCSI. Please help me out.


1.   If I have added two attempts and are enabled for the same MAC, if the 
first attempt fails to connect, will the second attempt be tried?

2.   If answer to the above is YES, then what's the difference between 
ISCSI Modes 'Enabled' and 'Enable for MPIO'?

3.   In our observation, we've found that the behavior is not same when two 
attempts are added for IPv4 and IPv6.

4.   Are there any standard set of test procedures for ISCSI behavior?

The following is the conflict
Case 1:
Attempt#1--Enabled for MPIO--IPv6-DHCP Attempt#2--Enabled for 
MPIO--IPv6-DHCP

Actual behavior: Attempt#2 doesn't show any initiator IPv6 address.

Case 2:
Attempt 1--Enabled for MPIO--IPv4-DHCP Attempt 2--Enabled for 
MPIO--IPv4-DHCP

Actual behavior: Attempt#2 shows Initiator IPv4 address.

Please provide your suggestions.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] iSCSI behavior

[Santhapur Naveen]

Hi Ting,

Thank you for your confirmation.
I would like to know if there are any specification document(s) available so 
that I can refer them on need.

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Wednesday, August 30, 2017 1:30 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Naveen,

For 1) Yes.
2) Yes, it is valid in current implementation.

Yes, IPv6 source address should be configured separately. It could be through 
manual or auto configuration.

Thanks,
Ting Ye

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Tuesday, August 29, 2017 8:22 PM
To: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Ting,

Thanks for your reply. I got your point but my question(s) are
1) I agree that if I add two attempts for the same NIC, there will be a warning 
popup. But my question is whether the second attempt also be tried for 
connection if first attempt fails to connect?
2) Is it valid to add two attempts where both are 'Enable for MPIO' for the 
same NIC?

I'm not clear about IPv6, you mean to say we need to configure an IPv6 address 
apart from adding the Attempt?

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Tuesday, August 29, 2017 2:01 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Naveen,

For 1), if you configure two attempts with iSCSI Mode "Enabled", you will 
receive an warning that you have configured two attempts using same NIC. 
If you configure two attempts with iSCSI Mode "Enabled for MPIO", it is valid, 
and if the first attempt failed, the second attempt will be tried.

For 2), Enabled for MPIO means you have enabled multi path I/O in iSCSI for 
supporting failover.

For 3 and 4), iSCSI does not allow configuring one new IPv6 address using iSCSI 
menu so Attempt #1 does not show initiator address.
Instead, iSCSI driver will let IPv6 driver to perform source address selection 
according to the configured iSCSI target IP address. You need assign IPv6 
source address using ifconfig6 or autoconfiguration before using iSCSI on IPv6 
stack.

Thanks,
Ting Ye


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, August 29, 2017 2:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] iSCSI behavior

Hello all,

I've some questions regarding iSCSI. Please help me out.


1.   If I have added two attempts and are enabled for the same MAC, if the 
first attempt fails to connect, will the second attempt be tried?

2.   If answer to the above is YES, then what's the difference between 
ISCSI Modes 'Enabled' and 'Enable for MPIO'?

3.   In our observation, we've found that the behavior is not same when two 
attempts are added for IPv4 and IPv6.

4.   Are there any standard set of test procedures for ISCSI behavior?

The following is the conflict
Case 1:
Attempt#1--Enabled for MPIO--IPv6-DHCP Attempt#2--Enabled for 
MPIO--IPv6-DHCP

Actual behavior: Attempt#2 doesn't show any initiator IPv6 address.

Case 2:
Attempt 1--Enabled for MPIO--IPv4-DHCP Attempt 2--Enabled for 
MPIO--IPv4-DHCP

Actual behavior: Attempt#2 shows Initiator IPv4 address.

Please provide your suggestions.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] iSCSI behavior

[Santhapur Naveen]

Hi Ting,

Thanks for your reply. I got your point but my question(s) are
1) I agree that if I add two attempts for the same NIC, there will be a warning 
popup. But my question is whether the second attempt also be tried for 
connection if first attempt fails to connect?
2) Is it valid to add two attempts where both are 'Enable for MPIO' for the 
same NIC?

I'm not clear about IPv6, you mean to say we need to configure an IPv6 address 
apart from adding the Attempt?

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Tuesday, August 29, 2017 2:01 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI behavior

Hi Naveen,

For 1), if you configure two attempts with iSCSI Mode "Enabled", you will 
receive an warning that you have configured two attempts using same NIC. 
If you configure two attempts with iSCSI Mode "Enabled for MPIO", it is valid, 
and if the first attempt failed, the second attempt will be tried.

For 2), Enabled for MPIO means you have enabled multi path I/O in iSCSI for 
supporting failover.

For 3 and 4), iSCSI does not allow configuring one new IPv6 address using iSCSI 
menu so Attempt #1 does not show initiator address.
Instead, iSCSI driver will let IPv6 driver to perform source address selection 
according to the configured iSCSI target IP address. You need assign IPv6 
source address using ifconfig6 or autoconfiguration before using iSCSI on IPv6 
stack.

Thanks,
Ting Ye


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, August 29, 2017 2:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] iSCSI behavior

Hello all,

I've some questions regarding iSCSI. Please help me out.


1.   If I have added two attempts and are enabled for the same MAC, if the 
first attempt fails to connect, will the second attempt be tried?

2.   If answer to the above is YES, then what's the difference between 
ISCSI Modes 'Enabled' and 'Enable for MPIO'?

3.   In our observation, we've found that the behavior is not same when two 
attempts are added for IPv4 and IPv6.

4.   Are there any standard set of test procedures for ISCSI behavior?

The following is the conflict
Case 1:
Attempt#1--Enabled for MPIO--IPv6-DHCP Attempt#2--Enabled for 
MPIO--IPv6-DHCP

Actual behavior: Attempt#2 doesn't show any initiator IPv6 address.

Case 2:
Attempt 1--Enabled for MPIO--IPv4-DHCP Attempt 2--Enabled for 
MPIO--IPv4-DHCP

Actual behavior: Attempt#2 shows Initiator IPv4 address.

Please provide your suggestions.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] iSCSI behavior

[Santhapur Naveen]

Hello all,

I've some questions regarding iSCSI. Please help me out.


1.   If I have added two attempts and are enabled for the same MAC, if the 
first attempt fails to connect, will the second attempt be tried?

2.   If answer to the above is YES, then what's the difference between 
ISCSI Modes 'Enabled' and 'Enable for MPIO'?

3.   In our observation, we've found that the behavior is not same when two 
attempts are added for IPv4 and IPv6.

4.   Are there any standard set of test procedures for ISCSI behavior?

The following is the conflict
Case 1:
Attempt#1--Enabled for MPIO--IPv6-DHCP
Attempt#2--Enabled for MPIO--IPv6-DHCP

Actual behavior: Attempt#2 doesn't show any initiator IPv6 address.

Case 2:
Attempt 1--Enabled for MPIO--IPv4-DHCP
Attempt 2--Enabled for MPIO--IPv4-DHCP

Actual behavior: Attempt#2 shows Initiator IPv4 address.

Please provide your suggestions.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] can the DNS driver relays the request?

[Santhapur Naveen]

Hi Jiaxin,

Thanks for the information provided.
Even I have gone through the RFC but wanted to double check.

Thank you
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, August 21, 2017 6:48 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: can the DNS driver relays the request?

Hi Naveen,

I think you mean the DNS relay is that one DNS client sends the DNS queries to 
the relay, then the relay sends the queries to the DNS server or whatever is 
set in the router's settings.

I checked the related RFCs of DNS and can't find the related definitions of 
that, but I believe it's the router's capability to provide the relay service 
just like the DHCP relay. Currently, it have been supported by some routers 
(D-Link or Cisco) but may need your another simple configuration (I'm not sure 
because I haven't tried that).

Besides, in the case you do need the support within the client, you can code 
the app/driver to handle the request first, then call the DNS driver APIs 
provided in NetworkPkg. I think it's the way to relay the request.

Thanks,
Jiaxin




> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Friday, August 18, 2017 1:32 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] can the DNS driver relays the request?
> 
> Hello all,
> 
> I need a piece of information about DNS driver.
> We are aware that the NetworkPkg contains DNS driver.
> Is this driver able to relay a request that has come from another DNS client?
> 
> Thank you
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] can the DNS driver relays the request?

[Santhapur Naveen]

Hello all,

I need a piece of information about DNS driver.
We are aware that the NetworkPkg contains DNS driver.
Is this driver able to relay a request that has come from another DNS client?

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] DHCP Option 61 support

[Santhapur Naveen]

Hello all,

Does the edk2 support DHCP option 61?
I can see some piece of code which makes use of this option in 
MdeModulePkg\Universal\Network\Dhcp4DxeDhcp4Io.c
But I also have found an article 
https://www.intel.com/content/www/us/en/support/software/manageability-products/07129.html
 in conflict.

Please clarify.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] iSCSI Setup in Linux

[Santhapur Naveen]

Hi Rocky,

Thanks for providing the iSCSI setup details.
I shall try and let you know if I have any questions.

Thank you
Naveen

-Original Message-
From: Ni, Xingrong [mailto:xingrong...@intel.com] 
Sent: Tuesday, July 18, 2017 6:51 AM
To: Santhapur Naveen; Ye, Ting; edk2-devel@lists.01.org
Cc: Liu, Jiang A
Subject: RE: iSCSI Setup in Linux

Hi Naveen,

Here is an Iscsi setup simple guider in SUSE SLES11sp3, you can try it and let 
me know if any question. 

Step1:  install iscsitarget on suse
  #zypper in iscsitarget

Step2: Setup an iSCSI target
 1:  Preparing the Storage space
  #mkdir /srv/iscsi
  #dd if=/dev/zero of=/srv/iscsi/disk1.img bs=1M count=4000

 2: Configuring an iSCSI target manually
#gedit /etc/ietd.conf (Delete original ited.conf, then 
create an ited.conf only contain below statement)
 Target iqn.tiano.com:iscsi1
  Lun 0 Path=/srv/iscsi/disk1.img,Type=fileio

 3: Restart iSCSI target server  #service iscsitarget restart

 4: Check Iscsi target server status #service iscsitarget status


Thanks & Best Wishes!
Rocky


-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Friday, July 7, 2017 7:42 PM
To: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org
Subject: RE: iSCSI Setup in Linux

Hi Ting,

I'm open to use any flavor of Linux (Ubuntu, SLES or Redhat...).
Please let me know If there's one such document.

Thank you
Naveen

-Original Message-
From: Ye, Ting [mailto:ting...@intel.com] 
Sent: Friday, July 07, 2017 12:58 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: iSCSI Setup in Linux

Hi Naveen,

May I know which Linux OS are you using to run iSCSI target? I think there are 
different iSCSI targets available in Linux.

Thanks,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Thursday, July 06, 2017 4:45 PM
To: edk2-devel@lists.01.org
Subject: [edk2] iSCSI Setup in Linux

Hi all,

Is there any document explaining the iscsi target configuration in linux OSes.
I've googled and most of the links are not working for me.
Is there's any open document available, would someone point me the url?

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] iSCSI Setup in Linux

[Santhapur Naveen]

Hi all,

Is there any document explaining the iscsi target configuration in linux OSes.
I've googled and most of the links are not working for me.
Is there's any open document available, would someone point me the url?

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] SCT test on EFI_BIS_PROTOCOL

[Santhapur Naveen]

Hi experts,

For one of the SCT test, EFI_BIS_PROTOCOL was needed. But I've tried to find 
out which driver is installing this protocol.
But I find no instance of this.
Please provide your comments on this.

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] IPv6 Stateless autoconfiguration

[Santhapur Naveen]

Hello all,

I have some queries for which the answers are needed from the experts here. 
Please help in answering them.

Does edk2 support IPv6 stateless address autoconfiguration as mentioned in 
RFC4862.
If yes, then why do we have to configure the dhcpv6 service in such a way that 
it provides IPv6 address also for HTTPv6/PXEv6 boot?

Thank you
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] HTTP Boot failed to download NBP file if it is .iso type

[Santhapur Naveen]

Hi Siyuan,

Thank you for your reply.
And regarding the OS installation, we are able to download SUSE iso (>3 GB) 
from the HTTP server. But the install didn't happen.
May I ask you what could be possible reason? Is there anything else I've had 
missed, please let me know.

Regards,
Naveen

-Original Message-
From: Fu, Siyuan [mailto:siyuan...@intel.com] 
Sent: Tuesday, June 13, 2017 8:17 AM
To: Santhapur Naveen; Karunakar P; edk2-devel@lists.01.org
Subject: RE: HTTP Boot failed to download NBP file if it is .iso type

Hi, Karunakar and Naveen

Status 0023 is EFI_HTTP_ERROR, which means the HTTP server replied an HTTP 
error. The HTTP error code is placed in 
HttpIo->RspToken.Message->Data.Response->StatusCode, and will be displayed in 
HttpBootPrintErrorMessage() function.

If a downloaded NBP is a RAM disk image, the BDS will try to find a boot file 
inside it according UEFI 2.7 section 3.5.1 "Boot via the Simple File Protocol".

Best Regards,
Siyuan


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Saturday, June 10, 2017 1:49 AM
To: Karunakar P; edk2-devel@lists.01.org
Subject: Re: [edk2] HTTP Boot failed to download NBP file if it is .iso type

Even if we are able to download an ISO file successfully, how will 
EFI_RAM_DISK_PROTOCOL comes to know what is the efi that needs to be used?

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Karunakar P
Sent: Friday, June 09, 2017 9:04 PM
To: edk2-devel@lists.01.org
Subject: [edk2] HTTP Boot failed to download NBP file if it is .iso type

Hi All,

We have facing an issue with HTTP boot.

[Issue]
HTTP Boot failed to download NBP file if it is an .iso type

[Reproduction Steps]

1.  Configure HTTP Server in Ubuntu environment.

2.  Place any iso image as NBP file.

3.  Perform UEFI HTTPv4 boot.

[Result]
DHCP process was success, But Failed to download NBP file.

[Observations]

1.  As per UEFI spec "23.7.1 Boot from URL" (UEFI 2.6, page 1222).

Here is what the section says about binary image returned by HTTP server:

"...the binary image [..] is a UEFI-formatted executable[...], or it could be 
mounted as a RAM disk which contains a UEFI-compliant file system (see Section 
12.3)."

We're interested in exploring second scenario, when downloaded image is a 
UEFI-compliant file system.

Section "23.7.3.1 Device Path" on page 1226 provides examples of image URL: 
http://192.168.1.100/boot.iso

The specification also says that "the HTTP Boot driver will register RAM disk 
with the downloaded NBP, by appending a RamDisk device node to the device path 
above, like...".



HttpBootDxe is doing this.But NBP file itself failing to download in the case 
of iso image.



2.  HTTP boot fails in the following function



HttpBootGetBootFile() ->



EFI_STATUS

HttpBootGetBootFile (

  IN HTTP_BOOT_PRIVATE_DATA   *Private,

  IN BOOLEAN  HeaderOnly,

  IN OUT UINTN*BufferSize,

 OUT UINT8*Buffer,

 OUT HTTP_BOOT_IMAGE_TYPE *ImageType

  )

{

.

.

.

 Status = HttpIoRecvResponse (

 >HttpIo,

 TRUE,

 ResponseData

 );

// Here the Status value is Success and ResponseData->Status = 0023



  if (EFI_ERROR (Status) || EFI_ERROR (ResponseData->Status)) {

if (EFI_ERROR (ResponseData->Status)) {

  StatusCode = HttpIo->RspToken.Message->Data.Response->StatusCode;

  HttpBootPrintErrorMessage (StatusCode);

  Status = ResponseData->Status;

// Here Status = 0023



}

goto ERROR_5;// goto ERROR_5

  }

.

.

.

}



Note:
We have HTTP server configured in Ubuntu Environment.

Could you please look into it.


Thanks,
karunakar


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
This e-mail is intended for the use of the addressee only and may contain 
privileged, confidential, or proprietary information that is exempt from 
disclosure under law. If you have received this message in error, please inform 
us promptly by reply e-mail, then delete the e-mail and destroy any printed 
copy. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] PXE boot option lacks IPv4 device path

[Santhapur Naveen]

This behavior is seen only in Simulator

From: Santhapur Naveen
Sent: Monday, June 12, 2017 9:27 AM
To: edk2-devel@lists.01.org
Subject: PXE boot option lacks IPv4 device path

Hello all,

I've built and run the Nt32Pkg source from 
here<https://github.com/tianocore/edk2>. I've enabled PXE boot support and I 
could see only MAC device path (005056C2, 0x1) present for all PXEv4 boot 
options something like UEFI PXEv4 MAC(005056C000XX).
But for HTTPv4, the device path is "MAC (005056C2, 
0x01)/IPv4(0.0.0.0, 0x0, DHCP, 0.0.0.0, 0.0.0.0, 0.0.0.0)/Uri()"

 Why the PXE boot option doesn't have the IPv4 device path?

Your comments are highly appreciated.

Regards,
Naveen

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] PXE boot option lacks IPv4 device path

[Santhapur Naveen]

Hello all,

I've built and run the Nt32Pkg source from 
here. I've enabled PXE boot support and I 
could see only MAC device path (005056C2, 0x1) present for all PXEv4 boot 
options something like UEFI PXEv4 MAC(005056C000XX).
But for HTTPv4, the device path is "MAC (005056C2, 
0x01)/IPv4(0.0.0.0, 0x0, DHCP, 0.0.0.0, 0.0.0.0, 0.0.0.0)/Uri()"

 Why the PXE boot option doesn't have the IPv4 device path?

Your comments are highly appreciated.

Regards,
Naveen

___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] HTTP Boot failed to download NBP file if it is .iso type

[Santhapur Naveen]

Even if we are able to download an ISO file successfully, how will 
EFI_RAM_DISK_PROTOCOL comes to know what is the efi that needs to be used?

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Karunakar P
Sent: Friday, June 09, 2017 9:04 PM
To: edk2-devel@lists.01.org
Subject: [edk2] HTTP Boot failed to download NBP file if it is .iso type

Hi All,

We have facing an issue with HTTP boot.

[Issue]
HTTP Boot failed to download NBP file if it is an .iso type

[Reproduction Steps]

1.  Configure HTTP Server in Ubuntu environment.

2.  Place any iso image as NBP file.

3.  Perform UEFI HTTPv4 boot.

[Result]
DHCP process was success, But Failed to download NBP file.

[Observations]

1.  As per UEFI spec "23.7.1 Boot from URL" (UEFI 2.6, page 1222).

Here is what the section says about binary image returned by HTTP server:

"...the binary image [..] is a UEFI-formatted executable[...], or it could be 
mounted as a RAM disk which contains a UEFI-compliant file system (see Section 
12.3)."

We're interested in exploring second scenario, when downloaded image is a 
UEFI-compliant file system.

Section "23.7.3.1 Device Path" on page 1226 provides examples of image URL: 
http://192.168.1.100/boot.iso

The specification also says that "the HTTP Boot driver will register RAM disk 
with the downloaded NBP, by appending a RamDisk device node to the device path 
above, like...".



HttpBootDxe is doing this.But NBP file itself failing to download in the case 
of iso image.



2.  HTTP boot fails in the following function



HttpBootGetBootFile() ->



EFI_STATUS

HttpBootGetBootFile (

  IN HTTP_BOOT_PRIVATE_DATA   *Private,

  IN BOOLEAN  HeaderOnly,

  IN OUT UINTN*BufferSize,

 OUT UINT8*Buffer,

 OUT HTTP_BOOT_IMAGE_TYPE *ImageType

  )

{

.

.

.

 Status = HttpIoRecvResponse (

 >HttpIo,

 TRUE,

 ResponseData

 );

// Here the Status value is Success and ResponseData->Status = 0023



  if (EFI_ERROR (Status) || EFI_ERROR (ResponseData->Status)) {

if (EFI_ERROR (ResponseData->Status)) {

  StatusCode = HttpIo->RspToken.Message->Data.Response->StatusCode;

  HttpBootPrintErrorMessage (StatusCode);

  Status = ResponseData->Status;

// Here Status = 0023



}

goto ERROR_5;// goto ERROR_5

  }

.

.

.

}



Note:
We have HTTP server configured in Ubuntu Environment.

Could you please look into it.


Thanks,
karunakar


___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
This e-mail is intended for the use of the addressee only and may contain 
privileged, confidential, or proprietary information that is exempt from 
disclosure under law. If you have received this message in error, please inform 
us promptly by reply e-mail, then delete the e-mail and destroy any printed 
copy. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] PXE Device path has just only MAC

[Santhapur Naveen]

Hello all,

I've built and run the Nt32Pkg source from 
here. I've enabled PXE boot support and I 
could see only MAC device path as (005056C2, 0x1) for PXEv4 boot options 
(UEFI PXEv4 MAC(005056C000XX)) and for some other PXE boot options as well.
But for HTTPv4, the device path is "MAC (005056C2, 
0x01)/IPv4(0.0.0.0, 0x0, DHCP, 0.0.0.0, 0.0.0.0, 0.0.0.0)/Uri()"

Isn't the PXE boot option should also have IPv4 device path 
followed by MAC? The PciRoot and Pci are prepended to the MAC by the way.
If we keep Uri aside, why the Device path for PXE and HTTP are 
different?

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] HTTPS boot support questions

[Santhapur Naveen]

Hi Jiaxin,

Thanks for the clarification.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Wednesday, June 07, 2017 1:14 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: HTTPS boot support questions

Naveen,

I mean the WinPE/Windows 10 OS can't be installed via UEFI HTTP(S) feature. 
Currently, I only verified the ISO image is SUSE SLES.

Thanks,
Jiaxin



> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Wednesday, June 7, 2017 3:29 PM
> To: Santhapur Naveen <nave...@amiindia.co.in>; Wu, Jiaxin 
> <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: HTTPS boot support questions
> 
> Hi Jiaxin,
> 
> For #2, you meant server for HTTPS can't be configured in Windows 
> alone or the OS can't be installed over HTTPS? I don't think the 
> latter is valid. Please clarify.
> 
> Thanks,
> Naveen
> 
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Wednesday, June 07, 2017 12:43 PM
> To: Wu, Jiaxin; edk2-devel@lists.01.org
> Subject: Re: [edk2] HTTPS boot support questions
> 
> Hi Jiaxin,
> 
> Thanks for your comments.
> 
> Regards,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Wednesday, June 07, 2017 12:41 PM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: HTTPS boot support questions
> 
> Hi Naveen,
> 
> For your question:
> #1: Yes, HTTPS Boot can work with port 80, but you have to close any 
> possible website may be using the same port.
> 
> #2: No, AFAIK, currently, HTTP(S) can't co-work with WinPE/Windows 10 
> OS installation.
> 
> #3: Yes, secure boot feature is not related to HTTPS boot. You can 
> finish the download process no matter secure boot enabled or not. But 
> the download image must be signed to continue the execution.
> 
> Thanks,
> Jiaxin
> 
> 
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Santhapur Naveen
> > Sent: Wednesday, June 7, 2017 12:11 PM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] HTTPS boot support questions
> >
> > Hello,
> >
> > I have some questions regarding HTTPS Boot and are as below.
> >
> > 1. If I'm using iPXE port 80 to communicate with server because of 
> > firewall concern. Does https boot happen  via the same 80 port?
> > 2. Does it support WinPE/Windows 10 OS installation? If yes, is 
> > there any open document available to achieve the same?
> > 3. Does it support network boot without disabling secure boot OS?
> >
> > Thanks in advance,
> > Naveen
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> This e-mail is intended for the use of the addressee only and may 
> contain privileged, confidential, or proprietary information that is 
> exempt from disclosure under law. If you have received this message in 
> error, please inform us promptly by reply e-mail, then delete the 
> e-mail and destroy any printed copy. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] HTTPS boot support questions

[Santhapur Naveen]

Hi Jiaxin,

For #2, you meant server for HTTPS can't be configured in Windows alone or the 
OS can't be installed over HTTPS? I don't think the latter is valid. Please 
clarify.

Thanks,
Naveen

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, June 07, 2017 12:43 PM
To: Wu, Jiaxin; edk2-devel@lists.01.org
Subject: Re: [edk2] HTTPS boot support questions

Hi Jiaxin,

Thanks for your comments.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Wednesday, June 07, 2017 12:41 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: HTTPS boot support questions

Hi Naveen,

For your question:
#1: Yes, HTTPS Boot can work with port 80, but you have to close any possible 
website may be using the same port.

#2: No, AFAIK, currently, HTTP(S) can't co-work with WinPE/Windows 10 OS 
installation.

#3: Yes, secure boot feature is not related to HTTPS boot. You can finish the 
download process no matter secure boot enabled or not. But the download image 
must be signed to continue the execution.

Thanks,
Jiaxin



> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Wednesday, June 7, 2017 12:11 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] HTTPS boot support questions
>
> Hello,
>
> I have some questions regarding HTTPS Boot and are as below.
>
> 1. If I'm using iPXE port 80 to communicate with server because of 
> firewall concern. Does https boot happen  via the same 80 port?
> 2. Does it support WinPE/Windows 10 OS installation? If yes, is there 
> any open document available to achieve the same?
> 3. Does it support network boot without disabling secure boot OS?
>
> Thanks in advance,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
This e-mail is intended for the use of the addressee only and may contain 
privileged, confidential, or proprietary information that is exempt from 
disclosure under law. If you have received this message in error, please inform 
us promptly by reply e-mail, then delete the e-mail and destroy any printed 
copy. Thank you.
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] HTTPS boot support questions

[Santhapur Naveen]

Hi Jiaxin,

Thanks for your comments.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Wednesday, June 07, 2017 12:41 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: HTTPS boot support questions

Hi Naveen,

For your question:
#1: Yes, HTTPS Boot can work with port 80, but you have to close any possible 
website may be using the same port.

#2: No, AFAIK, currently, HTTP(S) can't co-work with WinPE/Windows 10 OS 
installation.

#3: Yes, secure boot feature is not related to HTTPS boot. You can finish the 
download process no matter secure boot enabled or not. But the download image 
must be signed to continue the execution.

Thanks,
Jiaxin



> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Wednesday, June 7, 2017 12:11 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] HTTPS boot support questions
> 
> Hello,
> 
> I have some questions regarding HTTPS Boot and are as below.
> 
> 1. If I'm using iPXE port 80 to communicate with server because of 
> firewall concern. Does https boot happen  via the same 80 port?
> 2. Does it support WinPE/Windows 10 OS installation? If yes, is there 
> any open document available to achieve the same?
> 3. Does it support network boot without disabling secure boot OS?
> 
> Thanks in advance,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] HTTPS boot support questions

[Santhapur Naveen]

Hello,

I have some questions regarding HTTPS Boot and are as below.

1. If I'm using iPXE port 80 to communicate with server because of firewall 
concern. Does https boot happen  via the same 80 port?
2. Does it support WinPE/Windows 10 OS installation? If yes, is there any open 
document available to achieve the same?
3. Does it support network boot without disabling secure boot OS?

Thanks in advance,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] TFTP over IPv6 across /64 subnet

[Santhapur Naveen]

Hello all,

Does the current EDKII supports TFTP over IPv6 across /64 
subnet?
If not, does EDKII have any plans to support?

Thanks in advance.

Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Jiaxin,

Filed a bug in the bugzilla 
https://bugzilla.tianocore.org/show_bug.cgi?id=489
Let me know if you may need any details.

Regards,
Naveen
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, April 17, 2017 12:12 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Zhang, Lubo
Subject: RE: SUT hangs after performing a warm boot.

Naveen, 

Can you record the issue @ Bugzilla first? Then, we can update the process 
directly.

Thanks,
Jiaxin

> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Monday, April 17, 2017 2:36 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Zhang, Lubo <lubo.zh...@intel.com>
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Thank you Jiaxin. I didn't have access to my mail for the last 3-4 
> days. Sorry for the delay.
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Monday, April 17, 2017 12:05 PM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Cc: Zhang, Lubo
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Thanks Naveen,  I will try reproduce it, then report to you.
> 
> 
> > -Original Message-
> > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > Sent: Monday, April 17, 2017 2:33 PM
> > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Hi Jiaxin,
> >
> > The latter is correct. Restart the windows and the hang happens.
> >
> > Thanks,
> > Naveen
> >
> > -Original Message-
> > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > Sent: Thursday, April 13, 2017 1:34 PM
> > To: Wu, Jiaxin; Santhapur Naveen; edk2-devel@lists.01.org
> > Cc: Zhang, Lubo
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Or do you mean the issue should be reproduce at window warm boot 
> > with below steps?
> >
> > 1. Boot to windows
> > 2. restart the windows, then hang happen?
> >
> > Thanks,
> > Jiaxin
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On 
> > > Behalf Of Wu, Jiaxin
> > > Sent: Thursday, April 13, 2017 3:48 PM
> > > To: Santhapur Naveen <nave...@amiindia.co.in>; 
> > > edk2-devel@lists.01.org
> > > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > > Subject: Re: [edk2] SUT hangs after performing a warm boot.
> > >
> > > Naveen,
> > >
> > > Do you mean only the "reset -w" operation caused the hang? Need us 
> > > change the IPv6 policy?
> > >
> > > Thanks,
> > > Jiaxin
> > >
> > > > -Original Message-
> > > > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > > > Sent: Wednesday, April 12, 2017 8:12 PM
> > > > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > > > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > > > Subject: RE: SUT hangs after performing a warm boot.
> > > >
> > > > Hi Jiaxin,
> > > >
> > > > The patch in your previous mail doesn't help. The issue still 
> > > > exists even after the patch.
> > > > After some debugging, it is found that it hangs in 
> > > > p6SendNeighborSolicit()->Ip6Output()call.
> > > >
> > > > //
> > > >   // Send the Neighbor Solicitation message with
> > > >   // Source - unspecified address, destination - 
> > > > solicited-node multicast address
> > > >   // Target - the address to be validated
> > > >   //
> > > >   Status = Ip6SendNeighborSolicit (
> > > >  IpSb,
> > > >  NULL,
> > > >  >Destination,
> > > >  >AddressInfo->Address,
> > > >      NULL
> > > >  );
> > > >
> > > > I shall update you more information soon.
> > > >
> > > > Thanks,
> > > > Naveen
> > > >
> > > > -Original Message-
> > > > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > > > Sent: Tuesday, April 11, 2017 8:55 AM
> > > > To: Santhapur Naveen; edk2-devel@lists.01

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Thank you Jiaxin. I didn't have access to my mail for the last 3-4 days. Sorry 
for the delay.

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, April 17, 2017 12:05 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Zhang, Lubo
Subject: RE: SUT hangs after performing a warm boot.

Thanks Naveen,  I will try reproduce it, then report to you. 


> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Monday, April 17, 2017 2:33 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Zhang, Lubo <lubo.zh...@intel.com>
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Hi Jiaxin,
> 
>   The latter is correct. Restart the windows and the hang happens.
> 
> Thanks,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Thursday, April 13, 2017 1:34 PM
> To: Wu, Jiaxin; Santhapur Naveen; edk2-devel@lists.01.org
> Cc: Zhang, Lubo
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Or do you mean the issue should be reproduce at window warm boot with 
> below steps?
> 
> 1. Boot to windows
> 2. restart the windows, then hang happen?
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Wu, Jiaxin
> > Sent: Thursday, April 13, 2017 3:48 PM
> > To: Santhapur Naveen <nave...@amiindia.co.in>; 
> > edk2-devel@lists.01.org
> > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > Subject: Re: [edk2] SUT hangs after performing a warm boot.
> >
> > Naveen,
> >
> > Do you mean only the "reset -w" operation caused the hang? Need us 
> > change the IPv6 policy?
> >
> > Thanks,
> > Jiaxin
> >
> > > -Original Message-
> > > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > > Sent: Wednesday, April 12, 2017 8:12 PM
> > > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > > Subject: RE: SUT hangs after performing a warm boot.
> > >
> > > Hi Jiaxin,
> > >
> > >   The patch in your previous mail doesn't help. The issue still 
> > > exists even after the patch.
> > >   After some debugging, it is found that it hangs in 
> > > p6SendNeighborSolicit()->Ip6Output()call.
> > >
> > >   //
> > >   // Send the Neighbor Solicitation message with
> > >   // Source - unspecified address, destination - 
> > > solicited-node multicast address
> > >   // Target - the address to be validated
> > >   //
> > >   Status = Ip6SendNeighborSolicit (
> > >      IpSb,
> > >  NULL,
> > >  >Destination,
> > >  >AddressInfo->Address,
> > >  NULL
> > >  );
> > >
> > >   I shall update you more information soon.
> > >
> > > Thanks,
> > > Naveen
> > >
> > > -Original Message-
> > > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > > Sent: Tuesday, April 11, 2017 8:55 AM
> > > To: Santhapur Naveen; edk2-devel@lists.01.org
> > > Cc: Zhang, Lubo
> > > Subject: RE: SUT hangs after performing a warm boot.
> > >
> > > Ok, I didn't loop in another email discussion. I just reviewed the 
> > > patch from Lubo, and I think it may be related to this issue since 
> > > both of them are triggered  by Ip6NdFasterTimerTicking.
> > >
> > > Thanks,
> > > Jiaxin
> > >
> > > > -Original Message-
> > > > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > > > Sent: Tuesday, April 11, 2017 10:20 AM
> > > > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > > > Subject: RE: SUT hangs after performing a warm boot.
> > > >
> > > > Hi Jiaxin,
> > > >
> > > > I think this patch is for another fix which causes ASSERT. But 
> > > > anyways I'll give it a try and update you.
> > > >
> > > > Thanks,
> > > > Naveen
> > > >
> > > > -Original Message-
> > > > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > > > Sent: Tuesday, April 11, 2017 7:05 AM
> > > > To: Santhapur Naveen; edk2-devel@lists.01.org

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Hi Jiaxin,

The latter is correct. Restart the windows and the hang happens.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Thursday, April 13, 2017 1:34 PM
To: Wu, Jiaxin; Santhapur Naveen; edk2-devel@lists.01.org
Cc: Zhang, Lubo
Subject: RE: SUT hangs after performing a warm boot.

Or do you mean the issue should be reproduce at window warm boot with below 
steps?

1. Boot to windows
2. restart the windows, then hang happen?

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Wu, Jiaxin
> Sent: Thursday, April 13, 2017 3:48 PM
> To: Santhapur Naveen <nave...@amiindia.co.in>; edk2-devel@lists.01.org
> Cc: Zhang, Lubo <lubo.zh...@intel.com>
> Subject: Re: [edk2] SUT hangs after performing a warm boot.
> 
> Naveen,
> 
> Do you mean only the "reset -w" operation caused the hang? Need us 
> change the IPv6 policy?
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > Sent: Wednesday, April 12, 2017 8:12 PM
> > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > Cc: Zhang, Lubo <lubo.zh...@intel.com>
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Hi Jiaxin,
> >
> > The patch in your previous mail doesn't help. The issue still 
> > exists even after the patch.
> > After some debugging, it is found that it hangs in 
> > p6SendNeighborSolicit()->Ip6Output()call.
> >
> > //
> >   // Send the Neighbor Solicitation message with
> >   // Source - unspecified address, destination - 
> > solicited-node multicast address
> >   // Target - the address to be validated
> >   //
> >   Status = Ip6SendNeighborSolicit (
> >  IpSb,
> >  NULL,
> >  >Destination,
> >  >AddressInfo->Address,
> >  NULL
> >  );
> >
> > I shall update you more information soon.
> >
> > Thanks,
> > Naveen
> >
> > -Original Message-
> > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > Sent: Tuesday, April 11, 2017 8:55 AM
> > To: Santhapur Naveen; edk2-devel@lists.01.org
> > Cc: Zhang, Lubo
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Ok, I didn't loop in another email discussion. I just reviewed the 
> > patch from Lubo, and I think it may be related to this issue since 
> > both of them are triggered  by Ip6NdFasterTimerTicking.
> >
> > Thanks,
> > Jiaxin
> >
> > > -Original Message-
> > > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > > Sent: Tuesday, April 11, 2017 10:20 AM
> > > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > > Subject: RE: SUT hangs after performing a warm boot.
> > >
> > > Hi Jiaxin,
> > >
> > >   I think this patch is for another fix which causes ASSERT. But 
> > > anyways I'll give it a try and update you.
> > >
> > > Thanks,
> > > Naveen
> > >
> > > -Original Message-
> > > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > > Sent: Tuesday, April 11, 2017 7:05 AM
> > > To: Santhapur Naveen; edk2-devel@lists.01.org
> > > Subject: RE: SUT hangs after performing a warm boot.
> > >
> > > Hi Naveen,
> > >
> > > Can you help to verify whether the attached patch can resolve your issue?
> > >
> > > Thanks,
> > > Jiaxin
> > >
> > > > -Original Message-
> > > > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > > > Sent: Monday, April 10, 2017 7:31 PM
> > > > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > > > Subject: RE: SUT hangs after performing a warm boot.
> > > >
> > > > Hi Jiaxin,
> > > >
> > > > Below are the simple reproduction steps:
> > > >
> > > > BIOS UEFI Class3
> > > > (1)   Connect LAN cable (Realtek)
> > > > (2)   Do cold boot or warm boot stress (Windows 10)
> > > >
> > > > Please let me know for any additional information you may need.
> > > >
> > > > Thanks,
> > > > Naveen
> > > >
> > > > -Original Message-

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Hi Jiaxin,

The patch in your previous mail doesn't help. The issue still exists 
even after the patch.
After some debugging, it is found that it hangs in 
p6SendNeighborSolicit()->Ip6Output()call.

//
  // Send the Neighbor Solicitation message with
  // Source - unspecified address, destination - solicited-node 
multicast address
  // Target - the address to be validated
  //
  Status = Ip6SendNeighborSolicit (
 IpSb,
 NULL,
 >Destination,
 >AddressInfo->Address,
 NULL
 );

I shall update you more information soon.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Tuesday, April 11, 2017 8:55 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Zhang, Lubo
Subject: RE: SUT hangs after performing a warm boot.

Ok, I didn't loop in another email discussion. I just reviewed the patch from 
Lubo, and I think it may be related to this issue since both of them are 
triggered  by Ip6NdFasterTimerTicking.

Thanks,
Jiaxin

> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Tuesday, April 11, 2017 10:20 AM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Hi Jiaxin,
> 
>   I think this patch is for another fix which causes ASSERT. But 
> anyways I'll give it a try and update you.
> 
> Thanks,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Tuesday, April 11, 2017 7:05 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Hi Naveen,
> 
> Can you help to verify whether the attached patch can resolve your issue?
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > Sent: Monday, April 10, 2017 7:31 PM
> > To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Hi Jiaxin,
> >
> > Below are the simple reproduction steps:
> >
> > BIOS UEFI Class3
> > (1)   Connect LAN cable (Realtek)
> > (2)   Do cold boot or warm boot stress (Windows 10)
> >
> > Please let me know for any additional information you may need.
> >
> > Thanks,
> > Naveen
> >
> > -Original Message-
> > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > Sent: Monday, April 10, 2017 6:00 AM
> > To: Santhapur Naveen; edk2-devel@lists.01.org
> > Subject: RE: SUT hangs after performing a warm boot.
> >
> > Hi Naveen,
> >
> > As the description of Ip6NdFasterTimerTicking(), it's the time 
> > routine of ND module for IPv6.
> >
> > Can you provide the detailed reproduce steps?
> >
> > Thanks,
> > Jiaxin
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On 
> > > Behalf Of Santhapur Naveen
> > > Sent: Friday, April 7, 2017 8:20 PM
> > > To: edk2-devel@lists.01.org
> > > Subject: [edk2] SUT hangs after performing a warm boot.
> > >
> > > Hi all,
> > >
> > >   Under NetworkPkg, in Ip6Dxe driver, what purpose does 
> > > this function
> > > Ip6NdFasterTimerTicking() serve?
> > >   Sometimes, the SUT hangs in this function (at
> > > bootmgfw.Entry) when booting to Windows after performing a warm
> boot.
> > >
> > > Thanks,
> > > Naveen
> > > ___
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

[Santhapur Naveen]

Hi Jiaxin,

Thank you very much.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Tuesday, April 11, 2017 5:06 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: What happens if I have 2 DNS in the OFFER packet

Ok, I will try it tomorrow morning, then update it to you. Thanks report.

Thanks,
Jiaxin  

> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Tuesday, April 11, 2017 7:32 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: What happens if I have 2 DNS in the OFFER packet
> 
> Hi Jiaxin,
> 
>   Yeah, I've been using 'ifconfig -s eth0 dhcp' from shell to set the 
> IP address.
> 
> Regards,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Tuesday, April 11, 2017 5:00 PM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: What happens if I have 2 DNS in the OFFER packet
> 
> Hi Naveen,
> 
> Do you use the "ifconfig -s eth0 dhcp" command to set the IP address? 
> For
> Ip4config2 protocol, no matter how many DNS in offer packet, all of 
> will be configured (See Ip4Config2OnDhcp4Complete).
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Santhapur Naveen
> > Sent: Tuesday, April 11, 2017 5:29 PM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] What happens if I have 2 DNS in the OFFER packet
> >
> > Hi all,
> >
> > I've been facing an issue which is "IP is not assigned 
> > to the SUT if the received OFFER packet contains 2 DNS entries."
> > I don't have the environment with me. When I compared 
> > the Wireshark log in success and failure cases sent to me, I see no 
> > differences except the DNS entries in the OFFFER are different.
> >
> > In the failure case, DISCOVER packet is sent four times 
> > as per RFC. And the server is sending OFFER packet all the four 
> > times, but the SUT is not accepting. Since I don't have the 
> > environment in which there will be two DNS entries, I'm not in a 
> > position to provide more
> details.
> >
> > Is this an expected behavior or am I missing anything?
> >
> > Regards,
> > Naveen
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] What happens if I have 2 DNS in the OFFER packet

[Santhapur Naveen]

Hi Jiaxin,

Yeah, I've been using 'ifconfig -s eth0 dhcp' from shell to set the IP 
address.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Tuesday, April 11, 2017 5:00 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: What happens if I have 2 DNS in the OFFER packet

Hi Naveen,

Do you use the "ifconfig -s eth0 dhcp" command to set the IP address? For 
Ip4config2 protocol, no matter how many DNS in offer packet, all of will be 
configured (See Ip4Config2OnDhcp4Complete).

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Tuesday, April 11, 2017 5:29 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] What happens if I have 2 DNS in the OFFER packet
> 
> Hi all,
> 
> I've been facing an issue which is "IP is not assigned to 
> the SUT if the received OFFER packet contains 2 DNS entries."
> I don't have the environment with me. When I compared the 
> Wireshark log in success and failure cases sent to me, I see no 
> differences except the DNS entries in the OFFFER are different.
> 
> In the failure case, DISCOVER packet is sent four times as 
> per RFC. And the server is sending OFFER packet all the four times, 
> but the SUT is not accepting. Since I don't have the environment in 
> which there will be two DNS entries, I'm not in a position to provide more 
> details.
> 
> Is this an expected behavior or am I missing anything?
> 
> Regards,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] What happens if I have 2 DNS in the OFFER packet

[Santhapur Naveen]

Hi all,

I've been facing an issue which is "IP is not assigned to the SUT 
if the received OFFER packet contains 2 DNS entries."
I don't have the environment with me. When I compared the Wireshark 
log in success and failure cases sent to me, I see no differences except the 
DNS entries in the OFFFER are different.

In the failure case, DISCOVER packet is sent four times as per RFC. 
And the server is sending OFFER packet all the four times, but the SUT is not 
accepting. Since I don't have the environment in which there will be two DNS 
entries, I'm not in a position to provide more details.

Is this an expected behavior or am I missing anything?

Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Array out of bounds write

[Santhapur Naveen]

Hello all,

In the file PxeBcSupport.c of NetworkPkg there is

EFI_STATUS
PxeBcUdp4Write (
{
...
//
// Arrange one fragment buffer for data, and another fragment 
buffer for header if has.
//
FragCount = (HeaderSize != NULL) ? 2 : 1;
...
TxData->FragmentTable[FragCount - 1].FragmentLength = (UINT32) 
*BufferSize;
...
}

And similarly in

EFI_STATUS
PxeBcUdp6Write (
{
...
//
// Arrange one fragment buffer for data, and another fragment 
buffer for header if has.
//
FragCount = (HeaderSize != NULL) ? 2 : 1;
...
TxData->FragmentTable[FragCount - 1].FragmentLength = (UINT32) 
*BufferSize;
...
}

If HeaderSize is not NULL, then there is a chance of writing array over bounds 
since FragmentTable is of single element.

///
  /// Array of fragment descriptors.
  ///
  EFI_UDP6_FRAGMENT_DATAFragmentTable[1];

Shouldn't we be taking care of this?


Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Hi Jiaxin,

I think this patch is for another fix which causes ASSERT. But anyways 
I'll give it a try and update you.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Tuesday, April 11, 2017 7:05 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: SUT hangs after performing a warm boot.

Hi Naveen,

Can you help to verify whether the attached patch can resolve your issue?

Thanks,
Jiaxin

> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Monday, April 10, 2017 7:31 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Hi Jiaxin,
> 
>   Below are the simple reproduction steps:
> 
>   BIOS UEFI Class3
>   (1)   Connect LAN cable (Realtek)
>   (2)   Do cold boot or warm boot stress (Windows 10)
> 
>   Please let me know for any additional information you may need.
> 
> Thanks,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Monday, April 10, 2017 6:00 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: SUT hangs after performing a warm boot.
> 
> Hi Naveen,
> 
> As the description of Ip6NdFasterTimerTicking(), it's the time routine 
> of ND module for IPv6.
> 
> Can you provide the detailed reproduce steps?
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Santhapur Naveen
> > Sent: Friday, April 7, 2017 8:20 PM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] SUT hangs after performing a warm boot.
> >
> > Hi all,
> >
> >   Under NetworkPkg, in Ip6Dxe driver, what purpose does this 
> > function
> > Ip6NdFasterTimerTicking() serve?
> >   Sometimes, the SUT hangs in this function (at
> > bootmgfw.Entry) when booting to Windows after performing a warm boot.
> >
> > Thanks,
> > Naveen
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Hi Jiaxin,

Below are the simple reproduction steps:

BIOS UEFI Class3
(1)   Connect LAN cable (Realtek)
(2)   Do cold boot or warm boot stress (Windows 10)

Please let me know for any additional information you may need.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Monday, April 10, 2017 6:00 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: SUT hangs after performing a warm boot.

Hi Naveen,

As the description of Ip6NdFasterTimerTicking(), it's the time routine of ND 
module for IPv6.

Can you provide the detailed reproduce steps?

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Friday, April 7, 2017 8:20 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] SUT hangs after performing a warm boot.
> 
> Hi all,
> 
>   Under NetworkPkg, in Ip6Dxe driver, what purpose does this 
> function
> Ip6NdFasterTimerTicking() serve?
>   Sometimes, the SUT hangs in this function (at 
> bootmgfw.Entry) when booting to Windows after performing a warm boot.
> 
> Thanks,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] SUT hangs after performing a warm boot.

[Santhapur Naveen]

Hi all,

  Under NetworkPkg, in Ip6Dxe driver, what purpose does this function 
Ip6NdFasterTimerTicking() serve?
  Sometimes, the SUT hangs in this function (at bootmgfw.Entry) when 
booting to Windows after performing a warm boot.

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Unnecessary parameter validation in ISCSI or Full parameter check would be better !!

[Santhapur Naveen]

Hi,

  In iSCSI, there's a comment which says "Only do full parameter 
validation if iSCSI is enabled on this device." In such case, why iSCSI 
validates only a few of the parameters like Target Name, CHAP Secret and 
Reverse CHAP Secret.

  I believe the validation is unnecessary as the Attempt will not be 
considered for connection. Or Since we anyway save it to NVRAM, is it better to 
validate all the attempt details even though the mode is disabled?

Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ASSERT with PXE IPv6 boot.

[Santhapur Naveen]

Hi Lubo,

The issue can be reproduced when we set the PXE IPv6 as first boot 
option and let the system boot to it. Cancel when you get the windows Login 
page and it boots to PXE IPv6 again. In this case, ASSERT happens.

Note: we have a WDS server configured for deployment.

The issue CANNOT be reproduced when we boot to setup on every reboot 
and select the PXE IPv6 boot option.

Please see if you can reproduce with this environment. We will see from 
our side and provide you any useful information we find.

Thank you,
Naveen

-Original Message-
From: Santhapur Naveen 
Sent: Thursday, March 23, 2017 2:02 PM
To: 'Zhang, Lubo'
Cc: Ye, Ting; edk2-devel@lists.01.org
Subject: RE: ASSERT with PXE IPv6 boot.

Hi Lubo,

Thanks for the update.
I'll debug and see for more information and let you know.

Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, March 23, 2017 1:21 PM
To: Santhapur Naveen
Cc: Ye, Ting; edk2-devel@lists.01.org
Subject: RE: ASSERT with PXE IPv6 boot.

Hi Naveen

 I have made a quick test on Denlow platform following the steps to install 
windows 10, but cannot reproduce.


Thanks
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting
Sent: Thursday, March 23, 2017 1:18 PM
To: Santhapur Naveen <nave...@amiindia.co.in>; edk2-devel@lists.01.org
Subject: Re: [edk2] ASSERT with PXE IPv6 boot.

Hi Naveen,

Thanks for reporting this. We will have a try whether we could reproduce this 
issue.

Best Regards,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, March 21, 2017 11:08 PM
To: edk2-devel@lists.01.org
Subject: [edk2] ASSERT with PXE IPv6 boot.

Hello all,

I've a Windows Deployment Services PXE server supporting IPv6 with Windows 
10 installers present. I've been getting ASSERT with PXE IPv6 in the following 
scenario.
1) Enable IPv6 Support
2) PXE Boot to Win 10 installer
3) Cancel the install process (Causes system to reboot)
4) Attempt to PXE boot. Here the system hangs on the PXE boot screen.

and it ASSERTs at Ip6Dxe\Ip6ConfigImpl.c(797): Index != Item->DataSize / sizeof 
(EFI_IP6_CONFIG_MANUAL_ADDRESS).

Your suggestions is highly appreciated.

Best Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Vfr compiler error

[Santhapur Naveen]

Hi Liming,

That solves the build issues. :) 

Thank you,
Naveen

-Original Message-
From: Gao, Liming [mailto:liming@intel.com] 
Sent: Friday, March 31, 2017 6:15 AM
To: Dong, Eric; Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Vfr compiler error

Naveen:
  This has been supported in the latest BaseTools. Please update 
edk2-BaseTools-win32 repo, and try again. 

Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dong, 
> Eric
> Sent: Thursday, March 30, 2017 9:28 PM
> To: Santhapur Naveen <nave...@amiindia.co.in>; edk2-devel@lists.01.org
> Subject: Re: [edk2] Vfr compiler error
> 
> Hi Naveen,
> 
> Current VfrCompiler not support get value from PCD. Do you use PCD function 
> in the data structure?
> 
> Thanks,
> Eric
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Thursday, March 30, 2017 8:27 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Vfr compiler error
> 
> Hi guys,
> 
>   Facing some kind of error while building Nt32Pkg
> 
> VfrCompile...
> IScsiConfigNVDataStruc.h(211): ERROR 12288: FixedPcdGet8
> : unexpected token
> 
> VfrCompile...
> IScsiConfigNVDataStruc.h(211): ERROR 12288: (
> : unexpected token
> 
> VfrCompile...
> IScsiConfigNVDataStruc.h(211): ERROR 12288: )
> : unexpected token
> 
> Am I missing anything?
> 
> Regards,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Vfr compiler error

[Santhapur Naveen]

Hi guys,

  Facing some kind of error while building Nt32Pkg

VfrCompile...
IScsiConfigNVDataStruc.h(211): ERROR 12288: FixedPcdGet8
: unexpected token

VfrCompile...
IScsiConfigNVDataStruc.h(211): ERROR 12288: (
: unexpected token

VfrCompile...
IScsiConfigNVDataStruc.h(211): ERROR 12288: )
: unexpected token

Am I missing anything?

Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ASSERT with PXE IPv6 boot.

[Santhapur Naveen]

Hi Lubo,

Thanks for the update.
I'll debug and see for more information and let you know.

Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, March 23, 2017 1:21 PM
To: Santhapur Naveen
Cc: Ye, Ting; edk2-devel@lists.01.org
Subject: RE: ASSERT with PXE IPv6 boot.

Hi Naveen

 I have made a quick test on Denlow platform following the steps to install 
windows 10, but cannot reproduce.


Thanks
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting
Sent: Thursday, March 23, 2017 1:18 PM
To: Santhapur Naveen <nave...@amiindia.co.in>; edk2-devel@lists.01.org
Subject: Re: [edk2] ASSERT with PXE IPv6 boot.

Hi Naveen,

Thanks for reporting this. We will have a try whether we could reproduce this 
issue.

Best Regards,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, March 21, 2017 11:08 PM
To: edk2-devel@lists.01.org
Subject: [edk2] ASSERT with PXE IPv6 boot.

Hello all,

I've a Windows Deployment Services PXE server supporting IPv6 with Windows 
10 installers present. I've been getting ASSERT with PXE IPv6 in the following 
scenario.
1) Enable IPv6 Support
2) PXE Boot to Win 10 installer
3) Cancel the install process (Causes system to reboot)
4) Attempt to PXE boot. Here the system hangs on the PXE boot screen.

and it ASSERTs at Ip6Dxe\Ip6ConfigImpl.c(797): Index != Item->DataSize / sizeof 
(EFI_IP6_CONFIG_MANUAL_ADDRESS).

Your suggestions is highly appreciated.

Best Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] ASSERT with PXE IPv6 boot.

[Santhapur Naveen]

Hello all,

I've a Windows Deployment Services PXE server supporting IPv6 with Windows 
10 installers present. I've been getting ASSERT with PXE IPv6 in the following 
scenario.
1) Enable IPv6 Support
2) PXE Boot to Win 10 installer
3) Cancel the install process (Causes system to reboot)
4) Attempt to PXE boot. Here the system hangs on the PXE boot screen.

and it ASSERTs at Ip6Dxe\Ip6ConfigImpl.c(797): Index != Item->DataSize / sizeof 
(EFI_IP6_CONFIG_MANUAL_ADDRESS).

Your suggestions is highly appreciated.

Best Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Verifying HTTP Boot in Home environment

[Santhapur Naveen]

Hi Jiaxin,

I think my earlier result was in a corporate environment. I might have missed 
something while verifying the same. :(
Please let me know if my understanding about this is correct or not.

The normal DHCP configuration in a corporate environment looks like this.

default-lease-time 600;  
max-lease-time 7200;
allow booting;
option domain-name "cloudboot.com";
option domain-name-servers 192.168.184.1;
option vendor-class-identifier "HTTPClient";
option bootfile-name "http://www.cloudboot.com/EFI/Shell.efi;;

subnet 192.168.xx.0 netmask 255.255.255.0 {
  range 192.168.xx.ad 192.168.xx.cd;
}

and for home environment, it is almost the same except "option bootfile-name 
"http://www.cloudboot.com/EFI/Shell.efi";; will not be present.

If my understanding is not correct, please let me know.

Thanks,
Naveen

From: Wu, Jiaxin [jiaxin...@intel.com]
Sent: Monday, March 20, 2017 1:47 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Verifying HTTP Boot in Home environment

Great:).

> -----Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Monday, March 20, 2017 4:14 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Subject: RE: Verifying HTTP Boot in Home environment
>
> Hi Jiaxin,
>
> Thanks for your prompt reply.
> I've verified like the same and got the expected output.
>
> Many Thanks,
> Naveen
> ____
> From: Wu, Jiaxin [jiaxin...@intel.com]
> Sent: Monday, March 20, 2017 1:25 PM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: Verifying HTTP Boot in Home environment
>
> Hello Naveen,
>
> You can refer to the below wiki page for the detailed HTTP home
> environment usage:
> https://github.com/tianocore/tianocore.github.io/wiki/HTTP-Boot
>
> Thanks,
> Jiaxin
>
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> > Santhapur Naveen
> > Sent: Monday, March 20, 2017 3:07 PM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] Verifying HTTP Boot in Home environment
> >
> > Hello all,
> >
> > The commit, fa848a4048943251fc057fe8d6c5a82e01d2ffb6 adds the
> > support for HTTP Boot usage in home environment. Would anyone out
> here
> > please help me the procedure to verify this?
> >
> > Best Regards,
> > Naveen
> > ___
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Verifying HTTP Boot in Home environment

[Santhapur Naveen]

Hi Jiaxin,

Thanks for your prompt reply.
I've verified like the same and got the expected output.

Many Thanks,
Naveen

From: Wu, Jiaxin [jiaxin...@intel.com]
Sent: Monday, March 20, 2017 1:25 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Verifying HTTP Boot in Home environment

Hello Naveen,

You can refer to the below wiki page for the detailed HTTP home environment 
usage:
https://github.com/tianocore/tianocore.github.io/wiki/HTTP-Boot

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Santhapur Naveen
> Sent: Monday, March 20, 2017 3:07 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] Verifying HTTP Boot in Home environment
>
> Hello all,
>
> The commit, fa848a4048943251fc057fe8d6c5a82e01d2ffb6 adds the
> support for HTTP Boot usage in home environment. Would anyone out here
> please help me the procedure to verify this?
>
> Best Regards,
> Naveen
> ___
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Verifying HTTP Boot in Home environment

[Santhapur Naveen]

Hello all,

The commit, fa848a4048943251fc057fe8d6c5a82e01d2ffb6 adds the support for 
HTTP Boot usage in home environment. Would anyone out here please help me the 
procedure to verify this?

Best Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ISCSI says "Session Doesn't Exist"

[Santhapur Naveen]

Hi Lubo,

Many thanks for your update.

You mean to say that this issue is because of the TCP Service and this can be 
fixed with the path you are yet to send. Am I right?

Warm Regards,
Naveen

From: Zhang, Lubo [lubo.zh...@intel.com]
Sent: Tuesday, March 14, 2017 7:24 AM
To: Santhapur Naveen
Cc: Ye, Ting; edk2-devel@lists.01.org
Subject: RE: ISCSI says "Session Doesn't Exist"

Hi Naveen

 For this issue you mentioned, I have found the root cause. After we 
established the iSCSI connection between initiator and target server, if we use 
the following command immediately

Reset command (system power off, will not perform driver binding stop, from my 
debug log) : we can rebuilt the iSCSI connection if the target is deployed on 
Debain OS, but failed on windows server, this is the target server behavior. 
Since we do not send the reset packet on my platform, so the windows target 
server think our session is still exist and reject the new session request.

Reconnect -r:  this command will execute the iSCSI driver binding stop function 
and reset the TCP connection actively. But we cannot capture the reset packet 
either.  I debugged and find that before we reset the socket in 
IScsiSessionAbort, the socket configured state has already been set as 
unconfigured in tcp driver binding stop , so we will not invoke the TCP 
dispatch to abort the connection by sending a reset packet.

This is a Tcp service binding  destroy child issue, I will send a patch to fix.


Best regards
Lubo

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting
Sent: Tuesday, February 28, 2017 4:53 PM
To: Santhapur Naveen <nave...@amiindia.co.in>; edk2-devel@lists.01.org
Subject: Re: [edk2] ISCSI says "Session Doesn't Exist"

Hi Naveen,

Thanks for your info. We are able to reproduce the issue using Windows Server 
2012 now. So far we are still not sure whether it is a particular issue in 
Windows iSCSI target or UEFI iSCSI initiator.

Will update to you once we have further information later.

For your info: A link describes the know issues in Windows Server 2012 iSCSI 
target, https://technet.microsoft.com/en-us/library/jj863561(v=ws.11).aspx. It 
has a related issue but not the same one we met now.

Standard Login Key Negotiation
RFC 3720, section 10.13.3, specifies the following:
For a new session, the target MUST generate a non-zero TSIH and ONLY return it 
in the Login Final-Response.
The behavior exhibited by ISCSI Target Server:
When the iSCSI initiator performed a standard login and negotiated the login 
parameters, the iSCSI Target Server was observed to set the TSIH field in the 
first Login Response PDU.

Thanks,
Ting


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, February 28, 2017 4:04 AM
To: Ye, Ting <ting...@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] ISCSI says "Session Doesn't Exist"

Hello Ting,

I've configured iSCSI target in Windows Server 2012. And the procedure is 
similar as in 
https://blogs.technet.microsoft.com/filecab/2012/05/21/introduction-of-iscsi-target-in-windows-server-2012/
Please let me know if I had to make any changes to my iSCSI server.

Thank you,
Naveen

From: Ye, Ting [ting...@intel.com]
Sent: Monday, February 27, 2017 1:23 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: ISCSI says "Session Doesn't Exist"

Hi Naveen,

According to the table you shared (defined in RFC 3720), it seems when TSIH is 
ZERO, the target should not fail the login with "session does not exist".

   +--+
   |new   | zero| any| instantiate a new session  |
   +--+
   |existing  | zero| any| do session reinstatement   |
   |  | || (see section 5.3.5)|
   +--+

I checked the latest code in NetworkPkg/IScsiDxe, the Tsih is always set to 
ZERO in IScsiSessionInit. The immediate reset will also trigger driver binding 
start so IScsiSessionInit will be executed.

It seems to me your iSCSI target does not comply with the rules defined in RFC 
documentation. If possible, would you please tell us which iSCSI target are you 
using?

Thanks,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Friday, February 24, 2017 9:59 PM
To: edk2-devel@lists.01.org
Subject: [edk2] ISCSI says "Session Doesn't Exist"

Hello all,

I've a question about IScsi and any suggestions would be helpful

[Issue Summary]
If I add an ISCSI attempt and on the next reboot, a connection will be 
establ

[edk2] UNDI initialize

[Santhapur Naveen]

Hello all,

I've been facing the following error with one of my LAN cards.

Snp->undi.initialize() C001h:6h
Snp->undi.initialize() 8000h:Ah

Also the following.

Snp->Cdb.StatFlags= C001h/8000h
Snp->Cdb.StatCode = 6h/Ah

Is this something that had to do with the UNDI driver?

Your suggestions are highly appreciated.

Regards,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] ISCSI says "Session Doesn't Exist"

[Santhapur Naveen]

Hello Ting,

I've configured iSCSI target in Windows Server 2012. And the procedure is 
similar as in 
https://blogs.technet.microsoft.com/filecab/2012/05/21/introduction-of-iscsi-target-in-windows-server-2012/
Please let me know if I had to make any changes to my iSCSI server.

Thank you,
Naveen

From: Ye, Ting [ting...@intel.com]
Sent: Monday, February 27, 2017 1:23 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: ISCSI says "Session Doesn't Exist"

Hi Naveen,

According to the table you shared (defined in RFC 3720), it seems when TSIH is 
ZERO, the target should not fail the login with "session does not exist".

   +--+
   |new   | zero| any| instantiate a new session  |
   +--+
   |existing  | zero| any| do session reinstatement   |
   |  | || (see section 5.3.5)|
   +--+

I checked the latest code in NetworkPkg/IScsiDxe, the Tsih is always set to 
ZERO in IScsiSessionInit. The immediate reset will also trigger driver binding 
start so IScsiSessionInit will be executed.

It seems to me your iSCSI target does not comply with the rules defined in RFC 
documentation. If possible, would you please tell us which iSCSI target are you 
using?

Thanks,
Ting

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Friday, February 24, 2017 9:59 PM
To: edk2-devel@lists.01.org
Subject: [edk2] ISCSI says "Session Doesn't Exist"

Hello all,

I've a question about IScsi and any suggestions would be helpful

[Issue Summary]
If I add an ISCSI attempt and on the next reboot, a connection will be 
established in between the initiator and the target. Till now, it is fine. Now 
if I do an immediate reset with in 20 seconds, on the next boot, the initiator 
is trying to establish a session, but the target rejects saying "Session does 
not exist". If I reset after 20 seconds or so, the connection would have been 
established with the same login details.

To dive deeper, I've checked the RFC documentation on this and found the 
following information. But when I checked the wireshark capture, I found my 
TSIH is ZERO even for the immediate session. If I want to make my immediate 
session also into a successful one, what should I be doing? I'm aware that 
there's a function available IScsiSessionAbort(). Would it help me or provide 
your suggestions to get me going.


   +--+

   |ISID  | TSIH| CID| Target action  |

   +--+

   |new   | non-zero| any| fail the login |

   |  | || ("session does not exist") |

   +--+

   |new   | zero| any| instantiate a new session  |

   +--+

   |existing  | zero| any| do session reinstatement   |

   |  | || (see section 5.3.5)|

   +--+

   |existing  | non-zero| new| add a new connection to|

   |  | existing|| the session|

   +--+

   |existing  | non-zero|existing| do connection reinstatement|

   |  | existing||(see section 5.3.4) |

   +--+

   |existing  | non-zero| any| fail the login |

   |  | new || ("session does not exist") |

   +--+


Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] ISCSI says "Session Doesn't Exist"

[Santhapur Naveen]

Hello all,

I've a question about IScsi and any suggestions would be helpful

[Issue Summary]
If I add an ISCSI attempt and on the next reboot, a connection will be 
established in between the initiator and the target. Till now, it is fine. Now 
if I do an immediate reset with in 20 seconds, on the next boot, the initiator 
is trying to establish a session, but the target rejects saying "Session does 
not exist". If I reset after 20 seconds or so, the connection would have been 
established with the same login details.

To dive deeper, I've checked the RFC documentation on this and found the 
following information. But when I checked the wireshark capture, I found my 
TSIH is ZERO even for the immediate session. If I want to make my immediate 
session also into a successful one, what should I be doing? I'm aware that 
there's a function available IScsiSessionAbort(). Would it help me or provide 
your suggestions to get me going.


   +--+

   |ISID  | TSIH| CID| Target action  |

   +--+

   |new   | non-zero| any| fail the login |

   |  | || ("session does not exist") |

   +--+

   |new   | zero| any| instantiate a new session  |

   +--+

   |existing  | zero| any| do session reinstatement   |

   |  | || (see section 5.3.5)|

   +--+

   |existing  | non-zero| new| add a new connection to|

   |  | existing|| the session|

   +--+

   |existing  | non-zero|existing| do connection reinstatement|

   |  | existing||(see section 5.3.4) |

   +--+

   |existing  | non-zero| any| fail the login |

   |  | new || ("session does not exist") |

   +--+


Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

[Santhapur Naveen]

Hello Fu Siyuan,

   Thanks for the update.
I had reported a bug in the Bugzilla site. Please use the link 
https://bugzilla.tianocore.org/show_bug.cgi?id=155 to view the details.
   Please let me know if any other details are needed.

Thank you,
Naveen

From: Fu, Siyuan [mailto:siyuan...@intel.com]
Sent: Tuesday, October 18, 2016 8:16 AM
To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
Cc: Ye, Ting; Li, Ruth
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Hi, Naveen

I checked the code and found the IP4 stack is actually doesn't support 
classless IP address now, the main reason is in the NetLib interface 
NetGetIpClass() and NetIp4IsUnicast(). These 2 interfaces do not consider the 
netmask so it won't recognize a classless IP configuration. Almost all other 
network drivers (IP4, ARP, iSCSI, Mtftp, PXE, TCP, UDP) are using these 2 
interfaces so I guess they may have the same problem.
Please help to submit a ticket in tianocore Bugzilla for this issue, thanks.


BestRegards
Fu Siyuan

From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Friday, October 14, 2016 3:19 PM
To: Wu, Jiaxin <jiaxin...@intel.com<mailto:jiaxin...@intel.com>>; 
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Ye, Ting <ting...@intel.com<mailto:ting...@intel.com>>; Fu, Siyuan 
<siyuan...@intel.com<mailto:siyuan...@intel.com>>
Subject: Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Hello Jiaxin,

  We've run into one more problem with PXE boot. The PXE boot is not happening 
when the server tries to assign an IP address whose last octet is zero.

The below is my configuration:

[Server Configuration]
Ipv4 address : 192.168.0.1/16
Netmask: 255.255.0.0

DHCPv4 Scope:
Range: 192.168.0.2 to 192.168.10.10
Netmask: 255.255.0.0

  I've observed that in the given address range, if the server tries to 
allocate any IP address with the last octet as 0 i.e., for instance 192.168.A.0 
where A vary from 1 to 10, then the PXE boot fails saying "PXE-E09: Could not 
allocate I/O buffers."

  I agree that the x.y.z.0 and x.y.z.255 are network address any can't be 
assigned based on the subnet (In this case, 192.168.0.0 and 192.168.255.255). 
But here, the Netmask is different which expects the IP address x.y.a.0 which 
is within the range is valid and can be assigned to any client in the network.

  I captured Wireshark log and as per it, the D.O.R.A process is finished but 
the client is sending a Decline packet. I suspect the function 
NetIp4IsUnicast() has a role to play in this.

  Please provide your comments on this.

Best regards,
Naveen

-Original Message-
From: Santhapur Naveen
Sent: Friday, September 02, 2016 11:46 AM
To: 'Wu, Jiaxin'; 'edk2-devel@lists.01.org'
Cc: 'Ye, Ting'; 'Fu, Siyuan'
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Hello Jiaxin,

  My sincere apologies for the delayed response.

  I've verified the patch from my side and PXE boot is happening successfully 
even in classless IP network.

  May I know whether this will be included in EDK2? If yes, can you please 
provide any schedule for the same?

Best regards,
Naveen

-Original Message-
From: Santhapur Naveen
Sent: Thursday, August 18, 2016 11:14 AM
To: 'Wu, Jiaxin'; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Jiaxin,

We will verify the patch and update you the result.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Thursday, August 18, 2016 11:12 AM
To: Santhapur Naveen; Wu, Jiaxin; 
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Naveen,

Can you help to verify this patch to support the classless IP.

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Thursday, August 18, 2016 1:39 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Ye, Ting <ting...@intel.com<mailto:ting...@intel.com>>; Fu, Siyuan 
> <siyuan...@intel.com<mailto:siyuan...@intel.com>>;
> Santhapur Naveen <nave...@amiindia.co.in<mailto:nave...@amiindia.co.in>>
> Subject: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4
> TransmitReceive()
>
> The IP address should not be treated as classful one if DHCP options
> contain a classless IP with its true subnet mask. Otherwise, DHCPv4
> TransmitReceive() will failed. This real subnet m

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

[Santhapur Naveen]

Hello Jiaxin,

We've run into one more problem with PXE boot. The PXE boot is not 
happening when the server tries to assign an IP address whose last octet is 
zero.

The below is my configuration:

[Server Configuration]
Ipv4 address : 192.168.0.1/16
Netmask: 255.255.0.0

DHCPv4 Scope:
Range: 192.168.0.2 to 192.168.10.10
Netmask: 255.255.0.0

I've observed that in the given address range, if the server tries to 
allocate any IP address with the last octet as 0 i.e., for instance 192.168.A.0 
where A vary from 1 to 10, then the PXE boot fails saying "PXE-E09: Could not 
allocate I/O buffers." 

I agree that the x.y.z.0 and x.y.z.255 are network address any can't be 
assigned based on the subnet (In this case, 192.168.0.0 and 192.168.255.255). 
But here, the Netmask is different which expects the IP address x.y.a.0 which 
is within the range is valid and can be assigned to any client in the network.

I captured Wireshark log and as per it, the D.O.R.A process is finished 
but the client is sending a Decline packet. I suspect the function 
NetIp4IsUnicast() has a role to play in this.

Please provide your comments on this.

Best regards,
Naveen

-Original Message-----
From: Santhapur Naveen 
Sent: Friday, September 02, 2016 11:46 AM
To: 'Wu, Jiaxin'; 'edk2-devel@lists.01.org'
Cc: 'Ye, Ting'; 'Fu, Siyuan'
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Hello Jiaxin,

My sincere apologies for the delayed response.

I've verified the patch from my side and PXE boot is happening 
successfully even in classless IP network.

May I know whether this will be included in EDK2? If yes, can you 
please provide any schedule for the same?

Best regards,
Naveen

-Original Message-----
From: Santhapur Naveen
Sent: Thursday, August 18, 2016 11:14 AM
To: 'Wu, Jiaxin'; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Jiaxin,

We will verify the patch and update you the result.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Thursday, August 18, 2016 11:12 AM
To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Naveen,

Can you help to verify this patch to support the classless IP.

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Jiaxin Wu
> Sent: Thursday, August 18, 2016 1:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; 
> Santhapur Naveen <nave...@amiindia.co.in>
> Subject: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4
> TransmitReceive()
> 
> The IP address should not be treated as classful one if DHCP options 
> contain a classless IP with its true subnet mask. Otherwise, DHCPv4
> TransmitReceive() will failed. This real subnet mask will be parsed 
> and recorded in DhcpSb->Netmask. So, we need check it before get the 
> IP's corresponding subnet mask.
> 
> Cc: Santhapur Naveen <nave...@amiindia.co.in>
> Cc: Ye Ting <ting...@intel.com>
> Cc: Fu Siyuan <siyuan...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
> ---
>  .../Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 28 +++-
> --
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> index 4f491b4..79f7cde 100644
> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> @@ -1,9 +1,9 @@
>  /** @file
>This file implement the EFI_DHCP4_PROTOCOL interface.
> 
> -Copyright (c) 2006 - 2015, Intel Corporation. All rights 
> reserved.
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights 
> +reserved.
>  This program and the accompanying materials  are licensed and made 
> available under the terms and conditions of the BSD License  which 
> accompanies this distribution.  The full text of the license may be 
> found at http://opensource.org/licenses/bsd-license.php
> 
> @@ -1186,18 +1186,20 @@ Dhcp4InstanceConfigUdpIo (
>IN UDP_IO   *UdpIo,
>IN VOID *Context
>)
>  {
>DHCP_PROTOCOL *Instance;
> +  DHCP_SERVICE  *DhcpSb;
>EFI_DHCP4_TRANSMIT_RECEIVE_TOKEN  *Token;
>EFI_UDP4_CONFIG_DATA  UdpConfi

Re: [edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hi Jiaxin,

Thank you very much for the information you have provided. I shall try 
and update you. Thank you once again.

Best Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Friday, September 30, 2016 10:56 AM
To: Santhapur Naveen; Palmer, Thomas; Samer El Haj Mahmoud; 
edk2-devel@lists.01.org
Cc: Fu, Siyuan; Ye, Ting; Li, Ruth
Subject: RE: Issues with HTTPS Boot

Hi Naveen,

I have tried the openssl-1.0.2h and openssl-1.0.2j (the latest edk2-master 
version), both of them work well with the UEFI HTTPS in staging branch. I 
haven't met you issue:(. Now, I have synced the patches from EDK2 
master(https://github.com/tianocore/edk2 ) to HTTPS-TLS branch 
(https://github.com/tianocore/edk2-staging/tree/HTTPS-TLS ). That means current 
HTTPS in branch is developed based on openssl-1.0.2j.   

I noticed you're not using the latest code from the edk2-staging branch because 
your code base seems not support TLS version negotiation feature. Can you retry 
the latest code in current HTTPS-TLS branch? 

In order to eliminate the HTTPS server configuration issue, you can using IE or 
Chrome or any other HTTPS client (Note: don't forget to enroll the server CA 
cert) to verify the HTTPS server's functionality first. That also can help you 
to verify your self-signed certificates:). If you are using IIS8 HTTPS server, 
please also aware the README notes.
 

Thanks,
Jiaxin

> -Original Message-
> From: Wu, Jiaxin
> Sent: Monday, September 26, 2016 9:46 AM
> To: Santhapur Naveen <nave...@amiindia.co.in>; Palmer, Thomas 
> <thomas.pal...@hpe.com>; Samer El Haj Mahmoud <smahm...@lenovo.com>; 
> edk2-devel@lists.01.org
> Subject: RE: Issues with HTTPS Boot
> 
> Naveen,
> 
> The version in edk2-staging is openssl-1.0.2g, I can't reproduce the 
> failure case in the latest branch. From the limited debug information, 
> I'm not sure whether it's the compatibility issue with openssl-1.0.2h. 
> It is also possible that your server configuration is incorrect. 
> Anyway, I will try openssl-1.0.2h. But before that, please make sure 
> all the HTTPS related patches has been synced to your platform (From 
> edk2-staging version:
> 891dde7da95bdc5deb11f9262b3bc6fde4e678ef).
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> > Sent: Friday, September 23, 2016 3:01 PM
> > To: Wu, Jiaxin <jiaxin...@intel.com>; Palmer, Thomas 
> > <thomas.pal...@hpe.com>; Samer El Haj Mahmoud
> <smahm...@lenovo.com>;
> > edk2-devel@lists.01.org
> > Subject: RE: Issues with HTTPS Boot
> >
> > Hi Jiaxin,
> >
> > The openssl version I have been using is 1.0.2h and the cipher 
> > returned by the Sever Hello is "TLS_RSA_WITH_AES_128_CBC_SHA (0x002f)".
> >
> > Thanks,
> > Naveen
> >
> > -Original Message-
> > From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> > Sent: Friday, September 23, 2016 12:25 PM
> > To: Palmer, Thomas; Samer El Haj Mahmoud; Santhapur Naveen; edk2- 
> > de...@lists.01.org
> > Subject: RE: Issues with HTTPS Boot
> >
> > Naveen,
> >
> > For error code L14:F171:R105, it seems not failed in the
> ssl3_get_server_hello().
> > L14 means SLL lib error, R105 means SSL_R_WRONG_CIPHER_RETURNED,
> but
> > for F171, I can't find the corresponding error function represented.
> > Can you tell us the openssl version your platform used? and what's 
> > the cipher returned from server hello?
> >
> >
> > Thanks,
> > Jiaxin
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On 
> > > Behalf Of Palmer, Thomas
> > > Sent: Friday, September 23, 2016 2:10 AM
> > > To: Samer El Haj Mahmoud <smahm...@lenovo.com>; Santhapur Naveen 
> > > <nave...@amiindia.co.in>; edk2-devel@lists.01.org
> > > Subject: Re: [edk2] Issues with HTTPS Boot
> > >
> > >
> > > Naveen,
> > >
> > > I may be interpreting this OpenSSL error code incorrectly, so if 
> > > anyone has experience with this please chime in ...
> > >
> > > Looking at 1.02.h,  the 0x105 reason corresponds with 
> > > SSL_R_WRONG_CIPHER_RETURNED.  This happens in two places in
> s3_clnt.c.
> > > This would indicate that the TLS server is wanting to use a cipher 
> > > that the TLS client does not want to use.
> > >
> > > 0x105 can also correspond to SSL_F_DTLS1_SEND_CLIENT_CERTIFICATE ...
> > > but we don't support client certificates or DTLS at this point so 
> > > I would not expect this to 

[edk2] ifconfig command behavior when different subnet is given

[Santhapur Naveen]

Hello,

  I would like to have a clarification on one thing. From Shell if we 
try to assign a static IP for example, "ifconfig -s eth0 static 10.0.93.45 
255.255.255.244 10.0.0.14" What would be the behavior? In fact, when I tried, 
it was crashing inside the function Ip4AddRoute() at this line if 
(IP4_NET_EQUAL (RtEntry->Dest, Dest, Netmask) && (RtEntry->NextHop == Gateway)) 
and I happen to find the value of RtEntry is garbage.

  Would anyone please answer is this an expected behavior?

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hi,
I've downloaded the source from edk2-staging a couple weeks ago and 
have been using the same source since then.

Thanks,
Naveen

-Original Message-
From: Samer El Haj Mahmoud [mailto:smahm...@lenovo.com] 
Sent: Thursday, September 22, 2016 8:42 PM
To: Santhapur Naveen; Palmer, Thomas; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Naveen,

Are you using the latest code form the edk2-staging branch?


-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Thursday, September 22, 2016 7:07 AM
To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] Issues with HTTPS Boot

Hi Thomas,

Regarding your previous question about the server certificates, please 
find my response as below:

Do you have the appropriate certificate installed in UEFI for the target TLS 
server?
Yes, I do have the appropriate certificate installed on my server. I 
have followed the section 2.2 titles " Self-Generated Certificate" in the white 
paper to generate the certificates.

I have debugged a bit  further and went inside TlsConnectSession() to 
see where exactly it is failing and I found out like it fails in 
TlsDoHandshake() and gives PROTOCOL ERROR. To be precise, it gives error as 
"TlsDoHandshake ERROR 0x14171105=L14:F171:R105".

If I'm missing anything anywhere, would you please provide your 
comments.

Thank you,
Naveen

-Original Message-
From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] 
Sent: Thursday, September 22, 2016 12:56 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot


>From what you describe, it sounds like they should not have an issue 
>negotiating TLS version and cipher.


Do you have the appropriate certificate installed in UEFI for the target TLS 
server?   Either we need the 3rd part CA that signed the web server 
certificate, or you could install the self-signed certificate of the web server.

Also, are you able to see the any DEBUG statements from TlsLib.c?


Regards,

Thomas Palmer

"I have only made this letter longer because I have not had the time to make it 
shorter" - Blaise Pascal

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Wednesday, September 21, 2016 8:09 AM
To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Hi Thomas,

Regarding my previous mail, after TCP handshake, Client Says Hello to 
sever and the Server replies its Hello to the client with TLSv1.
 
Client says hello with the following Cipher Suites:

1. TLS_DHE_RSA_WITH_AES_256_CBC_SHA (0x0039) 2. 
TLS_DHE_RSA_WITH_AES_128_CBC_SHA (0x0033) 3. TLS_RSA_WITH_AES_256_CBC_SHA 
(0x0035) 4. TLS_RSA_WITH_AES_128_CBC_SHA (0x002f) 5. 
TLS_EMPTY_RENEGOTIATION_INFO_SCSV (0x00ff)

For the Client Hello, Server responds with its Hello and chooses 
TLS_RSA_WITH_AES_128_CBC_SHA (0x002f) using TLSv1. The client sends an 
acknowledgement to the server and then immediately sends RST. 

After some debugging, it was found that it fails in 
TlsConnectSession(). Would you please provide your comments on this?


Thanks,
Naveen

-Original Message-
From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
Sent: Tuesday, September 20, 2016 9:30 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Naveen,

I cannot see attachments on this email. 

What TLS versions and ciphers does your web server support? Depending 
on when you built the UEFI image, your server may need to have TLS v1.0 enabled 
and support one of the non-SHA256 ciphers listed at the top of TlsLib.c.   


Regards,

Thomas Palmer

"I have only made this letter longer because I have not had the time to make it 
shorter" - Blaise Pascal

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, September 20, 2016 6:42 AM
To: edk2-devel@lists.01.org
Subject: [edk2] Issues with HTTPS Boot

Hello All,

  Since the HTTPS Boot came into picture, I was very enthusiastic to 
try it. I configured the server as-is explained in the white paper 
https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers

  But when I try to go for an HTTPS boot, it stops after the TCP 
handshake. Attached is the Wireshark log. Please help me out and also let me 
know if any other details are needed.

Thank you,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing

Re: [edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hi Jiaxin,

The openssl version I have been using is 1.0.2h and the cipher returned 
by the Sever Hello is "TLS_RSA_WITH_AES_128_CBC_SHA (0x002f)".

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Friday, September 23, 2016 12:25 PM
To: Palmer, Thomas; Samer El Haj Mahmoud; Santhapur Naveen; 
edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Naveen,

For error code L14:F171:R105, it seems not failed in the 
ssl3_get_server_hello(). L14 means SLL lib error, R105 means 
SSL_R_WRONG_CIPHER_RETURNED, but for F171, I can't find the corresponding error 
function represented. Can you tell us the openssl version your platform used? 
and what's the cipher returned from server hello? 


Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Palmer, Thomas
> Sent: Friday, September 23, 2016 2:10 AM
> To: Samer El Haj Mahmoud <smahm...@lenovo.com>; Santhapur Naveen 
> <nave...@amiindia.co.in>; edk2-devel@lists.01.org
> Subject: Re: [edk2] Issues with HTTPS Boot
> 
> 
> Naveen,
> 
> I may be interpreting this OpenSSL error code incorrectly, so if 
> anyone has experience with this please chime in ...
> 
> Looking at 1.02.h,  the 0x105 reason corresponds with 
> SSL_R_WRONG_CIPHER_RETURNED.  This happens in two places in s3_clnt.c.
> This would indicate that the TLS server is wanting to use a cipher 
> that the TLS client does not want to use.
> 
> 0x105 can also correspond to SSL_F_DTLS1_SEND_CLIENT_CERTIFICATE ... 
> but we don't support client certificates or DTLS at this point so I 
> would not expect this to be in play.  (unless your server is 
> configured for that ...)
> 
> We should confirm this error code interpretation.  If you have a 
> debugger, set a break point for each instance of 
> SSL_R_WRONG_CIPHER_RETURNED, or add a print statement.  Which openssl version 
> are you using?
> 
> 
> Regards,
> 
> Thomas Palmer
> 
> "I have only made this letter longer because I have not had the time 
> to make it shorter" - Blaise Pascal
> 
> 
> -Original Message-
> From: Samer El Haj Mahmoud [mailto:smahm...@lenovo.com]
> Sent: Thursday, September 22, 2016 10:12 AM
> To: Santhapur Naveen <nave...@amiindia.co.in>; Palmer, Thomas 
> <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
> Subject: RE: Issues with HTTPS Boot
> 
> Naveen,
> 
> Are you using the latest code form the edk2-staging branch?
> 
> 
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Santhapur Naveen
> Sent: Thursday, September 22, 2016 7:07 AM
> To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] Issues with HTTPS Boot
> 
> Hi Thomas,
> 
>   Regarding your previous question about the server certificates, 
> please find my response as below:
> 
> Do you have the appropriate certificate installed in UEFI for the 
> target TLS server?
>   Yes, I do have the appropriate certificate installed on my server. I 
> have followed the section 2.2 titles " Self-Generated Certificate" in 
> the white paper to generate the certificates.
> 
>   I have debugged a bit  further and went inside TlsConnectSession() to 
> see where exactly it is failing and I found out like it fails in 
> TlsDoHandshake() and gives PROTOCOL ERROR. To be precise, it gives 
> error as "TlsDoHandshake ERROR 0x14171105=L14:F171:R105".
> 
>   If I'm missing anything anywhere, would you please provide your 
> comments.
> 
> Thank you,
> Naveen
> 
> -Original Message-
> From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
> Sent: Thursday, September 22, 2016 12:56 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Subject: RE: Issues with HTTPS Boot
> 
> 
> From what you describe, it sounds like they should not have an issue 
> negotiating TLS version and cipher.
> 
> 
> Do you have the appropriate certificate installed in UEFI for the target TLS
> server?   Either we need the 3rd part CA that signed the web server 
> certificate,
> or you could install the self-signed certificate of the web server.
> 
> Also, are you able to see the any DEBUG statements from TlsLib.c?
> 
> 
> Regards,
> 
> Thomas Palmer
> 
> "I have only made this letter longer because I have not had the time 
> to make it shorter" - Blaise Pascal
> 
> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Wednesday, September 21, 2016 8:09 AM
> To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
> Subject: RE: Is

Re: [edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hi Thomas,

Regarding your previous question about the server certificates, please 
find my response as below:

Do you have the appropriate certificate installed in UEFI for the target TLS 
server?
Yes, I do have the appropriate certificate installed on my server. I 
have followed the section 2.2 titles " Self-Generated Certificate" in the white 
paper to generate the certificates.

I have debugged a bit  further and went inside TlsConnectSession() to 
see where exactly it is failing and I found out like it fails in 
TlsDoHandshake() and gives PROTOCOL ERROR. To be precise, it gives error as 
"TlsDoHandshake ERROR 0x14171105=L14:F171:R105".

If I'm missing anything anywhere, would you please provide your 
comments.

Thank you,
Naveen

-Original Message-
From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] 
Sent: Thursday, September 22, 2016 12:56 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot


>From what you describe, it sounds like they should not have an issue 
>negotiating TLS version and cipher.


Do you have the appropriate certificate installed in UEFI for the target TLS 
server?   Either we need the 3rd part CA that signed the web server 
certificate, or you could install the self-signed certificate of the web server.

Also, are you able to see the any DEBUG statements from TlsLib.c?


Regards,

Thomas Palmer

"I have only made this letter longer because I have not had the time to make it 
shorter" - Blaise Pascal

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Wednesday, September 21, 2016 8:09 AM
To: Palmer, Thomas <thomas.pal...@hpe.com>; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Hi Thomas,

Regarding my previous mail, after TCP handshake, Client Says Hello to 
sever and the Server replies its Hello to the client with TLSv1.
 
Client says hello with the following Cipher Suites:

1. TLS_DHE_RSA_WITH_AES_256_CBC_SHA (0x0039) 2. 
TLS_DHE_RSA_WITH_AES_128_CBC_SHA (0x0033) 3. TLS_RSA_WITH_AES_256_CBC_SHA 
(0x0035) 4. TLS_RSA_WITH_AES_128_CBC_SHA (0x002f) 5. 
TLS_EMPTY_RENEGOTIATION_INFO_SCSV (0x00ff)

For the Client Hello, Server responds with its Hello and chooses 
TLS_RSA_WITH_AES_128_CBC_SHA (0x002f) using TLSv1. The client sends an 
acknowledgement to the server and then immediately sends RST. 

After some debugging, it was found that it fails in 
TlsConnectSession(). Would you please provide your comments on this?


Thanks,
Naveen

-Original Message-
From: Palmer, Thomas [mailto:thomas.pal...@hpe.com]
Sent: Tuesday, September 20, 2016 9:30 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Naveen,

I cannot see attachments on this email. 

What TLS versions and ciphers does your web server support? Depending 
on when you built the UEFI image, your server may need to have TLS v1.0 enabled 
and support one of the non-SHA256 ciphers listed at the top of TlsLib.c.   


Regards,

Thomas Palmer

"I have only made this letter longer because I have not had the time to make it 
shorter" - Blaise Pascal

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, September 20, 2016 6:42 AM
To: edk2-devel@lists.01.org
Subject: [edk2] Issues with HTTPS Boot

Hello All,

  Since the HTTPS Boot came into picture, I was very enthusiastic to 
try it. I configured the server as-is explained in the white paper 
https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers

  But when I try to go for an HTTPS boot, it stops after the TCP 
handshake. Attached is the Wireshark log. Please help me out and also let me 
know if any other details are needed.

Thank you,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hi Thomas,

Regarding my previous mail, after TCP handshake, Client Says Hello to 
sever and the Server replies its Hello to the client with TLSv1.
 
Client says hello with the following Cipher Suites:

1. TLS_DHE_RSA_WITH_AES_256_CBC_SHA (0x0039)
2. TLS_DHE_RSA_WITH_AES_128_CBC_SHA (0x0033)
3. TLS_RSA_WITH_AES_256_CBC_SHA (0x0035)
4. TLS_RSA_WITH_AES_128_CBC_SHA (0x002f)
5. TLS_EMPTY_RENEGOTIATION_INFO_SCSV (0x00ff)

For the Client Hello, Server responds with its Hello and chooses 
TLS_RSA_WITH_AES_128_CBC_SHA (0x002f) using TLSv1. The client sends an 
acknowledgement to the server and then immediately sends RST. 

After some debugging, it was found that it fails in 
TlsConnectSession(). Would you please provide your comments on this?


Thanks,
Naveen

-Original Message-
From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] 
Sent: Tuesday, September 20, 2016 9:30 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Subject: RE: Issues with HTTPS Boot

Naveen,

I cannot see attachments on this email. 

What TLS versions and ciphers does your web server support? Depending 
on when you built the UEFI image, your server may need to have TLS v1.0 enabled 
and support one of the non-SHA256 ciphers listed at the top of TlsLib.c.   


Regards,

Thomas Palmer

"I have only made this letter longer because I have not had the time to make it 
shorter" - Blaise Pascal

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Tuesday, September 20, 2016 6:42 AM
To: edk2-devel@lists.01.org
Subject: [edk2] Issues with HTTPS Boot

Hello All,

  Since the HTTPS Boot came into picture, I was very enthusiastic to 
try it. I configured the server as-is explained in the white paper 
https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers

  But when I try to go for an HTTPS boot, it stops after the TCP 
handshake. Attached is the Wireshark log. Please help me out and also let me 
know if any other details are needed.

Thank you,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Issues with HTTPS Boot

[Santhapur Naveen]

Hello All,

  Since the HTTPS Boot came into picture, I was very enthusiastic to 
try it. I configured the server as-is explained in the white paper 
https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers

  But when I try to go for an HTTPS boot, it stops after the TCP 
handshake. Attached is the Wireshark log. Please help me out and also let me 
know if any other details are needed.

Thank you,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] UEFI BitlockerUnlock failed with DHCPv4 only case.

[Santhapur Naveen]

Hello All,

  I have been facing a problem i.e., Network Unlock is failing when 
tried with DHCP4 only by disabling TCP/IPv6. My server configuration is as 
below:


1.WDS Server details
I.P: 10.10.10.11
Net Mask: 255.255.255.0

2.DHCP Server details
IP: 10.10.10.2
Scope: 10.10.10.10 - 10.10.10.200

  After some debugging it was found that the changes in the file 
MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c is the reason. If I use the 
old file, it works fine.

Microsoft Network Unlock link(reference): 
https://technet.microsoft.com/en-us/library/jj574173(v=ws.11).aspx


Note: WDS and DHCP are configure on two different machines. When I tested with 
DHCPv6 only by disabling TCP/IPv4 on WDS server, I was able to login 
successfully.

  I've attached the working and non-working source. Please help me to 
resolve this with latest ekd2 source.


Thank you,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

[Santhapur Naveen]

Hello Jiaxin,

Thank you very much for your timely help and support.

Regards,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Tuesday, September 06, 2016 4:35 PM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Hi Naveen,

The patch has been committed:

SHA-1: 8c5f78a2cc15199e3f77ae4b156023af366fd6c7
* MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

Thanks,
Jiaxin

> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Friday, September 2, 2016 2:16 PM
> To: Wu, Jiaxin <jiaxin...@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>
> Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for 
> DHCPv4
> TransmitReceive()
> 
> Hello Jiaxin,
> 
>   My sincere apologies for the delayed response.
> 
>   I've verified the patch from my side and PXE boot is happening 
> successfully even in classless IP network.
> 
>   May I know whether this will be included in EDK2? If yes, can you 
> please provide any schedule for the same?
> 
> Best regards,
> Naveen
> 
> -Original Message-
> From: Santhapur Naveen
> Sent: Thursday, August 18, 2016 11:14 AM
> To: 'Wu, Jiaxin'; edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
> Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for 
> DHCPv4
> TransmitReceive()
> 
> Jiaxin,
> 
> We will verify the patch and update you the result.
> 
> Thanks,
> Naveen
> 
> -Original Message-
> From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
> Sent: Thursday, August 18, 2016 11:12 AM
> To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
> Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for 
> DHCPv4
> TransmitReceive()
> 
> Naveen,
> 
> Can you help to verify this patch to support the classless IP.
> 
> Thanks,
> Jiaxin
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf 
> > Of Jiaxin Wu
> > Sent: Thursday, August 18, 2016 1:39 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; 
> > Santhapur Naveen <nave...@amiindia.co.in>
> > Subject: [edk2] [Patch] MdeModulePkg: Support classless IP for 
> > DHCPv4
> > TransmitReceive()
> >
> > The IP address should not be treated as classful one if DHCP options 
> > contain a classless IP with its true subnet mask. Otherwise, DHCPv4
> > TransmitReceive() will failed. This real subnet mask will be parsed 
> > and recorded in DhcpSb->Netmask. So, we need check it before get the 
> > IP's corresponding subnet mask.
> >
> > Cc: Santhapur Naveen <nave...@amiindia.co.in>
> > Cc: Ye Ting <ting...@intel.com>
> > Cc: Fu Siyuan <siyuan...@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
> > ---
> >  .../Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 28
> +++-
> > --
> >  1 file changed, 20 insertions(+), 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> > b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> > index 4f491b4..79f7cde 100644
> > --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> > +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> > @@ -1,9 +1,9 @@
> >  /** @file
> >This file implement the EFI_DHCP4_PROTOCOL interface.
> >
> > -Copyright (c) 2006 - 2015, Intel Corporation. All rights 
> > reserved.
> > +Copyright (c) 2006 - 2016, Intel Corporation. All rights 
> > +reserved.
> >  This program and the accompanying materials  are licensed and made 
> > available under the terms and conditions of the BSD License  which 
> > accompanies this distribution.  The full text of the license may be 
> > found at http://opensource.org/licenses/bsd-license.php
> >
> > @@ -1186,18 +1186,20 @@ Dhcp4InstanceConfigUdpIo (
> >IN UDP_IO   *UdpIo,
> >IN VOID *Context
> >)
> >  {
> >DHCP_PROTOCOL *Instance;
> > +  DHCP_SERVICE  *DhcpSb;
> >EFI_DHCP4_TRANSMIT_RECEIVE_TOKEN  *Token;
> >EFI_UDP4_CONFIG_DATA  UdpConfigData;
> >IP4_

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

[Santhapur Naveen]

Hello Jiaxin,

My sincere apologies for the delayed response.

I've verified the patch from my side and PXE boot is happening 
successfully even in classless IP network.

May I know whether this will be included in EDK2? If yes, can you 
please provide any schedule for the same?

Best regards,
Naveen

-Original Message-
From: Santhapur Naveen 
Sent: Thursday, August 18, 2016 11:14 AM
To: 'Wu, Jiaxin'; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Jiaxin,

We will verify the patch and update you the result.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Thursday, August 18, 2016 11:12 AM
To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Naveen,

Can you help to verify this patch to support the classless IP.

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Jiaxin Wu
> Sent: Thursday, August 18, 2016 1:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; 
> Santhapur Naveen <nave...@amiindia.co.in>
> Subject: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4
> TransmitReceive()
> 
> The IP address should not be treated as classful one if DHCP options 
> contain a classless IP with its true subnet mask. Otherwise, DHCPv4
> TransmitReceive() will failed. This real subnet mask will be parsed 
> and recorded in DhcpSb->Netmask. So, we need check it before get the 
> IP's corresponding subnet mask.
> 
> Cc: Santhapur Naveen <nave...@amiindia.co.in>
> Cc: Ye Ting <ting...@intel.com>
> Cc: Fu Siyuan <siyuan...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
> ---
>  .../Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 28 +++-
> --
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> index 4f491b4..79f7cde 100644
> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> @@ -1,9 +1,9 @@
>  /** @file
>This file implement the EFI_DHCP4_PROTOCOL interface.
> 
> -Copyright (c) 2006 - 2015, Intel Corporation. All rights 
> reserved.
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights 
> +reserved.
>  This program and the accompanying materials  are licensed and made 
> available under the terms and conditions of the BSD License  which 
> accompanies this distribution.  The full text of the license may be 
> found at http://opensource.org/licenses/bsd-license.php
> 
> @@ -1186,18 +1186,20 @@ Dhcp4InstanceConfigUdpIo (
>IN UDP_IO   *UdpIo,
>IN VOID *Context
>)
>  {
>DHCP_PROTOCOL *Instance;
> +  DHCP_SERVICE  *DhcpSb;
>EFI_DHCP4_TRANSMIT_RECEIVE_TOKEN  *Token;
>EFI_UDP4_CONFIG_DATA  UdpConfigData;
>IP4_ADDR  ClientAddr;
>IP4_ADDR  Ip;
>INTN  Class;
>IP4_ADDR  SubnetMask;
> 
>Instance = (DHCP_PROTOCOL *) Context;
> +  DhcpSb   = Instance->Service;
>Token= Instance->Token;
> 
>ZeroMem (, sizeof (EFI_UDP4_CONFIG_DATA));
> 
>UdpConfigData.AcceptBroadcast= TRUE;
> @@ -1206,14 +1208,19 @@ Dhcp4InstanceConfigUdpIo (
>UdpConfigData.DoNotFragment  = TRUE;
> 
>ClientAddr = EFI_NTOHL (Token->Packet->Dhcp4.Header.ClientAddr);
>Ip = HTONL (ClientAddr);
>CopyMem (, , sizeof 
> (EFI_IPv4_ADDRESS));
> -
> -  Class = NetGetIpClass (ClientAddr);
> -  ASSERT (Class < IP4_ADDR_CLASSE);
> -  SubnetMask = gIp4AllMasks[Class << 3];
> +
> +  if (DhcpSb->Netmask == 0) {
> +Class = NetGetIpClass (ClientAddr);
> +ASSERT (Class < IP4_ADDR_CLASSE);
> +SubnetMask = gIp4AllMasks[Class << 3];  } else {
> +SubnetMask = DhcpSb->Netmask;
> +  }
> +
>Ip = HTONL (SubnetMask);
>CopyMem (, , sizeof 
> (EFI_IPv4_ADDRESS));
> 
>if ((Token->ListenPointCount == 0) || 
> (Token->ListenPoints[0].ListenPort
> == 0)) {
>  UdpConfigData.StationPort = DHCP_CLIENT_PORT; @@ -1574,16
> +1581,21 @@ EfiDhcp4TransmitReceive (
>  EndPoint.Remote

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hi Lubo,

I've taken the source from the location you have specified and checked. 
But I still get the same failure. When I select the same HTTP boot option the 
2nd time, control goes to next boot option available. I guess the problem could 
be on my side only. I'll look into it.

Thank you very much for your time and effort.

Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, August 25, 2016 3:19 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

  Yes, the SVN version number I provide is not consistent with you. 
  The attachment is latest patch log details of the GitHub, you can make a  
contrast when you download the code. And then do some test.
  
Best Regards
Lubo
 
  

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Thursday, August 25, 2016 5:09 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

I believe the way we refer the version numbers seem different. I use 
tortoise SVN to get the details of the edk2. When I checked the revision 
numbers 22104 and 21740 for HttpBootDxe and HttpDxe drivers respectively, I 
couldn't find anything. Please refer the attachments. By any means is it 
possible for you to provide the way you refer the revision details?

However, I've downloaded the latest source from the URL you have 
provided and I'm trying to verify the same now. Will update you my result.

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, August 25, 2016 7:19 AM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
   I update the  SVN and now the revision is 22467.
   The HttpBootDxe revision is 22104,patch is - Fix IPv6 HTTPClient vendor 
class data
   The HttpDxe revision is 21740, patch is - NetworkPkg: Fix typos in 
comments.
   But I suggest you to download  the https://github.com/tianocore/edk2, it 
is latest edk2 code.

Best Regards
Lubo

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Wednesday, August 24, 2016 7:10 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Can you please provide me any reference revision number to download and 
check the same?

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 4:23 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
  I have checked the issue you mentioned. On my side, I updated the code to 
latest and do some test on NT32 and Denlow platform, both the first http boot 
and 2nd are successful. 
  Until now , we have fixed few bugs which may lead the 2nd http boot fail. 
As for the patch you mentioned is one case to fix the bug, So I suggest you to 
update the code firstly and at least make sure the HttpDxe , HttpBootDxe and 
DxeHttpLib are latest. 
   
 If any result, Pls let me know.

Best Regards
Lubo 
 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer 
mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg 
pointer should point a correct location.Now after the first  successful 
httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after 
the last byte, it may be a bad buffer if we don't receive another HttpHeader, 
so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot 
fail, so we need to check this case in HttpBodyParserCallback function in the 
first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zh...@intel.com>
Reviewed-by: Fu Siyuan <siyuan...@intel.com>
Reviewed-by: Ye Ting <ting...@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 
6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
S

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hi Lubo,

I believe the way we refer the version numbers seem different. I use 
tortoise SVN to get the details of the edk2. When I checked the revision 
numbers 22104 and 21740 for HttpBootDxe and HttpDxe drivers respectively, I 
couldn't find anything. Please refer the attachments. By any means is it 
possible for you to provide the way you refer the revision details?

However, I've downloaded the latest source from the URL you have 
provided and I'm trying to verify the same now. Will update you my result.

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, August 25, 2016 7:19 AM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
   I update the  SVN and now the revision is 22467.
   The HttpBootDxe revision is 22104,patch is - Fix IPv6 HTTPClient vendor 
class data
   The HttpDxe revision is 21740, patch is - NetworkPkg: Fix typos in 
comments.
   But I suggest you to download  the https://github.com/tianocore/edk2, it 
is latest edk2 code.

Best Regards
Lubo

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Wednesday, August 24, 2016 7:10 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Can you please provide me any reference revision number to download and 
check the same?

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 4:23 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
  I have checked the issue you mentioned. On my side, I updated the code to 
latest and do some test on NT32 and Denlow platform, both the first http boot 
and 2nd are successful. 
  Until now , we have fixed few bugs which may lead the 2nd http boot fail. 
As for the patch you mentioned is one case to fix the bug, So I suggest you to 
update the code firstly and at least make sure the HttpDxe , HttpBootDxe and 
DxeHttpLib are latest. 
   
 If any result, Pls let me know.

Best Regards
Lubo 
 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer 
mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg 
pointer should point a correct location.Now after the first  successful 
httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after 
the last byte, it may be a bad buffer if we don't receive another HttpHeader, 
so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot 
fail, so we need to check this case in HttpBodyParserCallback function in the 
first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zh...@intel.com>
Reviewed-by: Fu Siyuan <siyuan...@intel.com>
Reviewed-by: Ye Ting <ting...@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 
6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
 Could you list the patch name or Git SHA value which fixed the 2nd 
HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

  Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. 
So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the 
revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have 
missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https:

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hi Lubo,

I believe the way we refer the version numbers seem different. I use 
tortoise SVN to get the details of the edk2. When I checked the revision 
numbers 22104 and 21740 for HttpBootDxe and HttpDxe drivers respectively, I 
couldn't find anything. Please refer the attachment. By any means is it 
possible for you to provide the way you refer the revision details?

However, I've downloaded the latest source from the URL you have 
provided and I'm trying to verify the same now. Will update you my result.

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Thursday, August 25, 2016 7:19 AM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
   I update the  SVN and now the revision is 22467.
   The HttpBootDxe revision is 22104,patch is - Fix IPv6 HTTPClient vendor 
class data
   The HttpDxe revision is 21740, patch is - NetworkPkg: Fix typos in 
comments.
   But I suggest you to download  the https://github.com/tianocore/edk2, it 
is latest edk2 code.

Best Regards
Lubo

-Original Message-
From: Santhapur Naveen [mailto:nave...@amiindia.co.in] 
Sent: Wednesday, August 24, 2016 7:10 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Can you please provide me any reference revision number to download and 
check the same?

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 4:23 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
  I have checked the issue you mentioned. On my side, I updated the code to 
latest and do some test on NT32 and Denlow platform, both the first http boot 
and 2nd are successful. 
  Until now , we have fixed few bugs which may lead the 2nd http boot fail. 
As for the patch you mentioned is one case to fix the bug, So I suggest you to 
update the code firstly and at least make sure the HttpDxe , HttpBootDxe and 
DxeHttpLib are latest. 
   
 If any result, Pls let me know.

Best Regards
Lubo 
 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer 
mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg 
pointer should point a correct location.Now after the first  successful 
httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after 
the last byte, it may be a bad buffer if we don't receive another HttpHeader, 
so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot 
fail, so we need to check this case in HttpBodyParserCallback function in the 
first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zh...@intel.com>
Reviewed-by: Fu Siyuan <siyuan...@intel.com>
Reviewed-by: Ye Ting <ting...@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 
6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
 Could you list the patch name or Git SHA value which fixed the 2nd 
HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

  Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. 
So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the 
revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have 
missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https:

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hi Lubo,

Can you please provide me any reference revision number to download and 
check the same?

Thank you,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 4:23 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
  I have checked the issue you mentioned. On my side, I updated the code to 
latest and do some test on NT32 and Denlow platform, both the first http boot 
and 2nd are successful. 
  Until now , we have fixed few bugs which may lead the 2nd http boot fail. 
As for the patch you mentioned is one case to fix the bug, So I suggest you to 
update the code firstly and at least make sure the HttpDxe , HttpBootDxe and 
DxeHttpLib are latest. 
   
 If any result, Pls let me know.

Best Regards
Lubo 
 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zh...@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer 
mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg 
pointer should point a correct location.Now after the first  successful 
httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after 
the last byte, it may be a bad buffer if we don't receive another HttpHeader, 
so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot 
fail, so we need to check this case in HttpBodyParserCallback function in the 
first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zh...@intel.com>
Reviewed-by: Fu Siyuan <siyuan...@intel.com>
Reviewed-by: Ye Ting <ting...@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 
6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
 Could you list the patch name or Git SHA value which fixed the 2nd 
HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

  Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. 
So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the 
revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have 
missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hi Lubo,

Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer 
mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg 
pointer should point a correct location.Now after the first  successful 
httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after 
the last byte, it may be a bad buffer if we don't receive another HttpHeader, 
so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot 
fail, so we need to check this case in HttpBodyParserCallback function in the 
first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zh...@intel.com>
Reviewed-by: Fu Siyuan <siyuan...@intel.com>
Reviewed-by: Ye Ting <ting...@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin...@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 
6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-Original Message-
From: Zhang, Lubo [mailto:lubo.zh...@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
 Could you list the patch name or Git SHA value which fixed the 2nd 
HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

  Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. 
So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the 
revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have 
missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen]

Hello,

  Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. 
So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the 
revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have 
missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

[Santhapur Naveen]

Jiaxin,

We will verify the patch and update you the result.

Thanks,
Naveen

-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com] 
Sent: Thursday, August 18, 2016 11:12 AM
To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madhan B. Santharam
Subject: RE: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 
TransmitReceive()

Naveen,

Can you help to verify this patch to support the classless IP.

Thanks,
Jiaxin

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of 
> Jiaxin Wu
> Sent: Thursday, August 18, 2016 1:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; 
> Santhapur Naveen <nave...@amiindia.co.in>
> Subject: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4
> TransmitReceive()
> 
> The IP address should not be treated as classful one if DHCP options 
> contain a classless IP with its true subnet mask. Otherwise, DHCPv4
> TransmitReceive() will failed. This real subnet mask will be parsed 
> and recorded in DhcpSb->Netmask. So, we need check it before get the 
> IP's corresponding subnet mask.
> 
> Cc: Santhapur Naveen <nave...@amiindia.co.in>
> Cc: Ye Ting <ting...@intel.com>
> Cc: Fu Siyuan <siyuan...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiaxin Wu <jiaxin...@intel.com>
> ---
>  .../Universal/Network/Dhcp4Dxe/Dhcp4Impl.c | 28 +++-
> --
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> index 4f491b4..79f7cde 100644
> --- a/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> +++ b/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
> @@ -1,9 +1,9 @@
>  /** @file
>This file implement the EFI_DHCP4_PROTOCOL interface.
> 
> -Copyright (c) 2006 - 2015, Intel Corporation. All rights 
> reserved.
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights 
> +reserved.
>  This program and the accompanying materials  are licensed and made 
> available under the terms and conditions of the BSD License  which 
> accompanies this distribution.  The full text of the license may be 
> found at http://opensource.org/licenses/bsd-license.php
> 
> @@ -1186,18 +1186,20 @@ Dhcp4InstanceConfigUdpIo (
>IN UDP_IO   *UdpIo,
>IN VOID *Context
>)
>  {
>DHCP_PROTOCOL *Instance;
> +  DHCP_SERVICE  *DhcpSb;
>EFI_DHCP4_TRANSMIT_RECEIVE_TOKEN  *Token;
>EFI_UDP4_CONFIG_DATA  UdpConfigData;
>IP4_ADDR  ClientAddr;
>IP4_ADDR  Ip;
>INTN  Class;
>IP4_ADDR  SubnetMask;
> 
>Instance = (DHCP_PROTOCOL *) Context;
> +  DhcpSb   = Instance->Service;
>Token= Instance->Token;
> 
>ZeroMem (, sizeof (EFI_UDP4_CONFIG_DATA));
> 
>UdpConfigData.AcceptBroadcast= TRUE;
> @@ -1206,14 +1208,19 @@ Dhcp4InstanceConfigUdpIo (
>UdpConfigData.DoNotFragment  = TRUE;
> 
>ClientAddr = EFI_NTOHL (Token->Packet->Dhcp4.Header.ClientAddr);
>Ip = HTONL (ClientAddr);
>CopyMem (, , sizeof 
> (EFI_IPv4_ADDRESS));
> -
> -  Class = NetGetIpClass (ClientAddr);
> -  ASSERT (Class < IP4_ADDR_CLASSE);
> -  SubnetMask = gIp4AllMasks[Class << 3];
> +
> +  if (DhcpSb->Netmask == 0) {
> +Class = NetGetIpClass (ClientAddr);
> +ASSERT (Class < IP4_ADDR_CLASSE);
> +SubnetMask = gIp4AllMasks[Class << 3];  } else {
> +SubnetMask = DhcpSb->Netmask;
> +  }
> +
>Ip = HTONL (SubnetMask);
>CopyMem (, , sizeof 
> (EFI_IPv4_ADDRESS));
> 
>if ((Token->ListenPointCount == 0) || 
> (Token->ListenPoints[0].ListenPort
> == 0)) {
>  UdpConfigData.StationPort = DHCP_CLIENT_PORT; @@ -1574,16 
> +1581,21 @@ EfiDhcp4TransmitReceive (
>  EndPoint.RemotePort = DHCP_SERVER_PORT;
>} else {
>  EndPoint.RemotePort = Token->RemotePort;
>}
> 
> +  if (DhcpSb->Netmask == 0) {
> +Class = NetGetIpClass (ClientAddr);
> +ASSERT (Class < IP4_ADDR_CLASSE);
> +SubnetMask = gIp4AllMasks[Class << 3];  } else {
> +SubnetMask = DhcpSb->Netmask;
> +  }
> +
>//
>// Get the gateway.
>//
> -  Class = NetGetIpClass (ClientAddr);
> -  ASSERT (Class < IP4_ADDR_CLASSE);
> -  SubnetMask = gIp4AllMasks[Class << 3];
>ZeroMem (, sizeof (Gateway));
>if (!IP4_

Re: [edk2] Classless IP support for IPv4 PXE boot

[Santhapur Naveen]

Please find the below details and snapshot.



Revision: 21543

Author: Wu.Jiaxin

Date: Thursday, June 18, 2015 6:13:15 AM

Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA process 
dependency.

Modified: /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c



Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Wu Jiaxin <jiaxin...@intel.com>

Reviewed-by: Ye Ting <ting...@intel.com>

Reviewed-by: Fu Siyuan <siyuan...@intel.com>



Please check if the below snapshot may help.

[cid:image001.jpg@01D1F92C.D1247640]



Thanks,

Naveen



-Original Message-
From: Ye, Ting [mailto:ting...@intel.com]
Sent: Thursday, August 18, 2016 8:23 AM
To: Fu, Siyuan; Santhapur Naveen; edk2-devel@lists.01.org
Cc: Sivaraman Nainar; Madhan B. Santharam
Subject: RE: Classless IP support for IPv4 PXE boot



I searched the log messages:



Revision: 21543

Author: edk2buildsystem

Date: Friday, July 01, 2016 5:05:51 AM

Message:

MdeModulePkg VariableInfo: Fix GCC build failure



GCC build failure: 'RealCommSize' may be used uninitialized



Cc: Jiewen Yao <jiewen@intel.com<mailto:jiewen@intel.com>>

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Star Zeng <star.z...@intel.com<mailto:star.z...@intel.com>>

Reviewed-by: Giri P Mudusuru 
<giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> (cherry picked 
from commit 05b39efb669eaa173a76e58daf8e65bce2e0299e)



Modified : /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c





This looks irrelevant. Could you please confirm the revision?



Thanks,

Ting



-Original Message-

From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu, 
Siyuan

Sent: Thursday, August 18, 2016 10:48 AM

To: Santhapur Naveen <nave...@amiindia.co.in<mailto:nave...@amiindia.co.in>>; 
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

Cc: Sivaraman Nainar 
<sivaram...@amiindia.co.in<mailto:sivaram...@amiindia.co.in>>; Madhan B. 
Santharam <madh...@ami.com<mailto:madh...@ami.com>>

Subject: Re: [edk2] Classless IP support for IPv4 PXE boot



Hi, Naveen



May I know the GIT version of the 21543, or the subject of the commit message? 
I can't see the svn revision number on my side.



Thanks

Siyuan



> -Original Message-

> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of

> Santhapur Naveen

> Sent: Wednesday, August 17, 2016 7:41 PM

> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

> Cc: Sivaraman Nainar 
> <sivaram...@amiindia.co.in<mailto:sivaram...@amiindia.co.in>>; Madhan B. 
> Santharam

> <madh...@ami.com<mailto:madh...@ami.com>>

> Subject: [edk2] Classless IP support for IPv4 PXE boot

>

> Hello,

>

>   We happened to observe that the IPv4 PXE boot was happening

> successfully for both classless and classful IPs until the EDKII

> revision 21542. It has been found that there are some changes made in

> the revision

> 21543 and the IPv4 PXE boot is failing for classless IP addresses. The

> failure scenario was debugged and is explained here. Let's assume the

> subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP

> (let's say 192.168.1.0) but based on the first byte of the IP address

> to be assigned, the function NetGetIpClass() returns the IP class as

> Class-C and its respective subnet mask as 255.255.255.0 that should be

> for a classful IP address whereas 255.255.0.0 is the actual subnet in

> this scenario. The changes present in function

> Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure.

>

> May we know the reason behind the changes present in the Dhcp4Impl.c

> of the revision 21543? Is there any plan to bring the classless IP

> support in NetworkPkg?

>

>

> Thanks,

> Naveen

> ___

> edk2-devel mailing list

> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

> https://lists.01.org/mailman/listinfo/edk2-devel

___

edk2-devel mailing list

edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>

https://lists.01.org/mailman/listinfo/edk2-devel
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

[edk2] Classless IP support for IPv4 PXE boot

[Santhapur Naveen]

Hello,

  We happened to observe that the IPv4 PXE boot was happening 
successfully for both classless and classful IPs until the EDKII revision 
21542. It has been found that there are some changes made in the revision 21543 
and the IPv4 PXE boot is failing for classless IP addresses. The failure 
scenario was debugged and is explained here. Let's assume the subnet range is 
192.168.1.0/16. The DHCP server tries to allot an IP (let's say 192.168.1.0) 
but based on the first byte of the IP address to be assigned, the function 
NetGetIpClass() returns the IP class as Class-C and its respective subnet mask 
as 255.255.255.0 that should be for a classful IP address whereas 255.255.0.0 
is the actual subnet in this scenario. The changes present in function 
Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure.

May we know the reason behind the changes present in the Dhcp4Impl.c of the 
revision 21543? Is there any plan to bring the classless IP support in 
NetworkPkg?


Thanks,
Naveen
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel