Re: [E-devel] E SVN: maxerba trunk/E-MODULES-EXTRA/exebuf/src

[Daniel Juyung Seo]

Bingo!
I found this email from Govi.
http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg31491.html


>> 2. Macro E_(str) is used, to differentiate the elementary Strings from>>
commonly used #define _(str) in the applications. ( Just E ed :) )

Govi decided to use E_(str) for elementary.
I suggest to unify this to D_(str).
How do you guys think?

Daniel Juyung Seo (SeoZ)

On Fri, Apr 22, 2011 at 2:32 AM, Tom Hacohen  wrote:

> P.S, in elementary it should have probably been "D_".
>
>
> On Thu, Apr 21, 2011 at 8:30 PM, Tom Hacohen  wrote:
>
>> Dear Daniel,
>>
>> Elementary does what it does because it's a lib and you want to
>> specifically state the PACKAGE to be used.
>> You can just call gettext(str) if you want to use the currently "active"
>> PACKAGE.
>>
>> Why E was used? no idea, I didn't do that, a bit odd if you ask me.
>> The most common macro is _ but there are other conventions for different
>> invokations.
>>
>> Just google for the gettext tutorial and you'll see. Again, regarding elm:
>> odd.
>>
>> --
>> Tom.
>>
>>
>> On Thu, Apr 21, 2011 at 7:50 AM, Daniel Juyung Seo 
>> wrote:
>>
>>> Hello,
>>>
>>> >> -#define _(str) dgettext(PACKAGE, str)
>>> >> +#define D_(str) dgettext(PACKAGE, str)
>>>
>>> According to that change, I have a question.
>>> elementary uses E_(string) for dgettext.
>>>
>>> #define E_(string) dgettext(PACKAGE, string)
>>>
>>> Is there a recommended way to use dgettext?
>>> _(str), E_(str), D_(str) ?
>>>
>>> Thanks.
>>> Daniel Juyung Seo (SeoZ)
>>>
>>> On Thu, Apr 21, 2011 at 2:38 AM, Enlightenment SVN <
>>> no-re...@enlightenment.org> wrote:
>>>
>>> > Log:
>>> > it didn't build due to i18n issues: fixed
>>> >
>>> > Author:   maxerba
>>> > Date: 2011-04-20 10:38:25 -0700 (Wed, 20 Apr 2011)
>>> > New Revision: 58765
>>> > Trac: http://trac.enlightenment.org/e/changeset/58765
>>> >
>>> > Modified:
>>> >  trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
>>> > trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.h
>>> > trunk/E-MODULES-EXTRA/exebuf/src/exebuf_config.c
>>> >
>>> > Modified: trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
>>> > ===
>>> > --- trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
>>> 17:20:15
>>> > UTC (rev 58764)
>>> > +++ trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
>>> 17:38:25
>>> > UTC (rev 58765)
>>> > @@ -82,7 +82,7 @@
>>> >  /* config too old */
>>> >_exebuf_conf_free();
>>> > ecore_timer_add(1.0, _exebuf_conf_timer,
>>> > -_("Exebuf Module Configuration data needed
>>> "
>>> > +D_("Exebuf Module Configuration data
>>> needed "
>>> > "upgrading. Your old configuration has
>>> > been"
>>> > " wiped and a new set of defaults
>>> initialized.
>>> > "
>>> > "Thiswill happen regularly during "
>>> > @@ -102,7 +102,7 @@
>>> >  /* config too new...wtf ? */
>>> >  _exebuf_conf_free();
>>> > ecore_timer_add(1.0, _exebuf_conf_timer,
>>> > -_("Your Exebuf Module configuration is
>>> NEWER "
>>> > +D_("Your Exebuf Module configuration is
>>> NEWER
>>> > "
>>> > "than the module version. This is "
>>> > "verystrange. This should not happen
>>> > unless"
>>> > " you downgradedthe module or "
>>> > @@ -129,14 +129,14 @@
>>> >if (act)
>>> >  {
>>> >act->func.go = _exebuf_action_exebuf_cb;
>>> > -   e_action_predef_name_set(_("Launch"), _("Run Command Dialog"),
>>> > "exebuf",
>>> > +   e_action_predef_name_set(D_("Launch"), D_("Run Command
>>> Dialog"),
>>> > "exebuf",
>>> > NULL, NULL, 0);
>>> >  }
>>> >maug = e_int_menus_menu_augmentation_add_sorted
>>> > - ("main/1", _("Run Command"), _exebuf_menu_add, NULL, NULL, NULL);
>>> > + ("main/1", D_("Run Command"), _exebuf_menu_add, NULL, NULL,
>>> NULL);
>>> >
>>> > -   e_configure_registry_category_add("advanced", 80, _("Advanced"),
>>> NULL,
>>> > "preferences-advanced");
>>> > -   e_configure_registry_item_add("advanced/run_command", 40, _("Run
>>> > Command"), NULL, "system-run", exebuf_config_dialog);
>>> > +   e_configure_registry_category_add("advanced", 80, D_("Advanced"),
>>> NULL,
>>> > "preferences-advanced");
>>> > +   e_configure_registry_item_add("advanced/run_command", 40, D_("Run
>>> > Command"), NULL, "system-run", exebuf_config_dialog);
>>> >
>>> >/* Give E the module */
>>> >return m;
>>> > @@ -157,7 +157,7 @@
>>> >/* remove module-supplied action */
>>> >if (act)
>>> >  {
>>> > -   e_action_predef_name_del(_("Launch"), _("Run Command Dialog"));
>>> > + 

Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/software_x11

[Christopher Michael]

On 04/21/2011 07:33 PM, Carsten Haitzler (The Rasterman) wrote:
> On Thu, 21 Apr 2011 08:21:40 -0700 "Enlightenment SVN"
>   said:
>
> oops - sorry'bout that. copy&  paste typo fun++
>
No worries :)

dh

>> Log:
>> Evas: Fix typos from 'old mans' recent commit sot hings build again
>>wrt xcb.
>>
>>
>>
>> Author:   devilhorns
>> Date: 2011-04-21 08:21:40 -0700 (Thu, 21 Apr 2011)
>> New Revision: 58804
>> Trac: http://trac.enlightenment.org/e/changeset/58804
>>
>> Modified:
>>trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
>>
>> Modified: trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
>> ===

>


--
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] composite

[المسالم المسالمة]

hello developers

sorry to bothering you

but

since there is no one in

enlightenment-bugs-ow...@lists.sourceforge.net

to answer my request from

i decided to asking you

so

there is a problem here with that module

the problem here is some times when i try to open firefox (( i dont know
about other applications )) the whole E17 GUI will freez

and the only things that will responding to you is the mouse and keys
shortcuts if you want to kill the GUI and restart the COMPUTER
--
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] NEWS files

[Daniel Juyung Seo]

+1
I like this too :)

Daniel Juyung Seo (SeoZ)
On Apr 21, 2011 5:09 PM, "Boris 'billiob' Faure" <
bill...@gmail.com> wrote:
> Some typos:
>
>> Evas 1.1
> Ecore 1.1
>>
>> Changes since Evas 1.0:
> Changes since Ecore 1.0:
>> ---
>>
>> New Features:
>>
>> *ecore_x: XRandR backlight support
>>
>> API Additions:
>>
> […]
>
> Clear and simple, I like it.
>
>
> --
> Boris 'billiob' Faure
>
>
--
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve

> application availability and disaster protection. Learn more about
boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/software_x11

[The Rasterman]

On Thu, 21 Apr 2011 08:21:40 -0700 "Enlightenment SVN"
 said:

oops - sorry'bout that. copy & paste typo fun++

> Log:
> Evas: Fix typos from 'old mans' recent commit sot hings build again
>   wrt xcb.
>   
>   
> 
> Author:   devilhorns
> Date: 2011-04-21 08:21:40 -0700 (Thu, 21 Apr 2011)
> New Revision: 58804
> Trac: http://trac.enlightenment.org/e/changeset/58804
> 
> Modified:
>   trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c 
> 
> Modified: trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
> ===
> --- trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
> 2011-04-21 15:02:34 UTC (rev 58803) +++
> trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
> 2011-04-21 15:21:40 UTC (rev 58804) @@ -571,7 +571,7 @@ alpha,
> EVAS_COLORSPACE_ARGB); if (!im)
>{
> - _unfind_xob(obr->xob, 0);
> + _unfind_xcbob(obr->xcbob, 0);
>   free(obr);
>   return NULL;
>}
> 
> 
> --
> Benefiting from Server Virtualization: Beyond Initial Workload 
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve 
> application availability and disaster protection. Learn more about boosting 
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] eina_module log dom

[Mike Blumenkrantz]

Why is this on by default now? It's annoying to get the loading spam all the
time...

-- 
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!

--
Fulfilling the Lean Software Promise
Lean software platforms are now widely adopted and the benefits have been 
demonstrated beyond question. Learn why your peers are replacing JEE 
containers with lightweight application servers - and what you can gain 
from the move. http://p.sf.net/sfu/vmware-sfemails
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: maxerba trunk/E-MODULES-EXTRA/exebuf/src

[Tom Hacohen]

P.S, in elementary it should have probably been "D_".

On Thu, Apr 21, 2011 at 8:30 PM, Tom Hacohen  wrote:

> Dear Daniel,
>
> Elementary does what it does because it's a lib and you want to
> specifically state the PACKAGE to be used.
> You can just call gettext(str) if you want to use the currently "active"
> PACKAGE.
>
> Why E was used? no idea, I didn't do that, a bit odd if you ask me.
> The most common macro is _ but there are other conventions for different
> invokations.
>
> Just google for the gettext tutorial and you'll see. Again, regarding elm:
> odd.
>
> --
> Tom.
>
>
> On Thu, Apr 21, 2011 at 7:50 AM, Daniel Juyung Seo 
> wrote:
>
>> Hello,
>>
>> >> -#define _(str) dgettext(PACKAGE, str)
>> >> +#define D_(str) dgettext(PACKAGE, str)
>>
>> According to that change, I have a question.
>> elementary uses E_(string) for dgettext.
>>
>> #define E_(string) dgettext(PACKAGE, string)
>>
>> Is there a recommended way to use dgettext?
>> _(str), E_(str), D_(str) ?
>>
>> Thanks.
>> Daniel Juyung Seo (SeoZ)
>>
>> On Thu, Apr 21, 2011 at 2:38 AM, Enlightenment SVN <
>> no-re...@enlightenment.org> wrote:
>>
>> > Log:
>> > it didn't build due to i18n issues: fixed
>> >
>> > Author:   maxerba
>> > Date: 2011-04-20 10:38:25 -0700 (Wed, 20 Apr 2011)
>> > New Revision: 58765
>> > Trac: http://trac.enlightenment.org/e/changeset/58765
>> >
>> > Modified:
>> >  trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
>> > trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.h
>> > trunk/E-MODULES-EXTRA/exebuf/src/exebuf_config.c
>> >
>> > Modified: trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
>> > ===
>> > --- trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
>> 17:20:15
>> > UTC (rev 58764)
>> > +++ trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
>> 17:38:25
>> > UTC (rev 58765)
>> > @@ -82,7 +82,7 @@
>> >  /* config too old */
>> >_exebuf_conf_free();
>> > ecore_timer_add(1.0, _exebuf_conf_timer,
>> > -_("Exebuf Module Configuration data needed
>> "
>> > +D_("Exebuf Module Configuration data needed
>> "
>> > "upgrading. Your old configuration has
>> > been"
>> > " wiped and a new set of defaults
>> initialized.
>> > "
>> > "Thiswill happen regularly during "
>> > @@ -102,7 +102,7 @@
>> >  /* config too new...wtf ? */
>> >  _exebuf_conf_free();
>> > ecore_timer_add(1.0, _exebuf_conf_timer,
>> > -_("Your Exebuf Module configuration is
>> NEWER "
>> > +D_("Your Exebuf Module configuration is
>> NEWER
>> > "
>> > "than the module version. This is "
>> > "verystrange. This should not happen
>> > unless"
>> > " you downgradedthe module or "
>> > @@ -129,14 +129,14 @@
>> >if (act)
>> >  {
>> >act->func.go = _exebuf_action_exebuf_cb;
>> > -   e_action_predef_name_set(_("Launch"), _("Run Command Dialog"),
>> > "exebuf",
>> > +   e_action_predef_name_set(D_("Launch"), D_("Run Command Dialog"),
>> > "exebuf",
>> > NULL, NULL, 0);
>> >  }
>> >maug = e_int_menus_menu_augmentation_add_sorted
>> > - ("main/1", _("Run Command"), _exebuf_menu_add, NULL, NULL, NULL);
>> > + ("main/1", D_("Run Command"), _exebuf_menu_add, NULL, NULL, NULL);
>> >
>> > -   e_configure_registry_category_add("advanced", 80, _("Advanced"),
>> NULL,
>> > "preferences-advanced");
>> > -   e_configure_registry_item_add("advanced/run_command", 40, _("Run
>> > Command"), NULL, "system-run", exebuf_config_dialog);
>> > +   e_configure_registry_category_add("advanced", 80, D_("Advanced"),
>> NULL,
>> > "preferences-advanced");
>> > +   e_configure_registry_item_add("advanced/run_command", 40, D_("Run
>> > Command"), NULL, "system-run", exebuf_config_dialog);
>> >
>> >/* Give E the module */
>> >return m;
>> > @@ -157,7 +157,7 @@
>> >/* remove module-supplied action */
>> >if (act)
>> >  {
>> > -   e_action_predef_name_del(_("Launch"), _("Run Command Dialog"));
>> > +   e_action_predef_name_del(D_("Launch"), D_("Run Command
>> Dialog"));
>> >e_action_del("exebuf");
>> >act = NULL;
>> >  }
>> > @@ -246,7 +246,7 @@
>> >  static Eina_Bool
>> >  _exebuf_conf_timer(void *data)
>> >  {
>> > -   e_util_dialog_internal(_("Exebuf Configuration Updated"), data);
>> > +   e_util_dialog_internal(D_("Exebuf Configuration Updated"), data);
>> >
>> >return EINA_FALSE;
>> >  }
>> > @@ -296,7 +296,7 @@
>> >E_Menu_Item *mi;
>> >
>> >mi = e_menu_item_new(m);
>> > -   e_menu_item_label_set(mi, _("Run Command"));
>> > +   e_menu_item_label_set(mi, D_("Run Command"));
>> >e_util_menu_item_theme_icon_set(mi, "sy

Re: [E-devel] E SVN: maxerba trunk/E-MODULES-EXTRA/exebuf/src

[Tom Hacohen]

Dear Daniel,

Elementary does what it does because it's a lib and you want to specifically
state the PACKAGE to be used.
You can just call gettext(str) if you want to use the currently "active"
PACKAGE.

Why E was used? no idea, I didn't do that, a bit odd if you ask me.
The most common macro is _ but there are other conventions for different
invokations.

Just google for the gettext tutorial and you'll see. Again, regarding elm:
odd.

--
Tom.

On Thu, Apr 21, 2011 at 7:50 AM, Daniel Juyung Seo wrote:

> Hello,
>
> >> -#define _(str) dgettext(PACKAGE, str)
> >> +#define D_(str) dgettext(PACKAGE, str)
>
> According to that change, I have a question.
> elementary uses E_(string) for dgettext.
>
> #define E_(string) dgettext(PACKAGE, string)
>
> Is there a recommended way to use dgettext?
> _(str), E_(str), D_(str) ?
>
> Thanks.
> Daniel Juyung Seo (SeoZ)
>
> On Thu, Apr 21, 2011 at 2:38 AM, Enlightenment SVN <
> no-re...@enlightenment.org> wrote:
>
> > Log:
> > it didn't build due to i18n issues: fixed
> >
> > Author:   maxerba
> > Date: 2011-04-20 10:38:25 -0700 (Wed, 20 Apr 2011)
> > New Revision: 58765
> > Trac: http://trac.enlightenment.org/e/changeset/58765
> >
> > Modified:
> >  trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
> > trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.h
> > trunk/E-MODULES-EXTRA/exebuf/src/exebuf_config.c
> >
> > Modified: trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c
> > ===
> > --- trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
> 17:20:15
> > UTC (rev 58764)
> > +++ trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.c   2011-04-20
> 17:38:25
> > UTC (rev 58765)
> > @@ -82,7 +82,7 @@
> >  /* config too old */
> >_exebuf_conf_free();
> > ecore_timer_add(1.0, _exebuf_conf_timer,
> > -_("Exebuf Module Configuration data needed "
> > +D_("Exebuf Module Configuration data needed
> "
> > "upgrading. Your old configuration has
> > been"
> > " wiped and a new set of defaults
> initialized.
> > "
> > "Thiswill happen regularly during "
> > @@ -102,7 +102,7 @@
> >  /* config too new...wtf ? */
> >  _exebuf_conf_free();
> > ecore_timer_add(1.0, _exebuf_conf_timer,
> > -_("Your Exebuf Module configuration is NEWER
> "
> > +D_("Your Exebuf Module configuration is
> NEWER
> > "
> > "than the module version. This is "
> > "verystrange. This should not happen
> > unless"
> > " you downgradedthe module or "
> > @@ -129,14 +129,14 @@
> >if (act)
> >  {
> >act->func.go = _exebuf_action_exebuf_cb;
> > -   e_action_predef_name_set(_("Launch"), _("Run Command Dialog"),
> > "exebuf",
> > +   e_action_predef_name_set(D_("Launch"), D_("Run Command Dialog"),
> > "exebuf",
> > NULL, NULL, 0);
> >  }
> >maug = e_int_menus_menu_augmentation_add_sorted
> > - ("main/1", _("Run Command"), _exebuf_menu_add, NULL, NULL, NULL);
> > + ("main/1", D_("Run Command"), _exebuf_menu_add, NULL, NULL, NULL);
> >
> > -   e_configure_registry_category_add("advanced", 80, _("Advanced"),
> NULL,
> > "preferences-advanced");
> > -   e_configure_registry_item_add("advanced/run_command", 40, _("Run
> > Command"), NULL, "system-run", exebuf_config_dialog);
> > +   e_configure_registry_category_add("advanced", 80, D_("Advanced"),
> NULL,
> > "preferences-advanced");
> > +   e_configure_registry_item_add("advanced/run_command", 40, D_("Run
> > Command"), NULL, "system-run", exebuf_config_dialog);
> >
> >/* Give E the module */
> >return m;
> > @@ -157,7 +157,7 @@
> >/* remove module-supplied action */
> >if (act)
> >  {
> > -   e_action_predef_name_del(_("Launch"), _("Run Command Dialog"));
> > +   e_action_predef_name_del(D_("Launch"), D_("Run Command Dialog"));
> >e_action_del("exebuf");
> >act = NULL;
> >  }
> > @@ -246,7 +246,7 @@
> >  static Eina_Bool
> >  _exebuf_conf_timer(void *data)
> >  {
> > -   e_util_dialog_internal(_("Exebuf Configuration Updated"), data);
> > +   e_util_dialog_internal(D_("Exebuf Configuration Updated"), data);
> >
> >return EINA_FALSE;
> >  }
> > @@ -296,7 +296,7 @@
> >E_Menu_Item *mi;
> >
> >mi = e_menu_item_new(m);
> > -   e_menu_item_label_set(mi, _("Run Command"));
> > +   e_menu_item_label_set(mi, D_("Run Command"));
> >e_util_menu_item_theme_icon_set(mi, "system-run");
> >e_menu_item_callback_set(mi, _exebuf_run_cb, NULL);
> >  }
> >
> > Modified: trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.h
> > ===
> > --- trunk/E-MODULES-EXTRA/exebuf/src/e_mod_main.h   

Re: [E-devel] E SVN: maxerba trunk/E-MODULES-EXTRA/exebuf/src

[Massimo Maiurana]

Daniel Juyung Seo, il 21/04/2011 06:50, ha scritto:
> Hello,
> 
>>> -#define _(str) dgettext(PACKAGE, str)
>>> +#define D_(str) dgettext(PACKAGE, str)
> 
> According to that change, I have a question.
> elementary uses E_(string) for dgettext.
> 
> #define E_(string) dgettext(PACKAGE, string)
> 
> Is there a recommended way to use dgettext?
> _(str), E_(str), D_(str) ?

I don't knoew why elementary defines dgettext() as E_(), I used D_() in this
case because all modules defines it this way.

-- 

Massimo Maiurana  massimoragusa.linux.it
http://massimo.solira.orgGPG keyID #7044D601

Creare l'uomo  fu un'idea bizzarra  e originale,
ma  aggiungere  la  pecora  fu  una  tautologia.
  [Mark Twain]



signature.asc
Description: OpenPGP digital signature
--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: discomfitor IN trunk/ecore: . src/lib/ecore

[Mike Blumenkrantz]

On Tue, 19 Apr 2011 23:40:08 +0200 (CEST)
Vincent Torri  wrote:

> 
> 
> On Tue, 19 Apr 2011, Enlightenment SVN wrote:
> 
> > Log:
> > +ecore_exe_data_set
> >
> >
> > Author:   discomfitor
> > Date: 2011-04-19 14:38:24 -0700 (Tue, 19 Apr 2011)
> > New Revision: 58737
> > Trac: http://trac.enlightenment.org/e/changeset/58737
> >
> > Modified:
> >  trunk/ecore/ChangeLog trunk/ecore/src/lib/ecore/Ecore.h
> > trunk/ecore/src/lib/ecore/ecore_exe.c
> >
> > Modified: trunk/ecore/ChangeLog
> > ===
> > --- trunk/ecore/ChangeLog   2011-04-19 21:37:32 UTC (rev 58736)
> > +++ trunk/ecore/ChangeLog   2011-04-19 21:38:24 UTC (rev 58737)
> > @@ -131,3 +131,7 @@
> > 2011-04-13  Doyun Kang
> >
> > * Ecore_X + Ecore_Evas: Add more support for shape input setting
> > +
> > +2011-04-19 Mike Blumenkrantz
> > +
> > +* +ecore_exe_data_set
> 
> can you describe a bit more the entry. Changelog should not have sybillin 
> entries.
> 
> Vincent
oh wow I missed this mail completely. my bad.

-- 
Mike Blumenkrantz
Zentific: NULL pointer dereferences now 50% off!

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore

[Gustavo Sverzut Barbieri]

On Wed, Apr 20, 2011 at 10:47 PM, Carsten Haitzler  wrote:
> On Wed, 20 Apr 2011 10:54:03 -0300 Gustavo Sverzut Barbieri
>  said:
>
>> On Wed, Apr 20, 2011 at 3:51 AM, Enlightenment SVN
>>  wrote:
>> > Log:
>> > add animator runtime stuff to run animator for fixed timelength and an
>> >  interpolation mapping func.
>>
>>
>> > +   typedef Eina_Bool (*Ecore_Timeline_Cb) (void *data, double pos);
>>
>> > +   EAPI Ecore_Animator *ecore_animator_run_add(double runtime,
>> > Ecore_Timeline_Cb func, const void *data);
>>
>> It makes no sense to have "run' mixed with "Timeline", maybe have it
>> as ecore_animator_timeline_add()?
>
> in english a "run" of something is a batch or line or unit of things.
>
> "the project's run has finished"
> "i started up a run of the test suite"
>
> in that usage it implies it has a start and then an end. :)

So rename the callback name to Animation_Run ?


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] _NET_WM_DESKTOP

[Ag. Systems Administrator - Danny]

Ok, thank you for clarification.
Will live in hope for best future ;))

Best,
Daniel

2011/4/21 Carsten Haitzler 

> On Thu, 21 Apr 2011 10:24:09 +0200 Guillaume Friloux
>  said:
>
> as per irc. e could export e17 specific properties and info. as such there
> is
> no NEED for e17 itself to do this. it's a nicety to other tools. i don't
> think
> we need to visit this now, but bring it up again when e17 is in alpha or
> beta
> and we are not busy with other things and we can see about implementing
> something that exposes such info.
>
> > I asked the author of xdotool, here is his answer :
> >
> > yeah EWMH is pretty crappy at defining desktops
> > there's two general schools - desktop array (0, 1, 2, 3, ...)
> > or viewports
> > where your real "desktop' will be some zillons of pixels, your view on
> > them is just your screen size.
> > for example, compiz uses viewports (get_viewport)
> > but EWMH doesn't include how to hit what view a window is in
> > so you can't query what viewport a window is in
> > it's pretty crappy
> >
> >
> > So i dont think xdotool will work in e anytime soon.
> >
> > On 21/04/2011 09:51, Carsten Haitzler (The Rasterman) wrote:
> > > On Mon, 18 Apr 2011 15:55:41 +0300 "Ag. Systems Administrator - Danny"
> > >   said:
> > >
> > >> Hello All,
> > >>
> > >> $ xdotool get_desktop_for_window 12582925
> > >> Your windowmanager claims not to support _NET_WM_DESKTOP, so the
> attempt to
> > >> query a window's desktop location was aborted.
> > >>
> > >> Strange, as it looks that this functionality is already implemented in
> > >> ecore, but not enabled (commented out in e_hints.c, line 68)
> > >>
> > >> Something must be done/finished to enable this one? ;)
> > > e doesnt set the netwm desktop on a window. it actualyl can't support
> netwm
> > > desktop stuff because... e has N SETs of desktops (of XxY screens), one
> per
> > > screen (randr/xinerama screen zone). netwm was (last i looked)
> insufficient
> > > to support e as e has much more info.
> > >
> > >
> >
>
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
>
>
>
> --
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: cedric IN trunk/enlil: . src/enlil

[Cedric BAIL]

On Thu, Apr 21, 2011 at 3:58 PM, Vincent Torri  wrote:
> On Thu, 21 Apr 2011, Enlightenment SVN wrote:
>> Log:
>> enlil: fix build.
>>
>>
>> Author:       cedric
>> Date:         2011-04-21 06:53:21 -0700 (Thu, 21 Apr 2011)
>> New Revision: 58798
>> Trac:         http://trac.enlightenment.org/e/changeset/58798
>>
>> Modified:
>>  trunk/enlil/configure.ac trunk/enlil/src/enlil/Makefile.am 
>> trunk/enlil/src/enlil/enlil.c trunk/enlil/src/enlil/net_sync.c
>>
>> Modified: trunk/enlil/configure.ac
>> ===
>> --- trunk/enlil/configure.ac  2011-04-21 12:33:35 UTC (rev 58797)
>> +++ trunk/enlil/configure.ac  2011-04-21 13:53:21 UTC (rev 58798)
>> @@ -63,11 +63,11 @@
>>
>> ### Checks for libraries
>>
>> -requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0 
>> evas >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >= 
>> 1.0.2 libxml-2.0 >= 0.1.1"
>> +requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0 
>> evas >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >= 
>> 1.0.2 libxml-2.0 >= 0.1.1 azy"
>>
>> -PKG_CHECK_EXISTS([eabzu_client >= 0.0.1],
>> +PKG_CHECK_EXISTS([azy >= 0.0.1],
>>    [
>> -    requirements="eabzu_client >= 0.0.1 ${requirements}"
>> +    requirements="azy >= 0.0.1 ${requirements}"
>>     have_eabzu="yes"
>>     AC_DEFINE_UNQUOTED(HAVE_EABZU, [1], [have network synchronization 
>> (eabzu) support])
>
> the 2 lines above should also be killed, and you have to check that
> HAVE_EABZU is not used anymore in the code. Also, check all the lines
> where have_eabzu is used in configure.ac (if any)

Well, as eabzu was renamed as azy, I just fixed that by doing the
minimalistic change. I will let watchwolf do a complete and correct
fix, at least now it build and run fine.
-- 
Cedric BAIL

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: cedric IN trunk/enlil: . src/enlil

[Atton Jonathan]

I will fix this if cedric does not do it !

2011/4/21 Vincent Torri 

>
>
> On Thu, 21 Apr 2011, Enlightenment SVN wrote:
>
> > Log:
> > enlil: fix build.
> >
> >
> > Author:   cedric
> > Date: 2011-04-21 06:53:21 -0700 (Thu, 21 Apr 2011)
> > New Revision: 58798
> > Trac: http://trac.enlightenment.org/e/changeset/58798
> >
> > Modified:
> >  trunk/enlil/configure.ac trunk/enlil/src/enlil/Makefile.am
> trunk/enlil/src/enlil/enlil.c trunk/enlil/src/enlil/net_sync.c
> >
> > Modified: trunk/enlil/configure.ac
> > ===
> > --- trunk/enlil/configure.ac  2011-04-21 12:33:35 UTC (rev 58797)
> > +++ trunk/enlil/configure.ac  2011-04-21 13:53:21 UTC (rev 58798)
> > @@ -63,11 +63,11 @@
> >
> > ### Checks for libraries
> >
> > -requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0
> evas >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >=
> 1.0.2 libxml-2.0 >= 0.1.1"
> > +requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0
> evas >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >=
> 1.0.2 libxml-2.0 >= 0.1.1 azy"
> >
> > -PKG_CHECK_EXISTS([eabzu_client >= 0.0.1],
> > +PKG_CHECK_EXISTS([azy >= 0.0.1],
> >[
> > -requirements="eabzu_client >= 0.0.1 ${requirements}"
> > +requirements="azy >= 0.0.1 ${requirements}"
> > have_eabzu="yes"
> > AC_DEFINE_UNQUOTED(HAVE_EABZU, [1], [have network synchronization
> (eabzu) support])
>
> the 2 lines above should also be killed, and you have to check that
> HAVE_EABZU is not used anymore in the code. Also, check all the lines
> where have_eabzu is used in configure.ac (if any)
>
> Vincent
>
>
> >],
> >
> > Modified: trunk/enlil/src/enlil/Makefile.am
> > ===
> > --- trunk/enlil/src/enlil/Makefile.am 2011-04-21 12:33:35 UTC (rev 58797)
> > +++ trunk/enlil/src/enlil/Makefile.am 2011-04-21 13:53:21 UTC (rev 58798)
> > @@ -38,10 +38,21 @@
> > pwg_Common.c \
> > pwg_Common_Azy.c
> >
> > -BUILT_SOURCES = .sources
> > -.sources: ws_piwigo/services.azy
> > +pwg_Common.c: ws_piwigo/services.azy
> >   azy_parser -H -p -o ./ ws_piwigo/services.azy
> >
> > +pwg_Common_Azy.c: ws_piwigo/services.azy
> > + azy_parser -H -p -o ./ ws_piwigo/services.azy
> > +
> > +pwg_categories.azy_client.c: ws_piwigo/services.azy
> > + azy_parser -H -p -o ./ ws_piwigo/services.azy
> > +
> > +pwg_images.azy_client.c: ws_piwigo/services.azy
> > + azy_parser -H -p -o ./ ws_piwigo/services.azy
> > +
> > +pwg_session.azy_client.c: ws_piwigo/services.azy
> > + azy_parser -H -p -o ./ ws_piwigo/services.azy
> > +
> > installed_headersdir = $(prefix)/include/enlil
> > installed_headers_DATA = Enlil.h
> > libenlil_la_CFLAGS =  @EFL_PTHREAD_CFLAGS@
> >
> > Modified: trunk/enlil/src/enlil/enlil.c
> > ===
> > --- trunk/enlil/src/enlil/enlil.c 2011-04-21 12:33:35 UTC (rev 58797)
> > +++ trunk/enlil/src/enlil/enlil.c 2011-04-21 13:53:21 UTC (rev 58798)
> > @@ -2,7 +2,7 @@
> > #include 
> >
> > #ifdef HAVE_EABZU
> > -#include 
> > +#include 
> > #endif
> >
> > int ENLIL_LOG_DOMAIN_99;
> >
> > Modified: trunk/enlil/src/enlil/net_sync.c
> > ===
> > --- trunk/enlil/src/enlil/net_sync.c  2011-04-21 12:33:35 UTC (rev 58797)
> > +++ trunk/enlil/src/enlil/net_sync.c  2011-04-21 13:53:21 UTC (rev 58798)
> > @@ -4,7 +4,7 @@
> > #include "../../config.h"
> >
> > #ifdef HAVE_EABZU
> > -#include 
> > +#include 
> > #endif
> >
> > //mmap()
> >
> >
> >
> --
> > Benefiting from Server Virtualization: Beyond Initial Workload
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and
> improve
> > application availability and disaster protection. Learn more about
> boosting
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> >
>
>
> --
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>



-- 
Re

Re: [E-devel] E SVN: cedric IN trunk/enlil: . src/enlil

[Vincent Torri]

On Thu, 21 Apr 2011, Enlightenment SVN wrote:

> Log:
> enlil: fix build.
>
>
> Author:   cedric
> Date: 2011-04-21 06:53:21 -0700 (Thu, 21 Apr 2011)
> New Revision: 58798
> Trac: http://trac.enlightenment.org/e/changeset/58798
>
> Modified:
>  trunk/enlil/configure.ac trunk/enlil/src/enlil/Makefile.am 
> trunk/enlil/src/enlil/enlil.c trunk/enlil/src/enlil/net_sync.c
>
> Modified: trunk/enlil/configure.ac
> ===
> --- trunk/enlil/configure.ac  2011-04-21 12:33:35 UTC (rev 58797)
> +++ trunk/enlil/configure.ac  2011-04-21 13:53:21 UTC (rev 58798)
> @@ -63,11 +63,11 @@
>
> ### Checks for libraries
>
> -requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0 evas 
> >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >= 1.0.2 
> libxml-2.0 >= 0.1.1"
> +requirements="ethumb_client >= 0.1.0 ecore-file >= 1.0.0 ecore >= 1.0.0 evas 
> >= 1.0.0 eet >= 1.2.2 eina >= 1.0.0 libexif >= 0.6.16 libiptcdata >= 1.0.2 
> libxml-2.0 >= 0.1.1 azy"
>
> -PKG_CHECK_EXISTS([eabzu_client >= 0.0.1],
> +PKG_CHECK_EXISTS([azy >= 0.0.1],
>[
> -requirements="eabzu_client >= 0.0.1 ${requirements}"
> +requirements="azy >= 0.0.1 ${requirements}"
> have_eabzu="yes"
> AC_DEFINE_UNQUOTED(HAVE_EABZU, [1], [have network synchronization (eabzu) 
> support])

the 2 lines above should also be killed, and you have to check that 
HAVE_EABZU is not used anymore in the code. Also, check all the lines 
where have_eabzu is used in configure.ac (if any)

Vincent


>],
>
> Modified: trunk/enlil/src/enlil/Makefile.am
> ===
> --- trunk/enlil/src/enlil/Makefile.am 2011-04-21 12:33:35 UTC (rev 58797)
> +++ trunk/enlil/src/enlil/Makefile.am 2011-04-21 13:53:21 UTC (rev 58798)
> @@ -38,10 +38,21 @@
> pwg_Common.c \
> pwg_Common_Azy.c
>
> -BUILT_SOURCES = .sources
> -.sources: ws_piwigo/services.azy
> +pwg_Common.c: ws_piwigo/services.azy
>   azy_parser -H -p -o ./ ws_piwigo/services.azy
>
> +pwg_Common_Azy.c: ws_piwigo/services.azy
> + azy_parser -H -p -o ./ ws_piwigo/services.azy
> +
> +pwg_categories.azy_client.c: ws_piwigo/services.azy
> + azy_parser -H -p -o ./ ws_piwigo/services.azy
> +
> +pwg_images.azy_client.c: ws_piwigo/services.azy
> + azy_parser -H -p -o ./ ws_piwigo/services.azy
> +
> +pwg_session.azy_client.c: ws_piwigo/services.azy
> + azy_parser -H -p -o ./ ws_piwigo/services.azy
> +
> installed_headersdir = $(prefix)/include/enlil
> installed_headers_DATA = Enlil.h
> libenlil_la_CFLAGS =  @EFL_PTHREAD_CFLAGS@
>
> Modified: trunk/enlil/src/enlil/enlil.c
> ===
> --- trunk/enlil/src/enlil/enlil.c 2011-04-21 12:33:35 UTC (rev 58797)
> +++ trunk/enlil/src/enlil/enlil.c 2011-04-21 13:53:21 UTC (rev 58798)
> @@ -2,7 +2,7 @@
> #include 
>
> #ifdef HAVE_EABZU
> -#include 
> +#include 
> #endif
>
> int ENLIL_LOG_DOMAIN_99;
>
> Modified: trunk/enlil/src/enlil/net_sync.c
> ===
> --- trunk/enlil/src/enlil/net_sync.c  2011-04-21 12:33:35 UTC (rev 58797)
> +++ trunk/enlil/src/enlil/net_sync.c  2011-04-21 13:53:21 UTC (rev 58798)
> @@ -4,7 +4,7 @@
> #include "../../config.h"
>
> #ifdef HAVE_EABZU
> -#include 
> +#include 
> #endif
>
> //mmap()
>
>
> --
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
>

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: raster trunk/evas/src/modules/engines/software_x11

[Daniel Juyung Seo]

Hi Raster,
Is this change related to our discussion?

Daniel Juyung Seo (SeoZ)
On Apr 21, 2011 9:34 PM, "Enlightenment SVN" 
wrote:
> Log:
> add in lots of ptr checks to sw-x11 outbut code... this may only
> happen if we ran out of mem and mallocs failed... but we can avoid a
> crash.
>
>
>
> Author: raster
> Date: 2011-04-21 05:33:35 -0700 (Thu, 21 Apr 2011)
> New Revision: 58797
> Trac: http://trac.enlightenment.org/e/changeset/58797
>
> Modified:
> trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
trunk/evas/src/modules/engines/software_x11/evas_xlib_buffer.c
trunk/evas/src/modules/engines/software_x11/evas_xlib_outbuf.c
>
> Modified: trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
> ===
> --- trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
2011-04-21 12:22:07 UTC (rev 58796)
> +++ trunk/evas/src/modules/engines/software_x11/evas_xcb_outbuf.c
2011-04-21 12:33:35 UTC (rev 58797)
> @@ -40,7 +40,6 @@
> int lbytes;
> int bpp;
>
> -// return evas_software_xcb_x_output_buffer_new(d, v, depth, w, h, shm,
data);
> if (!shm)
> return evas_software_xcb_x_output_buffer_new(conn, depth, w, h, shm,
data);
> if (depth > 1)
> @@ -92,7 +91,6 @@
> static void
> _unfind_xcbob(Xcb_Output_Buffer *xcbob, int sync)
> {
> -// evas_software_xcb_x_output_buffer_free(xcbob, sync); return;
> if (xcbob->shm_info)
> {
> shmpool = eina_list_prepend(shmpool, xcbob);
> @@ -398,8 +396,14 @@
> Eina_Rectangle *rect;
>
> RECTS_CLIP_TO_RECT(x, y, w, h, 0, 0, buf->w, buf->h);
> + obr = calloc(1, sizeof(Outbuf_Region));
> + if (!obr) return NULL;
> rect = eina_rectangle_new(x, y, w, h);
> - if (!rect) return NULL;
> + if (!rect)
> + {
> + free(obr);
> + return NULL;
> + }
>
> buf->priv.onebuf_regions = eina_list_append(buf->priv.onebuf_regions,
rect);
> if (buf->priv.onebuf)
> @@ -416,7 +420,6 @@
> }
> return buf->priv.onebuf;
> }
> - obr = calloc(1, sizeof(Outbuf_Region));
> obr->x = 0;
> obr->y = 0;
> obr->w = buf->w;
> @@ -439,21 +442,37 @@
> buf->w, buf->h,
> use_shm,
> NULL);
> + if (!obr->xcbob)
> + {
> + free(obr);
> + return NULL;
> + }
> im = (RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
> buf->w, buf->h,
> (DATA32 *)evas_software_xcb_x_output_buffer_data(obr->xcbob, &bpl),
> alpha, EVAS_COLORSPACE_ARGB);
> - im->extended_info = obr;
> - if (buf->priv.x11.xcb.mask)
> - obr->mxcbob =
evas_software_xcb_x_output_buffer_new(buf->priv.x11.xcb.conn,
> - 1,
> - buf->w, buf->h,
> - use_shm,
> - NULL);
> + if (!im)
> + {
> + evas_software_xcb_x_output_buffer_free(obr->xcbob, 0);
> + free(obr);
> + return NULL;
> + }
> + im->extended_info = obr;
> + if (buf->priv.x11.xcb.mask)
> + obr->mxcbob =
evas_software_xcb_x_output_buffer_new(buf->priv.x11.xcb.conn,
> + 1,
> + buf->w, buf->h,
> + use_shm,
> + NULL);
> }
> else
> {
> im = (RGBA_Image *) evas_cache_image_empty(evas_common_image_cache_get());
> + if (!im)
> + {
> + free(obr);
> + return NULL;
> + }
> im->cache_entry.flags.alpha |= alpha ? 1 : 0;
> evas_cache_image_surface_alloc(&im->cache_entry, buf->w, buf->h);
> im->extended_info = obr;
> @@ -464,6 +483,12 @@
> buf->w, buf->h,
> use_shm,
> NULL);
> + if (!obr->xcbob)
> + {
> + evas_cache_image_drop(&im->cache_entry);
> + free(obr);
> + return NULL;
> + }
> if (buf->priv.x11.xcb.mask)
> obr->mxcbob =
evas_software_xcb_x_output_buffer_new(buf->priv.x11.xcb.conn,
> 1,
> @@ -478,6 +503,12 @@
> buf->h, buf->w,
> use_shm,
> NULL);
> + if (!obr->xcbob)
> + {
> + evas_cache_image_drop(&im->cache_entry);
> + free(obr);
> + return NULL;
> + }
> if (buf->priv.x11.xcb.mask)
> obr->mxcbob =
evas_software_xcb_x_output_buffer_new(buf->priv.x11.xcb.conn,
> 1,
> @@ -488,9 +519,11 @@
> }
> /* FIXME: We should be able to remove this memset, but somewhere in the
process
> we copy too much to the destination surface and some area are not cleaned
before copy. */
> - if (alpha)
> - /* FIXME: faster memset! */
> - memset(im->image.data, 0, w * h * sizeof(DATA32));
> + if ((alpha) && (im->image.data))
> + {
> + /* FIXME: faster memset! */
> + memset(im->image.data, 0, w * h * sizeof(DATA32));
> + }
>
> buf->priv.onebuf = im;
> return im;
> @@ -498,6 +531,7 @@
>
>
> obr = calloc(1, sizeof(Outbuf_Region));
> + if (!obr) return NULL;
> obr->x = x;
> obr->y = y;
> obr->w = w;
> @@ -526,27 +560,37 @@
> w, h,
> use_shm,
> NULL);
> - im = (RGBA_Image *) evas_cache_image_data(evas_common_image_cache_get(),
> - w, h,
> - (DATA32 *) evas_software_xcb_x_output_buffer_data(obr->xcbob, &bpl),
> - alpha, EVAS_COLORSPACE_ARGB);
> - im->extended_info = obr;
> + if (!obr->xcbob)
> + {
> + free(obr);
> + return NULL;
> + }
> + im = (RGBA_Image *)evas_cache_image_data(evas_common_image_cache_get(),
> + w, h,
> + (DATA32 *) evas_software_xcb_x_output_buffer_data(obr->xcbob, &bpl),
> + alpha, EVAS_COLORSPACE_ARGB);
> + if (!im)
> + {
> + _unfind_xob(obr->xob, 0);
> + free(obr);
> + return NULL;
> + }
> + im->extended_info = obr;
> if (buf->priv.x1

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[Cedric BAIL]

On Thu, Apr 21, 2011 at 1:49 PM, Carsten Haitzler  wrote:
> On Thu, 21 Apr 2011 11:35:29 +0200 Cedric BAIL  said:
>> On Thu, Apr 21, 2011 at 11:32 AM, Carsten Haitzler 
>> wrote:
>> > On Thu, 21 Apr 2011 10:43:14 +0200 Cedric BAIL  said:
>> >> On Thu, Apr 21, 2011 at 10:21 AM, Carsten Haitzler 
>> >> wrote:
>> >> > On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL 
>> >> > said: hmmm but you break stacking in that... now thats fixed odd and
>> >> > even... that actually may not be desired :)
>> >>
>> >> Stacking should not be broken by this patch. Theme can set if even or
>> >> odd should be raised and they will. Testing it in elementary_test
>> >> genlist 2, show that it is respected and it is working also when
>> >> appending or prepending some new items. But maybe you are speaking
>> >> about a completly different stuff and because genlist has so much
>> >> functionnality, i may have missed it.
>> >
>> > and if it shouldnt stack at all? if it should raise on select (then lower
>> > back to where it was if ti wasn't a raised item) etc? i didn't see that
>> > handling from my patch scan :)
>>
>> The case when it shouldn't is not handle in fact, didn't think about
>> that :-) As for select, it's another group, if I am not
>> misunderstanding the code, so it will do what the edje tell him to do
>> (raise or lower at the moment) and update accordingly each time. I
>> didn't see any issue during select test case, so I think that I
>> understood that part correctly, just need to fix the "not
>> raising/lowering" case.
>
> select isnt another group - it's a state for the item to be in :) selected
> state (when u click on it and it goes black)

Ah, yes, remembering that. That's why we use 1.0 and 0.0 for all
state, I think that the part Tom did in fact, that why I didn't take
care of it. It just worked :-)
-- 
Cedric BAIL

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] bug fix in _elm_util_mkup_to_text function ~

[Tom Hacohen]

Thanks, though indentation was WAY off. Fixed that.

In svn.

--
Tom.

On Thu, 2011-04-21 at 20:58 +0900, WooHyun Jung wrote:
> Hello. 
> 
> I've found one bug in _elm_util_mkup_to_text function.
> 
> If (!*p) then, it should finish the loop. 
> 
> Thx : ) 
> 
> 
> --
> Benefiting from Server Virtualization: Beyond Initial Workload 
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve 
> application availability and disaster protection. Learn more about boosting 
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] genlist "mode" feature

[Daniel Juyung Seo]

In SVN!

Thanks.
Daniel Juyung Seo (SeoZ)

On Tue, Apr 19, 2011 at 10:05 AM, Daniel Juyung Seo wrote:

> Thanks!
> I'll commit this after seunggyun's patch is committed.
>
> Daniel Juyung Seo (SeoZ)
>
>
> On Mon, Apr 18, 2011 at 7:51 PM, Carsten Haitzler wrote:
>
>> On Mon, 18 Apr 2011 15:18:43 +0900 Daniel Juyung Seo <
>> seojuyu...@gmail.com>
>> said:
>>
>> should i bitch about the little things? :) like stick:
>>
>> +   const char   *mode_type;
>> +   Elm_Genlist_Item *mode_item;
>> +   Ecore_Timer  *scr_hold_timer;
>>
>> next to some other ptrs in the struct. better struct packing (tho yes its
>> after
>> a double so it wont matter in real life - just in principal it matters).
>> actually that's about it. :)
>>
>> no further bitching. i like. +1.
>>
>> > Any suggestion about API or anything?
>> >
>> > According to the youtube video, it looks like this feature is related to
>> the
>> > effect.
>> > So I thought using elm_genlist_item_effect_mode_set() will be fine
>> before.
>> >
>> > But it is not. Because the effect is described in edc.
>> > There is nothing to do with effect in genlist source code.
>> > So I will keep using elm_genlist_item_mode_set() if there is no comment.
>> >
>> > Thanks.
>> > Daniel Juyung Seo (SeoZ)
>> >
>> > On Mon, Apr 18, 2011 at 10:08 AM, Daniel Juyung Seo
>> > wrote:
>> >
>> > > Dear all,
>> > > I introduce a new concept to genlist.
>> > > I named it "genlist mode" after I discussed it with raster.
>> > > Using this feature, one can activate/deactivate any mode(effect) to an
>> > > item.
>> > > The mode is defined in genlist item edc.
>> > >
>> > > You can watch a sample video on youtube.
>> > > http://www.youtube.com/watch?v=ZPbwpzwwiS8
>> > > I created two sample mode: Slide and Rotate.
>> > >
>> > > [Feature Description]
>> > >  - One can activate a specific mode to an item.
>> > >  - One item is activated at one time while others are deactivated.
>> > >  - Genlist handles deactivating other items when one item is
>> activated.
>> > >  - There are two different view: before activated, after activated.
>> > >  - Genlist creates the second view when the first view is activated.
>> > >Usually the first view is animated.
>> > >  - Genlist destroys the second view when the item finishes
>> deactivating.
>> > >  - Creating/Destroying the second view on the fly gives performance
>> > > enhancement because there is no reason to hold all objects in two
>> views all
>> > > the time.
>> > >  - Mode is defined in genlist edc so one can easily add it more.
>> > >  - Mode edc style is separated from normal genlist styles. One can
>> combine
>> > > any genlist style with mode edc style.
>> > >
>> > > [API]
>> > >  - EAPI void elm_genlist_item_mode_set(Elm_Genlist_Item *it, const
>> char
>> > > *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2);
>> > >Activate/Deactivate a mode to an item.
>> > >  - EAPI const char *elm_genlist_mode_get(const Evas_Object *obj)
>> > > EINA_ARG_NONNULL(1);
>> > >Get activated mode name.
>> > >  - EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const
>> Evas_Object
>> > > *obj) EINA_ARG_NONNULL(1);
>> > >Get activated item.
>> > >
>> > > [Structure]
>> > >  - Elm_Genlist_Item
>> > >Added const char *mode_item_style;
>> > >
>> > > [Usage]
>> > >  - Set mode style name to genlist item class.
>> > >itc.mode_item_style = "mode";
>> > >  - Activated mode to an item whenever you want.
>> > >elm_genlist_item_mode_set(it, "slide", EINA_TRUE);
>> > >
>> > > Please review this patch, if there is no issues I will commit this to
>> > > upstream.
>> > > Thanks.
>> > >
>> > > Daniel Juyung Seo (SeoZ)
>> > >
>> > >
>> > >
>> > >
>> --
>> > > Benefiting from Server Virtualization: Beyond Initial Workload
>> > > Consolidation -- Increasing the use of server virtualization is a top
>> > > priority.Virtualization can reduce costs, simplify management, and
>> improve
>> > > application availability and disaster protection. Learn more about
>> boosting
>> > > the value of server virtualization.
>> http://p.sf.net/sfu/vmware-sfdev2dev
>> > > ___
>> > > enlightenment-devel mailing list
>> > > enlightenment-devel@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >
>> > >
>> >
>> --
>> > Benefiting from Server Virtualization: Beyond Initial Workload
>> > Consolidation -- Increasing the use of server virtualization is a top
>> > priority.Virtualization can reduce costs, simplify management, and
>> improve
>> > application availability and disaster protection. Learn more about
>> boosting
>> > the value of server virtualization.
>> http://p.sf.net/sfu/vmware-sfdev2dev
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourcef

[E-devel] [Patch] bug fix in _elm_util_mkup_to_text function ~

[WooHyun Jung]

Hello. 

I've found one bug in _elm_util_mkup_to_text function.

If (!*p) then, it should finish the loop. 

Thx : ) 




elm_util.patch
Description: Binary data
--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[The Rasterman]

On Thu, 21 Apr 2011 11:35:29 +0200 Cedric BAIL  said:

> On Thu, Apr 21, 2011 at 11:32 AM, Carsten Haitzler 
> wrote:
> > On Thu, 21 Apr 2011 10:43:14 +0200 Cedric BAIL  said:
> >> On Thu, Apr 21, 2011 at 10:21 AM, Carsten Haitzler 
> >> wrote:
> >> > On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL 
> >> > said: hmmm but you break stacking in that... now thats fixed odd and
> >> > even... that actually may not be desired :)
> >>
> >> Stacking should not be broken by this patch. Theme can set if even or
> >> odd should be raised and they will. Testing it in elementary_test
> >> genlist 2, show that it is respected and it is working also when
> >> appending or prepending some new items. But maybe you are speaking
> >> about a completly different stuff and because genlist has so much
> >> functionnality, i may have missed it.
> >
> > and if it shouldnt stack at all? if it should raise on select (then lower
> > back to where it was if ti wasn't a raised item) etc? i didn't see that
> > handling from my patch scan :)
> 
> The case when it shouldn't is not handle in fact, didn't think about
> that :-) As for select, it's another group, if I am not
> misunderstanding the code, so it will do what the edje tell him to do
> (raise or lower at the moment) and update accordingly each time. I
> didn't see any issue during select test case, so I think that I
> understood that part correctly, just need to fix the "not
> raising/lowering" case.

select isnt another group - it's a state for the item to be in :) selected
state (when u click on it and it goes black)

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[Cedric BAIL]

On Thu, Apr 21, 2011 at 11:32 AM, Carsten Haitzler  wrote:
> On Thu, 21 Apr 2011 10:43:14 +0200 Cedric BAIL  said:
>> On Thu, Apr 21, 2011 at 10:21 AM, Carsten Haitzler 
>> wrote:
>> > On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL  said:
>> > hmmm but you break stacking in that... now thats fixed odd and even... that
>> > actually may not be desired :)
>>
>> Stacking should not be broken by this patch. Theme can set if even or
>> odd should be raised and they will. Testing it in elementary_test
>> genlist 2, show that it is respected and it is working also when
>> appending or prepending some new items. But maybe you are speaking
>> about a completly different stuff and because genlist has so much
>> functionnality, i may have missed it.
>
> and if it shouldnt stack at all? if it should raise on select (then lower back
> to where it was if ti wasn't a raised item) etc? i didn't see that handling
> from my patch scan :)

The case when it shouldn't is not handle in fact, didn't think about
that :-) As for select, it's another group, if I am not
misunderstanding the code, so it will do what the edje tell him to do
(raise or lower at the moment) and update accordingly each time. I
didn't see any issue during select test case, so I think that I
understood that part correctly, just need to fix the "not
raising/lowering" case.
-- 
Cedric BAIL

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[The Rasterman]

On Thu, 21 Apr 2011 10:43:14 +0200 Cedric BAIL  said:

> On Thu, Apr 21, 2011 at 10:21 AM, Carsten Haitzler 
> wrote:
> > On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL  said:
> > hmmm but you break stacking in that... now thats fixed odd and even... that
> > actually may not be desired :)
> 
> Stacking should not be broken by this patch. Theme can set if even or
> odd should be raised and they will. Testing it in elementary_test
> genlist 2, show that it is respected and it is working also when
> appending or prepending some new items. But maybe you are speaking
> about a completly different stuff and because genlist has so much
> functionnality, i may have missed it.

and if it shouldnt stack at all? if it should raise on select (then lower back
to where it was if ti wasn't a raised item) etc? i didn't see that handling
from my patch scan :)


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] _NET_WM_DESKTOP

[The Rasterman]

On Thu, 21 Apr 2011 10:24:09 +0200 Guillaume Friloux
 said:

as per irc. e could export e17 specific properties and info. as such there is
no NEED for e17 itself to do this. it's a nicety to other tools. i don't think
we need to visit this now, but bring it up again when e17 is in alpha or beta
and we are not busy with other things and we can see about implementing
something that exposes such info.

> I asked the author of xdotool, here is his answer :
> 
> yeah EWMH is pretty crappy at defining desktops
> there's two general schools - desktop array (0, 1, 2, 3, ...)
> or viewports
> where your real "desktop' will be some zillons of pixels, your view on 
> them is just your screen size.
> for example, compiz uses viewports (get_viewport)
> but EWMH doesn't include how to hit what view a window is in
> so you can't query what viewport a window is in
> it's pretty crappy
> 
> 
> So i dont think xdotool will work in e anytime soon.
> 
> On 21/04/2011 09:51, Carsten Haitzler (The Rasterman) wrote:
> > On Mon, 18 Apr 2011 15:55:41 +0300 "Ag. Systems Administrator - Danny"
> >   said:
> >
> >> Hello All,
> >>
> >> $ xdotool get_desktop_for_window 12582925
> >> Your windowmanager claims not to support _NET_WM_DESKTOP, so the attempt to
> >> query a window's desktop location was aborted.
> >>
> >> Strange, as it looks that this functionality is already implemented in
> >> ecore, but not enabled (commented out in e_hints.c, line 68)
> >>
> >> Something must be done/finished to enable this one? ;)
> > e doesnt set the netwm desktop on a window. it actualyl can't support netwm
> > desktop stuff because... e has N SETs of desktops (of XxY screens), one per
> > screen (randr/xinerama screen zone). netwm was (last i looked) insufficient
> > to support e as e has much more info.
> >
> >
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Review] [Patch] Evas - OpenGL and Evas: eng_window_use (Bug Patch)

[The Rasterman]

On Tue, 19 Apr 2011 10:33:07 +0900 "Sung W. Park"  said:

thanks! in svn it is!

> ok, i'm attaching a new patch.
> 
> the patch basically checks to see if the current context is evas' gl context
> and if it is, it'll call evas_gl_common_context_flush().  I think this
> is the proper
> way to go.  :-)
> 
> cheers,
> sung
> 
> On Mon, Apr 18, 2011 at 6:39 PM, Sung W. Park  wrote:
> > well, you're actually right.  I was a little concerned about that aspect but
> > now that you
> > point it out, it makes sense with multiple windows.
> > The real issue is that we have is evas_gl butting in and changing the
> > currrent context that evas isn't aware of.  the proper way to resolve
> > this would be for evas_gl_make_current to do a
> > evass_gl_common_context_flush().
> > the fix was a little hacky i admit..
> > I'll go ahead and fix evas_gl and send another patch.  =)
> > On Mon, Apr 18, 2011 at 3:50 PM, Carsten Haitzler 
> > wrote:
> >>
> >> On Wed, 13 Apr 2011 12:23:22 +0900 "Sung W. Park" 
> >> said:
> >>
> >> that patch seems wrong. if you are changing target window... and you have
> >> a
> >> previous window.. it flushes the gl render queue for the previous window
> >> target
> >> (or if the flush/use of the window) is flushed. you move the flush to
> >> AFTER
> >> setting the new context info (like new surfaces for read/write). that
> >> seems
> >> wrong.
> >>
> >> > Hi all,
> >> >
> >> > I've been toying around with creating a simple GLView smart object that
> >> > allows users do GL rendering simply.  Eventually, I would like to see
> >> > this
> >> > as an Elementary widget called GLView.  The idea behind this is that
> >> > if evas_gl provides the low level stuff, GLView gives the simplified
> >> > user-version.
> >> > I'll start another email thread later on this topic.
> >> >
> >> > The reason why I'm mentioning the above is because while working on
> >> > GLView,
> >> > I've noticed an interesting behavior.  (You can see this by
> >> > compiling/running the
> >> > program that I'm attaching.)  I'm drawing a simple blended Triangle in
> >> > the middle
> >> > of the GLView object and what i'm getting is a smaller inverted red
> >> > triangle
> >> > on the top left corner of the GLView object.  Obviously, something was
> >> > messing
> >> > with the state of my GL code.
> >> >
> >> > I've tracked this issue down to eng_window_use() in evas_x_main.c under
> >> > gl_x11
> >> > module.  In the code,
> >> > _
> >> > void
> >> > eng_window_use(Evas_GL_X11_Window *gw)
> >> > {
> >> >    if ((_evas_gl_x11_window != gw) || (force_use))
> >> >      {
> >> >         if (_evas_gl_x11_window)
> >> >           {
> >> >
> >> >  evas_gl_common_context_use(_evas_gl_x11_window->gl_context);
> >> >
> >> >  evas_gl_common_context_flush(_evas_gl_x11_window->gl_context);
> >> >           }
> >> >       _evas_gl_x11_window = gw;
> >> >        if (gw)
> >> >          {
> >> >        
> >> >        // Make Current Stuff..
> >> > _
> >> >
> >> > I've noticed that evas_gl_common_context_flush() gets called before it
> >> > does
> >> > MakeCurrent().  When the evas_gl_common_context_flush() gets called, it
> >> > resets
> >> > some shader stuff and does GL calls that tell the context to use the
> >> > particular shaders.  This explains why my GLView was picking on what
> >> > seemed
> >> > to be the MVP matrix states that Evas was using.
> >> >
> >> > Instead, what I think should happen is that the flush should be called
> >> > after
> >> > MakeCurrent happens.  Otherwise, you're not guaranteeing that your GL
> >> > calls
> >> > are being applied to the proper context. I've tried that and it seems to
> >> > address the
> >> > problem.
> >> >
> >> > You can try running the glview program that I'm attaching before you
> >> > apply
> >> > the patch and also try running it after you apply the patch.
> >> >
> >> > Let me know if this seems reasonable or I'm missing something somewhere.
> >> >
> >> > Thanks!
> >> >
> >> > cheers,
> >> > Sung
> >>
> >>
> >> --
> >> - Codito, ergo sum - "I code, therefore I am" --
> >> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
> >>
> >
> >


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] _NET_WM_DESKTOP

[Guillaume Friloux]

I asked the author of xdotool, here is his answer :

yeah EWMH is pretty crappy at defining desktops
there's two general schools - desktop array (0, 1, 2, 3, ...)
or viewports
where your real "desktop' will be some zillons of pixels, your view on 
them is just your screen size.

for example, compiz uses viewports (get_viewport)
but EWMH doesn't include how to hit what view a window is in
so you can't query what viewport a window is in
it's pretty crappy


So i dont think xdotool will work in e anytime soon.

On 21/04/2011 09:51, Carsten Haitzler (The Rasterman) wrote:

On Mon, 18 Apr 2011 15:55:41 +0300 "Ag. Systems Administrator - Danny"
  said:


Hello All,

$ xdotool get_desktop_for_window 12582925
Your windowmanager claims not to support _NET_WM_DESKTOP, so the attempt to
query a window's desktop location was aborted.

Strange, as it looks that this functionality is already implemented in
ecore, but not enabled (commented out in e_hints.c, line 68)

Something must be done/finished to enable this one? ;)

e doesnt set the netwm desktop on a window. it actualyl can't support netwm
desktop stuff because... e has N SETs of desktops (of XxY screens), one per
screen (randr/xinerama screen zone). netwm was (last i looked) insufficient to
support e as e has much more info.




<>--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: tasn trunk/evas/src/lib/engines/common

[Daniel Juyung Seo]

Thank you.
That's quite clear.
I just wanted to check the efl coding convention.

Thanks.
Daniel Juyung Seo (SeoZ)

On Thu, Apr 21, 2011 at 4:34 PM, Tom Hacohen <
tom.haco...@partner.samsung.com> wrote:

> Dear Daniel,
>
> One more thing I forgot to refer to:
> The reason I used (index == 0) instead of (!index) is because the former
> is more clear in this case. index == 0 is just a special number, could
> have been index == -1 or whatever, but the point here is that I care
> that the numerical value is something specific. For example, the
> condition if (index), without the negation doesn't make sense in this
> way.
>
> To summarize this up: I use "if (index)" or "if (!index)" only if both
> make sense and I use a specific condition if just one of them does, in
> other words: if the variable makes sense as a boolean.
>
> I hope my thoughts on the matter are clear.
>
> --
> Tom.
>
> On Thu, 2011-04-21 at 07:23 +, Tom Hacohen wrote:
> > Dear Daniel,
> >
> > The guidelines don't enforce either way in this case, and putting curly
> > brackets everywhere is nicer (in my pov) and helps completely preventing
> > dangling ifs.
> >
> > --
> > Tom.
> >
> > On Thu, 2011-04-21 at 14:05 +0900, Daniel Juyung Seo wrote:
> > > Hi Tom.
> > >
> > > +if (index == 0)
> > > +  {
> > > + index = evas_common_font_glyph_search(fn, &fi,
> > > REPLACEMENT_CHAR);
> > > +  }
> > >
> > > Why not this?
> > >
> > > if (!index)
> > >index = evas_common_font_glyph_search(fn, &fi, REPLACEMENT_CHAR);
> > >
> > > Daniel Juyung Seo (SeoZ)
> > >
> > > On Wed, Apr 20, 2011 at 11:20 PM, Enlightenment SVN <
> > > no-re...@enlightenment.org> wrote:
> > >
> > > > Log:
> > > > Evas font-engine: Fix drawing of replacement char when not using
> Harfbuzz.
> > > >
> > > > Author:   tasn
> > > > Date: 2011-04-20 07:20:48 -0700 (Wed, 20 Apr 2011)
> > > > New Revision: 58755
> > > > Trac: http://trac.enlightenment.org/e/changeset/58755
> > > >
> > > > Modified:
> > > >  trunk/evas/src/lib/engines/common/evas_font_draw.c
> > > >
> > > > Modified: trunk/evas/src/lib/engines/common/evas_font_draw.c
> > > > ===
> > > > --- trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20
> 14:16:51
> > > > UTC (rev 58754)
> > > > +++ trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20
> 14:20:48
> > > > UTC (rev 58755)
> > > > @@ -554,6 +554,11 @@
> > > > index =
> > > >evas_common_font_glyph_search(fn, &fi,
> > > > text[EVAS_FONT_WALK_POS]);
> > > >
> > > > +if (index == 0)
> > > > +  {
> > > > + index = evas_common_font_glyph_search(fn, &fi,
> > > > REPLACEMENT_CHAR);
> > > > +  }
> > > > +
> > > > if (fi->src->current_size != fi->size)
> > > >   {
> > > >  FTLOCK();
> > > >
> > > >
> > > >
> > > >
> --
> > > > Benefiting from Server Virtualization: Beyond Initial Workload
> > > > Consolidation -- Increasing the use of server virtualization is a top
> > > > priority.Virtualization can reduce costs, simplify management, and
> improve
> > > > application availability and disaster protection. Learn more about
> boosting
> > > > the value of server virtualization.
> http://p.sf.net/sfu/vmware-sfdev2dev
> > > > ___
> > > > enlightenment-svn mailing list
> > > > enlightenment-...@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> > > >
> > >
> --
> > > Benefiting from Server Virtualization: Beyond Initial Workload
> > > Consolidation -- Increasing the use of server virtualization is a top
> > > priority.Virtualization can reduce costs, simplify management, and
> improve
> > > application availability and disaster protection. Learn more about
> boosting
> > > the value of server virtualization.
> http://p.sf.net/sfu/vmware-sfdev2dev
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
> --
> > Benefiting from Server Virtualization: Beyond Initial Workload
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and
> improve
> > application availability and disaster protection. Learn more about
> boosting
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[Cedric BAIL]

On Thu, Apr 21, 2011 at 10:21 AM, Carsten Haitzler  wrote:
> On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL  said:
> hmmm but you break stacking in that... now thats fixed odd and even... that
> actually may not be desired :)

Stacking should not be broken by this patch. Theme can set if even or
odd should be raised and they will. Testing it in elementary_test
genlist 2, show that it is respected and it is working also when
appending or prepending some new items. But maybe you are speaking
about a completly different stuff and because genlist has so much
functionnality, i may have missed it.
-- 
Cedric BAIL

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_genlist - added new feature : genlist edit mode

[Daniel Juyung Seo]

Dear Seunggyun,
I have some comments.

1) Formatting.
   There are many wrong formatting: indentation, braces, using one line
after if, alignment of function declaration, trailing whitespaces and etc.

2) Exception for selection.
   There are some exception handling code for selection. Is there any reason
to do this?

3) It will be better to move _edit_mode_item_unrealize() above it->realized
= EINA_FALSE;
  Because after unrealizing all instances of that item, we can say the item
is unrealized.

@@ -1917,6 +1934,7 @@ _item_unrealize(Elm_Genlist_Item *it, Eina_Bool ca
 it->states = NULL;
 it->realized = EINA_FALSE;
 it->want_unrealize = EINA_FALSE;
 +   if (it->wd->edit_mode) _edit_mode_item_unrealize(it);
  }

4) Missing braces in if statement.
Unnecessary {, } for one liner.

+   if (it->wd->edit_mode && it->itc->edit_item_style)
+ {
+_edit_mode_item_controls(it, it->scrl_x,
it->scrl_y);
+ }

5) How about 'position' or something else instead of 'controls'?
Just a suggestion, if you mind just leave it :)

>> _edit_mode_item_controls()

6) Why two braces?
   And it's not reasonable check wd->edit_mode inside
_edit_mode_item_realize().
   Because it's not possible to go that line if it's not in an edit mode.

>> if ((it->wd->edit_mode))

7) Just return wd->edit_mode.

>> if (wd->edit_mode) return EINA_TRUE;
>> else return EINA_FALSE;

8) Use !! for Eina_Bool type parameter in EAPIs.

>> wd->edit_mode = edit_mode;
wd->edit_mode = !!edit_mode;

This workarounds application programmer's mistake.

9) How about using elm_genlist_realized_items_get() API?

>> EINA_INLIST_FOREACH(wd->blocks, itb)
>>   {
>> if (itb->realized)
>>   {
>> EINA_LIST_FOREACH(itb->items, l, it)
>>   {
>>  if (it->flags != ELM_GENLIST_ITEM_GROUP && it->realized)


10) Missing braces.

>> if (it->flags != ELM_GENLIST_ITEM_GROUP && it->realized)
if ((it->flags != ELM_GENLIST_ITEM_GROUP) && (it->realized))

There are more of it. Please check all.

11) Use __UNUSED__ for not used parameters.

12) Space between if and (.

>> if(!tit->checked)

13) Fix warnings.
   If you don't have enough warnings, add "-W -Wall -Wextra" to CFLAGS.

14) Seg fault.
   It's not working when I go to "Genlist Edit" menu. It's killed.

Hmm I'm not sure if only I have problems with running genlist edit in
elementary_test.
It has a seg fault.

Other e-developers, please test this.

Thank you.
Daniel Juyung Seo (SeoZ)

On Tue, Apr 19, 2011 at 4:32 PM, Seunggyun Kim wrote:

> Thanks for your review :)
>
> I attached fixed source diff code.
>
> The edit edc is like below table.
> -
> | elm.edit.icon.1 |   elm.swallow.edit.content   |  elm.edit.icon,2
> |
> -
>
> Now it is showing only edit mode set animation.
> If this is committed, I'll send another patch about edit mode unset
> animation.
>
> Thanks:)
>
>
> -Original Message-
> From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com]
> Sent: Monday, April 18, 2011 7:41 PM
> To: Seunggyun Kim
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] [Patch] elm_genlist - added new feature : genlist
> edit mode
>
> On Sat, 16 Apr 2011 17:30:13 +0900 Seunggyun Kim 
> said:
>
> i'm rather happy that i now get to grumble about much more esoteric things
> in
> patches :)
>
> ... why is ediit_mode not Eina_Bool and even better it's together with all
> the
> other Eina_Bool var:1 fields? this leads to much better struct packing.
> saves a
> byte :)
>doublelongpress_timeout;
> +   int   edit_mode;
>  };
>
> why are edit_icon_objs and edit_obj not higher up with pointers like
> Evas_Object *spacer etc.? better struct packing and alignment. :)
> +   Eina_List *edit_icon_objs;
> +   Evas_Object   *edit_obj;
>
>
> bonus space at end before ")" :)
> +if (it->itc->edit_item_style )
>
>
> this looks wrong. default case is item/edit_default but other styles are
> item/stylename. really shouldnt this be like "item/edit/default" and
> "item/edit/stylename".. in fact always item/edit/STYLENAME... ? simpler
> code
> and more consistent and style can provide a simpler stylename not needing
> edit_
> in it... :)
> +   if (it->itc->edit_item_style && strcmp(it->itc->edit_item_style,
> "default"))
> + {
> +strncat(buf, it->itc->edit_item_style, sizeof(buf) - strlen(buf));
> +_elm_theme_object_set(it->base.widget, it->edit_obj, "genlist",
> buf,
> elm_widget_style_get(it->base.widget));
> + }
> +   else
> + {
> +_elm_theme_object_set(it->base.widget, it->edit_obj, "genlist",
> "item/edit_default", elm_widget_style_get(it->base.widget));
> + }
>
> "original_edc" - you should namespace edc partnames "of

Re: [E-devel] [RFC] Switching even/odd inside elementary theme to edje signal

[The Rasterman]

On Wed, 20 Apr 2011 18:13:57 +0200 Cedric BAIL  said:

hmmm but you break stacking in that... now thats fixed odd and even... that
actually may not be desired :)

> Hi,
> 
>Since a long time inserting new item inside a genlist was broken.
> This patch was done by Tom Hacohen and myself, it switch even/odd to
> being a state of your item inside the same edje group and remove the
> need for two separated item. This will also improve ressource usage I
> think. As most of the time even/odd are almost the same object, with
> just different background, so loading two time the same stuff wasn't
> really efficient, this also improve cache reusing by decreasing the
> number of different objects in it.
>Obviously, this break all elementary theme that where using
> odd/even for genlist. They need to have both signal "elm,state,odd"
> and "elm,state,even" implemented to work again when this patch is
> applied. I would like to apply the same change to list and all object
> that do implement even/odd mecanism.
>If nobody mind about this patch, I will apply it friday.
> 
> As always have fun with my breakage :-)
> -- 
> Cedric BAIL


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] evas_filter_software_get() undefined

[The Rasterman]

On Thu, 21 Apr 2011 00:55:41 +1000 Brett Nash  said:

> On Tue, 2011-04-19 at 17:46 +0200, Vincent Torri wrote:
> > Hey
> > 
> > evas_filter_software_get() is used in the engine software_generic but is 
> > not exported (see its declaration i evas_private.h). Hence undef ref on 
> > Windows.
> > 
> > we must add EAPI. In that case, is it reasonable to move the declaration 
> > in evas_common.h ?
> 
> It would be a bit strange to be there: it's really part of the internal
> filter calls, so either leave it, or move it and all the other filter
> calls.
> 
> Otherwise it could be moved in to part of the software engine, and use
> it from there. 
> 
> The latter may be a better call.
> 
> Any other thoughts, I have no particular attachment to it's current
> location to be honest?

really it's ok to be EAPI'd - its a visible symbol, but not in Evas*.h headers
thus not "legal api" :)

>   Regards,
>   nash
> 
> 
> 
> --
> Benefiting from Server Virtualization: Beyond Initial Workload 
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve 
> application availability and disaster protection. Learn more about boosting 
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] _NET_WM_DESKTOP

[The Rasterman]

On Mon, 18 Apr 2011 15:55:41 +0300 "Ag. Systems Administrator - Danny"
 said:

> Hello All,
> 
> $ xdotool get_desktop_for_window 12582925
> Your windowmanager claims not to support _NET_WM_DESKTOP, so the attempt to
> query a window's desktop location was aborted.
> 
> Strange, as it looks that this functionality is already implemented in
> ecore, but not enabled (commented out in e_hints.c, line 68)
> 
> Something must be done/finished to enable this one? ;)

e doesnt set the netwm desktop on a window. it actualyl can't support netwm
desktop stuff because... e has N SETs of desktops (of XxY screens), one per
screen (randr/xinerama screen zone). netwm was (last i looked) insufficient to
support e as e has much more info.


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] NEWS files

[Boris 'billiob' Faure]

Some typos:

> Evas 1.1
Ecore 1.1
>
> Changes since Evas 1.0:
Changes since Ecore 1.0:
> ---
>
> New Features:
>
>     *ecore_x: XRandR backlight support
>
> API Additions:
>
[…]

Clear and simple, I like it.


-- 
Boris 'billiob' Faure

--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] E SVN: tasn trunk/evas/src/lib/engines/common

[Tom Hacohen]

Dear Daniel,

One more thing I forgot to refer to:
The reason I used (index == 0) instead of (!index) is because the former
is more clear in this case. index == 0 is just a special number, could
have been index == -1 or whatever, but the point here is that I care
that the numerical value is something specific. For example, the
condition if (index), without the negation doesn't make sense in this
way.

To summarize this up: I use "if (index)" or "if (!index)" only if both
make sense and I use a specific condition if just one of them does, in
other words: if the variable makes sense as a boolean.

I hope my thoughts on the matter are clear.

--
Tom.

On Thu, 2011-04-21 at 07:23 +, Tom Hacohen wrote:
> Dear Daniel,
> 
> The guidelines don't enforce either way in this case, and putting curly
> brackets everywhere is nicer (in my pov) and helps completely preventing
> dangling ifs.
> 
> --
> Tom.
> 
> On Thu, 2011-04-21 at 14:05 +0900, Daniel Juyung Seo wrote:
> > Hi Tom.
> > 
> > +if (index == 0)
> > +  {
> > + index = evas_common_font_glyph_search(fn, &fi,
> > REPLACEMENT_CHAR);
> > +  }
> > 
> > Why not this?
> > 
> > if (!index)
> >index = evas_common_font_glyph_search(fn, &fi, REPLACEMENT_CHAR);
> > 
> > Daniel Juyung Seo (SeoZ)
> > 
> > On Wed, Apr 20, 2011 at 11:20 PM, Enlightenment SVN <
> > no-re...@enlightenment.org> wrote:
> > 
> > > Log:
> > > Evas font-engine: Fix drawing of replacement char when not using Harfbuzz.
> > >
> > > Author:   tasn
> > > Date: 2011-04-20 07:20:48 -0700 (Wed, 20 Apr 2011)
> > > New Revision: 58755
> > > Trac: http://trac.enlightenment.org/e/changeset/58755
> > >
> > > Modified:
> > >  trunk/evas/src/lib/engines/common/evas_font_draw.c
> > >
> > > Modified: trunk/evas/src/lib/engines/common/evas_font_draw.c
> > > ===
> > > --- trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20 
> > > 14:16:51
> > > UTC (rev 58754)
> > > +++ trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20 
> > > 14:20:48
> > > UTC (rev 58755)
> > > @@ -554,6 +554,11 @@
> > > index =
> > >evas_common_font_glyph_search(fn, &fi,
> > > text[EVAS_FONT_WALK_POS]);
> > >
> > > +if (index == 0)
> > > +  {
> > > + index = evas_common_font_glyph_search(fn, &fi,
> > > REPLACEMENT_CHAR);
> > > +  }
> > > +
> > > if (fi->src->current_size != fi->size)
> > >   {
> > >  FTLOCK();
> > >
> > >
> > >
> > > --
> > > Benefiting from Server Virtualization: Beyond Initial Workload
> > > Consolidation -- Increasing the use of server virtualization is a top
> > > priority.Virtualization can reduce costs, simplify management, and improve
> > > application availability and disaster protection. Learn more about 
> > > boosting
> > > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > > ___
> > > enlightenment-svn mailing list
> > > enlightenment-...@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> > >
> > --
> > Benefiting from Server Virtualization: Beyond Initial Workload 
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and improve 
> > application availability and disaster protection. Learn more about boosting 
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 
> 
> 
> --
> Benefiting from Server Virtualization: Beyond Initial Workload 
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve 
> application availability and disaster protection. Learn more about boosting 
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sf

Re: [E-devel] E SVN: tasn trunk/evas/src/lib/engines/common

[Tom Hacohen]

Dear Daniel,

The guidelines don't enforce either way in this case, and putting curly
brackets everywhere is nicer (in my pov) and helps completely preventing
dangling ifs.

--
Tom.

On Thu, 2011-04-21 at 14:05 +0900, Daniel Juyung Seo wrote:
> Hi Tom.
> 
> +if (index == 0)
> +  {
> + index = evas_common_font_glyph_search(fn, &fi,
> REPLACEMENT_CHAR);
> +  }
> 
> Why not this?
> 
> if (!index)
>index = evas_common_font_glyph_search(fn, &fi, REPLACEMENT_CHAR);
> 
> Daniel Juyung Seo (SeoZ)
> 
> On Wed, Apr 20, 2011 at 11:20 PM, Enlightenment SVN <
> no-re...@enlightenment.org> wrote:
> 
> > Log:
> > Evas font-engine: Fix drawing of replacement char when not using Harfbuzz.
> >
> > Author:   tasn
> > Date: 2011-04-20 07:20:48 -0700 (Wed, 20 Apr 2011)
> > New Revision: 58755
> > Trac: http://trac.enlightenment.org/e/changeset/58755
> >
> > Modified:
> >  trunk/evas/src/lib/engines/common/evas_font_draw.c
> >
> > Modified: trunk/evas/src/lib/engines/common/evas_font_draw.c
> > ===
> > --- trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20 14:16:51
> > UTC (rev 58754)
> > +++ trunk/evas/src/lib/engines/common/evas_font_draw.c  2011-04-20 14:20:48
> > UTC (rev 58755)
> > @@ -554,6 +554,11 @@
> > index =
> >evas_common_font_glyph_search(fn, &fi,
> > text[EVAS_FONT_WALK_POS]);
> >
> > +if (index == 0)
> > +  {
> > + index = evas_common_font_glyph_search(fn, &fi,
> > REPLACEMENT_CHAR);
> > +  }
> > +
> > if (fi->src->current_size != fi->size)
> >   {
> >  FTLOCK();
> >
> >
> >
> > --
> > Benefiting from Server Virtualization: Beyond Initial Workload
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and improve
> > application availability and disaster protection. Learn more about boosting
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> --
> Benefiting from Server Virtualization: Beyond Initial Workload 
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve 
> application availability and disaster protection. Learn more about boosting 
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel



--
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel