[EGIT] [core/efl] master 01/01: evas/textblock: Remove null statement.
stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=642e4293fff1713b1ade7c112c5088d11d4a31ff
commit 642e4293fff1713b1ade7c112c5088d11d4a31ff
Author: Stefan Schmidt s.schm...@samsung.com
Date: Mon Sep 30 09:48:34 2013 +0100
evas/textblock: Remove null statement.
---
src/lib/evas/canvas/evas_object_textblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/evas/canvas/evas_object_textblock.c
b/src/lib/evas/canvas/evas_object_textblock.c
index 37bd6a3..291ef8e 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -1939,7 +1939,7 @@ _format_command(Evas_Object *eo_obj,
Evas_Object_Textblock_Format *fmt, const ch
!strcmp(underlines_named[i].param, param))
{
fmt-underline = underlines_named[i].underline;
- fmt-underline2 = underlines_named[i].underline2;;
+ fmt-underline2 = underlines_named[i].underline2;
fmt-underline_dash = underlines_named[i].underline_dash;
break;
}
--
[E-devel] arc patch error
Hello all, this is Daniel Juyung Seo. When trying to fetch phab patches to my local git, I faced ERR-CONDUIT-CORE error like below. $ arc patch --nobranch D246 Exception ERR-CONDUIT-CORE: You can not access the user inside the implementation of a Conduit method which does not require authentication (as per shouldRequireAuthentication()). (Run with --trace for a full exception trace.) I reset my arc authentication key but still got the same error. Also updated arcanist and libphutil but it didn't help. This hapens to other as well. Anybody has any idea about that? Thanks. Daniel Juyung Seo (SeoZ) -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] test_calendar.c: fix a typo
Previous seconds value for a day was 84600 (23:30) instead of 86400 (24:00).
The commit fixes it using constants.
---
src/bin/test_calendar.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/src/bin/test_calendar.c b/src/bin/test_calendar.c
index f3b7ee3..3bd82cf 100644
--- a/src/bin/test_calendar.c
+++ b/src/bin/test_calendar.c
@@ -21,6 +21,9 @@ enum _api_state
};
typedef enum _api_state api_state;
+#define SEC_PER_DAY 24 * 60 * 60
+#define SEC_PER_YEAR 365 * SEC_PER_DAY
+
static void
set_api_state(api_data *api)
{
@@ -34,9 +37,7 @@ set_api_state(api_data *api)
case STATE_MARK_MONTHLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9); /*
Set date to DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9); /*
Set date to DEC 31, 2010 */
elm_calendar_min_max_year_set(cal, 2010, 2011);
m = elm_calendar_mark_add(cal, checked, gmtime(the_time),
ELM_CALENDAR_MONTHLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -45,9 +46,7 @@ set_api_state(api_data *api)
case STATE_MARK_WEEKLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 4); /*
Set date to DEC 26, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 4); /*
Set date to DEC 26, 2010 */
elm_calendar_mark_del(m);
m = elm_calendar_mark_add(cal, checked, gmtime(the_time),
ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -56,9 +55,7 @@ set_api_state(api_data *api)
case STATE_SUNDAY_HIGHLIGHT:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 3); /*
Set date to DEC 25, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 3); /*
Set date to DEC 25, 2010 */
/* elm_calendar_mark_del(m); */
m = elm_calendar_mark_add(cal, holiday, gmtime(the_time),
ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -67,9 +64,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_WITH_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 10); /*
Set date to JAN 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 10); /*
Set date to JAN 01, 2011 */
elm_calendar_select_mode_set(cal, ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
}
@@ -77,9 +72,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_NO_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 40); /*
Set date to FEB 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 40); /*
Set date to FEB 01, 2011 */
elm_calendar_marks_clear(cal);
elm_calendar_select_mode_set(cal, ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -148,9 +141,7 @@ test_calendar(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *event_
evas_object_size_hint_weight_set(cal, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_box_pack_end(bx, cal);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9); /* Set date to
DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9); /* Set date to
DEC 31, 2010 */
elm_calendar_selected_time_set(cal, gmtime(the_time));
elm_calendar_min_max_year_set(cal, 2010, 2012);
@@ -268,10 +259,10 @@ test_calendar2(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *event
cal3 = elm_calendar_add(win);
evas_object_size_hint_weight_set(cal3, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(cal3, EVAS_HINT_FILL, EVAS_HINT_FILL);
- current_time = time(NULL) + 34 * 84600;
+ current_time = time(NULL) + 34 * SEC_PER_DAY;
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
Hello.
The change summary is a bit weak. Its not really a typo fix but a fix
for the wrong numbers of seconds a day. I changed it to:
test_calendar: Fix number of seconds per day.
Hope you don't mind.
On 09/30/2013 11:39 AM, Mariusz Bialonczyk wrote:
Previous seconds value for a day was 84600 (23:30) instead of 86400
(24:00).
Thats the famous Bruno Dilly 23.5h day. Never heard of it?
Pushed, thanks a lot.
regards
Stefan Schmidt
The commit fixes it using constants.
---
src/bin/test_calendar.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/src/bin/test_calendar.c b/src/bin/test_calendar.c
index f3b7ee3..3bd82cf 100644
--- a/src/bin/test_calendar.c
+++ b/src/bin/test_calendar.c
@@ -21,6 +21,9 @@ enum _api_state
};
typedef enum _api_state api_state;
+#define SEC_PER_DAY 24 * 60 * 60
+#define SEC_PER_YEAR 365 * SEC_PER_DAY
+
static void
set_api_state(api_data *api)
{
@@ -34,9 +37,7 @@ set_api_state(api_data *api)
case STATE_MARK_MONTHLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9);
/* Set date to DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9);
/* Set date to DEC 31, 2010 */
elm_calendar_min_max_year_set(cal, 2010, 2011);
m = elm_calendar_mark_add(cal, checked,
gmtime(the_time), ELM_CALENDAR_MONTHLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -45,9 +46,7 @@ set_api_state(api_data *api)
case STATE_MARK_WEEKLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 4);
/* Set date to DEC 26, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 4);
/* Set date to DEC 26, 2010 */
elm_calendar_mark_del(m);
m = elm_calendar_mark_add(cal, checked,
gmtime(the_time), ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -56,9 +55,7 @@ set_api_state(api_data *api)
case STATE_SUNDAY_HIGHLIGHT:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 3);
/* Set date to DEC 25, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 3);
/* Set date to DEC 25, 2010 */
/* elm_calendar_mark_del(m); */
m = elm_calendar_mark_add(cal, holiday,
gmtime(the_time), ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -67,9 +64,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_WITH_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 10);
/* Set date to JAN 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 10);
/* Set date to JAN 01, 2011 */
elm_calendar_select_mode_set(cal,
ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
}
@@ -77,9 +72,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_NO_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 40);
/* Set date to FEB 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 40);
/* Set date to FEB 01, 2011 */
elm_calendar_marks_clear(cal);
elm_calendar_select_mode_set(cal,
ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -148,9 +141,7 @@ test_calendar(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *event_
evas_object_size_hint_weight_set(cal, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
elm_box_pack_end(bx, cal);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9); /* Set date
to DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9); /* Set date
to DEC 31, 2010 */
elm_calendar_selected_time_set(cal, gmtime(the_time));
[EGIT] [core/elementary] master 02/02: elm_calendar: Fix wrong seconds per day also in comments.
stefan pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=213db71206e11a475f37d202c763c8a05e3a9c62 commit 213db71206e11a475f37d202c763c8a05e3a9c62 Author: Stefan Schmidt s.schm...@samsung.com Date: Mon Sep 30 13:31:23 2013 +0100 elm_calendar: Fix wrong seconds per day also in comments. Better fix it here as well before the 23.5h day spreads further and we are getting all out of sync. :) --- src/lib/elm_calendar_legacy.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elm_calendar_legacy.h b/src/lib/elm_calendar_legacy.h index 804a593..1dad047 100644 --- a/src/lib/elm_calendar_legacy.h +++ b/src/lib/elm_calendar_legacy.h @@ -211,12 +211,12 @@ EAPI void elm_calendar_format_function_set(Evas_Object *obj, Elm * struct tm selected_time; * time_t current_time; * - * current_time = time(NULL) + 5 * 84600; + * current_time = time(NULL) + 5 * (24 * 60 * 60); * localtime_r(current_time, selected_time); * elm_calendar_mark_add(cal, holiday, selected_time, * ELM_CALENDAR_ANNUALLY); * - * current_time = time(NULL) + 1 * 84600; + * current_time = time(NULL) + 1 * (24 * 60 * 60); * localtime_r(current_time, selected_time); * elm_calendar_mark_add(cal, checked, selected_time, ELM_CALENDAR_UNIQUE); * --
[EGIT] [core/elementary] master 01/02: test_calendar: Fix number of seconds per day.
stefan pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=144734972ad848b3e3516ddf47233b741b42dc16
commit 144734972ad848b3e3516ddf47233b741b42dc16
Author: Mariusz Bialonczyk ma...@skyboo.net
Date: Mon Sep 30 11:39:34 2013 +0100
test_calendar: Fix number of seconds per day.
Previous seconds value for a day was 84600 (23:30) instead of 86400
(24:00).
The commit fixes it using constants.
---
src/bin/test_calendar.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/src/bin/test_calendar.c b/src/bin/test_calendar.c
index f3b7ee3..3bd82cf 100644
--- a/src/bin/test_calendar.c
+++ b/src/bin/test_calendar.c
@@ -21,6 +21,9 @@ enum _api_state
};
typedef enum _api_state api_state;
+#define SEC_PER_DAY 24 * 60 * 60
+#define SEC_PER_YEAR 365 * SEC_PER_DAY
+
static void
set_api_state(api_data *api)
{
@@ -34,9 +37,7 @@ set_api_state(api_data *api)
case STATE_MARK_MONTHLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9); /*
Set date to DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9); /*
Set date to DEC 31, 2010 */
elm_calendar_min_max_year_set(cal, 2010, 2011);
m = elm_calendar_mark_add(cal, checked, gmtime(the_time),
ELM_CALENDAR_MONTHLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -45,9 +46,7 @@ set_api_state(api_data *api)
case STATE_MARK_WEEKLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 4); /*
Set date to DEC 26, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 4); /*
Set date to DEC 26, 2010 */
elm_calendar_mark_del(m);
m = elm_calendar_mark_add(cal, checked, gmtime(the_time),
ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -56,9 +55,7 @@ set_api_state(api_data *api)
case STATE_SUNDAY_HIGHLIGHT:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 3); /*
Set date to DEC 25, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 3); /*
Set date to DEC 25, 2010 */
/* elm_calendar_mark_del(m); */
m = elm_calendar_mark_add(cal, holiday, gmtime(the_time),
ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -67,9 +64,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_WITH_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 10); /*
Set date to JAN 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 10); /*
Set date to JAN 01, 2011 */
elm_calendar_select_mode_set(cal, ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
}
@@ -77,9 +72,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_NO_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 40); /*
Set date to FEB 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 40); /*
Set date to FEB 01, 2011 */
elm_calendar_marks_clear(cal);
elm_calendar_select_mode_set(cal, ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -148,9 +141,7 @@ test_calendar(void *data EINA_UNUSED, Evas_Object *obj
EINA_UNUSED, void *event_
evas_object_size_hint_weight_set(cal, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_box_pack_end(bx, cal);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9); /* Set date to
DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9); /* Set date to
DEC 31, 2010 */
elm_calendar_selected_time_set(cal, gmtime(the_time));
elm_calendar_min_max_year_set(cal, 2010, 2012);
@@ -268,10 +259,10 @@ test_calendar2(void *data EINA_UNUSED,
[E-devel] Weekly news from the automated build and QA front
Hello. *** Newsflash *** New research paper unvails that looking at potential problems early in the development and release process cuts down time spent on debugging aftterwards. Suggestions have been made that developers should have a look at these potential problems and either fix them or mark as incorrect. *** This should give everyone an overview over what has happened in the last week regarding our continuous integration builds, unit tests and coverage as well as all static analyser runs and things like address-sanitizer. The numbers in parentheses reflect the values from last week to give you a trend. CI: o Overall build statistic: 4.51% (4.44%) failed and 95.49% (95.56%) succeeded. https://build.enlightenment.org/ clang scan-build: o EFL scan-build reports 507 (517) issues. https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfu lBuild/artifact/scan-build/build/ Exactness: o The edje exactness builds are working now. Elm exactness still failing. o Problems with icons and paths (file selector widget) o Still waiting for the first successful run on jenkins Unit tests: o 271 (271) unit tests for efl and none failing Coverage: o EFL total coverage is at 25.7% (25.7%) lines and 28.5% (28.5%) functions https://build.enlightenment.org/view/Test%20Coverage/ Coverity: o EFL: Outstanding defects 455 (449) with a density of 0.86 (0.85). 2 defects fixed since last build and 8 added. o Elm: Outstanding defects 22 (21) with a density of 0.10 (0.09). 0 defects fixed since last build and 1 added. o E: Outstanding defects 202 (198) with a density of 0.72 (0.71). 0 defects fixed since last build and 4 added. If anybody wants to see something added here let me know and be my guest. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Weekly news from the automated build and QA front
On 13-09-30 13:46, Stefan Schmidt wrote: Hello. *** Newsflash *** New research paper unvails that looking at potential problems early in the development and release process cuts down time spent on debugging aftterwards. Suggestions have been made that developers should have a look at these potential problems and either fix them or mark as incorrect. *** I do agree with that statement. Coverity: o EFL: Outstanding defects 455 (449) with a density of 0.86 (0.85). 2 defects fixed since last build and 8 added. o Elm: Outstanding defects 22 (21) with a density of 0.10 (0.09). 0 defects fixed since last build and 1 added. o E: Outstanding defects 202 (198) with a density of 0.72 (0.71). 0 defects fixed since last build and 4 added. Could you test terminology? I won't be able to look into such reports before long, maybe not even before the EFL dev day but I'd like to have them in the near future. Thank you for your work. -- Boris Faure Pointer Arithmetician -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Weekly news from the automated build and QA front
Hello. On 09/30/2013 01:58 PM, Boris Faure wrote: On 13-09-30 13:46, Stefan Schmidt wrote: Hello. *** Newsflash *** New research paper unvails that looking at potential problems early in the development and release process cuts down time spent on debugging aftterwards. Suggestions have been made that developers should have a look at these potential problems and either fix them or mark as incorrect. *** I do agree with that statement. :) Coverity: o EFL: Outstanding defects 455 (449) with a density of 0.86 (0.85). 2 defects fixed since last build and 8 added. o Elm: Outstanding defects 22 (21) with a density of 0.10 (0.09). 0 defects fixed since last build and 1 added. o E: Outstanding defects 202 (198) with a density of 0.72 (0.71). 0 defects fixed since last build and 4 added. Could you test terminology? I won't be able to look into such reports before long, maybe not even before the EFL dev day but I'd like to have them in the near future. Added it to my todo list. Hopefully I will have it ready for the next Monday run. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
Thanks Mariusz Bialonczyk for your patch.
As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix.
Btw Mariusz, can you raise a patch with phabricator + arcanist next time?
https://phab.enlightenment.org/w/arcanist/
It's easy and quick to submit a patch than writing an email.
You can get a review and feedback as well from the system line by line
easily.
Thanks.
Daniel Juyung Seo (SeoZ)
On Mon, Sep 30, 2013 at 9:30 PM, Stefan Schmidt s.schm...@samsung.comwrote:
Hello.
The change summary is a bit weak. Its not really a typo fix but a fix
for the wrong numbers of seconds a day. I changed it to:
test_calendar: Fix number of seconds per day.
Hope you don't mind.
On 09/30/2013 11:39 AM, Mariusz Bialonczyk wrote:
Previous seconds value for a day was 84600 (23:30) instead of 86400
(24:00).
Thats the famous Bruno Dilly 23.5h day. Never heard of it?
Pushed, thanks a lot.
regards
Stefan Schmidt
The commit fixes it using constants.
---
src/bin/test_calendar.c | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/src/bin/test_calendar.c b/src/bin/test_calendar.c
index f3b7ee3..3bd82cf 100644
--- a/src/bin/test_calendar.c
+++ b/src/bin/test_calendar.c
@@ -21,6 +21,9 @@ enum _api_state
};
typedef enum _api_state api_state;
+#define SEC_PER_DAY 24 * 60 * 60
+#define SEC_PER_YEAR 365 * SEC_PER_DAY
+
static void
set_api_state(api_data *api)
{
@@ -34,9 +37,7 @@ set_api_state(api_data *api)
case STATE_MARK_MONTHLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 9);
/* Set date to DEC 31, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 9);
/* Set date to DEC 31, 2010 */
elm_calendar_min_max_year_set(cal, 2010, 2011);
m = elm_calendar_mark_add(cal, checked,
gmtime(the_time), ELM_CALENDAR_MONTHLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -45,9 +46,7 @@ set_api_state(api_data *api)
case STATE_MARK_WEEKLY:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 4);
/* Set date to DEC 26, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 4);
/* Set date to DEC 26, 2010 */
elm_calendar_mark_del(m);
m = elm_calendar_mark_add(cal, checked,
gmtime(the_time), ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -56,9 +55,7 @@ set_api_state(api_data *api)
case STATE_SUNDAY_HIGHLIGHT:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day * 3);
/* Set date to DEC 25, 2010 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY * 3);
/* Set date to DEC 25, 2010 */
/* elm_calendar_mark_del(m); */
m = elm_calendar_mark_add(cal, holiday,
gmtime(the_time), ELM_CALENDAR_WEEKLY);
elm_calendar_selected_time_set(cal, gmtime(the_time));
@@ -67,9 +64,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_WITH_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day *
10);
/* Set date to JAN 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY *
10);
/* Set date to JAN 01, 2011 */
elm_calendar_select_mode_set(cal,
ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal, gmtime(the_time));
}
@@ -77,9 +72,7 @@ set_api_state(api_data *api)
case STATE_SELECT_DATE_DISABLED_NO_MARKS:
{
Evas_Object *cal = eina_list_nth(items, 0);
- time_t sec_per_day = (60*60*24);
- time_t sec_per_year = sec_per_day * 365;
- time_t the_time = (sec_per_year * 41) + (sec_per_day *
40);
/* Set date to FEB 01, 2011 */
+ time_t the_time = (SEC_PER_YEAR * 41) + (SEC_PER_DAY *
40);
/* Set date to FEB 01, 2011 */
elm_calendar_marks_clear(cal);
elm_calendar_select_mode_set(cal,
ELM_CALENDAR_SELECT_MODE_NONE);
elm_calendar_selected_time_set(cal,
[EGIT] [core/elementary] master 01/03: elm_index.c: Internal refactoring. Removed unnecessary internal function parameters.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=bf84ffd3bddcff0305fe385dab95efef52346275
commit bf84ffd3bddcff0305fe385dab95efef52346275
Author: Daniel Juyung Seo seojuyu...@gmail.com
Date: Mon Sep 30 19:12:50 2013 +0900
elm_index.c: Internal refactoring. Removed unnecessary internal function
parameters.
- _index_box_clear()
- _index_box_auto_fill()
---
src/lib/elm_index.c | 54 ++---
1 file changed, 26 insertions(+), 28 deletions(-)
diff --git a/src/lib/elm_index.c b/src/lib/elm_index.c
index 7b64c6b..9a56e68 100644
--- a/src/lib/elm_index.c
+++ b/src/lib/elm_index.c
@@ -69,7 +69,6 @@ _box_custom_layout(Evas_Object *o,
static void
_index_box_clear(Evas_Object *obj,
- Evas_Object *box __UNUSED__,
int level)
{
Eina_List *l;
@@ -201,7 +200,6 @@ _omit_calc(void *data, int num_of_items, int
max_num_of_items)
// FIXME: always have index filled
static void
_index_box_auto_fill(Evas_Object *obj,
- Evas_Object *box,
int level)
{
int i = 0, max_num_of_items = 0, num_of_items = 0, g = 0, skip = 0;
@@ -303,7 +301,7 @@ _index_box_auto_fill(Evas_Object *obj,
evas_object_size_hint_weight_set(o, EVAS_HINT_EXPAND,
EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(o, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_widget_sub_object_add(obj, o);
-evas_object_box_append(box, o);
+evas_object_box_append(sd-bx[level], o);
stacking = edje_object_data_get(o, stacking);
if (stacking)
@@ -323,7 +321,7 @@ _index_box_auto_fill(Evas_Object *obj,
_access_widget_item_register(it);
}
- evas_object_smart_calculate(box);
+ evas_object_smart_calculate(sd-bx[level]);
sd-level_active[level] = EINA_TRUE;
}
@@ -341,8 +339,8 @@ _elm_index_smart_theme(Eo *obj, void *_pd, va_list *list)
Elm_Widget_Smart_Data *wd = eo_data_scope_get(obj, ELM_OBJ_WIDGET_CLASS);
Elm_Layout_Smart_Data *ld = eo_data_scope_get(obj, ELM_OBJ_LAYOUT_CLASS);
- _index_box_clear(obj, sd-bx[0], 0);
- _index_box_clear(obj, sd-bx[1], 1);
+ _index_box_clear(obj, 0);
+ _index_box_clear(obj, 1);
if (sd-horizontal)
eina_stringshare_replace(ld-group, base/horizontal);
@@ -393,11 +391,11 @@ _elm_index_smart_theme(Eo *obj, void *_pd, va_list *list)
edje_object_message_signal_process(wd-resize_obj);
elm_layout_sizing_eval(obj);
- _index_box_auto_fill(obj, sd-bx[0], 0);
+ _index_box_auto_fill(obj, 0);
if (sd-autohide_disabled)
{
-if (sd-level == 1) _index_box_auto_fill(obj, sd-bx[1], 1);
+if (sd-level == 1) _index_box_auto_fill(obj, 1);
elm_layout_signal_emit(obj, elm,state,active, elm);
}
else elm_layout_signal_emit(obj, elm,state,inactive, elm);
@@ -436,7 +434,7 @@ _item_del_pre_hook(Elm_Object_Item *it)
ELM_INDEX_DATA_GET(WIDGET(it), sd);
_item_free((Elm_Index_Item *)it);
- _index_box_clear(WIDGET(it), sd-bx[sd-level], sd-level);
+ _index_box_clear(WIDGET(it), sd-level);
return EINA_TRUE;
}
@@ -714,7 +712,7 @@ _on_mouse_down(void *data,
sd-dy = ev-canvas.y - y;
if (!sd-autohide_disabled)
{
-_index_box_clear(data, sd-bx[1], 1);
+_index_box_clear(data, 1);
elm_layout_signal_emit(data, elm,state,active, elm);
}
_sel_eval(data, ev-canvas.x, ev-canvas.y);
@@ -818,7 +816,7 @@ _on_mouse_in_access(void *data,
if (!sd-autohide_disabled)
{
-_index_box_clear(data, sd-bx[1], 1);
+_index_box_clear(data, 1);
elm_layout_signal_emit(data, elm,state,active, elm);
}
}
@@ -884,8 +882,8 @@ _index_resize_cb(void *data,
Elm_Index_Item *it;
- _index_box_clear(data, sd-bx[0], 0);
- _index_box_auto_fill(data, sd-bx[0], 0);
+ _index_box_clear(data, 0);
+ _index_box_auto_fill(data, 0);
it = (Elm_Index_Item *)elm_index_selected_item_get(obj, sd-level);
if (it)
@@ -1144,7 +1142,7 @@ _autohide_disabled_set(Eo *obj, void *_pd, va_list *list)
sd-level = 0;
if (sd-autohide_disabled)
{
-_index_box_clear(obj, sd-bx[1], 1);
+_index_box_clear(obj, 1);
elm_layout_signal_emit(obj, elm,state,active, elm);
}
else
@@ -1318,7 +1316,7 @@ _item_append(Eo *obj, void *_pd, va_list *list)
if (!it) return;
sd-items = eina_list_append(sd-items, it);
- _index_box_clear(obj, sd-bx[sd-level], sd-level);
+ _index_box_clear(obj, sd-level);
*ret = (Elm_Object_Item *)it;
}
@@ -1352,7 +1350,7 @@ _item_prepend(Eo *obj, void *_pd, va_list *list)
if (!it) return;
sd-items = eina_list_prepend(sd-items, it);
- _index_box_clear(obj, sd-bx[sd-level], sd-level);
+ _index_box_clear(obj, sd-level);
*ret = (Elm_Object_Item *)it;
}
@@ -1404,7 +1402,7 @@ _item_insert_after(Eo *obj, void *_pd, va_list *list)
if (!it) return;
[EGIT] [core/elementary] master 03/03: elc_naviframe.c: Check value before dereferencing it.
seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=0fb7dd08ce639f4c709822b58b6078c8187e9e7a
commit 0fb7dd08ce639f4c709822b58b6078c8187e9e7a
Author: Daniel Juyung Seo seojuyu...@gmail.com
Date: Mon Sep 30 22:16:34 2013 +0900
elc_naviframe.c: Check value before dereferencing it.
This fixes coverity CID 1099698.
---
src/lib/elc_naviframe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c
index 5de3af5..5dfd289 100644
--- a/src/lib/elc_naviframe.c
+++ b/src/lib/elc_naviframe.c
@@ -1283,7 +1283,7 @@ _elm_naviframe_smart_focus_next(Eo *obj, void *_pd
EINA_UNUSED, va_list *list)
if (ret) *ret = int_ret;
end:
- if (!*ret)
+ if (ret !*ret)
{
*next = obj;
*ret = !elm_widget_focus_get(obj);
--
Re: [E-devel] [EGIT] [core/elementary] master 02/03: elm: Longwaited trailing white space removal. Clean elm up!
whatisthisidonteven.jpg http://haugom.tk/wp-content/uploads/2013/08/what+is+this+I+don+t+even+_e6935e220e54cbbdf5685ce5d569e210.jpg On Mon, Sep 30, 2013 at 2:16 PM, Daniel Juyung Seo seojuyu...@gmail.comwrote: seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=f0d4a6fe6e98d47a902353a34e0e4f905b0fa51d commit f0d4a6fe6e98d47a902353a34e0e4f905b0fa51d Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Mon Sep 30 19:21:31 2013 +0900 elm: Longwaited trailing white space removal. Clean elm up! --- src/bin/quicklaunch.c | 6 +- src/bin/run.c | 14 +-- src/bin/test_bg.c | 2 +- src/bin/test_button.c | 2 +- src/bin/test_external.c| 2 +- src/bin/test_focus.c | 16 ++-- src/bin/test_genlist.c | 6 +- src/bin/test_glview.c | 4 +- src/bin/test_index.c | 4 +- src/bin/test_prefs.c | 2 +- src/bin/test_segment_control.c | 6 +- src/bin/test_video.c | 2 +- src/bin/test_win_plug.c| 2 +- src/lib/elc_multibuttonentry.c | 10 +- src/lib/elc_naviframe.c| 2 +- src/lib/elc_player.c | 18 ++-- src/lib/elm_calendar.c | 4 +- src/lib/elm_cnp.c | 192 ++--- src/lib/elm_colorselector.c| 32 +++ src/lib/elm_config.c | 14 +-- src/lib/elm_datetime.c | 10 +- src/lib/elm_entry.c| 8 +- src/lib/elm_flip.c | 2 +- src/lib/elm_flipselector.c | 4 +- src/lib/elm_genlist.c | 10 +- src/lib/elm_image.c| 2 +- src/lib/elm_interface_scrollable.c | 6 +- src/lib/elm_module.c | 2 +- src/lib/elm_panel.c| 12 +-- src/lib/elm_prefs_data.c | 6 +- src/lib/elm_slider.c | 6 +- src/lib/elm_url.c | 2 +- src/lib/elm_util.c | 2 +- src/lib/elm_widget.c | 2 +- src/lib/elm_win.c | 22 ++--- src/lib/els_cursor.c | 2 +- 36 files changed, 219 insertions(+), 219 deletions(-) -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote: Thanks Mariusz Bialonczyk for your patch. As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix. Btw Mariusz, can you raise a patch with phabricator + arcanist next time? https://phab.enlightenment.org/w/arcanist/ It was me who told him to use git format-patch and send it via mail. It's easy and quick to submit a patch than writing an email. You really think that? Given you have to install php, a new tool and learn it also. And also given you just mailed to the list with a problem using it :) I also think its quite unlikely that people would jump through all the hops for one patch. If they plan on more and trying to become a real commiter that might be worth the time but for only one patch I daubt it. You can get a review and feedback as well from the system line by line easily. That is indeed a nice thing. But I have to say I find the whole workflow quite arkward. But maybe it only me being used to patches and review on the ml. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Weekly news from the automated build and QA front
On Mon, Sep 30, 2013 at 9:46 PM, Stefan Schmidt s.schm...@samsung.comwrote: Hello. *** Newsflash *** New research paper unvails that looking at potential problems early in the development and release process cuts down time spent on debugging aftterwards. Suggestions have been made that developers should have a look at these potential problems and either fix them or mark as incorrect. *** This should give everyone an overview over what has happened in the last week regarding our continuous integration builds, unit tests and coverage as well as all static analyser runs and things like address-sanitizer. The numbers in parentheses reflect the values from last week to give you a trend. CI: o Overall build statistic: 4.51% (4.44%) failed and 95.49% (95.56%) succeeded. https://build.enlightenment.org/ clang scan-build: o EFL scan-build reports 507 (517) issues. https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfu lBuild/artifact/scan-build/build/ Exactness: o The edje exactness builds are working now. Elm exactness still failing. o Problems with icons and paths (file selector widget) o Still waiting for the first successful run on jenkins Unit tests: o 271 (271) unit tests for efl and none failing Coverage: o EFL total coverage is at 25.7% (25.7%) lines and 28.5% (28.5%) functions https://build.enlightenment.org/view/Test%20Coverage/ Coverity: o EFL: Outstanding defects 455 (449) with a density of 0.86 (0.85). 2 defects fixed since last build and 8 added. Thanks as always. o Elm: Outstanding defects 22 (21) with a density of 0.10 (0.09). 0 defects fixed since last build and 1 added. I just fixed this new defect in elementary. Thanks. Daniel Juyung Seo (SeoZ) o E: Outstanding defects 202 (198) with a density of 0.72 (0.71). 0 defects fixed since last build and 4 added. If anybody wants to see something added here let me know and be my guest. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
I agree. Arcanist is awful, and I definitely prefer to just get patches by mail since it saves me a considerable amount of time. On Mon, Sep 30, 2013 at 2:19 PM, Stefan Schmidt s.schm...@samsung.comwrote: On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote: Thanks Mariusz Bialonczyk for your patch. As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix. Btw Mariusz, can you raise a patch with phabricator + arcanist next time? https://phab.enlightenment.org/w/arcanist/ It was me who told him to use git format-patch and send it via mail. It's easy and quick to submit a patch than writing an email. You really think that? Given you have to install php, a new tool and learn it also. And also given you just mailed to the list with a problem using it :) I also think its quite unlikely that people would jump through all the hops for one patch. If they plan on more and trying to become a real commiter that might be worth the time but for only one patch I daubt it. You can get a review and feedback as well from the system line by line easily. That is indeed a nice thing. But I have to say I find the whole workflow quite arkward. But maybe it only me being used to patches and review on the ml. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 05/06: Eina inlist: Removed redundant if in EINA_INLIST_FOREACH_SAFE.
tasn pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=de6f57fac0a21f7729893b5d3d7a5606e9dcb1ce commit de6f57fac0a21f7729893b5d3d7a5606e9dcb1ce Author: Tom Hacohen t...@stosb.com Date: Mon Sep 30 14:28:38 2013 +0100 Eina inlist: Removed redundant if in EINA_INLIST_FOREACH_SAFE. If it is not NULL, so will EINA_INLIST_GET. As that returns a pointer to an area after it. --- src/lib/eina/eina_inlist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eina/eina_inlist.h b/src/lib/eina/eina_inlist.h index e3f1576..ba7ffec 100644 --- a/src/lib/eina/eina_inlist.h +++ b/src/lib/eina/eina_inlist.h @@ -843,7 +843,7 @@ EAPI Eina_Inlist *eina_inlist_sort(Eina_Inlist *head, Eina_Compare_Cb func); * that is part of the list. */ #define EINA_INLIST_FOREACH_SAFE(list, list2, it) \ - for (it = NULL, it = (list ? _EINA_INLIST_CONTAINER(it, list) : NULL), list2 = it ? ((EINA_INLIST_GET(it) ? EINA_INLIST_GET(it)-next : NULL)) : NULL; \ + for (it = NULL, it = (list ? _EINA_INLIST_CONTAINER(it, list) : NULL), list2 = it ? EINA_INLIST_GET(it)-next : NULL; \ it; \ it = list2 ? _EINA_INLIST_CONTAINER(it, list2) : NULL, list2 = list2 ? list2-next : NULL) --
[EGIT] [core/efl] master 01/06: Eo: don't va_start without a matching va_end.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=8ca320a1fc9448c051bdb3e42a972c1ad0da9161
commit 8ca320a1fc9448c051bdb3e42a972c1ad0da9161
Author: Tom Hacohen t...@stosb.com
Date: Mon Sep 30 14:07:20 2013 +0100
Eo: don't va_start without a matching va_end.
Fixes coverity CID1099708.
---
src/lib/eo/eo.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index fca2b19..2abff09 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -380,18 +380,22 @@ eo_do_internal(const char *file, int line, const Eo
*obj_id, ...)
va_list p_list;
Eina_Bool class_ref = _eo_is_a_class(obj_id);
- va_start(p_list, obj_id);
if (class_ref)
{
EO_CLASS_POINTER_RETURN_VAL(obj_id, klass, EINA_FALSE);
+
+va_start(p_list, obj_id);
ret = _eo_class_dov_internal(file, line, klass, p_list);
+va_end(p_list);
}
else
{
EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE);
+
+va_start(p_list, obj_id);
ret = _eo_obj_dov_internal(file, line, obj, p_list);
+va_end(p_list);
}
- va_end(p_list);
return ret;
}
--
[EGIT] [core/efl] master 03/06: Eo: Don't write to pointer after free.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f5d4a807c845f37f502882858a61ea018557365a
commit f5d4a807c845f37f502882858a61ea018557365a
Author: Tom Hacohen t...@stosb.com
Date: Mon Sep 30 14:15:37 2013 +0100
Eo: Don't write to pointer after free.
Fixes coverity: CID 1039898.
---
src/lib/eo/eo_base_class.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
index 33f826a..98a6a0d 100644
--- a/src/lib/eo/eo_base_class.c
+++ b/src/lib/eo/eo_base_class.c
@@ -422,9 +422,9 @@ struct _Eo_Callback_Description
static void
_eo_callback_remove(Private_Data *pd, Eo_Callback_Description *cb)
{
- Eo_Callback_Description *itr, *pitr;
+ Eo_Callback_Description *itr, *pitr = NULL;
- itr = pitr = pd-callbacks;
+ itr = pd-callbacks;
if (pd-callbacks == cb)
pd-callbacks = cb-next;
--
[EGIT] [core/efl] master 04/06: Eo callbacks: Fix a possible issue of corrupted callback list.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=104a57b58ab9bd015ca677a225cee4cb92cf
commit 104a57b58ab9bd015ca677a225cee4cb92cf
Author: Tom Hacohen t...@stosb.com
Date: Mon Sep 30 14:16:46 2013 +0100
Eo callbacks: Fix a possible issue of corrupted callback list.
This happens when we delete more than one callback at the beginning
of the list (i.e 2 or more) in one go.
---
src/lib/eo/eo_base_class.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
index 98a6a0d..a5a7c62 100644
--- a/src/lib/eo/eo_base_class.c
+++ b/src/lib/eo/eo_base_class.c
@@ -425,8 +425,6 @@ _eo_callback_remove(Private_Data *pd,
Eo_Callback_Description *cb)
Eo_Callback_Description *itr, *pitr = NULL;
itr = pd-callbacks;
- if (pd-callbacks == cb)
- pd-callbacks = cb-next;
for ( ; itr ; )
{
@@ -439,6 +437,10 @@ _eo_callback_remove(Private_Data *pd,
Eo_Callback_Description *cb)
{
pitr-next = titr-next;
}
+ else
+ {
+ pd-callbacks = titr-next;
+ }
free(titr);
}
else
--
[EGIT] [core/efl] master 06/06: Eo: Don't compare desc to NULL as it can never be NULL at that stage.
tasn pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=baf0fc426846743faef4165786a7e589b9c90347 commit baf0fc426846743faef4165786a7e589b9c90347 Author: Tom Hacohen t...@stosb.com Date: Mon Sep 30 14:32:47 2013 +0100 Eo: Don't compare desc to NULL as it can never be NULL at that stage. Fixes coverity CID1039420. --- src/lib/eo/eo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index b838bb3..b15bd84 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -496,7 +496,7 @@ _eo_class_base_op_init(_Eo_Class *klass) klass-base_id = _eo_ops_last_id; - if (desc desc-ops.base_op_id) + if (desc-ops.base_op_id) *(desc-ops.base_op_id) = klass-base_id; _eo_ops_last_id += desc-ops.count + 1; --
[EGIT] [core/efl] master 02/06: Eo: don't va_start without a matching va_end.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=42d29b55e596313562c31cfe7d15402b51aa0d0c
commit 42d29b55e596313562c31cfe7d15402b51aa0d0c
Author: Tom Hacohen t...@stosb.com
Date: Mon Sep 30 14:10:21 2013 +0100
Eo: don't va_start without a matching va_end.
Fixes coverity CID1099707.
---
src/lib/eo/eo.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 2abff09..b838bb3 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -427,22 +427,26 @@ eo_do_super_internal(const char *file, int line, const Eo
*obj_id, const Eo_Clas
EO_CLASS_POINTER_RETURN_VAL(cur_klass_id, cur_klass, EINA_FALSE);
- va_start(p_list, op);
if (_eo_is_a_class(obj_id))
{
EO_CLASS_POINTER_RETURN_VAL(obj_id, klass, EINA_FALSE);
+
+va_start(p_list, op);
nklass = _eo_kls_itr_next(klass, cur_klass, op);
op_ret = _eo_op_internal(file, line, (Eo_Base *) klass, nklass,
EO_OP_TYPE_CLASS, op, p_list);
+va_end(p_list);
}
else
{
EO_OBJ_POINTER_RETURN_VAL(obj_id, obj, EINA_FALSE);
+
+va_start(p_list, op);
nklass = _eo_kls_itr_next(obj-klass, cur_klass, op);
op_ret = _eo_op_internal(file, line, (Eo_Base *) obj, nklass,
EO_OP_TYPE_REGULAR, op, p_list);
if (obj-do_error)
ret = EINA_FALSE;
+va_end(p_list);
}
- va_end(p_list);
if (!op_ret)
_EO_OP_ERR_NO_OP_PRINT(file, line, op, nklass);
--
[EGIT] [core/enlightenment] master 01/01: e_fm custom and regular mode icon selection
discomfitor pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=38e3969e72c88c4cf438c7537c37a72cae7344a4
commit 38e3969e72c88c4cf438c7537c37a72cae7344a4
Author: Yossi Kantor yossi.kan...@samsung.com
Date: Tue Sep 17 08:58:05 2013 +0200
e_fm custom and regular mode icon selection
---
src/bin/e_fm.c | 366 ++---
1 file changed, 143 insertions(+), 223 deletions(-)
diff --git a/src/bin/e_fm.c b/src/bin/e_fm.c
index 2a2c2db..cf9cac6 100644
--- a/src/bin/e_fm.c
+++ b/src/bin/e_fm.c
@@ -88,6 +88,7 @@ struct _E_Fm2_Smart_Data
} new_file;
E_Fm2_Icon *last_selected;
+ E_Fm2_Icon *range_selected;
Eina_List *selected_icons;
Eina_List *icons_place;
Eina_List *queue;
@@ -310,6 +311,7 @@ static void _e_fm2_icon_sel_prev(Evas_Object *obj,
Eina_Bool add);
static void _e_fm2_icon_sel_next(Evas_Object *obj, Eina_Bool add);
static void _e_fm2_icon_sel_down(Evas_Object *obj, Eina_Bool add);
static void _e_fm2_icon_sel_up(Evas_Object *obj, Eina_Bool add);
+static void _e_fm2_icon_range_select(E_Fm2_Icon *ic);
static void _e_fm2_typebuf_show(Evas_Object *obj);
static void _e_fm2_typebuf_hide(Evas_Object *obj);
@@ -5034,6 +5036,7 @@ _e_fm2_icon_select(E_Fm2_Icon *ic)
prev = eina_list_last_data_get(ic-sd-selected_icons);
if (prev) prev-last_selected = EINA_FALSE;
ic-selected = EINA_TRUE;
+ ic-sd-range_selected = NULL;
ic-sd-last_selected = ic;
ic-sd-selected_icons = eina_list_append(ic-sd-selected_icons, ic);
ic-last_selected = EINA_TRUE;
@@ -5061,6 +5064,7 @@ _e_fm2_icon_deselect(E_Fm2_Icon *ic)
if (!ic-selected) return;
ic-selected = EINA_FALSE;
ic-last_selected = EINA_FALSE;
+ ic-sd-range_selected = NULL;
if (ic-sd-last_selected == ic) ic-sd-last_selected = NULL;
ic-sd-selected_icons = eina_list_remove(ic-sd-selected_icons, ic);
ic-selected_time = 0.0;
@@ -5414,10 +5418,10 @@ _e_fm2_icon_next_find(Evas_Object *obj, int next, int
(*match_func)(E_Fm2_Icon *
{
E_Fm2_Smart_Data *sd;
Eina_List *l;
- E_Fm2_Icon *ic, *ic_next;
+ E_Fm2_Icon *ic, *ic_next, *ic_vert, *ic_horz;
char view_mode;
int x = 0, y = 0, custom = 0;
- int dist, min = 65535;
+ int dist = 0, min_horz = 65535, min_vert = 65535;
sd = evas_object_smart_data_get(obj);
if (!sd) return NULL;
@@ -5428,106 +5432,64 @@ _e_fm2_icon_next_find(Evas_Object *obj, int next, int
(*match_func)(E_Fm2_Icon *
(view_mode == E_FM2_VIEW_MODE_CUSTOM_GRID_ICONS) ||
(view_mode == E_FM2_VIEW_MODE_CUSTOM_ICONS))
custom = 1;
-
+
+ l = eina_list_data_find_list(sd-icons, (sd-range_selected) ?
+ sd-range_selected :
+ sd-last_selected);
+
+ if (!l) return eina_list_data_get(sd-icons);
+
+ if (!next) return eina_list_data_get(l);
+
ic_next = NULL;
- /* find selected item / current position */
- EINA_LIST_FOREACH(sd-icons, l, ic)
- {
-if (ic-selected)
- {
- if (!custom !match_func)
- {
- ic_next = ic;
- }
- else
- {
- x = ic-x;
- y = ic-y;
- }
- break;
- }
- }
- if (next (custom || match_func))
- {
-/* find next item in custom grid, or list/grid when match
- func is given */
-if (next == 1)
- {
- EINA_LIST_FOREACH(sd-icons, l, ic)
- {
- if ((ic-x x)
- (custom ? (ic-y = y) : (ic-y == y))
- (!match_func || match_func(ic, data)))
-{
- dist = 2 * (ic-y - y) + (ic-x - x);
- if (dist min)
- {
-min = dist;
-ic_next = ic;
- }
-}
- }
- /* no next item was found in row go down and begin */
- if (!ic_next)
- {
- EINA_LIST_FOREACH(sd-icons, l, ic)
-{
- if ((ic-y y) (!match_func || match_func(ic,
data)))
- {
-dist = 2 * (abs(ic-y - y)) + ic-x;
-if (dist min)
- {
- min = dist;
- ic_next = ic;
- }
- }
-}
- }
- }
-/* find previous item */
-else if (next == -1)
+ ic_vert = NULL;
+ ic_horz = NULL;
+
+ if (custom || match_func)
+ {
+ic =
[EGIT] [core/efl] master 02/02: update po's
raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ad89985d41af1a53d8c8b129544ba808df50b5d7 commit ad89985d41af1a53d8c8b129544ba808df50b5d7 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Sep 30 23:31:37 2013 +0900 update po's --- po/ca.po| 2 +- po/cs.po| 2 +- po/de.po| 2 +- po/el.po| 2 +- po/eo.po| 2 +- po/es.po| 2 +- po/fr.po| 2 +- po/gl.po| 2 +- po/it.po| 2 +- po/ja.po| 2 +- po/ko.po| 2 +- po/lt.po| 2 +- po/nl.po| 2 +- po/pt.po| 2 +- po/ru.po| 2 +- po/sl.po| 2 +- po/sr.po| 2 +- po/zh_CN.po | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/po/ca.po b/po/ca.po index 5a31a21..5f4e5d1 100644 --- a/po/ca.po +++ b/po/ca.po @@ -8,7 +8,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2013-02-01 09:52+0100\n Last-Translator: Joan Coll jco...@gmail.com\n Language-Team: Catalan\n diff --git a/po/cs.po b/po/cs.po index cac87d2..155fc80 100644 --- a/po/cs.po +++ b/po/cs.po @@ -9,7 +9,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2012-12-13 12:06+0100\n Last-Translator: Tomáš Čech sleep_wal...@suse.cz\n Language-Team: Czech kde-i18n-...@kde.org\n diff --git a/po/de.po b/po/de.po index d841426..1822d1d 100644 --- a/po/de.po +++ b/po/de.po @@ -8,7 +8,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2012-06-24 17:10+0900\n Last-Translator: Jerome Pinot ngc...@gmail.com\n Language-Team: Enlightenment Team\n diff --git a/po/el.po b/po/el.po index 025f893..b342be9 100644 --- a/po/el.po +++ b/po/el.po @@ -10,7 +10,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2012-12-01 18:26+0200\n Last-Translator: Efstathios Iosifidis iosifi...@opensuse.org\n Language-Team: Ελληνικά, Σύγχρονα opensuse-translation...@opensuse.org\n diff --git a/po/eo.po b/po/eo.po index 63b3d42..f5e7a62 100644 --- a/po/eo.po +++ b/po/eo.po @@ -7,7 +7,7 @@ msgid msgstr Project-Id-Version: enlightenment\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2013-02-21 15:24+\n Last-Translator: Michael Moroni michael.mor...@mailoo.org\n Language-Team: Esperanto e...@li.org\n diff --git a/po/es.po b/po/es.po index f093f35..661d427 100644 --- a/po/es.po +++ b/po/es.po @@ -7,7 +7,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2013-01-04 23:53+0100\n Last-Translator: Adrián Arévalo adr...@gmail.com\n Language-Team: Enlightenment Team\n diff --git a/po/fr.po b/po/fr.po index c441871..c508ef1 100644 --- a/po/fr.po +++ b/po/fr.po @@ -9,7 +9,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2013-02-05 22:51+\n Last-Translator: ilLogict illog...@online.fr\n Language-Team: Enlightenment French Team enlightenment-intl@lists. diff --git a/po/gl.po b/po/gl.po index 7c7404a..318c4e8 100644 --- a/po/gl.po +++ b/po/gl.po @@ -6,7 +6,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2012-11-07 22:52+0100\n Last-Translator: Aníbal Garrido kh...@member.trisquel.info\n Language-Team: http://trasno.net/ proxe...@trasno.net\n diff --git a/po/it.po b/po/it.po index f469f07..bbeeb65 100644 --- a/po/it.po +++ b/po/it.po @@ -7,7 +7,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n -POT-Creation-Date: 2013-08-15 03:49+0900\n +POT-Creation-Date: 2013-09-30 14:26+0900\n PO-Revision-Date: 2013-01-05 20:49+0100\n Last-Translator: Massimo Maiurana maiur...@gmail.com\n Language-Team: none\n diff --git a/po/ja.po b/po/ja.po index 798ed5a..992ffb8 100644 --- a/po/ja.po +++ b/po/ja.po @@ -6,7 +6,7 @@ msgid msgstr Project-Id-Version: Efl\n Report-Msgid-Bugs-To: enlightenment-devel@lists.sourceforge.net\n
[EGIT] [core/efl] master 01/02: evas - improve textblock logic to reduce num of layouts when used - faster
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a4a285089f48c1c303aa389324f778eaefe9e3a8
commit a4a285089f48c1c303aa389324f778eaefe9e3a8
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Mon Sep 30 23:29:54 2013 +0900
evas - improve textblock logic to reduce num of layouts when used - faster
when using genlist and the edje item objects, there seem to be a lot
of excess textblock layouts happening. i was seeing about 12 layouts per tb
part in the edje before this patch. with this it's down to about 3.
---
src/lib/evas/canvas/evas_object_textblock.c | 235 +---
1 file changed, 182 insertions(+), 53 deletions(-)
diff --git a/src/lib/evas/canvas/evas_object_textblock.c
b/src/lib/evas/canvas/evas_object_textblock.c
index 291ef8e..e0aff4d 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -69,6 +69,9 @@
EAPI Eo_Op EVAS_OBJ_TEXTBLOCK_BASE_ID = EO_NOOP;
+//#define LYDBG(f, args...) printf(f, ##args)
+#define LYDBG(f, args...)
+
#define MY_CLASS EVAS_OBJ_TEXTBLOCK_CLASS
#define MY_CLASS_NAME Evas_Object_Textblock
@@ -495,7 +498,7 @@ struct _Evas_Object_Textblock
const char *repch;
const char *bidi_delimiters;
struct {
- int w, h;
+ int w, h, oneline_h;
Eina_Boolvalid : 1;
} formatted, native;
Eina_Bool redraw : 1;
@@ -532,11 +535,9 @@ static int evas_object_textblock_is_opaque(Evas_Object
*eo_obj,
static int evas_object_textblock_was_opaque(Evas_Object *eo_obj,
Evas_Object_Protected_Data *obj,
void *type_private_data);
-
static void evas_object_textblock_coords_recalc(Evas_Object *eo_obj,
Evas_Object_Protected_Data *obj,
void *type_private_data);
-
static void evas_object_textblock_scale_update(Evas_Object *eo_obj,
Evas_Object_Protected_Data *obj,
void *type_private_data);
@@ -560,7 +561,7 @@ static const Evas_Object_Func object_func =
evas_object_textblock_was_opaque,
NULL,
NULL,
- evas_object_textblock_coords_recalc,
+ NULL, /*evas_object_textblock_coords_recalc, - disable - not useful. */
evas_object_textblock_scale_update,
NULL,
NULL,
@@ -5104,6 +5105,7 @@ _layout(const Evas_Object *eo_obj, int w, int h, int
*w_ret, int *h_ret)
Ctxt ctxt, *c;
int style_pad_l = 0, style_pad_r = 0, style_pad_t = 0, style_pad_b = 0;
+ LYDBG(ZZ: layout %p %4ix%4i | w=%4i | last_w=%4i --- '%s'\n, eo_obj, w,
h, obj-cur-geometry.w, o-last_w, o-markup_text);
/* setup context */
c = ctxt;
c-obj = (Evas_Object *)eo_obj;
@@ -5269,6 +5271,7 @@ _layout(const Evas_Object *eo_obj, int w, int h, int
*w_ret, int *h_ret)
o-style_pad.t = style_pad_t;
o-style_pad.b = style_pad_b;
_paragraphs_clear(eo_obj, c-paragraphs);
+LYDBG(ZZ: ... layout #2\n);
_layout(eo_obj, w, h, w_ret, h_ret);
}
}
@@ -5287,8 +5290,19 @@ _relayout(const Evas_Object *eo_obj)
_layout(eo_obj, obj-cur-geometry.w, obj-cur-geometry.h,
o-formatted.w, o-formatted.h);
o-formatted.valid = 1;
+ o-formatted.oneline_h = 0;
o-last_w = obj-cur-geometry.w;
+ LYDBG(ZZ: - layout %p @ %ix%i = %ix%i\n, eo_obj,
obj-cur-geometry.w, obj-cur-geometry.h, o-formatted.w, o-formatted.h);
o-last_h = obj-cur-geometry.h;
+ if ((o-paragraphs) (!EINA_INLIST_GET(o-paragraphs)-next)
+ (o-paragraphs-lines)
(!EINA_INLIST_GET(o-paragraphs-lines)-next))
+ {
+if (obj-cur-geometry.h o-formatted.h)
+ {
+ LYDBG(ZZ: 1 line only... lasth == formatted h (%i)\n,
o-formatted.h);
+ o-formatted.oneline_h = o-formatted.h;
+ }
+ }
o-changed = 0;
o-content_changed = 0;
o-format_changed = EINA_FALSE;
@@ -5312,8 +5326,14 @@ _find_layout_item_line_match(Evas_Object *eo_obj,
Evas_Object_Textblock_Node_Tex
Evas_Object_Textblock_Paragraph *found_par;
Evas_Object_Textblock_Line *ln;
Evas_Object_Textblock *o = eo_data_scope_get(eo_obj, MY_CLASS);
+ Evas_Object_Protected_Data *obj = eo_data_scope_get(eo_obj, EVAS_OBJ_CLASS);
- if (!o-formatted.valid) _relayout(eo_obj);
+ evas_object_textblock_coords_recalc(eo_obj, obj, obj-private_data);
+ if (!o-formatted.valid)
+ {
+LYDBG(ZZ: relayout 1\n);
+_relayout(eo_obj);
+ }
found_par = n-par;
if (found_par)
@@ -7423,7 +7443,14 @@
evas_textblock_cursor_line_char_first(Evas_Textblock_Cursor *cur)
if (!cur) return;
TB_NULL_CHECK(cur-node);
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
Well this might be a personal preference. I am used to accept new things very well and easily. But I also agree with the fact that there is a high starting curve such as installing this and that. However once people do the initial setup, they will find it's super great and easy. Just see how people were already using that well. https://phab.enlightenment.org/differential/query/all/ https://phab.enlightenment.org/D230 One more merit is that only related people read that commit. Other people do not need to waste their time on unrelated patches. I just like arcanist :) You can keep using ml. I don't care. I just wanted him to know what efl's contribution process is. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Sep 30, 2013 at 10:25 PM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: I agree. Arcanist is awful, and I definitely prefer to just get patches by mail since it saves me a considerable amount of time. On Mon, Sep 30, 2013 at 2:19 PM, Stefan Schmidt s.schm...@samsung.com wrote: On 09/30/2013 02:10 PM, Daniel Juyung Seo wrote: Thanks Mariusz Bialonczyk for your patch. As Stefan mentioned it's not a typo fix. Thanks Stefan for the fix. Btw Mariusz, can you raise a patch with phabricator + arcanist next time? https://phab.enlightenment.org/w/arcanist/ It was me who told him to use git format-patch and send it via mail. It's easy and quick to submit a patch than writing an email. You really think that? Given you have to install php, a new tool and learn it also. And also given you just mailed to the list with a problem using it :) I also think its quite unlikely that people would jump through all the hops for one patch. If they plan on more and trying to become a real commiter that might be worth the time but for only one patch I daubt it. You can get a review and feedback as well from the system line by line easily. That is indeed a nice thing. But I have to say I find the whole workflow quite arkward. But maybe it only me being used to patches and review on the ml. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: Evas textblock: Moved relayout checks to a function.
tasn pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=bb84a01f7ce9d04b8d9ea9e14f8480f44b8449e1
commit bb84a01f7ce9d04b8d9ea9e14f8480f44b8449e1
Author: Tom Hacohen t...@stosb.com
Date: Mon Sep 30 16:15:16 2013 +0100
Evas textblock: Moved relayout checks to a function.
This cleans up the code a bit and makes it a bit simpler.
---
src/lib/evas/canvas/evas_object_textblock.c | 152
1 file changed, 40 insertions(+), 112 deletions(-)
diff --git a/src/lib/evas/canvas/evas_object_textblock.c
b/src/lib/evas/canvas/evas_object_textblock.c
index e0aff4d..ce34a1c 100644
--- a/src/lib/evas/canvas/evas_object_textblock.c
+++ b/src/lib/evas/canvas/evas_object_textblock.c
@@ -5309,6 +5309,23 @@ _relayout(const Evas_Object *eo_obj)
o-redraw = 1;
}
+/*
+ * @internal
+ * Check if the object needs a relayout, and if so, execute it.
+ */
+static inline void
+_relayout_if_needed(Evas_Object *eo_obj, const Evas_Object_Textblock *o)
+{
+ Evas_Object_Protected_Data *obj = eo_data_scope_get(eo_obj, EVAS_OBJ_CLASS);
+
+ evas_object_textblock_coords_recalc(eo_obj, obj, obj-private_data);
+ if (!o-formatted.valid)
+ {
+LYDBG(ZZ: relayout\n);
+_relayout(eo_obj);
+ }
+}
+
/**
* @internal
* Find the layout item and line that match the text node and position passed.
@@ -5326,14 +5343,8 @@ _find_layout_item_line_match(Evas_Object *eo_obj,
Evas_Object_Textblock_Node_Tex
Evas_Object_Textblock_Paragraph *found_par;
Evas_Object_Textblock_Line *ln;
Evas_Object_Textblock *o = eo_data_scope_get(eo_obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(eo_obj, EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(eo_obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 1\n);
-_relayout(eo_obj);
- }
+ _relayout_if_needed(eo_obj, o);
found_par = n-par;
if (found_par)
@@ -7443,14 +7454,8 @@
evas_textblock_cursor_line_char_first(Evas_Textblock_Cursor *cur)
if (!cur) return;
TB_NULL_CHECK(cur-node);
Evas_Object_Textblock *o = eo_data_scope_get(cur-obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(cur-obj,
EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(cur-obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 2\n);
-_relayout(cur-obj);
- }
+ _relayout_if_needed(cur-obj, o);
_find_layout_item_match(cur, ln, it);
@@ -7483,14 +7488,8 @@
evas_textblock_cursor_line_char_last(Evas_Textblock_Cursor *cur)
if (!cur) return;
TB_NULL_CHECK(cur-node);
Evas_Object_Textblock *o = eo_data_scope_get(cur-obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(cur-obj,
EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(cur-obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 3\n);
-_relayout(cur-obj);
- }
+ _relayout_if_needed(cur-obj, o);
_find_layout_item_match(cur, ln, it);
@@ -8028,14 +8027,8 @@ evas_textblock_cursor_line_set(Evas_Textblock_Cursor
*cur, int line)
if (!cur) return EINA_FALSE;
Evas_Object_Textblock *o = eo_data_scope_get(cur-obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(cur-obj,
EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(cur-obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 4\n);
-_relayout(cur-obj);
- }
+ _relayout_if_needed(cur-obj, o);
ln = _find_layout_line_num(cur-obj, line);
if (!ln) return EINA_FALSE;
@@ -9287,14 +9280,8 @@ evas_textblock_cursor_geometry_bidi_get(const
Evas_Textblock_Cursor *cur, Evas_C
{
if (!cur) return EINA_FALSE;
Evas_Object_Textblock *o = eo_data_scope_get(cur-obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(cur-obj,
EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(cur-obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 5\n);
-_relayout(cur-obj);
- }
+ _relayout_if_needed(cur-obj, o);
if (ctype == EVAS_TEXTBLOCK_CURSOR_UNDER)
{
@@ -9475,14 +9462,8 @@ evas_textblock_cursor_geometry_get(const
Evas_Textblock_Cursor *cur, Evas_Coord
int ret = -1;
if (!cur) return -1;
Evas_Object_Textblock *o = eo_data_scope_get(cur-obj, MY_CLASS);
- Evas_Object_Protected_Data *obj = eo_data_scope_get(cur-obj,
EVAS_OBJ_CLASS);
- evas_object_textblock_coords_recalc(cur-obj, obj, obj-private_data);
- if (!o-formatted.valid)
- {
-LYDBG(ZZ: relayout 6\n);
-_relayout(cur-obj);
- }
+ _relayout_if_needed(cur-obj, o);
if (ctype == EVAS_TEXTBLOCK_CURSOR_UNDER)
{
@@ -9549,14 +9530,8 @@ _evas_textblock_cursor_char_pen_geometry_common_get(int
(*query_func) (void *dat
if (!cur) return -1;
Evas_Object_Textblock *o =
Re: [E-devel] [EGIT] [core/elementary] master 02/03: elm: Longwaited trailing white space removal. Clean elm up!
On Mon, Sep 30, 2013 at 10:19 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: whatisthisidonteven.jpg http://haugom.tk/wp-content/uploads/2013/08/what+is+this+I+don+t+even+_e6935e220e54cbbdf5685ce5d569e210.jpg It's a merge conflict party and you are all invited. On Mon, Sep 30, 2013 at 2:16 PM, Daniel Juyung Seo seojuyu...@gmail.comwrote: seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=f0d4a6fe6e98d47a902353a34e0e4f905b0fa51d commit f0d4a6fe6e98d47a902353a34e0e4f905b0fa51d Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Mon Sep 30 19:21:31 2013 +0900 elm: Longwaited trailing white space removal. Clean elm up! --- src/bin/quicklaunch.c | 6 +- src/bin/run.c | 14 +-- src/bin/test_bg.c | 2 +- src/bin/test_button.c | 2 +- src/bin/test_external.c| 2 +- src/bin/test_focus.c | 16 ++-- src/bin/test_genlist.c | 6 +- src/bin/test_glview.c | 4 +- src/bin/test_index.c | 4 +- src/bin/test_prefs.c | 2 +- src/bin/test_segment_control.c | 6 +- src/bin/test_video.c | 2 +- src/bin/test_win_plug.c| 2 +- src/lib/elc_multibuttonentry.c | 10 +- src/lib/elc_naviframe.c| 2 +- src/lib/elc_player.c | 18 ++-- src/lib/elm_calendar.c | 4 +- src/lib/elm_cnp.c | 192 ++--- src/lib/elm_colorselector.c| 32 +++ src/lib/elm_config.c | 14 +-- src/lib/elm_datetime.c | 10 +- src/lib/elm_entry.c| 8 +- src/lib/elm_flip.c | 2 +- src/lib/elm_flipselector.c | 4 +- src/lib/elm_genlist.c | 10 +- src/lib/elm_image.c| 2 +- src/lib/elm_interface_scrollable.c | 6 +- src/lib/elm_module.c | 2 +- src/lib/elm_panel.c| 12 +-- src/lib/elm_prefs_data.c | 6 +- src/lib/elm_slider.c | 6 +- src/lib/elm_url.c | 2 +- src/lib/elm_util.c | 2 +- src/lib/elm_widget.c | 2 +- src/lib/elm_win.c | 22 ++--- src/lib/els_cursor.c | 2 +- 36 files changed, 219 insertions(+), 219 deletions(-) -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/elementary] master 01/01: elc_fileselector: Add fileselector_double_tap_navigation_enable configuration
ryuan pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=5bd79484ca3d2ffc4944ead737b73f579f92e3ee
commit 5bd79484ca3d2ffc4944ead737b73f579f92e3ee
Author: Ryuan Choi ryuan.c...@gmail.com
Date: Tue Oct 1 00:49:50 2013 +0900
elc_fileselector: Add fileselector_double_tap_navigation_enable
configuration
elm_filechooser used single tap not only for selection of file but also for
navigation of directory.
So it did not provide a way to select directory without navigation.
With fileselector_double_tap_navigation_enable option, single tap will be
used
only for selection and double tap will be used for navigation of file or
directory.
---
ChangeLog | 5 ++
NEWS | 1 +
config/standard/base.src | 1 +
src/lib/elc_fileselector.c| 133 ++
src/lib/elm_config.c | 5 ++
src/lib/elm_priv.h| 1 +
src/lib/elm_widget_fileselector.h | 3 +-
7 files changed, 105 insertions(+), 44 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7dc0c7a..e3bce08 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1659,3 +1659,8 @@
the content is static object and it won't be updated by content
position. This actually reduces the mapbuf calculation time muchly in
case of complex layout.
+
+2013-10-01 Ryuan Choi (ryuan)
+
+* fileselector: Add the configuration
fileselector_double_tap_navigation_enable.
+It makes fileselector navigate folder using double tap instead of
single tap.
diff --git a/NEWS b/NEWS
index d31e51a..72139a0 100644
--- a/NEWS
+++ b/NEWS
@@ -94,6 +94,7 @@ Additions:
* Add dismissed smart callback for hover.
* Add dismissed smart callback for menu.
* Add elm_menu_item_subitems_clear().
+ * Add the configuration fileselector_double_tap_navigation_enable.
Improvements:
diff --git a/config/standard/base.src b/config/standard/base.src
index b0eb81c..5f974ff 100644
--- a/config/standard/base.src
+++ b/config/standard/base.src
@@ -46,6 +46,7 @@ group Elm_Config struct {
value focus_highlight_animate uchar: 0;
value toolbar_shrink_mode int: 3;
value fileselector_expand_enable uchar: 1;
+ value fileselector_double_tap_navigation_enable uchar: 1;
value inwin_dialogs_enable uchar: 0;
value icon_size int: 32;
value longpress_timeout double: 1.0;
diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
index 3fa3136..b0ae946 100644
--- a/src/lib/elc_fileselector.c
+++ b/src/lib/elc_fileselector.c
@@ -49,7 +49,7 @@ _elm_fileselector_smart_del_do(Elm_Fileselector_Smart_Data
*sd)
{
if (sd-path) eina_stringshare_del(sd-path);
if (sd-selection) eina_stringshare_del(sd-selection);
- if (sd-sel_idler) free(ecore_idler_del(sd-sel_idler));
+ if (sd-populate_idler) free(ecore_idler_del(sd-populate_idler));
eo_do_super(sd-obj, MY_CLASS, evas_obj_smart_del());
}
@@ -658,45 +658,60 @@ _on_list_contract_req(void *data __UNUSED__,
}
static Eina_Bool
-_sel_do(void *data)
+_populate_do(void *data)
{
struct sel_data *sdata = data;
- const char *path;
const char *p;
- Eina_Bool is_dir;
ELM_FILESELECTOR_DATA_GET(sdata-fs, sd);
- path = sdata-path;
- is_dir = ecore_file_is_dir(path);
- /* We need to populate, if path is directory and:
-* - mode is GRID;
-* - mode is LIST and 'not expand mode';
-* in other cases update anchors. */
- if (((!sd-expand) || (sd-mode == ELM_FILESELECTOR_GRID)) (is_dir))
- {
-/* keep a ref to path 'couse it will be destroyed by _populate */
-p = eina_stringshare_add(path);
-_populate(sdata-fs, p, NULL, NULL);
-eina_stringshare_del(p);
- }
- else
- {
-elm_object_text_set(sd-name_entry, ecore_file_file_get(path));
- }
-
- /* We need to send callback when:
-* - path is dir and mode is ONLY FOLDER
-* - path is file and mode is NOT ONLY FOLDER */
- if (is_dir == sd-only_folder)
- evas_object_smart_callback_call(sdata-fs, SIG_SELECTED, (void *)path);
+ /* keep a ref to path 'couse it will be destroyed by _populate */
+ p = eina_stringshare_add(sdata-path);
+ _populate(sdata-fs, p, NULL, NULL);
+ eina_stringshare_del(p);
- sd-sel_idler = NULL;
+ sd-populate_idler = NULL;
free(sdata);
return ECORE_CALLBACK_CANCEL;
}
static void
+_on_item_double_clicked(void *data,
+ Evas_Object *obj __UNUSED__,
+ void *event_info)
+{
+ //This event_info could be a list or gengrid item
+ Elm_Object_Item *it = event_info;
+ struct sel_data *sdata;
+ void *old_sdata;
+ const char *path;
+ Eina_Bool is_dir;
+
+ ELM_FILESELECTOR_DATA_GET(data, sd);
+
+ if (!sd-double_tap_navigation) return;
+
+ path = elm_object_item_data_get(it);
+ if (!path) return;
+
+ is_dir = ecore_file_is_dir(path);
+ if (!is_dir) return;
+
+
Re: [E-devel] [EGIT] [core/elementary] master 02/03: elm: Longwaited trailing white space removal. Clean elm up!
On 30/09/13 17:11, Iván Briano wrote: On Mon, Sep 30, 2013 at 10:19 AM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: whatisthisidonteven.jpg http://haugom.tk/wp-content/uploads/2013/08/what+is+this+I+don+t+even+_e6935e220e54cbbdf5685ce5d569e210.jpg It's a merge conflict party and you are all invited. Usually the case, yeah. However there are meant to be git am/apply flags that should help with ignoring those. I'm not sure, as I've never tried them. -- Tom. -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
On 09/30/2013 02:30 PM, Stefan Schmidt wrote: Hello. The change summary is a bit weak. Its not really a typo fix but a fix for the wrong numbers of seconds a day. I changed it to: test_calendar: Fix number of seconds per day. Hope you don't mind. of course :) thanks! regards, -- Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net http://manio.skyboo.net | https://github.com/manio -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] test_calendar.c: fix a typo
On 09/30/2013 04:33 PM, Daniel Juyung Seo wrote: I just like arcanist :) You can keep using ml. I don't care. I just wanted him to know what efl's contribution process is. got it! maybe i'll give it a try next time, thanks :) regards, -- Mariusz Białończyk | xmpp/e-mail: ma...@skyboo.net http://manio.skyboo.net | https://github.com/manio -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60133471iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] crashdump 0.17.99.17123
Thread 1 (Thread 0xb5e5f7c0 (LWP 2441)):
#0 0xb771d424 in __kernel_vsyscall ()
No symbol table info available.
#1 0xb73690c1 in pause () at ../sysdeps/unix/syscall-template.S:81
No locals.
#2 0x0807a653 in e_alert_show () at e_alert.c:38
No locals.
#3 0x0817e7e8 in e_sigseg_act (x=11, info=0xbf86ae4c, data=0xbf86aecc) at
e_signals.c:71
No locals.
#4 signal handler called
No symbol table info available.
#5 0x080f3341 in _e_exe_instance_watchers_call (inst=0x90d1110,
type=E_EXEC_WATCH_STOPPED) at e_exec.c:323
iw = 0x0
l = 0x8fbe668
ln = 0x0
#6 0x080f44a8 in _e_exec_cb_exit (data=0x0, type=12, event=0x8ec6790) at
e_exec.c:773
ev = 0x8ec6790
inst = 0x90d1110
#7 0xb7164713 in _ecore_call_handler_cb (func=0x80f41a4 _e_exec_cb_exit,
data=0x0, type=12, event=0x8ec6790) at lib/ecore/ecore_private.h:357
r = 1 '\001'
#8 0xb7165684 in _ecore_event_call () at lib/ecore/ecore_events.c:562
ret = 1 '\001'
e = 0x92b35d8
handle_count = 4
l = 0xb7175a8c _ecore_signal_received_process+18
l_next = 0xbf86c2a8
eh = 0x8a7df20
#9 0xb716ed3c in _ecore_main_loop_iterate_internal (once_only=0) at
lib/ecore/ecore_main.c:2013
next_time = 0.38496794953789504
#10 0xb716d061 in ecore_main_loop_begin () at lib/ecore/ecore_main.c:1035
No locals.
#11 0x080771ca in main (argc=1, argv=0xbf86d494) at e_main.c:1075
nostartup = 0 '\000'
safe_mode = 0 '\000'
after_restart = 0 '\000'
waslocked = 0 '\000'
t = 1380565395.333128
tstart = 1380565395.333128
s = 0x0
buff = 1380565395.3\000\223\365\266\001\000\000\000X\002
\bS\031\033\b,Ah\266
action = {__sigaction_handler = {sa_handler = 0x817e86d
e_sigabrt_act, sa_sigaction = 0x817e86d e_sigabrt_act}, sa_mask = {__val =
{0 repeats 32 times}}, sa_flags = -1073741820, sa_restorer = 0x81b1930
__libc_csu_init}
__FUNCTION__ = main
Detaching from program: /usr/local/bin/enlightenment, process
2441
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60134791iu=/4140/ostg.clktrk
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [bindings/python/python-efl] master 02/02: Move common conversion functions from efl.eo to efl.utils.conversions
kuuko pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=5f4a46da4b725329495366130b4ef03ebaa1d376 commit 5f4a46da4b725329495366130b4ef03ebaa1d376 Author: Kai Huuhko kai.huu...@gmail.com Date: Tue Oct 1 04:56:28 2013 +0300 Move common conversion functions from efl.eo to efl.utils.conversions --- efl/ecore/efl.ecore.pyx| 3 +- efl/edje/efl.edje.pyx | 8 ++- efl/edje/efl.edje_edit.pyx | 23 +++ efl/edje/efl.edje_edit_part.pxi| 2 +- efl/edje/efl.edje_edit_program.pxi | 4 +- efl/elementary/box.pyx | 6 +- efl/elementary/calendar_elm.pyx| 8 +-- efl/elementary/configuration.pyx | 4 +- efl/elementary/dayselector.pyx | 8 +-- efl/elementary/general.pyx | 9 +-- efl/elementary/grid.pyx| 6 +- efl/elementary/object.pyx | 6 +- efl/elementary/object_item.pyx | 8 +-- efl/elementary/slideshow.pyx | 6 +- efl/elementary/theme.pyx | 10 +-- efl/elementary/transit.pyx | 9 +-- efl/elementary/widget_header.pxi | 5 +- efl/elementary/window.pyx | 8 +-- efl/emotion/efl.emotion.pyx| 3 +- efl/eo/efl.eo.pyx | 104 -- efl/evas/efl.evas.pyx | 4 +- efl/evas/efl.evas_object_grid.pxi | 2 +- efl/evas/efl.evas_object_table.pxi | 4 +- efl/utils/conversions.pyx | 129 + include/efl.c_eo.pxd | 16 ++--- include/efl.eo.pxd | 10 --- include/efl.utils.conversions.pxd | 12 setup.py | 10 ++- 28 files changed, 230 insertions(+), 197 deletions(-) diff --git a/efl/ecore/efl.ecore.pyx b/efl/ecore/efl.ecore.pyx index 6791cd1..8b78681 100644 --- a/efl/ecore/efl.ecore.pyx +++ b/efl/ecore/efl.ecore.pyx @@ -201,7 +201,8 @@ File monitor events import traceback -from efl.eo cimport Eo, PY_REFCOUNT, _ctouni +from efl.eo cimport Eo, PY_REFCOUNT +from efl.utils.conversions cimport _ctouni from cpython cimport Py_INCREF, Py_DECREF cimport efl.ecore.enums as enums diff --git a/efl/edje/efl.edje.pyx b/efl/edje/efl.edje.pyx index 92087df..a24f5c1 100644 --- a/efl/edje/efl.edje.pyx +++ b/efl/edje/efl.edje.pyx @@ -22,8 +22,10 @@ from cpython cimport PyMem_Malloc, PyMem_Free, PyUnicode_AsUTF8String cimport libc.stdlib from efl.eo cimport _object_mapping_register, object_from_instance, \ -_register_decorated_callbacks, _ctouni, _touni, \ -convert_eina_list_strings_to_python_list +_register_decorated_callbacks + +from efl.utils.conversions cimport _ctouni, _touni, \ +eina_list_strings_to_python_list # Edje_Message_Type: @@ -166,7 +168,7 @@ def file_collection_list(file): if isinstance(file, unicode): file = PyUnicode_AsUTF8String(file) lst = edje_file_collection_list( const_char *file if file is not None else NULL) -ret = convert_eina_list_strings_to_python_list(lst) +ret = eina_list_strings_to_python_list(lst) edje_file_collection_list_free(lst) return ret diff --git a/efl/edje/efl.edje_edit.pyx b/efl/edje/efl.edje_edit.pyx index 20532c2..b9e21bb 100644 --- a/efl/edje/efl.edje_edit.pyx +++ b/efl/edje/efl.edje_edit.pyx @@ -15,7 +15,8 @@ # You should have received a copy of the GNU Lesser General Public License # along with this Python-EFL. If not, see http://www.gnu.org/licenses/. -from efl.eo cimport _touni, _ctouni, convert_eina_list_strings_to_python_list +from efl.utils.conversions cimport _touni, _ctouni, \ +eina_list_strings_to_python_list from efl.edje cimport Edje_Part_Type from efl.edje import EDJE_PART_TYPE_EXTERNAL @@ -77,7 +78,7 @@ cdef class EdjeEdit(Edje): Eina_List *lst list ret lst = edje_edit_data_list_get(self.obj) -ret = convert_eina_list_strings_to_python_list(lst) +ret = eina_list_strings_to_python_list(lst) edje_edit_string_list_free(lst) return ret @@ -123,7 +124,7 @@ cdef class EdjeEdit(Edje): Eina_List *lst list ret lst = edje_edit_group_data_list_get(self.obj) -ret = convert_eina_list_strings_to_python_list(lst) +ret = eina_list_strings_to_python_list(lst) edje_edit_string_list_free(lst) return ret @@ -167,7 +168,7 @@ cdef class EdjeEdit(Edje): def __get__(self): cdef Eina_List *lst lst = edje_edit_styles_list_get(self.obj) -ret = convert_eina_list_strings_to_python_list(lst) +ret = eina_list_strings_to_python_list(lst) edje_edit_string_list_free(lst) return ret @@ -190,7 +191,7 @@ cdef class EdjeEdit(Edje): def __get__(self): cdef Eina_List *lst lst = edje_edit_color_classes_list_get(self.obj) -ret
[EGIT] [bindings/python/python-efl] master 01/02: Rename efl.pxd to efl.eina.pxd
kuuko pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=6587b5be679e659337f3f2219186eb4f9afc44d0
commit 6587b5be679e659337f3f2219186eb4f9afc44d0
Author: Kai Huuhko kai.huu...@gmail.com
Date: Mon Sep 30 07:26:35 2013 +0300
Rename efl.pxd to efl.eina.pxd
---
efl/edje/efl.edje_object.pxi| 10 +-
efl/elementary/multibuttonentry.pyx | 2 +-
efl/eo/efl.eo.pyx | 2 +-
efl/evas/efl.evas.pyx | 2 +-
include/efl.c_eo.pxd| 2 +-
include/efl.ecore.pxd | 4 ++--
include/efl.edje.pxd| 10 +-
include/efl.edje_edit.pxd | 2 +-
include/{efl.pxd = efl.eina.pxd} | 18 ++
include/efl.emotion.pxd | 4 ++--
include/efl.eo.pxd | 6 --
include/efl.evas.pxd| 19 +--
12 files changed, 34 insertions(+), 47 deletions(-)
diff --git a/efl/edje/efl.edje_object.pxi b/efl/edje/efl.edje_object.pxi
index 9f189b6..953f750 100644
--- a/efl/edje/efl.edje_object.pxi
+++ b/efl/edje/efl.edje_object.pxi
@@ -46,7 +46,7 @@ cdef void message_handler_cb(void *data,
cdef void signal_cb(void *data, Evas_Object *obj,
-const_char *emission, const_char_ptr source) with gil:
+const_char *emission, const_char *source) with gil:
cdef Edje self
self = object_from_instance(obj)
lst = tuple(objectdata)
@@ -368,7 +368,7 @@ cdef class Edje(Object):
def __get__(self):
return edje_object_scale_get(self.obj)
-cpdef scale_set(self, double scale):
+cpdef scale_set(self, double scale):
edje_object_scale_set(self.obj, scale)
cpdef scale_get(self):
return edje_object_scale_get(self.obj)
@@ -385,7 +385,7 @@ cdef class Edje(Object):
edje_object_mirrored_set(self.obj, rtl)
def mirrored_get(self):
return bool(edje_object_mirrored_get(self.obj))
-
+
def size_min_get(self):
:rtype: tuple of int
cdef int w, h
@@ -423,11 +423,11 @@ cdef class Edje(Object):
width and height. The user might choose to *impose* those minimum
sizes,
making the resulting calculation to get values equal or bigger than
minw and minh, for width and height, respectively.
-
+
:note: At the end of this call, the object won't be automatically
resized to new dimensions, but just return the calculated
sizes. The caller is the one up to change its geometry or not.
-
+
:warning: Be advised that invisible parts in the object obj will be
taken into account in this calculation.
diff --git a/efl/elementary/multibuttonentry.pyx
b/efl/elementary/multibuttonentry.pyx
index 346a963..4f086f8 100644
--- a/efl/elementary/multibuttonentry.pyx
+++ b/efl/elementary/multibuttonentry.pyx
@@ -64,7 +64,7 @@ include widget_header.pxi
from libc.stdlib cimport free
from libc.string cimport strdup
-from efl cimport Eina_Stringshare, eina_stringshare_add, eina_stringshare_del,
\
+from efl.eina cimport Eina_Stringshare, eina_stringshare_add,
eina_stringshare_del, \
eina_stringshare_replace
from object cimport Object
import traceback
diff --git a/efl/eo/efl.eo.pyx b/efl/eo/efl.eo.pyx
index a2c7332..06bf163 100644
--- a/efl/eo/efl.eo.pyx
+++ b/efl/eo/efl.eo.pyx
@@ -18,7 +18,7 @@
from cpython cimport PyObject, Py_INCREF, Py_DECREF, PyUnicode_AsUTF8String
from libc.stdlib cimport malloc, free
from libc.string cimport memcpy, strdup
-from efl cimport Eina_Bool, const_Eina_List, eina_list_append, const_void, \
+from efl.eina cimport Eina_Bool, const_Eina_List, eina_list_append,
const_void, \
Eina_Hash, eina_hash_string_superfast_new, eina_hash_add, eina_hash_del, \
eina_hash_find
from efl.c_eo cimport Eo as cEo, eo_init, eo_shutdown, eo_del, eo_do, \
diff --git a/efl/evas/efl.evas.pyx b/efl/evas/efl.evas.pyx
index 082a94d..5edb85c 100644
--- a/efl/evas/efl.evas.pyx
+++ b/efl/evas/efl.evas.pyx
@@ -17,7 +17,7 @@
import traceback
from cpython cimport PyUnicode_AsUTF8String
-from efl cimport *
+from efl.eina cimport *
from efl.eo cimport Eo, object_from_instance, _object_mapping_register
from efl.eo cimport _ctouni, _touni
cimport efl.evas.enums as enums
diff --git a/include/efl.c_eo.pxd b/include/efl.c_eo.pxd
index 91a5328..ae554fd 100644
--- a/include/efl.c_eo.pxd
+++ b/include/efl.c_eo.pxd
@@ -15,7 +15,7 @@
# You should have received a copy of the GNU Lesser General Public License
# along with this Python-EFL. If not, see http://www.gnu.org/licenses/.
-from efl cimport *
+from efl.eina cimport *
cdef extern from Eo.h:
diff --git a/include/efl.ecore.pxd b/include/efl.ecore.pxd
index 5ce8ea8..0cacd4c 100644
--- a/include/efl.ecore.pxd
+++ b/include/efl.ecore.pxd
@@ -15,7 +15,7 @@
# You should have
[EGIT] [core/elementary] master 01/02: remove ifdef from glsl in glview shader - ifdefs not universally supported
raster pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=54883cb7fb0c42f37615f1485e554d947b42c369
commit 54883cb7fb0c42f37615f1485e554d947b42c369
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Wed Sep 11 08:53:02 2013 +0900
remove ifdef from glsl in glview shader - ifdefs not universally supported
---
src/bin/test_glview.c| 3 ---
src/bin/test_glview_simple.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/src/bin/test_glview.c b/src/bin/test_glview.c
index 6381ef4..f9e01f8 100644
--- a/src/bin/test_glview.c
+++ b/src/bin/test_glview.c
@@ -327,9 +327,6 @@ static const char vertex_shader[] =
}\n;
static const char fragment_shader[] =
- #ifdef GL_ES\n
- precision mediump float;\n
- #endif\n
uniform vec4 color;\n
uniform vec3 light;\n
varying vec3 rotated_normal;\n
diff --git a/src/bin/test_glview_simple.c b/src/bin/test_glview_simple.c
index 438a6fa..2db4a35 100644
--- a/src/bin/test_glview_simple.c
+++ b/src/bin/test_glview_simple.c
@@ -70,9 +70,6 @@ init_shaders(GLData *gld)
}\n;
GLbyte fShaderStr[] =
- #ifdef GL_ES \n
- precision mediump float; \n
- #endif \n
void main() \n
{\n
gl_FragColor = vec4 ( 1.0, 0.0, 0.0, 1.0 );\n
--
[EGIT] [core/elementary] master 02/02: genlist - fix homogenous to NOT go (un)realizing every item on queue
raster pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=fa002c0313df3cb10d3f56c1dfc09c539a157e35
commit fa002c0313df3cb10d3f56c1dfc09c539a157e35
Author: Carsten Haitzler (Rasterman) ras...@rasterman.com
Date: Tue Oct 1 12:54:28 2013 +0900
genlist - fix homogenous to NOT go (un)realizing every item on queue
---
src/lib/elm_genlist.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 860e868..f713dce 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -4475,8 +4475,22 @@ _item_block_recalc(Item_Block *itb,
if (!it-item-mincalcd) changed = EINA_TRUE;
if (changed)
{
- _item_realize(it, in, EINA_TRUE);
- _elm_genlist_item_unrealize(it, EINA_TRUE);
+ Eina_Bool doit = EINA_TRUE;
+
+ if (itb-sd-homogeneous)
+ {
+if ((it-group) (itb-sd-group_item_height ==
0))
+ doit = EINA_TRUE;
+else if (itb-sd-item_height == 0)
+ doit = EINA_TRUE;
+else
+ doit = EINA_FALSE;
+ }
+ if (doit)
+ {
+_item_realize(it, in, EINA_TRUE);
+_elm_genlist_item_unrealize(it, EINA_TRUE);
+ }
}
}
else
--
