[EGIT] [themes/dark] master 01/01: naviframe done now for dark.
raster pushed a commit to branch master. http://git.enlightenment.org/themes/dark.git/commit/?id=b49ff9f9eb8fa21b0a4d353aeabe47c323ce2eda commit b49ff9f9eb8fa21b0a4d353aeabe47c323ce2eda Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Oct 14 16:28:33 2013 +0900 naviframe done now for dark. --- edje/dark.edc |1 - edje/edc/elm/button.edc|2 +- edje/edc/elm/naviframe.edc | 1386 +++- edje/img/shadow_vert.png | Bin 0 - 118 bytes mock-18.xcf.gz | Bin 613251 - 613251 bytes 5 files changed, 473 insertions(+), 916 deletions(-) diff --git a/edje/dark.edc b/edje/dark.edc index 480acb2..2513de6 100644 --- a/edje/dark.edc +++ b/edje/dark.edc @@ -58,7 +58,6 @@ collections { #include edc/elm/layout.edc // XXX: support multi progress (progressbar) #include edc/elm/progress.edc -// XXX: needs design work (naviframe) #include edc/elm/naviframe.edc #include edc/elm/panel.edc #include edc/elm/popup.edc diff --git a/edje/edc/elm/button.edc b/edje/edc/elm/button.edc index 71d91a4..6ec4056 100644 --- a/edje/edc/elm/button.edc +++ b/edje/edc/elm/button.edc @@ -117,7 +117,7 @@ group { name: elm/button/base/default; part { name: sizer.content; type: TEXT; mouse_events: 0; scale: 1; description { state: default 0.0; -fixed: 1 1; +//fixed: 1 1; visible: 0; text { font: FN; size: 10; min: 0 0; diff --git a/edje/edc/elm/naviframe.edc b/edje/edc/elm/naviframe.edc index 0ce957e..a9633d4 100644 --- a/edje/edc/elm/naviframe.edc +++ b/edje/edc/elm/naviframe.edc @@ -1,1078 +1,636 @@ -#if 0 group { name: elm/naviframe/item/basic/default; + images.image: vgrad_med_dark.png COMP; + images.image: bevel_out.png COMP; + images.image: shine.png COMP; + images.image: bevel_dark_out.png COMP; + images.image: shadow_vert.png COMP; parts { - part { name: elm.swallow.content; type: SWALLOW; - description { state: default 0.0; - } - } - part { name: access.title; type: RECT; repeat_events: 1; - description { state: default 0.0; -fixed: 1 1; -color: 0 0 0 0; - } - } - part { name: elm.swallow.prev_btn; type: SWALLOW; - description { state: default 0.0; - } - description { state: hidden 0.0; -inherit: default 0.0; -visible: 0; - } - } - part { name: elm.swallow.next_btn; type: SWALLOW; + // this set of limits and bottoms is evil - but it's a nasty construct + // allowing EITHER the title and subtitle texts OR the prev/next button + // swallows to control the lower bounds of the naviframe title, depending + // on which is taller +#define BOTTOMMAX() \ + part { name: limit0; type: SPACER; \ + description { state: default 0.0; \ +rel1.to_y: title3; \ +rel1.relative: 0.0 1.0; \ +rel2.to_y: elm.swallow.next_btn; \ +rel2.offset: -1 0; \ +align: 0.5 1.0; \ +fixed: 0 1; \ +limit: HEIGHT; \ + } \ + } \ + part { name: limit1; type: SPACER; \ + description { state: default 0.0; \ +rel1.to_y: elm.swallow.next_btn; \ +rel1.relative: 0.0 1.0; \ +rel2.to_y: title3; \ +rel2.offset: -1 0; \ +align: 0.5 1.0; \ +fixed: 0 1; \ +limit: HEIGHT; \ + } \ + } \ + part { name: bottom0; type: SPACER; \ + description { state: default 0.0; \ +rel1.to_y: limit1; \ +rel1.relative: 0.0 1.0; \ +rel2.to_y: limit0; \ +rel2.offset: -1 0; \ +align: 0.5 1.0; \ +fixed: 0 1; \ +limit: HEIGHT; \ + } \ + description { state: other 0.0; \ +inherit: default 0.0; \ +rel1.to_y: limit0; \ +rel2.to_y: limit1; \ + } \ + } \ + program { name: pbot0; \ + signal: limit,height,zero; source: bottom0; \ + script { \ +new st[31], Float:vl; \ +get_state(PART:bottom0, st, 30, vl); \ +if (st[0] == 'd') set_state(PART:bottom0, other, 1.0); \ +else set_state(PART:bottom0, default, 1.0); \ + } \ + } \ + part { name: limit2; type: SPACER; \ + description { state: default 0.0; \ +rel1.to_y: title3; \ +rel1.relative: 0.0 1.0; \ +rel2.to_y: elm.swallow.prev_btn; \ +rel2.offset: -1 0; \ +align: 0.5 1.0; \ +fixed: 0 1; \ +limit: HEIGHT; \ + } \ + } \ + part { name: limit3; type: SPACER; \ + description { state: default 0.0; \ +rel1.to_y: elm.swallow.prev_btn; \ +rel1.relative: 0.0 1.0; \ +rel2.to_y: title3; \ +
[EGIT] [core/enlightenment] master 01/01: Fix issue where randr dialog would crash when trying to close after cloning.
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=0d28595b66e2442c2c5ff073cf7cf85c227b3595 commit 0d28595b66e2442c2c5ff073cf7cf85c227b3595 Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 08:30:22 2013 +0100 Fix issue where randr dialog would crash when trying to close after cloning. Don't free the mode_info returned from mode find as this mode info is still part of the monitors collection of modes. Signed-off-by: Chris Michael cp.mich...@samsung.com --- src/modules/conf_randr/e_smart_monitor.c | 4 1 file changed, 4 deletions(-) diff --git a/src/modules/conf_randr/e_smart_monitor.c b/src/modules/conf_randr/e_smart_monitor.c index 4247fde..505aac9 100644 --- a/src/modules/conf_randr/e_smart_monitor.c +++ b/src/modules/conf_randr/e_smart_monitor.c @@ -575,8 +575,6 @@ e_smart_monitor_clone_set(Evas_Object *obj, Evas_Object *parent) _e_smart_monitor_mode_refresh_rate_get(mode_info); psd-changes |= E_SMART_MONITOR_CHANGED_MODE; - - ecore_x_randr_mode_info_free(mode_info); } else { @@ -615,8 +613,6 @@ e_smart_monitor_clone_set(Evas_Object *obj, Evas_Object *parent) _e_smart_monitor_mode_refresh_rate_get(mode_info); sd-changes |= E_SMART_MONITOR_CHANGED_MODE; - - ecore_x_randr_mode_info_free(mode_info); } else { --
[EGIT] [core/enlightenment] enlightenment-0.17 01/01: bugfix: efm icon event clipping now set correctly
discomfitor pushed a commit to branch enlightenment-0.17. http://git.enlightenment.org/core/enlightenment.git/commit/?id=b23cebb26ede3862109597d2d480c5f921cd696e commit b23cebb26ede3862109597d2d480c5f921cd696e Author: Mike Blumenkrantz m.blumenk...@samsung.com Date: Mon Oct 14 08:44:02 2013 +0100 bugfix: efm icon event clipping now set correctly --- ChangeLog | 4 src/bin/e_fm.c | 1 + 2 files changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index a0a9571..9367b20 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2013-10-14 Mike Blumenkrantz + +* Fix event clipping on filemanager icons + 2013-09-20 Mike Blumenkrantz * Check mouse location when clicking menus, only activate items when clicking in the menu diff --git a/src/bin/e_fm.c b/src/bin/e_fm.c index 15732f9..6a88958 100644 --- a/src/bin/e_fm.c +++ b/src/bin/e_fm.c @@ -4826,6 +4826,7 @@ _e_fm2_icon_realize(E_Fm2_Icon *ic) evas_object_stack_above(ic-rect, ic-obj); _e_fm2_icon_label_set(ic, ic-obj); evas_object_clip_set(ic-obj, ic-sd-clip); + evas_object_clip_set(ic-rect, ic-sd-clip); evas_object_move(ic-obj, ic-sd-x + ic-x - ic-sd-pos.x, ic-sd-y + ic-y - ic-sd-pos.y); --
[EGIT] [themes/dark] master 01/01: reviewed layouts... a bit.
raster pushed a commit to branch master. http://git.enlightenment.org/themes/dark.git/commit/?id=a27ca10cb7554cf40ec5a284f82df7c82d1039f7 commit a27ca10cb7554cf40ec5a284f82df7c82d1039f7 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Oct 14 16:44:44 2013 +0900 reviewed layouts... a bit. --- edje/dark.edc | 3 +- edje/edc/elm/layout.edc | 188 +++- 2 files changed, 75 insertions(+), 116 deletions(-) diff --git a/edje/dark.edc b/edje/dark.edc index 2513de6..334dcf3 100644 --- a/edje/dark.edc +++ b/edje/dark.edc @@ -54,7 +54,6 @@ collections { #include edc/elm/map.edc #include edc/elm/index.edc #include edc/elm/calendar.edc -// XXX: review (layout) #include edc/elm/layout.edc // XXX: support multi progress (progressbar) #include edc/elm/progress.edc @@ -62,7 +61,7 @@ collections { #include edc/elm/panel.edc #include edc/elm/popup.edc #include edc/elm/border.edc -// XXX: min size calc problems - too wide! +// XXX: min size calc problems - too wide! ... err ok on my 32bit box... eh? #include edc/elm/spinner.edc #include edc/elm/menu.edc #include edc/elm/clock.edc diff --git a/edje/edc/elm/layout.edc b/edje/edc/elm/layout.edc index 3f5b56e..902d82b 100644 --- a/edje/edc/elm/layout.edc +++ b/edje/edc/elm/layout.edc @@ -1,8 +1,7 @@ /* application with a main content area with a back button and title area */ group { name: elm/layout/application/content-back; parts { - part { name: elm.swallow.content; - type: SWALLOW; + part { name: elm.swallow.content; type: SWALLOW; description { state: default 0.0; rel1 { to_y: title_clipper; @@ -11,8 +10,7 @@ group { name: elm/layout/application/content-back; } } } - part { name: title_clipper; - type: RECT; + part { name: title_clipper; type: RECT; description { state: default 0.0; visible: 1; rel1.to_y: back; @@ -24,8 +22,7 @@ group { name: elm/layout/application/content-back; rel2.relative: 1.0 0.0; } } - part { name: back_clipper; - type: RECT; + part { name: back_clipper; type: RECT; clip_to: title_clipper; description { state: default 0.0; visible: 1; @@ -34,8 +31,7 @@ group { name: elm/layout/application/content-back; visible: 0; } } - part { name: back; - type: EXTERNAL; + part { name: back; type: EXTERNAL; source: elm/button; clip_to: back_clipper; description { state: default 0.0; @@ -54,38 +50,32 @@ group { name: elm/layout/application/content-back; } programs { program { -signal: clicked; -source: back; +signal: clicked; source: back; action: SIGNAL_EMIT elm,action,back elm; } program { -signal: elm,back,hide; -source: elm; +signal: elm,back,hide; source: elm; action: STATE_SET hidden 0.0; target: back_clipper; } program { -signal: elm,back,show; -source: elm; +signal: elm,back,show; source: elm; action: STATE_SET default 0.0; target: back_clipper; } program { -signal: elm,title,hide; -source: elm; +signal: elm,title,hide; source: elm; action: STATE_SET hidden 0.0; transition: LINEAR 0.1; target: title_clipper; } program { -signal: elm,title,show; -source: elm; +signal: elm,title,show; source: elm; action: STATE_SET default 0.0; target: title_clipper; } } - part { name: elm.swallow.end; - type: SWALLOW; + part { name: elm.swallow.end; type: SWALLOW; description { state: default 0.0; align: 1.0 0.0; fixed: 1 1; @@ -99,9 +89,8 @@ group { name: elm/layout/application/content-back; } } } - part { name: elm.text.title; - type: TEXT; - effect: SOFT_SHADOW; + part { name: elm.text.title; type: TEXT; + effect: SHADOW BOTTOM; scale: 1; clip_to: title_clipper; description { state: default 0.0; @@ -110,14 +99,15 @@ group { name: elm/layout/application/content-back; relative: 1.0 0.0; offset: 2 1; } -rel2 { to_y: back; +rel2 { + to_y: back; to_x: elm.swallow.end; relative: 0.0 1.0; offset: -3 -1; } -text { - font: Sans:style=Bold; - size: 12; +color: 255 255 255 255; +color3: 0 0 0 128; +text {
[EGIT] [core/elementary] master 01/01: fix signal callback handling to listen to * for namespacing change to elm
raster pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=c852516803a274d0158299cab14921ebf4450841 commit c852516803a274d0158299cab14921ebf4450841 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Oct 14 17:34:26 2013 +0900 fix signal callback handling to listen to * for namespacing change to elm --- src/lib/elm_flipselector.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/elm_flipselector.c b/src/lib/elm_flipselector.c index 023bdd6..3728090 100644 --- a/src/lib/elm_flipselector.c +++ b/src/lib/elm_flipselector.c @@ -565,13 +565,13 @@ _elm_flipselector_smart_add(Eo *obj, void *_pd, va_list *list EINA_UNUSED) CRITICAL(Failed to set layout!); elm_layout_signal_callback_add - (obj, elm,action,up,start, , _signal_val_up_start, obj); + (obj, elm,action,up,start, *, _signal_val_up_start, obj); elm_layout_signal_callback_add - (obj, elm,action,up,stop, , _signal_val_change_stop, obj); + (obj, elm,action,up,stop, *, _signal_val_change_stop, obj); elm_layout_signal_callback_add - (obj, elm,action,down,start, , _signal_val_down_start, obj); + (obj, elm,action,down,start, *, _signal_val_down_start, obj); elm_layout_signal_callback_add - (obj, elm,action,down,stop, , _signal_val_change_stop, obj); + (obj, elm,action,down,stop, *, _signal_val_change_stop, obj); priv-first_interval = FLIP_FIRST_INTERVAL; --
[EGIT] [themes/dark] master 01/01: flipselector cleaned up a bit.
raster pushed a commit to branch master. http://git.enlightenment.org/themes/dark.git/commit/?id=c30a34a33c73cb6cfafa22ee224bb8748cb23415 commit c30a34a33c73cb6cfafa22ee224bb8748cb23415 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Oct 14 17:40:53 2013 +0900 flipselector cleaned up a bit. --- edje/dark.edc | 2 +- edje/edc/elm/flipselector.edc | 186 -- edje/edc/elm/naviframe.edc| 1 - 3 files changed, 89 insertions(+), 100 deletions(-) diff --git a/edje/dark.edc b/edje/dark.edc index 334dcf3..a86f9f0 100644 --- a/edje/dark.edc +++ b/edje/dark.edc @@ -9,6 +9,7 @@ collections { // elm #include edc/elm/bg.edc #include edc/elm/button.edc +// XXX: mobile mode needs invbisible scrollers... make signals that do this #include edc/elm/scroller.edc // XXX: (entry) need to do magnifier etc... #include edc/elm/entry.edc @@ -48,7 +49,6 @@ collections { #include edc/elm/tooltip.edc #include edc/elm/colorsel.edc #include edc/elm/segment_control.edc -// XXX: needs design work (flipselector) #include edc/elm/flipselector.edc #include edc/elm/notify.edc #include edc/elm/map.edc diff --git a/edje/edc/elm/flipselector.edc b/edje/edc/elm/flipselector.edc index 41a4397..9087f67 100644 --- a/edje/edc/elm/flipselector.edc +++ b/edje/edc/elm/flipselector.edc @@ -2,18 +2,17 @@ #define FLIP_PICKER_MAX_LEN_STR 50 group { name: elm/flipselector/base/default; - images { - image: flip_base_shad.png COMP; - image: flip_shad.png COMP; - image: sym_up_light_normal.png COMP; - image: sym_down_light_normal.png COMP; - image: sym_up_dark_normal.png COMP; - image: sym_down_dark_normal.png COMP; - image: shine.png COMP; - } - data { - item: max_len FLIP_PICKER_MAX_LEN_STR; - } + images.image: flip_shad.png COMP; + images.image: sym_up_light_normal.png COMP; + images.image: sym_down_light_normal.png COMP; + images.image: sym_up_dark_normal.png COMP; + images.image: sym_down_dark_normal.png COMP; + images.image: shine.png COMP; + images.image: win_shadow.png COMP; + images.image: bevel_out.png COMP; + + data.item: max_len FLIP_PICKER_MAX_LEN_STR; + //FIXME: quick successive clicks on, say, up, lead to nastiness script { public cur, prev, next, lock; @@ -153,29 +152,26 @@ group { name: elm/flipselector/base/default; } } parts { - part { name: base_shadow; - mouse_events: 0; + part { name: base_shadow; mouse_events: 0; description { state: default 0.0; -rel1 { offset: -4 -4; to: base; } -rel2 { offset: 3 6; to: base; } -image { - normal: flip_base_shad.png; - border: 10 10 10 10; -} +image.normal: win_shadow.png; +image.border: 14 14 14 14; +image.middle: 0; +rel1.to: base; +rel1.offset: -7 -3; +rel2.to: base; +rel2.offset: 6 11; fill.smooth: 0; } } - part { name: base; - type: RECT; + part { name: base; type: RECT; scale: 1; description { state: default 0.0; -rel1.offset: 6 4; -rel2.offset: -6 -7; +rel1.offset: 6 6; +rel2.offset: -7 -7; } } - part { name: bottom; - type: RECT; - mouse_events: 1; + part { name: bottom; type: RECT; description { state: default 0.0; rel1 { to: base; relative: 0.0 0.5; } rel2.to: base; @@ -185,9 +181,7 @@ group { name: elm/flipselector/base/default; visible: 0; } } - part { name: top; - type: RECT; - mouse_events: 1; + part { name: top; type: RECT; description { state: default 0.0; rel1.to: base; rel2 { to: base; relative: 1.0 0.5; } @@ -204,21 +198,23 @@ group { name: elm/flipselector/base/default; description { state: default 0.0; rel1.to: bottom; rel2.to: bottom; -color: 80 79 79 255; +color: 72 72 72 255; } } - part { name: bottom_text_prev; - type: TEXT; + part { name: bottom_text_prev; type: TEXT; mouse_events: 0; effect: SHADOW BOTTOM; clip_to: bottom_clipper; - mouse_events: 0; scale: 1; description { state: default 0.0; -rel1.to: base; +rel1.to_x: base; +rel1.to_y: arrow_top; +rel1.relative: 0.0 0.7; +rel1.offset: 2 0; rel2.to: base; -text { - font: FN; - size: 20; +rel2.to_y: arrow_bottom; +rel2.relative: 1.0 0.3; +rel2.offset: -3 -1; +text { font: FN; size: 10; min: 1 1; align: 0.5 0.5;
[EGIT] [themes/dark] master 01/01: leave diskselector for elm 1.9 or later - needs a rewrite in its layout
raster pushed a commit to branch master. http://git.enlightenment.org/themes/dark.git/commit/?id=d48a343a5436d54afe310ce290ab36a22ac3e209 commit d48a343a5436d54afe310ce290ab36a22ac3e209 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Mon Oct 14 17:41:52 2013 +0900 leave diskselector for elm 1.9 or later - needs a rewrite in its layout --- edje/dark.edc | 1 - 1 file changed, 1 deletion(-) diff --git a/edje/dark.edc b/edje/dark.edc index a86f9f0..a7e3c89 100644 --- a/edje/dark.edc +++ b/edje/dark.edc @@ -38,7 +38,6 @@ collections { #include edc/elm/win.edc #include edc/elm/inwin.edc #include edc/elm/slideshow.edc -// XXX: fix gfx (diskselector) #include edc/elm/diskselector.edc // XXX: fix gfx (ctxpopup) - use bubble look used for tooltips, bubble etc. #include edc/elm/ctxpopup.edc --
[EGIT] [core/enlightenment] master 01/01: Fix randr cloning support with odd monitor sizes
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=886a5c48085464a636883eaa19b8938f11822efb commit 886a5c48085464a636883eaa19b8938f11822efb Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 09:07:26 2013 +0100 Fix randr cloning support with odd monitor sizes Now, if a clone cannot be set to the same resolution as the parent, then we will go through all the parent modes and try to find one that Both support. Signed-off-by: Chris Michael cp.mich...@samsung.com --- src/modules/conf_randr/e_smart_monitor.c | 135 +-- 1 file changed, 57 insertions(+), 78 deletions(-) diff --git a/src/modules/conf_randr/e_smart_monitor.c b/src/modules/conf_randr/e_smart_monitor.c index 505aac9..360c4bd 100644 --- a/src/modules/conf_randr/e_smart_monitor.c +++ b/src/modules/conf_randr/e_smart_monitor.c @@ -551,23 +551,45 @@ e_smart_monitor_clone_set(Evas_Object *obj, Evas_Object *parent) evas_object_hide(obj); -/* check if parent is larger */ -if ((psd-current.w sd-current.w) || -(psd-current.h sd-current.h)) +/* see if this monitor has a mode where the size is equal to the + * parent monitor */ +if ((mode_info = + _e_smart_monitor_mode_find(sd, psd-current.w, +psd-current.h, EINA_TRUE))) { - /* NB: X RandR does not allow clones of different size or mode. - * They both must match. Because of that, if the parent is - * larger, then we need to resize the parent down and set the mode */ - - /* set the parent mode to this mode */ - /* if ((psd-current.refresh_rate != sd-current.refresh_rate) || */ - /* (psd-current.w != sd-current.w) || */ - /* (psd-current.h != sd-current.h)) */ + /* this monitor Can support parents size */ + sd-current.w = mode_info-width; + sd-current.h = mode_info-height; + sd-current.mode = mode_info-xid; + sd-current.refresh_rate = + _e_smart_monitor_mode_refresh_rate_get(mode_info); + + sd-changes |= E_SMART_MONITOR_CHANGED_MODE; + } +else + { + Eina_List *l; + Ecore_X_Randr_Mode_Info *pmode = NULL; + + /* this monitor Cannot support parents size. + * We need to find a mode that they Both can support */ + + /* loop through parent modes (largest to smallest) */ + EINA_LIST_REVERSE_FOREACH(psd-modes, l, pmode) { - if ((mode_info = - _e_smart_monitor_mode_find(psd, sd-current.w, - sd-current.h, EINA_TRUE))) - { + if ((mode_info = + _e_smart_monitor_mode_find(sd, pmode-width, + pmode-height, EINA_TRUE))) +{ + sd-current.w = pmode-width; + sd-current.h = pmode-height; + sd-current.mode = pmode-xid; + sd-current.refresh_rate = + _e_smart_monitor_mode_refresh_rate_get(pmode); + + sd-changes |= E_SMART_MONITOR_CHANGED_MODE; + + /* update parent mode */ psd-current.w = mode_info-width; psd-current.h = mode_info-height; psd-current.mode = mode_info-xid; @@ -575,82 +597,38 @@ e_smart_monitor_clone_set(Evas_Object *obj, Evas_Object *parent) _e_smart_monitor_mode_refresh_rate_get(mode_info); psd-changes |= E_SMART_MONITOR_CHANGED_MODE; - } - else - { - /* we could not find a mode that matches this size */ - /* FIXME */ - } - } - if (psd-current.orient != sd-current.orient) - { - psd-current.orient = sd-current.orient; - psd-changes |= E_SMART_MONITOR_CHANGED_ORIENTATION; + break; +} } + } - _e_smart_monitor_resolution_set(psd, psd-current.w, psd-current.h); +/* update parent */ +if (psd-changes E_SMART_MONITOR_CHANGED_MODE) + { + _e_smart_monitor_resolution_set(psd, psd-current.w, + psd-current.h); evas_object_grid_pack(psd-grid.obj, parent, psd-current.x, psd-current.y, psd-current.w, psd-current.h); } -else if ((sd-current.w
[E-devel] THIS WEEKEND! Enlightenment Developer Day - 2013 (reminder)
https://phab.enlightenment.org/phame/live/3/post/enlightenment_developer_day_2013/ It's on Again - 20th of October, Edinburgh, Scotland https://phab.enlightenment.org/phame/live/3/post/enlightenment_developer_day_2013/ https://phab.enlightenment.org/w/enlightenment_developer_day_2013/ Developer Day is on again this year. There are a limited number of places for the event, so please register early. We'd like to thank Samsung Electronics for financially supporting this event and making it happen. This year we will be asking for a small registration fee for Developer Day that will be put towards hosting all registered attendees for an end-of-day dinner and drinks, so assume your money is being well spent in feeding and watering you for the night. Please see the Linuxcon Europe site for more information about venue, accommodation and pricing. Registration Register here: https://www.regonline.com/Register/Checkin.aspx?EventID=1290190 Note: You do not need to register to LinuxCon in order to attend the dev day. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Weekly news from the automated build and QA front
Hello. This should give everyone an overview over what has happened in the last week regarding our continuous integration builds, unit tests and coverage as well as all static analyser runs and things like address-sanitizer. The numbers in parentheses reflect the values from last week to give you a trend. CI: o Added terminology builds for every SCM change as well as after every elm build. o Overall build statistic: 3.5% (5.94%) failed and 96.5% (94.06%) succeeded. https://build.enlightenment.org/ clang scan-build: o EFL scan-build reports 503 (504) issues. https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfu lBuild/artifact/scan-build/build/ Exactness: o The edje exactness builds are working now. Elm exactness still failing. o Problems with icons and paths (file selector widget) o Still waiting for the first successful run on jenkins Unit tests: o 271 (271) unit tests for efl and none failing Coverage: o EFL total coverage is at 25.7% (25.7%) lines and 28.5% (28.5%) functions https://build.enlightenment.org/view/Test%20Coverage/ Coverity: o Added terminology on the request of Boris Faure o EFL: Outstanding defects 452 (452) with a density of 0.85 (0.85). 5 defects fixed since last build and 5 added. o Elm: Outstanding defects 21 (30) with a density of 0.10 (0.14). 5 defects fixed since last build and 1 added. o E: Outstanding defects 199 (199) with a density of 0.71 (0.73). 0 defects fixed since last build and 0 added. o Terminology: Outstanding defects 23 (22) with a density of 0.37 (0.35). 0 defects fixed since last build and 1 added. If anybody wants to see something added here let me know and be my guest. regards Stefan Schmidt -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/enlightenment] master 01/01: Fix bug when hotplugging a TV where resolution does not match the parent because a TV uses a non-standard 1360 resolution
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=a9e09bc26dcde3667c5af512e861c8f076fea917 commit a9e09bc26dcde3667c5af512e861c8f076fea917 Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 10:53:04 2013 +0100 Fix bug when hotplugging a TV where resolution does not match the parent because a TV uses a non-standard 1360 resolution Signed-off-by: Chris Michael cp.mich...@samsung.com --- src/bin/e_randr.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c index faf0c96..d34c9a4 100644 --- a/src/bin/e_randr.c +++ b/src/bin/e_randr.c @@ -886,15 +886,21 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo * crtc's mode for cloning * * NB: Hmmm, what to do if it Cannot use this mode ?? */ + + /* get the modes that this output supports */ modes = ecore_x_randr_output_modes_get(ev-win, output_cfg-xid, num, pref); + if (modes) { +/* loop the outputs modes */ for (c = 0; c num; c++) { -if (modes[c] == mode) +if ((modes[c] == mode) + ((modes[c]-width == mode-width) + (modes[c]-height == mode-height))) { can_clone = EINA_TRUE; break; @@ -915,14 +921,35 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo { int cw, ch; -ecore_x_randr_mode_size_get(ev-win, -modes[c], +ecore_x_randr_mode_size_get(ev-win, modes[c], cw, ch); if ((cw == mw) (ch == mh)) { mode = modes[c]; break; } + else + { + /* G, stupid TVs with their + * non-standard resolution of + * 1360x768 ... need to account for that */ + if (ch == mh) +{ + if (cw = (mw - 6)) + { +mode = modes[c]; +break; + } +} + else if (cw == mw) +{ + if (ch = (mh - 6)) + { +mode = modes[c]; +break; + } +} + } } } --
[EGIT] [core/enlightenment] master 01/01: Revert Fix bug when hotplugging a TV where resolution does not match the
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=4df53f06e35f583c3b84917c883c857bf3f9fb99 commit 4df53f06e35f583c3b84917c883c857bf3f9fb99 Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 11:07:24 2013 +0100 Revert Fix bug when hotplugging a TV where resolution does not match the This reverts commit a9e09bc26dcde3667c5af512e861c8f076fea917. Breaks build, and does not fix real issue. Revert --- src/bin/e_randr.c | 33 +++-- 1 file changed, 3 insertions(+), 30 deletions(-) diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c index d34c9a4..faf0c96 100644 --- a/src/bin/e_randr.c +++ b/src/bin/e_randr.c @@ -886,21 +886,15 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo * crtc's mode for cloning * * NB: Hmmm, what to do if it Cannot use this mode ?? */ - - /* get the modes that this output supports */ modes = ecore_x_randr_output_modes_get(ev-win, output_cfg-xid, num, pref); - if (modes) { -/* loop the outputs modes */ for (c = 0; c num; c++) { -if ((modes[c] == mode) - ((modes[c]-width == mode-width) - (modes[c]-height == mode-height))) +if (modes[c] == mode) { can_clone = EINA_TRUE; break; @@ -921,35 +915,14 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo { int cw, ch; -ecore_x_randr_mode_size_get(ev-win, modes[c], +ecore_x_randr_mode_size_get(ev-win, +modes[c], cw, ch); if ((cw == mw) (ch == mh)) { mode = modes[c]; break; } - else - { - /* G, stupid TVs with their - * non-standard resolution of - * 1360x768 ... need to account for that */ - if (ch == mh) -{ - if (cw = (mw - 6)) - { -mode = modes[c]; -break; - } -} - else if (cw == mw) -{ - if (ch = (mh - 6)) - { -mode = modes[c]; -break; - } -} - } } } --
[EGIT] [core/elementary] master 02/02: elm_thumb.c: focus/unfocused support in thumb.
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=b107cd9c3f80a4858ac274ae1e9b9f47897e6ca2 commit b107cd9c3f80a4858ac274ae1e9b9f47897e6ca2 Author: Amitesh Singh singh.amit...@gmail.com Date: Mon Oct 14 19:10:44 2013 +0900 elm_thumb.c: focus/unfocused support in thumb. This feature is enabled only when the user enalbed focus support manually for thumb. Reviewers: seoz Differential Revision: https://phab.enlightenment.org/D241 --- src/lib/elm_thumb.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/lib/elm_thumb.c b/src/lib/elm_thumb.c index 1acc408..43a19d8 100644 --- a/src/lib/elm_thumb.c +++ b/src/lib/elm_thumb.c @@ -691,6 +691,31 @@ _reload(Eo *obj EINA_UNUSED, void *_pd, va_list *list EINA_UNUSED) #endif } +static void +_elm_thumb_smart_on_focus(Eo *obj, void *_pd EINA_UNUSED, va_list *list) +{ + Elm_Widget_Smart_Data *wd = eo_data_scope_get(obj, ELM_OBJ_WIDGET_CLASS); + Eina_Bool *ret = va_arg(*list, Eina_Bool *); + if (ret) *ret = EINA_FALSE; + Eina_Bool int_ret = EINA_FALSE; + + eo_do_super(obj, MY_CLASS, elm_wdg_on_focus(int_ret)); + if (!int_ret) return; + + if (elm_widget_focus_get(obj)) + { +elm_layout_signal_emit(wd-resize_obj, elm,action,focus, elm); +evas_object_focus_set(wd-resize_obj, EINA_TRUE); + } + else + { +elm_layout_signal_emit(wd-resize_obj, elm,action,unfocus, elm); +evas_object_focus_set(wd-resize_obj, EINA_FALSE); + } + + if (ret) *ret = EINA_TRUE; +} + EAPI void elm_thumb_file_set(Evas_Object *obj, const char *file, @@ -1202,6 +1227,8 @@ _class_constructor(Eo_Class *klass) EO_OP_FUNC(EVAS_OBJ_SMART_ID(EVAS_OBJ_SMART_SUB_ID_SHOW), _elm_thumb_smart_show), EO_OP_FUNC(EVAS_OBJ_SMART_ID(EVAS_OBJ_SMART_SUB_ID_HIDE), _elm_thumb_smart_hide), +EO_OP_FUNC(ELM_WIDGET_ID(ELM_WIDGET_SUB_ID_ON_FOCUS), _elm_thumb_smart_on_focus), + EO_OP_FUNC(ELM_OBJ_THUMB_ID(ELM_OBJ_THUMB_SUB_ID_RELOAD), _reload), EO_OP_FUNC(ELM_OBJ_THUMB_ID(ELM_OBJ_THUMB_SUB_ID_FILE_SET), _file_set), EO_OP_FUNC(ELM_OBJ_THUMB_ID(ELM_OBJ_THUMB_SUB_ID_FILE_GET), _file_get), --
[EGIT] [core/elementary] master 01/02: elm_test: Fixed formatting. tab to space.
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=665f184485cc29e95bb9c84250bde81b2766c366 commit 665f184485cc29e95bb9c84250bde81b2766c366 Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Mon Oct 14 14:40:35 2013 +0900 elm_test: Fixed formatting. tab to space. Changed tab to space before working on the code. Kinda surprised by the number of tabs we had. --- src/bin/elementary_codegen.c | 10 +-- src/bin/elm_prefs_cc_handlers.c| 4 +- src/bin/elm_prefs_cc_parse.c | 6 +- src/bin/quicklaunch.c | 86 ++-- src/bin/run.c | 160 ++--- src/bin/test_access.c | 2 +- src/bin/test_application_server.c | 2 +- src/bin/test_gengrid.c | 2 +- src/bin/test_main_menu.c | 2 +- src/bin/test_map.c | 2 +- src/bin/test_notify.c | 4 +- src/bin/test_photocam.c| 4 +- src/bin/test_scaling.c | 18 ++--- src/bin/test_thumb.c | 4 +- src/bin/test_weather.c | 2 +- src/bin/test_win_plug.c| 6 +- src/bin/test_win_socket.c | 32 src/lib/elm_calendar.c | 106 src/lib/elm_conform.c | 20 ++--- src/lib/elm_image.c| 26 +++--- src/lib/elm_interface_scrollable.c | 12 +-- src/lib/elm_layout.c | 2 +- src/lib/elm_main.c | 4 +- src/lib/elm_map.c | 6 +- src/lib/elm_menu.c | 4 +- src/lib/elm_thumb.c| 8 +- src/lib/elm_widget.c | 4 +- src/lib/elm_win.c | 2 +- 28 files changed, 270 insertions(+), 270 deletions(-) diff --git a/src/bin/elementary_codegen.c b/src/bin/elementary_codegen.c index 5bf9a2c..319c06e 100644 --- a/src/bin/elementary_codegen.c +++ b/src/bin/elementary_codegen.c @@ -100,10 +100,10 @@ static FILE *header_fd = NULL; return elm_layout_content_unset(o, \%s\);\n \ }\n\n -#define H_CODEGEN_PART_CONTENT_SET \ +#define H_CODEGEN_PART_CONTENT_SET\ void %s_%s_set(Evas_Object *o, Evas_Object *value);\n -#define H_CODEGEN_PART_TEXT_SET\ +#define H_CODEGEN_PART_TEXT_SET \ void %s_%s_set(Evas_Object *o, const char *value);\n #define H_CODEGEN_PART_CONTENT_UNSET\ @@ -116,7 +116,7 @@ static FILE *header_fd = NULL; return elm_layout_content_get(o, \%s\);\n \ }\n\n -#define H_CODEGEN_PART_CONTENT_GET\ +#define H_CODEGEN_PART_CONTENT_GET \ Evas_Object *%s_%s_get(const Evas_Object *o);\n #define C_CODEGEN_PART_TEXT_GET\ @@ -126,7 +126,7 @@ static FILE *header_fd = NULL; return elm_layout_text_get(o, \%s\);\n\ }\n\n -#define H_CODEGEN_PART_TEXT_GET\ +#define H_CODEGEN_PART_TEXT_GET\ const char *%s_%s_get(const Evas_Object *o);\n #define C_CODEGEN_PART_BOX_APPEND\ @@ -234,7 +234,7 @@ static FILE *header_fd = NULL; elm_layout_signal_emit(o, \%s\, \%s\);\n \ }\n\n -#define H_CODEGEN_PROGRAM_EMIT \ +#define H_CODEGEN_PROGRAM_EMIT \ void %s_%s_emit(Evas_Object *o);\n #define C_CODEGEN_PROGRAM_CALLBACK_ADD \ diff --git a/src/bin/elm_prefs_cc_handlers.c b/src/bin/elm_prefs_cc_handlers.c index aadc372..93577ed 100644 --- a/src/bin/elm_prefs_cc_handlers.c +++ b/src/bin/elm_prefs_cc_handlers.c @@ -241,9 +241,9 @@ static void st_collection_page_autosave(void); @li SWALLOW - Swallows an Evas_Object. @li SAVE - Button that will get all the values bounded to items and save it on CFG file. - @li ACTION - Button that will emit a signal to .C file and call a +@li ACTION - Button that will emit a signal to .C file and call a smart callback. - @li RESET - Button that will return all the values bounded to items +@li RESET - Button that will return all the values bounded to items as default declared on .EPC file. @endproperty diff --git a/src/bin/elm_prefs_cc_parse.c b/src/bin/elm_prefs_cc_parse.c index 8e2bae3..747c732 100644 --- a/src/bin/elm_prefs_cc_parse.c +++ b/src/bin/elm_prefs_cc_parse.c @@ -925,10 +925,10 @@ check_min_arg_count(int min_required_args) if (num_args min_required_args) { - ERR(%s:%i got %i arguments, but expected at least %i, - file_in, line - 1, num_args, min_required_args); +ERR(%s:%i got %i arguments, but expected at least %i, +file_in, line - 1, num_args, min_required_args);
[EGIT] [core/elementary] master 01/01: Author: Added Amitesh Singh as an author of elm as he is worth it.
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=7fafe5fc6d7c269b59aa67607e8148e005af6a0b commit 7fafe5fc6d7c269b59aa67607e8148e005af6a0b Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Mon Oct 14 19:18:19 2013 +0900 Author: Added Amitesh Singh as an author of elm as he is worth it. --- AUTHORS | 1 + src/lib/elm_authors.h | 1 + 2 files changed, 2 insertions(+) diff --git a/AUTHORS b/AUTHORS index a98a82e..e7aba6e 100644 --- a/AUTHORS +++ b/AUTHORS @@ -82,3 +82,4 @@ Ryuan Choi (ryuan) ryuan.c...@samsung.com ryuan.c...@gmail.com Hosang Kim hosang12@samsung.com Youngbok Shin youngb.s...@samsung.com Niraj Kumar niraj...@samsung.com niraj.kumar@gmail.com +Amitesh Singh singh.amit...@gmail.com diff --git a/src/lib/elm_authors.h b/src/lib/elm_authors.h index 3045c29..ebaf0c7 100644 --- a/src/lib/elm_authors.h +++ b/src/lib/elm_authors.h @@ -84,6 +84,7 @@ * @author Hosang Kim hosang12.kim@@samsung.com * @author Youngbok Shin youngb.shin@@samsung.com * @author Niraj Kumar niraj.kr@@samsung.com niraj.kumar.ait@@gmail.com + * @author Amitesh Singh singh.amitesh@@gmail.com * * Please contact enlightenment-devel@lists.sourceforge.net to get in * contact with the developers and maintainers. --
[EGIT] [core/elementary] master 01/01: test_progress.c: Added new test case for vertical progress status
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=c673a70e8583269e470a2dc315e0bbc886f928e9 commit c673a70e8583269e470a2dc315e0bbc886f928e9 Author: Niraj Kumar jiraj...@samsung.com Date: Mon Oct 14 19:38:19 2013 +0900 test_progress.c: Added new test case for vertical progress status Summary: Added new test case for vertical progress status .This would be visible under Progressbar 2 elementary test Reviewers: seoz, singh.amitesh Differential Revision: https://phab.enlightenment.org/D233 --- data/themes/images/bt_recording.png | Bin 0 - 495 bytes data/themes/widgets/progressbar.edc | 364 +++- src/bin/test_progressbar.c | 67 +-- 3 files changed, 159 insertions(+), 272 deletions(-) diff --git a/data/themes/images/bt_recording.png b/data/themes/images/bt_recording.png new file mode 100755 index 000..e5937ba Binary files /dev/null and b/data/themes/images/bt_recording.png differ diff --git a/data/themes/widgets/progressbar.edc b/data/themes/widgets/progressbar.edc index ff3b535..de826b9 100644 --- a/data/themes/widgets/progressbar.edc +++ b/data/themes/widgets/progressbar.edc @@ -846,148 +846,14 @@ group { name: elm/progressbar/horizontal/wheel; } } - /// -group { name: elm/progressbar/horizontal/recording; +group { name: elm/progressbar/horizontal/double; + inherit: elm/progressbar/horizontal/default; images { - image: shelf_inset.png COMP; - image: bt_sm_base2.png COMP; - image: flip_shad.png COMP; + image: bt_recording.png COMP; } parts { - part { name: elm.background.progressbar; - type: RECT; - mouse_events: 0; - description { state: default 0.0; -rel1 { - relative: 0.0 0.0; - offset: 0 0; -} -rel2 { - relative: 1.0 1.0; -} - } - } - part { name: elm.swallow.bar; - mouse_events: 0; - scale: 1; - type: SWALLOW; - description { -min: 48 28; -max: 9 28; state: default 0.0; -rel1 { - to_x: elm.text; - to_y: elm.background.progressbar; - relative: 1.0 0.0; -} -rel2 { - to: elm.background.progressbar; - relative: 1.0 1.0; -} - } - } - part { name: elm.swallow.content; - type: SWALLOW; - description { state: default 0.0; -visible: 0; -align: 0.0 0.5; -rel1 { - offset: 4 0; - to_y: elm.background.progressbar; -} -rel2 { - offset: 3 -1; - relative: 0.0 1.0; - to_y: elm.background.progressbar; -} - } - description { state: visible 0.0; -inherit: default 0.0; -visible: 1; -aspect: 1.0 1.0; -aspect_preference: VERTICAL; -rel2.offset: 4 -1; - } - } - part { name: elm.text; - type: TEXT; - mouse_events: 0; - scale: 1; - description { state: default 0.0; -visible: 0; -fixed: 1 1; -align: 0.0 0.5; -rel1.to_x: elm.swallow.content; -rel1.relative: 1.0 0.0; -rel1.offset: -1 4; -rel2.to_x: elm.swallow.content; -rel2.relative: 1.0 1.0; -rel2.offset: -1 -5; -color: 0 0 0 255; -text { - font: Sans,Edje-Vera; - size: 10; - min: 0 0; - align: 0.0 0.5; -} - } - description { state: visible 0.0; -inherit: default 0.0; -visible: 1; -text.min: 1 1; -rel1.offset: 0 4; -rel2.offset: 0 -5; - } - } - part { name: background; - mouse_events: 0; - clip_to: elm.background.progressbar; - description { -state: default 0.0; -rel1 { - to: elm.swallow.bar; - relative: 0.0 0.0; -} -rel2 { - to: elm.swallow.bar; - relative: 1.0 1.0; - offset: -1 -1; -} -image { - normal: shelf_inset.png; - border: 7 7 7 7; -} - } - } - part { name: elm.text.status; - type: TEXT; - mouse_events: 0; - description { state: default 0.0; -fixed: 1 1; -visible: 0; -rel1 { - to: background; - relative: 0.5 0.5; -} -rel2 { - to: background; - relative: 0.5 0.5; -
[EGIT] [core/efl] master 07/07: efreet: No need to set pointer value
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c7c08b0e3eb8881738d5df160f290c6938234f7b commit c7c08b0e3eb8881738d5df160f290c6938234f7b Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 13:22:34 2013 +0200 efreet: No need to set pointer value CID 1039919 --- src/tests/efreet/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/efreet/main.c b/src/tests/efreet/main.c index e808992..01cdce5 100644 --- a/src/tests/efreet/main.c +++ b/src/tests/efreet/main.c @@ -123,7 +123,7 @@ main(int argc, char ** argv) { for (i = 0; tests[i].name; i++) printf(%s\n, tests[i].name); - run = eina_list_free(run); + eina_list_free(run); return 0; } run = eina_list_append(run, argv[i]); --
[EGIT] [core/efl] master 02/07: efreet: Check if count != 0
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6b18d7b80a45443e5d237bec0af1560e341e23f6 commit 6b18d7b80a45443e5d237bec0af1560e341e23f6 Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 11:57:01 2013 +0200 efreet: Check if count != 0 CID 1039434 --- src/tests/efreet/efreet_icon_cache_dump.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tests/efreet/efreet_icon_cache_dump.c b/src/tests/efreet/efreet_icon_cache_dump.c index d1cb126..321edda 100644 --- a/src/tests/efreet/efreet_icon_cache_dump.c +++ b/src/tests/efreet/efreet_icon_cache_dump.c @@ -55,7 +55,9 @@ dump(Efreet_Icon_Theme *theme) free(keys); start = ecore_time_get() - start; -avg = start / count; +avg = 0; +if (count 0) +avg = start / count; printf(read: %s - %u paths (time: %f) (avg %f)\n, theme-name.internal, count, start, avg); eet_close(ef); eet_clearcache(); --
[EGIT] [core/efl] master 01/07: efreet: Always '\0' terminate buf
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=7f303060311e7e209f8acdc62101fa5064be389c commit 7f303060311e7e209f8acdc62101fa5064be389c Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 11:54:51 2013 +0200 efreet: Always '\0' terminate buf CID 1039721 --- src/lib/efreet/efreet_trash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/efreet/efreet_trash.c b/src/lib/efreet/efreet_trash.c index 1301b83..e759247 100644 --- a/src/lib/efreet/efreet_trash.c +++ b/src/lib/efreet/efreet_trash.c @@ -111,6 +111,7 @@ efreet_trash_dir_get(const char *file) if (s_src.st_dev == s_dest.st_dev) { strncpy(buf, dir, PATH_MAX); +buf[PATH_MAX - 1] = 0; continue; } else --
[EGIT] [core/efl] master 06/07: efreet: Check buffer size
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=76721f415368b45d2d780e44faaf8b57a0b468e9 commit 76721f415368b45d2d780e44faaf8b57a0b468e9 Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 13:21:48 2013 +0200 efreet: Check buffer size CID 1039582, 1039583 --- src/lib/efreet/efreet_menu.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/lib/efreet/efreet_menu.c b/src/lib/efreet/efreet_menu.c index 739e9c1..b6103eb 100644 --- a/src/lib/efreet/efreet_menu.c +++ b/src/lib/efreet/efreet_menu.c @@ -3177,7 +3177,10 @@ efreet_menu_app_dir_scan(Efreet_Menu_Internal *internal, const char *path, const if (id) snprintf(buf2, sizeof(buf2), %s-%s, id, fname); else -strcpy(buf2, fname); +{ +strncpy(buf2, fname, PATH_MAX); +buf2[PATH_MAX - 1] = '\0'; +} if (info-type == EINA_FILE_DIR) { @@ -3285,7 +3288,10 @@ efreet_menu_directory_dir_scan(const char *path, const char *relative_path, if (relative_path) snprintf(buf2, sizeof(buf2), %s/%s, relative_path, fname); else -strcpy(buf2, fname); +{ +strncpy(buf2, fname, PATH_MAX); +buf2[PATH_MAX - 1] = '\0'; +} if (info-type == EINA_FILE_DIR) efreet_menu_directory_dir_scan(info-path, buf2, cache); --
[EGIT] [core/efl] master 05/07: efreet: Set umask before creating temporary file
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=e2dabc5d23c60a9faa79b4c5357da2a944c5272f commit e2dabc5d23c60a9faa79b4c5357da2a944c5272f Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 13:20:44 2013 +0200 efreet: Set umask before creating temporary file CID 1039615 --- src/bin/efreet/efreetd.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bin/efreet/efreetd.c b/src/bin/efreet/efreetd.c index fd4e8a0..18fc500 100644 --- a/src/bin/efreet/efreetd.c +++ b/src/bin/efreet/efreetd.c @@ -28,13 +28,17 @@ main(int argc, char *argv[]) { char path[PATH_MAX]; FILE *log; + mode_t um; strcpy(path, /tmp/efreetd_XX); + um = umask(0077); if (mkstemp(path) 0) { perror(mkstemp); +umask(um); return 1; } + umask(um); if (chmod(path, 0700) 0) { perror(chmod); --
[EGIT] [core/efl] master 04/07: efreet: Set umask before creating temp file
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=67a8feeb08e9dd6e58a1fb148a826e781ca5260d commit 67a8feeb08e9dd6e58a1fb148a826e781ca5260d Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 13:19:59 2013 +0200 efreet: Set umask before creating temp file CID 1039616 --- src/bin/efreet/efreet_desktop_cache_create.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/bin/efreet/efreet_desktop_cache_create.c b/src/bin/efreet/efreet_desktop_cache_create.c index 577091f..2fc6e91 100644 --- a/src/bin/efreet/efreet_desktop_cache_create.c +++ b/src/bin/efreet/efreet_desktop_cache_create.c @@ -225,6 +225,7 @@ main(int argc, char **argv) int i; char file[PATH_MAX] = { '\0' }; char util_file[PATH_MAX] = { '\0' }; +mode_t um; if (!eina_init()) goto eina_error; _efreet_desktop_cache_log_dom = @@ -296,14 +297,20 @@ main(int argc, char **argv) /* create cache */ snprintf(file, sizeof(file), %s.XX, efreet_desktop_cache_file()); +/* set secure umask for temporary files */ +um = umask(0077); tmpfd = mkstemp(file); +umask(um); if (tmpfd 0) goto error; close(tmpfd); ef = eet_open(file, EET_FILE_MODE_READ_WRITE); if (!ef) goto error; snprintf(util_file, sizeof(util_file), %s.XX, efreet_desktop_util_cache_file()); +/* set secure umask for temporary files */ +um = umask(0077); tmpfd = mkstemp(util_file); +umask(um); if (tmpfd 0) goto error; close(tmpfd); util_ef = eet_open(util_file, EET_FILE_MODE_READ_WRITE); --
[EGIT] [core/efl] master 03/07: efreet: Check size of buffer and '\0' terminate
englebass pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=cc89eb2af953aaadf2c5f2f252169497916e272a commit cc89eb2af953aaadf2c5f2f252169497916e272a Author: Sebastian Dransfeld sebastian.dransf...@sintef.no Date: Mon Oct 14 13:07:43 2013 +0200 efreet: Check size of buffer and '\0' terminate CID 1039595 --- src/bin/efreet/efreet_desktop_cache_create.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bin/efreet/efreet_desktop_cache_create.c b/src/bin/efreet/efreet_desktop_cache_create.c index 4a25575..577091f 100644 --- a/src/bin/efreet/efreet_desktop_cache_create.c +++ b/src/bin/efreet/efreet_desktop_cache_create.c @@ -152,7 +152,10 @@ cache_scan(const char *path, const char *base_id, int priority, int recurse, int if (*base_id) snprintf(id, sizeof(id), %s-%s, base_id, fname); else -strcpy(id, fname); +{ +strncpy(id, fname, PATH_MAX); +id[PATH_MAX - 1] = '\0'; +} file_id = id; } --
[EGIT] [core/enlightenment] master 01/01: Another attempt at odd TV resolution fix.
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=07fa7e4a13389779e7e950e8a034ba72f59fb5ea commit 07fa7e4a13389779e7e950e8a034ba72f59fb5ea Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 12:25:48 2013 +0100 Another attempt at odd TV resolution fix. Mike, try this one live please Signed-off-by: Chris Michael cp.mich...@samsung.com --- src/bin/e_randr.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c index faf0c96..0b65a28 100644 --- a/src/bin/e_randr.c +++ b/src/bin/e_randr.c @@ -876,7 +876,6 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo printf(\t\t\tUsing Crtc Config %d for Cloning\n, crtc_cfg-xid); - /* we found a valid crtc for this output */ output_cfg-crtc = crtc_cfg-xid; output_cfg-exists = (output_cfg-crtc != 0); @@ -896,6 +895,7 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo { if (modes[c] == mode) { + printf(\t\t\t\tMode: %d\n, mode); can_clone = EINA_TRUE; break; } @@ -911,6 +911,7 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo ecore_x_randr_mode_size_get(ev-win, mode, mw, mh); +printf(\t\t\t\tMode: %d - %d x %d\n, mode, mw, mh); for (c = 0; c num; c++) { int cw, ch; @@ -918,11 +919,22 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo ecore_x_randr_mode_size_get(ev-win, modes[c], cw, ch); + if ((cw == mw) (ch == mh)) { mode = modes[c]; break; } + else + { + /* trap for dumb non-standard TV + * resolution of 1360 x 768 */ + if (((cw + 6) == mw) (ch == mh)) +{ + mode = modes[c]; + break; +} + } } } --
[EGIT] [core/efl] master 01/01: eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1c1b48ca64c4d13cfd3677cde1ee99e4cf6c2c15 commit 1c1b48ca64c4d13cfd3677cde1ee99e4cf6c2c15 Author: Cedric BAIL ced...@efl.so Date: Mon Oct 14 13:22:45 2013 +0200 eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity. --- src/lib/eina/eina_inline_lock_posix.x | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/eina/eina_inline_lock_posix.x b/src/lib/eina/eina_inline_lock_posix.x index 2e5b038..3d90929 100644 --- a/src/lib/eina/eina_inline_lock_posix.x +++ b/src/lib/eina/eina_inline_lock_posix.x @@ -608,10 +608,11 @@ eina_spinlock_take(Eina_Spinlock *spinlock) { if (errno == EBUSY) sched_yield(); else if (errno == EDEADLK) return EINA_LOCK_DEADLOCK; + else return EINA_LOCK_FAIL; } } while (t != 0); - return t ? EINA_LOCK_FAIL : EINA_LOCK_SUCCEED; + return EINA_LOCK_SUCCEED; #else return eina_lock_take(spinlock); #endif --
[EGIT] [core/efl] master 01/01: evas: fix CID 1102547 - Resource leak
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=15b9a640ac0bc14dce0af360e7c888f8674c8dff commit 15b9a640ac0bc14dce0af360e7c888f8674c8dff Author: Cedric BAIL ced...@efl.so Date: Mon Oct 14 13:37:50 2013 +0200 evas: fix CID 1102547 - Resource leak If all rectangle are clipped out, it is perfectly possible to return no rectangle, this would lead to a possible leak. --- src/lib/evas/common/evas_tiler.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/lib/evas/common/evas_tiler.c b/src/lib/evas/common/evas_tiler.c index b9f982a..9f0fef5 100644 --- a/src/lib/evas/common/evas_tiler.c +++ b/src/lib/evas/common/evas_tiler.c @@ -939,14 +939,14 @@ evas_common_tilebuf_get_render_rects(Tilebuf *tb) } return rects; } - + rbuf = malloc(sizeof(Tilebuf_Rect) * num); if (!rbuf) return NULL; - + for (i = 0, n = tb-rects.head; n; n = n-next) { rect_t cur; - + cur = ((rect_node_t *)n)-rect; RECTS_CLIP_TO_RECT(cur.left, cur.top, cur.width, cur.height, 0, 0, tb-outbuf_w, tb-outbuf_h); @@ -966,6 +966,10 @@ evas_common_tilebuf_get_render_rects(Tilebuf *tb) i++; } } + + // It is possible that due to the clipping we do not return any rectangle here. + if (!rects) free(rbuf); + return rects; } --
[EGIT] [core/efl] master 01/01: edje: fix CID 1062226 - Dereference after null check.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=12072b22179f3e48b4ad850f78e5b4ff5442208f commit 12072b22179f3e48b4ad850f78e5b4ff5442208f Author: Cedric BAIL ced...@efl.so Date: Mon Oct 14 13:45:26 2013 +0200 edje: fix CID 1062226 - Dereference after null check. It seems to be possible in some badly crafted edj to trigger that path. --- src/bin/edje/edje_cc_handlers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c index dc01352..9ad50f6 100644 --- a/src/bin/edje/edje_cc_handlers.c +++ b/src/bin/edje/edje_cc_handlers.c @@ -5192,9 +5192,8 @@ st_collections_group_parts_part_description_inherit(void) if (min_dst) { WRN(%s:%i: couldn't find an exact match in part '%s' when looking for '%s' %lf. Falling back to nearest one '%s' %lf., - file_in, line - 1, ep-name, parent_name, parent_val, parent-state.name, parent-state.value); + file_in, line - 1, ep-name, parent_name, parent_val, parent ? parent-state.name : NULL, parent ? parent-state.value : NULL); } - } if (!parent) --
[EGIT] [core/efl] master 01/01: edje: fix CID 1054522 - Logically dead code
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=48bc51b0c7a1062020415ea2ebf7f6076c1a1b4c commit 48bc51b0c7a1062020415ea2ebf7f6076c1a1b4c Author: Cedric BAIL ced...@efl.so Date: Mon Oct 14 13:53:06 2013 +0200 edje: fix CID 1054522 - Logically dead code The buffer is a static buffer in that scenario, so never going to be NULL indeed. --- src/bin/edje/epp/cpplib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bin/edje/epp/cpplib.c b/src/bin/edje/epp/cpplib.c index 42abad4..af65241 100644 --- a/src/bin/edje/epp/cpplib.c +++ b/src/bin/edje/epp/cpplib.c @@ -1888,7 +1888,6 @@ cpp_push_buffer(cpp_reader * pfile, unsigned char *buffer, long length) if (buf == pfile-buffer_stack) cpp_fatal(macro or `#include' recursion too deep); buf--; - if (!buf) return NULL; memset((char *)buf, 0, sizeof(cpp_buffer)); CPP_BUFFER(pfile) = buf; #else --
[EGIT] [core/efl] master 01/01: edje: typo fix.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=443012dbcb3de397e536ec2afac0273b7e8cfff9 commit 443012dbcb3de397e536ec2afac0273b7e8cfff9 Author: Cedric BAIL ced...@efl.so Date: Mon Oct 14 14:00:59 2013 +0200 edje: typo fix. --- src/bin/edje/edje_cc_handlers.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c index 9ad50f6..dc9a024 100644 --- a/src/bin/edje/edje_cc_handlers.c +++ b/src/bin/edje/edje_cc_handlers.c @@ -4966,8 +4966,7 @@ _copied_map_colors_get(Edje_Part_Description_Common *parent) int i; if (parent-map.colors_count == 0) return NULL; - colors = (Edje_Map_Color **) malloc(sizeof(Edje_Map_Color **) * - parent-map.colors_count); + colors = malloc(sizeof(Edje_Map_Color *) * parent-map.colors_count); for (i = 0; i (int)parent-map.colors_count; i++) { @@ -5192,7 +5191,7 @@ st_collections_group_parts_part_description_inherit(void) if (min_dst) { WRN(%s:%i: couldn't find an exact match in part '%s' when looking for '%s' %lf. Falling back to nearest one '%s' %lf., - file_in, line - 1, ep-name, parent_name, parent_val, parent ? parent-state.name : NULL, parent ? parent-state.value : NULL); + file_in, line - 1, ep-name, parent_name, parent_val, parent ? parent-state.name : NULL, parent ? parent-state.value : 0); } } --
[EGIT] [core/enlightenment] master 01/01: Finally fix odd TV resolution cloning
devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=a0e993f59b3ffb9c5cbc25e6c8705c264fe52221 commit a0e993f59b3ffb9c5cbc25e6c8705c264fe52221 Author: Chris Michael cp.mich...@samsung.com Date: Mon Oct 14 13:35:28 2013 +0100 Finally fix odd TV resolution cloning Signed-off-by: Chris Michael cp.mich...@samsung.com --- src/bin/e_randr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/e_randr.c b/src/bin/e_randr.c index 0b65a28..725046e 100644 --- a/src/bin/e_randr.c +++ b/src/bin/e_randr.c @@ -929,7 +929,7 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo { /* trap for dumb non-standard TV * resolution of 1360 x 768 */ - if (((cw + 6) == mw) (ch == mh)) + if ((abs(cw - mw) = 10) (ch == mh)) { mode = modes[c]; break; @@ -950,6 +950,7 @@ _e_randr_event_cb_output_change(void *data EINA_UNUSED, int type EINA_UNUSED, vo Eina_List *o; E_Randr_Output_Config *out; +c = 0; couts = malloc(ocount * sizeof(Ecore_X_Randr_Output)); EINA_LIST_FOREACH(crtc_cfg-outputs, o, out) { --
[EGIT] [core/elementary] master 01/01: elm_genlist.h: added 'full' style documentation.
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=48006ce6ffba7c540e6007226fc015c6ed21179b commit 48006ce6ffba7c540e6007226fc015c6ed21179b Author: Daniel Juyung Seo seojuyu...@gmail.com Date: Mon Oct 14 20:33:58 2013 +0900 elm_genlist.h: added 'full' style documentation. - 'full' style is so useful, it needs to have a documentation. - Do not use @ for 'since' in this case. That will cause line break and looks ugly. - reminded by ccxwrk. --- src/lib/elm_genlist.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/lib/elm_genlist.h b/src/lib/elm_genlist.h index 60f0af6..95a1aee 100644 --- a/src/lib/elm_genlist.h +++ b/src/lib/elm_genlist.h @@ -108,9 +108,17 @@ * @image html img/widget/genlist/preview-03.png * @image latex img/widget/genlist/preview-03.eps * - * - one_icon - Only 1 icon (left) @since 1.7 - * - end_icon - Only 1 icon (at end/right) @since 1.7 - * - no_icon - No icon (at end/right) @since 1.7 + * - one_icon - Only 1 icon (left) (since 1.7) + * - end_icon - Only 1 icon (at end/right) (since 1.7) + * - no_icon - No icon (at end/right) (since 1.7) + * - full - Only 1 icon, elm.swallow.content, which consumes whole area of + * genlist itemj (since 1.7) + * + * If one wants to use more icons and texts than are offered in theme, there + * are two solutions. One is to use 'full' style that has one big swallow part. + * You can swallow anything there. The other solution is to customize genlist + * item style in application side by using elm_theme_extension_add() and its + * own edc. Please refer @ref theme_example_01 for that. * * @section Genlist_Items Structure of items * --
[EGIT] [core/efl] master 01/01: eo: fix doxygen description, which is needed for parser
yakov pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ed8301b8bfc5faab23b76668acc79f88759ecef5 commit ed8301b8bfc5faab23b76668acc79f88759ecef5 Author: Yakov Goldberg yako...@samsung.com Date: Mon Oct 14 16:15:11 2013 +0300 eo: fix doxygen description, which is needed for parser --- src/lib/eo/Eo.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/lib/eo/Eo.h b/src/lib/eo/Eo.h index dc105b0..8ec503f 100644 --- a/src/lib/eo/Eo.h +++ b/src/lib/eo/Eo.h @@ -1103,6 +1103,7 @@ enum { #define eo_base_data_del(key) EO_BASE_ID(EO_BASE_SUB_ID_DATA_DEL), EO_TYPECHECK(const char *, key) /** + * @def eo_parent_set * @brief Set the parent of an object * @param[in] parent the new parent. * @@ -1116,6 +1117,7 @@ enum { #define eo_parent_set(parent) EO_BASE_ID(EO_BASE_SUB_ID_PARENT_SET), EO_TYPECHECK(Eo *, parent) /** + * @def eo_parent_get * @brief Get the parent of an object * @param[out] a pointer to the parent object. * @@ -1124,6 +1126,7 @@ enum { #define eo_parent_get(parent) EO_BASE_ID(EO_BASE_SUB_ID_PARENT_GET), EO_TYPECHECK(Eo **, parent) /** + * @def eo_children_iterator_new * @brief Get an iterator on all childrens * @param obj the object to get the childrens from. * @return a pointer to an Eina_Iterator containing all the childrens. @@ -1447,7 +1450,7 @@ struct _Eo_Callback_Array_Item EO_CALLBACK_PRIORITY_DEFAULT, data) /** - * @def eo_event_callback_priority_add + * @def eo_event_callback_array_priority_add * @brief Add a callback array for an event with a specific priority. * @param[in] array an #Eo_Callback_Array_Item of events to listen to. * @param[in] priority The priority of the callback. @@ -1460,7 +1463,7 @@ struct _Eo_Callback_Array_Item #define eo_event_callback_array_priority_add(array, priority, data) EO_BASE_ID(EO_BASE_SUB_ID_EVENT_CALLBACK_ARRAY_PRIORITY_ADD), EO_TYPECHECK(const Eo_Callback_Array_Item *, array), EO_TYPECHECK(Eo_Callback_Priority, priority), EO_TYPECHECK(const void *, data) /** - * @def eo_event_callback_del + * @def eo_event_callback_array_del * @brief Del a callback array with a specific data associated to it for an event. * @param[in] array an #Eo_Callback_Array_Item of events to listen to. * @param[in] user_data The data to compare. --
Re: [E-devel] [EGIT] [core/efl] master 01/01: eina - and e3fl in general - stop using eina_error_get/set - useless really
On Fri, Oct 11, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Fri, 11 Oct 2013 11:53:40 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Fri, Oct 11, 2013 at 4:50 AM, Carsten Haitzler ras...@rasterman.com wrote: raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=69e27abdc37f222183ce27f4ce0e3fe2a45ca590 commit 69e27abdc37f222183ce27f4ce0e3fe2a45ca590 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Fri Oct 11 16:49:13 2013 +0900 eina - and e3fl in general - stop using eina_error_get/set - useless really while it's not the best thing to use and many places forget to set the error, knowing which error happened may be useful -- in the same lines when you get an EINTR/EAGAIN from syscalls. By just not getting the results we want we fail to provide context on why it failed :-( i know. problem is that our current usage is broken anyway. i\eina has lots of locks etc. to be threadsafe... but the eina_error system simply isn't and pretty much cannot be, so it's already broken when you use eina from 1 thread. so i just made it always not working. at least it's consistently broken. :) Ugh? Just make it a thread-local value, as errno. -- Gustavo Sverzut Barbieri -- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [RFC] configure options for maintainers
simple and easy, why not? On Fri, Oct 11, 2013 at 11:43 PM, Jérôme Pinot ngc...@gmail.com wrote: Hi, During the Enlightenment French League^W^W dinner, we had this idea of having a configure option for the EFL to setup a string identifying the compiler/maintainer/distribution of the build. Several projects use this kind of string, for instance TexLive, LibreOffice or POV-Ray. It can be use to find quickly the maintainer, to generate automatic bug reports and most important, blame someone else (not you, no, really). There are several way to accomplish this during configuration: POV-Ray uses the COMPILED_BY=Main Tainer f...@bar.org environment variable TexLive uses --with-banner-add=Tex Live 2013/MyDistro Main Tainer f...@bar.org LibreOffice uses several options: --with-distro=MyDistro --with-vendor=Main Tainer f...@bar.org --with-build-version=42 It seems to me that the LibreOffice options are better. What do you think about this? -- Jérôme Pinot http://ngc891.blogdns.net/ -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Add configure option to disable cserve
On Sun, Oct 13, 2013 at 11:13 PM, Jean-Philippe Andre jp.an...@samsung.com wrote: jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b1437273890058ce9e84f5efd3195f8834d0f9c0 commit b1437273890058ce9e84f5efd3195f8834d0f9c0 Author: Jean-Philippe Andre jp.an...@samsung.com Date: Mon Oct 14 10:32:16 2013 +0900 evas: Add configure option to disable cserve Some people might want to disable cserve2 at build time to generate smaller packages. wasn't the plan to disable non-cserve2 case and just have it as the only option, making sure it works and so on? this go completely in the other direction... we used to have this option, removed on purpose -- Gustavo Sverzut Barbieri -- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/elementary] master 01/01: elementary/entry - filled a missed smart callback in the doc.
hermet pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=e49bb7b07862097c7ffaf5f2fb7925cad6cf159a commit e49bb7b07862097c7ffaf5f2fb7925cad6cf159a Author: ChunEon Park her...@hermet.pe.kr Date: Tue Oct 15 02:11:42 2013 +0900 elementary/entry - filled a missed smart callback in the doc. --- src/lib/elm_entry.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elm_entry.h b/src/lib/elm_entry.h index d1cbfdd..af22ccf 100644 --- a/src/lib/elm_entry.h +++ b/src/lib/elm_entry.h @@ -229,6 +229,7 @@ * @li selection,changed: The current selection has changed. * @li selection,cleared: The current selection has been cleared. * @li cursor,changed: The cursor has changed position. + * @li cursor,changed,manual: The cursor has changed position manually. * @li anchor,clicked: An anchor has been clicked. The event_info * parameter for the callback will be an #Elm_Entry_Anchor_Info. * @li anchor,in: Mouse cursor has moved into an anchor. The event_info --
[E-devel] Error compiling python bindings
To avoid word wrapping I attach a file containing the error message. -- Massimo Maiurana Ragusa (RG) Cythonizing efl/elementary/genlist.pyx Error compiling Cython file: ... ctypedef void(*Elm_Drag_Item_Container_Pos) (void *data, Evas_Object *cont, Elm_Object_Item *it, Evas_Coord x, Evas_Coord y, int xposret, int yposret, Elm_Xdnd_Action action) ctypedef Eina_Bool (*Elm_Drop_Item_Container_Cb) (void *data, Evas_Object *obj, Elm_Object_Item *it, Elm_Selection_Data *ev, int xposret, int yposret) struct _Elm_Drag_User_Info: Elm_Sel_Format format const char *data ^ efl/elementary/cnp_callbacks.pxi:28:19: Syntax error in C variable declaration Traceback (most recent call last): File setup.py, line 256, in module ext_modules = cythonize(modules, include_path=[include]), File /opt/e17/lib/python2.7/site-packages/Cython/Build/Dependencies.py, line 667, in cythonize cythonize_one(*args[1:]) File /opt/e17/lib/python2.7/site-packages/Cython/Build/Dependencies.py, line 731, in cythonize_one raise CompileError(None, pyx_file) Cython.Compiler.Errors.CompileError: efl/elementary/genlist.pyx -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon --
Re: [E-devel] Error compiling python bindings
2013/10/14 Massimo Maiurana maiur...@gmail.com To avoid word wrapping I attach a file containing the error message. Yup, sorry, and thanks for reporting. Fixed in git -- Massimo Maiurana Ragusa (RG) -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [website/planet] master 01/01: conf: @lfelipe blog has gone, drop it
beber pushed a commit to branch master. http://git.enlightenment.org/website/planet.git/commit/?id=b17475be1bdfe5fef900537689afa4df31a5d22c commit b17475be1bdfe5fef900537689afa4df31a5d22c Author: Bertrand Jacquin be...@meleeweb.net Date: Mon Oct 14 22:06:29 2013 +0200 conf: @lfelipe blog has gone, drop it --- conf/config.ini | 4 1 file changed, 4 deletions(-) diff --git a/conf/config.ini b/conf/config.ini index 40d4d84..fcdfc53 100644 --- a/conf/config.ini +++ b/conf/config.ini @@ -88,10 +88,6 @@ face = yes user = kakaroto name = ~Youness Alaoui -[http://strano.org/files/feed-efl.xml] -user = lfelipe -name = ~Luis Felipe Strano Moraes - [http://www.politreco.com/tag/efl/feed/] user = lucas name = ~Lucas De Marchi --
Re: [E-devel] Error compiling python bindings
Davide Andreoli, il 14/10/2013 21:31, ha scritto: Yup, sorry, and thanks for reporting. Fixed in git Confirmed, thanks :) -- Massimo Maiurana Ragusa (RG) -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
Let's just bump the minimum version requirement already. ;) 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore-con: make curl support entirely runtime loaded via eina_module
2013/10/10 Carsten Haitzler ras...@rasterman.com raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2c1c6b9335e38c6e52b06829a95d9b58d780c99e commit 2c1c6b9335e38c6e52b06829a95d9b58d780c99e Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Thu Oct 10 22:31:18 2013 +0900 ecore-con: make curl support entirely runtime loaded via eina_module It seems you forgot about ecore_file_download, there are still lots of #ifdef HAVE_CURL there. I can make it work removing all the ifdef but I'm not sure how to fix some conditional stuff, for example the ecore_file_download_protocol_available() func. can you give a look pleaze ? davemds this makes curl support a pure runtime-only thing. libcurl is loaded by eina_module (dlopen/dlsym) when curl is actually first needed (when a url connection/object is created). this means that ecore-con has no link or compile dependencies on curl, only runtime, AND this saves memory (due to curl inits using apparently a chunk of private pages). so this saves memory and moves the dependency to runtime (though still consider libcurl a dependency of efl - but like a binary executed, it's at runtime). --- ChangeLog |5 + NEWS |1 + configure.ac | 17 - src/lib/ecore_con/ecore_con_private.h |7 +- src/lib/ecore_con/ecore_con_url.c | 1074 - 5 files changed, 520 insertions(+), 584 deletions(-) -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/terminology] master 01/01: let me click on link while some strange bug is fixed
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=b10714adebb135ad077f67b2e06a36f991f83c36 commit b10714adebb135ad077f67b2e06a36f991f83c36 Author: Boris Faure bill...@gmail.com Date: Mon Oct 14 22:46:08 2013 +0200 let me click on link while some strange bug is fixed See T441 --- src/bin/termio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bin/termio.c b/src/bin/termio.c index fd5b62c..6f179e3 100644 --- a/src/bin/termio.c +++ b/src/bin/termio.c @@ -3182,6 +3182,7 @@ _smart_cb_mouse_out(void *data, Evas *e EINA_UNUSED, Evas_Object *obj, sd-mouse.cx = -1; sd-mouse.cy = -1; sd-link.suspend = EINA_FALSE; +_remove_links(sd, obj); } else { @@ -3191,7 +3192,8 @@ _smart_cb_mouse_out(void *data, Evas *e EINA_UNUSED, Evas_Object *obj, sd-mouse.cx = cx; sd-mouse.cy = cy; } - _remove_links(sd, obj); + if ((sd-mouse.cx 0) || (sd-mouse.cy 0)) + _remove_links(sd, obj); } static void --
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
2013/10/14 Kai Huuhko kai.huu...@gmail.com Let's just bump the minimum version requirement already. ;) I agree to raise the minimum, 0.19.0? 0.19.1? On jenkins we have 0.19.1 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/terminology] master 01/01: invisible should not show previous underline/strikethrough
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=55200014a9a75cd38b82241bf1c690da2be292be commit 55200014a9a75cd38b82241bf1c690da2be292be Author: Boris Faure bill...@gmail.com Date: Mon Oct 14 23:19:01 2013 +0200 invisible should not show previous underline/strikethrough --- src/bin/termio.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bin/termio.c b/src/bin/termio.c index 6f179e3..50f49e4 100644 --- a/src/bin/termio.c +++ b/src/bin/termio.c @@ -1240,6 +1240,8 @@ _smart_apply(Evas_Object *obj) else tc[x].bg = COL_INVIS; tc[x].bg_extended = 0; tc[x].double_width = 0; + tc[x].underline = 0; + tc[x].strikethrough = 0; } else { @@ -1287,6 +1289,8 @@ _smart_apply(Evas_Object *obj) if (inv) tc[x].bg = COL_INVERSEBG; else tc[x].bg = COL_INVIS; tc[x].bg_extended = 0; + tc[x].underline = 0; + tc[x].strikethrough = 0; #if defined(SUPPORT_DBLWIDTH) tc[x].double_width = cells[j].att.dblwidth; #endif --
[EGIT] [apps/terminology] master 01/01: fix CID 1106345 - missing parentheses
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=c4366ed2b57c685cb9130ff7c5b4105692cfa207 commit c4366ed2b57c685cb9130ff7c5b4105692cfa207 Author: Boris Faure bill...@gmail.com Date: Mon Oct 14 23:22:19 2013 +0200 fix CID 1106345 - missing parentheses --- src/bin/options_theme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/options_theme.c b/src/bin/options_theme.c index 84e06e9..79d6e7c 100644 --- a/src/bin/options_theme.c +++ b/src/bin/options_theme.c @@ -126,7 +126,7 @@ options_theme(Evas_Object *opbox, Evas_Object *term) { const char *ext = strchr(file, '.'); -if ((config) (!file[0] != '.') +if ((config) (file[0] != '.') ((ext) (!strcasecmp(.edj, ext { t = calloc(1, sizeof(Theme)); --
[EGIT] [apps/terminology] master 01/01: fix CID 1100640 - read from pointer after free
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=46839daa9a12601c980c888b4242324035133dea commit 46839daa9a12601c980c888b4242324035133dea Author: Boris Faure bill...@gmail.com Date: Mon Oct 14 23:25:55 2013 +0200 fix CID 1100640 - read from pointer after free --- src/bin/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/main.c b/src/bin/main.c index 41a1b2f..2ab785c 100644 --- a/src/bin/main.c +++ b/src/bin/main.c @@ -629,6 +629,7 @@ main_close(Evas_Object *win, Evas_Object *term) if (!sp-term) { _split_free(sp); + sp = NULL; if ((spp-parent) (spp-parent-s2 == spp)) slot = PANES_BOTTOM; _split_merge(spp, spkeep, slot); @@ -650,7 +651,7 @@ main_close(Evas_Object *win, Evas_Object *term) _term_focus(sp-term); _term_focus_show(sp, sp-term); } -_split_tabcount_update(sp, sp-term); +if (sp) _split_tabcount_update(sp, sp-term); } else { --
[EGIT] [apps/terminology] master 01/01: fix CID 1100641 - uninitialized scalar variable
billiob pushed a commit to branch master. http://git.enlightenment.org/apps/terminology.git/commit/?id=b66dc2a3a0c4fb09ef04283ab539f0432db1663d commit b66dc2a3a0c4fb09ef04283ab539f0432db1663d Author: Boris Faure bill...@gmail.com Date: Mon Oct 14 23:32:48 2013 +0200 fix CID 1100641 - uninitialized scalar variable --- src/bin/termio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/bin/termio.c b/src/bin/termio.c index 50f49e4..71c5123 100644 --- a/src/bin/termio.c +++ b/src/bin/termio.c @@ -1688,7 +1688,7 @@ _take_selection(Evas_Object *obj, Elm_Sel_Type type) Termio *sd = evas_object_smart_data_get(obj); int start_x = 0, start_y = 0, end_x = 0, end_y = 0; char *s = NULL; - size_t len; + size_t len = 0; if (!sd) return; if (sd-cur.sel) @@ -1725,7 +1725,10 @@ _take_selection(Evas_Object *obj, Elm_Sel_Type type) eina_strbuf_free(sb); } else if (!start_y !end_y !start_x !end_x sd-link.string) - s = strdup(sd-link.string); + { +len = strlen(sd-link.string); +s = strndup(sd-link.string, len); + } else if ((start_x != end_x) || (start_y != end_y)) { if ((start_y end_y) || ((start_y == end_y) (end_x start_x))) @@ -1738,7 +1741,7 @@ _take_selection(Evas_Object *obj, Elm_Sel_Type type) if (s) { -if (sd-win) +if ((sd-win) (len 0)) { sd-have_sel = EINA_FALSE; sd-reset_sel = EINA_FALSE; --
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
0.19 is fine IMO. 0.19.1 has mostly bugfixes. Users N.B.: We intend to eventually package a release of the bindings with only the generated C files that are used to compile the extension modules, Cython will not be needed to compile them. 2013/10/15 Davide Andreoli d...@gurumeditation.it 2013/10/14 Kai Huuhko kai.huu...@gmail.com Let's just bump the minimum version requirement already. ;) I agree to raise the minimum, 0.19.0? 0.19.1? On jenkins we have 0.19.1 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Creating enlightenment module with C++
Hello, This patch allows C++ code to #include installed headers for enlightenment to create modules in C++. Any comments are appreciated. Regards, -- Felipe Magno de Almeida c++.patch Description: Binary data -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
Speaking of cython, does setup.py need to print the cython version even when it's fine? It screws up things like setup.py --version. Date: Tue, 15 Oct 2013 01:12:10 +0300 From: kai.huu...@gmail.com To: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P 0.19 is fine IMO. 0.19.1 has mostly bugfixes. Users N.B.: We intend to eventually package a release of the bindings with only the generated C files that are used to compile the extension modules, Cython will not be needed to compile them. 2013/10/15 Davide Andreoli d...@gurumeditation.it 2013/10/14 Kai Huuhko kai.huu...@gmail.com Let's just bump the minimum version requirement already. ;) I agree to raise the minimum, 0.19.0? 0.19.1? On jenkins we have 0.19.1 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format - const char *data + const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
2013/10/15 Kai Huuhko kai.huu...@gmail.com 0.19 is fine IMO. 0.19.1 has mostly bugfixes. Users N.B.: We intend to eventually package a release of the bindings with only the generated C files that are used to compile the extension modules, Cython will not be needed to compile them. I'm not sure about this, Gustavo tried this before and we got lots of trouble from users. I don't remember the details but I think that the generated c files must stick with the exactly python version that was created on. Also installing cython 0.19 is exactly the same thing as the 0.17, so I don't see any issue for the users. 2013/10/15 Davide Andreoli d...@gurumeditation.it 2013/10/14 Kai Huuhko kai.huu...@gmail.com Let's just bump the minimum version requirement already. ;) I agree to raise the minimum, 0.19.0? 0.19.1? On jenkins we have 0.19.1 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: ecore-file - remove ifdefs for HAVE_CULR since ecore-con always has it
raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ea9963f469c5de5d0b1e6707fa82ce9e57fe29c7 commit ea9963f469c5de5d0b1e6707fa82ce9e57fe29c7 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Tue Oct 15 09:16:26 2013 +0900 ecore-file - remove ifdefs for HAVE_CULR since ecore-con always has it now that it's runtime dlopen'ed etc. ecore-con always has url support via curl so ecore-file needs to assume that this can always work and this just use ecore-con-url anyway. --- src/lib/ecore_file/ecore_file_download.c | 24 1 file changed, 24 deletions(-) diff --git a/src/lib/ecore_file/ecore_file_download.c b/src/lib/ecore_file/ecore_file_download.c index 92a701b..e8fdf4c 100644 --- a/src/lib/ecore_file/ecore_file_download.c +++ b/src/lib/ecore_file/ecore_file_download.c @@ -26,7 +26,6 @@ struct _Ecore_File_Download_Job Ecore_File_Download_Progress_Cb progress_cb; }; -#ifdef HAVE_CURL Ecore_File_Download_Job *_ecore_file_download_curl(const char *url, const char *dst, Ecore_File_Download_Completion_Cb completion_cb, Ecore_File_Download_Progress_Cb progress_cb, @@ -35,7 +34,6 @@ Ecore_File_Download_Job *_ecore_file_download_curl(const char *url, const char * static Eina_Bool _ecore_file_download_url_complete_cb(void *data, int type, void *event); static Eina_Bool _ecore_file_download_url_progress_cb(void *data, int type, void *event); -#endif static Ecore_Event_Handler *_url_complete_handler = NULL; static Ecore_Event_Handler *_url_progress_download = NULL; @@ -54,10 +52,8 @@ ecore_file_download_init(void) ecore_con_shutdown(); return 0; } -#ifdef HAVE_CURL _url_complete_handler = ecore_event_handler_add(ECORE_CON_EVENT_URL_COMPLETE, _ecore_file_download_url_complete_cb, NULL); _url_progress_download = ecore_event_handler_add(ECORE_CON_EVENT_URL_PROGRESS, _ecore_file_download_url_progress_cb, NULL); -#endif return 1; } @@ -77,7 +73,6 @@ ecore_file_download_shutdown(void) ecore_con_shutdown(); } -# ifdef HAVE_CURL static Eina_Bool _ecore_file_download_headers_foreach_cb(const Eina_Hash *hash EINA_UNUSED, const void *key, void *data, void *fdata) { @@ -86,7 +81,6 @@ _ecore_file_download_headers_foreach_cb(const Eina_Hash *hash EINA_UNUSED, const return EINA_TRUE; } -# endif static Eina_Bool _ecore_file_download(const char *url, @@ -131,7 +125,6 @@ _ecore_file_download(const char *url, else return EINA_FALSE; } -#ifdef HAVE_CURL else if ((!strncmp(url, http://;, 7)) || (!strncmp(url, https://;, 8)) || (!strncmp(url, ftp://;, 6))) { @@ -148,18 +141,6 @@ _ecore_file_download(const char *url, return EINA_FALSE; } } -#else - else if ((!strncmp(url, http://;, 7)) || (!strncmp(url, https://;, 8)) || -(!strncmp(url, ftp://;, 6))) - { -(void)completion_cb; -(void)progress_cb; -(void)data; -(void)job_ret; -(void)headers; -return EINA_FALSE; - } -#endif else { return EINA_FALSE; @@ -251,15 +232,12 @@ EAPI Eina_Bool ecore_file_download_protocol_available(const char *protocol) { if (!strncmp(protocol, file://, 7)) return EINA_TRUE; -#ifdef HAVE_CURL else if (!strncmp(protocol, http://;, 7)) return EINA_TRUE; else if (!strncmp(protocol, ftp://;, 6)) return EINA_TRUE; -#endif return EINA_FALSE; } -# ifdef HAVE_CURL static int _ecore_file_download_url_compare_job(const void *data1, const void *data2) { @@ -391,9 +369,7 @@ ecore_file_download_abort(Ecore_File_Download_Job *job) if (job-completion_cb) job-completion_cb(ecore_con_url_data_get(job-url_con), job-dst, 1); -#ifdef HAVE_CURL ecore_con_url_free(job-url_con); -#endif _job_list = eina_list_remove(_job_list, job); fclose(job-file); free(job-dst); --
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Add configure option to disable cserve
On Mon, 14 Oct 2013 12:24:41 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Sun, Oct 13, 2013 at 11:13 PM, Jean-Philippe Andre jp.an...@samsung.com wrote: jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b1437273890058ce9e84f5efd3195f8834d0f9c0 commit b1437273890058ce9e84f5efd3195f8834d0f9c0 Author: Jean-Philippe Andre jp.an...@samsung.com Date: Mon Oct 14 10:32:16 2013 +0900 evas: Add configure option to disable cserve Some people might want to disable cserve2 at build time to generate smaller packages. wasn't the plan to disable non-cserve2 case and just have it as the only option, making sure it works and so on? this go completely in the other direction... we used to have this option, removed on purpose gustavo is right. we have too many paths of execution in efl in general - and unless it's onby default they basically don't get tested. the entire image loading etc. stuff is better served in cserve, one of the big reasons being memory efficiency (we use 3rd party libs like libpng, libjpeg, libtiff etc. a lot) and these libs come with lots of rw pages on their own, and thus bloat out the memory of every process once they touch such a file format. the loader binary slaves for cserve is in fact a great idea. they can be killed off after inactivity and cycle. but even better, they can CRASH and not take your app down. this is a major win. loading of data is one of the major vectors for attack security-wise and where if we have a bug, it can cause progrqms to become vulnerable to attacks via show this jpeg (if your app is an email client for example). keeping the attack surface small is a good thing. but it also helps out for all the mmap io we do. an mmaped file will cause a sigbus when you hit an io error. we patched over that with eina but its rather evil and eventually will fill memory with zero page turds. the above cycling cleans that out. so cserve is better for more than just sharing. and to ensure our codebase is SIMPLER... we want to move to the path of cserve being the ONLY path. it also opens up future possibilities if we have a daemon manager/broker always there. (hell - we could move RENDERING out-of-process... ok i can't think of a really viable reason why right now, but it's just to illustrate). :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore-con: make curl support entirely runtime loaded via eina_module
On Mon, 14 Oct 2013 22:34:05 +0200 Davide Andreoli d...@gurumeditation.it said: 2013/10/10 Carsten Haitzler ras...@rasterman.com raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2c1c6b9335e38c6e52b06829a95d9b58d780c99e commit 2c1c6b9335e38c6e52b06829a95d9b58d780c99e Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Thu Oct 10 22:31:18 2013 +0900 ecore-con: make curl support entirely runtime loaded via eina_module It seems you forgot about ecore_file_download, there are still lots of #ifdef HAVE_CURL there. I can make it work removing all the ifdef but I'm not sure how to fix some conditional stuff, for example the ecore_file_download_protocol_available() func. can you give a look pleaze ? fixed. the available - there really isnt much of a choice but to assume its always available without adding api that tries to TEST a dlopen cycle load which basically forces the load and thus negates the memory savings... :( davemds this makes curl support a pure runtime-only thing. libcurl is loaded by eina_module (dlopen/dlsym) when curl is actually first needed (when a url connection/object is created). this means that ecore-con has no link or compile dependencies on curl, only runtime, AND this saves memory (due to curl inits using apparently a chunk of private pages). so this saves memory and moves the dependency to runtime (though still consider libcurl a dependency of efl - but like a binary executed, it's at runtime). --- ChangeLog |5 + NEWS |1 + configure.ac | 17 - src/lib/ecore_con/ecore_con_private.h |7 +- src/lib/ecore_con/ecore_con_url.c | 1074 - 5 files changed, 520 insertions(+), 584 deletions(-) -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: eina - and e3fl in general - stop using eina_error_get/set - useless really
On Mon, 14 Oct 2013 12:18:26 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Fri, Oct 11, 2013 at 10:20 PM, Carsten Haitzler ras...@rasterman.com wrote: On Fri, 11 Oct 2013 11:53:40 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Fri, Oct 11, 2013 at 4:50 AM, Carsten Haitzler ras...@rasterman.com wrote: raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=69e27abdc37f222183ce27f4ce0e3fe2a45ca590 commit 69e27abdc37f222183ce27f4ce0e3fe2a45ca590 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Fri Oct 11 16:49:13 2013 +0900 eina - and e3fl in general - stop using eina_error_get/set - useless really while it's not the best thing to use and many places forget to set the error, knowing which error happened may be useful -- in the same lines when you get an EINTR/EAGAIN from syscalls. By just not getting the results we want we fail to provide context on why it failed :-( i know. problem is that our current usage is broken anyway. i\eina has lots of locks etc. to be threadsafe... but the eina_error system simply isn't and pretty much cannot be, so it's already broken when you use eina from 1 thread. so i just made it always not working. at least it's consistently broken. :) Ugh? Just make it a thread-local value, as errno. i considered that, but: http://gcc.gnu.org/onlinedocs/gcc-4.8.1/gcc/Thread_002dLocal.html#Thread_002dLocal or more specifically what bothers me is It requires significant support from the linker (ld), dynamic linker (ld.so), and system libraries (libc.so and libpthread.so), so it is not available everywhere. i can see how it is majorly problematic to have thread local storage implemented at all, as you now need pthread on create or join to magically allocate and then deallocate all the tls vars. btw... you need to count the number of eina_error_get()'s in efl... (as the MOST common use for an eina error would be checking allocation failure on list append, hash add etc.). it's basically not used. that's a core major issue with it. while technically correct to have, it is practically useless and unused because of the insane amount of code needed to handle such errors everywhere and unwind etc. :( if we fail to allocate a list node entry... or a hash entry... we're in DEEEP trouble memory-wise. we can't recover basically. anything we do to recover invariably may aqllocate some of this memory in the process of recovery... and repeat. -- Gustavo Sverzut Barbieri -- Mobile: +55 (19) 9225-2202 Contact: http://www.gustavobarbieri.com.br/contact -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: ecore_file: fix left over borking.
cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=48b0f8515a738aed2d11845966fbfbd618f1f75a commit 48b0f8515a738aed2d11845966fbfbd618f1f75a Author: Cedric Bail cedric.b...@samsung.com Date: Tue Oct 15 10:21:03 2013 +0900 ecore_file: fix left over borking. I think I teached raster well, my job here is done ! --- src/lib/ecore_file/ecore_file_download.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib/ecore_file/ecore_file_download.c b/src/lib/ecore_file/ecore_file_download.c index e8fdf4c..9ec113f 100644 --- a/src/lib/ecore_file/ecore_file_download.c +++ b/src/lib/ecore_file/ecore_file_download.c @@ -347,7 +347,6 @@ _ecore_file_download_curl(const char *url, const char *dst, return job; } -#endif /** * @brief Abort the given download job and call the completion_cb --
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Add configure option to disable cserve
On Tue, Oct 15, 2013 at 9:13 AM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 14 Oct 2013 12:24:41 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Sun, Oct 13, 2013 at 11:13 PM, Jean-Philippe Andre jp.an...@samsung.com wrote: jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b1437273890058ce9e84f5efd3195f8834d0f9c0 commit b1437273890058ce9e84f5efd3195f8834d0f9c0 Author: Jean-Philippe Andre jp.an...@samsung.com Date: Mon Oct 14 10:32:16 2013 +0900 evas: Add configure option to disable cserve Some people might want to disable cserve2 at build time to generate smaller packages. wasn't the plan to disable non-cserve2 case and just have it as the only option, making sure it works and so on? this go completely in the other direction... we used to have this option, removed on purpose gustavo is right. we have too many paths of execution in efl in general - and unless it's onby default they basically don't get tested. the entire image loading etc. stuff is better served in cserve, one of the big reasons being memory efficiency (we use 3rd party libs like libpng, libjpeg, libtiff etc. a lot) and these libs come with lots of rw pages on their own, and thus bloat out the memory of every process once they touch such a file format. the loader binary slaves for cserve is in fact a great idea. they can be killed off after inactivity and cycle. but even better, they can CRASH and not take your app down. this is a major win. loading of data is one of the major vectors for attack security-wise and where if we have a bug, it can cause progrqms to become vulnerable to attacks via show this jpeg (if your app is an email client for example). keeping the attack surface small is a good thing. but it also helps out for all the mmap io we do. an mmaped file will cause a sigbus when you hit an io error. we patched over that with eina but its rather evil and eventually will fill memory with zero page turds. the above cycling cleans that out. so cserve is better for more than just sharing. and to ensure our codebase is SIMPLER... we want to move to the path of cserve being the ONLY path. it also opens up future possibilities if we have a daemon manager/broker always there. (hell - we could move RENDERING out-of-process... ok i can't think of a really viable reason why right now, but it's just to illustrate). :) Yes, sure, but right now nobody is using it except JP and he has a lot of patch that need to be included in master (That should be done really soon). Also the code is yet not refactorized and not portable, so there is a long way before we can consider that our ONLY path. In fact right now, I would advocate for it to be optional in efl 1.8 if we are to release it in the coming month. -- Cedric BAIL -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Add configure option to disable cserve
On Tue, 15 Oct 2013 10:20:21 +0900 Cedric BAIL cedric.b...@free.fr said: On Tue, Oct 15, 2013 at 9:13 AM, Carsten Haitzler ras...@rasterman.com wrote: On Mon, 14 Oct 2013 12:24:41 -0300 Gustavo Sverzut Barbieri barbi...@gmail.com said: On Sun, Oct 13, 2013 at 11:13 PM, Jean-Philippe Andre jp.an...@samsung.com wrote: jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b1437273890058ce9e84f5efd3195f8834d0f9c0 commit b1437273890058ce9e84f5efd3195f8834d0f9c0 Author: Jean-Philippe Andre jp.an...@samsung.com Date: Mon Oct 14 10:32:16 2013 +0900 evas: Add configure option to disable cserve Some people might want to disable cserve2 at build time to generate smaller packages. wasn't the plan to disable non-cserve2 case and just have it as the only option, making sure it works and so on? this go completely in the other direction... we used to have this option, removed on purpose gustavo is right. we have too many paths of execution in efl in general - and unless it's onby default they basically don't get tested. the entire image loading etc. stuff is better served in cserve, one of the big reasons being memory efficiency (we use 3rd party libs like libpng, libjpeg, libtiff etc. a lot) and these libs come with lots of rw pages on their own, and thus bloat out the memory of every process once they touch such a file format. the loader binary slaves for cserve is in fact a great idea. they can be killed off after inactivity and cycle. but even better, they can CRASH and not take your app down. this is a major win. loading of data is one of the major vectors for attack security-wise and where if we have a bug, it can cause progrqms to become vulnerable to attacks via show this jpeg (if your app is an email client for example). keeping the attack surface small is a good thing. but it also helps out for all the mmap io we do. an mmaped file will cause a sigbus when you hit an io error. we patched over that with eina but its rather evil and eventually will fill memory with zero page turds. the above cycling cleans that out. so cserve is better for more than just sharing. and to ensure our codebase is SIMPLER... we want to move to the path of cserve being the ONLY path. it also opens up future possibilities if we have a daemon manager/broker always there. (hell - we could move RENDERING out-of-process... ok i can't think of a really viable reason why right now, but it's just to illustrate). :) Yes, sure, but right now nobody is using it except JP and he has a lot of patch that need to be included in master (That should be done really soon). Also the code is yet not refactorized and not portable, so there is a long way before we can consider that our ONLY path. In fact right now, I would advocate for it to be optional in efl 1.8 if we are to release it in the coming month. it doesn't mean we have to ADD in stuff to allow it not to be built. building it doesn't hurt other than some disk space and a bit of extra code support and we are moving that way anyway. :) -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: Revert eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity.
raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f93329d11950969228bef067f278041b2644b793 commit f93329d11950969228bef067f278041b2644b793 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Tue Oct 15 10:35:10 2013 +0900 Revert eina: fix CID 1106340: Logically dead code (DEADCODE) reported by coverity. This reverts commit 1c1b48ca64c4d13cfd3677cde1ee99e4cf6c2c15. this commit is causing all sorts of hell and crashes, hangs and what not. like: Thread 1 (Thread 0x7feb7389e780 (LWP 7149)): No symbol table info available. No symbol table info available. at lib/eina/eina_inlist.c:422 l = 0xf38a50 __FUNCTION__ = eina_inlist_demote #3 0x7feb6a809867 in _eina_chained_mempool_alloc_in ( pool=pool@entry=0x8650a0, p=p@entry=0xf38a50) at modules/eina/mp/chained_pool/eina_chained_mempool.c:197 mem = 0xf3a690 #4 0x7feb6a809dff in eina_chained_mempool_malloc (data=0x8650a0, size=optimized out) at modules/eina/mp/chained_pool/eina_chained_mempool.c:300 pool = 0x8650a0 p = 0xf38a50 mem = optimized out #5 0x7feb6a7e451f in eina_mempool_malloc (size=40, mp=optimized out) at lib/eina/eina_inline_mempool.x:103 No locals. #6 _eina_list_mempool_list_new (list=0x7feb5402a510) at lib/eina/eina_list.c:199 No locals. #7 eina_list_append (list=0x7feb5402a510, data=0xf41720) at lib/eina/eina_list.c:534 l = optimized out __FUNCTION__ = eina_list_append #8 0x00445d1a in e_bindings_signal_add (ctxt=optimized out, sig=0x947e6c mouse,clicked,[12], src=0x92248c e.event.close, mod=E_BINDING_MODIFIER_NONE, any_mod=1, action=0x93479c window_close, params=0x0) at e_bindings.c:1036 binding = 0xf41720 #9 0x004469d4 in e_bindings_init () at e_bindings.c:68 ebs = 0x947df0 ebm = optimized out ebw = optimized out ebe = optimized out ebk = optimized out eba = optimized out l = 0x9532e0 #10 0x00437516 in main (argc=optimized out, argv=optimized out) at e_main.c:941 safe_mode = 0 '\000' after_restart = 1 '\001' waslocked = 0 '\000' t = optimized out tstart = optimized out s = optimized out buff = 1381800872.3, '\000' repeats 19 times action = {__sigaction_handler = { sa_handler = 0x4fca00 e_sigabrt_act, sa_sigaction = 0x4fca00 e_sigabrt_act}, sa_mask = {__val = { 0 repeats 16 times}}, sa_flags = -1073741820, sa_restorer = 0x0} __FUNCTION__ = main Detaching from program: /usr/local/bin/enlightenment, process 7149 --- src/lib/eina/eina_inline_lock_posix.x | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/eina/eina_inline_lock_posix.x b/src/lib/eina/eina_inline_lock_posix.x index 3d90929..2e5b038 100644 --- a/src/lib/eina/eina_inline_lock_posix.x +++ b/src/lib/eina/eina_inline_lock_posix.x @@ -608,11 +608,10 @@ eina_spinlock_take(Eina_Spinlock *spinlock) { if (errno == EBUSY) sched_yield(); else if (errno == EDEADLK) return EINA_LOCK_DEADLOCK; - else return EINA_LOCK_FAIL; } } while (t != 0); - return EINA_LOCK_SUCCEED; + return t ? EINA_LOCK_FAIL : EINA_LOCK_SUCCEED; #else return eina_lock_take(spinlock); #endif --
[EGIT] [core/efl] master 01/01: Revert ecore_evas: window does not go back to normal state if you set iconified to EINA_FALSE.
raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=e309967384a28ccd8f463d63a91b06d2dcc4f8aa commit e309967384a28ccd8f463d63a91b06d2dcc4f8aa Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Tue Oct 15 10:45:37 2013 +0900 Revert ecore_evas: window does not go back to normal state if you set iconified to EINA_FALSE. This reverts commit 9bfb730ff57da3d8789f80256abedcbc19e98bfe. wrong! on deiconify this will now FORCE a ACTIVATE request to the wm (which asks the wm to focus the window/hilight it and make it active. might switch desktops or whatever). this is wrong. de-icoifying a windows does NOT mean ALSO activating it!. the log message also doesnt say what go back to normal state... means do they expect/INSIST windows MUSt be focused after de-iconification? that's wrong as it's a window management FOCUS policy, not something to do in the lib. --- src/modules/ecore_evas/engines/x/ecore_evas_x.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/modules/ecore_evas/engines/x/ecore_evas_x.c b/src/modules/ecore_evas/engines/x/ecore_evas_x.c index 20538dd..627dd15 100644 --- a/src/modules/ecore_evas/engines/x/ecore_evas_x.c +++ b/src/modules/ecore_evas/engines/x/ecore_evas_x.c @@ -2738,10 +2738,7 @@ _ecore_evas_x_iconified_set(Ecore_Evas *ee, int on) if (on) ecore_x_icccm_iconic_request_send(ee-prop.window, edata-win_root); else - { - ecore_evas_activate(ee); - ecore_evas_show(ee); - } + ecore_evas_show(ee); } static void --
[EGIT] [core/elementary] master 01/01: elm - entry magnifier - should be elm namespaced.
raster pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=fce12cf2e21dc36914295a2a33f16a0d6e59eb23 commit fce12cf2e21dc36914295a2a33f16a0d6e59eb23 Author: Carsten Haitzler (Rasterman) ras...@rasterman.com Date: Tue Oct 15 13:00:25 2013 +0900 elm - entry magnifier - should be elm namespaced. --- data/themes/widgets/entry.edc | 6 +++--- src/lib/elm_entry.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/data/themes/widgets/entry.edc b/data/themes/widgets/entry.edc index baec9d6..af440dc 100644 --- a/data/themes/widgets/entry.edc +++ b/data/themes/widgets/entry.edc @@ -1566,7 +1566,7 @@ group { name: elm/entry/magnifier/default; visible: 0; } } - part { name: swallow; + part { name: elm.swallow.content; type: SWALLOW; mouse_events: 0; scale: 1; @@ -1610,7 +1610,7 @@ group { name: elm/entry/magnifier/default; source: elm; action: STATE_SET default 0.0; target: bg; - target: swallow; + target: elm.swallow.content; target: outline; } program { name: magnifier_hide; @@ -1618,7 +1618,7 @@ group { name: elm/entry/magnifier/default; source: elm; action: STATE_SET hidden 0.0; target: bg; - target: swallow; + target: elm.swallow.content; target: outline; } } diff --git a/src/lib/elm_entry.c b/src/lib/elm_entry.c index 8f8fa34..b259dca 100644 --- a/src/lib/elm_entry.c +++ b/src/lib/elm_entry.c @@ -1340,7 +1340,7 @@ _magnifier_create(void *data) sd-mgf_clip = evas_object_rectangle_add(evas_object_evas_get(data)); evas_object_color_set(sd-mgf_clip, 255, 255, 255, 255); - edje_object_part_swallow(sd-mgf_bg, swallow, sd-mgf_clip); + edje_object_part_swallow(sd-mgf_bg, elm.swallow.content, sd-mgf_clip); if (sd-scroll) { --
Re: [E-devel] [EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P
On Mon, 14 Oct 2013 23:31:08 +0300 Kai Huuhko kai.huu...@gmail.com wrote: Let's just bump the minimum version requirement already. ;) Ubuntu LTS still has cython 0.15.1. Will I ever be able to actually compile any of this python stuff? 2013/10/14 davemds d...@gurumeditation.it davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=85ac11657711d3ae0c2b18abe0fea10b666e2d93 commit 85ac11657711d3ae0c2b18abe0fea10b666e2d93 Author: davemds d...@gurumeditation.it Date: Mon Oct 14 21:30:49 2013 +0200 Python-EFL: unbreak the compilation with older cython. Kuuko: you win a spank this time :P --- efl/elementary/cnp_callbacks.pxi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/efl/elementary/cnp_callbacks.pxi b/efl/elementary/cnp_callbacks.pxi index c41c86e..1eeeda5 100644 --- a/efl/elementary/cnp_callbacks.pxi +++ b/efl/elementary/cnp_callbacks.pxi @@ -25,7 +25,7 @@ cdef extern from Elementary.h: struct _Elm_Drag_User_Info: Elm_Sel_Format format -const char *data +const_char *data Eina_List *icons Elm_Xdnd_Action action Elm_Drag_Icon_Create_Cb createicon -- -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60134071iu=/4140/ostg.clktrk ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60135031iu=/4140/ostg.clktrk___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel