[EGIT] [core/efl] master 01/01: efl: fix a neon build break.
hermet pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=77d2e0cb959b9e7ecc6ffc09b67031ac3687f332
commit 77d2e0cb959b9e7ecc6ffc09b67031ac3687f332
Author: Hermet Park
Date: Thu Aug 4 15:22:23 2016 +0900
efl: fix a neon build break.
We found a some build break problem due to a build system.
In efl configuration, our efl configure enables neon if it's available,
but neon gonna partially turned off on evas compilation if the build system
has a non neon CFLAG option (ie, mfpu=vfpv..). In the end, neon is
partially enabled
and it turns out a build break.
It's non-sense but we can't allow this breakage.
There is no way to ignore build system option nor override our neon option
perfectly,
so, Let efl package ruled by build system overall.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 8cb7cd4..cb89323 100644
--- a/configure.ac
+++ b/configure.ac
@@ -593,7 +593,7 @@ case $host_cpu in
build_cpu_neon="yes"
AC_MSG_CHECKING([whether to use NEON instructions])
CFLAGS_save="${CFLAGS}"
- CFLAGS="${CFLAGS} -mfpu=neon -ftree-vectorize"
+ CFLAGS="-mfpu=neon -ftree-vectorize ${CFLAGS}"
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include ]], [[asm
volatile ("vqadd.u8 d0, d1, d0\n")]])],[
AC_MSG_RESULT([yes])
AC_DEFINE([BUILD_NEON], [1], [Build NEON Code])
--
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On 08/04/2016 02:57 PM, Carsten Haitzler (The Rasterman) wrote: > On Thu, 4 Aug 2016 15:16:03 +1000 David Seikel said: > >> On Thu, 4 Aug 2016 14:00:01 +0900 Carsten Haitzler (The Rasterman) >> wrote: >> >>> On Thu, 4 Aug 2016 13:23:33 +1000 David Seikel >>> said: >>> On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) wrote: > one thing with your evas 3d usage... it's not real/useful to > anyone else. if you made open source tools/apps that were easily > usable and downloadable (without needing special accounts you > have to pay for e.g second life) then you would be > interesting/relevant. > > let me give you a sample: > > if you made a really nice world clock app for seeing world > timezones, selecting yours, setting date/time etc. that even did > sexy stuff like used topological maps of the world so when you > zoom into an area you get some mountains/hills and so on... and > this was part of e's settings tools or clock tool with calendar > etc. ... well then that'd be really cool and useful to LOTs of > people and accessible to everyone. :) just saying. you're emails > are "i'm working on this thing.. here on my hard drive... it does > x/y/z and will do x/y/z". that's not REAL to anyone. it's not > accessible. it's not used daily thus important. :) you want evas > 3d to be useful to your BIGGER projects you do like this, do some > smaller ones out the front that people see and use daily. :) Er, my project is for Second Life, OpenSim, AND an alternative to both, and is on Github. Your arguments are invalid. Hell, my general idea is to make server side so efficient that by default, anyone can run their own little server to invite their friends to, even on their phone. I'm trying to open up 3D virtual worlds to the masses. >>> >>> "that are easily downloadable and usable without special accounts". >>> someone has to set up a server, run it, need accounts, etc. is it a >>> tool readily usable out of the box that people actually will need/use >>> regularly. a secondlife or quivalent is not. a terminal is. a wm is. >>> a web browser is. ... if someone has to set up a server themselves or >>> register accounts somewhere else at all you just failed the "useful >>> to anyone" :) >> >> If you read SledjHamr.org, you'll see I have taken all of that into >> account. Now you are just making up excuses to ignore me. > > count the number of people here participating in any virtual world. they use > terminals. email clients. wm's. the number of people involved in virtual > worlds > who would even look is small at best. perhaps you don't like it, but i'm > trying > to tell you that the reason no one is paying attention is you do not have > something they want. maybe others do, but no one here working on efl or e or > core users etc. is. or almost no one. if they were, then you wouldnt be a > periphery thing. i am not saying your work is bad or its stupid or anything. > i'm saying that expecting relevance is dependent on things being relevant to > others. if efl breaks terminology then that break becomes relevant because > LOTs > of people use it here and even elsewhere. but especially here. if evas_3d was > being used in e for eg 3d cube desktop switching effects... it'd be relevant > to > a whole lot of people immediately. > > i'm not even going to look at those projects because the premise of them as a > virtual world is not interesting or relevant to me. it is to you and that's > great. not to me. and if you go around wondering why they are not paying > attention then this is the primary reason. you have to have things in common > that make the things you want be relevant. :) i'm trying to help you here by > pointing out that to help the project you care about, you may have to do other > side projects that have relevance to others to bring that to the fore. :) > A gadget to display models of parts of virtual worlds inside E would be pretty interesting maybe. Extra extra bonus points if you can merge the concept of a virtual world and a Window manager, I've always wanted to be able to walk between my windows its about time someone reinveted 3D window managers, if you started work along those lines id definitely be interested. -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE LinuxAdeliade Australia, UTC+9:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On 08/04/2016 02:57 PM, Carsten Haitzler (The Rasterman) wrote: > On Thu, 4 Aug 2016 15:16:03 +1000 David Seikel said: > >> On Thu, 4 Aug 2016 14:00:01 +0900 Carsten Haitzler (The Rasterman) >> wrote: >> >>> On Thu, 4 Aug 2016 13:23:33 +1000 David Seikel >>> said: >>> On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) wrote: > one thing with your evas 3d usage... it's not real/useful to > anyone else. if you made open source tools/apps that were easily > usable and downloadable (without needing special accounts you > have to pay for e.g second life) then you would be > interesting/relevant. > > let me give you a sample: > > if you made a really nice world clock app for seeing world > timezones, selecting yours, setting date/time etc. that even did > sexy stuff like used topological maps of the world so when you > zoom into an area you get some mountains/hills and so on... and > this was part of e's settings tools or clock tool with calendar > etc. ... well then that'd be really cool and useful to LOTs of > people and accessible to everyone. :) just saying. you're emails > are "i'm working on this thing.. here on my hard drive... it does > x/y/z and will do x/y/z". that's not REAL to anyone. it's not > accessible. it's not used daily thus important. :) you want evas > 3d to be useful to your BIGGER projects you do like this, do some > smaller ones out the front that people see and use daily. :) Er, my project is for Second Life, OpenSim, AND an alternative to both, and is on Github. Your arguments are invalid. Hell, my general idea is to make server side so efficient that by default, anyone can run their own little server to invite their friends to, even on their phone. I'm trying to open up 3D virtual worlds to the masses. >>> >>> "that are easily downloadable and usable without special accounts". >>> someone has to set up a server, run it, need accounts, etc. is it a >>> tool readily usable out of the box that people actually will need/use >>> regularly. a secondlife or quivalent is not. a terminal is. a wm is. >>> a web browser is. ... if someone has to set up a server themselves or >>> register accounts somewhere else at all you just failed the "useful >>> to anyone" :) >> >> If you read SledjHamr.org, you'll see I have taken all of that into >> account. Now you are just making up excuses to ignore me. > > count the number of people here participating in any virtual world. they use > terminals. email clients. wm's. the number of people involved in virtual > worlds > who would even look is small at best. perhaps you don't like it, but i'm > trying > to tell you that the reason no one is paying attention is you do not have > something they want. maybe others do, but no one here working on efl or e or > core users etc. is. or almost no one. if they were, then you wouldnt be a > periphery thing. i am not saying your work is bad or its stupid or anything. > i'm saying that expecting relevance is dependent on things being relevant to > others. if efl breaks terminology then that break becomes relevant because > LOTs > of people use it here and even elsewhere. but especially here. if evas_3d was > being used in e for eg 3d cube desktop switching effects... it'd be relevant > to > a whole lot of people immediately. > > i'm not even going to look at those projects because the premise of them as a > virtual world is not interesting or relevant to me. it is to you and that's > great. not to me. and if you go around wondering why they are not paying > attention then this is the primary reason. you have to have things in common > that make the things you want be relevant. :) i'm trying to help you here by > pointing out that to help the project you care about, you may have to do other > side projects that have relevance to others to bring that to the fore. :) > A gadget to display models of parts of virtual worlds inside E would be pretty interesting maybe. -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE LinuxAdeliade Australia, UTC+9:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 15:16:03 +1000 David Seikel said: > On Thu, 4 Aug 2016 14:00:01 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > On Thu, 4 Aug 2016 13:23:33 +1000 David Seikel > > said: > > > > > On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) > > > wrote: > > > > > > > one thing with your evas 3d usage... it's not real/useful to > > > > anyone else. if you made open source tools/apps that were easily > > > > usable and downloadable (without needing special accounts you > > > > have to pay for e.g second life) then you would be > > > > interesting/relevant. > > > > > > > > let me give you a sample: > > > > > > > > if you made a really nice world clock app for seeing world > > > > timezones, selecting yours, setting date/time etc. that even did > > > > sexy stuff like used topological maps of the world so when you > > > > zoom into an area you get some mountains/hills and so on... and > > > > this was part of e's settings tools or clock tool with calendar > > > > etc. ... well then that'd be really cool and useful to LOTs of > > > > people and accessible to everyone. :) just saying. you're emails > > > > are "i'm working on this thing.. here on my hard drive... it does > > > > x/y/z and will do x/y/z". that's not REAL to anyone. it's not > > > > accessible. it's not used daily thus important. :) you want evas > > > > 3d to be useful to your BIGGER projects you do like this, do some > > > > smaller ones out the front that people see and use daily. :) > > > > > > Er, my project is for Second Life, OpenSim, AND an alternative to > > > both, and is on Github. Your arguments are invalid. Hell, my > > > general idea is to make server side so efficient that by default, > > > anyone can run their own little server to invite their friends to, > > > even on their phone. I'm trying to open up 3D virtual worlds to > > > the masses. > > > > "that are easily downloadable and usable without special accounts". > > someone has to set up a server, run it, need accounts, etc. is it a > > tool readily usable out of the box that people actually will need/use > > regularly. a secondlife or quivalent is not. a terminal is. a wm is. > > a web browser is. ... if someone has to set up a server themselves or > > register accounts somewhere else at all you just failed the "useful > > to anyone" :) > > If you read SledjHamr.org, you'll see I have taken all of that into > account. Now you are just making up excuses to ignore me. count the number of people here participating in any virtual world. they use terminals. email clients. wm's. the number of people involved in virtual worlds who would even look is small at best. perhaps you don't like it, but i'm trying to tell you that the reason no one is paying attention is you do not have something they want. maybe others do, but no one here working on efl or e or core users etc. is. or almost no one. if they were, then you wouldnt be a periphery thing. i am not saying your work is bad or its stupid or anything. i'm saying that expecting relevance is dependent on things being relevant to others. if efl breaks terminology then that break becomes relevant because LOTs of people use it here and even elsewhere. but especially here. if evas_3d was being used in e for eg 3d cube desktop switching effects... it'd be relevant to a whole lot of people immediately. i'm not even going to look at those projects because the premise of them as a virtual world is not interesting or relevant to me. it is to you and that's great. not to me. and if you go around wondering why they are not paying attention then this is the primary reason. you have to have things in common that make the things you want be relevant. :) i'm trying to help you here by pointing out that to help the project you care about, you may have to do other side projects that have relevance to others to bring that to the fore. :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 14:00:01 +0900 Carsten Haitzler (The Rasterman) wrote: > On Thu, 4 Aug 2016 13:23:33 +1000 David Seikel > said: > > > On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) > > wrote: > > > > > one thing with your evas 3d usage... it's not real/useful to > > > anyone else. if you made open source tools/apps that were easily > > > usable and downloadable (without needing special accounts you > > > have to pay for e.g second life) then you would be > > > interesting/relevant. > > > > > > let me give you a sample: > > > > > > if you made a really nice world clock app for seeing world > > > timezones, selecting yours, setting date/time etc. that even did > > > sexy stuff like used topological maps of the world so when you > > > zoom into an area you get some mountains/hills and so on... and > > > this was part of e's settings tools or clock tool with calendar > > > etc. ... well then that'd be really cool and useful to LOTs of > > > people and accessible to everyone. :) just saying. you're emails > > > are "i'm working on this thing.. here on my hard drive... it does > > > x/y/z and will do x/y/z". that's not REAL to anyone. it's not > > > accessible. it's not used daily thus important. :) you want evas > > > 3d to be useful to your BIGGER projects you do like this, do some > > > smaller ones out the front that people see and use daily. :) > > > > Er, my project is for Second Life, OpenSim, AND an alternative to > > both, and is on Github. Your arguments are invalid. Hell, my > > general idea is to make server side so efficient that by default, > > anyone can run their own little server to invite their friends to, > > even on their phone. I'm trying to open up 3D virtual worlds to > > the masses. > > "that are easily downloadable and usable without special accounts". > someone has to set up a server, run it, need accounts, etc. is it a > tool readily usable out of the box that people actually will need/use > regularly. a secondlife or quivalent is not. a terminal is. a wm is. > a web browser is. ... if someone has to set up a server themselves or > register accounts somewhere else at all you just failed the "useful > to anyone" :) If you read SledjHamr.org, you'll see I have taken all of that into account. Now you are just making up excuses to ignore me. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 13:23:33 +1000 David Seikel said: > On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > one thing with your evas 3d usage... it's not real/useful to anyone > > else. if you made open source tools/apps that were easily usable and > > downloadable (without needing special accounts you have to pay for > > e.g second life) then you would be interesting/relevant. > > > > let me give you a sample: > > > > if you made a really nice world clock app for seeing world timezones, > > selecting yours, setting date/time etc. that even did sexy stuff like > > used topological maps of the world so when you zoom into an area you > > get some mountains/hills and so on... and this was part of e's > > settings tools or clock tool with calendar etc. ... well then that'd > > be really cool and useful to LOTs of people and accessible to > > everyone. :) just saying. you're emails are "i'm working on this > > thing.. here on my hard drive... it does x/y/z and will do x/y/z". > > that's not REAL to anyone. it's not accessible. it's not used daily > > thus important. :) you want evas 3d to be useful to your BIGGER > > projects you do like this, do some smaller ones out the front that > > people see and use daily. :) > > Er, my project is for Second Life, OpenSim, AND an alternative to both, > and is on Github. Your arguments are invalid. Hell, my general idea > is to make server side so efficient that by default, anyone can run > their own little server to invite their friends to, even on their > phone. I'm trying to open up 3D virtual worlds to the masses. "that are easily downloadable and usable without special accounts". someone has to set up a server, run it, need accounts, etc. is it a tool readily usable out of the box that people actually will need/use regularly. a secondlife or quivalent is not. a terminal is. a wm is. a web browser is. ... if someone has to set up a server themselves or register accounts somewhere else at all you just failed the "useful to anyone" :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [apps/ephoto] master 01/01: Ephoto: Fix potential crash.
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=9a1efde36a4a3cb5be5756f89920e059cf3c971c
commit 9a1efde36a4a3cb5be5756f89920e059cf3c971c
Author: Stephen Houston
Date: Wed Aug 3 22:37:54 2016 -0500
Ephoto: Fix potential crash.
---
src/bin/ephoto_config.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/bin/ephoto_config.c b/src/bin/ephoto_config.c
index 9eed4b0..085bbad 100644
--- a/src/bin/ephoto_config.c
+++ b/src/bin/ephoto_config.c
@@ -37,7 +37,8 @@ _config_save_cb(void *data, Evas_Object *obj EINA_UNUSED,
if (ecore_file_is_dir(path) || !strcmp(path, "Last"))
eina_stringshare_replace(&ephoto->config->open, path);
- if (strcmp(path, ephoto->config->directory) && strcmp(path, "Last"))
+ if (strcmp(path, ephoto->config->directory) && strcmp(path, "Last") &&
+ ecore_file_exists(path))
{
ephoto_directory_browser_clear(ephoto);
ephoto_thumb_browser_clear(ephoto);
@@ -295,22 +296,22 @@ _config_settings(Ephoto *ephoto, Evas_Object *parent,
Evas_Object *popup)
elm_box_pack_end(box, hbox);
evas_object_show(hbox);
- ic = elm_icon_add(box);
+ ic = elm_icon_add(hbox);
evas_object_size_hint_aspect_set(ic, EVAS_ASPECT_CONTROL_VERTICAL, 1, 1);
elm_icon_standard_set(ic, "document-save");
- button = elm_button_add(box);
+ button = elm_button_add(hbox);
elm_object_text_set(button, _("Save"));
elm_object_part_content_set(button, "icon", ic);
evas_object_smart_callback_add(button, "clicked", _config_save_cb, popup);
elm_box_pack_end(hbox, button);
evas_object_show(button);
- ic = elm_icon_add(box);
+ ic = elm_icon_add(hbox);
evas_object_size_hint_aspect_set(ic, EVAS_ASPECT_CONTROL_VERTICAL, 1, 1);
elm_icon_standard_set(ic, "window-close");
- button = elm_button_add(box);
+ button = elm_button_add(hbox);
elm_object_text_set(button, _("Close"));
elm_object_part_content_set(button, "icon", ic);
evas_object_smart_callback_add(button, "clicked", _config_close_cb, popup);
--
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 11:29:50 +0900 Carsten Haitzler (The Rasterman) wrote: > one thing with your evas 3d usage... it's not real/useful to anyone > else. if you made open source tools/apps that were easily usable and > downloadable (without needing special accounts you have to pay for > e.g second life) then you would be interesting/relevant. > > let me give you a sample: > > if you made a really nice world clock app for seeing world timezones, > selecting yours, setting date/time etc. that even did sexy stuff like > used topological maps of the world so when you zoom into an area you > get some mountains/hills and so on... and this was part of e's > settings tools or clock tool with calendar etc. ... well then that'd > be really cool and useful to LOTs of people and accessible to > everyone. :) just saying. you're emails are "i'm working on this > thing.. here on my hard drive... it does x/y/z and will do x/y/z". > that's not REAL to anyone. it's not accessible. it's not used daily > thus important. :) you want evas 3d to be useful to your BIGGER > projects you do like this, do some smaller ones out the front that > people see and use daily. :) Er, my project is for Second Life, OpenSim, AND an alternative to both, and is on Github. Your arguments are invalid. Hell, my general idea is to make server side so efficient that by default, anyone can run their own little server to invite their friends to, even on their phone. I'm trying to open up 3D virtual worlds to the masses. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 11:39:08 +1000 David Seikel said: > On Thu, 4 Aug 2016 10:27:49 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > On Thu, 4 Aug 2016 10:53:57 +1000 David Seikel > > said: > > > > > On Thu, 4 Aug 2016 09:51:48 +0930 Simon Lees wrote: > > > > > > > > > > > > > > > On 08/04/2016 09:37 AM, David Seikel wrote: > > > > > On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler > > > > > wrote: > > > > > > > > > >> raster pushed a commit to branch master. > > > > >> > > > > >> http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 > > > > >> > > > > >> commit 1f48ce5f6b588ade04d37680e318622991ac48b5 > > > > >> Author: Carsten Haitzler (Rasterman) > > > > >> Date: Thu Aug 4 08:04:57 2016 +0900 > > > > >> > > > > >> emotion generic - vlc - make it off by default as 2 video > > > > >> bends is silly > > > > >> as per bug. requiring by DEFAULT 2 video back ends is > > > > >> rather rediculous. pick one and the others are optional. you > > > > >> could argue xine now is barely worth it, but it's stable and > > > > >> works and has proven to be not any real pain. > > > > >> > > > > >> gst1 is a more optimal and far more complete/featured > > > > >> backend that the vlc generic one anyway. vlc generic has the > > > > >> bonus of out-of-process, but gst1 is pretty stable (unlike the > > > > >> 0.1 backend), so let's not make peolpe install 2 video > > > > >> backends (or possibly 3 or more) just to build efl out of the > > > > >> box. > > > > > > > > > > gst1 is not available on some stable Linux distros. :-P > > > > > > > > > Which one specifically? as far as I know all the major ones have > > > > migrated and shouldn't you just be using the stable efl to match > > > > your stable distro :P > > > > > > Ubuntu 12.04 LTS hasn't reached EOL yet. VLC works fine with EFL > > > on that. If I was a mere user, sure I would stick to stable EFL, > > > I'm a developer. Though previous stable EFLs also had to be told > > > not to use gst1. > > > > 12.04 is 4+ years old. so no. doesn't count. you CAN switch to vlc or > > CAN switch to gst 0.10 backend with --enables/disables etc. but > > frankly. you don't count. not for the purposes of selecting DEFAULTS > > you don't. if the idea was "defaults are only on if everyone on the > > planet has that" then you would. the point is selecting for the vast > > majority of people. > > Your commit message implied both gst1 and VLC had advantages and > disadvantages, I was throwing out one more that might have switched the > balance in favour of VLC. gst1 is ALREADY a default. because it's extremely common and full featured. you are already having to --disable that default. so for you it changes nothing. having BOTH on by default is about as silly as we can be. gst1 is the best sensible default because it is actually full featured and stable. > And I'm well aware that I don't count, I never count, everyone always > ignores me. Hence me alias in places that require two names - onefang > Rejected. Even being the biggest user of Evas_3D outside of Samsung > doesn't get me listened to by the Evas_3D developers. :-P you CHOOSE to do the opposite of everyone else and just never update your OS and if we were to make that the default way of thinking we'd never be supporting new versions of anything and always fighting with "already fixed issues". we wouldnt even be doing wayland because that requires folloing new wl's, libinputs etc. closely. one thing with your evas 3d usage... it's not real/useful to anyone else. if you made open source tools/apps that were easily usable and downloadable (without needing special accounts you have to pay for e.g second life) then you would be interesting/relevant. let me give you a sample: if you made a really nice world clock app for seeing world timezones, selecting yours, setting date/time etc. that even did sexy stuff like used topological maps of the world so when you zoom into an area you get some mountains/hills and so on... and this was part of e's settings tools or clock tool with calendar etc. ... well then that'd be really cool and useful to LOTs of people and accessible to everyone. :) just saying. you're emails are "i'm working on this thing.. here on my hard drive... it does x/y/z and will do x/y/z". that's not REAL to anyone. it's not accessible. it's not used daily thus important. :) you want evas 3d to be useful to your BIGGER projects you do like this, do some smaller ones out the front that people see and use daily. :) > Meh, I'm used to it. Feel free to ignore this rant. lol > > -- > A big old stinking pile of genius that no one wants > coz there are too many silver coated monkeys in the world. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com --
Re: [E-devel] Remove currently broken single libs builds before 1.18 release?
On Mon, Aug 1, 2016 at 5:50 PM, Jean-Philippe André wrote: > On 2 August 2016 at 09:30, Simon Lees wrote: >> On 08/02/2016 09:05 AM, Carsten Haitzler (The Rasterman) wrote: >> > On Mon, 1 Aug 2016 13:38:22 -0700 Cedric BAIL >> said: >> >> On Mon, Aug 1, 2016 at 10:37 AM, Tom Hacohen >> wrote: >> >>> On 01/08/16 17:07, Stefan Schmidt wrote: >> The extra Makefiles to allow building some libraries separately have >> been broken for a while now. Nobody updated them when changes >> happened. >> The normal problem when trying to have two build setups in one tree. >> >> I just gave it another go and ecore, edje, eio and elementary failed >> for >> me. >> >> Many of them also fail from a tarball build because they include >> Makefile_Eolian_Subbuild_Helper.am which never makes it into the >> tarball. >> >> cd ../../.. && /bin/sh >> /home/stefan/EFL/efl/tmp/efl-1.18.0-beta1/missing >> automake-1.15 --gnu src/lib/ecore/Makefile >> configure.ac:284: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, >> and its use is discouraged. >> configure.ac:284: You should use the Autoconf-provided >> 'AC_PROG_MKDIR_P' >> macro instead, >> configure.ac:284: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your >> Makefile.am files. >> automake-1.15: error: cannot open < >> src/Makefile_Eolian_Subbuild_Helper.am: No such file or directory >> Makefile:1644: recipe for target 'Makefile.in' failed >> make: *** [Makefile.in] Error 1 >> >> >> All in all I think it would make sense to remove this extra Makefiles >> all together and stay with the one big Makefile build for 1.18. I know >> the build times are frustrating and we might want to switch back to a >> non aggregated Makefile to allow easier rebuilds of specific libs >> only. >> >> Having a second, non working, build setup in tree for the release is >> something I would like to avoid though. >> >> Comments? >> >>> >> >>> That's what I've been saying since they were introduced. Two build >> >>> systems is a bad idea, we should just stay with single build until we >> >>> move to split. >> >> >> >> And it also make clear that nobody really care about per directory >> >> build. Anyway. It has been now removed by commit >> >> dd1d3f0d2d8f7369f7461f54928eac2a4fce99fb. >> > >> > actually that's wrong. i have used them.. BUT when i use them it goes and >> > rebuilds AGAIN in that dir and doesn't use my existing toplevel build. >> that is >> > SUPER annoying. i've also found them to be at least partially broken. we >> > discussed this long ago and no one wanted 2 build systems. almost >> everyone >> > except you wants per-directory build back again and there just is no >> sane way >> > to have both with a single file. the subdir builds needed to be the ONLY >> builds >> > available. >> > >> >> As long as distro people can still build everything from one command. >> >> If the subtree builds are just to save developer build time, why don't >> you all just install ccache and be done with it, ccache significantly >> reduces my efl rebuild times. > > We use it :) A basic incremental build is still very slow (touch an file in > eina to see...). > > The problem with the per-directory build was two-fold: > - separate makefiles (totally unmanageable) Yes, only way around that would be to introduce our own pretool to fill the Makefile.am with the proper list of files. The rest are autotools limitation. > - it recompiled entirely each "module" (no incremental build after the main > build was run) Yes, that's due to the object naming convention used by autotools which use the full relative path, but subsequent build would not require a full rebuild. This is non fixable. > I know I broke the per directory build a few times, no one even said > anything. That's how much it was used. Pretty much my point. Also I have run some benchmark, if we do go back to multiple Makefile (If that was even doable), we will have a total build time when nothing has changed significantly increased as our issue is in parsing Makefile (9s on my laptop into parsing) and splitting Makefile will result in duplicated boilerplate to parse. It also means that as long as we have that many files, modules and libraries, this parsing will be there and will likely still cost us that much. I have started looking at GNU make and I think there is room for serious improvement in their parsing code. Will see if I can manage something in the comming weeks. As for the reason why we can't move to split Makefile.am, it's pretty simple. It has to be done in one move due to how autotools handle sub directories and dependencies. For anyone who has looked at our build system, this is just litterally insane to do. We have to face it our toolkit has grown big enough that any build system we use is going to be seriously complex, hard to maintain and slow (Before we didn't notic
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 10:27:49 +0900 Carsten Haitzler (The Rasterman) wrote: > On Thu, 4 Aug 2016 10:53:57 +1000 David Seikel > said: > > > On Thu, 4 Aug 2016 09:51:48 +0930 Simon Lees wrote: > > > > > > > > > > > On 08/04/2016 09:37 AM, David Seikel wrote: > > > > On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler > > > > wrote: > > > > > > > >> raster pushed a commit to branch master. > > > >> > > > >> http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 > > > >> > > > >> commit 1f48ce5f6b588ade04d37680e318622991ac48b5 > > > >> Author: Carsten Haitzler (Rasterman) > > > >> Date: Thu Aug 4 08:04:57 2016 +0900 > > > >> > > > >> emotion generic - vlc - make it off by default as 2 video > > > >> bends is silly > > > >> as per bug. requiring by DEFAULT 2 video back ends is > > > >> rather rediculous. pick one and the others are optional. you > > > >> could argue xine now is barely worth it, but it's stable and > > > >> works and has proven to be not any real pain. > > > >> > > > >> gst1 is a more optimal and far more complete/featured > > > >> backend that the vlc generic one anyway. vlc generic has the > > > >> bonus of out-of-process, but gst1 is pretty stable (unlike the > > > >> 0.1 backend), so let's not make peolpe install 2 video > > > >> backends (or possibly 3 or more) just to build efl out of the > > > >> box. > > > > > > > > gst1 is not available on some stable Linux distros. :-P > > > > > > > Which one specifically? as far as I know all the major ones have > > > migrated and shouldn't you just be using the stable efl to match > > > your stable distro :P > > > > Ubuntu 12.04 LTS hasn't reached EOL yet. VLC works fine with EFL > > on that. If I was a mere user, sure I would stick to stable EFL, > > I'm a developer. Though previous stable EFLs also had to be told > > not to use gst1. > > 12.04 is 4+ years old. so no. doesn't count. you CAN switch to vlc or > CAN switch to gst 0.10 backend with --enables/disables etc. but > frankly. you don't count. not for the purposes of selecting DEFAULTS > you don't. if the idea was "defaults are only on if everyone on the > planet has that" then you would. the point is selecting for the vast > majority of people. Your commit message implied both gst1 and VLC had advantages and disadvantages, I was throwing out one more that might have switched the balance in favour of VLC. And I'm well aware that I don't count, I never count, everyone always ignores me. Hence me alias in places that require two names - onefang Rejected. Even being the biggest user of Evas_3D outside of Samsung doesn't get me listened to by the Evas_3D developers. :-P Meh, I'm used to it. Feel free to ignore this rant. lol -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 10:53:57 +1000 David Seikel said: > On Thu, 4 Aug 2016 09:51:48 +0930 Simon Lees wrote: > > > > > > > On 08/04/2016 09:37 AM, David Seikel wrote: > > > On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler > > > wrote: > > > > > >> raster pushed a commit to branch master. > > >> > > >> http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 > > >> > > >> commit 1f48ce5f6b588ade04d37680e318622991ac48b5 > > >> Author: Carsten Haitzler (Rasterman) > > >> Date: Thu Aug 4 08:04:57 2016 +0900 > > >> > > >> emotion generic - vlc - make it off by default as 2 video bends > > >> is silly > > >> as per bug. requiring by DEFAULT 2 video back ends is rather > > >> rediculous. pick one and the others are optional. you could > > >> argue xine now is barely worth it, but it's stable and works and > > >> has proven to be not any real pain. > > >> > > >> gst1 is a more optimal and far more complete/featured backend > > >> that the vlc generic one anyway. vlc generic has the bonus of > > >> out-of-process, but gst1 is pretty stable (unlike the 0.1 backend), > > >> so let's not make peolpe install 2 video backends (or possibly 3 or > > >> more) just to build efl out of the box. > > > > > > gst1 is not available on some stable Linux distros. :-P > > > > > Which one specifically? as far as I know all the major ones have > > migrated and shouldn't you just be using the stable efl to match your > > stable distro :P > > Ubuntu 12.04 LTS hasn't reached EOL yet. VLC works fine with EFL > on that. If I was a mere user, sure I would stick to stable EFL, I'm a > developer. Though previous stable EFLs also had to be told not to use > gst1. 12.04 is 4+ years old. so no. doesn't count. you CAN switch to vlc or CAN switch to gst 0.10 backend with --enables/disables etc. but frankly. you don't count. not for the purposes of selecting DEFAULTS you don't. if the idea was "defaults are only on if everyone on the planet has that" then you would. the point is selecting for the vast majority of people. > On the other hand, I'm considering a switch to Debian some day > soonish, or something else. > > -- > A big old stinking pile of genius that no one wants > coz there are too many silver coated monkeys in the world. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On 08/04/2016 10:23 AM, David Seikel wrote: > On Thu, 4 Aug 2016 09:51:48 +0930 Simon Lees wrote: > >> >> >> On 08/04/2016 09:37 AM, David Seikel wrote: >>> On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler >>> wrote: >>> raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 commit 1f48ce5f6b588ade04d37680e318622991ac48b5 Author: Carsten Haitzler (Rasterman) Date: Thu Aug 4 08:04:57 2016 +0900 emotion generic - vlc - make it off by default as 2 video bends is silly as per bug. requiring by DEFAULT 2 video back ends is rather rediculous. pick one and the others are optional. you could argue xine now is barely worth it, but it's stable and works and has proven to be not any real pain. gst1 is a more optimal and far more complete/featured backend that the vlc generic one anyway. vlc generic has the bonus of out-of-process, but gst1 is pretty stable (unlike the 0.1 backend), so let's not make peolpe install 2 video backends (or possibly 3 or more) just to build efl out of the box. >>> >>> gst1 is not available on some stable Linux distros. :-P >>> >> Which one specifically? as far as I know all the major ones have >> migrated and shouldn't you just be using the stable efl to match your >> stable distro :P > > Ubuntu 12.04 LTS hasn't reached EOL yet. VLC works fine with EFL > on that. If I was a mere user, sure I would stick to stable EFL, I'm a > developer. Though previous stable EFLs also had to be told not to use > gst1. > gst1 is now the preferred option as basically all distro's are shipping it gst0.10 can still be built with a configure flag i'm pretty sure as an alternative to vlc > On the other hand, I'm considering a switch to Debian some day > soonish, or something else. > -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE LinuxAdeliade Australia, UTC+9:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Thu, 4 Aug 2016 09:51:48 +0930 Simon Lees wrote: > > > On 08/04/2016 09:37 AM, David Seikel wrote: > > On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler > > wrote: > > > >> raster pushed a commit to branch master. > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 > >> > >> commit 1f48ce5f6b588ade04d37680e318622991ac48b5 > >> Author: Carsten Haitzler (Rasterman) > >> Date: Thu Aug 4 08:04:57 2016 +0900 > >> > >> emotion generic - vlc - make it off by default as 2 video bends > >> is silly > >> as per bug. requiring by DEFAULT 2 video back ends is rather > >> rediculous. pick one and the others are optional. you could > >> argue xine now is barely worth it, but it's stable and works and > >> has proven to be not any real pain. > >> > >> gst1 is a more optimal and far more complete/featured backend > >> that the vlc generic one anyway. vlc generic has the bonus of > >> out-of-process, but gst1 is pretty stable (unlike the 0.1 backend), > >> so let's not make peolpe install 2 video backends (or possibly 3 or > >> more) just to build efl out of the box. > > > > gst1 is not available on some stable Linux distros. :-P > > > Which one specifically? as far as I know all the major ones have > migrated and shouldn't you just be using the stable efl to match your > stable distro :P Ubuntu 12.04 LTS hasn't reached EOL yet. VLC works fine with EFL on that. If I was a mere user, sure I would stick to stable EFL, I'm a developer. Though previous stable EFLs also had to be told not to use gst1. On the other hand, I'm considering a switch to Debian some day soonish, or something else. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/02: elementary: keep theme consistent regarding the disabling of odd/even.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=c64071ae132ddc5894d5daad8a874377a176aac5
commit c64071ae132ddc5894d5daad8a874377a176aac5
Author: Cedric Bail
Date: Wed Aug 3 17:29:31 2016 -0700
elementary: keep theme consistent regarding the disabling of odd/even.
This is another patch that should be reverted as soon as we start
7affe8c2047a41a2945cf6c048d59f28c974aa7a and is still a work around
T3086.
---
data/elementary/themes/edc/elm/index.edc | 6 ++
data/elementary/themes/edc/elm/list.edc | 18 ++
data/elementary/themes/edc/fileman.edc | 4
data/elementary/themes/edc/ilist.edc | 3 +++
4 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/data/elementary/themes/edc/elm/index.edc
b/data/elementary/themes/edc/elm/index.edc
index ce59294..5ce5190 100644
--- a/data/elementary/themes/edc/elm/index.edc
+++ b/data/elementary/themes/edc/elm/index.edc
@@ -147,6 +147,7 @@ group { name: "elm/index/base/vertical/default";
group { name: "elm/index/item/vertical/default";
data.item: "stacking" "below";
+ alias: "elm/index/item_odd/vertical/default";
images {
image: "darken_rounded_square_half.png" COMP;
}
@@ -261,6 +262,7 @@ group { name: "elm/index/item/vertical/default";
}
}
+#if 0
group { name: "elm/index/item_odd/vertical/default";
data.item: "stacking" "above";
data.item: "selectraise" "on";
@@ -374,6 +376,7 @@ group { name: "elm/index/item_odd/vertical/default";
}
}
}
+#endif
group { name: "elm/index/base/horizontal/default";
parts {
@@ -508,6 +511,7 @@ group { name: "elm/index/base/horizontal/default";
group { name: "elm/index/item/horizontal/default";
data.item: "stacking" "below";
+ alias: "elm/index/item_odd/horizontal/default";
images {
image: "darken_rounded_square_half_h.png" COMP;
}
@@ -610,6 +614,7 @@ group { name: "elm/index/item/horizontal/default";
}
}
+#if 0
group { name: "elm/index/item_odd/horizontal/default";
data.item: "stacking" "above";
data.item: "selectraise" "on";
@@ -710,3 +715,4 @@ group { name: "elm/index/item_odd/horizontal/default";
}
}
}
+#endif
diff --git a/data/elementary/themes/edc/elm/list.edc
b/data/elementary/themes/edc/elm/list.edc
index 0641938..87bf813 100644
--- a/data/elementary/themes/edc/elm/list.edc
+++ b/data/elementary/themes/edc/elm/list.edc
@@ -116,6 +116,7 @@
group { name: "elm/list/item/default";
data.item: "selectraise" "on";
data.item: "focusraise" "on";
+ alias: "elm/list/item_odd/default";
images.image: "bevel_curved_horiz_out.png" COMP;
images.image: "shadow_rounded_horiz.png" COMP;
images.image: "vgrad_med_dark.png" COMP;
@@ -136,16 +137,20 @@ group { name: "elm/list/item/default";
color: 64 64 64 255;
color_class: "list_item_base";
}
+#if 0
description { state: "odd" 0.0;
color: 56 56 56 255;
color_class: "list_item_base_odd";
}
+#endif
}
+#if 0
program {
signal: "elm,state,odd"; source: "elm";
action: STATE_SET "odd" 1.0;
target: "base";
}
+#endif
program {
signal: "elm,state,even"; source: "elm";
action: STATE_SET "default" 0.0;
@@ -401,9 +406,9 @@ group { name: "elm/list/item/default";
}
}
}
-ODD("elm/list/item_odd/default", "elm/list/item/default")
+//ODD("elm/list/item_odd/default", "elm/list/item/default")
COMPRESS("elm/list/item_compress/default", "elm/list/item/default")
-COMPRESS_ODD("elm/list/item_compress_odd/default", "elm/list/item/default")
+COMPRESS("elm/list/item_compress_odd/default", "elm/list/item/default")
// XXX: DO:
// elm/list/h_item/default
@@ -427,6 +432,7 @@ COMPRESS_ODD("elm/list/item_compress_odd/default",
"elm/list/item/default")
group { name: "elm/list/h_item/default";
data.item: "selectraise" "on";
data.item: "focusraise" "on";
+ alias: "elm/list/h_item_odd/default";
images.image: "bevel_curved_vert_out.png" COMP;
images.image: "shadow_rounded_vert.png" COMP;
images.image: "vgrad_med_dark.png" COMP;
@@ -447,16 +453,20 @@ group { name: "elm/list/h_item/default";
color: 64 64 64 255;
color_class: "list_item_base";
}
+#if 0
description { state: "odd" 0.0;
color: 56 56 56 255;
color_class: "list_item_base_odd";
}
+#endif
}
+#if 0
program {
signal: "elm,state,odd"; source: "elm";
action: STATE_SET "odd" 1.0;
target: "base";
}
+#endif
program {
signal: "elm,state,even"; source: "elm";
action: STATE_SET "default" 0.0;
@@ -712,9 +722,9 @@ group { name: "elm/list/h_item/default";
}
}
}
-ODD("elm/list/h_item_odd/default", "elm/list/h_item/default")
+//ODD("elm/list/h_item_odd/default", "elm/list/h_item/default")
COMPRE
[EGIT] [core/efl] master 02/02: edje: updated the start index of vector resource from 1 to 0
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=d458101a410a6ffc92d2e59f920a6246f833999f
commit d458101a410a6ffc92d2e59f920a6246f833999f
Author: Subhransu Mohanty
Date: Wed Aug 3 17:34:50 2016 -0700
edje: updated the start index of vector resource from 1 to 0
Reviewers: cedric, jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4205
Signed-off-by: Cedric Bail
---
src/bin/edje/edje_cc_handlers.c | 6 +++---
src/lib/edje/edje_calc.c| 4 ++--
src/lib/edje/edje_edit.c| 2 ++
src/lib/edje/edje_load.c| 5 -
4 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c
index 2f6481c..de5b138 100644
--- a/src/bin/edje/edje_cc_handlers.c
+++ b/src/bin/edje/edje_cc_handlers.c
@@ -2330,7 +2330,7 @@ _handle_vector_image(void)
name = parse_str(0);
- ed->vg.id = 0;
+ ed->vg.id = -1;
for (i = 0; i < edje_file->image_dir->vectors_count; ++i)
{
@@ -2342,7 +2342,7 @@ _handle_vector_image(void)
}
}
- if (!ed->vg.id)
+ if (ed->vg.id < 0)
error_and_abort(NULL, "Failed to find the vector resource :%s", name);
free(name);
@@ -2410,7 +2410,7 @@ st_images_vector(void)
vector = edje_file->image_dir->vectors +
edje_file->image_dir->vectors_count - 1;
vector->entry = tmp;
- vector->id = edje_file->image_dir->vectors_count;
+ vector->id = edje_file->image_dir->vectors_count - 1;
}
diff --git a/src/lib/edje/edje_calc.c b/src/lib/edje/edje_calc.c
index 66b1cee..64db709 100644
--- a/src/lib/edje/edje_calc.c
+++ b/src/lib/edje/edje_calc.c
@@ -3269,7 +3269,7 @@ static void
_edje_svg_recalc_apply(Edje *ed, Edje_Real_Part *ep, Edje_Calc_Params *p3
EINA_UNUSED, Edje_Part_Description_Vector *chosen_desc, FLOAT_T pos)
{
int w, h;
- int new_svg = 0;
+ int new_svg = -1;
Efl_VG *root_vg;
Eina_Matrix3 matrix;
Edje_Vector_Data *start, *end;
@@ -3288,7 +3288,7 @@ _edje_svg_recalc_apply(Edje *ed, Edje_Real_Part *ep,
Edje_Calc_Params *p3 EINA_U
new_svg = next_state->vg.id;
}
}
- if (new_svg) // animation with svg id change
+ if (new_svg >= 0) // animation with svg id change
{
start = _edje_ref_vector_data(ed, chosen_desc->vg.id);
end = _edje_ref_vector_data(ed, new_svg);
diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c
index 972ea88..f704a05 100644
--- a/src/lib/edje/edje_edit.c
+++ b/src/lib/edje/edje_edit.c
@@ -3142,6 +3142,8 @@ _edje_edit_real_part_add(Evas_Object *obj, const char
*name, Edje_Part_Type type
{
rp->type = EDJE_PART_TYPE_VECTOR;
rp->typedata.vector = calloc(1, sizeof(Edje_Real_Part_Vector));
+if (rp->typedata.vector)
+ rp->typedata.vector->cur.svg_id = -1;
rp->object = evas_object_vg_add(ed->base->evas);
}
else if (ep->type == EDJE_PART_TYPE_IMAGE || ep->type ==
EDJE_PART_TYPE_PROXY)
diff --git a/src/lib/edje/edje_load.c b/src/lib/edje/edje_load.c
index 0d43704..10602e4 100644
--- a/src/lib/edje/edje_load.c
+++ b/src/lib/edje/edje_load.c
@@ -734,7 +734,10 @@ _edje_object_file_set_internal(Evas_Object *obj, const
Eina_File *file, const ch
case EDJE_PART_TYPE_VECTOR:
rp->type = EDJE_PART_TYPE_VECTOR;
rp->typedata.vector = calloc(1,
sizeof(Edje_Real_Part_Vector));
- if (!rp->typedata.vector) memerr = EINA_TRUE;
+ if (!rp->typedata.vector)
+ memerr = EINA_TRUE;
+ else
+ rp->typedata.vector->cur.svg_id = -1;
break;
case EDJE_PART_TYPE_GROUP:
--
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On 08/04/2016 09:37 AM, David Seikel wrote: > On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler > wrote: > >> raster pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 >> >> commit 1f48ce5f6b588ade04d37680e318622991ac48b5 >> Author: Carsten Haitzler (Rasterman) >> Date: Thu Aug 4 08:04:57 2016 +0900 >> >> emotion generic - vlc - make it off by default as 2 video bends >> is silly >> as per bug. requiring by DEFAULT 2 video back ends is rather >> rediculous. pick one and the others are optional. you could argue >> xine now is barely worth it, but it's stable and works and has proven >> to be not any real pain. >> >> gst1 is a more optimal and far more complete/featured backend >> that the vlc generic one anyway. vlc generic has the bonus of >> out-of-process, but gst1 is pretty stable (unlike the 0.1 backend), >> so let's not make peolpe install 2 video backends (or possibly 3 or >> more) just to build efl out of the box. > > gst1 is not available on some stable Linux distros. :-P > Which one specifically? as far as I know all the major ones have migrated and shouldn't you just be using the stable efl to match your stable distro :P -- Simon Lees (Simotek)http://simotek.net Emergency Update Team keybase.io/simotek SUSE LinuxAdeliade Australia, UTC+9:30 GPG Fingerprint: 5B87 DB9D 88DC F606 E489 CEC5 0922 C246 02F0 014B signature.asc Description: OpenPGP digital signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
On Wed, 03 Aug 2016 16:08:11 -0700 Carsten Haitzler wrote: > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5 > > commit 1f48ce5f6b588ade04d37680e318622991ac48b5 > Author: Carsten Haitzler (Rasterman) > Date: Thu Aug 4 08:04:57 2016 +0900 > > emotion generic - vlc - make it off by default as 2 video bends > is silly > as per bug. requiring by DEFAULT 2 video back ends is rather > rediculous. pick one and the others are optional. you could argue > xine now is barely worth it, but it's stable and works and has proven > to be not any real pain. > > gst1 is a more optimal and far more complete/featured backend > that the vlc generic one anyway. vlc generic has the bonus of > out-of-process, but gst1 is pretty stable (unlike the 0.1 backend), > so let's not make peolpe install 2 video backends (or possibly 3 or > more) just to build efl out of the box. gst1 is not available on some stable Linux distros. :-P -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Problem with legacy ecore stuff lifetime
On Wed, 3 Aug 2016 19:47:47 +0200 Davide Andreoli said: > Ok, this has been fixed now in python bindings. > > The problem was that pyefl assume that every objects are Eo obj internally, > was coded this way at efl 1.8 and was a big Eo win that simplify a lot the > bindings (infact we rewrite quite everything at that time to use the Eo > infra) > > We really use a little subset of Eo as we know it's not stable, mainly 3 > functions: > eo_key_data_set() -> to store the created python obj > eo_event_callback_add(DEL) -> to clean the python obj > eo_class_name_get(eo_class_get(obj)) -> to create the correct python obj > as needed > > Now, from 1.18, ecore.Animators and ecore.Idlers are no more Eo based > sigh :( > > We fixed the issue by rewriting those 2 classes in the old way, without > using Eo. > This has been easy because the object lifetime are really simple, BUT can > be > really tricky to do the same on more complex objects. > > All this just to say: > PLEASE DON'T DO THE SAME IN THE FUTURE, or at least speak with me > to evaluate the consequences this can have in bindings. i actually kind of agree with you here. these should have stayed eo objects, BUT just objects we will later DROP in efl 2.0 - then they get the benefits of eo but the same use underneath legacy api and eo features and safety. perhaps this is something we should fix for 1.19? we really just want to bring BACK what we had for 1.17 there. > Thanks > davemds > > > > 2016-07-25 21:59 GMT+02:00 Davide Andreoli : > > > Hi all, > > lately quite all the ecore test we have in python-efl are failing for > > (seems) the same reason: > > > > the del callback seems not be called when you return FALSE from a callback > > that should delete the object in that case, Animator fe. > > > > I'm quite sure this is not a python related issue but I have no time until > > the next week to look at the C side. Can someone give a look at this? maybe > > cedric or tasn? > > > > This happen in quite all the ecore stuff in python-efl: > > Animator > > Poller > > Idler > > IdleEnterer > > IdleExiter > > > > Timers instead seems to work as expected. > > > > Thanks > > > > > -- > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: elm image - store smooth scale var in object as intended
On Wed, 3 Aug 2016 21:09:39 +0200 Davide Andreoli said:
> 2016-08-03 11:27 GMT+02:00 Carsten Haitzler :
>
> > raster pushed a commit to branch master.
> >
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=f23788dcb0c2b969f5312a3d72a8e0874952e64f
> >
> > commit f23788dcb0c2b969f5312a3d72a8e0874952e64f
> > Author: Carsten Haitzler (Rasterman)
> > Date: Wed Aug 3 18:24:16 2016 +0900
> >
> > elm image - store smooth scale var in object as intended
> >
> > this fixesa bug reported by davemds and kuuko in python bindings test
> > suite where setting smooth flag != getting it right after.
> >
>
> This doesn't seems to be the right fix, now the terminal (with quite all
> efl apps) are full of:
> ERR<6070>:eina_safety lib/evas/canvas/evas_image_legacy.c:338
> evas_object_image_smooth_scale_set() object is not an image!
gah. i didnt see any of that? but i can see why.
> > ---
> > src/lib/elementary/efl_ui_image.c | 7 ++-
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/src/lib/elementary/efl_ui_image.c
> > b/src/lib/elementary/efl_ui_image.c
> > index 8bf16a8..ba52cc9 100644
> > --- a/src/lib/elementary/efl_ui_image.c
> > +++ b/src/lib/elementary/efl_ui_image.c
> > @@ -544,17 +544,14 @@ _efl_ui_image_edje_file_set(Evas_Object *obj,
> > EOLIAN static void
> > _efl_ui_image_efl_image_smooth_scale_set(Eo *obj EINA_UNUSED,
> > Efl_Ui_Image_Data *sd, Eina_Bool smooth)
> > {
> > - if (sd->edje) return;
> > -
> > + sd->smooth = smooth;
> > evas_object_image_smooth_scale_set(sd->img, smooth);
> > }
> >
> > EOLIAN static Eina_Bool
> > _efl_ui_image_efl_image_smooth_scale_get(Eo *obj EINA_UNUSED,
> > Efl_Ui_Image_Data *sd)
> > {
> > - if (sd->edje) return EINA_FALSE;
> > -
> > - return evas_object_image_smooth_scale_get(sd->img);
> > + return sd->smooth;
> > }
> >
> > static Eina_Bool
> >
> > --
> >
> >
> >
> --
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: elm image - silence warnings of setting smooth if image is edje
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=a3e74139922e98fa8cca38ecb2eb9f25a16f4971
commit a3e74139922e98fa8cca38ecb2eb9f25a16f4971
Author: Carsten Haitzler (Rasterman)
Date: Thu Aug 4 08:17:18 2016 +0900
elm image - silence warnings of setting smooth if image is edje
---
src/lib/elementary/efl_ui_image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/efl_ui_image.c
b/src/lib/elementary/efl_ui_image.c
index ba52cc9..f27d17f 100644
--- a/src/lib/elementary/efl_ui_image.c
+++ b/src/lib/elementary/efl_ui_image.c
@@ -545,7 +545,7 @@ EOLIAN static void
_efl_ui_image_efl_image_smooth_scale_set(Eo *obj EINA_UNUSED,
Efl_Ui_Image_Data *sd, Eina_Bool smooth)
{
sd->smooth = smooth;
- evas_object_image_smooth_scale_set(sd->img, smooth);
+ if (!sd->edje) evas_object_image_smooth_scale_set(sd->img, smooth);
}
EOLIAN static Eina_Bool
--
[EGIT] [core/efl] master 01/01: emotion generic - vlc - make it off by default as 2 video bends is silly
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=1f48ce5f6b588ade04d37680e318622991ac48b5
commit 1f48ce5f6b588ade04d37680e318622991ac48b5
Author: Carsten Haitzler (Rasterman)
Date: Thu Aug 4 08:04:57 2016 +0900
emotion generic - vlc - make it off by default as 2 video bends is silly
as per bug. requiring by DEFAULT 2 video back ends is rather
rediculous. pick one and the others are optional. you could argue xine
now is barely worth it, but it's stable and works and has proven to be
not any real pain.
gst1 is a more optimal and far more complete/featured backend that the
vlc generic one anyway. vlc generic has the bonus of out-of-process,
but gst1 is pretty stable (unlike the 0.1 backend), so let's not make
peolpe install 2 video backends (or possibly 3 or more) just to build
efl out of the box.
this fixes T4284
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 70b12f1..8cb7cd4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5065,7 +5065,7 @@ fi
### Check availability
## Generic player
-EMOTION_GENERIC_PLAYER([GENERIC_VLC], [yes], [libvlc >= 2.0])
+EMOTION_GENERIC_PLAYER([GENERIC_VLC], [no], [libvlc >= 2.0])
EFL_ADD_FEATURE([EMOTION], [generic_vlc], [${with_generic_vlc}])
EFL_LIB_END([Emotion])
--
[EGIT] [core/efl] master 01/01: Fix further text checks in Elm_Code T4264
ajwillia-ms pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f2a4ff154fc67a4e5982d84c33440ea5c0705252
commit f2a4ff154fc67a4e5982d84c33440ea5c0705252
Author: Andy Williams
Date: Wed Aug 3 23:43:23 2016 +0100
Fix further text checks in Elm_Code T4264
An incorrect assumption in how unused memory may be initialised
@fix
---
src/tests/elementary/elm_code_test_text.c | 7 +--
src/tests/elementary/elm_code_test_widget_selection.c | 5 +++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/tests/elementary/elm_code_test_text.c
b/src/tests/elementary/elm_code_test_text.c
index 51dbf8d..fb198c9 100644
--- a/src/tests/elementary/elm_code_test_text.c
+++ b/src/tests/elementary/elm_code_test_text.c
@@ -15,7 +15,7 @@ START_TEST (elm_code_text_get_test)
Elm_Code_Line *line;
const char *str;
- int len;
+ unsigned int len;
elm_init(1, NULL);
code = elm_code_create();
@@ -35,6 +35,8 @@ START_TEST (elm_code_text_insert_test)
Elm_Code *code;
Elm_Code_File *file;
Elm_Code_Line *line;
+ const char *text;
+ unsigned int length;
elm_init(1, NULL);
code = elm_code_create();
@@ -44,7 +46,8 @@ START_TEST (elm_code_text_insert_test)
line = elm_code_file_line_get(file, 1);
elm_code_line_text_insert(line, 4, "ing", 3);
- ck_assert_str_eq("testing", elm_code_line_text_get(line, NULL));
+ text = elm_code_line_text_get(line, &length);
+ ck_assert_strn_eq("testing", text, length);
elm_shutdown();
}
END_TEST
diff --git a/src/tests/elementary/elm_code_test_widget_selection.c
b/src/tests/elementary/elm_code_test_widget_selection.c
index 9cb4b90..562a106 100644
--- a/src/tests/elementary/elm_code_test_widget_selection.c
+++ b/src/tests/elementary/elm_code_test_widget_selection.c
@@ -376,6 +376,7 @@ START_TEST
(elm_code_test_widget_selection_reverse_delete_twoline)
Elm_Code_Widget *widget;
Evas_Object *win;
const char *text;
+ unsigned int length;
elm_init(1, NULL);
code = elm_code_create();
@@ -395,8 +396,8 @@ START_TEST
(elm_code_test_widget_selection_reverse_delete_twoline)
elm_code_widget_selection_delete(widget);
line = elm_code_file_line_get(file, 1);
- text = elm_code_line_text_get(line, NULL);
- ck_assert_str_eq("teXT", text);
+ text = elm_code_line_text_get(line, &length);
+ ck_assert_strn_eq("teXT", text, length);
ck_assert_int_eq(1, elm_code_file_lines_get(file));
elm_code_free(code);
--
[EGIT] [apps/ephoto] master 01/01: Ephoto: Show the dir to open ephoto with, not the currently opened dir.
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=7bc7b4355107933660dc52a47b1e8edbf688e02f
commit 7bc7b4355107933660dc52a47b1e8edbf688e02f
Author: Stephen okra Houston
Date: Wed Aug 3 16:09:52 2016 -0500
Ephoto: Show the dir to open ephoto with, not the currently opened dir.
---
src/bin/ephoto_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/ephoto_config.c b/src/bin/ephoto_config.c
index 349dc98..9eed4b0 100644
--- a/src/bin/ephoto_config.c
+++ b/src/bin/ephoto_config.c
@@ -117,7 +117,7 @@ _config_general(Ephoto *ephoto, Evas_Object *parent)
_open_hv_select, ephoto);
elm_hoversel_item_add(hoversel, _("Custom Directory"), NULL, 0,
_open_hv_select, ephoto);
- elm_object_text_set(hoversel, ephoto->config->directory);
+ elm_object_text_set(hoversel, ephoto->config->open);
evas_object_data_set(hoversel, "ephoto", ephoto);
evas_object_size_hint_weight_set(hoversel, EVAS_HINT_EXPAND,
EVAS_HINT_FILL);
--
[EGIT] [apps/ephoto] master 01/01: Ephoto: Fix some configuration options and change how Ephoto runs on first start.
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=e2bc2e4df61ed76ae59a4cf2a8baf15175188577
commit e2bc2e4df61ed76ae59a4cf2a8baf15175188577
Author: Stephen okra Houston
Date: Wed Aug 3 16:05:48 2016 -0500
Ephoto: Fix some configuration options and change how Ephoto runs on first
start.
---
src/bin/ephoto.h | 3 +
src/bin/ephoto_config.c| 112 +
src/bin/ephoto_directory_browser.c | 9 +++
src/bin/ephoto_main.c | 6 ++
src/bin/ephoto_thumb_browser.c | 9 +++
5 files changed, 104 insertions(+), 35 deletions(-)
diff --git a/src/bin/ephoto.h b/src/bin/ephoto.h
index c0c7b78..04850f9 100644
--- a/src/bin/ephoto.h
+++ b/src/bin/ephoto.h
@@ -105,6 +105,7 @@ void ephoto_thumb_browser_update(Ephoto *ephoto,
Ephoto_Entry *entry);
void ephoto_thumb_browser_update_info_label(Ephoto *ephoto);
void ephoto_thumb_browser_slideshow(Evas_Object *obj);
void ephoto_thumb_browser_paste(Ephoto *ephoto, Elm_Object_Item *item);
+void ephoto_thumb_browser_clear(Ephoto *ephoto);
/* smart callbacks called: "selected" - an item in the thumb browser is
* selected. The selected Ephoto_Entry is passed as event_info argument. */
@@ -112,6 +113,7 @@ void ephoto_thumb_browser_paste(Ephoto *ephoto,
Elm_Object_Item *item);
Evas_Object *ephoto_directory_browser_add(Ephoto *ephoto, Evas_Object *parent);
void ephoto_directory_browser_initialize_structure(Ephoto *ephoto);
void ephoto_directory_browser_top_dir_set(Ephoto *ephoto, const char *dir);
+void ephoto_directory_browser_clear(Ephoto *ephoto);
/*thumbnailing functions taken from enlightenment*/
int e_thumb_init(void);
@@ -223,6 +225,7 @@ struct _Ephoto_Config
Eina_Bool prompts;
Eina_Bool drop;
Eina_Bool movess;
+ Eina_Bool firstrun;
Evas_Object *slide_time;
Evas_Object *slide_trans;
Evas_Object *open_dir;
diff --git a/src/bin/ephoto_config.c b/src/bin/ephoto_config.c
index c5802f5..349dc98 100644
--- a/src/bin/ephoto_config.c
+++ b/src/bin/ephoto_config.c
@@ -1,6 +1,6 @@
#include "ephoto.h"
-#define CONFIG_VERSION 17
+#define CONFIG_VERSION 18
static int _ephoto_config_load(Ephoto *ephoto);
static Eina_Bool _ephoto_on_config_save(void *data);
@@ -37,6 +37,15 @@ _config_save_cb(void *data, Evas_Object *obj EINA_UNUSED,
if (ecore_file_is_dir(path) || !strcmp(path, "Last"))
eina_stringshare_replace(&ephoto->config->open, path);
+ if (strcmp(path, ephoto->config->directory) && strcmp(path, "Last"))
+ {
+ephoto_directory_browser_clear(ephoto);
+ephoto_thumb_browser_clear(ephoto);
+eina_stringshare_replace(&ephoto->config->directory,
+ecore_file_realpath(path));
+ephoto_directory_browser_top_dir_set(ephoto,
ephoto->config->directory);
+ephoto_directory_browser_initialize_structure(ephoto);
+ }
ephoto->config->prompts = elm_check_state_get(ephoto->config->show_prompts);
ephoto->config->drop = elm_check_state_get(ephoto->config->move_drop);
ephoto->config->movess = elm_check_state_get(ephoto->config->slide_move);
@@ -108,7 +117,7 @@ _config_general(Ephoto *ephoto, Evas_Object *parent)
_open_hv_select, ephoto);
elm_hoversel_item_add(hoversel, _("Custom Directory"), NULL, 0,
_open_hv_select, ephoto);
- elm_object_text_set(hoversel, _("Directory To Open Ephoto In"));
+ elm_object_text_set(hoversel, ephoto->config->directory);
evas_object_data_set(hoversel, "ephoto", ephoto);
evas_object_size_hint_weight_set(hoversel, EVAS_HINT_EXPAND,
EVAS_HINT_FILL);
@@ -253,9 +262,9 @@ _config_slideshow(Ephoto *ephoto, Evas_Object *parent)
}
static Evas_Object *
-_config_settings(Ephoto *ephoto, Evas_Object *parent)
+_config_settings(Ephoto *ephoto, Evas_Object *parent, Evas_Object *popup)
{
- Evas_Object *box, *scroller, *vbox;
+ Evas_Object *box, *scroller, *vbox, *hbox, *ic, *button;
box = elm_box_add(parent);
elm_box_horizontal_set(box, EINA_FALSE);
@@ -279,6 +288,35 @@ _config_settings(Ephoto *ephoto, Evas_Object *parent)
_config_general(ephoto, vbox);
_config_slideshow(ephoto, vbox);
+ hbox = elm_box_add(box);
+ elm_box_horizontal_set(hbox, EINA_TRUE);
+ evas_object_size_hint_weight_set(hbox, EVAS_HINT_EXPAND, 0.0);
+ evas_object_size_hint_align_set(hbox, EVAS_HINT_FILL, EVAS_HINT_FILL);
+ elm_box_pack_end(box, hbox);
+ evas_object_show(hbox);
+
+ ic = elm_icon_add(box);
+ evas_object_size_hint_aspect_set(ic, EVAS_ASPECT_CONTROL_VERTICAL, 1, 1);
+ elm_icon_standard_set(ic, "document-save");
+
+ button = elm_button_add(box);
+ elm_object_text_set(button, _("Save"));
+ elm_object_part_content_set(button, "icon", ic);
+ evas_object_smart_callback_add(button, "clicked", _config_save_cb, popup);
+ elm_box_pack_end(hbox, button);
+ evas_object_show(button);
+
+ ic = elm_icon_add(box);
+ evas_object_size_hint_aspect_set(ic, EVAS_ASPECT
Re: [E-devel] Merging efl,eo and ecore
On Wed, 3 Aug 2016 20:36:41 +0200 Davide Andreoli wrote: > > > ethumb i think needs a redesign from scratch and so i was > > > separating it out like we did with e_dbus after 1.7. anything i > > > think may need a replacement in the future i was separating out. > > > > Can we do more than just images this time? Thumbnailing large 3D > > objects into a tiny copy that rotates in a file requester is > > something I want to do, or an ordinary 2D thumbnail at least. B-) > > > > Actually you can do this (3d thumbs) right now with ethumb, you just > need to write a backend for it. There is already an emotion backend > that create animated thumbs of video files. A tiny animation would be acceptable. The point is to show the model from more than a single angle, coz any arbitrarily chosen angle might not be useful for any given model. -- A big old stinking pile of genius that no one wants coz there are too many silver coated monkeys in the world. signature.asc Description: PGP signature -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: elm image - store smooth scale var in object as intended
2016-08-03 11:27 GMT+02:00 Carsten Haitzler :
> raster pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/efl.git/commit/?id=f23788dcb0c2b969f5312a3d72a8e0874952e64f
>
> commit f23788dcb0c2b969f5312a3d72a8e0874952e64f
> Author: Carsten Haitzler (Rasterman)
> Date: Wed Aug 3 18:24:16 2016 +0900
>
> elm image - store smooth scale var in object as intended
>
> this fixesa bug reported by davemds and kuuko in python bindings test
> suite where setting smooth flag != getting it right after.
>
This doesn't seems to be the right fix, now the terminal (with quite all
efl apps) are full of:
ERR<6070>:eina_safety lib/evas/canvas/evas_image_legacy.c:338
evas_object_image_smooth_scale_set() object is not an image!
> ---
> src/lib/elementary/efl_ui_image.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/lib/elementary/efl_ui_image.c
> b/src/lib/elementary/efl_ui_image.c
> index 8bf16a8..ba52cc9 100644
> --- a/src/lib/elementary/efl_ui_image.c
> +++ b/src/lib/elementary/efl_ui_image.c
> @@ -544,17 +544,14 @@ _efl_ui_image_edje_file_set(Evas_Object *obj,
> EOLIAN static void
> _efl_ui_image_efl_image_smooth_scale_set(Eo *obj EINA_UNUSED,
> Efl_Ui_Image_Data *sd, Eina_Bool smooth)
> {
> - if (sd->edje) return;
> -
> + sd->smooth = smooth;
> evas_object_image_smooth_scale_set(sd->img, smooth);
> }
>
> EOLIAN static Eina_Bool
> _efl_ui_image_efl_image_smooth_scale_get(Eo *obj EINA_UNUSED,
> Efl_Ui_Image_Data *sd)
> {
> - if (sd->edje) return EINA_FALSE;
> -
> - return evas_object_image_smooth_scale_get(sd->img);
> + return sd->smooth;
> }
>
> static Eina_Bool
>
> --
>
>
>
--
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 01/01: emotion: fix autodetection of emotion generic vlc player module.
cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7925c56ec96f600d77b108d296c20bc3a9b1d3bd
commit 7925c56ec96f600d77b108d296c20bc3a9b1d3bd
Author: Cedric Bail
Date: Wed Aug 3 12:01:17 2016 -0700
emotion: fix autodetection of emotion generic vlc player module.
T4273
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 6f4d80c..70b12f1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5065,7 +5065,7 @@ fi
### Check availability
## Generic player
-EMOTION_GENERIC_PLAYER([GENERIC_VLC], [VLC], [libvlc >= 2.0])
+EMOTION_GENERIC_PLAYER([GENERIC_VLC], [yes], [libvlc >= 2.0])
EFL_ADD_FEATURE([EMOTION], [generic_vlc], [${with_generic_vlc}])
EFL_LIB_END([Emotion])
--
Re: [E-devel] Merging efl,eo and ecore
2016-07-29 4:40 GMT+02:00 David Seikel : > On Fri, 29 Jul 2016 10:40:35 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > On Fri, 29 Jul 2016 10:41:14 +1000 David Seikel > > said: > > > > > On Fri, 29 Jul 2016 08:22:51 +0900 Carsten Haitzler (The Rasterman) > > > wrote: > > > > > > > On Thu, 28 Jul 2016 14:55:46 -0700 Cedric BAIL > > > > said: > > > > > > > > > Hello, > > > > > > > > > > I came to realize that splitting this 3 components don't really > > > > > make any more sense. If you want to build anything on top of > > > > > efl, you are > > > > > > > > i totally agree. in fact if we are going to merge... we should do > > > > a lot more merging. we need to decide on a future much smaller > > > > set of libraries > > > > > > > > e.g. (lib* assumed) > > > > > > > > efl: > > > > eina, eo, ecore, efl, eio > > > > > > > > eflgui: > > > > evas, edje, emotion, elementary, ector, ecore_audio, ecore_imf, > > > > ecore_imf_evas, ecore_input > > > > > > > > eflnet: > > > > ecore_con, ecore_ipc, eldbus, ecore_avahi > > > > > > > > eflsys: > > > > ecore_file, efreet, efreet_mime, efreet_trash, elocation > > > > > > > > others left over to figure out... > > > > ephysics, eet, elua, embryo, eolian, ethumb, ethumb_client > > > > > > > > and definitely unportable or dubiously universal lib api's: > > > > eeze, ecore_drm, ecore_drm2, ecore_buffer, ecore_cocoa, > > > > ecore_fb, ecore_psl1ght, ecore_sdl, ecore_wayland, ecore_wl2, > > > > ecore_win32, ecore_x, elput, escape, evil > > > > > > I think you left out evas_3D, though I'm beginning to suspect I'm > > > the only major user of that outside of Samsung. Cedric mentioned > > > that I might be. > > > > it is part of evas already. so included under evas. > > Cool then. > > > > Eet should be part of the efl library, it's a basic part of the > > > system, the data format used by most everything else. Eolian is > > > basically part of eo, it could join it in efl. On the other hand, > > > it's more a tool than a library? > > > > eolian tho is not used at runtime. only for code and doc > > generation... thus i left it out. eet is indeed core... today. but it > > has some issues. we still end up having to allocate masses of ram to > > decode data. we can mmap strings directly BUT realistically i never > > imagined our edje objects and files would become so big. they are > > huge. we eat up multiple MB of data in an app just for this. at least > > 100's of Kb for sure. and every app loads/decodes the same stuff into > > ram from the eet file. > > > > what I need to do is work out something new. something that: > > > > 1. actually isn't a flat key space. the keys in eet files are > > actually using a lot of space as they redundantly encode a parent > > namespace, so make it a tree to avoid this. > > 2. all of this data should be mmaped directly from the file and > > accessed directly without decoding anything to ram at all. all fields > > used on the fly. for the above directory structure etc. > > 3. actual data structures should be accessed directly as mmaped data > > form the file and NOT decoded into ram first. mmap them in place and > > come up with some magic to be able to access them as if they were > > data structures somehow (macros of static inline funcs of some sort). > > we'd then not have pointers but OFFSETS. every piece of data is "it's > > located as offset X in this file". this on 64bit will drop memory > > needed as now we don't use 64bit anymore (well unless we want eet > > files > 4GB...). I was mulling some kind of variable sized encoding > > of values so as long as the data only needs 1 bit, it can become part > > of a flags region of the mmaped mem with 1 bit masked out. same for > > other numbers (chars, int's, shorts, longs, long longs etc.) - encode > > things in some way where it'll only use the bits needed. etc. etc. - > > i haven't thought it out fully yet, BUt this needs a redesign to > > really address the scaling issues we have now. eet was great when > > things were small. not anymore. :( > > Rewriting eet is a whole other subject, might be better to start a new > thread about it. > > For my (not small) SledjHamr virtual world project, I want to use some > sort of fast and compact representation of all the world data. My > initial thought was to try eet, a custom binary protocol I have half > designed, and Lua scripts that have been compressed. Actually, I'm > using Lua scripts as protocol / file format for prototyping things, but > Lua is going to be a big part anyway. I'll benchmark them all, see > which works best. I want to store all this data in whichever format > works best, and use the same format for the network protocol. > > My custom binary protocol could be used as this eet rewrite. It's > fairly generic, since virtual worlds deal with a world full of random > data types and structures. I haven't gotten far enough yet with > anything that it's set in stone, so I could easily re-aim it's design a > litt
[EGIT] [apps/ephoto] master 01/01: Ephoto: Don't try and update gui parts from thread as it will crash.
okra pushed a commit to branch master.
http://git.enlightenment.org/apps/ephoto.git/commit/?id=346a53f02e5152152bfab20bf98aeb7b8764cecf
commit 346a53f02e5152152bfab20bf98aeb7b8764cecf
Author: Stephen okra Houston
Date: Wed Aug 3 13:26:03 2016 -0500
Ephoto: Don't try and update gui parts from thread as it will crash.
---
src/bin/ephoto_file.c | 35 +++
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/src/bin/ephoto_file.c b/src/bin/ephoto_file.c
index 326f2ca..fa7d9d6 100644
--- a/src/bin/ephoto_file.c
+++ b/src/bin/ephoto_file.c
@@ -576,6 +576,16 @@ _processing(Ephoto *ephoto, const char *title, const char
*text)
}
static void
+_thread_end_cb(void *data, Ecore_Thread *et EINA_UNUSED)
+{
+ Evas_Object *popup = data;
+ Ephoto *ephoto = evas_object_data_get(popup, "ephoto");
+
+ evas_object_del(popup);
+ elm_object_focus_set(ephoto->pager, EINA_TRUE);
+}
+
+static void
_move_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
{
Evas_Object *popup = data;
@@ -631,9 +641,6 @@ _move_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
}
ephoto->file_errors = 0;
ephoto->file_pos = NULL;
-
- evas_object_del(popup);
- elm_object_focus_set(ephoto->pager, EINA_TRUE);
}
static void
@@ -650,7 +657,7 @@ _move_files(Ephoto *ephoto, Eina_List *files,
ephoto->file_pos = eina_list_clone(files);
eina_list_free(files);
ephoto->file_thread = ecore_thread_run(_move_thread_cb,
- NULL, NULL, popup);
+ _thread_end_cb, _thread_end_cb, popup);
}
static void
@@ -707,9 +714,6 @@ _copy_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
}
ephoto->file_errors = 0;
ephoto->file_pos = NULL;
-
- evas_object_del(popup);
- elm_object_focus_set(ephoto->pager, EINA_TRUE);
}
static void
@@ -725,7 +729,7 @@ _copy_files(Ephoto *ephoto, Eina_List *files,
ephoto->file_pos = eina_list_clone(files);
eina_list_free(files);
ephoto->file_thread = ecore_thread_run(_copy_thread_cb,
- NULL, NULL, popup);
+ _thread_end_cb, NULL, popup);
}
static void
@@ -787,9 +791,6 @@ _delete_thread_cb(void *data, Ecore_Thread *et EINA_UNUSED)
}
ephoto->file_pos = NULL;
ephoto->file_errors = 0;
-
- evas_object_del(popup);
- elm_object_focus_set(ephoto->pager, EINA_TRUE);
}
static void
@@ -805,7 +806,7 @@ _delete_files(Ephoto *ephoto, Eina_List *files)
ephoto->file_pos = eina_list_clone(files);
eina_list_free(files);
ephoto->file_thread = ecore_thread_run(_delete_thread_cb,
- NULL, NULL, popup);
+ _thread_end_cb, NULL, popup);
}
static void
@@ -863,9 +864,6 @@ _delete_dir_thread_cb(void *data, Ecore_Thread *et
EINA_UNUSED)
}
ephoto->file_pos = NULL;
ephoto->file_errors = 0;
-
- evas_object_del(popup);
- elm_object_focus_set(ephoto->pager, EINA_TRUE);
}
static void
@@ -880,7 +878,7 @@ _delete_dir(Ephoto *ephoto, Eina_List *files)
ephoto->file_pos = NULL;
ephoto->file_thread = ecore_thread_run(_delete_dir_thread_cb,
- NULL, NULL, popup);
+ _thread_end_cb, NULL, popup);
}
static void
@@ -922,9 +920,6 @@ _empty_trash_thread_cb(void *data, Ecore_Thread *th
EINA_UNUSED)
}
ephoto->file_pos = NULL;
ephoto->file_errors = 0;
-
- evas_object_del(popup);
- elm_object_focus_set(ephoto->pager, EINA_TRUE);
}
static void
@@ -939,7 +934,7 @@ _empty_trash(Ephoto *ephoto, Eina_List *files)
ephoto->file_pos = eina_list_clone(files);
eina_list_free(files);
ephoto->file_thread = ecore_thread_run(_empty_trash_thread_cb,
- NULL, NULL, popup);
+ _thread_end_cb, NULL, popup);
}
static void
--
Re: [E-devel] Problem with legacy ecore stuff lifetime
Ok, this has been fixed now in python bindings. The problem was that pyefl assume that every objects are Eo obj internally, was coded this way at efl 1.8 and was a big Eo win that simplify a lot the bindings (infact we rewrite quite everything at that time to use the Eo infra) We really use a little subset of Eo as we know it's not stable, mainly 3 functions: eo_key_data_set() -> to store the created python obj eo_event_callback_add(DEL) -> to clean the python obj eo_class_name_get(eo_class_get(obj)) -> to create the correct python obj as needed Now, from 1.18, ecore.Animators and ecore.Idlers are no more Eo based sigh :( We fixed the issue by rewriting those 2 classes in the old way, without using Eo. This has been easy because the object lifetime are really simple, BUT can be really tricky to do the same on more complex objects. All this just to say: PLEASE DON'T DO THE SAME IN THE FUTURE, or at least speak with me to evaluate the consequences this can have in bindings. Thanks davemds 2016-07-25 21:59 GMT+02:00 Davide Andreoli : > Hi all, > lately quite all the ecore test we have in python-efl are failing for > (seems) the same reason: > > the del callback seems not be called when you return FALSE from a callback > that should delete the object in that case, Animator fe. > > I'm quite sure this is not a python related issue but I have no time until > the next week to look at the C side. Can someone give a look at this? maybe > cedric or tasn? > > This happen in quite all the ecore stuff in python-efl: > Animator > Poller > Idler > IdleEnterer > IdleExiter > > Timers instead seems to work as expected. > > Thanks > > -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Fix compiling evas x engine with no gles
On 08/03/2016 10:58 AM, Gustavo Sverzut Barbieri wrote: > On Wed, Aug 3, 2016 at 10:01 AM, Chris Michael wrote: > [...] >> +#ifndef GL_GLES >> if (v1 >= 360) gw->detected.noext_glXCreatePixmap = 1; >> +#endif >>} >> } >> else >> @@ -558,7 +560,12 @@ try_gles2: >> gw->detected.msaa = val; >> #endif >> >> +#ifndef GL_GLES >> eng_gl_symbols(gw->detected.noext_glXCreatePixmap); >> +#else >> + eng_gl_symbols(EINA_FALSE); // EINA_FALSE is ignored anyway for gl_gles >> +#endif > > Actually this gw->detected.noext_glXCreatePixmap is only used in this > function, thus I wonder why not a local variable instead of adding a > member to the struct and then ifdef it. > > You'd have to ask the original author of the code (jpeg). I just fixed the build break. Cheers, dh -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: Fix compiling evas x engine with no gles
On Wed, Aug 3, 2016 at 10:01 AM, Chris Michael wrote: [...] > +#ifndef GL_GLES > if (v1 >= 360) gw->detected.noext_glXCreatePixmap = 1; > +#endif >} > } > else > @@ -558,7 +560,12 @@ try_gles2: > gw->detected.msaa = val; > #endif > > +#ifndef GL_GLES > eng_gl_symbols(gw->detected.noext_glXCreatePixmap); > +#else > + eng_gl_symbols(EINA_FALSE); // EINA_FALSE is ignored anyway for gl_gles > +#endif Actually this gw->detected.noext_glXCreatePixmap is only used in this function, thus I wonder why not a local variable instead of adding a member to the struct and then ifdef it. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [core/efl] master 02/02: elm: scrollable: add guards to include eo and legacy header only when allowed
stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=9f5e5ae7326cd3bdef6675cb9ca11b86e7b416d1
commit 9f5e5ae7326cd3bdef6675cb9ca11b86e7b416d1
Author: Stefan Schmidt
Date: Wed Aug 3 13:48:02 2016 +0200
elm: scrollable: add guards to include eo and legacy header only when
allowed
Make sure the eo and legacy headers are only included when the matching
defines
are enabled.
---
src/lib/elementary/elm_interface_scrollable.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/lib/elementary/elm_interface_scrollable.h
b/src/lib/elementary/elm_interface_scrollable.h
index f216726..402e306 100644
--- a/src/lib/elementary/elm_interface_scrollable.h
+++ b/src/lib/elementary/elm_interface_scrollable.h
@@ -31,7 +31,12 @@
* Elm_Scrollable_Smart_Interface::extern_pan_set.
*/
+#ifdef EFL_EO_API_SUPPORT
#include "elm_pan.eo.h"
+#endif
+#ifndef EFL_NOLEGACY_API_SUPPORT
+#include "elm_pan.eo.legacy.h"
+#endif
/**
* Elementary scroller panning base smart data.
@@ -57,7 +62,12 @@ typedef void
(*Elm_Interface_Scrollable_Resize_Cb)(Evas_Object *obj, Evas_C
typedef struct _Elm_Scrollable_Smart_Interface_Data
Elm_Scrollable_Smart_Interface_Data;
+#ifdef EFL_EO_API_SUPPORT
#include "elm_interface_scrollable.eo.h"
+#endif
+#ifndef EFL_NOLEGACY_API_SUPPORT
+#include "elm_interface_scrollable.eo.legacy.h"
+#endif
struct _Elm_Scrollable_Smart_Interface_Data
{
--
[EGIT] [core/efl] master 01/02: elm: fileselector: add guards to include eo and legacy header only when allowed
stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=fea0c92bc98bd9b2ce85d84f1163200a7b39f830 commit fea0c92bc98bd9b2ce85d84f1163200a7b39f830 Author: Stefan Schmidt Date: Wed Aug 3 13:46:55 2016 +0200 elm: fileselector: add guards to include eo and legacy header only when allowed Make sure the eo and legacy headers are only included when the matching defines are enabled. --- src/lib/elementary/elm_interface_fileselector.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lib/elementary/elm_interface_fileselector.h b/src/lib/elementary/elm_interface_fileselector.h index e1c3bc7..98e4ba5 100644 --- a/src/lib/elementary/elm_interface_fileselector.h +++ b/src/lib/elementary/elm_interface_fileselector.h @@ -1,7 +1,12 @@ #ifndef ELM_INTEFARCE_FILESELECTOR_H #define ELM_INTEFARCE_FILESELECTOR_H +#ifdef EFL_EO_API_SUPPORT #include "elm_interface_fileselector.eo.h" +#endif +#ifndef EFL_NOLEGACY_API_SUPPORT +#include "elm_interface_fileselector.eo.legacy.h" +#endif #define ELM_FILESELECTOR_INTERFACE_CHECK(obj, ...) \ if (EINA_UNLIKELY(!eo_isa(obj, ELM_INTERFACE_FILESELECTOR_INTERFACE))) \ --
[EGIT] [core/efl] master 01/01: evas: Fix compiling evas x engine with no gles
devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=e4c641ed1e5607651e2d43a832e7cc01471f3fd6
commit e4c641ed1e5607651e2d43a832e7cc01471f3fd6
Author: Chris Michael
Date: Wed Aug 3 08:54:54 2016 -0400
evas: Fix compiling evas x engine with no gles
This fixes an issue from 19eb7b727fbf35620a13fb65b50d3 where the code
would no longer compile due to not finding noext_glXCreatePixmap in
the structure. This was due to the fact that this field was not
compiled into the structure if gl_gles was defined.
Signed-off-by: Chris Michael
---
src/modules/evas/engines/gl_x11/evas_x_main.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/modules/evas/engines/gl_x11/evas_x_main.c
b/src/modules/evas/engines/gl_x11/evas_x_main.c
index 9e03851..98dfcc8 100644
--- a/src/modules/evas/engines/gl_x11/evas_x_main.c
+++ b/src/modules/evas/engines/gl_x11/evas_x_main.c
@@ -542,7 +542,9 @@ try_gles2:
// ALSO as of some nvidia driver version loose binding is
// probably not needed
if (v1 < 195) gw->detected.loose_binding = 1;
+#ifndef GL_GLES
if (v1 >= 360) gw->detected.noext_glXCreatePixmap = 1;
+#endif
}
}
else
@@ -558,7 +560,12 @@ try_gles2:
gw->detected.msaa = val;
#endif
+#ifndef GL_GLES
eng_gl_symbols(gw->detected.noext_glXCreatePixmap);
+#else
+ eng_gl_symbols(EINA_FALSE); // EINA_FALSE is ignored anyway for gl_gles
+#endif
+
gw->gl_context = glsym_evas_gl_common_context_new();
if (!gw->gl_context)
{
--
[EGIT] [bindings/python/python-efl] master 01/01: Add logging to the rest of the individual unit tests
kuuko pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=0916eae9ff7833ee7b88dda95873836fd9b7575c
commit 0916eae9ff7833ee7b88dda95873836fd9b7575c
Author: Kai Huuhko
Date: Wed Aug 3 14:47:42 2016 +0300
Add logging to the rest of the individual unit tests
---
tests/dbus/00_run_all_tests.py | 7 +++
tests/dbus/test_01_basics.py | 7 +++
tests/ecore/00_run_all_tests.py| 8
tests/ecore/test_01_timer.py | 7 +++
tests/ecore/test_02_animator.py| 7 +++
tests/ecore/test_03_poller.py | 7 +++
tests/ecore/test_04_idler.py | 7 +++
tests/ecore/test_05_idle_enterer.py| 7 +++
tests/ecore/test_06_idle_exiter.py | 7 +++
tests/ecore/test_07_fd_handler.py | 8
tests/ecore/test_08_exe.py | 7 +++
tests/ecore/test_09_file_download.py | 7 +++
tests/ecore/test_10_file_monitor.py| 7 +++
tests/ecore/test_11_con.py | 7 +++
tests/edje/00_run_all_tests.py | 7 +++
tests/edje/test_01_basics.py | 7 +++
tests/edje/test_02_object.py | 7 +++
tests/edje/test_03_external.py | 7 +++
tests/edje/test_04_edit.py | 7 +++
tests/edje/test_05_decorators.py | 7 +++
tests/elementary/00_run_all_tests.py | 7 +++
tests/elementary/test_01_basics.py | 7 +++
tests/elementary/test_03_entry.py | 7 +++
tests/eo/00_run_all_tests.py | 7 +++
tests/eo/test_01_basics.py | 7 +++
tests/eo/test_02_class_names.py| 9 +++--
tests/evas/00_run_all_tests.py | 7 +++
tests/evas/test_01_rect.py | 7 +++
tests/evas/test_02_canvas.py | 7 +++
tests/evas/test_03_object.py | 7 +++
tests/evas/test_04_object_box.py | 7 +++
tests/evas/test_05_object_image.py | 7 +++
tests/evas/test_06_object_smart.py | 7 +++
tests/evas/test_07_object_line.py | 7 +++
tests/evas/test_08_object_polygon.py | 7 +++
tests/evas/test_09_object_text.py | 7 +++
tests/evas/test_10_object_textblock.py | 7 +++
tests/evas/test_11_object_textgrid.py | 7 +++
38 files changed, 268 insertions(+), 2 deletions(-)
diff --git a/tests/dbus/00_run_all_tests.py b/tests/dbus/00_run_all_tests.py
index 24dd275..e0bd7c2 100644
--- a/tests/dbus/00_run_all_tests.py
+++ b/tests/dbus/00_run_all_tests.py
@@ -1,7 +1,14 @@
#!/usr/bin/env python
import unittest
+import logging
+formatter = logging.Formatter("[%(levelname)s] %(name)s (%(filename)s:
%(lineno)d) --- %(message)s")
+handler = logging.StreamHandler()
+handler.setFormatter(formatter)
+efllog = logging.getLogger("efl")
+efllog.addHandler(handler)
+efllog.setLevel(logging.DEBUG)
loader = unittest.TestLoader()
suite = loader.discover('.')
diff --git a/tests/dbus/test_01_basics.py b/tests/dbus/test_01_basics.py
index 183f5a9..72c2518 100644
--- a/tests/dbus/test_01_basics.py
+++ b/tests/dbus/test_01_basics.py
@@ -5,6 +5,7 @@ import dbus.service
from efl.dbus_mainloop import DBusEcoreMainLoop
from efl import ecore
import unittest
+import logging
class TestDBusBasics(unittest.TestCase):
@@ -39,4 +40,10 @@ class TestDBusBasics(unittest.TestCase):
if __name__ == '__main__':
+formatter = logging.Formatter("[%(levelname)s] %(name)s (%(filename)s:
%(lineno)d) --- %(message)s")
+handler = logging.StreamHandler()
+handler.setFormatter(formatter)
+efllog = logging.getLogger("efl")
+efllog.addHandler(handler)
+efllog.setLevel(logging.DEBUG)
unittest.main(verbosity=2)
diff --git a/tests/ecore/00_run_all_tests.py b/tests/ecore/00_run_all_tests.py
index 24dd275..3dbbca3 100644
--- a/tests/ecore/00_run_all_tests.py
+++ b/tests/ecore/00_run_all_tests.py
@@ -1,8 +1,16 @@
#!/usr/bin/env python
import unittest
+import logging
+formatter = logging.Formatter("[%(levelname)s] %(name)s (%(filename)s:
%(lineno)d) --- %(message)s")
+handler = logging.StreamHandler()
+handler.setFormatter(formatter)
+efllog = logging.getLogger("efl")
+efllog.addHandler(handler)
+efllog.setLevel(logging.DEBUG)
+
loader = unittest.TestLoader()
suite = loader.discover('.')
runner = unittest.TextTestRunner(verbosity=2)
diff --git a/tests/ecore/test_01_timer.py b/tests/ecore/test_01_timer.py
index 3a3609d..81709aa 100644
--- a/tests/ecore/test_01_timer.py
+++ b/tests/ecore/test_01_timer.py
@@ -2,6 +2,7 @@
from efl import ecore
import unittest
+import logging
def cb(n, t, a):
@@ -56,4 +57,10 @@ class TestTimer(unittest.TestCase):
if __name__ == '__main__':
+formatter = logging.Formatter("[%(levelname)s] %(name)s (%(filename)s:
%(lineno)d) --- %(message)s")
+handler = logging.StreamHandler()
+handler.setFormatter(formatter)
+efllog = logging.getLogger("efl")
+efllog.addHandler(handler)
+efllog.setLevel(logging.D
Re: [E-devel] [RFC] ecore-con eoify
Em quarta-feira, 3 de agosto de 2016, David Seikel escreveu: > On Wed, 3 Aug 2016 00:05:10 -0300 Gustavo Sverzut Barbieri > > wrote: > > > > Also possible additional operation would be sending a file. > > > Eina_File should be a native type to any binding and we do have a > > > few place where you get one, would be nice to do be able to > > > transparently send one. > > > > See my comment about Eina.Blob. > > > > It should cover that unless you want to do progressive loading of > > chunks, such as instead of providing a full mmap()'ed file, you just > > open(2) it and on "read(size)", you do the syscall. This could be > > useful to fd that does not describe a file, but a socket, pipe, etc.. > > Well, yes, I want to do progressive downloading and showing of images, > with a chance to pause / stop the download. The use case is 3D virtual > worlds, you download only enough of progressive image format to be able > to show it at the current LOD for the 3D model it's attached to. In > other words, if this particular image is only used as a texture around > a model that is off in the distance, we only need to download enough of > the image to be clearly visible at a distance. The closer we get, the > more we need to download, since now you can see it clearer. This is unrelated, it's the send side I'm talking about. You can clearly do what you want with the read API. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[EGIT] [tools/enventor] master 01/01: edj_viewer: safety code.
hermet pushed a commit to branch master.
http://git.enlightenment.org/tools/enventor.git/commit/?id=fb4c8b70a8a59dcaaa3635b7a8421929e5f901dd
commit fb4c8b70a8a59dcaaa3635b7a8421929e5f901dd
Author: Hermet Park
Date: Wed Aug 3 19:55:58 2016 +0900
edj_viewer: safety code.
+ null check
---
src/lib/edj_viewer.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/lib/edj_viewer.c b/src/lib/edj_viewer.c
index 7015703..73fa1ec 100644
--- a/src/lib/edj_viewer.c
+++ b/src/lib/edj_viewer.c
@@ -835,6 +835,12 @@ void
view_size_get(view_data *vd, Evas_Coord *w, Evas_Coord *h)
{
if (!w || !h) return;
+ if (!vd)
+ {
+*w = 0;
+*h = 0;
+return;
+ }
evas_object_geometry_get(vd->layout, NULL , NULL, w, h);
--
[EGIT] [tools/enventor] master 01/01: Support individual group view scale.
hermet pushed a commit to branch master.
http://git.enlightenment.org/tools/enventor.git/commit/?id=fd050aacf2bba472ed746662deefa11756e535fa
commit fd050aacf2bba472ed746662deefa11756e535fa
Author: Hermet Park
Date: Wed Aug 3 19:35:04 2016 +0900
Support individual group view scale.
Now, groups keep their own view scale on their own contexts.
This will help user simultaneous group editing.
---
src/bin/config_data.c | 26 --
src/bin/live_edit.c| 6 --
src/bin/main.c | 21 -
src/bin/statusbar.c| 8 +---
src/include/common.h | 2 +-
src/include/config_data.h | 2 --
src/lib/edj_mgr.c | 18 --
src/lib/edj_viewer.c | 18 +-
src/lib/enventor_private.h | 3 +--
src/lib/enventor_smart.c | 4 ++--
10 files changed, 38 insertions(+), 70 deletions(-)
diff --git a/src/bin/config_data.c b/src/bin/config_data.c
index 89894ee..1c6836e 100644
--- a/src/bin/config_data.c
+++ b/src/bin/config_data.c
@@ -21,7 +21,6 @@ typedef struct config_s
unsigned int version;
float font_scale;
- double view_scale;
double editor_size;
double console_size;
@@ -189,7 +188,6 @@ config_load(void)
cd->fnt_path_list = NULL;
cd->dat_path_list = NULL;
cd->font_scale = 1;
-cd->view_scale = 1;
cd->view_size_w = 300;
cd->view_size_h = 300;
cd->win_size_w = WIN_DEFAULT_W;
@@ -299,8 +297,6 @@ eddc_init(void)
EET_T_STRING);
EET_DATA_DESCRIPTOR_ADD_BASIC(edd_base, config_data, "font_scale",
font_scale,
EET_T_FLOAT);
- EET_DATA_DESCRIPTOR_ADD_BASIC(edd_base, config_data, "view_scale",
- view_scale, EET_T_DOUBLE);
EET_DATA_DESCRIPTOR_ADD_BASIC(edd_base, config_data, "editor_size",
editor_size, EET_T_DOUBLE);
EET_DATA_DESCRIPTOR_ADD_BASIC(edd_base, config_data, "console_size",
@@ -940,28 +936,6 @@ config_auto_indent_set(Eina_Bool auto_indent)
}
void
-config_view_scale_set(double view_scale)
-{
- config_data *cd = g_cd;
- EINA_SAFETY_ON_NULL_RETURN(cd);
-
- if (view_scale > MAX_VIEW_SCALE)
- view_scale = MAX_VIEW_SCALE;
- else if (view_scale < MIN_VIEW_SCALE)
- view_scale = MIN_VIEW_SCALE;
- cd->view_scale = view_scale;
-}
-
-double
-config_view_scale_get(void)
-{
- config_data *cd = g_cd;
- EINA_SAFETY_ON_NULL_RETURN_VAL(cd, 0);
-
- return cd->view_scale;
-}
-
-void
config_view_size_set(Evas_Coord w, Evas_Coord h)
{
config_data *cd = g_cd;
diff --git a/src/bin/live_edit.c b/src/bin/live_edit.c
index 3926cea..7aa1a80 100644
--- a/src/bin/live_edit.c
+++ b/src/bin/live_edit.c
@@ -344,7 +344,8 @@ live_edit_symbol_set(live_data *ld)
snprintf(buf, sizeof(buf), "%s_bg", LIVEEDIT_ITEMS[ld->type].name);
Evas_Object *layout_symbol = elm_layout_add(ld->layout);
elm_layout_file_set(layout_symbol, EDJE_PATH, buf);
- elm_object_scale_set(layout_symbol, config_view_scale_get());
+ elm_object_scale_set(layout_symbol,
+
enventor_object_live_view_scale_get(base_enventor_get()));
elm_object_part_content_set(ld->layout, "elm.swallow.symbol",
layout_symbol);
}
@@ -2184,7 +2185,8 @@ live_edit_update(void)
Evas_Object *layout_symbol =
elm_object_part_content_get(ld->layout, "elm.swallow.symbol");
if (layout_symbol)
- elm_object_scale_set(layout_symbol, config_view_scale_get());
+ elm_object_scale_set(layout_symbol,
+
enventor_object_live_view_scale_get(base_enventor_get()));
live_edit_update_internal(ld);
}
diff --git a/src/bin/main.c b/src/bin/main.c
index ad6629d..71966e0 100644
--- a/src/bin/main.c
+++ b/src/bin/main.c
@@ -36,7 +36,6 @@ enventor_common_setup(Enventor_Object *enventor)
config_font_get(&font_name, &font_style);
enventor_object_font_set(enventor, font_name, font_style);
enventor_object_font_scale_set(enventor, config_font_scale_get());
- enventor_object_live_view_scale_set(enventor, config_view_scale_get());
enventor_object_auto_indent_set(enventor, config_auto_indent_get());
enventor_object_auto_complete_set(enventor, config_auto_complete_get());
enventor_object_smart_undo_redo_set(enventor, config_smart_undo_redo_get());
@@ -123,7 +122,6 @@ config_update_cb(void *data EINA_UNUSED)
syntax_color_update(enventor);
- stats_view_scale_update(config_view_scale_get());
base_tools_toggle(EINA_FALSE);
base_statusbar_toggle(EINA_FALSE);
base_console_auto_hide();
@@ -145,13 +143,14 @@ main_mouse_wheel_cb(void *data EINA_UNUSED, int type
EINA_UNUSED, void *ev)
if ((event->x >= x) && (event->x <= (x + w)) &&
(event->y >= y) && (event->y <= (y + h)))
{
-double scale = config_view_scale_get();
+double scale =
enventor_object_live_view_scale_get(base_enventor_ge
[EGIT] [core/efl] master 01/01: elm focus default theme: fix wrong resizing
woohyun pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=bb2e4195d7d0d510c968a0ba33c8b0ccfc94e101
commit bb2e4195d7d0d510c968a0ba33c8b0ccfc94e101
Author: WooHyun Jung
Date: Wed Aug 3 19:14:16 2016 +0900
elm focus default theme: fix wrong resizing
When focus is moved rapidly, final size of focus highlight is not
matched well with the focused object.
Without running anim in edc, it shows right performance.
@fix
---
data/elementary/themes/edc/elm/focus.edc | 1 -
1 file changed, 1 deletion(-)
diff --git a/data/elementary/themes/edc/elm/focus.edc
b/data/elementary/themes/edc/elm/focus.edc
index 2ea2804..663aeda 100644
--- a/data/elementary/themes/edc/elm/focus.edc
+++ b/data/elementary/themes/edc/elm/focus.edc
@@ -38,7 +38,6 @@ group { name: "elm/focus_highlight/top/default";
anim_id = get_int(g_anim_id);
if (anim_id != 0) {
cancel_anim(anim_id);
- animator1(1, 1.0);
}
x1 = getarg(2);
--
[EGIT] [core/enlightenment] master 02/02: e_alert: define EFL_BETA_API_SUPPORT before any include
bu5hm4n pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=66b4ff408e70b548aad1234ef400505799be7bc2 commit 66b4ff408e70b548aad1234ef400505799be7bc2 Author: Marcel Hollerbach Date: Wed Aug 3 11:30:58 2016 +0200 e_alert: define EFL_BETA_API_SUPPORT before any include otherwise we can include half efl without api and the other parts with beta api support, which leads to problems. The current problem was that Eo.h was first included without the EFL_BETA_API_SUPPORT, in Evas.h EFL_BETA_API_SUPPORT is defined, so the header expects Eo_Callback_Priority to be defined. @fix --- src/bin/e_alert_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bin/e_alert_main.c b/src/bin/e_alert_main.c index b2bcd3c..c0cb3c6 100644 --- a/src/bin/e_alert_main.c +++ b/src/bin/e_alert_main.c @@ -1,5 +1,9 @@ #include "config.h" +#ifdef HAVE_DRM2 +# define EFL_BETA_API_SUPPORT +#endif + #include #include #include @@ -19,7 +23,6 @@ # ifdef HAVE_WL_DRM # include # ifdef HAVE_DRM2 -# define EFL_BETA_API_SUPPORT # include # include # else --
[EGIT] [core/enlightenment] master 01/02: e_comp_wl: destroy e_drag when source disappears
bu5hm4n pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=180abefc0c2cd8e094a508589493bc5883589518
commit 180abefc0c2cd8e094a508589493bc5883589518
Author: Marcel Hollerbach
Date: Mon Jul 25 19:49:55 2016 +0200
e_comp_wl: destroy e_drag when source disappears
Otherwise we are expecting a running dnd later, and accessing invalid
memory.
---
src/bin/e_comp_wl_data.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/bin/e_comp_wl_data.c b/src/bin/e_comp_wl_data.c
index 04ccd32..0ea274c 100644
--- a/src/bin/e_comp_wl_data.c
+++ b/src/bin/e_comp_wl_data.c
@@ -375,7 +375,12 @@ _e_comp_wl_data_source_cb_resource_destroy(struct
wl_resource *resource)
_mime_types_free(source);
if (e_comp_wl->drag_source == source)
- e_comp_wl->drag_source = NULL;
+ {
+e_comp_wl->drag_source = NULL;
+//free the drag here
+e_object_del(E_OBJECT(e_comp_wl->drag));
+e_comp_wl->drag = NULL;
+ }
free(source);
}
--
[EGIT] [tools/enventor] master 01/01: file_tab: actually, list item allows to use tooltip.
hermet pushed a commit to branch master. http://git.enlightenment.org/tools/enventor.git/commit/?id=d57b173d394a28a954d57a7dc889c04faf71df59 commit d57b173d394a28a954d57a7dc889c04faf71df59 Author: Hermet Park Date: Wed Aug 3 18:34:48 2016 +0900 file_tab: actually, list item allows to use tooltip. --- src/bin/file_tab.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/bin/file_tab.c b/src/bin/file_tab.c index 514fcbe..e0cdb78 100644 --- a/src/bin/file_tab.c +++ b/src/bin/file_tab.c @@ -195,13 +195,11 @@ file_tab_it_add(Enventor_Item *enventor_it) elm_image_file_set(img, EDJE_PATH, "close"); elm_object_content_set(btn, img); - //Tooltip Dummy object - Evas_Object *box = elm_image_add(fd->list); - elm_object_tooltip_text_set(box, ecore_file_realpath(filepath)); - elm_object_tooltip_orient_set(box, ELM_TOOLTIP_ORIENT_TOP); - - fti->it = elm_list_item_append(fd->list, filename, btn, box, + fti->it = elm_list_item_append(fd->list, filename, btn, NULL, list_item_selected_cb, fti); + + elm_object_item_tooltip_text_set(fti->it, ecore_file_realpath(filepath)); + elm_list_go(fd->list); evas_object_smart_callback_add(btn, "clicked", close_btn_clicked_cb, fti); --
[EGIT] [tools/enventor] master 01/01: file_tab: support full path tooltip info.
hermet pushed a commit to branch master.
http://git.enlightenment.org/tools/enventor.git/commit/?id=98e833ef37f4802fe5cf1d99cf31ec086b31615a
commit 98e833ef37f4802fe5cf1d99cf31ec086b31615a
Author: Hermet Park
Date: Wed Aug 3 18:30:49 2016 +0900
file_tab: support full path tooltip info.
---
data/themes/default/theme_ext.edc | 5 +
src/bin/file_tab.c| 7 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/data/themes/default/theme_ext.edc
b/data/themes/default/theme_ext.edc
index 6204ca2..62404b6 100644
--- a/data/themes/default/theme_ext.edc
+++ b/data/themes/default/theme_ext.edc
@@ -389,6 +389,11 @@ group { name: "elm/list/h_item/enventor";
visible: 1;
}
}
+ swallow { "elm.swallow.end";
+ repeat_events: 1;
+ desc { "default";
+ }
+ }
program {
signal: "elm,state,selected"; source: "elm";
action: STATE_SET "selected" 0.0;
diff --git a/src/bin/file_tab.c b/src/bin/file_tab.c
index 336e040..514fcbe 100644
--- a/src/bin/file_tab.c
+++ b/src/bin/file_tab.c
@@ -195,7 +195,12 @@ file_tab_it_add(Enventor_Item *enventor_it)
elm_image_file_set(img, EDJE_PATH, "close");
elm_object_content_set(btn, img);
- fti->it = elm_list_item_append(fd->list, filename, btn, NULL,
+ //Tooltip Dummy object
+ Evas_Object *box = elm_image_add(fd->list);
+ elm_object_tooltip_text_set(box, ecore_file_realpath(filepath));
+ elm_object_tooltip_orient_set(box, ELM_TOOLTIP_ORIENT_TOP);
+
+ fti->it = elm_list_item_append(fd->list, filename, btn, box,
list_item_selected_cb, fti);
elm_list_go(fd->list);
--
[EGIT] [core/efl] master 01/01: elm image - store smooth scale var in object as intended
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f23788dcb0c2b969f5312a3d72a8e0874952e64f
commit f23788dcb0c2b969f5312a3d72a8e0874952e64f
Author: Carsten Haitzler (Rasterman)
Date: Wed Aug 3 18:24:16 2016 +0900
elm image - store smooth scale var in object as intended
this fixesa bug reported by davemds and kuuko in python bindings test
suite where setting smooth flag != getting it right after.
---
src/lib/elementary/efl_ui_image.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/lib/elementary/efl_ui_image.c
b/src/lib/elementary/efl_ui_image.c
index 8bf16a8..ba52cc9 100644
--- a/src/lib/elementary/efl_ui_image.c
+++ b/src/lib/elementary/efl_ui_image.c
@@ -544,17 +544,14 @@ _efl_ui_image_edje_file_set(Evas_Object *obj,
EOLIAN static void
_efl_ui_image_efl_image_smooth_scale_set(Eo *obj EINA_UNUSED,
Efl_Ui_Image_Data *sd, Eina_Bool smooth)
{
- if (sd->edje) return;
-
+ sd->smooth = smooth;
evas_object_image_smooth_scale_set(sd->img, smooth);
}
EOLIAN static Eina_Bool
_efl_ui_image_efl_image_smooth_scale_get(Eo *obj EINA_UNUSED,
Efl_Ui_Image_Data *sd)
{
- if (sd->edje) return EINA_FALSE;
-
- return evas_object_image_smooth_scale_get(sd->img);
+ return sd->smooth;
}
static Eina_Bool
--
[EGIT] [bindings/python/python-efl] master 01/01: Enable logging in elm image icon unit test
kuuko pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=d6bad7a8389e33b8e3cf1a98e8155cffbaca5989
commit d6bad7a8389e33b8e3cf1a98e8155cffbaca5989
Author: Kai Huuhko
Date: Wed Aug 3 12:10:12 2016 +0300
Enable logging in elm image icon unit test
---
tests/elementary/test_02_image_icon.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/elementary/test_02_image_icon.py
b/tests/elementary/test_02_image_icon.py
index 1c9b638..9031a51 100644
--- a/tests/elementary/test_02_image_icon.py
+++ b/tests/elementary/test_02_image_icon.py
@@ -2,6 +2,7 @@
import os
import unittest
+import logging
from efl.eo import Eo
from efl.evas import Image as evasImage
@@ -95,4 +96,10 @@ class TestElmIcon(unittest.TestCase):
u"this_fails")
if __name__ == '__main__':
+formatter = logging.Formatter("[%(levelname)s] %(name)s (%(filename)s:
%(lineno)d) --- %(message)s")
+handler = logging.StreamHandler()
+handler.setFormatter(formatter)
+efllog = logging.getLogger("efl")
+efllog.addHandler(handler)
+efllog.setLevel(logging.DEBUG)
unittest.main(verbosity=2)
--
[EGIT] [core/efl] master 01/01: widget: Fix propagation of events on hold
jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=9b2980e1b1bd1d7fd16c34b8f96b14a782926447 commit 9b2980e1b1bd1d7fd16c34b8f96b14a782926447 Author: Jean-Philippe Andre Date: Wed Aug 3 18:08:31 2016 +0900 widget: Fix propagation of events on hold Because of the translation between legacy and eo key events, the on_hold flag state could sometimes be lost. Symptom: elementary_test -to Focus Click on a button inside the scroller Up/down would jump to the end of the scroller, rather than the next button. Thanks a lot to Woohyeon for the very good bug report. --- src/lib/elementary/elm_widget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/elementary/elm_widget.c b/src/lib/elementary/elm_widget.c index fe56a87..18e38da 100644 --- a/src/lib/elementary/elm_widget.c +++ b/src/lib/elementary/elm_widget.c @@ -783,6 +783,8 @@ _propagate_event(void *data EINA_UNUSED, const Eo_Event *event) return; elm_widget_event_propagate(obj, type, &event_info, event_flags); + if (*event_flags & EVAS_EVENT_FLAG_ON_HOLD) + efl_event_processed_set(event->info, EINA_TRUE); } /** --
[EGIT] [core/efl] master 01/02: gl_x11: Minor code refactor around eglCreateImage
jpeg pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=444ab8fb175d2387513efb5256cc4c3bd4844702
commit 444ab8fb175d2387513efb5256cc4c3bd4844702
Author: Jean-Philippe Andre
Date: Wed Aug 3 11:29:14 2016 +0900
gl_x11: Minor code refactor around eglCreateImage
Trying to debug T3030... hitting a brick wall at the moment.
Add better error handling (for EGL).
---
src/modules/evas/engines/gl_x11/evas_engine.c | 33 +++
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/src/modules/evas/engines/gl_x11/evas_engine.c
b/src/modules/evas/engines/gl_x11/evas_engine.c
index 19fa9be..7a9f943 100644
--- a/src/modules/evas/engines/gl_x11/evas_engine.c
+++ b/src/modules/evas/engines/gl_x11/evas_engine.c
@@ -2551,6 +2551,11 @@ eng_image_native_set(void *data, void *image, void
*native)
#ifdef GL_GLES
if (native)
{
+if (!glsym_eglCreateImage)
+ {
+ ERR("Try eglCreateImage on EGL with no support");
+ return NULL;
+ }
n = calloc(1, sizeof(Native));
if (n)
{
@@ -2559,8 +2564,6 @@ eng_image_native_set(void *data, void *image, void
*native)
int num_config, i = 0;
int yinvert = 1;
-
eina_hash_add(eng_get_ob(re)->gl_context->shared->native_pm_hash, &pmid, im);
-
// assume 32bit pixmap! :)
config_attrs[i++] = EGL_RED_SIZE;
config_attrs[i++] = 8;
@@ -2587,9 +2590,11 @@ eng_image_native_set(void *data, void *image, void
*native)
&egl_config, 1, &num_config))
{
int err = eglGetError();
- ERR("eglChooseConfig() failed for pixmap 0x%x,
num_config = %i with error %d",
- (unsigned int)pm,
num_config, err);
+ ERR("eglChooseConfig() failed for pixmap %#lx, "
+ "num_config = %i with error %d", pm, num_config,
err);
glsym_evas_gl_common_error_set(err - EGL_SUCCESS);
+ free(n);
+ return NULL;
}
else
{
@@ -2603,18 +2608,17 @@ eng_image_native_set(void *data, void *image, void
*native)
memcpy(&(n->ns), ns, sizeof(Evas_Native_Surface));
n->ns_data.x11.pixmap = pm;
n->ns_data.x11.visual = vis;
- if (glsym_eglCreateImage)
- n->ns_data.x11.surface =
glsym_eglCreateImage(eng_get_ob(re)->egl_disp,
-
EGL_NO_CONTEXT,
-
EGL_NATIVE_PIXMAP_KHR,
- (void *)pm,
- NULL);
- else
- ERR("Try eglCreateImage on EGL with no support");
+ n->ns_data.x11.surface =
glsym_eglCreateImage(eng_get_ob(re)->egl_disp,
+ EGL_NO_CONTEXT,
+
EGL_NATIVE_PIXMAP_KHR,
+ (void *)pm,
NULL);
if (!n->ns_data.x11.surface)
- ERR("eglCreatePixmapSurface() for 0x%x failed", (unsigned
int)pm);
+ {
+ ERR("eglCreateImage() for Pixmap %#lx failed: %#x", pm,
eglGetError());
+ free(n);
+ return NULL;
+ }
n->ns_data.x11.config = (void *)egl_config;
-
im->native.yinvert = yinvert;
im->native.loose = 0;
im->native.disp= eng_get_ob(re)->egl_disp;
@@ -2625,6 +2629,7 @@ eng_image_native_set(void *data, void *image, void
*native)
im->native.func.free = _native_free_cb;
im->native.target = GL_TEXTURE_2D;
im->native.mipmap = 0;
+
eina_hash_add(eng_get_ob(re)->gl_context->shared->native_pm_hash, &pmid, im);
glsym_evas_gl_common_image_native_enable(im);
}
}
--
[EGIT] [core/efl] master 02/02: glx: Fix black windows in E on nvidia
jpeg pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=19eb7b727fbf35620a13fb65b50d3056a484360e
commit 19eb7b727fbf35620a13fb65b50d3056a484360e
Author: Jean-Philippe Andre
Date: Wed Aug 3 16:32:39 2016 +0900
glx: Fix black windows in E on nvidia
This fixes calls to glXCreatePixmap that would consistently
fail on nvidia >= 360.
It seems glXCreatePixmapEXT was used instead of glXCreatePixmap,
and that function always returned 0.
One could assume always using the non-EXT version of the
function should be preferred. Unfortunately, doing so for all
the other functions brings back the black windows.
I'm taking a very careful approach by doing this only for drivers
>= 360.
Fixes T3030
@fix
---
src/modules/evas/engines/gl_x11/evas_engine.c | 14 +-
src/modules/evas/engines/gl_x11/evas_engine.h | 3 ++-
src/modules/evas/engines/gl_x11/evas_x_main.c | 3 ++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/modules/evas/engines/gl_x11/evas_engine.c
b/src/modules/evas/engines/gl_x11/evas_engine.c
index 7a9f943..f5d783d 100644
--- a/src/modules/evas/engines/gl_x11/evas_engine.c
+++ b/src/modules/evas/engines/gl_x11/evas_engine.c
@@ -1330,13 +1330,15 @@ gl_symbols(void)
}
void
-eng_gl_symbols(void)
+eng_gl_symbols(Eina_Bool noext_glXCreatePixmap)
{
static int done = 0;
if (done) return;
#ifdef GL_GLES
+ (void) noext_glXCreatePixmap;
+
#define FINDSYM(dst, sym, typ) \
if (glsym_eglGetProcAddress) { \
if (!dst) dst = (typ)glsym_eglGetProcAddress(sym); \
@@ -1374,6 +1376,16 @@ eng_gl_symbols(void)
glsym_evas_gl_symbols((void*)glsym_glXGetProcAddress);
+ if (noext_glXCreatePixmap)
+ {
+/* Note for nvidia >= 360:
+ * glXBindTexImage{EXT,ARB} should be preferred over glXBindTexImage
+ * glXCreatePixmap should be preferred over glXCreatePixmap{EXT,ARB}
+ */
+FINDSYM(glsym_glXCreatePixmap, "glXCreatePixmap", glsym_func_xid);
+FINDSYM(glsym_glXDestroyPixmap, "glXDestroyPixmap", glsym_func_void);
+ }
+
FINDSYM(glsym_glXBindTexImage, "glXBindTexImageEXT", glsym_func_void);
FINDSYM(glsym_glXBindTexImage, "glXBindTexImageARB", glsym_func_void);
FINDSYM(glsym_glXBindTexImage, "glXBindTexImage", glsym_func_void);
diff --git a/src/modules/evas/engines/gl_x11/evas_engine.h
b/src/modules/evas/engines/gl_x11/evas_engine.h
index f84313b..5ecdd59 100644
--- a/src/modules/evas/engines/gl_x11/evas_engine.h
+++ b/src/modules/evas/engines/gl_x11/evas_engine.h
@@ -76,6 +76,7 @@ struct _Outbuf
unsigned char msaa;
#ifndef GL_GLES
Eina_Bool loose_binding : 1;
+ Eina_Bool noext_glXCreatePixmap : 1;
#endif
} detected;
@@ -199,7 +200,7 @@ Evas_Engine_GL_Context *eng_outbuf_gl_context_get(Outbuf
*ob);
void *eng_outbuf_egl_display_get(Outbuf *ob);
Eina_Bool eng_preload_make_current(void *data, void *doit);
-void eng_gl_symbols(void);
+void eng_gl_symbols(Eina_Bool noext_glXCreatePixmap);
static inline int
_re_wincheck(Outbuf *ob)
diff --git a/src/modules/evas/engines/gl_x11/evas_x_main.c
b/src/modules/evas/engines/gl_x11/evas_x_main.c
index f5e2edf..9e03851 100644
--- a/src/modules/evas/engines/gl_x11/evas_x_main.c
+++ b/src/modules/evas/engines/gl_x11/evas_x_main.c
@@ -542,6 +542,7 @@ try_gles2:
// ALSO as of some nvidia driver version loose binding is
// probably not needed
if (v1 < 195) gw->detected.loose_binding = 1;
+ if (v1 >= 360) gw->detected.noext_glXCreatePixmap = 1;
}
}
else
@@ -557,7 +558,7 @@ try_gles2:
gw->detected.msaa = val;
#endif
- eng_gl_symbols();
+ eng_gl_symbols(gw->detected.noext_glXCreatePixmap);
gw->gl_context = glsym_evas_gl_common_context_new();
if (!gw->gl_context)
{
--
[EGIT] [core/enlightenment] master 01/01: e comp - set alpha after setting native surface to avoid random crash
raster pushed a commit to branch master.
http://git.enlightenment.org/core/enlightenment.git/commit/?id=82c6bdf031eb50ef444a95ca7fe48a8146ccce43
commit 82c6bdf031eb50ef444a95ca7fe48a8146ccce43
Author: Carsten Haitzler (Rasterman)
Date: Wed Aug 3 17:27:23 2016 +0900
e comp - set alpha after setting native surface to avoid random crash
i noticed a crash on texture update with a previous garbage image data
ptr set before becoming a native suttface and so setting alpha would
cause a texture upload from a garbage pointer, so set native surface
then set alpha on or off so the data ptr is no longer used.
@fix
---
src/bin/e_comp_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/e_comp_object.c b/src/bin/e_comp_object.c
index af97018..32b4756 100644
--- a/src/bin/e_comp_object.c
+++ b/src/bin/e_comp_object.c
@@ -3751,8 +3751,8 @@ e_comp_object_native_surface_set(Evas_Object *obj,
Eina_Bool set)
evas_object_image_native_surface_set(cw->obj, set && (!cw->blanked) ?
(cw->ns ?: &ns) : NULL);
EINA_LIST_FOREACH(cw->obj_mirror, l, o)
{
-evas_object_image_alpha_set(o, !!cw->ns ? 1 : cw->ec->argb);
evas_object_image_native_surface_set(o, set ? (cw->ns ?: &ns) : NULL);
+evas_object_image_alpha_set(o, !!cw->ns ? 1 : cw->ec->argb);
}
}
--
[EGIT] [core/efl] master 01/01: elm theme - don't use empty env vars eina_prefix handles anyway
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=abeeb11b19a30a5721389bbd9699f92d0aca76a4
commit abeeb11b19a30a5721389bbd9699f92d0aca76a4
Author: Carsten Haitzler (Rasterman)
Date: Wed Aug 3 17:27:42 2016 +0900
elm theme - don't use empty env vars eina_prefix handles anyway
in 14ec825aa9ed9c6ede79d1729fdb291285b3bd6d cedric added trying
ELM_DATA_DIR env var explicitly for looking for themes. first if this
is NULL then we look in a bogus directory (null). secondly eina_prefix
already takes care of env vars like thsi as part of figuring out
prefix with correct namespace etc. so this just is a bug as opposed to
anything useful and the CORRECt implementation is already done in
eina_prefix.
@fix
---
src/lib/elementary/elm_theme.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/lib/elementary/elm_theme.c b/src/lib/elementary/elm_theme.c
index 96c15f0..542316b 100644
--- a/src/lib/elementary/elm_theme.c
+++ b/src/lib/elementary/elm_theme.c
@@ -96,14 +96,6 @@ _elm_theme_file_item_add(Elm_Theme_Files *files, const char
*item, Eina_Bool pre
eina_strbuf_append_printf(buf,
"%s/themes/%s.edj",
- getenv("ELM_DATA_DIR"), item);
-f = eina_file_open(eina_strbuf_string_get(buf), EINA_FALSE);
-_elm_theme_item_finalize(files, item, f, prepend, istheme);
-
-eina_strbuf_reset(buf);
-
-eina_strbuf_append_printf(buf,
- "%s/themes/%s.edj",
_elm_data_dir, item);
f = eina_file_open(eina_strbuf_string_get(buf), EINA_FALSE);
/* Finalize will be done by the common one */
--
[EGIT] [tools/eflete] master 02/02: import_edj: compare the widget name exactly.
jaehwan pushed a commit to branch master.
http://git.enlightenment.org/tools/eflete.git/commit/?id=ef3d96ec2b967e936f16e019cf267ab172549223
commit ef3d96ec2b967e936f16e019cf267ab172549223
Author: Jaehwan Kim
Date: Wed Aug 3 16:55:13 2016 +0900
import_edj: compare the widget name exactly.
If not, when we want to load button the multibuttonentry is loaded
with button.
@fix
---
src/bin/ui/tab_home_import_edj.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/bin/ui/tab_home_import_edj.c b/src/bin/ui/tab_home_import_edj.c
index db76b1a..09a5833 100644
--- a/src/bin/ui/tab_home_import_edj.c
+++ b/src/bin/ui/tab_home_import_edj.c
@@ -713,8 +713,11 @@ _tab_import_edj_data_set(const char *name, const char
*path, const char *edj, co
{
EINA_LIST_FOREACH(node->list, l1, sub)
{
-if (strstr(sub->name, widget_name))
+Eina_Stringshare *wname = widget_name_get(sub->name);
+
+if (!strcmp(wname, widget_name))
_genlist_style_selected_set(sub, style_list, true);
+eina_stringshare_del(wname);
}
}
else
--
[EGIT] [tools/eflete] master 01/02: widget_list: fix the memory leak.
jaehwan pushed a commit to branch master.
http://git.enlightenment.org/tools/eflete.git/commit/?id=b827975f8c3e67697279799422759d8edf5dcaf3
commit b827975f8c3e67697279799422759d8edf5dcaf3
Author: Jaehwan Kim
Date: Wed Aug 3 16:54:16 2016 +0900
widget_list: fix the memory leak.
@fix
---
src/bin/common/widget_list.c | 16 +---
src/bin/ui/tab_home_common.c | 2 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/bin/common/widget_list.c b/src/bin/common/widget_list.c
index e20bbda..b29018a 100644
--- a/src/bin/common/widget_list.c
+++ b/src/bin/common/widget_list.c
@@ -53,7 +53,7 @@ static const char *exception[] =
NULL
};
-const char *
+Eina_Stringshare *
widget_name_get(const Eina_Stringshare *group_name)
{
int len = strlen(group_name);
@@ -72,10 +72,10 @@ widget_name_get(const Eina_Stringshare *group_name)
}
str[i - 4] = '\0';
- return strdup(str);
+ return eina_stringshare_add(str);
}
-const char *
+Eina_Stringshare *
style_name_get(const Eina_Stringshare *group_name)
{
int len = strlen(group_name);
@@ -130,7 +130,7 @@ style_name_get(const Eina_Stringshare *group_name)
style[i - first] = '\0';
}
- return strdup(style);
+ return eina_stringshare_add(style);
}
Eina_Stringshare *
@@ -244,8 +244,8 @@ widget_prefix_list_get(Eina_List *collections, const char
*widget_name, const ch
Eina_List *l, *list = NULL;
Eina_Stringshare *group_name;
char prefix[1024];
- const char *widget = NULL;
- const char *style = NULL;
+ Eina_Stringshare *widget = NULL;
+ Eina_Stringshare *style = NULL;
int i, end = 0;
EINA_LIST_FOREACH(collections, l, group_name)
@@ -262,9 +262,11 @@ widget_prefix_list_get(Eina_List *collections, const char
*widget_name, const ch
prefix[i] = group_name[i];
prefix[i] = '\0';
- list = eina_list_append(list, strdup(prefix));
+ list = eina_list_append(list, eina_stringshare_add(prefix));
}
+ eina_stringshare_del(style);
}
+eina_stringshare_del(widget);
}
return list;
}
diff --git a/src/bin/ui/tab_home_common.c b/src/bin/ui/tab_home_common.c
index 01bf161..d5001d8 100644
--- a/src/bin/ui/tab_home_common.c
+++ b/src/bin/ui/tab_home_common.c
@@ -120,6 +120,8 @@ _group_copy(Project *pro, Eina_List *widgets)
gm_group_add(ap.project, cp_group_name, true);
}
}
+ EINA_LIST_FREE(prefixs, prefix)
+eina_stringshare_del(prefix);
}
}
}
--
[EGIT] [tools/enventor] master 01/01: edc_editor: show an image on cursor "images.image"
hermet pushed a commit to branch master.
http://git.enlightenment.org/tools/enventor.git/commit/?id=43cfa31a1419a2de32500fd7b89d73180c4ce205
commit 43cfa31a1419a2de32500fd7b89d73180c4ce205
Author: Hermet Park
Date: Wed Aug 3 16:36:36 2016 +0900
edc_editor: show an image on cursor "images.image"
---
src/lib/edc_editor.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/edc_editor.c b/src/lib/edc_editor.c
index 50b3aaa..cb0b08d 100644
--- a/src/lib/edc_editor.c
+++ b/src/lib/edc_editor.c
@@ -745,7 +745,8 @@ edit_cursor_double_clicked_cb(void *data, Evas_Object *obj,
(!strcmp(selected, "normal") && (strlen(selected) == 6)) ||
(!strcmp(selected, "tween") && (strlen(selected) == 5)) ||
(!strcmp(selected, "image.normal") && (strlen(selected) == 12)) ||
- (!strcmp(selected, "image.tween") && (strlen(selected) == 11)))
+ (!strcmp(selected, "image.tween") && (strlen(selected) == 11)) ||
+ (!strcmp(selected, "images.image") && (strlen(selected) == 12)))
{
int x, y;
evas_pointer_output_xy_get(evas_object_evas_get(ed->en_edit), &x, &y);
--
