Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().
On Mon, 5 Sep 2011 15:33:58 +0900 Naruto TAKAHASHI tnar...@gmail.com said: actually it was the im_info thing i was asking about - never mind as that was a bit of the patch that was not needed. this part moves get_ic(). filter_event() is occurred at input event(mount event or keyboard event). when occurring mouse event, don't need to get XIC. so I move get_ic() to in if(type == ECORE_IMF_EVENT_KEY_DOWN) nest. And the reason of deleting checking return value of get_ic() is get_ic() has already checked same. I should have split this patch to particular. 2011/9/3 Carsten Haitzler ras...@rasterman.com: On Mon, 29 Aug 2011 18:18:31 +0900 Naruto TAKAHASHI tnar...@gmail.com said: hmm the 2nd part - if (!im_info) looks ok - but the first seems pointless/useless. why the first bit? Hi All, I've added a checking null of im_info to get_ic(). Would you review this patch? Best Regards. -- Naruto TAKAHASHI tnar...@gmail.com -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Naruto TAKAHASHI tnar...@gmail.com -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().
this part moves get_ic(). filter_event() is occurred at input event(mount event or keyboard event). when occurring mouse event, don't need to get XIC. so I move get_ic() to in if(type == ECORE_IMF_EVENT_KEY_DOWN) nest. And the reason of deleting checking return value of get_ic() is get_ic() has already checked same. I should have split this patch to particular. 2011/9/3 Carsten Haitzler ras...@rasterman.com: On Mon, 29 Aug 2011 18:18:31 +0900 Naruto TAKAHASHI tnar...@gmail.com said: hmm the 2nd part - if (!im_info) looks ok - but the first seems pointless/useless. why the first bit? Hi All, I've added a checking null of im_info to get_ic(). Would you review this patch? Best Regards. -- Naruto TAKAHASHI tnar...@gmail.com -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler) ras...@rasterman.com -- Naruto TAKAHASHI tnar...@gmail.com -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free Love Thy Logs t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] Add a checking null of im_info to get_ic().
On Mon, 29 Aug 2011 18:18:31 +0900 Naruto TAKAHASHI tnar...@gmail.com said: hmm the 2nd part - if (!im_info) looks ok - but the first seems pointless/useless. why the first bit? Hi All, I've added a checking null of im_info to get_ic(). Would you review this patch? Best Regards. -- Naruto TAKAHASHI tnar...@gmail.com -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free Love Thy Logs t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] Add a checking null of im_info to get_ic().
Hi All,
I've added a checking null of im_info to get_ic().
Would you review this patch?
Best Regards.
--
Naruto TAKAHASHI
tnar...@gmail.com
diff --git a/ecore/src/modules/immodules/xim/ecore_imf_xim.c
b/ecore/src/modules/immodules/xim/ecore_imf_xim.c
index 791fdab..76ae9aa 100644
--- a/ecore/src/modules/immodules/xim/ecore_imf_xim.c
+++ b/ecore/src/modules/immodules/xim/ecore_imf_xim.c
@@ -451,11 +451,6 @@ _ecore_imf_context_xim_filter_event(Ecore_IMF_Context
*ctx,
Eina_Bool result = EINA_FALSE;
imf_context_data = ecore_imf_context_data_get(ctx);
- ic = imf_context_data-ic;
- if(!ic)
- {
-ic = get_ic(ctx);
- }
if(type == ECORE_IMF_EVENT_KEY_DOWN)
{
@@ -482,6 +477,8 @@ _ecore_imf_context_xim_filter_event(Ecore_IMF_Context
*ctx,
xev.keycode = _keycode_get(dsp, ev-keyname);
xev.same_screen = True;
+ic = get_ic(ctx);
+
if(ic)
{
Status mbstatus;
@@ -926,6 +923,12 @@ get_ic(Ecore_IMF_Context *ctx)
XPoint spot = { 0, 0 };
char *name = NULL;
+if(!im_info)
+ {
+ EINA_LOG_WARN(Doesn't open XIM.);
+ return NULL;
+ }
+
// supported styles
#if 0
int i;
--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
