Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[The Rasterman]

On Mon, 30 Apr 2012 16:32:06 +0900 Kim Shinwoo  said:

actually not reviewing code itself here at all... going to review results. very
interesting and quite cool! it's a step in the right direction indeed! but it
does look a bit odd with the item flipping ONLY when it gets "to" the edge. i'm
actually thinking that it really needs to more closely represent items as if
they are on a circular wheel. this means items NOT in the middle need to be
partly squashed & mapped too. of course this all needs to be flexible and able
to be flat as well as "circular disc" style. so here's my take:

1. we need a pseudo-wheel. this means it isn't perfectly round, BUT it has a
FLAT bit in the middle which is in fact the size of an item (as all items are
the same size). this means we can fit (when "stable") 1 item in the middle
(selected item) and have it not be transformed.
2. the extra space to the left/right of this flat area should (imho) curve into
the screen. where the "inflection" point is (where the item is perpendicular
to the screen plane - ie at 90 degrees and now invisible) needs to be
configurable by the theme i believe, but it can't be any further in than the
edge of the obj, but it can be further OUT away from the obj.
4. to do this i think we need to use the scroller ONLY as a way of handling drag
+momentum+bounce events and like genlist use a pan smart and handle the moving
of objects VIRTUALLY with the pan, not physically as scroller does now. this
will give us the flexibility we need.
5. this needs to be compatible with the current diskselector on the theme ende,
so this new circular mode will need to be an EXTRA bit of support by
diskselector, *IF* the theme requests it in the style. (eg data items on the
theme base)
6. i think this needs to do what the page curl flip code does... that means it
takes the box and sets that as a SOURCE for a bunch of image objects you place
around in a mesh to make it look curved. theme can use swallows and objects to
determine the inflection points above and code in diskselector just does the
rest of the mesh math then, and uses a minimal parent to the box to be able to
now move the box within the parent to scroll (as the pan is changed) and as
this changes, then the map gets re-rendered and thus the curve mesh gets
updated, so after the mesh is set up (and it's just re-set up if object
resizes), we just move the3 box object around to scroll items and everything
should "just work" with the middle selected item being flat and nice.

unfortunately this is vastly different from the code you've got in your patch :(

> I'm glad to get your response.
> The revised patch has been attached.
> Please review the patch.. Thanks!
> 
> Sincerely,
> Shinwoo Kim.
> 
> 2012/4/30 Daniel Juyung Seo :
> > The effect looks good to me.
> > Comments here.
> >
> > 1. indentation in your patch.
> > line 79
> > line 115 ~ 136
> >
> > 2. more braces for if
> > if (x + (w / 2) < ox + (0.2 * ow))
> > -->
> > if ((x + (w / 2)) < (ox + (0.2 * ow)))
> >
> > you need more braces for other if statements.
> >
> > I'll wait for other's comments about map.
> > Thanks.
> >
> > Daniel Juyung Seo (SeoZ)
> >
> >
> >
> >
> > On Mon, Apr 30, 2012 at 8:31 AM, Kim Shinwoo  wrote:
> >> Thanks for your response!
> >>
> >> I have updated the previous patch based on your comments.
> >> The indentation.. it is difficult to find where it is.. please enlighten
> >> me. Effects.. definitely.. :)
> >>
> >> Sincerely,
> >> Shinwoo Kim.
> >>
> >> 2012/4/27 Hyoyoung Chang :
> >>> On Fri, Apr 27, 2012 at 3:55 PM, cnook  wrote:
>  Dear all, hello.
> 
>  I have tried to use the map with the diskselector.
>  The attached patch is just draft version for using map.
> >>>
> >>> Is it really draft version? imho, it's too good to be initial version.
> >>> i just found few points which can be improved.
> >>>
> >>> 1.
> >>>  +             if (map == NULL) return EINA_FALSE
> >>>  ->           if (!map)
> >>>
> >>> 2. indentation near about evas_map_smooth_set()
> >>>
> >>> 3. as you said, effects can be more tailored.
> >>>
> 
>  BUT.. just remind the Raster's comment "at least it can retain its
>  api"... I removed number of letters feature.. when I had changed the
>  diskselector... So.. even though an item of diskselector moves right or
>  left side.. the item will keep its number of letters..
>  means... elm_diskselector_side_text_max_length_set does not work..
>  anyhow.. this is the draft version.. I would like to check that the map
>  is used properly..  as the Raster's recommends "it really needs to use
>  map"
> 
> 
>  Please review the attached patch. Thanks.
> 
>  Sincerely,
>  Shinwoo Kim.
> 
> 
>  2011/10/10 Carsten Haitzler 
> 
> > On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo
> >  > >
> > said:
> >
> > at least it can retain its api. :)
> >
> > > Wow this sounds like diskselector needs to be rewr

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[ChunEon Park]

Hello. Shinwoo. 


Here are my comments.


1. We need to keep the internal signal emits for backward compatibility. if 
there are apps which customized diskselector styles, they would be broken. So 
please just leave them and leave TODOs: remove these signals later 2.0 
2.Rotation effect looks really awful. How about making the rotation range 0 ~ 
45 ? or less then 45.



Even there are some magic numbers (0.2, 90) could be configurable but it's ok 
to me to modify them later since they are not important right now.



-Regards, Hermet-



-Original Message-
From: "Kim Shinwoo"<kimcinoo@gmail.com> 
To: "Enlightenment developer 
list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2012-04-30 (월) 16:32:06
Subject: Re: [E-devel] [Patch] elm_diskselector, set icon to added item

I'm glad to get your response.
The revised patch has been attached.
Please review the patch.. Thanks!

Sincerely,
Shinwoo Kim.

2012/4/30 Daniel Juyung Seo <seojuyung2>@gmail.com>:
> The effect looks good to me.
> Comments here.
>
> 1. indentation in your patch.
> line 79
> line 115 ~ 136
>
> 2. more braces for if
> if (x + (w / 2) < ox + (0.2 * ow))
> -->
> if ((x + (w / 2)) < (ox + (0.2 * ow)))
>
> you need more braces for other if statements.
>
> I'll wait for other's comments about map.
> Thanks.
>
> Daniel Juyung Seo (SeoZ)
>
>
>
>
> On Mon, Apr 30, 2012 at 8:31 AM, Kim Shinwoo 
<kimcinoo.efl>@gmail.com> wrote:
>> Thanks for your response!
>>
>> I have updated the previous patch based on your comments.
>> The indentation.. it is difficult to find where it is.. please 
enlighten me.
>> Effects.. definitely.. :)
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>> 2012/4/27 Hyoyoung Chang <hyoyoung>@gmail.com>:
>>> On Fri, Apr 27, 2012 at 3:55 PM, cnook 
<kimcinoo>@gmail.com> wrote:
>>>> Dear all, hello.
>>>>
>>>> I have tried to use the map with the diskselector.
>>>> The attached patch is just draft version for using map.
>>>
>>> Is it really draft version? imho, it's too good to be initial 
version.
>>> i just found few points which can be improved.
>>>
>>> 1.
>>>  + if (map == NULL) return EINA_FALSE
>>>  ->   if (!map)
>>>
>>> 2. indentation near about evas_map_smooth_set()
>>>
>>> 3. as you said, effects can be more tailored.
>>>
>>>>
>>>> BUT.. just remind the Raster's comment "at least it can retain 
its api"...
>>>> I removed number of letters feature.. when I had changed the 
diskselector...
>>>> So.. even though an item of diskselector moves right or left 
side.. the
>>>> item will keep its number of letters..
>>>> means... elm_diskselector_side_text_max_length_set does not 
work..
>>>> anyhow.. this is the draft version.. I would like to check 
that the map is
>>>> used properly..  as the Raster's recommends "it really needs 
to use map"
>>>>
>>>>
>>>> Please review the attached patch. Thanks.
>>>>
>>>> Sincerely,
>>>> Shinwoo Kim.
>>>>
>>>>
>>>> 2011/10/10 Carsten Haitzler <raster>@rasterman.com>
>>>>
>>>>> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo 
<seojuyung2>@gmail.com
>>>>> >
>>>>> said:
>>>>>
>>>>> at least it can retain its api. :)
>>>>>
>>>>> > Wow this sounds like diskselector needs to be 
rewritten a lot.
>>>>> >
>>>>> > Daniel Juyung Seo (SeoZ)
>>>>> >
>>>>> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
<raster>@rasterman.com>
>>>>> > wrote:
>>>>> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook 
<kimcinoo>@gmail.com> said:
>>>>> > >
>>>>> > >> Dear All, Hello!
>>>>> > >>
>>>>> > >> If the diskselector is round mode, the 
scroller of diskselector has
>>>>> > >> additional items for its rounding(carousel) 
effect.
>>>>> > >> Previously, 
elm_diskselector_item_icon_set(); did not care about
>>>>> > >> theses additional items.
>>>>> > >> Please review the attached patch that will 
care. Thanks.
>>>>> > >
>>>>> > > hmm ok 

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Kim Shinwoo]

I'm glad to get your response.
The revised patch has been attached.
Please review the patch.. Thanks!

Sincerely,
Shinwoo Kim.

2012/4/30 Daniel Juyung Seo :
> The effect looks good to me.
> Comments here.
>
> 1. indentation in your patch.
> line 79
> line 115 ~ 136
>
> 2. more braces for if
> if (x + (w / 2) < ox + (0.2 * ow))
> -->
> if ((x + (w / 2)) < (ox + (0.2 * ow)))
>
> you need more braces for other if statements.
>
> I'll wait for other's comments about map.
> Thanks.
>
> Daniel Juyung Seo (SeoZ)
>
>
>
>
> On Mon, Apr 30, 2012 at 8:31 AM, Kim Shinwoo  wrote:
>> Thanks for your response!
>>
>> I have updated the previous patch based on your comments.
>> The indentation.. it is difficult to find where it is.. please enlighten me.
>> Effects.. definitely.. :)
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>> 2012/4/27 Hyoyoung Chang :
>>> On Fri, Apr 27, 2012 at 3:55 PM, cnook  wrote:
 Dear all, hello.

 I have tried to use the map with the diskselector.
 The attached patch is just draft version for using map.
>>>
>>> Is it really draft version? imho, it's too good to be initial version.
>>> i just found few points which can be improved.
>>>
>>> 1.
>>>  +             if (map == NULL) return EINA_FALSE
>>>  ->           if (!map)
>>>
>>> 2. indentation near about evas_map_smooth_set()
>>>
>>> 3. as you said, effects can be more tailored.
>>>

 BUT.. just remind the Raster's comment "at least it can retain its api"...
 I removed number of letters feature.. when I had changed the 
 diskselector...
 So.. even though an item of diskselector moves right or left side.. the
 item will keep its number of letters..
 means... elm_diskselector_side_text_max_length_set does not work..
 anyhow.. this is the draft version.. I would like to check that the map is
 used properly..  as the Raster's recommends "it really needs to use map"


 Please review the attached patch. Thanks.

 Sincerely,
 Shinwoo Kim.


 2011/10/10 Carsten Haitzler 

> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo  >
> said:
>
> at least it can retain its api. :)
>
> > Wow this sounds like diskselector needs to be rewritten a lot.
> >
> > Daniel Juyung Seo (SeoZ)
> >
> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
> > wrote:
> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
> > >
> > >> Dear All, Hello!
> > >>
> > >> If the diskselector is round mode, the scroller of diskselector has
> > >> additional items for its rounding(carousel) effect.
> > >> Previously, elm_diskselector_item_icon_set(); did not care about
> > >> theses additional items.
> > >> Please review the attached patch that will care. Thanks.
> > >
> > > hmm ok - in svn. not giving this a lot of review. i was reviewing
> > > diskselector about a week ago or so and realized.. this widget needs a
> > > major overhaul in internal design and implementation. to implement a
> > > rounded disk - it really needs to use map, and even then the amount of
> > > rounding or if any at all should be configurable. it should almost
> > > definitely implement this with a pan smart like genlist does to allow
> for a
> > > virtual pan area (we can make it almost infinite - well make it just
> very
> > > very very very large) and based on position int he virtual pan,
> position
> > > children (really just use a box with map used to duplicate it on the
> curved
> > > or visibile area).
> > >
> > > --
> > > - Codito, ergo sum - "I code, therefore I am"
> --
> > > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
> > >
> > >
> > >
> --
> > > All the data continuously generated in your IT infrastructure contains
> a
> > > definitive record of customers, application performance, security
> > > threats, fraudulent activity and more. Splunk takes this data and 
> > > makes
> > > sense of it. Business sense. IT sense. Common sense.
> > > http://p.sf.net/sfu/splunk-d2dcopy1
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> >
> >
> --
> > All the data continuously generated in your IT infrastructure contains a
> > definitive record of customers, application performance, security
> > threats, fraudulent activity and more. Splunk takes this data and makes
> > sense of it. Business sense. IT sense. Common sense.
> > http://p.sf.net/sfu/splunk-d2dcopy1
> > ___
> > e

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Daniel Juyung Seo]

The effect looks good to me.
Comments here.

1. indentation in your patch.
line 79
line 115 ~ 136

2. more braces for if
if (x + (w / 2) < ox + (0.2 * ow))
-->
if ((x + (w / 2)) < (ox + (0.2 * ow)))

you need more braces for other if statements.

I'll wait for other's comments about map.
Thanks.

Daniel Juyung Seo (SeoZ)




On Mon, Apr 30, 2012 at 8:31 AM, Kim Shinwoo  wrote:
> Thanks for your response!
>
> I have updated the previous patch based on your comments.
> The indentation.. it is difficult to find where it is.. please enlighten me.
> Effects.. definitely.. :)
>
> Sincerely,
> Shinwoo Kim.
>
> 2012/4/27 Hyoyoung Chang :
>> On Fri, Apr 27, 2012 at 3:55 PM, cnook  wrote:
>>> Dear all, hello.
>>>
>>> I have tried to use the map with the diskselector.
>>> The attached patch is just draft version for using map.
>>
>> Is it really draft version? imho, it's too good to be initial version.
>> i just found few points which can be improved.
>>
>> 1.
>>  +             if (map == NULL) return EINA_FALSE
>>  ->           if (!map)
>>
>> 2. indentation near about evas_map_smooth_set()
>>
>> 3. as you said, effects can be more tailored.
>>
>>>
>>> BUT.. just remind the Raster's comment "at least it can retain its api"...
>>> I removed number of letters feature.. when I had changed the diskselector...
>>> So.. even though an item of diskselector moves right or left side.. the
>>> item will keep its number of letters..
>>> means... elm_diskselector_side_text_max_length_set does not work..
>>> anyhow.. this is the draft version.. I would like to check that the map is
>>> used properly..  as the Raster's recommends "it really needs to use map"
>>>
>>>
>>> Please review the attached patch. Thanks.
>>>
>>> Sincerely,
>>> Shinwoo Kim.
>>>
>>>
>>> 2011/10/10 Carsten Haitzler 
>>>
 On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo >>> >
 said:

 at least it can retain its api. :)

 > Wow this sounds like diskselector needs to be rewritten a lot.
 >
 > Daniel Juyung Seo (SeoZ)
 >
 > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
 > wrote:
 > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
 > >
 > >> Dear All, Hello!
 > >>
 > >> If the diskselector is round mode, the scroller of diskselector has
 > >> additional items for its rounding(carousel) effect.
 > >> Previously, elm_diskselector_item_icon_set(); did not care about
 > >> theses additional items.
 > >> Please review the attached patch that will care. Thanks.
 > >
 > > hmm ok - in svn. not giving this a lot of review. i was reviewing
 > > diskselector about a week ago or so and realized.. this widget needs a
 > > major overhaul in internal design and implementation. to implement a
 > > rounded disk - it really needs to use map, and even then the amount of
 > > rounding or if any at all should be configurable. it should almost
 > > definitely implement this with a pan smart like genlist does to allow
 for a
 > > virtual pan area (we can make it almost infinite - well make it just
 very
 > > very very very large) and based on position int he virtual pan,
 position
 > > children (really just use a box with map used to duplicate it on the
 curved
 > > or visibile area).
 > >
 > > --
 > > - Codito, ergo sum - "I code, therefore I am"
 --
 > > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
 > >
 > >
 > >
 --
 > > All the data continuously generated in your IT infrastructure contains
 a
 > > definitive record of customers, application performance, security
 > > threats, fraudulent activity and more. Splunk takes this data and makes
 > > sense of it. Business sense. IT sense. Common sense.
 > > http://p.sf.net/sfu/splunk-d2dcopy1
 > > ___
 > > enlightenment-devel mailing list
 > > enlightenment-devel@lists.sourceforge.net
 > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 > >
 >
 >
 --
 > All the data continuously generated in your IT infrastructure contains a
 > definitive record of customers, application performance, security
 > threats, fraudulent activity and more. Splunk takes this data and makes
 > sense of it. Business sense. IT sense. Common sense.
 > http://p.sf.net/sfu/splunk-d2dcopy1
 > ___
 > enlightenment-devel mailing list
 > enlightenment-devel@lists.sourceforge.net
 > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 >


 --
 - Codito, ergo sum - "I code, therefore I am" --
 The Rasterman (Carsten Haitzler)    ras...@rasterman.com

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Kim Shinwoo]

Thanks for your response!

I have updated the previous patch based on your comments.
The indentation.. it is difficult to find where it is.. please enlighten me.
Effects.. definitely.. :)

Sincerely,
Shinwoo Kim.

2012/4/27 Hyoyoung Chang :
> On Fri, Apr 27, 2012 at 3:55 PM, cnook  wrote:
>> Dear all, hello.
>>
>> I have tried to use the map with the diskselector.
>> The attached patch is just draft version for using map.
>
> Is it really draft version? imho, it's too good to be initial version.
> i just found few points which can be improved.
>
> 1.
>  +             if (map == NULL) return EINA_FALSE
>  ->           if (!map)
>
> 2. indentation near about evas_map_smooth_set()
>
> 3. as you said, effects can be more tailored.
>
>>
>> BUT.. just remind the Raster's comment "at least it can retain its api"...
>> I removed number of letters feature.. when I had changed the diskselector...
>> So.. even though an item of diskselector moves right or left side.. the
>> item will keep its number of letters..
>> means... elm_diskselector_side_text_max_length_set does not work..
>> anyhow.. this is the draft version.. I would like to check that the map is
>> used properly..  as the Raster's recommends "it really needs to use map"
>>
>>
>> Please review the attached patch. Thanks.
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>>
>> 2011/10/10 Carsten Haitzler 
>>
>>> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo >> >
>>> said:
>>>
>>> at least it can retain its api. :)
>>>
>>> > Wow this sounds like diskselector needs to be rewritten a lot.
>>> >
>>> > Daniel Juyung Seo (SeoZ)
>>> >
>>> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
>>> > wrote:
>>> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
>>> > >
>>> > >> Dear All, Hello!
>>> > >>
>>> > >> If the diskselector is round mode, the scroller of diskselector has
>>> > >> additional items for its rounding(carousel) effect.
>>> > >> Previously, elm_diskselector_item_icon_set(); did not care about
>>> > >> theses additional items.
>>> > >> Please review the attached patch that will care. Thanks.
>>> > >
>>> > > hmm ok - in svn. not giving this a lot of review. i was reviewing
>>> > > diskselector about a week ago or so and realized.. this widget needs a
>>> > > major overhaul in internal design and implementation. to implement a
>>> > > rounded disk - it really needs to use map, and even then the amount of
>>> > > rounding or if any at all should be configurable. it should almost
>>> > > definitely implement this with a pan smart like genlist does to allow
>>> for a
>>> > > virtual pan area (we can make it almost infinite - well make it just
>>> very
>>> > > very very very large) and based on position int he virtual pan,
>>> position
>>> > > children (really just use a box with map used to duplicate it on the
>>> curved
>>> > > or visibile area).
>>> > >
>>> > > --
>>> > > - Codito, ergo sum - "I code, therefore I am"
>>> --
>>> > > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>>> > >
>>> > >
>>> > >
>>> --
>>> > > All the data continuously generated in your IT infrastructure contains
>>> a
>>> > > definitive record of customers, application performance, security
>>> > > threats, fraudulent activity and more. Splunk takes this data and makes
>>> > > sense of it. Business sense. IT sense. Common sense.
>>> > > http://p.sf.net/sfu/splunk-d2dcopy1
>>> > > ___
>>> > > enlightenment-devel mailing list
>>> > > enlightenment-devel@lists.sourceforge.net
>>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>> > >
>>> >
>>> >
>>> --
>>> > All the data continuously generated in your IT infrastructure contains a
>>> > definitive record of customers, application performance, security
>>> > threats, fraudulent activity and more. Splunk takes this data and makes
>>> > sense of it. Business sense. IT sense. Common sense.
>>> > http://p.sf.net/sfu/splunk-d2dcopy1
>>> > ___
>>> > enlightenment-devel mailing list
>>> > enlightenment-devel@lists.sourceforge.net
>>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>> >
>>>
>>>
>>> --
>>> - Codito, ergo sum - "I code, therefore I am" --
>>> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>>>
>>>
>>
>> --
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> ___
>> enlightenment-devel mailing list
>>

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Hyoyoung Chang]

On Fri, Apr 27, 2012 at 3:55 PM, cnook  wrote:
> Dear all, hello.
>
> I have tried to use the map with the diskselector.
> The attached patch is just draft version for using map.

Is it really draft version? imho, it's too good to be initial version.
i just found few points which can be improved.

1.
 + if (map == NULL) return EINA_FALSE
  ->   if (!map)

2. indentation near about evas_map_smooth_set()

3. as you said, effects can be more tailored.

>
> BUT.. just remind the Raster's comment "at least it can retain its api"...
> I removed number of letters feature.. when I had changed the diskselector...
> So.. even though an item of diskselector moves right or left side.. the
> item will keep its number of letters..
> means... elm_diskselector_side_text_max_length_set does not work..
> anyhow.. this is the draft version.. I would like to check that the map is
> used properly..  as the Raster's recommends "it really needs to use map"
>
>
> Please review the attached patch. Thanks.
>
> Sincerely,
> Shinwoo Kim.
>
>
> 2011/10/10 Carsten Haitzler 
>
>> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo > >
>> said:
>>
>> at least it can retain its api. :)
>>
>> > Wow this sounds like diskselector needs to be rewritten a lot.
>> >
>> > Daniel Juyung Seo (SeoZ)
>> >
>> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
>> > wrote:
>> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
>> > >
>> > >> Dear All, Hello!
>> > >>
>> > >> If the diskselector is round mode, the scroller of diskselector has
>> > >> additional items for its rounding(carousel) effect.
>> > >> Previously, elm_diskselector_item_icon_set(); did not care about
>> > >> theses additional items.
>> > >> Please review the attached patch that will care. Thanks.
>> > >
>> > > hmm ok - in svn. not giving this a lot of review. i was reviewing
>> > > diskselector about a week ago or so and realized.. this widget needs a
>> > > major overhaul in internal design and implementation. to implement a
>> > > rounded disk - it really needs to use map, and even then the amount of
>> > > rounding or if any at all should be configurable. it should almost
>> > > definitely implement this with a pan smart like genlist does to allow
>> for a
>> > > virtual pan area (we can make it almost infinite - well make it just
>> very
>> > > very very very large) and based on position int he virtual pan,
>> position
>> > > children (really just use a box with map used to duplicate it on the
>> curved
>> > > or visibile area).
>> > >
>> > > --
>> > > - Codito, ergo sum - "I code, therefore I am"
>> --
>> > > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>> > >
>> > >
>> > >
>> --
>> > > All the data continuously generated in your IT infrastructure contains
>> a
>> > > definitive record of customers, application performance, security
>> > > threats, fraudulent activity and more. Splunk takes this data and makes
>> > > sense of it. Business sense. IT sense. Common sense.
>> > > http://p.sf.net/sfu/splunk-d2dcopy1
>> > > ___
>> > > enlightenment-devel mailing list
>> > > enlightenment-devel@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> > >
>> >
>> >
>> --
>> > All the data continuously generated in your IT infrastructure contains a
>> > definitive record of customers, application performance, security
>> > threats, fraudulent activity and more. Splunk takes this data and makes
>> > sense of it. Business sense. IT sense. Common sense.
>> > http://p.sf.net/sfu/splunk-d2dcopy1
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>>
>>
>> --
>> - Codito, ergo sum - "I code, therefore I am" --
>> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>>
>>
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
wi

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[cnook]

Dear all, hello.

I have tried to use the map with the diskselector.
The attached patch is just draft version for using map.

BUT.. just remind the Raster's comment "at least it can retain its api"...
I removed number of letters feature.. when I had changed the diskselector...
So.. even though an item of diskselector moves right or left side.. the
item will keep its number of letters..
means... elm_diskselector_side_text_max_length_set does not work..
anyhow.. this is the draft version.. I would like to check that the map is
used properly..  as the Raster's recommends "it really needs to use map"


Please review the attached patch. Thanks.

Sincerely,
Shinwoo Kim.


2011/10/10 Carsten Haitzler 

> On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo  >
> said:
>
> at least it can retain its api. :)
>
> > Wow this sounds like diskselector needs to be rewritten a lot.
> >
> > Daniel Juyung Seo (SeoZ)
> >
> > On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
> > wrote:
> > > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
> > >
> > >> Dear All, Hello!
> > >>
> > >> If the diskselector is round mode, the scroller of diskselector has
> > >> additional items for its rounding(carousel) effect.
> > >> Previously, elm_diskselector_item_icon_set(); did not care about
> > >> theses additional items.
> > >> Please review the attached patch that will care. Thanks.
> > >
> > > hmm ok - in svn. not giving this a lot of review. i was reviewing
> > > diskselector about a week ago or so and realized.. this widget needs a
> > > major overhaul in internal design and implementation. to implement a
> > > rounded disk - it really needs to use map, and even then the amount of
> > > rounding or if any at all should be configurable. it should almost
> > > definitely implement this with a pan smart like genlist does to allow
> for a
> > > virtual pan area (we can make it almost infinite - well make it just
> very
> > > very very very large) and based on position int he virtual pan,
> position
> > > children (really just use a box with map used to duplicate it on the
> curved
> > > or visibile area).
> > >
> > > --
> > > - Codito, ergo sum - "I code, therefore I am"
> --
> > > The Rasterman (Carsten Haitzler)ras...@rasterman.com
> > >
> > >
> > >
> --
> > > All the data continuously generated in your IT infrastructure contains
> a
> > > definitive record of customers, application performance, security
> > > threats, fraudulent activity and more. Splunk takes this data and makes
> > > sense of it. Business sense. IT sense. Common sense.
> > > http://p.sf.net/sfu/splunk-d2dcopy1
> > > ___
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> >
> >
> --
> > All the data continuously generated in your IT infrastructure contains a
> > definitive record of customers, application performance, security
> > threats, fraudulent activity and more. Splunk takes this data and makes
> > sense of it. Business sense. IT sense. Common sense.
> > http://p.sf.net/sfu/splunk-d2dcopy1
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)ras...@rasterman.com
>
>


diskselector.using.map.patch
Description: Binary data
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch][elm_diskselector] resolving a segmentation fault

[Kim Shinwoo]

Aha! Thanks for your response!

2012/4/17 Daniel Juyung Seo :
> yes changelog and news.are not used for elementary because elementary 1.0
> is not released.
> they will be needed after the release.
> thanks.
> On Apr 17, 2012 10:28 AM, "cnook"  wrote:
>
>> Dear All, Hello.
>>
>> If the diskselector item has only icon and does not have label, it makes a
>> segmentation fault.
>> Because the diskselector uses strcmp() to indicate selected item even
>> though the item does not have label - NULL with strcmp().
>> Then, please review the attached patch and give any feedback.
>>
>> Um.. There are empty ChangeLog and NEWS files in the elementary. So I leave
>> it just as it is.
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>>
>> --
>> Better than sec? Nothing is better than sec when it comes to
>> monitoring Big Data applications. Try Boundary one-second
>> resolution app monitoring today. Free.
>> http://p.sf.net/sfu/Boundary-dev2dev
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>>
> --
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch][elm_diskselector] resolving a segmentation fault

[Daniel Juyung Seo]

yes changelog and news.are not used for elementary because elementary 1.0
is not released.
they will be needed after the release.
thanks.
On Apr 17, 2012 10:28 AM, "cnook"  wrote:

> Dear All, Hello.
>
> If the diskselector item has only icon and does not have label, it makes a
> segmentation fault.
> Because the diskselector uses strcmp() to indicate selected item even
> though the item does not have label - NULL with strcmp().
> Then, please review the attached patch and give any feedback.
>
> Um.. There are empty ChangeLog and NEWS files in the elementary. So I leave
> it just as it is.
>
> Sincerely,
> Shinwoo Kim.
>
>
> --
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch][elm_diskselector] resolving a segmentation fault

[Sanjeev BA]

Sorry, mixed up 'it' with item.
In SVN r70253

Thanks,
Sanjeev


On Tue, Apr 17, 2012 at 10:57 AM, Sanjeev BA  wrote:

> "if (item->label" - is that required after you return if null ?
>
>
> On Tue, Apr 17, 2012 at 10:27 AM, cnook  wrote:
>
>> Dear All, Hello.
>>
>> If the diskselector item has only icon and does not have label, it makes a
>> segmentation fault.
>> Because the diskselector uses strcmp() to indicate selected item even
>> though the item does not have label - NULL with strcmp().
>> Then, please review the attached patch and give any feedback.
>>
>> Um.. There are empty ChangeLog and NEWS files in the elementary. So I
>> leave
>> it just as it is.
>>
>> Sincerely,
>> Shinwoo Kim.
>>
>>
>> --
>> Better than sec? Nothing is better than sec when it comes to
>> monitoring Big Data applications. Try Boundary one-second
>> resolution app monitoring today. Free.
>> http://p.sf.net/sfu/Boundary-dev2dev
>> ___
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>>
>
--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch][elm_diskselector] resolving a segmentation fault

[Sanjeev BA]

"if (item->label" - is that required after you return if null ?


On Tue, Apr 17, 2012 at 10:27 AM, cnook  wrote:

> Dear All, Hello.
>
> If the diskselector item has only icon and does not have label, it makes a
> segmentation fault.
> Because the diskselector uses strcmp() to indicate selected item even
> though the item does not have label - NULL with strcmp().
> Then, please review the attached patch and give any feedback.
>
> Um.. There are empty ChangeLog and NEWS files in the elementary. So I leave
> it just as it is.
>
> Sincerely,
> Shinwoo Kim.
>
>
> --
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> http://p.sf.net/sfu/Boundary-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch][elm_diskselector] resolving a segmentation fault

[cnook]

Dear All, Hello.

If the diskselector item has only icon and does not have label, it makes a
segmentation fault.
Because the diskselector uses strcmp() to indicate selected item even
though the item does not have label - NULL with strcmp().
Then, please review the attached patch and give any feedback.

Um.. There are empty ChangeLog and NEWS files in the elementary. So I leave
it just as it is.

Sincerely,
Shinwoo Kim.


elm_diskselector.fix.segment.fault.on.icon.item.without.label
Description: Binary data
--
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, using parent width

[Daniel Juyung Seo]

Right. Diskselector- and any widget - can have its own size regardless
of its parent size.

Daniel Juyung Seo (SeoZ)

On Thu, Oct 20, 2011 at 7:10 PM, Carsten Haitzler  wrote:
> On Thu, 20 Oct 2011 18:28:34 +0900 cnook  said:
>
>> Hello,
>>
>> This patch will make elm_diskselector to use its parent width for its
>> minimum width value.
>> Please review the attached patch.
>
> this is.. odd... it's... wrong! this is really not a good idea. very bad in
> fact.
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>
>
> --
> The demand for IT networking professionals continues to grow, and the
> demand for specialized networking skills is growing even more rapidly.
> Take a complimentary Learning@Ciosco Self-Assessment and learn
> about Cisco certifications, training, and career opportunities.
> http://p.sf.net/sfu/cisco-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Ciosco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, using parent width

[The Rasterman]

On Thu, 20 Oct 2011 18:28:34 +0900 cnook  said:

> Hello,
> 
> This patch will make elm_diskselector to use its parent width for its
> minimum width value.
> Please review the attached patch.

this is.. odd... it's... wrong! this is really not a good idea. very bad in
fact.

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Ciosco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_diskselector, using parent width

[cnook]

Hello,

This patch will make elm_diskselector to use its parent width for its
minimum width value.
Please review the attached patch.

Sincerely,
Shinwoo Kim
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 64194)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -169,7 +169,12 @@ _theme_data_get(Widget_Data *wd)
 
str = edje_object_data_get(wd->right_blank, "min_width");
if (str) wd->minw = MAX(-1, atoi(str));
-   else wd->minw = -1;
+   else
+ {
+parent = elm_widget_parent_widget_get(wd->self);
+if (!parent) wd->minw = -1;
+else evas_object_geometry_get(parent, NULL, NULL, &wd->minw, NULL);
+ }
 
str = edje_object_data_get(wd->right_blank, "min_height");
if (str) wd->minh = MAX(-1, atoi(str));
--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Ciosco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[The Rasterman]

On Mon, 10 Oct 2011 22:45:56 +0900 Daniel Juyung Seo 
said:

at least it can retain its api. :)

> Wow this sounds like diskselector needs to be rewritten a lot.
> 
> Daniel Juyung Seo (SeoZ)
> 
> On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler 
> wrote:
> > On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
> >
> >> Dear All, Hello!
> >>
> >> If the diskselector is round mode, the scroller of diskselector has
> >> additional items for its rounding(carousel) effect.
> >> Previously, elm_diskselector_item_icon_set(); did not care about
> >> theses additional items.
> >> Please review the attached patch that will care. Thanks.
> >
> > hmm ok - in svn. not giving this a lot of review. i was reviewing
> > diskselector about a week ago or so and realized.. this widget needs a
> > major overhaul in internal design and implementation. to implement a
> > rounded disk - it really needs to use map, and even then the amount of
> > rounding or if any at all should be configurable. it should almost
> > definitely implement this with a pan smart like genlist does to allow for a
> > virtual pan area (we can make it almost infinite - well make it just very
> > very very very large) and based on position int he virtual pan, position
> > children (really just use a box with map used to duplicate it on the curved
> > or visibile area).
> >
> > --
> > - Codito, ergo sum - "I code, therefore I am" --
> > The Rasterman (Carsten Haitzler)    ras...@rasterman.com
> >
> >
> > --
> > All the data continuously generated in your IT infrastructure contains a
> > definitive record of customers, application performance, security
> > threats, fraudulent activity and more. Splunk takes this data and makes
> > sense of it. Business sense. IT sense. Common sense.
> > http://p.sf.net/sfu/splunk-d2dcopy1
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> 
> --
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[Daniel Juyung Seo]

Wow this sounds like diskselector needs to be rewritten a lot.

Daniel Juyung Seo (SeoZ)

On Mon, Oct 10, 2011 at 6:45 PM, Carsten Haitzler  wrote:
> On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:
>
>> Dear All, Hello!
>>
>> If the diskselector is round mode, the scroller of diskselector has
>> additional items for its rounding(carousel) effect.
>> Previously, elm_diskselector_item_icon_set(); did not care about
>> theses additional items.
>> Please review the attached patch that will care. Thanks.
>
> hmm ok - in svn. not giving this a lot of review. i was reviewing diskselector
> about a week ago or so and realized.. this widget needs a major overhaul in
> internal design and implementation. to implement a rounded disk - it really
> needs to use map, and even then the amount of rounding or if any at all should
> be configurable. it should almost definitely implement this with a pan smart
> like genlist does to allow for a virtual pan area (we can make it almost
> infinite - well make it just very very very very large) and based on position
> int he virtual pan, position children (really just use a box with map used to
> duplicate it on the curved or visibile area).
>
> --
> - Codito, ergo sum - "I code, therefore I am" --
> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
>
>
> --
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[The Rasterman]

On Thu, 22 Sep 2011 18:39:53 +0900 cnook  said:

> Dear All, Hello!
> 
> If the diskselector is round mode, the scroller of diskselector has
> additional items for its rounding(carousel) effect.
> Previously, elm_diskselector_item_icon_set(); did not care about
> theses additional items.
> Please review the attached patch that will care. Thanks.

hmm ok - in svn. not giving this a lot of review. i was reviewing diskselector
about a week ago or so and realized.. this widget needs a major overhaul in
internal design and implementation. to implement a rounded disk - it really
needs to use map, and even then the amount of rounding or if any at all should
be configurable. it should almost definitely implement this with a pan smart
like genlist does to allow for a virtual pan area (we can make it almost
infinite - well make it just very very very very large) and based on position
int he virtual pan, position children (really just use a box with map used to
duplicate it on the curved or visibile area).

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

[cnook]

Please review this patch. Thanks.

2011/9/22 cnook :
> Dear All, Hello!
>
> If the diskselector is round mode, the scroller of diskselector has
> additional items for its rounding(carousel) effect.
> Previously, elm_diskselector_item_icon_set(); did not care about
> theses additional items.
> Please review the attached patch that will care. Thanks.
>
> Sincerely,
> Shinwoo Kim.
>

--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_diskselector, set icon to added item

[cnook]

Dear All, Hello!

If the diskselector is round mode, the scroller of diskselector has
additional items for its rounding(carousel) effect.
Previously, elm_diskselector_item_icon_set(); did not care about
theses additional items.
Please review the attached patch that will care. Thanks.

Sincerely,
Shinwoo Kim.
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 63533)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -597,7 +597,7 @@ _move_scroller(void *data)
 {
Evas_Object *obj = data;
Widget_Data *wd;
-   Eina_List *l;
+   Eina_List *list, *l;
Elm_Diskselector_Item *dit;
Evas_Coord y, w, h;
int i;
@@ -605,17 +605,26 @@ _move_scroller(void *data)
wd = elm_widget_data_get(obj);
if (!wd) return EINA_FALSE;
 
-   if (wd->round)
- i = 1;
+   if (!wd->round)
+ {
+i = 0;
+list = wd->items;
+ }
else
- i = 0;
+ {
+i = 1;
+list = wd->r_items;
+ }
 
-   EINA_LIST_FOREACH(wd->items, l, dit)
+   EINA_LIST_FOREACH(list, l, dit)
  {
 if (wd->selected_item == dit)
-  break;
+   break;
 i++;
  }
+
+   if (wd->round) i -= CEIL(wd->display_item_num);
+
if (!dit)
  {
 wd->selected_item =
@@ -748,6 +757,73 @@ _round_items_add(Widget_Data *wd)
  }
 }
 
+static void
+_item_icon_set(Elm_Diskselector_Item *it, Evas_Object *icon)
+{
+   if (it->icon == icon) return;
+   if (it->icon)
+ evas_object_del(it->icon);
+   it->icon = icon;
+   if (it->base.view)
+ {
+evas_object_size_hint_min_set(it->icon, 24, 24);
+evas_object_size_hint_max_set(it->icon, 40, 40);
+edje_object_part_swallow(it->base.view, "elm.swallow.icon", it->icon);
+evas_object_show(it->icon);
+elm_widget_sub_object_add(it->base.widget, it->icon);
+ }
+}
+
+static void
+_check_identical_item(Elm_Diskselector_Item *it, Evas_Object *icon)
+{
+   Widget_Data *wd;
+   Elm_Diskselector_Item *dit;
+   Eina_List *l;
+   int idx = 0;
+   int ic = 0;
+   int ac = 0;
+
+   wd = elm_widget_data_get(it->base.widget);
+   if (!wd) return;
+
+   if (wd->round)
+ {
+// Get index from indentical item from round items
+EINA_LIST_FOREACH(wd->r_items, l, dit)
+  {
+ if (it == dit) break;
+ idx++;
+  }
+
+// No item to match
+ic = eina_list_count(wd->r_items);
+if (idx >= ic) return;
+dit = NULL;
+
+// Number of added items: CEIL(wd->display_item_num)
+ac = CEIL(wd->display_item_num);
+
+if (((idx >= 0) && (idx < ac)) ||
+((idx >= ac) && (idx < (2 * ac
+  {
+  // Selected item: under, low region
+ dit = eina_list_nth(wd->r_items,
+ idx + ic - (2 * ac));
+  }
+else if (((idx >= (ic - ac)) && (idx < ic)) ||
+ ((idx >= (ic - (2 * ac))) && (idx < ic - ac)))
+  {
+  // Selected item: over, high region
+  dit = eina_list_nth(wd->r_items,
+  idx - ic + (2 * ac));
+  }
+
+if(dit) _item_icon_set(dit, icon);
+_sizing_eval(wd->self);
+ }
+}
+
 EAPI Evas_Object *
 elm_diskselector_add(Evas_Object *parent)
 {
@@ -1220,18 +1296,8 @@ EAPI void
 elm_diskselector_item_icon_set(Elm_Diskselector_Item *it, Evas_Object *icon)
 {
ELM_DISKSELECTOR_ITEM_CHECK_OR_RETURN(it);
-   if (it->icon == icon) return;
-   if (it->icon)
- evas_object_del(it->icon);
-   it->icon = icon;
-   if (it->base.view)
- {
-evas_object_size_hint_min_set(it->icon, 24, 24);
-evas_object_size_hint_max_set(it->icon, 40, 40);
-edje_object_part_swallow(it->base.view, "elm.swallow.icon", it->icon);
-evas_object_show(it->icon);
-elm_widget_sub_object_add(it->base.widget, it->icon);
- }
+   _item_icon_set(it, icon);
+   _check_identical_item(it, icon);
 }
 
 EAPI Elm_Diskselector_Item *
--
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector (ticket #853)

[Mike Blumenkrantz]

On Thu, 8 Sep 2011 12:41:27 +0900
cnook  wrote:

> Dear All, Hello~
> 
> The attached patch for resolving the ticket #853.
> (http://trac.enlightenment.org/e/ticket/853)
> 
> There is an issue when it comes to rounded item.
> Anyhow, I will fix it also.
> 
> Sincerely,
> Shinwoo Kim
in

-- 
Mike Blumenkrantz
Zentific: Coding in binary since '10.

--
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
Learn about the latest advances in developing for the 
BlackBerry® mobile platform with sessions, labs & more.
See new tools and technologies. Register for BlackBerry® DevCon today!
http://p.sf.net/sfu/rim-devcon-copy1 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_diskselector (ticket #853)

[cnook]

Dear All, Hello~

The attached patch for resolving the ticket #853.
(http://trac.enlightenment.org/e/ticket/853)

There is an issue when it comes to rounded item.
Anyhow, I will fix it also.

Sincerely,
Shinwoo Kim
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 63279)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -1225,7 +1225,13 @@ elm_diskselector_item_icon_set(Elm_Diskselector_It
  evas_object_del(it->icon);
it->icon = icon;
if (it->base.view)
- edje_object_part_swallow(it->base.view, "elm.swallow.icon", icon);
+ {
+evas_object_size_hint_min_set(it->icon, 24, 24);
+evas_object_size_hint_max_set(it->icon, 40, 40);
+edje_object_part_swallow(it->base.view, "elm.swallow.icon", it->icon);
+evas_object_show(it->icon);
+elm_widget_sub_object_add(it->base.widget, it->icon);
+ }
 }
 
 EAPI Elm_Diskselector_Item *
--
Doing More with Less: The Next Generation Virtual Desktop 
What are the key obstacles that have prevented many mid-market businesses
from deploying virtual desktops?   How do next-generation virtual desktops
provide companies an easier-to-deploy, easier-to-manage and more affordable
virtual desktop model.http://www.accelacomm.com/jaw/sfnl/114/51426474/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [patch] elm_diskselector - hangs after using elm_diskselector_item_selected_set

[Tom Hacohen]

On 07/09/11 18:04, Daniel Juyung Seo wrote:
> In SVN. Thanks.
> Please close the ticket.

You fixed it, you should close it...

--
Tom.

--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [patch] elm_diskselector - hangs after using elm_diskselector_item_selected_set

[Daniel Juyung Seo]

In SVN. Thanks.
Please close the ticket.

Daniel Juyung Seo (SeoZ)

On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang
 wrote:
> I omitted about credit.
> With cnook, I can easily find this bug.
> Thanks to cnook
>
>> -Original Message-
>> From: Hyoyoung Chang [mailto:hyoyoung.ch...@samsung.com]
>> Sent: Wednesday, September 07, 2011 6:52 PM
>> To: 'Enlightenment developer list'
>> Subject: [patch] elm_diskselector - hangs after using
>> elm_diskselector_item_selected_set
>>
>> Dear developers.
>>
>> This patch is fixing - hangs after using
>> elm_diskselector_item_selected_set.
>> Elm_diskselector add a idler and remove in _move_scroller with checking
>> wd->idler But in elm_diskselector_item_selected_set, it's not use wd-
>> >idler.
>> So idler is called infinite.
>>
>> It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854
> )
>>
>> Thank you
>
>
> --
> Using storage to extend the benefits of virtualization and iSCSI
> Virtualization increases hardware utilization and delivers a new level of
> agility. Learn what those decisions are and how to modernize your storage
> and backup environments for virtualization.
> http://www.accelacomm.com/jaw/sfnl/114/51434361/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [patch] elm_diskselector - hangs after using elm_diskselector_item_selected_set

[Hyoyoung Chang]

I omitted about credit.
With cnook, I can easily find this bug.
Thanks to cnook

> -Original Message-
> From: Hyoyoung Chang [mailto:hyoyoung.ch...@samsung.com]
> Sent: Wednesday, September 07, 2011 6:52 PM
> To: 'Enlightenment developer list'
> Subject: [patch] elm_diskselector - hangs after using
> elm_diskselector_item_selected_set
> 
> Dear developers.
> 
> This patch is fixing - hangs after using
> elm_diskselector_item_selected_set.
> Elm_diskselector add a idler and remove in _move_scroller with checking
> wd->idler But in elm_diskselector_item_selected_set, it's not use wd-
> >idler.
> So idler is called infinite.
> 
> It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854
)
> 
> Thank you


--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [patch] elm_diskselector - hangs after using elm_diskselector_item_selected_set

[Hyoyoung Chang]

Dear developers.

This patch is fixing - hangs after using elm_diskselector_item_selected_set.
Elm_diskselector add a idler and remove in _move_scroller with checking
wd->idler
But in elm_diskselector_item_selected_set, it's not use wd->idler.
So idler is called infinite.

It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 )

Thank you
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c  (리비전 63262)
+++ src/lib/elm_diskselector.c  (작업 사본)
@@ -1181,7 +1181,7 @@
  }
 
if (!wd->idler)
- ecore_idler_add(_move_scroller, it->base.widget);
+ wd->idler = ecore_idler_add(_move_scroller, it->base.widget);
 }
 
 EAPI Eina_Bool
--
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector, modify improper code

[ChunEon Park]

You have eagle eyes!
Thanks you a lot!

Let's run together for the best moment!
 -Regards, Hermet-
 
-Original Message-
From: "cnook"<kimci...@gmail.com> 
To: "EFL"<enlightenment-devel@lists.sourceforge.net>
Cc: 
Sent: 11-08-12(금) 14:57:57
Subject: [E-devel] [Patch] elm_diskselector, modify improper code
Dear All, Hi!
There were come codes in _del_pre_hook() that just don't make sense.
Please refer to the attached patch.
Sincerely,
Shinwoo Kim.
--
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. 
http://p.sf.net/sfu/wandisco-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
FREE DOWNLOAD - uberSVN with Social Coding for Subversion.
Subversion made easy with a complete admin console. Easy 
to use, easy to manage, easy to install, easy to extend. 
Get a Free download of the new open ALM Subversion platform now.
http://p.sf.net/sfu/wandisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_diskselector, modify improper code

[cnook]

Dear All, Hi!

There were come codes in _del_pre_hook() that just don't make sense.
Please refer to the attached patch.

Sincerely,
Shinwoo Kim.
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 62370)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -224,7 +224,7 @@ _del_pre_hook(Evas_Object * obj)
 if (it)
   {
  eina_stringshare_del(it->label);
- if (wd->first) evas_object_del(wd->first->base.view);
+ evas_object_del(it->base.view);
  free(it);
   }
  }
@@ -234,7 +234,7 @@ _del_pre_hook(Evas_Object * obj)
  if (it)
 {
eina_stringshare_del(it->label);
-   if (wd->first) evas_object_del(wd->first->base.view);
+   evas_object_del(it->base.view);
free(it);
 }
}
--
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. 
http://p.sf.net/sfu/wandisco-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector

[The Rasterman]

On Mon, 25 Jul 2011 21:25:36 +0900 cnook  said:

> Hi All,
> 
> I have attached elm_diskselector patch for resolving dynamic theme change
> issue.
> Previously, the item label did not display when them theme had changed while
> elm_diskselector displayed.

hmm this patch shows something disturbing... why is diskselector storing parent
on creation? thats really bad. in fact...  why get geometry og parent AS
wd->minw? this makes no sense if disckselectro created initially as a child
of win.. u'll be getting window geometry and setting that size to minw. thats
wrong. if this were to actually use the current parent (which it does actually)
then the parent width becomes the selectors min width.. this is wrong. imagine
its in a horizontal box with 2 things horizontally.. this cant make logical
sense. so i've removed the whole getting parent width for min width from the
widget. it should be using the min_width data if set (i don't like this much..
but its not as bad as the parent thing).. the sizing_eval in the end calculates
a min size which is right using the minw/h from theme data.. if it exists.

-- 
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector

[ChunEon Park]

It should be. 
in svn.
Thank you very much!

Let's run together for the best moment!
 -Regards, Hermet-
 
-Original Message-
From: "cnook" 
To: "Daniel Juyung Seo"
Cc: "EFL"
Sent: 11-07-27(수) 17:47:49
Subject: Re: [E-devel] [Patch] elm_diskselectorHi All,
I have attached refined path.
There is no storing parent.
Sincerely,
Shinwoo Kim.
2011/7/26 cnook 
> Hi!
>
> Your response always good for me.
>
> 1) Yes you're right,There would be a better solution than storing parent.
> I'll try to use other way that would use previous parent size if new
> parent does not have enough size.
>
>
> Sincerely,
> Shinwoo Kim.
>
>
>
> 2011/7/25 Daniel Juyung Seo 
>
>> Hello Shinwoo Kim,
>>
>> 1) Why do you store parent? parent can be changed at any time.
>> ie) elm_box_pack_end()
>> I think it's better not to change the code.
>> Of course there are some exceptions but diskselector looks like a
>> normal widget.
>>
>> 2) Setting it->label is ok.
>>
>> 3) When you make a diff, it's better add -x -up option.
>> $ svn diff -x -up
>> This tells you which function is changed in the diff.
>>
>> Thanks.
>> Daniel Juyung Seo (SeoZ)
>>
>>
>> On Mon, Jul 25, 2011 at 9:25 PM, cnook  wrote:
>> > Hi All,
>> >
>> > I have attached elm_diskselector patch for resolving dynamic theme
>> change
>> > issue.
>> > Previously, the item label did not display when them theme had changed
>> while
>> > elm_diskselector displayed.
>> >
>> > Sincerely,
>> > Shinwoo Kim.
>> >
>> >
>> --
>> > Storage Efficiency Calculator
>> > This modeling tool is based on patent-pending intellectual property that
>> > has been used successfully in hundreds of IBM storage optimization
>> engage-
>> > ments, worldwide. Store less, Store more with what you own, Move data
>> to
>> > the right place. Try It Now!
>> http://www.accelacomm.com/jaw/sfnl/114/51427378/
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>> >
>>
>
>
--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector

[cnook]

Hi All,

I have attached refined path.
There is no storing parent.

Sincerely,
Shinwoo Kim.


2011/7/26 cnook 

> Hi!
>
> Your response always good for me.
>
> 1) Yes you're right,There would be a better solution than storing parent.
> I'll try to use other way that would use previous parent size if new
> parent does not have enough size.
>
>
> Sincerely,
> Shinwoo Kim.
>
>
>
> 2011/7/25 Daniel Juyung Seo 
>
>> Hello Shinwoo Kim,
>>
>> 1) Why do you store parent? parent can be changed at any time.
>>ie) elm_box_pack_end()
>>I think it's better not to change the code.
>>Of course there are some exceptions but diskselector looks like a
>> normal widget.
>>
>> 2) Setting it->label is ok.
>>
>> 3) When you make a diff, it's better add -x -up option.
>>$ svn diff -x -up
>>This tells you which function is changed in the diff.
>>
>> Thanks.
>> Daniel Juyung Seo (SeoZ)
>>
>>
>> On Mon, Jul 25, 2011 at 9:25 PM, cnook  wrote:
>> > Hi All,
>> >
>> > I have attached elm_diskselector patch for resolving dynamic theme
>> change
>> > issue.
>> > Previously, the item label did not display when them theme had changed
>> while
>> > elm_diskselector displayed.
>> >
>> > Sincerely,
>> > Shinwoo Kim.
>> >
>> >
>> --
>> > Storage Efficiency Calculator
>> > This modeling tool is based on patent-pending intellectual property that
>> > has been used successfully in hundreds of IBM storage optimization
>> engage-
>> > ments, worldwide.  Store less, Store more with what you own, Move data
>> to
>> > the right place. Try It Now!
>> http://www.accelacomm.com/jaw/sfnl/114/51427378/
>> > ___
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>> >
>>
>
>
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 61723)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -274,6 +274,7 @@ _theme_hook(Evas_Object * obj)
   {
  _elm_theme_object_set(obj, it->base.view, "diskselector", "item",
elm_widget_style_get(obj));
+ edje_object_part_text_set(it->base.view, "elm.text", it->label);
   }
  }
else
@@ -282,6 +283,7 @@ _theme_hook(Evas_Object * obj)
   {
  _elm_theme_object_set(obj, it->base.view, "diskselector", "item",
elm_widget_style_get(obj));
+ edje_object_part_text_set(it->base.view, "elm.text", it->label);
   }
  }
_elm_theme_object_set(obj, wd->right_blank, "diskselector", "item",
--
Got Input?   Slashdot Needs You.
Take our quick survey online.  Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector

[cnook]

Hi!

Your response always good for me.

1) Yes you're right,There would be a better solution than storing parent.
I'll try to use other way that would use previous parent size if new
parent does not have enough size.


Sincerely,
Shinwoo Kim.


2011/7/25 Daniel Juyung Seo 

> Hello Shinwoo Kim,
>
> 1) Why do you store parent? parent can be changed at any time.
>ie) elm_box_pack_end()
>I think it's better not to change the code.
>Of course there are some exceptions but diskselector looks like a
> normal widget.
>
> 2) Setting it->label is ok.
>
> 3) When you make a diff, it's better add -x -up option.
>$ svn diff -x -up
>This tells you which function is changed in the diff.
>
> Thanks.
> Daniel Juyung Seo (SeoZ)
>
>
> On Mon, Jul 25, 2011 at 9:25 PM, cnook  wrote:
> > Hi All,
> >
> > I have attached elm_diskselector patch for resolving dynamic theme change
> > issue.
> > Previously, the item label did not display when them theme had changed
> while
> > elm_diskselector displayed.
> >
> > Sincerely,
> > Shinwoo Kim.
> >
> >
> --
> > Storage Efficiency Calculator
> > This modeling tool is based on patent-pending intellectual property that
> > has been used successfully in hundreds of IBM storage optimization
> engage-
> > ments, worldwide.  Store less, Store more with what you own, Move data to
> > the right place. Try It Now!
> http://www.accelacomm.com/jaw/sfnl/114/51427378/
> > ___
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
>
--
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [Patch] elm_diskselector

[Daniel Juyung Seo]

Hello Shinwoo Kim,

1) Why do you store parent? parent can be changed at any time.
ie) elm_box_pack_end()
I think it's better not to change the code.
Of course there are some exceptions but diskselector looks like a
normal widget.

2) Setting it->label is ok.

3) When you make a diff, it's better add -x -up option.
$ svn diff -x -up
This tells you which function is changed in the diff.

Thanks.
Daniel Juyung Seo (SeoZ)


On Mon, Jul 25, 2011 at 9:25 PM, cnook  wrote:
> Hi All,
>
> I have attached elm_diskselector patch for resolving dynamic theme change
> issue.
> Previously, the item label did not display when them theme had changed while
> elm_diskselector displayed.
>
> Sincerely,
> Shinwoo Kim.
>
> --
> Storage Efficiency Calculator
> This modeling tool is based on patent-pending intellectual property that
> has been used successfully in hundreds of IBM storage optimization engage-
> ments, worldwide.  Store less, Store more with what you own, Move data to
> the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>

--
Storage Efficiency Calculator
This modeling tool is based on patent-pending intellectual property that
has been used successfully in hundreds of IBM storage optimization engage-
ments, worldwide.  Store less, Store more with what you own, Move data to 
the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [Patch] elm_diskselector

[cnook]

Hi All,

I have attached elm_diskselector patch for resolving dynamic theme change
issue.
Previously, the item label did not display when them theme had changed while
elm_diskselector displayed.

Sincerely,
Shinwoo Kim.
Index: src/lib/elm_diskselector.c
===
--- src/lib/elm_diskselector.c	(revision 61687)
+++ src/lib/elm_diskselector.c	(working copy)
@@ -15,6 +15,7 @@
 
 struct _Widget_Data
 {
+   Evas_Object *parent;
Evas_Object *self;
Evas_Object *scroller;
Evas_Object *main_box;
@@ -169,9 +170,8 @@
if (str) wd->minw = MAX(-1, atoi(str));
else
  {
-parent = elm_widget_parent_widget_get(wd->self);
-if (!parent) wd->minw = -1;
-else evas_object_geometry_get(parent, NULL, NULL, &wd->minw, NULL);
+if (!wd->parent) wd->minw = -1;
+else evas_object_geometry_get(wd->parent, NULL, NULL, &wd->minw, NULL);
  }
 
str = edje_object_data_get(wd->right_blank, "min_height");
@@ -274,6 +274,7 @@
   {
  _elm_theme_object_set(obj, it->base.view, "diskselector", "item",
elm_widget_style_get(obj));
+ edje_object_part_text_set(it->base.view, "elm.text", it->label);
   }
  }
else
@@ -282,6 +283,7 @@
   {
  _elm_theme_object_set(obj, it->base.view, "diskselector", "item",
elm_widget_style_get(obj));
+ edje_object_part_text_set(it->base.view, "elm.text", it->label);
   }
  }
_elm_theme_object_set(obj, wd->right_blank, "diskselector", "item",
@@ -772,6 +774,7 @@
elm_widget_on_focus_hook_set(obj, _on_focus_hook, NULL);
elm_widget_event_hook_set(obj, _event_hook);
 
+   wd->parent = parent;
wd->self = obj;
wd->item_count = 0;
wd->round = EINA_FALSE;
--
Storage Efficiency Calculator
This modeling tool is based on patent-pending intellectual property that
has been used successfully in hundreds of IBM storage optimization engage-
ments, worldwide.  Store less, Store more with what you own, Move data to 
the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] elm_diskselector has mistypo APIs

[ChunEon Park]

 
Thanks. Jihoon Kim
 
in svn
 
But kept the previous APis as DEPRECAETD. 
 
 
 

Let's run together for the best moment!
-Regards, Hermet-
 
-Original Message-
From: "Jihoon Kim"<jihoon48@samsung.com> 
To: enlightenment-devel@lists.sourceforge.net
Cc: 
Sent: 11-06-22(수) 08:44:42
Subject: Re: [E-devel] [PATCH] elm_diskselector has mistypo APIsOops, 
test_diskselector uses API I modified in the previous patch e-mail.
I also fix test_diskselector.c and send the patch.
Please apply this patch for building elementary without build error.
-Original Message-
From: Jihoon Kim [mailto:imfin...@gmail.com] 
Sent: Tuesday, June 21, 2011 10:21 PM
To: enlightenment-devel@lists.sourceforge.net
Subject: [E-devel] [PATCH] elm_diskselector has mistypo APIs
Hi,
In some elm_diskselector API and doxygen, there are simple typographical
errors.
This patch will fix it.
--
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Re: [E-devel] [PATCH] elm_diskselector has mistypo APIs

[Jihoon Kim]

Oops, test_diskselector uses API I modified in the previous patch e-mail.

I also fix test_diskselector.c and send the patch.
Please apply this patch for building elementary without build error.

-Original Message-
From: Jihoon Kim [mailto:imfin...@gmail.com] 
Sent: Tuesday, June 21, 2011 10:21 PM
To: enlightenment-devel@lists.sourceforge.net
Subject: [E-devel] [PATCH] elm_diskselector has mistypo APIs

Hi,

In some elm_diskselector API and doxygen, there are simple typographical
errors.
This patch will fix it.



test_diskselector.patch
Description: Binary data
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[E-devel] [PATCH] elm_diskselector has mistypo APIs

[Jihoon Kim]

Hi,

In some elm_diskselector API and doxygen, there are simple typographical
errors.
This patch will fix it.
Index: elm_diskselector.c
===
--- elm_diskselector.c	(리비전 60547)
+++ elm_diskselector.c	(작업 사본)
@@ -6,7 +6,7 @@
  * with the selected on the middle.
  *
  * It can act like a circular list with round mode and labels can be
- * reduced for a defined lenght for side items.
+ * reduced for a defined length for side items.
  *
  * Signals that you can add callbacks for are:
  *
@@ -948,16 +948,16 @@ elm_diskselector_round_set(Evas_Object * obj, Eina
 }
 
 /**
- * Get the side labels max lenght
+ * Get the side labels max length
  *
  * @param obj The diskselector object
- * @return The max lenght defined for side labels, or 0 if not a valid
+ * @return The max length defined for side labels, or 0 if not a valid
  * diskselector
  *
  * @ingroup Diskselector
  */
 EAPI int
-elm_diskselector_side_label_lenght_get(const Evas_Object *obj)
+elm_diskselector_side_label_length_get(const Evas_Object *obj)
 {
ELM_CHECK_WIDTYPE(obj, widtype) 0;
Widget_Data *wd = elm_widget_data_get(obj);
@@ -966,15 +966,15 @@ EAPI int
 }
 
 /**
- * Set the side labels max lenght
+ * Set the side labels max length
  *
  * @param obj The diskselector object
- * @param len The max lenght defined for side labels
+ * @param len The max length defined for side labels
  *
  * @ingroup Diskselector
  */
 EAPI void
-elm_diskselector_side_label_lenght_set(Evas_Object *obj, int len)
+elm_diskselector_side_label_length_set(Evas_Object *obj, int len)
 {
ELM_CHECK_WIDTYPE(obj, widtype);
Widget_Data *wd = elm_widget_data_get(obj);
Index: Elementary.h.in
===
--- Elementary.h.in	(리비전 60547)
+++ Elementary.h.in	(작업 사본)
@@ -4158,8 +4158,8 @@ EAPI Elm_Genlist_Item *elm_genlist_item_sorted_ins
EAPI Evas_Object   *elm_diskselector_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
EAPI Eina_Bool  elm_diskselector_round_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI void   elm_diskselector_round_set(Evas_Object *obj, Eina_Bool round) EINA_ARG_NONNULL(1);
-   EAPI intelm_diskselector_side_label_lenght_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void   elm_diskselector_side_label_lenght_set(Evas_Object *obj, int len) EINA_ARG_NONNULL(1);
+   EAPI intelm_diskselector_side_label_length_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void   elm_diskselector_side_label_length_set(Evas_Object *obj, int len) EINA_ARG_NONNULL(1);
EAPI void   elm_diskselector_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce) EINA_ARG_NONNULL(1);
EAPI void   elm_diskselector_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce) EINA_ARG_NONNULL(1);
EAPI void   elm_diskselector_scroller_policy_get(const Evas_Object *obj, Elm_Scroller_Policy *policy_h, Elm_Scroller_Policy *policy_v) EINA_ARG_NONNULL(1);
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel