Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Mon, 29 Aug 2011 21:01:12 +0200 Cedric BAIL said: > On Mon, Aug 29, 2011 at 8:49 PM, Iván Briano (Sachiel) > wrote: > > 2011/8/29 Vincent Torri : > >> On Mon, 29 Aug 2011, Tom Hacohen wrote: > >>> On 29/08/11 19:34, Nicolas Aguirre wrote: > SPANK SPANK SPANK! > > I can't launch enlightenment anymore after this commit : > Here the backtrace : > >>> > >>> Same as my "elementary_test won't start" thread. :) > >>> So +1 from me. > >> > >> none of my evas-based app work here, so +1 too > >> > >> do I revert it ? > > > > With a vengeance. > > As it break everything in svn, yes, should be reverted asap. At least > discomfitor and I teached raster well, it tooks years, but we are > reaching our goal ! wtf? you do know the recalc array thing is currently logically broken? and my changes fix it to preserve order? i've got my changes running here - e17, elementary, everything, no crashes or problems. not even valgrind bitches on any of it. i have a few other unrelated changes i'm working on to try and fix long winded recalc cycles, but that change actually fixes broken logic. did anyone look a bit more deeply? only thing i saw was igloo's bt that doesn't tell me much now the code's reverted.. therew may be 1 bit of the old calc array code i hadnt kicked out - the calculate var. for some reason thats always 0 for me. also gcc warnings dont pick it up. gcc CHOULD have complained about use of uninitialized variable. wtf? but i'm sitting here with changes in place working and valgrind happy as a pig in mud too. it should have bitched as well. i've put it back in and removed the old calculate array on the stack - if that was it. why didn't gcc bitch though? at LEAST it should have bitched with all my warnings on. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
god! raster finally joined cedric+discomfitor svn breakin' union! Daniel Juyung Seo (SeoZ) On Aug 30, 2011 4:02 AM, "Cedric BAIL" wrote: -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Mon, Aug 29, 2011 at 8:49 PM, Iván Briano (Sachiel) wrote: > 2011/8/29 Vincent Torri : >> On Mon, 29 Aug 2011, Tom Hacohen wrote: >>> On 29/08/11 19:34, Nicolas Aguirre wrote: SPANK SPANK SPANK! I can't launch enlightenment anymore after this commit : Here the backtrace : >>> >>> Same as my "elementary_test won't start" thread. :) >>> So +1 from me. >> >> none of my evas-based app work here, so +1 too >> >> do I revert it ? > > With a vengeance. As it break everything in svn, yes, should be reverted asap. At least discomfitor and I teached raster well, it tooks years, but we are reaching our goal ! -- Cedric BAIL -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
2011/8/29 Vincent Torri : > > > On Mon, 29 Aug 2011, Tom Hacohen wrote: > >> On 29/08/11 19:34, Nicolas Aguirre wrote: >>> SPANK SPANK SPANK! >>> >>> I can't launch enlightenment anymore after this commit : >>> Here the backtrace : >> >> Same as my "elementary_test won't start" thread. :) >> So +1 from me. > > none of my evas-based app work here, so +1 too > > do I revert it ? With a vengeance. > > Vincent > > -- > Special Offer -- Download ArcSight Logger for FREE! > Finally, a world-class log management solution at an even better > price-free! And you'll get a free "Love Thy Logs" t-shirt when you > download Logger. Secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsisghtdev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Mon, 29 Aug 2011, Tom Hacohen wrote: > On 29/08/11 19:34, Nicolas Aguirre wrote: >> SPANK SPANK SPANK! >> >> I can't launch enlightenment anymore after this commit : >> Here the backtrace : > > Same as my "elementary_test won't start" thread. :) > So +1 from me. none of my evas-based app work here, so +1 too do I revert it ? Vincent -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On 29/08/11 19:34, Nicolas Aguirre wrote: > SPANK SPANK SPANK! > > I can't launch enlightenment anymore after this commit : > Here the backtrace : Same as my "elementary_test won't start" thread. :) So +1 from me. -- Tom. -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
2011/8/29 Enlightenment SVN : > Log: > i've found a subtle issue with how we queue recalcs of smart objs. if > an obj is already queued we dont push it FURTHEr down the queue if > smart recalc is enabled. now at least we keep order of operation/calc > correctly! > > > > Author: raster > Date: 2011-08-29 05:14:55 -0700 (Mon, 29 Aug 2011) > New Revision: 62944 > Trac: http://trac.enlightenment.org/e/changeset/62944 > > Modified: > trunk/evas/src/lib/canvas/evas_main.c > trunk/evas/src/lib/canvas/evas_object_smart.c > trunk/evas/src/lib/include/evas_private.h > SPANK SPANK SPANK! I can't launch enlightenment anymore after this commit : Here the backtrace : (gdb) bt full #0 0x00359200e7d0 in __pause_nocancel () from /lib64/libpthread.so.0 No symbol table info available. #1 0x00433674 in e_alert_show (sig=11) at e_alert.c:44 buf = "/opt/e17/lib/enlightenment/utils/enlightenment_alert 11 30152 96\000\000\000\000\000\000\000\000 \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000;\022v\230\001", '\000' , " \000\000\000"... #2 0x00506335 in e_sigseg_act (x=11, info=0x7fffd41e1470, data= 0x7fffd41e1340) at e_signals.c:125 No locals. #3 No symbol table info available. #4 0x7f3814e4db60 in eina_array_clean (array=0x7f3817cab160) at /opt/e17/include/eina-1/eina/eina_inline_array.x:157 No locals. #5 0x7f3814e4fb81 in evas_call_smarts_calculate (e=0x28bac80) at evas_object_smart.c:704 calculate = 0x7f3817cab160 obj = 0x0 ---Type to continue, or q to quit--- l = 0x0 #6 0x7f3814e7fb56 in evas_render_updates_internal (e=0x28bac80, make_updates=1 '\001', do_draw=1 '\001') at evas_render.c:1094 updates = 0x0 ll = 0x7fffd41e1a00 surface = 0x0 clean_them = 0 '\000' alpha = 0 '\000' r = 0x28b1290 ux = 32568 uy = 399730876 uw = 0 uh = 0 cx = 32568 cy = 353567960 cw = 32568 ch = 350308256 i = 32568 j = 350308256 haveup = 0 redraw_all = 0 __FUNCTION__ = "evas_render_updates_internal" #7 0x7f3814e81a0c in evas_render_updates (e=0x28bac80) ---Type to continue, or q to quit--- at evas_render.c:1515 No locals. #8 0x7f3817a90bd3 in _ecore_evas_x_render (ee=0x28baa70) at ecore_evas_x.c:397 r = 0x0 updates = 0x7fffd41e1a00 l = 0x75c8 rend = 0 ll = 0x0 ee2 = 0x0 #9 0x7f3817a89e24 in _ecore_evas_idle_enter (data=0x0) at ecore_evas.c:51 ee = 0x28baa70 t1 = 0 t2 = 0 rend = 0 #10 0x7f381513f669 in _ecore_call_task_cb (func= 0x7f3817a89d7c <_ecore_evas_idle_enter>, data=0x0) at ecore_private.h:242 r = 1 '\001' #11 0x7f381513f991 in _ecore_idle_enterer_call () at ecore_idle_enterer.c:165 ie = 0x24a22b0 #12 0x7f381514243d in _ecore_main_loop_iterate_internal (once_only=0) at ecore_main.c:1619 ---Type to continue, or q to quit--- next_time = -1 have_event = 0 have_signal = 345540576 #13 0x7f3815140f8e in ecore_main_loop_begin () at ecore_main.c:861 No locals. #14 0x0043047e in main (argc=5, argv=0x7fffd41e2cc8) at e_main.c:945 nostartup = 0 '\000' safe_mode = 0 '\000' after_restart = 0 '\000' t = 1314635150.5877531 tstart = 1314635150.5877531 s = 0x0 buff = "1314635150.6\000\000\000\000\362\r\200\235\065\000\000\000`\aS\000\000\000\000" action = {__sigaction_handler = {sa_handler = 0x50641b , sa_sigaction = 0x50641b }, sa_mask = {__val = {0 }}, sa_flags = -1073741820, sa_restorer = 0} (gdb) -- Nicolas Aguirre Mail: aguirre.nico...@gmail.com Web: http://enna.geexbox.org Blog: http://dev.enlightenment.fr/~captainigloo/ -- EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: . canvas include
On Tue, 14 Dec 2010 11:53:36 -0200 Rafael Antognolli said: > On Thu, Sep 2, 2010 at 9:06 PM, Enlightenment SVN > wrote: > > Log: > > in order to fix some horridibubble things. i had to add 4 api's. ugh. > > done. working. now... still 1 more bug. seems to be a changed flag bug > > too in dlip 2 test in scrolling list after map anim finished. smaller > > bug to deal with now. ugh. bug one bug to the other > > > > > > Author: raster > > Date: 2010-09-02 17:06:56 -0700 (Thu, 02 Sep 2010) > > New Revision: 51849 > > > Modified: trunk/evas/src/lib/canvas/evas_object_smart_clipped.c > > === > > --- trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-02 > > 23:46:00 UTC (rev 51848) +++ > > trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-03 > > 00:06:56 UTC (rev 51849) @@ -31,7 +31,12 @@ { > > Evas_Coord orig_x, orig_y; > > > > - evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); > > +// shortcut as we are in evas > > +// evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); > > + if (child->delete_me) continue; > > + if (child->is_static_clip) continue; > > + orig_x = child->cur.geometry.x; > > + orig_y = child->cur.geometry.y; > > evas_object_move(child, orig_x + dx, orig_y + dy); > > } > > > > @@ -68,6 +73,7 @@ > > > > cso->evas = evas_object_evas_get(obj); > > clipper = evas_object_rectangle_add(cso->evas); > > + evas_object_static_clip_set(clipper, 1); > > cso->clipper = NULL; > > evas_object_smart_member_add(clipper, obj); > > cso->clipper = clipper; > > Hmm... just a question after this commit: I suppose that since the > created clipper for the smart_clipped class is positioned at > -10,-10 and has size 20x20, it's not meant to be moved > by the smart class that implements it, right? > > We were moving and resizing that clipper on EWebKit, since it was used > to clip widgets inside inner frames. Since you changed this, the > clipper is at a wrong position, because the smart_clipped_smart_move > function doesn't move the clipper anymore. So what would be the > correct approach? hmm that clipper was before "infinite" (ok just really big) and it never really needed any moving as it was used as a master show/hide/fade for the smart obj children. not actually as a clip rect to clip them TO the smart obj. that was the intent of it originally... (master show/hide/fade) :) > 1) Implement our own smart_move function that moves the base.clipper, or > > 2) Have our own clipper that clips everything on our object, and is > clipped to this base clipper? 2) :) > Regards, > -- > Rafael Antognolli > ProFUSION embedded systems > http://profusion.mobi > > -- > Lotusphere 2011 > Register now for Lotusphere 2011 and learn how > to connect the dots, take your collaborative environment > to the next level, and enter the era of Social Business. > http://p.sf.net/sfu/lotusphere-d2d > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: . canvas include
On Tue, Dec 14, 2010 at 11:53 AM, Rafael Antognolli wrote: > On Thu, Sep 2, 2010 at 9:06 PM, Enlightenment SVN > wrote: >> Log: >> in order to fix some horridibubble things. i had to add 4 api's. ugh. >> done. working. now... still 1 more bug. seems to be a changed flag bug >> too in dlip 2 test in scrolling list after map anim finished. smaller >> bug to deal with now. ugh. bug one bug to the other >> >> >> Author: raster >> Date: 2010-09-02 17:06:56 -0700 (Thu, 02 Sep 2010) >> New Revision: 51849 > >> Modified: trunk/evas/src/lib/canvas/evas_object_smart_clipped.c >> === >> --- trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-02 >> 23:46:00 UTC (rev 51848) >> +++ trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-03 >> 00:06:56 UTC (rev 51849) >> @@ -31,7 +31,12 @@ >> { >> Evas_Coord orig_x, orig_y; >> >> - evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); >> +// shortcut as we are in evas >> +// evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); >> + if (child->delete_me) continue; >> + if (child->is_static_clip) continue; >> + orig_x = child->cur.geometry.x; >> + orig_y = child->cur.geometry.y; >> evas_object_move(child, orig_x + dx, orig_y + dy); >> } >> >> @@ -68,6 +73,7 @@ >> >> cso->evas = evas_object_evas_get(obj); >> clipper = evas_object_rectangle_add(cso->evas); >> + evas_object_static_clip_set(clipper, 1); >> cso->clipper = NULL; >> evas_object_smart_member_add(clipper, obj); >> cso->clipper = clipper; > > Hmm... just a question after this commit: I suppose that since the > created clipper for the smart_clipped class is positioned at > -10,-10 and has size 20x20, it's not meant to be moved > by the smart class that implements it, right? > > We were moving and resizing that clipper on EWebKit, since it was used > to clip widgets inside inner frames. Since you changed this, the > clipper is at a wrong position, because the smart_clipped_smart_move > function doesn't move the clipper anymore. So what would be the > correct approach? > > 1) Implement our own smart_move function that moves the base.clipper, or > > 2) Have our own clipper that clips everything on our object, and is > clipped to this base clipper? Raster's approach is the best here, as that was the aim of clipped smart object. I'd say, however that the best option is 3) override smart_add and reset clipper to not be a static one. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: . canvas include
On Thu, Sep 2, 2010 at 9:06 PM, Enlightenment SVN wrote: > Log: > in order to fix some horridibubble things. i had to add 4 api's. ugh. > done. working. now... still 1 more bug. seems to be a changed flag bug > too in dlip 2 test in scrolling list after map anim finished. smaller > bug to deal with now. ugh. bug one bug to the other > > > Author: raster > Date: 2010-09-02 17:06:56 -0700 (Thu, 02 Sep 2010) > New Revision: 51849 > Modified: trunk/evas/src/lib/canvas/evas_object_smart_clipped.c > === > --- trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-02 > 23:46:00 UTC (rev 51848) > +++ trunk/evas/src/lib/canvas/evas_object_smart_clipped.c 2010-09-03 > 00:06:56 UTC (rev 51849) > @@ -31,7 +31,12 @@ > { > Evas_Coord orig_x, orig_y; > > - evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); > +// shortcut as we are in evas > +// evas_object_geometry_get(child, &orig_x, &orig_y, NULL, NULL); > + if (child->delete_me) continue; > + if (child->is_static_clip) continue; > + orig_x = child->cur.geometry.x; > + orig_y = child->cur.geometry.y; > evas_object_move(child, orig_x + dx, orig_y + dy); > } > > @@ -68,6 +73,7 @@ > > cso->evas = evas_object_evas_get(obj); > clipper = evas_object_rectangle_add(cso->evas); > + evas_object_static_clip_set(clipper, 1); > cso->clipper = NULL; > evas_object_smart_member_add(clipper, obj); > cso->clipper = clipper; Hmm... just a question after this commit: I suppose that since the created clipper for the smart_clipped class is positioned at -10,-10 and has size 20x20, it's not meant to be moved by the smart class that implements it, right? We were moving and resizing that clipper on EWebKit, since it was used to clip widgets inside inner frames. Since you changed this, the clipper is at a wrong position, because the smart_clipped_smart_move function doesn't move the clipper anymore. So what would be the correct approach? 1) Implement our own smart_move function that moves the base.clipper, or 2) Have our own clipper that clips everything on our object, and is clipped to this base clipper? Regards, -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi -- Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Mon, Nov 29, 2010 at 2:16 PM, Lucas De Marchi wrote: > On Sat, Nov 27, 2010 at 10:26 AM, Carsten Haitzler > wrote: >> On Fri, 26 Nov 2010 12:42:15 -0200 Iván Briano (Sachiel) >>> But with branching and merging you can work on several features separately, >>> not having any of them influence the other and then forget which >>> branch had what. >>> Can't you see you are missing all the excitement that comes from >>> forgetting about >>> that awesome thing you had working some months ago and find out about it one >>> day listing all your branches out of curiosity, just to have the >>> smartest of merges >>> fail and having to do it manually anyway? > > When someone invent a tool to fix human stupidity or to cure > Alzheimer's disease, please tell me. I'd like to see that one as well ;-) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Sat, Nov 27, 2010 at 10:26 AM, Carsten Haitzler wrote: > On Fri, 26 Nov 2010 12:42:15 -0200 Iván Briano (Sachiel) >> But with branching and merging you can work on several features separately, >> not having any of them influence the other and then forget which >> branch had what. >> Can't you see you are missing all the excitement that comes from >> forgetting about >> that awesome thing you had working some months ago and find out about it one >> day listing all your branches out of curiosity, just to have the >> smartest of merges >> fail and having to do it manually anyway? When someone invent a tool to fix human stupidity or to cure Alzheimer's disease, please tell me. Lucas De Marchi -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Fri, 26 Nov 2010 12:42:15 -0200 Iván Briano (Sachiel) said: > 2010/11/26 Carsten Haitzler : > > On Fri, 26 Nov 2010 09:56:28 -0200 Gustavo Sverzut Barbieri > > said: > > > >> On Fri, Nov 26, 2010 at 8:45 AM, Carsten Haitzler > >> wrote: > >> > On Fri, 26 Nov 2010 08:08:52 -0200 Gustavo Sverzut Barbieri > >> > said: > >> > > >> > because i dont want to turn it on until 1.1. i want to keep the current > >> > alloc scheme precisely as-is for now. no no mp created, no counting of > >> > items or anything else. the macros reduce to exactly the current code as > >> > it stands right now. > >> > >> Yes, I understand that. However passthrough is exactly that with the > >> exception the functions get called, so the binary result is not the > >> same, but the behavior is (passthrough shouldn't do anything such as > >> "counting of items or anything else") > >> > >> But yeah, you're working around an SVN workflow problem with that. In > >> an ideal world you'd be working on some branch that would be merged > >> into trunk as soon as it's open for features... which is possible with > >> SVN, but a major PITA. > > > > an ifdef is less work than pretty much any branching and merging :) > > > > But with branching and merging you can work on several features separately, > not having any of them influence the other and then forget which > branch had what. > Can't you see you are missing all the excitement that comes from > forgetting about > that awesome thing you had working some months ago and find out about it one > day listing all your branches out of curiosity, just to have the > smartest of merges > fail and having to do it manually anyway? :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
2010/11/26 Carsten Haitzler : > On Fri, 26 Nov 2010 09:56:28 -0200 Gustavo Sverzut Barbieri > said: > >> On Fri, Nov 26, 2010 at 8:45 AM, Carsten Haitzler >> wrote: >> > On Fri, 26 Nov 2010 08:08:52 -0200 Gustavo Sverzut Barbieri >> > said: >> > >> > because i dont want to turn it on until 1.1. i want to keep the current >> > alloc scheme precisely as-is for now. no no mp created, no counting of >> > items or anything else. the macros reduce to exactly the current code as it >> > stands right now. >> >> Yes, I understand that. However passthrough is exactly that with the >> exception the functions get called, so the binary result is not the >> same, but the behavior is (passthrough shouldn't do anything such as >> "counting of items or anything else") >> >> But yeah, you're working around an SVN workflow problem with that. In >> an ideal world you'd be working on some branch that would be merged >> into trunk as soon as it's open for features... which is possible with >> SVN, but a major PITA. > > an ifdef is less work than pretty much any branching and merging :) > But with branching and merging you can work on several features separately, not having any of them influence the other and then forget which branch had what. Can't you see you are missing all the excitement that comes from forgetting about that awesome thing you had working some months ago and find out about it one day listing all your branches out of curiosity, just to have the smartest of merges fail and having to do it manually anyway? > > -- > - Codito, ergo sum - "I code, therefore I am" -- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > -- > Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! > Tap into the largest installed PC base & get more eyes on your game by > optimizing for Intel(R) Graphics Technology. Get started today with the > Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. > http://p.sf.net/sfu/intelisp-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Fri, 26 Nov 2010 09:56:28 -0200 Gustavo Sverzut Barbieri said: > On Fri, Nov 26, 2010 at 8:45 AM, Carsten Haitzler > wrote: > > On Fri, 26 Nov 2010 08:08:52 -0200 Gustavo Sverzut Barbieri > > said: > > > > because i dont want to turn it on until 1.1. i want to keep the current > > alloc scheme precisely as-is for now. no no mp created, no counting of > > items or anything else. the macros reduce to exactly the current code as it > > stands right now. > > Yes, I understand that. However passthrough is exactly that with the > exception the functions get called, so the binary result is not the > same, but the behavior is (passthrough shouldn't do anything such as > "counting of items or anything else") > > But yeah, you're working around an SVN workflow problem with that. In > an ideal world you'd be working on some branch that would be merged > into trunk as soon as it's open for features... which is possible with > SVN, but a major PITA. an ifdef is less work than pretty much any branching and merging :) -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Fri, Nov 26, 2010 at 8:45 AM, Carsten Haitzler wrote: > On Fri, 26 Nov 2010 08:08:52 -0200 Gustavo Sverzut Barbieri > said: > > because i dont want to turn it on until 1.1. i want to keep the current alloc > scheme precisely as-is for now. no no mp created, no counting of items or > anything else. the macros reduce to exactly the current code as it stands > right > now. Yes, I understand that. However passthrough is exactly that with the exception the functions get called, so the binary result is not the same, but the behavior is (passthrough shouldn't do anything such as "counting of items or anything else") But yeah, you're working around an SVN workflow problem with that. In an ideal world you'd be working on some branch that would be merged into trunk as soon as it's open for features... which is possible with SVN, but a major PITA. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 -- Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Fri, 26 Nov 2010 08:08:52 -0200 Gustavo Sverzut Barbieri said: because i dont want to turn it on until 1.1. i want to keep the current alloc scheme precisely as-is for now. no no mp created, no counting of items or anything else. the macros reduce to exactly the current code as it stands right now. > On Friday, November 26, 2010, Enlightenment SVN > wrote: > > Log: > > evas -> use mempool for many objects and things. but.. disable it for > > now. use old calloc+free thing for 1.0 and enable mpool for 1.1. this > > is just done in advance but disabled for some testing purposes looking > > for some bugs. > > Why do that option inside Evas? Just use MP and force it to use > "passthrough", then it will use malloc/free > > > > > Author: raster > > Date: 2010-11-26 02:01:18 -0800 (Fri, 26 Nov 2010) > > New Revision: 55006 > > > > Modified: > > trunk/evas/src/lib/canvas/evas_callbacks.c > > trunk/evas/src/lib/canvas/evas_object_image.c > > trunk/evas/src/lib/canvas/evas_object_line.c > > trunk/evas/src/lib/canvas/evas_object_main.c > > trunk/evas/src/lib/canvas/evas_object_polygon.c > > trunk/evas/src/lib/canvas/evas_object_rectangle.c > > trunk/evas/src/lib/canvas/evas_object_smart.c > > trunk/evas/src/lib/canvas/evas_object_smart_clipped.c > > trunk/evas/src/lib/canvas/evas_object_text.c > > trunk/evas/src/lib/canvas/evas_object_textblock.c > > trunk/evas/src/lib/include/evas_private.h > > > > Modified: trunk/evas/src/lib/canvas/evas_callbacks.c > > === > > --- trunk/evas/src/lib/canvas/evas_callbacks.c 2010-11-26 09:56:45 UTC > > (rev 55005) +++ trunk/evas/src/lib/canvas/evas_callbacks.c 2010-11-26 > > 10:01:18 UTC (rev 55006) @@ -5,6 +5,10 @@ > > static void evas_event_callback_clear(Evas *e); > > int _evas_event_counter = 0; > > > > +EVAS_MEMPOOL(_mp_fn); > > +EVAS_MEMPOOL(_mp_cb); > > +EVAS_MEMPOOL(_mp_pc); > > + > > void > > _evas_post_event_callback_call(Evas *e) > > { > > @@ -19,7 +23,7 @@ > > { > > if (!pc->func((void*)pc->data, e)) skip = 1; > > } > > - free(pc); > > + EVAS_MEMPOOL_FREE(_mp_pc, pc); > > } > > _evas_unwalk(e); > > } > > @@ -31,7 +35,7 @@ > > > > EINA_LIST_FREE(e->post_events, pc) > > { > > - free(pc); > > + EVAS_MEMPOOL_FREE(_mp_pc, pc); > > } > > _evas_unwalk(e); > > } > > @@ -51,7 +55,7 @@ > > if (fn->delete_me) > > { > > *list = eina_inlist_remove(*list, EINA_INLIST_GET(fn)); > > - free(fn); > > + EVAS_MEMPOOL_FREE(_mp_fn, fn); > > } > > } > > } > > @@ -65,7 +69,7 @@ > > evas_event_callback_list_post_free(&obj->callbacks->callbacks); > > if (!obj->callbacks->callbacks) > > { > > - free(obj->callbacks); > > + EVAS_MEMPOOL_FREE(_mp_cb, obj->callbacks); > > obj->callbacks = NULL; > > } > > } > > @@ -79,7 +83,7 @@ > > evas_event_callback_list_post_free(&e->callbacks->callbacks); > > if (!e->callbacks->callbacks) > > { > > - free(e->callbacks); > > + EVAS_MEMPOOL_FREE(_mp_cb, e->callbacks); > > e->callbacks = NULL; > > } > > } > > @@ -100,7 +104,7 @@ > > /* MEM OK */ > > if (!obj->callbacks) return; > > evas_event_callback_list_post_free(&obj->callbacks->callbacks); > > - free(obj->callbacks); > > + EVAS_MEMPOOL_FREE(_mp_cb, obj->callbacks); > > obj->callbacks = NULL; > > } > > > > @@ -120,7 +124,7 @@ > > /* MEM OK */ > > if (!e->callbacks) return; > > evas_event_callback_list_post_free(&e->callbacks->callbacks); > > - free(e->callbacks); > > + EVAS_MEMPOOL_FREE(_mp_cb, e->callbacks); > > e->callbacks = NULL; > > } > > > > @@ -440,19 +444,22 @@ > > > > if (!func) return; > > > > - fn = evas_mem_calloc(sizeof(Evas_Func_Node)); > > + if (!obj->callbacks) > > + { > > + EVAS_MEMPOOL_INIT(_mp_cb, "evas_callbacks", Evas_Callbacks, 512, ); > > + obj->callbacks = EVAS_MEMPOOL_ALLOC(_mp_cb, Evas_Callbacks); > > + if (!obj->callbacks) return; > > + EVAS_MEMPOOL_PREP(_mp_cb, obj->callbacks, Evas_Callbacks); > > + } > > + > > + EVAS_MEMPOOL_INIT(_mp_fn, "evas_func_node", Evas_Func_Node, 2048, ); > > + fn = EVAS_MEMPOOL_ALLOC(_mp_fn, Evas_Func_Node); > > if (!fn) return; > > + EVAS_MEMPOOL_PREP(_mp_fn, fn, Evas_Func_Node); > > fn->func = func; > > fn->data = (void *)data; > > fn->type = type; > > > > - if (!obj->callbacks) > > - obj->callbacks = evas_mem_calloc(sizeof(Evas_Callbacks)); > > - if (!obj->callbacks) > > - { > > - free(fn); > > - return; > > - } > > obj->callbacks->callbacks = > > eina_inlist_prepend(obj->callbacks->callbacks, EINA_INLIST_GET(fn)); > > } > > @@ -648,19 +655,22 @@ > > > > if (!func) return; > > > > - fn = evas_mem_calloc(sizeof(Evas_Func_Node)); > > + if (!e->callbacks) >
Re: [E-devel] E SVN: raster IN trunk/evas/src/lib: canvas include
On Friday, November 26, 2010, Enlightenment SVN wrote: > Log: > evas -> use mempool for many objects and things. but.. disable it for > now. use old calloc+free thing for 1.0 and enable mpool for 1.1. this > is just done in advance but disabled for some testing purposes looking > for some bugs. Why do that option inside Evas? Just use MP and force it to use "passthrough", then it will use malloc/free > > Author: raster > Date: 2010-11-26 02:01:18 -0800 (Fri, 26 Nov 2010) > New Revision: 55006 > > Modified: > trunk/evas/src/lib/canvas/evas_callbacks.c > trunk/evas/src/lib/canvas/evas_object_image.c > trunk/evas/src/lib/canvas/evas_object_line.c > trunk/evas/src/lib/canvas/evas_object_main.c > trunk/evas/src/lib/canvas/evas_object_polygon.c > trunk/evas/src/lib/canvas/evas_object_rectangle.c > trunk/evas/src/lib/canvas/evas_object_smart.c > trunk/evas/src/lib/canvas/evas_object_smart_clipped.c > trunk/evas/src/lib/canvas/evas_object_text.c > trunk/evas/src/lib/canvas/evas_object_textblock.c > trunk/evas/src/lib/include/evas_private.h > > Modified: trunk/evas/src/lib/canvas/evas_callbacks.c > === > --- trunk/evas/src/lib/canvas/evas_callbacks.c 2010-11-26 09:56:45 UTC (rev > 55005) > +++ trunk/evas/src/lib/canvas/evas_callbacks.c 2010-11-26 10:01:18 UTC (rev > 55006) > @@ -5,6 +5,10 @@ > static void evas_event_callback_clear(Evas *e); > int _evas_event_counter = 0; > > +EVAS_MEMPOOL(_mp_fn); > +EVAS_MEMPOOL(_mp_cb); > +EVAS_MEMPOOL(_mp_pc); > + > void > _evas_post_event_callback_call(Evas *e) > { > @@ -19,7 +23,7 @@ > { > if (!pc->func((void*)pc->data, e)) skip = 1; > } > - free(pc); > + EVAS_MEMPOOL_FREE(_mp_pc, pc); > } > _evas_unwalk(e); > } > @@ -31,7 +35,7 @@ > > EINA_LIST_FREE(e->post_events, pc) > { > - free(pc); > + EVAS_MEMPOOL_FREE(_mp_pc, pc); > } > _evas_unwalk(e); > } > @@ -51,7 +55,7 @@ > if (fn->delete_me) > { > *list = eina_inlist_remove(*list, EINA_INLIST_GET(fn)); > - free(fn); > + EVAS_MEMPOOL_FREE(_mp_fn, fn); > } > } > } > @@ -65,7 +69,7 @@ > evas_event_callback_list_post_free(&obj->callbacks->callbacks); > if (!obj->callbacks->callbacks) > { > - free(obj->callbacks); > + EVAS_MEMPOOL_FREE(_mp_cb, obj->callbacks); > obj->callbacks = NULL; > } > } > @@ -79,7 +83,7 @@ > evas_event_callback_list_post_free(&e->callbacks->callbacks); > if (!e->callbacks->callbacks) > { > - free(e->callbacks); > + EVAS_MEMPOOL_FREE(_mp_cb, e->callbacks); > e->callbacks = NULL; > } > } > @@ -100,7 +104,7 @@ > /* MEM OK */ > if (!obj->callbacks) return; > evas_event_callback_list_post_free(&obj->callbacks->callbacks); > - free(obj->callbacks); > + EVAS_MEMPOOL_FREE(_mp_cb, obj->callbacks); > obj->callbacks = NULL; > } > > @@ -120,7 +124,7 @@ > /* MEM OK */ > if (!e->callbacks) return; > evas_event_callback_list_post_free(&e->callbacks->callbacks); > - free(e->callbacks); > + EVAS_MEMPOOL_FREE(_mp_cb, e->callbacks); > e->callbacks = NULL; > } > > @@ -440,19 +444,22 @@ > > if (!func) return; > > - fn = evas_mem_calloc(sizeof(Evas_Func_Node)); > + if (!obj->callbacks) > + { > + EVAS_MEMPOOL_INIT(_mp_cb, "evas_callbacks", Evas_Callbacks, 512, ); > + obj->callbacks = EVAS_MEMPOOL_ALLOC(_mp_cb, Evas_Callbacks); > + if (!obj->callbacks) return; > + EVAS_MEMPOOL_PREP(_mp_cb, obj->callbacks, Evas_Callbacks); > + } > + > + EVAS_MEMPOOL_INIT(_mp_fn, "evas_func_node", Evas_Func_Node, 2048, ); > + fn = EVAS_MEMPOOL_ALLOC(_mp_fn, Evas_Func_Node); > if (!fn) return; > + EVAS_MEMPOOL_PREP(_mp_fn, fn, Evas_Func_Node); > fn->func = func; > fn->data = (void *)data; > fn->type = type; > > - if (!obj->callbacks) > - obj->callbacks = evas_mem_calloc(sizeof(Evas_Callbacks)); > - if (!obj->callbacks) > - { > - free(fn); > - return; > - } > obj->callbacks->callbacks = > eina_inlist_prepend(obj->callbacks->callbacks, EINA_INLIST_GET(fn)); > } > @@ -648,19 +655,22 @@ > > if (!func) return; > > - fn = evas_mem_calloc(sizeof(Evas_Func_Node)); > + if (!e->callbacks) > + { > + EVAS_MEMPOOL_INIT(_mp_cb, "evas_callbacks", Evas_Callbacks, 512, ); > + e->callbacks = EVAS_MEMPOOL_ALLOC(_mp_cb, Evas_Callbacks); > + if (!e->callbacks) return; > + EVAS_MEMPOOL_PREP(_mp_cb, e->callbacks, Evas_Callbacks); > + } > + > + EVAS_MEMPOOL_INIT(_mp_fn, "evas_func_node", Evas_Func_Node, 2048, ); > + fn = EVAS_MEMPOOL_ALLOC(_mp_fn, Evas_Func_Node); > if (!fn) return; > + EVAS_MEMPOOL_PREP(_mp_fn, fn, Evas_Func_Node); > fn->func = func; > fn->data = (void *)data; > fn->type = type; > > - if (!e->ca