Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2013-01-16 Thread ChunEon Park
oops.  
 


-Regards, Hermet- 
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
To: lt;enlightenment-...@lists.sourceforge.netgt;; 
Cc: 
Sent: 2013-01-16 (수) 20:45:02
Subject: E SVN: seoz trunk/elementary/src/lib

Log:
elm conform.c: Fixed build break.

Author:   seoz
Date: 2013-01-16 03:45:02 -0800 (Wed, 16 Jan 2013)
New Revision: 82880
Trac: http://trac.enlightenment.org/e/changeset/82880

Modified:
  trunk/elementary/src/lib/elm_conform.c 

Modified: trunk/elementary/src/lib/elm_conform.c
===
--- trunk/elementary/src/lib/elm_conform.c  2013-01-16 11:32:34 UTC (rev 
82879)
+++ trunk/elementary/src/lib/elm_conform.c  2013-01-16 11:45:02 UTC (rev 
82880)
@@ -456,7 +456,7 @@
Elm_Widget_Smart_Data *wd;
 
ELM_CONFORMANT_DATA_GET(conformant, sd);
-   wd = eo_data_get(obj, ELM_OBJ_WIDGET_CLASS);
+   wd = eo_data_get(conformant, ELM_OBJ_WIDGET_CLASS);
 
sd-gt;indmode = indmode;
 


--
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

 
--
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2013-01-09 Thread woohyun
Thanks ~ : ) 
-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
To: lt;enlightenment-...@lists.sourceforge.netgt;; 
Cc: 
Sent: 2013-01-10 (목) 00:54:42
Subject: E SVN: seoz trunk/elementary/src/lib

Log:
elm index: Fixed formatting.

Author:   seoz
Date: 2013-01-09 07:54:42 -0800 (Wed, 09 Jan 2013)
New Revision: 82468
Trac: http://trac.enlightenment.org/e/changeset/82468

Modified:
  trunk/elementary/src/lib/elm_index.c 

Modified: trunk/elementary/src/lib/elm_index.c
===
--- trunk/elementary/src/lib/elm_index.c2013-01-09 15:46:05 UTC (rev 
82467)
+++ trunk/elementary/src/lib/elm_index.c2013-01-09 15:54:42 UTC (rev 
82468)
@@ -1259,15 +1259,15 @@
p_it-gt;base.data = it-gt;base.data;
  _item_free(it);
  elm_widget_item_del(it);
-it = NULL;
+ it = NULL;
   }
  }
_index_box_clear(obj, sd-gt;bx[sd-gt;level], sd-gt;level);
 
if (!it)
-  *ret = NULL;
+ *ret = NULL;
else
-  *ret = (Elm_Object_Item *)it;
+ *ret = (Elm_Object_Item *)it;
 }
 
 EAPI Elm_Object_Item *


--
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

 
--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-12-06 Thread Gustavo Sverzut Barbieri
Not? Isn't it 1 or -1, not 1 and 0?

On Thursday, December 6, 2012, Enlightenment SVN wrote:

 Log:
 elm elm_interface_scrollable.c: Fixed wheel scroll direction with shift.

 Author:   seoz
 Date: 2012-12-06 00:25:53 -0800 (Thu, 06 Dec 2012)
 New Revision: 80312
 Trac: http://trac.enlightenment.org/e/changeset/80312

 Modified:
   trunk/elementary/src/lib/elm_interface_scrollable.c

 Modified: trunk/elementary/src/lib/elm_interface_scrollable.c
 ===
 --- trunk/elementary/src/lib/elm_interface_scrollable.c 2012-12-06
 08:25:47 UTC (rev 80311)
 +++ trunk/elementary/src/lib/elm_interface_scrollable.c 2012-12-06
 08:25:53 UTC (rev 80312)
 @@ -1723,7 +1723,7 @@
 (evas_key_modifier_is_set(ev-modifiers, Super)))
   return;
 else if (evas_key_modifier_is_set(ev-modifiers, Shift))
 - direction = 1;
 + direction = !direction;
 eo_do(sid-obj, elm_scrollable_interface_content_pos_get(x, y));
 if ((sid-down.bounce_x_animator) || (sid-down.bounce_y_animator) ||
 (sid-scrollto.x.animator) || (sid-scrollto.y.animator))



 --
 LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
 Remotely access PCs and mobile devices and provide instant support
 Improve your efficiency, and focus on delivering more value-add services
 Discover what IT Professionals Know. Rescue delivers
 http://p.sf.net/sfu/logmein_12329d2d
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net javascript:;
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn



-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-12-06 Thread Daniel Juyung Seo
It is 0 and 1.

Daniel Juyung Seo (SeoZ)
On Dec 6, 2012 8:46 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi
wrote:

 Not? Isn't it 1 or -1, not 1 and 0?

 On Thursday, December 6, 2012, Enlightenment SVN wrote:

  Log:
  elm elm_interface_scrollable.c: Fixed wheel scroll direction with shift.
 
  Author:   seoz
  Date: 2012-12-06 00:25:53 -0800 (Thu, 06 Dec 2012)
  New Revision: 80312
  Trac: http://trac.enlightenment.org/e/changeset/80312
 
  Modified:
trunk/elementary/src/lib/elm_interface_scrollable.c
 
  Modified: trunk/elementary/src/lib/elm_interface_scrollable.c
  ===
  --- trunk/elementary/src/lib/elm_interface_scrollable.c 2012-12-06
  08:25:47 UTC (rev 80311)
  +++ trunk/elementary/src/lib/elm_interface_scrollable.c 2012-12-06
  08:25:53 UTC (rev 80312)
  @@ -1723,7 +1723,7 @@
  (evas_key_modifier_is_set(ev-modifiers, Super)))
return;
  else if (evas_key_modifier_is_set(ev-modifiers, Shift))
  - direction = 1;
  + direction = !direction;
  eo_do(sid-obj, elm_scrollable_interface_content_pos_get(x, y));
  if ((sid-down.bounce_x_animator) || (sid-down.bounce_y_animator) ||
  (sid-scrollto.x.animator) || (sid-scrollto.y.animator))
 
 
 
 
 --
  LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
  Remotely access PCs and mobile devices and provide instant support
  Improve your efficiency, and focus on delivering more value-add services
  Discover what IT Professionals Know. Rescue delivers
  http://p.sf.net/sfu/logmein_12329d2d
  ___
  enlightenment-svn mailing list
  enlightenment-...@lists.sourceforge.net javascript:;
  https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
 


 --
 Gustavo Sverzut Barbieri
 http://profusion.mobi embedded systems
 --
 MSN: barbi...@gmail.com
 Skype: gsbarbieri
 Mobile: +55 (19) 9225-2202

 --
 LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
 Remotely access PCs and mobile devices and provide instant support
 Improve your efficiency, and focus on delivering more value-add services
 Discover what IT Professionals Know. Rescue delivers
 http://p.sf.net/sfu/logmein_12329d2d
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-11-15 Thread ChunEon Park
hi, seoz.


I don't understand why ev-gt;button != 1 is required in the mouse callbacks.



+ void *event_info)
 {
+   Evas_Event_Mouse_Up *ev = event_info;
+
+   if (ev-gt;button != 1) return;
}


What does it intended for?





-Regards, Hermet-

-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
To: lt;enlightenment-...@lists.sourceforge.netgt;; 
Cc: 
Sent: 2012-11-14 (수) 19:49:54
Subject: E SVN: seoz trunk/elementary/src/lib

Log:
elm image, photo, plug, segment_control, thumb: Check button type and on_hold 
flag on mouse_down/up.

Author:   seoz
Date: 2012-11-14 02:49:54 -0800 (Wed, 14 Nov 2012)
New Revision: 79284
Trac: http://trac.enlightenment.org/e/changeset/79284

Modified:
  trunk/elementary/src/lib/elm_image.c trunk/elementary/src/lib/elm_photo.c 
trunk/elementary/src/lib/elm_plug.c 
trunk/elementary/src/lib/elm_segment_control.c 
trunk/elementary/src/lib/elm_thumb.c 

Modified: trunk/elementary/src/lib/elm_image.c
===
--- trunk/elementary/src/lib/elm_image.c2012-11-14 10:49:51 UTC (rev 
79283)
+++ trunk/elementary/src/lib/elm_image.c2012-11-14 10:49:54 UTC (rev 
79284)
@@ -42,8 +42,13 @@
 _on_mouse_up(void *data,
  Evas *e __UNUSED__,
  Evas_Object *obj __UNUSED__,
- void *event_info __UNUSED__)
+ void *event_info)
 {
+   Evas_Event_Mouse_Up *ev = event_info;
+
+   if (ev-gt;button != 1) return;
+   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
+
evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
 }
 

Modified: trunk/elementary/src/lib/elm_photo.c
===
--- trunk/elementary/src/lib/elm_photo.c2012-11-14 10:49:51 UTC (rev 
79283)
+++ trunk/elementary/src/lib/elm_photo.c2012-11-14 10:49:54 UTC (rev 
79284)
@@ -172,10 +172,13 @@
 Evas_Object *icon,
 void *event_info __UNUSED__)
 {
+   Evas_Event_Mouse_Down *ev = event_info;
+
ELM_PHOTO_DATA_GET(data, sd);
 
+   if (ev-gt;button != 1) return;
+
if (sd-gt;long_press_timer) ecore_timer_del(sd-gt;long_press_timer);
-
/* FIXME: Hard coded timeout */
sd-gt;long_press_timer = ecore_timer_add(0.7, _long_press_cb, data);
evas_object_event_callback_add
@@ -188,8 +191,12 @@
   Evas_Object *obj __UNUSED__,
   void *event_info __UNUSED__)
 {
+   Evas_Event_Mouse_Up *ev = event_info;
ELM_PHOTO_DATA_GET(data, sd);
 
+   if (ev-gt;button != 1) return;
+   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
+
if (sd-gt;long_press_timer)
  {
 ecore_timer_del(sd-gt;long_press_timer);

Modified: trunk/elementary/src/lib/elm_plug.c
===
--- trunk/elementary/src/lib/elm_plug.c 2012-11-14 10:49:51 UTC (rev 79283)
+++ trunk/elementary/src/lib/elm_plug.c 2012-11-14 10:49:54 UTC (rev 79284)
@@ -54,8 +54,13 @@
 _on_mouse_up(void *data,
  Evas *e __UNUSED__,
  Evas_Object *obj __UNUSED__,
- void *event_info __UNUSED__)
+ void *event_info)
 {
+   Evas_Event_Mouse_Up *ev = event_info;
+
+   if (ev-gt;button != 1) return;
+   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
+
evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
 }
 

Modified: trunk/elementary/src/lib/elm_segment_control.c
===
--- trunk/elementary/src/lib/elm_segment_control.c  2012-11-14 10:49:51 UTC 
(rev 79283)
+++ trunk/elementary/src/lib/elm_segment_control.c  2012-11-14 10:49:54 UTC 
(rev 79284)
@@ -311,15 +311,15 @@
  Evas_Object *obj __UNUSED__,
  void *event_info)
 {
-   Elm_Segment_Item *it;
-   Evas_Event_Mouse_Up *ev;
+   Elm_Segment_Item *it = data;
+   Evas_Event_Mouse_Up *ev = event_info;
Evas_Coord x, y, w, h;
 
-   it = data;
ELM_SEGMENT_CONTROL_DATA_GET(WIDGET(it), sd);
 
+   if (ev-gt;button != 1) return;
+   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
if (elm_widget_disabled_get(ELM_WIDGET_DATA(sd)-gt;obj)) return;
-
if (it == sd-gt;selected_item) return;
 
ev = event_info;
@@ -338,13 +338,13 @@
Evas_Object *obj __UNUSED__,
void *event_info __UNUSED__)
 {
-   Elm_Segment_Item *it;
+   Elm_Segment_Item *it = data;
+   Evas_Event_Mouse_Down *ev = event_info;
 
-   it = data;
ELM_SEGMENT_CONTROL_DATA_GET(WIDGET(it), sd);
 
+   if (ev-gt;button != 1) return;
if (elm_widget_disabled_get(ELM_WIDGET_DATA(sd)-gt;obj)) return;
-
if (it == sd-gt;selected_item) return;
 
edje_object_signal_emit(VIEW(it), elm,state,segment,pressed, elm);

Modified: trunk/elementary/src/lib/elm_thumb.c
===
--- 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-11-15 Thread The Rasterman
On Fri, 16

so only left mouse button produces clicked signals? right mouse can produce
something else - eg for context popopups (as the clicked singal doesnt let u
know WHICH button caused it... so its not sane to figure it out inside the
clicked callback).

 hi, seoz.
 
 
 I don't understand why ev-gt;button != 1 is required in the mouse
 callbacks.
 
 
 
 + void *event_info)
  {
 +   Evas_Event_Mouse_Up *ev = event_info;
 +
 +   if (ev-gt;button != 1) return;
 }
 
 
 What does it intended for?
 
 
 
 
 
 -Regards, Hermet-
 
 -Original Message-
 From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
 To: lt;enlightenment-...@lists.sourceforge.netgt;; 
 Cc: 
 Sent: 2012-11-14 (수) 19:49:54
 Subject: E SVN: seoz trunk/elementary/src/lib
 
 Log:
 elm image, photo, plug, segment_control, thumb: Check button type and on_hold
 flag on mouse_down/up.
 
 Author:   seoz
 Date: 2012-11-14 02:49:54 -0800 (Wed, 14 Nov 2012)
 New Revision: 79284
 Trac: http://trac.enlightenment.org/e/changeset/79284
 
 Modified:
   trunk/elementary/src/lib/elm_image.c trunk/elementary/src/lib/elm_photo.c
 trunk/elementary/src/lib/elm_plug.c
 trunk/elementary/src/lib/elm_segment_control.c
 trunk/elementary/src/lib/elm_thumb.c 
 
 Modified: trunk/elementary/src/lib/elm_image.c
 ===
 --- trunk/elementary/src/lib/elm_image.c  2012-11-14 10:49:51 UTC (rev
 79283) +++ trunk/elementary/src/lib/elm_image.c   2012-11-14 10:49:54
 UTC (rev 79284) @@ -42,8 +42,13 @@
  _on_mouse_up(void *data,
   Evas *e __UNUSED__,
   Evas_Object *obj __UNUSED__,
 - void *event_info __UNUSED__)
 + void *event_info)
  {
 +   Evas_Event_Mouse_Up *ev = event_info;
 +
 +   if (ev-gt;button != 1) return;
 +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
 +
 evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
  }
  
 
 Modified: trunk/elementary/src/lib/elm_photo.c
 ===
 --- trunk/elementary/src/lib/elm_photo.c  2012-11-14 10:49:51 UTC (rev
 79283) +++ trunk/elementary/src/lib/elm_photo.c   2012-11-14 10:49:54
 UTC (rev 79284) @@ -172,10 +172,13 @@
  Evas_Object *icon,
  void *event_info __UNUSED__)
  {
 +   Evas_Event_Mouse_Down *ev = event_info;
 +
 ELM_PHOTO_DATA_GET(data, sd);
  
 +   if (ev-gt;button != 1) return;
 +
 if (sd-gt;long_press_timer) ecore_timer_del(sd-gt;long_press_timer);
 -
 /* FIXME: Hard coded timeout */
 sd-gt;long_press_timer = ecore_timer_add(0.7, _long_press_cb, data);
 evas_object_event_callback_add
 @@ -188,8 +191,12 @@
Evas_Object *obj __UNUSED__,
void *event_info __UNUSED__)
  {
 +   Evas_Event_Mouse_Up *ev = event_info;
 ELM_PHOTO_DATA_GET(data, sd);
  
 +   if (ev-gt;button != 1) return;
 +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
 +
 if (sd-gt;long_press_timer)
   {
  ecore_timer_del(sd-gt;long_press_timer);
 
 Modified: trunk/elementary/src/lib/elm_plug.c
 ===
 --- trunk/elementary/src/lib/elm_plug.c   2012-11-14 10:49:51 UTC (rev
 79283) +++ trunk/elementary/src/lib/elm_plug.c2012-11-14 10:49:54 UTC
 (rev 79284) @@ -54,8 +54,13 @@
  _on_mouse_up(void *data,
   Evas *e __UNUSED__,
   Evas_Object *obj __UNUSED__,
 - void *event_info __UNUSED__)
 + void *event_info)
  {
 +   Evas_Event_Mouse_Up *ev = event_info;
 +
 +   if (ev-gt;button != 1) return;
 +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
 +
 evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
  }
  
 
 Modified: trunk/elementary/src/lib/elm_segment_control.c
 ===
 --- trunk/elementary/src/lib/elm_segment_control.c2012-11-14 10:49:51
 UTC (rev 79283) +++ trunk/elementary/src/lib/elm_segment_control.c
 2012-11-14 10:49:54 UTC (rev 79284) @@ -311,15 +311,15 @@
   Evas_Object *obj __UNUSED__,
   void *event_info)
  {
 -   Elm_Segment_Item *it;
 -   Evas_Event_Mouse_Up *ev;
 +   Elm_Segment_Item *it = data;
 +   Evas_Event_Mouse_Up *ev = event_info;
 Evas_Coord x, y, w, h;
  
 -   it = data;
 ELM_SEGMENT_CONTROL_DATA_GET(WIDGET(it), sd);
  
 +   if (ev-gt;button != 1) return;
 +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
 if (elm_widget_disabled_get(ELM_WIDGET_DATA(sd)-gt;obj)) return;
 -
 if (it == sd-gt;selected_item) return;
  
 ev = event_info;
 @@ -338,13 +338,13 @@
 Evas_Object *obj __UNUSED__,
 void *event_info __UNUSED__)
  {
 -   Elm_Segment_Item *it;
 +   Elm_Segment_Item *it = data;
 +   Evas_Event_Mouse_Down *ev = event_info;
  
 -   it = data;
 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-11-15 Thread ChunEon Park
see... thank you.





-Regards, Hermet-

-Original Message-
From: Carsten Haitzlerlt;ras...@rasterman.comgt; 
To: Enlightenment developer 
listlt;enlightenment-devel@lists.sourceforge.netgt;; 
Cc: ChunEon Parklt;her...@naver.comgt;; 
lt;enlightenment-...@lists.sourceforge.netgt;; 
Sent: 2012-11-16 (금) 10:28:39
Subject: Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

On Fri, 16

so only left mouse button produces clicked signals? right mouse can produce
something else - eg for context popopups (as the clicked singal doesnt let u
know WHICH button caused it... so its not sane to figure it out inside the
clicked callback).

gt; hi, seoz.
gt; 
gt; 
gt; I don't understand why ev-gt;button != 1 is required in the mouse
gt; callbacks.
gt; 
gt; 
gt; 
gt; + void *event_info)
gt;  {
gt; +   Evas_Event_Mouse_Up *ev = event_info;
gt; +
gt; +   if (ev-gt;button != 1) return;
gt; }
gt; 
gt; 
gt; What does it intended for?
gt; 
gt; 
gt; 
gt; 
gt; 
gt; -Regards, Hermet-
gt; 
gt; -Original Message-
gt; From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
gt; To: lt;enlightenment-...@lists.sourceforge.netgt;; 
gt; Cc: 
gt; Sent: 2012-11-14 (수) 19:49:54
gt; Subject: E SVN: seoz trunk/elementary/src/lib
gt; 
gt; Log:
gt; elm image, photo, plug, segment_control, thumb: Check button type and 
on_hold
gt; flag on mouse_down/up.
gt; 
gt; Author:   seoz
gt; Date: 2012-11-14 02:49:54 -0800 (Wed, 14 Nov 2012)
gt; New Revision: 79284
gt; Trac: http://trac.enlightenment.org/e/changeset/79284
gt; 
gt; Modified:
gt;   trunk/elementary/src/lib/elm_image.c trunk/elementary/src/lib/elm_photo.c
gt; trunk/elementary/src/lib/elm_plug.c
gt; trunk/elementary/src/lib/elm_segment_control.c
gt; trunk/elementary/src/lib/elm_thumb.c 
gt; 
gt; Modified: trunk/elementary/src/lib/elm_image.c
gt; ===
gt; --- trunk/elementary/src/lib/elm_image.c   2012-11-14 10:49:51 UTC (rev
gt; 79283) +++ trunk/elementary/src/lib/elm_image.c2012-11-14 10:49:54
gt; UTC (rev 79284) @@ -42,8 +42,13 @@
gt;  _on_mouse_up(void *data,
gt;   Evas *e __UNUSED__,
gt;   Evas_Object *obj __UNUSED__,
gt; - void *event_info __UNUSED__)
gt; + void *event_info)
gt;  {
gt; +   Evas_Event_Mouse_Up *ev = event_info;
gt; +
gt; +   if (ev-gt;button != 1) return;
gt; +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
gt; +
gt; evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
gt;  }
gt;  
gt; 
gt; Modified: trunk/elementary/src/lib/elm_photo.c
gt; ===
gt; --- trunk/elementary/src/lib/elm_photo.c   2012-11-14 10:49:51 UTC (rev
gt; 79283) +++ trunk/elementary/src/lib/elm_photo.c2012-11-14 10:49:54
gt; UTC (rev 79284) @@ -172,10 +172,13 @@
gt;  Evas_Object *icon,
gt;  void *event_info __UNUSED__)
gt;  {
gt; +   Evas_Event_Mouse_Down *ev = event_info;
gt; +
gt; ELM_PHOTO_DATA_GET(data, sd);
gt;  
gt; +   if (ev-gt;button != 1) return;
gt; +
gt; if (sd-gt;long_press_timer) ecore_timer_del(sd-gt;long_press_timer);
gt; -
gt; /* FIXME: Hard coded timeout */
gt; sd-gt;long_press_timer = ecore_timer_add(0.7, _long_press_cb, data);
gt; evas_object_event_callback_add
gt; @@ -188,8 +191,12 @@
gt;Evas_Object *obj __UNUSED__,
gt;void *event_info __UNUSED__)
gt;  {
gt; +   Evas_Event_Mouse_Up *ev = event_info;
gt; ELM_PHOTO_DATA_GET(data, sd);
gt;  
gt; +   if (ev-gt;button != 1) return;
gt; +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
gt; +
gt; if (sd-gt;long_press_timer)
gt;   {
gt;  ecore_timer_del(sd-gt;long_press_timer);
gt; 
gt; Modified: trunk/elementary/src/lib/elm_plug.c
gt; ===
gt; --- trunk/elementary/src/lib/elm_plug.c2012-11-14 10:49:51 UTC (rev
gt; 79283) +++ trunk/elementary/src/lib/elm_plug.c 2012-11-14 10:49:54 UTC
gt; (rev 79284) @@ -54,8 +54,13 @@
gt;  _on_mouse_up(void *data,
gt;   Evas *e __UNUSED__,
gt;   Evas_Object *obj __UNUSED__,
gt; - void *event_info __UNUSED__)
gt; + void *event_info)
gt;  {
gt; +   Evas_Event_Mouse_Up *ev = event_info;
gt; +
gt; +   if (ev-gt;button != 1) return;
gt; +   if (ev-gt;event_flags amp; EVAS_EVENT_FLAG_ON_HOLD) return;
gt; +
gt; evas_object_smart_callback_call(data, SIG_CLICKED, NULL);
gt;  }
gt;  
gt; 
gt; Modified: trunk/elementary/src/lib/elm_segment_control.c
gt; ===
gt; --- trunk/elementary/src/lib/elm_segment_control.c 2012-11-14 10:49:51
gt; UTC (rev 79283) +++ trunk/elementary/src/lib/elm_segment_control.c
gt; 2012-11-14 10:49:54 UTC (rev 79284) @@ -311,15 +311,15 @@
gt;   Evas_Object *obj

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-08-30 Thread Eduardo Lima (Etrunko)
Backport

On Thu, Aug 30, 2012 at 12:43 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 elm naviframe: Naviframe's item Subtitle_label deleted in item_free. Patch by 
 Shilpa Onkar Singh shilpa.si...@samsung.com

 Author:   seoz
 Date: 2012-08-30 08:43:14 -0700 (Thu, 30 Aug 2012)
 New Revision: 75887
 Trac: http://trac.enlightenment.org/e/changeset/75887

 Modified:
   trunk/elementary/src/lib/elc_naviframe.c

 Modified: trunk/elementary/src/lib/elc_naviframe.c
 ===
 --- trunk/elementary/src/lib/elc_naviframe.c2012-08-30 15:22:36 UTC (rev 
 75886)
 +++ trunk/elementary/src/lib/elc_naviframe.c2012-08-30 15:43:14 UTC (rev 
 75887)
 @@ -76,6 +76,7 @@

 eina_stringshare_del(it-style);
 eina_stringshare_del(it-title_label);
 +   eina_stringshare_del(it-subtitle_label);

 if (it-title_prev_btn)
   evas_object_del(it-title_prev_btn);


 --
 Live Security Virtual Conference
 Exclusive live event will cover all the ways today's security and
 threat landscape has changed and how IT managers can respond. Discussions
 will include endpoint security, mobile security and the latest in malware
 threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn



-- 
Eduardo de Barros Lima ◤✠◢
ebl...@gmail.com

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-08-30 Thread Daniel Juyung Seo
Done! Thanks!

Daniel Juyung Seo (SeoZ)

On Fri, Aug 31, 2012 at 1:40 AM, Eduardo Lima (Etrunko)
ebl...@gmail.com wrote:
 Backport

 On Thu, Aug 30, 2012 at 12:43 PM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 elm naviframe: Naviframe's item Subtitle_label deleted in item_free. Patch 
 by Shilpa Onkar Singh shilpa.si...@samsung.com

 Author:   seoz
 Date: 2012-08-30 08:43:14 -0700 (Thu, 30 Aug 2012)
 New Revision: 75887
 Trac: http://trac.enlightenment.org/e/changeset/75887

 Modified:
   trunk/elementary/src/lib/elc_naviframe.c

 Modified: trunk/elementary/src/lib/elc_naviframe.c
 ===
 --- trunk/elementary/src/lib/elc_naviframe.c2012-08-30 15:22:36 UTC (rev 
 75886)
 +++ trunk/elementary/src/lib/elc_naviframe.c2012-08-30 15:43:14 UTC (rev 
 75887)
 @@ -76,6 +76,7 @@

 eina_stringshare_del(it-style);
 eina_stringshare_del(it-title_label);
 +   eina_stringshare_del(it-subtitle_label);

 if (it-title_prev_btn)
   evas_object_del(it-title_prev_btn);


 --
 Live Security Virtual Conference
 Exclusive live event will cover all the ways today's security and
 threat landscape has changed and how IT managers can respond. Discussions
 will include endpoint security, mobile security and the latest in malware
 threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn



 --
 Eduardo de Barros Lima ◤✠◢
 ebl...@gmail.com

 --
 Live Security Virtual Conference
 Exclusive live event will cover all the ways today's security and
 threat landscape has changed and how IT managers can respond. Discussions
 will include endpoint security, mobile security and the latest in malware
 threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-12 Thread ChunEon Park


If you does not support those callbacks, then they does not need to be 
registered.
I think it's enough to update the document only.





-Regards, Hermet-



-Original Message-
From: Enlightenment SVNlt;no-re...@enlightenment.orggt; 
To: lt;enlightenment-...@lists.sourceforge.netgt;; 
Cc: 
Sent: 2012-04-12 (목) 16:14:21
Subject: E SVN: seoz trunk/elementary/src/lib

Log:
elm genlist: genlist/gengrid do not support 
elm_object_item_part_text/content_set/unset. Use normal callback systems.

Author:   seoz
Date: 2012-04-12 00:14:21 -0700 (Thu, 12 Apr 2012)
New Revision: 70122
Trac: http://trac.enlightenment.org/e/changeset/70122

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===
--- trunk/elementary/src/lib/elm_genlist.c  2012-04-12 07:14:15 UTC (rev 
70121)
+++ trunk/elementary/src/lib/elm_genlist.c  2012-04-12 07:14:21 UTC (rev 
70122)
@@ -3638,29 +3638,21 @@
 }
 
 static void
-_item_content_set_hook(Elm_Gen_Item *it, const char *part, Evas_Object 
*content)
+_item_content_set_hook(Elm_Gen_Item *it __UNUSED__,
+   const char   *part __UNUSED__,
+   Evas_Object  *content __UNUSED__)
 {
-   Evas_Object *prev_obj;
-
-   if (content amp;amp; part)
- {
-if (eina_list_data_find(it-gt;content_objs, content)) return;
-prev_obj = _item_content_unset_hook(it, part);
-if (prev_obj) evas_object_del(prev_obj);
-it-gt;content_objs = eina_list_append(it-gt;content_objs, content);
-edje_object_part_swallow(VIEW(it), part, content);
- }
+   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
+   Use normal genlist/gengrid content_get callback model.);
 }
 
 static Evas_Object *
-_item_content_unset_hook(Elm_Gen_Item *it, const char *part)
+_item_content_unset_hook(Elm_Gen_Item *it __UNUSED__,
+ const char   *part __UNUSED__)
 {
-   Evas_Object *obj;
-   obj = edje_object_part_swallow_get(VIEW(it), part);
-   if (!obj) return NULL;
-   it-gt;content_objs = eina_list_remove(it-gt;content_objs, obj);
-   edje_object_part_unswallow(VIEW(it), obj);
-   return obj;
+   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
+   Use normal genlist/gengrid content_get callback model.);
+   return NULL;
 }
 
 static const char *
@@ -3671,6 +3663,15 @@
 }
 
 static void
+_item_text_set_hook(Elm_Object_Item *it __UNUSED__,
+const char  *part __UNUSED__,
+const char  *text __UNUSED__)
+{
+   WRN(genlist/gengrid do not support elm_object_item_part_text_set.\n
+   Use normal genlist/gengrid text_get callback model.);
+}
+
+static void
 _item_disable_hook(Elm_Object_Item *it)
 {
Eina_List *l;
@@ -3762,6 +3763,7 @@
elm_widget_item_content_set_hook_set(it, _item_content_set_hook);
elm_widget_item_content_unset_hook_set(it, _item_content_unset_hook);
elm_widget_item_text_get_hook_set(it, _item_text_get_hook);
+   elm_widget_item_text_set_hook_set(it, _item_text_set_hook);
elm_widget_item_disable_hook_set(it, _item_disable_hook);
elm_widget_item_del_pre_hook_set(it, _item_del_pre_hook);
elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);


--
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
___
enlightenment-svn mailing list
enlightenment-...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


--
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-12 Thread Daniel Juyung Seo
You are right. We need to document this.
But this is also a notice for the e-dev. If there is no sign like this
someone will add setter again some time later without noticing why it
does not exist.
Anyhow, I will document this.
Thanks!

Daniel Juyung Seo (SeoZ)

On Thu, Apr 12, 2012 at 8:29 PM, ChunEon Park her...@naver.com wrote:


 If you does not support those callbacks, then they does not need to be 
 registered.
 I think it's enough to update the document only.



 

 -Regards, Hermet-



 -Original Message-
 From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
 To: lt;enlightenment-...@lists.sourceforge.netgt;;
 Cc:
 Sent: 2012-04-12 (목) 16:14:21
 Subject: E SVN: seoz trunk/elementary/src/lib

 Log:
 elm genlist: genlist/gengrid do not support 
 elm_object_item_part_text/content_set/unset. Use normal callback systems.

 Author:       seoz
 Date:         2012-04-12 00:14:21 -0700 (Thu, 12 Apr 2012)
 New Revision: 70122
 Trac:         http://trac.enlightenment.org/e/changeset/70122

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:15 UTC (rev 
 70121)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:21 UTC (rev 
 70122)
 @@ -3638,29 +3638,21 @@
  }

  static void
 -_item_content_set_hook(Elm_Gen_Item *it, const char *part, Evas_Object 
 *content)
 +_item_content_set_hook(Elm_Gen_Item *it __UNUSED__,
 +                       const char   *part __UNUSED__,
 +                       Evas_Object  *content __UNUSED__)
  {
 -   Evas_Object *prev_obj;
 -
 -   if (content amp;amp; part)
 -     {
 -        if (eina_list_data_find(it-gt;content_objs, content)) return;
 -        prev_obj = _item_content_unset_hook(it, part);
 -        if (prev_obj) evas_object_del(prev_obj);
 -        it-gt;content_objs = eina_list_append(it-gt;content_objs, content);
 -        edje_object_part_swallow(VIEW(it), part, content);
 -     }
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
  }

  static Evas_Object *
 -_item_content_unset_hook(Elm_Gen_Item *it, const char *part)
 +_item_content_unset_hook(Elm_Gen_Item *it __UNUSED__,
 +                         const char   *part __UNUSED__)
  {
 -   Evas_Object *obj;
 -   obj = edje_object_part_swallow_get(VIEW(it), part);
 -   if (!obj) return NULL;
 -   it-gt;content_objs = eina_list_remove(it-gt;content_objs, obj);
 -   edje_object_part_unswallow(VIEW(it), obj);
 -   return obj;
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
 +   return NULL;
  }

  static const char *
 @@ -3671,6 +3663,15 @@
  }

  static void
 +_item_text_set_hook(Elm_Object_Item *it __UNUSED__,
 +                    const char      *part __UNUSED__,
 +                    const char      *text __UNUSED__)
 +{
 +   WRN(genlist/gengrid do not support elm_object_item_part_text_set.\n
 +       Use normal genlist/gengrid text_get callback model.);
 +}
 +
 +static void
  _item_disable_hook(Elm_Object_Item *it)
  {
    Eina_List *l;
 @@ -3762,6 +3763,7 @@
    elm_widget_item_content_set_hook_set(it, _item_content_set_hook);
    elm_widget_item_content_unset_hook_set(it, _item_content_unset_hook);
    elm_widget_item_text_get_hook_set(it, _item_text_get_hook);
 +   elm_widget_item_text_set_hook_set(it, _item_text_set_hook);
    elm_widget_item_disable_hook_set(it, _item_disable_hook);
    elm_widget_item_del_pre_hook_set(it, _item_del_pre_hook);
    elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-12 Thread Hyoyoung Chang
How about to add that printing warning in elm_widget?

On Thu, Apr 12, 2012 at 9:11 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote:
 You are right. We need to document this.
 But this is also a notice for the e-dev. If there is no sign like this
 someone will add setter again some time later without noticing why it
 does not exist.
 Anyhow, I will document this.
 Thanks!

 Daniel Juyung Seo (SeoZ)

 On Thu, Apr 12, 2012 at 8:29 PM, ChunEon Park her...@naver.com wrote:


 If you does not support those callbacks, then they does not need to be 
 registered.
 I think it's enough to update the document only.



 

 -Regards, Hermet-



 -Original Message-
 From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
 To: lt;enlightenment-...@lists.sourceforge.netgt;;
 Cc:
 Sent: 2012-04-12 (목) 16:14:21
 Subject: E SVN: seoz trunk/elementary/src/lib

 Log:
 elm genlist: genlist/gengrid do not support 
 elm_object_item_part_text/content_set/unset. Use normal callback systems.

 Author:       seoz
 Date:         2012-04-12 00:14:21 -0700 (Thu, 12 Apr 2012)
 New Revision: 70122
 Trac:         http://trac.enlightenment.org/e/changeset/70122

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:15 UTC (rev 
 70121)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:21 UTC (rev 
 70122)
 @@ -3638,29 +3638,21 @@
  }

  static void
 -_item_content_set_hook(Elm_Gen_Item *it, const char *part, Evas_Object 
 *content)
 +_item_content_set_hook(Elm_Gen_Item *it __UNUSED__,
 +                       const char   *part __UNUSED__,
 +                       Evas_Object  *content __UNUSED__)
  {
 -   Evas_Object *prev_obj;
 -
 -   if (content amp;amp; part)
 -     {
 -        if (eina_list_data_find(it-gt;content_objs, content)) return;
 -        prev_obj = _item_content_unset_hook(it, part);
 -        if (prev_obj) evas_object_del(prev_obj);
 -        it-gt;content_objs = eina_list_append(it-gt;content_objs, 
 content);
 -        edje_object_part_swallow(VIEW(it), part, content);
 -     }
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
  }

  static Evas_Object *
 -_item_content_unset_hook(Elm_Gen_Item *it, const char *part)
 +_item_content_unset_hook(Elm_Gen_Item *it __UNUSED__,
 +                         const char   *part __UNUSED__)
  {
 -   Evas_Object *obj;
 -   obj = edje_object_part_swallow_get(VIEW(it), part);
 -   if (!obj) return NULL;
 -   it-gt;content_objs = eina_list_remove(it-gt;content_objs, obj);
 -   edje_object_part_unswallow(VIEW(it), obj);
 -   return obj;
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
 +   return NULL;
  }

  static const char *
 @@ -3671,6 +3663,15 @@
  }

  static void
 +_item_text_set_hook(Elm_Object_Item *it __UNUSED__,
 +                    const char      *part __UNUSED__,
 +                    const char      *text __UNUSED__)
 +{
 +   WRN(genlist/gengrid do not support elm_object_item_part_text_set.\n
 +       Use normal genlist/gengrid text_get callback model.);
 +}
 +
 +static void
  _item_disable_hook(Elm_Object_Item *it)
  {
    Eina_List *l;
 @@ -3762,6 +3763,7 @@
    elm_widget_item_content_set_hook_set(it, _item_content_set_hook);
    elm_widget_item_content_unset_hook_set(it, _item_content_unset_hook);
    elm_widget_item_text_get_hook_set(it, _item_text_get_hook);
 +   elm_widget_item_text_set_hook_set(it, _item_text_set_hook);
    elm_widget_item_disable_hook_set(it, _item_disable_hook);
    elm_widget_item_del_pre_hook_set(it, _item_del_pre_hook);
    elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

 --
 For Developers, A Lot Can Happen In 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-12 Thread Daniel Juyung Seo
You are right. I'm working on it as Hermet suggested.
Thanks.

Daniel Juyung Seo (SeoZ)

On Thu, Apr 12, 2012 at 10:02 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
 How about to add that printing warning in elm_widget?

 On Thu, Apr 12, 2012 at 9:11 PM, Daniel Juyung Seo seojuyu...@gmail.com 
 wrote:
 You are right. We need to document this.
 But this is also a notice for the e-dev. If there is no sign like this
 someone will add setter again some time later without noticing why it
 does not exist.
 Anyhow, I will document this.
 Thanks!

 Daniel Juyung Seo (SeoZ)

 On Thu, Apr 12, 2012 at 8:29 PM, ChunEon Park her...@naver.com wrote:


 If you does not support those callbacks, then they does not need to be 
 registered.
 I think it's enough to update the document only.



 

 -Regards, Hermet-



 -Original Message-
 From: Enlightenment SVNlt;no-re...@enlightenment.orggt;
 To: lt;enlightenment-...@lists.sourceforge.netgt;;
 Cc:
 Sent: 2012-04-12 (목) 16:14:21
 Subject: E SVN: seoz trunk/elementary/src/lib

 Log:
 elm genlist: genlist/gengrid do not support 
 elm_object_item_part_text/content_set/unset. Use normal callback systems.

 Author:       seoz
 Date:         2012-04-12 00:14:21 -0700 (Thu, 12 Apr 2012)
 New Revision: 70122
 Trac:         http://trac.enlightenment.org/e/changeset/70122

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:15 UTC 
 (rev 70121)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-04-12 07:14:21 UTC 
 (rev 70122)
 @@ -3638,29 +3638,21 @@
  }

  static void
 -_item_content_set_hook(Elm_Gen_Item *it, const char *part, Evas_Object 
 *content)
 +_item_content_set_hook(Elm_Gen_Item *it __UNUSED__,
 +                       const char   *part __UNUSED__,
 +                       Evas_Object  *content __UNUSED__)
  {
 -   Evas_Object *prev_obj;
 -
 -   if (content amp;amp; part)
 -     {
 -        if (eina_list_data_find(it-gt;content_objs, content)) return;
 -        prev_obj = _item_content_unset_hook(it, part);
 -        if (prev_obj) evas_object_del(prev_obj);
 -        it-gt;content_objs = eina_list_append(it-gt;content_objs, 
 content);
 -        edje_object_part_swallow(VIEW(it), part, content);
 -     }
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
  }

  static Evas_Object *
 -_item_content_unset_hook(Elm_Gen_Item *it, const char *part)
 +_item_content_unset_hook(Elm_Gen_Item *it __UNUSED__,
 +                         const char   *part __UNUSED__)
  {
 -   Evas_Object *obj;
 -   obj = edje_object_part_swallow_get(VIEW(it), part);
 -   if (!obj) return NULL;
 -   it-gt;content_objs = eina_list_remove(it-gt;content_objs, obj);
 -   edje_object_part_unswallow(VIEW(it), obj);
 -   return obj;
 +   WRN(genlist/gengrid do not support elm_object_item_part_content_set.\n
 +       Use normal genlist/gengrid content_get callback model.);
 +   return NULL;
  }

  static const char *
 @@ -3671,6 +3663,15 @@
  }

  static void
 +_item_text_set_hook(Elm_Object_Item *it __UNUSED__,
 +                    const char      *part __UNUSED__,
 +                    const char      *text __UNUSED__)
 +{
 +   WRN(genlist/gengrid do not support elm_object_item_part_text_set.\n
 +       Use normal genlist/gengrid text_get callback model.);
 +}
 +
 +static void
  _item_disable_hook(Elm_Object_Item *it)
  {
    Eina_List *l;
 @@ -3762,6 +3763,7 @@
    elm_widget_item_content_set_hook_set(it, _item_content_set_hook);
    elm_widget_item_content_unset_hook_set(it, _item_content_unset_hook);
    elm_widget_item_text_get_hook_set(it, _item_text_get_hook);
 +   elm_widget_item_text_set_hook_set(it, _item_text_set_hook);
    elm_widget_item_disable_hook_set(it, _item_disable_hook);
    elm_widget_item_del_pre_hook_set(it, _item_del_pre_hook);
    elm_widget_item_signal_emit_hook_set(it, _item_signal_emit_hook);


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-06 Thread Hyoyoung Chang
On Fri, Apr 6, 2012 at 4:10 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 elm genlist: Get the stringlist only when it does not exist. Free the 
 stringlist when we change the item class.

 Author:       seoz
 Date:         2012-04-06 00:10:29 -0700 (Fri, 06 Apr 2012)
 New Revision: 69946
 Trac:         http://trac.enlightenment.org/e/changeset/69946

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-04-06 07:10:26 UTC (rev 
 69945)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-04-06 07:10:29 UTC (rev 
 69946)
 @@ -1904,7 +1904,8 @@
         const Eina_List *l;
         const char *key;

 -        *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 texts));
 +        if (!(*source))
 +          *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 texts));
         EINA_LIST_FOREACH(*source, l, key)
           {
              if (parts  fnmatch(parts, key, FNM_PERIOD))
 @@ -2010,7 +2011,8 @@
         const char *key;
         char buf[4096];

 -        *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 states));
 +        if (!(*source))
 +          *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 states));
         EINA_LIST_FOREACH(*source, l, key)
           {
              if (parts  fnmatch(parts, key, FNM_PERIOD))
 @@ -2171,8 +2173,9 @@
         if (it-flipped)
           {
              edje_object_signal_emit(VIEW(it), elm,state,flip,enabled, 
 elm);
 -             it-item-flip_contents =
 -               elm_widget_stringlist_get(edje_object_data_get(VIEW(it), 
 flips));
 +             if (!(it-item-flip_contents))
 +               it-item-flip_contents =
 +                  elm_widget_stringlist_get(edje_object_data_get(VIEW(it), 
 flips));
              it-item-flip_content_objs =
                _item_mode_content_realize(it, VIEW(it),
                                           it-item-flip_contents, NULL,
 @@ -3271,8 +3274,9 @@
    assert(eina_list_count(it-item-deco_it_content_objs) == 0);

    _item_text_realize(it, it-item-deco_it_view, it-item-deco_it_texts, 
 NULL);
 -   it-item-deco_it_contents =
 -     elm_widget_stringlist_get(edje_object_data_get(it-item-deco_it_view, 
 contents));
 +   if (!it-item-deco_it_contents)
 +     it-item-deco_it_contents =
 +        
 elm_widget_stringlist_get(edje_object_data_get(it-item-deco_it_view, 
 contents));
    it-item-deco_it_content_objs =
      _item_mode_content_realize(it, it-item-deco_it_view,
                                 it-item-deco_it_contents, NULL,
 @@ -3425,8 +3429,9 @@

    _item_text_realize(it, it-deco_all_view, it-item-deco_all_texts, NULL);
    if (it-flipped) edje_object_signal_emit(it-deco_all_view, 
 elm,state,flip,enabled, elm);
 -   it-item-deco_all_contents =
 -     elm_widget_stringlist_get(edje_object_data_get(it-deco_all_view, 
 contents));
 +   if (!it-item-deco_all_contents)
 +     it-item-deco_all_contents =
 +        elm_widget_stringlist_get(edje_object_data_get(it-deco_all_view, 
 contents));
    it-item-deco_all_content_objs =
      _item_mode_content_realize(it, it-deco_all_view,
                                 it-item-deco_all_contents, NULL,
 @@ -5100,6 +5105,34 @@
    if (_it-generation  _it-wd-generation) return;
    _it-itc = itc;
    _it-item-nocache_once = EINA_TRUE;
 +
 +   elm_widget_stringlist_free(_it-texts);
 +   _it-texts = NULL;
 +   elm_widget_stringlist_free(_it-contents);
 +   _it-contents = NULL;
 +   elm_widget_stringlist_free(_it-states);
 +   _it-states = NULL;
 +
 +   if (_it-flipped)
 +     {
 +        elm_widget_stringlist_free(_it-item-flip_contents);
 +        _it-item-flip_contents = NULL;
 +     }
 +   if (_it-item-deco_it_view)
 +     {
 +        elm_widget_stringlist_free(_it-item-deco_it_texts);
 +        _it-item-deco_it_texts = NULL;
 +        elm_widget_stringlist_free(_it-item-deco_it_contents);
 +        _it-item-deco_it_contents = NULL;
 +     }
 +   if (_it-wd-decorate_all_mode)
 +     {
 +        elm_widget_stringlist_free(_it-item-deco_all_texts);
 +        _it-item-deco_all_texts = NULL;
 +        elm_widget_stringlist_free(_it-item-deco_all_contents);
 +        _it-item-deco_all_contents = NULL;
 +     }
 +
    elm_genlist_item_update(it);
  }

elm_genlist_item_item_class_update() calls _update_job()
_update_job() calls item unrealizing.
how about to move freeing widget string routine to item_unrealize?




 --
 For Developers, A Lot Can Happen In A Second.
 Boundary is the first to Know...and Tell You.
 Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
 http://p.sf.net/sfu/Boundary-d2dvs2
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-06 Thread Daniel Juyung Seo
No, it doesn't need to be freed at every unrealize.
stringlist will stay same until item style changes so
realize/unrealize do not change the string list.
So this is more optimized way of doing it.

Daniel Juyung Seo (SeoZ)

On Fri, Apr 6, 2012 at 9:21 PM, Hyoyoung Chang hyoyo...@gmail.com wrote:
 On Fri, Apr 6, 2012 at 4:10 PM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 elm genlist: Get the stringlist only when it does not exist. Free the 
 stringlist when we change the item class.

 Author:       seoz
 Date:         2012-04-06 00:10:29 -0700 (Fri, 06 Apr 2012)
 New Revision: 69946
 Trac:         http://trac.enlightenment.org/e/changeset/69946

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-04-06 07:10:26 UTC (rev 
 69945)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-04-06 07:10:29 UTC (rev 
 69946)
 @@ -1904,7 +1904,8 @@
         const Eina_List *l;
         const char *key;

 -        *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 texts));
 +        if (!(*source))
 +          *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 texts));
         EINA_LIST_FOREACH(*source, l, key)
           {
              if (parts  fnmatch(parts, key, FNM_PERIOD))
 @@ -2010,7 +2011,8 @@
         const char *key;
         char buf[4096];

 -        *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 states));
 +        if (!(*source))
 +          *source = elm_widget_stringlist_get(edje_object_data_get(target, 
 states));
         EINA_LIST_FOREACH(*source, l, key)
           {
              if (parts  fnmatch(parts, key, FNM_PERIOD))
 @@ -2171,8 +2173,9 @@
         if (it-flipped)
           {
              edje_object_signal_emit(VIEW(it), elm,state,flip,enabled, 
 elm);
 -             it-item-flip_contents =
 -               elm_widget_stringlist_get(edje_object_data_get(VIEW(it), 
 flips));
 +             if (!(it-item-flip_contents))
 +               it-item-flip_contents =
 +                  elm_widget_stringlist_get(edje_object_data_get(VIEW(it), 
 flips));
              it-item-flip_content_objs =
                _item_mode_content_realize(it, VIEW(it),
                                           it-item-flip_contents, NULL,
 @@ -3271,8 +3274,9 @@
    assert(eina_list_count(it-item-deco_it_content_objs) == 0);

    _item_text_realize(it, it-item-deco_it_view, it-item-deco_it_texts, 
 NULL);
 -   it-item-deco_it_contents =
 -     elm_widget_stringlist_get(edje_object_data_get(it-item-deco_it_view, 
 contents));
 +   if (!it-item-deco_it_contents)
 +     it-item-deco_it_contents =
 +        
 elm_widget_stringlist_get(edje_object_data_get(it-item-deco_it_view, 
 contents));
    it-item-deco_it_content_objs =
      _item_mode_content_realize(it, it-item-deco_it_view,
                                 it-item-deco_it_contents, NULL,
 @@ -3425,8 +3429,9 @@

    _item_text_realize(it, it-deco_all_view, it-item-deco_all_texts, 
 NULL);
    if (it-flipped) edje_object_signal_emit(it-deco_all_view, 
 elm,state,flip,enabled, elm);
 -   it-item-deco_all_contents =
 -     elm_widget_stringlist_get(edje_object_data_get(it-deco_all_view, 
 contents));
 +   if (!it-item-deco_all_contents)
 +     it-item-deco_all_contents =
 +        elm_widget_stringlist_get(edje_object_data_get(it-deco_all_view, 
 contents));
    it-item-deco_all_content_objs =
      _item_mode_content_realize(it, it-deco_all_view,
                                 it-item-deco_all_contents, NULL,
 @@ -5100,6 +5105,34 @@
    if (_it-generation  _it-wd-generation) return;
    _it-itc = itc;
    _it-item-nocache_once = EINA_TRUE;
 +
 +   elm_widget_stringlist_free(_it-texts);
 +   _it-texts = NULL;
 +   elm_widget_stringlist_free(_it-contents);
 +   _it-contents = NULL;
 +   elm_widget_stringlist_free(_it-states);
 +   _it-states = NULL;
 +
 +   if (_it-flipped)
 +     {
 +        elm_widget_stringlist_free(_it-item-flip_contents);
 +        _it-item-flip_contents = NULL;
 +     }
 +   if (_it-item-deco_it_view)
 +     {
 +        elm_widget_stringlist_free(_it-item-deco_it_texts);
 +        _it-item-deco_it_texts = NULL;
 +        elm_widget_stringlist_free(_it-item-deco_it_contents);
 +        _it-item-deco_it_contents = NULL;
 +     }
 +   if (_it-wd-decorate_all_mode)
 +     {
 +        elm_widget_stringlist_free(_it-item-deco_all_texts);
 +        _it-item-deco_all_texts = NULL;
 +        elm_widget_stringlist_free(_it-item-deco_all_contents);
 +        _it-item-deco_all_contents = NULL;
 +     }
 +
    elm_genlist_item_update(it);
  }

 elm_genlist_item_item_class_update() calls _update_job()
 _update_job() calls item unrealizing.
 how about to move freeing widget string routine to item_unrealize?




 --
 For Developers, A Lot 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-04-01 Thread Daniel Juyung Seo
It's not possible to access to caller's timer/animator variable.
To do this, we need to get the address of caller's variable. ex) user_timer.

Daniel Juyung Seo (SeoZ)

On Sat, Mar 31, 2012 at 7:10 PM, Sanjeev BA eflel...@gmail.com wrote:
 Wouldnt it be simpler to put this in ecore timer del itself.
 On Mar 30, 2012 9:31 PM, Enlightenment SVN no-re...@enlightenment.org
 wrote:

 Log:
 elm: Set timer/animator to NULL after they're deleted.

 Author:       seoz
 Date:         2012-03-30 05:31:11 -0700 (Fri, 30 Mar 2012)
 New Revision: 69796
 Trac:         http://trac.enlightenment.org/e/changeset/69796

 Modified:
  trunk/elementary/src/lib/elm_flipselector.c
 trunk/elementary/src/lib/elm_index.c trunk/elementary/src/lib/elm_list.c
 trunk/elementary/src/lib/elm_slideshow.c

 Modified: trunk/elementary/src/lib/elm_flipselector.c
 ===
 --- trunk/elementary/src/lib/elm_flipselector.c 2012-03-30 12:31:01 UTC
 (rev 69795)
 +++ trunk/elementary/src/lib/elm_flipselector.c 2012-03-30 12:31:11 UTC
 (rev 69796)
 @@ -324,6 +324,7 @@
      return EINA_FALSE;

    if (wd-spin) ecore_timer_del(wd-spin);
 +   wd-spin = NULL;

    /* TODO: if direction setting via API is not coming in, replace
       these calls by flip_{next,prev} */
 @@ -663,6 +664,7 @@
    if (!wd) return;

    if (wd-spin) ecore_timer_del(wd-spin);
 +   wd-spin = NULL;

    _flipselector_walk(wd);
    _flip_down(wd);
 @@ -678,6 +680,7 @@
    if (!wd) return;

    if (wd-spin) ecore_timer_del(wd-spin);
 +   wd-spin = NULL;

    _flipselector_walk(wd);
    _flip_up(wd);

 Modified: trunk/elementary/src/lib/elm_index.c
 ===
 --- trunk/elementary/src/lib/elm_index.c        2012-03-30 12:31:01 UTC
 (rev 69795)
 +++ trunk/elementary/src/lib/elm_index.c        2012-03-30 12:31:11 UTC
 (rev 69796)
 @@ -70,6 +70,7 @@
         elm_widget_item_free(it);
      }
    if (wd-delay) ecore_timer_del(wd-delay);
 +   wd-delay = NULL;
  }

  static void

 Modified: trunk/elementary/src/lib/elm_list.c
 ===
 --- trunk/elementary/src/lib/elm_list.c 2012-03-30 12:31:01 UTC (rev 69795)
 +++ trunk/elementary/src/lib/elm_list.c 2012-03-30 12:31:11 UTC (rev 69796)
 @@ -133,7 +133,9 @@
    eina_stringshare_del(it-label);

    if (it-swipe_timer) ecore_timer_del(it-swipe_timer);
 +   it-swipe_timer = NULL;
    if (it-long_timer) ecore_timer_del(it-long_timer);
 +   it-long_timer = NULL;
    if (it-icon) evas_object_del(it-icon);
    if (it-end) evas_object_del(it-end);
  }

 Modified: trunk/elementary/src/lib/elm_slideshow.c
 ===
 --- trunk/elementary/src/lib/elm_slideshow.c    2012-03-30 12:31:01 UTC
 (rev 69795)
 +++ trunk/elementary/src/lib/elm_slideshow.c    2012-03-30 12:31:11 UTC
 (rev 69796)
 @@ -494,6 +494,7 @@
    _end(WIDGET(item), WIDGET(item), NULL, NULL);

    if (wd-timer) ecore_timer_del(wd-timer);
 +   wd-timer = NULL;
    if (wd-timeout  0.0)
      wd-timer = ecore_timer_add(wd-timeout, _timer_cb, WIDGET(item));
    _item_realize(next);
 @@ -523,6 +524,7 @@
    _end(obj, obj, NULL, NULL);

    if (wd-timer) ecore_timer_del(wd-timer);
 +   wd-timer = NULL;
    if (wd-timeout  0.0)
      wd-timer = ecore_timer_add(wd-timeout, _timer_cb, obj);

 @@ -556,6 +558,7 @@
    _end(obj, obj, NULL, NULL);

    if (wd-timer) ecore_timer_del(wd-timer);
 +   wd-timer = NULL;
    if (wd-timeout  0.0)
      wd-timer = ecore_timer_add(wd-timeout, _timer_cb, obj);




 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

 --
 This SF email is sponsosred by:
 Try Windows Azure free for 90 days Click Here
 http://p.sf.net/sfu/sfd2d-msazure
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-03-06 Thread Michael Blumenkrantz
On Tue,  6 Mar 2012 21:49:13 -0800
Enlightenment SVN no-re...@enlightenment.org wrote:

 Log:
 elm multibuttonentry: Updated document. I know this sucks this widget is
 wrongly designed. 
   Signed-off-by: Daniel Juyung Seo juyung@samsung.com
 
 Author:   seoz
 Date: 2012-03-06 21:49:13 -0800 (Tue, 06 Mar 2012)
 New Revision: 68873
 Trac: http://trac.enlightenment.org/e/changeset/68873
 
 Modified:
   trunk/elementary/src/lib/elc_multibuttonentry.h 
 

so...given this why not remove it for 1.0 ?

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-29 Thread Christopher Michael
On 02/29/2012 02:02 AM, Carsten Haitzler (The Rasterman) wrote:
 On Wed, 29 Feb 2012 15:52:07 +0900 Daniel Juyung Seoseojuyu...@gmail.com
 said:

 On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michaelcpmicha...@comcast.net
 wrote:

 On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
 Log:
 elm win: Commented unused function.

 Signed-off-by: Daniel Juyung Seojuyung@samsung.com

 Author:   seoz
 Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
 New Revision: 68533
 Trac: http://trac.enlightenment.org/e/changeset/68533

 Modified:
 trunk/elementary/src/lib/elm_win.c



 Hello


 These are going to be employed in code very soon...don't get unused
 happy yet.


 I knew it would be a temporary fix and I already read your commit.
 It was for shutting up warning message while building.
 So don't care :)
 Thanks.

 i kind of agree - at this stage we are tryng to nix all warnings so we can
 focus on the real warnings/problems that turn up. :) if there has to be tmp
 code.. making it not add warns is good.

 i highly suggest people use -W -Wall -Wextra :)

Already do. But if you are not using m4 silent, then the warnings get 
mixed with the build output, and people don't see them. Seriously, 
enable m4 silent, record the build, grep warning and you'll see the 
larger messes.

dh

 Daniel Juyung Seo (SeoZ)



 They are just a basis. i'll clean it up. who else takes care of the
 unused vars ;) These are going to be used to allow elm to pass a buffer
 of the mouse cursor (pixels) to wayland and allow the protocol there to
 attach those pixels to the surface of the cursor. if that cursor is
 rendered in shm or egl, who cares ;)

 dh


 Modified: trunk/elementary/src/lib/elm_win.c
 ===
 --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC
 (rev 68532)
 +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC
 (rev 68533)
 @@ -102,7 +102,7 @@
static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);

 -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
 +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);

static const char SIG_DELETE_REQUEST[] = delete,request;
static const char SIG_FOCUS_OUT[] = focus,out;
 @@ -1547,6 +1547,7 @@
   evas_object_del(win-win_obj);
}

 +/*
static void
_elm_win_pointer_add(Elm_Win *win, const char *style)
{
 @@ -1566,6 +1567,7 @@
   evas_object_resize(win-pointer.obj, 32, 32);
   evas_object_show(win-pointer.obj);
}
 +*/

#ifdef ELM_DEBUG
static void


--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-29 Thread Daniel Juyung Seo
Thanks but what's m4 slience and how can I set that?
Thanks in advance.

Daniel Juyung Seo (SeoZ)

On Wed, Feb 29, 2012 at 5:38 PM, Christopher Michael cpmicha...@comcast.net
 wrote:

 On 02/29/2012 02:02 AM, Carsten Haitzler (The Rasterman) wrote:
  On Wed, 29 Feb 2012 15:52:07 +0900 Daniel Juyung Seo
 seojuyu...@gmail.com
  said:
 
  On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michael
 cpmicha...@comcast.net
  wrote:
 
  On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
  Log:
  elm win: Commented unused function.
 
  Signed-off-by: Daniel Juyung Seojuyung@samsung.com
 
  Author:   seoz
  Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
  New Revision: 68533
  Trac: http://trac.enlightenment.org/e/changeset/68533
 
  Modified:
  trunk/elementary/src/lib/elm_win.c
 
 
 
  Hello
 
 
  These are going to be employed in code very soon...don't get unused
  happy yet.
 
 
  I knew it would be a temporary fix and I already read your commit.
  It was for shutting up warning message while building.
  So don't care :)
  Thanks.
 
  i kind of agree - at this stage we are tryng to nix all warnings so we
 can
  focus on the real warnings/problems that turn up. :) if there has to be
 tmp
  code.. making it not add warns is good.
 
  i highly suggest people use -W -Wall -Wextra :)
 
 Already do. But if you are not using m4 silent, then the warnings get
 mixed with the build output, and people don't see them. Seriously,
 enable m4 silent, record the build, grep warning and you'll see the
 larger messes.

 dh

  Daniel Juyung Seo (SeoZ)
 
 
 
  They are just a basis. i'll clean it up. who else takes care of the
  unused vars ;) These are going to be used to allow elm to pass a buffer
  of the mouse cursor (pixels) to wayland and allow the protocol there to
  attach those pixels to the surface of the cursor. if that cursor is
  rendered in shm or egl, who cares ;)
 
  dh
 
 
  Modified: trunk/elementary/src/lib/elm_win.c
  ===
  --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC
  (rev 68532)
  +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC
  (rev 68533)
  @@ -102,7 +102,7 @@
 static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
  __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
 static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
  __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
 
  -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
  +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);
 
 static const char SIG_DELETE_REQUEST[] = delete,request;
 static const char SIG_FOCUS_OUT[] = focus,out;
  @@ -1547,6 +1547,7 @@
evas_object_del(win-win_obj);
 }
 
  +/*
 static void
 _elm_win_pointer_add(Elm_Win *win, const char *style)
 {
  @@ -1566,6 +1567,7 @@
evas_object_resize(win-pointer.obj, 32, 32);
evas_object_show(win-pointer.obj);
 }
  +*/
 
 #ifdef ELM_DEBUG
 static void



 --
 Virtualization  Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-29 Thread Christopher Michael
On 02/29/2012 03:58 AM, Daniel Juyung Seo wrote:
 Thanks but what's m4 slience and how can I set that?
 Thanks in advance.

It's an m4 macro that silences normal (clean) build output so you don't 
see (or need to) all the -I/usr/include output during build (or other 
such define things).

Basically, instead of the messy output you are used to, you will get 
something like this:

(, clean code)

make[5]: Entering directory 
`/home/devilhorns/e/evas/src/modules/engines/gl_common'
   CC evas_gl_context.lo
   CC evas_gl_shader.lo
   CC evas_gl_rectangle.lo
   CC evas_gl_texture.lo
   CC evas_gl_image.lo
   CC evas_gl_font.lo
   CC evas_gl_polygon.lo
   CC evas_gl_line.lo
   CC evas_gl_filter.lo
   CCLD   libevas_engine_gl_common.la
make[5]: Leaving directory 
`/home/devilhorns/e/evas/src/modules/engines/gl_common'
Making all in gl_x11

make[5]: Entering directory 
`/home/devilhorns/e/evas/src/modules/engines/software_x11'
   CC module_la-evas_engine.lo
   CC module_la-evas_xcb_xdefaults.lo
   CC module_la-evas_xcb_outbuf.lo
   CC module_la-evas_xcb_buffer.lo
   CC module_la-evas_xcb_color.lo
   CC module_la-evas_xcb_main.lo
   CCLD   module.la
make[5]: Leaving directory 
`/home/devilhorns/e/evas/src/modules/engines/software_x11'


(booo, not clean code) ;)

make[5]: Entering directory 
`/home/devilhorns/e/evas/src/modules/engines/gl_x11'
   CC module_la-evas_engine.lo
evas_engine.c: In function '_sym_init':
evas_engine.c:519:4: warning: assignment from incompatible pointer type
evas_engine.c:519:4: warning: assignment from incompatible pointer type
evas_engine.c: In function 'eng_gl_make_current':
evas_engine.c:3349:35: warning: comparison between signed and unsigned 
integer expressions
   CC module_la-evas_x_main.lo
   CCLD   module.la
make[5]: Leaving directory 
`/home/devilhorns/e/evas/src/modules/engines/gl_x11'
Making all in gl_sdl
make[5]: Entering directory 
`/home/devilhorns/e/evas/src/modules/engines/gl_sdl'
make[5]: Nothing to be done for `all'.

Not sure exactly what is required to get it working on buntu distros. I 
just build the normal (latest) autoconf, automake, etc, etc and it just 
works :) I'm sure google could help you w/ your buntu issues tho ;)

 Daniel Juyung Seo (SeoZ)

 On Wed, Feb 29, 2012 at 5:38 PM, Christopher Michaelcpmicha...@comcast.net
 wrote:

 On 02/29/2012 02:02 AM, Carsten Haitzler (The Rasterman) wrote:
 On Wed, 29 Feb 2012 15:52:07 +0900 Daniel Juyung Seo
 seojuyu...@gmail.com
 said:

 On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michael
 cpmicha...@comcast.net
 wrote:

 On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
 Log:
 elm win: Commented unused function.

  Signed-off-by: Daniel Juyung Seojuyung@samsung.com

 Author:   seoz
 Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
 New Revision: 68533
 Trac: http://trac.enlightenment.org/e/changeset/68533

 Modified:
  trunk/elementary/src/lib/elm_win.c



 Hello


 These are going to be employed in code very soon...don't get unused
 happy yet.


 I knew it would be a temporary fix and I already read your commit.
 It was for shutting up warning message while building.
 So don't care :)
 Thanks.

 i kind of agree - at this stage we are tryng to nix all warnings so we
 can
 focus on the real warnings/problems that turn up. :) if there has to be
 tmp
 code.. making it not add warns is good.

 i highly suggest people use -W -Wall -Wextra :)

 Already do. But if you are not using m4 silent, then the warnings get
 mixed with the build output, and people don't see them. Seriously,
 enable m4 silent, record the build, grep warning and you'll see the
 larger messes.

 dh

 Daniel Juyung Seo (SeoZ)



 They are just a basis. i'll clean it up. who else takes care of the
 unused vars ;) These are going to be used to allow elm to pass a buffer
 of the mouse cursor (pixels) to wayland and allow the protocol there to
 attach those pixels to the surface of the cursor. if that cursor is
 rendered in shm or egl, who cares ;)

 dh


 Modified: trunk/elementary/src/lib/elm_win.c
 ===
 --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC
 (rev 68532)
 +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC
 (rev 68533)
 @@ -102,7 +102,7 @@
 static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
 static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);

 -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
 +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);

 static const char SIG_DELETE_REQUEST[] = delete,request;
 static const char SIG_FOCUS_OUT[] = focus,out;
 @@ -1547,6 +1547,7 @@
evas_object_del(win-win_obj);
 }

 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-29 Thread Vincent Torri
On Wed, Feb 29, 2012 at 10:13 AM, Christopher Michael
cpmicha...@comcast.net wrote:
 On 02/29/2012 03:58 AM, Daniel Juyung Seo wrote:
 Thanks but what's m4 slience and how can I set that?
 Thanks in advance.

 It's an m4 macro that silences normal (clean) build output so you don't
 see (or need to) all the -I/usr/include output during build (or other
 such define things).

 Basically, instead of the messy output you are used to, you will get
 something like this:

 (, clean code)

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_common'
   CC     evas_gl_context.lo
   CC     evas_gl_shader.lo
   CC     evas_gl_rectangle.lo
   CC     evas_gl_texture.lo
   CC     evas_gl_image.lo
   CC     evas_gl_font.lo
   CC     evas_gl_polygon.lo
   CC     evas_gl_line.lo
   CC     evas_gl_filter.lo
   CCLD   libevas_engine_gl_common.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_common'
 Making all in gl_x11

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/software_x11'
   CC     module_la-evas_engine.lo
   CC     module_la-evas_xcb_xdefaults.lo
   CC     module_la-evas_xcb_outbuf.lo
   CC     module_la-evas_xcb_buffer.lo
   CC     module_la-evas_xcb_color.lo
   CC     module_la-evas_xcb_main.lo
   CCLD   module.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/software_x11'


 (booo, not clean code) ;)

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_x11'
   CC     module_la-evas_engine.lo
 evas_engine.c: In function '_sym_init':
 evas_engine.c:519:4: warning: assignment from incompatible pointer type
 evas_engine.c:519:4: warning: assignment from incompatible pointer type
 evas_engine.c: In function 'eng_gl_make_current':
 evas_engine.c:3349:35: warning: comparison between signed and unsigned
 integer expressions
   CC     module_la-evas_x_main.lo
   CCLD   module.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_x11'
 Making all in gl_sdl
 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_sdl'
 make[5]: Nothing to be done for `all'.

 Not sure exactly what is required to get it working on buntu distros. I
 just build the normal (latest) autoconf, automake, etc, etc and it just
 works :) I'm sure google could help you w/ your buntu issues tho ;)

recent automake (can't remember the version, but something like 1.10 or 1.11)

to have old output (can be sometimes useful) : make V=0

Vincent

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-29 Thread Christopher Michael
On 02/29/2012 04:26 AM, Vincent Torri wrote:
 On Wed, Feb 29, 2012 at 10:13 AM, Christopher Michael
 cpmicha...@comcast.net  wrote:
 On 02/29/2012 03:58 AM, Daniel Juyung Seo wrote:
 Thanks but what's m4 slience and how can I set that?
 Thanks in advance.

 It's an m4 macro that silences normal (clean) build output so you don't
 see (or need to) all the -I/usr/include output during build (or other
 such define things).

 Basically, instead of the messy output you are used to, you will get
 something like this:

 (, clean code)

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_common'
CC evas_gl_context.lo
CC evas_gl_shader.lo
CC evas_gl_rectangle.lo
CC evas_gl_texture.lo
CC evas_gl_image.lo
CC evas_gl_font.lo
CC evas_gl_polygon.lo
CC evas_gl_line.lo
CC evas_gl_filter.lo
CCLD   libevas_engine_gl_common.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_common'
 Making all in gl_x11

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/software_x11'
CC module_la-evas_engine.lo
CC module_la-evas_xcb_xdefaults.lo
CC module_la-evas_xcb_outbuf.lo
CC module_la-evas_xcb_buffer.lo
CC module_la-evas_xcb_color.lo
CC module_la-evas_xcb_main.lo
CCLD   module.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/software_x11'


 (booo, not clean code) ;)

 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_x11'
CC module_la-evas_engine.lo
 evas_engine.c: In function '_sym_init':
 evas_engine.c:519:4: warning: assignment from incompatible pointer type
 evas_engine.c:519:4: warning: assignment from incompatible pointer type
 evas_engine.c: In function 'eng_gl_make_current':
 evas_engine.c:3349:35: warning: comparison between signed and unsigned
 integer expressions
CC module_la-evas_x_main.lo
CCLD   module.la
 make[5]: Leaving directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_x11'
 Making all in gl_sdl
 make[5]: Entering directory
 `/home/devilhorns/e/evas/src/modules/engines/gl_sdl'
 make[5]: Nothing to be done for `all'.

 Not sure exactly what is required to get it working on buntu distros. I
 just build the normal (latest) autoconf, automake, etc, etc and it just
 works :) I'm sure google could help you w/ your buntu issues tho ;)

 recent automake (can't remember the version, but something like 1.10 or 1.11)

Gentoo here so I always have the latest. it's reporting 1.11 as stable 
and that's what I have where it works.

dh

 to have old output (can be sometimes useful) : make V=0

 Vincent


--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-28 Thread Christopher Michael
On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
 Log:
 elm win: Commented unused function.

Signed-off-by: Daniel Juyung Seojuyung@samsung.com

 Author:   seoz
 Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
 New Revision: 68533
 Trac: http://trac.enlightenment.org/e/changeset/68533

 Modified:
trunk/elementary/src/lib/elm_win.c


These are going to be employed in code very soon...don't get unused 
happy yet.

They are just a basis. i'll clean it up. who else takes care of the 
unused vars ;) These are going to be used to allow elm to pass a buffer 
of the mouse cursor (pixels) to wayland and allow the protocol there to 
attach those pixels to the surface of the cursor. if that cursor is 
rendered in shm or egl, who cares ;)

dh


 Modified: trunk/elementary/src/lib/elm_win.c
 ===
 --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC (rev 
 68532)
 +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC (rev 
 68533)
 @@ -102,7 +102,7 @@
   static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj 
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
   static void _elm_win_frame_cb_close(void *data, Evas_Object *obj 
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);

 -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
 +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);

   static const char SIG_DELETE_REQUEST[] = delete,request;
   static const char SIG_FOCUS_OUT[] = focus,out;
 @@ -1547,6 +1547,7 @@
  evas_object_del(win-win_obj);
   }

 +/*
   static void
   _elm_win_pointer_add(Elm_Win *win, const char *style)
   {
 @@ -1566,6 +1567,7 @@
  evas_object_resize(win-pointer.obj, 32, 32);
  evas_object_show(win-pointer.obj);
   }
 +*/

   #ifdef ELM_DEBUG
   static void


--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-28 Thread Daniel Juyung Seo
On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michael cpmicha...@comcast.net
 wrote:

 On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
  Log:
  elm win: Commented unused function.
 
 Signed-off-by: Daniel Juyung Seojuyung@samsung.com
 
  Author:   seoz
  Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
  New Revision: 68533
  Trac: http://trac.enlightenment.org/e/changeset/68533
 
  Modified:
 trunk/elementary/src/lib/elm_win.c
 


Hello


 These are going to be employed in code very soon...don't get unused
 happy yet.


I knew it would be a temporary fix and I already read your commit.
It was for shutting up warning message while building.
So don't care :)
Thanks.

Daniel Juyung Seo (SeoZ)



 They are just a basis. i'll clean it up. who else takes care of the
 unused vars ;) These are going to be used to allow elm to pass a buffer
 of the mouse cursor (pixels) to wayland and allow the protocol there to
 attach those pixels to the surface of the cursor. if that cursor is
 rendered in shm or egl, who cares ;)

 dh


  Modified: trunk/elementary/src/lib/elm_win.c
  ===
  --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC
 (rev 68532)
  +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC
 (rev 68533)
  @@ -102,7 +102,7 @@
static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
 __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
 
  -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
  +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);
 
static const char SIG_DELETE_REQUEST[] = delete,request;
static const char SIG_FOCUS_OUT[] = focus,out;
  @@ -1547,6 +1547,7 @@
   evas_object_del(win-win_obj);
}
 
  +/*
static void
_elm_win_pointer_add(Elm_Win *win, const char *style)
{
  @@ -1566,6 +1567,7 @@
   evas_object_resize(win-pointer.obj, 32, 32);
   evas_object_show(win-pointer.obj);
}
  +*/
 
#ifdef ELM_DEBUG
static void
 


 --
 Virtualization  Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-28 Thread The Rasterman
On Wed, 29 Feb 2012 15:52:07 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:

 On Wed, Feb 29, 2012 at 2:59 PM, Christopher Michael cpmicha...@comcast.net
  wrote:
 
  On 02/29/2012 12:05 AM, Enlightenment SVN wrote:
   Log:
   elm win: Commented unused function.
  
  Signed-off-by: Daniel Juyung Seojuyung@samsung.com
  
   Author:   seoz
   Date: 2012-02-28 21:05:50 -0800 (Tue, 28 Feb 2012)
   New Revision: 68533
   Trac: http://trac.enlightenment.org/e/changeset/68533
  
   Modified:
  trunk/elementary/src/lib/elm_win.c
  
 
 
 Hello
 
 
  These are going to be employed in code very soon...don't get unused
  happy yet.
 
 
 I knew it would be a temporary fix and I already read your commit.
 It was for shutting up warning message while building.
 So don't care :)
 Thanks.

i kind of agree - at this stage we are tryng to nix all warnings so we can
focus on the real warnings/problems that turn up. :) if there has to be tmp
code.. making it not add warns is good.

i highly suggest people use -W -Wall -Wextra :)

 Daniel Juyung Seo (SeoZ)
 
 
 
  They are just a basis. i'll clean it up. who else takes care of the
  unused vars ;) These are going to be used to allow elm to pass a buffer
  of the mouse cursor (pixels) to wayland and allow the protocol there to
  attach those pixels to the surface of the cursor. if that cursor is
  rendered in shm or egl, who cares ;)
 
  dh
 
 
   Modified: trunk/elementary/src/lib/elm_win.c
   ===
   --- trunk/elementary/src/lib/elm_win.c2012-02-29 04:50:20 UTC
  (rev 68532)
   +++ trunk/elementary/src/lib/elm_win.c2012-02-29 05:05:50 UTC
  (rev 68533)
   @@ -102,7 +102,7 @@
 static void _elm_win_frame_cb_maximize(void *data, Evas_Object *obj
  __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
 static void _elm_win_frame_cb_close(void *data, Evas_Object *obj
  __UNUSED__, const char *sig __UNUSED__, const char *source __UNUSED__);
  
   -static void _elm_win_pointer_add(Elm_Win *win, const char *style);
   +//static void _elm_win_pointer_add(Elm_Win *win, const char *style);
  
 static const char SIG_DELETE_REQUEST[] = delete,request;
 static const char SIG_FOCUS_OUT[] = focus,out;
   @@ -1547,6 +1547,7 @@
evas_object_del(win-win_obj);
 }
  
   +/*
 static void
 _elm_win_pointer_add(Elm_Win *win, const char *style)
 {
   @@ -1566,6 +1567,7 @@
evas_object_resize(win-pointer.obj, 32, 32);
evas_object_show(win-pointer.obj);
 }
   +*/
  
 #ifdef ELM_DEBUG
 static void
  
 
 
  --
  Virtualization  Cloud Management Using Capacity Planning
  Cloud computing makes use of virtualization - but cloud computing
  also focuses on allowing computing to be delivered as a service.
  http://www.accelacomm.com/jaw/sfnl/114/51521223/
  ___
  enlightenment-devel mailing list
  enlightenment-devel@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 
 --
 Virtualization  Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing 
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
 


-- 
- Codito, ergo sum - I code, therefore I am --
The Rasterman (Carsten Haitzler)ras...@rasterman.com


--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-21 Thread Daniel Juyung Seo
This API was just added today so I don't deprecate the previous one.
But I just changed the name.
Thanks.

Daniel Juyung Seo (SeoZ)

On Wed, Feb 22, 2012 at 12:22 PM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 elm genlist: elm_genlist_item_count - elm_genlist_items_count

  Signed-off-by: Daniel Juyung Seo juyung@samsung.com

 Author:       seoz
 Date:         2012-02-21 19:22:10 -0800 (Tue, 21 Feb 2012)
 New Revision: 68245
 Trac:         http://trac.enlightenment.org/e/changeset/68245

 Modified:
  trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_genlist.h

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2012-02-22 03:22:03 UTC (rev 
 68244)
 +++ trunk/elementary/src/lib/elm_genlist.c      2012-02-22 03:22:10 UTC (rev 
 68245)
 @@ -3818,7 +3818,7 @@
  }

  EAPI unsigned int
 -elm_genlist_item_count(const Evas_Object *obj)
 +elm_genlist_items_count(const Evas_Object *obj)
  {
    ELM_CHECK_WIDTYPE(obj, widtype) 0;
    Widget_Data *wd = elm_widget_data_get(obj);

 Modified: trunk/elementary/src/lib/elm_genlist.h
 ===
 --- trunk/elementary/src/lib/elm_genlist.h      2012-02-22 03:22:03 UTC (rev 
 68244)
 +++ trunk/elementary/src/lib/elm_genlist.h      2012-02-22 03:22:10 UTC (rev 
 68245)
 @@ -1924,7 +1924,7 @@
  *
  * @ingroup Genlist
  */
 -EAPI unsigned int elm_genlist_item_count(const Evas_Object *obj);
 +EAPI unsigned int elm_genlist_items_count(const Evas_Object *obj);
  /**
  * @}
  */


 --
 Virtualization  Cloud Management Using Capacity Planning
 Cloud computing makes use of virtualization - but cloud computing
 also focuses on allowing computing to be delivered as a service.
 http://www.accelacomm.com/jaw/sfnl/114/51521223/
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Virtualization  Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-15 Thread Daniel Juyung Seo
ihyoyoung,
can you please add some comments on elm_cnp documentation?
I have no knowledge about copy and paste, and it's hard to understand with
current description.
Thanks in advance.

Daniel Juyung Seo (SeoZ)

On Thu, Feb 16, 2012 at 4:06 PM, Enlightenment SVN 
no-re...@enlightenment.org wrote:

 Log:
 elm cnp: Reviewed cnp APIs. Many things need to be changed.

  Signed-off-by: Daniel Juyung Seo juyung@samsung.com

 Author:   seoz
 Date: 2012-02-15 23:06:13 -0800 (Wed, 15 Feb 2012)
 New Revision: 68007
 Trac: http://trac.enlightenment.org/e/changeset/68007

 Modified:
  trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_cnp.h 
 trunk/elementary/src/lib/elm_cnp_helper.c

 Modified: trunk/elementary/src/lib/Elementary.h.in
 ===
 --- trunk/elementary/src/lib/Elementary.h.in2012-02-16 07:06:09 UTC
 (rev 68006)
 +++ trunk/elementary/src/lib/Elementary.h.in2012-02-16 07:06:13 UTC
 (rev 68007)
 @@ -184,7 +184,7 @@
  #include elm_calendar.h
  #include elm_check.h
  #include elm_clock.h
 -#include elm_cnp.h
 +#include elm_cnp.h // comments in elm_cnp.h
  #include elm_colorselector.h
  #include elm_config.h
  #include elm_conform.h

 Modified: trunk/elementary/src/lib/elm_cnp.h
 ===
 --- trunk/elementary/src/lib/elm_cnp.h  2012-02-16 07:06:09 UTC (rev 68006)
 +++ trunk/elementary/src/lib/elm_cnp.h  2012-02-16 07:06:13 UTC (rev 68007)
 @@ -45,13 +45,13 @@
  };

  /**
 - * @brief Set a data of a widget to copy and paste.
 + * @brief Set copy and paste data to a widget.
  *
 - * Append the given callback to the list. This functions will be called
 - * called.
 + * XXX: need to be rewritten.
 + * Append the given callback to the list. This functions will be called.
  *
 - * @param selection selection type for copying and pasting
 - * @param widget The source widget pointer
 + * @param selection Selection type for copying and pasting
 + * @param obj The source widget pointer
  * @param format Type of selection format
  * @param buf The pointer of data source
  * @return If EINA_TRUE, setting data is success.
 @@ -59,20 +59,24 @@
  * @ingroup CopyPaste
  *
  */
 +// XXX: EAPI void elm_object_cnp_selection_set(Evas_Object *obj,
 Elm_Sel_Type selection,
 +// Elm_Sel_Format format,
 const void *buf,
 +// size_t buflen);
 +EAPI Eina_Bool elm_cnp_selection_set(Elm_Sel_Type selection, Evas_Object
 *obj,
 + Elm_Sel_Format format, const void
 *buf,
 + size_t buflen);

 -EAPI Eina_Bool elm_cnp_selection_set(Elm_Sel_Type selection, Evas_Object
 *widget, Elm_Sel_Format format, const void *buf, size_t buflen);
 -
  /**
 - * @brief Retrieve the data from the widget which is set for copying and
 pasting.
 + * @brief Retrieve the copy and paste data from the widget.
  *
 - * Getting the data from the widget which is set for copying and pasting.
 - * Mainly the widget is elm_entry. If then @p datacb and @p udata are
 - * can be NULL. If not, @p datacb and @p udata are used for retrieving
 data.
 + * Gets the data from the widget which is set for copying and pasting.
 + * Mainly the widget is elm_entry. If then @p datacb and @p udata can be
 NULL.
 + * If not, @p datacb and @p udata are used for retrieving data.
  *
  * @see also elm_cnp_selection_set()
  *
 - * @param selection selection type for copying and pasting
 - * @param widget The source widget pointer
 + * @param selection Selection type for copying and pasting
 + * @param obj The source widget pointer
  * @param datacb The user data callback if the target widget isn't
 elm_entry
  * @param udata The user data pointer for @p datacb
  * @return If EINA_TRUE, getting data is success.
 @@ -80,26 +84,38 @@
  * @ingroup CopyPaste
  *
  */
 +// XXX: This api needs to be refined by cnp experts.
 +//  I suggest:
 +// 1. return copy and paste data.
 +// 2. call cnp callback regardless of widget type.
 +// 3. apps insert text data into entry manually.
 +// XXX: EAPI void *elm_object_cnp_selection_get(Evas_Object *obj,
 +//  Elm_Sel_Type selection,
 +//  Elm_Sel_Format format,
 +//  Elm_Cnp_Cb datacb);
 +EAPI Eina_Bool elm_cnp_selection_get(Elm_Sel_Type selection,
 + Elm_Sel_Format format, Evas_Object
 *obj,
 + Elm_Drop_Cb datacb, void *udata);

 -EAPI Eina_Bool elm_cnp_selection_get(Elm_Sel_Type selection,
 Elm_Sel_Format format, Evas_Object *widget, Elm_Drop_Cb datacb, void
 *udata);
 -
  /**
 - * @brief Clear the data in the widget which is set for copying and
 pasting.
 + * @brief Clear the copy and paste data in the 

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-02-15 Thread Hyoyoung Chang
frankly speaking, i didn't care of cnp apis.
some are too much coupled with ecore_x.
and other things are not updated.
After reviewing i'll make two patches
first patch is updating docs and infos.
and other patch will contain decoupling with elm_entry and ecore_x.


On Thu, Feb 16, 2012 at 4:10 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote:
 ihyoyoung,
 can you please add some comments on elm_cnp documentation?
 I have no knowledge about copy and paste, and it's hard to understand with
 current description.
 Thanks in advance.

 Daniel Juyung Seo (SeoZ)

 On Thu, Feb 16, 2012 at 4:06 PM, Enlightenment SVN 
 no-re...@enlightenment.org wrote:

 Log:
 elm cnp: Reviewed cnp APIs. Many things need to be changed.

  Signed-off-by: Daniel Juyung Seo juyung@samsung.com

 Author:       seoz
 Date:         2012-02-15 23:06:13 -0800 (Wed, 15 Feb 2012)
 New Revision: 68007
 Trac:         http://trac.enlightenment.org/e/changeset/68007

 Modified:
  trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_cnp.h 
 trunk/elementary/src/lib/elm_cnp_helper.c

 Modified: trunk/elementary/src/lib/Elementary.h.in
 ===
 --- trunk/elementary/src/lib/Elementary.h.in    2012-02-16 07:06:09 UTC
 (rev 68006)
 +++ trunk/elementary/src/lib/Elementary.h.in    2012-02-16 07:06:13 UTC
 (rev 68007)
 @@ -184,7 +184,7 @@
  #include elm_calendar.h
  #include elm_check.h
  #include elm_clock.h
 -#include elm_cnp.h
 +#include elm_cnp.h // comments in elm_cnp.h
  #include elm_colorselector.h
  #include elm_config.h
  #include elm_conform.h

 Modified: trunk/elementary/src/lib/elm_cnp.h
 ===
 --- trunk/elementary/src/lib/elm_cnp.h  2012-02-16 07:06:09 UTC (rev 68006)
 +++ trunk/elementary/src/lib/elm_cnp.h  2012-02-16 07:06:13 UTC (rev 68007)
 @@ -45,13 +45,13 @@
  };

  /**
 - * @brief Set a data of a widget to copy and paste.
 + * @brief Set copy and paste data to a widget.
  *
 - * Append the given callback to the list. This functions will be called
 - * called.
 + * XXX: need to be rewritten.
 + * Append the given callback to the list. This functions will be called.
  *
 - * @param selection selection type for copying and pasting
 - * @param widget The source widget pointer
 + * @param selection Selection type for copying and pasting
 + * @param obj The source widget pointer
  * @param format Type of selection format
  * @param buf The pointer of data source
  * @return If EINA_TRUE, setting data is success.
 @@ -59,20 +59,24 @@
  * @ingroup CopyPaste
  *
  */
 +// XXX: EAPI void elm_object_cnp_selection_set(Evas_Object *obj,
 Elm_Sel_Type selection,
 +//                                             Elm_Sel_Format format,
 const void *buf,
 +//                                             size_t buflen);
 +EAPI Eina_Bool elm_cnp_selection_set(Elm_Sel_Type selection, Evas_Object
 *obj,
 +                                     Elm_Sel_Format format, const void
 *buf,
 +                                     size_t buflen);

 -EAPI Eina_Bool elm_cnp_selection_set(Elm_Sel_Type selection, Evas_Object
 *widget, Elm_Sel_Format format, const void *buf, size_t buflen);
 -
  /**
 - * @brief Retrieve the data from the widget which is set for copying and
 pasting.
 + * @brief Retrieve the copy and paste data from the widget.
  *
 - * Getting the data from the widget which is set for copying and pasting.
 - * Mainly the widget is elm_entry. If then @p datacb and @p udata are
 - * can be NULL. If not, @p datacb and @p udata are used for retrieving
 data.
 + * Gets the data from the widget which is set for copying and pasting.
 + * Mainly the widget is elm_entry. If then @p datacb and @p udata can be
 NULL.
 + * If not, @p datacb and @p udata are used for retrieving data.
  *
  * @see also elm_cnp_selection_set()
  *
 - * @param selection selection type for copying and pasting
 - * @param widget The source widget pointer
 + * @param selection Selection type for copying and pasting
 + * @param obj The source widget pointer
  * @param datacb The user data callback if the target widget isn't
 elm_entry
  * @param udata The user data pointer for @p datacb
  * @return If EINA_TRUE, getting data is success.
 @@ -80,26 +84,38 @@
  * @ingroup CopyPaste
  *
  */
 +// XXX: This api needs to be refined by cnp experts.
 +//      I suggest:
 +//         1. return copy and paste data.
 +//         2. call cnp callback regardless of widget type.
 +//         3. apps insert text data into entry manually.
 +// XXX: EAPI void *elm_object_cnp_selection_get(Evas_Object *obj,
 +//                                              Elm_Sel_Type selection,
 +//                                              Elm_Sel_Format format,
 +//                                              Elm_Cnp_Cb datacb);
 +EAPI Eina_Bool elm_cnp_selection_get(Elm_Sel_Type selection,
 +                                     Elm_Sel_Format format, Evas_Object
 *obj,
 +     

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-01-10 Thread Sachiel
2012/1/10 Enlightenment SVN no-re...@enlightenment.org:
 Log:
 enki: Turn off edje_cc verbose mode.


This patch is not doing that. And it looks wrong. On many levels.

 Author:       seoz
 Date:         2012-01-10 07:34:04 -0800 (Tue, 10 Jan 2012)
 New Revision: 67016
 Trac:         http://trac.enlightenment.org/e/changeset/67016

 Modified:
  trunk/elementary/src/lib/elm_main.c

 Modified: trunk/elementary/src/lib/elm_main.c
 ===
 --- trunk/elementary/src/lib/elm_main.c 2012-01-10 11:57:09 UTC (rev 67015)
 +++ trunk/elementary/src/lib/elm_main.c 2012-01-10 15:34:04 UTC (rev 67016)
 @@ -2084,18 +2084,6 @@
  }

  EAPI void
 -elm_object_access_info_set(Evas_Object *obj, const char *txt)
 -{
 -   elm_widget_access_info_set(obj, txt);
 -}
 -
 -EAPI Evas_Object *
 -elm_object_name_find(const Evas_Object *obj, const char *name, int recurse)
 -{
 -   return elm_widget_name_find(obj, name, recurse);
 -}
 -
 -EAPI void
  elm_object_item_access_info_set(Elm_Object_Item *it, const char *txt)
  {
    _elm_widget_item_access_info_set((Elm_Widget_Item *) it, txt);
 @@ -2119,17 +2107,20 @@
    _elm_widget_item_signal_emit((Elm_Widget_Item *) it, emission, source);
  }

 -EAPI void elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool 
 disabled)
 +EAPI void
 +elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool disabled)
  {
    _elm_widget_item_disabled_set((Elm_Widget_Item *) it, disabled);
  }

 -EAPI Eina_Bool elm_object_item_disabled_get(const Elm_Object_Item *it)
 +EAPI Eina_Bool
 +elm_object_item_disabled_get(const Elm_Object_Item *it)
  {
    return _elm_widget_item_disabled_get((Elm_Widget_Item *) it);
  }

 -EAPI void elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb 
 del_cb)
 +EAPI void
 +elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb del_cb)
  {
    _elm_widget_item_del_cb_set((Elm_Widget_Item *) it, del_cb);
  }


 --
 Write once. Port to many.
 Get the SDK and tools to simplify cross-platform app development. Create
 new or port existing apps to sell to consumers worldwide. Explore the
 Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
 http://p.sf.net/sfu/intel-appdev
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-01-10 Thread Daniel Juyung Seo
oh my god!
sorry i will revert this and commit a right patch.
On Jan 11, 2012 5:09 AM, Iván Briano (Sachiel) sachi...@gmail.com wrote:

 2012/1/10 Enlightenment SVN no-re...@enlightenment.org:
  Log:
  enki: Turn off edje_cc verbose mode.
 

 This patch is not doing that. And it looks wrong. On many levels.

  Author:   seoz
  Date: 2012-01-10 07:34:04 -0800 (Tue, 10 Jan 2012)
  New Revision: 67016
  Trac: http://trac.enlightenment.org/e/changeset/67016
 
  Modified:
   trunk/elementary/src/lib/elm_main.c
 
  Modified: trunk/elementary/src/lib/elm_main.c
  ===
  --- trunk/elementary/src/lib/elm_main.c 2012-01-10 11:57:09 UTC (rev
 67015)
  +++ trunk/elementary/src/lib/elm_main.c 2012-01-10 15:34:04 UTC (rev
 67016)
  @@ -2084,18 +2084,6 @@
   }
 
   EAPI void
  -elm_object_access_info_set(Evas_Object *obj, const char *txt)
  -{
  -   elm_widget_access_info_set(obj, txt);
  -}
  -
  -EAPI Evas_Object *
  -elm_object_name_find(const Evas_Object *obj, const char *name, int
 recurse)
  -{
  -   return elm_widget_name_find(obj, name, recurse);
  -}
  -
  -EAPI void
   elm_object_item_access_info_set(Elm_Object_Item *it, const char *txt)
   {
 _elm_widget_item_access_info_set((Elm_Widget_Item *) it, txt);
  @@ -2119,17 +2107,20 @@
 _elm_widget_item_signal_emit((Elm_Widget_Item *) it, emission,
 source);
   }
 
  -EAPI void elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool
 disabled)
  +EAPI void
  +elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool disabled)
   {
 _elm_widget_item_disabled_set((Elm_Widget_Item *) it, disabled);
   }
 
  -EAPI Eina_Bool elm_object_item_disabled_get(const Elm_Object_Item *it)
  +EAPI Eina_Bool
  +elm_object_item_disabled_get(const Elm_Object_Item *it)
   {
 return _elm_widget_item_disabled_get((Elm_Widget_Item *) it);
   }
 
  -EAPI void elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb
 del_cb)
  +EAPI void
  +elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb del_cb)
   {
 _elm_widget_item_del_cb_set((Elm_Widget_Item *) it, del_cb);
   }
 
 
 
 --
  Write once. Port to many.
  Get the SDK and tools to simplify cross-platform app development. Create
  new or port existing apps to sell to consumers worldwide. Explore the
  Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
  http://p.sf.net/sfu/intel-appdev
  ___
  enlightenment-svn mailing list
  enlightenment-...@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


 --
 Write once. Port to many.
 Get the SDK and tools to simplify cross-platform app development. Create
 new or port existing apps to sell to consumers worldwide. Explore the
 Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
 http://p.sf.net/sfu/intel-appdev
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2012-01-10 Thread Daniel Juyung Seo
Reverted!
Thanks for reporting and sorry for my mistake.

Daniel Juyung Seo (SeoZ)

On Wed, Jan 11, 2012 at 7:32 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote:
 oh my god!
 sorry i will revert this and commit a right patch.

 On Jan 11, 2012 5:09 AM, Iván Briano (Sachiel) sachi...@gmail.com wrote:

 2012/1/10 Enlightenment SVN no-re...@enlightenment.org:
  Log:
  enki: Turn off edje_cc verbose mode.
 

 This patch is not doing that. And it looks wrong. On many levels.

  Author:       seoz
  Date:         2012-01-10 07:34:04 -0800 (Tue, 10 Jan 2012)
  New Revision: 67016
  Trac:         http://trac.enlightenment.org/e/changeset/67016
 
  Modified:
   trunk/elementary/src/lib/elm_main.c
 
  Modified: trunk/elementary/src/lib/elm_main.c
  ===
  --- trunk/elementary/src/lib/elm_main.c 2012-01-10 11:57:09 UTC (rev
  67015)
  +++ trunk/elementary/src/lib/elm_main.c 2012-01-10 15:34:04 UTC (rev
  67016)
  @@ -2084,18 +2084,6 @@
   }
 
   EAPI void
  -elm_object_access_info_set(Evas_Object *obj, const char *txt)
  -{
  -   elm_widget_access_info_set(obj, txt);
  -}
  -
  -EAPI Evas_Object *
  -elm_object_name_find(const Evas_Object *obj, const char *name, int
  recurse)
  -{
  -   return elm_widget_name_find(obj, name, recurse);
  -}
  -
  -EAPI void
   elm_object_item_access_info_set(Elm_Object_Item *it, const char *txt)
   {
     _elm_widget_item_access_info_set((Elm_Widget_Item *) it, txt);
  @@ -2119,17 +2107,20 @@
     _elm_widget_item_signal_emit((Elm_Widget_Item *) it, emission,
  source);
   }
 
  -EAPI void elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool
  disabled)
  +EAPI void
  +elm_object_item_disabled_set(Elm_Object_Item *it, Eina_Bool disabled)
   {
     _elm_widget_item_disabled_set((Elm_Widget_Item *) it, disabled);
   }
 
  -EAPI Eina_Bool elm_object_item_disabled_get(const Elm_Object_Item *it)
  +EAPI Eina_Bool
  +elm_object_item_disabled_get(const Elm_Object_Item *it)
   {
     return _elm_widget_item_disabled_get((Elm_Widget_Item *) it);
   }
 
  -EAPI void elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb
  del_cb)
  +EAPI void
  +elm_object_item_del_cb_set(Elm_Object_Item *it, Evas_Smart_Cb del_cb)
   {
     _elm_widget_item_del_cb_set((Elm_Widget_Item *) it, del_cb);
   }
 
 
 
  --
  Write once. Port to many.
  Get the SDK and tools to simplify cross-platform app development. Create
  new or port existing apps to sell to consumers worldwide. Explore the
  Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
  http://p.sf.net/sfu/intel-appdev
  ___
  enlightenment-svn mailing list
  enlightenment-...@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


 --
 Write once. Port to many.
 Get the SDK and tools to simplify cross-platform app development. Create
 new or port existing apps to sell to consumers worldwide. Explore the
 Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
 http://p.sf.net/sfu/intel-appdev
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-12-12 Thread Daniel Juyung Seo
I reverted elm_genlist/els_scroller.
Sorry, it was my mistake.

Daniel Juyung Seo (SeoZ)

On Tue, Dec 13, 2011 at 8:53 AM, Enlightenment SVN
no-re...@enlightenment.org wrote:
 Log:
 elm toolbar/naviframe: Added more documentation about elm_object and
  elm_object_item common APIs support. This needs to be done for other
  widgets which support elm_object/elm_object_item.


 Author:       seoz
 Date:         2011-12-12 15:53:26 -0800 (Mon, 12 Dec 2011)
 New Revision: 66122
 Trac:         http://trac.enlightenment.org/e/changeset/66122

 Modified:
  trunk/elementary/src/lib/Elementary.h.in 
 trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/els_scroller.c

 Modified: trunk/elementary/src/lib/Elementary.h.in
 ===
 --- trunk/elementary/src/lib/Elementary.h.in    2011-12-12 19:59:25 UTC (rev 
 66121)
 +++ trunk/elementary/src/lib/Elementary.h.in    2011-12-12 23:53:26 UTC (rev 
 66122)
 @@ -15339,6 +15339,13 @@
     * Default text parts of the toolbar items that you can use for are:
     * @li default - label of the toolbar item
     *
 +    * Supported elm_object_item common APIs.
 +    * @li elm_object_item_disabled_set
 +    * @li elm_object_item_text_set
 +    * @li elm_object_item_part_text_set
 +    * @li elm_object_item_text_get
 +    * @li elm_object_item_part_text_get
 +    *
     * List of examples:
     * @li @ref toolbar_example_01
     * @li @ref toolbar_example_02
 @@ -29703,6 +29710,22 @@
     * @li default - Title label in the title area
     * @li subtitle - Sub-title label in the title area
     *
 +    * Supported elm_object common APIs.
 +    * @li elm_object_signal_emit
 +    *
 +    * Supported elm_object_item common APIs.
 +    * @li elm_object_item_text_set
 +    * @li elm_object_item_part_text_set
 +    * @li elm_object_item_text_get
 +    * @li elm_object_item_part_text_get
 +    * @li elm_object_item_content_set
 +    * @li elm_object_item_part_content_set
 +    * @li elm_object_item_content_get
 +    * @li elm_object_item_part_content_get
 +    * @li elm_object_item_content_unset
 +    * @li elm_object_item_part_content_unset
 +    * @li elm_object_item_signal_emit
 +    *
     * @ref tutorial_naviframe gives a good overview of the usage of the API.
     */


 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c      2011-12-12 19:59:25 UTC (rev 
 66121)
 +++ trunk/elementary/src/lib/elm_genlist.c      2011-12-12 23:53:26 UTC (rev 
 66122)
 @@ -5,6 +5,7 @@
  #include elm_priv.h
  #include els_scroller.h
  #include elm_genlist.h
 +#include els_pan.h

  #define MAX_ITEMS_PER_BLOCK 32
  #define REORDER_EFFECT_TIME 0.5
 @@ -137,6 +138,7 @@
  static void      _elm_genlist_clear(Evas_Object *obj, Eina_Bool standby);

  static Evas_Smart_Class _pan_sc = EVAS_SMART_CLASS_INIT_VERSION;
 +static void _pan_child_size_get(Evas_Object *obj, Evas_Coord  *w, Evas_Coord 
  *h);

  static const char SIG_ACTIVATED[] = activated;
  static const char SIG_CLICKED_DOUBLE[] = clicked,double;
 @@ -2154,6 +2156,7 @@
    evas_event_freeze(evas_object_evas_get(it-wd-obj));
    evas_object_resize(view, it-item-w, it-item-h);
    evas_object_move(view, it_x, it_y);
 +//fprintf(stderr, it: %p, x %d y %d\n, view, it_x, it_y);
    evas_object_show(view);
    evas_event_thaw(evas_object_evas_get(it-wd-obj));
    evas_event_thaw_eval(evas_object_evas_get(it-wd-obj));
 @@ -2218,6 +2221,7 @@
                          }
                        if (!it-item-move_effect_enabled)
                          {
 +//fprintf(stderr, it %p itb-y %d it-y %d pan_y %d oy %d\n, it, itb-y, 
 it-y, it-wd-pan_y, oy);
                             if (it-item-mode_view)
                                _item_position(it, it-item-mode_view, 
 it-item-scrl_x,
                                               it-item-scrl_y);
 @@ -2284,6 +2288,29 @@
  }

  static void
 +_scroll_item(Widget_Data *wd)
 +{
 +   wd-show_item-item-showme = EINA_FALSE;
 +   if (wd-bring_in)
 +     elm_smart_scroller_region_bring_in(wd-scr,
 +                                        wd-show_item-x +
 +                                        wd-show_item-item-block-x,
 +                                        wd-show_item-y +
 +                                        wd-show_item-item-block-y,
 +                                        wd-show_item-item-block-w,
 +                                        wd-show_item-item-h);
 +   else
 +     elm_smart_scroller_child_region_show(wd-scr,
 +                                          wd-show_item-x +
 +                                          wd-show_item-item-block-x,
 +                                          wd-show_item-y +
 +                                          wd-show_item-item-block-y,
 +                                          wd-show_item-item-block-w,
 +                                          wd-show_item-item-h);
 +   

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-10-21 Thread Mike Blumenkrantz
On Fri, 21 Oct 2011 09:53:01 -0700
Enlightenment SVN no-re...@enlightenment.org wrote:

 Log:
 elm gengrid: Changed widget data member 'self' to 'obj'. Sync with genlist.
   
 
 Author:   seoz
 Date: 2011-10-21 09:53:01 -0700 (Fri, 21 Oct 2011)
 New Revision: 64262
 Trac: http://trac.enlightenment.org/e/changeset/64262
 
 Modified:
   trunk/elementary/src/lib/elm_gengrid.c 
oh good, I was going to do this today

-- 
Mike Blumenkrantz
Zentific: Doctor recommended, mother approved.

--
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Gustavo Sverzut Barbieri
On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN 
no-re...@enlightenment.org wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
if (!txt) txt = (char *)it-label;
if (txt) return strdup(txt);
return txt;


Hey Seoz, don't fix the bugs like this... it is not wrong, but not
recommended to fix the problem at the wrong place.

Consider the following solution:
   const char *txt = item-access_info;
   if (!txt) txt = it-label;
   if (txt) return strdup(txt);
   return NULL;

no cast abuse, make it clear of the usage and the return of NULL.

moreover, the function signature has item marked as __UNUSED__ while it's
being used... pfff :-/

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Tom Hacohen
On 24/08/11 17:04, Gustavo Sverzut Barbieri wrote:
 On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN
 no-re...@enlightenment.org  wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
 if (!txt) txt = (char *)it-label;
 if (txt) return strdup(txt);
 return txt;


 Hey Seoz, don't fix the bugs like this... it is not wrong, but not
 recommended to fix the problem at the wrong place.

 Consider the following solution:
 const char *txt = item-access_info;
 if (!txt) txt = it-label;
 if (txt) return strdup(txt);
 return NULL;

 no cast abuse, make it clear of the usage and the return of NULL.

 moreover, the function signature has item marked as __UNUSED__ while it's
 being used... pfff :-/


+1. We enable/fix warnings because we want to detect bad usage, not make 
the compilers silence no matter what your cflags are. Just casting is 
bad, very bad, and can lead to errors. Same goes with mike's comment 
about __UNUSED__.

This applies to all warnings, not just casting.

--
Tom.

--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Tom Hacohen
On 24/08/11 17:09, Tom Hacohen wrote:
 On 24/08/11 17:04, Gustavo Sverzut Barbieri wrote:
 On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN
 no-re...@enlightenment.org   wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
  if (!txt) txt = (char *)it-label;
  if (txt) return strdup(txt);
  return txt;


 Hey Seoz, don't fix the bugs like this... it is not wrong, but not
 recommended to fix the problem at the wrong place.

 Consider the following solution:
  const char *txt = item-access_info;
  if (!txt) txt = it-label;
  if (txt) return strdup(txt);
  return NULL;

 no cast abuse, make it clear of the usage and the return of NULL.

 moreover, the function signature has item marked as __UNUSED__ while it's
 being used... pfff :-/


 +1. We enable/fix warnings because we want to detect bad usage, not make
 the compilers silence no matter what your cflags are. Just casting is
 bad, very bad, and can lead to errors. Same goes with mike's comment
 about __UNUSED__.

Hm... Gustavo's comment, wth, for some reason I thought it was mike.

--
Tom.

--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Tom Hacohen
On 24/08/11 17:09, Tom Hacohen wrote:
 On 24/08/11 17:04, Gustavo Sverzut Barbieri wrote:
 On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN
 no-re...@enlightenment.org   wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
  if (!txt) txt = (char *)it-label;
  if (txt) return strdup(txt);
  return txt;


 Hey Seoz, don't fix the bugs like this... it is not wrong, but not
 recommended to fix the problem at the wrong place.

 Consider the following solution:
  const char *txt = item-access_info;
  if (!txt) txt = it-label;
  if (txt) return strdup(txt);
  return NULL;

 no cast abuse, make it clear of the usage and the return of NULL.

 moreover, the function signature has item marked as __UNUSED__ while it's
 being used... pfff :-/


 +1. We enable/fix warnings because we want to detect bad usage, not make
 the compilers silence no matter what your cflags are. Just casting is
 bad, very bad, and can lead to errors. Same goes with mike's comment
 about __UNUSED__.

Hm... Gustavo's comment, wth, for some reason I thought it was mike.

--
TOm.

--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Daniel Juyung Seo
Thanks, it was my mistake.
My bad.
Fixed, in svn!

Daniel Juyung Seo (SeoZ)

On Wed, Aug 24, 2011 at 11:04 PM, Gustavo Sverzut Barbieri
barbi...@profusion.mobi wrote:
 On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN 
 no-re...@enlightenment.org wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
    if (!txt) txt = (char *)it-label;
    if (txt) return strdup(txt);
    return txt;


 Hey Seoz, don't fix the bugs like this... it is not wrong, but not
 recommended to fix the problem at the wrong place.

 Consider the following solution:
   const char *txt = item-access_info;
   if (!txt) txt = it-label;
   if (txt) return strdup(txt);
   return NULL;

 no cast abuse, make it clear of the usage and the return of NULL.

 moreover, the function signature has item marked as __UNUSED__ while it's
 being used... pfff :-/

 --
 Gustavo Sverzut Barbieri
 http://profusion.mobi embedded systems
 --
 MSN: barbi...@gmail.com
 Skype: gsbarbieri
 Mobile: +55 (19) 9225-2202
 --
 EMC VNX: the world's simplest storage, starting under $10K
 The only unified storage solution that offers unified management
 Up to 160% more powerful than alternatives and 25% more efficient.
 Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-08-24 Thread Daniel Juyung Seo
Thanks,
I don't know why I did that :(
Anyhow, thanks a lot. I will consider it more next time.

Daniel Juyung Seo (SeoZ)

On Wed, Aug 24, 2011 at 11:09 PM, Tom Hacohen
tom.haco...@partner.samsung.com wrote:
 On 24/08/11 17:04, Gustavo Sverzut Barbieri wrote:
 On Wed, Aug 24, 2011 at 5:10 AM, Enlightenment SVN
 no-re...@enlightenment.org  wrote:

 Log:
 elm toolbar: Fixed build warnings.

 -   char *txt = item-access_info;
 +   char *txt = (char *)item-access_info;
     if (!txt) txt = (char *)it-label;
     if (txt) return strdup(txt);
     return txt;


 Hey Seoz, don't fix the bugs like this... it is not wrong, but not
 recommended to fix the problem at the wrong place.

 Consider the following solution:
     const char *txt = item-access_info;
     if (!txt) txt = it-label;
     if (txt) return strdup(txt);
     return NULL;

 no cast abuse, make it clear of the usage and the return of NULL.

 moreover, the function signature has item marked as __UNUSED__ while it's
 being used... pfff :-/


 +1. We enable/fix warnings because we want to detect bad usage, not make
 the compilers silence no matter what your cflags are. Just casting is
 bad, very bad, and can lead to errors. Same goes with mike's comment
 about __UNUSED__.

 This applies to all warnings, not just casting.

 --
 Tom.

 --
 EMC VNX: the world's simplest storage, starting under $10K
 The only unified storage solution that offers unified management
 Up to 160% more powerful than alternatives and 25% more efficient.
 Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management 
Up to 160% more powerful than alternatives and 25% more efficient. 
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-07-26 Thread Mike Blumenkrantz
On Mon, 25 Jul 2011 23:07:54 -0700
Enlightenment SVN no-re...@enlightenment.org wrote:

 Log:
 elm genscroller: Fixed warnings while raster is not working on this :)
   hooray! lol!
   
 
 Author:   seoz
 Date: 2011-07-25 23:07:54 -0700 (Mon, 25 Jul 2011)
 New Revision: 61727
 Trac: http://trac.enlightenment.org/e/changeset/61727
 
 Modified:
   trunk/elementary/src/lib/elm_genscroller.c 
someone buy this man a drink, ASAP.

-- 
Mike Blumenkrantz
Zentific: Coding in binary since '10.

--
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-05-03 Thread Nicolas Aguirre
2011/5/3 Enlightenment SVN no-re...@enlightenment.org

 Log:
 Elementary genlist: Fixed warning. Spank raster.


 Author:   seoz
 Date: 2011-05-03 10:32:18 -0700 (Tue, 03 May 2011)
 New Revision: 59154
 Trac: http://trac.enlightenment.org/e/changeset/59154

 Modified:
  trunk/elementary/src/lib/elm_genlist.c

 Modified: trunk/elementary/src/lib/elm_genlist.c
 ===
 --- trunk/elementary/src/lib/elm_genlist.c  2011-05-03 16:18:17 UTC
 (rev 59153)
 +++ trunk/elementary/src/lib/elm_genlist.c  2011-05-03 17:32:18 UTC
 (rev 59154)
 @@ -1965,7 +1965,7 @@
  _item_block_recalc(Item_Block *itb,
int in,
int qadd,
 -   int norender)
 +   int norender __UNUSED__)
  {
const Eina_List *l;
Elm_Genlist_Item *it;



 --
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today.  Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


If it's unused, and as it seems to be an internal function, it should be
better to remove defintively this argument ?

-- 
Nicolas Aguirre
Mail: aguirre.nico...@gmail.com
Web: http://enna.geexbox.org
Blog: http://dev.enlightenment.fr/~captainigloo/
--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-05-03 Thread Daniel Juyung Seo
Absolutely right.
If there is any chance to use the commented code again, we need to discuss.
I guess that's why raster just commented them not removing.

Raster?

Thanks.
Daniel Juyung Seo (SeoZ)

On Wed, May 4, 2011 at 2:43 AM, Nicolas Aguirre
aguirre.nico...@gmail.comwrote:

 2011/5/3 Enlightenment SVN no-re...@enlightenment.org

  Log:
  Elementary genlist: Fixed warning. Spank raster.
 
 
  Author:   seoz
  Date: 2011-05-03 10:32:18 -0700 (Tue, 03 May 2011)
  New Revision: 59154
  Trac: http://trac.enlightenment.org/e/changeset/59154
 
  Modified:
   trunk/elementary/src/lib/elm_genlist.c
 
  Modified: trunk/elementary/src/lib/elm_genlist.c
  ===
  --- trunk/elementary/src/lib/elm_genlist.c  2011-05-03 16:18:17 UTC
  (rev 59153)
  +++ trunk/elementary/src/lib/elm_genlist.c  2011-05-03 17:32:18 UTC
  (rev 59154)
  @@ -1965,7 +1965,7 @@
   _item_block_recalc(Item_Block *itb,
 int in,
 int qadd,
  -   int norender)
  +   int norender __UNUSED__)
   {
 const Eina_List *l;
 Elm_Genlist_Item *it;
 
 
 
 
 --
  WhatsUp Gold - Download Free Network Management Software
  The most intuitive, comprehensive, and cost-effective network
  management toolset available today.  Delivers lowest initial
  acquisition cost and overall TCO of any competing solution.
  http://p.sf.net/sfu/whatsupgold-sd
  ___
  enlightenment-svn mailing list
  enlightenment-...@lists.sourceforge.net
  https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
 

 If it's unused, and as it seems to be an internal function, it should be
 better to remove defintively this argument ?

 --
 Nicolas Aguirre
 Mail: aguirre.nico...@gmail.com
 Web: http://enna.geexbox.org
 Blog: http://dev.enlightenment.fr/~captainigloo/

 --
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today.  Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-04-29 Thread Daniel Juyung Seo
〉〉I didn't understand. Are you using elm_layout_content_get to delete the
content ?

Nope. That was just an example. Users need to handle contents by their own
needs. That's why another elm_xxx_content_get APIs in elm don't have const I
guess.

〉〉 Why aren't you using elm_layout_unset to unparent it ?

Actually that's what I suggested. But because of the reason I explained
above which raster explained to me, I changed my mind. If this is wrong I
will fix this and another APIs.

How do you think? Any suggestions are welcomed.

Daniel Juyung Seo (SeoZ)
On Apr 29, 2011 10:37 PM, Bruno Dilly bdi...@profusion.mobi wrote:
 On Fri, Apr 29, 2011 at 9:33 AM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 Elementary layout: Removed 'const' from elm_layout_content_get() API.

  This API callers can handle layout content. ex)
  evas_object_del(content);

 I didn't understand. Are you using elm_layout_content_get to delete
 the content ?
 Why aren't you using elm_layout_unset to unparent it ?



 Author:   seoz
 Date: 2011-04-29 05:33:36 -0700 (Fri, 29 Apr 2011)
 New Revision: 59035
 Trac: http://trac.enlightenment.org/e/changeset/59035

 Modified:
  
 trunk/elementary/src/lib/Elementary.h.intrunk/elementary/src/lib/elm_layout.c

 Modified: trunk/elementary/src/lib/Elementary.h.in
 ===
 --- trunk/elementary/src/lib/Elementary.h.in2011-04-29 10:50:55 UTC
(rev 59034)
 +++ trunk/elementary/src/lib/Elementary.h.in2011-04-29 12:33:36 UTC
(rev 59035)
 @@ -1043,7 +1043,7 @@
EAPI Eina_Bool  elm_layout_file_set(Evas_Object *obj, const
char *file, const char *group) EINA_ARG_NONNULL(1);
EAPI Eina_Bool  elm_layout_theme_set(Evas_Object *obj, const
char *clas, const char *group, const char *style) EINA_ARG_NONNULL(1);
EAPI void   elm_layout_content_set(Evas_Object *obj, const
char *swallow, Evas_Object *content) EINA_ARG_NONNULL(1);
 -   EAPI const Evas_Object *elm_layout_content_get(const Evas_Object
*obj, const char *swallow) EINA_ARG_NONNULL(1);
 +   EAPI Evas_Object   *elm_layout_content_get(const Evas_Object
*obj, const char *swallow) EINA_ARG_NONNULL(1);
EAPI Evas_Object   *elm_layout_content_unset(Evas_Object *obj,
const char *swallow) EINA_ARG_NONNULL(1);
EAPI void   elm_layout_text_set(Evas_Object *obj, const
char *part, const char *text) EINA_ARG_NONNULL(1);
EAPI const char*elm_layout_text_get(const Evas_Object *obj,
const char *part) EINA_ARG_NONNULL(1);

 Modified: trunk/elementary/src/lib/elm_layout.c
 ===
 --- trunk/elementary/src/lib/elm_layout.c   2011-04-29 10:50:55 UTC
(rev 59034)
 +++ trunk/elementary/src/lib/elm_layout.c   2011-04-29 12:33:36 UTC
(rev 59035)
 @@ -464,7 +464,7 @@
  *
  * @ingroup Layout
  */
 -EAPI const Evas_Object *
 +EAPI Evas_Object *
  elm_layout_content_get(const Evas_Object *obj, const char *swallow)
  {
Widget_Data *wd = elm_widget_data_get(obj);



--
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today.  Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn



--
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today. Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-04-29 Thread Bruno Dilly
On Fri, Apr 29, 2011 at 11:10 AM, Daniel Juyung Seo
seojuyu...@gmail.com wrote:
 〉〉I didn't understand. Are you using elm_layout_content_get to delete the
 content ?

 Nope. That was just an example. Users need to handle contents by their own
 needs. That's why another elm_xxx_content_get APIs in elm don't have const I
 guess.

 〉〉 Why aren't you using elm_layout_unset to unparent it ?

 Actually that's what I suggested. But because of the reason I explained
 above which raster explained to me, I changed my mind. If this is wrong I
 will fix this and another APIs.

No, it's ok.
I just said that for the case of delete I would use elm_layout_content_unset.


 How do you think? Any suggestions are welcomed.

 Daniel Juyung Seo (SeoZ)

 On Apr 29, 2011 10:37 PM, Bruno Dilly bdi...@profusion.mobi wrote:
 On Fri, Apr 29, 2011 at 9:33 AM, Enlightenment SVN
 no-re...@enlightenment.org wrote:
 Log:
 Elementary layout: Removed 'const' from elm_layout_content_get() API.

  This API callers can handle layout content. ex)
  evas_object_del(content);

 I didn't understand. Are you using elm_layout_content_get to delete
 the content ?
 Why aren't you using elm_layout_unset to unparent it ?



 Author:       seoz
 Date:         2011-04-29 05:33:36 -0700 (Fri, 29 Apr 2011)
 New Revision: 59035
 Trac:         http://trac.enlightenment.org/e/changeset/59035

 Modified:
  trunk/elementary/src/lib/Elementary.h.in
 trunk/elementary/src/lib/elm_layout.c

 Modified: trunk/elementary/src/lib/Elementary.h.in
 ===
 --- trunk/elementary/src/lib/Elementary.h.in    2011-04-29 10:50:55 UTC
 (rev 59034)
 +++ trunk/elementary/src/lib/Elementary.h.in    2011-04-29 12:33:36 UTC
 (rev 59035)
 @@ -1043,7 +1043,7 @@
    EAPI Eina_Bool          elm_layout_file_set(Evas_Object *obj, const
 char *file, const char *group) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool          elm_layout_theme_set(Evas_Object *obj, const
 char *clas, const char *group, const char *style) EINA_ARG_NONNULL(1);
    EAPI void               elm_layout_content_set(Evas_Object *obj, const
 char *swallow, Evas_Object *content) EINA_ARG_NONNULL(1);
 -   EAPI const Evas_Object *elm_layout_content_get(const Evas_Object
 *obj, const char *swallow) EINA_ARG_NONNULL(1);
 +   EAPI Evas_Object       *elm_layout_content_get(const Evas_Object
 *obj, const char *swallow) EINA_ARG_NONNULL(1);
    EAPI Evas_Object       *elm_layout_content_unset(Evas_Object *obj,
 const char *swallow) EINA_ARG_NONNULL(1);
    EAPI void               elm_layout_text_set(Evas_Object *obj, const
 char *part, const char *text) EINA_ARG_NONNULL(1);
    EAPI const char        *elm_layout_text_get(const Evas_Object *obj,
 const char *part) EINA_ARG_NONNULL(1);

 Modified: trunk/elementary/src/lib/elm_layout.c
 ===
 --- trunk/elementary/src/lib/elm_layout.c       2011-04-29 10:50:55 UTC
 (rev 59034)
 +++ trunk/elementary/src/lib/elm_layout.c       2011-04-29 12:33:36 UTC
 (rev 59035)
 @@ -464,7 +464,7 @@
  *
  * @ingroup Layout
  */
 -EAPI const Evas_Object *
 +EAPI Evas_Object *
  elm_layout_content_get(const Evas_Object *obj, const char *swallow)
  {
    Widget_Data *wd = elm_widget_data_get(obj);



 --
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today.  Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-svn mailing list
 enlightenment-...@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-svn



 --
 WhatsUp Gold - Download Free Network Management Software
 The most intuitive, comprehensive, and cost-effective network
 management toolset available today. Delivers lowest initial
 acquisition cost and overall TCO of any competing solution.
 http://p.sf.net/sfu/whatsupgold-sd
 ___
 enlightenment-devel mailing list
 enlightenment-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


--
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-02-28 Thread Sebastian Dransfeld
On 02/27/2011 11:59 PM, Enlightenment SVN wrote:
 Log:
 Elementary elm_button.c: Fix formatting.

This seems to be wrong formatting. two spaces indent after if. Or?

S.



 Author:   seoz
 Date: 2011-02-27 14:59:12 -0800 (Sun, 27 Feb 2011)
 New Revision: 57400
 Trac: http://trac.enlightenment.org/e/changeset/57400

 Modified:
trunk/elementary/src/lib/elm_button.c

 Modified: trunk/elementary/src/lib/elm_button.c
 ===
 --- trunk/elementary/src/lib/elm_button.c 2011-02-27 22:39:51 UTC (rev 
 57399)
 +++ trunk/elementary/src/lib/elm_button.c 2011-02-27 22:59:12 UTC (rev 
 57400)
 @@ -41,10 +41,10 @@
   static const char SIG_REPEATED[] = repeated;
   static const char SIG_UNPRESSED[] = unpressed;
   static const Evas_Smart_Cb_Description _signals[] = {
 -  {SIG_CLICKED, },
 -  {SIG_REPEATED, },
 -  {SIG_UNPRESSED, },
 -  {NULL, NULL}
 +   {SIG_CLICKED, },
 +   {SIG_REPEATED, },
 +   {SIG_UNPRESSED, },
 +   {NULL, NULL}
   };

   static Eina_Bool
 @@ -59,7 +59,7 @@
  if ((strcmp(ev-keyname, Return))
  (strcmp(ev-keyname, KP_Enter))
  (strcmp(ev-keyname, space)))
 - return EINA_FALSE;
 +  return EINA_FALSE;
  _activate(obj);
  ev-event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
  edje_object_signal_emit(wd-btn, elm,anim,activate, elm);
 @@ -82,13 +82,13 @@
  if (!wd) return;
  if (elm_widget_focus_get(obj))
{
 - edje_object_signal_emit(wd-btn, elm,action,focus, elm);
 - evas_object_focus_set(wd-btn, EINA_TRUE);
 +edje_object_signal_emit(wd-btn, elm,action,focus, elm);
 +evas_object_focus_set(wd-btn, EINA_TRUE);
}
  else
{
 - edje_object_signal_emit(wd-btn, elm,action,unfocus, elm);
 - evas_object_focus_set(wd-btn, EINA_FALSE);
 +edje_object_signal_emit(wd-btn, elm,action,unfocus, elm);
 +evas_object_focus_set(wd-btn, EINA_FALSE);
}
   }

 @@ -110,25 +110,25 @@
  _mirrored_set(obj, elm_widget_mirrored_get(obj));
  _elm_theme_object_set(obj, wd-btn, button, base, 
 elm_widget_style_get(obj));
  if (wd-icon)
 - edje_object_part_swallow(wd-btn, elm.swallow.content, wd-icon);
 +  edje_object_part_swallow(wd-btn, elm.swallow.content, wd-icon);
  if (wd-label)
 - edje_object_signal_emit(wd-btn, elm,state,text,visible, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,text,visible, elm);
  else
 - edje_object_signal_emit(wd-btn, elm,state,text,hidden, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,text,hidden, elm);
  if (wd-icon)
 - edje_object_signal_emit(wd-btn, elm,state,icon,visible, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,icon,visible, elm);
  else
 - edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
  edje_object_part_text_set(wd-btn, elm.text, wd-label);
  if (elm_object_disabled_get(obj))
 - edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
  edje_object_message_signal_process(wd-btn);
  edje_object_scale_set(wd-btn, elm_widget_scale_get(obj) * 
 _elm_config-scale);
  str = edje_object_data_get(wd-btn, focus_highlight);
  if ((str)  (!strcmp(str, on)))
 - elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
 +  elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
  else
 - elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
 +  elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
  _sizing_eval(obj);
   }

 @@ -138,9 +138,9 @@
  Widget_Data *wd = elm_widget_data_get(obj);
  if (!wd) return;
  if (elm_widget_disabled_get(obj))
 - edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
  else
 - edje_object_signal_emit(wd-btn, elm,state,enabled, elm);
 +  edje_object_signal_emit(wd-btn, elm,state,enabled, elm);
   }

   static void
 @@ -197,12 +197,12 @@
  if (!wd) return;
  if (sub == wd-icon)
{
 - edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 - evas_object_event_callback_del_full(sub, 
 EVAS_CALLBACK_CHANGED_SIZE_HINTS,
 -   _changed_size_hints, obj);
 - wd-icon = NULL;
 - edje_object_message_signal_process(wd-btn);
 - _sizing_eval(obj);
 +edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 +evas_object_event_callback_del_full(sub, 
 EVAS_CALLBACK_CHANGED_SIZE_HINTS,
 +_changed_size_hints, obj);
 +wd-icon = NULL;
 +edje_object_message_signal_process(wd-btn);
 +_sizing_eval(obj);
}
   }

 @@ -213,8 +213,8 @@
  if (!wd) return;
  if (wd-timer)
{
 - ecore_timer_del(wd-timer);
 - wd-timer = NULL;
 +   

Re: [E-devel] E SVN: seoz trunk/elementary/src/lib

2011-02-28 Thread Daniel Juyung Seo
Wow... This is wow.

I just found that vim settings in Elementary.h.in was WRONG.
I was following indentation rules from Elementary.h.in documentation
for several months.
But that was wrong. I just fixed and committed that.

Thanks for your comment, Sebastian.

Daniel Juyung Seo (SeoZ)

On Mon, Feb 28, 2011 at 11:00 AM, Sebastian Dransfeld
s...@tango.flipp.net wrote:
 On 02/27/2011 11:59 PM, Enlightenment SVN wrote:
 Log:
 Elementary elm_button.c: Fix formatting.

 This seems to be wrong formatting. two spaces indent after if. Or?

 S.



 Author:       seoz
 Date:         2011-02-27 14:59:12 -0800 (Sun, 27 Feb 2011)
 New Revision: 57400
 Trac:         http://trac.enlightenment.org/e/changeset/57400

 Modified:
    trunk/elementary/src/lib/elm_button.c

 Modified: trunk/elementary/src/lib/elm_button.c
 ===
 --- trunk/elementary/src/lib/elm_button.c     2011-02-27 22:39:51 UTC (rev 
 57399)
 +++ trunk/elementary/src/lib/elm_button.c     2011-02-27 22:59:12 UTC (rev 
 57400)
 @@ -41,10 +41,10 @@
   static const char SIG_REPEATED[] = repeated;
   static const char SIG_UNPRESSED[] = unpressed;
   static const Evas_Smart_Cb_Description _signals[] = {
 -  {SIG_CLICKED, },
 -  {SIG_REPEATED, },
 -  {SIG_UNPRESSED, },
 -  {NULL, NULL}
 +       {SIG_CLICKED, },
 +       {SIG_REPEATED, },
 +       {SIG_UNPRESSED, },
 +       {NULL, NULL}
   };

   static Eina_Bool
 @@ -59,7 +59,7 @@
      if ((strcmp(ev-keyname, Return))
          (strcmp(ev-keyname, KP_Enter))
          (strcmp(ev-keyname, space)))
 -     return EINA_FALSE;
 +      return EINA_FALSE;
      _activate(obj);
      ev-event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
      edje_object_signal_emit(wd-btn, elm,anim,activate, elm);
 @@ -82,13 +82,13 @@
      if (!wd) return;
      if (elm_widget_focus_get(obj))
        {
 -     edje_object_signal_emit(wd-btn, elm,action,focus, elm);
 -     evas_object_focus_set(wd-btn, EINA_TRUE);
 +        edje_object_signal_emit(wd-btn, elm,action,focus, elm);
 +        evas_object_focus_set(wd-btn, EINA_TRUE);
        }
      else
        {
 -     edje_object_signal_emit(wd-btn, elm,action,unfocus, elm);
 -     evas_object_focus_set(wd-btn, EINA_FALSE);
 +        edje_object_signal_emit(wd-btn, elm,action,unfocus, elm);
 +        evas_object_focus_set(wd-btn, EINA_FALSE);
        }
   }

 @@ -110,25 +110,25 @@
      _mirrored_set(obj, elm_widget_mirrored_get(obj));
      _elm_theme_object_set(obj, wd-btn, button, base, 
 elm_widget_style_get(obj));
      if (wd-icon)
 -     edje_object_part_swallow(wd-btn, elm.swallow.content, wd-icon);
 +      edje_object_part_swallow(wd-btn, elm.swallow.content, wd-icon);
      if (wd-label)
 -     edje_object_signal_emit(wd-btn, elm,state,text,visible, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,text,visible, elm);
      else
 -     edje_object_signal_emit(wd-btn, elm,state,text,hidden, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,text,hidden, elm);
      if (wd-icon)
 -     edje_object_signal_emit(wd-btn, elm,state,icon,visible, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,icon,visible, elm);
      else
 -     edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
      edje_object_part_text_set(wd-btn, elm.text, wd-label);
      if (elm_object_disabled_get(obj))
 -     edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
      edje_object_message_signal_process(wd-btn);
      edje_object_scale_set(wd-btn, elm_widget_scale_get(obj) * 
 _elm_config-scale);
      str = edje_object_data_get(wd-btn, focus_highlight);
      if ((str)  (!strcmp(str, on)))
 -     elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
 +      elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
      else
 -     elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
 +      elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
      _sizing_eval(obj);
   }

 @@ -138,9 +138,9 @@
      Widget_Data *wd = elm_widget_data_get(obj);
      if (!wd) return;
      if (elm_widget_disabled_get(obj))
 -     edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,disabled, elm);
      else
 -     edje_object_signal_emit(wd-btn, elm,state,enabled, elm);
 +      edje_object_signal_emit(wd-btn, elm,state,enabled, elm);
   }

   static void
 @@ -197,12 +197,12 @@
      if (!wd) return;
      if (sub == wd-icon)
        {
 -     edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 -     evas_object_event_callback_del_full(sub, 
 EVAS_CALLBACK_CHANGED_SIZE_HINTS,
 -                                       _changed_size_hints, obj);
 -     wd-icon = NULL;
 -     edje_object_message_signal_process(wd-btn);
 -     _sizing_eval(obj);
 +        edje_object_signal_emit(wd-btn, elm,state,icon,hidden, elm);
 +