Re: [E-devel] E CVS: apps/e devilhorns
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 19 May 2008 07:10:18 -0300 "Gustavo Sverzut Barbieri" <[EMAIL PROTECTED]> wrote: > http://wiki.enlightenment.org/index.php/E-Coding#Indentation > > Also, PLEASE try to highlight trailing whitespace and remove them! For SciTE users, you can set strip.trailing.spaces=1 in your .SciTEUser.properties file. In the wiki page mentioned by Gustavo you can find a new (work in progess) paragraph editing with Scite. Massimiliano - -- Massimiliano Calamelli http://mcalamelli.netsons.org [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (MingW32) iD8DBQFIMWwNleGEL56NNP4RAmfKAKCpm6Bej5rt8wF+/p8yB93OlgKJrQCfZD+n qbmDWPjvQr5kXJHjjzAG11I= =eJfB -END PGP SIGNATURE- - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, May 19, 2008 at 6:57 AM, Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e/src/bin > > > Modified Files: >e_gadcon.c > > > Log Message: > Fix some formatting while I am here tracking down why every module (when > used with new gadman module) has an extra separator in the menu. guys, let's take care to avoid such things... please try to follow the coding style so dh and englebass don't have to go and reformat everything every time. http://wiki.enlightenment.org/index.php/E-Coding#Indentation Also, PLEASE try to highlight trailing whitespace and remove them! vim: ---%<- highlight OverLength ctermbg=red ctermfg=white guibg=red guifg=white match OverLength '\%81v.*' "flag problematic whitespace (trailing and spaces before tabs) ""Note you get the same by doing let c_space_errors=1 but "this rule really applys to everything. highlight RedundantSpaces term=standout ctermbg=red guibg=red match RedundantSpaces /\s\+$\| \+\ze\t/ let c_space_errors=1 ""use :set list! to toggle visible whitespace on/off set listchars=tab:>-,trail:.,extends:> set list emacs: ---%<- (custom-set-variables '(show-trailing-whitespace t) ) --->%- I don't use hight tabs on emacs, but you might do it with C-x w h (or M-x highlight-regexp) and type "[]" (replace with keypress, just press [, then TAB, then ]) -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -- MSN: [EMAIL PROTECTED] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, May 19, 2008 at 6:39 AM, Enlightenment CVS
<[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/modules/gadman
>
>
> Modified Files:
>e_mod_gadman.c e_mod_gadman.h e_mod_main.c
>
>
> Log Message:
> Cleanup compiler warnings.
>
> ===
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_gadman.c,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -3 -r1.2 -r1.3
> --- e_mod_gadman.c 19 May 2008 09:21:44 - 1.2
> +++ e_mod_gadman.c 19 May 2008 09:39:37 - 1.3
> -return &b;
> +return strdup(b);
> }
>return "(You must define a binding)";
boing! you need to strdup() "(You must...)" and I hope you're
free()ing it as well...
===
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_gadman.h,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -3 -r1.1 -r1.2
> --- e_mod_gadman.h 19 May 2008 04:37:34 - 1.1
> +++ e_mod_gadman.h 19 May 2008 09:39:37 - 1.2
> @@ -20,7 +20,7 @@
>Evas_Object *mover;
>Evas_Object *mover_top;
>Evas_Object *full_bg;
> - char*icon_name;
> + const char*icon_name;
>
>int visible;
>int use_composite;
> ===
> RCS file: /cvs/e/e17/apps/e/src/modules/gadman/e_mod_main.c,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -3 -r1.2 -r1.3
> --- e_mod_main.c19 May 2008 09:21:44 - 1.2
> +++ e_mod_main.c19 May 2008 09:39:37 - 1.3
> @@ -41,8 +41,9 @@
>/* Menu augmentation */
>Man->icon_name = evas_stringshare_add(buf);
>Man->maug = NULL;
> - Man->maug = e_int_menus_menu_augmentation_add("config/1",
> _gadman_maug_add,
> - Man->icon_name, NULL, NULL);
> + Man->maug =
> + e_int_menus_menu_augmentation_add("config/1", _gadman_maug_add,
> + (void *)Man->icon_name, NULL, NULL);
(void *) is not that good here... maybe we could change the e_int_...
to take a const void * there? Internally it could cast when
dispatching, for easy of use.
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: [EMAIL PROTECTED]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Jan 1, 2008 2:56 AM, Vincent Torri <[EMAIL PROTECTED]> wrote: > > anyway, happy new year :) > Happy new year! (= -- Hisham Mardam Bey http://hisham.cc/ +1-514-713-9312 Codito Ergo Sum (I Code Therefore I Am) - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 31 Dec 2007, Hisham Mardam Bey wrote: > Thanks for the links, but that is really not my point here. My point > is that if someone walks in and tries to figure out what these > functions really do, there's no way of doing so (unless you consider > reading the source code then jumping over to the FDO documentation a > good way). which functions ? * ecore_x_screen_is_composited : i've not added it, and you can see a description in ecore_xcb_netwm.c. The doc in ecore_x_netwm.c is not that detailed. * all the _prefetch functions : I've documented ALL the code in the xcb backend, using sometimes the X specifications to describe the functions. in both cases, doxygen documentation can be generated to see what these functions do. Is it sufficient ? Should we detail more those documentations ? anyway, happy new year :) Vincent - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Dec 31, 2007 4:45 AM, Vincent Torri <[EMAIL PROTECTED]> wrote: > > Is this stuff properly documented? We really should make it a > > requirement to not let any new code / changes into CVS without the > > proper documentation. > > after a discussion with devilhorns on irc, it seems that no composite > calls are used in e17, so I would say that it's useless (for now) to know > if the composite extension is available or not. > > about knowing if composite is available, see: > > http://gitweb.freedesktop.org/?p=xorg/proto/compositeproto.git;a=blob_plain;f=compositeproto.txt > > section 7. > > about ecore_x_screen_is_composited, see: > > http://standards.freedesktop.org/wm-spec/wm-spec-1.4.html#id2512311 > Thanks for the links, but that is really not my point here. My point is that if someone walks in and tries to figure out what these functions really do, there's no way of doing so (unless you consider reading the source code then jumping over to the FDO documentation a good way). What I'm trying to say is that we need to have some form of code documentation policy in this project of ours. Stuff that is going to make its way into cvs should be properly documented (and when needed, commented) so both developers of the libraries and people using the libraries can figure things out with a minimal amount of hassle and code grepping. -- Hisham Mardam Bey http://hisham.cc/ +1-514-713-9312 Codito Ergo Sum (I Code Therefore I Am) - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
> On Dec 30, 2007 2:55 AM, Vincent Torri <[EMAIL PROTECTED]> wrote: >> >>> - if ((e_config->use_composite) && (ecore_x_composite_query())) >>> + if ((e_config->use_composite) && (ecore_x_screen_is_composited(0))) >> >> ecore_x_screen_is_composited does not check if the X server >> supports the composite extension. Use ecore_x_composite_query as you did >> in your previous commit. >> >> If you want to use the composite extension in a specific screen, then >> you indeed must also use ecore_x_screen_is_composited with that screen >> number. >> > > Is this stuff properly documented? We really should make it a > requirement to not let any new code / changes into CVS without the > proper documentation. after a discussion with devilhorns on irc, it seems that no composite calls are used in e17, so I would say that it's useless (for now) to know if the composite extension is available or not. about knowing if composite is available, see: http://gitweb.freedesktop.org/?p=xorg/proto/compositeproto.git;a=blob_plain;f=compositeproto.txt section 7. about ecore_x_screen_is_composited, see: http://standards.freedesktop.org/wm-spec/wm-spec-1.4.html#id2512311 Vincent - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Dec 30, 2007 2:55 AM, Vincent Torri <[EMAIL PROTECTED]> wrote: > > > - if ((e_config->use_composite) && (ecore_x_composite_query())) > > + if ((e_config->use_composite) && (ecore_x_screen_is_composited(0))) > > ecore_x_screen_is_composited does not check if the X server > supports the composite extension. Use ecore_x_composite_query as you did > in your previous commit. > > If you want to use the composite extension in a specific screen, then > you indeed must also use ecore_x_screen_is_composited with that screen > number. > Is this stuff properly documented? We really should make it a requirement to not let any new code / changes into CVS without the proper documentation. -- Hisham Mardam Bey http://hisham.cc/ +1-514-713-9312 Codito Ergo Sum (I Code Therefore I Am) - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
> - if ((e_config->use_composite) && (ecore_x_composite_query())) > + if ((e_config->use_composite) && (ecore_x_screen_is_composited(0))) ecore_x_screen_is_composited does not check if the X server supports the composite extension. Use ecore_x_composite_query as you did in your previous commit. If you want to use the composite extension in a specific screen, then you indeed must also use ecore_x_screen_is_composited with that screen number. Vincent - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Nov 24, 2007 11:12 AM, Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e/src/modules/conf > > > Modified Files: > e_conf.c > > > Log Message: > Subscribe to module update event. This will allow Config Panel to have > dynamic adds/dels when a module gets loaded/unloaded; ie: If you load module > that makes entries to Config Panel, then the Panel lists will dynamically be > updated with those entries. something else related to this would be to _not_ reload the modules list, or at least, if you do -- Gustavo Sverzut Barbieri -- Jabber: [EMAIL PROTECTED] MSN: [EMAIL PROTECTED] ICQ#: 17249123 Skype: gsbarbieri Mobile: +55 (81) 9927 0010 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Zachary Goldberg wrote: > DH, > > Is there any way to make these categories collapsable? I'de think > that once your E is setup initially you'de want the giant list of 40 > config modules mostly out of the way. > > -ZGold > With the current e_widget_ilist, no. dh - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Agreed. Zachary Goldberg wrote: > DH, > > Is there any way to make these categories collapsable? I'de think > that once your E is setup initially you'de want the giant list of 40 > config modules mostly out of the way. > > -ZGold > > On 11/2/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote: >> Enlightenment CVS committal >> >> Author : devilhorns >> Project : e17 >> Module : apps/e >> >> Dir : e17/apps/e/src/bin >> >> >> Modified Files: >> e_int_config_modules.c >> >> >> Log Message: >> Modify dialog to sort modules into categories. > - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
DH,
Is there any way to make these categories collapsable? I'de think
that once your E is setup initially you'de want the giant list of 40
config modules mostly out of the way.
-ZGold
On 11/2/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/bin
>
>
> Modified Files:
> e_int_config_modules.c
>
>
> Log Message:
> Modify dialog to sort modules into categories.
>
> ===
> RCS file: /cvs/e/e17/apps/e/src/bin/e_int_config_modules.c,v
> retrieving revision 1.77
> retrieving revision 1.78
> diff -u -3 -r1.77 -r1.78
> --- e_int_config_modules.c 31 Oct 2007 19:48:30 - 1.77
> +++ e_int_config_modules.c 2 Nov 2007 07:00:17 - 1.78
> @@ -6,7 +6,7 @@
> typedef struct _CFModule
> {
> const char *short_name, *name, *comment;
> - const char *icon, *orig_path;
> + const char *icon, *orig_path, *type;
> int enabled, selected;
> } CFModule;
>
> @@ -34,6 +34,8 @@
> static void _btn_cb_unload (void *data, void *data2);
> static void _btn_cb_load (void *data, void *data2);
> static int _upd_hdl_cb(void *data, int type, void *event);
> +static void _fill_list (Evas_Object *obj, const char *type, int
> enabled);
> +static int _find_module_category (const char *type, int enabled);
>
> /* Hash callback Protos */
> static Evas_Bool _modules_hash_cb_free (Evas_Hash *hash __UNUSED__,
> @@ -192,6 +194,7 @@
> ecore_list_first_goto(files);
> while ((mod = ecore_list_next(files)))
> {
> + const char *type;
> char buf[4096];
> Efreet_Desktop *desktop;
> CFModule *module;
> @@ -210,9 +213,18 @@
> module->short_name = evas_stringshare_add(mod);
> if (desktop->name) module->name = evas_stringshare_add(desktop->name);
> if (desktop->icon) module->icon = evas_stringshare_add(desktop->icon);
> - if (desktop->comment) module->comment =
> evas_stringshare_add(desktop->comment);
> + if (desktop->comment)
> + module->comment = evas_stringshare_add(desktop->comment);
> if (desktop->orig_path)
> module->orig_path = evas_stringshare_add(desktop->orig_path);
> + if (desktop->x)
> + {
> +type = ecore_hash_get(desktop->x, "X-Enlightenment-ModuleType");
> +if (type)
> + module->type = evas_stringshare_add(type);
> + }
> + else
> + module->type = evas_stringshare_add("shelf");
> if (e_module_find(mod)) module->enabled = 1;
>
> modules = evas_hash_direct_add(modules,
> @@ -240,7 +252,6 @@
> _fill_avail_list(E_Config_Dialog_Data *cfdata)
> {
> Evas *evas;
> - Evas_List *l = NULL;
> Evas_Coord w;
>
> if (!cfdata) return;
> @@ -251,60 +262,44 @@
> e_widget_ilist_freeze(cfdata->o_avail);
> e_widget_ilist_clear(cfdata->o_avail);
>
> - for (l = modules_list; l; l = l->next)
> + if (_find_module_category("appearance", 0))
> {
> - CFModule *module = NULL;
> - Evas_Object *ic = NULL;
> - char *name, *icon, *path;
> - char buf[4096];
> -
> - name = l->data;
> - if (!name) continue;
> - module = evas_hash_find(modules, name);
> - if ((!module) || (module->enabled) || (!module->icon)) continue;
> - /*
> - icon = efreet_icon_path_find(e_config->icon_theme,
> -module->icon, "24x24");
> - if ((!icon) && (module->orig_path))
> - {
> -path = ecore_file_dir_get(module->orig_path);
> -snprintf(buf, sizeof(buf), "%s/%s.edj", path, module->icon);
> -icon = strdup(buf);
> -free(path);
> - }
> -*/
> - if (module->orig_path)
> - {
> -path = ecore_file_dir_get(module->orig_path);
> -snprintf(buf, sizeof(buf), "%s/%s.edj", path, module->icon);
> -icon = strdup(buf);
> -free(path);
> - }
> - if (icon)
> - {
> -ic = e_util_icon_add(icon, evas);
> -free(icon);
> - }
> - if (module->name)
> - e_widget_ilist_append(cfdata->o_avail, ic, module->name, NULL,
> NULL, NULL);
> - else if (module->short_name)
> - e_widget_ilist_append(cfdata->o_avail, ic, module->short_name,
> NULL, NULL, NULL);
> + e_widget_ilist_header_append(cfdata->o_avail, NULL, _("Appearance"));
> + _fill_list(cfdata->o_avail, "appearance", 0);
> }
> -
> + if (_find_module_category("config", 0))
> + {
> + e_widget_ilist_header_append(cfdata->o_avail, NULL,
> _("Configuration"));
> + _fill_list(cfdata->o_avail, "config", 0);
> + }
> + if (_find_module_category("shelf", 0))
> + {
> + e_widget_ilist_header_append(cfdata->o_avail, NULL, _("Shelf"));
>
Re: [E-devel] E CVS: apps/e devilhorns
Enlightenment CVS wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e/src/bin > > > Modified Files: > e_fm_main.c > > > Log Message: > Use mkpath, thanks Seb :) You should still check the return value from mkpath. If mkpath returns 0, it couldn't create the dir for some reason. > > === > RCS file: /cvs/e/e17/apps/e/src/bin/e_fm_main.c,v > retrieving revision 1.31 > retrieving revision 1.32 > diff -u -3 -r1.31 -r1.32 > --- e_fm_main.c 10 Oct 2007 17:54:04 - 1.31 > +++ e_fm_main.c 10 Oct 2007 19:04:55 - 1.32 > @@ -1634,16 +1634,13 @@ > fop = (E_Fop *)data; > if (!fop) return 0; > > - /* Check that 'home trash' exists, create if not */ > + /* Check that 'home trash' and subsequesnt dirs exists, create if not */ > snprintf(buf, sizeof(buf), "%s/Trash", efreet_data_home_get()); > trash_dir = evas_stringshare_add(buf); > - if (!ecore_file_exists(trash_dir)) ecore_file_mkdir(trash_dir); > - > - /* Create required 'info' and 'files' subdirs if needed */ > snprintf(buf, sizeof(buf), "%s/files", trash_dir); > - if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); > + ecore_file_mkpath(buf); > snprintf(buf, sizeof(buf), "%s/info", trash_dir); > - if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); > + ecore_file_mkpath(buf); > > filename = evas_stringshare_add(strrchr(fop->src, '/')); > escname = ecore_file_escape_name(filename); -- Sebastian - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Sebastian Dransfeld wrote: > Enlightenment CVS wrote: >> Log Message: >> Add FDO spec compliant trash implimentation. >> Not actually called from anywhere just yet, committing for potential review. >> + /* Check that 'home trash' exists, create if not */ >> + snprintf(buf, sizeof(buf), "%s/Trash", efreet_data_home_get()); >> + trash_dir = evas_stringshare_add(buf); >> + if (!ecore_file_exists(trash_dir)) ecore_file_mkdir(trash_dir); >> + >> + /* Create required 'info' and 'files' subdirs if needed */ >> + snprintf(buf, sizeof(buf), "%s/files", trash_dir); >> + if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); >> + snprintf(buf, sizeof(buf), "%s/info", trash_dir); >> + if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); > > Maybe use mkpath? > > Sebastian > Will do, Thanks :) dh - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Enlightenment CVS wrote: > Log Message: > Add FDO spec compliant trash implimentation. > Not actually called from anywhere just yet, committing for potential review. > + /* Check that 'home trash' exists, create if not */ > + snprintf(buf, sizeof(buf), "%s/Trash", efreet_data_home_get()); > + trash_dir = evas_stringshare_add(buf); > + if (!ecore_file_exists(trash_dir)) ecore_file_mkdir(trash_dir); > + > + /* Create required 'info' and 'files' subdirs if needed */ > + snprintf(buf, sizeof(buf), "%s/files", trash_dir); > + if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); > + snprintf(buf, sizeof(buf), "%s/info", trash_dir); > + if (!ecore_file_exists(buf)) ecore_file_mkdir(buf); Maybe use mkpath? Sebastian - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Tue, Jul 10, 2007 at 07:15:35AM -0400, Enlightenment CVS wrote: > Enlightenment CVS committal > > Author : devilhorns > Log Message: > Give menu apps dialogs (favs, ibar, etc, etc) ability to move items up/down > in the list. Allows user to "customize" their order in the menus, as per > ManoWarrior feature request. > > Added some API to ilist widget to help with this. iList can now do > append_relative, prepend, and prepend_relative. > Thanks. This had been sorely needed for a while. Brian - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On 7/9/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> @@ -534,12 +535,14 @@
> if (menu->entries)
> {
> Efreet_Menu *entry;
> -
> +
shouldn't we avoid trailing white spaces and these kind of changes?
Both emacs and vi have highlights for trailing white spaces, I guess
that other editors also do. I have my emacs set to display them with
red background, really ugly so I never leave those :-)
--
Gustavo Sverzut Barbieri
--
Jabber: [EMAIL PROTECTED]
MSN: [EMAIL PROTECTED]
ICQ#: 17249123
Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On 4/19/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e/src/bin > > > Modified Files: > e_entry.c > > > Log Message: > Add right-click copy/paste popup menu to e_entry for Codewarrior :) > Pure pwnage! (= Thanks Chris. -- Hisham Mardam Bey http://hisham.cc/ +9613609386 Codito Ergo Sum (I Code Therefore I Am) - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Stafford Horne wrote: > On Thu, 30 Nov 2006 12:20:37 -0500 (EST) > Enlightenment CVS <[EMAIL PROTECTED]> wrote: > >> Enlightenment CVS committal >> >> Author : devilhorns >> Project : e17 >> Module : apps/e >> >> Dir : e17/apps/e/src/bin >> >> >> Modified Files: >> e_int_config_imc.c >> >> >> Log Message: >> Fix segfault in new input config dialog. >> Fix potential segfault with a printf. >> Some formatting. > > Sorry, May I dare say that this is not complete? > Shorne, Yea, I saw the commit about Advanced not being done but when I tried to launch the new dialog with just Basic mode, it gave me a segfault...hence the patch/commit so that it wouldn't die on users. Cheers, dh - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Thu, 30 Nov 2006 12:20:37 -0500 (EST) Enlightenment CVS <[EMAIL PROTECTED]> wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e/src/bin > > > Modified Files: > e_int_config_imc.c > > > Log Message: > Fix segfault in new input config dialog. > Fix potential segfault with a printf. > Some formatting. Sorry, May I dare say that this is not complete? -- Stafford M. Horne Senior Engineer 高级工程师 SurfControl plc 美讯智科技 Peoples Republic of China, Beijing 中华人民共和国， 北京 Mobile: +86 13611014044 手机：＋86 13611014044 (Website) http://blog.shorne-pla.net/ (网站) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Thu, 30 Nov 2006 23:59:32 +0900 Carsten Haitzler (The Rasterman) <[EMAIL PROTECTED]> wrote: > On Thu, 30 Nov 2006 04:03:21 -0500 Christopher Michael > <[EMAIL PROTECTED]> babbled: > > > P.S. - Happy Birthday Raster !! :) (belated tho it may be) Hope you > > had a good one. > > thanks man... another foot into the old mens club for me Welcome to the old men's club, let me get you a drink. B-) signature.asc Description: PGP signature - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Thu, 30 Nov 2006 04:03:21 -0500 Christopher Michael <[EMAIL PROTECTED]> babbled: > Carsten Haitzler (The Rasterman) wrote: > > On Wed, 29 Nov 2006 15:40:27 -0500 (EST) Enlightenment CVS > > <[EMAIL PROTECTED]> babbled: > > > > any reason NOT to have multiple? as we may change multiple windows' > > properties? the default config dialogs want only 1 as u are editing the > > same thing - here we need to check if there is a dialog FOR that border > > already up - not 1 dialog total :) > > > >> Enlightenment CVS committal > >> > >> Author : devilhorns > >> Project : e17 > >> Module : apps/e > >> > >> Dir : e17/apps/e/src/bin > >> > >> > >> Modified Files: > >>e_int_config_borders.c > >> > >> > >> Log Message: > >> Use the config dialog find functions to avoid having 2 border dialogs open > >> for the same window. > <--- snip ---> > > After sleeping on it, I totally agree :) I'll look into > modifying/creating config dialog search functions. Basically, I believe > we need something that will search the config dialog collection for a > given class (which we do have already) and return that config dialog so > we can compare cfd->border to the current one being edited. Will look > into today :) well you can have bd->border_dialog that does just that for you - explicitly - if bd->border_dialog != NULL then raise/show that dialog - otherwise, create new (and on delete - set bd->... to NULL) > P.S. - Happy Birthday Raster !! :) (belated tho it may be) Hope you had > a good one. thanks man... another foot into the old mens club for me -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Carsten Haitzler (The Rasterman) wrote: > On Wed, 29 Nov 2006 15:40:27 -0500 (EST) Enlightenment CVS > <[EMAIL PROTECTED]> babbled: > > any reason NOT to have multiple? as we may change multiple windows' > properties? > the default config dialogs want only 1 as u are editing the same thing - here > we need to check if there is a dialog FOR that border already up - not 1 > dialog > total :) > >> Enlightenment CVS committal >> >> Author : devilhorns >> Project : e17 >> Module : apps/e >> >> Dir : e17/apps/e/src/bin >> >> >> Modified Files: >> e_int_config_borders.c >> >> >> Log Message: >> Use the config dialog find functions to avoid having 2 border dialogs open >> for the same window. <--- snip ---> After sleeping on it, I totally agree :) I'll look into modifying/creating config dialog search functions. Basically, I believe we need something that will search the config dialog collection for a given class (which we do have already) and return that config dialog so we can compare cfd->border to the current one being edited. Will look into today :) P.S. - Happy Birthday Raster !! :) (belated tho it may be) Hope you had a good one. Cheers, dh - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Wed, 29 Nov 2006 15:40:27 -0500 (EST) Enlightenment CVS
<[EMAIL PROTECTED]> babbled:
any reason NOT to have multiple? as we may change multiple windows' properties?
the default config dialogs want only 1 as u are editing the same thing - here
we need to check if there is a dialog FOR that border already up - not 1 dialog
total :)
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/bin
>
>
> Modified Files:
> e_int_config_borders.c
>
>
> Log Message:
> Use the config dialog find functions to avoid having 2 border dialogs open
> for the same window.
>
> ===
> RCS file: /cvs/e/e17/apps/e/src/bin/e_int_config_borders.c,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -3 -r1.6 -r1.7
> --- e_int_config_borders.c29 Nov 2006 19:14:54 - 1.6
> +++ e_int_config_borders.c29 Nov 2006 20:40:27 - 1.7
> @@ -22,7 +22,8 @@
> {
> E_Config_Dialog *cfd;
> E_Config_Dialog_View *v;
> -
> +
> + if (e_config_dialog_find("E", "_config_border_style_dialog")) return NULL;
> v = _config_view_new();
> if (!v) return NULL;
> cfd = e_config_dialog_new(con, _("Default Border Style"),
> @@ -36,7 +37,8 @@
> {
> E_Config_Dialog *cfd;
> E_Config_Dialog_View *v;
> -
> +
> + if (e_config_dialog_find("E", "_config_border_border_style_dialog"))
> return NULL; v = _config_view_new();
> if (!v) return NULL;
> cfd = e_config_dialog_new(bd->zone->container,
>
>
>
> -
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> ___
> enlightenment-cvs mailing list
> enlightenment-cvs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 27 Nov 2006 11:20:06 -0600 Brian Mattern <[EMAIL PROTECTED]> babbled: > On Tue, Nov 28, 2006 at 12:57:20AM +0800, Stafford Horne wrote: > > On Mon, 27 Nov 2006 08:34:57 -0500 > > Christopher Michael <[EMAIL PROTECTED]> wrote: > > > > > Stafford Horne wrote: > > > > On Mon, 27 Nov 2006 07:57:03 +0100 > > > > Anders Troback <[EMAIL PROTECTED]> wrote: > > > > > > > >> Just want to say: Good idea :-) > > > > > > > > I now have to go through all categories to find what I am looking for. > > > > Its probably just me though. I don't mind much because I only look > > > > at... never. > > > > > > > As opposed to scrolling an exceedingly, ever-increasing, long list of > > > the same options? At least this way, things are broken up into their > > > proper categories, and for most people, should be easier to find. IE: I > > > wanna change how the bg looks...hmm, Appearance maybe? :) > > > > You are right, most categories are good already, but Misc and Advanced are > > too vague for most people. IE: I want to change language. Is it in > > Appearance? NO, is it in Extensions? No! advanced maybe? Not that one. Ill > > just go to Misc... There is is :) > > > > Well, I actually put language it into misc in the first place. I just > > suggest that some one _smart_ (with solving usability problems) > > re-shuffle/add/remove categories to make a bit more sense. > > > I agree that we may need to reorganize a bit. But, no organization will > be totally fool-proof. Another option to ease finding the dialogs would > be to keep a list of strings / keywords in the dialog and add a search > box. absolutely. search... :) > rephorm > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Tue, 28 Nov 2006 00:57:20 +0800 Stafford Horne <[EMAIL PROTECTED]> babbled: > On Mon, 27 Nov 2006 08:34:57 -0500 > Christopher Michael <[EMAIL PROTECTED]> wrote: > > > Stafford Horne wrote: > > > On Mon, 27 Nov 2006 07:57:03 +0100 > > > Anders Troback <[EMAIL PROTECTED]> wrote: > > > > > >> Just want to say: Good idea :-) > > > > > > I now have to go through all categories to find what I am looking for. > > > Its probably just me though. I don't mind much because I only look at... > > > never. > > > > > As opposed to scrolling an exceedingly, ever-increasing, long list of > > the same options? At least this way, things are broken up into their > > proper categories, and for most people, should be easier to find. IE: I > > wanna change how the bg looks...hmm, Appearance maybe? :) > > You are right, most categories are good already, but Misc and Advanced are > too vague for most people. IE: I want to change language. Is it in > Appearance? NO, is it in Extensions? No! advanced maybe? Not that one. Ill > just go to Misc... There is is :) > > Well, I actually put language it into misc in the first place. I just > suggest that some one _smart_ (with solving usability problems) > re-shuffle/add/remove categories to make a bit more sense. I definitely agree that there needs to be reshuffling to make this easier/more logical/obvious etc. language probably belongs in a category of its own as we want a imc installer/selector too later so there likely will be 2 language related dialogs. > -Stafford > > dh > > > > > -- > Stafford M. Horne > Senior Engineer 高级工程师 > SurfControl plc 美讯智科技 > Peoples Republic of China, Beijing 中华人民共和国， 北京 > Mobile: +86 13611014044 手机：＋86 13611014044 > > (Website) http://blog.shorne-pla.net/ (网站) > -Take > Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay > panel and you'll get the chance to share youropinions on IT & business topics > through brief surveys - and earn > cashhttp://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___enlightenment-devel > mailing > [EMAIL PROTECTED]://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Tue, Nov 28, 2006 at 12:57:20AM +0800, Stafford Horne wrote: > On Mon, 27 Nov 2006 08:34:57 -0500 > Christopher Michael <[EMAIL PROTECTED]> wrote: > > > Stafford Horne wrote: > > > On Mon, 27 Nov 2006 07:57:03 +0100 > > > Anders Troback <[EMAIL PROTECTED]> wrote: > > > > > >> Just want to say: Good idea :-) > > > > > > I now have to go through all categories to find what I am looking for. > > > Its probably just me though. I don't mind much because I only look at... > > > never. > > > > > As opposed to scrolling an exceedingly, ever-increasing, long list of > > the same options? At least this way, things are broken up into their > > proper categories, and for most people, should be easier to find. IE: I > > wanna change how the bg looks...hmm, Appearance maybe? :) > > You are right, most categories are good already, but Misc and Advanced are > too vague for most people. IE: I want to change language. Is it in > Appearance? NO, is it in Extensions? No! advanced maybe? Not that one. Ill > just go to Misc... There is is :) > > Well, I actually put language it into misc in the first place. I just > suggest that some one _smart_ (with solving usability problems) > re-shuffle/add/remove categories to make a bit more sense. I agree that we may need to reorganize a bit. But, no organization will be totally fool-proof. Another option to ease finding the dialogs would be to keep a list of strings / keywords in the dialog and add a search box. rephorm - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 27 Nov 2006 08:34:57 -0500 Christopher Michael <[EMAIL PROTECTED]> wrote: > Stafford Horne wrote: > > On Mon, 27 Nov 2006 07:57:03 +0100 > > Anders Troback <[EMAIL PROTECTED]> wrote: > > > >> Just want to say: Good idea :-) > > > > I now have to go through all categories to find what I am looking for. Its > > probably just me though. I don't mind much because I only look at... never. > > > As opposed to scrolling an exceedingly, ever-increasing, long list of > the same options? At least this way, things are broken up into their > proper categories, and for most people, should be easier to find. IE: I > wanna change how the bg looks...hmm, Appearance maybe? :) You are right, most categories are good already, but Misc and Advanced are too vague for most people. IE: I want to change language. Is it in Appearance? NO, is it in Extensions? No! advanced maybe? Not that one. Ill just go to Misc... There is is :) Well, I actually put language it into misc in the first place. I just suggest that some one _smart_ (with solving usability problems) re-shuffle/add/remove categories to make a bit more sense. -Stafford > dh > -- Stafford M. Horne Senior Engineer 高级工程师 SurfControl plc 美讯智科技 Peoples Republic of China, Beijing 中华人民共和国， 北京 Mobile: +86 13611014044 手机：＋86 13611014044 (Website) http://blog.shorne-pla.net/ (网站) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 27 Nov 2006 08:34:57 -0500 Christopher Michael <[EMAIL PROTECTED]> wrote: > Stafford Horne wrote: > > On Mon, 27 Nov 2006 07:57:03 +0100 > > Anders Troback <[EMAIL PROTECTED]> wrote: > > > >> Just want to say: Good idea :-) > > > > I now have to go through all categories to find what I am looking > > for. Its probably just me though. I don't mind much because I only > > look at... never. > > > As opposed to scrolling an exceedingly, ever-increasing, long list of > the same options? At least this way, things are broken up into their > proper categories, and for most people, should be easier to find. IE: > I wanna change how the bg looks...hmm, Appearance maybe? :) > How about a "All" category or a advance button with all...?! -- Microsoft is not the answer. Microsoft is the question. And 'No' is the answer! Anders Trobäck http://www.troback.com - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Stafford Horne wrote: > On Mon, 27 Nov 2006 07:57:03 +0100 > Anders Troback <[EMAIL PROTECTED]> wrote: > >> Just want to say: Good idea :-) > > I now have to go through all categories to find what I am looking for. Its > probably just me though. I don't mind much because I only look at... never. > As opposed to scrolling an exceedingly, ever-increasing, long list of the same options? At least this way, things are broken up into their proper categories, and for most people, should be easier to find. IE: I wanna change how the bg looks...hmm, Appearance maybe? :) dh - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 27 Nov 2006 07:57:03 +0100
Anders Troback <[EMAIL PROTECTED]> wrote:
> Just want to say: Good idea :-)
I now have to go through all categories to find what I am looking for. Its
probably just me though. I don't mind much because I only look at... never.
> \\troback
>
> On Sun, 26 Nov 2006 11:10:49 -0500 (EST)
> Enlightenment CVS <[EMAIL PROTECTED]> wrote:
>
> > Enlightenment CVS committal
> >
> > Author : devilhorns
> > Project : e17
> > Module : apps/e
> >
> > Dir : e17/apps/e/src/bin
> >
> >
> > Modified Files:
> > e_configure.h e_configure.c
> >
> >
> > Log Message:
> > Redo Config Panel as per conversation with raster, using 2 lists now.
> >
> > ===
> > RCS file: /cvs/e/e17/apps/e/src/bin/e_configure.h,v
> > retrieving revision 1.6
> > retrieving revision 1.7
> > diff -u -3 -r1.6 -r1.7
> > --- e_configure.h 27 Mar 2006 14:46:26 - 1.6
> > +++ e_configure.h 26 Nov 2006 16:10:48 - 1.7
> > @@ -1,6 +1,10 @@
> > #ifdef E_TYPEDEFS
> >
> > typedef struct _E_Configure E_Configure;
> > +typedef struct _E_Configure_CB E_Configure_CB;
> > +
> > +typedef struct _E_Configure_Category E_Configure_Category;
> > +typedef struct _E_Configure_Item E_Configure_Item;
> >
> > #else
> > #ifndef E_CONFIGURE_H
> > @@ -8,23 +12,46 @@
> >
> > #define E_CONFIGURE_TYPE 0xE0b01014
> >
> > -struct _E_Configure
> > +struct _E_Configure
> > {
> > - E_Object e_obj_inherit;
> > -
> > + E_Object e_obj_inherit;
> > +
> > E_Container *con;
> > - E_Win *win;
> > - Evas*evas;
> > + E_Win *win;
> > + Evas *evas;
> > Evas_Object *edje;
> > - Evas_Object *ilist;
> > +
> > + Evas_Object *o_list;
> > + Evas_Object *cat_list;
> > + Evas_Object *item_list;
> > Evas_Object *close;
> >
> > - Evas_List *cblist;
> > + Evas_List *cats;
> > +};
> > +
> > +struct _E_Configure_CB
> > +{
> > + E_Configure *eco;
> > + E_Config_Dialog *(*func) (E_Container *con);
> > +};
> > +
> > +struct _E_Configure_Category
> > +{
> > + E_Configure *eco;
> > + const char *label;
> > +
> > + Evas_List *items;
> > +};
> > +
> > +struct _E_Configure_Item
> > +{
> > + E_Configure_CB *cb;
> > +
> > + const char *label;
> > + const char *icon;
> > };
> >
> > EAPI E_Configure *e_configure_show(E_Container *con);
> > -EAPI void e_configure_standard_item_add(E_Configure *eco,
> > char *icon, char *label, E_Config_Dialog *(*func) (E_Container
> > *con)); -EAPI void e_configure_header_item_add(E_Configure
> > *eco, char *icon, char *label);
> > -
> > +
> > #endif
> > #endif
> > ===
> > RCS file: /cvs/e/e17/apps/e/src/bin/e_configure.c,v
> > retrieving revision 1.72
> > retrieving revision 1.73
> > diff -u -3 -r1.72 -r1.73
> > --- e_configure.c 16 Nov 2006 17:44:20 - 1.72
> > +++ e_configure.c 26 Nov 2006 16:10:48 - 1.73
> > @@ -1,242 +1,318 @@
> > #include "e.h"
> >
> > -typedef struct _E_Configure_CB E_Configure_CB;
> > -
> > -struct _E_Configure_CB
> > -{
> > - E_Configure *eco;
> > - E_Config_Dialog *(*func) (E_Container *con);
> > -};
> > -
> > -static void _e_configure_free(E_Configure *app);
> > +static void _e_configure_free(E_Configure *eco);
> > static void _e_configure_cb_del_req(E_Win *win);
> > static void _e_configure_cb_resize(E_Win *win);
> > -static void _e_configure_cb_standard(void *data);
> > static void _e_configure_cb_close(void *data, void *data2);
> > +static E_Configure_Category *_e_configure_category_add(E_Configure
> > *eco, char *label, char *icon); +static void
> > _e_configure_category_cb(void *data); +static E_Configure_Item
> > *_e_configure_item_add(E_Configure_Category *cat, char *label, char
> > *icon, E_Config_Dialog *(*func) (E_Container *con)); +static void
> > _e_configure_item_cb(void *data); static E_Configure *_e_configure =
> > NULL;
> > EAPI E_Configure *
> > -e_configure_show(E_Container *con)
> > +e_configure_show(E_Container *con)
> > {
> > E_Configure *eco;
> > + E_Configure_Category *cat;
> > E_Manager *man;
> > Evas_Coord ew, eh, mw, mh;
> > -
> > - if (_e_configure)
> > +
> > + if (_e_configure)
> > {
> > - E_Zone *z;
> > + E_Zone *z, *z2;
> >
> > eco = _e_configure;
> > z = e_util_zone_current_get(e_manager_current_get());
> > - e_border_uniconify(eco->win->border);
> > + z2 = eco->win->border->zone;
> > e_win_show(eco->win);
> > e_win_raise(eco->win);
> > - if (z->container == eco->win->border->zone->container)
> > + if (z->container == z2->container)
> > e_border_desk_set(eco->win->border, e_desk_current_get(z));
> > - else
> > + else
> > {
> > if (!eco->win->border->sticky)
> >e_desk_show(eco->win->border->desk);
> > -
> > ecore_x_pointer_warp(eco->win->border->zone->contai
Re: [E-devel] E CVS: apps/e devilhorns
Just want to say: Good idea :-)
\\troback
On Sun, 26 Nov 2006 11:10:49 -0500 (EST)
Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/bin
>
>
> Modified Files:
> e_configure.h e_configure.c
>
>
> Log Message:
> Redo Config Panel as per conversation with raster, using 2 lists now.
>
> ===
> RCS file: /cvs/e/e17/apps/e/src/bin/e_configure.h,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -u -3 -r1.6 -r1.7
> --- e_configure.h 27 Mar 2006 14:46:26 - 1.6
> +++ e_configure.h 26 Nov 2006 16:10:48 - 1.7
> @@ -1,6 +1,10 @@
> #ifdef E_TYPEDEFS
>
> typedef struct _E_Configure E_Configure;
> +typedef struct _E_Configure_CB E_Configure_CB;
> +
> +typedef struct _E_Configure_Category E_Configure_Category;
> +typedef struct _E_Configure_Item E_Configure_Item;
>
> #else
> #ifndef E_CONFIGURE_H
> @@ -8,23 +12,46 @@
>
> #define E_CONFIGURE_TYPE 0xE0b01014
>
> -struct _E_Configure
> +struct _E_Configure
> {
> - E_Object e_obj_inherit;
> -
> + E_Object e_obj_inherit;
> +
> E_Container *con;
> - E_Win *win;
> - Evas*evas;
> + E_Win *win;
> + Evas *evas;
> Evas_Object *edje;
> - Evas_Object *ilist;
> +
> + Evas_Object *o_list;
> + Evas_Object *cat_list;
> + Evas_Object *item_list;
> Evas_Object *close;
>
> - Evas_List *cblist;
> + Evas_List *cats;
> +};
> +
> +struct _E_Configure_CB
> +{
> + E_Configure *eco;
> + E_Config_Dialog *(*func) (E_Container *con);
> +};
> +
> +struct _E_Configure_Category
> +{
> + E_Configure *eco;
> + const char *label;
> +
> + Evas_List *items;
> +};
> +
> +struct _E_Configure_Item
> +{
> + E_Configure_CB *cb;
> +
> + const char *label;
> + const char *icon;
> };
>
> EAPI E_Configure *e_configure_show(E_Container *con);
> -EAPI void e_configure_standard_item_add(E_Configure *eco,
> char *icon, char *label, E_Config_Dialog *(*func) (E_Container
> *con)); -EAPI void e_configure_header_item_add(E_Configure
> *eco, char *icon, char *label);
> -
> +
> #endif
> #endif
> ===
> RCS file: /cvs/e/e17/apps/e/src/bin/e_configure.c,v
> retrieving revision 1.72
> retrieving revision 1.73
> diff -u -3 -r1.72 -r1.73
> --- e_configure.c 16 Nov 2006 17:44:20 - 1.72
> +++ e_configure.c 26 Nov 2006 16:10:48 - 1.73
> @@ -1,242 +1,318 @@
> #include "e.h"
>
> -typedef struct _E_Configure_CB E_Configure_CB;
> -
> -struct _E_Configure_CB
> -{
> - E_Configure *eco;
> - E_Config_Dialog *(*func) (E_Container *con);
> -};
> -
> -static void _e_configure_free(E_Configure *app);
> +static void _e_configure_free(E_Configure *eco);
> static void _e_configure_cb_del_req(E_Win *win);
> static void _e_configure_cb_resize(E_Win *win);
> -static void _e_configure_cb_standard(void *data);
> static void _e_configure_cb_close(void *data, void *data2);
> +static E_Configure_Category *_e_configure_category_add(E_Configure
> *eco, char *label, char *icon); +static void
> _e_configure_category_cb(void *data); +static E_Configure_Item
> *_e_configure_item_add(E_Configure_Category *cat, char *label, char
> *icon, E_Config_Dialog *(*func) (E_Container *con)); +static void
> _e_configure_item_cb(void *data); static E_Configure *_e_configure =
> NULL;
> EAPI E_Configure *
> -e_configure_show(E_Container *con)
> +e_configure_show(E_Container *con)
> {
> E_Configure *eco;
> + E_Configure_Category *cat;
> E_Manager *man;
> Evas_Coord ew, eh, mw, mh;
> -
> - if (_e_configure)
> +
> + if (_e_configure)
> {
> - E_Zone *z;
> + E_Zone *z, *z2;
>
> eco = _e_configure;
> z = e_util_zone_current_get(e_manager_current_get());
> - e_border_uniconify(eco->win->border);
> + z2 = eco->win->border->zone;
> e_win_show(eco->win);
> e_win_raise(eco->win);
> - if (z->container == eco->win->border->zone->container)
> + if (z->container == z2->container)
> e_border_desk_set(eco->win->border, e_desk_current_get(z));
> - else
> + else
> {
>if (!eco->win->border->sticky)
> e_desk_show(eco->win->border->desk);
> -
> ecore_x_pointer_warp(eco->win->border->zone->container->win,
> - eco->win->border->zone->x +
> (eco->win->border->zone->w / 2),
> - eco->win->border->zone->y +
> (eco->win->border->zone->h / 2));
> + ecore_x_pointer_warp(z2->container->win,
> + z2->x + (z2->w / 2), z2->y +
> (z2->h / 2)); }
> e_border_unshade(eco->win->border, E_DIRECTION_DOWN);
> return NULL;
> }
>
> - if (!con)
> + if (!con)
> {
> man = e_manager_curre
Re: [E-devel] E CVS: apps/e devilhorns
Nathan Ingersoll wrote: > On 10/5/06, Christopher Michael <[EMAIL PROTECTED]> wrote: >> Allowing themes to expand the list is on my TODO for this. Basically, I >> was thinking that the config dialog would list all the "standardized" >> color classes, as it does now, then at the bottom of the list, have it >> show any "extra" color classes that the theme supports, which would >> include module color classes. >> >> I'm completely open to input on this, and now is the time as the dialog >> is in it's infancy. > > Originally, the idea behind the color classes was not to provide an > exhaustive directory of parts that can have their colors overridden. > It was more that you would provide a limited set of classes so the > user can easily set the color scheme for their whole environment. > Maybe the better solution is hierarchical color classes, so the basic > list would affect most elements, but individual parts could be changed > in advanced mode. > Ok, I can buy that :) Simple enough todo in the Basic Dialog. dh - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On 10/5/06, Christopher Michael <[EMAIL PROTECTED]> wrote: > > Allowing themes to expand the list is on my TODO for this. Basically, I > was thinking that the config dialog would list all the "standardized" > color classes, as it does now, then at the bottom of the list, have it > show any "extra" color classes that the theme supports, which would > include module color classes. > > I'm completely open to input on this, and now is the time as the dialog > is in it's infancy. Originally, the idea behind the color classes was not to provide an exhaustive directory of parts that can have their colors overridden. It was more that you would provide a limited set of classes so the user can easily set the color scheme for their whole environment. Maybe the better solution is hierarchical color classes, so the basic list would affect most elements, but individual parts could be changed in advanced mode. - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Stafford Horne wrote: > > Consider class names like > mod_label > mod_title > mod_text > The main reason for using a battery_label, temperature_label (etc etc) was that so battery could have a different color class from temperature. If we went with some generic classes, which I'm not totally against, then that would mean all module labels would have the same color, as opposed to using blue on the battery and red on temperature, etc, etc. Allowing themes to expand the list is on my TODO for this. Basically, I was thinking that the config dialog would list all the "standardized" color classes, as it does now, then at the bottom of the list, have it show any "extra" color classes that the theme supports, which would include module color classes. I'm completely open to input on this, and now is the time as the dialog is in it's infancy. dh - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Devilhorns,
I see that you are using class names which are very specific like cpufreq_label
and battery_label. This will cause an issue for third party modules not being
able to use color classes. I think its best that class names be generic to
modules as a whole and not specific functions.
Consider class names like
mod_label
mod_title
mod_text
Most of the labels look good. Another option would be for enabling third party
modules to extend the available color/font class lists dynamically.
Thats just my opinion though,
-Stafford
On Thu, 5 Oct 2006 22:25:57 -0400 (EDT)
Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/data/themes
>
>
> Modified Files:
> default_battery.edc default_cpufreq.edc default_entry.edc
> default_error.edc default_ibox.edc default_radio.edc
> default_slider.edc default_temperature.edc
> default_theme_about.edc
>
>
> Log Message:
> Added more color classes.
>
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_battery.edc,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -3 -r1.12 -r1.13
> --- default_battery.edc 28 Sep 2006 06:07:15 - 1.12
> +++ default_battery.edc 6 Oct 2006 02:25:57 - 1.13
> @@ -159,6 +159,7 @@
> color: 255 255 255 255;
> color2: 0 0 0 128;
> color3: 0 0 0 32;
> + color_class: "battery_label";
> text {
> text: "100%";
> font: "Edje-Vera-Bold";
> @@ -189,6 +190,7 @@
> color: 255 255 255 255;
> color2: 0 0 0 128;
> color3: 0 0 0 32;
> + color_class: "battery_label";
> text {
> text: "00:00";
> font: "Edje-Vera-Bold";
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_cpufreq.edc,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -u -3 -r1.8 -r1.9
> --- default_cpufreq.edc 28 Sep 2006 06:07:15 - 1.8
> +++ default_cpufreq.edc 6 Oct 2006 02:25:57 - 1.9
> @@ -304,6 +304,7 @@
> color: 255 255 255 255;
> color2: 0 0 0 128;
> color3: 0 0 0 32;
> + color_class: "cpufreq_label";
> text {
> text: "??? Ghz";
> font: "Edje-Vera-Bold";
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_entry.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_entry.edc 23 Aug 2006 08:53:25 - 1.13
> +++ default_entry.edc 6 Oct 2006 02:25:57 - 1.14
> @@ -86,6 +86,7 @@
>description {
> state: "default" 0.0;
> color: 0 0 0 255;
> + color_class: "entry_text";
> text {
> text: "Entry";
> font: "Edje-Vera";
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_error.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_error.edc 23 Aug 2006 03:39:01 - 1.13
> +++ default_error.edc 6 Oct 2006 02:25:57 - 1.14
> @@ -122,6 +122,7 @@
> }
> color:0 0 0 255;
> color3: 255 255 255 128;
> + color_class: "error_title";
> text {
> text: "Title";
> font: "Edje-Vera-Bold";
> @@ -213,6 +214,7 @@
> }
> color:0 0 0 255;
> color3: 255 255 255 128;
> + color_class: "button_text";
> text {
> text: "OK";
> font: "Edje-Vera";
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_ibox.edc,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -3 -r1.4 -r1.5
> --- default_ibox.edc 23 Aug 2006 03:39:01 - 1.4
> +++ default_ibox.edc 6 Oct 2006 02:25:57 - 1.5
> @@ -212,6 +212,7 @@
> }
> color: 255 255 255 0;
> color3: 0 0 0 0;
> + color_class: "ibox_label";
> text {
> text: "Icon Name";
> font: "Edje-Vera-Bold";
> ===
> RCS file: /cvs/e/e17/apps/e/data/themes/default_radio.edc,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -3 -r1.13 -r1.14
> --- default_radio.edc 23 Aug 2006 03:39:01 - 1.13
> +++ default_radio.edc 6 Oct 2006 02:25:57 - 1.14
> @@ -81,6 +81,7 @@
> }
> color: 0 0 0 255;
> color3: 255 255 255 128;
> + color_class: "radio_text";
> text {
> text: "Radio Butto
Re: [E-devel] E CVS: apps/e devilhorns
This problem might be the same I had with the unsorted shelf list. Somewhere there is the assumption that the nth element in the shelf list has id n. Sebastian Enlightenment CVS wrote: > Enlightenment CVS committal > > Author : devilhorns > Project : e17 > Module : apps/e > > Dir : e17/apps/e > > > Modified Files: > TODO > > > Log Message: > Add shelf buggers to TODO. > > I will try to debug this later when I have more time. > > === > RCS file: /cvs/e/e17/apps/e/TODO,v > retrieving revision 1.375 > retrieving revision 1.376 > diff -u -3 -r1.375 -r1.376 > --- TODO 20 Jul 2006 13:36:23 - 1.375 > +++ TODO 23 Jul 2006 07:03:27 - 1.376 > @@ -37,6 +37,7 @@ > * BUG: in screen resolution change dialog the flip config is a pair of raidio >buttons. it should be a pair of checkboxes to turn that flip bit on or >off etc. etc. > +* BUG: Shelf Configuration is b0rked. With an existing e_config, changing > style on shelf 0 changes style on a different shelf. With a fresh e_config > and 2 shelves, changing Style for shelf 0 makes ibar go blank (no icons). All > seems related to shelf->id not getting set somewhere. > ]]] > > [[[ > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > ___ > enlightenment-cvs mailing list > enlightenment-cvs@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Tue, 4 Jul 2006 07:56:15 +0900 Carsten Haitzler (The Rasterman) <[EMAIL PROTECTED]> wrote: > On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] babbled: > > > On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > > > Carsten Haitzler (The Rasterman) wrote: > > > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > > > <[EMAIL PROTECTED]> babbled: > > > > > > > > What was the reasoning for this? why would one need to pass the > > > > path to an module icon explicitly? (if you want to do your own > > > > icon in a dialog for a different dialog you can always do the > > > > dialog by hand?) > > > > > > > > <-- snip --> > > > > > This was requested by Andy so that modules config dialogs could > > > show their icon in the border of their config dialogs. I think > > > consistency was his main goal and also so users can identify > > > easily what config dialog is for what module. > > > > > > If it is a problem I can roll it back and change the modules back > > > to previous way of showing the E icon on the border of the config > > > dialog. > > > > > > dh > > > > > > I *think* he meant that e already knows where the modules icon is, > > so you you shouldn't need to pass th path in. That is, it should > > just use the icon by default. > > that's kind of what i was thinking - but then you would need to pass > the module handle in - you need to pass something in at any rate so e > can figure it out. Void pointer called data, works everywhere else. B-) signature.asc Description: PGP signature Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Tue, 4 Jul 2006 06:55:47 +1000 David Seikel <[EMAIL PROTECTED]> babbled: > On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] wrote: > > > On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > > > Carsten Haitzler (The Rasterman) wrote: > > > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > > > <[EMAIL PROTECTED]> babbled: > > > > > > > > What was the reasoning for this? why would one need to pass the > > > > path to an module icon explicitly? (if you want to do your own > > > > icon in a dialog for a different dialog you can always do the > > > > dialog by hand?) > > > > > > > > <-- snip --> > > > > > This was requested by Andy so that modules config dialogs could show > > > their icon in the border of their config dialogs. I think > > > consistency was his main goal and also so users can identify easily > > > what config dialog is for what module. > > > > > > If it is a problem I can roll it back and change the modules back to > > > previous way of showing the E icon on the border of the config > > > dialog. > > > > > > dh > > > > > > I *think* he meant that e already knows where the modules icon is, so > > you you shouldn't need to pass th path in. That is, it should just > > use the icon by default. > > For e_config_dialog_new(), the only thing that it has to go by (if the > path is not passed in) is the E_Container, which has an E_Gadman in it. > I'm unsure if that is enough, isn't gadman going away? I'm not seeing > any where in there that will point to where the icon is, it only seems > to be in the E_Module. How to get there from here? you don't :) you need to pass it in... :) > While on the same subject, I'm not so sure that a gadcon can get access > to its E_Module if all it has is the E_Gadcon or E_Gadcon_Client, or > E_Gadcon_Client_Class. This makes it hard to get access to its own > icon in gadcon callbacks that only get one of those gadcon structs. I > suggest that the E_Gadcon structs have the relevant E_Module stored in > them. it can't. gadcon isn't JUST for modules. its entirely separate from modules. the fact that the only user of gadcon is modules is a separate matter :) > On the other hand, I'm not sure of all the gory internal details of the > module implementation that is hidden from the average module writer. > All I just said could be complete bollocks. > -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] babbled: > On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > > Carsten Haitzler (The Rasterman) wrote: > > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > > <[EMAIL PROTECTED]> babbled: > > > > > > What was the reasoning for this? why would one need to pass the path to an > > > module icon explicitly? (if you want to do your own icon in a dialog for a > > > different dialog you can always do the dialog by hand?) > > > > > <-- snip --> > > > This was requested by Andy so that modules config dialogs could show > > their icon in the border of their config dialogs. I think consistency > > was his main goal and also so users can identify easily what config > > dialog is for what module. > > > > If it is a problem I can roll it back and change the modules back to > > previous way of showing the E icon on the border of the config dialog. > > > > dh > > > I *think* he meant that e already knows where the modules icon is, so > you you shouldn't need to pass th path in. That is, it should just use the > icon by default. that's kind of what i was thinking - but then you would need to pass the module handle in - you need to pass something in at any rate so e can figure it out. -- - Codito, ergo sum - "I code, therefore I am" -- The Rasterman (Carsten Haitzler)[EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 03 Jul 2006 15:15:49 -0400 Christopher Michael <[EMAIL PROTECTED]>
babbled:
> Carsten Haitzler (The Rasterman) wrote:
> > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS
> > <[EMAIL PROTECTED]> babbled:
> >
> > What was the reasoning for this? why would one need to pass the path to an
> > module icon explicitly? (if you want to do your own icon in a dialog for a
> > different dialog you can always do the dialog by hand?)
> >
> >> Enlightenment CVS committal
> >>
> >> Author : devilhorns
> >> Project : e17
> >> Module : apps/e
> >>
> >> Dir : e17/apps/e/src/modules/temperature
> >>
> >>
> >> Modified Files:
> >>e_mod_config.c
> >>
> >>
> >> Log Message:
> >> As per HandyAndE request, this patch gives ability for modules config
> >> dialogs to show their icon in their config dialog by passing in the
> >> module_eap path to the config_dialog_new function as the icon parameter ie:
> >>
> >> e_config_dialog_new(con, module_name, eap_path, 0, v, data);
> >>
> >> Update E core modules to use this ability.
> >> Fix dropshadow config dialog to fit in 640x480.
> >>
> >> ===
> >> RCS file: /cvs/e/e17/apps/e/src/modules/temperature/e_mod_config.c,v
> >> retrieving revision 1.20
> >> retrieving revision 1.21
> >> diff -u -3 -r1.20 -r1.21
> >> --- e_mod_config.c 7 Jun 2006 08:34:10 - 1.20
> >> +++ e_mod_config.c 3 Jul 2006 07:35:44 - 1.21
> >> @@ -44,6 +44,7 @@
> >> {
> >> E_Config_Dialog *cfd;
> >> E_Config_Dialog_View *v;
> >> + char buf[4096];
> >>
> >> v = E_NEW(E_Config_Dialog_View, 1);
> >>
> >> @@ -53,9 +54,10 @@
> >> v->basic.create_widgets = _basic_create_widgets;
> >> v->advanced.apply_cfdata = _advanced_apply_data;
> >> v->advanced.create_widgets = _advanced_create_widgets;
> >> -
> >> +
> >> + snprintf(buf, sizeof(buf), "%s/module.eap", e_module_dir_get
> >> (temperature_config->module)); cfd = e_config_dialog_new
> >> (e_container_current_get(e_manager_current_get()),
> >> - _("Temperature Configuration"), NULL, 0, v,
> >> NULL);
> >> + _("Temperature Configuration"), buf, 0, v,
> >> NULL); temperature_config->config_dialog = cfd;
> >> }
> >>
> >>
> >>
> >>
> >> Using Tomcat but need to do more? Need to support web services, security?
> >> Get stuff done quickly with pre-integrated technology to make your job
> >> easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
> >> Geronimo
> >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >> ___ enlightenment-cvs mailing
> >> list enlightenment-cvs@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
> >>
> >
> >
> This was requested by Andy so that modules config dialogs could show
> their icon in the border of their config dialogs. I think consistency
> was his main goal and also so users can identify easily what config
> dialog is for what module.
ok - sure. :)
> If it is a problem I can roll it back and change the modules back to
> previous way of showing the E icon on the border of the config dialog.
no problem - just asking for the "why" :)
> dh
>
>
>
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
David Seikel wrote: > On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] wrote: > >> On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: >>> Carsten Haitzler (The Rasterman) wrote: On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS <[EMAIL PROTECTED]> babbled: What was the reasoning for this? why would one need to pass the path to an module icon explicitly? (if you want to do your own icon in a dialog for a different dialog you can always do the dialog by hand?) >> <-- snip --> >> >>> This was requested by Andy so that modules config dialogs could show >>> their icon in the border of their config dialogs. I think >>> consistency was his main goal and also so users can identify easily >>> what config dialog is for what module. >>> >>> If it is a problem I can roll it back and change the modules back to >>> previous way of showing the E icon on the border of the config >>> dialog. >>> >>> dh >> >> I *think* he meant that e already knows where the modules icon is, so >> you you shouldn't need to pass th path in. That is, it should just >> use the icon by default. > > For e_config_dialog_new(), the only thing that it has to go by (if the > path is not passed in) is the E_Container, which has an E_Gadman in it. > I'm unsure if that is enough, isn't gadman going away? I'm not seeing > any where in there that will point to where the icon is, it only seems > to be in the E_Module. How to get there from here? > > While on the same subject, I'm not so sure that a gadcon can get access > to its E_Module if all it has is the E_Gadcon or E_Gadcon_Client, or > E_Gadcon_Client_Class. This makes it hard to get access to its own > icon in gadcon callbacks that only get one of those gadcon structs. I > suggest that the E_Gadcon structs have the relevant E_Module stored in > them. > > On the other hand, I'm not sure of all the gory internal details of the > module implementation that is hidden from the average module writer. > All I just said could be complete bollocks. > > > > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel Yes, for config_dialog_new e does not know where the modules icon is as there is no reference to the module being passed in, nor accessible from any params passed in to it (aside from recent module.eap patch). > > > (if you want to do your own > > > icon in a dialog for a different dialog you can always do the > > > dialog by hand?) Yes, but then we lose the "nicety" of using e_config_dialog_new, having consistent config dialogs and the config handling routines that are supplied thus. Honestly, I don't see the problem here. If an author wants to use an E icon, they can just pass in "enlightenment/e" (any icon provided by the theme actually), or NULL, to get the original E logo. If they want to use the modules icon, simply provide a path to the module.eap. This allows us to still use e_config_dialog_new, getting the benefits of consistent config dialogs, and allows for the border icon to be set to something other than E icons. If they want something completely different then of course they are free to code their own dialogs. dh Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 3 Jul 2006 15:24:31 -0500 [EMAIL PROTECTED] wrote: > On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > > Carsten Haitzler (The Rasterman) wrote: > > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > > <[EMAIL PROTECTED]> babbled: > > > > > > What was the reasoning for this? why would one need to pass the > > > path to an module icon explicitly? (if you want to do your own > > > icon in a dialog for a different dialog you can always do the > > > dialog by hand?) > > > > > <-- snip --> > > > This was requested by Andy so that modules config dialogs could show > > their icon in the border of their config dialogs. I think > > consistency was his main goal and also so users can identify easily > > what config dialog is for what module. > > > > If it is a problem I can roll it back and change the modules back to > > previous way of showing the E icon on the border of the config > > dialog. > > > > dh > > > I *think* he meant that e already knows where the modules icon is, so > you you shouldn't need to pass th path in. That is, it should just > use the icon by default. For e_config_dialog_new(), the only thing that it has to go by (if the path is not passed in) is the E_Container, which has an E_Gadman in it. I'm unsure if that is enough, isn't gadman going away? I'm not seeing any where in there that will point to where the icon is, it only seems to be in the E_Module. How to get there from here? While on the same subject, I'm not so sure that a gadcon can get access to its E_Module if all it has is the E_Gadcon or E_Gadcon_Client, or E_Gadcon_Client_Class. This makes it hard to get access to its own icon in gadcon callbacks that only get one of those gadcon structs. I suggest that the E_Gadcon structs have the relevant E_Module stored in them. On the other hand, I'm not sure of all the gory internal details of the module implementation that is hidden from the average module writer. All I just said could be complete bollocks. signature.asc Description: PGP signature Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, Jul 03, 2006 at 03:15:49PM -0400, Christopher Michael wrote: > Carsten Haitzler (The Rasterman) wrote: > > On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS > > <[EMAIL PROTECTED]> babbled: > > > > What was the reasoning for this? why would one need to pass the path to an > > module icon explicitly? (if you want to do your own icon in a dialog for a > > different dialog you can always do the dialog by hand?) > > <-- snip --> > This was requested by Andy so that modules config dialogs could show > their icon in the border of their config dialogs. I think consistency > was his main goal and also so users can identify easily what config > dialog is for what module. > > If it is a problem I can roll it back and change the modules back to > previous way of showing the E icon on the border of the config dialog. > > dh I *think* he meant that e already knows where the modules icon is, so you you shouldn't need to pass th path in. That is, it should just use the icon by default. Brian Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Christopher Michael wrote:
> Carsten Haitzler (The Rasterman) wrote:
>> On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS
>> <[EMAIL PROTECTED]> babbled:
>>
>> What was the reasoning for this? why would one need to pass the path to an
>> module icon explicitly? (if you want to do your own icon in a dialog for a
>> different dialog you can always do the dialog by hand?)
>>
>>> Enlightenment CVS committal
>>>
>>> Author : devilhorns
>>> Project : e17
>>> Module : apps/e
>>>
>>> Dir : e17/apps/e/src/modules/temperature
>>>
>>>
>>> Modified Files:
>>> e_mod_config.c
>>>
>>>
>>> Log Message:
>>> As per HandyAndE request, this patch gives ability for modules config
>>> dialogs to show their icon in their config dialog by passing in the
>>> module_eap path to the config_dialog_new function as the icon parameter ie:
>>>
>>> e_config_dialog_new(con, module_name, eap_path, 0, v, data);
>>>
>>> Update E core modules to use this ability.
>>> Fix dropshadow config dialog to fit in 640x480.
>>>
>>> ===
>>> RCS file: /cvs/e/e17/apps/e/src/modules/temperature/e_mod_config.c,v
>>> retrieving revision 1.20
>>> retrieving revision 1.21
>>> diff -u -3 -r1.20 -r1.21
>>> --- e_mod_config.c 7 Jun 2006 08:34:10 - 1.20
>>> +++ e_mod_config.c 3 Jul 2006 07:35:44 - 1.21
>>> @@ -44,6 +44,7 @@
>>> {
>>> E_Config_Dialog *cfd;
>>> E_Config_Dialog_View *v;
>>> + char buf[4096];
>>>
>>> v = E_NEW(E_Config_Dialog_View, 1);
>>>
>>> @@ -53,9 +54,10 @@
>>> v->basic.create_widgets = _basic_create_widgets;
>>> v->advanced.apply_cfdata = _advanced_apply_data;
>>> v->advanced.create_widgets = _advanced_create_widgets;
>>> -
>>> +
>>> + snprintf(buf, sizeof(buf), "%s/module.eap", e_module_dir_get
>>> (temperature_config->module)); cfd = e_config_dialog_new
>>> (e_container_current_get(e_manager_current_get()),
>>> -_("Temperature Configuration"), NULL, 0, v,
>>> NULL);
>>> +_("Temperature Configuration"), buf, 0, v,
>>> NULL); temperature_config->config_dialog = cfd;
>>> }
>>>
>>>
>>>
>>>
>>> Using Tomcat but need to do more? Need to support web services, security?
>>> Get stuff done quickly with pre-integrated technology to make your job
>>> easier
>>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>>> ___
>>> enlightenment-cvs mailing list
>>> enlightenment-cvs@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>>>
>>
> This was requested by Andy so that modules config dialogs could show
> their icon in the border of their config dialogs. I think consistency
> was his main goal and also so users can identify easily what config
> dialog is for what module.
>
> If it is a problem I can roll it back and change the modules back to
> previous way of showing the E icon on the border of the config dialog.
>
> dh
>
>
>
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
It should also be noted that the previous method of passing
"enlightenment/e" or "enlightenment/configuration" still works. This is
akin to the recent work on the modules about dialogs.
dh
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
Carsten Haitzler (The Rasterman) wrote:
> On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS
> <[EMAIL PROTECTED]> babbled:
>
> What was the reasoning for this? why would one need to pass the path to an
> module icon explicitly? (if you want to do your own icon in a dialog for a
> different dialog you can always do the dialog by hand?)
>
>> Enlightenment CVS committal
>>
>> Author : devilhorns
>> Project : e17
>> Module : apps/e
>>
>> Dir : e17/apps/e/src/modules/temperature
>>
>>
>> Modified Files:
>> e_mod_config.c
>>
>>
>> Log Message:
>> As per HandyAndE request, this patch gives ability for modules config
>> dialogs to show their icon in their config dialog by passing in the
>> module_eap path to the config_dialog_new function as the icon parameter ie:
>>
>> e_config_dialog_new(con, module_name, eap_path, 0, v, data);
>>
>> Update E core modules to use this ability.
>> Fix dropshadow config dialog to fit in 640x480.
>>
>> ===
>> RCS file: /cvs/e/e17/apps/e/src/modules/temperature/e_mod_config.c,v
>> retrieving revision 1.20
>> retrieving revision 1.21
>> diff -u -3 -r1.20 -r1.21
>> --- e_mod_config.c 7 Jun 2006 08:34:10 - 1.20
>> +++ e_mod_config.c 3 Jul 2006 07:35:44 - 1.21
>> @@ -44,6 +44,7 @@
>> {
>> E_Config_Dialog *cfd;
>> E_Config_Dialog_View *v;
>> + char buf[4096];
>>
>> v = E_NEW(E_Config_Dialog_View, 1);
>>
>> @@ -53,9 +54,10 @@
>> v->basic.create_widgets = _basic_create_widgets;
>> v->advanced.apply_cfdata = _advanced_apply_data;
>> v->advanced.create_widgets = _advanced_create_widgets;
>> -
>> +
>> + snprintf(buf, sizeof(buf), "%s/module.eap", e_module_dir_get
>> (temperature_config->module)); cfd = e_config_dialog_new
>> (e_container_current_get(e_manager_current_get()),
>> - _("Temperature Configuration"), NULL, 0, v,
>> NULL);
>> + _("Temperature Configuration"), buf, 0, v,
>> NULL); temperature_config->config_dialog = cfd;
>> }
>>
>>
>>
>>
>> Using Tomcat but need to do more? Need to support web services, security?
>> Get stuff done quickly with pre-integrated technology to make your job easier
>> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
>> ___
>> enlightenment-cvs mailing list
>> enlightenment-cvs@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>>
>
>
This was requested by Andy so that modules config dialogs could show
their icon in the border of their config dialogs. I think consistency
was his main goal and also so users can identify easily what config
dialog is for what module.
If it is a problem I can roll it back and change the modules back to
previous way of showing the E icon on the border of the config dialog.
dh
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: apps/e devilhorns
On Mon, 3 Jul 2006 03:35:44 -0400 (EDT) Enlightenment CVS
<[EMAIL PROTECTED]> babbled:
What was the reasoning for this? why would one need to pass the path to an
module icon explicitly? (if you want to do your own icon in a dialog for a
different dialog you can always do the dialog by hand?)
> Enlightenment CVS committal
>
> Author : devilhorns
> Project : e17
> Module : apps/e
>
> Dir : e17/apps/e/src/modules/temperature
>
>
> Modified Files:
> e_mod_config.c
>
>
> Log Message:
> As per HandyAndE request, this patch gives ability for modules config
> dialogs to show their icon in their config dialog by passing in the
> module_eap path to the config_dialog_new function as the icon parameter ie:
>
> e_config_dialog_new(con, module_name, eap_path, 0, v, data);
>
> Update E core modules to use this ability.
> Fix dropshadow config dialog to fit in 640x480.
>
> ===
> RCS file: /cvs/e/e17/apps/e/src/modules/temperature/e_mod_config.c,v
> retrieving revision 1.20
> retrieving revision 1.21
> diff -u -3 -r1.20 -r1.21
> --- e_mod_config.c7 Jun 2006 08:34:10 - 1.20
> +++ e_mod_config.c3 Jul 2006 07:35:44 - 1.21
> @@ -44,6 +44,7 @@
> {
> E_Config_Dialog *cfd;
> E_Config_Dialog_View *v;
> + char buf[4096];
>
> v = E_NEW(E_Config_Dialog_View, 1);
>
> @@ -53,9 +54,10 @@
> v->basic.create_widgets = _basic_create_widgets;
> v->advanced.apply_cfdata = _advanced_apply_data;
> v->advanced.create_widgets = _advanced_create_widgets;
> -
> +
> + snprintf(buf, sizeof(buf), "%s/module.eap", e_module_dir_get
> (temperature_config->module)); cfd = e_config_dialog_new
> (e_container_current_get(e_manager_current_get()),
> - _("Temperature Configuration"), NULL, 0, v,
> NULL);
> + _("Temperature Configuration"), buf, 0, v,
> NULL); temperature_config->config_dialog = cfd;
> }
>
>
>
>
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> ___
> enlightenment-cvs mailing list
> enlightenment-cvs@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
>
--
- Codito, ergo sum - "I code, therefore I am" --
The Rasterman (Carsten Haitzler)[EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
