[Bug 435514] Review Request: lbrickbuster2 - Brickbuster arcade game

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435514


Stjepan Gros stjepan.g...@gmail.com changed:

   What|Removed |Added

 CC||stjepan.g...@gmail.com




--- Comment #8 from Stjepan Gros stjepan.g...@gmail.com  2009-08-28 02:00:38 
EDT ---
*** Bug 517466 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517466] Review Request: lbreakout2 - A breakout-style arcade game for Linux

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517466


Stjepan Gros stjepan.g...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE




--- Comment #7 from Stjepan Gros stjepan.g...@gmail.com  2009-08-28 02:00:38 
EDT ---
I just found out that lbreakout2 was rebranded as lbrickbuster2, so I'm closing
this ticket.

*** This bug has been marked as a duplicate of 435514 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 504261] Review Request: mailody - Simple KDE-based IMAP mail client

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504261


Sandro Mathys s...@sandro-mathys.ch changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #17 from Sandro Mathys s...@sandro-mathys.ch  2009-08-28 02:19:44 
EDT ---
Yep, it's been in rawhide for a while.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513239] Review Request: ansel - Full featured photo management application

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513239





--- Comment #7 from Andrew Colin Kissa and...@topdog.za.net  2009-08-28 
02:31:13 EDT ---

Prototype and prototype-UI are two different frameworks although prototype-UI
is based on prototype and script.aculo.us. Ansel uses the latter. As you can
see from the notice below in the code, its not production ready.

/*
Namespace: UI

  Introduction:
Prototype-UI is a library of user interface components based on the
Prototype framework.
Its aim is to easilly improve user experience in web applications.

It also provides utilities to help developers.

  Guideline:
- Prototype conventions are followed
- Everything should be unobstrusive
- All components are themable with CSS stylesheets, various themes are
provided

  Warning:
Prototype-UI is still under deep development, this release is targeted to
developers only.
All interfaces are subjects to changes, suggestions are welcome.

DO NOT use it in production for now.

  Authors:
- Sébastien Gruhier, http://www.xilinus.com
- Samuel Lebeau, http://gotfresh.info
*/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507830] Review Request: camorama - Gnome webcam viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830





--- Comment #2 from Dan Horák d...@danny.cz  2009-08-28 02:43:32 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
 ce04cd2d4abe265b19a365a515f225111dcfb969  camorama-0.19.tar.bz2
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (GPLv2+). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK GUI app with desktop file


- comments should be added about the status and purpose of the patches
- GConf schemas are installed during build, --disable-schemas or exported
environment variable is missing, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf for details

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 520048] New: Review Request: ibus-table-stroke5 - Stroke 5 table for IBus-Table.

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ibus-table-stroke5 - Stroke 5 table for IBus-Table.

https://bugzilla.redhat.com/show_bug.cgi?id=520048

   Summary: Review Request: ibus-table-stroke5 - Stroke 5 table
for IBus-Table.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: k...@kaio.me
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://kaio.fedorapeople.org/packaging/ibus-table-stroke5.spec
SRPM URL:
http://kaio.fedorapeople.org/packaging/ibus-table-stroke5-1.2.0.20090828-1.fc12.src.rpm
Description: Stroke 5 table for IBus-Table.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507830] Review Request: camorama - Gnome webcam viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830





--- Comment #3 from Hans de Goede hdego...@redhat.com  2009-08-28 03:29:28 
EDT ---
(In reply to comment #2)
 formal review is here, see the notes below:
 

Thanks!

 
 - comments should be added about the status and purpose of the patches
 - GConf schemas are installed during build, --disable-schemas or exported
 environment variable is missing, see
 https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf for details  

Both fixed:
Spec URL: http://people.atrpms.net/~hdegoede/camorama.spec
SRPM URL: http://people.atrpms.net/~hdegoede/camorama-0.19-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513239] Review Request: ansel - Full featured photo management application

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513239





--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2009-08-28 03:34:43 EDT ---
(In reply to comment #7)
 Prototype and prototype-UI are two different frameworks although prototype-UI
 is based on prototype and script.aculo.us.
Ups, I'm really don't understand it first. Thanks for clarification. But on
main site - http://www.prototype-ui.com/ now Release Candidate present. So, I
think it is ready for packaging if you willing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507615] Review request: Vemana2000-fonts Unicode compliant OpenType font

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507615


sandeep shedmake sshed...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #59 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info  
2009-08-28 03:52:52 EDT ---
(In reply to comment #55)
 (In reply to comment #54)
  At a minimum, you must rebuild those jars from source. Assuming that you 
  have
  the source and are able to do that, I think you are safe to simply delete 
  the
  bundled prebuilt jars during %prep, and do not need to make a custom 
  tarball.  
 
 Thanks for doing the final call. Completely fine with me and easier for
 packaging. ;-)  

Hm... I must rebuild it before make decision what it may be excluded?? In this
case, will be best solution include it also in package... Sic, it require
additional time in any case.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507830] Review Request: camorama - Gnome webcam viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830


Dan Horák d...@danny.cz changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Dan Horák d...@danny.cz  2009-08-28 03:44:40 EDT ---
All issues are fixed, this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507830] Review Request: camorama - Gnome webcam viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830


Hans de Goede hdego...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Hans de Goede hdego...@redhat.com  2009-08-28 04:28:26 
EDT ---
New Package CVS Request
===
Package Name:  camorama
Short Description: Gnome webcam viewer
Owners:jwrdegoede
Branches:  F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 502614] Review Request: stfl - STFL implements a curses-based widget set for text terminals

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502614





--- Comment #21 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp  2009-08-28 
04:46:20 EDT ---
Are the any reason why libstfl.so _itself_ is not linked against
libncursesw.so?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519695] Review Request: hunspell-shs - Shuswap hunspell dictionaries

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519695


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?




--- Comment #1 from Parag AN(पराग) panem...@gmail.com  2009-08-28 04:49:57 
EDT ---
will review this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517983] Review Request: 3proxy - Tiny but very powerful proxy

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517983





--- Comment #11 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 05:00:38 EDT ---
3proxy-0.6-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/3proxy-0.6-3.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517983] Review Request: 3proxy - Tiny but very powerful proxy

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517983





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 05:03:23 EDT ---
3proxy-0.6-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/3proxy-0.6-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517983] Review Request: 3proxy - Tiny but very powerful proxy

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517983





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 05:02:13 EDT ---
3proxy-0.6-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/3proxy-0.6-3.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #60 from Christian Krause c...@plauener.de  2009-08-28 05:42:32 
EDT ---
(In reply to comment #58)
 (In reply to comment #56)
 I don't think Tom implies to not have any java bits. Just don't use prebuilt
 ones as shipped. If the Makefile supports rebuilding the jars then perhaps all
 that is needed is to add some java build dependencies (and remove the java
 build targets to trigger the builds).

Yes and no. ;-)
1. The java client doesn't build out of the box just by by the global make.
There are some manual steps necessary. However, the pre-built binaries would be
installed when using make install. 

2. On the other hand, I was under the expression that we don't want to ship the
clients at all. If this is the case, we must make sure that they don't go into
the binary rpm. 
The safest way to achieve this is to delete them as early as possible in the
%prep section. If we decide later to add them, we can just remove the patch and
add probably some commands in the %build section to build them, too. 

(In reply to comment #59)
 (In reply to comment #55)
  (In reply to comment #54)
   At a minimum, you must rebuild those jars from source. Assuming that you 
   have
   the source and are able to do that, I think you are safe to simply delete 
   the
   bundled prebuilt jars during %prep, and do not need to make a custom 
   tarball.  
  
  Thanks for doing the final call. Completely fine with me and easier for
  packaging. ;-)  
 
 Hm... I must rebuild it before make decision what it may be excluded?? In this
 case, will be best solution include it also in package... Sic, it require
 additional time in any case.  

I think there is a misunderstanding. If we don't want to ship the java client,
we can just delete the binaries and we don't need to rebuild them. The only
minor request I had was to move the deletion from the %install section to the
%prep section to be on the safe side, that no any change in the build system of
upstream would leak them accidentely in later...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517497] Review Request: perl-Nagios-Plugin - Family of perl modules to streamline writing Nagios plugins

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517497


Ruben Kerkhof ru...@rubenkerkhof.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #11 from Ruben Kerkhof ru...@rubenkerkhof.com  2009-08-28 
05:52:39 EDT ---
I must have been sleepwalking :-)
Let's try again.

New Package CVS Request
===
Package Name: perl-Nagios-Plugin
Short Description: Family of perl modules to streamline writing Nagios plugins
Owners: ruben
Branches: F-11
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 502130] Review Request: openocd - Open On-Chip Debugger

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502130





--- Comment #20 from Chitlesh GOORAH chitl...@gmail.com  2009-08-28 06:30:19 
EDT ---
Please proceed for build and push as described in
https://fedoraproject.org/wiki/PackageMaintainers/Join#Check_out_the_module

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 506174] Review Request: qtdmm - a digital multimeter readout software

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506174





--- Comment #14 from Chitlesh GOORAH chitl...@gmail.com  2009-08-28 06:29:28 
EDT ---
Ping ? please refer to comment #13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519383] Review Request: python-xklavier - Python bindings for libxklavier

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519383


Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #7 from Rakesh Pandit rpan...@redhat.com  2009-08-28 06:46:10 EDT 
---
before importing change: %define to %global on top of your spec file, were
python_sitearch is defined. Latest templates have those modifications.

Changing the ticket status to ASSIGNED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 498195] Review Request: zarafa-webaccess - Zarafa Webaccess featuring a 'Look Feel' similar to Outlook

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498195





--- Comment #2 from Jeroen van Meeuwen kana...@kanarip.com  2009-08-28 
06:57:59 EDT ---
6.30.1 is released now, shall we pick this up?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519383] Review Request: python-xklavier - Python bindings for libxklavier

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519383


Huzaifa S. Sidhpurwala huzai...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 498195] Review Request: zarafa-webaccess - Zarafa Webaccess featuring a 'Look Feel' similar to Outlook

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498195





--- Comment #3 from Robert Scheck redhat-bugzi...@linuxnetz.de  2009-08-28 
07:05:44 EDT ---
Doesn't work so far, because FELEGAL at bug #498194 still exists and the legal
issue between FSF Europe thinking and FSF US thinking or whatever it is, is not 
yet resolved - correct, Tom?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519383] Review Request: python-xklavier - Python bindings for libxklavier

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519383


Huzaifa S. Sidhpurwala huzai...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW




--- Comment #8 from Huzaifa S. Sidhpurwala huzai...@redhat.com  2009-08-28 
07:02:01 EDT ---
cvs done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #61 from Axel Thimm axel.th...@atrpms.net  2009-08-28 08:14:35 
EDT ---
(In reply to comment #60)
 1. The java client doesn't build out of the box just by by the global make.
 There are some manual steps necessary.

Well, can't these manual steps be written in a specfile?

 2. On the other hand, I was under the expression that we don't want to ship 
 the
 clients at all.

Whether the java applet is desired or not is a different question depending on
its usefulness (the license question has already been checked). What is rather
certain and would require an exception by the FPC otherwise is that if there
are any java bits to be packaged they have to have been built by the package.
So, it's either

a) Rebuild the java support and the first step would be to remove the existing
targets and add build support to the specfile or the upstream Makefile(s), or

b) don't add any java support, but you don't need to actually delete them
during the build if they are not used in packaging, removing the folders from
the main Makefile is enough (like in a diff further up the report).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #62 from Christian Krause c...@plauener.de  2009-08-28 08:29:56 
EDT ---
(In reply to comment #61)
 Whether the java applet is desired or not is a different question depending on
 its usefulness (the license question has already been checked). What is rather
 certain and would require an exception by the FPC otherwise is that if there
 are any java bits to be packaged they have to have been built by the package.

I fully agree. It is up to the packager whether we wants to add the java client
or not. I'm fine with either way.

 So, it's either
 
 a) Rebuild the java support and the first step would be to remove the existing
 targets and add build support to the specfile or the upstream Makefile(s), or

Yes.

 b) don't add any java support, but you don't need to actually delete them
 during the build if they are not used in packaging, removing the folders from
 the main Makefile is enough (like in a diff further up the report).  

I agree that this may be debatable.
Personally think explicit deleting of the pre-built binaries in spec file in
the %prep section will make it quite obvious for anyone who looks at the spec
file later, that there is an issue with pre-built binaries which must be kept
in mind. That's all. ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460182] Review Request: python-virtualenv - Tool to create isolated Python environments

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460182


Peter Halliday phalli...@excelsiorsystems.net changed:

   What|Removed |Added

 CC||phalli...@excelsiorsystems.
   ||net




--- Comment #11 from Peter Halliday phalli...@excelsiorsystems.net  
2009-08-28 08:42:33 EDT ---
*** Bug 519615 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519615] Review Request: python-virtualenv - Virtual Python Environment builder

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519615


Peter Halliday phalli...@excelsiorsystems.net changed:

   What|Removed |Added

 Status|NEW |CLOSED
   Clone Of||460182
 Resolution||DUPLICATE




--- Comment #1 from Peter Halliday phalli...@excelsiorsystems.net  2009-08-28 
08:42:33 EDT ---
I just recognize taht this duplicates 460182.

*** This bug has been marked as a duplicate of 460182 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167525] Review Request: cpptasks

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=167525





--- Comment #9 from D Haley my...@yahoo.com  2009-08-28 08:59:03 EDT ---
SPEC URL: http://dhd.selfip.com/427e/cpptasks-1.0b5-2.spec
SRPM URL: http://dhd.selfip.com/427e/cpptasks-1.0b5-2.fc10.src.rpm 

RPMLint:
$ cat tmp
Wrote: /home/makerpm/rpmbuild/SRPMS/cpptasks-1.0b5-2.fc10.src.rpm
Wrote: /home/makerpm/rpmbuild/RPMS/noarch/cpptasks-1.0b5-2.fc10.noarch.rpm
Wrote:
/home/makerpm/rpmbuild/RPMS/noarch/cpptasks-javadoc-1.0b5-2.fc10.noarch.rpm

$ rpmlint -v `cat tmp | awk '{print $2}'`
cpptasks.src: I: checking
cpptasks.noarch: I: checking
cpptasks.noarch: W: non-conffile-in-etc /etc/ant.d/cpptasks
cpptasks-javadoc.noarch: I: checking
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

I'm ignoring the warning, as I don't think this should be marked as a
configuration file. Users should *not* be modifying this file in any way.

Koji:
F10:http://koji.fedoraproject.org/koji/taskinfo?taskID=1640839
F11:http://koji.fedoraproject.org/koji/taskinfo?taskID=1640849

I would have found this sooner if it wasn't marked CLOSED NOTABUG and blocked
FE-DEADREVIEW. :-)
Mea culpa.

In the absence of a manual, how about putting a URL to the online manual in the
description or in a README.fedora?

Good idea. Done.

 Does this package need to wait for that release of maven in order to build 
 the manual?
Well, I don't know. It needs the clirr plugins, so it isn't going to build at
the moment. I must admit I find maven somewhat opaque, and am not overly keen
on packaging clirr. If it gets packaged, I will update however.

Is there a reason for not building with gcj? 
Sorry, not sure why this needs to be done.  If licencing is the concern, Sun's
javac has been free (as in software) for quite a while now, I believe since F9.
I note that packages such as maven2-plugin-release use OpenJDK in preference to
gcj...

 Does this package need to drop a file into /etc/ant.d?
Yes, Fixed. I also moved the jar file + symlink to %{_javadir}/ant/, in line
with other ant tasks (ant-commons-logging,ant-junit, etc)

The -javadoc subpackage does not require the base package.
Fixed.

Please replace the %doc lines for the base package with this:
Fixed, however I also added README.fedora as well.


Thanks for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #32 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 09:24:56 EDT ---
dvisvgm-0.8.3-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/dvisvgm-0.8.3-1.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519538] Review Request: clutter-sharp - C#/.NET bindings to Clutter

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519538


Paul Lange pala...@gmx.de changed:

   What|Removed |Added

 CC||pala...@gmx.de




--- Comment #3 from Paul Lange pala...@gmx.de  2009-08-28 09:23:09 EDT ---
Thanks for creating the package. I don't have the time to make a full review
but I noticed some things.

* mixed use of %{buildroot} and $RPM_BUILD_ROOT ($RPM_BUILD_ROOT only in
%install)
* latest changelog version is 0-0.3 but release field says 0.2
* shouldn't the %defattr filed be %defattr(-,root,root,-)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #33 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 09:25:02 EDT ---
dvisvgm-0.8.3-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/dvisvgm-0.8.3-1.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #34 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 09:25:08 EDT ---
dvisvgm-0.8.3-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/dvisvgm-0.8.3-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515081





--- Comment #16 from Pierre-YvesChibon pin...@pingoured.fr  2009-08-28 
09:34:34 EDT ---
Thanks a lot for the review :)
I'll do the two correction before importing in the CVS.


New Package CVS Request
===
Package Name: R-affy
Short Description:  Methods for Affymetrix Oligonucleotide Arrays
Owners: pingou
Branches: F-10, F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 498195] Review Request: zarafa-webaccess - Zarafa Webaccess featuring a 'Look Feel' similar to Outlook

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498195





--- Comment #4 from Tom spot Callaway tcall...@redhat.com  2009-08-28 
09:50:09 EDT ---
Well, that's not exactly the issue, but yes, the licensing issue isn't
resolved. There was some progress made yesterday, but the folks at RH Legal who
were handling this particular issue are on vacation until next week, so we
won't see any progress until at least then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #35 from Jussi Lehtola jussi.leht...@iki.fi  2009-08-28 10:09:17 
EDT ---
Martin: as dvisvgm has already been introduced in the stable repository, the
new updates don't resolve this bug anymore as it has already been marked
closed. Don't mark this bug any more in updates, OK?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517197] Review Request: ghc-GLUT - bindings to the C GLUT library

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517197


Yaakov Nemoy loupgaroubl...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-08-28 
10:24:56 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.[1]
(devshell)[yan...@koan ghc-GLUT]$ rpmlint -iv *{spec,rpm} 
ghc-GLUT.src: I: checking 
ghc-GLUT-devel.i686: I: checking  
ghc-GLUT-devel.ppc: I: checking   
ghc-GLUT-devel.x86_64: I: checking
ghc-GLUT-doc.i686: I: checking
ghc-GLUT-doc.ppc: I: checking 
ghc-GLUT-doc.x86_64: I: checking  
ghc-GLUT-prof.i686: I: checking   
ghc-GLUT-prof.i686: E: devel-dependency ghc-GLUT-devel
Your package has a dependency on a devel package but it's not a devel package
itself.  

ghc-GLUT-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files. 

ghc-GLUT-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.10.4/GLUT-2.1.1.2/libHSGLUT-2.1.1.2_p.a
A development file (usually source code) is located in a non-devel package. If  
you want to include source code in your package, be sure to create a
development package.

ghc-GLUT-prof.ppc: I: checking
ghc-GLUT-prof.ppc: E: devel-dependency ghc-GLUT-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-GLUT-prof.ppc: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-GLUT-prof.ppc: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.10.4/GLUT-2.1.1.2/libHSGLUT-2.1.1.2_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

ghc-GLUT-prof.x86_64: I: checking
ghc-GLUT-prof.x86_64: E: devel-dependency ghc-GLUT-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-GLUT-prof.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

ghc-GLUT-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.10.4/GLUT-2.1.1.2/libHSGLUT-2.1.1.2_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

10 packages and 1 specfiles checked; 3 errors, 6 warnings.
 CHECK -- Normal for a haskell package

MUST: The package must be named according to the Package Naming Guidelines .
 CHECK

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
 CHECK

MUST: The package must meet the Packaging Guidelines .
 CHECK

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
 CHECK

MUST: The License field in the package spec file must match the actual license.
[3]
 CHECK

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
 CHECK

MUST: The spec file must be written in American English. [5]
 CHECK

MUST: The spec file for the package MUST be legible. [6]
 CHECK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
 CHECK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
 CHECK

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
 CHECK

MUST: All build dependencies must be listed in 

[Bug 518849] Review Request: python-werkzeug - an advanced WSGI utility module

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518849


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:28:52 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515049] Review Request: dvisvgm - Converts DVI files to SVG

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515049





--- Comment #36 from Martin Gieseking martin.giesek...@uos.de  2009-08-28 
10:27:14 EDT ---
That's strange. I didn't enter a bug number in the Bugs field and unchecked
the box Close bugs when update is stable in the bodhi web-interface. However,
the bug number from the previous build was automatically assigned after
submitting the new update. I thought that's the normal behavior...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517851] Review Request: beacon - WYSIWYG editor for docbook xml

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517851


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs-




--- Comment #14 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:29:51 
EDT ---
Please set the fedora-cvs flag back to '?' when you've fixed the above issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 493013] Review Request: dzen2 - A general purpose messaging and notification program

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493013


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:32:33 EDT 
---
It looks like you mixed up Short Description and InitialCC.  I've made the
assumption that you wanted InitialCC to be empty.

CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519538] Review Request: clutter-sharp - C#/.NET bindings to Clutter

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519538





--- Comment #4 from Christian Krause c...@plauener.de  2009-08-28 10:32:28 
EDT ---
(In reply to comment #3)
 Thanks for creating the package. I don't have the time to make a full review
 but I noticed some things.
 
 * mixed use of %{buildroot} and $RPM_BUILD_ROOT ($RPM_BUILD_ROOT only in
 %install)
 * latest changelog version is 0-0.3 but release field says 0.2
 * shouldn't the %defattr filed be %defattr(-,root,root,-)?  

Thanks for the comment - all issues fixed:

Spec URL: http://chkr.fedorapeople.org/review/clutter-sharp.spec
SRPM URL:
http://chkr.fedorapeople.org/review/clutter-sharp-0-0.3.20090828.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426752] Review Request: ghc-X11-xft - Haskell binding to Xft

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426752


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #34 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:31:09 
EDT ---
Franches are named F-10, F-11, etc.  I've fixed that up.

CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 503847] Review Request: paperbox - A GTK tracker based document browser

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503847


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #20 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:37:05 
EDT ---
Branches are named F-10, F-11, etc.  I've fixed that up.

CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518189] Review Request: java-augeas - Java bindings for Augeas

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518189


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:37:57 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507615] Review request: Vemana2000-fonts Unicode compliant OpenType font

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507615


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #7 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:40:43 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519302] Review Request: eog-plugins - A collection of plugins for the eog image viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519302


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:38:28 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517141] Review Request: ghc-fgl - functional graph library for Haskell

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517141


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:39:00 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519482] Review Request: zikula-module-feeds - RSS feeds module for zikula

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519482


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:39:33 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517497] Review Request: perl-Nagios-Plugin - Family of perl modules to streamline writing Nagios plugins

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517497


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #12 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:41:32 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507830] Review Request: camorama - Gnome webcam viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507830


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #6 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 10:41:01 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 497833] Review Request: tuna - Application tuning GUI command line utility

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497833





--- Comment #12 from Arnaldo Carvalho de Melo a...@redhat.com  2009-08-28 
10:47:05 EDT ---
ping, is there anything else I need to do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516114] Review Request: trac-accountmanager-plugin - Trac plugin for account registration and management

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516114





--- Comment #5 from Paul Howarth p...@city-fan.org  2009-08-28 10:58:01 EDT 
---
The tarball in the SRPM is missing a bunch of stuff - seems you still have a
broken setuptools/subversion still?

One of the missing items is the sessionstore_convert.py script, so you
shouldn't need a separate source item for that. The templates directory is also
missing.

There are still a couple of comments left over from the template (sitelib at
the top, and again in the %files list).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 426754] Review Request: ghc-xmonad-contrib - Third party extensions for xmonad

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426754





--- Comment #24 from Yaakov Nemoy loupgaroubl...@gmail.com  2009-08-28 
11:13:47 EDT ---
SPEC: http://ynemoy.fedorapeople.org/review/ghc-xmonad-contrib.spec
SRPM:
http://ynemoy.fedorapeople.org/review/ghc-xmonad-contrib-0.8.1-8.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516114] Review Request: trac-accountmanager-plugin - Trac plugin for account registration and management

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516114





--- Comment #6 from Ben Boeckel maths...@gmail.com  2009-08-28 11:16:54 EDT 
---
Spec URL:
http://benboeckel.net/packaging/trac-accountmanager-plugin/trac-accountmanager-plugin.spec
SRPM URL:
http://benboeckel.net/packaging/trac-accountmanager-plugin/trac-accountmanager-plugin-0.2.1-0.3.20090522svn5836.fc11.src.rpm

Oops, forgot to do the gz-bz2 from using your script. Now it's using the
correct tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518766] Review Request: auto-destdir - Automate DESTDIR support for make install

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518766


David A. Wheeler dwhee...@dwheeler.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518766] Review Request: auto-destdir - Automate DESTDIR support for make install

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518766


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #15 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 11:53:02 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 515081] Review Request: R-affy - Methods for Affymetrix Oligonucleotide Arrays

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515081


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag||fedora-cvs+




--- Comment #17 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 11:55:57 
EDT ---
Don't forget to set the fedora-cvs flag; otherwise most CVS admins won't see
your request.

CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517197] Review Request: ghc-GLUT - bindings to the C GLUT library

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517197


Bryan O'Sullivan b...@serpentine.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Bryan O'Sullivan b...@serpentine.com  2009-08-28 12:04:36 
EDT ---
New Package CVS Request
===
Package Name: ghc-GLUT
Short Description: bindings to the C GLUT library
Owners: bos petersen ynemoy
Branches: F-11 F-12
InitialCC: haskell-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517197] Review Request: ghc-GLUT - bindings to the C GLUT library

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517197


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #5 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 12:09:56 EDT 
---
I've just created the F-11 branch.  If you really, really need a very early
F-12 branch, we may be able to do that later today, so if that's what you need
then go ahead and make another CVS request.

CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513892] Review Request: bilbo - Blogging client, focused on simplicity and usability

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513892


Martin Gieseking martin.giesek...@uos.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #6 from Martin Gieseking martin.giesek...@uos.de  2009-08-28 
12:26:35 EDT ---
Applying bilbo-0.9-license-headers.patch is redundant since it doesn't change
the program code and has no effect on building the package. So it can be
omitted.
Beside that, everything looks fine now. 

The package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 448661] Review Request: u-boot-tools - contains mkimage a tool to create kernel bootable images for u-boot

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448661


Dan Horák d...@danny.cz changed:

   What|Removed |Added

 CC||d...@danny.cz




--- Comment #20 from Dan Horák d...@danny.cz  2009-08-28 12:42:56 EDT ---
Debian did put mkimage into a separate source package -
http://packages.debian.org/lenny/uboot-mkimage. I can make and submit a rpm
based on it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518449] Review Request: moblin-panel-people - Moblin Panel for People

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518449


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #7 from Peter Robinson pbrobin...@gmail.com  2009-08-28 13:04:42 
EDT ---
Imported into CVS. Has build issues at the moment as the
telepathy-mission-control has broken anerley.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518450] Review Request: moblin-panel-status - Moblin Panel for Social Network Status

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518450


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #8 from Peter Robinson pbrobin...@gmail.com  2009-08-28 13:04:55 
EDT ---
Imported into CVS. Has build issues at the moment as the
telepathy-mission-control has broken anerley.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 507223] Review Request: dalston - Moblin System Information Icons

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507223





--- Comment #18 from Peter Robinson pbrobin...@gmail.com  2009-08-28 13:06:50 
EDT ---
New upstream relese
SRPM: http://pbrobinson.fedorapeople.org/dalston-0.1.2-1.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519425] Review Request: plexus-naming - Plexus Naming Component

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519425





--- Comment #7 from Andrew Overholt overh...@redhat.com  2009-08-28 13:44:30 
EDT ---
With license fix from upstream:

http://overholt.fedorapeople.org/plexus-naming.spec
http://overholt.fedorapeople.org/plexus-naming-1.0-0.4.a3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513892] Review Request: bilbo - Blogging client, focused on simplicity and usability

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513892


Ben Boeckel maths...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Ben Boeckel maths...@gmail.com  2009-08-28 13:44:59 EDT 
---
New Package CVS Request
===
Package Name: bilbo
Short Description: Blogging client, focused on simplicity and usability
Owners: mathstuf
Branches: F-10 F-11
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519138] Review Request: libbs2b - Bauer stereophonic-to-binaural DSP library

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519138


Martin Gieseking martin.giesek...@uos.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||martin.giesek...@uos.de
 AssignedTo|nob...@fedoraproject.org|martin.giesek...@uos.de
   Flag||fedora-review?




--- Comment #1 from Martin Gieseking martin.giesek...@uos.de  2009-08-28 
14:01:26 EDT ---
Hello Karel,

here is the review of your package. It is pretty clean. Just the
BuildRequires(pre/post) should be removed (see below).


rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm
libbs2b-devel.i586: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

The warning is expected and can safely be ignored.

-
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: License file(s) must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
- md5 hash is 00d32ffa6461dde6a632c846da3e0a13

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile,...
[X] MUST: All build dependencies must be listed in BuildRequires.
- Requires(post) and Requires(pre) are redundant here (no %pre scriptlet)
- dependency /sbin/ldconfig is determined automatically
  (see
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries)

[.] MUST: The spec file MUST handle locales properly. 
- no locales

[+] MUST: Packages with shared libs must call ldconfig in %post and %postun.
[.] MUST: If the package is designed to be relocatable,...
[.] MUST: A package must own all directories that it creates.
- doesn't create directories

[+] MUST: File must not be listed more than once in the %files listings.
[+] MUST: Permissions on files must be set properly. 
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
- no large docs

[+] MUST: Files in %doc must not affect the runtime of the application. 
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
- no static libs

[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[+] MUST: .so (without suffix) must go in a -devel package.
[+] MUST: devel packages must have a Requires: %{name} = %{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages with GUI applications must include a %{name}.desktop file.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
- builds in mock 

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
- koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=1641475

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 167525] Review Request: cpptasks

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=167525


Jerry James loganje...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #10 from Jerry James loganje...@gmail.com  2009-08-28 14:07:21 
EDT ---
 Well, I don't know. It needs the clirr plugins, so it isn't going to build at
 the moment. I must admit I find maven somewhat opaque, and am not overly keen
 on packaging clirr. If it gets packaged, I will update however.

I've had a look, and clirr just isn't going to happen for Fedora.  First, it's
a dead project.  Second, it only builds with maven1, NOT maven2.  But it's not
needed for building the manual, anyway, is it?  I think we can just patch the
clirr-related parts out of build.xml.

 Is there a reason for not building with gcj? 
 Sorry, not sure why this needs to be done.  If licencing is the concern, Sun's
 javac has been free (as in software) for quite a while now, I believe since 
 F9.
 I note that packages such as maven2-plugin-release use OpenJDK in preference 
 to
 gcj...

Last I heard, OpenJDK on PPC/PPC64 is 1 or 2 orders of magnitude slower than
gcj-generated code.  GCJ support is not a MUST item, so I won't block the
review on this point.  Personally, I'd be happy to see gcj-compiled code go
away and all Java packages become noarch.  For that to happen, though, the
speed problems with OpenJDK need to be fixed.  I don't know who is working on
that or what the status is.

So, going over the list again, java-devel still isn't a BR, but it's pulled in
by ant, so I guess that's okay.  Everything else is fixed, so this package is
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519071] Review Request: wiipresent - Giving presentations (or control applications) with your Wiimote

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519071





--- Comment #1 from Dominic Hopf dma...@gmail.com  2009-08-28 14:33:17 EDT ---
$ rpmlint wiipresent.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint wiipresent-0.7.5.2-2.fc11.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint wiipresent-0.7.5.2-2.fc11.i586.rpm 
wiipresent-debuginfo-0.7.5.2-2.fc11.i586.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


MUSTs
-

OK: packaged is named according to the package naming guidelines
OK: specfile name matches %{name}.spec
OK: package seems to meet packaging guidelines
OK: license in specfile matches actual license and meets licensing guidelines
OK: license file is included in %doc
OK: specfile is written in AE
OK: specfile is legible
OK: sourcefile in the package is the same as provided in the mentioned source,
md5sum fits
OK: package compiles successfully
OK: all build dependencies are listed in BuildRequires
N/A: package handles locales properly
 there are no locales installed with this package
N/A: call ldconfig in %post and %postun
 there is no binary installed with this package
OK: package is not designed to be relocatable
OK: package owns directorys it creates
OK: does not list a file more than once in the %files listing
OK: %files section includes %defattr and permissions are set properly
OK: %clean section is there and contains rm -rf %{buildroot}
NOT OK: macros are consistently used
OK: package contains code
N/A: subpackage for large documentation files
 there are no large documentation files
OK: program runs properly without files listed in %doc
N/A: header files are in a -devel package
 there are no header files
N/A: static libraries are in a -static package
 there are no static libs
N/A: require pkgconfig if package contains a pkgconfig(.pc)
 there is no pkgconfig file
N/A: put .so-files into -devel package if there are library files with suffix
 there is no library with suffix, in fact there isn't any library
N/A: devel package includes fully versioned dependency for the base package
 there is no devel package
N/A: any libtool archives are removed
 there are no libtool archives
OK: contains desktop file if it is a GUI application
OK: package does not own any files or directories owned by other packages
OK: buildroot is removed at beginning of %install
N/A: filenames are encoded in UTF-8
 not necessary since there are no non-ASCII filenames


SHOULD
--
N/A: non-English translations for description and summary
 there are no other languages supported by this package, in fact it does
not
 provide any localization. I assume localizations are not needed for this
 package.
OK: package builds in mock
OK: package builds into binary rpms for all supported architectures
N/A: program runs
 I did not test myself if the program works as it should
N/A: subpackages contain fully versioned dependency for the base package
 there are no subpackages
N/A: pkgconfig file is placed in a devel package
 there is no pkgconfig file
N/A: require package providing a file instead of the file itself
 no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required

Please do not use macros for rm and make install in the %install section. This
also should fix the consistency of using macros which is not ok.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519986] media-player-id - Data files describing media player capabilities

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519986


Bill Nottingham nott...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|nott...@redhat.com
   Flag||fedora-review?




--- Comment #1 from Bill Nottingham nott...@redhat.com  2009-08-28 15:06:28 
EDT ---
MUST items:
- Package meets naming and packaging guidelines - OK
- Spec file matches base package name. - OK
- Spec has consistant macro usage. - OK
- Meets Packaging Guidelines. - OK
- License - ***

1) This package consists of nothing but configuration files and a udev rules
file. These are configuration, and not necessarily copyrightable.
2) Spot says use a permissive license just to be sure.
3) Which implies the BSD in the tarball is OK...
4) except it still states:

Copyright (c) The Regents of the University of California.

which is almost certainly wrong, in the case that the package *is*
copyrightable. Should be Christophe  Martin, or whomever.

- License field in spec matches - OK, as it stands
- License file included in package - OK
- Spec in American English - OK
- Spec is legible. - OK
- Sources match upstream md5sum:

878fd1b6a8baccf0ce46d29f2fde559a40d6573c  media-player-id-1.tar.gz

OK.

- Package needs ExcludeArch - ***

Might want 'ExcludeArch: s390 s390x other similar things'. But I doubt it
matters that much.

- BuildRequires correct - OK. 
- Spec handles locales/find_lang - N/A
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot - OK
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content. - OK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime. - OK

- Package compiles and builds on at least one arch. - OK (tested F12)
- Package has no duplicate files in %files. - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates. - OK
- No rpmlint output. - OK
- final provides and requires are sane: - OK

Can we get them to fix the licensing?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513892] Review Request: bilbo - Blogging client, focused on simplicity and usability

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513892


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 15:19:02 EDT 
---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519425] Review Request: plexus-naming - Plexus Naming Component

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519425





--- Comment #8 from Jeff Johnston jjohn...@redhat.com  2009-08-28 15:52:22 
EDT ---
(In reply to comment #7)
 With license fix from upstream:
 
 http://overholt.fedorapeople.org/plexus-naming.spec
 http://overholt.fedorapeople.org/plexus-naming-1.0-0.4.a3.fc11.src.rpm  

I ran into a problem building due to the level of plexus-utils in f11 not being
adequate to build the rpm.  It tries to build but the junit test fails and the
build does not complete.  

Please add a release number to the BuildRequires for plexus-utils

BuildRequires: plexus-utils = 1.4.5

since downloading the plexus-utils 1.4.5-1.2 from rawhide solved the problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225746] Merge Review: fedora-release

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225746


Jesse Keating jkeat...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #17 from Jesse Keating jkeat...@redhat.com  2009-08-28 15:59:09 
EDT ---
Package Change Request
==
Package Name: fedora-release
New Branches: F-12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225746] Merge Review: fedora-release

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225746


Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #18 from Jason Tibbitts ti...@math.uh.edu  2009-08-28 16:03:45 
EDT ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519425] Review Request: plexus-naming - Plexus Naming Component

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519425





--- Comment #9 from Andrew Overholt overh...@redhat.com  2009-08-28 16:22:26 
EDT ---
Sorry, added:

http://overholt.fedorapeople.org/plexus-naming.spec
http://overholt.fedorapeople.org/plexus-naming-1.0-0.5.a3.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519986] media-player-id - Data files describing media player capabilities

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519986





--- Comment #2 from Matthias Clasen mcla...@redhat.com  2009-08-28 16:30:19 
EDT ---
 Might want 'ExcludeArch: s390 s390x other similar things'

Why ? Is there a reason, other than 'media players are pretty irrelevant on
s390' ?

 Can we get them to fix the licensing?  

I'll point that out to them. I might hold off a few days on completing this
review anyway, since Christophe was considering renaming it to
media-player-info.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519986] media-player-id - Data files describing media player capabilities

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519986





--- Comment #3 from Bill Nottingham nott...@redhat.com  2009-08-28 16:32:04 
EDT ---
(In reply to comment #2)
  Might want 'ExcludeArch: s390 s390x other similar things'
 
 Why ? Is there a reason, other than 'media players are pretty irrelevant on
 s390' ?

No, not really.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 518082] Review Request: rubygem-facade - A module that helps implement the facade pattern

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518082


Brett Lentz wakko...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 505928] Review Request: hdapsd - Protects hard drives by parking head when fall is detected

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505928


Tomasz Torcz zdzi...@irc.pl changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #16 from Tomasz Torcz zdzi...@irc.pl  2009-08-28 16:44:10 EDT ---
New Package CVS Request
===
Package Name: hdapsd
Short Description: Protects hard drives by parking head when fall is detected
Owners: ttorcz
Branches: F-12
InitialCC: ttorcz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519425] Review Request: plexus-naming - Plexus Naming Component

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519425


Jeff Johnston jjohn...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #10 from Jeff Johnston jjohn...@redhat.com  2009-08-28 16:53:02 
EDT ---
Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519425] Review Request: plexus-naming - Plexus Naming Component

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519425


Andrew Overholt overh...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #11 from Andrew Overholt overh...@redhat.com  2009-08-28 17:00:16 
EDT ---
New Package CVS Request
===
Package Name: plexus-naming
Short Description: Plexus Naming Component
Owners: overholt, akurtakov
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519282] Review Request: calibre - e-book converter and library manager

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519282





--- Comment #1 from Ionuț Arțăriși maple...@fedoraproject.org  2009-08-28 
17:06:13 EDT ---
Spec URL: http://mapleoin.fedorapeople.org/calibre-0.8.10/calibre.spec
SRPM URL:
http://mapleoin.fedorapeople.org/calibre-0.8.10/calibre-0.6.10-1.fc11.src.rpm

I fixed a few issues: the man page duplication, and man page installation,
.desktop files, lrfviewer icon file and a new upstream release.

rpmlint output: http://fpaste.org/Z7qg/

I've gotten rid of anything but these two new warnings and all the old
non-executable-script errors.
calibre.i586: W: non-conffile-in-etc /etc/bash_completion.d/calibre
calibre.i586: W: non-conffile-in-etc /etc/udev/rules.d/95-calibre.rules

Feedback welcome! ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 490988] Review Request: libvdpau - Wrapper library for the Video Decode and Presentation API

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490988


Stephen Warren s-t-rhbugzi...@wwwdotorg.org changed:

   What|Removed |Added

 CC||s-t-rhbugzi...@wwwdotorg.or
   ||g




--- Comment #7 from Stephen Warren s-t-rhbugzi...@wwwdotorg.org  2009-08-28 
17:18:16 EDT ---
It'd be nice to package libvdpau_trace.so too, although I suppose that would be
a different package.

Just as an aside, S3's implementation doesn't use the wrapper lib; they just
overwrite libvdpau.so with their main driver binary.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519071] Review Request: wiipresent - Giving presentations (or control applications) with your Wiimote

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519071


Christoph Wickert christoph.wick...@googlemail.com changed:

   What|Removed |Added

 CC||christoph.wick...@googlemai
   ||l.com




--- Comment #2 from Christoph Wickert christoph.wick...@googlemail.com  
2009-08-28 17:45:28 EDT ---
Pleas note that 

%post
/usr/bin/update-desktop-database -q || :

%postun
/usr/bin/update-desktop-database -q || :

is not necessary, because the desktop file contains no mimetype. This is only
needed it an application is supposed to open a certain mime type, so the Open
with... entry gets created.

And of course,

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

are not necessary ether. This would only be neccessary if there was a mime type
AND you want to build this package on EPEL/Fedora  5, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database


I don't like the summary. Summary should be short an precise but not whole
sentences. How about: Tool to control applications or presentations with a
Wiimote?


I didn't test it, but 

%if 0%{?fedora} = 11
BuildRequires: xorg-x11-proto-devel
%else
BuildRequires: libXi-devel
%endif

looks bogus to me, as libXi-devel requires xorg-x11-proto-devel.


%{_mandir}/man1/wiipresent.1* does not need to be tagged as %doc, rpmbuild will
take care of this. It doesn't do no harm, it's just a hint.


Finally: the build root tag should be

%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

or even better

%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)

Doesn't really matter ether, but IMO for new packages we should follow the
guidelines from
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

That's all from my side, nothing more to add.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 520202] New: Review Request: maven-doxia-sitetools - Doxia content generation framework

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: maven-doxia-sitetools - Doxia content generation 
framework

https://bugzilla.redhat.com/show_bug.cgi?id=520202

   Summary: Review Request: maven-doxia-sitetools - Doxia content
generation framework
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: overh...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://overholt.fedorapeople.org/maven-doxia-sitetools.spec
SRPM URL:
http://overholt.fedorapeople.org/maven-doxia-sitetools-1.0-0.2.a10.fc11.src.rpm

Description: 
Doxia is a content generation framework which aims to provide its
users with powerful techniques for generating static and dynamic
content. Doxia can be used to generate static sites in addition to
being incorporated into dynamic content generation systems like blogs,
wikis and content management systems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 520202] Review Request: maven-doxia-sitetools - Doxia content generation framework

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520202





--- Comment #1 from Andrew Overholt overh...@redhat.com  2009-08-28 17:48:07 
EDT ---
This is a full review request.  The previous pre-review request was bug
#500267.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 500267] Pre-Review Request: maven-doxia-sitetools - Content generation framework

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=500267


Andrew Overholt overh...@redhat.com changed:

   What|Removed |Added

 CC||overh...@redhat.com




--- Comment #4 from Andrew Overholt overh...@redhat.com  2009-08-28 17:48:18 
EDT ---
Full review request:  bug #520202

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 519302] Review Request: eog-plugins - A collection of plugins for the eog image viewer

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519302


Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #4 from Matthias Clasen mcla...@redhat.com  2009-08-28 17:46:29 
EDT ---
Build done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 506174] Review Request: qtdmm - a digital multimeter readout software

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506174





--- Comment #15 from Andrew Zabolotny anp...@mail.ru  2009-08-28 17:51:42 EDT 
---
Sorry, was tracked away by everyday life.

Have commited everything to F-10, F-11 and -devel. Did a successful test build
for everyone.

Should I do 'make update' now for both distros?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226276] Merge Review: perl

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226276


Stepan Kasal ska...@redhat.com changed:

   What|Removed |Added

 CC||ska...@redhat.com
   Flag||fedora-cvs?




--- Comment #39 from Stepan Kasal ska...@redhat.com  2009-08-28 17:56:49 EDT 
---
Package Change Request
==
Package Name: perl
New Branches: F-12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 516869] Review Request: perl-Search-Xapian - Xapian perl bindings

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516869


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #9 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 17:57:58 EDT ---
perl-Search-Xapian-1.0.11.0-5.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Search-Xapian'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9090

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517155] Review Request: ghc-OpenGL - bindings to the C OpenGL library

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517155


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #9 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 18:00:22 EDT ---
ghc-OpenGL-2.2.1.1-1.fc11 has been pushed to the Fedora 11 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ghc-OpenGL'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9108

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 517497] Review Request: perl-Nagios-Plugin - Family of perl modules to streamline writing Nagios plugins

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517497





--- Comment #13 from Fedora Update System upda...@fedoraproject.org  
2009-08-28 18:01:26 EDT ---
perl-Nagios-Plugin-0.33-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Nagios-Plugin-0.33-2.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 450527] Review Request: libkni3 - C++ library for the Katana robot arm

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450527





--- Comment #22 from Tim Niemueller t...@niemueller.de  2009-08-28 18:09:04 
EDT ---
I have uploaded a new version of the package. The shared libraries are now
renamed (adding a 3 as suffix). Therefore the problem with parallel installing
libkni3 (and a later proposed libkni v4) is solved.

SRPM at http://fedorapeople.org/~timn/robotics/libkni3-3.9.2-11.fc11.src.rpm,
spec at http://fedorapeople.org/~timn/robotics/libkni3,spec.

Can I consider this package as approved then?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 520204] Review Request: aspell5-ro - Romanian dictionary for Aspell

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520204


Ionuț Arțăriși maple...@fedoraproject.org changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 520204] New: Review Request: aspell5-ro - Romanian dictionary for Aspell

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: aspell5-ro - Romanian dictionary for Aspell

https://bugzilla.redhat.com/show_bug.cgi?id=520204

   Summary: Review Request: aspell5-ro - Romanian dictionary for
Aspell
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: maple...@fedoraproject.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://mapleoin.fedorapeople.org/pkgs/aspell-ro/aspell-ro.spec
SRPM URL:
http://mapleoin.fedorapeople.org/pkgs/aspell-ro/aspell-ro-3.2.7-1.fc11.src.rpm
Description: Provides the word list/dictionaries for the following: Romanian

--

I basically copied a lot of this from the french one:
http://cvs.fedoraproject.org/viewvc/rpms/aspell-fr/F-11/aspell-fr.spec?view=co

Modified a bit for extra files and different source.

This is (sort of) my first package so I would please like a sponsor!
I've got another package awaiting review/sponsorship here: #519282

Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 513892] Review Request: bilbo - Blogging client, focused on simplicity and usability

2009-08-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513892


Ben Boeckel maths...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Comment #9 from Ben Boeckel maths...@gmail.com  2009-08-28 18:26:49 EDT 
---
Built for F-11 (Rawhide has dependency issues), closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >