Re: [Firebird-devel] Firebird support for "newer" compilers & SDKs / especially on Windows & MacOS X

2016-03-15 Thread Kovalenko Dmitry
>One of our developers discovered that Firebird 2.5 fails to compile
MSVC2013, made some steps in the direction of fixing it (like we did
internally for GCC 6), and was told that for Firebird 2.5, it was more work
than he envisioned: http://tracker.firebirdsql.org/browse/CORE-5120

You can look to my "clone" of FB2.5:
https://github.com/dmitry-lipetsk/firebird/tree/B2_5_Release

It supports compilation by VS2005-VS2015. I use VS2015.

But contains the some corrections of source code and project files.

- [sample of command line for compilations]

1. builds\win32\build_fb_all.bat MSVC14XP

2. builds\win32\build_fb_all.bat MSVC12XP

3. builds\win32\build_fb.bat MSVC14XP AMD64 Debug

-
Binary files (in case of VS2015) will be placed into folders:

output\msvc14xp_Win32_Debug
output\msvc14xp_Win32_Release
output\msvc14xp_x64_Debug
output\msvc14xp_x64_Release

-
Regards,
Dmitry Kovalenko


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] Firebird support for "newer" compilers & SDKs / especially on Windows & MacOS X

2016-03-15 Thread Dmitry Yemanov
15.03.2016 18:37, Lionel Elie Mamane wrote:
>
> Short version: will Firebird (2.5? 3? latest?) in general be kept
> compatible with the latest major compilers (within a reasonable time
> of their release) for each platform for the foreseeable future?

Yes. Just don't expect it to happen immediately.

v2.5 is officially built using VC2005 but also supports VC2008 and 
VC2010 (used by some our developers).
v3.0 is officially built using VC2010 but also supports VC2012/2013.
v4.0 will be officially built using VC2013.

I don't want to promise anything for v2.5 which is likely to be 
discontinued in two years, but I see no reason why v3 and v4 cannot be 
compiled using VC2015 or whatever later. Obviously, it's not our top 
priority. We just need someone to setup VC2015 and give it a try.


Dmitry


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] Firebird support for "newer" compilers & SDKs / especially on Windows & MacOS X

2016-03-15 Thread Michal Kubecek
On Tue, Mar 15, 2016 at 04:37:06PM +0100, Lionel Elie Mamane wrote:
> 
> Then, we read the thread "Compiler for official Firebird 4 release on
> Windows" on this ML. Which says that not only Firebird 3, bit Firebird
> 4 binaries on http://firebirdsql.org/ will be compiled with
> MSVC2013. Some people within the LibreOffice developer community have
> understood that as "Firebird 4 will not support newer MSVC";

Well, that would be really pesimistic interpretation. I seriously doubt
core developers who work on Windows would like to confine themselves to
MSVC 2013 for the whole FB4 lifetime. As I said before, what will be the
official binaries compiled with and what compilers will be supported are
two very different questions.

It seems at least some of the issues you ran into are the same problems
we encountered with gcc6, see the initial comment of CORE-5099 for the
list. I believe all except 2 and 3 can be safely fixed in all branches
from 2.5 up and I think they should. As for issue 2 (exception specifier
for operator new), this could be fixed as well once we make sure MSVC is
OK with suggested solution.

The most complicated is issue 3, dead store elimination (see my comment
from February 26). I'm not sure how much of the code relies on zeroing
object storage in operator new. It may not be feasible (and safe) to fix
all of them in 2.5 and maybe not even in 3.0 (which is already at RC2).
Good news is it can be worked around with "-flifetime-dse=1" or stronger
"-fno-lifetime-dse". The tricky part is that gcc < 5 does not recognize
this option but that can be resolved in configure script.

I'm going to propose patches for the easy issues later this week, let's
see what the consensus will be.

  Michal Kubecek


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Jim Starkey
Could somebody explain why Firebird is in the filename translation 
business at all?  Other than the need for the inet remote interface to 
follow symbolic links, historically this has not been necessary. It 
clearly isn't needed to open the file.

If the purpose is to server as the root of the lock tree, wouldn't a 
UUIC in the database header page be a better solution?

Or is it something else?

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] Example of useing services in new API

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 08:27 PM, Dimitry Sibiryakov wrote:
> Hello, All.
>
> Among examples in "interfaces" folder I don't see any that could show how 
> to work with
> services using new API. Is it possible at all?
>

Yes, certainly.
Plan to add it (also use of FB_MESSAGE macro to describe messages and 
working with events) before release.

What is almost unsupported - arrays.


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


[Firebird-devel] Example of useing services in new API

2016-03-15 Thread Dimitry Sibiryakov
   Hello, All.

   Among examples in "interfaces" folder I don't see any that could show how to 
work with 
services using new API. Is it possible at all?

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Adriano dos Santos Fernandes
On 15/03/2016 13:30, Dimitry Sibiryakov wrote:
> 15.03.2016 13:24, Adriano dos Santos Fernandes wrote:
>> Also should test old client (which cannot use utf8_filename dpb)
>> connecting to new (with your change, and already one without it)
>> checking it work as originally.
>Old client that doesn't support utf8_filename flag is 2.1. Is Firebird 
> version 2.1 
> still supported?
>
If it's able to connect to Firebird server v4, Firebird server v4 should
handle its connection correctly (from the 2.1 client POV).


Adriano


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 13:24, Adriano dos Santos Fernandes wrote:
> Also should test old client (which cannot use utf8_filename dpb)
> connecting to new (with your change, and already one without it)
> checking it work as originally.

   Old client that doesn't support utf8_filename flag is 2.1. Is Firebird 
version 2.1 
still supported?

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


[Firebird-devel] [FB-Tracker] Created: (CORE-5151) Casting text to integer fails if text is within range but more than nine digits

2016-03-15 Thread Firebird admin @ RxStrategies Inc (JIRA)
Casting text to integer fails if text is within range but more than nine digits
---

 Key: CORE-5151
 URL: http://tracker.firebirdsql.org/browse/CORE-5151
 Project: Firebird Core
  Issue Type: Bug
Affects Versions: 2.5.5
Reporter: Firebird admin @ RxStrategies Inc


Production code fails when assigning a text value to DECIMAL(9,2).  Example 
below uses integer for simplicity.

/* numeric value is out of range */
select cast('25992.9' as integer)
from rdb$database

/* works */
select cast('25992.9000' as integer)
from rdb$database

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


[Firebird-devel] Firebird support for "newer" compilers & SDKs / especially on Windows & MacOS X

2016-03-15 Thread Lionel Elie Mamane
Hi,

Short version: will Firebird (2.5? 3? latest?) in general be kept
compatible with the latest major compilers (within a reasonable time
of their release) for each platform for the foreseeable future?

Long version:

As you may already know, LibreOffice embeds Firebird 2.5. This is
currently as an experimental feature, mainly because the Firebird data
format is endianess-dependent and we (on the LibreOffice side) have
not yet finished the work for switching to Firebird's backup format
instead of the native format.

LibreOffice has a policy of compiling things it embeds itself, and
thus makes the same with Firebird.

In the meantime, and at first sight unrelated, LibreOffice is trying
to upgrade to MSVC2015 for building its Microsoft Windows
binaries. This is made rather pressing by the fact that Python 3.5,
which LibreOffice also embeds, dropped support for MSVC2013. In
general, we don't want to commit to being stuck with an older compiler
because of one of the externals that we embed.

One of our developers discovered that Firebird 2.5 fails to compile
MSVC2013, made some steps in the direction of fixing it (like we did
internally for GCC 6), and was told that for Firebird 2.5, it was more
work than he envisioned:
http://tracker.firebirdsql.org/browse/CORE-5120

This makes it hard to keep Firebird in LibreOffice. We are still eager
to embed Firebird in LibreOffice and to make it our default embedded
database; we would be OK-to-happy with upgrading to version 3 for
that, since it seems it is nearing release and stability, having
release candidate status.

Then, we read the thread "Compiler for official Firebird 4 release on
Windows" on this ML. Which says that not only Firebird 3, bit Firebird
4 binaries on http://firebirdsql.org/ will be compiled with
MSVC2013. Some people within the LibreOffice developer community have
understood that as "Firebird 4 will not support newer MSVC"; my
understanding is that one can be compatible with MSVC2013 *and* MSVC
2015 *and* (when it comes out) MSVC 2018, etc, so there is still
hope. But fact is that there has been quite some worry among
LibreOffice developers around that, compounded by past difficulties in
integrating Firebird into our build environment.

So I'm writing to get a statement from you guys on whether my
interpretation is correct, that is you _will_ actively keep Firebird
(at least some stable non-beta version) compilable with the latest and
greatest? (And then our conclusion will be that we can continue to
plan for embedding Firebird in LibreOffice.)


Thanks in advance,

-- 
Lionel

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 14:50, Michal Kubecek wrote:
> As most linux distributions have been using UTF-8 for everything for
> quite some time, file names ended up being in UTF-8 as well. But it's
> just kind of an "unwritten law", not a standard.

   Ok, I'll add calls to Utf8ToSystem into unix.cpp before fopen().

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Michal Kubecek
On Tue, Mar 15, 2016 at 01:49:20PM +0100, Dimitry Sibiryakov wrote:
> >Does POSIX requires any changes for this issue ?
> 
>AFAIK - no, fopen() handles utf-8 in file names out of box.

I would rather say posix filesystems are encoding agnostic. In general,
the file name is just a sequence of bytes not containing zero bytes
('\0') and slashes ('/') and it's up to you to decide what encoding you
want to use, as long as it's not something like UTF-16 or UCS-2 (which
many windows users mistake for UTF-16).

As most linux distributions have been using UTF-8 for everything for
quite some time, file names ended up being in UTF-8 as well. But it's
just kind of an "unwritten law", not a standard.

 Michal Kubecek


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 14:00, Alex Peshkoff wrote:
> Please provide proof reference for it.

http://stackoverflow.com/questions/4676327/how-to-open-a-file-with-wchar-t-containing-non-ascii-string-in-linux

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 03:49 PM, Dimitry Sibiryakov wrote:
> 15.03.2016 13:36, Vlad Khorsun wrote:
>> But why you not included it into namespace os_utils ???
> To keep old code working. Otherwise I would have to change every piece of 
> code where
> the class is used.

It's OS specific and therefore belongs to that namespace.

>> Does POSIX requires any changes for this issue ?
> AFAIK - no, fopen() handles utf-8 in file names out of box.
>

Please provide proof reference for it.


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 03:36 PM, Vlad Khorsun wrote:

>> Question: should I commit them at once or separately?
> I see two questions in statement above.


I've discussed some points with author privately in russian and I do not 
agree with this commit. It's half done and breaks a lot of places even 
at the first look.


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 13:47, Adriano dos Santos Fernandes wrote:
> No regressions in any commit is top priority.

   Sure. I'll do extended testing in areas you mentioned.

> It surely work.
>
> Without isc_dbp_utf8_filename ever work as intended. You sure should
> test this with different servers and clients.

   I tested it with ANSI code page 1251 without isc_dpb_utf8_filename. It still 
works.

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 13:36, Vlad Khorsun wrote:
> But why you not included it into namespace os_utils ???

   To keep old code working. Otherwise I would have to change every piece of 
code where 
the class is used.
   Besides, I doubt that this all-purpose class belongs to that namespace.

> Also, i prefer to see is at separate commit.

   No problem.

>Does POSIX requires any changes for this issue ?

   AFAIK - no, fopen() handles utf-8 in file names out of box.

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Adriano dos Santos Fernandes
On 15/03/2016 09:41, Dimitry Sibiryakov wrote:
> 15.03.2016 13:24, Adriano dos Santos Fernandes wrote:
>> You should at least test every code path related to the functions you
>> changed the input/output code page, like code paths related to files
>> names in databases (external files, shadows, whatever).
>I was explicitly asked by admins not to make wide patches. Every single 
> issue will be 
> fixed separately.

No regressions in any commit is top priority.

>> Also should test old client (which cannot use utf8_filename dpb)
>> connecting to new (with your change, and already one without it)
>> checking it work as originally.
>Originally it doesn't work at all. That's what all these tickets are 
> about. Connection 
> strings without isc_dbp_utf8_filename inside are handled by server y-valve as 
> before, no 
> changes in this regard.
>
It surely work.

Without isc_dbp_utf8_filename ever work as intended. You sure should
test this with different servers and clients.

Support for isc_dbp_utf8_filename was implemented given the limitations
of being using the ANSI API with FS functions, so working.


Adriano


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 13:24, Adriano dos Santos Fernandes wrote:
> You should at least test every code path related to the functions you
> changed the input/output code page, like code paths related to files
> names in databases (external files, shadows, whatever).

   I was explicitly asked by admins not to make wide patches. Every single 
issue will be 
fixed separately.

> Also should test old client (which cannot use utf8_filename dpb)
> connecting to new (with your change, and already one without it)
> checking it work as originally.

   Originally it doesn't work at all. That's what all these tickets are about. 
Connection 
strings without isc_dbp_utf8_filename inside are handled by server y-valve as 
before, no 
changes in this regard.

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] FB 3 RC2 never asks last byte byte for isc_info_svc_stdin

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 03:34 PM, Jiří Činčura wrote:
> Nobody from core team?
>

Jiri, I have no idea how to help you. fbsvcmgr works just fine.
If you can provide reproducible test case which I can run on linux (may 
be client on wine) I will take a look what happens.


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Vlad Khorsun
15.03.2016 14:05, Dimitry Sibiryakov wrote:
>In attachment you can find patch for CORE-3172 and another one that adds 
> minimal support for unicode database names into engine.

   You moved class WideCharBuffer into os_utils, as suggested, it is ok.
But why you not included it into namespace os_utils ??? Also, i prefer to
see is at separate commit.

> Together they make attached testcase work.
>These patches target only particular issue and are minimal on purpose.

   Does POSIX requires any changes for this issue ?

>Question: should I commit them at once or separately?

   I see two questions in statement above.

Vlad

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] FB 3 RC2 never asks last byte byte for isc_info_svc_stdin

2016-03-15 Thread Jiří Činčura
Nobody from core team?

-- 
Mgr. Jiří Činčura
Independent IT Specialist


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Adriano dos Santos Fernandes
On 15/03/2016 09:18, Dimitry Sibiryakov wrote:
> 15.03.2016 13:13, Alex Peshkoff wrote:
>>   first of all I
>> want to know how was it tested - what environments and what tasks.
>Testcase was attached. Only operations relevant to CORE-3172 were tested: 
> creation of 
> database and attach. The rest is untouched by patch and will require separate 
> testcases 
> and separate decisions.
>
You should at least test every code path related to the functions you
changed the input/output code page, like code paths related to files
names in databases (external files, shadows, whatever).

Also should test old client (which cannot use utf8_filename dpb)
connecting to new (with your change, and already one without it)
checking it work as originally.


Adriano


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 03:18 PM, Dimitry Sibiryakov wrote:
> 15.03.2016 13:13, Alex Peshkoff wrote:
>>first of all I
>> want to know how was it tested - what environments and what tasks.
> Testcase was attached. Only operations relevant to CORE-3172 were tested: 
> creation of
> database and attach. The rest is untouched by patch and will require separate 
> testcases
> and separate decisions.
>

What _environments_?
What OS-es, what codepages/charsets?
You should check services, you should check trace.
Currently your patch breaks more than fixes. :(


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 13:13, Alex Peshkoff wrote:
>   first of all I
> want to know how was it tested - what environments and what tasks.

   Testcase was attached. Only operations relevant to CORE-3172 were tested: 
creation of 
database and attach. The rest is untouched by patch and will require separate 
testcases 
and separate decisions.

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 03:05 PM, Dimitry Sibiryakov wrote:
> 14.03.2016 9:49, Dimitry Sibiryakov wrote:
>>Agreement?
>
>   Silence is an agreement, huh?..
>
>   In attachment you can find patch for CORE-3172 and another one that 
> adds minimal support for unicode database names into engine. Together 
> they make attached testcase work.
>   These patches target only particular issue and are minimal on purpose.
>   Question: should I commit them at once or separately?
>

I like an idea of making internals more & more UTF8, but first of all I 
want to know how was it tested - what environments and what tasks.


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] File lookup

2016-03-15 Thread Alex Peshkoff
On 03/15/2016 12:40 PM, Dimitry Sibiryakov wrote:
> 15.03.2016 10:33, Alex Peshkoff wrote:
>> Where do we have races in_current_  codebase?
> Dunno, you told about them.
>

I've said that _if_ you remove filenames comparison from 
initAttachment() in jrd.cpp or make it case-insensitive on posix there 
_will be_ races.
Current code seems to be ok - at least intensive tests did not show 
races/deadlocks in it.

And be sure - existing in FB3 combination of db-list mutex 
(databases_mutex) and per-database mutex (dbb_init_fini) arrived not 
because we have a desire to make code more complex. It was absolutely 
necessary to release databases_mutex because keeping it locked too long 
(like it was pre fb-2.5) caused various deadlocks. One of them I 
remember - it was related to external databases, but it was not the only 
one. If you want to make this code better please contact privately - I 
will try to explain why I had to add all that checkouts which are 
present in the code.



--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] RFC: File names with non-ASCII non-ANSI letters

2016-03-15 Thread Dimitry Sibiryakov

14.03.2016 9:49, Dimitry Sibiryakov wrote:

   Agreement?


  Silence is an agreement, huh?..

  In attachment you can find patch for CORE-3172 and another one that adds minimal 
support for unicode database names into engine. Together they make attached testcase work.

  These patches target only particular issue and are minimal on purpose.
  Question: should I commit them at once or separately?

--
  WBR, SD.


CORE-3172.patch.7z
Description: Binary data


UniBasic.patch.7z
Description: Binary data


CORE-3127.cpp.7z
Description: Binary data
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


[Firebird-devel] [FB-Tracker] Reopened: (CORE-3172) DPB flag isc_dpb_utf8_filename don't work

2016-03-15 Thread Dimitry Sibiryakov (JIRA)

 [ 
http://tracker.firebirdsql.org/browse/CORE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dimitry Sibiryakov reopened CORE-3172:
--

Planning Status: Considered for inclusion

This ticket is not a duplicate because is caused not by lack of Unicode support 
in engine, but unnesessary recoding of UTF-8 file names into ANSI code page in 
Y-valve on client side, which completely beats the idea behind 
isc_dpb_utf8_filename flag.

> DPB flag isc_dpb_utf8_filename don't work
> -
>
> Key: CORE-3172
> URL: http://tracker.firebirdsql.org/browse/CORE-3172
> Project: Firebird Core
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: 2.5.0
> Environment: Case 1 : Windows Server / Windows Client
> Case 2 : Linux Server / Windows Client
>Reporter: Pierre Yager
> Attachments: CORE-3127.cpp.7z
>
>
> While trying to implement support to utf8_filename DPB flag into UIB 
> Components we cannot pass any test.
> 1) I created a database with a system charset filename in either server, then 
> I renamed it to unicode charset using the operating system commands (Rename 
> on Windows, mv on Linux). For instance I choosed this name : привет.fdb
> 2) I succeded accessing the database on the Linux server using ISQL on both 
> Linux and Windows clients. On Windows client the database name has to be 
> specified in an input file, on Linux client, the filename can be specified 
> either as a command line argument or in an input file but neither allow to 
> specify the connexion string within the ISQL console prompt.
> 3) On Windows clients, accessing such databases is impossible. I gave a look 
> at the Firebird engine core and It seems that the algorithm to resolve file 
> names is : 
> read filename; 
> if not isc_dpb_utf8filename then 
>   ISC_SystemToUTF8(filename); 
> ISC_UTF8ToSystem(filename);
> Open(filename)
> So the filename is always accessed using an ANSI filename throught ANSI API 
> on Windows.
> On Linux SystemToUTF8/UTF8ToSystem functions are void and fopen((char*)) is 
> UTF8 compliant.
> 4) Within the Delphi (2010, Full Unicode) client using the latest UIB 
> Components I tried different compositions between adding the utf8_filename 
> flag or not, transcoding the database name to utf8 or not... 
> Results : 
> * utf8_filename flag : ON - Filename : UTF8 : I get this error : Cannot 
> transliterate character between character sets / Connection error / Error 
> Code: 652
> * utf8_filename flag : OFF - Filename : UTF8 : I get this error : I/O error 
> during "open" operation for file "/db/├É┬┐├æÔé¼├É┬©├É┬▓├É┬Á├æÔÇÜ.fdb"
> Error while trying to open file
> No such file or directory
> Unsuccessful execution caused by a system error that precludes successful 
> execution of subsequent statements
> Error Code: 24
> * utf8_filename flag : ON - Filename : Ansi : the filename is sent as 
> ?.fdb because there is no russian chars in the Win1252 charset
> * utf8_filename flag : OFF - Filename : Ansi : same as above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

   

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] GitHub

2016-03-15 Thread Lester Caine
On 15/03/16 02:24, Jim Starkey wrote:
> The combination of cmake and git submodules would let the Firebird 
> project to be decomposed in clean, separate, architecturally independent 
> projects, a win-win all around.

The key statement there is the 'combination of'. Although the facilities
provides by the git version of submodules have improved, it is reliant
on a combination of tools to make things work that we used to have in a
single package.

http://blogs.atlassian.com/2011/12/git-submodules/ check out the
'gotcha' although I find the problem is more to do with the selected
submodules being a particular snapshot, rather than an active element
you can update.

-- 
Lester Caine - G8HFL
-
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] File lookup

2016-03-15 Thread Dimitry Sibiryakov
15.03.2016 10:33, Alex Peshkoff wrote:
> Where do we have races in_current_  codebase?

   Dunno, you told about them.

-- 
   WBR, SD.

--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel


Re: [Firebird-devel] File lookup

2016-03-15 Thread Alex Peshkoff
On 03/14/2016 08:56 PM, Dimitry Sibiryakov wrote:
> 14.03.2016 18:39, Alex Peshkoff wrote:
>> Do you suggest to lock db list mutex from yvalve? And from network
>> server? :)
> This is a separate discussion about thread races on database file 
> creation and open, if
> you haven't noticed. Y-valve has nothing to do with that.
>

Where do we have races in _current_ codebase?


--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel