Re: [Flightgear-devel] Photo scenery patch: request for help
I have tested these modifications to the master branch and in order for the photos to be shown in the terrain, the shadder effect (inside the Rendering Options menu) needs to be set to Performance (0); Otherwise the regular terrain materials will show. I believe that this patch is a great addition to the Scenery development as it brings us closer to what you will most likely see when flying over that region, and I do second Peter's request for most savvy and expert members to add this change as a part of the master branch. IB -Original Message- From: fgphotoscenery [mailto:fgphotoscen...@yahoo.com] Sent: Monday, March 26, 2012 12:35 AM To: flightgear-devel@lists.sourceforge.net Subject: [Flightgear-devel] Photo scenery patch: request for help This is a request for help to see if his patch could be put into flightgear. I do not understand enough of flightgear to be able to push this forward myself. My only involvement in all this are some scenery images I made that use his patch (http://fgphotoscenery.square7.ch, http://www.flightgear.org/forums/viewtopic.php?f=5t=15174). On my machine at least, also some modification of terrain-default.eff is necessary, because when using Benoit's patch as he made it, the standard texture is covering the photo texture except for very small regions like streets and just around airports. This is due to the fact that terrain-default.eff has evolved since Benoit made that patch of course. Because I don't know enough about the shaders, I only could make a very violent modification to terrain-default.eff that would allow me to see the photo texture on top. This modification does break a lot of the shading as Vivian and Frederic immediately pointed out. The request for help therefore also includes to have a look at what needs to be modified in terrain-default.eff in order to show the photo texture without breaking all the rest. -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Photo scenery patch: request for help
Not sure if this adds anything new, but digging in old email, I found Tim's review of the photo scenery patch from about a year ago. I'm not sure if the patch was updated since (or even if it's really the same at all), but there were two issues/questions then: 1. It unconditionally uses texture unit 3 in the terrain fragment shader even if no photo-realistic texture has been found. 2. It seems to blend the photo textures with the default material textures using the alpha value of the photo texture, but that isn't documented anywhere.. The purpose wasn't really clear then - i.e. why would you want to blend something photo realistic with a material texture in the first place. To get the patch into Git, Tim asked for the first issue to be fixed, so there was no impact unless photo textures were actually used. And he tried to discuss the second point. There wasn't any follow up/reply from the author though (at least, none that I'm aware of - which of course could just mean they switched to French ;-) ). cheers, Thorsten -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Photo scenery patch: request for help
Yes, this does add something new, at least to me. It is very likely that the discussion in the old email you found is the exact same patch. Benoit's version of the patch on his website is dated 24th of March 2011. Was this email exchange on some public forum (devel list/gitorious) so that I could have a look? I could then also contact Tim (Moore?) in order to see if there was a follow-up. Maybe he also has an idea of how much work it could probably be to address the two questions. Peter - Ursprüngliche Message - Von: ThorstenB bre...@gmail.com An: FlightGear developers discussions flightgear-devel@lists.sourceforge.net CC: Gesendet: 20:14 Montag, 26.März 2012 Betreff: Re: [Flightgear-devel] Photo scenery patch: request for help Not sure if this adds anything new, but digging in old email, I found Tim's review of the photo scenery patch from about a year ago. I'm not sure if the patch was updated since (or even if it's really the same at all), but there were two issues/questions then: 1. It unconditionally uses texture unit 3 in the terrain fragment shader even if no photo-realistic texture has been found. 2. It seems to blend the photo textures with the default material textures using the alpha value of the photo texture, but that isn't documented anywhere.. The purpose wasn't really clear then - i.e. why would you want to blend something photo realistic with a material texture in the first place. To get the patch into Git, Tim asked for the first issue to be fixed, so there was no impact unless photo textures were actually used. And he tried to discuss the second point. There wasn't any follow up/reply from the author though (at least, none that I'm aware of - which of course could just mean they switched to French ;-) ). cheers, Thorsten -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Photo scenery patch: request for help
Benoit Laniel has developed a patch to fgdata and simgear that allows to add photo scenery images to flightgear very easily (http://blaniel.free.fr/pub/flightgear/brest/). It was first used for the second version of the Brest scenery. Unfortunately contacting Benoit failed several times and people I asked have not heard of him for a long time, hopefully he is fine. This is a request for help to see if his patch could be put into flightgear. I do not understand enough of flightgear to be able to push this forward myself. My only involvement in all this are some scenery images I made that use his patch (http://fgphotoscenery.square7.ch, http://www.flightgear.org/forums/viewtopic.php?f=5t=15174). On my machine at least, also some modification of terrain-default.eff is necessary, because when using Benoit's patch as he made it, the standard texture is covering the photo texture except for very small regions like streets and just around airports. This is due to the fact that terrain-default.eff has evolved since Benoit made that patch of course. Because I don't know enough about the shaders, I only could make a very violent modification to terrain-default.eff that would allow me to see the photo texture on top. This modification does break a lot of the shading as Vivian and Frederic immediately pointed out. The request for help therefore also includes to have a look at what needs to be modified in terrain-default.eff in order to show the photo texture without breaking all the rest. Benoit's patches for the current master branches (including my change to terrain-default.eff) can be found here: http://fgphotoscenery.square7.ch/photo_2.7.0.patch.zip. Would anybody be willing to take this up? The photo scenery enthusiasts definitely would be extremely grateful. Cheers, Peter -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel