Re: Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page
> > notification updates (they're cached) are only a hassle because they're > logged Agreed. In development, the extra logs make debugging more difficult; performance is not the motivation. On Thu, Dec 7, 2017 at 10:08 AM, Daniel Lobato Garcia <elobat...@gmail.com> wrote: > On 12/06, Ohad Levy wrote: > > On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines <wrai...@redhat.com> > wrote: > > > > > > Oh yeah, especially notifications. Why can't they just update when > the > > > page updates? > > > > > > I think it would be good to move the notifications to a websocket > approach > > > instead of polling. I know, I know, PRs welcome :) > > > > > > > We can consider using SSE for sending notifications too, but I'm > uncertain > > how it would play with passenger. a more reliable approach would probably > > be to start using redis + websockets additional service proxied by apache > > (and webpack in development) > > I tried to make the Job Invocations donut chart work with ActionCable > (so yeah, WebSockets): > > https://github.com/dlobatog/foreman/tree/actioncable , needs > foreman_remote_execution to work > > Unfortunately.. > https://www.phusionpassenger.com/library/config/apache/ > action_cable_integration/ > > If anyone wants to spend time changing our stack to be Passenger > standalone behind an Apache proxy, I'd welcome the change but I am not > sure whether that's worth the effort/possible bugs/etc.. > > Having said that, notification updates (they're cached) are only a > hassle because they're logged. At least I don't notice any slowness or > anything, especially since they're cached. > > > > > Ohad > > > > > > > > On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy <ohadl...@gmail.com> wrote: > > > > > >> > > >> > > >> On Dec 6, 2017 12:19 PM, "Ivan Necas" <ine...@redhat.com> wrote: > > >> > > >> The only concern, as the users are used to the auto-refresh, once we > turn > > >> that off, they can start thinking the thing got stuck. > > >> > > >> > > >> In that case let's keep updating the talk progress without replacing > the > > >> entire tab? > > >> > > >> > > >> -- Ivan > > >> > > >> On Wed, 6 Dec 2017 at 17:50, Ohad Levy <ohadl...@gmail.com> wrote: > > >> > > >>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink <akof...@redhat.com> > > >>> wrote: > > >>> > > >>>> As part of this I would love to see *all* auto reloads default to > off > > >>>>> > > >>>> > > >>> +1 - PR are welcomes ;) > > >>> > > >>> > > >>>> Oh yeah, especially notifications. Why can't they just update when > the > > >>>> page updates? > > >>>> > > >>>> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines <wrai...@redhat.com> > > >>>> wrote: > > >>>> > > >>>>> > I think the refresh should still be off by default. > > >>>>> > > >>>>> As part of this I would love to see *all* auto reloads default to > > >>>>> off. The dashboard, for example, constantly reloading by default > is > > >>>>> annoying to me. > > >>>>> > > >>>>> Cheers, > > >>>>> Walden > > >>>>> > > >>>>> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink <akof...@redhat.com > > > > >>>>> wrote: > > >>>>> > > >>>>>> Hello, > > >>>>>> > > >>>>>> We have the option of toggling auto-refresh on individual tasks, > but > > >>>>>> I often find myself at the foreman_tasks#tasks page > intermittently clicking > > >>>>>> the search button to monitor the state of automated tasks (in my > case, > > >>>>>> usually bats content/proxy tests). I'm proposing a button or an > option > > >>>>>> under the search drop down button to enable/disable auto refresh. > I think > > >>>>>> the refresh should still be off by default. > > >>>>>> > > >>>>>> Any comments? > > >>>>>> > > >>>>>> - Andrew > > >>>>>>
Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page
> > As part of this I would love to see *all* auto reloads default to off Oh yeah, especially notifications. Why can't they just update when the page updates? On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines <wrai...@redhat.com> wrote: > > I think the refresh should still be off by default. > > As part of this I would love to see *all* auto reloads default to off. > The dashboard, for example, constantly reloading by default is annoying to > me. > > Cheers, > Walden > > On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink <akof...@redhat.com> wrote: > >> Hello, >> >> We have the option of toggling auto-refresh on individual tasks, but I >> often find myself at the foreman_tasks#tasks page intermittently clicking >> the search button to monitor the state of automated tasks (in my case, >> usually bats content/proxy tests). I'm proposing a button or an option >> under the search drop down button to enable/disable auto refresh. I think >> the refresh should still be off by default. >> >> Any comments? >> >> - Andrew >> >> -- >> Andrew Kofink >> akof...@redhat.com >> IRC: akofink >> Software Engineer >> Red Hat Satellite >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page
Hello, We have the option of toggling auto-refresh on individual tasks, but I often find myself at the foreman_tasks#tasks page intermittently clicking the search button to monitor the state of automated tasks (in my case, usually bats content/proxy tests). I'm proposing a button or an option under the search drop down button to enable/disable auto refresh. I think the refresh should still be off by default. Any comments? - Andrew -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nominating additional maintainers in foreman-core
+1 to both! On Wed, Dec 6, 2017 at 9:14 AM, Ohad Levy <ohadl...@gmail.com> wrote: > > > On Dec 6, 2017 7:41 AM, "Tomer Brisker" <tbris...@redhat.com> wrote: > > Hello, > As many of you may have noticed, foreman-core open PR count has been in > the area of 100-110 for most of the last few months. There are only a few > people with merge access that actively review PRs, so that the time it > takes for changes to be accepted can take long. I would like to propose > granting merge access to two more members of the community: > > Shimon Shtein - has 75 merged commits [1] and has taken part in the > reviews of 64 merged commits[2]. > Michael Moll - has 71 merged commits [3] and has taken part in the reviews > of 130 merged commits[4]. He is also already a long time maintainer of > several of our other repos and has proven to be a responsible maintainer. > > Please send +1/-1 either to the list or to me in private if you prefer. > Per our process, unless I receive any objections within a week, I will > request one of the organization owners to grant them access. > > > +1 to both :) > > > [1] https://github.com/theforeman/foreman/pulls?q=is%3Apr+author > %3Ashimshtein+is%3Aclosed > [2] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93 > =is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+ > [3] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93 > =is%3Apr+author%3Ammoll+is%3Aclosed+ > [4] https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93 > =is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+ > > -- > Have a nice day, > Tomer Brisker > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Unique IDs and UI testing automation
Seems reasonable to me. I don't really see a downside other than the work to add all the IDs. On Wed, Nov 29, 2017 at 1:08 PM, Walden Raines <wrai...@redhat.com> wrote: > Hey, > > In order to assist in UI automation, I would like to propose that we add > unique IDs to the following elements: > >- Tables and table rows (s) >- All inputs, including those not technically in a form (row select >checkboxes, for example) >- All buttons > > These IDs should all follow the same format, perhaps something like > object.class-object.id-element.type. For example, product-2-row and > product-2-checkbox. > > Thoughts on this? Anything that needs to be added or changed? > > Thanks, > Walden > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Proposal: Foreman 1.18 = 2.0
+1 to 2.0 and removing API v1! Oh, and 2.0 should cook breakfast. Also, should we bump Katello to 4.0? Just a thought. On Wed, Nov 29, 2017 at 8:49 AM, Bernhard Suttner <sutt...@atix.de> wrote: > I also like the idea of a version 2.0 very much. Personally, I would be > very happy to move bastion from katello to foreman so that it's possible to > create modern, angular js components within foreman. One more reason to do > this is, because I think foreman should be the structure, the base > "framework" all other plugins like katello can live in. Just my thoughts... > > Best regards, > Bernhard Suttner > > ATIX - The Linux & Open Source Company > https://www.atix.de > > -Ursprüngliche Nachricht- > > Von:Lukas Zapletal <l...@redhat.com> > > Gesendet: Mittwoch 29 November 2017 14:18 > > An: foreman-dev <foreman-dev@googlegroups.com> > > Betreff: Re: [foreman-dev] Proposal: Foreman 1.18 = 2.0 > > > > > Bikeshedding about SemVer aside, I'm good with doing a 2.0 release in > > > the near future, but *please* lets use it to deprecate / drop stuff we > > > no longer want to maintain. Otherwise there's no real point to it. > > > > I agree we can take this "opportunity" to drop some deprecated things > > like V1 API, but I don't see many other things. We are pretty good in > > deprecating things using our "two releases" rule which should be > > followed no matter if we bump major version or not. > > > > Let's not block 2.0 with any feature, I wrote the reasons, if we fit > > in some deprecation work why not. But's let's agree on 2.0 timeframe > > regardless of any planning. > > > > -- > > Later, > > Lukas @lzap Zapletal > > > > -- > > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Community-developed Ansible modules for Foreman API objects
Yeah, modules have to be written in Python for inclusion in Ansible core [1]. [1] http://docs.ansible.com/ansible/latest/dev_guide/developing_modules_checklist.html On Wed, Nov 29, 2017 at 4:40 AM, Ewoud Kohl van Wijngaarden < ew...@kohlvanwijngaarden.nl> wrote: > I had a look at this at some point but what I really dislike about Hammer > as an API is that the JSON output is also capitalized and inconsistent. > Ended up with large mappings and quickly gave up. Maybe I missed something > and it can be done easily. > > > On Wed, Nov 29, 2017 at 09:35:46AM +, Sean O'Keeffe wrote: > >> Here's a radical thought, use Hammer... >> >> Ansible modules do not have to be written in Python[2], although Ansible >> does provide some nice shortcuts with Python, all that is really required >> is JSON output... Some Ruby examples [1] >> A couple of things to note if we were to entertain going down this route; >> - How does DOCUMENTATION work for non-python modules? I played around for >> a >> bit, but couldn't get ansible-doc to work.. >> - If the goal is to get them into Ansible core, will they accept Ruby >> modules? Looking at Ansible core I think all the modules are python... >> >> >> [1] https://github.com/ansible/ansible-for-rubyists >> [2] >> http://ansible-docs.readthedocs.io/zh/stable-2.0/rst/ >> developing_modules.html >> >> On Fri, Oct 27, 2017 at 8:11 PM, Michael Hofer < >> michael.ho...@adfinis-sygroup.ch> wrote: >> >> On Wed, 25 Oct 2017 08:09:10 -0400 >>> Andrew Kofink <akof...@redhat.com> wrote: >>> [...] >>> > If given a choice, I would vote for Nailgun, a more mature project with >>> > more contributors and guaranteed future contribution from Satellite QA. >>> > There is a bit of a gap between foreman-ansible-modules and Nailgun, >>> given >>> > that it is not purpose built; for this, we do include >>> > ansible_nailgun_cement.py [1]. >>> > >>> > I appreciate the support and interest from the community. >>> >>> So far we've only used python-foreman in a few different projects, one to >>> configure Foreman based on a YAML file. We use python-foreman to resolve >>> the >>> IDs first thus the actual names of the templates, etc. can be used. >>> Working >>> with the lib is nice but it still needs some glue because the API is >>> inconsistent and doing a lookup for the ID is not aligned for all >>> resources. >>> >>> I have no experience with nailgun but from my point of view dependencies >>> are >>> not that big of a deal when provided as proper packages. E.g. to use the >>> Ansible mysql_db module you require python-mysqldb. >>> >>> I'd love to switch to an upstream Ansible module to configure Foreman and >>> improve our existing playbooks. >>> >>> Thanks for all the hard work so far! >>> >> > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Kanban tools and redmine
I'm open to using other kanban style tools. To me it doesn't really matter that much how we plan - it's the same information just in a different format. So, if people have reasons, then I'm fine with switching. On Tue, Nov 28, 2017 at 4:29 PM, Walden Raines <wrai...@redhat.com> wrote: > Hey, > > With several teams moving to kanban style tools for the visualization of > tasks I'm wondering if anyone has tried redmine's PluginKanban [1]. > > I really like the idea of a trello/kanboard like tool but I hate having to > update tasks in multiple places. Another idea I had was to switch (back) > to using GH issues and use GH projects [2] as well. > > Any other thoughts on how to make these kanban boards work better with > redmine? > > Cheers, > Walden > > [1] http://www.redmine.org/projects/redmine/wiki/PluginKanban > [2] https://help.github.com/articles/about-project-boards/ > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Propsing a move from Google Groups to Discourse
I had the opportunity to more thoroughly explore Discourse over the holiday, and I really love it! I think most users will already be used to this forum style interface (quasi Stack Exchange). I really like the features of voting and marking replies as The Answer. You've convinced me! I encourage others to go play around with it as well. I think you'll find it more familiar than you might think. On Thu, Nov 9, 2017 at 8:33 AM, Greg Sutcliffe <g...@emeraldreverie.org> wrote: > On 08/11/17 17:01, Ivan Necas wrote: > > And, if we meet in some time (let's say 6 months from the kick off) > > and look at the numbers, I think it would be much easier discussion > > if we should ditch the list or not. Additionally, we would have 6 > > months of hands on experience with Discourse. > > I'm going to assume we're talking about side-by-side for a single > channel (i.e the users list). I'll focus on that, but I remain open to > the option of running -dev on a list and -users on a forum, we can make > that work. Still not my top choice, but doable. > > So, I'm all for following the data - in fact I'm actually studying Data > Science at the moment in my spare time so I can be better at this for > our community metrics in general (this course [1], good fun). > > What I think you're proposing is that we measure the amount of activity > on both platforms after 6 months, and then use that as an indicator of > how much people *like* each platform. The problem is that this > experiment contains both systemic bais and a confounding variable. > > Firstly, the systemic bias: people will stay where the conversation is > (i.e. the network effect). Unless everyone moves, no-one does. If we had > zero users on both platforms at the start, this could probably be > accounted for, but that's not the case. > > Secondly, the counfounding variable (nemesis of all data scientists). > You're suggesting that "amount of activity" on a given platform (X) can > be used to infer "willingness to use" that platform (Y). But this > doesn't account for the procrastination problem (there are studies, I > picked a couple [2,3]). People don't change if they don't *have* to, > however much better the alternative is. So there's a variable affecting > X but not Y that we can't account for, which means we can't use it for > inference. > > > I'm not suggesting 100% agreement, on the other hand I'm serious > > about listening carefully to the people that actually ARE active in > > the community. > > 100% agree with that, that's exactly what this thread is for. I'll post > that summary I mentioned shortly to try and loop some more voices in. > > Cheers, > Greg > > [1] https://www.coursera.org/specializations/jhu-data-science > > [2] Opt-in vs opt-out organ donation - much higher donation rate with > opt-out. People could *save lives* by filling out a form, and they don't. > > https://bmcmedicine.biomedcentral.com/articles/10.1186/s12916-014-0131-4 > > [3] Electricity costs. 14 million houses in the UK could be saving £200 > per year (2016 data), but they don't switch. UK is actually > considerating putting automatic tariff switching into law because people > are so bad at this. > > https://www.gov.uk/government/publications/household-energy- > savings-through-switching-supporting-evidence/many- > households-could-save-around-200-per-year-through- > switching-energy-supplier-basis-for-claim > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Nominating cfouant for write access to hammer-cli-katello
I hereby nominate Christine Fouant to gain commit access to hammer-cli-katello. She currently has 12 merged PRs <https://github.com/search?utf8=%E2%9C%93=author%3Acfouant+repo%3AKatello%2Fhammer-cli-katello+is%3Amerged=Issues> and has helped to review 11 merged PRs <https://github.com/search?utf8=%E2%9C%93=commenter%3Acfouant+-author%3Acfouant+repo%3AKatello%2Fhammer-cli-katello+is%3Amerged=> . Let the +/-1's begin! -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Forklift now requires Ansible >= 2.4
Hello, Forklift <https://github.com/theforeman/forklift> [1] now requires at least Ansible 2.4 as of this PR <https://github.com/theforeman/forklift/pull/554> [2]. It should be available from the extras repository in EL7. [1] https://github.com/theforeman/forklift [2] https://github.com/theforeman/forklift/pull/554 Andrew -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Propsing a move from Google Groups to Discourse
I admit, I skimmed the prior emails (they were tl). I just wanted to ask if discourse is searchable/is indexed from the wider internet. I've often found relevant mailing list discussions by searching from Google, and I really value that. - Andrew On Wed, Nov 1, 2017 at 12:04 PM, Greg Sutcliffe <g...@emeraldreverie.org> wrote: > One more point, we're currently on a free tier of our SMTP provider, > which is limited to 6k emails / month & 200 mails / day. > > I'm seeing if I can negotiate a free higher tier for a FOSS project, > but for now, go easy on the mail testing :D > > Greg > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge Permissions for Katello/katello
Thanks everyone! On Tue, Oct 31, 2017 at 9:47 PM, Justin Sherrill <jlsherr...@gmail.com> wrote: > Given its been a number of days with no -1's, I've now granted you access! > > Congrats! > > Justin > > On Tue, Oct 31, 2017 at 9:36 PM, Eric D Helms <eric.d.he...@gmail.com> > wrote: > >> +1 >> >> On Oct 31, 2017 10:17 AM, "Walden Raines" <wrai...@redhat.com> wrote: >> >>> +1, figured you already had merge permissions. >>> >>> On Tue, Oct 31, 2017 at 8:16 AM, Brad Buckingham <bbuck...@redhat.com> >>> wrote: >>> >>>> +1 to providing Andrew with merge permissions!! >>>> >>>> On Fri, Oct 27, 2017 at 10:25 AM, Andrew Kofink <akof...@redhat.com> >>>> wrote: >>>> >>>>> Hello, >>>>> >>>>> I'm not sure why I waited so long to ask, but in light of other >>>>> requests, I submit my own. Here are my merged PRs >>>>> <https://github.com/search?utf8=%E2%9C%93=author%3Aakofink+repo%3AKatello%2Fkatello+is%3Amerged=Issues>, >>>>> and here are other PRs I've helped review >>>>> <https://github.com/search?utf8=%E2%9C%93=commenter%3Aakofink+-author%3Aakofink+repo%3AKatello%2Fkatello+is%3Amerged=>. >>>>> Do you consent to giving me the mighty power of the Green Button? >>>>> >>>>> Andrew >>>>> >>>>> -- >>>>> Andrew Kofink >>>>> akof...@redhat.com >>>>> IRC: akofink >>>>> Software Engineer >>>>> Red Hat Satellite >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "foreman-dev" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to foreman-dev+unsubscr...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "foreman-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to foreman-dev+unsubscr...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "foreman-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to foreman-dev+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge permissions for Katello/katello
+1 On Tue, Oct 31, 2017 at 8:17 AM, Brad Buckingham <bbuck...@redhat.com> wrote: > +1 from me as well! > > On Fri, Oct 27, 2017 at 9:19 AM, John Mitsch <jomit...@redhat.com> wrote: > >> +1 from me! >> >> John Mitsch >> Red Hat Engineering >> (860)-967-7285 <(860)%20967-7285> >> irc: jomitsch >> >> On Thu, Oct 26, 2017 at 4:00 PM, Jonathon Turel <jtu...@gmail.com> wrote: >> >>> Hey folks, >>> >>> The time has come (through some helpful suggestions) that I should make >>> my request to have $subject bestowed upon me. If you'd like to see some of >>> my contributions to Katello here are my merged PRs >>> <https://github.com/search?utf8=%E2%9C%93=author%3Ajturel+repo%3AKatello%2Fkatello+is%3Amerged=Issues> >>> and PRs I've otherwise participated in >>> <https://github.com/search?utf8=%E2%9C%93=commenter%3Ajturel+-author%3Ajturel+repo%3AKatello%2Fkatello+is%3Amerged=>. >>> Looking forward to contributing more as I continue to come up to speed. >>> What do you all think? >>> >>> Thanks! >>> >>> Jonathon >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "foreman-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to foreman-dev+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Merge permission for theforemen/foreman-ansible-modules
+1 from me! We have benefited greatly from Matthias' contributions in foreman-ansible-modules. If you'd like to see some of his work, here are his merged PRs <https://github.com/search?utf8=%E2%9C%93=author%3Amdellweg+repo%3Atheforeman%2Fforeman-ansible-modules+is%3Amerged=Issues>, and here are all the PRs he has helped to review <https://github.com/search?utf8=%E2%9C%93=commenter%3Amdellweg+-author%3Aakofink+repo%3Atheforeman%2Fforeman-ansible-modules+is%3Amerged=> . On Mon, Oct 30, 2017 at 11:34 AM, Matthias Dellweg <dell...@atix.de> wrote: > Hello, > i was just encouraged, to ask for merge/push permission in > theforeman/foreman-ansible-modules. > I have contributed to this repository almost since the beginning (yes, > it's a very young one), > and did a hand full of reviews that lead to constructive discussions. The > collaboration with > Andrew, Eric and Evgeni have always been very fruitful from my perspective. > For co-inventing the DRY glue layer 'cement' (with fobheb), github > classifies me as the top > garbage collector with by far the most removed lines. > > I ask you kindly to vote, whether i shall be entrusted with the power of > the merge. > Thanks for considering, > Matthias > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Heads up - hound rubocop version updated
I created an issue in Katello [1] to track the changes there. We may assign someone [who isn't there] during today's triage. [1] http://projects.theforeman.org/issues/21468 On Wed, Oct 25, 2017 at 7:32 AM, Tomer Brisker <tbris...@redhat.com> wrote: > Hi, > > Hound have updated their version of rubocop to 0.51 which includes some > rule name changes. I have opened a PR [1] to foreman-core to upgrade to the > latest version and updated the todo file. > All plugins using rubocop should make sure their .rubocop.yaml is > compatible with the new version. > > Hound ignores the rubocop version specified in the gemfile, which means > that it will start barking on every PR in repos that use it if the settings > are incompatible, and once the PR is merged into foreman core, those > plugins depending on core and running rubocop on jenkins will start failing. > > The changes to rubocop's rule names can be foun in their changelog [2], > or by manually running rubocop version 0.51 with your current configuration > and looking out for errors. In case the errors are in the > .rubocop_todo.yaml file, it can be automatically regenerated by running > `rubucop --auto-gen-config` (but keep in mind this will disable any > currently failing cops). > > > [1] https://github.com/theforeman/foreman/pull/4949 > [2] https://github.com/bbatsov/rubocop/blob/master/CHANGELOG.md > > -- > Have a nice day, > Tomer Brisker > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] FactoryGirl renamed to FactoryBot - plugin maintainer action needed
I went ahead and made an issue for Katello [1]. I'll submit a PR today with the changes. [1] http://projects.theforeman.org/issues/21458 On Wed, Oct 25, 2017 at 9:12 AM, Tomer Brisker <tbris...@redhat.com> wrote: > Hello, > > The Thoughtbot team have decided to rename the factory_girl gem, which we > depend on for tests, to factory_bot [1]. This led to our CI breaking due to > the name change. For now, we have pinned factory_girl to the last working > version to unblock CI, but we should prepare to change to the new name. > > This requires, basically, changing every occurrence of `FactoryGirl` to > `FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the > name change, no other changes were made to the API. > > Marek has opened a PR[2] for fixing this in foreman-core, however once > this is merged it will break tests for all plugins depending on the core > factory_girl. To prevent prolonged breakage, all plugin maintainers should > work to prepare a PR making the above mentioned change, so that it can be > merged once core PR is merged. > > To give you some time to fix this and prevent breakage, the core PR will > be merged one week from today, on November 1st. Please make sure you are > prepared to correctly handle this change in your plugin. If needed, feel > free to reach out to me, Marek, or any of the other core maintainers. > > [1] https://github.com/thoughtbot/factory_bot/issues/921 > [2] https://github.com/theforeman/foreman/pull/4935 > > -- > Have a nice day, > Tomer Brisker > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Community-developed Ansible modules for Foreman API objects
Nailgun is used for Satellite's QA for testing the API. It's not purpose-built for Ansible, but it is generally written as a Python library for Satellite's API. We get 'free' maintenance/features with Nailgun because the QA team contributes to it (we have access as well). Nailgun seems to have similar dependencies to python-foreman (i.e. requests). > - I would overwrite the nailgun using modules like foreman_ptable.py etc. We still need to discuss what we will do with duplicate modules (whether to use python-foreman or nailgun). If there are modules that don't exist in foreman-ansible-modules, we would appreciate PRs for those. - there is no place to put Ansible module documentation fragments into like > utils/module_docs_fragments/foreman.py I would say just create utils/module_docs_fragments in your PR. If given a choice, I would vote for Nailgun, a more mature project with more contributors and guaranteed future contribution from Satellite QA. There is a bit of a gap between foreman-ansible-modules and Nailgun, given that it is not purpose built; for this, we do include ansible_nailgun_cement.py [1]. I appreciate the support and interest from the community. [1] https://github.com/theforeman/foreman-ansible-modules/blob/master/module_utils/ansible_nailgun_cement.py Andrew On Tue, Oct 24, 2017 at 3:47 PM, Thomas Krahn <thomas.krahn...@gmail.com> wrote: > Hi all, > > as the maintainer of the Ansible Foreman modules > <https://github.com/Nosmoht/ansible-module-foreman> i would like to share > my thoughts with you. > > First of all i really like the idea to bring Foreman modules into Ansible. > The complete configuration of Foreman is much easier if you can use > Infrastructure as Code. > That was the reason why i started the implementation in March 2015. At > this time Ansible didn't have the module_utils folder and modules had to be > "self contained". > So the only way to use shared code was to create a Python library and use > it. My result of that constraint is the Python Foreman library > <https://github.com/Nosmoht/python-foreman>. > It was and still is a challenge to always sync the modules and the library > functionality. > > As far as i can see Nailgun is the library to work with Satellite 6 API. > > In regards to the future used library i see three different options so far: > 1. nailgun > 2. python-foreman > 3. Ansible's module_utils. > > I don't want to talk about functionality here, but more about constraints > and dependencies. > If either nailgun or python-foreman is used people would have to install > the library to use the Ansible modules and could have the same sync issue > like i had in the past. > Besides that i believe the library would have even more dependencies > (python-requests for example) which could make things even more worst. > On the other hand people would have a Python library that could even be > used outside of Ansible for other tasks. > > If all that stuff is put into Ansible's module_utils folder we wouldn't > have any sync issue nor external dependencies, but the usage would be > limited to Ansible. > And Ansible provides a great framework that abstracts a lot of things > (methods like fetch_url() and open_url()) that otherwise would have to be > reimplemented. > > Long term speaking i believe a common Python library would be the winner > as it provides a standardized and well tested Foreman/Satellite interface > to the world. > > I'm not sure how far the nailgun development is, but python-foreman is > open source and i'm happy to hand out the ownership of that repository. > > > > Next topic: Ansible modules > > I've already done a lot of work to move the modules from python-foreman + > modules into "everything in Ansible". > Means all the library stuff goes into module_utils/foreman.py plus all the > modules in modules/cloud/foreman/*.py. > Nearly 75% of that work is done so i could open a PR for each module that > is already finished. > If that's something the community would like to see...let's do it :-) > > I wanted to commit that code into https://github.com/theforeman/ > foreman-ansible-modules but had some issue. > - I would overwrite the nailgun using modules like foreman_ptable.py etc. > - there is no place to put Ansible module documentation fragments into > like utils/module_docs_fragments/foreman.py > > If anyone has an idea how to fix that let me know ;) > > > Happy to see how it's going on > Nosmoht > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visi
Re: [foreman-dev] Centralizing tool_belt in theforeman Github
+1 I guess the foreman and katello config files will still live separately (i.e. katello_35.yaml and foreman_16.yaml) but in the same repo. On Mon, Oct 23, 2017 at 5:59 AM, Daniel Lobato Garcia <elobat...@gmail.com> wrote: > On 10/20, Eric D Helms wrote: > > For quite a few releases now, we've been using a little tool named > > tool_belt as a CLI to perform release tasks such as finding cherry picks, > > or building koji configurations. The larger idea of the repository is you > > define a release via a configuration file and perform various release > > actions based on the data within the config file. The original repository > > lives on my personal Github account [1]. At some point, this was forked > to > > theforeman organization and configurations for just Foreman stored in it. > > Meanwhile, in the original repository are configs for Katello releases. > > > > I would like to propose merging the configuration files from theforeman > to > > my original repository, deleting thetheforeman fork and then transferring > > my repository to theforeman to serve as the single shared repository. If > > you have any concerns, objections or questions please raise them here. > > > > If there are no objections, I will perform this next Wednesday or > Thursday. > > > > > > [1] https://github.com/ehelms/tool_belt > > [2] https://github.com/theforeman/tool_belt > > > > -- > > Eric D. Helms > > Red Hat Engineering > > > > -- > > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > +1, I would also like to merge https://github.com/dlobatog/foreman_release > into that repository, making each of the scripts a subcommand of tool_belt > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Found In Version Katello Redmine custom field
RFC: Because Katello is a nested project under Foreman in Redmine, we can only see Foreman versions in the "version" field. It would be great to have a custom text box field "Found In Version" that bug reporters can provide the exact RPM they installed to see the issue. Let me know if you would find this useful. -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Redmine running slowly
Me as well. It's quite difficult to work this way. On Tue, Oct 10, 2017 at 10:40 AM, Dirk Götz <goetz.dir...@gmail.com> wrote: > Now Redmine seems to be down completely. Only getting 404 or 502 errors > since an half hour. > > Regards, > Dirk > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Proposed drop of supporting ruby 2.0 in hammer
+1 out with the old On Tue, Oct 10, 2017 at 8:00 AM, Michael Moll <kved...@kvedulv.de> wrote: > On Tue, Oct 10, 2017 at 01:45:42PM +0200, Ewoud Kohl van Wijngaarden wrote: > > On Tue, Oct 10, 2017 at 01:21:36PM +0200, Tomas Strachota wrote: > > >we recently encountered a compatibility issue with older version of > > >Clamp that we use on ruby 2.0 installations. Latest Clamp releases > > >require ruby 2.1+. See [1] for some more details. > > > > > >The easiest solution seems to be dropping ruby 2.0 support, which was > > >eol 2016-02-24 anyway. We use scl with ruby 2.2 on rpm based distros, > > >so we should be safe there. > > Support for Trusty has been dropped in 1.16 and 1.17 will drop Jessie. > > Focussing on 2.1+ or 2.2+ should be no problem. > > exactly. > -- > Michael Moll > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Nomination for an additional GitHub org owner
+1 for Eric! On Mon, Jun 26, 2017 at 4:12 AM, Ivan Necas <ine...@redhat.com> wrote: > Marek Hulán <mhu...@redhat.com> writes: > > > +1 > > +1 > > > > > On pondělí 26. června 2017 7:41:18 CEST Ondrej Prazak wrote: > >> +1 from me > >> > >> On Mon, Jun 26, 2017 at 3:16 AM, Tom McKay <thomasmc...@redhat.com> > wrote: > >> > +1 for @ehelms > >> > > >> > On Fri, Jun 23, 2017 at 9:05 AM, Neil Hanlon <nhan...@kayak.com> > wrote: > >> >> +1 from me :) > >> >> > >> >> On Fri, Jun 23, 2017 at 8:44 AM Greg Sutcliffe < > greg.sutcli...@gmail.com> > >> >> > >> >> wrote: > >> >>> Hi all, > >> >>> > >> >>> Slightly different to our usual "nominate a new commiter" process, > but > >> >>> I'm wondering if we need to appoint a new owner on our GitHub > >> >>> organisation? > >> >>> > >> >>> Currently, only Dominic and Ohad are owners, and they are both > >> >>> frequently busy with other things, which leads to some delays when > >> >>> adding in new repos or moving things about. 2 people is also a > fairly > >> >>> high bus factor. I think it's time we added a third name to the > owners > >> >>> - we don't have an official process for this, but I'm treating like > >> >>> commit access, so here's a nomination email. > >> >>> > >> >>> Obviously, this is mainly a role for maintenance - creating/forking > >> >>> repos, moving them, creating new teams, etc. rather than about > merging > >> >>> code. I think a we have a few people that would be a good fit - my > >> >>> suggestion would be Eric Helms. He's experienced both in our > structure > >> >>> & in GitHub-y stuff, and is in a different timezone, which helps if > >> >>> something comes up out of European hours. > >> >>> > >> >>> Any comments/concerns/upvotes? :) > >> >>> > >> >>> Cheers > >> >>> Greg > >> >>> > >> >>> -- > >> >>> You received this message because you are subscribed to the Google > >> >>> Groups "foreman-dev" group. > >> >>> To unsubscribe from this group and stop receiving emails from it, > send > >> >>> an email to foreman-dev+unsubscr...@googlegroups.com. > >> >>> For more options, visit https://groups.google.com/d/optout. > >> >> > >> >> -- > >> >> You received this message because you are subscribed to the Google > Groups > >> >> "foreman-dev" group. > >> >> To unsubscribe from this group and stop receiving emails from it, > send an > >> >> email to foreman-dev+unsubscr...@googlegroups.com. > >> >> For more options, visit https://groups.google.com/d/optout. > >> > > >> > -- > >> > You received this message because you are subscribed to the Google > Groups > >> > "foreman-dev" group. > >> > To unsubscribe from this group and stop receiving emails from it, > send an > >> > email to foreman-dev+unsubscr...@googlegroups.com. > >> > For more options, visit https://groups.google.com/d/optout. > > > > > > -- > > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Organization titles in CLI
Correct. If there are 2 orgs with the same name under different parents, then not specifying `--parent` would result in an error such as "More than one record found". On Tue, Apr 11, 2017 at 7:08 AM, Tomas Strachota <tstra...@redhat.com> wrote: > I'm not sure I understand. It is currently possible to update parents > of organizations. Did you mean to use the parent parameter as a > compound identifier together with names? > > i.e. for changing a name and a parent you would use: > $ hammer organization update --name Brno --parent EMEA --new-name Krno > --new-parent ... > > and for info: > $ hammer organization info --name Brno --parent EMEA > > Did I understand it correctly? > > > On Mon, Apr 10, 2017 at 6:12 PM, Andrew Kofink <akof...@redhat.com> wrote: > > Tomas, > > > > Would it be easier to print the parent with list/info commands and allow > > updating that attribute (i.e. --parent/--parent-id)? We already have a > > handler in the ID resolver when multiple records are returned when only > one > > is expected, though the error message does not tell the user how to > further > > filter the results. > > > > - Andrew > > > > On Mon, Apr 10, 2017 at 11:09 AM, Tomas Strachota <tstra...@redhat.com> > > wrote: > >> > >> I recently found out hammer uses only short names for identifying > >> organizations. Names aren't globally unique, which makes it impossible > >> to modify or delete an org when there are two of the same name but > >> nested under a different parent org. See [1] for details. > >> > >> I opened a preliminary PR [2] that adds option --organization-title to > >> all commands that consume taxonomies and a column "Title" to output of > >> the list command. This is simple solution, consistent with how it > >> works in hostgroups, but I don't think it's the best from the > >> usability point of view. Both options --name and --title as well as > >> table column labels feel redundant (columns contain the same data if > >> orgs aren't nested). > >> > >> An alternative approach is to completely replace names with labels in > >> hammer internally. We would have to change id resolver and let the > >> list commands print titles (in a column labeled "Name"). That's how > >> it's displayed in UI. > >> > >> Pros: > >> - users wouldn't notice the change, it should be seamless in most > cases > >> - no need to add extra options > >> - consistent with the UI, where column labeled "Name" contains > >> titles in taxonomy tables > >> > >> Cons: > >> - name isn't the same as title and it might not feel natural to update > >> as: > >> hammer location update --name 'emea/brno' --new-name 'krno' which > >> would then be displayed as 'emea/krno' > >> > >> The con I mentioned could be fixed by checking if a user passed a name > >> containing '/' and using only last part of title in such cases. That > >> would make even --new-name 'emea/krno' work. > >> > >> Theoretically it could be used also for changing organizations parent. > >> --name 'emea/brno' --new-name 'europe/krno' would change parent to an > >> organization with title 'europe' and rename to 'krno'. But that's > >> maybe too much. > >> > >> How do you find the alternative approach? Do you see any other options > >> how the commands could work? Any idea is welcome. > >> I'd like to change hostgroup commands to use the same style and make > >> it consistent across the whole cli when we find a good solution. Are > >> there any commands in plugins (looking mainly at hammer-cli-katello) > >> that use resources with nested names? > >> > >> T. > >> > >> [1] http://projects.theforeman.org/issues/19157/ > >> [2] https://github.com/theforeman/hammer-cli-foreman/pull/299 > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "foreman-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an > >> email to foreman-dev+unsubscr...@googlegroups.com. > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > -- > > Andrew Kofink > > akof...@redhat.com > > IRC: akofink > > Associate Software Engineer > > Red Hat Satellite > > > > -- > > You received this message because
Re: [foreman-dev] Organization titles in CLI
Tomas, Would it be easier to print the parent with list/info commands and allow updating that attribute (i.e. --parent/--parent-id)? We already have a handler in the ID resolver when multiple records are returned when only one is expected, though the error message does not tell the user how to further filter the results. - Andrew On Mon, Apr 10, 2017 at 11:09 AM, Tomas Strachota <tstra...@redhat.com> wrote: > I recently found out hammer uses only short names for identifying > organizations. Names aren't globally unique, which makes it impossible > to modify or delete an org when there are two of the same name but > nested under a different parent org. See [1] for details. > > I opened a preliminary PR [2] that adds option --organization-title to > all commands that consume taxonomies and a column "Title" to output of > the list command. This is simple solution, consistent with how it > works in hostgroups, but I don't think it's the best from the > usability point of view. Both options --name and --title as well as > table column labels feel redundant (columns contain the same data if > orgs aren't nested). > > An alternative approach is to completely replace names with labels in > hammer internally. We would have to change id resolver and let the > list commands print titles (in a column labeled "Name"). That's how > it's displayed in UI. > > Pros: > - users wouldn't notice the change, it should be seamless in most cases > - no need to add extra options > - consistent with the UI, where column labeled "Name" contains > titles in taxonomy tables > > Cons: > - name isn't the same as title and it might not feel natural to update > as: > hammer location update --name 'emea/brno' --new-name 'krno' which > would then be displayed as 'emea/krno' > > The con I mentioned could be fixed by checking if a user passed a name > containing '/' and using only last part of title in such cases. That > would make even --new-name 'emea/krno' work. > > Theoretically it could be used also for changing organizations parent. > --name 'emea/brno' --new-name 'europe/krno' would change parent to an > organization with title 'europe' and rename to 'krno'. But that's > maybe too much. > > How do you find the alternative approach? Do you see any other options > how the commands could work? Any idea is welcome. > I'd like to change hostgroup commands to use the same style and make > it consistent across the whole cli when we find a good solution. Are > there any commands in plugins (looking mainly at hammer-cli-katello) > that use resources with nested names? > > T. > > [1] http://projects.theforeman.org/issues/19157/ > [2] https://github.com/theforeman/hammer-cli-foreman/pull/299 > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Link to redmine issues using prprocessor
Greg, If you would like to start a discussion for inclusion of MIQ bot, please start a new thread. :) On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe <greg.sutcli...@gmail.com> wrote: > While we're talking about modifying PrProcessor, some of the automatic > and requested task options in the MIQ bot are pretty cool - maybe we > should steal^W copy those in? :P. I can definitely see uses for > add/remove labels, at least. > > https://github.com/ManageIQ/miq_bot?#automatic-tasks > > Greg > -- > IRC / Twitter: @gwmngilfen > Diaspora: gwmngil...@joindiaspora.com > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Link to redmine issues using prprocessor
I have made the change to amend the body of the pull request with the links to the issues, which shouldn't send a new notification/email. This will be a per-repo configuration. If you'd like for a repository to be included in the change, please let me know via email, or comment on the pull request <https://github.com/theforeman/prprocessor/pull/59>. I already added katello/katello, katello/hammer-cli-csv, and katello/hammer-cli-katello. - Andrew On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe <greg.sutcli...@gmail.com> wrote: > While we're talking about modifying PrProcessor, some of the automatic > and requested task options in the MIQ bot are pretty cool - maybe we > should steal^W copy those in? :P. I can definitely see uses for > add/remove labels, at least. > > https://github.com/ManageIQ/miq_bot?#automatic-tasks > > Greg > -- > IRC / Twitter: @gwmngilfen > Diaspora: gwmngil...@joindiaspora.com > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Link to redmine issues using prprocessor
I find myself copying/pasting issue numbers from GitHub PRs to a redmine url way too much every day. It takes a bit of time, and it's annoying as well as easy to fix. I've submitted this PR to comment on a newly submitted PR with links to the associated issues in redmine: https://github.com/theforeman/prprocessor/pull/59 I'd like to hear your thoughts if you have something to say about it. - Andrew -- Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Hammer Development Box
Hello Foreman community! If you need to work on hammer or one of its plugins, please check out the hammer development box <https://github.com/Katello/forklift/blob/master/docs/development.md#hammer-development> in forklift. It's just hammer, not Foreman/Katello, so you'll need to point it to a running server, as the instructions note. Do let me know if you have any questions! Andrew Kofink akof...@redhat.com IRC: akofink Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] Extend Foreman Facets to Allow Adding Included Attributes
Hello Semion, I'd like to contribute to the Foreman Facet API so it can be used to add included ActiveRecord attributes. This change is motivated by this comment on a Katello pull request <https://github.com/Katello/katello/pull/6236/files#diff-243193e44ff7150915ec447e89b4e205R24> . That pull request is trying to add content_view, lifecycle_environment, etc. to the host object that is passed to the view to avoid N+1 query warnings and increase performance of that page. I was told by Ori that you would be a good person to ask for ideas on how to implement this change in Foreman. Any help is greatly appreciated. Regards, Andrew Kofink akof...@redhat.com Associate Software Engineer Red Hat Satellite -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Possible to move redmine Katello project under Foreman?
+1 to less separation of the two projects in our overhead organization of issues/features. Andrew Kofink Software Engineering Intern Red Hat Satellite 6 akof...@redhat.com On Wed, Aug 3, 2016 at 4:08 AM, Marek Hulán <mhu...@redhat.com> wrote: > +1 for moving into Foreman project subtree > > -- > Marek > > On Tuesday 02 of August 2016 17:36:53 Ivan Necas wrote: > > I think having everything under one tree makes sense. Long-term, the > > goal is to turn > > Katello to not feel like a separate project, but rather an extension. > > > > +1 > > > > Of course I'm not aware of some possible consequences if there are any? > > > > -- Ivan > > > > On Tue, Aug 2, 2016 at 3:56 PM, Tom McKay <thomasmc...@redhat.com> > wrote: > > > As we try to work towards better bugzilla and redmine component > > > definitions > > > and relations, I keep finding myself wishing I could use redmine for > both > > > foreman and katello issues together. > > > > > > For example, several dev teams are experimenting with redmine > "versions" > > > for their sprints[1]. I don't think that a single version can include > > > issues from both foreman and katello projects. If katello was a > > > subproject of foreman, though, then teams could bring any issue into > > > their sprint view. > > > > > > Is there a case for keeping katello separate any longer, or can we > > > combine? > > > > > > [1] > > > > http://projects.theforeman.org/projects/foreman/roadmap#Team_Ivan_Iteratio > > > n_1 > > > > > > -- > > > You received this message because you are subscribed to the Google > Groups > > > "foreman-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send > an > > > email to foreman-dev+unsubscr...@googlegroups.com. > > > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] Hammer CLI Options for ID Resolution
Tomas,
Here's the issue: http://projects.theforeman.org/issues/15830
The affected commands are quite widespread. Since the 6.2 release, there
have been 2 bug reports that duplicate 15830. Any command that has content
views or lifecycle environments as a non-primary option with ID resolution
(i.e. hostgroups create/update, content-view filter create/update) are most
likely affected. We really need to get this fixed before the 6.3
development freeze, and right now, hammer-cli-katello development could be
blocked if there's a non-related bug on an affected command.
I'd be happy to chat with you tomorrow. How about 3pm your time? I will
send you a calendar invite.
Andrew Kofink
Software Engineering Intern
Red Hat Satellite 6
akof...@redhat.com
On Wed, Jul 27, 2016 at 3:10 PM, Tomas Strachota <tstrach...@redhat.com>
wrote:
> Hi Andrew,
>
> searchables are meant to be used only for storing alternative identifiers
> for a resource. That's why they're always prefixed in options. Together
> with *_id params from index action of the resource they create compound
> identifier. I understand it makes it very difficult to use in your case,
> but I wouldn't change the searchables behaviour (for now). The whole thing
> deserves deeper refactoring. I put my ideas into a RFC [1] and I would be
> glad if you could add more issues you encountered with this part of code
> and review the proposal. I hope that together we can make it more readable
> and usable.
>
> Until we do the proper refactoring I'd stay with my previous proposal.
> Feel free to ping me and we can discuss it via hangout. Can you please send
> me the issue you're working on or what commands are affected? I'll take a
> look at it prior to our chat.
>
> T.
>
> [1] https://github.com/theforeman/rfcs/pull/8
>
>
> On 07/26/2016 08:30 PM, Andrew Kofink wrote:
>
>> Tomas,
>>
>> Right now, if I add a searchable for organization-id to the
>> :content_views resource, the option is scoped as
>> --content-view-organization-id. I think it may be beneficial to modify
>> the DependentSearchablesOptionBuilder in hammer-cli-foreman to accept
>> another option, scope_to_resource. This option would default to 'true',
>> and the behavior would remain as is, but if it's set to 'false', this
>> logic
>> <
>> https://github.com/theforeman/hammer-cli-foreman/blob/master/lib/hammer_cli_foreman/option_builders.rb#L232
>> >
>> would change to make the option at the top level (i.e. --organization-id
>> instead of --content-view-organization-id). Here's what I was thinking:
>> https://gist.github.com/akofink/c1682bfbdf70e848deeed7be6eb31063
>>
>> The SEARCHABLES array would accept options like this:
>>
>> SEARCHABLES = {
>>:hostgroup => [
>> s_name(_("Hostgroup name")),
>> s("title", _("Hostgroup title"), editable: false,
>> scope_to_resource: false)
>>]
>> }
>>
>> I wanted to run this by you before beginning work on it to make sure it
>> seems sensible. Also, since the logic wouldn't be Katello specific, the
>> change should be able to go into hammer-cli-foreman; Extending the
>> DependentSearchablesOptionBuilder from hammer-cli-katello seems like it
>> might get messy.
>>
>> Thanks,
>>
>> Andrew Kofink
>>
>> Software Engineering Intern
>> Red Hat Satellite 6
>> akof...@redhat.com <mailto:akof...@redhat.com>
>>
>> On Tue, Jul 26, 2016 at 5:01 AM, Tomas Strachota <tstrach...@redhat.com
>> <mailto:tstrach...@redhat.com>> wrote:
>>
>> On 07/22/2016 09:01 PM, Andrew Kofink wrote:
>>
>> Hi Team (especially Martin and Tomas),
>>
>> I've been banging my head on the table for a few days now, so I
>> thought
>> I would just ask:
>>
>> I want to resolve a content view by its name; currently,
>> content_views#index has no required parameters, so no automatic
>> options
>> are generated. I would like to add the option to search for the
>> content
>> view by organization_id, and I also want hammer to add the
>> options for
>> resolving that organization_id from the organization_name and
>> organization_label. Lastly, and probably most important, I want
>> this to
>> happen any time the option --content-view-id is added to a
>> command.
>>
>> This works downstream because organization_id is a required
>> parameter on
>> content_views#index, but upstream is currently broken due to a
>>
[foreman-dev] Ruby 1.9.3 Support in HammerCLI
Since Ruby 1.9.3. is no longer maintained <https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/>, we'd like to drop support in the hammer-cli gems. Foreman 1.12 drops support for 1.9.3 already. One known caveat is Ubuntu Trusty (14.04), which mmoll knows how to deal with. Please voice your opinions/objections. Thanks! Andrew Kofink Software Engineering Intern Red Hat Satellite 6 akof...@redhat.com -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
