Re: [foreman-dev] HoundCI - annoying?
I feel actually quite the opposite, we used to have Hound via some external service and this feels much better integrated. Since github introduced reviews, Hound integration could take advantage of it in the future? They will implode once a review is confirmed, that could help. On the other hand, we should definitely not insist on all Hound checks what "community think is a good practice". We have discussed that, there were flamewars on this topic here already :-) And we did great job in trying to find the balance. If you have suggestions, just make a PR with the checkstyle changes. LZ On Wed, Jan 11, 2017 at 5:18 PM, Timo Goebel wrote: > Hi devs, > > I'm usually not very easily annoyed. What get's me started though eventually > is when things don't work properly. > HoundCI is one of those things. > > My main concern is, that I get an e-mail and/or Github notification for > every single comment. These can easily be ten or more e-mails. They're not > grouped as other reviews. > In addition, the inline comments are very distracting when reviewing a PR > imho. When the issues are fixed, I'd prefer for the comments to be removed. > When reviewing a PR, I usually don't care about the style issues. I just > want to see if there are some problems or if all is fine. > > Back in the days, code style was checked by Jenkins. I think, it did a far > better job in displaying style issues. With the current Jenkins Github > plugin it believe would be easily possible to show style issues as a > separate line along with all the other CI checks. > > One argument in favor of HoundCI is, that it checks JavaScript style. But I > think, that can easily be set up in Jenkins as well by running eslint. > > Any comments? How do others feel? > > Timo > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Later, Lukas @lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] HoundCI - annoying?
On 01/11, Timo Goebel wrote: > Hi devs, > > I'm usually not very easily annoyed. What get's me started though > eventually is when things don't work properly. > HoundCI is one of those things. > > My main concern is, that I get an e-mail and/or Github notification for > every single comment. These can easily be ten or more e-mails. They're not > grouped as other reviews. > In addition, the inline comments are very distracting when reviewing a PR > imho. When the issues are fixed, I'd prefer for the comments to be removed. > When reviewing a PR, I usually don't care about the style issues. I just > want to see if there are some problems or if all is fine. > > Back in the days, code style was checked by Jenkins. I think, it did a far > better job in displaying style issues. With the current Jenkins Github > plugin it believe would be easily possible to show style issues as a > separate line along with all the other CI checks. I don't think it did a better job displaying the issues. I do remember having to point up people to the exact jenkins page where rubocop failures showed up, as it wasn't immediately obvious what happened. Inline comments show new contributors what's failing right there. That was my motivation for using Hound, also Javascript linting and saving us the trouble of having more jobs in jenkins was also a nice side benefit > > One argument in favor of HoundCI is, that it checks JavaScript style. But I > think, that can easily be set up in Jenkins as well by running eslint. > > Any comments? How do others feel? > > Timo > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. signature.asc Description: PGP signature
Re: [foreman-dev] HoundCI - annoying?
Hi, I agree that it is annoying to get a ton of messages from hound every time a new version of rubocop is released or when they change something in their default setup. Hound is working on using the review api but are currently running into some issues with it: https://github.com/houndci/hound/pull/1262 It is nice to get the comments inline instead of having to go over the jenkins log to find what didn't work, and using hound also freed up a bit of the jenkins capacity. However, I don't have a strong objection to going back to jenkins, especially if we could prevent tests from running if there are rubocop errors. On Thu, Jan 12, 2017 at 9:48 AM, Marek Hulán wrote: > Hello, > > yes, I find it annoying and I liked the jenkins job more. It would be > great if > hound would be able to use reviews that would generate one email per > review. > Hopefully they work on it. Otherwise I'd be for moving back to jenkins. > > On středa 11. ledna 2017 12:07:38 CET David Davis wrote: > > Not sure if it helps you but you can filter out the HoundCI emails by > > checking for emails from "Hound ”. Also, when > a > > HoundCI comment is addressed, isn’t the comment collapsed? > > Sometimes that's annoying as well, the the hound comments in collapsed > thread. > > -- > Marek > > > I agree though that HoundCI doesn’t seem to work properly. On Katello, > > we’ve seen it add inline comments but pass PRs, fail Pos without inline > > comments, and raise inline comments that we’re not seeing when running > > rubocop locally. > > > > Another reason to move to Jenkins is that sometimes HoundCI doesn’t catch > > all the errors that actually rubocop might since it only looks at the > lines > > changed. Like right now, it doesn’t look like rubocop is passing for > > foreman on develop. > > > > > > David > > > > On Wed, Jan 11, 2017 at 11:18 AM, Timo Goebel > wrote: > > > Hi devs, > > > > > > I'm usually not very easily annoyed. What get's me started though > > > eventually is when things don't work properly. > > > HoundCI is one of those things. > > > > > > My main concern is, that I get an e-mail and/or Github notification for > > > every single comment. These can easily be ten or more e-mails. They're > not > > > grouped as other reviews. > > > In addition, the inline comments are very distracting when reviewing a > PR > > > imho. When the issues are fixed, I'd prefer for the comments to be > > > removed. > > > When reviewing a PR, I usually don't care about the style issues. I > just > > > want to see if there are some problems or if all is fine. > > > > > > Back in the days, code style was checked by Jenkins. I think, it did a > far > > > better job in displaying style issues. With the current Jenkins Github > > > plugin it believe would be easily possible to show style issues as a > > > separate line along with all the other CI checks. > > > > > > One argument in favor of HoundCI is, that it checks JavaScript style. > But > > > I think, that can easily be set up in Jenkins as well by running > eslint. > > > > > > Any comments? How do others feel? > > > > > > Timo > > > > > > -- > > > You received this message because you are subscribed to the Google > Groups > > > "foreman-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send > an > > > email to foreman-dev+unsubscr...@googlegroups.com. > > > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Have a nice day, Tomer Brisker Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] HoundCI - annoying?
Hello, yes, I find it annoying and I liked the jenkins job more. It would be great if hound would be able to use reviews that would generate one email per review. Hopefully they work on it. Otherwise I'd be for moving back to jenkins. On středa 11. ledna 2017 12:07:38 CET David Davis wrote: > Not sure if it helps you but you can filter out the HoundCI emails by > checking for emails from "Hound ”. Also, when a > HoundCI comment is addressed, isn’t the comment collapsed? Sometimes that's annoying as well, the the hound comments in collapsed thread. -- Marek > I agree though that HoundCI doesn’t seem to work properly. On Katello, > we’ve seen it add inline comments but pass PRs, fail Pos without inline > comments, and raise inline comments that we’re not seeing when running > rubocop locally. > > Another reason to move to Jenkins is that sometimes HoundCI doesn’t catch > all the errors that actually rubocop might since it only looks at the lines > changed. Like right now, it doesn’t look like rubocop is passing for > foreman on develop. > > > David > > On Wed, Jan 11, 2017 at 11:18 AM, Timo Goebel wrote: > > Hi devs, > > > > I'm usually not very easily annoyed. What get's me started though > > eventually is when things don't work properly. > > HoundCI is one of those things. > > > > My main concern is, that I get an e-mail and/or Github notification for > > every single comment. These can easily be ten or more e-mails. They're not > > grouped as other reviews. > > In addition, the inline comments are very distracting when reviewing a PR > > imho. When the issues are fixed, I'd prefer for the comments to be > > removed. > > When reviewing a PR, I usually don't care about the style issues. I just > > want to see if there are some problems or if all is fine. > > > > Back in the days, code style was checked by Jenkins. I think, it did a far > > better job in displaying style issues. With the current Jenkins Github > > plugin it believe would be easily possible to show style issues as a > > separate line along with all the other CI checks. > > > > One argument in favor of HoundCI is, that it checks JavaScript style. But > > I think, that can easily be set up in Jenkins as well by running eslint. > > > > Any comments? How do others feel? > > > > Timo > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscr...@googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [foreman-dev] HoundCI - annoying?
Not sure if it helps you but you can filter out the HoundCI emails by checking for emails from "Hound ”. Also, when a HoundCI comment is addressed, isn’t the comment collapsed? I agree though that HoundCI doesn’t seem to work properly. On Katello, we’ve seen it add inline comments but pass PRs, fail Pos without inline comments, and raise inline comments that we’re not seeing when running rubocop locally. Another reason to move to Jenkins is that sometimes HoundCI doesn’t catch all the errors that actually rubocop might since it only looks at the lines changed. Like right now, it doesn’t look like rubocop is passing for foreman on develop. David On Wed, Jan 11, 2017 at 11:18 AM, Timo Goebel wrote: > Hi devs, > > I'm usually not very easily annoyed. What get's me started though > eventually is when things don't work properly. > HoundCI is one of those things. > > My main concern is, that I get an e-mail and/or Github notification for > every single comment. These can easily be ten or more e-mails. They're not > grouped as other reviews. > In addition, the inline comments are very distracting when reviewing a PR > imho. When the issues are fixed, I'd prefer for the comments to be removed. > When reviewing a PR, I usually don't care about the style issues. I just > want to see if there are some problems or if all is fine. > > Back in the days, code style was checked by Jenkins. I think, it did a far > better job in displaying style issues. With the current Jenkins Github > plugin it believe would be easily possible to show style issues as a > separate line along with all the other CI checks. > > One argument in favor of HoundCI is, that it checks JavaScript style. But > I think, that can easily be set up in Jenkins as well by running eslint. > > Any comments? How do others feel? > > Timo > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[foreman-dev] HoundCI - annoying?
Hi devs, I'm usually not very easily annoyed. What get's me started though eventually is when things don't work properly. HoundCI is one of those things. My main concern is, that I get an e-mail and/or Github notification for every single comment. These can easily be ten or more e-mails. They're not grouped as other reviews. In addition, the inline comments are very distracting when reviewing a PR imho. When the issues are fixed, I'd prefer for the comments to be removed. When reviewing a PR, I usually don't care about the style issues. I just want to see if there are some problems or if all is fine. Back in the days, code style was checked by Jenkins. I think, it did a far better job in displaying style issues. With the current Jenkins Github plugin it believe would be easily possible to show style issues as a separate line along with all the other CI checks. One argument in favor of HoundCI is, that it checks JavaScript style. But I think, that can easily be set up in Jenkins as well by running eslint. Any comments? How do others feel? Timo -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
