Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Matthias Andree]

Am 12.02.2014 07:20, schrieb Erich Dollansky:
> Hi,
> 
> On Wed, 12 Feb 2014 06:49:28 +0100
> Christoph Moench-Tegeder  wrote:
> 
>> ## Rainer Hurling (rhur...@gwdg.de):
>>
>>> Thanks for this info. So perhaps your situation is like the one,
>>> mandree@ observed on his 10.0 box: no crashes without the patch?
>>
>> Exactly.
> 
> I do not know if this related but my gimp did not work anymore after I
> successfully have had rawtherapee installed. After recompiling gimp-app
> and reinstalling it, also gimp works again.

For me, Gimp still works after installation of rawtherapee, without
recompiling gimp-app, on 9.2-RELEASE.  I hadn't installed gimp on 10.0
prior to installing rawtherapee, but "pkg install gimp-app" also gives
me a working gimp on 10.0-RELEASE-amd64.


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Rainer Hurling]

Am 11.02.2014 23:02 (UTC+1) schrieb Matthias Andree:
> Am 11.02.2014 10:46, schrieb Rainer Hurling:
> 
>> I just recognized another issue, what I think is not intended.
>>
>> Newest graphics/rawtherapee installs and uses devel/libc++. This wanted
>> behaviour is included in the ports Makefile for OpenMP reasons.
>>
>> As a side effect, other ports with c++ usage also seem to grab
>> devel/libc++, even if devel/libc++ is not mentioned in the ports
>> Makefile. You can try this by rebuilding and reinstalling e.g.
>> graphics/darktable. This leads to
> 
> I think that is an artifact of the same library being installed in two
> places.  As far as I understood bapt@ (Cc'd), the idea is that the port
> mirrors the c++ library we have in the base system, and both are
> compatible, and particularly, they have the same ABI.  Basically we need
> the libc++ headers to make use of libc++'s inline namespace so that
> rawtherapee references libc++'s symbols (in the std::__1:: namespace)
> rather than libstdc++ (in the std:: namespace).
> 
> If you are willing to experiment, you should be able to deinstall libc++
> now, and both darktable and rawtherapee should continue to work with the
> base libc++.

Yes, this presumption is right. After 'pkg delete -f libc++-200683
libcxxrt-20131225_1' I am able to use rawtherapee furthermore. So ports
like RawTherapee would also work, when devel/libc++ and devel/libcxxrt
would be deinstalled right after successfull installation of the port.


My problem is more the other side around: Why do ports like e.g.
graphics/darktable pick up the headers from devel/libc++ instead of the
base ones? In darktable there is no devel/libc++ dependency specified.
Installing graphics/darktable, while devel/libc++ is already installed,
creates a dependency.

This will jumble up the dependency list in ports/packages and should not
happen. Only ports with a declared dependency on devel/libc++ should use
this port.

> 
>> #pkg info -r libc++-200683
>> libc++-200683:
>>  rawtherapee-4.0.12_1
>>  darktable-1.2.3_3
>>
>> #ldd /usr/local/bin/darktable | grep c++
>>  libc++.so.1 => /usr/local/lib/libc++.so.1 (0x4690e000)
> 
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Erich Dollansky]

Hi,

On Wed, 12 Feb 2014 06:49:28 +0100
Christoph Moench-Tegeder  wrote:

> ## Rainer Hurling (rhur...@gwdg.de):
> 
> > Thanks for this info. So perhaps your situation is like the one,
> > mandree@ observed on his 10.0 box: no crashes without the patch?
> 
> Exactly.

I do not know if this related but my gimp did not work anymore after I
successfully have had rawtherapee installed. After recompiling gimp-app
and reinstalling it, also gimp works again.

Erich
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Christoph Moench-Tegeder]

## Rainer Hurling (rhur...@gwdg.de):

> Thanks for this info. So perhaps your situation is like the one,
> mandree@ observed on his 10.0 box: no crashes without the patch?

Exactly.

Regards,
Christoph

-- 
Spare Space
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Tijl Coosemans]

On Tue, 11 Feb 2014 23:14:05 +0100 Matthias Andree wrote:
> Am 11.02.2014 22:10, schrieb Rainer Hurling:
>> Am 11.02.2014 21:55, schrieb Christoph Moench-Tegeder:
>>> My base is 10.0-RELEASE, and the port is "totally recent"
>>> (rawtherapee-4.0.12_1, Makefile r343191). converters/libiconv
>>> hadn't been installed until "right now".
>>> OTOH I'm very careful with using umlauts in file names etc. (been bitten
>>> once too often), even as my environment is UTF-8, so I might
>>> have missed that issue when testing.
>> 
>> Thanks for this info. So perhaps your situation is like the one,
>> mandree@ observed on his 10.0 box: no crashes without the patch?
> 
> I am also using 10.0-RELEASE.
> 
> So the question is if someone has (had) problems with rawtherapee on
> 10-*STABLE* (OSVERSION >= 1000500) while glib20 is still at
> glib-2.36.3_1?  Please speak up if you are one of them!
> 
> Because if so that might suggest we are facing regressions
> from 10-RELEASE to 10-STABLE and
> from 10-RELEASE to 11-STABLE.
> 
> That might warrant investigation.

10-RELEASE shipped with a faulty implementation of WCHAR_T conversion,
so it doesn't return an error but it doesn't do the right thing either.
This implementation has been backed out again after the release, so
iconv_open returns -1 again when you request WCHAR_T conversion.
The crash happens when an application doesn't test for errors and
assumes the return value is a valid pointer.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Matthias Andree]

Am 11.02.2014 22:10, schrieb Rainer Hurling:
> Am 11.02.2014 21:55, schrieb Christoph Moench-Tegeder:

>> My base is 10.0-RELEASE, and the port is "totally recent"
>> (rawtherapee-4.0.12_1, Makefile r343191). converters/libiconv
>> hadn't been installed until "right now".
>> OTOH I'm very careful with using umlauts in file names etc. (been bitten
>> once too often), even as my environment is UTF-8, so I might
>> have missed that issue when testing.
> 
> Thanks for this info. So perhaps your situation is like the one,
> mandree@ observed on his 10.0 box: no crashes without the patch?

I am also using 10.0-RELEASE.

So the question is if someone has (had) problems with rawtherapee on
10-*STABLE* (OSVERSION >= 1000500) while glib20 is still at
glib-2.36.3_1?  Please speak up if you are one of them!

Because if so that might suggest we are facing regressions
from 10-RELEASE to 10-STABLE and
from 10-RELEASE to 11-STABLE.

That might warrant investigation.


___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Matthias Andree]

Am 11.02.2014 10:46, schrieb Rainer Hurling:

> I just recognized another issue, what I think is not intended.
> 
> Newest graphics/rawtherapee installs and uses devel/libc++. This wanted
> behaviour is included in the ports Makefile for OpenMP reasons.
> 
> As a side effect, other ports with c++ usage also seem to grab
> devel/libc++, even if devel/libc++ is not mentioned in the ports
> Makefile. You can try this by rebuilding and reinstalling e.g.
> graphics/darktable. This leads to

I think that is an artifact of the same library being installed in two
places.  As far as I understood bapt@ (Cc'd), the idea is that the port
mirrors the c++ library we have in the base system, and both are
compatible, and particularly, they have the same ABI.  Basically we need
the libc++ headers to make use of libc++'s inline namespace so that
rawtherapee references libc++'s symbols (in the std::__1:: namespace)
rather than libstdc++ (in the std:: namespace).

If you are willing to experiment, you should be able to deinstall libc++
now, and both darktable and rawtherapee should continue to work with the
base libc++.

> #pkg info -r libc++-200683
> libc++-200683:
>   rawtherapee-4.0.12_1
>   darktable-1.2.3_3
> 
> #ldd /usr/local/bin/darktable | grep c++
>   libc++.so.1 => /usr/local/lib/libc++.so.1 (0x4690e000)

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Rainer Hurling]

Am 11.02.2014 21:55, schrieb Christoph Moench-Tegeder:
> ## Rainer Hurling (rhur...@gwdg.de):
> 
 *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
>>>
>>> I'm not able to reproduce the original crash (even when playing with
>>> LC_CTYPE and umlauts), and I do not see regressions from that glib
>>> patch.
>>
>> Hmm, is it right, that your base and port (last commit with gcc48
>> dependency) are very recent?
> 
> My base is 10.0-RELEASE, and the port is "totally recent"
> (rawtherapee-4.0.12_1, Makefile r343191). converters/libiconv
> hadn't been installed until "right now".
> OTOH I'm very careful with using umlauts in file names etc. (been bitten
> once too often), even as my environment is UTF-8, so I might
> have missed that issue when testing.

Thanks for this info. So perhaps your situation is like the one,
mandree@ observed on his 10.0 box: no crashes without the patch?

> 
> Regards,
> Christoph
> 

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Christoph Moench-Tegeder]

## Rainer Hurling (rhur...@gwdg.de):

> >> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
> > 
> > I'm not able to reproduce the original crash (even when playing with
> > LC_CTYPE and umlauts), and I do not see regressions from that glib
> > patch.
> 
> Hmm, is it right, that your base and port (last commit with gcc48
> dependency) are very recent?

My base is 10.0-RELEASE, and the port is "totally recent"
(rawtherapee-4.0.12_1, Makefile r343191). converters/libiconv
hadn't been installed until "right now".
OTOH I'm very careful with using umlauts in file names etc. (been bitten
once too often), even as my environment is UTF-8, so I might
have missed that issue when testing.

Regards,
Christoph

-- 
Spare Space
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Rainer Hurling]

Am 11.02.2014 20:27, schrieb Christoph Moench-Tegeder:
> ## Matthias Andree (mand...@freebsd.org):
> 
>> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
> 
> I'm not able to reproduce the original crash (even when playing with
> LC_CTYPE and umlauts), and I do not see regressions from that glib
> patch.

Hmm, is it right, that your base and port (last commit with gcc48
dependency) are very recent?

Just to be sure ;)

Greetings,
Rainer

> 
> Regards,
> Christoph
> 

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Christoph Moench-Tegeder]

## Matthias Andree (mand...@freebsd.org):

> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*

I'm not able to reproduce the original crash (even when playing with
LC_CTYPE and umlauts), and I do not see regressions from that glib
patch.

Regards,
Christoph

-- 
Spare Space
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Tijl Coosemans]

On Mon, 10 Feb 2014 23:24:06 +0100 Matthias Andree wrote:
> Am 10.02.2014 18:08, schrieb Erich Dollansky:
>> it depends obviously on factors we do not really know. I also have had
>> a working rawtherapee a few weeks ago. Just the last update of the
>> ports tree killed it again.
> 
> Greetings,
> 
> thanks to Waitman who debugged things over the weekend, we have a prime
> suspect, and that's an insufficient iconv() set on FreeBSD 10 and newer
> that for some users makes glib20 and glibmm together throw an exception
> when asked to convert UTF-8 to wchar_t that Rawtherapee does not catch
> nor report.  We may also have a solution, which I am asking you to test.
> 
> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
> 
> 1. download Koop's patch to glib20 from
>

You might want to mention in the iconv:wchar_t comment that the actual
use of "WCHAR_T" is in glibmm.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Rainer Hurling]

Am 11.02.2014 10:09 (UTC+1) schrieb Matthias Andree:
> (stripping Cc: list down a bit)
> 
> Am 11.02.2014 09:54, schrieb Rainer Hurling:
> 
>>> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
>>
>> I just tried RawTherapee after rebuilding devel/glib20 with the iconv
>> related patch, and it works flawlessly! Some small test with filters and
>> converting also seem to work.
>>
>> This is on HEAD r261632 amd64. RawTherapee is build with gcc48 and
>> OpenMP support.
>>
>> Once, if there is an official patch in the ports tree, is it recommended
>> to rebuild all dependencies of glib20?
> 
> Unless there will be other changes to glib20 outside the patch, that
> would not be required.  The patch to glib20 does not change its ABI to
> applications (its 'consumers', so to say), so just reinstalling glib20
> so that it uses libiconv rather than libc for iconv*() functions would
> suffice (and on FreeBSD 8.x and 9.x, glib20 always uses libiconv.)
> 
>>> 1. download Koop's patch to glib20 from
>>>
>>>
>>> 2. apply the patch, build and install glib20 with the patch
>>>
>>> 3. try *and report* if that fixes the rawtherapee crashes?
>>
>> Many thanks to not give up with this issue! RawTherapee is a great raw
>> processor for both, amateurs and professionals. And it is one of that
>> great programs, we want to use on different platforms (including Windows).
> 
> Unfortunately the code base is less sound than we would like for a
> portable application.  I've read a few upstream crash issues and RT
> seems a pig to debug.

I just recognized another issue, what I think is not intended.

Newest graphics/rawtherapee installs and uses devel/libc++. This wanted
behaviour is included in the ports Makefile for OpenMP reasons.

As a side effect, other ports with c++ usage also seem to grab
devel/libc++, even if devel/libc++ is not mentioned in the ports
Makefile. You can try this by rebuilding and reinstalling e.g.
graphics/darktable. This leads to

#pkg info -r libc++-200683
libc++-200683:
rawtherapee-4.0.12_1
darktable-1.2.3_3

#ldd /usr/local/bin/darktable | grep c++
libc++.so.1 => /usr/local/lib/libc++.so.1 (0x4690e000)

I don't know, if this is harmless or if this should not happen?

Once again, this is on HEAD r261632 amd64.

Any comments or ideas?

Regards,
Rainer
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Matthias Andree]

(stripping Cc: list down a bit)

Am 11.02.2014 09:54, schrieb Rainer Hurling:

>> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*
> 
> I just tried RawTherapee after rebuilding devel/glib20 with the iconv
> related patch, and it works flawlessly! Some small test with filters and
> converting also seem to work.
> 
> This is on HEAD r261632 amd64. RawTherapee is build with gcc48 and
> OpenMP support.
> 
> Once, if there is an official patch in the ports tree, is it recommended
> to rebuild all dependencies of glib20?

Unless there will be other changes to glib20 outside the patch, that
would not be required.  The patch to glib20 does not change its ABI to
applications (its 'consumers', so to say), so just reinstalling glib20
so that it uses libiconv rather than libc for iconv*() functions would
suffice (and on FreeBSD 8.x and 9.x, glib20 always uses libiconv.)

>> 1. download Koop's patch to glib20 from
>>
>>
>> 2. apply the patch, build and install glib20 with the patch
>>
>> 3. try *and report* if that fixes the rawtherapee crashes?
> 
> Many thanks to not give up with this issue! RawTherapee is a great raw
> processor for both, amateurs and professionals. And it is one of that
> great programs, we want to use on different platforms (including Windows).

Unfortunately the code base is less sound than we would like for a
portable application.  I've read a few upstream crash issues and RT
seems a pig to debug.

___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Rainer Hurling]

Am 10.02.2014 23:24 (UTC+1) schrieb Matthias Andree:
> Am 10.02.2014 18:08, schrieb Erich Dollansky:
> 
>> it depends obviously on factors we do not really know. I also have had
>> a working rawtherapee a few weeks ago. Just the last update of the
>> ports tree killed it again.
> 
> Greetings,
> 
> thanks to Waitman who debugged things over the weekend, we have a prime
> suspect, and that's an insufficient iconv() set on FreeBSD 10 and newer
> that for some users makes glib20 and glibmm together throw an exception
> when asked to convert UTF-8 to wchar_t that Rawtherapee does not catch
> nor report.  We may also have a solution, which I am asking you to test.

I also whish to thank Waitman for his debugging work :)

> *Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*

I just tried RawTherapee after rebuilding devel/glib20 with the iconv
related patch, and it works flawlessly! Some small test with filters and
converting also seem to work.

This is on HEAD r261632 amd64. RawTherapee is build with gcc48 and
OpenMP support.

Once, if there is an official patch in the ports tree, is it recommended
to rebuild all dependencies of glib20?

> 1. download Koop's patch to glib20 from
>
> 
> 2. apply the patch, build and install glib20 with the patch
> 
> 3. try *and report* if that fixes the rawtherapee crashes?

Many thanks to not give up with this issue! RawTherapee is a great raw
processor for both, amateurs and professionals. And it is one of that
great programs, we want to use on different platforms (including Windows).

Greetings,
Rainer

> Thanks.
> 
> Best regards
> Matthias
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

PATCH: Re: graphics/rawtherapee: r342622 crashes on HEAD

[Matthias Andree]

Am 10.02.2014 18:08, schrieb Erich Dollansky:

> it depends obviously on factors we do not really know. I also have had
> a working rawtherapee a few weeks ago. Just the last update of the
> ports tree killed it again.

Greetings,

thanks to Waitman who debugged things over the weekend, we have a prime
suspect, and that's an insufficient iconv() set on FreeBSD 10 and newer
that for some users makes glib20 and glibmm together throw an exception
when asked to convert UTF-8 to wchar_t that Rawtherapee does not catch
nor report.  We may also have a solution, which I am asking you to test.

*Can everyone who has rawtherapee crash on FreeBSD 10 or 11 please:*

1. download Koop's patch to glib20 from
   

2. apply the patch, build and install glib20 with the patch

3. try *and report* if that fixes the rawtherapee crashes?

Thanks.

Best regards
Matthias
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"