[Freeciv-Dev] [bug #13812] Two bug trackers?
URL: http://gna.org/bugs/?13812 Summary: Two bug trackers? Project: Freeciv Submitted by: rfalke Submitted on: Monday 06/29/2009 at 09:15 Category: freeciv.org Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: There is the old RT-based bug tracker at http://bugs.freeciv.org which is also linked from the Wiki main page (http://freeciv.wikia.com/wiki/Main_Page) and than there is a bug tracker I'm posting this. Is there a reason why the old tracker is still online? ___ Reply to this item at: http://gna.org/bugs/?13812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13802] [Patch] Invalid iterator for NULL hash tables
Follow-up Comment #1, bug #13802 (project freeciv): It is really needed? Couldn't it be performed by adding a test in the iterating marco like: if (NULL != hash)? ___ Reply to this item at: http://gna.org/bugs/?13802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
URL: http://gna.org/bugs/?13814 Summary: segfault in assess_danger_player Project: Freeciv Submitted by: mbook Submitted on: Monday 06/29/2009 at 18:07 Category: general Severity: 4 - Important Priority: 7 - High Status: Confirmed Assigned to: mbook Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: I have confirmed the crash, it occurs fairly regularly after a few turns in trunk if I just set all units to auto-explore at the start of the game. On 26/06/2009, Jordi Negrevernis i Font jnegrever...@jnfprogramari.com wrote: Ejem... happy debugging... #0 0x0806b9db in assess_danger_player (pplayer=0x82c8a74) at advmilitary.c:415 myiter = (struct genlist_link *) 0x2 #1 0x080cc6f6 in ai_do_first_activities (pplayer=0x82c8a74) at aihand.c:430 No locals. #2 0x08052dbf in srv_running () at srv_main.c:642 eot_timer = (struct timer *) 0x89a3290 save_counter = 1 is_new_turn = true __PRETTY_FUNCTION__ = srv_running #3 0x08053984 in srv_main () at srv_main.c:2383 No locals. #4 0x0804b1df in main (argc=1, argv=0xbfdfe3e4) at civserver.c:290 inx = 1 showhelp = 27 showvers = 8 option = value optimized out 探検するのは危険だそうです。 ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13797] [Patch] Rename player.ai as player.ai_data
Update of bug #13797 (project freeciv): Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13797 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13802] [Patch] Invalid iterator for NULL hash tables
Follow-up Comment #2, bug #13802 (project freeciv): It is really needed? Couldn't it be performed by adding a test in the iterating marco like: if (NULL != hash)? If you mean in the specific iteration macros like hash_keys_iterate, this would need to be repeated each time a new macro like that is defined, and I wanted to avoid the situation where the same code is duplicated in the headers every time. One design goal of the generic_iterate macro is to reduce the definition to only the things that are different. If you mean to put the NULL check in the generic_ iterate macro itself, it would have to be a check on the iterator pointer, since the extra init arguments are passed via macro varargs, and could be completely absent or more than 1 (i.e. there is no way to put them in an if-expression). One reason I did not allow NULL iterator pointers is so that I would not have to put NULL checks in all of the iterator_*() functions and also in any code that would use the init function outside of the generic_ iterate macro. Iterator pointers are somewhat special in that the memory is guaranteed to be on the stack; it is never NULL. If we decide to use NULL iterator pointers in one place, we would have to do away with this nice property and assume that iterators could be NULL almost everywhere. We would not need the iterator.c file, but then we would need a lot more NULL checks everywhere else, so purely from a number of lines of code standpoint I don't think we gain anything. The functions in iterator.c also provide some boiler- plate code which can be copied and adapted for new iterator implementations (albeit the sizeof function is missing). Is that acceptable justification? イエスかノーかはっきり言ってください。 ___ Reply to this item at: http://gna.org/bugs/?13802 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
Follow-up Comment #1, bug #13814 (project freeciv): The crash seems to occur when a hut is entered... どうぞ、小屋にお入りください。 ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
Follow-up Comment #2, bug #13814 (project freeciv): It just occurred to me that my recent barbarian.c commit was buggy in case barbarian player is created midturn. It could explain this crash if barbarian player is create from hut. But does it happen already before onsetbarbs turn? ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
Follow-up Comment #3, bug #13814 (project freeciv): It just occurred to me that my recent barbarian.c commit was buggy in case barbarian player is created midturn. It could explain this crash if barbarian player is create from hut. But does it happen already before onsetbarbs turn? Yes. Steps to reproduce: 1. Start a new game with at least one player. 2. Use the editor to place huts all around the starting position. 3. Set units to auto-explore (or just take huts yourself). 4. Server eventually crashes when some hut is taken. お断りします。 ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings
Follow-up Comment #5, bug #13810 (project freeciv): new patch on top of the last one (depends on gna13805): update union in struct settings_s + wrapper functions * new union in struct settings_s by pepeto * idea for wrapper functions by mbook I also added a patch which includes both changesets. (file #6078, file #6079) ___ Additional Item Attachment: File name: 0001-update-union-in-struct-settings_s-wrapper-function.patch Size:17 KB File name: version2-gna13810.patch.diff Size:18 KB ___ Reply to this item at: http://gna.org/bugs/?13810 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13805] [patch] change call by id (int) to call by reference (struct settings_s)
Follow-up Comment #5, bug #13805 (project freeciv): added a patch against trunk which includes both changes (file #6080) ___ Additional Item Attachment: File name: version2-gna13805.patch.diff Size:17 KB ___ Reply to this item at: http://gna.org/bugs/?13805 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] how to use git locally for freeciv
Am Thursday 18 June 2009 01:50:53 schrieb Madeline Book: On 17/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote: [...] My experience (we did it with git-svn here at work) is that it's a bit of an impedance mismatch; svn's limitations impose limitations on how you use git (I don't know if git-svnimport is any better): merges seem to make SVN go WTF? and freak out. Although I've never tried, I guess you could use a separate branch for each patchset, if you take care with how you bring it back into SVN. I have a branch for each patchset. And it is a one-way data exchange svn - git. The changes are submitted to gna as patches. Until now all is fine ... Separate branches is what I use with git-svn, making a new branch whenever I need to build on changes not yet in the main branch (i.e. trunk, S2_1, etc.). As a contributor one has to submit patches for inspection anyway, so when I do go to commit something, I just checkout the destination branch, apply the previously posted patch file, commit to git, then dcommit with git-svn. Unfortunately since the underlying repo is still svn, we cannot use the powerful branch merging features of git. :( A while ago I wrote a mini intro to using git with freeciv svn: https://mail.gna.org/public/freeciv-dev/2008-03/msg00048.html a size of 350MB? I have more than 3GB, most of it in the directory tags. It's not a problem but do I need this directory? I did a 'git svn clone svn://...' matth...@mattsys:/home/matthias/git du -h --max-depth=2 2.5G./freeciv.git/tags 251M./freeciv.git/branches 242M./freeciv.git/trunk 208M./freeciv.git/.git 3.2G./freeciv.git 3.2G. Matthias Though that was over a year ago and I'm sure that some git commands have changed since then (if something fails check the updated docs). As a matter of convenience I have a separate git repository for S2_1, since there are many autoconf/packet related changes which would require a complete ./autogen.sh make whenever switching to trunk. I also like having a bunch of shell aliases for commonly used command sequences: alias gb='git branch' alias gba='git branch -a' alias gci='git commit -v' alias gco='git checkout' alias gd='git diff' alias gdc='git diff --color' alias gdci='git-svn dcommit' alias gl='git log' alias glt='git log --pretty=format:%s%n%n%b' alias gps='git push' alias gpu='git pull' alias gr='git reset' alias greb='git-svn rebase' alias gsh='git show' alias gshc='git show --stat -p --color' alias gst='git status' Using git branches is much more space efficient than copying the svn repo each time, and incomparably faster. This was actually the main reason I learned to use git a long time, though git has many more advantages beyond just that. ;) あなたも同化される。 -- Matthias Pfafferodt - http://www.mapfa.de Matthias.Pfafferodt at mapfa.de ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
Follow-up Comment #4, bug #13814 (project freeciv): I tested many times, I really cannot reproduce any crash. ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13817] [S2_1] done_moving is not reset after the unit orders are cleared
URL: http://gna.org/bugs/?13817 Summary: [S2_1] done_moving is not reset after the unit orders are cleared Project: Freeciv Submitted by: pepeto Submitted on: Monday 06/29/2009 at 22:47 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: The patch in PR#40563 was not applied to S2_1. ___ Reply to this item at: http://gna.org/bugs/?13817 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] how to use git locally for freeciv
On 29/06/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote: Am Thursday 18 June 2009 01:50:53 schrieb Madeline Book: On 17/06/2009, Bernd Jendrissek bernd.jendris...@gmail.com wrote: [...] My experience (we did it with git-svn here at work) is that it's a bit of an impedance mismatch; svn's limitations impose limitations on how you use git (I don't know if git-svnimport is any better): merges seem to make SVN go WTF? and freak out. Although I've never tried, I guess you could use a separate branch for each patchset, if you take care with how you bring it back into SVN. I have a branch for each patchset. And it is a one-way data exchange svn - git. The changes are submitted to gna as patches. Until now all is fine ... Separate branches is what I use with git-svn, making a new branch whenever I need to build on changes not yet in the main branch (i.e. trunk, S2_1, etc.). As a contributor one has to submit patches for inspection anyway, so when I do go to commit something, I just checkout the destination branch, apply the previously posted patch file, commit to git, then dcommit with git-svn. Unfortunately since the underlying repo is still svn, we cannot use the powerful branch merging features of git. :( A while ago I wrote a mini intro to using git with freeciv svn: https://mail.gna.org/public/freeciv-dev/2008-03/msg00048.html a size of 350MB? I have more than 3GB, most of it in the directory tags. It's not a problem but do I need this directory? I did a 'git svn clone svn://...' matth...@mattsys:/home/matthias/git du -h --max-depth=2 2.5G./freeciv.git/tags 251M./freeciv.git/branches 242M./freeciv.git/trunk 208M./freeciv.git/.git 3.2G./freeciv.git 3.2G. Something is strange, since I have the full repository, with all my local branches and all remote branches and tags in 341 MB as of today (with git-repack -a -d and make distclean with 'trunk' checked out). My directory layout is different, I only have one directory (I call it 'git-svn'), in which there is a '.git' dir of 148M (du -h -s . inside) and the currently checked out source within it (i.e. no separate 'tags', 'branches' and 'trunk' directories, e.g. 'autogen.sh' is just in 'git-svn'). Maybe despite what the documentation says, git-svn clone behaves differently from running git-svn init and git-svn fetch separately. Or maybe you have an old version of git or git-svn that behaves that way. $ git-svn --version git-svn version 1.6.3.1 (svn 1.5.1) Anyway, the commands I used (in the directory you want to be the root of the repository, like 'git-svn' above) are: $ git svn init -t tags -b branches -T trunk --prefix=gna/ svn://svn.gna.org/svn/freeciv $ git svn fetch (It will take a long time to fetch all the revisions, just do the command again if it is interrupted by you or something else. Maybe you will need a while ! git svn fetch; sleep 5; done or similar for your shell. ;)) (I'm also not sure if you should use 'svn+ssh://synt...@svn.gna...' instead of just plain 'svn://svn.gna...', since I do not know if you will have to re-fetch the whole damn thing if you were to get svn write access some day...) $ git-repack -a -d $ git config branch.autosetupmerge true $ git-checkout trunk gna/trunk $ git-svn rebase Now you should be all set. I have no idea why your repository is so huge. It looks like it somehow copied the entire svn repository, and then just added a .git directory at its root. You do not need all of that, the laborious svn fetch should have grabbed all of the necessary information and converted it into git form. I hope I'm not crazy/stupid. ;) 信じられねぇぇ！ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13814] segfault in assess_danger_player
Follow-up Comment #5, bug #13814 (project freeciv): I tested many times, I really cannot reproduce any crash. When I put printfs that access the city pointer in assess_danger_player(), the exactly reproducible crashes go away. :( Maybe this is another compiler bug (I will try various compiler flags)... 機械の中に幽霊がある。 ___ Reply to this item at: http://gna.org/bugs/?13814 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13817] [S2_1] done_moving is not reset after the unit orders are cleared
Update of bug #13817 (project freeciv): Assigned to:None = mbook ___ Reply to this item at: http://gna.org/bugs/?13817 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13819] Assertion failure in get_invention()
Update of bug #13819 (project freeciv): Status: In Progress = None ___ Reply to this item at: http://gna.org/bugs/?13819 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13819] Assertion failure in get_invention()
Follow-up Comment #1, bug #13819 (project freeciv): It should be noted that crashes were not reported with default ruleset, but with custom rewonder ruleset. I have had no time to look at the ruleset, but maybe something there causes player to gain several techs / turn and automatic tech selection cannot handle that. ___ Reply to this item at: http://gna.org/bugs/?13819 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13819] Assertion failure in get_invention()
Update of bug #13819 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13819 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] how to use git locally for freeciv
I just made a git repository on gitorious mirroring the trunk branch in gna svn. Try it out: $ git clone git://gitorious.org/freeciv-svn-mirror/freeciv-svn-mirror.git Web page: http://gitorious.org/freeciv-svn-mirror It should be a bit faster than via git-svn. ;) そのおもちゃを見せてくれ。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] how to use git locally for freeciv
On 29/06/2009, Madeline Book madeline.b...@gmail.com wrote: I just made a git repository on gitorious mirroring the trunk branch in gna svn. Try it out: $ git clone git://gitorious.org/freeciv-svn-mirror/freeciv-svn-mirror.git And when that finishes do $ git-checkout -b trunk origin/trunk in the newly created directory (freeciv-svn-mirror). Sorry, I think I had a mistake in the git-checkout example step in my previous mail: I forgot the -b argument to create a new branch. ただの枝だ。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
