[Freeciv-Dev] [bug #13846] recursion checking for the read command

2009-07-04 Thread Matthias Pfafferodt

Follow-up Comment #5, bug #13846 (project freeciv):

I added 'bool read_cmd'. I thin this can be changed
to 'int read_level' and for 'read_level = 5' there
will be an error message ...

___

Reply to this item at:

  http://gna.org/bugs/?13846

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-04 Thread Matthias Pfafferodt

Follow-up Comment #10, bug #13810 (project freeciv):

 Why do you use the setting number as first argument 
 to almost every setting function? The only function 
 that takes a setting id should be setting_by_number(). 
 
  for (i = 0; i  SETTINGS_NUM; i++) { 

This way I can use

pset_scategory(i)

else I would have

pset_scategory(setting_by_number(i))

If the second one is prefered I will change it.

Reading your comments I also found that I'm missing
some knowledge about how to code (I did learn some
basics about C/C++ coding but I do mainly html/php).
I think I have to reread the patches #13805 and
#13810 (and an unsend patch to add action callback
function) carefully with regard to variable and
function naming and possible simplifications. And
I need to do some planning before coding ...


___

Reply to this item at:

  http://gna.org/bugs/?13810

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-04 Thread Madeline Book

Follow-up Comment #11, bug #13810 (project freeciv):

 This way I can use 
 
 pset_scategory(i) 
 
 else I would have 
 
 pset_scategory(setting_by_number(i))

There is an example of how to create an iteration
macro when the array pointer is not available in
the header in the patch in bug #13793.

 Reading your comments I also found that I'm missing 
 some knowledge about how to code (I did learn some 
 basics about C/C++ coding but I do mainly html/php). 
 I think I have to reread the patches #13805 and 
 #13810 (and an unsend patch to add action callback 
 function) carefully with regard to variable and 
 function naming and possible simplifications. And 
 I need to do some planning before coding ...

Sorry if something was unclear beforehand.
Unfortunately I will not be able to explain so much
now as I will be trying to finish the work for 2.2.



では失礼します。

___

Reply to this item at:

  http://gna.org/bugs/?13810

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] how to use git locally for freeciv

2009-07-04 Thread Matthias Pfafferodt
Am Thursday 02 July 2009 01:19:19 schrieben Sie:
 On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
  You don't need to. As I said the 3 GB size is not a problem. I think I
  will also get warclient and longturn to compare ...

 The 3 GB is just silly. The entire history of the trunk and S2_1
 branches when cloned from freeciv-svn-mirror are only 269M.

Perhaps I should simple delete the directory './tags' as git does not use it? 
This way I'm down to 700MB ...

I did a second checkout (using 'git svn clone svn://...) and did get similar 
numbers. First the './.git' directory is downloaded and after that all tags / 
branches as well as trunk are checked out.

Matthias

matth...@mattsys:/home/matthias/git du -h --max-depth=2
2.5G./freeciv.git/tags
251M./freeciv.git/branches
242M./freeciv.git/trunk
208M./freeciv.git/.git
3.2G./freeciv.git
3.2G.





 
 どうしてあんまり太っている。



-- 
Matthias Pfafferodt - http://www.mapfa.de
Matthias.Pfafferodt at mapfa.de

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13810] [patch] use unions to save the game settings

2009-07-04 Thread Matthias Pfafferodt

Follow-up Comment #12, bug #13810 (project freeciv):

 Sorry if something was unclear beforehand. 
 Unfortunately I will not be able to explain so much 
 now as I will be trying to finish the work for 2.2. 

Thanks for the help! I did learn something in the
discussions and the last thing I did want is to keep
you from finishing 2.2 ;-)



___

Reply to this item at:

  http://gna.org/bugs/?13810

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13850] add min/max definitions for saveturns

2009-07-04 Thread Matthias Pfafferodt

URL:
  http://gna.org/bugs/?13850

 Summary: add min/max definitions for saveturns
 Project: Freeciv
Submitted by: syntron
Submitted on: Donnerstag 02.07.2009 um 20:48
Category: general
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

see summary



___

File Attachments:


---
Date: Donnerstag 02.07.2009 um 20:48  Name:
0001-add-min-max-definitions-for-saveturns.patch  Size: 1kB   By: syntron

http://gna.org/bugs/download.php?file_id=6115

___

Reply to this item at:

  http://gna.org/bugs/?13850

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-04 Thread Marko Lindqvist

Follow-up Comment #1, bug #13848 (project freeciv):

Looks good in most part.

- I don't like switch and case at same indentation level. I would vote
for half indent step (2/2 = 1) for case
- Could you add assert() rule that instead of assert(FALSE) assert with
more verbose error message should be used when possible:

switch(value) {
 case 1:
 case 2:
   do_something();
   break;
 case 3:
   assert(value != 3);
   break;
}

___

Reply to this item at:

  http://gna.org/bugs/?13848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13726] Add the flag in start page

2009-07-04 Thread Marko Lindqvist

Update of bug #13726 (project freeciv):

  Status:None = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13726

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13770] Emphasize OOP for path finding code

2009-07-04 Thread Marko Lindqvist

Update of bug #13770 (project freeciv):

  Status:None = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13770

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13637] [patch] add effect Migration_Pct

2009-07-04 Thread Marko Lindqvist

Update of bug #13637 (project freeciv):

  Status:None = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13637

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13828] move definition of GAME_*_COMPRESS_TYP to game.h

2009-07-04 Thread Marko Lindqvist

Update of bug #13828 (project freeciv):

  Status:None = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13828

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13850] add min/max definitions for saveturns

2009-07-04 Thread Marko Lindqvist

Update of bug #13850 (project freeciv):

 Assigned to:None = cazfi  


___

Reply to this item at:

  http://gna.org/bugs/?13850

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] how to use git locally for freeciv

2009-07-04 Thread Marko Lindqvist
2009/7/2 Madeline Book madeline.b...@gmail.com:
 On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:

 You don't need to. As I said the 3 GB size is not a problem. I think I will
 also get warclient and longturn to compare ...

 The 3 GB is just silly. The entire history of the trunk and S2_1
 branches when cloned from freeciv-svn-mirror are only 269M.

 I think Matthias has all the branches and tags as separate
directories in his harddisk. Madeline's (and mine) git repository just
knows that tag is identical to some trunk/branch revision.


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] how to use git locally for freeciv

2009-07-04 Thread Matthias Pfafferodt
Am Thursday 02 July 2009 23:24:09 schrieb Marko Lindqvist:
 2009/7/2 Madeline Book madeline.b...@gmail.com:
  On 01/07/2009, Matthias Pfafferodt matthias.pfaffer...@mapfa.de wrote:
  You don't need to. As I said the 3 GB size is not a problem. I think I
  will also get warclient and longturn to compare ...
 
  The 3 GB is just silly. The entire history of the trunk and S2_1
  branches when cloned from freeciv-svn-mirror are only 269M.

  I think Matthias has all the branches and tags as separate
 directories in his harddisk. Madeline's (and mine) git repository just
 knows that tag is identical to some trunk/branch revision.


  - ML

This could be; I have git version 1.6.0.2 (from opensuse). Current up-to-date 
version is v1.6.3.3 ...

Matthias
-- 
Matthias Pfafferodt - http://www.mapfa.de
Matthias.Pfafferodt at mapfa.de

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Mailing List

2009-07-04 Thread Matthias Pfafferodt
Hello,

does the list has hickups? I'm missing some emails about comments to patches 
on gna since Thursday. The newest mail in the email archive is also from 
Thursday (https://mail.gna.org/public/freeciv-dev/2009-07/threads.html). I 
hope this Email will find its way.

Matthias
-- 
Matthias Pfafferodt - http://www.mapfa.de
Matthias.Pfafferodt at mapfa.de

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39923) ggz support for 2.1

2009-07-04 Thread Marko Lindqvist

URL: http://bugs.freeciv.org/Ticket/Display.html?id=39923 

2007/11/28 Jason Dorje Short jdo...@gmail.com:
 However the default
 profile hard-coded in freeciv is for pubserver.freeciv.org as the
 server.  This patch should be applied to change that default profile, or
 pubserver.freeciv.org should be changed to point to
 freeciv.ggzgamingzone.org.

 Just found this patch when searching for correct server name to set
in default profile. Seems like Jason wrote the patch I now need
already years ago. I'll test and commit this.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [bug #13726] Add the flag in start page

2009-07-04 Thread Madeline Book
On 30/06/2009, Madeline Book no-reply.invalid-addr...@gna.org wrote:

 Follow-up Comment #8, bug #13726 (project freeciv):

 (Book, why don't I receive your message on my e-mail account?)

 I have no idea, maybe it was just late in arriving?
 Maybe your spam filter got tired of reading through
 my drivel.

 Was it just the last one, or all my comments on the
 gna bugtracker? I'm not doing anything strange, just
 using the post a comment box...

Now I'm not getting any email from gna when I post
comments to tickets. O-o



もしかして嫌いか。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Gna email problems

2009-07-04 Thread Marko Lindqvist
2009/7/3 Madeline Book madeline.b...@gmail.com:

 Now I'm not getting any email from gna when I post
 comments to tickets. O-o

 It seems that commit messages are not being sent to freeciv-commits.

Neither does cia.vc see them. http://cia.vc/stats/project/FreeCiv


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13707] [Patch] Free memory allocated by init_nls()

2009-07-04 Thread Marko Lindqvist

Update of bug #13707 (project freeciv):

Category:None = general
  Status:None = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13707

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13860] [Patch] Scripting: create_base

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13860

 Summary: [Patch] Scripting: create_base
 Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 03:17
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

This patch adds create_base method to scripting interface.



___

File Attachments:


---
Date: Saturday 07/04/2009 at 03:17  Name: CreateBaseScripting.diff  Size: 7kB
  By: cazfi

http://gna.org/bugs/download.php?file_id=6123

___

Reply to this item at:

  http://gna.org/bugs/?13860

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-04 Thread Madeline Book

Follow-up Comment #4, bug #13848 (project freeciv):

Some rules I was just reminded of:

- No more than 2 empty lines between any sections
  in the code.

- #include the header corresponding to the current
  c source file after all other headers.



思い出してくれてありがとう。

___

Reply to this item at:

  http://gna.org/bugs/?13848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13823] [Patch] Fix gtk2 theme installation when also sdl client compiled

2009-07-04 Thread Marko Lindqvist

Update of bug #13823 (project freeciv):

  Status:None = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13823

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13857] [Patch] Debian package building

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13857

 Summary: [Patch] Debian package building
 Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 00:48
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

This patch is almost total rewrite to very outdated and broken debian
directory for building snapshot packets.



___

File Attachments:


---
Date: Saturday 07/04/2009 at 00:48  Name: DebSnapshot.diff  Size: 23kB   By:
cazfi

http://gna.org/bugs/download.php?file_id=6119

___

Reply to this item at:

  http://gna.org/bugs/?13857

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13860] [Patch] Scripting: create_base

2009-07-04 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #13860 (project freeciv):

Are there rules for the included files, i.e. sort
them alphabetical?

+/* server */
+#include citytools.h
 #include barbarian.h
+#include maphand.h
 #include plrhand.h
-#include citytools.h
 #include techtools.h
 #include unittools.h


___

Reply to this item at:

  http://gna.org/bugs/?13860

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13859] [Patch] Gen-movement version of prohibiting units in cities in the middle of non-native

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13859

 Summary: [Patch] Gen-movement version of prohibiting units
in cities in the middle of non-native
 Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 02:05
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

Gen-movement version of prohibiting units in cities in the middle of
non-native terrain.

Note that we are not civ1 compatible in that ships cannot enter channel of
several cities.



___

File Attachments:


---
Date: Saturday 07/04/2009 at 02:05  Name: CityMiddleOfNonNative.diff  Size:
873B   By: cazfi

http://gna.org/bugs/download.php?file_id=6122

___

Reply to this item at:

  http://gna.org/bugs/?13859

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13863] Remove old server goto code, step 1: warmap alternatives

2009-07-04 Thread Marko Lindqvist

Update of bug #13863 (project freeciv):

 Assigned to:None = cazfi  


___

Reply to this item at:

  http://gna.org/bugs/?13863

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13862] [Patch] Separate default.lua script.lua

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13862

 Summary: [Patch] Separate default.lua  script.lua
 Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 12:14
Category: general
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

We current load just one script file, script.lua. This is maintenance
nightmare for custom rulesets. They cannot implement just their own custom
scripts, but have to implement (and maintain!) all the scripting provided by
default script.lua (currently only huts, but much more in the future).
Actually, we have this problem already in officil Freeciv distribution. It
appears that civ1/civ2 rulesets have their own outdated copies of
script.lua.

Attached patch divides scripting in to two files. default.lua implements
scripts that should be available for all rulesets. script.lua is for ruleset
specific scripts.



___

File Attachments:


---
Date: Saturday 07/04/2009 at 12:14  Name: DefaultLuaScript.diff  Size: 17kB  
By: cazfi

http://gna.org/bugs/download.php?file_id=6125

___

Reply to this item at:

  http://gna.org/bugs/?13862

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13851] [Patch] Update wish list URL in TODO

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13851

 Summary: [Patch] Update wish list URL in TODO
 Project: Freeciv
Submitted by: cazfi
Submitted on: Friday 07/03/2009 at 01:34
Category: docs
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

$subject




___

File Attachments:


---
Date: Friday 07/03/2009 at 01:34  Name: TODOWishListUrl.diff  Size: 551B  
By: cazfi

http://gna.org/bugs/download.php?file_id=6116

___

Reply to this item at:

  http://gna.org/bugs/?13851

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13735] [Patch] Fix tolua-5.1b compiler warnings

2009-07-04 Thread Marko Lindqvist

Update of bug #13735 (project freeciv):

  Status:None = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13735

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13858] [Patch] Move SINGLE_MOVE co to movement.h

2009-07-04 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?13858

 Summary: [Patch] Move SINGLE_MOVE  co to movement.h
 Project: Freeciv
Submitted by: cazfi
Submitted on: Saturday 07/04/2009 at 01:50
Category: None
Severity: 3 - Normal
Priority: 1 - Later
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 
Operating System: None

___

Details:

$subject




___

File Attachments:


---
Date: Saturday 07/04/2009 at 01:50  Name: SingleMoveToMovementH.diff  Size:
3kB   By: cazfi

http://gna.org/bugs/download.php?file_id=6120

___

Reply to this item at:

  http://gna.org/bugs/?13858

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-04 Thread Madeline Book

Follow-up Comment #3, bug #13848 (project freeciv):

 Could you add assert() rule that instead of
 assert(FALSE) assert with more verbose error
 message should be used when possible: [...]

There is the die() function which can be used
if the assert condition is not descriptive
enough. I'll add a note about it and also to
avoid using assert(0) and similar.



ちょっと!まだ死なないでくれよ。

___

Reply to this item at:

  http://gna.org/bugs/?13848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-04 Thread Marko Lindqvist

Follow-up Comment #5, bug #13848 (project freeciv):

Reason why I want case labels intendet is that having ending } as first
line starting at the same level as switch itself makes it easier to see at
one glance where current switch ends. My eyes (and brain) just work that
way :-)

___

Reply to this item at:

  http://gna.org/bugs/?13848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13848] [Patch] More detailed coding style guidelines

2009-07-04 Thread Marko Lindqvist

Follow-up Comment #6, bug #13848 (project freeciv):

I discourage use of die() in most cases. I don't think CodingStyle should
advertise it.

Note that die() kills even release builds (those with NDEBUG) when assert()
does not. Of course failing assert() sometimes indicates problem that causes
crash anyway.

___

Reply to this item at:

  http://gna.org/bugs/?13848

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13811] [Patch] string vector

2009-07-04 Thread Madeline Book

Follow-up Comment #1, bug #13811 (project freeciv):

Some general notes:

- The #include shared.h in iterator.h can be
  committed separately immediately if desired.
- The string vector header+implementation and
  the changes in common/tech.c should be separate
  patch submissions.
- Use 8 spaces instead of a tab for 4 indent levels.
- No more than 2 empty lines between code parts.

Some notes about the string vector implementation:

- I suggest a shorter class name, e.g. 'strvec'.
  This would also help to distinguish it from
  vectors created with the specvec macro.
- Most other data structures in freeciv use
  X_free() instead of X_destroy().
- Since a vector generalizes the array concept
  (i.e. it supports O(1) random access), there is
  already an iteration interface using element
  indicies (i.e. a for loop). Hence there is no
  need to use the generic iterator interface.
- The insert_{before,after} functions should just
  take an element index instead of iterators, if
  not removed altogether (there is already an
  insert() function).

Some notes about the other changes:

- The need for static variables and consequently the
  string vector (in this patch) would be removed if
  you just made advance_name_{by,for}_player() take
  a buffer and maximum size arguments. Updating all
  callers would a bit tedious (by=12 for=57), but it
  would be the correct approach.




もっと簡潔であるべきだ。

___

Reply to this item at:

  http://gna.org/bugs/?13811

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13834] [Patch] struct ai_type

2009-07-04 Thread Marko Lindqvist

Update of bug #13834 (project freeciv):

  Status:None = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?13834

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #13811] [Patch] string vector

2009-07-04 Thread pepeto

Follow-up Comment #2, bug #13811 (project freeciv):

 - I suggest a shorter class name, e.g. 'strvec'.
 This would also help to distinguish it from
 vectors created with the specvec macro. 

I renamed it str_vec, but it really looks ugly to me. I prefer the original
name. What about string_vec ?


(file #6129)
___

Additional Item Attachment:

File name: string_vector.diff Size:11 KB


___

Reply to this item at:

  http://gna.org/bugs/?13811

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Mailing List

2009-07-04 Thread Matthias Pfafferodt
Am Saturday 04 July 2009 18:10:58 schrieb Matthias Pfafferodt:
 Hello,

 does the list has hickups? I'm missing some emails about comments to
 patches on gna since Thursday. The newest mail in the email archive is also
 from Thursday
 (https://mail.gna.org/public/freeciv-dev/2009-07/threads.html). I hope this
 Email will find its way.

 Matthias

OK, I now got around 40 mails for Freeciv-Dev ... seems to be a problem at 
gna.org?

-- 
Matthias Pfafferodt - http://www.mapfa.de
Matthias.Pfafferodt at mapfa.de

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev