[Freeciv-Dev] [patch #2609] Polish localization for S2_3

[Hubert Kowalewski]

Follow-up Comment #6, patch #2609 (project freeciv):

A small revision reflecting the changes from June 15.

(file #13205)
___

Additional Item Attachment:

File name: pl.po.zip  Size:444 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2529] Configure checks for gtk3-client

[Marko Lindqvist]

Update of patch #2529 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2286] AI module directory structure

[Marko Lindqvist]

Update of patch #2286 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18058] trunk: data/nation && data/flags/Makefile.am inconsistence

[Marko Lindqvist]

Follow-up Comment #3, bug #18058 (project freeciv):

I'd rather place this check_flags.sh under scripts/. Attached version has
data_dir path adjusted accordingly.

If nobody objects in 48h, I'll add this to version control.

(file #13204)
___

Additional Item Attachment:

File name: check_flags.sh Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

[David Fernandez]

Follow-up Comment #6, bug #18221 (project freeciv):

Ok, thanks, no hurry.
For now, gold upkeep style = 1 seems to avoid the crashes.

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18228] Configure does not support Mac OS Framework-style SDL installation

[Marko Lindqvist]

Update of bug #18228 (project freeciv):

  Status:None => Need Info  

___

Follow-up Comment #1:

To get started with this I'd like someone with such a system to try to
configure with --enable-client=sdl and to send error message it produces and
config.log-file generated from that configure run.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18200] Configure does not support Mac OS Framework-style Qt installation

[Marko Lindqvist]

Update of bug #18200 (project freeciv):

 Planned Release: => 2.4.0  
 Summary: Configure is unable to detect frameworks =>
Configure does not support Mac OS Framework-style Qt installation

___

Follow-up Comment #8:

I've been splitting this one to several tickets. This ticket handles
configure check for Framework Qt-installation.
Attached is first related patch. Based on information I've got so far it
tries to detect and setup include paths correctly. So if it works correctly,
you don't need to set CXXFLAGS or CPPFLAGS from commandline. It also has
similar implementation for library path setting, but as we still don't know
what the correct paths are, this is more than likely not to work.

- Test program compilation failure from comment #6 & comment #7 is now
handled in bug #18227. Please comment patch from comment #7 in that ticket

- Framework SDL-installation detection is handled in bug #18228


(file #13203)
___

Additional Item Attachment:

File name: QtFrameworkDetect_18200.diff   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18228] Configure does not support Mac OS Framework-style SDL installation

[Marko Lindqvist]

URL:
  

 Summary: Configure does not support Mac OS Framework-style
SDL installation
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Jun 2011 03:41:21 AM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Mac OS
 Planned Release: 2.4.0

___

Details:

Splitting from bug #18200

Configure should detect Mac OS Framework-style SDL installations.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18227] Qt-client configure check test program compilation fails

[Marko Lindqvist]

URL:
  

 Summary: Qt-client configure check test program compilation
fails
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 15 Jun 2011 03:38:25 AM EEST
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

Splitting from bug #18200.

Even when QApplication-header is found from include path,
FC_QT_CLIENT_COMPILETEST test program compilation fails on some systems. From
config.log:

conftest.cpp: In function 'int main()':
conftest.cpp:69: error: no matching function for call to
'QApplication::QApplication(int, int)'
/Library/Frameworks/QtGUI.framework/Versions/4/Headers/qapplication.h:375:
note: candidates are: QApplication::QApplication(const QApplication&)
/Library/Frameworks/QtGUI.framework/Versions/4/Headers/qapplication.h:128:
note: QApplication::QApplication(int&, char**,
QApplication::Type, int)
/Library/Frameworks/QtGUI.framework/Versions/4/Headers/qapplication.h:127:
note: QApplication::QApplication(int&, char**, bool, int)
/Library/Frameworks/QtGUI.framework/Versions/4/Headers/qapplication.h:126:
note: QApplication::QApplication(int&, char**, int)

bug #18200 comment #7 already has one potential fix attached.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64

[Jacob Nevins]

Update of bug #18170 (project freeciv):

  Status:None => In Progress
 Assigned to:None => jtn


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18170] md5 sum broken in trunk on sparc64

[Marko Lindqvist]

Follow-up Comment #8, bug #18170 (project freeciv):

> I can't find a ticket for its addition to Freeciv, so I don't
> know more about its exact provenance (a "Mike Kaufman" was
> involved).

For the record: Mike & others originally wrote authentication code for
freeciv pubserver only (now, how many of you even remember pubserver...:-) It
was not in public freeciv version control, but just local patch applied when
freeciv server for pubserver was built. It's quality reflected that; it was
meant to run only on that one specific hardware and environment (hardcoded
mysql usernames, passwords, filesystem paths...)
At some point Mike decided to save the authentication code from failing
pubserver by adding it to freeciv version control.
It was behind #ifdefs and didn't even compile when I decided to set up my own
public server. So I cleaned the code up a good deal to make it reusable in my
case.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18192] Client allocates unnecessarily memory for tile knowledge maps

[Marko Lindqvist]

Update of bug #18192 (project freeciv):

 Assigned to:None => cazfi  
 Planned Release: => 2.4.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2687] Chickasaw nation

[J.M. Maalderink]

Update of patch #2687 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2686] Chiapanec nation

[J.M. Maalderink]

Update of patch #2686 (project freeciv):

  Status: In Progress => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

[Marko Lindqvist]

Update of bug #18221 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Planned Release: => 2.2.6, 2.3.0, 2.4.0
 Summary: Crash while playing custom Ruleset => Not enough
buildings/units sold to restore positive balance

___

Follow-up Comment #5:

Fix attached.

Don't really know any good workarounds for original reporter until fixed
version of freeciv is released.

(file #13202)
___

Additional Item Attachment:

File name: SellNeededNumberOfUnits_18221.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17906] Gold upkeep icon covers unhappiness upkeep icon

[Jacob Nevins]

Update of bug #17906 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2688] Insert linebreaks to long happiness effect provider lists in happiness tab

[Jacob Nevins]

Update of patch #2688 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

[Marko Lindqvist]

Follow-up Comment #4, bug #18221 (project freeciv):

I really should have read code more carefully before sending previous
comment. Actually you do get upkeep back when building or unit is being sold
(at least function headers claim so).

But it now seems to me that there's bug in that not enough buildings/units is
being sold. Just max one of each is being sold. So you can be paying upkeep
for 100 units taking your balance very much negative, and then you get back
upkeep for just one.

Check for continuing selling is not about if there still is units/buildings
remaining to be sold. Instead number of available buildings/units are compared
to variables. And these variables are set to number of remaining
buildings/units when first one is sold -> they will certainly be same as
number of available buildings/units when considering selling second one ->
second one is never sold.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

[David Fernandez]

Follow-up Comment #3, bug #18221 (project freeciv):

Wow, you tested it pretty fast! Thank you very much.

If the cause is negative treasury, then I know how to workarround it. The bug
must be related to this patch: https://gna.org/bugs/?16413, where I already
noticed treasure reached negative values when I used experimental ruleset and
gold upkeep style 2, altough I did not submit a proper savegame.

Just changing gold upkeep style to 1 in my ruleset, this savegame can
continue without crashes.

If syntron is arround he surely can help to fix it.

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

[Marko Lindqvist]

Follow-up Comment #2, bug #18221 (project freeciv):

Well, I think that there's nothing in the code that would assert that balance
really gets positive before this failing assert(). But this is not simply
matter of removing the assert() as negative balance breaks a lot of things
then on.

Code block before the assert() is like:
while(balance < 0 && something_to_sell) {
  sell_something()
}
but nothing prevents balance from still being negative when everything is
sold.

One thing we may want to change in development code (probably not in stable
branches) is that upkeep for units and buildings being sold because of
negative balance would not be paid. Currently their upkeep is already paid by
the time we sell them.
In stable branches, and temporarily in trunk, I'd just make simple hack to
set balance = 0 if it's still negative after we have sold everything.

I also think that this bug can manifest itself only if upkeep of some unit or
building is higher than its selling value -> otherwise selling it would always
restore balance to at least same level than it was before paying upkeep.
Original reporter may want to use that information to make to his ruleset
such temporary changes that it won't crash freeciv until this is fixed.
However, it's possible that there is some bug in how selling value (or
upkeep) is calculated causing former to be smaller than latter even if ruleset
seems not to allow that. I'll trace exact cause of this reproducible crash a
bit further.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

[Marko Lindqvist]

Update of bug #18221 (project freeciv):

Category:None => general
  Status:None => Confirmed  
 Assigned to:None => cazfi  

___

Follow-up Comment #1:

Nicely reproducible in S2_2 head. This is assert failure caused by the fact
that player somehow gets negative balance.

Backtrace follows.


> freeciv-server: server/cityturn.c:1834:
player_balance_treasury_units_and_buildings: Assertion `0' failed.

(gdb) bt full
#0  0x7719d3d5 in raise (sig=) at
../nptl/sysdeps/unix/sysv/linux/raise.c:64
pid = 
selftid = 
#1  0x771a0650 in abort () at abort.c:92
act = {__sigaction_handler = {sa_handler = 0x578408, sa_sigaction =
0x578408}, sa_mask = {__val = {
  140737340187112, 140737488346496, 1834, 140737488346736,
140737339251622, 206158430232, 
  140737488346752, 140737488346528, 140737339163480,
206158430256, 140737488346776, 13255024, 
  7392, 8390880602273947706, 2316873722724511593,
140737488348520}}, sa_flags = -148176321, 
  sa_restorer = 0x55ad80}
sigs = {__val = {32, 0 }}
#2  0x77196581 in __assert_fail (assertion=0x578408 "0", file=, line=1834, 
function=0x55c220 "player_balance_treasury_units_and_buildings") at
assert.c:81
buf = 0xca4170 "freeciv-server: server/cityturn.c:1834:
player_balance_treasury_units_and_buildings: Assertion `0' failed.n"
#3  0x0044985c in player_balance_treasury_units_and_buildings
(pplayer=0x8f5c70)
at server/cityturn.c:1834
ci = {pcity = 0x23ddc70, pimprove = 0x865900}
impr_count = 
unit_count = 
sell_unit = 
#4  update_city_activities (pplayer=0x8f5c70) at server/cityturn.c:517
i = 
r = 
n = 0
gold = 2
__PRETTY_FUNCTION__ = "update_city_activities"
#5  0x0040a29d in end_phase () at server/srv_main.c:891
MY_i = 14
pplayer = 0x8f5c70
#6  srv_running () at server/srv_main.c:2081
save_counter = 1
is_new_turn = true
eot_timer = 0xb464b0
need_send_pending_events = false
#7  srv_main () at server/srv_main.c:2446
No locals.
#8  0x0040406f in main (argc=,
argv=0x7fffe278)
at server/civserver.c:359
inx = 3
showhelp = 
showvers = 
option = 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2660] Add gamename setting

[Marko Lindqvist]

Follow-up Comment #1, patch #2660 (project freeciv):

Is it intentional (this is just a first step) that this patch does not *use*
gamename for anything, just allows setting it.

I looked through the patch, but this should not be taken as indication that
I'm about to take it into freeciv. I were just curious, and wanted to check if
this would be somehow useful.


- It's overkill to allow setting gamename with two different means; from
commandline and by special command. We are running out of letters for
commandline options (and -g used to mean --gamelog, so old users may expect
that) and you probably want to change gamename when you start new game within
same server incarnation, so this should probably be just command
- In settings.c you add ctype.h include before fc_config.h include.
fc_config.h *must* be first header to include in each source file.
- In gamename_validate() you have one command after if() without making it a
block "{}". Unacceptable. Read CodingStyle.
- Code in gamename_validate() should be reorganized so that gotos are not
needed. Gotos are acceptable in some extremely rare situations where code
would be next to impossible to organize otherwise. Here its avoidance is
trivial.
- Should gamename be saved to savegame?
- If you insist on adding commandline option, doc/man/freeciv-server.6.in
should be updated

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18221] Crash while playing custom Ruleset

[David Fernandez]

URL:
  

 Summary: Crash while playing custom Ruleset
 Project: Freeciv
Submitted by: tirolalira
Submitted on: mar 14 jun 2011 21:51:25 GMT
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Freeciv v2.2.5 crashes while playing my custom Ruleset, and I have been
unable to find the cause.

The server crashes during AI turn showing the Windows error message "this
program had an error and it will be closed..."
It uses to crash arround turn 200, so it is surely related to timeframe (new
techs, units, etc).
Most of the times I can continue playing if I reload the previous autosave,
but then it keeps crashing randomly.

I have been able to save a game that crashes everytime I press end turn. I
attach a .zip file including:
1- Custom Ruleset civ2-3, to install over v2.2.5
2- Savegame: press end turn to recreate the crash
3- The log file generated the first time it crashed (I was playing with spain
in AI mode). 

I played similar ruleset over v2.2.3 without problems, and I keep track of my
changes while adapting it for 2.2.5. I would thank any help to find the bug
and fix it.



___

File Attachments:


---
Date: mar 14 jun 2011 21:51:25 GMT  Name: Crash_civ2-3.zip  Size: 652kB   By:
tirolalira



___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2648] Updated "controls" help section based on comments in mapctrl.c

[Marko Lindqvist]

Update of patch #2648 (project freeciv):

Category:None => client 
 Planned Release: => 2.3.0, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2529] Configure checks for gtk3-client

[Marko Lindqvist]

Update of patch #2529 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2497] Scenario downloading support for freeciv-modpack

[Marko Lindqvist]

Update of patch #2497 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Untested patch to add support for modpack type "Scenario" that will be loaded
to ~/.freeciv/scenarios/

Version specific subdir has already been added to FREECIV_SCENARIO_PATH, so
this patch completes this ticket.

(file #13200)
___

Additional Item Attachment:

File name: MPTScenario_2497.diff  Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1968] add players_iterate_alive()

[Marko Lindqvist]

Update of patch #1968 (project freeciv):

 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18219] sdl-client compiler warning about possibly uninitialized widget.

[Marko Lindqvist]

Update of bug #18219 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18219] sdl-client compiler warning about possibly uninitialized widget.

[Marko Lindqvist]

URL:
  

 Summary: sdl-client compiler warning about possibly
uninitialized widget.
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Jun 2011 11:44:04 PM EEST
Category: client-sdl
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0, 2.4.0

___

Details:

gcc 4.6 warns (and with -Werror fails):


Fix attached. Will commit immediately as compilation fix.




___

File Attachments:


---
Date: Tue 14 Jun 2011 11:44:04 PM EEST  Name: WidgetInit.diff  Size: 923B  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1936] limit the number of units with gold upkeep a city can support

[David Fernandez]

Follow-up Comment #16, patch #1936 (project freeciv):

I'd like to test this patch.
May I install it over current trunk repository (together with "update hit
point calculation for killunhomed")? Would AI handle it? or I should wait to
v2.4.0

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

[Marko Lindqvist]

Follow-up Comment #2, bug #18217 (project freeciv):

One noteworthy thing about these warnings is that they don't cause failure
even with -Werror.
I don't know why that is (gcc feature or bug) and how long that will last.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2685] Acrean nation

[J.M. Maalderink]

Update of patch #2685 (project freeciv):

  Status: In Progress => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2709] Japanese clans nations

[Daniel Markstedt]

Follow-up Comment #3, patch #2709 (project freeciv):

FYI, there's an old "Japan" modpack by Rob Best available from the download
server. It hasn't been updated for Freeciv 2.2 though.
http://download.gna.org/freeciv/contrib/modpacks/japan/

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2709] Japanese clans nations

[J. M. Gorbach]

Follow-up Comment #2, patch #2709 (project freeciv):

>>The flags should be in svg, and shields will be generated using the svg
image. 

Ok!

>>Maybe it's a better idea to turn this into a mod? 

Yes, it's a better idea. Thanks for reply.

___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

[Marko Lindqvist]

Update of bug #18217 (project freeciv):

 Planned Release: => 2.2.6, 2.3.0, 2.4.0

___

Follow-up Comment #1:

Many of these warnings come deep from our macro magic. I rather don't rewrite
those parts in stable branches. Instead I propose attached patches for S2_2
and S2_3. They just disable the warning.

I have not tested this with compiler other than gcc 4.6. I'm worried that
there is something wrong with FC_C_FLAGS() as it allowd typoed version of the
commandline option to pass. If FC_C_FLAGS() really is buggy, these patches may
break build with other compilers. It would be good if people tested this and
reported results.

(file #13197, file #13198)
___

Additional Item Attachment:

File name: UnusedVarWarnDisable_18217-S2_3.diff Size:0 KB
File name: UnusedVarWarnDisable_18217-S2_2.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2710] Improving Hasinay nation

[J.M. Maalderink]

Update of patch #2710 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2709] Japanese clans nations

[J.M. Maalderink]

Update of patch #2709 (project freeciv):

  Status:None => In Progress
 Assigned to:None => mixcoatl   

___

Follow-up Comment #1:

The flags should be in svg, and shields will be generated using the svg
image.

However, I'm not sure if we should include clans as nations. Maybe it's a
better idea to turn this into a mod? 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2707] Seminole nation

[J.M. Maalderink]

Update of patch #2707 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2705] Choctaw nation

[J.M. Maalderink]

Update of patch #2705 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18182] Adjective of Botswana; Batswana and Bashoto nations

[J.M. Maalderink]

Update of bug #18182 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2713] Include only allowed gtk3 headers

[Marko Lindqvist]

URL:
  

 Summary: Include only allowed gtk3 headers
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Jun 2011 08:35:13 PM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0

___

Details:

gtk3-programs are not allowed to directly include 'subheaders' of gtk.
Attached patch replaces such include (the only one in our codebase) with legal
gtk/gtk.h include.
Changes also gtk2-client as I saw no reason not to, and keeping codebases of
clients as similar as possible makes maintenance easier.



___

File Attachments:


---
Date: Tue 14 Jun 2011 08:35:13 PM EEST  Name: Gtk3AllowedIncludes.diff  Size:
776B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18217] variable 'xxx' set but not used

[Marko Lindqvist]

URL:
  

 Summary: variable 'xxx' set but not used
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 14 Jun 2011 08:27:24 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

After gcc update (to 4.6 series) I get a lot of new warnings of the form:
variable 'xxx' set but not used [-Wunused-but-set-variable]




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2701] gtk3-client settings

[Marko Lindqvist]

Follow-up Comment #2, patch #2701 (project freeciv):

- Updated against svn

(file #13195)
___

Additional Item Attachment:

File name: Gtk3Settings_2701-3.diff.bz2   Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18111] Replace some unsafe strcpy/strcat with fc_strlcpy/fc_strlcat

[Marko Lindqvist]

Follow-up Comment #1, bug #18111 (project freeciv):

First change this patch does is:
> -  strcpy(dest, str);
> +  fc_strlcpy(dest, str, strlen(str)+1);

How that makes anything safer? Seems to me that it only obscures the fact
that it's unsafe. Size of strcpy() area is already strlen()+1, and your change
does not give any protection against too small dest or missing ' ' from where
str should end.

I didnät read patch any further this time.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2615] Fix double hotkeys in some menu

[Marko Lindqvist]

Update of patch #2615 (project freeciv):

  Status:None => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17954] Hotekys displayed twice

[Marko Lindqvist]

Update of bug #17954 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

[Marko Lindqvist]

Update of bug #18209 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

Fix

(file #13194)
___

Additional Item Attachment:

File name: ExcludeSGCompat_18209.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

[Marko Lindqvist]

Follow-up Comment #2, bug #18209 (project freeciv):

> Actually code to save exclude info even to new savegames seems
> to be missing.

Actually I'm just blind. It's there.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18209] Compatibility with savegames without startpos.exclude information

[Marko Lindqvist]

Follow-up Comment #1, bug #18209 (project freeciv):

Actually code to save exclude info even to new savegames seems to be missing.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2708] Remove default ai includes from server code

[Marko Lindqvist]

Update of patch #2708 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2702] Gtk3 include path comments

[Marko Lindqvist]

Update of patch #2702 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev