[Freeciv-Dev] [patch #5773] Distribute a tool to parse scorelogs
URL: http://gna.org/patch/?5773 Summary: Distribute a tool to parse scorelogs Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Feb 2015 10:25:41 AM EET Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: We should provide a tool to parse scorelogs in our distribution. patch #5727 has one. ___ Reply to this item at: http://gna.org/patch/?5773 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5756] Make Amplio2 maglevs more distinct
Follow-up Comment #2, patch #5756 (project freeciv): GriffonSpade too is working on new maglev gfx: http://forum.freeciv.org/f/viewtopic.php?f=12t=7start=76 I would rather take that (something actually designed as Maglev) rather than just rerecoloring of the Railroad (recolored Railroad was just a spaceholder to begin with) ___ Reply to this item at: http://gna.org/patch/?5756 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23233] Windows Installer build tries to strip freeciv-ruledit even when it's not built
URL: http://gna.org/bugs/?23233 Summary: Windows Installer build tries to strip freeciv-ruledit even when it's not built Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Feb 2015 11:33:08 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0, 3.0.0 ___ Details: ...\bin\strip.exe 'install-gtk3/freeciv-ruledit.exe': No such file Untested fix attached. ___ File Attachments: --- Date: Sun 01 Feb 2015 11:33:08 AM EET Name: StrippingRuledit.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=23680 ___ Reply to this item at: http://gna.org/bugs/?23233 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20624] Goto/Airlift dialog sometimes focuses all cities in turn
Update of bug #20624 (project freeciv): Status: Confirmed = Ready For Test ___ Follow-up Comment #4: Fix (file #23681) ___ Additional Item Attachment: File name: GotoSelectionCb.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?20624 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22197] City dialog map not refreshed after changing governor
Follow-up Comment #5, bug #22197 (project freeciv): I can't reproduce. Can someone? ___ Reply to this item at: http://gna.org/bugs/?22197 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19584] Left panel and the docks in it cannot be resized
Update of bug #19584 (project freeciv): Status:None = Wont Fix Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #3: WontFix? Nobody disagreed in a week. ___ Reply to this item at: http://gna.org/bugs/?19584 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20624] Goto/Airlift dialog sometimes focuses all cities in turn
Follow-up Comment #2, bug #20624 (project freeciv): I can't reproduce with current S2_5 and the provided savegame. Mapview does center to the city in question when one is selected in the dialog. If the bug remains, I would assume it to be that when the dialog is being built, each newly added entry gets the 'selected' status in turn. ___ Reply to this item at: http://gna.org/bugs/?20624 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #15, bug #21851 (project freeciv): I can reproduce the leak in the X server (1.16.3, Arch version) with Freeciv 2.4.4 (Gtk 2 client). As far as I remember, this problem has been around for a long time (all I can say is it was likely not present before Amplio became the default). The memory usage of the X server goes down when Freeciv is closed. I got no Valgrind output for the Gtk 2 client (logical, the memory belongs to X). Having investigated two possible causes: * The leak is not in the 'Present units' list (moving units back and forth doesn't increase memory usage) * The leak is not in the 'Buildings' list (adding and removing buildings using the editor doesn't increase memory usage) ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5007] civ2civ3: custom veteran system for Engineers?
Update of patch #5007 (project freeciv): Planned Release: 2.5.0, 2.6.0, 3.0.0 = 2.5.1, 2.6.0, 3.0.0 ___ Follow-up Comment #6: As it seems that the balance part of the ticket has been rejected, and this is now only about the names of the veterancy levels, don't consider this 2.5.0 blocker. ___ Reply to this item at: http://gna.org/patch/?5007 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23231] Multiplayer ruleset lua error: attempt to index field '?' (a nil value)
Follow-up Comment #2, bug #23231 (project freeciv): Though there has been recent changes to related parts, I think this probably isn't an regression since 2.4, so not necessarily 2.5.0 blocker. Do others agree? (OTOH this is probably also easy to fix) ___ Reply to this item at: http://gna.org/bugs/?23231 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20624] Goto/Airlift dialog sometimes focuses all cities in turn
Update of bug #20624 (project freeciv): Status:None = Confirmed Planned Release: 2.5.0 = 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Follow-up Comment #3: I can't reproduce with current S2_5 and the provided savegame. Err... I can, when following the reproducing instructions carefully enough (Show All Cities) - add new cities to the dialog when it's already open. ___ Reply to this item at: http://gna.org/bugs/?20624 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5774] Help: Check that ruleset has relevant _Possible effects
URL: http://gna.org/patch/?5774 Summary: Help: Check that ruleset has relevant _Possible effects Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Feb 2015 04:01:04 PM EET Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Step towards patch #5006. This one is something that all of S2_5, S2_6, and TRUNK can have (so can be part of base for branch specific improvements) Check that relevant _Possible effect can *ever* be enabled in the ruleset before claiming that unit can do an action. This still does not make sure it can be enabled for the unit in question. ___ File Attachments: --- Date: Sun 01 Feb 2015 04:01:04 PM EET Name: SettlerPossibleHelp.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=23682 --- Date: Sun 01 Feb 2015 04:01:04 PM EET Name: SettlerPossibleHelp-S2_5.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=23683 ___ Reply to this item at: http://gna.org/patch/?5774 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4190] [Metaticket] Split translations to multiple po-files
Follow-up Comment #11, patch #4190 (project freeciv): What there's left to do in the context of this ticket (and S2_5)? Some remaining work was also discussed on the mailing list, but it was last proposed to be left to 2.6 (and a new ticket, I suppose?): http://mail.gna.org/public/freeciv-dev/2014-10/msg00230.html ___ Reply to this item at: http://gna.org/patch/?4190 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #14, bug #21851 (project freeciv): Does this still happen with current Ubuntu versions? Is this freeciv-2.5 regression compared to freeciv-2.4? If it's an regression and affects current OS versions, this seems like a freeciv-2.5.0 blocker. Is gtk2-client the only client affected, or does gtk3-client have the same behavior? ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] 2.5.0 tickets
On 28 January 2015 at 07:02, Marko Lindqvist cazf...@gmail.com wrote: And now: Bugs: 22, of which 4 Ready For Test Patches: 18 / 6 Total 40 open, of which 30 unimplemented Some inaccuracies: - There's some art tickets that are common to all tilesets though requiring separate art for each - Meta tickets sometimes double one ticket in count. Once the final part is solved, both the ticket of the part itself and the metaticket gets resolved at once Bugs: 21, of which 5 Ready For Test Patches: 13 / 0 Total: 34 open, of which 29 unimplemented Bugs #23231 Multiplayer ruleset lua error: attempt to index field '?' (a nil value) #23230 adjust_improvement_wants_by_effects() has illegal array accesses using continent number 0 #23227 Building advisor has illegal array accesses using continent number 0 #23226 Threaded AI city worker task requests leak #23218 Loopholes when disaster wrecks current production #23214 Fundamentalism food upkeep 3 #23213 Fallback icons needed for Qt client #23143 Fortress+River defense bonus reduced in 2.5 compared to 2.4 #22807 civ2civ3: Temple of Zeus / King Richard's Crusade undocumented half effect under Democracy #22625 Client crash when changing tileset with science dialog open #22294 2.5 typos, etc #22197 City dialog map not refreshed after changing governor #21851 Possible memory leak in S2_5 (in X server?) #21350 Supplied scenario start positions vs core nations #20999 Info label just black box in Windows Gtk3 builds (Gtk bug?) #20624 Goto/Airlift dialog sometimes focuses all cities in turn #20598 Something funny with Ready checkboxes in pregame screen #20536 Missing icon for roads in editor #20032 Many unit activities use same icons (amplio2) #19905 rapid middle click can orphan tooltip #19584 Left panel and the docks in it cannot be resized Patches #5771 [Metaticket] Unit upkeep icons for upkeep 2 in supplied tilesets #5691 civ2civ3: help texts for governments #5013 Maglev graphics for all supplied tilesets #5007 civ2civ3: custom veteran system for Engineers? #5006 Suppress Can build mines on tiles etc in help based on Mining_Possible, etc #4936 Tart up civ2civ3 help #4650 Split single input xx.po file into translations/*/xx.po #4486 Unit upkeep icons for upkeep 2 in supplied tilesets (amplio2) #4420 [Metaticket] Art required for 2.5 #4190 [Metaticket] Split translations to multiple po-files #4160 Gfx for Inaccessible terrain #3793 [metaticket] Help updates for 2.5.0 #3448 [metaticket] Nation sets: allow set of nations that will ever appear in-game to be chosen - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21475] Text background problems with gtk2 =2.24.21
Follow-up Comment #19, bug #21475 (project freeciv): I'll try to do crosser build with that commit reverted. ...and it worked. ___ Reply to this item at: http://gna.org/bugs/?21475 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21350] Supplied scenario start positions vs core nations
Follow-up Comment #5, bug #21350 (project freeciv): Is there something to consider as an regression from 2.4? Or is this just that the new core nationset feature is not as complete as it could? Do we have any plans for this affecting S2_5? Do we have any future plans (possibly something that requires changes not permitted in S2_5 due to format freezes) for this (i.e., do we want to retarget this)? ___ Reply to this item at: http://gna.org/bugs/?21350 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5006] Suppress Can build mines on tiles etc in help based on Mining_Possible, etc
Update of patch #5006 (project freeciv): Depends on: = patch #5774 ___ Reply to this item at: http://gna.org/patch/?5006 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5006] Suppress Can build mines on tiles etc in help based on Mining_Possible, etc
Follow-up Comment #4, patch #5006 (project freeciv): the shape of a solution for S2_5, but nothing firm yet (I'm not yet convinced we want to backport universal_fulfills_requirement(), although that's an easy way to solve the problem). We seem to be missing many tools that would be very handy in updating the help system to match new features. And S2_5 is not the first branch where we end to this situation. We should learn from this, and check the help system in S2_6 in earlier phase, when it's still possible to add needed lower level functionality. Maybe making help system check (i.e., to have at least a plan how to update it) an requirement for entering datafile format freeze? ___ Reply to this item at: http://gna.org/patch/?5006 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5007] civ2civ3: custom veteran system for Engineers?
Follow-up Comment #8, patch #5007 (project freeciv): beginner, seasoned, senior and expert? ___ Reply to this item at: http://gna.org/patch/?5007 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5774] Help: Check that ruleset has relevant _Possible effects
Follow-up Comment #1, patch #5774 (project freeciv): Note that terrain Transform capability of the unit is not handled this way. As there's no hardcoded unit type flag related to it any more, help for it comes (in supplied rulesets at least) from the user unit type flag. So it's ruleset author's responsibility to handle that. ___ Reply to this item at: http://gna.org/patch/?5774 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #17, bug #21851 (project freeciv): If it helps, in my case, the event that increase the memory usage the most is the use of the dropdown menu to change the production in the city window. In the Overview tab? I almost never use that myself, using the worklist even when I want to modify just the current production (first item in the list). Does it work as a workaround for you, or does using the Production -tab cause similar memory problem? ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Follow-up Comment #7, bug #23154 (project freeciv): 1: 0x44b1ae0 1889 Legion at (82,33) Motecuhzoma Ilhuicamina 1: in handle_tile_info() [packhand.c::2730]: assertion '0 == unit_list_size(ptile-units)' failed (2015/02/01 16:49:58) now I have proper savegame (bug_23154.sav.bz2) (file #23684) ___ Additional Item Attachment: File name: bug_23154.sav.bz2 Size:168 KB ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #16, bug #21851 (project freeciv): If it helps, in my case, the event that increase the memory usage the most is the use of the dropdown menu to change the production in the city window. This problem used to force me to restart the system when running out of memory, but I learnt to avoid it by changing the swappiness to 10 (it was 60 by default), as suggested here: https://help.ubuntu.com/community/SwapFaq Now, I just need to close freeciv and open it again when getting slow. At the end of the game, once every turn or so, but I have only 2GB RAM. ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23223] Freeciv-web bugs with sending arrays
Update of bug #23223 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #5: This has been fixed now. I have verified and tested it. Thanks again! ___ Reply to this item at: http://gna.org/bugs/?23223 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5007] civ2civ3: custom veteran system for Engineers?
Follow-up Comment #7, patch #5007 (project freeciv): I like the idea of giving veteran chances to workers and reducing the chances to engineers, but I'm not sure about the best way. In civ2civ3, like classic, the veteran power factors are 100, 150, 175, 200. And I'd like to keep it the same for combat and work. I like the veteran chances from experimental rules: veteran_work_raise_chance = 2, 1, 0 veteran_power_fact= 100, 125, 150 But I find confussing that veteran combatient has power 150%, while veteran worker with same icon has 125%. And I think even this minimum chance would create too much veteran workers, if available from start: veteran_work_raise_chance = 1, 0 veteran_power_fact= 100, 150 So, I'd vote to keep veterancy only for engineers: veteran_work_raise_chance = 3, 2, 1, 0 veteran_power_fact= 100, 150, 175, 200 But they would require 4 veterancy names. What about beginner, seasoned, senior and master? I'll do the patch if no better suggestions. ___ Reply to this item at: http://gna.org/patch/?5007 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #18, bug #21851 (project freeciv): In the Overview tab? Yes, for some reason I find it faster here than changing the tab. Does using the Production -tab cause similar memory problem? I admit I hardly use the production tab, so I can't tell. I'll test to use the tab instead of the dropdown menu, to see if I notice an improvement. ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5776] Make ENTER in tooltip bold
URL: http://gna.org/patch/?5776 Summary: Make ENTER in tooltip bold Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 01:03:08 AM EET Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Markup ENTER in Press ENTER or double-click to sell an improvement. -tooltip bold in gtk-clients. While this should be purely cosmetic change, as I investigated bug #21851 the old tooltip (using gtk_widget_tooltip_set_text() ) seemed to be involved to some weird memory usage behavior. The difference was just above the noise of other things allocating and freeing memory, so it's hard to tell if it was real; if there is something wrong with the old tooltip (and no similar problem with the new one). But anyway, changing it to this should not hurt either. ___ File Attachments: --- Date: Mon 02 Feb 2015 01:03:08 AM EET Name: SellTooltipMarkup.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=23686 ___ Reply to this item at: http://gna.org/patch/?5776 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #20, bug #21851 (project freeciv): If I actually choose something from the menu, Xorg takes a lot of memory and that's not restored for some time. That is similar to what I noticed. Most of my pc freezes occurred at that point, just when I press a item in the drop down menu. I can't be sure if the memory of the dropdown menu is restored later in my case too, because I simply monitorized it by eye. But I'm sure that, the more I open the city dialogs, the bigger the memory usage. Does the usage of those buttons cause similar memory consumption problem for you? Now that you say it, I actually try to use those buttons because I did notice that they do not cause the same memory consumption than closing the window and opening a new city dialog. But I have not measured it objectively. This is an important problem that makes it hard for me to play in my laptop, please tell me if I can run some tool to help with the diagnosis. ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5775] Remove unused change_shell
URL: http://gna.org/patch/?5775 Summary: Remove unused change_shell Project: Freeciv Submitted by: cazfi Submitted on: Sun 01 Feb 2015 09:49:12 PM EET Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Remove unused change_shell variable from gtk-clients' city dialog. Targeting also stable branches to keep code identical for further attempts to fix bug #21851. ___ File Attachments: --- Date: Sun 01 Feb 2015 09:49:12 PM EET Name: ChangeShellRm.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=23685 ___ Reply to this item at: http://gna.org/patch/?5775 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #19, bug #21851 (project freeciv): I can't reproduce any lasting memory loss (sometimes it takes a while for things to settle). When I first open the dropdown menu, Xorg takes a bit more memory. If I then cancel the menu (click the arrow again), the memory is immediately restored. If I actually choose something from the menu, Xorg takes a lot of memory and that's not restored for some time. Though that memory usage is not necessarily any way related to your problem, I tracked it down to the fact that production change request is sent to the server, server sends an updated city info with the changed production target, and the already open city dialog gets refreshed in its entirety (so the problem can be in any element of the dialog, not necessarily in the production menu (which I assume gtk to close already before the server response gets handled)) In addition to handling of the server sent message, there's another case where real_city_dialog_refresh() gets called for open dialog: when one changes to Next or Prev city. Does the usage of those buttons cause similar memory consumption problem for you? ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5777] Void parameter list for city_dialog_update_prev_next()
URL: http://gna.org/patch/?5777 Summary: Void parameter list for city_dialog_update_prev_next() Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 01:16:01 AM EET Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Both gtk-clients. ___ File Attachments: --- Date: Mon 02 Feb 2015 01:16:01 AM EET Name: CDUPNVoid.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=23687 ___ Reply to this item at: http://gna.org/patch/?5777 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5763] Tribal government gets martial law 2 per unit
Update of patch #5763 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Follow-up Comment #4: _And I did not create a different patch for S2_6 because I guess it would be the same, but I can do it if you prefer._ There is no need to create an extra patch when it is the same. ___ Reply to this item at: http://gna.org/patch/?5763 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [Freeciv-commits] r27927 - in /branches/S2_6: data/civ2civ3/effects.ruleset doc/README.ruleset_civ2civ3
On 1 February 2015 at 21:43, sveinun...@users.sourceforge.net wrote:
Author: sveinung
Date: Sun Feb 1 20:43:30 2015
New Revision: 27927
URL: http://svn.gna.org/viewcvs/freeciv?rev=27927view=rev
Log:
civ2civ3: Give Tribal government 2 martial law per unit.
Increase the effect of martial law under Tribal government from 0 to 2 per
unit. This should make it a good alternative to Despotism again. (Tribal's
extra movement was replaced by a higher probability of gaining veterancy in
combat)
Patch by David Fernandez bardo
See patch #5763
Modified:
branches/S2_6/data/civ2civ3/effects.ruleset
branches/S2_6/doc/README.ruleset_civ2civ3
+[effect_martial_law_max]
type= Martial_Law_Max
value = 3
reqs=
+{ type, name, range, present
+; Gov, Anarchy, Player, FALSE
+; Gov, Tribal, Player, FALSE
+; Gov, Communism, Player, FALSE
+; Gov, Despotism, Player, FALSE
+; Gov, Monarchy, Player, FALSE
+ Gov, Fundamentalism, Player, FALSE
+ Gov, Federation, Player, FALSE
+ Gov, Republic, Player, FALSE
+ Gov, Democracy, Player, FALSE
}
Is there a situation where Martial_Law_Each is not 0, and
Martial_Law_Max should have value other than 3? Or could we clean out
all these Gov requirements from this Martial_Law_Max effect?
- ML
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #21, bug #21851 (project freeciv): If I actually choose something from the menu, Xorg takes a lot of memory and that's not restored for some time. That seems to correlate with the fact that the menu opens on top of city improvements list - once the menu closes, pointer is on top of improvements list - often times tooltip of that list opens. The memory consumption seems a bit high for such a simple widget as the tooltip opened, but after removing the tooltip from the source code completely this high memory consumption disappears. patch #5776 is related to this. ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5691] civ2civ3: help texts for governments
Follow-up Comment #1, patch #5691 (project freeciv): Is it intended that trade-corruption-by-distance under Federation is half that of other governments (except Communism where there is none), and that learning The Corporation eliminates trade-corruption-by-distance for Federation whereas it halves it for other governments? ___ Reply to this item at: http://gna.org/patch/?5691 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5779] Remove unused enum info_style from citydlg.c
URL: http://gna.org/patch/?5779 Summary: Remove unused enum info_style from citydlg.c Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 03:36:09 AM EET Category: client-gtk-3.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Styles are not handled like that in gtk3-client. Unfortunately that handling cannot be backported to gtk2-client, where valgrind gives warnings about the old styles stuff. ___ File Attachments: --- Date: Mon 02 Feb 2015 03:36:09 AM EET Name: InfoStyleRm.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=23689 ___ Reply to this item at: http://gna.org/patch/?5779 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23225] can_extra_be_removed() leaks virtual tiles
Update of bug #23225 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23225 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5718] Sdl2-client widgets with UTF-8 text
Update of patch #5718 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: - Updated against svn (file #23693, file #23694) ___ Additional Item Attachment: File name: Sdl2Utf8-4.patch.bz2 Size:39 KB File name: Sdl2Utf8-S2_6-4.patch.bz2 Size:39 KB ___ Reply to this item at: http://gna.org/patch/?5718 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23154] failed assertion in handle_tile_info
Update of bug #23154 (project freeciv): Category:None = client Planned Release: = 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/bugs/?23154 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23234] Info label styles not unref'd
URL: http://gna.org/bugs/?23234 Summary: Info label styles not unref'd Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 03:58:53 AM EET Category: client-gtk-2.0 Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: popdown_all_city_dialogs() marks city dlgs uninitialized, so they get initialized again when opened next time. New initialization will create new GtkRcStyles for info labels, leaking the old ones. Attached fix makes popdown_all_city_dialogs() to unref old styles. ___ File Attachments: --- Date: Mon 02 Feb 2015 03:58:53 AM EET Name: InfoStyleUnref.patch Size: 754B By: cazfi http://gna.org/bugs/download.php?file_id=23691 ___ Reply to this item at: http://gna.org/bugs/?23234 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5691] civ2civ3: help texts for governments
Follow-up Comment #2, patch #5691 (project freeciv): It sounds odd when you describe how I implemented it, but I think it is correct. The final result should be that all governments increase the trade-corruption by 2 per tile, except Federation where it is 1 per tile. Once Corporation is researched, it is 1 per tile for every government (reduced by 1 = halved), except for Federation that is completely removed (reduced by 1). Communism is the other exception, where corruption and waste is 0 per tile, no matter the researchs. The Trade technology should have the same effect over shield-waste, than Corporation over trade-corruption. With both techs, Trade and Corporation, then Federation has no corruption nor waste, same than Communism. Maybe there is a better way to implement it, because I guess this one is not friendly for the autogenerated help. ___ Reply to this item at: http://gna.org/patch/?5691 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5768] Make sure string array from create_new_line_utf8strs() is NULL terminated
Update of patch #5768 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5768 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)
Follow-up Comment #22, bug #21851 (project freeciv): After some more tests, I think you are right, the key factor is the selection of a item in the dropdown menu. No need to click it, just to move the mouse over the items, and the memory usage of Xorg increase a ridiculous amount, up to 100 MB in my tests!!, that are never recovered once the city dialog is closed. I can reproduce it whenever I want now. I simply open a city dialog, click the dropdown menu, then I move the mouse up and down over the items for some time, then I close the menu without selecting anything, I close the city dialog, and the memory usage of Xorg increase from the initial 100 MB, to 200 MB or so. If I repeat with another city, it increases to 300 MB, and so on until my pc runs out of memory. I'll test that patch. ___ Reply to this item at: http://gna.org/bugs/?21851 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5780] Initialize 'city_dialogs_have_been_initialised'
URL: http://gna.org/patch/?5780 Summary: Initialize 'city_dialogs_have_been_initialised' Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 03:50:48 AM EET Category: client-gtk-2.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: The variable guarding whether city dialogs have been initialized, is not initialized itself. Initialize it. ___ File Attachments: --- Date: Mon 02 Feb 2015 03:50:49 AM EET Name: InitializeInitialize.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=23690 ___ Reply to this item at: http://gna.org/patch/?5780 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5769] Copy Research Data
Update of patch #5769 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5769 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23214] Fundamentalism food upkeep 3
Update of bug #23214 (project freeciv): Status: In Progress = Ready For Test Planned Release: 2.5.0, 2.6.0, 3.0.0 = 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Follow-up Comment #3: Patch (file #23695) ___ Additional Item Attachment: File name: MultiFundamentalist.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?23214 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23237] Heading for diplomatic actions: Orders of xxx aborted because of failed move
URL: http://gna.org/bugs/?23237 Summary: Heading for diplomatic actions: Orders of xxx aborted because of failed move Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 06:45:44 AM EET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Using alien ruleset, I tried to copy research data (steal tech) from an enemy city. That resulted in two messages from server: Orders of Stealth Spy aborted because of failed move. No new techonology found in Rock. I think first one of these should not be there (don't know if it would be there even after succesful mission) ___ Reply to this item at: http://gna.org/bugs/?23237 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5781] Setting Default(ness) level
URL: http://gna.org/patch/?5781 Summary: Setting Default(ness) level Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Feb 2015 07:24:24 AM EET Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0, 3.0.0 ___ Details: Replace boolean 'changed' information about settings with defaultness level. If the setting value originates from the ruleset (defaultness level 'ruleset'), rulesave saves it to game.ruleset settings. ___ File Attachments: --- Date: Mon 02 Feb 2015 07:24:24 AM EET Name: SettingDefaultLevel.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=23696 ___ Reply to this item at: http://gna.org/patch/?5781 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
