[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-20 Thread J. M. Gorbach 
Follow-up Comment #6, patch #6434 (project freeciv):

> The scenario as it appears in the patch. Added separately to make it easier
to have a quick look.
It's very impressive.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23953] Autogenerated help claims that disband in a city has a profit

2015-10-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Autogenerated help claims that disband in a city has
a profit
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 20 Oct 2015 12:35:24 PM UTC
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: Any
 Planned Release: 3.0.0

___

Details:

It became possible to disband a unit in a city without getting 50% of its
production cost when Recycle Unit was split from Disband Unit.



___

File Attachments:


---
Date: Tue 20 Oct 2015 12:35:24 PM UTC  Name:
0010-Update-help-generation-for-Recycle-Unit.patch  Size: 1kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6453] Centralize action blocks action

2015-10-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Centralize action blocks action
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 20 Oct 2015 12:27:14 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Move the code checking if an enabler controlled action is blocked by the
legality of another enabler controlled action to a central location.



___

File Attachments:


---
Date: Tue 20 Oct 2015 12:27:14 PM UTC  Name:
0001-Centralize-action-blocks-action.patch  Size: 7kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6454] Explain if action blocks action

2015-10-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Explain if action blocks action
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 20 Oct 2015 12:32:31 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:





___

File Attachments:


---
Date: Tue 20 Oct 2015 12:32:31 PM UTC  Name:
0002-Explain-if-action-blocks-action.patch  Size: 3kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6454] Explain if action blocks action

2015-10-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6454 (project freeciv):

  Depends on: => patch #6453


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6455] SDL 2 client: Use ruleset defined action ui names

2015-10-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: SDL 2 client: Use ruleset defined action ui names
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 20 Oct 2015 02:24:04 PM UTC
Category: client-sdl2
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Tue 20 Oct 2015 02:24:04 PM UTC  Name:
3.0-SDL-2-client-Use-ruleset-defined-action-ui-names.patch  Size: 4kB   By:
sveinung


---
Date: Tue 20 Oct 2015 02:24:04 PM UTC  Name:
2.6-SDL-clients-Use-ruleset-defined-action-ui-names.patch  Size: 4kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-10-20 Thread Sławomir Lach 
Follow-up Comment #62, patch #6104 (project freeciv):

Each commit expect one was fixup. I send newest patch.

Is it not too hard helping me with preparing a patch ;-D ?

(file #25372)
___

Additional Item Attachment:

File name: 0001-Introducing-unit-flag-allowing-unit-to-escape-from-t.patch
Size:23 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6452] sandbox ruleset

2015-10-20 Thread Sławomir Lach 
Follow-up Comment #1, patch #6452 (project freeciv):

I think that Freeciv developers should copy experimental ruleset into new
name. What about savegame compatibility? Who cares? If someone have played in
experimental ruleset, I think it do this for testing reasons.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23955] Editor Tool Icon Leak

2015-10-20 Thread Marko Lindqvist 
URL:
  

 Summary: Editor Tool Icon Leak
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 20 Oct 2015 10:26:44 PM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Though the code in question is (almost) identical between gtk2- and
gtk3-client, only gtk3-client is leaking memory because of the different logic
in sprite implementation called.

Fix attached.



___

File Attachments:


---
Date: Tue 20 Oct 2015 10:26:44 PM EEST  Name: ToolIconsLeak.patch  Size: 3kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-10-20 Thread Sławomir Lach 
Follow-up Comment #64, patch #6104 (project freeciv):

Repaired. I will have deeper look into my patch at end of this week.

(file #25374)
___

Additional Item Attachment:

File name: 0001-Introducing-unit-flag-allowing-unit-to-escape-from-t.patch
Size:23 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23954] Pixamp too short in city dialog in supported units

2015-10-20 Thread mir3x 
URL:
  

 Summary: Pixamp too short in city dialog in supported units
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 20 Oct 2015 07:25:09 PM CEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.2, 2.6.0, 3.0
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

In trident ruleset,in gtk3 client, food upkeep is shown partially, because
pixmap holding it is too small.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6443] Include svn revision to name of Windows Installer Snapshot build

2015-10-20 Thread Marko Lindqvist 
Update of patch #6443 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-10-20 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #63, patch #6104 (project freeciv):

Quick look:

+#define SPECENUM_VALUE77 L_DEFEND_OK
 #define SPECENUM_VALUE75NAME N_("?unitflag:DefendOk")
You forgot to update the name.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23942] Sdl2-client erronously prefers theme by the sdl-client specific setting

2015-10-20 Thread Marko Lindqvist 
Update of bug #23942 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23944] government menu icons: gtk_image_set_pixel_size: assertion 'GTK_IS_IMAGE (image)' failed

2015-10-20 Thread Marko Lindqvist 
Update of bug #23944 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6245] Drop sdl-client

2015-10-20 Thread Marko Lindqvist 
Follow-up Comment #3, patch #6245 (project freeciv):

Earlier list of files and directories to remove was missing some entries. Full
list:
- client/gui-sdl
- data/themes/gui-sdl
- m4/sdl-client.m4
- m4/sdl.m4
- bootstrap/freeciv-sdl.appdata.xml.in
- bootstrap/freeciv-sdl.desktop.in

This ticket does not touch client options at all - they cannot be completely
removed as we want to allow migrating them to sdl2-client.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23383] Qt: Unit upkeep window is too short on Trident ruleset.

2015-10-20 Thread mir3x 
Additional Item Attachment, bug #23383 (project freeciv):

File name: qt_upkeep.patchSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23383] Qt: Unit upkeep window is too short on Trident ruleset.

2015-10-20 Thread mir3x 
Follow-up Comment #2, bug #23383 (project freeciv):

Changed.

But maybe there exists some sample sprite which could be loaded, to calculate
exact size of unit ? Or maybe I could check some sprite which should exists in
every tileset ? ( in order to be sure that pixmap will hold whole uni and
overlays)

Otherwise if I calculate size after getting first unit, then units area would
be resized, then labels area too, and whole window might be too.

And I just spotted that bug exists in gtk3 client too.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5028] Server setting for random trait selection

2015-10-20 Thread Marko Lindqvist 
Follow-up Comment #3, patch #5028 (project freeciv):

I'm afraid choosing _min and _max values for the ruleset would get extra
complicated if one has to also consider what the "midpoint" will then be for
the default mode. Effects of the trait value are not always linear, or the
sensible variation is mostly to one direction from the sensible default.
So I think we need to make this even more complex by giving the ruleset author
control over the "fixed" value used when "random" from the range is not
chosen. But fortunately we can make ruleset based definition of that optional,
going by the midpoint of the range by default.

I'm not sure if trait ranges in experimental are identical to those in
variant2, but the latter values have been used in one real game, second one
currently running.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-20 Thread Jarkko Huttunen 
Follow-up Comment #10, bug #23861 (project freeciv):

Here's the files I got, when ending a network game with the patch. Trying to
run local game hanged up like before. No error messages.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23956] diplomats.c has many 'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs

2015-10-20 Thread Marko Lindqvist 
URL:
  

 Summary: diplomats.c has many
'unit_alive(were_checking_if_this_is_illegal_ptr->id)' -constructs
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 21 Oct 2015 12:48:34 AM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_6
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

unit_alive() checks in diplomats.c may result in an illegal memory access for
the very reason unit_alive() is supposed to protect against (using pointers to
a dead unit).

Unfortunately it's not obvious what to do to those cases. Are they kind of
sanity checks that can simply be removed? Or do we need to get the 'id' from
the time unit was certainly alive from somewhere?

There's such uses in unithand.c too. By a quick look two of them are both
completely safe and useless - the unit pointer is a result from a id based
query just before those unit existence checks.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6451] i18n: the Freeciv source files are UTF-8

2015-10-20 Thread Jacob Nevins 
Follow-up Comment #1, patch #6451 (project freeciv):

Would this make it safe to use UTF-8 in msgids (a restriction alluded to in
patch #3481)?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-20 Thread Jarkko Huttunen 
Follow-up Comment #11, bug #23861 (project freeciv):


"You imply it was OK with 2.5.0?
Skimming the changes 2.5.0->2.5.1, I don't spot (or recall) any changes to the
network handling."

I downloaded and installed 2.5.0 again while ago and it works. 2.5.1 doesn't.

"Does the "client hang up" make it unresponsive forever, or can you click
"Connect to Network Game" after a while"

Yes, it goes unresponsive forever.

From stderr.txt (attached):
"in scroll_if_necessary() [../../../../../client/gui-gtk-2.0/chatline.c::561]:
assertion 'scroll_target != ((void *)0)' failed."

Chatline goes over the bounds and/or stucks in a loop?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-20 Thread Sveinung Kvilhaugsvik 
Update of patch #6434 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6456] Give specific unit_move_to_tile_test() return value for animals getting out of native terrain

2015-10-20 Thread Marko Lindqvist 
URL:
  

 Summary: Give specific unit_move_to_tile_test() return value
for animals getting out of native terrain
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 20 Oct 2015 11:42:05 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Reusing MR_NO_TRANSPORTER_CAPATICITY might break some things in the future, so
when it's animals not moving out of their territory reutnr
MR_ANIMAL_DISALLOWED.



___

File Attachments:


---
Date: Tue 20 Oct 2015 11:42:05 PM EEST  Name: AnimalDisallowed.patch  Size:
902B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-20 Thread Jarkko Huttunen 
Additional Item Attachment, bug #23861 (project freeciv):

File name: freeciv-server_21_10.RPT   Size:3 KB
File name: stderr.txt Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5028] Server setting for random trait selection

2015-10-20 Thread Jacob Nevins 
Follow-up Comment #4, patch #5028 (project freeciv):

> I think we need to make this even more complex by giving the 
> ruleset author control over the "fixed" value used when 
> "random" from the range is not chosen.
I feared that.

Two possible ways (both affecting d3f) with different future expandability:
* New optional 'expansionist_default' in ruleset
** Server option selects whether this is used or uniform probability
distribution between min-max, ignoring 'default' (future option values could
use different probability distributions, possibly taking midpoint into
account)
* Allow a ruleset-defined set of min/max pairs, set one to min=max='midpoint'
in supplied rulesets
** Server option chooses which is used (a bit like 'nationset')

> I'm not sure if trait ranges in experimental are identical to 
> those in variant2, but the latter values have been used in one 
> real game, second one currently running.
They're not the same.


variant2experimental
(from   (from S2_6 svn)
freeciv-modpack)
expansionist30-90   35-80
trader  30-90   35-80
aggressive  55-125  35-80


Sounds like we should adopt the playtested values?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5340] Add terrain name->letter mapping to savefile format

2015-10-20 Thread Jacob Nevins 
Follow-up Comment #2, patch #5340 (project freeciv):

I think it would be nice for us to have a go at loading in 2.6, if anyone has
time.

As far as I know, this is still the only known barrier to the goal of
ruleset-independent scenarios. Until we do this we won't know what else needs
doing. If nothing else comes out of the woodwork then we could optimistically
hope to release that in 2.6. (However if it turns out to be at all complicated
we should defer that goal to 3.0 rather than trying to fix it, but I expect
the terrain mapping can stay in place.)

Having saving but not loading in 2.6 doesn't help much, I think; this is
mainly for scenarios which will have to be somewhat handcrafted anyway and
will generally be of the same format as the game version that's loading them.
It would allow rulesets to change their use of terrain letters between 2.6 and
3.0, but that seems unlikely to be interesting.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6451] i18n: the Freeciv source files are UTF-8

2015-10-20 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #2, patch #6451 (project freeciv):

> Would this make it safe to use UTF-8 in msgids
Yes.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3481] en_US locale (to restore diacritics etc)

2015-10-20 Thread Jacob Nevins 
Follow-up Comment #6, patch #3481 (project freeciv):

> (An alternative would be lifting the restriction that means 
> msgids have to be ASCII-only. I don't know what that entails.)
See patch #6451.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6451] i18n: the Freeciv source files are UTF-8

2015-10-20 Thread Marko Lindqvist 
Follow-up Comment #3, patch #6451 (project freeciv):

> Would this make it safe to use UTF-8 in msgids

Need to check gettext NEWS to see how things are in our minimum requirement
gettext.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5340] Add terrain name->letter mapping to savefile format

2015-10-20 Thread Marko Lindqvist 
Follow-up Comment #3, patch #5340 (project freeciv):

> However if it turns out to be at all complicated we should
> defer that goal to 3.0

TRUNK already has some "ruleset-independent scenarios" supporting code that
S2_6 does not. I would need to refresh my memory about the exact details, but
getting it to work correctly for all the cases we need to support was rather
hard even when taking advantage of the fact that in savegame3.c we don't need
to simultaneously support loading older formats.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6457] Server to support packet_unit_load to adjacent tile

2015-10-20 Thread Marko Lindqvist 
URL:
  

 Summary: Server to support packet_unit_load to adjacent tile
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 21 Oct 2015 06:58:58 AM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Change the server side (-> network protocol in a sense that such request is no
longer invalid) so that cargo to be loaded to specified transport with
packet_unit_load needs not to be on the same tile yet, but if it's in adjacent
tile it will try to move to the transport tile. Similarly the unit might be
loaded to another transport where it's first unloaded from.

This way the client can control also what transport cargo enters when the
loading happens on the shore so that the cargo unit cannot move to the ocean
tile without getting automatically loaded to some transport. This is a
prerequisite for proper unit loading UI:




___

File Attachments:


---
Date: Wed 21 Oct 2015 06:58:58 AM EEST  Name: LoadAdjacent-S2_6.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev