[Freeciv-Dev] [bug #24308] Adding to city does not cause "city_size_change" signal

[Marko Lindqvist]

URL:
  

 Summary: Adding to city does not cause "city_size_change"
signal
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 14 Jan 2016 11:36:36 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24307] City growth causes double "city_size_change" signal

[Marko Lindqvist]

Update of bug #24307 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

The generic city_increase_size() function must not emit the new
"city_size_change" signal like we do for old "city_growth" signal.
"city_size_change" gets emitted in calling functions.

Fix attached

(file #26335)
___

Additional Item Attachment:

File name: GrowSignalOnce.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24308] Adding to city does not cause "city_size_change" signal

[Marko Lindqvist]

Update of bug #24308 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Fix attached

(file #26336, file #26337)
___

Additional Item Attachment:

File name: UnitAddCitySizeEmit.patch  Size:1 KB
File name: UnitAddCitySizeEmit-S2_6.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6816] default.lua namespace

[Marko Lindqvist]

URL:
  

 Summary: default.lua namespace
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 14 Jan 2016 01:08:23 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Since ruleset specific script.lua and default.lua share function namespace,
default lua should use well-known namespace so that as long as script.lua does
not use that namespace there won't be conflicts even when newer version adds
new functions to default.lua.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

[Marko Lindqvist]

Update of task #7814 (project freeciv):

  Depends on: => patch #6816


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6775] Qt client - added trade planning

[Frank]

Follow-up Comment #2, patch #6775 (project freeciv):

If you need a test case with "unusual" trade rules check out the attached
2.5/dunnoob/effects.ruleset

General idea: The 1st trade route per city needs a marketplace. The 2nd, 3rd,
and 4th trade route need a bank.  Additionally the 3rd and 4th trade route
require magnetism and corporation (in any order, same idea as in the classic
ruleset.)  In all cases a stock exchange instead of a temporarily destroyed
marketplace or bank is good enough (= "fire insurance").

(file #26338)
___

Additional Item Attachment:

File name: effects.rulesetSize:54 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Andreas Røsdal]

URL:
  

 Summary: Freeciv-web server using max cpu
 Project: Freeciv
Submitted by: andreasr
Submitted on: Thu 14 Jan 2016 10:42:45 PM UTC
Category: freeciv-web
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

In the current version of Freeciv-web, sometimes the Freeciv C server begins
using 100% CPU and several gigabytes of memory. This is with Freeciv server
svn revision 30535.

Here is a backtrace from attaching to such as process:

(gdb) bt full
#0  utf8_check_string (string=string@entry=0x7ffef2285ec0 "You can't modify your spaceship after launch!",
length=length@entry=74) at utf.c:174
count = 1
i = 62
#1  0x7f059f346e96 in json_stringn (value=0x7ffef2285ec0 "You can't modify your spaceship after launch!",
len=74) at value.c:699
No locals.
#2  0x0060ea82 in dio_put_string_json ()
No symbol table info available.
#3  0x00589f89 in send_packet_chat_msg_100 ()
No symbol table info available.
#4  0x004092d8 in notify_conn_packet ()
No symbol table info available.
#5  0x00409a19 in notify_player ()
No symbol table info available.
#6  0x00433714 in adv_spaceship_autoplace ()
No symbol table info available.
#7  0x0041156b in srv_main ()
No symbol table info available.
#8  0x00407e89 in main ()
No symbol table info available.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

[Sveinung Kvilhaugsvik]

Update of patch #6104 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #66:

I spent a lot of time trying to make it work so I could test it. (A typo in
setting the name of the "Hut" unit role flag prevented the default civ2civ3
ruleset from loading) Then I fixed a bug that triggered an assertion. (The
defender unit, with hp less than or equal to 0, didn't reach the "didn't
escape" code) At that point I just addressed any remaining issue I could
find.

Please improve the testing of any future patches. See
http://freeciv.wikia.com/wiki/Testing_Tips

My changes (that I remember):
 * various white space changes
 * various English changes
 * move the documentation ruleset comments from unit class flags to unit type
flags. Remove them from rulesets that don't document unit type flags.
 * rewrite and complete documentation ruleset comments
 * add documentation ruleset comments to multiplayer and sandbox. (Sandbox
didn't exist when this patch was submitted)
 * "?unitfLg:" -> "?unitflag:"
 * fixed typo SPECENUM_VALUE74AME
 * fixed type added to comment that shouldn't be changed
 * move check of unit hp to escape test. (It caused a bug)
 * merge if statements in escape
 * assert that an escaping unit has hp left
 * check that a tile has 0 units rather than that the first unit in its unit
list is NULL
 * check the defense for unit type rather than unit type class
 * don't tell the attacking player that he has killed a unit that escaped
 * move escape text below the lost the battle text

(file #26339)
___

Additional Item Attachment:

File name: Let-some-units-escape-stack-death-sveinung.patch Size:26 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Sveinung Kvilhaugsvik]

Update of bug #24309 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Release: => TRUNK, 2.6 
 Planned Release: => 3.0.0, 2.6.0   

___

Follow-up Comment #1:

Untested patch attached. I haven't checked if the problem is present in 2.5
too.

(file #26340)
___

Additional Item Attachment:

File name: 0001-Don-t-autoplace-spaceship-parts-after-launch.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Andreas Røsdal]

Follow-up Comment #2, bug #24309 (project freeciv):

Thanks! Pushed to production.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24309] Freeciv-web server using max cpu

[Marko Lindqvist]

Update of bug #24309 (project freeciv):

Category: freeciv-web => general
 Planned Release:3.0.0, 2.6.0 => 3.0.0, 2.6.0, 2.5.2

___

Follow-up Comment #3:

> I haven't checked if the problem is present in 2.5 too.

At least the server-side autoplace code for all players was ported to S2_5
too. It has been added since 2.5.1 -> this would be an regression, and we are
about to release 2.5.2 this weekend.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24306] View-tab not translatable in QT client

[Markus Linnakangas]

Follow-up Comment #2, bug #24306 (project freeciv):

Good point Marko, you are exactly correct. I did not bother to test with
default language, which of course I should have. After using Q_() macro as you
suggest, it works fine with default language and with translation.

Would be great if this small fix could still get in the 2.5.2 release, the
string is already translated (at least in Finnish) in po-file, and if fix is
not done, the untranslated "View" is visible all the time in main screen
during the gameplay in QT client.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev