[Freeciv-Dev] [patch #1212] command key revamp (see also patch #1188)
Follow-up Comment #2, patch #1212 (project freeciv): Compilation failed. Oops - thanks for catching that, Marko. Until I can get things set up for Windows, I'm editing blind... ___ Reply to this item at: http://gna.org/patch/?1212 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #22, patch #1188 (project freeciv): Understood, thanks Marko. I wasn't sure what to check in order to follow your request on the dev list. I'll first check that link in the future. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #20, patch #1188 (project freeciv): Cool, thanks Marko! It feels cool to have my first patch integrated into Freeciv... I wasn't sure if you were going to wait to run update-po until after committing the patches for the other clients (#1211, #1212, #1213). But the four patch tickets - especially this one - make some pretty big changes to translatable strings. Just thought I'd mention it since you'd requested on the dev list that we mention when patches contain changes to translatable strings. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13931] implement reset command
Follow-up Comment #14, bug #13931 (project freeciv): Thanks for adding the release field, Daniel. It's at least useful for non-admins to see what the admins think for timing. Touching on my previous comment, is there a way that non-admin users can set bug/patch dependencies? It would be helpful beyond the setting targeted release. For example, there are several patch chains of tickets which depend on another filed ticket (e.g. bug #13868, bug #13869, bug #13870, ... or patch #1211, patch #1212, patch #1213). It would be much nicer to be able to take advantage of gna's dependency chain tracking than having to rely on the title or comment fields. Is that possible? ___ Reply to this item at: http://gna.org/bugs/?13931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #18, patch #1188 (project freeciv): Hi, Marko and Matthias. Thank you both again for taking time to review my patches and for your comments. I've created a new patch, which rolls both stages into a single patch. (I figured that this was less confusing than trying to keep the menu reorg and modifier key changes as two separate stages). These are the only two patches needed for the GTK client: * (just added): keys_gtk_r15875_v03.diff * file #6195: helpdata.txt.diff Other clients: * patch #1211: SDL * patch #1212: Windows native * patch #1213: XAW I hope that I've been able to address both your comments either by modifications or by explanation. Please let me know if you'd like any further changes (e.g. Marko if you don't agree with my reasoning behind the position of the Edit and Civilization menus). I'd be happy to change my patches to meet the requirements for acceptance into Freeciv. (file #6457) ___ Additional Item Attachment: File name: keys_gtk_r15875_v03.diff Size:37 KB ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #16, patch #1188 (project freeciv): I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. I can understand the initial confusion. I'd agree to an extent, since I myself am still not sure this is the most optimal structure - but I think some of the strange feeling comes from previous experience (Tax Rates were in Edit previously, also not optimal). The idea is to separate actions that affect the game structure (i.e. preferences, etc.) and the game in progress (city list, tax rates, etc). Hence, your civilization (the overarching condition of the collection of cities, etc). I laid out my reasons much better before, but I also would like to repeat that if this set of patches are accepted, they'd be the basis for future evolution rather than the end-all be-all. Which would include integrating feedback from users like that. One message I get: Can't set sensitivity for non-existent menu main/Civilization/Tax Rates. It is repeated quit often for the client OK, I'll take a look into that and make a revised patch. I was going to make one other revision to bring it in line with the patches I submitted for other clients anyway. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #17, patch #1188 (project freeciv): I use the new menu structure. It is a little bit strange first - I expect tax setting in the game menu. Speaking of my incorporating feedback, I'd definitely like to take the opportunity to learn your other feelings. This first round was very focused on the unit selection and manipulation (and hopefully that shows up well :-) ). So I'm curious to hear if there were problems, suggestions, etc for those. Or anything else - user testing is iterative, and it's always good to hear feedback even if it's only testing on a small group... :-) (Note that there is one additional patch that I need to make for drop paratrooper/clean pollution, but I was waiting to do that until I had a better feeling of whether this patch would be accepted. I'm at least feeling hopeful, so I'll add that one as well this weekend.) ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13931] implement reset command
Follow-up Comment #11, bug #13931 (project freeciv): As written in [...] tickets can depend on each other Perhaps such a meta ticket is possible? That would be great, though I haven't been able to figure out how to set dependencies in the Savane interface. Besides meta tickets, that would also be very useful for multi-patch groups. Maybe a permissions issue for normal users? ___ Reply to this item at: http://gna.org/bugs/?13931 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #13, patch #1188 (project freeciv): Hi, Marko. Just wanted to check whether you still wanted me to modify the menu order, or if you were okay with the order as in my patches. As I said earlier, I'm happy to make your requested modifications now. As I mentioned below, my rationale for the menu order in these patches is that it's closer to the prior 2.x menu order (internal consistency) and recommended order for general-use applications (external consistency). ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #11, patch #1188 (project freeciv): OK, I'll get patches together and put each one in a separate ticket, so that they can be reviewed independently. - Civilization has general settings affecting your whole civilization, yet it is next to last menu. I would move it second after Game. I agree that might seem a little odd at first, but its commands affect game controls, rather than elements of the game itself (views, lists, etc - the exception is revolution, but tough to say where else to put it at the moment). This has worked well for e.g. Photoshop, Illustrator, Flash (development), which offer palettes and other controls in a similar spot. I've used those apps regularly, and think it works well overall. But I admit that my same experience that led me to bring this arrangement in Freeciv may have clouded my judgment. :-) - Edit is not usually needed at all - I would move it after all the menus used in normal play, just before Help. I tried to follow the generally accepted order of menus (File, Edit, View, Select, Window = Civilization, Help). But this Edit menu is also more vestigial than useful. Once the menus are converted to GtkUIManager, it'll be possible to change top-level items. Then edit mode can gain more menu items, better/more shortcuts (no conflicts with game menus). That would allow the edit mode commands to disappear from Edit, and it would make sense to move the others out and remove Edit completely. I see this revamp as the start of an iterative process, focusing on unit management this round. I didn't clean up the other menus as much, because the final arrangement isn't yet clear in my head and I wanted to avoid too much moving around during future steps. That said, I'm more than happy to make your two changes to the patches if you still see fit. I just wanted to explain my thoughts a bit, in case that showed a bit more method to my madness... :-) ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1211] command key revamp (see also patch #1188)
URL: http://gna.org/patch/?1211 Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-sdl Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Patch to ensure that SDL client uses same command keys as GTK client and the information in the global helpdata.txt. (GTK changes in patch #1188) * new command keys * consistent text with key and across clients * patch for helpdata.txt in patch #1188 Please note: This patch contains changes to translatable strings, so update-po should be run after the patch is applied. ___ File Attachments: --- Date: Saturday 08/01/2009 at 15:19 Name: keys_sdl_r15860_v01.diff Size: 21kB By: jkeller http://gna.org/patch/download.php?file_id=6319 ___ Reply to this item at: http://gna.org/patch/?1211 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #12, patch #1188 (project freeciv): I just submitted patches for the other clients: * patch #1211: SDL * patch #1212: Windows native * patch #1213: XAW These three bring the same changes to other clients as the files in this patch: * file #6194: (apply first) menu.c.01_reorg.diff * file #6197: menu.c.02_accels_revised.diff * file #6195: helpdata.txt.diff After all patches are applied, update-po should be run to catch the changes to translatable strings. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1212] command key revamp (see also patch #1188)
URL: http://gna.org/patch/?1212 Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-win32 Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Patch to ensure that Windows native client uses same command keys as GTK client and the information in the global helpdata.txt. (GTK changes in patch #1188) * new command keys * consistent text with key and across clients * patch for helpdata.txt in patch #1188 Please note: This patch contains changes to translatable strings, so update-po should be run after the patch is applied. ___ File Attachments: --- Date: Saturday 08/01/2009 at 15:19 Name: keys_win32_r15860_v01.diff Size: 6kB By: jkeller http://gna.org/patch/download.php?file_id=6320 ___ Reply to this item at: http://gna.org/patch/?1212 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1213] command key revamp (see also patch #1188)
URL: http://gna.org/patch/?1213 Summary: command key revamp (see also patch #1188) Project: Freeciv Submitted by: jkeller Submitted on: Saturday 08/01/2009 at 15:19 Category: client-xaw Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Patch to ensure that XAW client uses same command keys as GTK client and the information in the global helpdata.txt. (GTK changes in patch #1188) * new command keys * consistent text with key and across clients * patch for helpdata.txt in patch #1188 Please note: This patch contains changes to translatable strings, so update-po should be run after the patch is applied. ___ File Attachments: --- Date: Saturday 08/01/2009 at 15:19 Name: keys_xaw_r15860_v01.diff Size: 8kB By: jkeller http://gna.org/patch/download.php?file_id=6321 ___ Reply to this item at: http://gna.org/patch/?1213 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #8, patch #1188 (project freeciv): Wow, Marco. Thanks for the willingness to experiment! I definitely understand and respect not wanting to make different key usage in different clients. I tried to make these changes logical and at the same time not too disruptive (I don't think anyone would want to have the basic go-to changed to Z :-D ), and tried to think of the other clients while working on the GTK client (I think I've actually reduced the number of Ctrl-key combinations, nicer for everyone). So it's entirely logical to want to bring these changes to other clients, and is my hope as well. I've looked at the other clients, and I'd be willing and able to create patches for SDL, XAW and Windows native clients. I'd just change the keys (to keep consistency between clients) but not the menu layout (so as to avoid breakage). Then the maintainers for the two other clients with menus (XAW and Windows) could revise menu structure per the final GTK implementation, as they saw fit. I could have those three patches for this weekend; would you be interested? Would that help get these changes in for 2.1? Here's my reasoning for hoping to get my changes in for 2.1: 0 In the GTK client as it stands, there are new keys for selecting units, and the editing mode is implemented (both new since 2.0) - my patches affect both. I'd love to have my new key structure implemented so that it could get revised during the 2.1 cycle (more people testing = more input). 0 I'm hoping to move the GTK client's menu to GtkUIManager instead of GtkItemFactory. This would permit some big UI fixes, potentially also helping the editor. (Whether implemented in 2.1 or not would depend on the project's policy for UI changes to released versions, which I'm not familiar with). I certainly don't want to pressure you, and am happy to follow your decision. On the other hand, I've been itching for years to get started with this work (hampered by time but also the old RT bug tracker), so if I sound eager it's because I am. :-) ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #9, patch #1188 (project freeciv): Excuse me, I must have a tired brain. I meant 2.2 where I wrote 2.1 in my previous comment... i.e. hoping to get these changes into 2.2 before it's branched. ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #6, patch #1188 (project freeciv): Glad to hear the patches worked for you, Marko! I had split the patch into two patches in order to avoid noise created by the renaming. That makes it possible to see the basic restructuring (menu.c.01_reorg.diff) and the (necessary) refinements (to allow shortcuts to coexist, etc - menu.c.02_accels_revised.diff). The documentation patch isn't really useful on its own either, and in fact includes some changes that address prior command changes (by other developers) which aren't currently shown in the help system. This was why I've included three patches in one ticket. Moving items around in the menu and then renaming them is actually an atomic operation - the goal is a large menu and command redesign. I can place patch menu.c.01_reorg.diff and menu.c.02_accels_revised.diff in two tickets - would you like me to go forward on that? But I'm not sure that there's any other way to reduce the patch size further. I'd be happy to make changes if you had suggestions, I'm still trying to learn the process for this project... ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
Follow-up Comment #3, patch #1188 (project freeciv): Huh, that's odd. menu.c hasn't changed since I made the patches. Maybe I made an error? Which patch doesn't work? Did you apply them in order? (menu.c.01_reorg.diff, menu.c.02_accels_revised.diff, then helpdata.txt.diff) menu.c.02_accels.diff (attachment 6196) should be marked as obsolete or superseded or however Gna marks a patch as old... I had tried to split the big patch into two logical parts, but maybe it would be better as a single patch. would you prefer that? In any case, thanks for taking the time to review it (or at least try ;-) ). ___ Reply to this item at: http://gna.org/patch/?1188 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Follow-up Comment #7, bug #13843 (project freeciv): OK, that makes sense - much better to fix the problem deeper down. Shows how much I have to learn about the depths of the code. :-) Still, I can't help but wonder: can_units_do_base() and can_units_do_base_gui() return essentially the same information, but with two different code paths and different tests. Besides applying your patch, wouldn't it be good to also normalize these two functions? (Not necessarily the way I did it, but something to prevent discordances like this, should the base functions change again.) ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Follow-up Comment #5, bug #13843 (project freeciv): Sorry, Marko. I suppose I should have given more info so that you could reproduce. Steps: * with a unit capable of it, build a fortress (either with new Build Base Fortress or with old Build Fortress) * after fortress is built, now look at available commands for the same unit on that tile ** Fortress under Build Base is insensitive ** Build Fortress is still sensitive The above also applies to Airbase. The above steps should show the inconsistency: 1) The new commands reflect whether the base type can be built by the unit as well as whether there is already a base of that type on the current tile. 2) The old commands only reflect whether the unit has the technical ability to build, not whether there is already a base of that type present on the current tile. My patch changed the check for the old commands so that their sensitivity was the same as for the new commands under the Build Base menu. ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1188] proposed menu and command key revamp
URL: http://gna.org/patch/?1188 Summary: proposed menu and command key revamp Project: Freeciv Submitted by: jkeller Submitted on: Saturday 07/11/2009 at 16:56 Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any ___ Details: Please note that these patches are revised and updated from a previous ticket on RT: http://bugs.freeciv.org/Ticket/Display.html?id=40216 That old ticket can be closed as obsolete. REVISION: The patches in this ticket apply to the latest revision of trunk (15826) as of this filing. TRANSLATION: These patches contain changes to translatable strings, so update-po should be run if/when they are accepted. BACKGROUND I've made an attempt to restructure Freeciv's menus in a way that makes sense for both new users and old hands. I consider myself a casual old-timer, having played Freeciv for several years, but not every day. I've always found the single, long Orders menu daunting. Commands are found in large groups (between dividers), new commands are hard to find when they're added, and I expect that new users have a very hard time discovering even common commands (Go to is sixth down in the fourth group). Having a single, long menu for all unit commands makes it very hard to define good mnemonics (the underlined letters) which also don't conflict with each other. The length also leads to putting commands in sub-menus (presumably to avoid making the Orders menu even longer). But these are hard to target with the mouse, and hard to use as a way to discover to available commands. Some accelerators require pressing Control and Shift together, a hand-twisting exercise for commands that users are likely to use often. Even more importantly, it's a hurdle for accessibility. Tear-off menus seem like a great idea, but don't beat the simplicity of better menu organization and modeless dialog boxes. The typical user (even in Linux) aren't going to have encountered them elsewhere, and so aren't likely to discover their use. Instead, I hoped to improve the situation for everyone and avoid the need for a tear-off menu. The exception was the View menu, which I would like to revisit in the future. STRUCTURAL CHANGES The Game menu, like the File menu in any other program, should really be thought of as a meta menu. It should handle the principle object (the game) as a black box, rather acting on the the things contained within the object. I moved the tax rates and revolution commands to the Reports menu; they have much more in common with the other items found there. I renamed the Reports menu to Civilization. While Freeciv isn't a spreadsheet [1], this menu nonetheless roughly corresponds to the Window menu in many applications: it's a list of tabs and toolkit windows that apply to the game as a whole. Using Window would help for external consistency, but that name is too generic. I think Civilization does a better job of showing that it contains commands that act on a large scale than Reports, which to me implies a set of static reports (the presence of the main view alone shows that the menu items aren't static). I've only worked on the GTK+ client, since I'm not familiar with any of the other clients. I realize that these patches would have an impact on the other clients, too (since the help documentation is common to all). These patches serve as a proof of concept and, if accepted, my hope is that it would be easy for the other client maintainers to change their clients to match. ACCELERATORS These deserve a special note: I'm very aware that changing these hotkeys is potentially disruptive and maybe even political. However, I've tried to take great care to keep the principal accelerators the same. My main guiding principals: * try to group together actions with their opposites (e.g. Sentry Unsentry [formerly Wake up others] are assigned S and Shift+S) * try to group together related actions (e.g. commands in Select menu) * try to make simple commands use no modifier * try to reserve Shift modifier for less-used or more-destructive commands The Select menu commands are new to trunk, so there shouldn't be a lot of people used to them already. I've based their layout on similar guiding principals behind Undo, Cut, Copy, Paste in terms of proximity on a QWERTY keyboard. Also note that all on tile and same type on tile are simply a Shift modifier apart. PATCHES I've split my changes into three patches: Rearrange the menus (menu.c.01_reorg.diff) * split up long Orders menu - Select menu for selecting units - Unit menu for movement and other actions on the unit itself - Work menu for actions mostly pertaining to workers/settlers - Combat menu for
[Freeciv-Dev] menu accelerator revamp, and next steps
Hooray for a working bug/patch tracker! I've submitted a renewed and revised version of my proposed menu+command revamp. I've even used the patch tracker (second patch in there) per the previous discussion for non-bug tickets. You can find my full explanation and the patches in patch #1188. This email is more about the future... My overall goal is to try to bring interface changes to Freeciv that would make it both easier to learn and easier to use, as well as some potentially cool things for interacting with the map and units. Lofty goals, but you all will be the ultimate judge of course. I'm going to try to take it in small steps... :-) As my immediate next step, I was hoping to move the GTK client to GtkUIManager (GtkItemFactory has been deprecated since 2.4, which happens to be the base version of GTK required by Freeciv). This wouldn't simply be an exercise in refactoring. There are some very tangible benefits to GtkUIManager: One of these is the ability to merge/unmerge menus, which would permit some interface cleanup that I think everyone would find interesting. Before proceeding, I wanted to test the waters and find out the interest level. Would a move to GtkUIManager have a possibility of being accepted, or are there reasons to keep GtkItemFactory? Hoping you'll find my patches interesting... - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions
Follow-up Comment #4, bug #13867 (project freeciv): Ah, oops - my apologies for the noise. I really should have read the patch before sounding off (since I clearly misunderstood the translation tags as being used for static text rather than calculated text). :-p [Still... it's unfortunate that Gna doesn't attach patches to the mailed copy of the ticket like was the case with bugs filed using RT.] ___ Reply to this item at: http://gna.org/bugs/?13867 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Follow-up Comment #3, bug #13843 (project freeciv): Thanks for taking the time to explain more in-depth, Marko! That really helps me to understand the context. I've make changes to my (upcoming) menu reorg patch. I have some better ideas, but for now I punted too and left the menu as-is. :-) On the other hand, your new code reveals an inconsistency in how the existing Build Fortress and Build Airbase have their sensitivity set. It looks like can_units_do_base() checks to see if units can build a base type *and* can do that activity on the current tile, whereas can_units_do_base_gui() only checks to see if units can build a base type. I've attached a patch that makes can_units_do_base_gui() behave the same as can_units_do_base(). (file #6170) ___ Additional Item Attachment: File name: unitlist.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13867] [patch 01/07] get game settings via wrapper functions
Follow-up Comment #2, bug #13867 (project freeciv): Using '_()' within the setting_*() functions is not done because the some callers need the untranslated string (see stdinhand.c:send_server_setting()). Wouldn't it be better, then, to use N_() instead of simply dropping _() ? This change would still pull the string out for translation (ensuring that these uses are included in the list of references), but wouldn't translate the string itself. Look around the code for other uses to see examples, that'll explain better than I could. Maybe I'm wrong, or this is just a style choice, but thought I'd point that possibility out anyway... ___ Reply to this item at: http://gna.org/bugs/?13867 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Patch tracker
Daniel Markstedt wrote: I've noticed numerous bugs with the [patch] tags in the gna bug tracker. Just though it'd mention, if you haven't noticed already, that there's a separate patch tracker available at https://gna.org/patch/?group=freeciv Do you think we'd use it, or shall I just close it? As hopeful patch contributor, and external rather than part of the maintainers group, I personally think that a single source would be more discoverable. Despite the administrative hassle this might create, it's more than likely that only people in the know will check the two separate sources (and even then, unlikely to actually use the right one - witness the bug reports that come straight to this mailing list). Patch-for-bug vs. patch-for-new feature might seem clear to those involved for a time, so it'd probably would give similar results to simply set up tags/keywords that can be assigned by the maintainers to sort the two types for later searches. (Assuming that, like on bugzilla, it's possible to create/assign arbitrary tags.) Also, a related question: does the patch tracker work with the same Gna account as the bug tracker? And send emails to this list? Wondering for my own reference if the patch tracker does end up being the preferred way. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13843] [Patch] Build base menu
Follow-up Comment #1, bug #13843 (project freeciv): I'm sorry I'm posting after this bug is closed, but it's of interest to me. I'm in the middle of redoing a menu layout change that I originally submitted about a year ago. Would you be able to go into a bit more depth about why this path moves items into a submenu? I don't quite understand the context (I'm way behind on list reading, so please point me to the appropriate thread if there was a discussion). Also, these seem to make the two old entries redundant, but they remain in the orders menu (Build Airbase and Fortify/Build Fortress). ___ Reply to this item at: http://gna.org/bugs/?13843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40228) Lone And, became more experienced! -message
Marko Lindqvist wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40228 S2_2 After successful attack, Messages tab shows: Start of turn 2 And, became more experienced! And, became more experienced has event type separate from the 'parent' message. So it's possible that this message is displayed when parent is not. Note that there is two parent event types; defending and attacking units. I can confirm seeing this regularly in games played in 2.2 and trunk. I almost never see any information about my units when I attack (either in same turn, or when attack is delayed until start of next turn). I usually do see information about enemy units as well as mine when being attacked. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40216) Re: [patch] proposed menu restructuring
Hi, Ulrik. Sorry about replying on-list, you'll see why below. Ulrik Sverdrup wrote: Forwarding the patches too, as they seemed to be missing. John, this is a very good proposition. I'll try to look at it. Cool, thanks! I'm hoping to make it a first of many... And -- you can create tickes. In fact you just created http://bugs.freeciv.org/Ticket/Display.html?id=40217 with some misdirected message. Yeah, I realized that just after I used reply-all. I'd meant to replace the [EMAIL PROTECTED] address with the list address, as I did for this email. The important thing to reply to a ticket is the subject line. check this subject line. It has to contain a reference to the ticket (PR#40216). I understand, and I've tried that before. This is something that goes back some time (early 2006, at least). My account's permissions got messed up at some point, and no one has been able to fix it since then. When I try to reply via email, I get a message back from RT with the subject line Message not recorded and Permission Denied in the body. In fact, I tried replying to that spurious ticket I created yesterday, and got this very reply. The Web interface is no different, in that I can't add comments. I apparently don't have the right permissions - the Update Type pulldown only lists Comments (Not sent to requestors). That allows me to comment, but the list never gets notified - which makes it almost impossible to interact with anyone. It's frustrating since all this means that I can open tickets, but I can't reply to them - or to other people's tickets. Here's a link to a thread from February from my last time asking about this: https://mail.gna.org/public/freeciv-dev/2008-02/msg00122.html Hopefully, the kinks in my RT account can be fixed by someone. I've got a bunch of other ideas that I'm hoping to work on. :-) Cheers, - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40217) Re: [patch] proposed menu restructuring
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40217 Marko Lindqvist wrote: Forwading to request tracker (and thus creating new ticket) for storing the patches. We don't want them to get lost and forgotten. John: If you have something to add, please try to reply to the copy RT sends to the list. Hi, Marko. That's actually the reason I wrote to the list, and why I pointed to a prior email thread in my first email: [1] https://mail.gna.org/public/freeciv-dev/2008-02/msg00122.html (Though the issue dates back to at least February 2006.) I can't reply to any tickets - I've tried, many times - either via the Web interface or by email. There's something wrong with my RT account, and so far no one has been able to fix it. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch] proposed menu restructuring
Marko Lindqvist wrote: Forwading to request tracker (and thus creating new ticket) for storing the patches. We don't want them to get lost and forgotten. John: If you have something to add, please try to reply to the copy RT sends to the list. Gah, my previous reply-to opened a ticket. Bringing it back on-list, so that I have a thread I can still reply to: Hi, Marko. That's actually the reason I wrote to the list, and why I pointed to a prior email thread in my first email: [1] https://mail.gna.org/public/freeciv-dev/2008-02/msg00122.html (Though the issue dates back to at least February 2006.) I can't reply to any tickets - I've tried, many times - either via the Web interface or by email. There's something wrong with my RT account, and so far no one has been able to fix it. - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] can't add comments to any tickets in RT
Sorry for an email to the whole list. It's been a while, so I wasn't sure who was best to write. And I can't use the RT ticket system for this bug since the problem is in the system itself... :-p I have my own account on RT. I can submit a new ticket via email (and maybe via the web interface, but I didn't want to pollute things too much). But I can't update tickets (my own or other people's) using either interface. I get Message not recorded and Permission Denied using both methods. Maybe this is a permissions problem of some sort? If so, would someone be able to fix them for me? It's an annoying hindrance because I'd really like to try my hand at contributing. For info, my account name is jkeller and my email address is this one ([EMAIL PROTECTED]). Thanks in advance! - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40102) testing
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40102 Please ignore this ticket. I'm trying to see if I'm able to open new tickets by email again (was broken for me last I tried)... ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] tileset (esp. Amplio) problems in trunk?
I've checked the list and tickets, and couldn't find anything that seemed to fit. Apologies if this was already covered under some other subject. I haven't been able to select any but the basic tilesets (isotrident, trident, isophex, and hex2t) in trunk for some time. I usually do a make clean + svn up before rebuilding, but today I did a full, clean svn co and I have the same result. The Amplio tileset and the .tilespec file are built there, but it doesn't show up in the pull-down list at all. Besides my svn updates and rebuilds, I've also tried deleting my .civclientrc. No luck... I reported this as bug #39593, but I'm not sure if it's a bug with the tileset, something else, or my own error. Does anyone have any ideas? Thanks in advance, - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] RT problems?
Marko Lindqvist wrote: On 04/09/07, Per I. Mathisen wrote: On Mon, 3 Sep 2007, Marko Lindqvist wrote: It seems to me that we have problems with this list. Could RT be the reason of delaying messages? Can anyone look? My experience is that mails about new tickets are not coming through, but comments to old ones do. Tickets are created (I get confirmation email, and web interface shows them) As far as I understand, the RT installation is living on borrowed time. We really need to start looking for other options with third-party hosting. I am taking backups of the database occasionally in case it goes down permanently. True. But I suspect that problems were related to mailing list (gna). Had it been RT problem, it would have been exactly same for all the people in this list. However, it seems that people have been replying to mails I got only hours later. The weird thing is that I added a comment yesterday to PR#39662 (Build cost always shown as '1' for current production). It still hasn't shown up on the list, but I've been seeing other people's comments just fine... Or is this some RT behavior? - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] RT problems?
Christian Prochaska wrote: On 9/4/07, John Keller [EMAIL PROTECTED] wrote: The weird thing is that I added a comment yesterday to PR#39662 (Build cost always shown as '1' for current production). It still hasn't shown up on the list, but I've been seeing other people's comments just fine... Or is this some RT behavior? - John Comments in RT generally don't show up at the list. You need to select Response to requestors for Update type. Thanks for the explanation. Hmm, I only have Comments (Not sent to requestors) in the update type pulldown (my account email address is the same as the one I'm sending this email from). Maybe I have limited access? That would explain why I couldn't add a refers to entry... - John ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39592) trunk: can't buy item being produced
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39592 I play svn trunk, and am at revision 13359. I always upgrade by doing make clean, svn up and then ./autogen.sh --prefix=[path to dir in my home]. Production always shows xxx/1 in the city report page or popup dialog, though the number of turns remaining is correct. Choosing buy from the city popup or the city report page deducts the amount of gold from my treasury, but the item isn't purchased. In fact, it's possible to repeatedly press buy (as long as enough gold is in treasury), and have the cost repeatedly deducted. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39593) trunk: can't select Amplio or most other tilesets
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39593 I play svn trunk, and am at revision 13359. I always upgrade by doing make clean, svn up, ./autogen.sh --prefix=[path to dir in my home] before make and make install. I'm not sure if this is the result of ongoing work for terrain, but I can't use the Amplio tileset or many others. The local options configuration only lists these tilesets: isotrident, trident, isophex, and hex2t. Not a biggie, but I was just getting used to the ginormous Amplio tiles... :-) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
