[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

[Matthias Pfafferodt]

Follow-up Comment #13, bug #21897 (project freeciv):

all builds (S2_4, S2_5 and S2_6) are fine - I did not test the functionality

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

[Matthias Pfafferodt]

Follow-up Comment #12, bug #21897 (project freeciv):

patch added to the opensuse builds but it will need some time till results
will be available; the build service is stopped at the moment

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

[Matthias Pfafferodt]

Follow-up Comment #9, bug #21897 (project freeciv):

I did test both patches. It does not work - have a look at
https://build.opensuse.org/project/monitor/home:syntron:freeciv (only 64bit;
32bit did not rebuild due to an error on the SAN server of the build system)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

[Matthias Pfafferodt]

Follow-up Comment #4, bug #21897 (project freeciv):

At the moment I only trigger rebuilds of the RPMs for the svn versions from
time to time. There are no test games etc.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21897] Enabling multiple fcdb backends cause same object files to be linked from multiple libraries

[Matthias Pfafferodt]

Follow-up Comment #2, bug #21897 (project freeciv):

Now there is another linking error (see
https://build.opensuse.org/project/monitor/home:syntron:freeciv)


[  903s]   CC   dummy.o
[  904s]   CCLD freeciv-gtk2
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_fetch_lengths'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_double'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_int64'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `sqlite3_exec'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_changes'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_text'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_autocommit'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_num_rows'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `mysql_init'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQstatus'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`PQsetNoticeProcessor'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_busy_timeout'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_fetch_fields'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `sqlite3_step'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `mysql_close'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQnfields'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQsetdbLogin'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQgetvalue'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `sqlite3_open'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_reset'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_bytes'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQcmdTuples'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_insert_id'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQclear'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQfmod'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQconnectdb'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_blob'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_last_insert_rowid'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `mysql_error'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_name'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQntuples'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_prepare'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQfname'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_free_result'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_affected_rows'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_real_escape_string'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_field_count'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_real_query'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQfinish'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_fetch_row'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_finalize'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_real_connect'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`PQerrorMessage'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `mysql_commit'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_store_result'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_count'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_close'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_mprintf'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_decltype'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQgetisnull'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_column_type'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`PQescapeStringConn'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQexec'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`sqlite3_errmsg'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `sqlite3_free'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to `PQftype'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`mysql_rollback'
[  904s] ../common/.libs/libfreeciv.so: undefined reference to
`PQresultStatus'
[  904s] collect2: error: ld returned 1 exit status
[  904s] make[3]: *** [freeciv-gtk2] Error 1
[  904s

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

[Matthias Pfafferodt]

Update of bug #21696 (project freeciv):

 Open/Closed:Open => Closed 

___

Follow-up Comment #12:

I check the changes between the last working version and the build with th
error. Only this change was a possible source. Using the new ticket is OK. I
will close this one (again).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

[Matthias Pfafferodt]

Update of bug #21696 (project freeciv):

 Open/Closed:  Closed => Open   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21696] [patch] build fix: libfreeciv-srv.la depends on lua libraries

[Matthias Pfafferodt]

Follow-up Comment #8, bug #21696 (project freeciv):

this patch breaks all builds using system lua libraries (--enable-sys-lua);
see the rpm builds at
https://build.opensuse.org/project/monitor/home:syntron:freeciv

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20632] lua-5.2 compiler warnings (ignoring return value of 'fwrite')

[Matthias Pfafferodt]

Follow-up Comment #4, bug #20632 (project freeciv):

you can ignore comment #2 and comment #3. I had an error in my script to
create the tarball for 2.4.0-beta. It contained the trunk version of freeciv.
Thus, this bug report is still only for trunk.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20632] lua-5.2 compiler warnings (ignoring return value of 'fwrite')

[Matthias Pfafferodt]

Follow-up Comment #3, bug #20632 (project freeciv):

> What gcc version is that? Have you explicitly set some CFLAGS or CPPFLAGS? 

The spec file did not change between S2_4 and 2.4.0-beta1. S2_4 can be build
as is but 2.4.0-beta1 shows the error. No special settings are used. The spec
files are visible in the opensuse build service.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20632] lua-5.2 compiler warnings (ignoring return value of 'fwrite')

[Matthias Pfafferodt]

Follow-up Comment #2, bug #20632 (project freeciv):

This bug is also valid for 2.4.0-beta1; I have activated system lua for
opensuse >= 12.2 and disable building of 2.4.0-beta1 for opensuse 12.1 there
it lua 5.2 is not available.

see:
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c

[Matthias Pfafferodt]

Update of bug #20585 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c

[Matthias Pfafferodt]

Update of bug #20585 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

the attached patch removes the compiler option NDEBUG from the mysql CFLAGS -
building finishes now without problems. Can it be applied?

(file #17687)
___

Additional Item Attachment:

File name: 0001-remove-NDEBUG-from-mysql-cflags.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20717] lbaselib.c:37:14: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result

[Matthias Pfafferodt]

Follow-up Comment #2, bug #20717 (project freeciv):

I can use system lua for opensuse >= 12.2. On this distributions lua 5.2 is
available. Thus svn2_5 is not build for opensuse 12.1 anymore.

see:
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20717] lbaselib.c:37:14: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result

[Matthias Pfafferodt]

URL:
  

 Summary: lbaselib.c:37:14: error: ignoring return value of
'fwrite', declared with attribute warn_unused_result
 Project: Freeciv
Submitted by: syntron
Submitted on: Sat 06 Apr 2013 12:25:15 AM CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.svn.22676
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:


[  209s] make[4]: Entering directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.5.svn.22676/dependencies/lua-5.2/src'
[  209s]   CC lapi.lo
[  211s]   CC lauxlib.lo
[  215s]   CC lbaselib.lo
[  215s] lbaselib.c: In function 'luaB_print':
[  215s] lbaselib.c:37:14: error: ignoring return value of 'fwrite', declared
with attribute warn_unused_result [-Werror=unused-result]
[  215s] lbaselib.c:38:5: error: ignoring return value of 'fwrite', declared
with attribute warn_unused_result [-Werror=unused-result]
[  215s] lbaselib.c:41:3: error: ignoring return value of 'fwrite', declared
with attribute warn_unused_result [-Werror=unused-result]
[  215s] cc1: all warnings being treated as errors


see
https://build.opensuse.org/package/live_build_log?arch=i586&package=freeciv-2.5svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_12.1




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c

[Matthias Pfafferodt]

Follow-up Comment #2, bug #20585 (project freeciv):

I found the reason for the error in the mysql (mariadb) CFLAGS - they contain
a definition of NDEBUG. How to process here?


#> mysql_config -cflags
Usage: /usr/bin/mysql_config [OPTIONS]
Options:
--cflags [-I/usr/include/mysql -fmessage-length=0
-D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -g -DPIC -fPIC -fno-strict-aliasing -g -DNDEBUG]
--include[-I/usr/include/mysql]
--libs   [-L/usr/lib64 -lmysqlclient -lpthread -lz -lm -lssl
-lcrypto -ldl]
--libs_r [-L/usr/lib64 -lmysqlclient_r -lpthread -lz -lm -lssl
-lcrypto -ldl]
--plugindir  [/usr/lib64/mysql/plugin]
--socket [/var/run/mysql/mysql.sock]
--port   [0]
--version[5.5.29]
--libmysqld-libs [-L/usr/lib64 -lmysqld]
--variable=VAR   VAR is one of:
pkgincludedir [/usr/include/mysql]
pkglibdir [/usr/lib64]
plugindir [/usr/lib64/mysql/plugin]


(file #17669)
___

Additional Item Attachment:

File name: config.log Size:205 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2969] aicmd command

[Matthias Pfafferodt]

Follow-up Comment #2, patch #2969 (project freeciv):

sorry, I did forget to update the patch file - it is the old one from 2011 ...

(file #17428)
___

Additional Item Attachment:

File name: 0001-aicmd-command.patch   Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2554] lua AI module

[Matthias Pfafferodt]

Follow-up Comment #11, patch #2554 (project freeciv):

Thanks for the comments! I will change the patch accordingly.

Could you help me to find the place there default ai player_alloc is called?

The calling structure is:
ai->funcs.player_alloc
. => lai_player_alloc (lai_func.c)
.. => player_set_ai_data (using struct lai_plr *luaplr as ai data)
.. => lai_api_player_alloc (api_lai_base.c)
... => dai_data_init


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2554] lua AI module

[Matthias Pfafferodt]

Follow-up Comment #8, patch #2554 (project freeciv):

please remember to apply the dependencies patch #2969 and bug #20600 before
this one

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2554] lua AI module

[Matthias Pfafferodt]

Update of patch #2554 (project freeciv):

  Status:  Ready For Test => In Progress
 Summary:  stub lua AI module => lua AI module  

___

Follow-up Comment #7:

I reworked the lua ai patch. At the moment it can be activated (use ./fcser -L
lua) and runs without crash or errors. But, the lua AI does not really moves
its units etc. Thus, help is needed!

I suspect the error in the area of data handling. The AI functions use
arguments which are not handled in the default lua name space. Remembering the
calling flow:

 => LuaAI function => call to lua => callback to C => default AI

the arguments (pointers) have to be 'tunneled' throw lua. I use a 'dummy' data
type lai_data for this. It 'transports' the pointer via the lua environment.
I'm not sure if this is the corret way to go ...



(file #17404)
___

Additional Item Attachment:

File name: 0006-basic-commit-for-a-lua-ai.patch Size:108 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20600] dai_player_load: add 'const' to struct section_file

[Matthias Pfafferodt]

URL:
  

 Summary: dai_player_load: add 'const' to struct section_file
 Project: Freeciv
Submitted by: syntron
Submitted on: Thu 07 Mar 2013 04:00:19 PM CET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

dai_city_load() and dai_unit_load() use const for struct section_file - add it
also for dai_player_load()



___

File Attachments:


---
Date: Thu 07 Mar 2013 04:00:19 PM CET  Name:
0004-dai_player_load-add-const-to-struct-section_file.patch  Size: 4kB   By:
syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20586] fix tolua_client.pkg and tolua_common_a.pkg

[Matthias Pfafferodt]

Update of bug #20586 (project freeciv):

 Summary: fix tolua_clinet.pkg and tolua_common_a.pkg => fix
tolua_client.pkg and tolua_common_a.pkg


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20586] fix tolua_clinet.pkg and tolua_common_a.pkg

[Matthias Pfafferodt]

URL:
  

 Summary: fix tolua_clinet.pkg and tolua_common_a.pkg
 Project: Freeciv
Submitted by: syntron
Submitted on: Mon 04 Mar 2013 10:54:10 PM CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: svn22472
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

switching from lua 5.1 to 5.2 needs changes to unpack()

see also patch #3230



___

File Attachments:


---
Date: Mon 04 Mar 2013 10:54:10 PM CET  Name:
0002-fix-tolua_clinet.pkg-and-tolua_common_a.pkg.patch  Size: 2kB   By:
syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c

[Matthias Pfafferodt]

URL:
  

 Summary: variable 'punit' set but not used in citytools.c
 Project: Freeciv
Submitted by: syntron
Submitted on: Mon 04 Mar 2013 10:35:16 PM CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: svn22473
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

I get the following error on opensuse 12.3 (see
https://build.opensuse.org/package/live_build_log?arch=x86_64&package=freeciv-2.4svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_12.3_Update_standard).
The build uses '--enable-debug=yes'.


[  608s] citytools.c: In function 'transfer_city_units':
[  608s] citytools.c:724:3: error: variable 'punit' set but not used
[-Werror=unused-but-set-variable]
[  608s] cc1: all warnings being treated as errors
[  608s] make[3]: *** [citytools.lo] Error 1
[  608s] make[3]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473/server'
[  608s] make[2]: *** [all-recursive] Error 1
[  608s] make[2]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473/server'
[  608s] make[1]: *** [all-recursive] Error 1
[  608s] make[1]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473'
[  608s] make: *** [all] Error 2
[  608s] error: Bad exit status from /var/tmp/rpm-tmp.4s0bpV (%build)


It's the following code:

#ifdef DEBUG
  unit_list_iterate(pcity->units_supported, punit) {
fc_assert(punit->homecity == pcity->id);
fc_assert(unit_owner(punit) == pplayer);
  } unit_list_iterate_end;
#endif /* DEBUG */


opensuse 12.3 will be released on 13.03. I do not know which additional test
is activated there ...




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2

[Matthias Pfafferodt]

Follow-up Comment #11, bug #20551 (project freeciv):

file #17357 fixes the bug for me; see also svn 2.5 at
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20489] Explorers shouldn't stop exploring

[Matthias Pfafferodt]

Follow-up Comment #7, bug #20489 (project freeciv):

Yes, client side lua script is limit. There are no callbacks into the lua
environment. I did a prove of concept (see patch #2519). Thinking about this
discussion I wrote a possible algorithm for the unit handling by the client as
RFC in patch #3768

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3768] [RFC] client side lua script for unit actions

[Matthias Pfafferodt]

Update of patch #3768 (project freeciv):

 Summary:   [RFC] => [RFC] client side lua
script for unit actions


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3768] [RFC]

[Matthias Pfafferodt]

URL:
  

 Summary: [RFC]
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 01 Mar 2013 09:58:04 PM CET
Category: client
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

In bug #20489 the possibilities of client side lua script is discussed (auto
exploring). I through about this. Given the current state I could image the
following algorithm:

- for each unit there is the possibility to assign a lua script controlling
the unit. It could be accessed / changed via a keyboard shortcut which in turn
proposes possible lua functions in the client lua script. The script name is
saved in the unit structure (first only in the client)

- after turn change the client iterates over all units and, if a lua script is
set, executes it with option 'turn change'. This would execute _one_ command
for the unit (i.e. go left)

- if the unit data changes due to a server response, the client calls the lua
script again at the end of the handling of the server data (in the example
with option 'moved'). If move points are left, the next command can be
requested by the lua script.

- on a later step, the lua function could be send to the server at the time it
is set. Thus, it could be saved if the game is saved and restored on game load
(if the lua function is still available; else there should be an error
message).

- within the client lua environment, the function could save data about the
job for the unit. But this information would be lost if the client is closed.
Thus, a small data packet (32 byte?) could be allowed to be transferred to the
server to save some data in the savegame (i.e the current job of the unit or
the goto tile)

- using this things like exploring or connect by road could be done on client
side

For this to work, several things are to be done:

- lua functions to request all possible (simple) (player) commands for a unit
(move, settler actions, ...)

- hocks back to the lua code at the end of all possible unit action send by
the server (wakeup, moved, successful attack, ...)






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2143] [RFC] AI interface using lua

[Matthias Pfafferodt]

Follow-up Comment #8, patch #2143 (project freeciv):

I will have to see if the old patches are still useable ...

> This cannot work correctly. (Well, it does as long as you use 
> all parts of default ai, and don't reimplement any part 
> yourself). 

Therefore my old patches for the lua ai included a complete copy of the
default ai ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20428] 'g_thread_init' is deprecated

[Matthias Pfafferodt]

Follow-up Comment #5, bug #20428 (project freeciv):

sorry for the delay - yes it is fixed; see
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv

now only bug #19975 remains

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20428] 'g_thread_init' is deprecated

[Matthias Pfafferodt]

URL:
  

 Summary: 'g_thread_init' is deprecated
 Project: Freeciv
Submitted by: syntron
Submitted on: Sun 13 Jan 2013 04:30:49 PM CET
Category: module installer
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_3 (svn 22114)
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

S2_3 can not compiled on newest opensuse (Tumbleweed) due to the following
deprecated function used in modinst:


[  399s] modinst.c: In function 'gui_download_modpack':
[  399s] modinst.c:161:3: error: 'g_thread_create' is deprecated (declared at
/usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new'
instead [-Werror=deprecated-declarations]
[  399s] modinst.c: In function 'main':
[  399s] modinst.c:333:3: error: 'g_thread_init' is deprecated (declared at
/usr/include/glib-2.0/glib/deprecated/gthread.h:259)
[-Werror=deprecated-declarations]
[  399s] cc1: all warnings being treated as errors
[  399s] make[2]: *** [modinst.o] Error 1
[  399s] make[2]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.3.svn.22114/modinst'
[  399s] make[1]: *** [all-recursive] Error 1
[  399s] make[1]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.3.svn.22114'
[  399s] make: *** [all] Error 2
[  399s] error: Bad exit status from /var/tmp/rpm-tmp.fbYloy (%build)


see complete log at
https://build.opensuse.org/package/live_build_log?arch=x86_64&package=freeciv-2.3svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_Tumbleweed

(matrix with all build tests at
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19975] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

[Matthias Pfafferodt]

Follow-up Comment #3, bug #19975 (project freeciv):

still valid for all S2_4 i586 builds (svn 22113) ...

(matrix with all build tests at
https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19975] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

[Matthias Pfafferodt]

Follow-up Comment #2, bug #19975 (project freeciv):

Is this to be solved for 2.4.x? Or can this version only be compiled without
extra checks?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Update of patch #3495 (project freeciv):

Category:None => general
  Status:None => In Progress

___

Follow-up Comment #12:

No Problem - thanks for testing the code!

In comment #6 two missing lua functions were mentioned. One is implemented in
comment #5 (Player find.leader (nation_name)). Should it be inserted into
tolua_game.pkg?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Follow-up Comment #10, patch #3495 (project freeciv):

> Now I test the (untested) function, but... Where should I insert? Function
turn_cb(turn, year) or function city_nation_swedish()? 

The function should be inserted on its own (separate function). After that you
could change your function as follows:

function  city_nation_swedish()
  local owner = search_player_with_nation("Swedish") 
  if owner then
local Stockholm = find.tile(208,93)
create_city(owner,  Stockholm, 'Stockholm')
  else
log.error("No player with nation 'Swedish'")
  end
end

(all untested)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Follow-up Comment #8, patch #3495 (project freeciv):

Sorry about the confusion; I mean the function in comment #5 would be the
currently missing function find.leader(nation_name) implemented in lua. The
function find.player(player_name) could be implemented similar. I can't test
it at the moment ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Follow-up Comment #6, patch #3495 (project freeciv):

According to http://freeciv.wikia.com/wiki/Lua_reference_manual#find this
would be (if it is working) the missing function:

Player   find.leader (nation_name)

Similar the function:

Player   find.player (player_name)

Could be implemented using only lua.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Follow-up Comment #5, patch #3495 (project freeciv):

It should even work using lua. Below an (untested) function:

[code]
function search_player_with_nation(nation_str)
  for player in players_iterate() do
local plr_nation_str = player.nation:rule_name()
if (nation_str == plr_nation_str)
  return player
end
  end
  
  return NIL
end
[/code]

It returns with player with nation 'nation_str' if it exists, else NIL. The
player can then be used in the functions to create the city, etc.

Question: should such functions be collected in something like a lua (example)
library? I think such functions helps to learn lua and are perhaps rewritten
as their existence is not known. It could be default.lua in the ruleset
directories or functions.lua in ./data. I know about function usefull for
longturn to create new players which were posted here long ago

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3495] Starting with first city placed

[Matthias Pfafferodt]

Follow-up Comment #4, patch #3495 (project freeciv):

I think the player attribute should not be changed at this point as player is
the information that is needed to create a city. A nation must not exist on
the map. What about a new lua function

player get_player(Nation_Type pnation) which returns the player of that nation
if it exists. If not it would return NULL and you would know that first a
player with the required nation has to be created. Such a function would not
require much work ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3506] Default AI using ai type it got as parameter

[Matthias Pfafferodt]

Follow-up Comment #1, patch #3506 (project freeciv):

I think this idea is a good one. The current (old) version of the lua AI did
use an copy of the default/classic AI for most functions. A lua interface is
wrapped around each such that the function could step by step changed to be
written in lua code.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17843] City radius effects work only with city size requirements

[Matthias Pfafferodt]

Follow-up Comment #9, bug #17843 (project freeciv):

In an ideal world there would be no change. Did you test if the savegame still
varies if you do a second load/save cycle? At this point all city should be
up-to-date so there are no further changes ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19976] modpack needs libm

[Matthias Pfafferodt]

URL:
  

 Summary: modpack needs libm
 Project: Freeciv
Submitted by: syntron
Submitted on: Tue 24 Jul 2012 08:30:03 PM CEST
Category: module installer
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 (svn21612), trunk (svn21614)
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I did try to get the up-to-date freeciv packages at
https://build.opensuse.org/project/show?project=home%3Asyntron%3Afreeciv to
compile again (S2_3, S2_4, trunk). Besides a strange compile error only for
i586 (bug #19975) I did found that I had to add -lm as hard dependency for
linking the included lua libraries (needed for the modpack tool as there is no
other dependency including it). Lua provides mathematic functions (at least
tan()) and thus requires to be linked with this lib. A quick and dirty hack is
attached. It is needed for S2_4 and trunk in combination with opensuse 12.1 or
tumbleweed.



___

File Attachments:


---
Date: Tue 24 Jul 2012 08:30:03 PM CEST  Name: freeciv-lua_libm.diff  Size:
333B   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19975] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

[Matthias Pfafferodt]

URL:
  

 Summary: dialogs.c:597:7: error: array subscript is above
array bounds [-Werror=array-bounds]
 Project: Freeciv
Submitted by: syntron
Submitted on: Tue 24 Jul 2012 08:26:34 PM CEST
Category: client-xaw
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 (svn21612)
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

I get the following compiling error for S2_4 on i586. It seems to be something
arch specific as x86 finishes its build process:

[  861s] dialogs.c: In function 'popup_pillage_dialog':
[  861s] dialogs.c:597:7: error: array subscript is above array bounds
[-Werror=array-bounds]
[  861s] cc1: all warnings being treated as errors

The build has '--enable-debug=yes'. The complete log can be found at:

https://build.opensuse.org/package/live_build_log?arch=i586&package=freeciv-2.4svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_Tumbleweed

This error does _not_ happens for trunk - was there a change with regard to
this code? Or is this all a red herring?




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Matthias Pfafferodt]

Follow-up Comment #3, bug #19971 (project freeciv):

> Is the patch OK?
I looks fine as far as I can see without compiling it. I gives a defined state
for such (unknown) tiles.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19971] mapimg: Spurious border lines around unknown tiles

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19971 (project freeciv):

This should be similar to the borders plotted on the main map (as far as I
remember this terrain is unknown and there could be a city of another player?!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2514] [lua102] common lua functions

[Matthias Pfafferodt]

Follow-up Comment #9, patch #2514 (project freeciv):

'respawn' is / was(?) a feature requested by longturn. At the moment it is /
was done via C-code but lua would be better as it is not hardcoded, i.e. no
need to recompile freeciv to change parts of this code. I did create an
additional patch to use this function but it was never finished. Attached is
the old (not rebased to trunk) state of the patch.

If there are more questions to patches by me please ask; I will try to answer
and also rebase the my old work. But it will be slowly!

(file #16167)
___

Additional Item Attachment:

File name: 0009-respawn-command-as-lua-callback.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

[Matthias Pfafferodt]

Follow-up Comment #5, bug #19296 (project freeciv):

> pkg-config --libs MagickWand
> -lMagickWand -lMagickCore
> and at least as of ImageMagick 6.7.4.0
> MagickWand-config --libs 
> MagickWand-config --libs
> the output is the same. 
Correct - but it wasn't on opensuse. If you got to the bug I opened you will
find that it will be fixed in the next version. I think, doing the compiling
check is a save way to go.

> On the other hand, it might just be another (odd) freciv policy 
> - you still use the whole AM_PATH_GTK_2_0 macro; most packages 
> simply rely on pkg-config here, instead of that compile check. 
No, I do not think is is a policy to use use old macros. But often the old
ones are not changed till they do not work anymore. In the case you mentioned,
the information of the macro is also available via a pkg-config call? Do you
know other things which should be checked?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19228] bug in freeciv-stub s --help

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19228 (project freeciv):

This is due to patch #2977 - a simplification of the command line options. As
the stub client does not has any framework there is nothing to report ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19149] [unused var fix] SDL client

[Matthias Pfafferodt]

Update of bug #19149 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #7:

updated patch; it uses the solution proposed by Jason Dorje Short  in
bug #18217:

- use a macro UNUSED_VAR(x) to define a variable as 'unused'


(file #14817)
___

Additional Item Attachment:

File name: 0014-unused-var-fix-SDL-client-2.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19297] fix mnemonic diplodlg [gtk2 version]

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19297 (project freeciv):

updated version of the patch; use the correct gtk function ...

(file #14816)
___

Additional Item Attachment:

File name: 0017-fix-mnemonic-diplodlg-gtk2-version.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18217] GCC 4.6: variable 'xxx' set but not used

[Matthias Pfafferodt]

Follow-up Comment #13, bug #18217 (project freeciv):

see also bug #19153

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

[Matthias Pfafferodt]

Update of bug #19296 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #3:

> Test linkage for whole WAND_LIBS would be cleaner and would also 
> catch other problematic libraries, not just libbz2. 
Done by the patch; Thanks for the hint - more learned about the internals of
the tools I use ;-)

> why isn't freeciv simply using pkg-config for this and serveral
> other checks ? If that's broken, most of your build system like
> is.
MagickWand has its own tools (MagickWand-config) which are used. They report
-lbz2 as a dependency but the corresponding development packages are not
automatically installed. I have reported it at the opensuse bug tracker at
https://bugzilla.novell.com/show_bug.cgi?id=741947


(file #14811)
___

Additional Item Attachment:

File name: 0016-fix-check-for-MagickWand-libbzip2.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19149] [unused var fix] SDL client

[Matthias Pfafferodt]

Follow-up Comment #5, bug #19149 (project freeciv):

> Would it be possible to solve this by using macro from jdorje's 
> patch in bug #18217?
I did remember that something about the warning was on the list but I did not
remembered there I did read it. Now I have done all the work jdorje did again
in a different way. I will check this tomorrow.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19297] fix mnemonic diplodlg [gtk2 version]

[Matthias Pfafferodt]

URL:
  

 Summary: fix mnemonic diplodlg [gtk2 version]
 Project: Freeciv
Submitted by: syntron
Submitted on: Mon 16 Jan 2012 08:08:36 PM CET
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:





___

File Attachments:


---
Date: Mon 16 Jan 2012 08:08:36 PM CET  Name:
0018-fix-mnemonic-diplodlg-gtk2-version.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

[Matthias Pfafferodt]

URL:
  

 Summary: fix check for MagickWand (libbzip2)
 Project: Freeciv
Submitted by: syntron
Submitted on: Mon 16 Jan 2012 08:07:53 PM CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.2, 2.4.0, 2.5.0

___

Details:





___

File Attachments:


---
Date: Mon 16 Jan 2012 08:07:53 PM CET  Name:
0017-fix-check-for-MagickWand-libbzip2.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2994] readd lua properties for City and Unit

[Matthias Pfafferodt]

Update of patch #2994 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => syntron
 Open/Closed:Open => Closed 
 Planned Release:   2.4.0 => 2.4.0, 2.5.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #63:

after the gtk3 version is applied this ticket will now be closed

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3086] Remove --disable-acceptable-warns

[Matthias Pfafferodt]

Follow-up Comment #1, patch #3086 (project freeciv):

There is still one entry of bug #19153 missing (bug #19149). A patch exists
but it is more a hack than a patch ...

These patches there needed to compile freeciv on opensuse 12.1


#> gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib64/gcc/x86_64-suse-linux/4.6/lto-wrapper
Target: x86_64-suse-linux
Configured with: ../configure --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada
--enable-checking=release --with-gxx-include-dir=/usr/include/c++/4.6
--enable-ssp --disable-libssp --disable-plugin
--with-bugurl=http://bugs.opensuse.org/ --with-pkgversion='SUSE Linux'
--disable-libgcj --disable-libmudflap --with-slibdir=/lib64 --with-system-zlib
--enable-__cxa_atexit --enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --program-suffix=-4.6
--enable-linux-futex --without-system-libunwind --with-arch-32=i586
--with-tune=generic --build=x86_64-suse-linux
Thread model: posix
gcc version 4.6.2 (SUSE Linux) 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19152] [unused var fix] macros in map.h

[Matthias Pfafferodt]

Update of bug #19152 (project freeciv):

Category:None => general
  Status: In Progress => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19154] [unused var fix] gtk3 client

[Matthias Pfafferodt]

Update of bug #19154 (project freeciv):

Category:None => client-gtk-3.0 
  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19151] [unused var fix] gtk2 client

[Matthias Pfafferodt]

Update of bug #19151 (project freeciv):

Category:None => client-gtk-2.0 
  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19150] [unused var fix] xaw client

[Matthias Pfafferodt]

Update of bug #19150 (project freeciv):

Category:None => client-xaw 
  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 
 Planned Release:   2.5.0 => 2.5.0, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19149] [unused var fix] SDL client

[Matthias Pfafferodt]

Follow-up Comment #3, bug #19149 (project freeciv):

part 1 is commited; a solution for part2 is still missing ...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19148] [unused var fix] remove variable 'status' from api_edit_create_player()

[Matthias Pfafferodt]

Update of bug #19148 (project freeciv):

Category:None => general
  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 
 Planned Release:   2.5.0 => 2.5.0, 2.4.0   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19147] [unused var fix] use *_list_size() to get the number of units

[Matthias Pfafferodt]

Update of bug #19147 (project freeciv):

Category:None => general
  Status:  Ready For Test => Fixed  
 Assigned to:None => syntron
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19266] compile error at ko.po

[Matthias Pfafferodt]

URL:
  

 Summary: compile error at ko.po
 Project: Freeciv
Submitted by: syntron
Submitted on: Tue 10 Jan 2012 09:21:19 PM CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

after commit 20677 compiling fails at ko.po:

file=./`echo ko | sed 's,.*/,,'`.gmo \
  && rm -f $file && /usr/bin/msgfmt -c --statistics -o $file ko.po
ko.po:138: format specifications in 'msgid_plural' and 'msgstr[0]' for
argument 2 are not the same
ko.po:217: format specifications in 'msgid_plural' and 'msgstr[0]' for
argument 2 are not the same
ko.po:232: format specifications in 'msgid_plural' and 'msgstr[0]' for
argument 3 are not the same
ko.po:275: number of format specifications in 'msgid' and 'msgstr' does not
match
/usr/bin/msgfmt: found 7 fatal errors
2011 translated messages, 1792 fuzzy translations, 3070 untranslated
messages.
make[2]: *** [ko.gmo] Error 1
make[2]: Leaving directory
`/usr/src/packages/BUILD/freeciv-2.4.svn.rev20677/po'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/usr/src/packages/BUILD/freeciv-2.4.svn.rev20677'
make: *** [all] Error 2





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #56, bug #18835 (project freeciv):

> > Likely unrelated, but as this patch dropped mnemonics in a few places,
why is it 
> > still calling gtk_image_menu_item_new_with_mnemonic or setting 
> > "use-underline" there ? 
>
> I will check this. 

Fixed in the new file (3). I will commit this one shortly; all remaining
issues should get new tickets.

(file #14781)
___

Additional Item Attachment:

File name: 0017-gtk3-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19160] in player_load_units_transporter() [savegame.c::2285]: assertion 'id_trans == -1 || ptrans != ((void *)0)' failed

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19160 (project freeciv):

svn r20638 blongs to bug #18975. I will look into this!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18975] in unit_virtual_destroy() [unit.c::1732]: assertion '!unit_transported(punit)' failed.

[Matthias Pfafferodt]

Update of bug #18975 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19125] [server] mapgen fails to compile

[Matthias Pfafferodt]

Update of bug #19125 (project freeciv):

  Status:None => Confirmed  

___

Follow-up Comment #2:

see bug #19153 for a list of all needed changes; the mapgen bug is fixed in
bug #19152

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19153] [unused var fix] Metapatch

[Matthias Pfafferodt]

Update of bug #19153 (project freeciv):

  Depends on: => bugs #19154


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19154] [unused var fix] gtk3 client

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] gtk3 client
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:50:40 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0,2.4.0

___

Details:





___

File Attachments:


---
Date: Fri 09 Dec 2011 07:50:40 PM CET  Name:
0010-unused-var-fix-gtk3-client.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19153] [unused var fix] Metapatch

[Matthias Pfafferodt]

Update of bug #19153 (project freeciv):

  Depends on: => bugs #18835


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19153] [unused var fix] Metapatch

[Matthias Pfafferodt]

Update of bug #19153 (project freeciv):

  Depends on: => bugs #19147


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19153] [unused var fix] Metapatch

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] Metapatch
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:44:15 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0,2.4.0

___

Details:

opensuse 12.1 did result in new error messages. The checks for set but not
used variables finds more reasons to warn. This metapatch links to all bug
fixes for these.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19152] [unused var fix] macros in map.h

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] macros in map.h
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:42:25 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0,2.4.0

___

Details:

the macros define in map.h iterate also over the tile; thus, this variable is
set but sometimes not used. This patch adds reduced macros for this case.
Perhaps the macro definitions of 'adjc_dirlist_iterate' and
'adjc_dirlist_base_iterate' can be merged? I did not find a solution.




___

File Attachments:


---
Date: Fri 09 Dec 2011 07:42:25 PM CET  Name:
0009-unused-var-fix-macros-in-map.h.patch  Size: 6kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19151] [unused var fix] gtk2 client

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] gtk2 client
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:41:44 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0,2.4.0

___

Details:

remove variables which are set but not used



___

File Attachments:


---
Date: Fri 09 Dec 2011 07:41:44 PM CET  Name:
0008-unused-var-fix-gtk2-client.patch  Size: 2kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19150] [unused var fix] xaw client

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] xaw client
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:41:07 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

remove variables which are set but not used



___

File Attachments:


---
Date: Fri 09 Dec 2011 07:41:07 PM CET  Name:
0007-unused-var-fix-xaw-client.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19149] [unused var fix] SDL client

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] SDL client
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:40:35 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

The first patch removes variables which are set but not used.

The second patch contains a case which I could not fix due to the macros
used. This variable is set in DISEMBLE_RGBA but not used in ALPHA_BLEND; is a
reduced version of DISEMBLE_RGBA really needed?




___

File Attachments:


---
Date: Fri 09 Dec 2011 07:40:35 PM CET  Name:
0005-unused-var-fix-SDL-client.patch  Size: 10kB   By: syntron


---
Date: Fri 09 Dec 2011 07:40:35 PM CET  Name:
0006-unused-var-fix-SDL-client-2.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19148] [unused var fix] remove variable 'status' from api_edit_create_player()

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] remove variable 'status' from
api_edit_create_player() 
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:38:34 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

This was discussed earlier but I did not find the ticket. 'status' is a
relict from my work doing the rewrite of the lua code.



___

File Attachments:


---
Date: Fri 09 Dec 2011 07:38:34 PM CET  Name:
0004-unused-var-fix-remove-variable-status-from-api_edit_.patch  Size: 2kB  
By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19147] [unused var fix] use *_list_size() to get the number of units

[Matthias Pfafferodt]

URL:
  

 Summary: [unused var fix] use *_list_size() to get the
number of units
 Project: Freeciv
Submitted by: syntron
Submitted on: Fri 09 Dec 2011 07:36:53 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

replaces an old iteration over all units to count them



___

File Attachments:


---
Date: Fri 09 Dec 2011 07:36:53 PM CET  Name:
0003-unused-var-fix-use-_list_size-to-get-the-number-of-u.patch  Size: 1010B  
By: syntron



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #55, bug #18835 (project freeciv):

I did found an small bug in the patch - there is an unused variable, which is
fixed in this updated version of the 3rd file.

> Likely unrelated, but as this patch dropped mnemonics in a few places, why
is it
> still calling gtk_image_menu_item_new_with_mnemonic or setting
> "use-underline" there ?

I will check this.

> As for the gtk3 warnings, initially I thought it's something regarding the
length of
> the labels, but now I think it might be related to the size of the flags -
but that's still
> a guess.

OK; but is seems to be nothing dangerous.

> On gtk3 warnings topic: ever since 3.2.2, there's a new compile warning for
the
> dialog  construct freeciv is using - now gtk_dialog_new_with_buttons wishes
for
> at least one button and a proper NULL sentinel.

The gtk version I use is 3.2.1 (opensuse 12.1). I will have to wait till a
rpm package for the next version is ready.

(file #14664)
___

Additional Item Attachment:

File name: 0002-gtk3-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19125] [server] mapgen fails to compile

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19125 (project freeciv):

Yes, I also got this (and more) error messages if trying to copile
freeciv on opensuse 12.1. I have fixed all warnings (= errors on debug mode)
but have to cleanup the changes to create patches. Latest on the weekend you
will find them here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

 Planned Release:2.4.0, 2.3.2 => 2.4.0, 2.3.2, 2.5.0

___

Follow-up Comment #53:

commited to S2_3, S2_4 and trunk; the ticket is not closed as the gtk3
version is missing. It compiles but reportes some errors. I do not know if
they are related to this code as it is the first time I got a relly working
gtk3 client. They seem to be unrelated but please check:


(freeciv-gtk3:10064): Gtk-CRITICAL **:
gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed

(freeciv-gtk3:10064): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to
allocate widget with width 120 and height -1


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] Fullmoon build results

[Matthias Pfafferodt]

Am Sonntag, 4. Dezember 2011, 20:27:30 schrieb Marko Lindqvist:
> On 4 December 2011 07:35,   wrote:
> > This is build report automatically generated by FullMoon Ilmarinen
> > (0.4.50.1)
> > 
> > Fullmoon operated by Marko Lindqvist  This build is
> > from TRUNK.
> > 
> > Component "svn", Host "cazfi.net", Phase "Source update(1)": Succeeded
> > Component "autogen.sh", Host "cazfi.net", Phase "Other command(0)":
> > Succeeded Component "server", Host "cazfi.net", Phase "Build(2)":
> > Succeeded Component "gtk2", Host "cazfi.net", Phase "Build(2)":
> > Succeeded
> > Component "sdl", Host "cazfi.net", Phase "Build(2)": Succeeded
> > Component "xaw", Host "cazfi.net", Phase "Build(2)": Succeeded
> > Component "qt", Host "cazfi.net", Phase "Build(2)": Succeeded
> > Component "stub", Host "cazfi.net", Phase "Build(2)": Succeeded
> > Component "QualityCheck", Host "cazfi.net", Phase "Check(4)": FAILED
> 
> And stderr is available from http://build.cazfi.net/freeciv/nightly/

Thanks for doing nightly builds!  One kindly request: could you change the 
naming schema to use something like .mm.dd? This way it would be clear 
where the last logs are to be found. Furthermore, the last logs (2011/12/01-) 
showed something like 'no space left on device' ...

I will try to submit the meeting dialog patch today (http://gna.org/bugs/?
18835); could you check if it can also be applied to the gtk3 client (no 
dependencies on gtk2?). I did compile test it on opensuse 12.1 (gtk3 version: 
3.2.1) without error. Running it showed the errors listed in the bug report 
which have to be fixed before it can be commit to this client.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19029] Trouble saving/loading players' known territory for player indices >=40

[Matthias Pfafferodt]

Follow-up Comment #6, bug #19029 (project freeciv):

> Meanwhile, a question. In the per-player part of the savefile,
> there's the saved terrain, playerX.map_t (saved in
> sg_save_player_vision()). For each map tile, this saves a single
> character representing what the player believes the terrain to
> be, or 'u' for unknown terrain. 
playerX.map_t is only saved if fow is enabled. If not, all players will
use the main map. In that case the unknown information is important.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #18957] /wall not persistent

[Matthias Pfafferodt]

Short comment:

The discussion was that /wall messages are related to server messages which 
are important _now_ for all connected players but not at a later date. Thus 
they should not be replayed.


Am Sonntag, 20. November 2011, 20:28:46 schrieb Jacob Nevins:
> Follow-up Comment #1, bug #18957 (project freeciv):
> 
> The behaviour was changed in bug #17011. Apparently this came from
> Longturn...
> 
> ___
> 
> Reply to this item at:
> 
>   
> 
> ___
>   Message sent via/by Gna!
>   http://gna.org/
> 
> 
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19007] fix known map in savegame2

[Matthias Pfafferodt]

Update of bug #19007 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #4:

I did not find this ticket yesterday evening. My proposal is to deactivate
the /remove command after a game was started for 2.3.1. Thus, there is time to
do all the checks needed to get the command working. As posted in bug #18776
there are further bugs if a client is connected at the time a player is
removed.

> There's a newer file of the same name attached to bug #18776:
> file #14574. Does that supersede file #14565 attached here? 
Yes.

> From what I understand, if there are a lot of players saving
> their vision is buggy. It seems the /remove problem uncovered a
> number of bugs with saving a game.
See above; the changes due to the removal of a player have to be send to the
connected clients else their state is incorrect.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

[Matthias Pfafferodt]

Update of bug #18776 (project freeciv):

  Status:  Ready For Test => In Progress
 Planned Release: 2.3.1,2.4.0 => 2.3.2,2.4.0


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19007] fix known map in savegame2

[Matthias Pfafferodt]

Update of bug #19007 (project freeciv):

 Planned Release:  2.3.12,2.4.0,2.5.0 => 2.3.2,2.4.0,2.5.0  


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19007] fix known map in savegame2

[Matthias Pfafferodt]

Update of bug #19007 (project freeciv):

 Planned Release:   2.3.1,2.4.0,2.5.0 => 2.3.12,2.4.0,2.5.0 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

[Matthias Pfafferodt]

Follow-up Comment #31, bug #18776 (project freeciv):

The attached two patches should fix the bug, but (see below)

0005-basic-fix-known-map-in-savegame2.patch
- do not use the player_count() but the highest used player slot index
- fast fix to be used in 2.3.1
- it only changes the function used to calculate the number of int values
needed to save the known information to match the highest used player slot
index

0006-fix-bug-in-player_map_free.patch
- fix freeing the player map if a player is removed
- needed to remove the owner information saved in the tile data (used in a
savegame)

the 'but':
- I could not reproduce the bug without the patch, so there is no test if
this is really a fix for it
- removing a player results in strange behaviour of the client (noexistend
units and cities are shown; clicking on a removed city will crash the client)

my proposal:
- deactivate the remove command if the game was started for 2.3.1; this was
changed in bug #18641 for S2_3; it could (will) be checked for 2.3.2 ...

(file #14579, file #14580)
___

Additional Item Attachment:

File name: 0005-basic-fix-known-map-in-savegame2.patch Size:2 KB
File name: 0006-fix-bug-in-player_map_free.patch Size:2 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

[Matthias Pfafferodt]

Follow-up Comment #30, bug #18776 (project freeciv):

> Last call for 2.3.1 -- I will make the release starting tomorrow
> morning. 
I will create a minimal version which does allow the /remove command to work.
A hint is comment #21:
> It does not crash. And i tested it without your previous
> patches, the ones with vision - while they might have fixed
> something they were not the cause of my segfaults. 
Thus, only a basic version of the fix posted at bug #19007 is needed. I will
test this and commit a version with the smallest possible change.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #43, bug #18835 (project freeciv):

version for gtk3 (it does apply; not compile tested)

- only patch 1 had to be changed (gtk2 => gtk3 in strings)

(file #14575, file #14576, file #14577)
___

Additional Item Attachment:

File name: 0001-gtk2-add-option-to-gui_dialog_new-to-skip-check-of-p.patch
Size:9 KB
File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB
File name: 0002-gtk2-diplomacy-in-a-horizontal-notebook.patch Size:10 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

[Matthias Pfafferodt]

Follow-up Comment #26, bug #18776 (project freeciv):

by Marko Lindqvist:
> I think someone has mixed number of bits and hex values at some
> point. While we read 8 hex values to known[], here we handle it
> as bits already, so that "8" should be "32" (p is always 0 to 31
> bigger than l*32)
I think that was me ... updated patch with fixed numbers attached. I do hope
this one fixes all bugs due to removed players and also saves the known
information correctly. It changes the information in a savegame file.

Please test!


(file #14574)
___

Additional Item Attachment:

File name: 0011-fix-known-map-in-savegame2.patch Size:4 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19014] AI diplomats doesn't dodge enemy units

[Matthias Pfafferodt]

Follow-up Comment #1, bug #19014 (project freeciv):

patch by Jordi Negrevernis i Font  (see patch #2978)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2978] AI diplomats stack next to an enemy city

[Matthias Pfafferodt]

Update of patch #2978 (project freeciv):

 Planned Release: => 2.3.2,2.4.0,2.5.0  
 Summary: AI diplomats doesn't dodge enemy units and stack
next to an enemy city => AI diplomats stack next to an enemy city

___

Follow-up Comment #4:

updated patch; doging of enemy units can be found in bug #19014

(file #14572)
___

Additional Item Attachment:

File name: 0013-AI-diplomats-stack-next-to-an-enemy-city.patch Size:3 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19014] AI diplomats doesn't dodge enemy units

[Matthias Pfafferodt]

URL:
  

 Summary: AI diplomats doesn't dodge enemy units
 Project: Freeciv
Submitted by: syntron
Submitted on: Do 17 Nov 2011 22:43:43 CET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.2,2.4.0,2.5.0

___

Details:





___

File Attachments:


---
Date: Do 17 Nov 2011 22:43:43 CET  Name:
0012-AI-diplomats-doesn-t-dodge-enemy-units.patch  Size: 1kB   By: syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

Severity:1 - Wish => 3 - Normal 
 Planned Release:   2.4.0, 2.3.2? => 2.4.0, 2.3.2   

___

Follow-up Comment #41:

updated patch files:
- part 1: file #14294 
- part 2: file #14295 
- part 3: new file (from this comment; includes file #14548 and file #14549;
additional some code cleanup)

Can these patches be applied to gtk3 or do they use some function which is
not defined in gtk3 or depreciated? I will try to get gtk3 but do not know if
I will be succesfull

(file #14569)
___

Additional Item Attachment:

File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #40, bug #18835 (project freeciv):

> Can't break it now; thanks.
OK; this will be commited as soon as 2.3.1 is released

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev