[Freeciv-Dev] [patch #8119] Sogdian nation

2017-02-25 Thread Andrzej M. Gorzym
URL:
  

 Summary: Sogdian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sat 25 Feb 2017 04:23:08 PM CET
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 
 Contains string changes: None

___

Details:





___

File Attachments:


---
Date: Sat 25 Feb 2017 04:23:08 PM CET  Name: sogdiana.svg  Size: 24kB   By:
artaxes


---
Date: Sat 25 Feb 2017 04:23:08 PM CET  Name: sogdian.ruleset  Size: 1kB   By:
artaxes



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-20 Thread J. M. Gorbach
Follow-up Comment #6, patch #6434 (project freeciv):

> The scenario as it appears in the patch. Added separately to make it easier
to have a quick look.
It's very impressive.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-17 Thread J. M. Gorbach
Follow-up Comment #1, patch #6434 (project freeciv):

Through Lua code? I.e. edit.create_city, edit.create_road.. ?

___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-17 Thread J. M. Gorbach
Follow-up Comment #2, patch #6434 (project freeciv):

My old scenario with cities... Maybe it's useful.

(file #25335)
___

Additional Item Attachment:

File name: europev2.6.sav Size:448 KB


___

Reply to this item at:

  

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-08-26 Thread J. M. Gorbach
Follow-up Comment #27, patch #5306 (project freeciv):

Finish it completely

___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-08-25 Thread J. M. Gorbach
Follow-up Comment #25, patch #5306 (project freeciv):

 I could update it for you. I could even finish it completely if you don't
have the time to do so your self right now.
Ok, thank you.

___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-31 Thread J. M. Gorbach
Follow-up Comment #20, patch #5306 (project freeciv):

If (2) you can't expel the unit  Ok... Enslave? Imprison? Murder? Hostage?
Here (http://apolyton.net/wiki/Call_to_Power), there are interesting ideas
(future?):
* UNIT_ORDER_ENSLAVE_SETTLER
* VOID DoFreeSlaves()   Frees the slaves in city. Only works if that city was
captured this turn.
* INT IsSlaver(unit)  True if the unit is a slaver.

___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-31 Thread J. M. Gorbach
Follow-up Comment #19, patch #5306 (project freeciv):

As you probably have noticed I'm not as quick to respond as I was earlier
this week. I think I will be able to take time for a new review tomorrow
afternoon. Don't worry if you don't have a new iteration by then. I'll
probably have time for a review again early next week or maybe even at the end
of the week end. 
No problem Sveinung.
I understand. Freeciv is a large code base. Even with tools that helps you
navigate it there is a lot of new stuff. 
Exactly.
Of do_expel_unit()?
Yes.
Comment will need an update. 
Done.
Who is this a link to? (Please rename for clarity) 
Done.
Who is supposed to be on this tile? (Please rename for clarity)
Done.
The code tries to find the city a diplomat will flee to. Pick the comment or
the code.
Done.
You got the owner of the wrong unit. You want to find a city belonging to the
target so you can send it there. (Or just go for the capital in stead) 
Done.
Let us keep things simple. Abort if no city is found. (pcity == NULL means
that no city was found) Notify the actor player that there is no place to send
the target and insert a return statement. (You have written notice code below)

Done.
 Remove the capital test. If you decide to expel the target to his capital
you could add a fc_assert with is_capital() in stead. Since you aborted if
pcity wasn't found you don't have to test it. 
Done.
 Not sure if I understand what you were trying to do here. Let me know if I
got you wrong. 
I don't understand too. An old piece of code without sense... Anyway I've
deleted.
 This is the notice I mentioned above. English issue (I'm not a native
speaker): I think it should be You didn't expel
I know... Anyway Done.
 Copy past error. 
Done.

I don't think that not finding a place to send someone should count as
getting caught/stopped. I'm open to counter arguments.
It's an interesting point.
 The expulsion didn't fail when your own unit was expelled. The unit didn't
die so it wasn't lost. While the expulsion was a success the chance of failure
wasn't all that high. The question is you did this vs someone did this to
you, not loss or success.
I agree.
Expel Failed  Expel Suffered
Expel Succeeded  Expel Accomplished
Was your goal to avoid introducing a third event type?
No, my goal was to write the code correctly and learn something. Now I see
other possibilities about expel units. 

Expel unit: accomplished (1) or not (2)

If (1) you expel the *unit*  Ok.

If (2) you can't expel the *unit*  Ok... Enslave? Imprison? Murder? Hostage?

*Who can we expel?* Settler (the most annoying unit in the game), workers,
military unit; if actor unit  target unit... i.e. *Pikemen  Warriors,
Phalanx* or *Knights  Horsemen, Chariot*.

What do you think?

(file #24704)
___

Additional Item Attachment:

File name: expel_units.patch  Size:16 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-29 Thread J. M. Gorbach
Follow-up Comment #17, patch #5306 (project freeciv):

Why WIN_ in event the names? Suggestions: E_UNIT_WAS_EXPELLED
E_UNIT_DID_EXPEL 
Done.
Not sure what you mean here. If you want me to explain I need to know
specifically what you want me to explain. Or did you ask me to finish
do_expel_unit() for you?
No. Just a moment of sadness and anger. The order or disposition is
correct?
Could return NULL if no city is found. NULL - crash. You should check for
NULL and handle it. Aborting is an OK way of handling it. 
Done.
Don't add diplomat_escape_full. The actor doesn't escape. No need. He just
expelled someone. 
Done.

(file #24697)
___

Additional Item Attachment:

File name: expel_units.patch  Size:16 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-29 Thread J. M. Gorbach
Follow-up Comment #15, patch #5306 (project freeciv):

As stated in patch #6057, I would drop it completely from 3.0 already - any
code you do for it now would get wiped out before ever getting released.
Perfect.
J. M. Gorbach: Do you want to skip the Xaw stuff?
Yes, I want to skip Xaw stuff.
Expel isn't a spy action. It could be used to teleport domestic units. Change
name and group. 
Done.
Define the tags for icons and sound. The client refused to start because the
tileset didn't have the wanted tags. See how
http://repo.or.cz/w/freeciv.git/commitdiff/9c7b6d4f6e8f40de2ac51da7be3e1ea7aceb2aec
changes data/misc/events.spec and data/stdsounds.soundspec 
Done.
Don't mention foreign at all.
Work in progress.
Document the restriction (not self) you added.
Explain what expel does (where does it end up?)
Yeah... When I complete the task, because until now I can read and understand
maybe 55/60% of the code.
Other things.
I've updated do_expel_unit, but I need help because it's very difficult and I
don't understand (only unithand.c).


(file #24695)
___

Additional Item Attachment:

File name: expel_units.patch  Size:16 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-28 Thread J. M. Gorbach
Follow-up Comment #11, patch #5306 (project freeciv):

The variable names in do_expel_unit are confusing. I suggest using the words
actor (for the unit doing the expulsion) and expelled (or target) in the
variable names to make it clear who is who. 
Done (actor and target).
The even types E_MY_DIPLOMAT_BRIBE and E_ENEMY_DIPLOMAT_BRIBE in the
notifications about expulsion are wrong. Use existing events or create new
once if no one fits.
Done.

#define SPECENUM_VALUE122 E_MY_DIPLOMAT_EXPEL
#define SPECENUM_VALUE123 E_ENEMY_DIPLOMAT_EXPEL

Why never expel a unit to its capital?
My mistake. I've edited... Can you check again? 
The Xaw client needs the button added in the data too. ( See
http://repo.or.cz/w/freeciv.git/commitdiff/25ee5735a91265bac09df12eb42dff2ca7037643
) 
Well... It's not very logic. Anyway it's done, but check please.
Update the documentation that foreign isn't hard coded.
Done.


(file #24683)
___

Additional Item Attachment:

File name: expel_units.patch  Size:18 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-28 Thread J. M. Gorbach
Follow-up Comment #9, patch #5306 (project freeciv):

+ || wanted_action == ACTION_EXPEL_UNIT) 
Done.
I think that sending it back to the same city the diplomat would have fled to
(find_closest_city) is an acceptable alternative to sending it to the capital
or to its home city.
Capital? Done... I hope.
 The Capital_City effect decides what the capital is. In classic it looks for
the palace.
Ok.

(file #24680)
___

Additional Item Attachment:

File name: expel_units.patch  Size:17 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-27 Thread J. M. Gorbach
Follow-up Comment #7, patch #5306 (project freeciv):

 Why would anyone become a veteran from expelling a unit? This will be used
to let players expel diplomats they can't kill because of a peace treaty.
Don't assume a battle here. 
It's my mistake.

___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-27 Thread J. M. Gorbach
Follow-up Comment #6, patch #5306 (project freeciv):

 Expelling a diplomat will send him home. My suggestion is to send him to his
capital. (Capital of the expelled unit, not the capital of the unit doing the
expulsion) This creates a corner case for players without a capital. You could
add that the expelled unit has a capital as a hard coded requirement to the
action and as an assertion to the function doing the expelling. An alternative
is to use the unit's home city. That creates another corner case: units
without a home city.
Ok...
 The action should be documented in doc/README.actions 
Done.
 change names. expel units - expel unit, etc 
Done.
 the clients should send the target unit, not the target tile
Done.
 Why do you define a unit lost reason? The unit is sent home, not killed.
Because... I'm very confuse.
 Why would anyone become a veteran from expelling a unit? This will be used
to let players expel diplomats they can't kill because of a peace treaty.
Don't assume a battle here.
Because 
 Why hard code that you can't expel your own units? A ruleset author may use
the action to create a unit that will teleport a unit to its capital/home
city/etc. A ruleset like that may even wish to limit the action to domestic
units. 
I totally agree. Unfortunately I have to read the code with more attention.
 diplomat_bribe() and spy_sabotage_unit() in diplomats.c - performs (spy)
actions with a unit target 
I don't know... but I've copied and pasted exactly diplomat_bribe(), but I
change every name as victim, diplomat, etc..
 teleport_unit_to_city() in unittools - function that moves a unit to a city.
Maybe you can use it directly? 
Very interesting... The same thing for find_closest_city(). I've added the
function in the patch, but I don't know how I can insert Capital reference
in the code. I was thinking about another find where I search a city with
Palace. 

Capital is a city where you can find the Palace... It's correct?

(file #24676)
___

Additional Item Attachment:

File name: expel_units.patch  Size:17 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-27 Thread J. M. Gorbach
Follow-up Comment #3, patch #5306 (project freeciv):

--You shouldn't do anything in server/rscompat.c. It is for adding rules that
used to be hard coded to rulesets during ruleset version upgrade. Expel is a
new action.
Right!
--Your changes in aiair.c and aitools.c don't belong there. Expel isn't an
attack.
Right!
--do_expel_units() captures all units at the tile in stead of deporting them
to their capital. 
I have a problem with capital, bool and struct...
--why did you make it an action against a unit stack rather than an action
against a single unit? What makes a unit stack target better than a unit
target for this action? 
Because I've copied and pasted ''CAPTURE_UNITS'', the function more similar to
EXPEL_UNITS. Now I understand your feedback and I hope it's correct now...

(file #24669)
___

Additional Item Attachment:

File name: expel_units.patch  Size:17 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5306] Add the new action Expel Unit

2015-07-26 Thread J. M. Gorbach
Follow-up Comment #1, patch #5306 (project freeciv):

- Are you interested in giving Expel Unit a try? It's a new action.
Yes, I'm interested.

(file #24666)
___

Additional Item Attachment:

File name: expel_units.patch  Size:21 KB


___

Reply to this item at:

  http://gna.org/patch/?5306

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6127] Lua improvements (methods and effects) + Resource

2015-07-17 Thread J. M. Gorbach
Follow-up Comment #1, patch #6127 (project freeciv):

Methods: 

(5) Extra: rule_name and name_translation
(6) Nation Set: untranslated_name, rule_name, name_translation and
description
(7) Nation Group: untranslated_name, rule_name and name_translation


(file #24632)
___

Additional Item Attachment:

File name: lua.patch  Size:26 KB


___

Reply to this item at:

  http://gna.org/patch/?6127

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6127] Lua improvements (methods and effects) + Resource

2015-07-17 Thread J. M. Gorbach
Follow-up Comment #2, patch #6127 (project freeciv):

Methods: 

(8) Road: rule_name and name_translation 
(9) Style: rule_name and name_translation 
(10) Specialist: rule_name, plural_translation and abbreviation_translation

(file #24633)
___

Additional Item Attachment:

File name: lua.patch  Size:32 KB


___

Reply to this item at:

  http://gna.org/patch/?6127

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6127] Lua improvements (methods and effects) + Resource

2015-07-16 Thread J. M. Gorbach
Additional Item Attachment, patch #6127 (project freeciv):

File name: lua.patch  Size:19 KB


___

Reply to this item at:

  http://gna.org/patch/?6127

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6127] Lua improvements (methods and effects) + Resource

2015-07-16 Thread J. M. Gorbach
URL:
  http://gna.org/patch/?6127

 Summary: Lua improvements (methods and effects) + Resource
 Project: Freeciv
Submitted by: gorb
Submitted on: Thu 16 Jul 2015 10:17:29 AM UTC
Category: general
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Methods:

(1) City: is_happy, is_unhappy, is_celebrating, rapture_grow,
got_defense_effect, is_gov_center, is_capital, is_city_center, is_free_worked
(2) Nation: is_nation_pickable, is_nation_playable
(3) Building_type: is_special_improvement 
(4) Resource: rule_name, name_translation, terrain_has_resource

Effects: unit_bonus, tile_bonus, building_bonus, unittype_bonus





___

File Attachments:


---
Date: Thu 16 Jul 2015 10:17:29 AM UTC  Name: lua.diff  Size: 20kB   By: gorb

http://gna.org/patch/download.php?file_id=24630

___

Reply to this item at:

  http://gna.org/patch/?6127

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22082] Lua disaster signal can't suppress message We survived the disaster without serious damages.

2014-12-28 Thread J. M. Gorbach
Follow-up Comment #5, bug #22082 (project freeciv):

Trunk version: boolean passed to lua script, default.lua outputting the
message when appropriate. 
Very interesting, I read your patch. I have a question... Why 2 and not 3 in
your patch?

  luascript_signal_create(fcl, disaster, 2,

and the same...

script_server_signal_emit(disaster, 2,


___

Reply to this item at:

  http://gna.org/bugs/?22082

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5597] civ2civ3: achievements

2014-12-23 Thread J. M. Gorbach
Follow-up Comment #1, patch #5597 (project freeciv):

Nice idea.
I plan to add culture points and achievement to this ruleset, if you agree.
So... Culture can be negative? I read something about Civ3 culture system, but
I've never played Civ3. Maybe broke alliance, border friction or broke
alliance in wartime can cause a decrease of culture points.

___

Reply to this item at:

  http://gna.org/patch/?5597

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5587] Labels for earth scenarios

2014-12-21 Thread J. M. Gorbach
Follow-up Comment #3, patch #5587 (project freeciv):

I wonder if there is a way to make that those labeled tiles have an effect
on the game. 
It's a very interesting idea. This can create an exciting element that
requires the player to adapt to the tactical situation!
My first idea was to find a way to increase the culture points of the owner
of a labeled tile, now that achievements are available in v2.6, but I'm not
sure if possible (or worth to implement).
Now.. Freeciv has the boolean 'hut_enter'. One possible solution... create
another boolean like 'tile_enter' or 'tile_place' with API_TYPE_TILE in
script_signal.c.

And.. Maybe we can write a lua script: 
when the explorer (land) - or the caravel (sea) - 
enter in the tile (xxx,xxx)
notify (You've climbed Mount Everest)
gain history



___

Reply to this item at:

  http://gna.org/patch/?5587

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22082] Lua disaster signal can't suppress message We survived the disaster without serious damages.

2014-05-26 Thread J. M. Gorbach
Follow-up Comment #1, bug #22082 (project freeciv):

 Perhaps we can move the emission of the message to a default signal handler
in default.lua instead, and make emitting the message ruleset Lua's
responsibility?

I agree.

___

Reply to this item at:

  http://gna.org/bugs/?22082

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4011] Lua: edit.change_terrain and edit.place_resource

2014-02-25 Thread J. M. Gorbach
Follow-up Comment #4, patch #4011 (project freeciv):

I checked another time... 

File: server/sanitycheck.c

Function: static void check_map(const char *file, const char *function, int
line)

Specific:
193   SANITY_TILE(ptile, cont  0);
and
195 if (!is_ocean_tile(tile1)) {
196   SANITY_TILE(ptile, tile_continent(tile1) == cont);
197 }

There is a warning when I start a game (file #19670), I open and close Editing
Mode and Turn Done.

Tileset problem, it's probably incompatible with the ruleset: Map topology and
tileset incompatible.

___

Reply to this item at:

  http://gna.org/patch/?4011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4011] Lua: edit.change_terrain and edit.place_resource

2014-02-25 Thread J. M. Gorbach
Follow-up Comment #5, patch #4011 (project freeciv):

In my patch from 'tile_change_terrain' to 'tile_set_terrain'.

Fix... but when I turn Grassland into Ocean (resource: Whales).

in begin_turn() [srv_main.c::881]: assertion 'cont  0' failed.
in begin_phase() [srv_main.c::972]: assertion 'cont  0' failed.

___

Reply to this item at:

  http://gna.org/patch/?4011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4011] Lua: edit.change_terrain and edit.place_resource

2014-02-25 Thread J. M. Gorbach
Follow-up Comment #7, patch #4011 (project freeciv):

Are you recalculating the continents?
Ehm... no, because I don't know where I have to look. I searched in the code
*num_continents* and *last_num_continents*. Maybe I have to work in
server/generator files (i.e. utilities.c) or in ai/default/ (i.e. aidata.c and
aidata.h) or elsewhere (common, client, etc).

If you have any advice it would be very much appreciated! 

___

Reply to this item at:

  http://gna.org/patch/?4011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4011] Lua: edit.change_terrain and edit.place_resource

2014-01-04 Thread J. M. Gorbach
Follow-up Comment #3, patch #4011 (project freeciv):

I checked another time...

I added scripting lua (transform terrain -mountain- and place resource -gold-)
in the scenario. If I turn ocean, deep ocean or lake in mountains, there are
error messages. Same position, exactly on sanity_check().

If I turn plain in mountain, nothing... I don't know if swamp, glacier,
forest, hill or other terrains are ok, but I think so.



(file #19670)
___

Additional Item Attachment:

File name: europe-200x100-v2.sav  Size:60 KB


___

Reply to this item at:

  http://gna.org/patch/?4011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21239] Optional rule: Penalty to attack due to ZoC

2013-10-30 Thread J. M. Gorbach
Follow-up Comment #9, bug #21239 (project freeciv):

My suggestion tries to make these waves of units a valid tactic, as we see in
most wargames. 
I agree and if there is a possibility to control with Lua script these
waves... it's very interesting.

___

Reply to this item at:

  http://gna.org/bugs/?21239

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4034] The alans

2013-07-29 Thread Andrzej M. Gorzym
Follow-up Comment #1, patch #4034 (project freeciv):

Excuse me, but some of your suggestions have been made by others.

___

Reply to this item at:

  http://gna.org/patch/?4034

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3361] Support web-links in helptexts

2013-07-18 Thread J. M. Gorbach
Follow-up Comment #5, patch #3361 (project freeciv):

I've found: https://developer.gnome.org/pango/unstable/index.html and
https://developer.gnome.org/pango/unstable/PangoMarkupFormat.html

___

Reply to this item at:

  http://gna.org/patch/?3361

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4011] Lua: edit.change_terrain and edit.place_resource

2013-07-17 Thread J. M. Gorbach
URL:
  http://gna.org/patch/?4011

 Summary: Lua: edit.change_terrain and edit.place_resource
 Project: Freeciv
Submitted by: gorb
Submitted on: Wed 17 Jul 2013 10:46:27 AM GMT
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Add two new lua functions in module edit:
edit.change_terrain, change terrain
edit.place_resource

I've tested with:

function map_labels()
  local terrain = find.tile(170,230)
  edit.change_terrain(terrain, 'Mountains')
  local terrain = find.tile(170,230)
  edit.place_resource(terrain, 'Gold')
end

function turn_cb(turn, year)
  if turn == 0 then
  map_labels()
  end
end

Works, the result is a transformation from deep ocean to mountain, with a
resource (gold), but there are messages. 
Only change function:

in begin_turn() [srv_main.c::881]: assertion 'cont  0' failed.
( 170,  230) at Mountains
in begin_phase() [srv_main.c::948]: assertion 'cont  0' failed.
( 170,  230) at Mountains

Both functions (change and place):

in begin_phase() [srv_main.c::948]: assertion 'cont  0' failed.
( 170,  230) at Mountains




___

File Attachments:


---
Date: Wed 17 Jul 2013 10:46:27 AM GMT  Name:
change_terrain_and_place_resource.diff  Size: 3kB   By: gorb

http://gna.org/patch/download.php?file_id=18310

___

Reply to this item at:

  http://gna.org/patch/?4011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3332] Negated requirements_vector

2013-04-25 Thread J. M. Gorbach
Follow-up Comment #5, patch #3332 (project freeciv):

I agree with bug #20695 and I ask to close this patch, because it's pointless.

___

Reply to this item at:

  http://gna.org/patch/?3332

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3879] Remove negated reqs{} field in favor of something semantically nicer

2013-04-23 Thread J. M. Gorbach
Follow-up Comment #1, patch #3879 (project freeciv):

or by changing the word used to be something positive.
I agree.
Note that the introduction of nreqs uses an entirely different mechanism than
that suggested in patch #3332
The mechanism was wrong and my original idea was confuse. My purpose was the
patch #1342, where requirement_vector nreqs replaced obsoleted_by. This was
the second step.

The first step was in patch #1339, where requirement_vector reqs replaced the
fields require_advance, need_improvement and need_government.

Same for patch #1341 and #1340.



___

Reply to this item at:

  http://gna.org/patch/?3879

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Can I un-static function?

2013-04-09 Thread M
I made scalable minimap for qt-client ( default is integer only, that one  
is fully scalable),

but I had to draw viewport manually.
For that I had to convert gui to overview position, but that function is  
static ( in overview_common.c),
so I used gui to map conversion and then map to overview ( but I added gui  
to map conversion to

mapview.cpp in qt )
But now I think it would be much easier if I could just make  
gui_to_overview_pos non-static.

So should I do it or not ?

--
mir3x

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20086] in astr_vadd() [astring.c::164]: assertion '(size_t) -1 != new_len' failed.

2013-02-17 Thread J. M. Gorbach
Follow-up Comment #3, bug #20086 (project freeciv):

Does this patch also solve your problem? 
Yes, problem solve. Thanks!

___

Reply to this item at:

  http://gna.org/bugs/?20086

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3625] Unit nationality

2013-01-28 Thread J. M. Gorbach
Follow-up Comment #1, patch #3625 (project freeciv):

Great! :-)

___

Reply to this item at:

  http://gna.org/patch/?3625

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3480] Tech helptext popup when tech researched

2013-01-18 Thread J. M. Gorbach
Follow-up Comment #1, patch #3480 (project freeciv):

 Should we provide this feature in client code (with option to disable those
popups) for all rulesets?
Yes :)

___

Reply to this item at:

  http://gna.org/patch/?3480

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3422] Carian nation

2012-11-27 Thread Andrzej M. Gorzym
Follow-up Comment #2, patch #3422 (project freeciv):

Other Carian flag by TheseusDeuteros (Alternate History Discussion Board
user):
http://www.alternatehistory.com/discussion/showpost.php?p=6917932postcount=5674
Made at my request.

(file #16804)
___

Additional Item Attachment:

File name: carian.svg Size:13 KB


___

Reply to this item at:

  http://gna.org/patch/?3422

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2014] Novgorodian nation

2012-11-25 Thread Andrzej M. Gorzym
Follow-up Comment #10, patch #2014 (project freeciv):

What you think about this ?
http://intrepidtee.deviantart.com/art/Novgorod-Republic-Flag-278146065
On this image's page there is no information about the wide copyright
license.
Author of this flag has been advised on the proposition.
He probably used the symbol of Wikimedia Commons stated here before. Maybe can
use this flag, indicating the names of the authors in file.

___

Reply to this item at:

  http://gna.org/patch/?2014

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-21 Thread J. M. Gorbach
Follow-up Comment #15, patch #3495 (project freeciv):

This last point is actually why I think this must be implemented in ruleset 
C-code. Server must be aware of the fact that city will be founded to starting
location before it assigns those locations.
I agree.

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-20 Thread J. M. Gorbach
Follow-up Comment #13, patch #3495 (project freeciv):

Should it be inserted into tolua_game.pkg?
Yes, it should be inserted into tolua_game.pkg and api_game_find.c

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20086] in astr_vadd() [astring.c::164]: assertion '(size_t) -1 != new_len' failed.

2012-08-20 Thread J. M. Gorbach
URL:
  http://gna.org/bugs/?20086

 Summary: in astr_vadd() [astring.c::164]: assertion '(size_t)
-1 != new_len' failed.
 Project: Freeciv
Submitted by: gorb
Submitted on: lun 20 ago 2012 13:47:20 GMT
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2/2.4.0-beta1/trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

256*256 (or 16*16*16*16) = 65536

static char buf[65536] in 2.3
static char buf[65536] in 2.4
static char buf[65536] in trunk v.21813

My scenario file: Formatted string bigger than 2 bytes.

I don't know if is a correct value, but I increased buf at 16777216
(256*256*256) and the error disappear. Maybe the correct value is 1048576
(16*16*16*16*16). 

Is it possible increase the buf for s2_4?



___

File Attachments:


---
Date: lun 20 ago 2012 13:47:20 GMT  Name: limit_buf_trunk.patch  Size: 537B  
By: gorb

http://gna.org/bugs/download.php?file_id=16413

___

Reply to this item at:

  http://gna.org/bugs/?20086

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-19 Thread J. M. Gorbach
Follow-up Comment #7, patch #3495 (project freeciv):

According to http://freeciv.wikia.com/wiki/Lua_reference_manual#find this
would be (if it is working) the missing function: Player find.leader
(nation_name) 
It's not working.

Original (working)
local owner = find.player(0)

Test (not working)
local owner = find.leader(Swedish)
local owner = find.leader('Swedish')
local owner = find.leader(Swedish)
local owner = find.leader(nation_swedish)
local owner = find.leader('nation_swedish')
local owner = find.leader(nation_swedish)

Error: [string script.code]:4: attempt to call field 'leader' (a nil value)

Question: should such functions be collected in something like a lua
(example) library?

I don't know. I write my function in scenario files between [script] code=$
and $.

Now I test the (untested) function, but... Where should I insert? Function
turn_cb(turn, year) or function  city_nation_swedish()?




___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-19 Thread J. M. Gorbach
Follow-up Comment #9, patch #3495 (project freeciv):

Sorry about the confusion; I mean the function in comment #5 would be the
currently missing function find.leader(nation_name) implemented in lua. The
function find.player(player_name) could be implemented similar. I can't test
it at the moment ...

No problem. Thanks for your help!

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-19 Thread J. M. Gorbach
Follow-up Comment #11, patch #3495 (project freeciv):

 The function should be inserted on its own (separate function). After that
you could change your function as follows.

Congratulations! Working! You missed only:

[...]
if (nation_str == plr_nation_str)
*then* return player
end
[...]

without *then* it's not working :)

Thanks Syntron!

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-15 Thread J. M. Gorbach
Follow-up Comment #3, patch #3495 (project freeciv):

From server/scripting/api_server_edit.c:


void api_edit_create_city(lua_State *L, Player *pplayer, Tile *ptile,
  const char *name)


Is it possible add ''Nation_Type *pnation'' at the API? If it's not possible
maybe create new API with ''Nation_Type *pnation''.

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20058] Invalid string conversion from UTF-8 to CP1252 with Turkish leader name

2012-08-13 Thread J. M. Gorbach
Follow-up Comment #1, bug #20058 (project freeciv):

Invalid string conversion from UTF-8 to CP1252. 

Today same problem with 2.4.0-beta1 Gtk Windows package: Kriðjānis
Valdemārs (Latvian),  Džemal Bijedić (Bosnia) and Dragoş
(Moldavian).

___

Reply to this item at:

  http://gna.org/bugs/?20058

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20058] Invalid string conversion from UTF-8 to CP1252 with Turkish leader name

2012-08-13 Thread J. M. Gorbach
Additional Item Attachment, bug #20058 (project freeciv):

File name: leaders.pngSize:12 KB


___

Reply to this item at:

  http://gna.org/bugs/?20058

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20058] Invalid string conversion from UTF-8 to CP1252 with Turkish leader name

2012-08-13 Thread J. M. Gorbach
Follow-up Comment #3, bug #20058 (project freeciv):

gorb, did/do you see a similar problem with previous Windows versions?
No, I didn't/don't.

___

Reply to this item at:

  http://gna.org/bugs/?20058

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-10 Thread J. M. Gorbach
Follow-up Comment #2, patch #3495 (project freeciv):

I used to insert in script.lua a function. 
Or in a scenario files between:

[script]
code=$
$

but it's not simply for novice. I have a scenario (Europe 350*350 - S_3) where
I generate 617 cities at the start. The problem are nations!
If I use script lua:

  local owner = find.player(0)

Maybe player(0) is Poland or Greece or United Kingdom, but Stockholm is
Swedish! I tried find.nation_type('nameofthenation') and
find.nation_type(nameofthenation), but both don't run.

___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3495] Starting with first city placed

2012-08-09 Thread J. M. Gorbach
Follow-up Comment #1, patch #3495 (project freeciv):

I used to insert in script.lua a function.

function  city_nation_swedish()
  local owner = find.player(0)
  local Stockholm = find.tile(208,93)
  create_city(owner,  Stockholm, 'Stockholm')
end
function turn_cb(turn, year)
  if turn == 0 then
  city_nation_swedish()
  end
end
signal.connect('turn_started', 'turn_cb')

Maybe insert coordinates of city in scenario file, under nation start
position.

r0=Swedish
r0sx=208
r0sy=93
r0scity=Stockholm
r0sx=???
r0sy=???
r0scity=Sundsvall


___

Reply to this item at:

  http://gna.org/patch/?3495

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3316] Celtic nation

2012-07-27 Thread Andrzej M. Gorzym
Follow-up Comment #3, patch #3316 (project freeciv):

Probably it my final fixes, so can add.

(file #16210)
___

Additional Item Attachment:

File name: celtic.ruleset Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?3316

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3409] Update British Isles scenario format

2012-07-21 Thread J. M. Gorbach
Follow-up Comment #2, patch #3409 (project freeciv):

Eiher we should update to S2_4 format, or wait stable S2_5 format.
I don't know. Maybe there are other patch for S2_5.

___

Reply to this item at:

  http://gna.org/patch/?3409

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2195] New Early Germanic nations

2012-07-19 Thread Andrzej M. Gorzym
Follow-up Comment #18, patch #2195 (project freeciv):

Gepid ruleset updated.
Names of cities are constructed in Gothic language.

(file #16133)
___

Additional Item Attachment:

File name: gepid.ruleset  Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?2195

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2195] New Early Germanic nations

2012-07-19 Thread Andrzej M. Gorzym
Follow-up Comment #19, patch #2195 (project freeciv):

Flag with modified Herulian shield. After modification looks some like
Germanic ring symbol.

(file #16136)
___

Additional Item Attachment:

File name: gepid.svg  Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?2195

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3428] Kara Koyunlu nation

2012-07-17 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3428

 Summary: Kara Koyunlu nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Tue 17 Jul 2012 05:33:41 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Kara Koyunlu or Black Sheep Turkomans.

Flag:
http://en.wikipedia.org/wiki/File:KarakoyunluFlag.png



___

File Attachments:


---
Date: Tue 17 Jul 2012 05:33:41 PM CEST  Name: karakoyunlu.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=16125

___

Reply to this item at:

  http://gna.org/patch/?3428

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3422] Carian nation

2012-07-15 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3422

 Summary: Carian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 15 Jul 2012 05:48:19 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Carians.

Flag with statuette of Zeus Labraundos (Wikimedia Commons).



___

File Attachments:


---
Date: Sun 15 Jul 2012 05:48:19 PM CEST  Name: carian.svg  Size: 9kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16100
---
Date: Sun 15 Jul 2012 05:48:19 PM CEST  Name: carian.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16101

___

Reply to this item at:

  http://gna.org/patch/?3422

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3422] Carian nation

2012-07-15 Thread Andrzej M. Gorzym
Follow-up Comment #1, patch #3422 (project freeciv):

Some edits.

(file #16104)
___

Additional Item Attachment:

File name: carian.ruleset Size:2 KB


___

Reply to this item at:

  http://gna.org/patch/?3422

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3423] Lydian nation

2012-07-15 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3423

 Summary: Lydian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 15 Jul 2012 07:01:56 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Flag with a coin from Lydia:
http://en.wikipedia.org/wiki/File:BMC_06.jpg



___

File Attachments:


---
Date: Sun 15 Jul 2012 07:01:56 PM CEST  Name: lydian.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16105
---
Date: Sun 15 Jul 2012 07:01:56 PM CEST  Name: lydian.svg  Size: 106kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16106

___

Reply to this item at:

  http://gna.org/patch/?3423

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3413] Laz nation

2012-07-14 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3413

 Summary: Laz nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sat 14 Jul 2012 01:02:02 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Laz people from North-East Turkey and Georgia.

Flag by me.



___

File Attachments:


---
Date: Sat 14 Jul 2012 01:02:02 PM CEST  Name: laz.svg  Size: 3kB   By: artaxes

http://gna.org/patch/download.php?file_id=16080
---
Date: Sat 14 Jul 2012 01:02:02 PM CEST  Name: laz.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16081

___

Reply to this item at:

  http://gna.org/patch/?3413

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3414] Umbrian nation

2012-07-14 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3414

 Summary: Umbrian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sat 14 Jul 2012 03:06:15 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Umbri.

Flag based on ancient Umbrian warrior's amulet.



___

File Attachments:


---
Date: Sat 14 Jul 2012 03:06:15 PM CEST  Name: umbri.svg  Size: 4kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16083
---
Date: Sat 14 Jul 2012 03:06:15 PM CEST  Name: umbrian.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16084

___

Reply to this item at:

  http://gna.org/patch/?3414

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3415] Lucanian nation

2012-07-14 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3415

 Summary: Lucanian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sat 14 Jul 2012 07:40:21 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Lucanians.

Flag based on Basilicata region flag.



___

File Attachments:


---
Date: Sat 14 Jul 2012 07:40:21 PM CEST  Name: lucanian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=16087
---
Date: Sat 14 Jul 2012 07:40:21 PM CEST  Name: lucania.svg  Size: 12kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16088

___

Reply to this item at:

  http://gna.org/patch/?3415

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3416] Bruttian nation

2012-07-14 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3416

 Summary: Bruttian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sat 14 Jul 2012 09:30:13 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Bruttii.

Flag with a laurel.



___

File Attachments:


---
Date: Sat 14 Jul 2012 09:30:14 PM CEST  Name: bruttium.svg  Size: 12kB   By:
artaxes

http://gna.org/patch/download.php?file_id=16090
---
Date: Sat 14 Jul 2012 09:30:13 PM CEST  Name: bruttian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=16089

___

Reply to this item at:

  http://gna.org/patch/?3416

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-11 Thread J. M. Gorbach
Follow-up Comment #17, patch #3377 (project freeciv):

- Huts were not added to generated map
- Set only those server settings that should have non-default value
- Removed specials from savegame.options as there's no map included at all
- Restored one changed string

I applied the patch and tutorial.sav started without errors. More lighter with
21.6 kb (22.5 kb old tutorial.sav) :)

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread J. M. Gorbach
Follow-up Comment #13, patch #3377 (project freeciv):

Savegame format does't run for scenario files (ie. earth 160x90, etc.).
Neither

mapsize, FULLSIZE, FULLSIZE ?
size, x measure, y measure ?

nor

+topology, ISO|WRAPX, ISO|WRAPX ?
+mapsize, XYSIZE, XYSIZE ?
+xsize, x measure, x measure ?
+ysize, y measure, y measure ?



___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-10 Thread J. M. Gorbach
Follow-up Comment #15, patch #3377 (project freeciv):

That scenario has map already, server settings for generating one should not
matter.
Ok. Save and load tutorial.sav without errors.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19919] When playing scenario, normal save creates scenario

2012-07-10 Thread J. M. Gorbach
Follow-up Comment #2, bug #19919 (project freeciv):

Tested my theories. Fix attached.
Applied patch and bug seems fixed.

___

Reply to this item at:

  http://gna.org/bugs/?19919

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #1, patch #3377 (project freeciv):

Any volunteers?
I applied the patch, but... tutorial.sav don't start

in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Failed to create suitable map, retrying with another mapseed
in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Cannot create suitable map with given settings.
Segnalare questo messaggio a http://gna.org/projects/freeciv/

I tried with british-isles-85x80-v2.80.sav (edit by hand) and start without
problem.


(file #16018)
___

Additional Item Attachment:

File name: british-isles-85x80-v2.80.sav.gz Size:3 KB


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #4, patch #3377 (project freeciv):

Which branch you used? It should be compatible with current freeciv TRUNK.
I use rev. 21469



___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #5, patch #3377 (project freeciv):

I tried with british-isles-85x80-v2.80.sav (edit by hand) and start without
problem.
I made a mistake... British map doesn't start. Measure isn't 85x80, but
73x81.
I applied the patch, but... tutorial.sav doesn't start.
I added a minimap at the bottom of tutorial.sav

t000=
t001=gggg
t002=gggg
t003=
t004=
t005=
t006=
t007=
n000=
n001=
n002=
n003=
n004=
n005=
n006=
n007=

but same output.

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #8, patch #3377 (project freeciv):

Applied patch:

+mapsize, FULLSIZE, FULLSIZE
+size, 1, 1

I don't know, maybe it's my pc, but the same output. Now I use rev. 21471,
last change jtn (2012-07-08 11:26:08 +0200).

in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Failed to create suitable map, retrying with another mapseed
in map_init_topology() [map.c::332]: assertion 'MAP_WIDTH =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in map_init_topology() [map.c::333]: assertion 'MAP_HEIGHT =
MAP_MIN_LINEAR_SIZE' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
in create_start_positions() [startpos.c::399]: assertion 'player_count() =
sum' failed.
Segnalare questo messaggio a http://gna.org/projects/freeciv/
The server couldn't allocate starting positions.
Cannot create suitable map with given settings.
Segnalare questo messaggio a http://gna.org/projects/freeciv/


___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #10, patch #3377 (project freeciv):

More importantly, below minimum xsize and ysize settings were removed.
Exactly! Anyway new format is very interesting, great job!

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #11, patch #3377 (project freeciv):

See bug #18476: allow to load games without a map (i.e. tutorial)?

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3377] Update tutorial savegame format

2012-07-08 Thread J. M. Gorbach
Follow-up Comment #12, patch #3377 (project freeciv):

Now I use rev. 21480 and tutorial.sav start without errors :)

___

Reply to this item at:

  http://gna.org/patch/?3377

___
  Messaggio inviato con/da Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3372] Kamboja nation

2012-07-06 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3372

 Summary: Kamboja nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Fri 06 Jul 2012 09:16:25 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Ancient Iranian Kamboja.

Flag based on Faravahar symbol from Wikimedia Commons.



___

File Attachments:


---
Date: Fri 06 Jul 2012 09:16:25 AM CEST  Name: kamboja.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15983
---
Date: Fri 06 Jul 2012 09:16:25 AM CEST  Name: kamboja.svg  Size: 111kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15984

___

Reply to this item at:

  http://gna.org/patch/?3372

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3373] Alanian nation

2012-07-06 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3373

 Summary: Alanian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Fri 06 Jul 2012 11:55:08 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Alans.

Flag with bow from clip-art and Ossetian colours.



___

File Attachments:


---
Date: Fri 06 Jul 2012 11:55:08 AM CEST  Name: alanian.svg  Size: 8kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15986
---
Date: Fri 06 Jul 2012 11:55:08 AM CEST  Name: alanian.ruleset  Size: 3kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15987

___

Reply to this item at:

  http://gna.org/patch/?3373

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3375] Cilician nation

2012-07-06 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3375

 Summary: Cilician nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Fri 06 Jul 2012 03:31:06 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Little Armenia.

http://en.wikipedia.org/wiki/File:Rubenid_Flag.svg



___

File Attachments:


---
Date: Fri 06 Jul 2012 03:31:06 PM CEST  Name: cilician.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15989

___

Reply to this item at:

  http://gna.org/patch/?3375

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3361] Support web-links in helptexts

2012-07-06 Thread J. M. Gorbach
Follow-up Comment #3, patch #3361 (project freeciv):

Maybe this library is useful:
http://sourceforge.net/projects/bbcodelib/

___

Reply to this item at:

  http://gna.org/patch/?3361

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3358] Galatian nation

2012-07-02 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3358

 Summary: Galatian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Mon 02 Jul 2012 03:18:00 PM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Flag with a Celtic knot (Wikimedia Commons).



___

File Attachments:


---
Date: Mon 02 Jul 2012 03:18:00 PM CEST  Name: galatian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15955
---
Date: Mon 02 Jul 2012 03:18:00 PM CEST  Name: galatian.svg  Size: 43kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15956

___

Reply to this item at:

  http://gna.org/patch/?3358

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [Freeciv-i18n] Nations in Freeciv (was: S2_4 nation updates)

2012-06-24 Thread Jos M. Maalderink

 Whew, I unleashed something here. Jos has found this discussion, but it
 ought to have been on -dev as well as -i18n, so that other nation
 contributors have a chance to join in.

Yes. We should at least contact Andrzej.

 I think there's two things here: whether all these nations are enhancing
 the game and belong in the core Freeciv distribution at all (ignoring
 for a moment the impact on translators), and if so, how to help players
 navigate them, and then there's managing the impact on the translation
 team specifically.
 
 Personally, I'm quite fond of our nation collection; I think it's pretty
 cool that there exists this growing GPL'd set of nation descriptions,
 with flags, cities, leaders, relationships (civil_war, conflicts_with)
 and potted histories (from which I've learnt some stuff), of consistent
 quality, all curated by a qualified historian.
 I accept that's not necessarily a reason that it has to live in the core
 of Freeciv, though.

That's my feeling as well. I like being able to choose between a lot of nations 
including obscure ones, and it doesn't hurt having them in anyway. But at the 
same time it shouldn't become a nuisance for players who don't care much for 
having a multitude of nations.

 
  * More, finer-grained nation groups, and maybe subgroups (Europe/Baltic).
This would also help automatic nation selection; if I select some
Baltic duchy, it'd be kind of cool if the game is specific enough to
throw six other Baltic duchy AIs into the game with me.
Requires re-classifying existing nations, and for period-based
grouping, probably some scholarly discussion and compromise (see
Early Modern discussion in http://gna.org/patch/?1698 et al).
 
  * More sophisticated UI for selecting nation groups. Being able to
filter on the intersection of Ancient AND African, for example, to
get down to a manageable list to browse. Don't really know how to
make this intuitive (I'd try Ctrl-clicking on the nation group tabs
to select more than one, but it's not very discoverable).

I like these ideas; it would allow for thematic games.

 If we are to be ruthless and somehow divide the nations into core and
 extended ones, well, I have no idea where to start :) I'd want to
 leave that up to Jos  co, if they are willing.

The core nations could be all nations that have appeared in one of the 
Civilization games. That would be 40-something nations, which seems like a 
manageable number. Actually, it might be a good idea to introduce a core 
nation group already in addition to the already existing nation groups. It 
could replace 'ancient' as the group that appears first when selecting a nation 
so that people who don't want to plow through large nation lists can pick a 
core one immediately.

 re incompleteness/imbalance: I wouldn't judge by the current snapshot of
 nations, since there's been a continuous flow of them for years. Jos can
 probably comment further, but http://gna.org/patch/?2010 suggests that
 they're approaching it continent-by-continent, so some areas are going
 to be fatter than others while that's going on.

For some time I was making mothern nations based on the list of countries by 
population, but apart from that it's mostly random. All but two modern nations 
(Palau and Tuvalu) are included in the game now, three if you count Azawad. I 
have a list of nations that could be included (attached) but I don't have any 
systematic approach of which nations I make then. I usually just make a nation 
when I feel like it, though of course it often happens that I make a couple of 
geographically or historically related ones together. As far as I can tell 
Andrzej has the same approach. 

 re in-game confusion caused by Poles vs Greater Poles etc:
 conflicts_with already exists and is maintained to discourage nations
 with confusingly similar names or flags from appearing in the same game.
 I checked a couple of the examples listed as confusingly similar, and
 they are marked as conflicting.

On a related issue, it would be a good idea if the borders of flags and shields 
could be in the player color rather than default black. It would make 
identification slightly easier and as an additional plus we could have separate 
designs for flags and shields (cropping it out of the same source as used for 
the flag sometimes leads to ridiculous shield imagines).

  ___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3315] Dacian nation

2012-06-23 Thread Andrzej M. Gorzym
Follow-up Comment #1, patch #3315 (project freeciv):

Other flag based on Dacian shield from Wikimedia Commons.

(file #15868)
___

Additional Item Attachment:

File name: dacian.svg Size:7 KB


___

Reply to this item at:

  http://gna.org/patch/?3315

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3332] Negated requirements_vector

2012-06-18 Thread J. M. Gorbach
URL:
  http://gna.org/patch/?3332

 Summary: Negated requirements_vector
 Project: Freeciv
Submitted by: gorb
Submitted on: Mon 18 Jun 2012 06:41:10 PM GMT
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Add 'requirement_vector nreqs':

* Base
* Cities
* Government
* Building
* Road
* Specialist

Gmake is OK: no warnings and no errors.

Add 'requirement_vector reqs';
Add 'requirement_vector nreqs':

* Nation

Gmake is OK: no warning and no error.



___

File Attachments:


---
Date: Mon 18 Jun 2012 06:41:10 PM GMT  Name:
trunk-rev21330_bcsrgb_requirement_nreqs.diff  Size: 17kB   By: gorb

http://gna.org/patch/download.php?file_id=15842
---
Date: Mon 18 Jun 2012 06:41:10 PM GMT  Name:
trunk-rev21330_nations_reqs_nreqs.diff  Size: 4kB   By: gorb

http://gna.org/patch/download.php?file_id=15843

___

Reply to this item at:

  http://gna.org/patch/?3332

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3332] Negated requirements_vector

2012-06-18 Thread J. M. Gorbach
Follow-up Comment #2, patch #3332 (project freeciv):

 Could you provide examples why you want the nreqs for each object type?

Yes, I can, but only one object type: building, see patch #1341.

Base, cities, government, road, nation and specialist are useless. I waste my
time, but see gmake without error is good.

Maybe for nation bug #18358, but I am not sure.






___

Reply to this item at:

  http://gna.org/patch/?3332

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3327] Ranian nation

2012-06-17 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3327

 Summary: Ranian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 17 Jun 2012 09:39:51 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Slavic Ranians or Rugians.

Flag based on Western Pommeranian with Ranian coat.



___

File Attachments:


---
Date: Sun 17 Jun 2012 09:39:51 AM CEST  Name: ranian.ruleset  Size: 3kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15823
---
Date: Sun 17 Jun 2012 09:39:51 AM CEST  Name: ranian.svg  Size: 48kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15824

___

Reply to this item at:

  http://gna.org/patch/?3327

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3328] Cimmerian nation

2012-06-17 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3328

 Summary: Cimmerian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 17 Jun 2012 09:43:23 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Cimmerians of Herodotus.

Flag based on an ancient figure of horse.



___

File Attachments:


---
Date: Sun 17 Jun 2012 09:43:23 AM CEST  Name: cimmerian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15825
---
Date: Sun 17 Jun 2012 09:43:23 AM CEST  Name: cimmerian.svg  Size: 16kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15826

___

Reply to this item at:

  http://gna.org/patch/?3328

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3329] Lusitanian nation

2012-06-17 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3329

 Summary: Lusitanian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 17 Jun 2012 09:47:07 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Lusitanians.

Flag with Celtic knut from Wikimedia.



___

File Attachments:


---
Date: Sun 17 Jun 2012 09:47:07 AM CEST  Name: lusitanian.ruleset  Size: 1kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15827
---
Date: Sun 17 Jun 2012 09:47:07 AM CEST  Name: lusitanian.svg  Size: 26kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15828

___

Reply to this item at:

  http://gna.org/patch/?3329

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3330] Varangian nation

2012-06-17 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3330

 Summary: Varangian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 17 Jun 2012 09:57:38 AM CEST
Category: rulesets
Priority: 1 - Later
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Varangians or Eastern Vikings of Gardariki.

Flag based on Nordic cross (dualistic meaning of this cross who also may
indicate a sword), colours of former Russian flag and Odala rune (from
Wikimedia) to added pagan character to these people.



___

File Attachments:


---
Date: Sun 17 Jun 2012 09:57:38 AM CEST  Name: varangian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15829
---
Date: Sun 17 Jun 2012 09:57:38 AM CEST  Name: gardariki.svg  Size: 4kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15830

___

Reply to this item at:

  http://gna.org/patch/?3330

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3325] Allow custom types for governments to be used in effect requirements.

2012-06-17 Thread J. M. Gorbach
Follow-up Comment #2, patch #3325 (project freeciv):

You remember me, but I've spent months with #1339.

Gmake result in SVN (rev. 21329) with your ruleset.c

ruleset.c: In function 'load_government_names':
ruleset.c:2488:24: error: 'MAX_NUM_USER_GOV_FLAGS' undeclared (first use in
this function)
ruleset.c:2488:24: note: each undeclared identifier is reported only once for
each function it appears in
ruleset.c:2494:5: warning: implicit declaration of function
'set_user_gov_flag_name' [-Wimplicit-function-declaration]
ruleset.c:2494:28: error: 'F_USER_GOV_FLAG_1' undeclared (first use in this
function)
ruleset.c: In function 'load_ruleset_governments':
ruleset.c:2590:5: warning: implicit declaration of function 'gtype_index'
[-Wimplicit-function-declaration]
ruleset.c:2592:5: error: 'struct government' has no member named 'flags'
ruleset.c:2592:5: error: 'struct government' has no member named 'flags'
ruleset.c:2593:5: warning: implicit declaration of function 'gtype_has_flag'
[-Wimplicit-function-declaration]
ruleset.c:2595:5: error: 'slist' undeclared (first use in this function)
ruleset.c:2595:43: error: 'nval' undeclared (first use in this function)
ruleset.c:2597:9: error: 'j' undeclared (first use in this function)
ruleset.c:2598:7: error: 'sval' undeclared (first use in this function)
ruleset.c:2599:16: warning: left-hand operand of comma expression has no
effect [-Wunused-value]
ruleset.c:2599:16: warning: value computed is not used [-Wunused-value]
ruleset.c:2599:16: warning: left-hand operand of comma expression has no
effect [-Wunused-value]
ruleset.c:2602:7: error: 'ival' undeclared (first use in this function)
ruleset.c:2602:7: warning: implicit declaration of function
'gov_flag_by_rule_name' [-Wimplicit-function-declaration]
ruleset.c:2604:9: warning: implicit declaration of function 'gtype_rule_name'
[-Wimplicit-function-declaration]
ruleset.c:2607:9: error: 'struct government' has no member named 'flags'
ruleset.c: In function 'send_ruleset_governments':
ruleset.c:4339:2: error: 'packet' undeclared (first use in this function)
ruleset.c:4339:18: error: 'struct government' has no member named 'flags'


___

Reply to this item at:

  http://gna.org/patch/?3325

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3315] Dacian nation

2012-06-02 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3315

 Summary: Dacian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 03 Jun 2012 12:03:01 AM CEST
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Flag with dacian Draco.



___

File Attachments:


---
Date: Sun 03 Jun 2012 12:03:01 AM CEST  Name: dacian.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15789
---
Date: Sun 03 Jun 2012 12:03:01 AM CEST  Name: dacian.svg  Size: 18kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15790

___

Reply to this item at:

  http://gna.org/patch/?3315

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3316] Celtic nation

2012-06-02 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3316

 Summary: Celtic nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 03 Jun 2012 12:06:07 AM CEST
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Flag with a Celtic spiral from Wikimedia Commons.



___

File Attachments:


---
Date: Sun 03 Jun 2012 12:06:07 AM CEST  Name: celtic.ruleset  Size: 3kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15791
---
Date: Sun 03 Jun 2012 12:06:07 AM CEST  Name: celtic.svg  Size: 12kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15792

___

Reply to this item at:

  http://gna.org/patch/?3316

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3317] Italian Greek nation

2012-06-02 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3317

 Summary: Italian Greek nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 03 Jun 2012 12:12:18 AM CEST
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Magna Graecia.

Flag with Greek coat of arms and combination of Greek and Italian colours.



___

File Attachments:


---
Date: Sun 03 Jun 2012 12:12:18 AM CEST  Name: italiangreek.ruleset  Size: 3kB 
 By: artaxes

http://gna.org/patch/download.php?file_id=15793
---
Date: Sun 03 Jun 2012 12:12:18 AM CEST  Name: italian_greek.svg  Size: 70kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15794

___

Reply to this item at:

  http://gna.org/patch/?3317

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3318] Lycian nation

2012-06-02 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3318

 Summary: Lycian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 03 Jun 2012 12:15:47 AM CEST
Category: rulesets
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Flag with great goddess symbol.



___

File Attachments:


---
Date: Sun 03 Jun 2012 12:15:47 AM CEST  Name: lycian.ruleset  Size: 1kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15795
---
Date: Sun 03 Jun 2012 12:15:47 AM CEST  Name: lycian.svg  Size: 5kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15796

___

Reply to this item at:

  http://gna.org/patch/?3318

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev



[Freeciv-Dev] [patch #3298] Carantanian nation

2012-05-15 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3298

 Summary: Carantanian nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Tue 15 May 2012 08:50:18 PM CEST
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Carantanians or Alpine Slavs.

Flag used the Carantanian Panther:
http://commons.wikimedia.org/wiki/File:Carantanian_panther.png



___

File Attachments:


---
Date: Tue 15 May 2012 08:50:19 PM CEST  Name: carantanian.ruleset  Size: 2kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15743
---
Date: Tue 15 May 2012 08:50:18 PM CEST  Name: carantanian.svg  Size: 43kB  
By: artaxes

http://gna.org/patch/download.php?file_id=15742

___

Reply to this item at:

  http://gna.org/patch/?3298

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1339] Unit type requirements

2012-05-14 Thread J. M. Gorbach
Follow-up Comment #12, patch #1339 (project freeciv):

Updated patch trunk rev.21272

Same gmake result...

(file #15739)
___

Additional Item Attachment:

File name: trunk-rev21272_requirement_vector.diff Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?1339

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2774] Phrygian nation

2012-05-10 Thread Andrzej M. Gorzym
Follow-up Comment #2, patch #2774 (project freeciv):

Added towns and civilwar nations.
In the flag was used this:
http://commons.wikimedia.org/wiki/File:Meuble_bonnet_phrygien.svg

(file #15719, file #15720)
___

Additional Item Attachment:

File name: phrygian.ruleset   Size:1 KB
File name: phrygian.svg   Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?2774

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2506] Boian nation

2012-05-10 Thread Andrzej M. Gorzym
Follow-up Comment #3, patch #2506 (project freeciv):

Flag with Celtic spiral symbol.

(file #15721)
___

Additional Item Attachment:

File name: boian.svg  Size:9 KB


___

Reply to this item at:

  http://gna.org/patch/?2506

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2428] Sabinian nation

2012-05-06 Thread Andrzej M. Gorzym
Follow-up Comment #5, patch #2428 (project freeciv):

New flag added with oak leafs (Oak was one of symbols of Mars).

(file #15684)
___

Additional Item Attachment:

File name: sabinium.svg   Size:12 KB


___

Reply to this item at:

  http://gna.org/patch/?2428

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2532] Samnite nation

2012-05-06 Thread Andrzej M. Gorzym
Follow-up Comment #4, patch #2532 (project freeciv):

Flag with outline of Samnite warrior added.

(file #15685)
___

Additional Item Attachment:

File name: samnium.svgSize:16 KB


___

Reply to this item at:

  http://gna.org/patch/?2532

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3279] Rusyn nation

2012-05-06 Thread Andrzej M. Gorzym
URL:
  http://gna.org/patch/?3279

 Summary: Rusyn nation
 Project: Freeciv
Submitted by: artaxes
Submitted on: Sun 06 May 2012 06:07:57 PM CEST
Category: rulesets
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

The Rusyns.



___

File Attachments:


---
Date: Sun 06 May 2012 06:07:57 PM CEST  Name: rusyn.svg  Size: 19kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15691
---
Date: Sun 06 May 2012 06:07:57 PM CEST  Name: rusyn.ruleset  Size: 2kB   By:
artaxes

http://gna.org/patch/download.php?file_id=15692

___

Reply to this item at:

  http://gna.org/patch/?3279

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


  1   2   3   >