[Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-08-06 Thread Madeline Book

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

Committed to S2_2 (r15100) and trunk (r15099).


--
丘の上に住んでいる村人が喜んだ。
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-08-01 Thread Madeline Book

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

> [EMAIL PROTECTED] - Fri Jul 25 16:33:19 2008]:
> 
> 2008/7/20 Madeline Book:
> > I do now recall that there was a ticket to fix
> > something to do with the auto farmland/irrigation for city
> > tiles, perhaps there was small unintended side-effect in that
> > patch.
> 
>  You mean #40207? It's still missing S2_2/TRUNK version, so it can't
> be cause of this.

Yes, you are right. It was due to a minor mistake when
the fruity terrains were removed, and is easily fixed.


---
知らない人にいきなりキスをされたら、どうする?
diff --git a/data/default/terrain.ruleset b/data/default/terrain.ruleset
index 526c52c..323bf3a 100644
--- a/data/default/terrain.ruleset
+++ b/data/default/terrain.ruleset
@@ -452,7 +452,7 @@ resources= "resource_coal", "resource_wine"
 road_trade_incr  = 0
 road_time= 4
 irrigation_result= "yes"
-irrigation_food_incr = 0
+irrigation_food_incr = 1
 irrigation_time  = 10
 mining_result= "yes"
 mining_shield_incr   = 3
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-07-25 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

2008/7/20 Madeline Book:
> I do now recall that there was a ticket to fix
> something to do with the auto farmland/irrigation for city
> tiles, perhaps there was small unintended side-effect in that
> patch.

 You mean #40207? It's still missing S2_2/TRUNK version, so it can't
be cause of this.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-07-19 Thread Madeline Book

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

> [EMAIL PROTECTED] - Sat Jul 19 19:54:51 2008]:
> 
> Probably to do with the way auto-improvements were changed
> in handling.
> 
> City squares automatically get irrigation.  Hill + irrigation = 2
> food.  Of course you can mine the hill too, then you get the
> irrigation and the mining bonus, which is a bit wrong but is the way
> it's always been.  Forests can't be irrigated and so don't get the
> bonus.
> 
> Is auto-irrigation handled correctly for cities on other terrain
> types?  It should be 2 food for plains or grassland (in despotism),
> or 3 food (despotism) for wheat.

I checked all other terrain/resource types and all governments;
the only abnormality is the 1 food for hill cities (in all
governements). I do now recall that there was a ticket to fix
something to do with the auto farmland/irrigation for city
tiles, perhaps there was small unintended side-effect in that
patch.


--
農場主は怠け者ので、坂を登りたくないです。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-07-19 Thread Jason Dorje Short

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

Probably to do with the way auto-improvements were changed in handling.

City squares automatically get irrigation.  Hill + irrigation = 2
food.  Of course you can mine the hill too, then you get the
irrigation and the mining bonus, which is a bit wrong but is the way
it's always been.  Forests can't be irrigated and so don't get the
bonus.

Is auto-irrigation handled correctly for cities on other terrain
types?  It should be 2 food for plains or grassland (in despotism), or
3 food (despotism) for wheat.

-jason


On 7/18/08, Madeline Book <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40383 >
>
> When a city is built on a hill it is supposed to get 2 food
> from the tile it is built on, but for some strange reason
> in S2_2/trunk this is now only 1 food.
>
>
> --
> 庶民は餓死寸前である。
>
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev
>



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40383) Hills are supposed to give 2 food for city tiles not 1

2008-07-19 Thread Madeline Book

http://bugs.freeciv.org/Ticket/Display.html?id=40383 >

When a city is built on a hill it is supposed to get 2 food
from the tile it is built on, but for some strange reason
in S2_2/trunk this is now only 1 food.


--
庶民は餓死寸前である。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev