[Freeciv-Dev] [bug #15373] add health effect to default/effects.ruleset

[Matthias Pfafferodt]

Follow-up Comment #2, bug #15373 (project freeciv):

My error - see patch comments; I also reduced the base propability from 25%
to 20%

the patch is only for trunk; if a fix for S2_2 (2.2.1) is needed, I will try
to reduce the number of changes to the code

== patch comments ==

update illness / health

* for testing the calculations I used floating point numbers but within the
freeciv codebase integers are used - rounding errors (no illness up to size
10); calculate the values using floats
* move the check for illness_min_size into city_illness()
* reduce illness_base_factor from 25 to 20
* add health effects:

aqueduct: 50
sewer system: 30
cure for cancer: 20

=> reduction by up to 80% (100%)

(file #8116)
___

Additional Item Attachment:

File name: 20100215-trunk-update-illness-health.patch Size:7 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [bug #15373] add health effect to default/effects.ruleset

[Yoav Luft]

When I first made this, I used some spreadsheets in order to choose
parameters, and hoped for parameters that will prevent cities of
effectively growing bigger than 8 without improvement.
I no longer have those spreadsheets, but my original ruleset is found here:
http://forum.freeciv.org/viewtopic.php?t=5721
The patch is, of course, irrelevant. Also, I don't know how much the
code had changed since my original contribution, so it might be
relevant any more.

On Mon, Feb 15, 2010 at 11:23 PM, Jacob Nevins
 wrote:
>
> Follow-up Comment #1, bug #15373 (project freeciv):
>
> I've actually been playing default rules with illness enabled for a while,
> for giggles. I'm finding it effectively just reduces the max city size with
> no Sewer System; the default increase in plague chance with size is very
> steep (size 7/8/9 = 0.0%, size 10 = 11.0%), so I never even get to size 11 (I
> don't have Sanitation yet). I think this slope dwarfs any effects from
> pollution/trade. So, the default setup seems uninteresting enough that it's
> not worth being able to switch it on; I assumed that the parameters needed
> more tuning.
>
> I've got Health_Pct effects Aqueduct = 30, Sewer System = 20, Cure for Cancer
> = 5; I can't remember where I lifted these from now, but I think the
> parameters in the [illness] section of game.ruleset are probably what needs
> tuning. I imagine it also gets more interesting if you have buildings
> specifically for this like Hospital.
>
> Perhaps syntron's "experimental" ruleset (patch #1236) has better tuned
> parameters; I haven't looked yet. (It's perhaps a shame that that isn't in
> 2.2.0 to play with.)
>
>> Also the effect code on [http://freeciv.wikia.com/wiki/Math_...] is wrong,
> the name of the effect is "Health_Pct" and not "Health".
>
> Fixed.
>
>    ___
>
> Reply to this item at:
>
>  
>
> ___
>  Message sent via/by Gna!
>  http://gna.org/
>
>
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev
>

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] add health effect to default/effects.ruleset

[Jacob Nevins]

Follow-up Comment #1, bug #15373 (project freeciv):

I've actually been playing default rules with illness enabled for a while,
for giggles. I'm finding it effectively just reduces the max city size with
no Sewer System; the default increase in plague chance with size is very
steep (size 7/8/9 = 0.0%, size 10 = 11.0%), so I never even get to size 11 (I
don't have Sanitation yet). I think this slope dwarfs any effects from
pollution/trade. So, the default setup seems uninteresting enough that it's
not worth being able to switch it on; I assumed that the parameters needed
more tuning.

I've got Health_Pct effects Aqueduct = 30, Sewer System = 20, Cure for Cancer
= 5; I can't remember where I lifted these from now, but I think the
parameters in the [illness] section of game.ruleset are probably what needs
tuning. I imagine it also gets more interesting if you have buildings
specifically for this like Hospital.

Perhaps syntron's "experimental" ruleset (patch #1236) has better tuned
parameters; I haven't looked yet. (It's perhaps a shame that that isn't in
2.2.0 to play with.)

> Also the effect code on [http://freeciv.wikia.com/wiki/Math_...] is wrong,
the name of the effect is "Health_Pct" and not "Health".

Fixed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] add health effect to default/effects.ruleset

[Andreas]

URL:
  

 Summary: add health effect to default/effects.ruleset
 Project: Freeciv
Submitted by: anbe
Submitted on: Monday 02/15/2010 at 14:53
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0-beta3
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Hi,

is there a reason that default/effects.ruleset does not contain
effect_aqueduct_health and effect_sewer_system_health?

Even if illness is not enabled by default, all related settings should be
there so you get a working illness system by just toggling the switch. And
without illness being enabled, the health settings just should do nothing.

Also the effect code on [[http://freeciv.wikia.com/wiki/Math_of_Freeciv]] is
wrong, the name of the effect is "Health_Pct" and not "Health".


Andreas




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev