[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-02 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

jcholast commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/1e6a204b4372bbbfb722a00370a5ce4e34406b9f
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-264397268
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

pvoborni commented:
"""
Lets push this code if it is correct but only misses usecases mentioned above". 
Honza will implement the missing usecases in separate PR.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-264202590
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

tiran commented:
"""
@pvoborni No, my answer is an disagreement. Honza does not want the approve the 
PR as it stands now.

My proposal is

* Review this PR under the premise that it does not break current code when 
```IPA_CONFDIR``` is absent.
* Review the disputable code lines after my deadline and within the next two 
weeks. Some of them might need an explicit confdir, some might not. I need to 
carefully think about each call.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-264172504
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To 
rest later by Honza?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-264159913
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

pvoborni commented:
"""
Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To 
rest later by Honza?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-264159913
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-30 Thread pvoborni
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

pvoborni commented:
"""
If I understand Christian right, it is not disagreement about something which 
needs to be done. But rather a proposal to address rest of the scripts later in 
other pull request. So that we can push this PR to unblock subsequent reviews.

Is it correct? If so can be proceed with checking if current code is OK and 
finished rest in other PR?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263891701
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-30 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

tiran commented:
"""
- [X] 
```daemons/dnssec/ipa-dnskeysync-replica:124:ipalib.api.bootstrap(in_server=True,
 log=None)  # no logging to file```
- [X] ```daemons/dnssec/ipa-dnskeysyncd:23:api.bootstrap(in_server=True, 
log=None)  # no logging to file```
- [X] 
```daemons/dnssec/ipa-ods-exporter:618:ipalib.api.bootstrap(in_server=True, 
log=None)  # no logging to file```
- [ ] ```doc/guide/wsgi.py.txt:9:env._bootstrap(context='server', log=None)```
- [ ] ```doc/guide/wsgi.py.txt:13:api.bootstrap(context='server', 
debug=env.debug, log=None) (ref:wsgi-app-bootstrap)```
- [X] ```install/restart_scripts/renew_ra_cert:39:
api.bootstrap(in_server=True, context='restart')```
- [X] ```install/tools/ipa-adtrust-install:269:api.bootstrap(**cfg)```
- [X] ```install/tools/ipa-ca-install:262:api.bootstrap(in_server=True, 
ra_plugin='dogtag')```
- [ ] ```install/tools/ipa-compat-manage:105:api.bootstrap(context='cli', 
in_server=True, debug=options.debug)```
- [ ] ```install/tools/ipa-csreplica-manage:418:api.bootstrap(**api_env)```
- [X] ```install/tools/ipa-dns-install:139:api.bootstrap(**cfg)```
- [ ] ```install/tools/ipa-managed-entries:75:api.bootstrap(context='cli', 
debug=options.debug)```
- [X] ```install/tools/ipa-nis-manage:118:api.bootstrap(context='cli', 
debug=options.debug, in_server=True)```
- [X] ```install/tools/ipa-replica-manage:1512:api.bootstrap(**api_env)```
- [ ] ```ipaserver/dnssec/ldapkeydb.py:417:
ipalib.api.bootstrap(in_server=True, log=None)  # no logging to file```
- [ ] ```ipaserver/advise/base.py:238:api.bootstrap(in_server=False, 
context='cli')```
- [ ] ```ipaserver/advise/base.py:240:
advise_api.bootstrap(in_server=False, context='cli')```
- [ ] ```ipaserver/install/ipa_cacert_manage.py:99:
api.bootstrap(in_server=True)```
- [ ] ```ipaserver/install/ipa_kra_install.py:80:
api.bootstrap(in_server=True)```
- [ ] ```ipaserver/install/ipa_otptoken_import.py:512:
api.bootstrap(in_server=True)```
- [ ] ```ipaserver/install/ipa_replica_prepare.py:183:
api.bootstrap(in_server=True)```
- [ ] ```ipaserver/install/ipa_server_certinstall.py:102:
api.bootstrap(in_server=True)```
- [ ] ```ipatests/test_ipaserver/test_ldap.py:114:
myapi.bootstrap(context='cli', in_server=True)```
- [ ] ```ipatests/test_ipaserver/test_serverroles.py:472:
test_api.bootstrap(in_server=True, ldap_uri=api.env.ldap_uri)```
- [ ] ```lite-server.py:130:(options, args) = 
api.bootstrap_with_global_options(parser, context='lite')```

"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263861585
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

tiran commented:
"""
All bootstrap() calls without an explicit confdir argument are fine. If you 
think otherwise, please list all calls and give me a compelling reason to have 
them ignore IPA_CONFDIR.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263580703
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

jcholast commented:
"""
Please explain, all of the affected scripts are server-only and thus not 
related to the integration effort and most probably won't work correctly with 
non-server configuration anyway.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263540749
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

tiran commented:
"""
I fixed a few. Some scripts deliberately do not have the confdir flag in 
bootstrap.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263532412
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-29 Thread jcholast
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

jcholast commented:
"""
You missed a few:
```
daemons/dnssec/ipa-dnskeysync-replica:124:ipalib.api.bootstrap(in_server=True, 
log=None)  # no logging to file
daemons/dnssec/ipa-dnskeysyncd:23:api.bootstrap(in_server=True, log=None)  # no 
logging to file
daemons/dnssec/ipa-ods-exporter:618:ipalib.api.bootstrap(in_server=True, 
log=None)  # no logging to file
doc/guide/wsgi.py.txt:9:env._bootstrap(context='server', log=None)
doc/guide/wsgi.py.txt:13:api.bootstrap(context='server', debug=env.debug, 
log=None) (ref:wsgi-app-bootstrap)
install/restart_scripts/renew_ra_cert:39:api.bootstrap(in_server=True, 
context='restart')
install/tools/ipa-adtrust-install:269:api.bootstrap(**cfg)
install/tools/ipa-ca-install:262:api.bootstrap(in_server=True, 
ra_plugin='dogtag')
install/tools/ipa-compat-manage:105:api.bootstrap(context='cli', 
in_server=True, debug=options.debug)
install/tools/ipa-csreplica-manage:418:api.bootstrap(**api_env)
install/tools/ipa-dns-install:139:api.bootstrap(**cfg)
install/tools/ipa-managed-entries:75:api.bootstrap(context='cli', 
debug=options.debug)
install/tools/ipa-nis-manage:118:api.bootstrap(context='cli', 
debug=options.debug, in_server=True)
install/tools/ipa-replica-manage:1512:api.bootstrap(**api_env)
ipapython/dnssec/ldapkeydb.py:417:ipalib.api.bootstrap(in_server=True, 
log=None)  # no logging to file
ipaserver/advise/base.py:238:api.bootstrap(in_server=False, 
context='cli')
ipaserver/advise/base.py:240:advise_api.bootstrap(in_server=False, 
context='cli')
ipaserver/install/ipa_cacert_manage.py:99:api.bootstrap(in_server=True)
ipaserver/install/ipa_kra_install.py:80:api.bootstrap(in_server=True)
ipaserver/install/ipa_otptoken_import.py:512:
api.bootstrap(in_server=True)
ipaserver/install/ipa_replica_prepare.py:183:
api.bootstrap(in_server=True)
ipaserver/install/ipa_server_certinstall.py:102:
api.bootstrap(in_server=True)
ipatests/test_ipaserver/test_ldap.py:114:myapi.bootstrap(context='cli', 
in_server=True)
ipatests/test_ipaserver/test_serverroles.py:472:
test_api.bootstrap(in_server=True, ldap_uri=api.env.ldap_uri)
lite-server.py:130:(options, args) = 
api.bootstrap_with_global_options(parser, context='lite')
```
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263513330
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-11-28 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/280
Title: #280: Set explicit confdir option for global contexts

tiran commented:
"""
For #182 
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/280#issuecomment-263301120
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code