Re: Clarification request for ipa/cgraph code

2007-05-10 Thread Paolo Bonzini 

Mike Stump wrote:

In ipa-type-escape.c we have:

  /* Return either TYPE if this is first time TYPE has been seen an
 compatible TYPE that has already been processed.  */

I'd fix it, if I knew I knew what it meant.  either, an and that are
the things that are confusing to me.


Return TYPE if no type compatible with TYPE has been seen so far, 
otherwise return a type compatible with TYPE that has already been 
processed.


Or,

Find a type compatible with TYPE among those that have been processed, 
and return it.  If none can be found, register and return TYPE.


(It took me two/three iterations to read your message too.  You want to 
quote either, an and that probably...).


Paolo

Re: Clarification request for ipa/cgraph code

2007-05-09 Thread Steven Bosscher 

On 5/9/07, Mike Stump [EMAIL PROTECTED] wrote:

In ipa-type-escape.c we have:

  /* Return either TYPE if this is first time TYPE has been seen an
 compatible TYPE that has already been processed.  */

I'd fix it, if I knew I knew what it meant.  either, an and that are
the things that are confusing to me.


Your message is itself also a bit confusing. Fix what? What did you
mean in the an and sentence?

Gr.
Steven

Re: Clarification request for ipa/cgraph code

2007-05-09 Thread Mike Stump 

On May 9, 2007, at 2:33 PM, Steven Bosscher wrote:

On 5/9/07, Mike Stump [EMAIL PROTECTED] wrote:

In ipa-type-escape.c we have:

 /* Return either TYPE if this is first time TYPE has been seen an
compatible TYPE that has already been processed.  */

I'd fix it, if I knew I knew what it meant.  either, an and that are
the things that are confusing to me.


Your message is itself also a bit confusing.


You find the sentence well written and understandable?  That utterance  
isn't part of the standard language gcc is written in.  Maybe a short  
video will help you understand at least one aspect that is wrong:


  http://tinyurl.com/2zgrch

:-)  Another thing that appears wrong is:

  compatible TYPE

it should be:

  compatible type

as near as I can tell.

   a type compatible with TYPE

might be yet another way to express it.

Re: Clarification request for ipa/cgraph code

2007-05-09 Thread Brooks Moses 

Steven Bosscher wrote:

On 5/9/07, Mike Stump [EMAIL PROTECTED] wrote:

In ipa-type-escape.c we have:

  /* Return either TYPE if this is first time TYPE has been seen an
 compatible TYPE that has already been processed.  */

I'd fix it, if I knew I knew what it meant.  either, an and that are
the things that are confusing to me.


Your message is itself also a bit confusing. Fix what? What did you
mean in the an and sentence?


Fix the incomprehensible pre-existing comment he quoted by converting it 
to a comprehensible one, I suppose.  The words either, an, and 
that in the comment in question are things he finds particularly 
confusing about the sentence.


- Brooks