Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-17 Thread Alexandru Dutu 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9103
---

Ship it!


Ship It!

- Alexandru Dutu


On Nov. 16, 2016, 4:44 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 16, 2016, 4:44 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11730:9ee83d124c9c
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/
---

(Updated Nov. 16, 2016, 4:44 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11730:9ee83d124c9c
---
syscall_emul: [PATCH 21/22] rewrite code related to system call exits

The changeset refactors exit, exit_group, and futex related exit
functionality.


Diffs (updated)
-

  src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/futex_map.hh PRE-CREATION 
  src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3702/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-15 Thread Michael LeBeane 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9079
---

Ship it!


Ship It!

- Michael LeBeane


On Nov. 14, 2016, 9:30 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 14, 2016, 9:30 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11728:9ca77be78b02
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Michael LeBeane 


> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote:
> > src/sim/futex_map.hh, line 81
> > 
> >
> > Why not something simple, like:
> > 
> > return std::hash(addr) ^ (std::hash(tgid) << 1)
> 
> Brandon Potter wrote:
> The return value has to be size_t which from the C standard will at least 
> have a max value of 65536 
> (http://stackoverflow.com/questions/918787/whats-sizeofsize-t-on-32-bit-vs-the-various-64-bit-data-models).
>  The key values are uint64_t. Since the value is cap starts at 65536, I 
> wanted to make sure that the entire number was being fed into the hash. 
> That's why I work through with the for loop that breaks uint64_t apart based 
> on sizeof(size_t).
> 
> I chose the largest prime number less than the max to start as the hash 
> value. It could've been anything though; the choice was arbitrary.
> 
> So, is this OK? This functor is really just a dumb widget to satisfy 
> std::hash. I don't expect the futex_map to grow to be so large that the hash 
> value matters much.

Yeah, I don't think the hash matters to much, which is why I prefer something 
simple.  Don't care too much though, do what you prefer.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9052
---


On Nov. 14, 2016, 9:30 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 14, 2016, 9:30 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11728:9ca77be78b02
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/
---

(Updated Nov. 14, 2016, 9:30 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11728:9ca77be78b02
---
syscall_emul: [PATCH 21/22] rewrite code related to system call exits

The changeset refactors exit, exit_group, and futex related exit
functionality.


Diffs (updated)
-

  src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/se_signal.hh PRE-CREATION 
  src/sim/futex_map.hh PRE-CREATION 
  src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/se_signal.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3702/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter 


> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote:
> > src/sim/futex_map.hh, line 81
> > 
> >
> > Why not something simple, like:
> > 
> > return std::hash(addr) ^ (std::hash(tgid) << 1)

The return value has to be size_t which from the C standard will at least have 
a max value of 65536 
(http://stackoverflow.com/questions/918787/whats-sizeofsize-t-on-32-bit-vs-the-various-64-bit-data-models).
 The key values are uint64_t. Since the value is cap starts at 65536, I wanted 
to make sure that the entire number was being fed into the hash. That's why I 
work through with the for loop that breaks uint64_t apart based on 
sizeof(size_t).

I chose the largest prime number less than the max to start as the hash value. 
It could've been anything though; the choice was arbitrary.

So, is this OK? This functor is really just a dumb widget to satisfy std::hash. 
I don't expect the futex_map to grow to be so large that the hash value matters 
much.


> On Nov. 14, 2016, 7:19 p.m., Michael LeBeane wrote:
> > src/sim/system.hh, line 74
> > 
> >
> > spurious whitespace change

The include style checker does this on it's own. I can't qref the patch without 
this being done (or hacking on it a bit).


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9052
---


On Nov. 14, 2016, 9:30 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 14, 2016, 9:30 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11728:9ca77be78b02
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/se_signal.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Michael LeBeane 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9052
---



src/sim/futex_map.hh (line 65)


I'm not sure if this is needed.



src/sim/futex_map.hh (line 81)


Why not something simple, like:

return std::hash(addr) ^ (std::hash(tgid) << 1)



src/sim/system.hh (line 73)


spurious whitespace change


- Michael LeBeane


On Nov. 14, 2016, 6:49 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 14, 2016, 6:49 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11728:be8e9fbd0bec
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/se_signal.cc PRE-CREATION 
>   src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-14 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/
---

(Updated Nov. 14, 2016, 6:49 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11728:be8e9fbd0bec
---
syscall_emul: [PATCH 21/22] rewrite code related to system call exits

The changeset refactors exit, exit_group, and futex related exit
functionality.


Diffs (updated)
-

  src/sim/se_signal.hh PRE-CREATION 
  src/sim/se_signal.cc PRE-CREATION 
  src/sim/syscall_emul.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/syscall_emul.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 
  src/sim/futex_map.hh PRE-CREATION 
  src/sim/process.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 

Diff: http://reviews.gem5.org/r/3702/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-10 Thread Tony Gutierrez 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/#review9036
---



src/sim/futex_map.hh (line 5)


This is not the license we should be using. See the gpu-compute code for 
our license.



src/sim/futex_map.hh (line 66)


This comment needs more detail.



src/sim/futex_map.hh (line 91)


Newline after the return type.



src/sim/se_signal.cc (line 2)


Should this not be 2014, 2016?


- Tony Gutierrez


On Nov. 7, 2016, 2:20 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3702/
> ---
> 
> (Updated Nov. 7, 2016, 2:20 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11710:0f51ecfa24aa
> ---
> syscall_emul: [PATCH 21/22] rewrite code related to system call exits
> 
> The changeset refactors exit, exit_group, and futex related exit
> functionality.
> 
> 
> Diffs
> -
> 
>   src/sim/futex_map.hh PRE-CREATION 
>   src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/se_signal.hh PRE-CREATION 
>   src/sim/se_signal.cc PRE-CREATION 
>   src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
>   src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
> 
> Diff: http://reviews.gem5.org/r/3702/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

2016-11-07 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3702/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11710:0f51ecfa24aa
---
syscall_emul: [PATCH 21/22] rewrite code related to system call exits

The changeset refactors exit, exit_group, and futex related exit
functionality.


Diffs
-

  src/sim/futex_map.hh PRE-CREATION 
  src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/se_signal.hh PRE-CREATION 
  src/sim/se_signal.cc PRE-CREATION 
  src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 
  src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 

Diff: http://reviews.gem5.org/r/3702/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev