Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-11 Thread Steve Reinhardt 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review722
---

Ship it!


- Steve


On 2011-01-11 09:27:55, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-11 09:27:55)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> mem: Added support for Null data packet
> 
> The packet now identifies whether static or dynamic data has been allocated 
> and
> is used by Ruby to determine whehter to copy the data pointer into the ruby
> request.  Ruby does not currently support array data.
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
>   src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
>   src/mem/ruby/system/RubyPort.cc 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-11 Thread Brad Beckmann 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/
---

(Updated 2011-01-11 09:27:55.596573)


Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

mem: Added support for Null data packet

The packet now identifies whether static or dynamic data has been allocated and
is used by Ruby to determine whehter to copy the data pointer into the ruby
request.  Ruby does not currently support array data.


Diffs (updated)
-

  src/mem/packet.hh 9f9e10967912 
  src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
  src/mem/ruby/system/RubyPort.cc 9f9e10967912 

Diff: http://reviews.m5sim.org/r/399/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Gabe Black 


> On 2011-01-10 13:54:18, Gabe Black wrote:
> > src/mem/packet.hh, line 775
> > 
> >
> > You need spaces around |.
> 
> Brad Beckmann wrote:
> I can add a space around |, but hat is inconsistent with the rest of the 
> file.

Ah, yeah, I see that now. I don't think that's correct style generally 
speaking, but you're probably right to stay consistent with the rest of the 
file.


- Gabe


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review708
---


On 2011-01-10 15:59:13, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-10 15:59:13)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> mem: Added support for Null data packet
> 
> The packet now identifies whether static or dynamic data has been allocated 
> and
> is used by Ruby to determine whehter to copy the data pointer into the ruby
> request.  Ruby does not currently support array data.
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
>   src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
>   src/mem/ruby/system/RubyPort.cc 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Lisa Hsu 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review715
---

Ship it!


Obviates the need for a different patch I had in my own queue, and more 
general.  Thanks Brad.

- Lisa


On 2011-01-10 15:59:13, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-10 15:59:13)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> mem: Added support for Null data packet
> 
> The packet now identifies whether static or dynamic data has been allocated 
> and
> is used by Ruby to determine whehter to copy the data pointer into the ruby
> request.  Ruby does not currently support array data.
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
>   src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
>   src/mem/ruby/system/RubyPort.cc 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Steve Reinhardt 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review714
---



src/mem/ruby/system/RubyPort.cc


I suggest changing Packet::getPtr() to take an optional flag like this:
 getPtr(bool null_ok = false)
 {
   assert(null_ok ||
 flags.isSet(STATIC_DATA|DYNAMIC_DATA));
   return (T*)data;
 }
(assuming that data really is null when those flags are clear), then 
changing this section to just call getPtr(true) (you might not even 
need the ruby_data temp anymore, I'm not sure), and you won't even need the 
method that you can't find a good name for :-)



- Steve


On 2011-01-10 15:59:13, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-10 15:59:13)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> mem: Added support for Null data packet
> 
> The packet now identifies whether static or dynamic data has been allocated 
> and
> is used by Ruby to determine whehter to copy the data pointer into the ruby
> request.  Ruby does not currently support array data.
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
>   src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
>   src/mem/ruby/system/RubyPort.cc 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Brad Beckmann 


> On 2011-01-10 13:54:18, Gabe Black wrote:
> > src/mem/packet.hh, line 775
> > 
> >
> > You need spaces around |.

I can add a space around |, but hat is inconsistent with the rest of the file.  


- Brad


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review708
---


On 2011-01-10 15:59:13, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-10 15:59:13)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> mem: Added support for Null data packet
> 
> The packet now identifies whether static or dynamic data has been allocated 
> and
> is used by Ruby to determine whehter to copy the data pointer into the ruby
> request.  Ruby does not currently support array data.
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
>   src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
>   src/mem/ruby/system/RubyPort.cc 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Brad Beckmann 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/
---

(Updated 2011-01-10 15:59:13.160265)


Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary (updated)
---

mem: Added support for Null data packet

The packet now identifies whether static or dynamic data has been allocated and
is used by Ruby to determine whehter to copy the data pointer into the ruby
request.  Ruby does not currently support array data.


Diffs (updated)
-

  src/mem/packet.hh 9f9e10967912 
  src/mem/ruby/system/DMASequencer.cc 9f9e10967912 
  src/mem/ruby/system/RubyPort.cc 9f9e10967912 

Diff: http://reviews.m5sim.org/r/399/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev