Re: [m5-dev] Review Request: packet: Added public method to identify valid data

[Ali Saidi]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review684
---


I'm not sure this change does what you think it does. those flags only mean 
that the packet has data storage allocated, it doesn't say anything about the 
validity of that data. I can't think of a good reason why someone external 
would need to know that the packet has data allocated. If that is what you're 
going for, then it should have a name that makes it clear that this just means 
storage, nothing about the protocol and a good doxygen comment.

- Ali


On 2011-01-06 16:13:49, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-06 16:13:49)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> packet: Added public method to identify valid data
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: packet: Added public method to identify valid data

[Gabe Black]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/#review653
---



src/mem/packet.hh


Review board seems to be flagging some whitespace you have at the end of 
this line. The idea of this function seems fine but its name is a little 
awkward. How about hasData()?


- Gabe


On 2011-01-06 16:13:49, Brad Beckmann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/399/
> ---
> 
> (Updated 2011-01-06 16:13:49)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> packet: Added public method to identify valid data
> 
> 
> Diffs
> -
> 
>   src/mem/packet.hh 9f9e10967912 
> 
> Diff: http://reviews.m5sim.org/r/399/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Review Request: packet: Added public method to identify valid data

[Brad Beckmann]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/399/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

packet: Added public method to identify valid data


Diffs
-

  src/mem/packet.hh 9f9e10967912 

Diff: http://reviews.m5sim.org/r/399/diff


Testing
---


Thanks,

Brad

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev